Timeline

Jan 1, 2018:

8:27 PM Changeset in webkit [226320] by Michael Catanzaro

• 10 edits
  10 copies in trunk

Rolled over to ChangeLog-2018-01-01

8:18 PM Changeset in webkit [226319] by Michael Catanzaro

• 2 edits in trunk/LayoutTests

Unreviewed, add some more GTK crash expectations

• platform/gtk/TestExpectations:

3:42 PM Changeset in webkit [226318] by jeffm@apple.com

• 16 edits in trunk

Source/JavaScriptCore:
Update user-visible copyright strings to include 2018
​https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

• Info.plist:

Source/WebCore:
Update user-visible copyright strings to include 2018
​https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

• Info.plist:

Source/WebKit:
[Attachment Support] Remove current macOS support for dragging file-backed attachments
​https://bugs.webkit.org/show_bug.cgi?id=181188

Patch by Wenson Hsieh <Wenson Hsieh> on 2017-12-30
Reviewed by Dan Bernstein.

See WebCore/ChangeLog for more detail.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::setPromisedDataForAttachment): Deleted.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setPromisedDataForAttachment): Deleted.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setPromisedDataForAttachment): Deleted.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedDataForAttachment): Deleted.

• WebProcess/WebCoreSupport/WebDragClient.h:
• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteAttachment): Deleted.

Source/WebKitLegacy/mac:
Update user-visible copyright strings to include 2018
​https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

• Info.plist:

WebKitLibraries:
Update user-visible copyright strings to include 2018
​https://bugs.webkit.org/show_bug.cgi?id=181141

Reviewed by Dan Bernstein.

• win/tools/scripts/COPYRIGHT-END-YEAR:

12:32 PM Changeset in webkit [226317] by Simon Fraser

• 7 edits
  2 adds in trunk

REGRESSION (r225122): fePointLights don't work
​https://bugs.webkit.org/show_bug.cgi?id=181142

Reviewed by Dan Bates.

Source/WebCore:

r225122 refactored the initialLightingData code, but failed to set the lighting
color in the return value of PointLightSource::computePixelLightingData, so fePointLights
always used black.

Also fix a spelling error in initialLightingData.

Tests: svg/filters/fePointLight-color.svg

• platform/graphics/filters/DistantLightSource.cpp:

(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::computePixelLightingData const):

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):

• platform/graphics/filters/LightSource.h:
• platform/graphics/filters/PointLightSource.cpp:

(WebCore::PointLightSource::computePixelLightingData const):

• platform/graphics/filters/SpotLightSource.cpp:

(WebCore::SpotLightSource::computePixelLightingData const):

LayoutTests:

Ref test that compares a point light with a flood color.

• svg/filters/fePointLight-color-expected.svg: Added.
• svg/filters/fePointLight-color.svg: Added.

12:28 PM Changeset in webkit [226316] by Simon Fraser

• 5 edits
  3 adds in trunk

Bottom right pixel of feDiffuseLighting has the wrong color
​https://bugs.webkit.org/show_bug.cgi?id=181203

Reviewed by Antti Koivisto.

Source/WebCore:

The lower right pixel of a feDiffuseLighting was the wrong color, because the kernel
values didn't match the spec for the bottom right Y values.

Test: svg/filters/feDiffuseLighting-bottomRightPixel.html

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::bottomRightNormal const):

LayoutTests:

Test that draws an SVG image into a canvas, and scales it up without interpolation.

• svg/filters/feDiffuseLighting-bottomRightPixel-expected.html: Added.
• svg/filters/feDiffuseLighting-bottomRightPixel.html: Added.
• svg/filters/resources/feDiffuseLighting-rect.svg: Added.

11:53 AM Changeset in webkit [226315] by Simon Fraser

• 6 edits
  2 adds in trunk

SVG lighting colors need to be converted into linearSRGB
​https://bugs.webkit.org/show_bug.cgi?id=181196

Reviewed by Dan Bates.

Source/WebCore:

SVG filters, like feLighting, that poke values directly into buffers rather than going
through CG like feFlood, need to convert colors into the operating color space. So add
conversion functions to go between linear and sRGB colors, and use these in feLighting,
and in ImageBuffer (which is only used for non-CG platforms).

Tests: svg/filters/feSpotLight-color.svg

• platform/graphics/ColorUtilities.cpp:

(WebCore::linearToSRGBColorComponent):
(WebCore::sRGBToLinearColorComponent):
(WebCore::linearToSRGBColor):
(WebCore::sRGBToLinearColor):

• platform/graphics/ColorUtilities.h:
• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):

LayoutTests:

Compare a far-away green spotlight with a green flood. The bottom right pixel always
has the wrong color (webkit.org/b/181203), so mask it out.

• svg/filters/feSpotLight-color-expected.svg: Added.
• svg/filters/feSpotLight-color.svg: Added.

Dec 31, 2017:

1:25 AM Changeset in webkit [226314] by jiewen_tan@apple.com

• 3 edits in trunk/Source/WebCore

[WebCrypto] Avoid promises being destroyed in secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=180499
<rdar://problem/35890680>

Reviewed by Youenn Fablet.

This patch adds pending promise queue to SubtleCrypto such that it no longer
passes promises around different threads, which could cause crashes when
promises are destroyed in secondary threads.

Covered by existing tests.

• crypto/SubtleCrypto.cpp:

(WebCore::getPromise):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::digest):
(WebCore::SubtleCrypto::generateKey):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

• crypto/SubtleCrypto.h: