⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2018:

11:26 PM Changeset in webkit [226766] by aestes@apple.com
  • 16 edits
    3 moves
    2 adds
    2 deletes in trunk

[Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidationEvent
​https://bugs.webkit.org/show_bug.cgi?id=181437
<rdar://problem/36376481>

Reviewed by Tim Horton.
Source/WebCore:

Renamed ApplePayMerchantValidationEvent to MerchantValidationEvent and changed complete() to accept a Promise.

Test: http/tests/paymentrequest/payment-request-merchant-validation.https.html

  • DerivedSources.make:
  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::merchantValidationCompleted):
(WebCore::ApplePayPaymentHandler::validateMerchant):

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
  • Modules/paymentrequest/MerchantValidationEvent.cpp: Renamed from Source/WebCore/Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.cpp.

(WebCore::MerchantValidationEvent::create):
(WebCore::MerchantValidationEvent::MerchantValidationEvent):
(WebCore::MerchantValidationEvent::eventInterface const):
(WebCore::MerchantValidationEvent::complete):

  • Modules/paymentrequest/MerchantValidationEvent.h: Renamed from Source/WebCore/Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.h.
  • Modules/paymentrequest/MerchantValidationEvent.idl: Renamed from Source/WebCore/Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.idl.
  • Modules/paymentrequest/PaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::completeMerchantValidation):

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventNames.in:

LayoutTests:

  • http/tests/paymentrequest/payment-request-change-shipping-address.https.html:
  • http/tests/paymentrequest/payment-request-change-shipping-option.https.html:
  • http/tests/paymentrequest/payment-request-merchant-validation.https-expected.txt: Added.
  • http/tests/paymentrequest/payment-request-merchant-validation.https.html: Added.
  • http/tests/paymentrequest/resources/helpers.js:

(async.getPaymentRequestResponse):

  • http/tests/paymentrequest/updateWith-method-pmi-handling.https.html:
  • http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https-expected.txt: Removed.
  • http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https.html: Removed.
11:07 PM Changeset in webkit [226765] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

REGRESSION(r218975): Web Inspector: Add back NavigationSidebarPanel initialization parameter used by SearchSidebarPanel (top overflow shadow)
​https://bugs.webkit.org/show_bug.cgi?id=181518
<rdar://problem/36427197>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-10
Reviewed by Matt Baker.

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .overflow-shadow.top):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel):
Add back the initialization parameter still used by SearchSidebarPanel
and add back its implementation. There were still references to
dynamically update _topOverflowShadowElement in NavigationSidebarPanel.

11:05 PM Changeset in webkit [226764] by Carlos Garcia Campos
  • 4 edits in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

  • imported/w3c/importer.json:
  • imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py:
  • imported/w3c/webdriver/tests/sessions/new_session/support/create.py:
11:05 PM Changeset in webkit [226763] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Incorrect check with WI.debuggableType
​https://bugs.webkit.org/show_bug.cgi?id=181515
<rdar://problem/36425509>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-10
Reviewed by Brian Burg.

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
This moved to WI.sharedApp a while ago.

10:34 PM Changeset in webkit [226762] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit

-[WKWebView _web_gestureEventWasNotHandledByWebCore:] should call -_gestureEventWasNotHandledByWebCore:
​https://bugs.webkit.org/show_bug.cgi?id=181498

Reviewed by Alex Christensen.

WKView's API contract allows clients to override -_gestureEventWasNotHandledByWebCore:, and -[WKView
_web_gestureEventWasNotHandledByWebCore:] calls -_gestureEventWasNotHandledByWebCore: instead of
invoking WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly() directly. WKWebView should do
the same thing.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _web_gestureEventWasNotHandledByWebCore:]):
Call -_gestureEventWasNotHandledByWebCore:, which will call gestureEventWasNotHandledByWebCoreFromViewOnly().

10:13 PM Changeset in webkit [226761] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

[GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
​https://bugs.webkit.org/show_bug.cgi?id=181475

Reviewed by Michael Catanzaro.

  • gtk/install-dependencies: Update package list for Arch Linux, extend

message shown at end of installation with additional tips.

9:15 PM Changeset in webkit [226760] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for http/tests/misc/submit-post-keygen.html.
​https://bugs.webkit.org/show_bug.cgi?id=121331

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:06 PM Changeset in webkit [226759] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark swipe/pushstate-with-manual-scrollrestoration.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=181502

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:57 PM Changeset in webkit [226758] by pvollan@apple.com
  • 2 edits in trunk

[Win] WebKitLegacy should be a dll, not a static library.
​https://bugs.webkit.org/show_bug.cgi?id=181500

Reviewed by Alex Christensen.

Set WebKitLegacy library type to shared.

  • Source/cmake/OptionsWin.cmake:
8:16 PM Changeset in webkit [226757] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark accessibility/mac/aria-multiple-liveregions-notification.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181494

Unreviewed test gardening.

  • platform/mac/TestExpectations:
8:06 PM Changeset in webkit [226756] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/misc/slow-loading-animated-image.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181479

Unreviewed test gardening.

  • platform/mac/TestExpectations:
7:36 PM Changeset in webkit [226755] by Matt Baker
  • 4 edits
    2 adds in trunk

Web Inspector: Canvas tab: throttle recording slider updates
​https://bugs.webkit.org/show_bug.cgi?id=180839
<rdar://problem/36057849>

Reviewed by Joseph Pecoraro

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

Add Object.throttle and Function.cancelThrottle. Repeated calls to a
function on a throttled object are delayed, so that the function isn't
invoked more frequently than the specified delay value.

For a description of throttling behavior see:

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype.updateActionIndex):
Throttle frequency of canvas snapshot creation to 200ms.
(WI.RecordingContentView.prototype.hidden):
Prevent trailing edge call after hiding the view.

LayoutTests:

  • inspector/unit-tests/throttle-expected.txt: Added.
  • inspector/unit-tests/throttle.html: Added.

Added function throttling tests.

7:30 PM Changeset in webkit [226754] by don.olmstead@sony.com
  • 6 edits in trunk/Source/WebCore

[Curl] Cross-protocol, cross-site scripting (XPXSS) using HTML forms
Nhttps://bugs.webkit.org/show_bug.cgi?id=153088

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-10
Reviewed by Alex Christensen.

No new tests because it's covered by existing tests.

  • platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::getHttpVersion):

  • platform/network/curl/CurlContext.h:
  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::didReceiveHeader):

  • platform/network/curl/CurlResponse.h:

(WebCore::CurlResponse::isolatedCopy const):

  • platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::setStatusLine):

7:05 PM Changeset in webkit [226753] by Wenson Hsieh
  • 14 edits
    2 adds in trunk

REGRESSION(r222507): Composition highlight doesn't render when using IME
​https://bugs.webkit.org/show_bug.cgi?id=181485
<rdar://problem/35896516>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes the order of arguments passed to paintTextSubrangeBackground from paintCompositionBackground.

Test: editing/marked-text-appearance.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground):

Source/WebKit:

Add plumbing for a suppressUnderline argument when setting marked text.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetComposition):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting):

  • WebProcess/WebPage/WebPage.h:

Tools:

Add a suppressUnderline argument to TextInputController.setMarkedText. This suppresses the custom underlines
rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
allow rendering composition backgrounds (see InlineTextBox::paint).

  • DumpRenderTree/ios/TextInputControllerIOS.m:

(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
(-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.

  • DumpRenderTree/mac/TextInputControllerMac.m:

(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
(-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.

  • WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
  • WebKitTestRunner/InjectedBundle/TextInputController.cpp:

(WTR::TextInputController::setMarkedText):

  • WebKitTestRunner/InjectedBundle/TextInputController.h:

LayoutTests:

Add a new layout test to ensure that in the absence of custom composition underlines, a marked composition
string appears different once it is confirmed.

  • editing/marked-text-appearance-expected-mismatch.html: Added.
  • editing/marked-text-appearance.html: Added.
7:03 PM Changeset in webkit [226752] by jfbastien@apple.com
  • 16 edits in trunk

Poison small JSObject derivatives which only contain pointers
​https://bugs.webkit.org/show_bug.cgi?id=181483
<rdar://problem/36407127>

Reviewed by Mark Lam.

Source/JavaScriptCore:

I wrote a script that finds interesting things to poison or
generally harden. These stood out because they derive from
JSObject and only contain a few pointer or pointer-like fields,
and could therefore just be poisoned. This also requires some
template "improvements" to our poisoning machinery. Worth noting
is that I'm making PoisonedUniquePtr move-assignable and
move-constructible from unique_ptr, which makes it a better
drop-in replacement because we don't need to use
makePoisonedUniquePtr. This means function-locals can be
unique_ptr and get the nice RAII pattern, and once the function is
done you can just move to the class' PoisonedUniquePtr without
worrying.

  • API/JSAPIWrapperObject.h:

(JSC::JSAPIWrapperObject::wrappedObject):

  • API/JSAPIWrapperObject.mm:

(JSC::JSAPIWrapperObject::JSAPIWrapperObject):

  • API/JSCallbackObject.h:
  • runtime/ArrayPrototype.h:
  • runtime/DateInstance.h:
  • runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::finishCreation):
(JSC::JSArrayBuffer::isShared const):
(JSC::JSArrayBuffer::sharingMode const):

  • runtime/JSArrayBuffer.h:
  • runtime/JSCPoison.h:

Source/WTF:

The associated JSC poisoning change requires some template
"improvements" to our poisoning machinery. Worth noting is that
I'm making PoisonedUniquePtr move-assignable and
move-constructible from unique_ptr, which makes it a better
drop-in replacement because we don't need to use
makePoisonedUniquePtr. This means function-locals can be
unique_ptr and get the nice RAII pattern, and once the function is
done you can just move to the class' PoisonedUniquePtr without
worrying.

  • wtf/Poisoned.h:

(WTF::PoisonedImpl::PoisonedImpl):

  • wtf/PoisonedUniquePtr.h:

(WTF::PoisonedUniquePtr::PoisonedUniquePtr):
(WTF::PoisonedUniquePtr::operator=):

Tools:

Test the new move-assign and move-copy from unique_ptr, as well as
nullptr_t ctors.

  • TestWebKitAPI/Tests/WTF/Poisoned.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:

(TestWebKitAPI::TEST):

6:30 PM Changeset in webkit [226751] by Chris Dumez
  • 4 edits in trunk

Multiple http/wpt/beacon/contentextensions/ test are flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179256
<rdar://problem/35401978>

Reviewed by Alex Christensen.

Tools:

Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
instance gets its own folder to avoid conflicts and flakiness.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):

LayoutTests:

Stop marking content extensions tests as flaky.

  • platform/mac-wk2/TestExpectations:
6:18 PM Changeset in webkit [226750] by timothy_horton@apple.com
  • 16 edits
    2 adds in trunk

REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
​https://bugs.webkit.org/show_bug.cgi?id=181269
<rdar://problem/35110344>

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processDidExit]):
(-[WKWebView _didCommitLayerTree:]):
When swiping to a page that set history.scrollRestoration = "manual",
we will never restore the scroll position. We will still restore
"state", but won't have a location. Currently, the code assumes that
it should wait to remove the swipe snapshot until the scroll position
is restored. Instead, wait until the "state" is restored, whether
or not that includes a scroll position/center point restoration.

Do this by making _firstTransactionIDAfterPageRestore an optional,
and reset it after it fires, so that we only run the restoration code
in _didCommitLayerTree for the first commit after state restoration,
not all subsequent commits. Then, tell ViewGestureController that
the scroll position has been restored even if the page opted out.

The reason that this is specific to pushState is that normal,
non-same-document loads bail from waiting for the scroll position
restoration in VGC::didReachMainFrameLoadTerminalState() (see the long
comment there for an explanation).

(-[WKWebView _beginBackSwipeForTesting]):
(-[WKWebView _completeBackSwipeForTesting]):

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/ViewGestureController.h:
  • UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController transitionForDirection:]):
(WebKit::ViewGestureController::beginSimulatedSwipeInDirectionForTesting):
(WebKit::ViewGestureController::completeSimulatedSwipeInDirectionForTesting):

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSimulatedSwipeInDirectionForTesting):
(WebKit::ViewGestureController::completeSimulatedSwipeInDirectionForTesting):
Add a mechanism to forcefully test swipe back. Instead of simulating
events like on Mac, we just talk to the UIKit internals and force
the interaction to start, pause, and then complete when we want.

  • swipe/pushstate-with-manual-scrollrestoration-expected.txt: Added.
  • swipe/pushstate-with-manual-scrollrestoration.html: Added.

Add a test (which previously would complain about taking too long)
that using manual scroll position restoration and pushState together
doesn't cause swipes to hang until the watchdog fires.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::beginBackSwipe):
(WTR::UIScriptController::completeBackSwipe):

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::beginBackSwipe):
(WTR::UIScriptController::completeBackSwipe):
(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::replaceTextAtRange):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::setNavigationGesturesEnabled):

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::beginBackSwipe):
(WTR::UIScriptController::completeBackSwipe):
Implement beginBackSwipe and completeBackSwipe on iOS (they already
exist on Mac) in terms of the new WKWebView testing SPI.

5:45 PM Changeset in webkit [226749] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip http/tests/workers/service/cors-image-fetch.html.
​https://bugs.webkit.org/show_bug.cgi?id=181222

Unreviewed test gardening.

5:39 PM Changeset in webkit [226748] by jmarcell@apple.com
  • 7 edits in branches/safari-604.5.6.0-branch/Source

Versioning.

5:38 PM Changeset in webkit [226747] by Konstantin Tokarev
  • 2 edits in trunk/Source/WTF

Add nullptr_t specialization of poison
​https://bugs.webkit.org/show_bug.cgi?id=181469

Patch by Don Olmstead <​don.olmstead@sony.com> on 2018-01-10
Reviewed by JF Bastien.

  • wtf/Poisoned.h:

(WTF::PoisonedImpl::poison):

5:35 PM Changeset in webkit [226746] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.5.6.0.1

Tag Safari-604.5.6.0.1.

4:45 PM Changeset in webkit [226745] by commit-queue@webkit.org
  • 9 edits in trunk

Use no-cache fetch mode when loading main documents with location.reload()
​https://bugs.webkit.org/show_bug.cgi?id=181285
LayoutTests/imported/w3c:

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-10
Reviewed by Alex Christensen.

  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-10
Reviewed by Alex Christensen.

Covered by rebased tests.

Start to translate cache policy used for navigation as FetchOptions::Cache.
This allows ensuring service workers receive the right cache mode when intercepting navigation loads.
To not change current navigation behavior, ReturnCacheDataElseLoad and ReturnCacheDataDontLoad still trigger default fetch cache mode.

For Reload and ReloadExpiredOnly frame load types, using no-cache mode is more efficient than reload mode,
as a conditional request will be sent if possible. This applies to location.reload which is consistent with other browsers.
Keep reload mode for ReloadFromOrigin.

  • loader/DocumentLoader.cpp:

(WebCore::toFetchOptionsCache):
(WebCore::DocumentLoader::loadMainResource):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::defaultRequestCachingPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/NavigationScheduler.cpp:

LayoutTests:

<rdar://problem/36356831>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-10
Reviewed by Alex Christensen.

  • http/tests/inspector/network/har/har-page-expected.txt:
  • http/tests/inspector/network/har/har-page.html:
4:14 PM Changeset in webkit [226744] by jmarcell@apple.com
  • 2 edits in branches/safari-604.5.6.0-branch/Source/JavaScriptCore

Cherry-pick r226672. rdar://problem/36397324

4:14 PM Changeset in webkit [226743] by jmarcell@apple.com
  • 7 edits in branches/safari-604.5.6.0-branch/Source

Versioning.

4:06 PM Changeset in webkit [226742] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Use protectedThis for the 'updatePrevalentDomainsToPartitionOrBlockCookies' lambda
​https://bugs.webkit.org/show_bug.cgi?id=181452
<rdar://problem/36416912>

Reviewed by Chris Dumez.

We forgot to use a 'protectedThis' back in r225006 for one of the lambdas used by
the WebsiteDataStore for processing.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):

3:41 PM Changeset in webkit [226741] by jmarcell@apple.com
  • 7 edits in branches/safari-605-branch/Source

Versioning.

3:29 PM Changeset in webkit [226740] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark accessibility/table-header-calculation-for-header-rows.html as failure on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=181501

Unreviewed test gardening.

  • platform/win/TestExpectations:
3:19 PM Changeset in webkit [226739] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

3:04 PM Changeset in webkit [226738] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.21

Tag Safari-605.1.21.

2:51 PM Changeset in webkit [226737] by Matt Lewis
  • 4 edits in trunk/LayoutTests

Adjusted expectations for webrtc/video-unmute.html.
​https://bugs.webkit.org/show_bug.cgi?id=172879

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
2:46 PM Changeset in webkit [226736] by Jonathan Bedard
  • 3 edits in trunk/Tools

REGRESSION (r226715): ignore WARNING output in linter tests
​https://bugs.webkit.org/show_bug.cgi?id=181486
<rdar://problem/36408847>

Reviewed by Aakash Jain.

Linter unit tests should not be interested in logs at the the INFO or WARNING levels.

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.init): Pass logging level to be captured.

  • Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.

2:43 PM Changeset in webkit [226735] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skip http/wpt/service-workers/fetchEvent.https.html in Debug
​https://bugs.webkit.org/show_bug.cgi?id=181481

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-10

2:21 PM Changeset in webkit [226734] by jmarcell@apple.com
  • 1 copy in branches/safari-604.5.6.0-branch

New Branch.

2:08 PM Changeset in webkit [226733] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 47

Added a tag for Safari Technology Preview release 47.

2:04 PM Changeset in webkit [226732] by jmarcell@apple.com
  • 1 copy in tags/Safari-606.1.1

Tag Safari-606.1.1.

1:57 PM Changeset in webkit [226731] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/workers/service/service-worker-importScript.html as flaky on macOS WK2.
​https://bugs.webkit.org/show_bug.cgi?id=181097

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:53 PM Changeset in webkit [226730] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html as flaky on macOS and iOS WK2.
​https://bugs.webkit.org/show_bug.cgi?id=181392

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:00 PM Changeset in webkit [226729] by clopez@igalia.com
  • 3 edits in trunk/Tools

Add a JSCOnly MIPS buildbot
​https://bugs.webkit.org/show_bug.cgi?id=181487

Reviewed by Michael Catanzaro.

Add the new bot configs definitions for the master and update the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
12:19 PM Changeset in webkit [226728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Should not try to autocomplete subsections of a string
​https://bugs.webkit.org/show_bug.cgi?id=181461
<rdar://problem/36369421>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-10
Reviewed by Brian Burg.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
Disable autocompletion within strings.

12:07 PM Changeset in webkit [226727] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Rebaseline test after r225366.

Unreviewed test gardening.

  • platform/win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
11:58 AM Changeset in webkit [226726] by Jonathan Bedard
  • 2 edits in trunk/Tools

REGRESSION (r226715): don't re-check number of simulators in child processes
​https://bugs.webkit.org/show_bug.cgi?id=181484
<rdar://problem/36407151>

Reviewed by Aakash Jain.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.init): Skip the number of simulators check if simulators
are already initialized.

11:41 AM Changeset in webkit [226725] by commit-queue@webkit.org
  • 67 edits
    2 deletes in trunk

Unreviewed, rolling out r226667 and r226673.
​https://bugs.webkit.org/show_bug.cgi?id=181488

This caused a flaky crash. (Requested by mlewis13 on #webkit).

Reverted changesets:

"CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226667

"REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226673

11:27 AM Changeset in webkit [226724] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.5.6

Tag Safari-604.5.6.

11:03 AM Changeset in webkit [226723] by Jonathan Bedard
  • 2 edits in trunk/Tools

Follow-up fix to r226715
​https://bugs.webkit.org/show_bug.cgi?id=180555
<rdar://problem/36131381>

Unreviewed infrastructure fix.

  • Scripts/webkitpy/xcode/new_simulated_device.py:

(SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
of delete.

10:20 AM Changeset in webkit [226722] by Chris Dumez
  • 5 edits in trunk/LayoutTests

REGRESSION (r224301?): LayoutTest http/tests/workers/service/registration-task-queue-scheduling-1.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=179342
<rdar://problem/35478161>

Reviewed by Youenn Fablet.

Unmark the test as flaky.

  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html:
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:

Update test to register a scriptURL that actually fails. When registration succeeds, the test
logs lines indicating that registration succeeded unexpectedly. Also, when registration
succeeds, the registration of the top frame are no longer guaranteed to be resolved before
the ones of the subframe (because it involves things like network loads).

10:19 AM Changeset in webkit [226721] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%
​https://bugs.webkit.org/show_bug.cgi?id=181460
<rdar://problem/36379776>

Reviewed by Ryosuke Niwa.

  • css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):

Don't do the expensive security origin test if the sheet base URL and document URL are identical.
This is true for inline style and inline stylesheets.

9:51 AM Changeset in webkit [226720] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, skip http/tests/workers/service/other_resources folder.

It is a resources folder and does not contain tests.

9:29 AM Changeset in webkit [226719] by pvollan@apple.com
  • 5 edits in trunk/LayoutTests

[Win] Rebaseline tests after r225366.

Unreviewed test gardening.

  • platform/win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/win/svg/custom/feComponentTransfer-Table-expected.txt:
9:01 AM Changeset in webkit [226718] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix windows build.

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::computeNextMatchElement):

8:38 AM Changeset in webkit [226717] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening

  • platform/gtk/TestExpectations: Unflag now-passing test and skip

mediastream tests, useless without any webrtc backend.

8:16 AM Changeset in webkit [226716] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebDriver

WebDriver: deserializeTimeouts() shouldn't reject double timeout values
​https://bugs.webkit.org/show_bug.cgi?id=181473

Reviewed by Carlos Garcia Campos.

With these changes, the following tests are fixed:

imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py::testShouldTimeoutIfScriptDoesNotInvokeCallbackWithLongTimeout
imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py::testShouldDetectPageLoadsWhileWaitingOnAnAsyncScriptAndReturnAnError
imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py::testShouldBeAbleToExecuteAsynchronousScripts
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldImplicitlyWaitForASingleElement
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldStillFailToFindAnElementWhenImplicitWaitsAreEnabled
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldReturnAfterFirstAttemptToFindOneAfterDisablingImplicitWaits
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldImplicitlyWaitUntilAtLeastOneElementIsFoundWhenSearchingForMany
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldStillFailToFindAnElemenstWhenImplicitWaitsAreEnabled
imported/selenium/py/test/selenium/webdriver/common/implicit_waits_tests.py::testShouldReturnAfterFirstAttemptToFindManyAfterDisablingImplicitWaits
imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py::testShouldTimeoutOnPageLoadTakingTooLong
imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py::testShouldTimeoutOnPageLoadTakingTooLong
imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py::testShouldWaitOnlyAsLongAsTimeoutSpecifiedWhenImplicitWaitsAreSet

The following two tests regress, and will be looked into separately:

imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid
imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_invalid

  • WebDriverService.cpp:

(WebDriver::integerValue): Helper function that retrieves an integer value
from a given JSON::Value object, if possible.
(WebDriver::deserializeTimeouts): Timeout JSON value has to be converted to
an integer, which is allowed if the value is of either Integer or Double type.
Helper integerValue() function retrieves the integer value, in addition to
ensuring that possible double value that we convert to an integer is already
in integer form to begin with.

8:05 AM Changeset in webkit [226715] by Jonathan Bedard
  • 8 edits in trunk/Tools

webkitpy: Refactor simulator code (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=180555
<rdar://problem/36131381>

Reviewed by Aakash Jain.

The patch leverages the SimulatedDeviceManager when running layout tests.
This patch is primarily code removal, since much of the IOSSimulatorPort
was dedicated to managing simulators. The removed code is either now owned by the
SimulatedDeviceManager (and committed in Part 1) or supported a technique to
boot multiple simulators which was made obsolete in Xcode 9.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._custom_device_for_test.in): Device names now have spaces in them,
strip those spaces.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Remove '--runtime' flag, this is achieved with the --version flag.

  • Scripts/webkitpy/port/ios.py:

(IOSPort.init): The _current_device idiom is no longer required since the
SimulatedDeviceManager keeps track of any previously booted devices.
(IOSPort.target_host): Even when only a single device is used, it will be accessed
through the array of managed devices.
(IOSPort.using_multiple_devices): Deleted.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.using_multiple_devices): Deleted.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Remove constants required to manage simulators, change device
class strings so they can be parsed by the DeviceType class.
(IOSSimulatorPort.init): Determine the number of processes to use by checking
the number of simulators currently booted, the number of child processes specified
and the maximum number of simulators supported by this system.
(IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
devices owned by the SimulatedDeviceManager.
(IOSSimulatorPort.ios_version): Remove support for the --runtime option.
(IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
the maximum number of supported simulators on this system.
(IOSSimulatorPort._create_devices): Construct a list of device requests with a
request for each child process and send this list to the SimulatedDeviceManager to
initialize the devices.
(IOSSimulatorPort.clean_up_test_run):
(IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
specified version of iOS.
(IOSSimulatorPort.reset_preferences):
(IOSSimulatorPort.simulator_runtime): Deleted.
(IOSSimulatorPort.simulator_device_type): Deleted.
(IOSSimulatorPort._teardown_managed_simulators): Deleted.
(IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
(IOSSimulatorPort._create_simulators): Deleted.
(IOSSimulatorPort._quit_ios_simulator): Deleted.
(IOSSimulatorPort._using_dedicated_simulators): Deleted.
(IOSSimulatorPort.using_multiple_devices): Deleted.
(IOSSimulatorPort._create_device): Deleted.
(IOSSimulatorPort.get_simulator_path): Deleted.
(IOSSimulatorPort._createSimulatorApps): Deleted.
(IOSSimulatorPort._createSimulatorApp): Deleted.

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline): Filter out commands run when determining the
maximum number of simulators run on this system.
(TestRebaselineExpectations.test_rebaseline_expectations): Ditto.

  • Scripts/webkitpy/xcode/new_simulated_device.py:

(SimulatedDeviceManager._does_fulfill_request): Fixed log statement.

7:54 AM Changeset in webkit [226714] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[RenderTreeBuilder] Move RenderRuby's moveChildren logic to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=181470
<rdar://problem/36397683>

Reviewed by Antti Koivisto.

This is about moving code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren): Deleted.
(WebCore::RenderRubyBase::mergeChildrenWithBase): Deleted.
(WebCore::RenderRubyBase::moveInlineChildren): Deleted.
(WebCore::RenderRubyBase::moveBlockChildren): Deleted.

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::takeChild):

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::moveRubyChildren):

  • rendering/updating/RenderTreeBuilder.h:
  • rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::moveInlineChildren):
(WebCore::RenderTreeBuilder::Ruby::moveBlockChildren):
(WebCore::RenderTreeBuilder::Ruby::moveChildren):
(WebCore::RenderTreeBuilder::Ruby::moveChildrenInternal):
(WebCore::RenderTreeBuilder::Ruby::insertChild):

  • rendering/updating/RenderTreeBuilderRuby.h:
7:29 AM Changeset in webkit [226713] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] fix critical GObject warning

Rubber-stamped by Carlos Garcia Campos.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): No need to
resort to complicated things to get the element name...

7:26 AM Changeset in webkit [226712] by Philippe Normand
  • 4 edits in trunk

[GStreamer] REGRESSION(r226629): broke media/video-interruption-with-resume-allowing-play.html
​https://bugs.webkit.org/show_bug.cgi?id=181471
<rdar://problem/36402323>

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This patch mainly reduces the amount of playback state changes
emitted by the GStreamer player to its client. Emitting those
notifications too often has bad side effects.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::paused const): Add debug messages.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): This debug message appears too much. Demote.
(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded const): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress const): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Try to emit
playback state change notification only when going to PLAYING.
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed): Add warning message.

LayoutTests:

  • platform/gtk/TestExpectations: These 2 tests shall pass now.
6:44 AM Changeset in webkit [226711] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
​https://bugs.webkit.org/show_bug.cgi?id=181474

Reviewed by Carlos Alberto Lopez Perez.

We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
name as the name.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
(WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().

4:29 AM Changeset in webkit [226710] by Ms2ger@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Enable css2.1/20110323/c541-word-sp-000.htm.
​https://bugs.webkit.org/show_bug.cgi?id=94009

Unreviewed test gardening.

It was fixed in r226404.

  • platform/gtk/TestExpectations:
4:13 AM Changeset in webkit [226709] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations for media test timing out on GTK

  • platform/gtk/TestExpectations:
3:25 AM Changeset in webkit [226708] by Carlos Garcia Campos
  • 25 edits
    6 copies
    6 adds
    2 deletes in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

  • imported/w3c/importer.json:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py:
  • imported/w3c/tools/wptrunner/wptrunner/environment.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
  • imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
  • imported/w3c/tools/wptrunner/wptrunner/update/update.py:
  • imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptlogging.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
  • imported/w3c/webdriver/OWNERS:
  • imported/w3c/webdriver/interface/interface.html: Removed.
  • imported/w3c/webdriver/tests/actions/modifier_click.py:
  • imported/w3c/webdriver/tests/actions/mouse.py:
  • imported/w3c/webdriver/tests/actions/mouse_dblclick.py: Added.
  • imported/w3c/webdriver/tests/actions/sequence.py:
  • imported/w3c/webdriver/tests/actions/support/mouse.py: Added.
  • imported/w3c/webdriver/tests/cookies/add_cookie.py:
  • imported/w3c/webdriver/tests/cookies/get_named_cookie.py:
  • imported/w3c/webdriver/tests/element_retrieval/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/retrieval/init.py.
  • imported/w3c/webdriver/tests/element_retrieval/find_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element.py.
  • imported/w3c/webdriver/tests/element_retrieval/find_element_from_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element_from_element.py.
  • imported/w3c/webdriver/tests/element_retrieval/find_elements.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_elements.py.
  • imported/w3c/webdriver/tests/element_retrieval/find_elements_from_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py.
  • imported/w3c/webdriver/tests/element_send_keys/init.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/init.py.
  • imported/w3c/webdriver/tests/element_send_keys/interactability.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/scroll_into_view.py: Added.
  • imported/w3c/webdriver/tests/execute_script/cyclic.py: Added.
  • imported/w3c/webdriver/tests/get_window_rect.py:
  • imported/w3c/webdriver/tests/interface.html:
  • imported/w3c/webdriver/tests/navigation/current_url.py:
  • imported/w3c/webdriver/tests/support/asserts.py:
  • imported/w3c/webdriver/tests/support/fixtures.py:
2:50 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
2:44 AM Changeset in webkit [226707] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.18.5

WebKitGTK+ 2.18.5

2:43 AM Changeset in webkit [226706] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.18.5 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.18.5.
2:16 AM Changeset in webkit [226705] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add Service Worker CSP persistency
​https://bugs.webkit.org/show_bug.cgi?id=181434

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-10
Reviewed by Alex Christensen.

Covered by manual testing.
Future work on service worker test infrastructure should allow automating such tests.

Add support for service worker CSP data persistency.
Add a version parameter to increment each time the schema is changing.
This allows the same store to be used by multiple WebKits.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::v1RecordsTableSchema):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):

2:15 AM Changeset in webkit [226704] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations for media test timing out on GTK

  • platform/gtk/TestExpectations:
1:01 AM Changeset in webkit [226703] by Antti Koivisto
  • 12 edits in trunk

Invalidate current element style on class change accurately
​https://bugs.webkit.org/show_bug.cgi?id=181210

Reviewed by Zalan Bujtas.

Source/WebCore:

  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::collectFeatures const):
(WebCore::DocumentRuleSets::subjectClassRules const):

New rule set containing class rules affecting the subject element.

(WebCore::DocumentRuleSets::ancestorClassRules const):

  • css/DocumentRuleSets.h:
  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):

Classify selector components into various buckets based on the elements they match relative to
the subject element. There are more categories than this patch strictly needs, for future use.

(WebCore::RuleFeatureSet::collectFeatures):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::shrinkToFit):

  • css/RuleFeature.h:
  • css/StyleResolver.h:

(WebCore::StyleResolver::hasSelectorForClass const): Deleted.

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::elementNeedsInvalidation):
(WebCore::Style::ClassChangeInvalidation::computeInvalidation):

Don't invalidate current element unconditionally on class change. Instead find the subject rulesets
that might affect it use them to perform invalidation.

(WebCore::Style::ClassChangeInvalidation::invalidateStyleWithRuleSets):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle): Deleted.
(WebCore::Style::ClassChangeInvalidation::invalidateDescendantStyle): Deleted.

  • style/ClassChangeInvalidation.h:

(WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation):
(WebCore::Style::ClassChangeInvalidation::~ClassChangeInvalidation):

  • style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::classNamesAffectedByRules const):

LayoutTests:

  • fast/css/set-inline-style-recalc-expected.txt:
  • fast/css/set-inline-style-recalc.html:
12:56 AM Changeset in webkit [226702] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r226018 - [GTK][WPE] Enable WebProcess memory monitor
​https://bugs.webkit.org/show_bug.cgi?id=180861

Reviewed by Michael Catanzaro.

For some reason this is only enabled in mac. We want to enable it also in GTK and WPE ports. This runs every 30
seconds to release memory or even kill the process if necessary. Carlos López has realized that in some
applications using video tags, the memory grows a lot and it's never released. It seems it's not memory leaked,
but simply large memory allocations (I guess it's gst allocating video frames) that make the heap grow. The
memory pressure calls malloc_trim that releases all that memory keeping the web process footprint stable.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

12:35 AM Changeset in webkit [226701] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r224458 - [GTK] Fix gtk-doc generation with gtk-doc master
​https://bugs.webkit.org/show_bug.cgi?id=179252

Reviewed by Carlos Garcia Campos.

gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
particular, this means we can no longer rely on shell stuff in our run command that we use
to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
make documentation generation work again.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

12:34 AM Changeset in webkit [226700] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebInspectorUI

Merge r221800 - Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
​https://bugs.webkit.org/show_bug.cgi?id=176633

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-08
Reviewed by Michael Saboff.

  • UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.

12:33 AM Changeset in webkit [226699] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Merge r226495 - Reduce the precision of "high" resolution time to 1ms
​https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillRTCStats):

  • page/Performance.cpp:

(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in ​https://github.com/w3c/web-platform-tests/pull/8711

12:28 AM Changeset in webkit [226698] by Carlos Garcia Campos
  • 19 edits in releases/WebKitGTK/webkit-2.18

Merge r226386 - Disable SharedArrayBuffers from Web API
​https://bugs.webkit.org/show_bug.cgi?id=181266

Reviewed by Saam Barati.

JSTests:

Disabled SharedArrayBuffer tests.

  • stress/SharedArrayBuffer-opt.js:
  • stress/SharedArrayBuffer.js:
  • stress/array-buffer-byte-length.js:
  • stress/atomics-add-uint32.js:
  • stress/atomics-known-int-use.js:
  • stress/atomics-neg-zero.js:
  • stress/atomics-store-return.js:
  • stress/lars-sab-workers.js:
  • stress/regress-159779-1.js:
  • stress/regress-159779-2.js:
  • stress/regress-170473.js:
  • test262.yaml:

Source/JavaScriptCore:

Removed SharedArrayBuffer prototype and structure from GlobalObject creation
to disable.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):

Source/WTF:

Turn off SharedArrayBuffers using a compile time flag ENABLE_SHARED_ARRAY_BUFFER.

  • wtf/Platform.h:

LayoutTests:

Disabled SharedArrayBuffer tests.

12:20 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
Fix off-by-one error (diff)

Jan 9, 2018:

10:15 PM Changeset in webkit [226697] by graouts@webkit.org
  • 8 edits in trunk

[Web Animations] Expose the id property on Animation
​https://bugs.webkit.org/show_bug.cgi?id=181450
<rdar://problem/36383600>

Reviewed by Dean Jackson.

Source/WebCore:

Expose the "id" property on Animation and handle the "id" property on the optional KeyframeAnimationOptions object
passed to Element.animate(). All of the WPT tests related to this property are now passing.

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:
  • dom/Element.cpp:

(WebCore::Element::animate):

LayoutTests:

Mark all tests related to the "id" property as passing.

  • http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/id-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt:
9:43 PM Changeset in webkit [226696] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r226672. rdar://problem/36397330

9:02 PM Changeset in webkit [226695] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org against at r226694.

Rubber-stamped by Keith Miller.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
8:51 PM Changeset in webkit [226694] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

Speedometer 2.0: Update the About page.
​https://bugs.webkit.org/show_bug.cgi?id=175918

Reviewed by Keith Miller.

Updated the about page for Speedometer 2.0.

  • Speedometer/index.html:
8:31 PM Changeset in webkit [226693] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r226669. rdar://problem/36393011

8:31 PM Changeset in webkit [226692] by jmarcell@apple.com
  • 5 edits in branches/safari-605-branch

Cherry-pick r226638. rdar://problem/36392286

8:31 PM Changeset in webkit [226691] by jmarcell@apple.com
  • 24 edits in branches/safari-605-branch

Cherry-pick r226628. rdar://problem/36392341

8:31 PM Changeset in webkit [226690] by jmarcell@apple.com
  • 12 edits in branches/safari-605-branch/Source

Cherry-pick r226626. rdar://problem/36392359

8:31 PM Changeset in webkit [226689] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r226623. rdar://problem/36392380

8:31 PM Changeset in webkit [226688] by jmarcell@apple.com
  • 5 edits
    2 adds in branches/safari-605-branch

Cherry-pick r226617. rdar://problem/36392336

8:31 PM Changeset in webkit [226687] by jmarcell@apple.com
  • 15 edits in branches/safari-605-branch

Cherry-pick r226615. rdar://problem/36392328

8:31 PM Changeset in webkit [226686] by jmarcell@apple.com
  • 6 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r226556. rdar://problem/36392331

8:31 PM Changeset in webkit [226685] by jmarcell@apple.com
  • 8 edits in branches/safari-605-branch/Source

Cherry-pick r226542. rdar://problem/36392364

8:31 PM Changeset in webkit [226684] by jmarcell@apple.com
  • 26 edits in branches/safari-605-branch/Source

Cherry-pick r226530. rdar://problem/36392325

8:31 PM Changeset in webkit [226683] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r226528. rdar://problem/36392391

8:31 PM Changeset in webkit [226682] by jmarcell@apple.com
  • 14 edits
    2 adds in branches/safari-605-branch

Cherry-pick r226526. rdar://problem/36392384

8:31 PM Changeset in webkit [226681] by jmarcell@apple.com
  • 5 edits
    2 adds in branches/safari-605-branch

Cherry-pick r226521. rdar://problem/36392339

8:31 PM Changeset in webkit [226680] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r226519. rdar://problem/36392376

8:31 PM Changeset in webkit [226679] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r226517. rdar://problem/36392371

8:31 PM Changeset in webkit [226678] by jmarcell@apple.com
  • 7 edits in branches/safari-605-branch/Source

Versioning.

8:08 PM Changeset in webkit [226677] by Chris Dumez
  • 6 edits
    9 adds in trunk

Make service workers behave correctly with regards to Page Cache
​https://bugs.webkit.org/show_bug.cgi?id=181446
<rdar://problem/36164291>

Reviewed by Youenn Fablet.

Source/WebCore:

Make service workers behave correctly with regards to Page Cache:

  1. If a document has an active service worker, do not let it go into PageCache
  2. When a document goes into page cache, unregister it from the list of service worker clients
  3. When a document is restored from page cache, add it nack to the list of service worker clients

Tests: http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache.html

http/tests/workers/service/client-removed-from-clients-while-in-page-cache.html
http/tests/workers/service/no-page-cache-when-controlled.html
http/tests/workers/service/other_resources/test.html

  • dom/Document.cpp:

(WebCore::Document::suspend):
(WebCore::Document::resume):

  • history/PageCache.cpp:

(WebCore::canCacheFrame):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::serviceWorkerKey):

  • page/DiagnosticLoggingKeys.h:

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache-expected.txt: Added.
  • http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache.html: Added.
  • http/tests/workers/service/client-removed-from-clients-while-in-page-cache-expected.txt: Added.
  • http/tests/workers/service/client-removed-from-clients-while-in-page-cache.html: Added.
  • http/tests/workers/service/no-page-cache-when-controlled-expected.txt: Added.
  • http/tests/workers/service/no-page-cache-when-controlled.html: Added.
  • http/tests/workers/service/other_resources/test.html: Added.
  • http/tests/workers/service/resources/getClientCount-worker.js: Added.

(event.then):

7:31 PM Changeset in webkit [226676] by Chris Dumez
  • 11 edits in trunk

We should not return undefined for most properties of a detached Window
​https://bugs.webkit.org/show_bug.cgi?id=181416
<rdar://problem/36162489>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that more checks are passing.

  • web-platform-tests/custom-elements/custom-element-registry/per-global-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-append-to-child-document-expected.txt:
  • web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:

Source/WebCore:

We should not return undefined for most properties on a detached Window. WebKit previously only exposed "closed"
and "close" properties on detached / frameless windows. However, this does not match the HTML specification [1]
or the behavior of Firefox and Chrome.

Note that Chrome does not seem to fully follow the HTML specification either, it seems to treat detached windows
the same way as cross-origin ones. As a result, it only exposed properties that are visible cross-origin when
a window is detached / frameless.

[1] ​https://html.spec.whatwg.org/#windowproxy-get

No new tests, updated existingt tests.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

LayoutTests:

Update existing tests to reflect behavior change.

  • fast/dom/Window/orphaned-frame-access-expected.txt:
  • fast/dom/Window/orphaned-frame-access.html:
  • fast/frames/detached-frame-property-expected.txt:
  • fast/frames/detached-frame-property.html:
7:24 PM Changeset in webkit [226675] by Darin Adler
  • 10 edits in trunk

Further refinement to list item and counter code after "list-item" counter fix
​https://bugs.webkit.org/show_bug.cgi?id=181426

Reviewed by Zalan Bujtas.

Source/WebCore:

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInheritCounter): Use auto.
(WebCore::StyleBuilderCustom::applyValueCounter): Use auto, removed unneeded
null checks for things that can never be null, moved the saturated addition
here and got rid of the addIncrementValue function from CounterDirectives.
Use the saturatedAddition function from SaturatedArithmetic.h instead of the
much less efficient one that did the same thing, CounterDirectives::addClamped.

  • rendering/RenderCounter.cpp:

(WebCore::listItemCounterDirectives): Use aggregate syntax for the return
statements.
(WebCore::planCounter): Changed to use a struct return value instead of two
out arguments. Use the saturatedAddition function from SaturatedArithmetic.h
instead of the much less efficient one that did the same thing,
CounterDirectives::addClamped.
(WebCore::findPlaceForCounter): Changed to use a struct return value instead
of two out arguments.
(WebCore::makeCounterNode): Updated for the above changes. Changed code to
use add instead of both get and set. Updated to keep the counter maps inside
the values of the "map of maps" instead of using a unique_ptr and allocating
each one on the heap.
(WebCore::destroyCounterNodeWithoutMapRemoval): Changed argument to a reference
instead of a pointer. Updated for changes to the map. Use RefPtr more
consistently.
(WebCore::RenderCounter::destroyCounterNodes): Use iterators less.
(WebCore::RenderCounter::destroyCounterNode): Ditto.
(WebCore::RenderCounter::rendererRemovedFromTree): Add a check of
hasCounterNodeMap here before calling destroyCounterNodes, so that function
can assume the flag is true (both other callers already check it).
(WebCore::updateCounters): Use auto and update for changes above.
(WebCore::RenderCounter::rendererStyleChanged): Use modern for loops instead
of iterators.
(showCounterRendererTree): Use auto and udpate for changes above.

  • rendering/RenderListItem.cpp:

(WebCore::enclosingList): Stop referring to elements as "nodes". Changed
the local variable names for clarity.
(WebCore::nextListItemHelper): Renamed from nextListItem since it's not
intended to be called directly and we want to use a function pointer to
nextListItem. Fixed the algorithm to correctly handle ad hoc "lists" that
are not actually HTML list elements, using the definition in the enclosingList
function as the previousListItem function already did.
(WebCore::nextListItem): Updated for name changes.
(WebCore::firstListItem): Renamed from nextListItem for clarity.
(WebCore::previousListItem): Rewrote loop so it doesn't have to do things
so strangely when we find another list.
(WebCore::RenderListItem::updateItemValuesForOrderedList): Use auto and
update local variable names.
(WebCore::RenderListItem::itemCountForOrderedList): Ditto.
(WebCore::RenderListItem::updateValueNow const): Rewrote to use an iterative
algorithm instead of a recursive one. Fixes the FIXME here.
(WebCore::RenderListItem::updateValue): Use m_valueWasSetExplicitly
instead of m_explicitValue.
(WebCore::RenderListItem::explicitValueChanged): Use auto and simplified
the loop a bit.
(WebCore::RenderListItem::setExplicitValue): Set m_valueWasSetExplicitly
instead of m_explicitValue.
(WebCore::previousOrNextItem): Deleted.
(WebCore::RenderListItem::updateListMarkerNumbers): Streamlined the loop
a bit and used a fucntion pointer to handle the two different directions.
(WebCore::RenderListItem::isInReversedOrderedList const): Simplified by
getting rid of an unneeded use of pointers and local variables.

  • rendering/RenderListItem.h: Use a boolean, m_valueWasSetExplicitly,

instead of a separate optional m_explicitValue.

  • rendering/style/CounterDirectives.h: Since all the code in this file was

rewritten, removed old copyrights. Deleted the addIncrementValue function,
since it is clear enough in the one call site in the style builder.
Deleted the addClamped function because it was just a much slower
version of the saturatedAddition function. Made == and != into constexpr
functions since they are simple enough to be.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCounterDirectives const): Deleted. Caller can
handle this just fine without a helper function.

  • rendering/style/RenderStyle.h: Ditto.

LayoutTests:

  • fast/css/counters/counter-list-item.html: Removed an extra newline at the end of

the file.

7:17 PM Changeset in webkit [226674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r201855): Web Inspector: Should see "length" autocompletion suggestion on a string literal
​https://bugs.webkit.org/show_bug.cgi?id=181462
<rdar://problem/36390699>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-09
Reviewed by Matt Baker.

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.inspectedPage_evalResult_getCompletions):
This is code that runs on the inspected target, which may have an old version of
WebKit/JavaScriptCore, so don't use new syntax like this.

(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
We intended to return the result by as a JSON value instead of a RemoteObject.

7:04 PM Changeset in webkit [226673] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r226667): CodeBlocks should be in IsoSubspaces
<​https://bugs.webkit.org/show_bug.cgi?id=180884>

Fixes the following build error:

heap/Heap.cpp:2708:10: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]

  • heap/Heap.cpp:

(JSC::Heap::addCoreConstraints): Remove 'this' from lambda to
fix the build.

7:00 PM Changeset in webkit [226672] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

and32 with an Address source on ARM64 did not invalidate dataTempRegister
​https://bugs.webkit.org/show_bug.cgi?id=181467

Reviewed by Michael Saboff.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::and32):

6:43 PM Changeset in webkit [226671] by Ross Kirsling
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Layers sidebar shows popover on selection even when collapsed
​https://bugs.webkit.org/show_bug.cgi?id=181465

Reviewed by Matt Baker.

  • UserInterface/Views/LayerDetailsSidebarPanel.js:

(WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
Have sidebar show itself if necessary before displaying popover.

6:37 PM Changeset in webkit [226670] by aestes@apple.com
  • 2 edits in trunk/Tools

[Xcode] Use the Apple Internal SDK if available when building ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=181459

Reviewed by Dan Bernstein.

  • ImageDiff/cg/Configurations/Base.xcconfig:
5:34 PM Changeset in webkit [226669] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Storage Access API: Turn feature on by default in WebPreferences.yaml
​https://bugs.webkit.org/show_bug.cgi?id=181458

Reviewed by Brent Fulgham.

  • Shared/WebPreferences.yaml:
4:44 PM Changeset in webkit [226668] by mmaxfield@apple.com
  • 9 edits
    12 moves
    2 adds in trunk

font-display:fallback can cause a visual flash (which is supposed to be impossible)
​https://bugs.webkit.org/show_bug.cgi?id=181374

Reviewed by Simon Fraser.

Source/WebCore:

A FontCascade represents an entire font-family fallback list, but sometimes we need to pull out a single
representative font from the list to calculate things like line height. Previously, if the first item in
the font-family list was in the middle of being downloaded, this representative font was hardcoded to be
Times. However, when actually laying out and drawing the glyphs, we have logic to skip the interstitial
Times if there are any installed fonts present in the font-family list (so you wouldn't ever actually
see Times). This means that line height (among other things) was being calculated as if Times was used,
but in reality, some other font from the font-family list was being used.

Alone, this isn't a huge problem, but font-display:fallback makes a font transition between "timed out"
and "failed," and when the font hits the failed state, the representative font skips over the cancelled
item and hits the next item in the fallback list. This means that line heights will change, which causes
a visual flash, even when font-display:fallback is specified.

The solution is simply to educate the logic which identifies this representative font so that it
understands what to do for currently-loading fonts.

Tests: fast/text/font-display/swap-flash.html

  • platform/graphics/FontCascadeFonts.h:

(WebCore::FontCascadeFonts::primaryFont):

  • rendering/line/BreakingContext.h:

(WebCore::textWidth):

Tools:

The test requires Palatino.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

Move font-display tests into their common subfolder.

  • fast/text/font-display/block-finish-expected.html: Renamed from LayoutTests/fast/text/loading-block-finish-expected.html.
  • fast/text/font-display/block-finish.html: Renamed from LayoutTests/fast/text/loading-block-finish.html.
  • fast/text/font-display/block-nofinish-expected.html: Renamed from LayoutTests/fast/text/loading-block-nofinish-expected.html.
  • fast/text/font-display/block-nofinish.html: Renamed from LayoutTests/fast/text/loading-block-nofinish.html.
  • fast/text/font-display/failure-finish-expected.html: Renamed from LayoutTests/fast/text/loading-failure-finish-expected.html.
  • fast/text/font-display/failure-finish.html: Renamed from LayoutTests/fast/text/loading-failure-finish.html.
  • fast/text/font-display/failure-nofinish-expected.html: Renamed from LayoutTests/fast/text/loading-failure-nofinish-expected.html.
  • fast/text/font-display/failure-nofinish.html: Renamed from LayoutTests/fast/text/loading-failure-nofinish.html.
  • fast/text/font-display/swap-finish-expected.html: Renamed from LayoutTests/fast/text/loading-swap-finish-expected.html.
  • fast/text/font-display/swap-finish.html: Renamed from LayoutTests/fast/text/loading-swap-finish.html.
  • fast/text/font-display/swap-nofinish-expected.html: Renamed from LayoutTests/fast/text/loading-swap-nofinish-expected.html.
  • fast/text/font-display/swap-nofinish.html: Renamed from LayoutTests/fast/text/loading-swap-nofinish.html.
  • fast/text/font-display/swap-flash-expected.html: Added.
  • fast/text/font-display/swap-flash.html: Added.
  • platform/win/TestExpectations:
4:30 PM Changeset in webkit [226667] by fpizlo@apple.com
  • 66 edits
    2 adds in trunk

CodeBlocks should be in IsoSubspaces
​https://bugs.webkit.org/show_bug.cgi?id=180884

Reviewed by Saam Barati.
Source/JavaScriptCore:


This moves CodeBlocks into IsoSubspaces. Doing so means that we no longer need to have the
special CodeBlockSet HashSets of new and old CodeBlocks. We also no longer use
WeakReferenceHarvester or UnconditionalFinalizer. Instead:

  • Code block sweeping is now just eager sweeping. This means that it automatically takes advantage of our unswept set, which roughly corresponds to what CodeBlockSet used to use its eden set for.


  • Those idea of Executable "weakly visiting" the CodeBlock is replaced by Executable marking a ExecutableToCodeBlockEdge object. That object being marked corresponds to what we used to call CodeBlock "having been weakly visited". This means that CodeBlockSet no longer has to clear the set of weakly visited code blocks. This also means that determining CodeBlock liveness, propagating CodeBlock transitions, and jettisoning CodeBlocks during GC are now the edge's job. The edge is also in an IsoSubspace and it has IsoCellSets to tell us which edges have output constraints (what we used to call CodeBlock's weak reference harvester) and which have unconditional finalizers.


  • CodeBlock now uses an IsoCellSet to tell if it has an unconditional finalizer.


  • CodeBlockSet still exists! It has one unified HashSet of CodeBlocks that we use to handle requests from the sampler, debugger, and other facilities. They may want to ask if some pointer corresponds to a CodeBlock during stages of execution during which the GC is unable to answer isLive() queries. The trickiest is the sampling profiler thread. There is no way that the GC's isLive could tell us of a CodeBlock that had already been allocated has now been full constructed.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::finishCreationCommon):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitChildren):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::hasInstalledVMTrapBreakpoints const):
(JSC::CodeBlock::installVMTrapBreakpoints):
(JSC::CodeBlock::dumpMathICStats):
(JSC::CodeBlock::visitWeakly): Deleted.
(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted.
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::subspaceFor):
(JSC::CodeBlock::ownerEdge const):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.

  • bytecode/EvalCodeBlock.h:

(JSC::EvalCodeBlock::create): Deleted.
(JSC::EvalCodeBlock::createStructure): Deleted.
(JSC::EvalCodeBlock::variable): Deleted.
(JSC::EvalCodeBlock::numVariables): Deleted.
(JSC::EvalCodeBlock::functionHoistingCandidate): Deleted.
(JSC::EvalCodeBlock::numFunctionHoistingCandidates): Deleted.
(JSC::EvalCodeBlock::EvalCodeBlock): Deleted.
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock const): Deleted.

  • bytecode/ExecutableToCodeBlockEdge.cpp: Added.

(JSC::ExecutableToCodeBlockEdge::createStructure):
(JSC::ExecutableToCodeBlockEdge::create):
(JSC::ExecutableToCodeBlockEdge::visitChildren):
(JSC::ExecutableToCodeBlockEdge::visitOutputConstraints):
(JSC::ExecutableToCodeBlockEdge::finalizeUnconditionally):
(JSC::ExecutableToCodeBlockEdge::activate):
(JSC::ExecutableToCodeBlockEdge::deactivate):
(JSC::ExecutableToCodeBlockEdge::deactivateAndUnwrap):
(JSC::ExecutableToCodeBlockEdge::wrap):
(JSC::ExecutableToCodeBlockEdge::wrapAndActivate):
(JSC::ExecutableToCodeBlockEdge::ExecutableToCodeBlockEdge):
(JSC::ExecutableToCodeBlockEdge::runConstraint):

  • bytecode/ExecutableToCodeBlockEdge.h: Added.

(JSC::ExecutableToCodeBlockEdge::subspaceFor):
(JSC::ExecutableToCodeBlockEdge::codeBlock const):
(JSC::ExecutableToCodeBlockEdge::unwrap):

  • bytecode/FunctionCodeBlock.h:

(JSC::FunctionCodeBlock::subspaceFor):
(JSC::FunctionCodeBlock::createStructure):

  • bytecode/ModuleProgramCodeBlock.h:

(JSC::ModuleProgramCodeBlock::create): Deleted.
(JSC::ModuleProgramCodeBlock::createStructure): Deleted.
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock): Deleted.

  • bytecode/ProgramCodeBlock.h:

(JSC::ProgramCodeBlock::create): Deleted.
(JSC::ProgramCodeBlock::createStructure): Deleted.
(JSC::ProgramCodeBlock::ProgramCodeBlock): Deleted.

  • debugger/Debugger.cpp:

(JSC::Debugger::SetSteppingModeFunctor::operator() const):
(JSC::Debugger::ToggleBreakpointFunctor::operator() const):
(JSC::Debugger::ClearCodeBlockDebuggerRequestsFunctor::operator() const):
(JSC::Debugger::ClearDebuggerRequestsFunctor::operator() const):

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::contains):
(JSC::CodeBlockSet::dump const):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::promoteYoungCodeBlocks): Deleted.
(JSC::CodeBlockSet::clearMarksForFullCollection): Deleted.
(JSC::CodeBlockSet::lastChanceToFinalize): Deleted.
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): Deleted.

  • heap/CodeBlockSet.h:
  • heap/CodeBlockSetInlines.h:

(JSC::CodeBlockSet::iterate):
(JSC::CodeBlockSet::iterateViaSubspaces):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):
(JSC::DummyMarkHook::markKnownJSCell):
(JSC::CompositeMarkHook::mark):
(JSC::CompositeMarkHook::markKnownJSCell):

  • heap/ConservativeRoots.h:
  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::finalizeMarkedUnconditionalFinalizers):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::beginMarking):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::sweepInFinalize):
(JSC::Heap::forEachCodeBlockImpl):
(JSC::Heap::forEachCodeBlockIgnoringJITPlansImpl):
(JSC::Heap::addCoreConstraints):
(JSC::Heap::finalizeUnconditionalFinalizersInIsoSubspace): Deleted.

  • heap/Heap.h:
  • heap/HeapCell.h:
  • heap/HeapCellInlines.h:

(JSC::HeapCell::subspace const):

  • heap/HeapInlines.h:

(JSC::Heap::forEachCodeBlock):
(JSC::Heap::forEachCodeBlockIgnoringJITPlans):

  • heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):

  • heap/IsoCellSet.cpp:

(JSC::IsoCellSet::parallelNotEmptyMarkedBlockSource):

  • heap/IsoCellSet.h:
  • heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::forEachMarkedCellInParallel):
(JSC::IsoCellSet::forEachLiveCell):

  • heap/LargeAllocation.h:

(JSC::LargeAllocation::subspace const):

  • heap/MarkStackMergingConstraint.cpp:

(JSC::MarkStackMergingConstraint::executeImpl):

  • heap/MarkStackMergingConstraint.h:
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::parallelNotEmptyBlockSource):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::didAddToAllocator):
(JSC::MarkedBlock::Handle::didRemoveFromAllocator):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::subspace const):

  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::forEachLiveCell):

  • heap/MarkedSpaceInlines.h:

(JSC::MarkedSpace::forEachLiveCell):

  • heap/MarkingConstraint.cpp:

(JSC::MarkingConstraint::execute):
(JSC::MarkingConstraint::doParallelWork):
(JSC::MarkingConstraint::finishParallelWork): Deleted.
(JSC::MarkingConstraint::doParallelWorkImpl): Deleted.
(JSC::MarkingConstraint::finishParallelWorkImpl): Deleted.

  • heap/MarkingConstraint.h:
  • heap/MarkingConstraintSet.cpp:

(JSC::MarkingConstraintSet::add):

  • heap/MarkingConstraintSet.h:

(JSC::MarkingConstraintSet::add):

  • heap/MarkingConstraintSolver.cpp:

(JSC::MarkingConstraintSolver::execute):
(JSC::MarkingConstraintSolver::addParallelTask):
(JSC::MarkingConstraintSolver::runExecutionThread):
(JSC::MarkingConstraintSolver::didExecute): Deleted.

  • heap/MarkingConstraintSolver.h:

(JSC::MarkingConstraintSolver::TaskWithConstraint::TaskWithConstraint):
(JSC::MarkingConstraintSolver::TaskWithConstraint::operator== const):

  • heap/SimpleMarkingConstraint.cpp:

(JSC::SimpleMarkingConstraint::SimpleMarkingConstraint):
(JSC::SimpleMarkingConstraint::executeImpl):

  • heap/SimpleMarkingConstraint.h:

(JSC::SimpleMarkingConstraint::SimpleMarkingConstraint):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::addParallelConstraintTask):

  • heap/SlotVisitor.h:
  • heap/Subspace.cpp:

(JSC::Subspace::sweep):

  • heap/Subspace.h:
  • heap/SubspaceInlines.h:

(JSC::Subspace::forEachLiveCell):

  • llint/LowLevelInterpreter.asm:
  • runtime/EvalExecutable.cpp:

(JSC::EvalExecutable::visitChildren):

  • runtime/EvalExecutable.h:

(JSC::EvalExecutable::codeBlock):

  • runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::visitChildren):

  • runtime/FunctionExecutable.h:
  • runtime/JSType.h:
  • runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::visitChildren):

  • runtime/ModuleProgramExecutable.h:
  • runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::visitChildren):

  • runtime/ProgramExecutable.h:
  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::SpaceAndFinalizerSet::SpaceAndFinalizerSet):
(JSC::VM::SpaceAndFinalizerSet::finalizerSetFor):
(JSC::VM::forEachCodeBlockSpace):

  • runtime/VMTraps.cpp:

(JSC::VMTraps::handleTraps):

  • tools/VMInspector.cpp:

(JSC::VMInspector::codeBlockForMachinePC):
(JSC::VMInspector::isValidCodeBlock):

Source/WebCore:

No new tests because no new behavior.

Adopting new parallel constraint API, so that more of the logic of doing parallel
constraint solving is shared between the DOM's output constraints and JSC's output
constraints.

  • bindings/js/DOMGCOutputConstraint.cpp:

(WebCore::DOMGCOutputConstraint::executeImpl):
(WebCore::DOMGCOutputConstraint::doParallelWorkImpl): Deleted.
(WebCore::DOMGCOutputConstraint::finishParallelWorkImpl): Deleted.

  • bindings/js/DOMGCOutputConstraint.h:

Source/WTF:


Deque<>::contains() is helpful for a debug ASSERT.

  • wtf/Deque.h:

(WTF::inlineCapacity>::contains):

4:05 PM Changeset in webkit [226666] by Simon Fraser
  • 11 edits in trunk/Source/WebCore

Clean up Marquee-related enums
​https://bugs.webkit.org/show_bug.cgi?id=181347

Reviewed by Anders Carlsson.

Modernize EMarqueeBehavior and EMarqueeDirection enums. Stop using the weird negative
values in the MarqueeDirection and do manual reverse direction mapping.

Make some member functions of RenderMarquee private.

Stop using bitfields in RenderMarquee because the memory saving is not worth it, and doing so
allows us to use modern initialization.

No behavior change.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator MarqueeBehavior const):
(WebCore::CSSPrimitiveValue::operator MarqueeDirection const):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior const): Deleted.
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection const): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent const):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::RenderMarquee):
(WebCore::reverseDirection):
(WebCore::RenderMarquee::direction const):
(WebCore::RenderMarquee::isHorizontal const):
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::start):
(WebCore::RenderMarquee::updateMarqueePosition):
(WebCore::RenderMarquee::updateMarqueeStyle):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMarquee.h:
  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::marqueeBehavior const):
(WebCore::RenderStyle::marqueeDirection const):
(WebCore::RenderStyle::setMarqueeDirection):
(WebCore::RenderStyle::setMarqueeBehavior):
(WebCore::RenderStyle::initialMarqueeBehavior):
(WebCore::RenderStyle::initialMarqueeDirection):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleMarqueeData.cpp:

(WebCore::StyleMarqueeData::StyleMarqueeData):

  • rendering/style/StyleMarqueeData.h:
3:54 PM Changeset in webkit [226665] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

WKOpenPanelParameters SPI should return autoreleased objects
​https://bugs.webkit.org/show_bug.cgi?id=181457
<rdar://problem/35884960>

Reviewed by Tim Horton.

In r226607 I made a mistake by returning an object that has been released.
I instead follow a pattern of leaking and autoreleasing that we use elsewhere in the ObjC API.

  • UIProcess/API/Cocoa/WKOpenPanelParameters.mm:

(-[WKOpenPanelParameters _acceptedMIMETypes]):
(-[WKOpenPanelParameters _acceptedFileExtensions]):

3:47 PM Changeset in webkit [226664] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Many CVDisplayLink threads created and destroyed while watching a YouTube video
​https://bugs.webkit.org/show_bug.cgi?id=181396

Reviewed by Simon Fraser.

When watching some YouTube videos (or any video with default controls), event handlers for
the "timeupdate" event which use rAF will cause the underlying platform objects to be
destroyed in between "timeupdate" events being fired, since they occur every 250ms, and rAF
objects are destroyed every 166ms (or 10/60hz). Update this constant to destroy the
underlying objects every 333ms (or 20/60hz) so that this common pattern doesn't lead to
excessive rAF platform object turnover.

  • platform/Logging.h:
  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

  • platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh):

3:46 PM Changeset in webkit [226663] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed test expectaions.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
3:46 PM Changeset in webkit [226662] by jmarcell@apple.com
  • 1 copy in branches/safari-605-branch

New Branch.

3:43 PM Changeset in webkit [226661] by sbarati@apple.com
  • 2 edits in trunk/Tools

Give some slack in display-profiler-outputs computation of the terminal window's number of columns
​https://bugs.webkit.org/show_bug.cgi?id=181449

Reviewed by JF Bastien.

This allows me to Cmd+f in my terminal to search for things without
having the results become misaligned.

  • Scripts/display-profiler-output:
3:31 PM Changeset in webkit [226660] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[RenderTreeBuilder] Move RenderElement addChild mutation logic to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=181451
<rdar://problem/36385562>

Reviewed by Antti Koivisto.

This is about moving code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::addChild):
(WebCore::RenderElement::childRequiresTable const): Deleted.

  • rendering/RenderElement.h:
  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::insertChildToRenderElement):
(WebCore::RenderTreeBuilder::childRequiresTable):

  • rendering/updating/RenderTreeBuilder.h:
  • rendering/updating/RenderTreeBuilderInline.cpp:

(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
(WebCore::RenderTreeBuilder::Inline::insertChildIgnoringContinuation):
(WebCore::RenderTreeBuilder::Inline::newChildIsInline):
(WebCore::newChildIsInline): Deleted.

  • rendering/updating/RenderTreeBuilderInline.h:
3:00 PM Changeset in webkit [226659] by Matt Lewis
  • 6 edits in trunk

Unreviewed, rolling out r226531.

This caused test failures on macOS WK2.

Reverted changeset:

"Use no-cache fetch mode when loading main documents with
location.reload()"
​https://bugs.webkit.org/show_bug.cgi?id=181285
​https://trac.webkit.org/changeset/226531

1:47 PM Changeset in webkit [226658] by msaboff@apple.com
  • 8 edits in trunk/Source

Unreviewed, rolling out r226600 and r226603
​https://bugs.webkit.org/show_bug.cgi?id=181351

Add a DOM gadget for Spectre testing

  • runtime/Options.h:
  • dom/Comment.cpp:

(WebCore::Comment::Comment):
(WebCore::Comment::setReadLength): Deleted.
(WebCore::Comment::charCodeAt): Deleted.
(WebCore::Comment::clflushReadLength): Deleted.

  • dom/Comment.h:
  • dom/Comment.idl:
  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::spectreGadgetsEnabled const): Deleted.

  • page/RuntimeEnabledFeatures.h:
1:17 PM Changeset in webkit [226657] by don.olmstead@sony.com
  • 35 edits in trunk/Source/WebCore

Add additional WEBCORE_EXPORTs
​https://bugs.webkit.org/show_bug.cgi?id=181414

Reviewed by Alex Christensen.

No new tests. No change in behavior.

  • dom/Document.h:
  • dom/ViewportArguments.h:
  • page/DOMWindow.h:
  • page/FrameView.h:
  • page/PageOverlayController.h:
  • platform/ContextMenuItem.h:
  • platform/Pasteboard.h:
  • platform/SharedBuffer.h:
  • platform/UserAgent.h:
  • platform/graphics/GLContext.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayerTransform.h:
  • platform/graphics/PlatformDisplay.h:
  • platform/graphics/cairo/BackingStoreBackendCairoImpl.h:
  • platform/graphics/cairo/PlatformContextCairo.h:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/nicosia/NicosiaBuffer.h:
  • platform/graphics/nicosia/NicosiaPaintingEngine.h:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperAnimation.h:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperFPSCounter.h:
  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer): Deleted.
(WebCore::TextureMapperLayer::setID): Deleted.
(WebCore::TextureMapperLayer::id): Deleted.
(WebCore::TextureMapperLayer:: const): Deleted.
(WebCore::TextureMapperLayer::setScrollClient): Deleted.
(WebCore::TextureMapperLayer::setIsScrollable): Deleted.
(WebCore::TextureMapperLayer::isScrollable const): Deleted.
(WebCore::TextureMapperLayer::textureMapper const): Deleted.
(WebCore::TextureMapperLayer::setTextureMapper): Deleted.
(WebCore::TextureMapperLayer::drawsContent const): Deleted.
(WebCore::TextureMapperLayer::contentsAreVisible const): Deleted.
(WebCore::TextureMapperLayer::size const): Deleted.
(WebCore::TextureMapperLayer::opacity const): Deleted.
(WebCore::TextureMapperLayer::transform const): Deleted.
(WebCore::TextureMapperLayer::hasFilters const): Deleted.
(WebCore::TextureMapperLayer::isShowingRepaintCounter const): Deleted.
(WebCore::TextureMapperLayer::fixedToViewport const): Deleted.
(WebCore::TextureMapperLayer::rootLayer const): Deleted.
(WebCore::TextureMapperLayer::texture): Deleted.
(WebCore::TextureMapperLayer::adjustedPosition const): Deleted.
(WebCore::TextureMapperLayer::layerRect const): Deleted.
(WebCore::TextureMapperLayer::State::State): Deleted.

  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
  • platform/graphics/texmap/TextureMapperTile.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(WebCore::CoordinatedGraphicsLayer::isScrollable const): Deleted.
(WebCore::CoordinatedGraphicsLayer::id const): Deleted.
(WebCore::CoordinatedGraphicsLayer::coverRect const): Deleted.
(WebCore::CoordinatedGraphicsLayer::fixedToViewport const): Deleted.

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:

(WebCore::CoordinatedImageBacking::id const): Deleted.

  • platform/graphics/texmap/coordinated/TiledBackingStore.h:
  • platform/graphics/texmap/coordinated/UpdateAtlas.h:
  • platform/network/AuthenticationChallengeBase.h:
  • platform/network/CredentialBase.h:
  • platform/network/ProtectionSpaceBase.h:
  • platform/network/curl/SocketStreamHandleImpl.h:
  • replay/UserInputBridge.h:
1:15 PM Changeset in webkit [226656] by commit-queue@webkit.org
  • 4 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

[Curl] Move FormData related tasks into new CurlFormDataStream class.
​https://bugs.webkit.org/show_bug.cgi?id=181106

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-09
Reviewed by Alex Christensen.

No new tests because no behavior change.

  • platform/Curl.cmake:
  • platform/network/curl/CurlFormDataStream.cpp: Added.

(WebCore::CurlFormDataStream::CurlFormDataStream):
(WebCore::CurlFormDataStream::~CurlFormDataStream):
(WebCore::CurlFormDataStream::clean):
(WebCore::CurlFormDataStream::shouldUseChunkTransfer):
(WebCore::CurlFormDataStream::totalSize):
(WebCore::CurlFormDataStream::computeContentLength):
(WebCore::CurlFormDataStream::read):
(WebCore::CurlFormDataStream::readFromFile):
(WebCore::CurlFormDataStream::readFromData):

  • platform/network/curl/CurlFormDataStream.h: Renamed from Source/WebCore/platform/network/curl/FormDataStreamCurl.h.

(WebCore::CurlFormDataStream::elementSize):
(WebCore::CurlFormDataStream::totalReadSize):

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::CurlRequest):
(WebCore::CurlRequest::willSendData):
(WebCore::CurlRequest::finalizeTransfer):
(WebCore::CurlRequest::setupPUT):
(WebCore::CurlRequest::setupPOST):
(WebCore::CurlRequest::setupSendData):
(WebCore::CurlRequest::resolveBlobReferences): Deleted.
(WebCore::CurlRequest::setupFormData): Deleted.

  • platform/network/curl/CurlRequest.h:
  • platform/network/curl/FormDataStreamCurl.cpp: Removed.
1:13 PM Changeset in webkit [226655] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable
​https://bugs.webkit.org/show_bug.cgi?id=181409

Reviewed by Keith Miller.

When I was looking at profiler data for Speedometer, I noticed that one of
the hottest functions in Speedometer is around 1100 bytecode operations long.
Only about 100 of those bytecode ops ever execute. However, we ended up
spending a lot of time compiling basic blocks that never executed. We often
plant ForceOSRExit nodes when we parse bytecodes that have a null value profile.
This is the case when such a node never executes.

This patch makes it so that anytime a block has a ForceOSRExit, we replace its
terminal node with an Unreachable node (and remove all nodes after the
ForceOSRExit). This will cut down on graph size when such a block dominates
other blocks in the CFG. This allows us to get rid of huge chunks of the CFG
in certain programs. When doing this transformation, we also insert
Flushes/PhantomLocals to ensure we can recover values that are bytecode
live-in to the ForceOSRExit.

Using ForceOSRExit as the signal for this is a bit of a hack. It definitely
does not get rid of all the CFG that it could. If we decide it's worth
it, we could use additional inputs into this mechanism. For example, we could
profile if a basic block ever executes inside the LLInt/Baseline, and
remove parts of the CFG based on that.

When running Speedometer with the concurrent JIT turned off, this patch
improves DFG/FTL compile times by around 5%.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parse):

12:15 PM Changeset in webkit [226654] by Alan Bujtas
  • 7 edits
    2 adds in trunk/Source/WebCore

[RenderTreeBuilder] Move MathML addChild logic to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=181443
<rdar://problem/36380228>

Reviewed by Antti Koivisto.

This is about moving code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::createMathMLOperator): Deleted.
(WebCore::RenderMathMLFenced::makeFences): Deleted.

  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::insertChildToRenderMathMLFenced):

  • rendering/updating/RenderTreeBuilder.h:

(WebCore::RenderTreeBuilder::mathMLBuilder):

11:27 AM Changeset in webkit [226653] by Antti Koivisto
  • 3 edits
    3 adds in trunk

Blank page except for inner iframes because pending stylesheets cause style.isNotFinal() to be true
​https://bugs.webkit.org/show_bug.cgi?id=180940
<rdar://problem/36116507>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/local/loading-stylesheet-import-remove.html

If a <link> referencing a stylesheet containing an @import that was still loading was removed
from the document, the loading state was never cleared. For head stylesheets this blocked
rendering permanently.

Test reduction by Justin Ridgewell.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::removedFromAncestor):

Test if the stylesheet it loading before clearing the pointer.

LayoutTests:

  • http/tests/local/loading-stylesheet-import-remove.html: Added.
  • http/tests/local/loading-stylesheet-import-remove-expected.html: Added.
  • http/tests/local/resources/slow-import.css: Added.
11:14 AM Changeset in webkit [226652] by ddkilzer@apple.com
  • 4 edits in trunk/Tools

[webkitpy] PlatformInfo should have default argument for casual use
​https://bugs.webkit.org/show_bug.cgi?id=180827

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-09
Reviewed by David Kilzer.

PlatformInfo should be the only way to check platform specific thing instead
of sys.platform or other various checks. If there is something you want to check,
it should be placed in PlatformInfo.

Currently to instantiate PlatformInfo, it requires arguments, which is usually
sys, platform and Executive(). They are straight forward and should be handled
by default arguments. Then we can instantiate PlatformInfo more casual.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo): Use relative module path import
(PlatformInfo.init):
(PlatformInfo.executive): Lazy instantiation of Executive()
(PlatformInfo.total_bytes_memory): Accessing via above property
(PlatformInfo.xcode_sdk_version): Ditto
(PlatformInfo.xcode_simctl_list): Ditto
(PlatformInfo.xcode_version): Ditto
(PlatformInfo._win_version_str): Ditto

  • Scripts/webkitpy/common/system/systemhost.py:

(SystemHost.init):

  • Scripts/webkitpy/common/system/user.py:

(User.init):

11:10 AM Changeset in webkit [226651] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

Make imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html robust to quota error
​https://bugs.webkit.org/show_bug.cgi?id=181404

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-09
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Ensure fetch event promise is resolved in case cache is used.
Ensure each cache entry is deleted to not hit any cache quota error.
Test was previously deleting the whole cache, but in WebKit, the quota
in such a case will only be updated when the cache is garbaged collected, which is not deterministic.
Make tests output more results to improve debugability.

  • web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html:
  • web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html:
  • web-platform-tests/service-workers/service-worker/resources/fetch-canvas-tainting-iframe.html:

LayoutTests:

10:49 AM Changeset in webkit [226650] by mark.lam@apple.com
  • 5 edits
    1 add in trunk

ASSERTION FAILED: pair.second->m_type & PropertyNode::Getter
​https://bugs.webkit.org/show_bug.cgi?id=181388
<rdar://problem/36349351>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-181388.js: Added.

Source/JavaScriptCore:

When there are duplicate setters or getters, we may end up overwriting a getter
with a setter, or vice versa. This patch adds tracking for getters/setters that
have been overwritten with duplicates and ignore them.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):

  • parser/Nodes.h:

(JSC::PropertyNode::isOverriddenByDuplicate const):
(JSC::PropertyNode::setIsOverriddenByDuplicate):

10:35 AM Changeset in webkit [226649] by mitz@apple.com
  • 8 copies
    1 add in releases/Apple/iOS 11.2.2

Added a tag for iOS 11.2.2.

10:32 AM Changeset in webkit [226648] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari 11.0.2 (v. 11604.4.7.1.6 & 12604.4.7.1.6)

Added a tag for Safari 11.0.2 (v. 11604.4.7.1.6 & 12604.4.7.1.6)

10:29 AM Changeset in webkit [226647] by mitz@apple.com
  • 3 edits
    8 deletes in trunk/Source

Removed some empty directories that were left behind

Source/ThirdParty/ANGLE:

  • src/third_party/murmurhash: Removed.
  • third_party: Removed.
  • third_party/deqp: Removed.

Source/WebCore:

  • Modules/indieui: Removed.
  • Modules/vibration: Removed.
  • platform/graphics/ca/mac: Removed.
  • platform/mediastream/gstreamer: Removed.

Source/WebKit:

  • WebProcess/Cookies/cf: Removed.
  • WebProcess/ios: Removed.
10:24 AM Changeset in webkit [226646] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[iOS Debug WK2] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=181087
<rdar://problem/36188109>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-09
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Updated test to get a more deterministic output.

  • web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html:

LayoutTests:

  • platform/ios-wk2/TestExpectations: Removed flaky expectation.
9:55 AM Changeset in webkit [226645] by graouts@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactor timing function solving code
​https://bugs.webkit.org/show_bug.cgi?id=181428

Reviewed by Dean Jackson.

We have duplicated code to solve "cubic" and "steps" timing functions in AnimationBase and TextureMapperAnimation,
and we will soon need similar code to deal with timing functions in Web Animations. We move this code into TimingFunction
with a single transformTime() function that can be called directly on the timing function rather than having callers
figure out what type timing functions are to solve them.

No test as there shouldn't be any behavior change.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress const):
(WebCore::solveEpsilon): Deleted.
(WebCore::solveCubicBezierFunction): Deleted.
(WebCore::solveStepsFunction): Deleted.
(WebCore::solveSpringFunction): Deleted.

  • platform/animation/TimingFunction.cpp:

(WebCore::TimingFunction::transformTime const):

  • platform/animation/TimingFunction.h:
  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimation::apply):
(WebCore::solveEpsilon): Deleted.
(WebCore::solveCubicBezierFunction): Deleted.
(WebCore::solveStepsFunction): Deleted.
(WebCore::applyTimingFunction): Deleted.

9:54 AM Changeset in webkit [226644] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit

Don't record dynamic spelling corrections while in an ephemeral browsing session
​https://bugs.webkit.org/show_bug.cgi?id=181417
<rdar://problem/33309104>

Dynamic spelling correction responses are kept on disk. Avoid recording
these responses when in an ephemeral session.

Reviewed by Tim Horton and Wenson Hsieh.

  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::recordAutocorrectionResponse):

Add a WebViewImpl parameter so we can query the current session.
Return early before recording the response if the session is
ephemeral.

(WebKit::CorrectionPanel::handleAcceptedReplacement):

Update a caller to include the new parameter.

  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::recordAutocorrectionResponse):

Ditto.

9:20 AM Changeset in webkit [226643] by jmarcell@apple.com
  • 42 edits in tags/Safari-605.1.20

Revert r226432. rdar://problem/10353542

9:20 AM Changeset in webkit [226642] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.20/Tools

Revert r226441. rdar://problem/10353542

9:20 AM Changeset in webkit [226641] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.20/Tools

Revert r226450. rdar://problem/10353542

9:13 AM Changeset in webkit [226640] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, silence -Wunused-parameter warning

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::setupNewlyCreatedServiceWorker):

8:50 AM Changeset in webkit [226639] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk/LayoutTests

[EME] Add layout test for clearKey CENC message event
​https://bugs.webkit.org/show_bug.cgi?id=180928

Patch by Yacine Bandou <​yacine.bandou_ext@softathome.com> on 2018-01-09
Reviewed by Xabier Rodriguez-Calvar.

Tests the reception of clearKey message event after the encrypted event and checks its KeyID.
There are two tests: one with MSE playback and another with regular playback.

  • media/encrypted-media/clearKey/clearKey-message-cenc-event-expected.txt: Added.
  • media/encrypted-media/clearKey/clearKey-message-cenc-event-mse-expected.txt: Added.
  • media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html: Added.

Test with MSE playback.

  • media/encrypted-media/clearKey/clearKey-message-cenc-event.html: Added.

Test with regular playback.

  • media/encrypted-media/clearKey/encrypted-media-clearKey-handler.js: Added.

This JavaScript file provides a simple clearKey EME implementation, checks the EME support, handles the "encrypted", "message" and
"keystatuseschange" events, and updates the CDM session with the right keys.
This implementation allows to play an encrypted media (video or audio or both), it is used in this test by overloading the "onMessage" callback
by an other function that checks the 'message' event and stops the test.

  • media/encrypted-media/medias-enc.js:

I take this opportunity to introduce some fixes:
Rename "mimetype" field to "mimeType", this field is only used in "clearKey-encrypted-cenc-event-mse.html",
thus it is easy to change it now.
Change the KeyID of the encrypted video with the right value, it is used for first time in this test.

  • media/media-source/media-source-loader-simple.js:

Use "mimeType" instead of "mimetype" as it is modified in "medias-enc.js".

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wpe/TestExpectations:
8:45 AM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
8:44 AM Changeset in webkit [226638] by commit-queue@webkit.org
  • 5 edits in trunk

Check Image::m_image is not null in ImageLoader::decode()
​https://bugs.webkit.org/show_bug.cgi?id=180386
<rdar://problem/34634483>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-01-09
Reviewed by Tim Horton.

Source/WebCore:

Ensure ImageLoader::m_image is not null before referencing it.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::decode):

LayoutTests:

Add a new rejected case for decoding an image with an invalid URL.

  • fast/images/decode-static-image-reject-expected.txt:
  • fast/images/decode-static-image-reject.html:
8:44 AM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
8:30 AM Changeset in webkit [226637] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.19.5

WebKitGTK+ 2.19.5

8:29 AM Changeset in webkit [226636] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.19.5.
8:23 AM Changeset in webkit [226635] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebCore

[FreeType] Use FastMalloc for FreeType
​https://bugs.webkit.org/show_bug.cgi?id=181387

Reviewed by Michael Catanzaro.

Add custom memory allocator for FreeType to use FastMalloc.

  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::initializeFreeTypeLibrary):
(WebCore::createFontCustomPlatformData):

8:15 AM Changeset in webkit [226634] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[RenderTreeBuilder] Move RenderTable* addChild mutation logic to RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=181424
<rdar://problem/36368628>

Reviewed by Antti Koivisto.

This is about moving code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

Covered by existing tests.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::insertChildToRenderTable):
(WebCore::RenderTreeBuilder::insertChildToRenderTableSection):
(WebCore::RenderTreeBuilder::insertChildToRenderTableRow):

  • rendering/updating/RenderTreeBuilder.h:
  • rendering/updating/RenderTreeBuilderTable.cpp:

(WebCore::RenderTreeBuilder::Table::insertChild):

  • rendering/updating/RenderTreeBuilderTable.h:
7:53 AM Changeset in webkit [226633] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit

[GTK] Missing symbols exported in 2.19.4
​https://bugs.webkit.org/show_bug.cgi?id=181433

Reviewed by Michael Catanzaro.

Add missing WEBKIT_API to webkit_dom_dom_window_webkit_message_handlers_post_message().

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.h:
  • webkitglib-symbols.map: Remove webkit_media_player_debug from local.
7:22 AM Changeset in webkit [226632] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[RenderTreeBuilder] Transition Render*::addChild() calls to RenderTreeBuilder::insertChildToRender*()
​https://bugs.webkit.org/show_bug.cgi?id=181407
<rdar://problem/36361176>

Reviewed by Antti Koivisto.

Eventually all mutation will be going through the RenderTreeBuilder.

No change in functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::addChild):

  • rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::rubyBaseSafe):

  • rendering/updating/RenderTreeBuilderBlockFlow.cpp:

(WebCore::RenderTreeBuilder::BlockFlow::insertChild):

  • rendering/updating/RenderTreeBuilderMultiColumn.cpp:

(WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow):

  • rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForChild):

7:05 AM Changeset in webkit [226631] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=181436

Patch by Ali Juma <​ajuma@chromium.org> on 2018-01-09
Reviewed by Frédéric Wang.

Test gardening.

Mark test that seems to have timing issues as flaky.

6:43 AM Changeset in webkit [226630] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Ensure SleepDisabler is not held by pages in page cache
​https://bugs.webkit.org/show_bug.cgi?id=180197

Reviewed by Eric Carlson.

The sleep disabler is now checked again whenever the media player
playback state or other characteristic has changed in the media
engine.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
Check if the sleep disabler state needs to be updated or not.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
(WebCore::HTMLMediaElement::shouldDisableSleep const): Enable
sleep disabler for GTK and WPE ports.

5:59 AM Changeset in webkit [226629] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GStreamer] Missing notifications to player client
​https://bugs.webkit.org/show_bug.cgi?id=181432

Reviewed by Carlos Garcia Campos.

We now properly emit playback state changes and characteristic
updates to the client when the pipeline state changes and when
audio/video tracks changes are detected.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
This debug message appears too often in logs. Demote.
(WebCore::MediaPlayerPrivateGStreamer::durationMediaTime const): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Emit
charasteristicChanged notification.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Keep track
of old and current pipeline state.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
5:57 AM Changeset in webkit [226628] by commit-queue@webkit.org
  • 24 edits in trunk

Add CSP support to service workers
​https://bugs.webkit.org/show_bug.cgi?id=181385

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-09
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Added recovery of CSP information from WorkerScriptLoader.
Added plumbing to pass the CSP information to Service Workers.
Did not add persistency support for the CSP information as this requires changing the SQL database schema.
This will be done in a follow-up.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::didReceiveResponse):

  • workers/WorkerScriptLoader.h:

(WebCore::WorkerScriptLoader::contentSecurityPolicy const):

  • workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):

  • workers/service/SWClientConnection.h:
  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

  • workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

  • workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

  • workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::create):

  • workers/service/ServiceWorkerGlobalScope.h:
  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::notifyFinished):

  • workers/service/ServiceWorkerJobClient.h:
  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::v1RecordsTableSchema):
(WebCore::RegistrationDatabase::importRecords):

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::updateWorker):
(WebCore::SWServer::installContextData):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):

  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):
(WebCore::m_contentSecurityPolicy):
(WebCore::SWServerWorker::contextData const):

  • workers/service/server/SWServerWorker.h:
5:11 AM Changeset in webkit [226627] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Provide a method to obtain a CSS value from a RenderStyle by CSSPropertyID
​https://bugs.webkit.org/show_bug.cgi?id=181429

Patch by Antoine Quint <Antoine Quint> on 2018-01-09
Reviewed by Antti Koivisto.

The KeyframeEffect.getKeyframes() method from Web Animations requires that we return all styles applied at a given
animation effect keyframe. When we parse keyframes, we create RenderStyle objects that are stored in a KeyframeList,
as well as a list of CSSPropertyIDs that are animated. In order to provide the list of animated properties and their
values when calling getKeyframes(), we need to be able to read back from the RenderStyle we create. As a first step
towards this goal, we factor some code in ComputedStyleExtractor::propertyValue() out into a new method
ComputedStyleExtractor::valueForPropertyinStyle() which takes in an explicit RenderStyle.

No test as this is simply refactoring that doesn't change or add behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSComputedStyleDeclaration.h:
4:48 AM Changeset in webkit [226626] by commit-queue@webkit.org
  • 12 edits in trunk/Source

SWClientConnection should not keep references to service worker jobs
​https://bugs.webkit.org/show_bug.cgi?id=181381

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-09
Reviewed by Chris Dumez.

Source/WebCore:

Difficult to test determiniscally but corresponding crash log should no longer happen in debug builds.

Stopped passing ServiceWorkerJob references from ServiceWorkerContainer (potentially in service worker thread) to SWClientConnection (main thread).
Instead pass job identifiers and related data to the main thread.

Minor refactoring to use ServiceWorkerJobIdentifier instead of ServiceWorkerJobDataIdentifier which contains more data than needed.

  • workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::postTaskForJob):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::clearPendingJobs):
(WebCore::SWClientConnection::finishedFetchingScript): Deleted.

  • workers/service/SWClientConnection.h:
  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::resolveUnregistrationJob):
(WebCore::SWServer::startScriptFetch):

  • workers/service/server/SWServer.h:

Source/WebKit:

Updated IPC handling based on WebCore refactoring.

  • Scripts/webkit/messages.py:

(forward_declarations_and_headers):
(headers_for_type):

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • WebProcess/Storage/WebSWClientConnection.messages.in:
3:56 AM Changeset in webkit [226625] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.19.4

WebKitGTK+ 2.19.4

3:55 AM Changeset in webkit [226624] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.19.4.
2:57 AM Changeset in webkit [226623] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

REGRESSION(r224460): Text fields sometimes get "messed up"
​https://bugs.webkit.org/show_bug.cgi?id=181115

Reviewed by Zalan Bujtas.

Add the scroll position to paint offset before computing the clip rectangle. Before r224460, scroll position was
substracted after the clip rectangle was computed.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::computeClipRect):

2:53 AM Changeset in webkit [226622] by commit-queue@webkit.org
  • 16 edits
    6 adds in trunk

Implement VisualViewport API events
​https://bugs.webkit.org/show_bug.cgi?id=179386

Patch by Ali Juma <​ajuma@chromium.org> on 2018-01-09
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectation for a viewport WPT that now passes.

  • web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt:

Source/WebCore:

Implement the events (resize and scroll) defined by the Visual Viewport API
(​https://wicg.github.io/visual-viewport/#events).

This is behind the VisualViewportAPI experimental feature flag.

In order to detect when events need to be fired, change the computation of
Visual Viewport attributes to happen whenever the layout viewport is updated
rather than only on-demand.

Tests: fast/visual-viewport/resize-event-fired-window-resized.html

fast/visual-viewport/resize-event-fired.html
fast/visual-viewport/scroll-event-fired.html

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded):
Add support for tracking resize event listeners.

  • dom/Document.h:
  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::enqueueScrollEvent):
Factored out of enqueueOrDispatchScrollEvent so that this logic can be reused
for Visual Viewport scroll events.
(WebCore::DocumentEventQueue::enqueueResizeEvent):
(WebCore::DocumentEventQueue::pendingEventTimerFired):

  • dom/DocumentEventQueue.h:
  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutViewport):

  • page/VisualViewport.cpp:

(WebCore::VisualViewport::addEventListener):
(WebCore::layoutIfNonNull):
(WebCore::VisualViewport::offsetLeft const):
Remove attribute computation logic since this now happens during update().
(WebCore::VisualViewport::offsetTop const): Ditto.
(WebCore::VisualViewport::pageLeft const): Ditto.
(WebCore::VisualViewport::pageTop const): Ditto.
(WebCore::VisualViewport::width const): Ditto.
(WebCore::VisualViewport::height const): Ditto.
(WebCore::VisualViewport::scale const):
(WebCore::VisualViewport::update):
Added. Computes all of the Visual Viewport attributes and determines
whether events need to be fired.
(WebCore::VisualViewport::enqueueResizeEvent):
(WebCore::VisualViewport::enqueueScrollEvent):
(WebCore::getFrameViewAndLayoutIfNonNull): Deleted.

  • page/VisualViewport.h:

Source/WebKit:

Change the default value of the VisualViewportAPI experimental feature flag to
DEFAULT_EXPERIMENTAL_FEATURES_ENABLED. This patch completes the implementation
of this feature as specified by ​https://wicg.github.io/visual-viewport/, so this
feature is now ready for wider testing.

  • Shared/WebPreferences.yaml:

LayoutTests:

Add tests for Visual Viewport API events. Test that a resize event is fired after
pinch zoom and after window resize, and test that a scroll event is fired when the
visual viewport is scrolled.

  • fast/visual-viewport/resize-event-fired-expected.txt: Added.
  • fast/visual-viewport/resize-event-fired-window-resized-expected.txt: Added.
  • fast/visual-viewport/resize-event-fired-window-resized.html: Added.
  • fast/visual-viewport/resize-event-fired.html: Added.
  • fast/visual-viewport/scroll-event-fired-expected.txt: Added.
  • fast/visual-viewport/scroll-event-fired.html: Added.
  • platform/gtk/TestExpectations:

Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK.

  • platform/ios/TestExpectations:

Skipped test that resizes a window, since this isn't supported on iOS.

  • platform/win/TestExpectations:

Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on Windows.

2:02 AM Changeset in webkit [226621] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EME] Add the CENC initData support in ClearKey CDM
​https://bugs.webkit.org/show_bug.cgi?id=180081

Patch by Yacine Bandou <​yacine.bandou_ext@softathome.com> on 2018-01-09
Reviewed by Xabier Rodriguez-Calvar.

Add the "cenc" initDataType support in ClearKey CDM.
Parse the CENC initData and extract the KIDs by following the W3C spec
​https://www.w3.org/TR/eme-initdata-cenc/#common-system

Tests: media/encrypted-media/clearKey/clearKey-message-cenc-event.html

media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html

  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::extractKeyidsLocationFromCencInitData):
(WebCore::isCencInitData):
(WebCore::extractKeyidsFromCencInitData):
(WebCore::CDMPrivateClearKey::supportsInitDataType const):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMInstanceClearKey::requestLicense):

1:52 AM Changeset in webkit [226620] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[Cairo] Pass state values directly to Cairo operations
​https://bugs.webkit.org/show_bug.cgi?id=181389

Reviewed by Carlos Garcia Campos.

Instead of passing reference to the GraphicsContextState object to
various Cairo operations, only pass the required state values. This
makes it explicit what state values are used in these operations, at the
expense of some long parameter lists, but this will be better addressed
by future refactoring of this code into more concise functions.

No new tests -- no change in functionality.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::dashedLineCornerWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternWidthForStrokeWidth):
(WebCore::Cairo::drawGlyphs):
(WebCore::Cairo::drawRect):
(WebCore::Cairo::drawLine):
(WebCore::Cairo::drawEllipse):

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::FontCascade::drawGlyphs):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):

1:29 AM Changeset in webkit [226619] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
​https://bugs.webkit.org/show_bug.cgi?id=176443

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2018-01-09
Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

1:05 AM Changeset in webkit [226618] by fred.wang@free.fr
  • 3 edits in trunk/Tools

check-webkit-style: Verify syntax for WK_API_AVAILABLE
​https://bugs.webkit.org/show_bug.cgi?id=181394

Patch by Frederic Wang <​fwang@igalia.com.fr> on 2018-01-09
Reviewed by Darin Adler.

A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
as the second parameter instead of ios(WK_IOS_TBA). This generally
builds for iOS on EWS but not when using the public SDK. See r224057,
r223207 and r226211 for example. This patch adds a basic style check
for that macro to prevent this kind of mistake.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
(check_style): Run new style check.
(CppChecker): Add build type for the new style check.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.

12:34 AM Changeset in webkit [226617] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

Release assert in addResourceTiming when a cache resource is requested during style recalc
​https://bugs.webkit.org/show_bug.cgi?id=181137
<rdar://problem/35666574>

Reviewed by Simon Fraser.

Source/WebCore:

Make the dispatching of resourcetimingbufferfull event asynchronous to avoid dispatching it
synchronously during a style resolution when CachedResourceLoader::requestImage requests
a previously loaded image.

We now schedule a timer when the resource timing buffer becomes full, and dispatch the event
when the timer fires. Meanwhile, we have a backup buffer to which additional resource timing
entries would be added. Once the event is dispatched, we refill the buffer exposed to author
scripts. When refilling the buffer results in it becoming full again, we keep repeating the
process of firing resourcetimingbufferfull and re-filling the buffer until either we stop
making progress (i.e. the script didn't increase the number of empty entires in the buffer)
or the backup buffer (at the time we started this process) becomes empty.

Also fixed a bug that we were firing resourcetimingbufferfull event when the last entry that
fits within the buffer size was added instead of when an entry is being added to an already
full buffer. To make this work, the patch introduces m_resourceTimingBufferFullFlag,
representing the concept "resource timing buffer full" flag in the resource timing specification.

Test: http/tests/performance/performance-resource-timing-resourcetimingbufferfull-crash.html

  • page/Performance.cpp:

(WebCore::Performance::Performance):
(WebCore::Performance::clearResourceTimings):
(WebCore::Performance::setResourceTimingBufferSize):
(WebCore::Performance::addResourceTiming):
(WebCore::Performance::resourceTimingBufferFullTimerFired):

  • page/Performance.h:

LayoutTests:

Added a regression test for the crash.

Also fixed test cases in rt-performance-extensions.js which were incorrectly asserting and assuming that
resourcetimingbufferfull event will be fired when there are exactly the same number of entries as the buffer size.

  • http/tests/performance/performance-resource-timing-resourcetimingbufferfull -crash-expected.txt: Added.
  • http/tests/performance/performance-resource-timing-resourcetimingbufferfull-crash.html: Added.
  • http/wpt/resource-timing/rt-performance-extensions.js: Fixed the test cases.
Note: See TracTimeline for information about the timeline view.