⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 19, 2018:

11:45 PM Changeset in webkit [227267] by Carlos Garcia Campos
  • 2 edits in trunk/WebDriverTests

Unreviewed GTK+ gardening. Skip imported/w3c/webdriver/tests/sessions/new_session/response.py.

It's causing a crash in the driver process and affecting all other tests.

11:24 PM Changeset in webkit [227266] by Wenson Hsieh
  • 3 edits in trunk/Source/WebCore

[macOS] [WK2] Drag location is computed incorrectly when dragging content from subframes
​https://bugs.webkit.org/show_bug.cgi?id=181896
<rdar://problem/35479043>

Reviewed by Tim Horton.

In r218837, I packaged most of the information needed to start a drag into DragItem, which is propagated to the client layer
via the startDrag codepath. However, this introduced a bug in computing the event position and drag location in window
coordinates. Consider the case where we're determining the drag image offset for a dragged element in a subframe:

Before the patch, the drag location (which starts out in the subframe's content coordinates) would be converted to root view
coordinates, which would then be converted to mainframe content coordinates, which would then be converted to window coordinates
using the mainframe's view. After the patch, we carry out the same math until the last step, where we erroneously use the
_subframe's_ view to convert to window coordinates from content coordinates. This results in the position of the iframe relative
to the mainframe being accounted for twice.

To fix this, we simply use the main frame's view to convert from mainframe content coordinates to window coordinates while
computing the drag location. As for the event position in window coordinates, this is currently unused by any codepath in WebKit,
so we can just remove it altogether.

Since this bug only affects drag and drop in the macOS WebKit2 port, there's currently no way to test this. I'll be using
<​https://bugs.webkit.org/show_bug.cgi?id=181898> to track adding test support for drag and drop on macOS WebKit2. Manually tested
dragging in both WebKit1 and WebKit2 on macOS. dragLocationInWindowCoordinates isn't used at all for iOS drag and drop.

  • page/DragController.cpp:

(WebCore::DragController::doSystemDrag):

  • platform/DragItem.h:

(WebCore::DragItem::encode const):
(WebCore::DragItem::decode):

10:40 PM Changeset in webkit [227265] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Expose Safe Browsing SPI
​https://bugs.webkit.org/show_bug.cgi?id=181804
<rdar://problem/36626946>

Patch by Zach Li <​zacharyli323@gmail.com> on 2018-01-19
Reviewed by Dan Bernstein.

If client is using Apple internal SDK, then we can just import the header; if not,
then we declare necessary symbols that client will need.

  • Configurations/WebKit.xcconfig:

Only link against SafariSafeBrowsing framework on macOS High Sierra
and iOS 11 and above. Weak link against SafariSafeBrowsing framework
because it is not present on the Base system.

  • Platform/spi/Cocoa/SafeBrowsingSPI.h: Added.
  • WebKit.xcodeproj/project.pbxproj:

Added SafeBrowsingSPI.h.

  • WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd:

Added.

8:34 PM Changeset in webkit [227264] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181901

Unreviewed test gardening.

8:21 PM Changeset in webkit [227263] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181900

Unreviewed test gardening.

8:05 PM Changeset in webkit [227262] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181897

Unreviewed test gardening.

7:55 PM Changeset in webkit [227261] by Ryan Haddad
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r227235.

The test for this change consistently times out on High
Sierra.

Reverted changeset:

"Support for preconnect Link headers"
​https://bugs.webkit.org/show_bug.cgi?id=181657
​https://trac.webkit.org/changeset/227235

7:50 PM Changeset in webkit [227260] by Ryan Haddad
  • 4 edits
    2 adds in trunk/LayoutTests

[Sierra Debug WK2] ASSERTION FAILED: paymentCoordinator().supportsVersion(version)
​https://bugs.webkit.org/show_bug.cgi?id=181833

Patch by Andy Estes <​aestes@apple.com> on 2018-01-19
Reviewed by Youenn Fablet.

Moved the version 3 test into its own file that only runs on High Sierra and later.

  • http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html: Added.
  • platform/mac-wk2/TestExpectations:
6:29 PM Changeset in webkit [227259] by jmarcell@apple.com
  • 12 edits in branches/safari-605-branch/Source

Apply patch. rdar://problem/36654954

Update OS Version-based conditionals.
<rdar://problem/36654954>

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • editing/cocoa/HTMLConverter.mm: (_WebMessageDocumentClass):
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:
  • platform/mac/EventLoopMac.mm: (WebCore::EventLoop::cycle):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • Platform/IPC/mac/ConnectionMac.mm: (IPC::AccessibilityProcessSuspendedNotification):
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::shouldLeakBoost):
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataForPreviewItemController:atPosition:type:]):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeProcess):

Source/WTF:

  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
  • wtf/spi/cocoa/NSMapTableSPI.h:
6:24 PM Changeset in webkit [227258] by lingcherd_ho@apple.com
  • 4 edits in trunk/Tools

Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=181881

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.

5:58 PM Changeset in webkit [227257] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix, removed unused lambda capture.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):

5:57 PM Changeset in webkit [227256] by jmarcell@apple.com
  • 12 edits in tags/Safari-605.1.24.2/Source

Apply patch. rdar://problem/36654954

Update OS Version-based conditionals.
<rdar://problem/36654954>

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • editing/cocoa/HTMLConverter.mm: (_WebMessageDocumentClass):
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:
  • platform/mac/EventLoopMac.mm: (WebCore::EventLoop::cycle):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • Platform/IPC/mac/ConnectionMac.mm: (IPC::AccessibilityProcessSuspendedNotification):
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::shouldLeakBoost):
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataForPreviewItemController:atPosition:type:]):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeProcess):

Source/WTF:

  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
  • wtf/spi/cocoa/NSMapTableSPI.h:
5:50 PM Changeset in webkit [227255] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/wpt/web-animations/timing-model/animation-effects/current-iteration.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181888

Unreviewed test gardening.

5:47 PM Changeset in webkit [227254] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.24.2/Source

Versioning.

5:40 PM Changeset in webkit [227253] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.24.2

New tag.

5:13 PM Changeset in webkit [227252] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.24.1/Source

Versioning.

4:58 PM Changeset in webkit [227251] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.24.1

New tag.

4:16 PM Changeset in webkit [227250] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for webrtc/video-mute.html.
​https://bugs.webkit.org/show_bug.cgi?id=177501

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:16 PM Changeset in webkit [227249] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-* tests as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181565

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:10 PM Changeset in webkit [227248] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Remove unused calls to WebResourceLoadStatisticsStore:logTestingEvent() to fix API test
​https://bugs.webkit.org/show_bug.cgi?id=181890
<rdar://problem/36674772>

Unreviewed API test fix.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):

3:37 PM Changeset in webkit [227247] by Megan Gardner
  • 4 edits in branches/safari-605-branch/Source/WebKit

Present WKFileUploadPanel on correct ViewController
​https://bugs.webkit.org/show_bug.cgi?id=181884
<rdar://problem/35114892>

Reviewed by Tim Horton and Joseph Pecoraro

We should not be getting the main view controller directly, as done in
ValidationBubbleIOS. This will keep us from presenting on view controllers are
in the midst of being dismissed, etc, causing us to get into states where we lose
the ability to present the WKFileUploadPanel.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView viewControllerForPresentingFileUploadPanel:]):

  • UIProcess/ios/forms/WKFileUploadPanel.h:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(fallbackViewController):
(-[WKFileUploadPanel _presentFullscreenViewController:animated:]):

3:35 PM Changeset in webkit [227246] by Ryan Haddad
  • 2 edits in trunk/JSTests

Disable Atomics when SharedArrayBuffer isn’t enabled
​https://bugs.webkit.org/show_bug.cgi?id=181572

Unreviewed test gardening.

  • test262.yaml: Skip tests that fail after this change.
3:26 PM Changeset in webkit [227245] by commit-queue@webkit.org
  • 7 edits in trunk

Cache storage errors like Quota should trigger console messages
​https://bugs.webkit.org/show_bug.cgi?id=181879
<rdar://problem/36669048>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-19
Reviewed by Chris Dumez.

Source/WebCore:

Covered by rebased test.

  • Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):

  • Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::errorToException):
(WebCore::DOMCacheEngine::logErrorAndConvertToException):

  • Modules/cache/DOMCacheEngine.h:
  • Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):

LayoutTests:

  • http/wpt/cache-storage/cache-quota.any-expected.txt:
3:18 PM Changeset in webkit [227244] by Ross Kirsling
  • 6 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Layers tab should do away with popovers (if possible)
​https://bugs.webkit.org/show_bug.cgi?id=181805

Reviewed by Matt Baker.

  • Localizations/en.lproj/localizedStrings.js:

Remove superfluous colon from a string.

  • UserInterface/Main.html:
  • UserInterface/Views/LayerDetailsSidebarPanel.css:
  • UserInterface/Views/Layers3DContentView.css: Added.

Remove popover styling from sidebar, add new file with similar styling for canvas overlay.

  • UserInterface/Views/LayerDetailsSidebarPanel.js:

(WI.LayerDetailsSidebarPanel):
(WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
(WI.LayerDetailsSidebarPanel.prototype._dataGridSelectedNodeChanged):
(WI.LayerDetailsSidebarPanel.prototype._updateLayers):
(WI.LayerDetailsSidebarPanel.prototype._updateBottomBar):
(WI.LayerDetailsSidebarPanel.prototype.willDismissPopover): Deleted.
(WI.LayerDetailsSidebarPanel.prototype._showPopoverForSelectedNode): Deleted.
(WI.LayerDetailsSidebarPanel.prototype._presentPopover): Deleted.
(WI.LayerDetailsSidebarPanel.prototype._contentForPopover): Deleted.
(WI.LayerDetailsSidebarPanel.prototype._populateListOfCompositingReasons.addReason): Deleted.
(WI.LayerDetailsSidebarPanel.prototype._populateListOfCompositingReasons): Deleted.

  • UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.shown):
(WI.Layers3DContentView.prototype.selectLayerById):
(WI.Layers3DContentView.prototype._canvasMouseDown):
(WI.Layers3DContentView.prototype._buildLayerInfoElement):
(WI.Layers3DContentView.prototype._updateLayerInfoElement):
(WI.Layers3DContentView.prototype._updateReasonsList):
Remove popover from sidebar table, overlay div with same data arrangement on top of the canvas.
Also reverse the fix from r226671 since the visualization is no longer unusable without the sidebar!

3:01 PM Changeset in webkit [227243] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab: Multiple "waiting for frames" messages displayed
​https://bugs.webkit.org/show_bug.cgi?id=181865
<rdar://problem/36664737>

Reviewed by Devin Rousso.

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._recordingStarted):
(WI.CanvasContentView.prototype._recordingStopped):

2:58 PM Changeset in webkit [227242] by commit-queue@webkit.org
  • 18 edits
    1 add in trunk

Do not go to the storage process when registering a service worker client if there is no service worker registered
​https://bugs.webkit.org/show_bug.cgi?id=181740
<rdar://problem/36650400>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-19
Reviewed by Chris Dumez.

Source/WebCore:

Register a document as service worker client only if there is an existing service worker connection.
This allows not creating any connection if no service worker is registered.

Add internals API to test whether a service worker connection was created or not.
This is used by API tests that cover the changes.

  • dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): No need to create a service worker connection if client is not registered yet.
(WebCore::Document::setServiceWorkerConnection): No need to unregister/register if service worker connection is the same.
Similarly, if Document is to be destroyed or suspended, we should not register it.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

  • testing/Internals.cpp:

(WebCore::Internals::hasServiceWorkerConnection):

  • testing/Internals.h:
  • testing/Internals.idl:
  • workers/service/ServiceWorkerProvider.cpp:

(WebCore::ServiceWorkerProvider::registerServiceWorkerClients):

  • workers/service/ServiceWorkerProvider.h:

Source/WebKit:

UIProcess notifies all web processes to register their service worker clients when spinning the service worker process.
Add private API to set the number of web processes for testing purposes.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setMaximumNumberOfProcesses:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::registerServiceWorkerClients):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Add support for internals inside API tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.

(TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
(TestWebKitAPI::InternalsInjectedBundleTest::initialize):
(TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
(TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(setConfigurationInjectedBundlePath):
(-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):

2:53 PM Changeset in webkit [227241] by jmarcell@apple.com
  • 7 edits in tags/Safari-606.1.2.1/Source

Versioning.

2:48 PM Changeset in webkit [227240] by dino@apple.com
  • 14 edits
    1 copy in trunk

REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
​https://bugs.webkit.org/show_bug.cgi?id=181817
<rdar://problem/35274055>

Source/WebCore:

Add a setting for controlling whether touch listeners are passive
by default on document/window/body.

Updated existing test.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):

  • page/Settings.yaml:

Source/WebKit:

Reviewed by Simon Fraser.

Add a linked-on-or-after check to set passive touch listeners on document in WebCore.

  • CMakeLists.txt:
  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.cpp: Copied from Source/WebKit/UIProcess/Cocoa/VersionChecks.h.

(defaultPassiveTouchListenersAsDefaultOnDocument):

  • Shared/WebPreferencesDefaultValues.h:
  • UIProcess/Cocoa/VersionChecks.h:
  • WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

Reviewed by Simon Fraser.

Add a linked-on-or-after check to set passive touch listeners on document in WebCore.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

LayoutTests:

Reviewed by Simon Fraser.

  • fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt:
2:43 PM Changeset in webkit [227239] by jmarcell@apple.com
  • 1 copy in tags/Safari-606.1.2.1

New tag.

2:43 PM Changeset in webkit [227238] by dbates@webkit.org
  • 4 edits
    4 adds in trunk

Update frame-ancestor directive to match Content Security Policy Level 3
​https://bugs.webkit.org/show_bug.cgi?id=178891
<rdar://problem/35209458>

Reviewed by Alex Christensen.

Derived from Blink e667cc2e501fabab3605b838e4ee0d642a9c4a59:
<​https://chromium.googlesource.com/chromium/src.git/+/e667cc2e501fabab3605b838e4ee0d642a9c4a59>

Source/WebCore:

Update frame-ancestor directive to match against the origin of the ancestor document per the
Content Security Policy Level 3 spec.: <​https://w3c.github.io/webappsec-csp/> (15 January 2018).
Specifically this change in behavior was made to CSP 3 in <​https://github.com/w3c/webappsec/issues/311>.
In earlier versions of the spec, the frame-ancestor directive matched against the URL of the
ancestor document.

Disregarding allow-same-origin sandboxed iframes, a document with policy "frame-ancestor 'self'"
will be blocked from loading in a sandboxed iframe as a result of this change.

Tests: http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-allow-same-origin-sandboxed-cross-url-allow.html

http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-sandboxed-cross-url-block.html

  • page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::checkFrameAncestors):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-allow-same-origin-sandboxed-cross-url-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-allow-same-origin-sandboxed-cross-url-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-sandboxed-cross-url-block-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-sandboxed-cross-url-block.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/frame-ancestors-test.js:

(injectNestedIframe):
(window.onload):
(testNestedIFrame):

2:33 PM Changeset in webkit [227237] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Curl] Add timeout support to XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=181876

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-19
Reviewed by Alex Christensen

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::setTimeout):

  • platform/network/curl/CurlContext.h:
  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didCompleteTransfer):

  • platform/network/curl/ResourceError.h:
  • platform/network/curl/ResourceErrorCurl.cpp:

(WebCore::ResourceError::httpError):

2:30 PM Changeset in webkit [227236] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Kill ArithNegate's ArithProfile assert inside BytecodeParser
​https://bugs.webkit.org/show_bug.cgi?id=181877
<rdar://problem/36630552>

Reviewed by Mark Lam.

JSTests:

  • stress/arith-profile-for-negate-can-see-non-number-due-to-dfg-osr-exit-profiling.js: Added.

(runNearStackLimit):
(f1):
(f2):
(f3):
(i.catch):
(i.try.runNearStackLimit):
(catch):

Source/JavaScriptCore:

Before this patch, we used to assert that op_negate's result ArithProfile
only produces number. It's logically true that negate only produces a number.
However, the DFG may incorrectly pick this ArithProfile when doing OSR exit
profiling. So we'll end up profiling something that's likely the input to
negate. This patch removes the assert. We cede to the fact that Graph::methodOfGettingAValueProfileFor
is entirely heuristic based, potentially leading to profiling results being imprecise.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

2:16 PM Changeset in webkit [227235] by yoav@yoav.ws
  • 6 edits
    4 adds in trunk

Support for preconnect Link headers
​https://bugs.webkit.org/show_bug.cgi?id=181657

Reviewed by Darin Adler.

Source/WebCore:

Move the preconnect functionality into its own function, and
also call this function when Link headers are processed.

Test: http/tests/preconnect/link-header-rel-preconnect-http.php

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLinksFromHeader): Call preconnectIfNeeded.
(WebCore::LinkLoader::preconnectIfNeeded): Preconnect to a host functionality moved here.
(WebCore::LinkLoader::loadLink): Call preconnectIfNeeded.

  • loader/LinkLoader.h:

LayoutTests:

Add test to see Link preconnect headers trigger a connection.

  • http/tests/preconnect/link-header-rel-preconnect-http-expected.txt: Added.
  • http/tests/preconnect/link-header-rel-preconnect-http.html: Added.
  • http/tests/preconnect/resources/header-preconnect.php: Added.
  • platform/ios-simulator/TestExpectations: Skipped the test, as ios-simulator doesn't process Link headers for subresources.
  • platform/win/TestExpectations: Skipped the preconnect test directory, as it doesn't work on Windows.
2:12 PM Changeset in webkit [227234] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

Should allow updating a build-request to 'canceled'.
​https://bugs.webkit.org/show_bug.cgi?id=181819

Reviewed by Ryosuke Niwa.

It's possible syncing script update a build-request to 'canceled' state.

  • public/api/build-requests.php: Added 'canceled' as an acceptable update state.
  • server-tests/api-build-requests-tests.js: Added a unit test to update a build-request to 'canceled'.
1:48 PM Changeset in webkit [227233] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found
<​https://webkit.org/b/181871>

Rubber-stamped by JF Bastien.

  • CMakeLists.txt: Add ICU header search path to

LLIntOffsetsExtractor target by reusing
JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES.

1:36 PM Changeset in webkit [227232] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: tabbing on commented out property throws exception
​https://bugs.webkit.org/show_bug.cgi?id=180676
<rdar://problem/35981058>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.startEditingFirstProperty):
Tabbing from the selector field should focus on the first editable property.
When no editable properties are present, a new blank property should be added after the commented out ones.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.startEditingLastProperty):
Shift-tabbing from the selector field should focus on the last editable property of the previous CSS rule.
When no editable properties are present, a new blank property should be added after the commented out ones.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetCSSStyleDeclarationEditorFocusMoved):
When navigating between properties skip the commented out ones.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._editablePropertyAfter):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._editablePropertyBefore):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.get enabled):
(WI.SpreadsheetStyleProperty.prototype._update):

1:22 PM Changeset in webkit [227231] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[Cocoa] _WKNSWindowExtras.h: Add missing availability annotation
​https://bugs.webkit.org/show_bug.cgi?id=181868

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-19
Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/_WKNSWindowExtras.h:
1:19 PM Changeset in webkit [227230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Fix jsc-only build
​https://bugs.webkit.org/show_bug.cgi?id=181874

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-01-19
Reviewed by JF Bastien.

This makes "build-webkit --jsc-only" work on Mac!

  • wtf/PlatformJSCOnly.cmake:
1:15 PM Changeset in webkit [227229] by sbarati@apple.com
  • 4 edits
    2 adds in trunk

Spread's effects are modeled incorrectly both in AI and in Clobberize
​https://bugs.webkit.org/show_bug.cgi?id=181867
<rdar://problem/36290415>

Reviewed by Michael Saboff.

JSTests:

  • stress/ai-needs-to-model-spreads-effects.js: Added.

(try.p.Symbol.iterator):
(try.go):
(catch):

  • stress/clobberize-needs-to-model-spread-effects.js: Added.

(assert):
(foo):
(a.Symbol.iterator):

Source/JavaScriptCore:

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

12:13 PM Changeset in webkit [227228] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Make styles sidebar always LTR
​https://bugs.webkit.org/show_bug.cgi?id=175357
<rdar://problem/33787988>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):

12:11 PM Changeset in webkit [227227] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Add void to argument list to fix build with -Wstrict-prototypes
​https://bugs.webkit.org/show_bug.cgi?id=181870
<rdar://problem/36666750>

Unreviewed build fix.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
12:04 PM Changeset in webkit [227226] by Joseph Pecoraro
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Follow-up build fix for r227206.

Unreviewed.

  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/VideoProcessingSoftLink.h:

Avoid duplicate and different definitions of ALWAYS_INLINE.

11:54 AM Changeset in webkit [227225] by commit-queue@webkit.org
  • 94 edits in trunk

AppCache: Log a Deprecation warning to the Console when AppCache is used
​https://bugs.webkit.org/show_bug.cgi?id=181778

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-19
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker-expected.txt:
  • web-platform-tests/html/browsers/offline/introduction-4/event_cached-expected.txt:
  • web-platform-tests/html/browsers/offline/introduction-4/event_checking-expected.txt:
  • web-platform-tests/html/browsers/offline/introduction-4/event_noupdate-expected.txt:
  • web-platform-tests/html/browsers/offline/introduction-4/event_progress-expected.txt:
  • web-platform-tests/html/browsers/offline/manifest_url_check-expected.txt:
  • web-platform-tests/service-workers/service-worker/appcache-ordering-main.https-expected.txt:

Source/WebCore:

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

LayoutTests:

  • http/tests/appcache/404-manifest-expected.txt:
  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/404-resource-with-slow-main-resource-expected.txt:
  • http/tests/appcache/abort-cache-onchecking-expected.txt:
  • http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt:
  • http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt:
  • http/tests/appcache/abort-cache-ondownloading-expected.txt:
  • http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt:
  • http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt:
  • http/tests/appcache/abort-cache-onprogress-expected.txt:
  • http/tests/appcache/access-via-redirect-expected.txt:
  • http/tests/appcache/crash-when-navigating-away-then-back-expected.txt:
  • http/tests/appcache/credential-url-expected.txt:
  • http/tests/appcache/cyrillic-uri-expected.txt:
  • http/tests/appcache/decide-navigation-policy-after-delay-expected.txt:
  • http/tests/appcache/deferred-events-delete-while-raising-expected.txt:
  • http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt:
  • http/tests/appcache/deferred-events-expected.txt:
  • http/tests/appcache/different-https-origin-resource-main-expected.txt:
  • http/tests/appcache/different-origin-manifest-expected.txt:
  • http/tests/appcache/different-scheme-expected.txt:
  • http/tests/appcache/document-write-html-element-2-expected.txt:
  • http/tests/appcache/empty-manifest-expected.txt:
  • http/tests/appcache/fail-on-update-2-expected.txt:
  • http/tests/appcache/fail-on-update-expected.txt:
  • http/tests/appcache/fallback-expected.txt:
  • http/tests/appcache/fallback-namespace-outside-manifest-path-expected.txt:
  • http/tests/appcache/foreign-fallback-expected.txt:
  • http/tests/appcache/foreign-iframe-main-expected.txt:
  • http/tests/appcache/history-test-expected.txt:
  • http/tests/appcache/idempotent-update-expected.txt:
  • http/tests/appcache/identifier-test-expected.txt:
  • http/tests/appcache/interrupted-update-expected.txt:
  • http/tests/appcache/local-content-expected.txt:
  • http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt:
  • http/tests/appcache/main-resource-hash-expected.txt:
  • http/tests/appcache/main-resource-redirect-expected.txt:
  • http/tests/appcache/manifest-containing-itself-expected.txt:
  • http/tests/appcache/manifest-parsing-expected.txt:
  • http/tests/appcache/manifest-redirect-2-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/manifest-with-empty-file-expected.txt:
  • http/tests/appcache/max-size-expected.txt:
  • http/tests/appcache/multi-fallback-expected.txt:
  • http/tests/appcache/navigating-away-while-cache-attempt-in-progress-expected.txt:
  • http/tests/appcache/non-html-expected.txt:
  • http/tests/appcache/offline-access-expected.txt:
  • http/tests/appcache/online-fallback-layering-expected.txt:
  • http/tests/appcache/online-whitelist-expected.txt:
  • http/tests/appcache/origin-delete-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-expected.txt:
  • http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/origin-usage-expected.txt:
  • http/tests/appcache/origins-with-appcache-expected.txt:
  • http/tests/appcache/progress-counter-expected.txt:
  • http/tests/appcache/reload-expected.txt:
  • http/tests/appcache/remove-cache-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/simple-expected.txt:
  • http/tests/appcache/simple-video-async-expected.txt:
  • http/tests/appcache/simple-video-sync-expected.txt:
  • http/tests/appcache/top-frame-1-expected.txt:
  • http/tests/appcache/top-frame-2-expected.txt:
  • http/tests/appcache/top-frame-3-expected.txt:
  • http/tests/appcache/top-frame-4-expected.txt:
  • http/tests/appcache/update-cache-expected.txt:
  • http/tests/appcache/video-expected.txt:
  • http/tests/appcache/whitelist-wildcard-expected.txt:
  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:
  • http/tests/appcache/x-frame-options-prevents-framing-expected.txt:
  • http/tests/appcache/xhr-foreign-resource-expected.txt:
  • http/tests/contentfiltering/load-substitute-data-from-appcache-expected.txt:
  • http/tests/security/appcache-switching-private-browsing-expected.txt:
  • http/tests/security/cross-origin-appcache-allowed-expected.txt:
  • http/tests/security/cross-origin-appcache-expected.txt:
  • http/tests/security/same-origin-appcache-blocked-expected.txt:
  • http/tests/ssl/upgrade-origin-usage-expected.txt:
11:47 AM Changeset in webkit [227224] by Ryan Haddad
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r227211.

Breaks iOS Simulator tests.

Reverted changeset:

"Expose Safe Browsing SPI"
​https://bugs.webkit.org/show_bug.cgi?id=181804
​https://trac.webkit.org/changeset/227211

11:26 AM Changeset in webkit [227223] by wilander@apple.com
  • 20 edits in trunk

Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
​https://bugs.webkit.org/show_bug.cgi?id=181822
​https://bugs.webkit.org/show_bug.cgi?id=175263
​https://bugs.webkit.org/show_bug.cgi?id=178536
​https://bugs.webkit.org/show_bug.cgi?id=181223
​https://bugs.webkit.org/show_bug.cgi?id=181482
<rdar://problem/33491222>
<rdar://problem/33805293>
<rdar://problem/36332683>
<rdar://problem/36549026>

Reviewed by Alex Christensen.

Source/WebKit:

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore):
(WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStore]):

Calls the new API with no-op completion handler.

(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStore:]):

New API with completion handler.

(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours:]):

Calls the new API with no-op completion handler.

(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours:completionHandler:]):

New API with completion handler.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::statisticsClearInMemoryAndPersistentStore):
(WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):

LayoutTests:

  • http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html:
  • http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store.html:
  • http/tests/resourceLoadStatistics/grandfathering.html:
  • platform/ios/TestExpectations:

Marked the three updated tests as [ Pass ].

  • platform/mac-wk2/TestExpectations:

Marked the three updated tests as [ Pass ].

11:15 AM Changeset in webkit [227222] by Jonathan Bedard
  • 2 edits in trunk/Tools

run-webkit-tests fails when there is a curly brace in Xcode build output
​https://bugs.webkit.org/show_bug.cgi?id=181254
<rdar://problem/36453374>

Reviewed by Daniel Bates.

  • Scripts/webkitpy/port/base.py:

(Port._run_script): Encode script output before logging it.

11:13 AM Changeset in webkit [227221] by Chris Dumez
  • 6 edits in trunk/Source/WebCore
ASSERT(registration
isTerminating()) hit in SWServerWorker::skipWaiting()

​https://bugs.webkit.org/show_bug.cgi?id=181761
<rdar://problem/36594564>

Reviewed by Youenn Fablet.

There is a short period of time, early in the registration process where a
SWServerWorker object exists for a registration but is not in the registration's
installing/waiting/active slots yet. As a result, if a registration is cleared
during this period (for e.g. due to the user clearing all website data), that
SWServerWorker will not be terminated. We then hit assertion later on when this
worker is trying to do things (like call skipWaiting).

To address the issue, we now keep a reference this SWServerWorker on the
registration, via a new SWServerRegistration::m_preInstallationWorker data member.
When the registration is cleared, we now take care of terminating this worker.

No new tests, covered by existing tests that crash flakily in debug builds.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):
if the mutex is locked, then the worker thread is still starting. We spin the
runloop and try to stop again later. This avoids the deadlock shown in
Bug 181763 as the worker thread may need to interact with the main thread
during startup.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::installContextData):

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::install):

  • workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::~SWServerRegistration):
(WebCore::SWServerRegistration::setPreInstallationWorker):
(WebCore::SWServerRegistration::clear):

  • workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::preInstallationWorker const):

11:13 AM Changeset in webkit [227220] by Chris Dumez
  • 5 edits in trunk

Service worker registrations restored from disk may not be reused when the JS calls register() again
​https://bugs.webkit.org/show_bug.cgi?id=181810
<rdar://problem/36591711>

Reviewed by Youenn Fablet.

Source/WebCore:

The issue was that when restoring a registration from disk, we would not set its active worker right
away. We only set it later in installContextData(). installContextData() is only called after we’ve
launched the service worker process and established a connection to it.

However, we would start processing jobs (such as registrations) before we’ve established the connection
to the service worker process. SWServerJobQueue::runRegisterJob(), in order to reuse an existing
registration checks the registration’s active worker has the right script URL. The issue was that when
this code would execute, we may not have set the registration’s active service worker yet, in which case,
we would update the existing registration instead of reusing it as-is.

To address the issue, we now delay the processing of jobs until the connection to the service worker
process has been established and we've installed all pending contexts via installContextData().

Changed is covered by new API test.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::serverToContextConnectionCreated):

  • workers/service/server/SWServer.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
(-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):

11:12 AM Changeset in webkit [227219] by jcraig@apple.com
  • 6 edits in trunk

AX: when invert colors is on, double-invert image and picture elements in UserAgentStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=181281
<rdar://problem/36291776>

Reviewed by Simon Fraser.

Source/WebCore:

Updated "Smart Invert" to include img and picture element inversion and tests.

Tests: accessibility/smart-invert-reference.html

accessibility/smart-invert.html

  • css/html.css:

(@media (inverted-colors)):
(img:not(picture>img), picture, video):

LayoutTests:

Updated to include img and picture element tests.

  • accessibility/smart-invert-expected.txt:
  • accessibility/smart-invert-reference-expected.html:
  • accessibility/smart-invert.html:
11:02 AM Changeset in webkit [227218] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

REGRESSION (r223149): Ref WebPageProxy objects before calling their functionality
​https://bugs.webkit.org/show_bug.cgi?id=181863
<rdar://problem/36662452>

Reviewed by Chris Dumez.

More fix ups following r223149. When notifying all pages of a process state change we need to
take care to ref all the pages before iterating over them and notifying them of the change.
Notifying a page of such a state change may ultimately delegate to the embedding client. And
the embedding client can do anything, including deallocating one or more pages.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::willChangeIsResponsive):
(WebKit::WebProcessProxy::didChangeIsResponsive):
(WebKit::WebProcessProxy::requestTermination):

10:51 AM Changeset in webkit [227217] by Ryan Haddad
  • 2 edits in trunk/Tools

Remove El Capitan queues from flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=181860

Reviewed by Aakash Jain.

  • TestResultServer/static-dashboards/builders.jsonp:
10:38 AM Changeset in webkit [227216] by Chris Dumez
  • 21 edits
    2 adds in trunk

The WebContent process should not process incoming IPC while waiting for a sync IPC reply
​https://bugs.webkit.org/show_bug.cgi?id=181560

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add internals API for testing purposes.

Test: fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html

  • page/ChromeClient.h:
  • testing/Internals.cpp:

(WebCore::Internals::testIncomingSyncIPCMessageWhileWaitingForSyncReply):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

The WebContent process should not process incoming IPC while waiting for a sync IPC reply.
This is causing hard-to-debug crashes because developers often assume the state does not
change during a sendSync() call.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply):

  • Platform/IPC/Connection.h:

(IPC::Connection::setShouldProcessIncomingMessagesWhileWaitingForSyncReply):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::testIncomingSyncIPCMessageWhileWaitingForSyncReply):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::NetworkProcessConnection):

  • WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::WebToStorageProcessConnection):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::testIncomingSyncIPCMessageWhileWaitingForSyncReply):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::syncIPCMessageWhileWaitingForSyncReplyForTesting):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

LayoutTests:

Add layout test coverage.

  • fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt: Added.
  • fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html: Added.
10:33 AM Changeset in webkit [227215] by keith_miller@apple.com
  • 17 edits in trunk

HaveInternalSDK includes should be "#include?"
​https://bugs.webkit.org/show_bug.cgi?id=179670

Reviewed by Dan Bernstein.

Source/bmalloc:

  • Configurations/Base.xcconfig:

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:

Source/WebKit:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:

Tools:

  • MiniBrowser/Configurations/Base.xcconfig:
  • MobileMiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
10:32 AM Changeset in webkit [227214] by dbates@webkit.org
  • 9 edits in trunk/Source

Fix misspelling; substitute willDetachRenderer for willDetatchRenderer.

Source/WebCore:

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willDetachRenderers):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::willDetachRenderer):
(WebCore::PluginViewBase::willDetatchRenderer): Deleted.

Source/WebKit:

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::willDetachRenderer):
(WebKit::PDFPlugin::willDetatchRenderer): Deleted.

  • WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::willDetachRenderer):
(WebKit::Plugin::willDetatchRenderer): Deleted.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::willDetachRenderer):
(WebKit::PluginView::willDetatchRenderer): Deleted.

  • WebProcess/Plugins/PluginView.h:
10:12 AM Changeset in webkit [227213] by Jonathan Bedard
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix, remove unused lambda captures.

  • dom/messageports/MessagePortChannel.cpp:

(WebCore::MessagePortChannel::takeAllMessagesForPort):

  • dom/messageports/MessagePortChannelRegistry.cpp:

(WebCore::MessagePortChannelRegistry::messagePortChannelCreated):

10:09 AM Changeset in webkit [227212] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Update XPCSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=181827
rdar://problem/36393031

Reviewed by Daniel Bates.

  • wtf/spi/darwin/XPCSPI.h:
10:05 AM Changeset in webkit [227211] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Expose Safe Browsing SPI
​https://bugs.webkit.org/show_bug.cgi?id=181804
<rdar://problem/36626946>

Patch by Zach Li <​zacharyli323@gmail.com> on 2018-01-19
Reviewed by Alex Christensen.

If client is using Apple internal SDK, then we can just import the header; if not,
then we declare necessary symbols that client will need.

  • Configurations/WebKit.xcconfig:

Only link against SafariSafeBrowsing framework on macOS High Sierra
and iOS 11 and above. Weak link against SafariSafeBrowsing framework
because it is not present on the Base system.

  • Platform/spi/Cocoa/SafeBrowsingSPI.h: Added.
  • WebKit.xcodeproj/project.pbxproj:

Added SafeBrowsingSPI.h.

  • WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/11/SafariSafeBrowsing.framework/SafariSafeBrowsing.tbd:

Added.

9:59 AM Changeset in webkit [227210] by graouts@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Web Animations] Remove http/wpt/wk-web-animations tests
​https://bugs.webkit.org/show_bug.cgi?id=181861

These tests were written early on during our Web Animations implementation before we had a good sense of the quality
of the coverage of the W3C WPT suite. That suite is extremely comprehensive and all of the assertions we wrote ourselves
are redundant and should be removed so that all testing, unless specific to our implementation, is done through the WPT
suite.

Reviewed by Dean Jackson.

  • http/wpt/wk-web-animations/interfaces/document-get-animations-expected.txt: Removed.
  • http/wpt/wk-web-animations/interfaces/document-get-animations.html: Removed.
  • http/wpt/wk-web-animations/interfaces/element-get-animations-expected.txt: Removed.
  • http/wpt/wk-web-animations/interfaces/element-get-animations.html: Removed.
  • http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle-expected.txt: Removed.
  • http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-creation-basic-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-creation-basic.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-current-time-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-current-time.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect-timing-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect-timing.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-effect.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-interface-effect-property-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-interface-effect-property.html: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-interface-start-time-property-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/animation-interface-start-time-property.html: Removed.
  • http/wpt/wk-web-animations/timing-model/document-timeline-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/document-timeline.html: Removed.
  • http/wpt/wk-web-animations/timing-model/keyframe-effect-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html: Removed.
  • http/wpt/wk-web-animations/timing-model/keyframe-effect.html: Removed.
  • http/wpt/wk-web-animations/timing-model/timeline-current-time-expected.txt: Removed.
  • http/wpt/wk-web-animations/timing-model/timeline-current-time.html: Removed.
9:58 AM Changeset in webkit [227209] by pvollan@apple.com
  • 4 edits in trunk/Source/WebKitLegacy/win

[Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
​https://bugs.webkit.org/show_bug.cgi?id=181859
<rdar://problem/36659886>

Reviewed by Alex Christensen.

Use local include patch.

  • WebKitQuartzCoreAdditions/API/WKCACFImage.h:
  • WebKitQuartzCoreAdditions/API/WKCACFView.h:
  • WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
9:56 AM Changeset in webkit [227208] by graouts@webkit.org
  • 40 edits
    3 copies in trunk

[Web Animations] Expose timing properties (delay, endDelay, fill, iterationStart, iterations, direction) and getComputedTiming()
​https://bugs.webkit.org/show_bug.cgi?id=181857
<rdar://problem/36660081>

Reviewed by Dean Jackson.

Source/WebCore:

We start the work to implement the rest of the Web Animations timing and animation model by exposing more properties on
AnimationEffectTiming to control delay (delay, endDelay), looping (iterationStart, iterations), fill and direction.
Additionally, we expose the getComputedTiming() method on AnimationEffect, although it currently lacks some computed
properties that will come in later patch as we implement various processes defined by the spec. We also update the
existing duration() method on AnimationEffectTiming to be called iterationDuration() to match the terms used in the
specification.

Finally, we make all new properties, and update existing ones, that expose a time value go through the new utility
function secondsToWebAnimationsAPITime() to guarantee rounded values with microseconds precision, as advised by
the Web Animations specification.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationEffect.cpp:

(WebCore::AnimationEffect::localTime const):
(WebCore::AnimationEffect::getComputedTiming):

  • animation/AnimationEffect.h:
  • animation/AnimationEffect.idl:
  • animation/AnimationEffectTiming.cpp:

(WebCore::AnimationEffectTiming::AnimationEffectTiming):
(WebCore::AnimationEffectTiming::setIterationStart):
(WebCore::AnimationEffectTiming::setIterations):
(WebCore::AnimationEffectTiming::bindingsDuration const):
(WebCore::AnimationEffectTiming::setBindingsDuration):
(WebCore::AnimationEffectTiming::endTime const):
(WebCore::AnimationEffectTiming::activeDuration const):

  • animation/AnimationEffectTiming.h:
  • animation/AnimationEffectTiming.idl:
  • animation/AnimationPlaybackEvent.cpp:

(WebCore::AnimationPlaybackEvent::bindingsCurrentTime const):
(WebCore::AnimationPlaybackEvent::bindingsTimelineTime const):

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::bindingsCurrentTime):

  • animation/ComputedTimingProperties.h: Added.
  • animation/ComputedTimingProperties.idl: Added. We set nullable double values to a default value of "null" since

otherwise setting those properties to a null value would not set the properties in the converted JS dictionary.

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::create): Handle new timing properties passed in the KeyframeEffectOptions dictionary.
(WebCore::KeyframeEffect::applyAtLocalTime):
(WebCore::KeyframeEffect::getAnimatedStyle):
(WebCore::KeyframeEffect::startOrStopAccelerated):

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::bindingsCurrentTime const):
(WebCore::WebAnimation::effectEndTime const):
(WebCore::WebAnimation::timeToNextRequiredTick const):

  • animation/WebAnimationUtilities.h: Added.

(WebCore::secondsToWebAnimationsAPITime):

LayoutTests:

Update expectations with progressions and new failure points now we expose more of the API.

  • http/wpt/web-animations/animation-model/animation-types/discrete-animation-expected.txt:
  • http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/finish-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/finished-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/pause-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/play-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/delay-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/direction-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/duration-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/fill-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterationStart-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterations-expected.txt:
  • http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt:
  • http/wpt/web-animations/timing-model/animation-effects/active-time-expected.txt:
  • http/wpt/web-animations/timing-model/animation-effects/current-iteration-expected.txt:
  • http/wpt/web-animations/timing-model/animation-effects/local-time-expected.txt:
  • http/wpt/web-animations/timing-model/animation-effects/phases-and-states-expected.txt:
  • http/wpt/web-animations/timing-model/animation-effects/simple-iteration-progress-expected.txt:
  • http/wpt/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt:
  • http/wpt/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt:
  • http/wpt/web-animations/timing-model/time-transformations/transformed-progress-expected.txt:
  • http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html:
9:55 AM Changeset in webkit [227207] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove dead networking code
​https://bugs.webkit.org/show_bug.cgi?id=181813

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-01-19
Reviewed by Tim Horton.

CFURLConnection is only used on Windows.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::encodingRequiresPlatformData const):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

9:48 AM Changeset in webkit [227206] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/ThirdParty/libwebrtc

Softlink VideoProcessing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=181853
<rdar://problem/36590005>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-19
Reviewed by Eric Carlson.

  • Configurations/libwebrtc.xcconfig:
  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/VideoProcessingSoftLink.cpp: Added.
  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/VideoProcessingSoftLink.h: Added.
  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h:
  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.mm:

(internal::SetVTSessionProperty):
(webrtc::H264VideoToolboxEncoderVCP::Encode):

  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.mm:

(webrtc::VideoToolboxVideoEncoderFactory::VideoToolboxVideoEncoderFactory):

  • libwebrtc.xcodeproj/project.pbxproj:
9:46 AM Changeset in webkit [227205] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Remove unused WebViewPrivate _allowCookies
​https://bugs.webkit.org/show_bug.cgi?id=181812

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-01-19
Reviewed by Tim Horton.

Source/WebCore:

This SPI was in the original iOS upstreaming and has not been used in many years.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setDefaultAllowCookies): Deleted.
(WebCore::ResourceRequestBase::defaultAllowCookies): Deleted.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(+[WebView _setAllowCookies:]): Deleted.
(+[WebView _allowCookies]): Deleted.

  • WebView/WebViewPrivate.h:
9:45 AM Changeset in webkit [227204] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/images/image-supports-video.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181862

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:38 AM Changeset in webkit [227203] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for media/W3C/audio/networkState/networkState_during_loadstart.html.
​https://bugs.webkit.org/show_bug.cgi?id=123010

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:12 AM Changeset in webkit [227202] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move select-out-of-floated-non-editable iOS Simulator expectations to iOS

Unreviewed test gardening.

r222317 introduced these test expectations. These expectations should apply to both
Simulator and device testing.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
8:45 AM Changeset in webkit [227201] by fred.wang@free.fr
  • 10 edits in trunk/LayoutTests

Use promises for basic-gestures.js and 'await' for the corresponding tests
​https://bugs.webkit.org/show_bug.cgi?id=181841

Patch by Frederic Wang <​fwang@igalia.com> on 2018-01-19
Reviewed by Megan Gardner.

  • fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html: Remove redundant

check for testRunner.runUIScript, rewrite runUIScript calls to just await a promise, add the
async keyword to runTest and reindent.
Also remove extraneous space after + operator.

  • fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-to-select-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html: Ditto.
  • fast/events/touch/ios/long-press-to-select-text.html: Ditto.
  • resources/basic-gestures.js: For all functions in this file, wrap the script source into a

runUIScript call and a new promise, reindent.

8:21 AM Changeset in webkit [227200] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark svg/filters/feDiffuseLighting-bottomRightPixel.html as failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=181854

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:10 AM Changeset in webkit [227199] by graouts@webkit.org
  • 2 edits in trunk/LayoutTests

[iOS] LayoutTest media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html fails on Internal bots
​https://bugs.webkit.org/show_bug.cgi?id=181843
<rdar://problem/36061363>

The button we were trying to press was outside of the viewable screen area and so the tap wouldn't occur.
Resizing the video to fit in the window fixes the issue.

Reviewed by Youenn Fablet.

  • media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
7:19 AM Changeset in webkit [227198] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

WebDriver: driver environment not passed to pytest when running w3c tests
​https://bugs.webkit.org/show_bug.cgi?id=181852

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2018-01-19
Reviewed by Carlos Alberto Lopez Perez.

That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:

(WebDriverW3CExecutor.run):

6:19 AM Changeset in webkit [227197] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] WebDriver: wayland display no used in wayland bot
​https://bugs.webkit.org/show_bug.cgi?id=181851

Reviewed by Carlos Alberto Lopez Perez.

We need to handle the additionalArguments property in the WebDriverTests step.

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunWebDriverTests.start):

5:06 AM Changeset in webkit [227196] by Yusuke Suzuki
  • 2 edits in trunk/JSTests

Unreviewed, reduce count of iteration to fix timing out debug JSC test
​https://bugs.webkit.org/show_bug.cgi?id=181535

  • stress/inserted-recovery-with-set-last-index.js:
4:22 AM Changeset in webkit [227195] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] TERM environment variable is not passed to the test driver.
​https://bugs.webkit.org/show_bug.cgi?id=181847

Rubber-stamped by by Carlos Garcia Campos.

  • Scripts/webkitpy/port/base.py:

(Port.to.setup_environ_for_server):

3:54 AM Changeset in webkit [227194] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
​https://bugs.webkit.org/show_bug.cgi?id=181844

Reviewed by Carlos Alberto Lopez Perez.

We always try to create the directory where to store the json file, but when the filename is given directly,
like in the bots, the current dir is used.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
empty string.

1:58 AM Changeset in webkit [227193] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] WebDriver tests are running outside the jhbuild env
​https://bugs.webkit.org/show_bug.cgi?id=181842

Reviewed by Žan Doberšek.

We need to enter jhbuild env in run-webdriver-tests.

  • Scripts/run-webdriver-tests:

Jan 18, 2018:

11:31 PM Changeset in webkit [227192] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Run WebDriver tests in the bots
​https://bugs.webkit.org/show_bug.cgi?id=181787

Reviewed by Michael Catanzaro.

Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
factory for the GTK port for now.

  • BuildSlaveSupport/build.webkit.org-config/factories.py:

(TestFactory.init):

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunWebDriverTests):
(RunWebDriverTests.start):
(RunWebDriverTests.commandComplete):
(RunWebDriverTests.evaluateCommand):
(RunWebDriverTests.getText):
(RunWebDriverTests.getText2):

11:03 PM Changeset in webkit [227191] by fred.wang@free.fr
  • 9 edits
    2 copies
    1 delete in trunk/LayoutTests

Move helper files for iOS touch gestures into LayoutTests/resources
​https://bugs.webkit.org/show_bug.cgi?id=181798

Patch by Frederic Wang <​fwang@igalia.com> on 2018-01-18
Reviewed by Wenson Hsieh.

  • fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html: Change URL of

basic-gestures.js ; remove gesture-helpers.js it seems unused and has the wrong URL anyway.

  • fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html: Change URL

of basic-gestures.js.

  • fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-to-select-text.html: Ditto.
  • fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html: Ditto.
  • fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html: Ditto.
  • fast/events/touch/ios/long-press-to-select-text.html: Ditto.
  • resources/basic-gestures.js: Renamed from LayoutTests/fast/events/touch/ios/resources/basic-gestures.js.
  • resources/ui-debugging.js: Renamed from LayoutTests/fast/events/touch/ios/resources/ui-debugging.js.

Note that this file was introduced in r222517 but seems unused for now.

10:33 PM Changeset in webkit [227190] by beidson@apple.com
  • 24 edits
    11 adds
    4 deletes in trunk/Source/WebCore

Make in-process MessagePorts be (mostly) asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=181454

Reviewed by Alex Christensen.

No new tests (Covered *brutally* by existing tests)

Part of making MessagePorts be a thing we can pass across processes is making them work async.

The existing "MessagePortChannel" method of abstraction was not cut out for this.
This patch gets rid of MessagePortChannel and adds a new MessagePortChannelProvider abstraction.
It then gets the new machinery working in-process (with some pieces of out-of-process in place)

One synchronous behavior this patch maintains is the hasPendingActivity() check used to support GC.
That will (creatively) be made async in the next followup.

More generally from MessagePorts, this patch also adds a "MessageWithMessagePorts" object to be used
with all forms of postMessage(). Much better.

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/InProcessMessagePortChannel.cpp: Removed.
  • dom/InProcessMessagePortChannel.h: Removed.
  • dom/MessagePortChannel.cpp: Removed.
  • dom/MessagePortChannel.h: Removed.
  • dom/MessageChannel.cpp:

(WebCore::MessageChannel::create):
(WebCore::MessageChannel::MessageChannel):
(WebCore::m_port2): Deleted.

  • dom/MessageChannel.h:

(WebCore::MessageChannel::create): Deleted.

  • dom/MessagePort.cpp:

(WebCore::MessagePort::create):
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::~MessagePort):
(WebCore::MessagePort::entangle):
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::messageAvailable):
(WebCore::MessagePort::start):
(WebCore::MessagePort::close):
(WebCore::MessagePort::contextDestroyed):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::hasPendingActivity const):
(WebCore::MessagePort::locallyEntangledPort const):
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entanglePorts):
(WebCore::MessagePort::entangleWithRemote): Deleted.

  • dom/MessagePort.h:
  • dom/MessagePortIdentifier.h:

(WebCore::MessagePortIdentifier::logString const):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::processMessageWithMessagePortsSoon):
(WebCore::ScriptExecutionContext::dispatchMessagePortEvents):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Deleted.

  • dom/ScriptExecutionContext.h:

Add a single object that represents two intertwined ports, tracks their pending
messages, tracks which process they're in, etc etc:

  • dom/messageports/MessagePortChannel.cpp: Added.

(WebCore::MessagePortChannel::create):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::~MessagePortChannel):
(WebCore::MessagePortChannel::includesPort):
(WebCore::MessagePortChannel::entanglePortWithProcess):
(WebCore::MessagePortChannel::disentanglePort):
(WebCore::MessagePortChannel::closePort):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::takeAllMessagesForPort):
(WebCore::MessagePortChannel::hasAnyMessagesPendingOrInFlight const):

  • dom/messageports/MessagePortChannel.h: Added.

(WebCore::MessagePortChannel::port1 const):
(WebCore::MessagePortChannel::port2 const):
(WebCore::MessagePortChannel::logString const):

Abstraction for creating and operating on MessagePorts in a potentially cross-process way:

  • dom/messageports/MessagePortChannelProvider.cpp: Added.

(WebCore::MessagePortChannelProvider::singleton):
(WebCore::MessagePortChannelProvider::setSharedProvider):

  • dom/messageports/MessagePortChannelProvider.h: Added.

(WebCore::MessagePortChannelProvider::~MessagePortChannelProvider):

Adds a concrete implementation of that provider to be used in-process (e.g. WK1):

  • dom/messageports/MessagePortChannelProviderImpl.cpp: Added.

(WebCore::MessagePortChannelProviderImpl::~MessagePortChannelProviderImpl):
(WebCore::MessagePortChannelProviderImpl::performActionOnAppropriateThread):
(WebCore::MessagePortChannelProviderImpl::createNewMessagePortChannel):
(WebCore::MessagePortChannelProviderImpl::entangleLocalPortInThisProcessToRemote):
(WebCore::MessagePortChannelProviderImpl::messagePortDisentangled):
(WebCore::MessagePortChannelProviderImpl::messagePortClosed):
(WebCore::MessagePortChannelProviderImpl::postMessageToRemote):
(WebCore::MessagePortChannelProviderImpl::takeAllMessagesForPort):
(WebCore::MessagePortChannelProviderImpl::hasMessagesForPorts_temporarySync):

  • dom/messageports/MessagePortChannelProviderImpl.h: Added.

Adds a main thread object to handle the set of all MessagePortChannels that are open.
For now it lives in the WebProcess, but for out-of-process it will live in the UIProcess:

  • dom/messageports/MessagePortChannelRegistry.cpp: Added.

(WebCore::MessagePortChannelRegistry::~MessagePortChannelRegistry):
(WebCore::MessagePortChannelRegistry::didCreateMessagePortChannel):
(WebCore::MessagePortChannelRegistry::messagePortChannelCreated):
(WebCore::MessagePortChannelRegistry::messagePortChannelDestroyed):
(WebCore::MessagePortChannelRegistry::didEntangleLocalToRemote):
(WebCore::MessagePortChannelRegistry::didDisentangleMessagePort):
(WebCore::MessagePortChannelRegistry::didCloseMessagePort):
(WebCore::MessagePortChannelRegistry::didPostMessageToRemote):
(WebCore::MessagePortChannelRegistry::takeAllMessagesForPort):
(WebCore::MessagePortChannelRegistry::hasMessagesForPorts_temporarySync): This is named against style

and weird on purpose - to call attention to how bad it is and how it's temporary.

(WebCore::MessagePortChannelRegistry::existingChannelContainingPort):

  • dom/messageports/MessagePortChannelRegistry.h: Added.

Add an object that represents a "SerializedScriptValue for the message payload and the ports
that are being transferred along with that payload". This is used in all forms of postMessage():

  • dom/messageports/MessageWithMessagePorts.cpp: Added.
  • dom/messageports/MessageWithMessagePorts.h: Added.
  • page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):

  • platform/Logging.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::postMessage):

  • workers/Worker.cpp:

(WebCore::Worker::postMessage):

  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

  • workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):

  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorker):

  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::fireMessageEvent):
(WebCore::ServiceWorkerThread::postMessageToServiceWorker):

  • workers/service/context/ServiceWorkerThread.h:
10:17 PM Changeset in webkit [227189] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=180171

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:11 PM Changeset in webkit [227188] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark inspector/debugger/breakpoint-action-log.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181839

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:04 PM Changeset in webkit [227187] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark storage/websql/database-lock-after-reload.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173928

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:04 PM Changeset in webkit [227186] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172243

Unreviewed test gardening.

9:55 PM Changeset in webkit [227185] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark js/slow-stress/Int32Array-alloc-huge-long-lived.html as slow on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=181838

Unreviewed test gardening.

  • platform/ios/TestExpectations:
9:42 PM Changeset in webkit [227184] by aakash_jain@apple.com
  • 7 edits in trunk/Websites/perf.webkit.org

Add support for builderNameToIDMap in BuildbotSyncer
​https://bugs.webkit.org/show_bug.cgi?id=176526

Reviewed by Ryosuke Niwa.

  • tools/js/buildbot-syncer.js:

(BuildbotSyncer._loadConfig): Added builderNameToIDMap parameter. It would be used later on.
(BuildbotSyncer._resolveBuildersWithPlatforms): Ditto.
(BuildbotSyncer._validateAndMergeConfig): Added builderID as a valid config parameter.

  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.getBuilderNameToIDMap): Method to fetch BuilderNameToIDMap from Buildbot 0.9.
(BuildbotTriggerable.prototype.getBuilderNameToIDMapDeprecated): Method to fetch BuilderNameToIDMap from Buildbot 0.8.
(BuildbotTriggerable.prototype.initSyncers): Updated to use getBuilderNameToIDMap.

  • unit-tests/buildbot-syncer-tests.js: Updated unit-tests.
  • server-tests/resources/mock-data.js:

(MockData.buildbotBuildersURLDeprecated): URL for fetching Builders list.
(MockData.buildbotBuildersURL): Ditto for Buildbot 0.9
(MockData.mockBuildbotBuildersDeprecated): Sample builders data for Buildbot 0.8
(MockData.mockBuildbotBuilders): Ditto for Buildbot 0.9

  • server-tests/tools-buildbot-triggerable-tests.js: Added test for getBuilderNameToIDMap. Updated tests to handle

newly added promise for fetching builders list from Buildbot.

  • server-tests/tools-sync-buildbot-integration-tests.js: Ditto.
8:55 PM Changeset in webkit [227183] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/W3C/video/networkState/networkState_during_loadstart.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179643

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
8:46 PM Changeset in webkit [227182] by rniwa@webkit.org
  • 4 edits in trunk/Websites/perf.webkit.org

Charts can be empty when values are all identical
​https://bugs.webkit.org/show_bug.cgi?id=181828

Reviewed by Alexey Proskuryakov.

Fixed the bug that when SampleVarianceUpperTriangularMatrix can store -Infinity as the initial cost
of some entries when the sample standard deviation between two points turns out to be 0,
and cause splitIntoSegmentsUntilGoodEnough to return undefiend because no segmentation has a finite cost.

Also fixed the bug that the time series chart fails to show any data points when all data points have
identical values as the entire y-coordinate gets collapsed to an empty value range by adjusting the max value
when min & max values are identical.

  • public/v3/components/time-series-chart.js:

(TimeSeriesChart.prototype._ensureValueRangeCache): Raise the max slightly when min & max are identical
to avoid the chart becoming empty. Otherwise valueDiff in _computeVerticalRenderingMetrics becomes 0
and value-to-y-coordinate conversion always results in NaN.

  • public/shared/statistics.js:

(Statistics..SampleVarianceUpperTriangularMatrix):

  • unit-tests/statistics-tests.js: Added a test case.
8:33 PM Changeset in webkit [227181] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/video-main-content-allow-then-deny.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181830

Unreviewed test gardening.

  • platform/mac/TestExpectations:
8:29 PM Changeset in webkit [227180] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Update TestExpectations for fast/multicol/spanner-crash-when-adding-summary.html.

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
8:25 PM Changeset in webkit [227179] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=181499

Unreviewed test gardening.

  • platform/ios/TestExpectations:
7:45 PM Changeset in webkit [227178] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227147. rdar://problem/36429159

7:21 PM Changeset in webkit [227177] by jmarcell@apple.com
  • 10 edits in branches/safari-605-branch

Cherry-pick r226956. rdar://problem/36598688

5:35 PM Changeset in webkit [227176] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix, removed unused lambda capture.

  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::ServiceWorkerTerminationRequest::ServiceWorkerTerminationRequest):

4:58 PM Changeset in webkit [227175] by jmarcell@apple.com
  • 7 edits in branches/safari-605-branch/Source

Versioning.

4:57 PM Changeset in webkit [227174] by Chris Dumez
  • 8 edits
    4 adds in trunk

We should be able to terminate service workers that are unresponsive
​https://bugs.webkit.org/show_bug.cgi?id=181563
<rdar://problem/35280031>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/workers/service/postmessage-after-terminating-hung-worker.html

  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::terminateWorker):
Before calling WorkerThread::stop(), set a timer with the given timeout parameter.
If the worker thread has not stopped when the timer fires, forcefully exit the
service worker process. The StorageProcess will take care of relaunching the
service worker process if it exits abruptly.

(WebCore::SWContextManager::serviceWorkerFailedToTerminate):
Log error message if we failed to terminate a service worker and call exit().

(WebCore::SWContextManager::ServiceWorkerTerminationRequest::ServiceWorkerTerminationRequest):

  • workers/service/context/SWContextManager.h:

Source/WebKit:

  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::terminateWorker):
Use a 10 second timeout for forcefully exiting the service worker process when
the service worker in question fails to terminate.

(WebKit::WebSWContextManagerConnection::syncTerminateWorker):
Use a 100ms timeout for forcefully exiting the service worker process when
the service worker in question fails to terminate. This method is only called
from the layout tests, which is why we use a very short timeout.

Source/WTF:

  • wtf/ObjectIdentifier.h:

(WTF::ObjectIdentifier::loggingString const):
Allow using loggingString() from RELEASE_LOG().

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/postmessage-after-terminating-hung-worker-expected.txt: Added.
  • http/tests/workers/service/postmessage-after-terminating-hung-worker.html: Added.
  • http/tests/workers/service/resources/postmessage-after-terminating-hung-worker.js: Added.
  • http/tests/workers/service/resources/postmessage-echo-worker-mayhang.js: Added.
4:51 PM Changeset in webkit [227173] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.24

Tag Safari-605.1.24.

4:43 PM Changeset in webkit [227172] by ap@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/mac

Build fix, remove a call to -[NSWindow setOneShot:]
​https://bugs.webkit.org/show_bug.cgi?id=181809

Reviewed by Tim Horton.

  • WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _buildUI]):

4:25 PM Changeset in webkit [227171] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Pass correct url for http test to test driver.
​https://bugs.webkit.org/show_bug.cgi?id=181814

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-18
Reviewed by Alex Christensen.

  • Scripts/webkitpy/port/driver.py:

(Driver):
(Driver.http_test_path_to_uri):
(Driver.is_secure_path):
(Driver.http_base_url):
(Driver.uri_to_test):

4:19 PM Changeset in webkit [227170] by Ryan Haddad
  • 2 edits in trunk/Tools

Unreviewed, update the triggerable name for 'sierra-release-perf-tests'

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:07 PM Changeset in webkit [227169] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227165. rdar://problem/36628552

3:53 PM Changeset in webkit [227168] by jfbastien@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Set the minimum executable allocator size properly
​https://bugs.webkit.org/show_bug.cgi?id=181816
<rdar://problem/36635533>

Reviewed by Saam Barati.

Executable allocator expects at least two page size's worth of
allocation in certain conditions, and that causes some tests to
now fail because they ask for less. Set that minimum correctly. We
were already rounding up to a page size, so having a minimum of 2
page sizes is fine.

  • jit/ExecutableAllocator.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

3:39 PM Changeset in webkit [227167] by Ryan Haddad
  • 4 edits in trunk/Source

Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.

Source/WebKit:

  • UIProcess/ios/WKPDFPageNumberIndicator.mm:

(-[WKPDFPageNumberIndicator _makeRoundedCorners]):

Source/WebKitLegacy/mac:

  • Carbon/HIWebView.mm:

(overrideCGContext):
(restoreCGContext):

3:01 PM Changeset in webkit [227166] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Don't fetch more than two builds to check duplicity of builds in ReportProcessor
​https://bugs.webkit.org/show_bug.cgi?id=181786

Reviewed by Wenson Hsieh.

Limit the number of builds to check to avoid using a lot of memory with a long delay.

  • public/include/report-processor.php:

(ReportProcessor::resolve_build_id):

2:43 PM Changeset in webkit [227165] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2018-01-18 Michael Saboff <​msaboff@apple.com>

Unreviewed build fix for Windows

  • interpreter/FrameTracers.h:

(JSC::assertStackPointerIsAligned): Can't use gcc style inlined assembly
on Windows.

1:51 PM Changeset in webkit [227164] by jmarcell@apple.com
  • 5 edits in tags/Safari-605.1.23.1/Source/JavaScriptCore

Cherry-pick r227152. rdar://problem/36628594

1:51 PM Changeset in webkit [227163] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.23.1/Source

Versioning.

1:20 PM Changeset in webkit [227162] by jmarcell@apple.com
  • 5 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227152. rdar://problem/36628552

1:12 PM Changeset in webkit [227161] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Do not go to the storage process when loading a main resource if there is no service worker registered
​https://bugs.webkit.org/show_bug.cgi?id=181395

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-18
Reviewed by Chris Dumez.

Source/WebCore:

No observable behavior change.
Instead of creating a connection to know whether there is a potential service worker,
Ask the service worker provider that will use the connection if needed.
Otherwise, it will use a default value provided by the UIProcess.

Tested by cleaning all service workers and checking the computed value of the default value,
then observing whether pages registering service workers work well.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • workers/service/ServiceWorkerProvider.cpp:

(WebCore::ServiceWorkerProvider::mayHaveServiceWorkerRegisteredForOrigin):

  • workers/service/ServiceWorkerProvider.h:

Source/WebKit:

Add a new web process creation parameter to know whether there is any service worker registered at web process creation time.
If there is none, the web process will then start to load HTTP resources from the network.
The connection to the storage process is then executed when receiving the first bytes of the main resource.
This connection is needed as other web processes may create service workers at any given time.
If there is one registered service worker, the web process will wait for its connection to the storage process to be active.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::hasRegisteredServiceWorkers):

  • UIProcess/ServiceWorkerProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession):

  • WebProcess/Storage/WebServiceWorkerProvider.h:
  • WebProcess/Storage/WebToStorageProcessConnection.h:

(WebKit::WebToStorageProcessConnection::existingServiceWorkerConnectionForSession):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

1:08 PM Changeset in webkit [227160] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.23.1

New tag.

1:00 PM Changeset in webkit [227159] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Poisons should be initialized after Options are initialized.
​https://bugs.webkit.org/show_bug.cgi?id=181807
<rdar://problem/36629138>

Reviewed by Keith Miller.

This is because poison initialization may depend on options.

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

12:39 PM Changeset in webkit [227158] by jdiggs@igalia.com
  • 4 edits in trunk/LayoutTests

AX: roles-computedRoleString.html layout test should support enabling/disabling individual test cases
​https://bugs.webkit.org/show_bug.cgi?id=181806

Reviewed by Chris Fleizach.

Add a "data-platform" attribute to each element so that we can enable or disable
a given test case on a given platform. Update the platform expectations for GTK
to reflect changes and new support which happened in the interim. And remove the
test from the list of expected failures.

  • accessibility/roles-computedRoleString.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/roles-computedRoleString-expected.txt:
12:10 PM Changeset in webkit [227157] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Regression(r223149): WebProcessProxy::didClose() no longer refs WebPageProxy objects
​https://bugs.webkit.org/show_bug.cgi?id=181771
<rdar://problem/36566237>

Reviewed by Brady Eidson.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):
Use copyToVectorOf<RefPtr<WebPageProxy>>() to maintain pre-r223149 behavior
and ref the pages.

11:49 AM Changeset in webkit [227156] by mitz@apple.com
  • 54 edits
    7 adds in trunk

[Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
​https://bugs.webkit.org/show_bug.cgi?id=181803

Reviewed by Tim Horton.

Source/bmalloc:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • Configurations/Version.xcconfig: Updated.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.

Source/ThirdParty/libwebrtc:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.
  • Configurations/opus.xcconfig: Adopted macOSTargetConditionals helper.

Source/WebCore:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • Configurations/Version.xcconfig: Updated.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.

Source/WebCore/PAL:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • Configurations/Version.xcconfig: Updated.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.

Source/WebInspectorUI:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/Version.xcconfig: Ditto.

Source/WebKit:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • Configurations/Version.xcconfig: Updated.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.

Source/WebKitLegacy/mac:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • Configurations/Version.xcconfig: Updated.
  • Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.

Source/WTF:

  • Configurations/Base.xcconfig: Updated.
  • Configurations/DebugRelease.xcconfig: Updated.

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
  • ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
  • ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
  • MiniBrowser/Configurations/Base.xcconfig: Ditto.
  • MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
  • TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
  • TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings useful for defining settings that depend on the target macOS version.
  • WebKitTestRunner/Configurations/Base.xcconfig: Updated.
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
11:41 AM Changeset in webkit [227155] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab: record button on canvas card doesn't always show on hover, or is misplaced
​https://bugs.webkit.org/show_bug.cgi?id=179183

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas:not(.is-recording) > header > .navigation-bar > .item.record-start-stop): Deleted.

11:01 AM Changeset in webkit [227154] by lingcherd_ho@apple.com
  • 4 edits in trunk/Tools

Remove Opensource El Capitan queues from buildbot
​https://bugs.webkit.org/show_bug.cgi?id=181712

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
10:46 AM Changeset in webkit [227153] by Chris Dumez
  • 7 edits in trunk

Service Workers restored from persistent storage have 'redundant' state
​https://bugs.webkit.org/show_bug.cgi?id=181749
<rdar://problem/36556486>

Reviewed by Youenn Fablet.

Source/WebCore:

Tested by new API test.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::installContextData):
Make sure the SWServerWorker's state is set to "activated" after it is assigned to
the registrations' active slot. Otherwise, it stays in its default state (redundant).

Source/WebKit:

Allow service workers to intercept custom protocol loads as this is useful for
API testing.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):

  • WebProcess/Network/WebLoaderStrategy.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):

10:44 AM Changeset in webkit [227152] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

REGRESSION (r226068): [X86] Crash in JavaScriptCore ShadowChicken when handling exceptions
​https://bugs.webkit.org/show_bug.cgi?id=181802

Reviewed by Filip Pizlo.

There where a few places where the stack isn't properly aligned for X86 when we call into C++ code.
Two places are where we call into exception handling code, the LLInt and from nativeForGenerator.
The other place was when we call into the operationOSRWriteBarrier().

Added an assert check that the stack is aligned on X86 platforms in the native call tracing code.
This helped find the other cases beyond the original problem.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::osrWriteBarrier):

  • interpreter/FrameTracers.h:

(JSC::assertStackPointerIsAligned):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • llint/LowLevelInterpreter32_64.asm:
10:38 AM Changeset in webkit [227151] by jdiggs@igalia.com
  • 6 edits
    3 adds in trunk

[GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
​https://bugs.webkit.org/show_bug.cgi?id=176796

Reviewed by Chris Fleizach.

Tools:

Add sanity check that we have a URL before calling g_strstr_len().

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::url):

LayoutTests:

Remove failing tests from Test Expectations. Update expected results of
xml-roles-exposed to reflect several bug fixes which were made in the
interim. Modify add-children-pseudo-element.html to account for platform
differences in the accessibility tree. Add an additional URL test because
we didn't have coverage for getting the URL of accessible links resulting
from native anchor elements.

  • accessibility/add-children-pseudo-element.html: Modified.
  • accessibility/gtk/link-url-expected.txt: Added.
  • accessibility/gtk/link-url.html: Added.
  • accessibility/gtk/xml-roles-exposed-expected.txt: Updated.
  • platform/gtk/TestExpectations: Removed failing tests.
  • platform/gtk/accessibility/add-children-pseudo-element-expected.txt: Added.
10:31 AM Changeset in webkit [227150] by Ryan Haddad
  • 2 edits in trunk/Tools

Add triggers for Sierra test262 and perf queues
​https://bugs.webkit.org/show_bug.cgi?id=181799

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:15 AM Changeset in webkit [227149] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227146. rdar://problem/36624319

10:12 AM Changeset in webkit [227148] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked multiple imported/w3c/web-platform-tests/service-workers/ test as flaky
​https://bugs.webkit.org/show_bug.cgi?id=181750

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:50 AM Changeset in webkit [227147] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%
​https://bugs.webkit.org/show_bug.cgi?id=181460
<rdar://problem/36379776>

Reviewed by Ryosuke Niwa.

  • css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):

Don't do the expensive security origin test if the supplied sheet base URL is null. This
is true for rules coming from the same document.

9:49 AM Changeset in webkit [227146] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

REGRESSION(r225858): Sandbox violations due to blocked access to Spotlight search preferences
​https://bugs.webkit.org/show_bug.cgi?id=181797
<rdar://problem/36546412>

Reviewed by Eric Carlson.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add the read permission for

'com.apple.lookup.shared' to support DataDetectors.

9:37 AM Changeset in webkit [227145] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (r223604): Setting :before/after pseudo element on <noscript> asserts
​https://bugs.webkit.org/show_bug.cgi?id=181795
<rdar://problem/36334524>

Reviewed by David Kilzer.

Source/WebCore:

<noscript> disallows renderer generation outside CSS mechanisms, however we would still construct
PseudoElements for them during style resolution. These were never removed properly because the
pseudo element removal was tied to render tree teardown. Without proper removal the associated
animations were also not canceled.

Test: fast/css-generated-content/noscript-pseudo-anim-crash.html

  • dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

Take care to get rid of PseudoElements when the element is removed from the tree.
This also cancels any associated animations.

LayoutTests:

  • fast/css-generated-content/noscript-pseudo-anim-crash-expected.txt: Added.
  • fast/css-generated-content/noscript-pseudo-anim-crash.html: Added.
9:26 AM Changeset in webkit [227144] by Chris Fleizach
  • 8 edits
    2 adds in trunk

AX: Aria-activedescendant not supported
​https://bugs.webkit.org/show_bug.cgi?id=161734
<rdar://problem/28202679>

Reviewed by Joanmarie Diggs.

Source/WebCore:

When a combo-box owns/controls a list/listbox/grid/tree, the owned element needs to check the active-descendant of the combobox when
checking if it has selected children.
The target of the selection change notification should also be the owned element in these cases.

Test: accessibility/aria-combobox-controlling-list.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectedListItem):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::targetElementForActiveDescendant const):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::canHaveSelectedChildren const):
(WebCore::AccessibilityRenderObject::selectedChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • accessibility/aria-combobox-control-owns-elements-expected.txt: Added.
  • accessibility/aria-combobox-control-owns-elements.html: Added.
8:52 AM Changeset in webkit [227143] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html as failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=181662

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:46 AM Changeset in webkit [227142] by mitz@apple.com
  • 3 edits in trunk

[Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
​https://bugs.webkit.org/show_bug.cgi?id=181784

Reviewed by Anders Carlsson.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
8:13 AM Changeset in webkit [227141] by pvollan@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION (r224780): Text stroke not applied to video captions.
​https://bugs.webkit.org/show_bug.cgi?id=181743
<rdar://problem/35874338>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: media/track/track-css-visible-stroke-expected.html

media/track/track-css-visible-stroke.html

After r224780, it is no longer possible to mix text stroke styles with webkit
legacy text stroke styles.

  • css/StyleResolver.cpp:

(WebCore::isValidCueStyleProperty):

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS const):

LayoutTests:

  • media/track/track-css-stroke-cues-expected.txt:
  • media/track/track-css-stroke-cues.html:
  • media/track/track-css-visible-stroke-expected.html: Added.
  • media/track/track-css-visible-stroke.html: Added.
7:42 AM Changeset in webkit [227140] by aestes@apple.com
  • 13 edits
    2 adds in trunk

[Payment Request] Support a default shipping address for Apple Pay
​https://bugs.webkit.org/show_bug.cgi?id=181754
<rdar://problem/36009733>

Reviewed by Brady Eidson.

Source/WebCore:

Move shippingContact from ApplePayPaymentRequest to ApplePayRequestBase. This allows
merchants to specify a default shipping address when using Apple Pay with Payment Request.

This also fixes a bug found during testing where
+[NSPersonNameComponentsFormatter localizedStringFromPersonNameComponents:style:options:]
would throw an exception when passed a nil NSPersonNameComponents.

Test: http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html

  • Modules/applepay/ApplePayPaymentRequest.h:
  • Modules/applepay/ApplePayPaymentRequest.idl:
  • Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/ApplePayRequestBase.h:
  • Modules/applepay/ApplePayRequestBase.idl:
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/ApplePaySessionPaymentRequest.h:

(WebCore::ApplePaySessionPaymentRequest::version const):
(WebCore::ApplePaySessionPaymentRequest::setVersion):

  • Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::convert):

  • Modules/applepay/paymentrequest/ApplePayRequest.idl:
  • testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeMerchantValidation):

  • testing/MockPaymentCoordinator.h:

LayoutTests:

  • http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html: Added.
6:33 AM Changeset in webkit [227139] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=181435

Patch by Ali Juma <​ajuma@chromium.org> on 2018-01-18
Reviewed by Frédéric Wang.

Test gardening. The flakiness was fixed by r227054, so remove the test expectation.

2:11 AM Changeset in webkit [227138] by Carlos Garcia Campos
  • 3 edits in trunk/WebDriverTests

Unreviewed. Update Selenium WebDriver imported tests.

  • imported/selenium/importer.json:
  • imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py:

(reset_timeouts):

12:33 AM Changeset in webkit [227137] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Layout Test http/tests/images/image-supports-video.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=181008
<rdar://problem/36143943>

Reviewed by Youenn Fablet.

Send a "Cache-control: nocache" header from the HTTP server when the image resource is
requested.

  • http/tests/resources/redirect-to-video-if-accepted.php:
  • platform/mac-wk1/TestExpectations:
12:27 AM Changeset in webkit [227136] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r227096.
​https://bugs.webkit.org/show_bug.cgi?id=181788

"it caused a 15% octane regression" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"Support MultiGetByOffset in the DFG"
​https://bugs.webkit.org/show_bug.cgi?id=181466
​https://trac.webkit.org/changeset/227096

12:24 AM Changeset in webkit [227135] by Wenson Hsieh
  • 5 edits in trunk

[iOS] Specify -[NSURL _title] for the associated URL when copying an image element
​https://bugs.webkit.org/show_bug.cgi?id=181783
<rdar://problem/35785445>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Always specify the -[NSURL _title] to be either the title specified in a PasteboardImage's inner PasteboardURL,
or if no title is specified, fall back to the user-visible URL string. This is because at least one internal
client always tries to use the -_title property to determine the title of a pasted URL, or if none is specified,
the -suggestedName. Since we need to set suggestedName to the preferred file name of the copied image and we
don't want the suggested name to become the title of the link, we need to explicitly set the link title.

In doing so, this patch also fixes a bug wherein we forget to set the _title of the NSURL we're registering to
an NSItemProvider.

Tests: ActionSheetTests.CopyImageElementWithHREFAndTitle (new)

ActionSheetTests.CopyImageElementWithHREF (modified)

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

Tools:

Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
copying an image contains a relevant title.

  • TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/ios/DataInteractionSimulator.mm:
  • TestWebKitAPI/ios/UIKitSPI.h:
Note: See TracTimeline for information about the timeline view.