Context Navigation

AsyncScrollingCoordinator::frameViewLayoutUpdated() is called every time a subframe lays out.
We don't need to eagerly update the non-fast scrollable region at this time; we can just mark
it dirty, and rely on the existing scrolling tree commit code to recompute it.

On my machine this makes fast/frames/lots-of-objects.html no longer a timeout.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):

LayoutTests:

platform/mac-wk2/TestExpectations: fast/frames/lots-of-objects.html is no longer always a timeout.

8:39 PM Changeset in webkit [227395] by Dewei Zhu

2 edits in trunk/Websites/perf.webkit.org

'run-test.py' script should make sure 'node_modules' directory exists before installing node packages.
https://bugs.webkit.org/show_bug.cgi?id=181808

Reviewed by Ryosuke Niwa.

'run-test.py' will fail if 'node_modules' does not exist before running this script.
Instead of calling 'os.chdir' to change directory, use 'cwd' in subprocess instead.

tools/run-tests.py: Added the logic to ensure 'node_modules' exists.

Also use 'cwd' in subprocess.call instead of calling 'os.chdir' ahead.

8:08 PM Changeset in webkit [227394] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227218. rdar://problem/36746114

8:08 PM Changeset in webkit [227393] by jmarcell@apple.com

10 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227275. rdar://problem/36745983

8:08 PM Changeset in webkit [227392] by jmarcell@apple.com

16 edits in branches/safari-605-branch/Source

Cherry-pick r227282. rdar://problem/36746077

8:08 PM Changeset in webkit [227391] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227298. rdar://problem/36746084

8:08 PM Changeset in webkit [227390] by jmarcell@apple.com

4 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227338. rdar://problem/36746095

8:08 PM Changeset in webkit [227389] by jmarcell@apple.com

10 edits in branches/safari-605-branch

Cherry-pick r227339. rdar://problem/36745908

8:08 PM Changeset in webkit [227388] by jmarcell@apple.com

4 edits
1 add in branches/safari-605-branch

Cherry-pick r227341. rdar://problem/36746038

8:08 PM Changeset in webkit [227387] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227343. rdar://problem/36746168

8:08 PM Changeset in webkit [227386] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227345. rdar://problem/36745991

8:08 PM Changeset in webkit [227385] by jmarcell@apple.com

5 edits
2 adds in branches/safari-605-branch

Cherry-pick r227346. rdar://problem/36746149

8:08 PM Changeset in webkit [227384] by jmarcell@apple.com

4 edits
3 adds in branches/safari-605-branch

Cherry-pick r227348. rdar://problem/36746180

8:08 PM Changeset in webkit [227383] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227349. rdar://problem/36746053

7:00 PM Changeset in webkit [227382] by jiewen_tan@apple.com

24 edits
4 copies
21 adds in trunk

[WebAuthN] Implement PublicKeyCredential's Create with a dummy authenticator
https://bugs.webkit.org/show_bug.cgi?id=181928
<rdar://problem/36459893>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch implements PublicKeyCredential's Create from https://www.w3.org/TR/webauthn/#createCredential
as of 5 December 2017. In order to do testing, a dummy authenticator is implemented to exercise a failure
and a pass path. A number of dependencies need to be resolved later in order to comply with the spec.
Also, the current architecture of handling async WebAuthN operations including dispatching, timeout, and aborting
might need a redesign once the underlying authenticator is clear. Since this is our first attempt to implement
a prototype, all those limitations, in my opinion, can be marked as non-blocking to accelerate the whole
process. Those limitations will then be addressed once the first prototype is finshed.

Tests: http/tests/webauthn/public-key-credential-create-with-invalid-parameters.https.html

http/tests/webauthn/public-key-credential-same-origin-with-ancestors-2.https.html
http/tests/webauthn/public-key-credential-same-origin-with-ancestors.https.html
http/wpt/webauthn/idl.https.html
http/wpt/webauthn/public-key-credential-create-failure.https.html
http/wpt/webauthn/public-key-credential-create-success.https.html

Modules/credentialmanagement/BasicCredential.h:
Modules/credentialmanagement/BasicCredential.idl:
Modules/credentialmanagement/CredentialsContainer.cpp:

(WebCore::CredentialsContainer::PendingPromise::PendingPromise):
(WebCore::CredentialsContainer::dispatchTask):
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
(WebCore::CredentialsContainer::preventSilentAccess const):
(WebCore::CredentialsContainer::preventSilentAccess): Deleted.

Modules/credentialmanagement/CredentialsContainer.h:

(WebCore::CredentialsContainer::PendingPromise::create):

Modules/webauthn/Authenticator.cpp: Copied from Source/WebCore/Modules/webauthn/AuthenticatorResponse.cpp.

(WebCore::Authenticator::singleton):
(WebCore::Authenticator::makeCredential const):

Modules/webauthn/Authenticator.h: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h.
Modules/webauthn/AuthenticatorAssertionResponse.cpp:

(WebCore::AuthenticatorAssertionResponse::authenticatorData const):
(WebCore::AuthenticatorAssertionResponse::signature const):
(WebCore::AuthenticatorAssertionResponse::userHandle const):
(WebCore::AuthenticatorAssertionResponse::~AuthenticatorAssertionResponse): Deleted.
(WebCore::AuthenticatorAssertionResponse::authenticatorData): Deleted.
(WebCore::AuthenticatorAssertionResponse::signature): Deleted.
(WebCore::AuthenticatorAssertionResponse::userHandle): Deleted.

Modules/webauthn/AuthenticatorAssertionResponse.h:

(WebCore::AuthenticatorAssertionResponse::create):

Modules/webauthn/AuthenticatorAttestationResponse.cpp:

(WebCore::AuthenticatorAttestationResponse::attestationObject const):
(WebCore::AuthenticatorAttestationResponse::~AuthenticatorAttestationResponse): Deleted.
(WebCore::AuthenticatorAttestationResponse::attestationObject): Deleted.

Modules/webauthn/AuthenticatorAttestationResponse.h:

(WebCore::AuthenticatorAttestationResponse::create):

Modules/webauthn/AuthenticatorResponse.cpp:

(WebCore::AuthenticatorResponse::clientDataJSON const):
(WebCore::AuthenticatorResponse::~AuthenticatorResponse): Deleted.
(WebCore::AuthenticatorResponse::clientDataJSON): Deleted.

Modules/webauthn/AuthenticatorResponse.h:
Modules/webauthn/AuthenticatorResponse.idl:
Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredentialInternal::produceClientDataJson):
(WebCore::PublicKeyCredentialInternal::produceClientDataJsonHash):
(WebCore::PublicKeyCredentialInternal::getIdFromAttestationObject):
(WebCore::PublicKeyCredential::PublicKeyCredential):
(WebCore::PublicKeyCredential::discoverFromExternalSource):
(WebCore::PublicKeyCredential::create):
(WebCore::PublicKeyCredential::rawId const):
(WebCore::PublicKeyCredential::response const):
(WebCore::PublicKeyCredential::getClientExtensionResults const):
(WebCore::PublicKeyCredential::rawId): Deleted.
(WebCore::PublicKeyCredential::response): Deleted.
(WebCore::PublicKeyCredential::getClientExtensionResults): Deleted.

Modules/webauthn/PublicKeyCredential.h:
Modules/webauthn/PublicKeyCredential.idl:
Modules/webauthn/PublicKeyCredentialCreationOptions.h:

(): Deleted.

Modules/webauthn/PublicKeyCredentialDescriptor.h:
Modules/webauthn/PublicKeyCredentialDescriptor.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSAuthenticatorResponseCustom.cpp: Copied from Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp.

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSBasicCredentialCustom.cpp: Copied from Source/WebCore/Modules/webauthn/AuthenticatorResponse.cpp.

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSBindingsAllInOne.cpp:

LayoutTests:

Test cases are divided into two different folders. One follows wpt style. The other contains tests
that I don't know how to write them in wpt style.

http/tests/webauthn/public-key-credential-create-with-invalid-parameters.https-expected.txt: Added.
http/tests/webauthn/public-key-credential-create-with-invalid-parameters.https.html: Added.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors-2.https-expected.txt: Added.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors-2.https.html: Added.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt: Added.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors.https.html: Added.
http/tests/webauthn/resources/last-layer-frame.https.html: Added.
http/tests/webauthn/resources/second-layer-frame.https.html: Added.
http/tests/webauthn/resources/util.js: Added.

It will be good to convert them into wpt style.

http/wpt/webauthn/WebAuthN.idl: Added.
http/wpt/webauthn/idl.https-expected.txt: Added.
http/wpt/webauthn/idl.https.html: Added.
http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt: Added.
http/wpt/webauthn/public-key-credential-create-failure.https.html: Added.
http/wpt/webauthn/public-key-credential-create-success.https-expected.txt: Added.
http/wpt/webauthn/public-key-credential-create-success.https.html: Added.
http/wpt/webauthn/resources/util.js: Added.

6:09 PM Changeset in webkit [227381] by mmaxfield@apple.com

13 edits in trunk/Source/WebCore

[Cocoa] Support font collections
https://bugs.webkit.org/show_bug.cgi?id=181826
<rdar://problem/36455137>

Reviewed by Dean Jackson.

Source/WebCore:

Use the CoreText call CTFontManagerCreateFontDescriptorsFromData() to get all the descriptors inside
the collection file. We select which one by using the fragment identifier at the end of the url linking
to the remote font. For example, to select the 4th font inside a TTC file, the @font-face block would
look like:

@font-face {

font-family: "MyFont";
src: url("path/to/font.ttc#4");

}

Note that these numbers are 1-indexed.

The CSS Fonts spec states:

Fragment identifiers are used to indicate which font to load. If a container format lacks a defined
fragment identifier scheme, implementations should use a simple 1-based indexing scheme (e.g.
"font-collection#1" for the first font, "font-collection#2" for the second font).

Not only are TTC font collections supported, but WOFF2 font collections are also supported, which is
increasingly important web standard.

No new tests because I don't have a font collection file with the appropriate license for the
WebKit repository. I tested manually.

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::calculateIndex const):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createCustomFontData):

loader/cache/CachedFont.h:
platform/graphics/cairo/FontCustomPlatformData.h:
platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/mac/FontCustomPlatformData.h:
platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/win/FontCustomPlatformData.h:
platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::createFontCustomPlatformData):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

6:04 PM Changeset in webkit [227380] by Ryan Haddad

2 edits in trunk/LayoutTests

Skip http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html on Sierra.
https://bugs.webkit.org/show_bug.cgi?id=181833

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

6:00 PM Changeset in webkit [227379] by Simon Fraser

2 edits in trunk/Source/WebCore

REGRESSION (r227011): fast/frames/hidpi-position-iframe-on-device-pixel.html times out
https://bugs.webkit.org/show_bug.cgi?id=181959

Reviewed by Zalan Bujtas.

This test creates 300 iframes, which became slow after r227011 because they all became part
of the non-fast scrollable region, slowing down ScrollingCoordinator::absoluteEventTrackingRegionsForFrame().

Fix by not adding non-scrollable iframes, and making FrameView::isScrollable() more efficient for frames
that have not done layout yet.

page/FrameView.cpp:

(WebCore::FrameView::isScrollable):
(WebCore::FrameView::addChild):

5:54 PM Changeset in webkit [227378] by jonlee@apple.com

2 edits in trunk/Source/WebKit

Update title label size
https://bugs.webkit.org/show_bug.cgi?id=181962
rdar://problem/36754744

Reviewed by Simon Fraser.

UIProcess/ios/WKFullScreenWindowControllerIOS.mm:

(-[_WKFullScreenViewController setLocation:secure:trustedName:trustedSite:]): Move titleLabel properties into
createSubviews.
(-[_WKFullScreenViewController createSubviews]): Set the title label for both the cancel and location buttons.
Refer to a const CGFloat for the font size.

5:45 PM Changeset in webkit [227377] by Megan Gardner

13 edits in trunk/Source/WebKit

Temporarily restore block selection code conditionally
https://bugs.webkit.org/show_bug.cgi?id=181895
<rdar://problem/36567325>

Reviewed by Tim Horton.

We need to restore this code temporarily to avoid a crash.

Platform/spi/ios/UIKitSPI.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]):

5:37 PM Changeset in webkit [227376] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK after r227156.

Configurations/WebCore.xcconfig:

5:36 PM Changeset in webkit [227375] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

We should not try to link against the Safe Browsing framework on watchOS and tvOS.
https://bugs.webkit.org/show_bug.cgi?id=181965.

Patch by Zach Li <zacharyli323@gmail.com> on 2018-01-22
Reviewed by Tim Horton.

Configurations/WebKit.xcconfig:

5:34 PM Changeset in webkit [227374] by Simon Fraser

6 edits
4 adds in trunk

REGRESSION (r226981): ASSERTION FAILED: startY >= 0 && endY <= height && startY < endY in WebCore::FEMorphology::platformApplyGeneric
https://bugs.webkit.org/show_bug.cgi?id=181836

Reviewed by Tim Horton.
Source/WebCore:

All the filters that use ParallelJobs<> has the same type of bug where very wide but not tall
filter regions could result in computing an optimalThreadNumber that was greater than the
number of rows to process, which resulted in jobs with zero rows to process.

Since we split the work by rows, cap the maximum number of threads to height/8 so that each job
has at least 8 rows of pixels to process. Add some assertions to detect jobs with zero rows.

FEMorphology was also using implicit float -> int conversion to detect integer overflow of radius,
so change that to use explicit clamping.

Tests: svg/filters/feLighting-parallel-jobs.svg

svg/filters/feTurbulence-parallel-jobs-wide.svg

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::platformApplyGeneric):

platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApply):
(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

svg/filters/feLighting-parallel-jobs.svg: Added.
svg/filters/feMorphology-invalid-radius.svg: Change the test to detect the bug on non-Retina too.
svg/filters/feTurbulence-parallel-jobs-wide.svg: Added.

5:29 PM Changeset in webkit [227373] by Ryan Haddad

3 edits in trunk/Source/WebCore

Resign NowPlaying status when no media element is eligible
https://bugs.webkit.org/show_bug.cgi?id=181914
<rdar://problem/35294116>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-01-22
Reviewed by Jer Noble.

No new tests, these changes prevent existing tests from crashing.

html/HTMLMediaElement.h:
html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted const): Return early when the media
element has been suspended.
(WebCore::MediaElementSession::canShowControlsManager const): Return false when the
media element has been suspended.
(WebCore::isMainContentForPurposesOfAutoplay): Return early if it isn't safe to update
style because HitTest can force a layout.
(WebCore::MediaElementSession::updateIsMainContent const): Ditto.

5:25 PM Changeset in webkit [227372] by achristensen@apple.com

8 edits
4 deletes in trunk/Source

Begin removing QTKit code
https://bugs.webkit.org/show_bug.cgi?id=181951

Reviewed by Jer Noble.

Source/WebCore:

QTKit was being used on El Capitan and before.

Configurations/WebCore.xcconfig:
SourcesMac.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):
(WebCore::MediaPlayer::supportsType):

platform/graphics/mac/MediaPlayerPrivateQTKit.h: Removed.
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Removed.
platform/graphics/mac/MediaTimeQTKit.h: Removed.
platform/graphics/mac/MediaTimeQTKit.mm: Removed.
platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController updatePowerAssertions]):

Source/WTF:

wtf/Platform.h:

5:09 PM Changeset in webkit [227371] by Wenson Hsieh

2 edits in trunk/Source/WebKitLegacy/mac

WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
https://bugs.webkit.org/show_bug.cgi?id=181960
<rdar://problem/36431678>

Reviewed by Tim Horton.

Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.

This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.

WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

4:52 PM Changeset in webkit [227370] by Nikita Vasilyev

7 edits
2 adds in trunk

Web Inspector: Styles Redesign: data corruption when updating values quickly
https://bugs.webkit.org/show_bug.cgi?id=179461
<rdar://problem/35431882>

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Data corruption used to happen because CSSStyleDeclaration.prototype.text didn't
update synchronously. Making two or more quick changes resulted in corrupted data.

Imagine we modify a CSS value 3 times:

Front-end: (1)-(2)---(3)
Back-end: (1)-----(2)-(3)

The first response from the backend could happen after the 2nd edit. In this patch,
CSSStyleDeclaration is locked when its view is being edited.

To correctly display invalid and overridden properties, the backend is allowed to update
CSSStyleDeclaration and CSSProperty when they're locked if the text from the backend
matches the model's text. This should happen when the backend is caught up with the
front-end changes.

UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype.update):

UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration):
(WI.CSSStyleDeclaration.prototype.get locked):
(WI.CSSStyleDeclaration.prototype.set locked):
(WI.CSSStyleDeclaration.prototype.set text):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.detached):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get editing):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set focused):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set inlineSwatchActive):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.stylePropertyInlineSwatchActivated):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.stylePropertyInlineSwatchDeactivated):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._updateStyleLock):
Lock CSSStyleDeclaration when a CSS property name or value is focused or
an inline widget is active.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
When selector is focused, clicking on the white-space should not add a new blank property.

LayoutTests:

inspector/css/modify-css-property-expected.txt: Added.
inspector/css/modify-css-property.html: Added.

4:45 PM Changeset in webkit [227369] by Matt Lewis

2 edits in trunk/LayoutTests

Marked fast/forms/searchfield-heights.html as flaky on High Sierra.
https://bugs.webkit.org/show_bug.cgi?id=181914

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:01 PM Changeset in webkit [227368] by Matt Lewis

2 edits in trunk/LayoutTests

Skipped http/tests/resourceLoadStatistics/grandfathering.html.
https://bugs.webkit.org/show_bug.cgi?id=181482

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

2:53 PM Changeset in webkit [227367] by jmarcell@apple.com

7 edits in tags/Safari-606.1.2.2/Source

Versioning.

2:45 PM Changeset in webkit [227366] by jmarcell@apple.com

1 copy in tags/Safari-606.1.2.2

New tag.

2:38 PM Changeset in webkit [227365] by Ryan Haddad

3 edits in trunk/LayoutTests

Mark inspector/debugger/tail-deleted-frames-from-vm-entry.html as slow on macOS Debug.
https://bugs.webkit.org/show_bug.cgi?id=181952

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

2:28 PM Changeset in webkit [227364] by achristensen@apple.com

52 edits
8 deletes in trunk/Source/WebKit

Remove pre-NetworkSession loading code
https://bugs.webkit.org/show_bug.cgi?id=181944

Reviewed by Tim Horton.

We were keeping it around for El Capitan.

NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:

(WebKit::LegacyCustomProtocolManager::registerProtocolClass):

NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:

(WebKit::LegacyCustomProtocolManager::initialize):

NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
NetworkProcess/Downloads/BlobDownloadClient.cpp: Removed.
NetworkProcess/Downloads/BlobDownloadClient.h: Removed.
NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::~Download):
(WebKit::Download::cancel):
(WebKit::Download::didReceiveChallenge):
(WebKit::Download::didFinish):
(WebKit::Download::isAlwaysOnLoggingAllowed const):
(WebKit::Download::start): Deleted.
(WebKit::Download::startWithHandle): Deleted.
(WebKit::Download::didStart): Deleted.
(WebKit::Download::willSendRedirectedRequest): Deleted.
(WebKit::Download::didReceiveAuthenticationChallenge): Deleted.
(WebKit::Download::didReceiveResponse): Deleted.
(WebKit::Download::shouldDecodeSourceDataOfMIMEType): Deleted.
(WebKit::Download::decideDestinationWithSuggestedFilename): Deleted.
(WebKit::Download::decideDestinationWithSuggestedFilenameAsync): Deleted.
(WebKit::Download::didDecideDownloadDestination): Deleted.
(WebKit::Download::continueDidReceiveResponse): Deleted.

NetworkProcess/Downloads/Download.h:

(WebKit::Download::setBlobFileReferences): Deleted.
(WebKit::Download::request const): Deleted.

NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::willDecidePendingDownloadDestination):
(WebKit::DownloadManager::convertNetworkLoadToDownload):
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
(WebKit::DownloadManager::resumeDownload):
(WebKit::DownloadManager::cancelDownload):

NetworkProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::startDownload):

NetworkProcess/Downloads/PendingDownload.cpp:
NetworkProcess/Downloads/PendingDownload.h:
NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
NetworkProcess/Downloads/ios/DownloadIOS.mm: Removed.
NetworkProcess/Downloads/mac/DownloadMac.mm: Removed.
NetworkProcess/NetworkCORSPreflightChecker.cpp:
NetworkProcess/NetworkCORSPreflightChecker.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

NetworkProcess/NetworkDataTask.cpp:
NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkDataTaskBlob.cpp:
NetworkProcess/NetworkDataTaskBlob.h:
NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::setDefersLoading):
(WebKit::NetworkLoad::cancel):
(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::shouldCaptureExtraNetworkLoadMetrics const):
(WebKit::NetworkLoad::didReceiveResponseAsync): Deleted.
(WebKit::NetworkLoad::didReceiveBuffer): Deleted.
(WebKit::NetworkLoad::didFinishLoading): Deleted.
(WebKit::NetworkLoad::didFail): Deleted.
(WebKit::NetworkLoad::willSendRequestAsync): Deleted.
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync): Deleted.
(WebKit::NetworkLoad::shouldUseCredentialStorage): Deleted.
(WebKit::NetworkLoad::didReceiveAuthenticationChallenge): Deleted.
(WebKit::NetworkLoad::receivedCancellation): Deleted.

NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkLoadParameters.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::clearCachedCredentials):
(WebKit::NetworkProcess::findPendingDownloadLocation):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):

NetworkProcess/NetworkSession.cpp:
NetworkProcess/NetworkSession.h:
NetworkProcess/PingLoad.cpp:
NetworkProcess/PingLoad.h:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):

NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

NetworkProcess/cocoa/NetworkSessionCocoa.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:
NetworkProcess/mac/NetworkLoadMac.mm: Removed.
NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):

Shared/Authentication/AuthenticationManager.h:
Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: Removed.
Shared/SessionTracker.cpp:

(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):

Shared/SessionTracker.h:
Shared/mac/CookieStorageShim.h: Removed.
Shared/mac/CookieStorageShim.mm: Removed.
UIProcess/API/APIDownloadClient.h:

(API::DownloadClient::didReceiveData):
(API::DownloadClient::shouldDecodeSourceDataOfMIMEType): Deleted.

UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

UIProcess/Cocoa/DownloadClient.h:
UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::shouldDecodeSourceDataOfMIMEType): Deleted.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::didReceiveResponse):
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType): Deleted.
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename): Deleted.

UIProcess/Downloads/DownloadProxy.h:
UIProcess/Downloads/DownloadProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearCachedCredentials):

config.h:

2:21 PM Changeset in webkit [227363] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/browsers/offline/manifest_url_check.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179851

Unreviewed test gardening.

TestExpectations:

2:17 PM Changeset in webkit [227362] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227213. rdar://problem/36722644

2:17 PM Changeset in webkit [227361] by jmarcell@apple.com

24 edits
11 adds
4 deletes in branches/safari-605-branch/Source/WebCore

Cherry-pick r227190. rdar://problem/36722644

2:17 PM Changeset in webkit [227360] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227176. rdar://problem/36723030

2:17 PM Changeset in webkit [227359] by jmarcell@apple.com

8 edits
4 adds in branches/safari-605-branch

Cherry-pick r227174. rdar://problem/36723030

2:15 PM Changeset in webkit [227358] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

SW: Make sure ServiceWorker loading and requests are correctly cleared by ITP
https://bugs.webkit.org/show_bug.cgi?id=181942
<rdar://problem/35132091>

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-22
Reviewed by Chris Dumez.

Add ServiceWorkerRegistrations and DOMCache as persistent data to be cleared according ITP decisions.

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes):

2:12 PM Changeset in webkit [227357] by pvollan@apple.com

2 edits in trunk/Source/WebCore

[Win] Null pointer crash under WebCore::RenderStyle::colorIncludingFallback.
https://bugs.webkit.org/show_bug.cgi?id=181801
<rdar://problem/35614900>

Reviewed by Brent Fulgham.

Do not paint synchronously when popup items have been added or changed while the popup is visible.
If new popup items have been added after the popup was shown, a synchronous paint operation will
possibly access their style before it is ready, leading to a null pointer crash. The invalidated
area will be painted asynchronously.

No new tests. To reproduce this crash, it is necessary to open a popup with JavaScript, add new
popup items, and then end the test. Opening the popup can be done by sending a mousedown event
with the eventsender. However, on Windows the mousedown event is sent synchronously, and will
block as long as the popup is open and running the popup event loop. This means no JS can be
executed until the popup is closed, causing the test to always time out before new popup items
can be added. I have verified the fix with a manual test case.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::updateFromElement):

2:08 PM Changeset in webkit [227356] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not.
https://bugs.webkit.org/show_bug.cgi?id=181906

Reviewed by Ryosuke Niwa.

Before this change, 'ifBuilt' will always set specified property for test properties as long as there
is a build type build in the same build request group. However, this is no longer valid as we don't
want to set specified property for testing when only owned commit is built in previous build.
'ifBuilt' needs to conditionally set property based on whether certain required repositories are built.
Empty required repository list means no requirement on repository to set property.

tools/js/buildbot-syncer.js:

(BuildbotSyncer.prototype._propertiesForBuildRequest):In the case of 'built', only set property when
repository requirment is meet and there is a 'build' root request in the same build request group.
(BuildbotSyncer._parseRepositoryGroup): Extend 'ifBuild' to pass information based on contition.

unit-tests/buildbot-syncer-tests.js: Added unit tests.

1:49 PM Changeset in webkit [227355] by Megan Gardner

13 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227274. rdar://problem/36722660

2018-01-20 Andy Estes <aestes@apple.com>

[Apple Pay] Stop eagerly loading PassKit.framework
https://bugs.webkit.org/show_bug.cgi?id=181911
<rdar://problem/36555369>

Reviewed by Tim Horton.

Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
Shared/WebPageCreationParameters.h:

Removed availablePaymentNetworks from WebPageCreationParameters.

UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetApplePayEnabled):
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]):

Stopped calling WebPaymentCoordinatorProxy::platformSupportsPayments().

UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp: (WebKit::WebPaymentCoordinatorProxy::availablePaymentNetworks):
UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:

Added message AvailablePaymentNetworks, which synchronously returns a Vector of payment
networks.

UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments):

Returned false if PassKitLibrary() fails.

(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):

Called completionHandler with false if PassKitLibrary() fails.

(WebKit::WebPaymentCoordinatorProxy::platformAvailablePaymentNetworks):
(WebKit::WebPaymentCoordinatorProxy::availablePaymentNetworks):

Renamed availablePaymentNetworks to platformAvailablePaymentNetworks

(WebKit::WebPaymentCoordinatorProxy::platformSupportsPayments): Deleted.

UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: (WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

Called completionHandler with false if PassKitLibrary() fails.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters):

Stopped calling WebPaymentCoordinatorProxy::availablePaymentNetworks().

WebProcess/ApplePay/WebPaymentCoordinator.cpp: (WebKit::WebPaymentCoordinator::availablePaymentNetworks): (WebKit::WebPaymentCoordinator::validatedPaymentNetwork):
WebProcess/ApplePay/WebPaymentCoordinator.h:

Implemented PaymentCoordinatorClient::validatedPaymentNetwork(). m_availablePaymentNetworks
starts off as std::nullopt, but is initialized by sending the AvailablePaymentNetworks sync
message the first time it's accessed.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):

Stopped setting PageConfiguration::availablePaymentNetworks.

Patch by Jason Marcell <jmarcell@apple.com> on 2018-01-22

1:32 PM Changeset in webkit [227354] by Matt Lewis

2 edits in trunk/LayoutTests

Marked http/wpt/service-workers/update-service-worker.https.html as flaky on High Sierra release.
https://bugs.webkit.org/show_bug.cgi?id=181753

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:27 PM Changeset in webkit [227353] by Chris Dumez

2 edits in trunk/Source/WebCore

RELEASE_ASSERT(registration) hit in SWServer::installContextData(const ServiceWorkerContextData&)
https://bugs.webkit.org/show_bug.cgi?id=181941
<rdar://problem/36744892>

Reviewed by Youenn Fablet.

Make sure we clear SWServer::m_pendingContextDatas & SWServer::m_pendingJobs as needed
when clearing Website data. Otherwise, we will hit assertion when those gets processed
after the connection to the SW process has been established (not to mentioned we failed
to clear some in-memory data even though the user asked us to).

workers/service/server/SWServer.cpp:

(WebCore::SWServer::clearAll):
(WebCore::SWServer::clear):

1:25 PM Changeset in webkit [227352] by jmarcell@apple.com

1 copy in tags/Safari-606.1.1.2

New tag.

1:13 PM Changeset in webkit [227351] by rniwa@webkit.org

6 edits
1 add in trunk

Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
https://bugs.webkit.org/show_bug.cgi?id=181616
<rdar://problem/36484908>

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by WebContentReader::readHTML and WebContentMarkupReader::readHTML not sanitizing plain HTML string
as done for web archives even when custom pasteboard data is enabled. Fixed the bug by doing the sanitization.

Unfortunately, we can't make file URLs available in this case because WebContent process doesn't have sandbox extensions
to access local files referenced by the HTML source in the clipboard, and we can't make WebContent process request for
a sandbox extension¸on an arbitrary local file, as it would defeat the whole point of sandboxing.

Instead, we strip away all HTML attributes referencing a URL whose scheme is not HTTP, HTTPS, or data when sanitizing
text/html from the clipboard to avoid exposing local file paths, which can reveal privacy & security sensitive data
such as the user's full name, and the location of private containers of other applications in the system.

Tests: PasteHTML.DoesNotSanitizeHTMLWhenCustomPasteboardDataIsDisabled

PasteHTML.DoesNotStripFileURLsWhenCustomPasteboardDataIsDisabled
PasteHTML.ExposesHTMLTypeInDataTransfer
PasteHTML.KeepsHTTPURLs
PasteHTML.SanitizesHTML
PasteHTML.StripsFileURLs

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::WebContentReader::readHTML): Fixed the bug by sanitizing the markup, and stripping away file URLs.
(WebCore::WebContentMarkupReader::readHTML): Ditto.

editing/markup.cpp:

(WebCore::removeSubresourceURLAttributes): Added.
(WebCore::sanitizeMarkup): Added.

editing/markup.h:

Tools:

Added tests to make sure we sanitize plain HTML, not just web archives,
when and only when custom pasteboard data is enabled.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.

(writeHTMLToPasteboard): Added.
(createWebViewWithCustomPasteboardDataSetting): Added.

1:08 PM Changeset in webkit [227350] by Chris Dumez

11 edits in trunk/Source

Add release logging to help debug issues related to service workers
https://bugs.webkit.org/show_bug.cgi?id=181935
<rdar://problem/36735900>

Reviewed by Brady Eidson.

Source/WebCore:

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
(WebCore::ServiceWorker::postMessage):
(WebCore::ServiceWorker::isAlwaysOnLoggingAllowed const):

workers/service/ServiceWorker.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::updateRegistration):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::isAlwaysOnLoggingAllowed const):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):
(WebCore::ServiceWorkerRegistration::scheduleTaskToFireUpdateFoundEvent):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::didFinishActivation):
(WebCore::SWServer::terminateWorkerInternal):

workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::runRegisterJob):

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::didFinishFetch):
(WebKit::WebSWServerConnection::didFailFetch):
(WebKit::WebSWServerConnection::didNotHandleFetch):

1:01 PM Changeset in webkit [227349] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] REGRESSION (r225763): Allow access to power logging features
https://bugs.webkit.org/show_bug.cgi?id=181938
<rdar://problem/36442803>

Reviewed by Eric Carlson.

I denied access to the powerlog facility in r225763, not realizing that it
gets activated in certain logging scenarios. This patch reverts this change.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

12:22 PM Changeset in webkit [227348] by Chris Dumez

4 edits
3 adds in trunk

Safari Tech Preview can't use GitHub login at forums.swift.org
https://bugs.webkit.org/show_bug.cgi?id=181908
<rdar://problem/36715111>

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-22
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/wpt/service-workers/navigation-redirect.https.html

For subresource loads, redirections will not change who is in charge of continuing the load (service worker or network process).
For navigation loads, we need to match the registration for every redirection since this is using the Manual redirect mode.
This allows starting the load with a service worker and finishing the load with another service worker, which will become the controller.

Implement this by wrapping the registration matching of an URL within DocumentLoader::matchRegistration.
Use that method in DocumentLoader::redirectReceived.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::matchRegistration):
(WebCore::doRegistrationsMatch):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::startLoadingMainResource):

loader/DocumentLoader.h:

LayoutTests:

http/wpt/service-workers/navigation-redirect-worker.js: Added.

(async):

http/wpt/service-workers/navigation-redirect.https-expected.txt: Added.
http/wpt/service-workers/navigation-redirect.https.html: Added.

12:18 PM Changeset in webkit [227347] by Antti Koivisto

2 edits in trunk/PerformanceTests

StyleBench: Separate test for :nth pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=181932

Reviewed by Sam Weinig.

Optimization strategies for nth are different from other structural pseudo classes (:first-child etc). Move them to a separate test.

StyleBench/resources/style-bench.js:

(structuralPseudoClassConfiguration):
(nthPseudoClassConfiguration):

Add a new configuration.

(predefinedConfigurations):
(pseudoClassConfiguration): Deleted.

12:07 PM Changeset in webkit [227346] by Antti Koivisto

5 edits
2 adds in trunk

REGRESSION (Safari 11): Buttons inside a fieldset legend cannot be clicked on in Safari 11
https://bugs.webkit.org/show_bug.cgi?id=179666
<rdar://problem/35534292>

Reviewed by Zalan Bujtas.

Source/WebCore:

The legend element of a fieldset is in the border area, outside the clip rect.
With overflow:hidden mouse events won't reach it.

Test case by Dhaya Benmessaoud.

Test: fast/forms/legend-overflow-hidden-hit-test.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestExcludedChildrenInBorder):

Add a special case to hit testing to handle legend, similarly to what is done for painting.

rendering/RenderBlock.h:

LayoutTests:

fast/forms/legend-overflow-hidden-hit-test-expected.txt: Added.
fast/forms/legend-overflow-hidden-hit-test.html: Added.
platform/ios/TestExpectations:

11:25 AM Changeset in webkit [227345] by Brent Fulgham

3 edits in trunk/Source/WebKit

[macOS, iOS] Allow accss to AVFoundation preference
https://bugs.webkit.org/show_bug.cgi?id=181937
<rdar://problem/33137029>

Reviewed by Eric Carlson.

Grant access to the 'com.apple.avfoundation.frecents' preference.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
WebProcess/com.apple.WebProcess.sb.in:

11:16 AM Changeset in webkit [227344] by jdiggs@igalia.com

15 edits in trunk

AX: Implement support for Graphics ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=181796

Reviewed by Chris Fleizach.

Source/WebCore:

Add mappings for the three new roles (graphics-document, graphics-object,
and graphics-symbol) as per the Graphics Accessibility API Mappings spec.

No new tests; instead, new test cases added to roles-computedRoleString.html
and roles-exposed.html.

accessibility/AccessibilityObject.cpp:

(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::computedRoleString const):

accessibility/AccessibilityObject.h:
accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests:

Add new test cases and update expectations accordingly.

accessibility/gtk/xml-roles-exposed-expected.txt:
accessibility/gtk/xml-roles-exposed.html:
accessibility/roles-computedRoleString.html:
accessibility/roles-exposed.html:
platform/gtk/accessibility/roles-computedRoleString-expected.txt:
platform/gtk/accessibility/roles-exposed-expected.txt:
platform/mac/accessibility/roles-computedRoleString-expected.txt:
platform/mac/accessibility/roles-exposed-expected.txt:

10:48 AM Changeset in webkit [227343] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION(r224535): Can't write reviews in the App Store
https://bugs.webkit.org/show_bug.cgi?id=181936
<rdar://problem/36670246>

Reviewed by Zalan Bujtas.

page/LayoutContext.cpp:

(WebCore::LayoutContext::updateStyleForLayout):

r224535 was about media queries but it also removed a seemingly spurious call to SyleScope::didChangeStyleSheetEnvironment
from the path that does not involve media queries.
Turns out UITextContentView somehow depended on it, so revert this specific change.

10:42 AM Changeset in webkit [227342] by ap@apple.com

2 edits in trunk/Tools

REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
https://bugs.webkit.org/show_bug.cgi?id=181400
rdar://problem/36358768

Reviewed by JF Bastien.

BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.

10:37 AM Changeset in webkit [227341] by msaboff@apple.com

4 edits
1 add in trunk

DFG abstract interpreter needs to properly model effects of some Math ops
https://bugs.webkit.org/show_bug.cgi?id=181886

Reviewed by Saam Barati.

JSTests:

New regression test.

stress/arith-nodes-abstract-interpreter-untypeduse.js: Added.

(test):

Source/JavaScriptCore:

Reviewed the processing of the various ArithXXX and CompareXXX and found that
several nodes don't handle UntypedUse. Added clobberWorld() for those cases.

dfg/DFGAbstractInterpreter.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):

10:35 AM Changeset in webkit [227340] by beidson@apple.com

18 edits
4 adds in trunk/Source

In WebKit2, make the MessagePortChannelRegistry live in the UI process.
https://bugs.webkit.org/show_bug.cgi?id=181922

Reviewed by Andy Estes.

Source/WebCore:

No new tests (Refactor, no behavior change)

Add encoder/decoders and EXPORT a whole bunch of stuff.

WebCore.xcodeproj/project.pbxproj:

dom/MessagePort.h:

dom/messageports/MessagePortChannel.cpp:

(WebCore::MessagePortChannel::processForPort):

dom/messageports/MessagePortChannel.h:

dom/messageports/MessagePortChannelProvider.h:
dom/messageports/MessagePortChannelRegistry.h:

dom/messageports/MessageWithMessagePorts.h:

(WebCore::MessageWithMessagePorts::encode const):
(WebCore::MessageWithMessagePorts::decode):

Source/WebKit:

With all of the work that went into making MessagePorts be fully asynchronous
and to be process-aware, formally moving them out-of-process is just a matter
of adding WebKit IPC layers.

The basic unit of asynchronicity is "MessagePortChannelProvider", and this patch
adds both a WebMessagePortChannelProvider and UIMessagePortChannelProvider for
each side of the process divide.

UIProcess/UIMessagePortChannelProvider.cpp: Added.

(WebKit::UIMessagePortChannelProvider::singleton):
(WebKit::UIMessagePortChannelProvider::UIMessagePortChannelProvider):
(WebKit::UIMessagePortChannelProvider::~UIMessagePortChannelProvider):
(WebKit::UIMessagePortChannelProvider::createNewMessagePortChannel):
(WebKit::UIMessagePortChannelProvider::entangleLocalPortInThisProcessToRemote):
(WebKit::UIMessagePortChannelProvider::messagePortDisentangled):
(WebKit::UIMessagePortChannelProvider::messagePortClosed):
(WebKit::UIMessagePortChannelProvider::takeAllMessagesForPort):
(WebKit::UIMessagePortChannelProvider::postMessageToRemote):
(WebKit::UIMessagePortChannelProvider::checkRemotePortForActivity):
(WebKit::UIMessagePortChannelProvider::checkProcessLocalPortForActivity):

UIProcess/UIMessagePortChannelProvider.h: Added.

(WebKit::UIMessagePortChannelProvider::registry):

UIProcess/WebPageProxy.cpp:

(WebKit::m_configurationPreferenceValues):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::processForIdentifier):
(WebKit::m_userMediaCaptureManagerProxy):
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::createNewMessagePortChannel):
(WebKit::WebProcessProxy::entangleLocalPortInThisProcessToRemote):
(WebKit::WebProcessProxy::messagePortDisentangled):
(WebKit::WebProcessProxy::messagePortClosed):
(WebKit::WebProcessProxy::takeAllMessagesForPort):
(WebKit::WebProcessProxy::didDeliverMessagePortMessages):
(WebKit::WebProcessProxy::postMessageToRemote):
(WebKit::WebProcessProxy::checkRemotePortForActivity):
(WebKit::WebProcessProxy::checkProcessLocalPortForActivity):
(WebKit::WebProcessProxy::didCheckProcessLocalPortForActivity):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:

WebKit.xcodeproj/project.pbxproj:

WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp: Added.

(WebKit::WebMessagePortChannelProvider::singleton):
(WebKit::WebMessagePortChannelProvider::WebMessagePortChannelProvider):
(WebKit::WebMessagePortChannelProvider::~WebMessagePortChannelProvider):
(WebKit::WebMessagePortChannelProvider::createNewMessagePortChannel):
(WebKit::WebMessagePortChannelProvider::entangleLocalPortInThisProcessToRemote):
(WebKit::WebMessagePortChannelProvider::messagePortDisentangled):
(WebKit::WebMessagePortChannelProvider::messagePortClosed):
(WebKit::WebMessagePortChannelProvider::takeAllMessagesForPort):
(WebKit::WebMessagePortChannelProvider::didTakeAllMessagesForPort):
(WebKit::WebMessagePortChannelProvider::didCheckRemotePortForActivity):
(WebKit::WebMessagePortChannelProvider::postMessageToRemote):
(WebKit::WebMessagePortChannelProvider::checkProcessLocalPortForActivity):
(WebKit::WebMessagePortChannelProvider::checkRemotePortForActivity):

WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h: Added.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeProcess):
(WebKit::WebProcess::didTakeAllMessagesForPort):
(WebKit::WebProcess::checkProcessLocalPortForActivity):
(WebKit::WebProcess::didCheckRemotePortForActivity):
(WebKit::WebProcess::messagesAvailableForPort):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

10:33 AM Changeset in webkit [227339] by commit-queue@webkit.org

10 edits in trunk

Fetch Headers from an Opaque response should be filtered out
https://bugs.webkit.org/show_bug.cgi?id=181926

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-22
Reviewed by Chris Dumez.

Source/WebCore:

Covered by updated test.

Refactor to use the same FetchResponse::create for Cache API and cloning.
In this method, ensure that response and headers are filtered correctly according response tainting.
Make also sure that synthetic responses do not get filtered (not needed since created by JavaScript).

Introduce helper routine to set the header map of a resource response.
Use this routine when cloning a synthetic response as in that case, m_internalResponse has no header at all.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::updateRecords):

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):
(WebCore::FetchResponse::clone):

Modules/fetch/FetchResponse.h:
platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setHTTPHeaderFields):

platform/network/ResourceResponseBase.h:
testing/ServiceWorkerInternals.cpp:

(WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):

LayoutTests:

http/wpt/fetch/response-opaque-clone-expected.txt:
http/wpt/fetch/response-opaque-clone.html:

10:24 AM Changeset in webkit [227338] by aestes@apple.com

4 edits in trunk/LayoutTests

LayoutTest http/tests/paymentrequest/payment-request-abort-method.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=178107
<rdar://problem/34901064>

Reviewed by Brady Eidson.

Modified the test to call show() with user activation.

http/tests/paymentrequest/payment-request-abort-method.https.html:
platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

9:59 AM Changeset in webkit [227337] by jmarcell@apple.com

5 edits
5 adds in branches/safari-605-branch

Cherry-pick r227280. rdar://problem/36722450

9:59 AM Changeset in webkit [227336] by jmarcell@apple.com

4 edits in branches/safari-605-branch

Cherry-pick r227278. rdar://problem/36722580

9:58 AM Changeset in webkit [227335] by jmarcell@apple.com

27 edits in branches/safari-605-branch/Source

Cherry-pick r227274. rdar://problem/36722660

9:58 AM Changeset in webkit [227334] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Tools

Cherry-pick r227273. rdar://problem/36722654

9:58 AM Changeset in webkit [227333] by jmarcell@apple.com

7 edits
2 adds in branches/safari-605-branch

Cherry-pick r227272. rdar://problem/36722635

9:58 AM Changeset in webkit [227332] by jmarcell@apple.com

14 edits in branches/safari-605-branch

Cherry-pick r227270. rdar://problem/36722650

9:58 AM Changeset in webkit [227331] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227269. rdar://problem/36722433

9:58 AM Changeset in webkit [227330] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227266. rdar://problem/36723017

9:58 AM Changeset in webkit [227329] by jmarcell@apple.com

7 edits in branches/safari-605-branch

Cherry-pick r227245. rdar://problem/36722470

9:58 AM Changeset in webkit [227328] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227243. rdar://problem/36722430

9:58 AM Changeset in webkit [227327] by jmarcell@apple.com

18 edits
1 add in branches/safari-605-branch

Cherry-pick r227242. rdar://problem/36722539

9:58 AM Changeset in webkit [227326] by jmarcell@apple.com

14 edits
1 copy in branches/safari-605-branch

Cherry-pick r227240. rdar://problem/36722464

9:58 AM Changeset in webkit [227325] by jmarcell@apple.com

4 edits
4 adds in branches/safari-605-branch

Cherry-pick r227238. rdar://problem/36722424

9:58 AM Changeset in webkit [227324] by jmarcell@apple.com

3 edits
1 add in branches/safari-605-branch

Cherry-pick r227236. rdar://problem/36722544

9:58 AM Changeset in webkit [227323] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227232. rdar://problem/36722564

9:58 AM Changeset in webkit [227322] by jmarcell@apple.com

4 edits
2 adds in branches/safari-605-branch

Cherry-pick r227229. rdar://problem/36722641

9:58 AM Changeset in webkit [227321] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227228. rdar://problem/36722601

9:58 AM Changeset in webkit [227320] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/ThirdParty/libwebrtc

Cherry-pick r227226. rdar://problem/36722612

9:58 AM Changeset in webkit [227319] by jmarcell@apple.com

94 edits in branches/safari-605-branch

Cherry-pick r227225. rdar://problem/36722527

9:57 AM Changeset in webkit [227318] by jmarcell@apple.com

6 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227221. rdar://problem/36722533

9:57 AM Changeset in webkit [227317] by jmarcell@apple.com

5 edits in branches/safari-605-branch

Cherry-pick r227220. rdar://problem/36722596

9:57 AM Changeset in webkit [227316] by jmarcell@apple.com

6 edits in branches/safari-605-branch

Cherry-pick r227219. rdar://problem/36722501

9:57 AM Changeset in webkit [227315] by jmarcell@apple.com

21 edits
2 adds in branches/safari-605-branch

Cherry-pick r227216. rdar://problem/36722508

9:57 AM Changeset in webkit [227314] by jmarcell@apple.com

4 edits in branches/safari-605-branch/Source/WebKitLegacy/win

Cherry-pick r227209. rdar://problem/36722622

9:57 AM Changeset in webkit [227313] by jmarcell@apple.com

6 edits
2 adds in branches/safari-605-branch/Source/ThirdParty/libwebrtc

Cherry-pick r227206. rdar://problem/36722612

9:57 AM Changeset in webkit [227312] by jmarcell@apple.com

2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227199. rdar://problem/36722438

9:57 AM Changeset in webkit [227311] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227168. rdar://problem/36722591

9:57 AM Changeset in webkit [227310] by jmarcell@apple.com

16 edits in branches/safari-605-branch/Source

Cherry-pick r227161. rdar://problem/36722461

9:57 AM Changeset in webkit [227309] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227159. rdar://problem/36722618

9:57 AM Changeset in webkit [227308] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227157. rdar://problem/36723021

9:57 AM Changeset in webkit [227307] by jmarcell@apple.com

7 edits in branches/safari-605-branch

Cherry-pick r227153. rdar://problem/36722558

9:57 AM Changeset in webkit [227306] by jmarcell@apple.com

3 edits
2 adds in branches/safari-605-branch

Cherry-pick r227145. rdar://problem/36722475

9:57 AM Changeset in webkit [227305] by jmarcell@apple.com

6 edits
2 adds in branches/safari-605-branch

Cherry-pick r227141. rdar://problem/36722585

9:57 AM Changeset in webkit [227304] by jmarcell@apple.com

13 edits
2 adds in branches/safari-605-branch

Cherry-pick r227140. rdar://problem/36722478

9:57 AM Changeset in webkit [227303] by jmarcell@apple.com

6 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227136. rdar://problem/36722486

9:57 AM Changeset in webkit [227302] by jmarcell@apple.com

5 edits in branches/safari-605-branch

Cherry-pick r227135. rdar://problem/36722512

9:57 AM Changeset in webkit [227301] by jmarcell@apple.com

5 edits
2 adds in branches/safari-605-branch

Cherry-pick r227082. rdar://problem/36722629

9:56 AM Changeset in webkit [227300] by jmarcell@apple.com

23 edits in branches/safari-605-branch

Cherry-pick r227079. rdar://problem/36722442

9:56 AM Changeset in webkit [227299] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227008. rdar://problem/36722458

9:51 AM Changeset in webkit [227298] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Bump default cache storage quota to 50MB
https://bugs.webkit.org/show_bug.cgi?id=181924

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-22
Reviewed by Chris Dumez.

Existing web sites use more than 20 MB.

UIProcess/WebsiteData/WebsiteDataStore.h:

9:01 AM Changeset in webkit [227297] by jfernandez@igalia.com

22 edits in trunk

[css-align] 'overflow' keyword must precede the self-position and content-position value
https://bugs.webkit.org/show_bug.cgi?id=181793

Reviewed by Antti Koivisto.

Source/WebCore:

There were several discussions to avoid ambiguities with the complex
values, specially when it comes to define the place-xxx shorthands.

One of the sources of problems is the 'overflow-position' keyword. The
CSS WG has decided to change the syntax of all the CSS Box Alignment
properties so that the 'overflow-position' keyword always precede the
'self-position' or the 'content-position' keywords.

https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434

In order to apply this change to the Content Distribution properties'
(align-content and justify-content) syntax I had to completely
re-implement their parsing function. Thanks to this I addressed also
the issue with the content-distribution fallback, which cannot be
specified explicitly now.

https://github.com/w3c/csswg-drafts/issues/1002#ref-commit-c38cac4

No new tests, just rebaselined the expected results of the test cases affected.

Despite the so many layout tests affected by this change, it's
unlikely that it might break any content in current web
sites. This patch changes the new CSS syntax, obviously backward
compatible, defined by the new CSS Box Alignment. The
'overflow-position' keyword is only used by the layout models
implementing the new spec, so far only CSS Grid Layout.
Considering that CSS Grid has been shipped last year, it's unlikely
that many sites are using the new CSS values.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):

css/CSSContentDistributionValue.cpp:

(WebCore::CSSContentDistributionValue::customCSSText const):

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertSelfOrDefaultAlignmentData):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeOverflowPositionKeyword):
(WebCore::consumeContentPositionKeyword):
(WebCore::consumeContentDistributionOverflowPosition):
(WebCore::consumeSelfPositionOverflowPosition):

LayoutTests:

Rebaseline expected results of the test cases affected by this change.

css3/parse-align-content.html:
css3/parse-align-items.html:
css3/parse-align-self.html:
css3/parse-justify-content.html:
css3/overwrite-self-alignment.html:
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html:
css3/overwrite-content-alignment.html:
fast/css-grid-layout/grid-content-alignment-overflow.html:
fast/css-grid-layout/grid-align-justify-overflow.html:
fast/css/parse-justify-items.html:
fast/css/parse-justify-self.html:
fast/repaint/align-items-overflow-change.html:
fast/repaint/align-self-overflow-change.html:
fast/repaint/justify-items-overflow-change.html:
fast/repaint/justify-self-overflow-change.html:

9:01 AM Changeset in webkit [227296] by pvollan@apple.com

2 edits in trunk/LayoutTests

Mark svg/filters/fePointLight-color.svg as failure on Windows.
https://bugs.webkit.org/show_bug.cgi?id=181869

Unreviewed test gardening.

platform/win/TestExpectations:

8:07 AM Changeset in webkit [227295] by commit-queue@webkit.org

21 edits
2 copies
57 adds
1 delete in trunk

Parse calc() in CSS media queries
https://bugs.webkit.org/show_bug.cgi?id=181716

LayoutTests/imported/w3c:

Patch by Chris Nardi <csnardi1@gmail.com> on 2018-01-22
Reviewed by Antti Koivisto.

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/css/mediaqueries/OWNERS: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-001.html: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-002-expected.xht: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-002.html: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-003-expected.xht: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-003.html: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-004-expected.xht: Added.
web-platform-tests/css/mediaqueries/aspect-ratio-004.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-001.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-002-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-002.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-003-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-003.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-004-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-004.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-005-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-005.html: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-006-expected.xht: Added.
web-platform-tests/css/mediaqueries/device-aspect-ratio-006.html: Added.
web-platform-tests/css/mediaqueries/min-width-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/min-width-001.xht: Added.
web-platform-tests/css/mediaqueries/min-width-tables-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/min-width-tables-001.html: Added.
web-platform-tests/css/mediaqueries/mq-calc-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-calc-001.html: Added.
web-platform-tests/css/mediaqueries/mq-calc-002-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-calc-002.html: Added.
web-platform-tests/css/mediaqueries/mq-calc-003-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-calc-003.html: Added.
web-platform-tests/css/mediaqueries/mq-calc-004-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-calc-004.html: Added.
web-platform-tests/css/mediaqueries/mq-calc-005-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-calc-005.html: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-001.html: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-002-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-002.html: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-003-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-003.html: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-004-expected.xht: Added.
web-platform-tests/css/mediaqueries/mq-invalid-media-type-004.html: Added.
web-platform-tests/css/mediaqueries/relative-units-001-expected.xht: Added.
web-platform-tests/css/mediaqueries/relative-units-001.html: Added.
web-platform-tests/css/mediaqueries/relative-units-002-expected.xht: Added.
web-platform-tests/css/mediaqueries/relative-units-002.html: Added.
web-platform-tests/css/mediaqueries/relative-units-003-expected.xht: Added.
web-platform-tests/css/mediaqueries/relative-units-003.html: Added.
web-platform-tests/css/mediaqueries/relative-units-004-expected.xht: Added.
web-platform-tests/css/mediaqueries/relative-units-004.html: Added.
web-platform-tests/css/mediaqueries/support/media_queries_iframe.html: Renamed from LayoutTests/fast/media/w3c/resources/media_queries_iframe.html.
web-platform-tests/css/mediaqueries/support/min-width-tables-001-iframe.html: Added.
web-platform-tests/css/mediaqueries/support/w3c-import.log: Added.
web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: Renamed from LayoutTests/fast/media/w3c/test_media_queries-expected.txt.
web-platform-tests/css/mediaqueries/test_media_queries.html: Renamed from LayoutTests/fast/media/w3c/test_media_queries.html.
web-platform-tests/css/mediaqueries/w3c-import.log: Added.

Source/WebCore:

calc() was previously unsupported inside of media queries. This change
adds in support for parsing calc inside of media queries.

Patch by Chris Nardi <csnardi1@gmail.com> on 2018-01-22
Reviewed by Antti Koivisto.

Tests: Imported web-platform-tests/css/mediaqueries

css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent): Updated function to take a CSSPrimitiveValue.
(WebCore::featureWithValidDensity): Updated function to take a CSSPrimitiveValue instead of a CSSParserToken.
(WebCore::featureWithValidPositiveLength): Ditto.
(WebCore::featureExpectingPositiveInteger): Ditto.
(WebCore::featureWithPositiveInteger): Ditto.
(WebCore::featureWithPositiveNumber): Ditto.
(WebCore::featureWithZeroOrOne): Ditto.
(WebCore::MediaQueryExpression::MediaQueryExpression): Use CSSPropertyParserHelpers for consuming.

css/MediaQueryExpression.h:
css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeResolution): Added function for use in media query expression parsing.

css/parser/CSSPropertyParserHelpers.h:
css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::readRestrictor): Updated functions to take a CSSParserTokenRange in order to use CSSPropertyParserHelpers.
(WebCore::MediaQueryParser::readMediaNot): Ditto.
(WebCore::MediaQueryParser::readMediaType): Ditto.
(WebCore::MediaQueryParser::readAnd): Ditto.
(WebCore::MediaQueryParser::readFeatureStart): Ditto.
(WebCore::MediaQueryParser::readFeature): Ditto.
(WebCore::MediaQueryParser::readFeatureColon): Ditto.
(WebCore::MediaQueryParser::readFeatureValue): Ditto.
(WebCore::MediaQueryParser::readFeatureEnd): Ditto.
(WebCore::MediaQueryParser::skipUntilComma): Ditto.
(WebCore::MediaQueryParser::skipUntilBlockEnd): Ditto.
(WebCore::MediaQueryParser::processToken): Ditto.
(WebCore::MediaQueryParser::parseInternal): Ditto.
(WebCore::MediaQueryData::clear): Removed reference to m_valueList
(WebCore::MediaQueryData::addExpression): Use CSSParserTokenRange.
(WebCore::MediaQueryData::lastExpressionValid): New helper function.
(WebCore::MediaQueryData::removeLastExpression): New helper function.

css/parser/MediaQueryParser.h:

LayoutTests:

Imported CSS mediaqueries tests from WPT, deleting our (old) copy of one test. Updated
expectations.

Patch by Chris Nardi <csnardi1@gmail.com> on 2018-01-22
Reviewed by Antti Koivisto.

TestExpectations:
fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt:
fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt:
fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt:
fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt:
fast/media/w3c/README: Removed.
fast/media/w3c/test_media_queries-expected.txt: Removed.
platform/ios/TestExpectations:
platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt:
platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt:
platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt:
platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt:

7:03 AM Changeset in webkit [227294] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

Unreviewed build fix after r227292. Fixing a bad copy-paste that broke
the GTK+ debug builds.

WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::convertCairoSurfaceToShareableBitmap):

6:33 AM Changeset in webkit [227293] by Carlos Garcia Campos

7 edits in trunk

WebDriver: implement get element CSS value command
https://bugs.webkit.org/show_bug.cgi?id=181736

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

13.4 Get Element CSS Value
https://w3c.github.io/webdriver/webdriver-spec.html#get-element-css-value

Fixes: imported/selenium/py/test/selenium/webdriver/common/rendered_webelement_tests.py::testShouldPickUpStyleOfAnElement

imported/selenium/py/test/selenium/webdriver/common/rendered_webelement_tests.py::testShouldAllowInheritedStylesToBeUsed

Session.cpp:

(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):

Session.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::getElementCSSValue):

WebDriverService.h:

WebDriverTests:

TestExpectations.json: Unskip tests passing now.

6:23 AM Changeset in webkit [227292] by zandobersek@gmail.com

9 edits in trunk/Source

[Cairo] Refactor PlatformContextCairo::drawSurfaceToContext() into a Cairo operation
https://bugs.webkit.org/show_bug.cgi?id=181930

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Move the PlatformContextCairo::drawSurfaceToContext() code into the
Cairo namespace as an operation, renaming it to drawSurface(). Mirroring
other operations, the PlatformContextCairo object is now passed through
a reference as the first argument to the function, and cairo_t context
object is retrieved from that.

Call sites of the PlatformContextCairo::drawSurfaceToContext() method
are adjusted to now call Cairo::drawSurface() and properly pass the
PlatformContextCairo object to the function.

No new tests -- no change in functionality.

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::prepareForStroking): Make this static.
(WebCore::Cairo::drawPatternToCairoContext):
(WebCore::Cairo::drawNativeImage):
(WebCore::Cairo::drawSurface):

platform/graphics/cairo/CairoOperations.h:
platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::drawPatternToCairoContext): Deleted.
(WebCore::PlatformContextCairo::drawSurfaceToContext): Deleted.

platform/graphics/cairo/PlatformContextCairo.h:
platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::paintCurrentFrame):

Source/WebKit:

Call sites of the PlatformContextCairo::drawSurfaceToContext() method
are adjusted to now call Cairo::drawSurface() and properly pass the
PlatformContextCairo object to the function.

Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::paint):

WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::convertCairoSurfaceToShareableBitmap):

6:22 AM Changeset in webkit [227291] by Carlos Garcia Campos

38 edits
1 copy
2 adds
2 deletes in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

imported/w3c/importer.json:
imported/w3c/tools/webdriver/webdriver/client.py:
imported/w3c/tools/webdriver/webdriver/protocol.py:
imported/w3c/tools/webdriver/webdriver/servo.py: Removed.
imported/w3c/tools/webdriver/webdriver/transport.py:
imported/w3c/tools/wptrunner/MANIFEST.in:
imported/w3c/tools/wptrunner/README.rst:
imported/w3c/tools/wptrunner/docs/conf.py:
imported/w3c/tools/wptrunner/docs/usage.rst:
imported/w3c/tools/wptrunner/setup.py:
imported/w3c/tools/wptrunner/tox.ini:
imported/w3c/tools/wptrunner/wptrunner/browsers/init.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/b2g_setup/certtest_app.zip: Removed.
imported/w3c/tools/wptrunner/wptrunner/browsers/chrome_android.py: Copied from WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/ie.py.
imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/ie.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py:
imported/w3c/tools/wptrunner/wptrunner/environment.py:
imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py:
imported/w3c/tools/wptrunner/wptrunner/executors/executorservodriver.py:
imported/w3c/tools/wptrunner/wptrunner/manifestupdate.py:
imported/w3c/tools/wptrunner/wptrunner/metadata.py:
imported/w3c/tools/wptrunner/wptrunner/stability.py:
imported/w3c/tools/wptrunner/wptrunner/testloader.py:
imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
imported/w3c/tools/wptrunner/wptrunner/tests/test_hosts.py:
imported/w3c/tools/wptrunner/wptrunner/update/init.py:
imported/w3c/tools/wptrunner/wptrunner/update/sync.py:
imported/w3c/tools/wptrunner/wptrunner/update/tree.py:
imported/w3c/tools/wptrunner/wptrunner/vcs.py:
imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
imported/w3c/tools/wptrunner/wptrunner/wptmanifest/tests/test_serializer.py:
imported/w3c/tools/wptrunner/wptrunner/wptmanifest/tests/test_tokenizer.py:
imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
imported/w3c/webdriver/tests/execute_async_script/init.py: Added.
imported/w3c/webdriver/tests/execute_script/init.py: Added.
imported/w3c/webdriver/tests/sessions/new_session/response.py:

6:04 AM Changeset in webkit [227290] by Carlos Garcia Campos

6 edits in trunk

[GTK] WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/response.py is crashing in the bots
https://bugs.webkit.org/show_bug.cgi?id=181904

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

Handle the case of failing to launch the browser. The test is actually failing because it's sending wrong
capabilities, the driver tries to fall back to the default driver, but since WebKit is not installed in the
bots, it fails to find the MiniBrowser. The test needs to be fixed, but we shouldn't crash when the browser
can't be spawned for whatever reason in any case. This patch handles that case and changes the boolean result of
connectToBrowser to be an optional error string instead. This way we can provide more detailed error message
when we reject the session creation because the browser failed to start.

SessionHost.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::newSession):

glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::connectToBrowser):
(WebDriver::ConnectToBrowserAsyncData::ConnectToBrowserAsyncData):
(WebDriver::SessionHost::launchBrowser):
(WebDriver::SessionHost::setupConnection):

WebDriverTests:

Unskip imported/w3c/webdriver/tests/sessions/new_session/response.py.

TestExpectations.json:

6:03 AM Changeset in webkit [227289] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
https://bugs.webkit.org/show_bug.cgi?id=181929

Reviewed by Michael Catanzaro.

The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
the website data completion callback is not called immediately, and a new file is created when the operation
finishes. We need to check that the file was removing after calling clear.

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(fileChangedCallback):
(testWebsiteDataResourceLoadStatistics):

4:33 AM Changeset in webkit [227288] by Manuel Rego Casasnovas

4 edits
4 adds in trunk

[css-grid] Spanning Grid item has too much space at the bottom / is too high
https://bugs.webkit.org/show_bug.cgi?id=181677

LayoutTests/imported/w3c:

Imported WPT tests to check this change.

Reviewed by Javier Fernandez.

web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-001-expected.txt: Added.
web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-001.html: Added.
web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-002-expected.txt: Added.
web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-002.html: Added.
web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

Source/WebCore:

Reviewed by Javier Fernandez.

In IndefiniteSizeStrategy::findUsedFlexFraction() we were not
subtracting the size of the gutters when we call findFrUnitSize().
If an item spans several tracks, we cannot pass the maxContentForChild()
directly, we need to subtract the gutters as they are treated
as fixed size tracks in the algorithm.

The spec text is pretty clear regarding this
(https://drafts.csswg.org/css-grid/#algo-find-fr-size):
"Let leftover space be the space to fill minus the base sizes

of the non-flexible grid tracks."

Gutters are treated as fixed-size tracks for the purpose
of the track sizing algorithm, so we need to subtract them from the
leftover space while finding the size of an "fr".

Tests: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-001.html

imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-find-fr-size-gutters-002.html

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::findFrUnitSize const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):

1:02 AM Changeset in webkit [227287] by Carlos Garcia Campos

2 edits in trunk/Tools

Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.

TestWebKitAPI/glib/TestExpectations.json:

12:12 AM Changeset in webkit [227286] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.

Partially revert r226782, the fix was wrong for the GLib version we currently use.

TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:

(testWebKitConsoleMessageNetworkError):

12:00 AM Changeset in webkit [227285] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Remove unused verbose mode from GLib API tests runner.

glib/api_test_runner.py:

(add_options):

Jan 21, 2018:

11:57 PM Changeset in webkit [227284] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

Unreviewed. Fix compile warning.

Use #include instead of #import in cross-platform code.

Shared/WebPreferencesDefaultValues.cpp:

11:38 PM Changeset in webkit [227283] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

Should reject updating a build request which has an associated build.
https://bugs.webkit.org/show_bug.cgi?id=181893

Reviewed by Ryosuke Niwa.

Current code does not prevent submitting to same build request multiple times.
This could lead to a build losing its associated build request.
As a result, this build will be visible in charts which is not right.
Added a check when a build request is reported.
Addressed a 'FIXME' for the race condition inside ReportProcessor->resolve_build_id by surrounding
it with a database transaction.

public/include/report-processor.php:

Wrap adding platform and resolve_build_id with a database transaction.
Add a check to make sure only a build request has no associated build can be updated.

server-tests/api-report-tests.js: Added unit tests accordingly.

10:41 PM Changeset in webkit [227282] by rniwa@webkit.org

16 edits in trunk/Source

Turning off custom pasteboard data doesn't actually turn it off in WK2
https://bugs.webkit.org/show_bug.cgi?id=181920
<rdar://problem/36686429>

Reviewed by Wenson Hsieh.

Source/WebCore:

Replaced the global settings for custom pasteboard data by regular runtime enabled flags.

dom/DataTransfer.cpp:

(WebCore::DataTransfer::getDataForItem const):
(WebCore::DataTransfer::shouldSuppressGetAndSetDataToAvoidExposingFilePaths const):
(WebCore::DataTransfer::setDataFromItemList):
(WebCore::DataTransfer::types const):
(WebCore::DataTransfer::commitToPasteboard):

dom/DataTransferItemList.cpp:

(WebCore::shouldExposeTypeInItemList):

editing/Editor.cpp:

(WebCore::createDataTransferForClipboardEvent):

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentAndAddResources):
(WebCore::WebContentReader::readWebArchive):

page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::defaultCustomPasteboardDataEnabled): Deleted.

page/DeprecatedGlobalSettings.h:

(WebCore::DeprecatedGlobalSettings::setCustomPasteboardDataEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::customPasteboardDataEnabled): Deleted.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCustomPasteboardDataEnabled):
(WebCore::RuntimeEnabledFeatures::customPasteboardDataEnabled const):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setCustomPasteboardDataEnabled):

Source/WebKit:

Moved the code to decide when to enable custom pasteboard data from WebCore
since we never enable this feature in WebKit1.

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.cpp:

(defaultCustomPasteboardDataEnabled): Added.

Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

Always disable custom pasteboard data in WebKit1. See r226156 for details.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

7:58 PM Changeset in webkit [227281] by Wenson Hsieh

14 edits in trunk

Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
https://bugs.webkit.org/show_bug.cgi?id=181918

Reviewed by Tim Horton.

Source/JavaScriptCore: