Context Navigation

← Previous Period
Next Period →

Timeline

Feb 4, 2018:

11:38 PM Changeset in webkit [228085] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
https://bugs.webkit.org/show_bug.cgi?id=182466

Reviewed by Michael Catanzaro.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):
Use cairo_format_stride_for_width() to obtain stride that Cairo thinks
is appropriate for the given width, taking into account internal
alignment requirements.

11:33 PM Changeset in webkit [228084] by zandobersek@gmail.com

3 edits
1 add in trunk/Source/WebCore

[Cairo] Split TexMap functionality out of GraphicsContext3DCairo
https://bugs.webkit.org/show_bug.cgi?id=182465

Reviewed by Michael Catanzaro.

Take the Non-Cairo GraphicsContext3D functionality that's stashed in
GraphicsContext3DCairo and move it into the GraphicsContext3DTextureMapper
file.

In GraphicsContext3DCairo.cpp, only the Cairo-specific GraphicsContext3D
functionality remains, specifically ImageExtractor and paintToCanvas().

Everything else is moved into GraphicsContext3DTextureMapper.cpp. This
filename and its location under platform/graphics/texmap/ was chosen
since all the ports using this file (GTK, WPE, WinCairo) are also using
the TextureMapper module. Various #if-guards are simplified in the
moved-over code to reflect this.

GraphicsContext3DCairo.cpp now better reflects GraphicsContext3DCG.cpp,
with both implementing functionality specific to a 2D painting library,
whereas GraphicsContext3DTextureMapper.cpp reflects
GraphicsContext3DCocoa.cpp in covering functionality needed to integrate
the GraphicsContext3D output into the platform-specific composition
system.

No new tests -- no change in behavior.

platform/TextureMapper.cmake:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::activeContexts): Deleted.
(WebCore::GraphicsContext3D::create): Deleted.
(WebCore::GraphicsContext3D::GraphicsContext3D): Deleted.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Deleted.
(WebCore::GraphicsContext3D::setContextLostCallback): Deleted.
(WebCore::GraphicsContext3D::setErrorMessageCallback): Deleted.
(WebCore::GraphicsContext3D::makeContextCurrent): Deleted.
(WebCore::GraphicsContext3D::checkGPUStatus): Deleted.
(WebCore::GraphicsContext3D::platformGraphicsContext3D): Deleted.
(WebCore::GraphicsContext3D::platformTexture const): Deleted.
(WebCore::GraphicsContext3D::isGLES2Compliant const): Deleted.
(WebCore::GraphicsContext3D::platformLayer const): Deleted.
(WebCore::GraphicsContext3D::getExtensions): Deleted.

platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp: Copied from Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp.

(WebCore::activeContexts):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::checkGPUStatus):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture const):
(WebCore::GraphicsContext3D::isGLES2Compliant const):
(WebCore::GraphicsContext3D::platformLayer const):
(WebCore::GraphicsContext3D::getExtensions):

10:32 PM Changeset in webkit [228083] by jmarcell@apple.com

6 edits in branches/safari-605-branch/Source

Apply patch. rdar://problem/36547114

Disable some runtime feature flags on safari-605-branch

10:32 PM Changeset in webkit [228082] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit/UIProcess/ios

Apply patch. rdar://problem/37145545

Build fix.

10:32 PM Changeset in webkit [228081] by jmarcell@apple.com

3 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227935. rdar://problem/37145460

10:32 PM Changeset in webkit [228080] by jmarcell@apple.com

2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227865. rdar://problem/37145460

9:30 PM Changeset in webkit [228079] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r228050. rdar://problem/37220143

9:30 PM Changeset in webkit [228078] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r228041. rdar://problem/37220123

9:30 PM Changeset in webkit [228077] by jmarcell@apple.com

4 edits in branches/safari-605-branch

Cherry-pick r228036. rdar://problem/37220130

9:30 PM Changeset in webkit [228076] by jmarcell@apple.com

14 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r228035. rdar://problem/37220146

9:30 PM Changeset in webkit [228075] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r228034. rdar://problem/37220140

9:30 PM Changeset in webkit [228074] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r228033. rdar://problem/37220144

9:30 PM Changeset in webkit [228073] by jmarcell@apple.com

3 edits
1 add in branches/safari-605-branch

Cherry-pick r228031. rdar://problem/37220129

9:30 PM Changeset in webkit [228072] by jmarcell@apple.com

4 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r228030. rdar://problem/37220121

9:30 PM Changeset in webkit [228071] by jmarcell@apple.com

9 edits in branches/safari-605-branch

Cherry-pick r228025. rdar://problem/37220140

9:30 PM Changeset in webkit [228070] by jmarcell@apple.com

17 edits in branches/safari-605-branch

Cherry-pick r228019. rdar://problem/37220144

9:30 PM Changeset in webkit [228069] by jmarcell@apple.com

4 edits in branches/safari-605-branch

Cherry-pick r228015. rdar://problem/37220133

9:30 PM Changeset in webkit [228068] by jmarcell@apple.com

3 edits
1 add in branches/safari-605-branch

Cherry-pick r227998. rdar://problem/37220126

9:30 PM Changeset in webkit [228067] by jmarcell@apple.com

5 edits
3 adds in branches/safari-605-branch

Cherry-pick r227997. rdar://problem/37220136

6:19 PM Changeset in webkit [228066] by jmarcell@apple.com

7 edits in branches/safari-605-branch

Cherry-pick r227994. rdar://problem/37145542

6:19 PM Changeset in webkit [228065] by jmarcell@apple.com

3 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227992. rdar://problem/37145465

6:19 PM Changeset in webkit [228064] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227990. rdar://problem/37145451

6:19 PM Changeset in webkit [228063] by jmarcell@apple.com

11 edits in branches/safari-605-branch

Cherry-pick r227985. rdar://problem/37145479

6:19 PM Changeset in webkit [228062] by jmarcell@apple.com

7 edits in branches/safari-605-branch

Cherry-pick r227974. rdar://problem/37145538

6:18 PM Changeset in webkit [228061] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227967. rdar://problem/37145562

6:18 PM Changeset in webkit [228060] by jmarcell@apple.com

6 edits in branches/safari-605-branch

Cherry-pick r227959. rdar://problem/37145559

6:18 PM Changeset in webkit [228059] by jmarcell@apple.com

18 edits
1 delete in branches/safari-605-branch/Source

Cherry-pick r227951. rdar://problem/37145493

6:18 PM Changeset in webkit [228058] by jmarcell@apple.com

11 edits in branches/safari-605-branch

Cherry-pick r227948. rdar://problem/37145473

6:18 PM Changeset in webkit [228057] by jmarcell@apple.com

9 edits
2 adds in branches/safari-605-branch

Cherry-pick r227936. rdar://problem/37145449

6:18 PM Changeset in webkit [228056] by jmarcell@apple.com

3 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227934. rdar://problem/37145534

6:18 PM Changeset in webkit [228055] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebCore

Cherry-pick r227932. rdar://problem/37145456

6:18 PM Changeset in webkit [228054] by jmarcell@apple.com

2 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227927. rdar://problem/37145549

6:18 PM Changeset in webkit [228053] by jmarcell@apple.com

3 edits
4 adds in branches/safari-605-branch

Cherry-pick r227926. rdar://problem/37145475

12:18 AM Changeset in webkit [228052] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

Simplify GraphicsContext3D::paintToCanvas()
https://bugs.webkit.org/show_bug.cgi?id=182459

Reviewed by Michael Catanzaro.

Cairo-specific paintToCanvas() method is dropped in favor of the more
common one that operates on a GraphicsContext object. The platform
context object is then retrieved inside the Cairo-speficic
paintToCanvas() implementation, and not at the call site in
GraphicsContext3D::paintRenderingResultsToCanvas().

GraphicsContext3D::paintToCanvas() is also modified so that the image
and canvas sizes are passed through IntSize objects, and not through
a width-and-height pair of integer values.

No new tests -- no change in behavior.

platform/graphics/GraphicsContext3D.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

12:17 AM Changeset in webkit [228051] by zandobersek@gmail.com

5 edits
1 add in trunk/Source/ThirdParty

Lots of build warnings from Source/ThirdParty/openvr
https://bugs.webkit.org/show_bug.cgi?id=182117

Reviewed by Michael Catanzaro.

Suppress OpenVR compiler warnings by listing -Wno-unknown-pragmas,
-Wno-unused-parameter and -Wno-unused-variable options among the
libopenvr_api.so CXX flags.

CMake configuration warning about default project variables for the
openvr_api project is avoided by removing the openvr_api project and
instead setting the OPENVR_SOURCE_DIR to the path of the OpenVR
source directory under Source/ThirdParty/.

Another compiler warning is removed by fixing the return condition in
the Path_WriteBinaryFile() function to perform an equality comparison
instead of an assignment. This has already been fixed upstream.

All changes to the OpenVR code are reflected in the separately-managed
patch files kept in the patches/ directory.

openvr/README.webkit:
openvr/patches/Path_WriteBinaryFile-fix-return-condition.patch: Added.
openvr/patches/cmake-build.patch:
openvr/src/CMakeLists.txt:
openvr/src/vrcommon/pathtools_public.cpp:

(Path_WriteBinaryFile):

Feb 3, 2018:

7:35 PM Changeset in webkit [228050] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

UI process sometimes crashes under -[WKContentView _lookupForWebView:]
https://bugs.webkit.org/show_bug.cgi?id=182460
<rdar://problem/33260602>

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _lookupForWebView:]):
If you have a range selection, but no rects for the selection, retrieving
the 0th element of selectionRects will crash the UI process. To fix, in
this case, use the rect for the starting caret instead.

It doesn't seem like the presentationRect is actually currently used for
the Lookup service, so the only impact is that we shouldn't crash anymore.

2:39 PM Changeset in webkit [228049] by ap@apple.com