Timeline

Feb 11, 2018:

11:33 PM Changeset in webkit [228371] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

WebDriver: addCookie command should prepend a dot to domain if missing
​https://bugs.webkit.org/show_bug.cgi?id=182328
<rdar://problem/37116398>

Reviewed by Michael Catanzaro.

RFC 2965: If an explicitly specified value does not start with a dot, the user agent supplies a leading dot.

Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):

11:32 PM Changeset in webkit [228370] by guijemont@igalia.com

• 2 edits in trunk/Source/JavaScriptCore

[MIPS] JSC needs to be built with -latomic
​https://bugs.webkit.org/show_bug.cgi?id=182610

Reviewed by Žan Doberšek.

Since r228149, on MIPS we need to link with -latomic, because
atomic_fetch_add_8 is not available as a compiler intrinsic.

• CMakeLists.txt:

10:22 PM Changeset in webkit [228369] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/Source/WebKit

[WinCairo] Add WKBaseWin.h
​https://bugs.webkit.org/show_bug.cgi?id=182681

Patch by Yousuke Kimoto <​yousuke.kimoto@sony.com> on 2018-02-11
Reviewed by Yusuke Suzuki.

• PlatformWin.cmake:
• Shared/API/c/win/WKBaseWin.h: Added.

5:54 PM WebKitGTK/2.20.x edited by Michael Catanzaro

(diff)

5:52 PM WebKitGTK/2.20.x edited by Michael Catanzaro

Review safari-605-branch for backports through r228364 (diff)

12:09 PM Changeset in webkit [228368] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Scrolling sometimes jumps around
​https://bugs.webkit.org/show_bug.cgi?id=178519

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2018-02-11
Reviewed by Michael Catanzaro.

• platform/gtk/ScrollAnimatorGtk.cpp:

(WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
returned, causing the viewport to scroll to the end of the page.

Feb 10, 2018:

5:53 PM Changeset in webkit [228367] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Remove an unused static variable in DeprecatedGlobalSettings.h
​https://bugs.webkit.org/show_bug.cgi?id=182672

Reviewed by Joseph Pecoraro.

After r227282, this flag is no longer used anywhere. No change in behavior.

• page/DeprecatedGlobalSettings.h:

3:49 PM Changeset in webkit [228366] by fpizlo@apple.com

• 11 edits
  2 adds in trunk

Don't waste memory for error.stack
​https://bugs.webkit.org/show_bug.cgi?id=182656

Reviewed by Saam Barati.

JSTests:

Tests the policy.

• stress/gc-error-stack.js: Added. Shows that the GC forgets frames now.
• stress/no-gc-error-stack.js: Added. Shows that the GC won't forget things if you ask for the stack.

Source/JavaScriptCore:

This makes the StackFrames in ErrorInstance and Exception weak. We simply forget their
contents if we GC.

This isn't going to happen under normal operation since your callees and code blocks will
still be alive when you ask for .stack.

Bug 182650 tracks improving this so that it's not lossy. For now, I think it's worth it,
since it is likely to recover 3-5 MB on membuster.

• heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):

• runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::visitChildren):
(JSC::ErrorInstance::finalizeUnconditionally):

• runtime/ErrorInstance.h:

(JSC::ErrorInstance::subspaceFor):

• runtime/Exception.cpp:

(JSC::Exception::visitChildren):
(JSC::Exception::finalizeUnconditionally):

• runtime/Exception.h:

(JSC::Exception::valueOffset): Deleted.
(JSC::Exception::value const): Deleted.
(JSC::Exception::stack const): Deleted.
(JSC::Exception::didNotifyInspectorOfThrow const): Deleted.
(JSC::Exception::setDidNotifyInspectorOfThrow): Deleted.

• runtime/StackFrame.cpp:

(JSC::StackFrame::isFinalizationCandidate):
(JSC::StackFrame::finalizeUnconditionally):
(JSC::StackFrame::visitChildren): Deleted.

• runtime/StackFrame.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

7:44 AM Changeset in webkit [228365] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=182662
<rdar://problem/37408571>

Reviewed by Simon Fraser.

No change in functionality.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::takeChild):
(WebCore::canDropAnonymousBlock): Deleted.
(WebCore::canMergeContiguousAnonymousBlocks): Deleted.

• rendering/RenderBlock.h:

(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):

• rendering/RenderBlockFlow.h:
• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::takenChildFromRenderBlock):

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::canDropAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderTreeBuilder::Block::takeChild):

• rendering/updating/RenderTreeBuilderBlock.h: