Timeline

Mar 10, 2018:

11:20 PM Changeset in webkit [229514] by Yusuke Suzuki

• 25 edits
  4 adds in trunk

[FTL] Drop NewRegexp for String.prototype.match with RegExp + global flag
​https://bugs.webkit.org/show_bug.cgi?id=181848

Reviewed by Sam Weinig.

JSTests:

• microbenchmarks/regexp-u-global-es5.js: Added.

(fn):

• microbenchmarks/regexp-u-global-es6.js: Added.

(fn):

• stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js: Added.

(shouldBe):
(test):
(i.switch):

• stress/materialized-regexp-has-correct-last-index-set-by-match.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

In r181535, we support string.match(/nonglobal/) code. However, string.match(/global/g) is not
optimized since it sets lastIndex value before performing RegExp operation.

This patch optimizes the above "with a global flag" case by emitting SetRegExpObjectLastIndex properly.
RegExpMatchFast is converted to SetRegExpObjectLastIndex and RegExpMatchFastGlobal. The latter node
just holds RegExp (not RegExpObject) cell so that it can offer a chance to make NewRegexp PhantomNewRegexp
in object allocation sinking phase.

Added microbenchmarks shows that this patch makes NewRegexp PhantomNewRegexp even if the given RegExp
has a global flag. And it improves the performance.

baseline patched

regexp-u-global-es5 44.1298+-4.6128 ^{33.7920+-2.0110} definitely 1.3059x faster
regexp-u-global-es6 182.3272+-2.2861 ^{154.3414+-7.6769} definitely 1.1813x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGMayExit.cpp:
• dfg/DFGNode.cpp:

(JSC::DFG::Node::convertToRegExpMatchFastGlobal):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasCellOperand):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileRegExpMatchFastGlobal):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileRegExpMatchFastGlobal):

• runtime/RegExpObject.cpp:

(JSC::collectMatches): Deleted.

• runtime/RegExpObject.h:
• runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::execInline):
(JSC::RegExpObject::matchInline):
(JSC::advanceStringUnicode):
(JSC::collectMatches):
(JSC::RegExpObject::advanceStringUnicode): Deleted.

• runtime/RegExpPrototype.cpp:

(JSC::advanceStringIndex):

11:16 PM Changeset in webkit [229513] by Yusuke Suzuki

• 3 edits in trunk/Source/JavaScriptCore

B3::reduceStrength should canonicalize integer comparisons
​https://bugs.webkit.org/show_bug.cgi?id=150958

Reviewed by Filip Pizlo.

This patch sorts operands of comparisons by flipping opcode. For example, Above(0, @2) is
converted to Below(@2, 0). This sorting is the same to handleCommutativity rule. Since we
canonicalize comparisons to have constant value at least on the right hand side, we can
remove pattern matchings checking leftImm in B3LowerToAir.

Since this flipping changes the opcode of the value, to achieve safely, we just create a
new value which has flipped opcode and swapped operands. If we can fold it to a constant,
we replace m_value with this constant. If we fail to fold it to constant, we replace
m_value with the flipped one.

These comparisons are already handled in testb3.

• b3/B3LowerToAir.cpp:
• b3/B3ReduceStrength.cpp:

5:49 PM Changeset in webkit [229512] by jer.noble@apple.com

• 2 edits
  3 copies
  1 move
  5 adds
  1 delete in trunk/Source/WebKit

Improvements to fullscreen; new UI and security features
​https://bugs.webkit.org/show_bug.cgi?id=183503

Reviewed by Dean Jackson.

Now that the iOS Fullscreen code has more than one major class, move it into an ios/
directory.

Clean up the WKFullScreenWindowControllerIOS class to more clearly separate external
facing API from purely internal functions.

Move the WKFullScreenViewController out into its own file. Add support for fullscreen
top inset and fullscreen autohide duration CSS constants.

Add a heuristic to distinguish between media control related touches and ones that look
more keyboard interactions.

Add a new UIStackView based control to hold the fullscreen controls.

• UIProcess/ios/WKFullScreenWindowControllerIOS.mm: Removed.
• UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp: Added.

(WebKit::FullscreenTouchSecheuristic::scoreOfNextTouch):
(WebKit::FullscreenTouchSecheuristic::reset):
(WebKit::FullscreenTouchSecheuristic::distanceScore):
(WebKit::FullscreenTouchSecheuristic::attenuationFactor):

• UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h:

(WebKit::FullscreenTouchSecheuristic::setRampUpSpeed):
(WebKit::FullscreenTouchSecheuristic::setRampDownSpeed):
(WebKit::FullscreenTouchSecheuristic::setXWeight):
(WebKit::FullscreenTouchSecheuristic::setYWeight):
(WebKit::FullscreenTouchSecheuristic::setSize):
(WebKit::FullscreenTouchSecheuristic::setGamma):
(WebKit::FullscreenTouchSecheuristic::setGammaCutoff):

• UIProcess/ios/fullscreen/WKFullScreenViewController.h:
• UIProcess/ios/fullscreen/WKFullScreenViewController.mm: Added.

(WKFullScreenViewControllerPlaybackSessionModelClient::setParent):
(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
(-[_WKExtrinsicButton setExtrinsicContentSize:]):
(-[_WKExtrinsicButton intrinsicContentSize]):
(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController dealloc]):
(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController setPrefersStatusBarHidden:]):
(-[WKFullScreenViewController setPlaying:]):
(-[WKFullScreenViewController setPictureInPictureActive:]):
(-[WKFullScreenViewController loadView]):
(-[WKFullScreenViewController viewWillAppear:]):
(-[WKFullScreenViewController viewDidLayoutSubviews]):
(-[WKFullScreenViewController viewWillTransitionToSize:withTransitionCoordinator:]):
(-[WKFullScreenViewController preferredStatusBarStyle]):
(-[WKFullScreenViewController prefersStatusBarHidden]):
(-[WKFullScreenViewController gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKFullScreenViewController gestureRecognizer:shouldReceiveTouch:]):
(-[WKFullScreenViewController _manager]):
(-[WKFullScreenViewController _effectiveFullscreenInsetTop]):
(-[WKFullScreenViewController _cancelAction:]):
(-[WKFullScreenViewController _togglePiPAction:]):
(-[WKFullScreenViewController _touchDetected:]):
(-[WKFullScreenViewController _statusBarFrameDidChange:]):
(-[WKFullScreenViewController _updateWebViewFullscreenInsets]):
(-[WKFullScreenViewController _showPhishingAlert]):

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h: Copied from Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.h.
• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: Added.

(WebKit::replaceViewWithView):
(WebKit::WKWebViewState::applyTo):
(WebKit::WKWebViewState::store):
(-[WKFullscreenAnimationController transitionDuration:]):
(-[WKFullscreenAnimationController configureInitialAndFinalStatesForTransition:]):
(-[WKFullscreenAnimationController animateTransition:]):
(-[WKFullscreenAnimationController animationEnded:]):
(-[WKFullscreenAnimationController startInteractiveTransition:]):
(-[WKFullscreenAnimationController updateWithPercent:]):
(-[WKFullscreenAnimationController updateWithPercent:translation:anchor:]):
(-[WKFullscreenAnimationController end:]):
(-[WKFullScreenInteractiveTransition initWithAnimator:anchor:]):
(-[WKFullScreenInteractiveTransition wantsInteractiveStart]):
(-[WKFullScreenInteractiveTransition startInteractiveTransition:]):
(-[WKFullScreenInteractiveTransition updateInteractiveTransition:withTranslation:]):
(-[WKFullScreenInteractiveTransition cancelInteractiveTransition]):
(-[WKFullScreenInteractiveTransition finishInteractiveTransition]):
(-[WKFullScreenWindowController initWithWebView:]):
(-[WKFullScreenWindowController dealloc]):
(-[WKFullScreenWindowController isFullScreen]):
(-[WKFullScreenWindowController webViewPlaceholder]):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController requestExitFullScreen]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController close]):
(-[WKFullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen]):
(-[WKFullScreenWindowController videoControlsManagerDidChange]):
(-[WKFullScreenWindowController gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKFullScreenWindowController animationControllerForPresentedController:presentingController:sourceController:]):
(-[WKFullScreenWindowController animationControllerForDismissedController:]):
(-[WKFullScreenWindowController interactionControllerForDismissal:]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
(-[WKFullScreenWindowController _invalidateEVOrganizationName]):
(-[WKFullScreenWindowController _isSecure]):
(-[WKFullScreenWindowController _serverTrust]):
(-[WKFullScreenWindowController _EVOrganizationName]):
(-[WKFullScreenWindowController _updateLocationInfo]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _startToDismissFullscreenChanged:]):
(-[WKFullScreenWindowController _interactiveDismissChanged:]):

• UIProcess/ios/fullscreen/WKFullscreenStackView.h: Renamed from Source/WebKit/UIProcess/ios/WKFullScreenWindowControllerIOS.h.
• UIProcess/ios/fullscreen/WKFullscreenStackView.mm: Added.

(+[WKFullscreenStackView baseEffects]):
(+[WKFullscreenStackView configureView:forTintEffectWithColor:filterType:]):
(+[WKFullscreenStackView configureView:withBackgroundFillOfColor:opacity:filter:]):
(+[WKFullscreenStackView secondaryMaterialOverlayView]):
(+[WKFullscreenStackView applyPrimaryGlyphTintToView:]):
(+[WKFullscreenStackView applySecondaryGlyphTintToView:]):
(-[WKFullscreenStackView initWithArrangedSubviews:axis:]):
(-[WKFullscreenStackView setTargetViewForSecondaryMaterialOverlay:]):
(-[WKFullscreenStackView contentView]):
(-[WKFullscreenStackView _setArrangedSubviews:axis:]):
(-[WKFullscreenStackView setBounds:]):
(-[WKFullscreenStackView updateConstraints]):

• WebKit.xcodeproj/project.pbxproj:

5:38 PM Changeset in webkit [229511] by Megan Gardner

• 17 edits in trunk/Source

Media query for default appearance
​https://bugs.webkit.org/show_bug.cgi?id=183539
<rdar://problem/38326388>

Reviewed by Tim Horton.

Source/WebCore:

Not currently testable, will add tests in a later patch.

Write a media query to evaluate appearance.

• css/CSSValueKeywords.in:
• css/MediaFeatureNames.h:
• css/MediaQueryEvaluator.cpp:

(WebCore::defaultAppearanceEvaluate):

• css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

• page/Page.h:

(WebCore::Page::defaultAppearance const):
(WebCore::Page::setDefaultAppearance):

Source/WebKit:

Write a media query to evaluate appearance.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setUseSystemAppearance:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setDefaultAppearance):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::defaultAppearance const):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_credentialsMessenger):
(WebKit::WebPage::setDefaultAppearance):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

Write a media query to evaluate appearance.

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _setUseSystemAppearance:]):

3:26 PM Changeset in webkit [229510] by dbates@webkit.org

• 6 edits in trunk/Source/WebCore

InlineTextBox should own shadow data
​https://bugs.webkit.org/show_bug.cgi?id=183359
<rdar://problem/38171343>

Reviewed by Darin Adler.

Following r229147 we recompute the selection style, including any shadow data, whenever we
paint the inline text box. Therefore, InlineTextBox needs to take ownership of the shadow
data or it may be deallocated before it can be used.

Covered by existing tests.

• rendering/InlineTextBox.cpp: Changed data type of InlineTextBox::MarkedTextStyle::textShadow

from const ShadowData* to std::optional<ShadowData>. Also removed explicitly deleted equality
and inequality operators as they are unnecessary. Layout tests should catch if these are ever
implemented and used when painting because the painted results will be wrong.
(WebCore::InlineTextBox::computeStyleForUnmarkedMarkedText const): Clone ShadowData.
(WebCore::InlineTextBox::resolveStyleForMarkedText): Simplified logic.
(WebCore::InlineTextBox::paintMarkedTextForeground): Modified code now that MarkedTextStyle
holds a std::optional<ShadowData>.
(WebCore::InlineTextBox::paintMarkedTextDecoration): Ditto.

• rendering/TextPaintStyle.cpp:

(WebCore::computeTextSelectionPaintStyle): Changed the out parameter type from const ShadowData*
to std::optional<ShadowData>& and modified code as needed.

• rendering/TextPaintStyle.h:
• rendering/style/ShadowData.cpp: Removed unncessary #include of header LayoutRect.h.

This header will be included via ShadowData.h.
(WebCore::ShadowData::clone): Convenience method that returns an std::optional to a
cloned ShadowData object.

• rendering/style/ShadowData.h:

1:43 PM Changeset in webkit [229509] by jmarcell@apple.com

• 4 edits in tags/Safari-606.1.7.1/Source/JavaScriptCore

Cherry-pick r229506. rdar://problem/38316707

1:37 PM Changeset in webkit [229508] by jmarcell@apple.com

• 7 edits in tags/Safari-606.1.7.1/Source

Versioning.

1:34 PM Changeset in webkit [229507] by jmarcell@apple.com

• 1 copy in tags/Safari-606.1.7.1

New tag.

12:13 PM Changeset in webkit [229506] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

offlineasm should reset the Assembler's working state before doing another pass for a new target.
​https://bugs.webkit.org/show_bug.cgi?id=183538
<rdar://problem/38325955>

Reviewed by Michael Saboff.

• llint/LowLevelInterpreter.cpp:
• offlineasm/asm.rb:
• offlineasm/cloop.rb:

11:31 AM Changeset in webkit [229505] by Alan Bujtas

• 3 edits
  2 adds in trunk

Turn off offset*/scroll* optimization for input elements with shadow content
​https://bugs.webkit.org/show_bug.cgi?id=182383
<rdar://problem/37114190>

Reviewed by Antti Koivisto.

Source/WebCore:

We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
the previously computed values even when some part of the tree is dirty.
In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
for the root, while true (needs layout) for the shadow content.
This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.

Test: fast/forms/scrollheight-with-mutation-crash.html

• dom/Document.cpp:

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

LayoutTests:

• fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
• fast/forms/scrollheight-with-mutation-crash.html: Added.

9:28 AM Changeset in webkit [229504] by commit-queue@webkit.org

• 8 edits in trunk/Source

Unreviewed, rolling out r229436.
​https://bugs.webkit.org/show_bug.cgi?id=183542

seems to have regressed wasm compile times by 10% (Requested
by pizlo-mbp on #webkit).

Reverted changeset:

"bmalloc mutex should be adaptive"
​https://bugs.webkit.org/show_bug.cgi?id=177839
​https://trac.webkit.org/changeset/229436

3:33 AM Changeset in webkit [229503] by Wenson Hsieh

• 15 edits in trunk

[macOS] Copying a table from the Numbers app and pasting into iCloud Numbers fails
​https://bugs.webkit.org/show_bug.cgi?id=183485
<rdar://problem/38041984>

Reviewed by Ryosuke Niwa.

Source/WebCore:

After r222656, WebKit now treats raw image data on the pasteboard as files for the purposes of computing
DataTransfer.files and DataTransfer.types. However, this is combined with existing policies that suppress
DataTransfer.getData and DataTransfer.setData when the pasteboard contains files (generalized to copy/paste in
r222688). This means we now don't allow web pages to access "text/plain" in the case where the user copies part
of a table from the native Numbers app since Numbers additionally writes a snapshot of the table to the platform
pasteboard.

This restriction on getData/setData was intended to prevent web pages from extracting users' file paths when
pasting or dropping, so it doesn't make sense to enforce this restriction even when there is only in-memory
image data on the pasteboard. To fix this bug, we make Pasteboard::fileContentState() differentiate between
cases where there are (real) files on the pasteboard, and cases where we've fallen back to treating image data
as files.

Rebaselined existing LayoutTests to match new behavior.
Also covered by 4 new API tests:

• PasteMixedContent.ImageDataAndPlainText
• PasteMixedContent.ImageDataAndPlainTextAndURL
• PasteMixedContent.ImageDataAndPlainTextAndURLAndHTML
• UIPasteboardTests.DataTransferGetDataWhenPastingImageAndText

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::shouldSuppressGetAndSetDataToAvoidExposingFilePaths const):

If custom pasteboard data is enabled, suppress getData and setData if and only if we might actually expose file
paths (see Pasteboard::fileContentState).

(WebCore::DataTransfer::types const):

Only allow "text/html" or "text/uri-list" in the case where there are actual files in the pasteboard. If there's
only image data, add all of the DOM-safe types back into the list of types.

• platform/Pasteboard.h:
• platform/StaticPasteboard.h:

Add an enum type to represent the result of Pasteboard::fileContentState.

• NoFileOrImageData indicates that there was nothing on the pasteboard that could be considered a file

from the point of view of the page.

• InMemoryImage indicates that there are no files on the pasteboard, but there is image data that we consider

to be files, exposed via DataTransfer API.

• MayContainFilePaths indicates that there might be file paths on the pasteboard. This means that the source

has either written file paths to the pasteboard (for example, through NSFilenamesPboardType) or the source
has written image data along with a URL type of some sort that does not match one of the allowed URL schemes
that are safe to expose (currently, these are http-family, data, or blob).

• platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

Refactor to return one of the three enum types described above.

(WebCore::Pasteboard::containsFiles): Deleted.

• platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::fileContentState):
(WebCore::Pasteboard::containsFiles): Deleted.

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::fileContentState):
(WebCore::Pasteboard::containsFiles): Deleted.

• platform/wpe/PasteboardWPE.cpp:

(WebCore::Pasteboard::fileContentState):
(WebCore::Pasteboard::containsFiles): Deleted.

Adjust for Pasteboard::fileContentState() tweaks.

Tools:

Add new API tests to cover scenarios in which we paste image data alongside text data.

• TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

(TestWebKitAPI::TEST):

LayoutTests:

Rebaseline some pasteboard-related layout tests, in which we now expose text/plain alongside files that were
written to the DataTransfer by the page itself.

• editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt:
• editing/pasteboard/data-transfer-item-list-add-file-on-copy-expected.txt:
• editing/pasteboard/data-transfer-item-list-add-file-on-drag-expected.txt:

Mar 9, 2018:

9:27 PM Changeset in webkit [229502] by Chris Dumez

• 2 edits
  1 copy
  4 adds in trunk/LayoutTests

inspector/page/frameScheduledNavigation.html has different output with async policy delegates
​https://bugs.webkit.org/show_bug.cgi?id=183469

Reviewed by Ryosuke Niwa.

The test tracks 3 internal events:

1. frameScheduledNavigation
2. frameStartedLoading
3. frameClearedScheduledNavigation

Without async policy delegates, the events happen in this order. However, with asynchronous
policy delegates, frameStartedLoading happens *after* frameClearedScheduledNavigation. What
happens *before* frameClearedScheduledNavigation is the navigation policy check. When we
get the policy response to continue (asynchronously), we then actually start the load and
frameStartedLoading gets logged.

• inspector/page/frameScheduledNavigation-async-delegates-expected.txt: Added.
• inspector/page/frameScheduledNavigation-async-delegates.html: Copied from LayoutTests/inspector/page/frameScheduledNavigation.html.
• inspector/page/frameScheduledNavigation.html:

8:44 PM Changeset in webkit [229501] by Dewei Zhu

• 3 edits in trunk/Websites/perf.webkit.org

Create analysis task should use build time as fallback when commit time is not available.
​https://bugs.webkit.org/show_bug.cgi?id=183309

Reviewed by Ryosuke Niwa.

Added the ability to schedule analysis task for the range without commit time.

• public/privileged-api/create-analysis-task.php: Use build time as fallback.
• server-tests/privileged-api-create-analysis-task-tests.js: Added a unit test for this change.

7:53 PM Changeset in webkit [229500] by Chris Fleizach

• 5 edits
  2 adds in trunk

AX: WebKit seems to be running spell checker even on non-editable content text
​https://bugs.webkit.org/show_bug.cgi?id=183456
<rdar://problem/38076042>

Reviewed by Joanmarie Diggs.

Source/WebCore:

Test: accessibility/mac/attributed-string/attributed-string-does-not-includes-misspelled-for-non-editable.html

Only apply misspelled attributes if it's for editable text. It's not useful or performant to do this for static text.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetSpelling):

LayoutTests:

• accessibility/mac/attributed-string/attributed-string-does-not-includes-misspelled-for-non-editable-expected.txt: Added.
• accessibility/mac/attributed-string/attributed-string-does-not-includes-misspelled-for-non-editable.html: Added.
• accessibility/mac/attributed-string/attributed-string-for-range-with-options.html:
• accessibility/mac/attributed-string/attributed-string-for-range.html:

Update tests to reflect that only editable content returns misspelled attributes.

7:37 PM Changeset in webkit [229499] by n_wang@apple.com

• 4 edits in trunk

AX: AOM: More accessibility events support
​https://bugs.webkit.org/show_bug.cgi?id=183023
<rdar://problem/37764380>

Reviewed by Chris Fleizach.

Source/WebCore:

The test is crashing when we call updateBackingStore when
the AXObjectCache object is gone. Added a check to fix that.

Modified the test by using the right format of setTimeout and extended the delay.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

LayoutTests:

• accessibility/mac/AOM-events-webarea-crash.html:

7:10 PM Changeset in webkit [229498] by Ross Kirsling

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix WinCairo build after r229497.

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

5:47 PM Changeset in webkit [229497] by Ross Kirsling

• 2 edits in trunk/Source/WebCore

Clean up MIMETypeRegistry::mimeTypeAssociationMap for Curl
​https://bugs.webkit.org/show_bug.cgi?id=170529

Reviewed by Alex Christensen.

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):
(WebCore::mimeTypeAssociationMap): Deleted.
Create map with makeNeverDestroyed and a loop instead.

5:28 PM Changeset in webkit [229496] by Ryan Haddad

• 3 edits
  2 deletes in trunk/LayoutTests

Unreviewed, rolling out r229468.

This change caused http/tests/security/frame-loading-via-
document-write.html to fail.

Reverted changeset:

"http/tests/security/frame-loading-via-document-write-async-
delegates.html fails with async delegates"
​https://bugs.webkit.org/show_bug.cgi?id=183460
​https://trac.webkit.org/changeset/229468

5:24 PM Changeset in webkit [229495] by Nikita Vasilyev

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: Open all resources in Sources tab instead of Resources/Debugger
​https://bugs.webkit.org/show_bug.cgi?id=183317
<rdar://problem/38108455>

Reviewed by Matt Baker.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Main.js:
• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL):
Introduce preferredTabType option instead of listing ignoreResourcesTab, ignoreDebuggerTab, ignoreSearchTab, and ignoreNetworkTab.
The only correct outcome of selecting "Reveal in Sources Tab" context menu is to open Sources tab, not any other tab.

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):

• UserInterface/Views/TabBrowser.js:

(WI.TabBrowser.prototype.bestTabContentViewForRepresentedObject):

5:18 PM Changeset in webkit [229494] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

Unconditionalize more methods in VideoFullscreenInterface (and related classes)
​https://bugs.webkit.org/show_bug.cgi?id=183501
<rdar://problem/38312038>

Unreviewed build fix; add correct pragmas to code referencing m_playbackSessionManager.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::hasActiveVideoForControlsManager const):
(WebKit::WebPageProxy::requestControlledElementID const):
(WebKit::WebPageProxy::isPlayingVideoInEnhancedFullscreen const):

4:43 PM Changeset in webkit [229493] by BJ Burg

• 16 edits in trunk/Source

Web Inspector: there should only be one way for async backend commands to send failure
​https://bugs.webkit.org/show_bug.cgi?id=183524

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

If this is an async command, errors should be reported with BackendDispatcher::CallbackBase::sendFailure.
To avoid mixups, don't include the ErrorString out-parameter in generated async command signatures.
This change only affects interfaces generated for C++ backend dispatchers.

• inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:

(CppBackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command):

• inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

• inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:

Source/WebCore:

Remove some useless ErrorString arguments. Fix some bugs where we
may never call the callback in an early exit situation.

Covered by existing Inspector and protocol generator tests.

• inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::executeSQL):

• inspector/agents/InspectorDatabaseAgent.h:
• inspector/agents/InspectorIndexedDBAgent.h:
• inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::getDocumentAndIDBFactoryFromFrameOrSendFailure):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore::assertDocument): Deleted.
(WebCore::assertIDBFactory): Deleted.
Modernize this code a little bit to share the document/idbFactory extraction code.

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::loadResource):

• inspector/agents/InspectorNetworkAgent.h:

Source/WebKit:

Remove useless ErrorString argument from async commands.

For Automation protocol, introduce sync and async macros for filling
in and sending a failure response. Now that async commands don't have
an ErrorString and sync commands don't have a callback, trying to send
an error with the wrong macro is a compile-time error.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::getBrowsingContexts):
(WebKit::WebAutomationSession::getBrowsingContext):
(WebKit::WebAutomationSession::createBrowsingContext):
(WebKit::WebAutomationSession::closeBrowsingContext):
(WebKit::WebAutomationSession::switchToBrowsingContext):
(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
(WebKit::WebAutomationSession::waitForNavigationToComplete):
(WebKit::WebAutomationSession::navigateBrowsingContext):
(WebKit::WebAutomationSession::goBackInBrowsingContext):
(WebKit::WebAutomationSession::goForwardInBrowsingContext):
(WebKit::WebAutomationSession::reloadBrowsingContext):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::resolveChildFrameHandle):
(WebKit::WebAutomationSession::resolveParentFrameHandle):
(WebKit::WebAutomationSession::computeElementLayout):
(WebKit::WebAutomationSession::selectOptionElement):
(WebKit::WebAutomationSession::isShowingJavaScriptDialog):
(WebKit::WebAutomationSession::dismissCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::acceptCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::messageOfCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::setUserInputForCurrentJavaScriptPrompt):
(WebKit::WebAutomationSession::setFilesToSelectForFileUpload):
(WebKit::WebAutomationSession::getAllCookies):
(WebKit::WebAutomationSession::deleteSingleCookie):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::takeScreenshot):
(WebKit::WebAutomationSession::didTakeScreenshot):

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSessionMacros.h:
• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::inspectBrowsingContext):

4:41 PM Changeset in webkit [229492] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Crash in ServiceWorkerContainer::ready
​https://bugs.webkit.org/show_bug.cgi?id=183380

Reviewed by Chris Dumez.

Not using 'this' through lambdas.
Instead rely on the last lambda that is passed a ScriptExecutionContext& to get back 'this' which is a ServiceWorkerContainer.

Should be covered by imported/w3c/web-platform-tests/service-workers/service-worker/register-default-scope.https.html no longer crashing.
Although it should probably be LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html that should crash
since this is the main test using ready.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ready):

4:38 PM Changeset in webkit [229491] by youenn@apple.com

• 8 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource and RealtimeOutgoingVideoSource should be destroyed on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=183483
<rdar://problem/38214152>

Reviewed by Eric Carlson.

When dereferencing from libwebrtc code path, schedule a call to deref on main thread.
WebCore dereferencing is happening in the main thread so this guarantees destruction on the main thread.

Covered by updated mock libwebrtc peer connection backend.
We make mock senders to keep a reference to their source which are RealtimeOutgoingXXSource.
We then make mock peer connection backend to free the mock senders in a background thread.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doStop):

• platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::stop):

• platform/mediastream/RealtimeOutgoingAudioSource.h:
• platform/mediastream/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::stop):

• platform/mediastream/RealtimeOutgoingVideoSource.h:
• testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::ThreadKeeper::create):
(WebCore::ThreadKeeper::setThread):
(WebCore::MockLibWebRTCPeerConnection::~MockLibWebRTCPeerConnection):

• testing/MockLibWebRTCPeerConnection.h:

4:12 PM Changeset in webkit [229490] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

Don't pass NULL to the result parameter of SecTrustEvaluate()
​https://bugs.webkit.org/show_bug.cgi?id=183495
<rdar://problem/38185688>

Reviewed by Andy Estes.

• UIProcess/ios/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _EVOrganizationName]):

3:45 PM Changeset in webkit [229489] by aakash_jain@apple.com

• 3 edits in trunk/Websites/perf.webkit.org

BuildbotBuildEntry for buildbot 0.9 uses incorrect buildrequestid
​https://bugs.webkit.org/show_bug.cgi?id=183194

Reviewed by Ryosuke Niwa.

• tools/js/buildbot-syncer.js:

(BuildbotBuildEntry.prototype.initialize): Updated _buildRequestId to use correct build-request-id, as set in syncer._buildRequestPropertyName.
(BuildbotSyncer.prototype.pathForPendingBuilds): Updated url to fetch properties for build-requests.

• unit-tests/buildbot-syncer-tests.js:

(sampleBuildData): Updated sampleBuildData with correct build-request-id in properties. Added
properties to samplePendingBuildRequestData.

3:39 PM Changeset in webkit [229488] by dino@apple.com

• 5 edits in trunk/Source/WebKit

Allow NavigationState to intercept requests and send them to SystemPreviewController
​https://bugs.webkit.org/show_bug.cgi?id=183526
<rdar://problem/37801140>

Reviewed by Tim Horton.

Implement a bit more of SystemPreviewController, such that it can be used
from NavigationState to identify and handle content that can be previewed.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

If we'd in a download response policy, then check if SystemPreviewController
can show the content. We ignore the download, but pass the original URL onto
the preview. Ultimately, we'd want to avoid the navigation
but use the download destination URL for preview.

• UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

(-[_WKPreviewControllerDataSource initWithURL:]):

Move the URL to property, to help use a single datasource object for all previews.

(-[_WKPreviewControllerDataSource previewController:previewItemAtIndex:]):
(-[_WKPreviewControllerDelegate initWithSystemPreviewController:]):

Add a delegate object, so we can detect when the preview is dismissed and return
to the previous page.

(-[_WKPreviewControllerDelegate previewControllerWillDismiss:]):
(WebKit::SystemPreviewController::showPreview):

Use single instances of the QLPreviewController, its datasource and delegate.

• UIProcess/SystemPreviewController.cpp:

Add a helper to navigate back.

(WebKit::SystemPreviewController::SystemPreviewController):
(WebKit::SystemPreviewController::sendPageBack):

• UIProcess/SystemPreviewController.h:

3:10 PM Changeset in webkit [229487] by jer.noble@apple.com

• 3 edits in trunk/Source/WebKit

webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness
​https://bugs.webkit.org/show_bug.cgi?id=183383
<rdar://problem/38197028>

Reviewed by Eric Carlson.

Follow-up patch: now that the 'fullscreenchange' event is being fired slightly earlier, the
Fullscreen.TopContentInset tests triggers what appears to be an existing behavior: if you
exit in the middle of an enter fullscreen animation, the exit never happens, because the
NSWindow never starts the exit animation. The solution is to store the exit fullscreen
request, and only act upon it when the enter animation completes.

• UIProcess/mac/WKFullScreenWindowController.h:
• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):

3:07 PM Changeset in webkit [229486] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Build fix after r229476.
​https://bugs.webkit.org/show_bug.cgi?id=183488

Not reviewed.

• runtime/StackAlignment.h:

2:56 PM Changeset in webkit [229485] by jer.noble@apple.com

• 19 edits in trunk/Source

Unconditionalize more methods in VideoFullscreenInterface (and related classes)
​https://bugs.webkit.org/show_bug.cgi?id=183501

Reviewed by Eric Carlson.

Source/WebCore:

No need for these methods to be PLATFORM(MAC) only.

• platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModelClient::ensureControlsManager):

• platform/ios/VideoFullscreenInterfaceAVKit.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::isPlayingVideoInEnhancedFullscreen const):

• platform/mac/VideoFullscreenInterfaceMac.h:

Source/WebKit:

No reason for these methods to be PLATFORM(MAC) only.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _videoControlsManagerDidChange]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::setUpPlaybackControlsManagerWithID):
(WebKit::PlaybackSessionManagerProxy::clearPlaybackControlsManager):

• UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):
(WebKit::WebPageProxy::handleControlledElementIDResponse const):
(WebKit::WebPageProxy::isPlayingVideoInEnhancedFullscreen const):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::videoControlsManagerDidChange):

• UIProcess/ios/WKFullScreenWindowControllerIOS.h:
• UIProcess/ios/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController videoControlsManagerDidChange]):

• WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::setUpPlaybackControlsManager):

2:43 PM Changeset in webkit [229484] by pvollan@apple.com

• 4 edits in trunk/Source/WebKit

Create CA layer contexts with +remoteContextWithOptions.
​https://bugs.webkit.org/show_bug.cgi?id=182747

Reviewed by Brent Fulgham.

CA layer contexts (CAContext) are currently created with +contextWithCGSConnection, which is
using the main WindowServer connection to create the context. Instead, the contexts can be
created with +remoteContextWithOptions, which does not use the main WindowServer connection.
This is a step towards limiting the access the WebContent process has to the window server.
To make the +remoteContextWithOptions call succeed, the sandbox has to be modified to allow
access to CARenderServer. Also, access to the WindowServer should be denied by calling
CGSSetDenyWindowServerConnections(true) before entering the sandbox. This is planned to do
in a follow-up patch. The call to +remoteContextWithOptions will open up WindowServer
connections, since the WindowServer is the system default CA render server, but these
connections come with limited WindowServer exposure. In addition, we need to open up the
sandbox for accessing some IOKit properties.

• Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForExternalHostingProcess):

• Shared/mac/HangDetectionDisablerMac.mm:

(WebKit::setClientsMayIgnoreEvents):

• WebProcess/com.apple.WebProcess.sb.in:

1:47 PM Changeset in webkit [229483] by youenn@apple.com

• 3 edits
  4 adds in trunk

ServiceWorker should respect IDB and DOMCache partitioning
​https://bugs.webkit.org/show_bug.cgi?id=183496

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/wpt/service-workers/third-party-registration.html

Set the correct top origin of service worker ScriptExecutionContext.

• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):

LayoutTests:

• http/wpt/service-workers/resources/third-party-registration-frame.html: Added.
• http/wpt/service-workers/resources/third-party-worker.js: Added.
• http/wpt/service-workers/third-party-registration-expected.txt: Added.
• http/wpt/service-workers/third-party-registration.html: Added.

1:45 PM Changeset in webkit [229482] by mark.lam@apple.com

• 6 edits in trunk/Source/JavaScriptCore

[Re-landing] Add support for ARM64E.
​https://bugs.webkit.org/show_bug.cgi?id=183398
<rdar://problem/38212621>

Reviewed by Michael Saboff.

• assembler/MacroAssembler.h:
• llint/LLIntOfflineAsmConfig.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/backends.rb:

1:35 PM Changeset in webkit [229481] by mark.lam@apple.com

• 20 edits
  1 add in trunk/Source

[Re-landing] Prepare LLInt code to support pointer profiling.
​https://bugs.webkit.org/show_bug.cgi?id=183387
<rdar://problem/38199678>

Reviewed by JF Bastien.

Source/JavaScriptCore:

1. Introduced PtrTag enums for supporting pointer profiling later.

2. Also introduced tagging, untagging, retagging, and tag removal placeholder template functions for the same purpose.

3. Prepare the offlineasm for supporting pointer profiling later.

4. Tagged some pointers in LLInt asm code. Currently, these should have no effect on behavior.

5. Removed returnToThrowForThrownException() because it is not used anywhere.

6. Added the offlineasm folder to JavaScriptCore Xcode project so that it's easier to view and edit these files in Xcode.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/LLIntCallLinkInfo.h:

(JSC::LLIntCallLinkInfo::unlink):

• llint/LLIntData.cpp:

(JSC::LLInt::initialize):

• llint/LLIntData.h:
• llint/LLIntExceptions.cpp:

(JSC::LLInt::returnToThrowForThrownException): Deleted.

• llint/LLIntExceptions.h:
• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntOffsetsExtractor.cpp:
• llint/LLIntPCRanges.h:

(JSC::LLInt::isLLIntPC):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/ast.rb:
• offlineasm/instructions.rb:
• offlineasm/risc.rb:
• runtime/PtrTag.h: Added.

(JSC::uniquePtrTagID):
(JSC::ptrTag):
(JSC::tagCodePtr):
(JSC::untagCodePtr):
(JSC::retagCodePtr):
(JSC::removeCodePtrTag):

Source/WTF:

• wtf/Platform.h:

1:31 PM Changeset in webkit [229480] by Brent Fulgham

• 9 edits in trunk/Source/WebKit

Remove cookie API access from WebContent Process
​https://bugs.webkit.org/show_bug.cgi?id=183519
<rdar://problem/35368802>

Reviewed by Alex Christensen.

All cookie access is now handled in the Network Process. However, there are vestiges of the original logic that used CFNetwork APIs in the WebContent process.

This patch removes CFNetwork calls from the WebProcess code paths, since they serve no purpose in modern WebKit.

No tests because this is a code cleanup with no expected change in behavior.

• NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Moved from WebFrameNetworkingContext.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::setSharedHTTPCookieStorage): Moved from ChildProcess, since this should only be
called in the NetworkProcess.

• Shared/ChildProcess.h:
• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setSharedHTTPCookieStorage): Deleted.

• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession): Remove CFNetwork code. This version of
'ensureWebsiteDataStoreSession' is needed to maintain a dictionary on the WebProcess side so we can refer to
the same network session in both the WebContent and Network processes.
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Deleted.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Remove calls to CFNetwork.

1:14 PM Changeset in webkit [229479] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Cannot change audio input source device
​https://bugs.webkit.org/show_bug.cgi?id=175975
<rdar://problem/34073589>

Reviewed by Eric Carlson.

Covered by manually testing ​https://webrtc.github.io/samples/src/content/devices/input-output/ with a USB web cam.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::setCaptureDeviceID):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):

1:04 PM Changeset in webkit [229478] by mark.lam@apple.com

• 14 edits in trunk/Source/JavaScriptCore

Remove unused LLINT_STATS feature.
​https://bugs.webkit.org/show_bug.cgi?id=183522
<rdar://problem/38313139>

Rubber-stamped by Keith Miller.

We haven't used this in a while, and it is one more option that makes offlineasm
build slower. We can always re-introduce this later if we need it.

• jsc.cpp:
• llint/LLIntCommon.h:
• llint/LLIntData.cpp:

(JSC::LLInt::initialize):
(JSC::LLInt::Data::finalizeStats): Deleted.
(JSC::LLInt::compareStats): Deleted.
(JSC::LLInt::Data::dumpStats): Deleted.
(JSC::LLInt::Data::ensureStats): Deleted.
(JSC::LLInt::Data::loadStats): Deleted.
(JSC::LLInt::Data::resetStats): Deleted.
(JSC::LLInt::Data::saveStats): Deleted.

• llint/LLIntData.h:

(): Deleted.
(JSC::LLInt::Data::opcodeStats): Deleted.

• llint/LLIntOfflineAsmConfig.h:
• llint/LLIntSlowPaths.cpp:
• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/Options.cpp:

(JSC::Options::isAvailable):
(JSC::recomputeDependentOptions):

• runtime/Options.h:
• runtime/TestRunnerUtils.cpp:

(JSC::finalizeStatsAtEndOfTesting):

12:47 PM Changeset in webkit [229477] by youenn@apple.com

• 4 edits in trunk

ServiceWorkerClientFetch should send data to its resource loader once the didReceiveResponse completion handler is called
​https://bugs.webkit.org/show_bug.cgi?id=183110

Reviewed by Chris Dumez.

Buffering data/finish event/fail event until the response completion handler is called.

• WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::didReceiveResponse):
(WebKit::ServiceWorkerClientFetch::didReceiveData):
(WebKit::ServiceWorkerClientFetch::didFinish):
(WebKit::ServiceWorkerClientFetch::didFail):
(WebKit::ServiceWorkerClientFetch::didNotHandle):
(WebKit::ServiceWorkerClientFetch::cancel):
(WebKit::ServiceWorkerClientFetch::continueLoadingAfterCheckingResponse):

• WebProcess/Storage/ServiceWorkerClientFetch.h:

12:27 PM Changeset in webkit [229476] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Relanding "testmasm crashes in testBranchTruncateDoubleToInt32() on ARM64"
​https://bugs.webkit.org/show_bug.cgi?id=183488

It applied and built just fine locally.

• assembler/testmasm.cpp:

(JSC::testBranchTruncateDoubleToInt32):

11:20 AM Changeset in webkit [229475] by jer.noble@apple.com

• 16 edits
  4 adds in trunk

Add new CSS env constants for use with fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=183498

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fullscreen/fullscreen-auto-hide-delay.html

fullscreen/fullscreen-inset-top.html

• dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::nameForProperty const):
(WebCore::variableDataForPositiveDuration):
(WebCore::ConstantPropertyMap::setFullscreenInsetTop):
(WebCore::ConstantPropertyMap::setFullscreenAutoHideDelay):

• dom/ConstantPropertyMap.h:
• page/Page.cpp:

(WebCore::Page::setFullscreenInsetTop):
(WebCore::Page::setFullscreenAutoHideDelay):

• page/Page.h:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setFullscreenInsetTop):
(WebCore::Internals::setFullscreenAutoHideDelay):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Pass the values given to WebFullScreenManagerProxy through the process boundary and
into WebCore.

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::setFullscreenInsetTop):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDelay):

• UIProcess/WebFullScreenManagerProxy.h:
• WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::setFullscreenInsetTop):
(WebKit::WebFullScreenManager::setFullscreenAutoHideDelay):

• WebProcess/FullScreen/WebFullScreenManager.h:
• WebProcess/FullScreen/WebFullScreenManager.messages.in:

LayoutTests:

• fullscreen/full-screen-test.js:

(run):

• fullscreen/fullscreen-auto-hide-delay-expected.txt: Added.
• fullscreen/fullscreen-auto-hide-delay.html: Added.
• fullscreen/fullscreen-inset-top-expected.txt: Added.
• fullscreen/fullscreen-inset-top.html: Added.

11:14 AM Changeset in webkit [229474] by Alan Bujtas

• 9 edits
  2 adds in trunk

RenderTreeBuilder::splitAnonymousBoxesAroundChild should take multicolumn spanners into account.
​https://bugs.webkit.org/show_bug.cgi?id=183493
<rdar://problem/38030461>

Reviewed by Antti Koivisto.

Source/WebCore:

Multicolumn spanners are taken out of their original position and placed next
to a RenderMultiColumnSet. splitAnonymousBoxesAroundChild needs to know the original parent (in the render tree context).

Test: fast/multicol/adjust-beforeChild-for-spanner-crash.html

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::splitAnonymousBoxesAroundChild):

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):

• rendering/updating/RenderTreeBuilderMultiColumn.cpp:

(WebCore::RenderTreeBuilder::MultiColumn::adjustBeforeChildForMultiColumnSpannerIfNeeded):

• rendering/updating/RenderTreeBuilderMultiColumn.h:
• rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::moveChildrenInternal):

• rendering/updating/RenderTreeBuilderTable.cpp:

(WebCore::RenderTreeBuilder::Table::attach):

LayoutTests:

• fast/multicol/adjust-beforeChild-for-spanner-crash-expected.txt: Added.
• fast/multicol/adjust-beforeChild-for-spanner-crash.html: Added.

11:10 AM Changeset in webkit [229473] by Alan Bujtas

• 1 edit
  97 adds in trunk/Tools

[LayoutReloaded] Initial commit -block formatting context.
​https://bugs.webkit.org/show_bug.cgi?id=183462

Reviewed by Antti Koivisto.

See README.md

• LayoutReloaded/BlockContainer.js: Added.

(BlockContainer):
(BlockContainer.prototype.establishesInlineFormattingContext):

• LayoutReloaded/BlockFormattingContext.js: Added.

(BlockFormattingContext):
(BlockFormattingContext.prototype.layout):
(BlockFormattingContext.prototype.computeWidth):
(BlockFormattingContext.prototype.computeHeight):
(BlockFormattingContext.prototype.marginTop):
(BlockFormattingContext.prototype.marginBottom):
(BlockFormattingContext.prototype._computeStaticPosition):
(BlockFormattingContext.prototype._placeInFlowPositionedChildren):
(BlockFormattingContext.prototype._placeOutOfFlowDescendants):
(BlockFormattingContext.prototype._computeOutOfFlowWidth):
(BlockFormattingContext.prototype._computeFloatingWidth):
(BlockFormattingContext.prototype._computeInFlowWidth):
(BlockFormattingContext.prototype._computeOutOfFlowHeight):
(BlockFormattingContext.prototype._computeFloatingHeight):
(BlockFormattingContext.prototype._computeInFlowHeight):
(BlockFormattingContext.prototype._computeHorizontalConstraint):
(BlockFormattingContext.prototype._computeContentHeight):
(BlockFormattingContext.prototype._computeInFlowPositionedPosition):
(BlockFormattingContext.prototype._computeOutOfFlowPosition):
(BlockFormattingContext.prototype._shrinkToFitWidth):

• LayoutReloaded/BlockMarginCollapse.js: Added.

(BlockMarginCollapse.marginTop):
(BlockMarginCollapse.marginBottom):
(BlockMarginCollapse._isMarginTopCollapsedWithSibling):
(BlockMarginCollapse._isMarginBottomCollapsedWithSibling):
(BlockMarginCollapse._isMarginTopCollapsedWithParent):
(BlockMarginCollapse._isMarginBottomCollapsedWithParent):
(BlockMarginCollapse._nonCollapsedMarginTop):
(BlockMarginCollapse._nonCollapsedMarginBottom):
(BlockMarginCollapse._collapsedMarginTopFromFirstChild):
(BlockMarginCollapse._collapsedMarginBottomFromLastChild):
(BlockMarginCollapse._marginValue):
(BlockMarginCollapse._hasAdjoiningMarginTopAndBottom):
(BlockMarginCollapse):

• LayoutReloaded/Box.js: Added.

(Box):
(Box.prototype.id):
(Box.prototype.setRendererName):
(Box.prototype.name):
(Box.prototype.node):
(Box.prototype.parent):
(Box.prototype.nextSibling):
(Box.prototype.nextInFlowSibling):
(Box.prototype.previousSibling):
(Box.prototype.previousInFlowSibling):
(Box.prototype.setParent):
(Box.prototype.setNextSibling):
(Box.prototype.setPreviousSibling):
(Box.prototype.rect):
(Box.prototype.topLeft):
(Box.prototype.bottomRight):
(Box.prototype.setTopLeft):
(Box.prototype.setSize):
(Box.prototype.setWidth):
(Box.prototype.setHeight):
(Box.prototype.isContainer):
(Box.prototype.isBlockLevelBox):
(Box.prototype.isBlockContainerBox):
(Box.prototype.isInlineLevelBox):
(Box.prototype.setIsAnonymous):
(Box.prototype.isAnonymous):
(Box.prototype.establishesFormattingContext):
(Box.prototype.establishedFormattingContext):
(Box.prototype.establishesBlockFormattingContext):
(Box.prototype.establishesInlineFormattingContext):
(Box.prototype.isPositioned):
(Box.prototype.isRelativePositioned):
(Box.prototype.isAbsolutePositioned):
(Box.prototype.isFixedPositioned):
(Box.prototype.isInFlow):
(Box.prototype.isOutOfFlowPositioned):
(Box.prototype.isInFlowPositioned):
(Box.prototype.isFloatingPositioned):
(Box.prototype.isFloatingOrOutOfFlowPositioned):
(Box.prototype.isRootElement):
(Box.prototype.containingBlock):
(Box.prototype.borderBox):
(Box.prototype.paddingBox):
(Box.prototype.contentBox):

• LayoutReloaded/Container.js: Added.

(Container):
(Container.prototype.isContainer):
(Container.prototype.setFirstChild):
(Container.prototype.setLastChild):
(Container.prototype.firstChild):
(Container.prototype.firstInFlowChild):
(Container.prototype.lastChild):
(Container.prototype.lastInFlowChild):
(Container.prototype.hasChild):
(Container.prototype.hasInFlowChild):

• LayoutReloaded/FloatingContext.js: Added.

(FloatingContext):
(FloatingContext.prototype.computePosition):
(FloatingContext.prototype.bottom):
(FloatingContext.prototype._positionForFloating):
(FloatingContext.prototype._positionForClear):
(FloatingContext.prototype._computePositionToAvoidIntrudingFloats):
(FloatingContext.prototype._addFloating):
(FloatingContext.prototype._findInnerMostLeftAndRight):
(FloatingContext.prototype._moveToNextVerticalPosition):
(FloatingContext.prototype._availableSpace):
(FloatingContext.prototype._findFloatingAtVerticalPosition):
(FloatingContext.prototype._isEmpty):
(FloatingContext.prototype._adjustedFloatingPosition):
(FloatingContext.prototype._bottom):
(FloatingContext.prototype._formattingContext):

• LayoutReloaded/FormattingContext.js: Added.

(FormattingContext):
(FormattingContext.prototype.rootContainer):
(FormattingContext.prototype.floatingContext):
(FormattingContext.prototype.layout):
(FormattingContext.prototype.computeWidth):
(FormattingContext.prototype.computeHeight):
(FormattingContext.prototype.marginTop):
(FormattingContext.prototype.marginLeft):
(FormattingContext.prototype.marginBottom):
(FormattingContext.prototype.marginRight):
(FormattingContext.prototype.absoluteMarginBox):
(FormattingContext.prototype.absoluteBorderBox):
(FormattingContext.prototype.absolutePaddingBox):
(FormattingContext.prototype.absoluteContentBox):

• LayoutReloaded/InitialBlockContainer.js: Added.

(InitialBlockContainer):
(InitialBlockContainer.prototype.establishesBlockFormattingContext):
(InitialBlockContainer.prototype.paddingBox):
(InitialBlockContainer.prototype.contentBox):

• LayoutReloaded/InlineBox.js: Added.

(InlineBox):
(InlineBox.prototype.setText):
(InlineBox.prototype.text):

• LayoutReloaded/InlineFormattingContext.js: Added.

(InlineFormattingContext):
(InlineFormattingContext.prototype.layout):
(InlineFormattingContext.prototype._handleInlineBox):
(InlineFormattingContext.prototype._handleText):

• LayoutReloaded/Layout.js: Added.

(layout):

• LayoutReloaded/LayoutContext.js: Added.

(LayoutContext):
(LayoutContext.prototype.layoutFormattingContext):

• LayoutReloaded/LayoutReloaded.xcworkspace/contents.xcworkspacedata: Added.
• LayoutReloaded/LayoutReloaded.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist: Added.
• LayoutReloaded/README.md: Added.
• LayoutReloaded/Text.js: Added.

(Text):

• LayoutReloaded/TreeBuilder.js: Added.

(TreeBuilder.prototype.createTree):
(TreeBuilder.prototype._createAndAttachBox):
(TreeBuilder.prototype._appendChild):
(TreeBuilder.prototype._findBox):
(TreeBuilder.prototype._findNode):
(TreeBuilder):

• LayoutReloaded/Utils.js: Added.

(LayoutPoint):
(LayoutPoint.prototype.setLeft):
(LayoutPoint.prototype.setTop):
(LayoutPoint.prototype.left):
(LayoutPoint.prototype.top):
(LayoutPoint.prototype.shiftLeft):
(LayoutPoint.prototype.shiftTop):
(LayoutPoint.prototype.moveBy):
(LayoutPoint.prototype.equal):
(LayoutPoint.prototype.clone):
(LayoutSize):
(LayoutSize.prototype.setWidth):
(LayoutSize.prototype.setHeight):
(LayoutSize.prototype.width):
(LayoutSize.prototype.height):
(LayoutSize.prototype.growBy):
(LayoutSize.prototype.shrinkBy):
(LayoutSize.prototype.isEmpty):
(LayoutSize.prototype.equal):
(LayoutSize.prototype.clone):
(LayoutRect):
(LayoutRect.prototype.setTop):
(LayoutRect.prototype.setLeft):
(LayoutRect.prototype.setBottom):
(LayoutRect.prototype.setRight):
(LayoutRect.prototype.left):
(LayoutRect.prototype.top):
(LayoutRect.prototype.bottom):
(LayoutRect.prototype.right):
(LayoutRect.prototype.setTopLeft):
(LayoutRect.prototype.topLeft):
(LayoutRect.prototype.topRight):
(LayoutRect.prototype.bottomRight):
(LayoutRect.prototype.setWidth):
(LayoutRect.prototype.setHeight):
(LayoutRect.prototype.setSize):
(LayoutRect.prototype.size):
(LayoutRect.prototype.width):
(LayoutRect.prototype.height):
(LayoutRect.prototype.growBy):
(LayoutRect.prototype.shrinkBy):
(LayoutRect.prototype.moveBy):
(LayoutRect.prototype.isEmpty):
(LayoutRect.prototype.equal):
(LayoutRect.prototype.intersects):
(LayoutRect.prototype.contains):
(LayoutRect.prototype.clone):
(ASSERT_NOT_REACHED):
(ASSERT):
(Utils.computedValue):
(Utils.propertyIsAuto):
(Utils.isWidthAuto):
(Utils.isHeightAuto):
(Utils.isTopAuto):
(Utils.isLeftAuto):
(Utils.isBottomAuto):
(Utils.isRightAuto):
(Utils.width):
(Utils.height):
(Utils.top):
(Utils.bottom):
(Utils.left):
(Utils.right):
(Utils.hasBorderTop):
(Utils.hasBorderBottom):
(Utils.hasPaddingTop):
(Utils.hasPaddingBottom):
(Utils.computedMarginTop):
(Utils.computedMarginLeft):
(Utils.computedMarginBottom):
(Utils.computedMarginRight):
(Utils.computedBorderTopLeft):
(Utils.computedBorderBottomRight):
(Utils.computedPaddingTopLeft):
(Utils.computedPaddingBottomRight):
(Utils.computedBorderAndPaddingTop):
(Utils.computedBorderAndPaddingLeft):
(Utils.computedBorderAndPaddingBottom):
(Utils.computedBorderAndPaddingRight):
(Utils.computedHorizontalBorderAndPadding):
(Utils.computedVerticalBorderAndPadding):
(Utils.hasClear):
(Utils.hasClearLeft):
(Utils.hasClearRight):
(Utils.hasClearBoth):
(Utils.isBlockLevelElement):
(Utils.isBlockContainerElement):
(Utils.isInlineLevelElement):
(Utils.isTableElement):
(Utils.isRelativePositioned):
(Utils.isAbsolutePositioned):
(Utils.isFixedPositioned):
(Utils.isOverflowVisible):
(Utils.isFloatingPositioned):
(Utils.isFloatingLeft):
(Utils.mapToContainer):
(Utils.mapStaticToAbsolute):
(Utils.collectOutOfFlowDescendants):
(Utils.nextBreakingOpportunity):
(Utils.measureText):
(Utils.layoutTreeDump):
(Utils._dumpBox):
(Utils._dumpTree):
(Utils):

• LayoutReloaded/misc/LayoutReloadedWebKit.patch: Added.
• LayoutReloaded/misc/headers/BlockContainer.h: Added.
• LayoutReloaded/misc/headers/BlockFormattingContext.h: Added.
• LayoutReloaded/misc/headers/BlockMarginCollapse.h: Added.
• LayoutReloaded/misc/headers/Box.h: Added.
• LayoutReloaded/misc/headers/Container.h: Added.
• LayoutReloaded/misc/headers/FloatingContext.h: Added.
• LayoutReloaded/misc/headers/FormattingContext.h: Added.
• LayoutReloaded/misc/headers/InitialBlockContainer.h: Added.
• LayoutReloaded/misc/headers/InlineBox.h: Added.
• LayoutReloaded/misc/headers/LayoutContext.h: Added.
• LayoutReloaded/misc/headers/Text.h: Added.
• LayoutReloaded/test/TestHarness.js: Added.

(verifyLayoutTreeDump):
(runLayout):

• LayoutReloaded/test/absolute-auto-with-sibling-margin-bottom.html: Added.
• LayoutReloaded/test/absolute-bottom.html: Added.
• LayoutReloaded/test/absolute-height-stretch.html: Added.
• LayoutReloaded/test/absolute-left-auto.html: Added.
• LayoutReloaded/test/absolute-left-right-top-bottom-auto.html: Added.
• LayoutReloaded/test/absolute-nested.html: Added.
• LayoutReloaded/test/absolute-nested2.html: Added.
• LayoutReloaded/test/absolute-simple.html: Added.
• LayoutReloaded/test/absolute-width-shrink-to-fit.html: Added.
• LayoutReloaded/test/absolute-width-stretch.html: Added.
• LayoutReloaded/test/absolute-with-inline-preferred-width.html: Added.
• LayoutReloaded/test/absolute-with-static-block-position-nested.html: Added.
• LayoutReloaded/test/almost-intruding-left-float-simple.html: Added.
• LayoutReloaded/test/border-simple.html: Added.
• LayoutReloaded/test/fixed-nested.html: Added.
• LayoutReloaded/test/float-left-when-container-has-padding-margin.html: Added.
• LayoutReloaded/test/floating-box-clear-both-simple.html: Added.
• LayoutReloaded/test/floating-box-clear-right-simple.html: Added.
• LayoutReloaded/test/floating-box-left-and-right-multiple-with-top-offset.html: Added.
• LayoutReloaded/test/floating-box-left-and-right-multiple.html: Added.
• LayoutReloaded/test/floating-box-right-simple.html: Added.
• LayoutReloaded/test/floating-box-with-clear-siblings.html: Added.
• LayoutReloaded/test/floating-box-with-clear-simple.html: Added.
• LayoutReloaded/test/floating-box-with-new-formatting-context.html: Added.
• LayoutReloaded/test/floating-box-with-relative-positioned-sibling.html: Added.
• LayoutReloaded/test/floating-left-right-simple.html: Added.
• LayoutReloaded/test/floating-left-right-with-all-margins.html: Added.
• LayoutReloaded/test/floating-lefts-and-rights-simple.html: Added.
• LayoutReloaded/test/floating-multiple-lefts-in-body.html: Added.
• LayoutReloaded/test/floating-multiple-lefts-multiple-lines.html: Added.
• LayoutReloaded/test/floating-multiple-lefts.html: Added.
• LayoutReloaded/test/floating-sizing.html: Added.
• LayoutReloaded/test/floating-sizing2.html: Added.
• LayoutReloaded/test/floating-sizing3.html: Added.
• LayoutReloaded/test/floating-with-new-block-formatting-context.html: Added.
• LayoutReloaded/test/index.html: Added.
• LayoutReloaded/test/inline-content-simple.html: Added.
• LayoutReloaded/test/intruding-left-float-simple.html: Added.
• LayoutReloaded/test/margin-collapse-bottom-bottom.html: Added.
• LayoutReloaded/test/margin-collapse-bottom-nested.html: Added.
• LayoutReloaded/test/margin-collapse-first-last-are-floating.html: Added.
• LayoutReloaded/test/margin-collapse-simple.html: Added.
• LayoutReloaded/test/margin-collapse-top-nested.html: Added.
• LayoutReloaded/test/margin-collapse-when-child-has-padding-border.html: Added.
• LayoutReloaded/test/margin-collapse-with-block-formatting-context.html: Added.
• LayoutReloaded/test/margin-collapse-with-block-formatting-context2.html: Added.
• LayoutReloaded/test/margin-left-right-sizing-out-of-flow.html: Added.
• LayoutReloaded/test/margin-left-right-sizing.html: Added.
• LayoutReloaded/test/margin-propagation-simple-content-height.html: Added.
• LayoutReloaded/test/margin-sibling-collapse-propagated.html: Added.
• LayoutReloaded/test/margin-simple.html: Added.
• LayoutReloaded/test/negative-margin-simple.html: Added.
• LayoutReloaded/test/padding-nested.html: Added.
• LayoutReloaded/test/padding-simple.html: Added.
• LayoutReloaded/test/relative-auto-with-parent-offset.html: Added.
• LayoutReloaded/test/relative-auto.html: Added.
• LayoutReloaded/test/relative-bottom.html: Added.
• LayoutReloaded/test/relative-right.html: Added.
• LayoutReloaded/test/relative-siblings.html: Added.
• LayoutReloaded/test/relative-simple.html: Added.

10:59 AM Changeset in webkit [229472] by jer.noble@apple.com

• 9 edits in trunk/Source

Add isPictureInPictureActive messaging across WebKit process boundary
​https://bugs.webkit.org/show_bug.cgi?id=183499

Reviewed by Eric Carlson.

Source/WebCore:

• platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModelClient::pictureInPictureActiveChanged):

• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::updateForEventName):
(WebCore::PlaybackSessionModelMediaElement::isPictureInPictureActive const):

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::isPictureInPictureActive const):

Source/WebKit:

• UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
• UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
• UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::pictureInPictureActiveChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureActiveChanged):

10:51 AM Changeset in webkit [229471] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[Curl] Implement connection limit.
​https://bugs.webkit.org/show_bug.cgi?id=183016

Implement both connection limit per host and total
connection limit on curl network layer.

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-03-09
Reviewed by Youenn Fablet.

No new tests because there's no behavior change.

• platform/network/curl/CurlContext.cpp:

(WebCore::EnvironmentVariableReader::sscanTemplate<signed>):
(WebCore::CurlContext::CurlContext):
(WebCore::CurlMultiHandle::setMaxConnects):
(WebCore::CurlMultiHandle::setMaxTotalConnections):
(WebCore::CurlMultiHandle::setMaxHostConnections):

• platform/network/curl/CurlContext.h:

(WebCore::CurlContext::scheduler):

• platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::startWithJobManager):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::pausedStatusChanged):

• platform/network/curl/CurlRequestScheduler.cpp:

(WebCore::CurlRequestScheduler::CurlRequestScheduler):
(WebCore::CurlRequestScheduler::workerThread):
(WebCore::CurlRequestScheduler::singleton): Deleted.

• platform/network/curl/CurlRequestScheduler.h:

10:51 AM Changeset in webkit [229470] by commit-queue@webkit.org

• 2 edits in trunk/Tools

WebKitTestRunner: Do not build accessibility files/idl when !HAVE(ACCESSIBILITY)
​https://bugs.webkit.org/show_bug.cgi?id=183516

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2018-03-09
Reviewed by Alex Christensen.

• WebKitTestRunner/CMakeLists.txt:

10:48 AM Changeset in webkit [229469] by commit-queue@webkit.org

• 8 edits
  1 add in trunk

[webkitpy, WinCairo] Launch Apache HTTPD for HTTP Tests.
​https://bugs.webkit.org/show_bug.cgi?id=183265

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-03-09
Reviewed by Daniel Bates.

Launch apache httpd server from python script for WinCairo HTTP LayoutTests. By now, AppleWin uses
Cygwin to launch httpd server. This patch enables native Windows to run HTTP LayoutTests by starting
and stopping httpd server from the script.

Tools:

• Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):
(LayoutTestApacheHttpd._copy_apache_config_file):
(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.platform):
(LayoutTestApacheHttpd._spawn_process):
(LayoutTestApacheHttpd._stop_running_server):
(LayoutTestApacheHttpd._run):
(LayoutTestApacheHttpd._server_error):

• Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.aliases):
(HttpServerBase):
(HttpServerBase._build_alias_path_pairs):
(HttpServerBase._build_alias_path_pairs._make_path):

• Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:

(TestHttpServerBase.test_corrupt_pid_file):
(TestHttpServerBase):
(TestHttpServerBase.test_build_alias_path_pairs):

• Scripts/webkitpy/port/base.py:

(Port._apache_config_file_name_for_platform):

• Scripts/webkitpy/port/port_testcase.py:

(test_apache_config_file_name_for_platform):

• Scripts/webkitpy/port/win.py:

(WinPort._path_to_apache):
(WinCairoPort.default_baseline_search_path):
(WinCairoPort):
(WinCairoPort.check_httpd):

LayoutTests:

• http/conf/win-httpd-2.4-php7.conf: Added.

For WinCairo from native Windows environment.

10:45 AM Changeset in webkit [229468] by Chris Dumez

• 3 edits
  1 copy
  1 add in trunk/LayoutTests

http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates
​https://bugs.webkit.org/show_bug.cgi?id=183460

Reviewed by Alex Christensen.

The test has 3 frames which all initially load "about:blank". Then using document.write(), it inserts
HTML in each frame.
Frame 1: body has an onload event handler, which calls JS is click an anchor link to navigate the frame.
Frame 2: body has an onload event handler to do some logging
Frame 3: body has an onload event handler and finishes the test (calls testRunner.notifyDone())

The issue is that with asynchronous policy delegates, the first frame may not have navigated yet by the
time the third frame is loaded. Indeed, the onload event of the first frame merely clicks am anchor link
which will trigger a navigation policy check and then later navigate.

To make the test more robust, we now count the number of loads and call testRunner.notifyDone() when
we've reached the expected number of loads.

• http/tests/security/frame-loading-via-document-write-async-delegates-expected.txt: Added.
• http/tests/security/frame-loading-via-document-write-async-delegates.html: Copied from LayoutTests/http/tests/security/frame-loading-via-document-write.html.
• http/tests/security/frame-loading-via-document-write.html:
• http/tests/security/resources/frame-loading-via-document-write.js:

10:40 AM Changeset in webkit [229467] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Add guard for wtf/glib include
​https://bugs.webkit.org/show_bug.cgi?id=183521

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2018-03-09
Reviewed by Alex Christensen.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

10:21 AM Changeset in webkit [229466] by jer.noble@apple.com

• 8 edits in trunk

webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness
​https://bugs.webkit.org/show_bug.cgi?id=183383

Source/WebCore:

Reviewed by Eric Carlson.

Fire the webkitfullscreenchange event at the same time as the pseudo class selector changes, during the handling
of webkitDidEnterFullScreenForElement. For WebKit2 clients, this is guaranteed to be asynchronous, since the
calling method originates in the UIProcess. For WebKit1 clients (and WKTR and DRT), there's the possibility that
webkitWillEnterFullScreenForElement will be called synchronously from within
Document::requestFullScreenForElement(), so break that synchronousness by starting the
ChromeClient::enterFullScreenForElement(...) process in a async task.

Previously, the firing of the fullscreenchange event was done through a zero-length timer. Use a
GenericTaskQueue instead.

A number of layout tests depend on the behavior that the element will be in fullscreen when the 'playing' event
fires. This was true for DRT (but not WKTR), since its fullscreen implementations were deliberately synchronous, but
won't necessarily be true for all ports. Fix this in a subsequent patch.

• dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::dispatchFullScreenChangeEvents):

• dom/Document.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::setPlaying):

LayoutTests:

Fix a couple tests that depended on non-standard behavior, and skip other tests to be fixed later.

Reviewed by Eric Carlson.

• media/fullscreen-video-going-into-pip.html:
• media/video-fullscreeen-only-playback.html:
• platform/mac/TestExpectations:

10:02 AM Changeset in webkit [229465] by Yusuke Suzuki

• 5 edits in trunk/Source/JavaScriptCore

Unreviewed, remove WebAssemblyFunctionType
​https://bugs.webkit.org/show_bug.cgi?id=183429

Drop WebAssemblyFunctionType since it is no longer used. This breaks
JSCast assumption that all the derived classes of JSFunction use
JSFunctionType. We also add ASSERT for JSFunction::finishCreation.

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):

• runtime/JSType.h:
• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::createStructure):

• wasm/js/WebAssemblyFunction.h:

9:59 AM Changeset in webkit [229464] by Ryan Haddad

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r229446.

This change relies on changes that have been rolled out.

Reverted changeset:

"testmasm crashes in testBranchTruncateDoubleToInt32() on
ARM64"
​https://bugs.webkit.org/show_bug.cgi?id=183488
​https://trac.webkit.org/changeset/229446

9:57 AM Changeset in webkit [229463] by fred.wang@free.fr

• 2 edits
  1 delete in trunk/LayoutTests

Unreviewed GTK+ gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-03-09

• platform/gtk/TestExpectations: Skip test requiring DASHBOARD_SUPPORT.
• platform/gtk/mathml/mathml-in-dashboard-expected.txt: Removed.

7:11 AM Changeset in webkit [229462] by aestes@apple.com

• 7 edits in trunk

[Mac] WebKit fails to receive file promises when the embedding app is sandboxed
​https://bugs.webkit.org/show_bug.cgi?id=183489
<rdar://problem/38267517>

Source/WebKit:

WebKit calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
to issue a sandbox extension for this directory, but for security reasons App Sandbox
refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
block with a nil error and a valid file URL, but no file will actually exist at that URL.

In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
drop destination.

Reviewed by Wenson Hsieh.

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::performDragOperation):

Source/WebKitLegacy/mac:

WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
to issue a sandbox extension for this directory, but for security reasons App Sandbox
refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
block with a nil error and a valid file URL, but no file will actually exist at that URL.

In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
drop destination.

Reviewed by Wenson Hsieh.

• WebView/WebView.mm:

(-[WebView performDragOperation:]):

LayoutTests:

Reviewed by Wenson Hsieh.

Now that we create a unique temporary directory per drop, this test no longer encounters a
name conflict for apple.gif.

• editing/pasteboard/file-input-files-access-promise-expected.txt:
• editing/pasteboard/file-input-files-access-promise.html:

6:41 AM Changeset in webkit [229461] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form
​https://bugs.webkit.org/show_bug.cgi?id=183510

Reviewed by Michael Catanzaro.

Source/WebKit:

In 2.22 WebKitDOMHTMLFormElement will be deprecated in GTK+ port and won't still exist in WPE. The new
JavaScript GLib API will be used to replace most of the DOM API, but a few classes will remain with a minimal
API for things that can't be done with JavaScript. WebKitDOMElement will stay and will be added to WPE as well,
so if we change the signal parameter to WebKitDOMElement we will be able to keep using
WebKitWebPage::will-submit-form without any changes. WPE will gain this signal and the rest of the API that uses
DOM.

• WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(webkit_web_page_class_init):

Tools:

Update the test to use WebKitDOMElement instead and fix a memory leak.

• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(handleFormSubmissionCallback):
(willSubmitFormCallback):

6:03 AM Changeset in webkit [229460] by zandobersek@gmail.com

• 6 edits
  4 adds in trunk/Source/WebCore

[Nicosia] Add threaded PaintingEngine implementation
​https://bugs.webkit.org/show_bug.cgi?id=183511

Reviewed by Carlos Garcia Campos.

Add Nicosia::PaintingEngineThreaded, class that internally uses a thread
pool in which painting tasks are executed.

Implementation for now defaults to using GLib's GThreadPool, defaulting
to 4 threads that are exclusive to this pool. These parameters should be
fine-tuned in the future, or even made configurable, but are a solid
basis for testing.

In PaintingEngineThreaded::paint(), PaintingContext implementation is
used to record all the operations, and the gathered Vector is combined
with the Buffer object and dispatched into the thread pool. In the
thread function, the provided buffer and painting operations are run
through the PaintingContext implementation, replaying all the operations
on a painting context that draws into the given buffer.

The recorded operation objects implement the PaintingOperation interface
contain all the data necessary to replay a given operation. They can be
executed against a PaintingOperationReplay object, as is the case during
PaintingContext::replay(), or they can be dumped into a TextStream
object for debugging purposes.

PaintingContext now also provides the record() and replay() static
functions. PaintingContext objects now differ per purpose, which can be
either for painting or for recording. paint() and replay() use a
for-painting PaintingContext, and record() uses a for-recording one.
The for-painting PaintingContext receives a Buffer object, i.e. a memory
area on which it can draw, while the for-recording PaintingContext uses
the passed-in PaintingOperations Vector that should store all the
recorded operations.

The current Cairo implementation of PaintingContext is moved into
PaintingContextCairo::ForPainting. PaintingContextCairo::ForRecording is
added but is currently no-op until a Cairo-specific GraphicsContextImpl
with recording capabilities is added, allowing any call on the
GraphicsContext object used in PaintingContext::record() to be recorded
for later replay. PaintingOperationReplayCairo, inheriting from
PaintingOperationReplay, will be used for replay purposes, providing
only reference to the PlatformContextCairo object that is constructed in
PaintingContextCairo::ForPainting.

The Cairo-specific GraphicsContextImpl implementation will be added in
a separate patch. After that, PaintingEngine::create() will be modified
so that the Nicosia::PaintingEngineThreaded implementation can be used
for testing purposes, probably by setting an environment variable.

• platform/TextureMapper.cmake:
• platform/graphics/nicosia/NicosiaPaintingContext.cpp:

(Nicosia::PaintingContext::createForPainting):
(Nicosia::PaintingContext::createForRecording):
(Nicosia::PaintingContext::create): Deleted.

• platform/graphics/nicosia/NicosiaPaintingContext.h:

(Nicosia::PaintingContext::paint):
(Nicosia::PaintingContext::record):
(Nicosia::PaintingContext::replay):

• platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp: Added.

(Nicosia::s_threadFunc):
(Nicosia::paintLayer):
(Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
(Nicosia::PaintingEngineThreaded::~PaintingEngineThreaded):
(Nicosia::PaintingEngineThreaded::paint):

• platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.cpp.
• platform/graphics/nicosia/NicosiaPaintingOperation.h: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.cpp.
• platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp:

(Nicosia::PaintingContextCairo::ForPainting::ForPainting):
(Nicosia::PaintingContextCairo::ForPainting::~ForPainting):
(Nicosia::PaintingContextCairo::ForPainting::graphicsContext):
(Nicosia::PaintingContextCairo::ForPainting::replay):
(Nicosia::PaintingContextCairo::ForRecording::ForRecording):
(Nicosia::PaintingContextCairo::ForRecording::graphicsContext):
(Nicosia::PaintingContextCairo::ForRecording::replay):
(Nicosia::PaintingContextCairo::PaintingContextCairo): Deleted.
(Nicosia::PaintingContextCairo::~PaintingContextCairo): Deleted.
(Nicosia::PaintingContextCairo::graphicsContext): Deleted.

• platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.h:
• platform/graphics/nicosia/cairo/NicosiaPaintingOperationReplayCairo.h: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContext.cpp.

(Nicosia::PaintingOperationReplayCairo::PaintingOperationReplayCairo):

5:43 AM Changeset in webkit [229459] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Remove some unused cruft in TextureMapperLayer.

The ScrollingClient class is not used anymore since r229318.
findScrollableContentsLayerAt() is similarly unused, but also lacking
an actual definition. ContentsLayerCount enum can also be purged.

Rubber-stamped by Carlos Garcia Campos.

• platform/graphics/texmap/TextureMapperLayer.h:

2:58 AM Changeset in webkit [229458] by Carlos Garcia Campos

• 13 edits in releases/WebKitGTK/webkit-2.20

Revert "[GTK][WPE] Add API to configure and enable resource load statistics"

This reverts commit 6fe1852f8509b29ef0869f9030179ef099cac864.

2:37 AM Changeset in webkit [229457] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit

Unreviewed. [GTK][WPE] Bump Since tags of resource load stats API.

The functionality hasn't been properly tested to be released in WebKitGTK+ 2.20.

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkit_website_data_manager_class_init):

• UIProcess/API/gtk/WebKitWebsiteData.h:
• UIProcess/API/wpe/WebKitWebsiteData.h:

2:18 AM Changeset in webkit [229456] by Carlos Garcia Campos

• 2 edits in trunk

Unreviewed. Bump WebKitGTK+ version to 2.21.0.

• Source/cmake/OptionsGTK.cmake:

1:13 AM Changeset in webkit [229455] by zandobersek@gmail.com

• 3 edits in trunk/LayoutTests

Unreviewed GTK+ gardening.

• platform/gtk/TestExpectations: Add a failure expectation for the

http/tests/preconnect/link-header-rel-preconnect-http.html test.

• platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update baseline after r229310.