Timeline
Apr 15, 2018:
- 11:58 PM Changeset in webkit [230666] by
-
- 7 edits in trunk/Websites/perf.webkit.org
Make it possible to hide some repository groups
https://bugs.webkit.org/show_bug.cgi?id=184632
Reviewed by Saam Barati.
Added the ability to hide repository groups in the custom analysis task configurator from the admin page.
Hidden repositroy groups will continue to function for existing test groups. This is purely an UI change.
- init-database.sql: Added repositorygroup_hidden as a new column to triggerable_repository_groups.
- public/admin/triggerables.php: Added a form field to hide a repository group.
- public/include/manifest-generator.php: Include hidden state in the manifest file.
- public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Filter out hidden repository groups.
- public/v3/models/triggerable.js:
(prototype.isHidden): Added.
- server-tests/api-manifest-tests.js: Updated an existing test case to test a hidden repository group.
- 10:38 PM Changeset in webkit [230665] by
-
- 4 edits in trunk
[Web Animations] Animations do not naturally get a finish event
https://bugs.webkit.org/show_bug.cgi?id=184639
<rdar://problem/39397649>
Reviewed by Jon Lee.
LayoutTests/imported/w3c:
Record two progressions in the Web Animations WPT tests.
- web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
Source/WebCore:
We must call updateFinishedState() when an animation gets sampled as it means its timeline's time has progressed
and it may have crossed to a finished state. Calling updateFinishedState() when sampling means that we'll correctly
set the animation's hold time to its end value, which means that currentTime() will now always be clamped to return
the end time once its has reached it, so we must not schedule animations to resolve immediately anymore since otherwise
they will keep being scheduled in a loop.
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::timeToNextRequiredTick const):
(WebCore::WebAnimation::resolve):
- 6:01 PM Changeset in webkit [230664] by
-
- 21 edits2 adds in trunk
Change Event's returnValue so it doesn't expose a new primitive
https://bugs.webkit.org/show_bug.cgi?id=184415
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Import test coverage from https://github.com/w3c/web-platform-tests/pull/10258.
- web-platform-tests/dom/events/AddEventListenerOptions-passive-expected.txt:
- web-platform-tests/dom/events/AddEventListenerOptions-passive.html:
- web-platform-tests/dom/events/Event-constructors.html:
- web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt:
- web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html:
- web-platform-tests/dom/events/Event-defaultPrevented-expected.txt:
- web-platform-tests/dom/events/Event-defaultPrevented.html:
- web-platform-tests/dom/events/Event-dispatch-click.html:
- web-platform-tests/dom/events/Event-dispatch-detached-click.html:
- web-platform-tests/dom/events/Event-dispatch-other-document.html:
- web-platform-tests/dom/events/Event-initEvent.html:
- web-platform-tests/dom/events/Event-returnValue-expected.txt: Added.
- web-platform-tests/dom/events/Event-returnValue.html: Added.
- web-platform-tests/dom/events/EventListener-handleEvent.html:
- web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue-expected.txt:
- web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue.html:
- web-platform-tests/dom/events/w3c-import.log:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/interfaces/dom.idl:
Source/WebCore:
Update Event.returnValue setter to match the latest DOM specification after:
In particular, the returnValue setter is now a no-op if the new flag value
is true. If the input flag value is false, it only sets the 'canceled' flag
if the event is cancelable and the event’s in passive listener flag is unset.
Test: imported/w3c/web-platform-tests/dom/events/Event-returnValue.html
- dom/Event.cpp:
(WebCore::Event::setLegacyReturnValue):
(WebCore::Event::setCanceledFlagIfPossible):
(WebCore::Event::preventDefault):
- dom/Event.h:
- 2:21 PM Changeset in webkit [230663] by
-
- 3 edits1 add in trunk/Tools
[iOS] Add API tests for PDF find-in-page
https://bugs.webkit.org/show_bug.cgi?id=184634
Reviewed by Dan Bernstein.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/find.pdf: Added.
- TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
(-[TestFindDelegate findString]):
(-[TestFindDelegate _webView:didCountMatches:forString:]):
(-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
(-[TestFindDelegate _webView:didFailToFindString:]):
(loadWebView):
(TEST):
- 10:38 AM Changeset in webkit [230662] by
-
- 7 edits5 adds in trunk
Function.prototype.caller shouldn't return generator bodies
https://bugs.webkit.org/show_bug.cgi?id=184630
Reviewed by Yusuke Suzuki.
JSTests:
- stress/function-caller-async-arrow-function-body.js: Added.
- stress/function-caller-async-function-body.js: Added.
- stress/function-caller-async-generator-body.js: Added.
- stress/function-caller-generator-body.js: Added.
- stress/function-caller-generator-method-body.js: Added.
Source/JavaScriptCore:
Function.prototype.caller no longer returns generator bodies. Those are meant to be
private.
Also added some builtin debugging tools so that it's easier to do the investigation that I
did.
- builtins/BuiltinNames.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::callerGetter):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncBuiltinDescribe):
- runtime/JSGlobalObjectFunctions.h:
- 9:32 AM Changeset in webkit [230661] by
-
- 4 edits1 add in trunk
[WPE] Install files needed for WebKitWebExtensions
https://bugs.webkit.org/show_bug.cgi?id=179915
Reviewed by Žan Doberšek.
.:
- Source/cmake/OptionsWPE.cmake:
Source/WebKit:
- PlatformWPE.cmake: Install pkg-config file, injected bundle, and API headers.
- UIProcess/API/glib/WebKitWebContext.cpp: Load the injected bundle when installed.
- wpe/wpe-web-extension.pc.in: Added.
Apr 14, 2018:
- 6:42 PM Changeset in webkit [230660] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r230659.
https://bugs.webkit.org/show_bug.cgi?id=184633
Landed prematurely (Requested by ap on #webkit).
Reverted changeset:
"Deactivate the WindowServer connection for the WebContent
process."
https://bugs.webkit.org/show_bug.cgi?id=184451
https://trac.webkit.org/changeset/230659
- 10:57 AM Changeset in webkit [230659] by
-
- 2 edits in trunk/Source/WTF
Deactivate the WindowServer connection for the WebContent process.
https://bugs.webkit.org/show_bug.cgi?id=184451
<rdar://problem/38313938>
Reviewed by Brent Fulgham.
Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection
for the WebContent process by enabling the call to 'CGSSetDenyWindowServerConnections(true)' on
process startup. After calling this function, every attempt to establish a connection to the
WindowServer from the WebContent process will fail, except for CA render server connections.
- wtf/FeatureDefines.h:
- 2:11 AM Changeset in webkit [230658] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Expose a method to retrieve the GstStream from a TrackPrivateBaseGStreamer
https://bugs.webkit.org/show_bug.cgi?id=184620
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-04-14
Reviewed by Philippe Normand.
This is a minor change, a dedicated test doesn't really make sense here.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
(WebCore::TrackPrivateBaseGStreamer::stream):
- 12:00 AM Changeset in webkit [230657] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Build is broken after r230640
https://bugs.webkit.org/show_bug.cgi?id=184623
Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2018-04-14
Reviewed by Žan Doberšek.
UIProcess/SuspendedPageProxy.cpp was not included to CMake build in r230640.
- CMakeLists.txt: Added UIProcess/SuspendedPageProxy.cpp to WebKit_SOURCES.
