Timeline
May 5, 2018:
- 6:06 PM Changeset in webkit [231399] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA phase should only do clobber asserts in debug
https://bugs.webkit.org/show_bug.cgi?id=185354
Reviewed by Saam Barati.
Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
unless asserts are enabled.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- 4:45 PM Changeset in webkit [231398] by
-
- 6 edits in trunk/Source/WebCore
Cleanup XMLHttpRequestUpload a little
https://bugs.webkit.org/show_bug.cgi?id=185344
Patch by Sam Weinig <sam@webkit.org> on 2018-05-05
Reviewed by Yusuke Suzuki.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitAdditionalChildren):
Use auto to reduce redundancy.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::upload):
- xml/XMLHttpRequest.h:
Switch upload() to return a reference.
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h:
Cleanup formatting, modernize and switch XMLHttpRequest member from a pointer
to a reference.
- 3:42 PM Changeset in webkit [231397] by
-
- 2 edits in trunk/Source/WebCore
Draw a drop-shadow behind the system preview badge
https://bugs.webkit.org/show_bug.cgi?id=185356
<rdar://problem/40004936>
Reviewed by Wenson Hsieh.
Draw a very subtle drop-shadow under the system
preview badge so that it is more visible on a pure
white background.
I also moved some code around to make it more clear
and improved comments.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
May 4, 2018:
- 9:39 PM Changeset in webkit [231396] by
-
- 4 edits in trunk
[iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
https://bugs.webkit.org/show_bug.cgi?id=185289
<rdar://problem/35756912>
Reviewed by Tim Horton and Darin Adler.
Source/WebCore:
When inserting multiple URLs as individual items in a single drop, we currently separate each item with a space
(see r217284). However, it still seems difficult to tell dropped links apart. This patch makes some slight
tweaks to WebContentReader::readURL so that it inserts line breaks before dropped URLs, if the dropped URL isn't
the first item to be inserted in the resulting document fragment.
Augments existing API tests in DataInteractionTests.
- editing/ios/WebContentReaderIOS.mm:
Additionally remove some extraneous header imports from this implementation file.
(WebCore::WebContentReader::readURL):
Tools:
Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
sessions.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 7:11 PM Changeset in webkit [231395] by
-
- 2 edits in trunk/LayoutTests
webrtc/addICECandidate-closed.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=185336
Reviewed by Eric Carlson.
- webrtc/addICECandidate-closed.html:
- 5:26 PM Changeset in webkit [231394] by
-
- 3 edits in trunk/Source/WebCore
Use IOSurfaces for CoreImage operations where possible
https://bugs.webkit.org/show_bug.cgi?id=185230
<rdar://problem/39926929>
Reviewed by Jon Lee.
On iOS hardware, we can use IOSurfaces as a rendering destination
for CoreImage, which means we're keeping data on the GPU
for rendering.
As a drive-by fix, I used a convenience method for Gaussian blurs.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
- 5:16 PM Changeset in webkit [231393] by
-
- 11 edits1 move in trunk/Source
Shift to a lower-level framework for simplifying URLs
https://bugs.webkit.org/show_bug.cgi?id=185334
Reviewed by Dan Bernstein.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- platform/mac/DragImageMac.mm:
(WebCore::LinkImageLayout::LinkImageLayout):
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/PlatformMac.cmake:
- pal/spi/cocoa/URLFormattingSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h.
Source/WebKit:
- Configurations/WebKit.xcconfig:
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _updateLocationInfo]):
Source/WTF:
- wtf/Platform.h:
- 4:58 PM Changeset in webkit [231392] by
-
- 4 edits in trunk/Source/WebCore
Release assert in ScriptController::canExecuteScripts via HTMLMediaElement::~HTMLMediaElement()
https://bugs.webkit.org/show_bug.cgi?id=185288
Reviewed by Jer Noble.
The crash is caused by HTMLMediaElement::~HTMLMediaElement canceling the resource load via CachedResource
which ends up calling FrameLoader::checkCompleted() and fire load event on the document synchronously.
Speculatively fix the crash by scheduling the check instead.
In long term, ResourceLoader::cancel should never fire load event synchronously: webkit.org/b/185284.
Unfortunately, no new tests since I can't get MediaResource to get destructed at the right time.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isRunningDestructor): Added to detect this specific case.
(WebCore::HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElementDestructorScope::HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElementDestructorScope::~HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Instantiate HTMLMediaElement.
- html/HTMLMediaElement.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Call scheduleCheckCompleted instead of synchronously calling
checkCompleted if we're in the middle of destructing a HTMLMediaElement.
- 4:56 PM Changeset in webkit [231391] by
-
- 43 edits in trunk
Web Inspector: simplify the WI.Collection interface
https://bugs.webkit.org/show_bug.cgi?id=185187
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/Collection.js:
(WI.Collection.prototype.get size): Added.
(WI.Collection.prototype.has): Added.
(WI.Collection.prototype.toJSON):
(WI.Collection.prototype.[Symbol.iterator]): Added.
(WI.Collection.prototype.get items): Deleted.
(WI.Collection.prototype.toArray): Deleted.
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype._removeCanvas):
- UserInterface/Controllers/DOMDebuggerManager.js:
(WebInspector.DOMDebuggerManager.prototype.get domBreakpoints):
- UserInterface/Models/Frame.js:
(WI.Frame.prototype.removeAllChildFrames):
(WI.Frame.prototype.resourceForURL):
(WI.Frame.prototype.removeAllResources):
- UserInterface/Models/Script.js:
(WI.Script):
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._updateNavigationItems):
- UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._recordingRemoved):
(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._addCanvas):
(WI.CanvasTabContentView.prototype._removeCanvas):
- UserInterface/Views/CanvasTreeElement.js:
(WI.CanvasTreeElement.prototype.onpopulate):
- UserInterface/Views/CollectionContentView.js:
(WI.CollectionContentView.prototype.initialLayout):
(WI.CollectionContentView.prototype.attached):
- UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype._filterCookies):
- UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._addResourcesRecursivelyForFrame):
- UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement.prototype.updateParentStatus):
(WI.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
- UserInterface/Views/FrameTreeElement.js:
(WI.FrameTreeElement.prototype.onpopulate):
- UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype.get contentTreeOutlines):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWithInitialResourcesIfNeeded):
- UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._addResourcesForFrame):
(WI.OpenResourceDialog.prototype._addResourcesForTarget):
- UserInterface/Views/TreeOutlineGroup.js:
(WI.TreeOutlineGroup.prototype.get selectedTreeElement):
(WI.TreeOutlineGroup.prototype._removeConflictingTreeSelections):
- UserInterface/Views/WorkerTreeElement.js:
(WI.WorkerTreeElement.prototype.onpopulate):
LayoutTests:
- http/tests/inspector/dom/cross-domain-inspected-node-access.html:
- http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html:
- http/tests/inspector/network/har/har-page.html:
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html:
- http/tests/inspector/network/resource-response-source-memory-cache.html:
- http/tests/inspector/network/resource-sizes-memory-cache.html:
- http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html:
- http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html:
- http/tests/websocket/tests/hybi/inspector/before-load.html:
- inspector/canvas/resources/recording-utilities.js:
- inspector/css/manager-preferredInspectorStyleSheetForFrame.html:
- inspector/debugger/resources/log-pause-location.js:
(TestPage.registerInitializer.window.findScript):
- inspector/dom/highlightFrame.html:
- inspector/dom/highlightNode.html:
- inspector/dom/highlightNodeList.html:
- inspector/dom/highlightSelector.html:
- inspector/model/frame-extra-scripts.html:
- inspector/page/empty-or-missing-resources.html:
- inspector/unit-tests/resource-collection.html:
- inspector/worker/resources-in-worker.html:
- 4:52 PM Changeset in webkit [231390] by
-
- 7 edits2 moves in trunk/Source/WebCore
Rename DocumentOrderedMap to TreeScopeOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=185290
Reviewed by Zalan Bujtas.
Renamed the class since it's almost always a mistake to use this class as a member variable of Document.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/MouseRelatedEvent.cpp: Include the forgotten DOMWindow.h. Unified build files bit us here.
- dom/TreeScope.cpp:
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::addImageElementByUsemap):
(WebCore::TreeScope::labelElementForId):
- dom/TreeScope.h:
- dom/TreeScopeOrderedMap.cpp: Renamed from DocumentOrderedMap.cpp
- dom/TreeScopeOrderedMap.h: Renamed from DocumentOrderedMap.h
- html/HTMLDocument.h:
- 4:42 PM Changeset in webkit [231389] by
-
- 2 edits in trunk/Source/WebKit
Shutdown WindowServer connections after checking in with launch services
https://bugs.webkit.org/show_bug.cgi?id=185082
<rdar://problem/39613173>
Reviewed by Brent Fulgham.
When WindowServer access is blocked in the WebContent process, we should shutdown all connections
after checking in with launch services.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
- 4:41 PM Changeset in webkit [231388] by
-
- 4 edits1 delete in trunk/LayoutTests
REGRESSION (r230326?): Layout Test http/tests/contentextensions/make-https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=184476
<rdar://problem/39384226>
Reviewed by Ryosuke Niwa.
Removed flakiness expectation.
Updated test to no longer log load callbacks.
Instead, we rely on the fact that the four content extension upgrades
are also logged as console log messages.
- http/tests/contentextensions/make-https-expected.txt:
- http/tests/contentextensions/make-https.html:
- platform/mac-sierra-wk2/http/tests/contentextensions/make-https-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- 4:29 PM Changeset in webkit [231387] by
-
- 8 edits in trunk/Source
[Win][WebKit] Fix forwarding headers for Windows build
https://bugs.webkit.org/show_bug.cgi?id=184412
Reviewed by Alex Christensen.
Source/WebCore:
No new tests. No change in behavior.
- PlatformWin.cmake:
Source/WebKit:
- PlatformWin.cmake:
- UIProcess/API/APIAttachment.h:
- UIProcess/API/APIContextMenuClient.h:
- UIProcess/API/C/WKProcessTerminationReason.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- 4:07 PM Changeset in webkit [231386] by
-
- 2 edits in trunk/LayoutTests
Mark animations/duplicate-keys.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=185332
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 3:34 PM Changeset in webkit [231385] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests for iOS after r231359.
Unreviewed test gardening.
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- 3:23 PM Changeset in webkit [231384] by
-
- 4 edits in trunk/Source/WebCore
[Simple line layout] Add support for line layout box generation with multiple text renderers.
https://bugs.webkit.org/show_bug.cgi?id=185276
Reviewed by Antti Koivisto.
Covered by existing tests.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::canUseForLineBoxTree):
(WebCore::SimpleLineLayout::generateLineBoxTree):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::renderer const):
(WebCore::SimpleLineLayout::RunResolver::Run::localStart const):
(WebCore::SimpleLineLayout::RunResolver::Run::localEnd const):
- rendering/SimpleLineLayoutResolver.h:
- 2:43 PM Changeset in webkit [231383] by
-
- 155 edits in trunk
Deprecate legacy WebView and friends
https://bugs.webkit.org/show_bug.cgi?id=185279
rdar://problem/33268700
Reviewed by Tim Horton.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Added BUILDING_WEBKIT define to disable the deprecation macros.
- bridge/objc/WebScriptObject.h:
Added deprecation macros to WebScriptObject and WebUndefined.
- platform/cocoa/WebKitAvailability.h:
Added more macros and a way to disable deprecation warnings for
WebKit build and in clients like Safari.
Source/WebKitLegacy/mac:
Added deprecation macros to all the classes, extern strings, and enums.
- Configurations/WebKitLegacy.xcconfig:
Added BUILDING_WEBKIT define to disable the deprecation macros.
- DOM/DOMAbstractView.h:
- DOM/DOMAttr.h:
- DOM/DOMBlob.h:
- DOM/DOMCDATASection.h:
- DOM/DOMCSSCharsetRule.h:
- DOM/DOMCSSFontFaceRule.h:
- DOM/DOMCSSImportRule.h:
- DOM/DOMCSSMediaRule.h:
- DOM/DOMCSSPageRule.h:
- DOM/DOMCSSPrimitiveValue.h:
- DOM/DOMCSSRule.h:
- DOM/DOMCSSRuleList.h:
- DOM/DOMCSSStyleDeclaration.h:
- DOM/DOMCSSStyleRule.h:
- DOM/DOMCSSStyleSheet.h:
- DOM/DOMCSSUnknownRule.h:
- DOM/DOMCSSValue.h:
- DOM/DOMCSSValueList.h:
- DOM/DOMCharacterData.h:
- DOM/DOMComment.h:
- DOM/DOMCounter.h:
- DOM/DOMDocument.h:
- DOM/DOMDocumentFragment.h:
- DOM/DOMDocumentType.h:
- DOM/DOMElement.h:
- DOM/DOMEntity.h:
- DOM/DOMEntityReference.h:
- DOM/DOMEvent.h:
- DOM/DOMEventException.h:
- DOM/DOMEventListener.h:
- DOM/DOMEventTarget.h:
- DOM/DOMException.h:
- DOM/DOMFile.h:
- DOM/DOMFileList.h:
- DOM/DOMHTMLAnchorElement.h:
- DOM/DOMHTMLAppletElement.h:
- DOM/DOMHTMLAreaElement.h:
- DOM/DOMHTMLBRElement.h:
- DOM/DOMHTMLBaseElement.h:
- DOM/DOMHTMLBaseFontElement.h:
- DOM/DOMHTMLBodyElement.h:
- DOM/DOMHTMLButtonElement.h:
- DOM/DOMHTMLCanvasElement.h:
- DOM/DOMHTMLCollection.h:
- DOM/DOMHTMLDListElement.h:
- DOM/DOMHTMLDirectoryElement.h:
- DOM/DOMHTMLDivElement.h:
- DOM/DOMHTMLDocument.h:
- DOM/DOMHTMLElement.h:
- DOM/DOMHTMLEmbedElement.h:
- DOM/DOMHTMLFieldSetElement.h:
- DOM/DOMHTMLFontElement.h:
- DOM/DOMHTMLFormElement.h:
- DOM/DOMHTMLFrameElement.h:
- DOM/DOMHTMLFrameSetElement.h:
- DOM/DOMHTMLHRElement.h:
- DOM/DOMHTMLHeadElement.h:
- DOM/DOMHTMLHeadingElement.h:
- DOM/DOMHTMLHtmlElement.h:
- DOM/DOMHTMLIFrameElement.h:
- DOM/DOMHTMLImageElement.h:
- DOM/DOMHTMLInputElement.h:
- DOM/DOMHTMLLIElement.h:
- DOM/DOMHTMLLabelElement.h:
- DOM/DOMHTMLLegendElement.h:
- DOM/DOMHTMLLinkElement.h:
- DOM/DOMHTMLMapElement.h:
- DOM/DOMHTMLMarqueeElement.h:
- DOM/DOMHTMLMediaElement.h:
- DOM/DOMHTMLMenuElement.h:
- DOM/DOMHTMLMetaElement.h:
- DOM/DOMHTMLModElement.h:
- DOM/DOMHTMLOListElement.h:
- DOM/DOMHTMLObjectElement.h:
- DOM/DOMHTMLOptGroupElement.h:
- DOM/DOMHTMLOptionElement.h:
- DOM/DOMHTMLOptionsCollection.h:
- DOM/DOMHTMLParagraphElement.h:
- DOM/DOMHTMLParamElement.h:
- DOM/DOMHTMLPreElement.h:
- DOM/DOMHTMLQuoteElement.h:
- DOM/DOMHTMLScriptElement.h:
- DOM/DOMHTMLSelectElement.h:
- DOM/DOMHTMLStyleElement.h:
- DOM/DOMHTMLTableCaptionElement.h:
- DOM/DOMHTMLTableCellElement.h:
- DOM/DOMHTMLTableColElement.h:
- DOM/DOMHTMLTableElement.h:
- DOM/DOMHTMLTableRowElement.h:
- DOM/DOMHTMLTableSectionElement.h:
- DOM/DOMHTMLTextAreaElement.h:
- DOM/DOMHTMLTitleElement.h:
- DOM/DOMHTMLUListElement.h:
- DOM/DOMHTMLVideoElement.h:
- DOM/DOMImplementation.h:
- DOM/DOMKeyboardEvent.h:
- DOM/DOMMediaError.h:
- DOM/DOMMediaList.h:
- DOM/DOMMouseEvent.h:
- DOM/DOMMutationEvent.h:
- DOM/DOMNamedNodeMap.h:
- DOM/DOMNode.h:
- DOM/DOMNodeFilter.h:
- DOM/DOMNodeIterator.h:
- DOM/DOMNodeList.h:
- DOM/DOMObject.h:
- DOM/DOMOverflowEvent.h:
- DOM/DOMProcessingInstruction.h:
- DOM/DOMProgressEvent.h:
- DOM/DOMRGBColor.h:
- DOM/DOMRange.h:
- DOM/DOMRangeException.h:
- DOM/DOMRect.h:
- DOM/DOMStyleSheet.h:
- DOM/DOMStyleSheetList.h:
- DOM/DOMText.h:
- DOM/DOMTextEvent.h:
- DOM/DOMTimeRanges.h:
- DOM/DOMTokenList.h:
- DOM/DOMTreeWalker.h:
- DOM/DOMUIEvent.h:
- DOM/DOMWheelEvent.h:
- DOM/DOMXPathException.h:
- DOM/DOMXPathExpression.h:
- DOM/DOMXPathNSResolver.h:
- DOM/DOMXPathResult.h:
- History/WebBackForwardList.h:
- History/WebHistory.h:
- History/WebHistoryItem.h:
- Misc/WebDownload.h:
- Misc/WebKitErrors.h:
- Plugins/WebPluginViewFactory.h:
- WebView/WebArchive.h:
- WebView/WebDataSource.h:
- WebView/WebDocument.h:
- WebView/WebEditingDelegate.h:
- WebView/WebFormDelegate.h:
- WebView/WebFrame.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebFrameView.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferencesPrivate.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebUIDelegate.h:
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.h:
- WebView/WebViewPrivate.h:
- postprocess-headers.sh:
Remove step that converts WEBKIT macros to NS macros.
Change it to just remove the macros on iOS builds.
Tools:
- MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
- 2:39 PM Changeset in webkit [231382] by
-
- 7 edits in trunk/Source
Log media time range as JSON
https://bugs.webkit.org/show_bug.cgi?id=185321
<rdar://problem/39986746>
Reviewed by Youenn Fablet.
Source/WebCore:
No new tests, tested manually.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addPlayedRange): Log as time range.
(WebCore::HTMLMediaElement::visibilityStateChanged): Cleanup.
- platform/graphics/MediaPlayer.h:
(WTF::LogArgument<MediaTime>::toString):
(WTF::LogArgument<MediaTimeRange>::toString):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Log error as time range.
Source/WTF:
- wtf/MediaTime.cpp:
(WTF::toJSONStringInternal): Extract guts of MediaTime::toJSONString to this static function
so it can be used by MediaTimeRange::toJSONString as well.
(WTF::MediaTime::toJSONString const):
(WTF::MediaTimeRange::toJSONString const):
- wtf/MediaTime.h:
- 2:26 PM Changeset in webkit [231381] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests after r231359.
Unreviewed test gardening.
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- 2:26 PM Changeset in webkit [231380] by
-
- 3 edits in trunk/LayoutTests
Update TestExpectations for media/video-aspect-ratio.html.
https://bugs.webkit.org/show_bug.cgi?id=184457
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 2:15 PM Changeset in webkit [231379] by
-
- 3 edits2 adds in trunk
Use the containing block to compute the pagination gap when the container is inline.
https://bugs.webkit.org/show_bug.cgi?id=184724
<rdar://problem/39521800>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/overflow/page-overflow-with-inline-body-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::applyPaginationToViewport):
LayoutTests:
- fast/overflow/page-overflow-with-inline-body-crash-expected.txt: Added.
- fast/overflow/page-overflow-with-inline-body-crash.html: Added.
- 1:54 PM Changeset in webkit [231378] by
-
- 2 edits in trunk/Source/WebCore
Don't use GSFont* in minimal simulator mode
https://bugs.webkit.org/show_bug.cgi?id=185320
<rdar://problem/39734478>
Reviewed by Beth Dakin.
- page/cocoa/MemoryReleaseCocoa.mm:
(WebCore::platformReleaseMemory):
- 1:51 PM Changeset in webkit [231377] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: Newly added unsupported properties sometimes don't have warnings
https://bugs.webkit.org/show_bug.cgi?id=183097
<rdar://problem/37843816>
Reviewed by Matt Baker.
Update status of properties warnings every time focus moves.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyFocusMoved):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._updatePropertiesStatus):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
- 1:48 PM Changeset in webkit [231376] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Apps that are not visible may not get suspended if they trigger page loads while in the background
https://bugs.webkit.org/show_bug.cgi?id=185318
Reviewed by Geoffrey Garen.
Whenever there is a page load going on, we take a background process assertion to delay process
suspension until this load completes. However, there is also a 3 seconds grace period after
a load is complete to allow the app to trigger a new load shortly after. This grace period was
introduced to support use cases where a visible app does loads in an offscreen view. However,
it can be abused by apps running in the background as they could trigger new page loads while
in the background to delay process suspension. This patch tightens the policy so that only
apps that are currently visible get to use this grace period. Apps that are in the background
get to finish their current load and will then get suspended.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading):
- 1:47 PM Changeset in webkit [231375] by
-
- 3 edits1 add in trunk
isCacheableArrayLength should return true for undecided arrays
https://bugs.webkit.org/show_bug.cgi?id=185309
Reviewed by Michael Saboff.
JSTests:
- stress/get-array-length-undecided.js: Added.
(test):
Source/JavaScriptCore:
Undecided arrays have butterflies so there is no reason why we
should not be able to cache their length.
- bytecode/InlineAccess.cpp:
(JSC::InlineAccess::isCacheableArrayLength):
- 1:44 PM Changeset in webkit [231374] by
-
- 2 edits in trunk/Source/WebKit
Adjust sandbox profile for simulator.
https://bugs.webkit.org/show_bug.cgi?id=185319
Reviewed by Brent Fulgham.
Disable Kerberos rules, as well as rules related to NSApplication initialization.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:40 PM Changeset in webkit [231373] by
-
- 1 edit2 adds in trunk/Tools
Test262-Runner: Add base module to the local deps - unicore/PVA.pl
https://bugs.webkit.org/show_bug.cgi?id=185314
Patch by Leo Balter <Leo Balter> on 2018-05-04
Reviewed by Michael Saboff.
- Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
- 1:29 PM Changeset in webkit [231372] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: ensure that tabbing through the last section wraps back to the first
https://bugs.webkit.org/show_bug.cgi?id=181973
Reviewed by Matt Baker.
Unified delegate functions to start editing previous/next rules into a single function for
simplicity.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetCSSStyleDeclarationEditorFocusMoved):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidChange):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorStartEditingAdjacentRule):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.cssStyleDeclarationEditorStartEditingAdjacentRule): Deleted.
- UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.focusFirstSection):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.focusLastSection):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.spreadsheetCSSStyleDeclarationSectionStartEditingAdjacentRule):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionStartEditingNextRule): Deleted.
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionStartEditingPreviousRule): Deleted.
- UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype.styleDetailsPanelFocusLastPseudoClassCheckbox):
(WI.GeneralStyleDetailsSidebarPanel.prototype.styleDetailsPanelFocusFilterBar):
(WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleForcedPseudoClassCheckboxKeydown):
(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleFilterBarInputFieldKeyDown):
Drive-by fix: provide tabbing support for the Computed styles panel.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WI.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey.switchRule):
(WI.CSSStyleDeclarationTextEditor.prototype._handleTabKey.switchRule):
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection):
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection):
(WI.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorStartEditingAdjacentRule):
- 12:42 PM Changeset in webkit [231371] by
-
- 3 edits in trunk/Source/WebKit
Wasted time dlopening Lookup when tearing down a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=185310
<rdar://problem/39934085>
Reviewed by Wenson Hsieh.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver startObservingLookupDismissalIfNeeded]):
(WebKit::WebViewImpl::prepareForDictionaryLookup):
(-[WKWindowVisibilityObserver startObservingLookupDismissal]): Deleted.
Avoid un-registering as a Lookup dismissal observer if we never
registered in the first place, because that involves dlopening Lookup.
- 12:16 PM Changeset in webkit [231370] by
-
- 2 edits in trunk/Source/WebKit
Allow Web Touch events to timeout
https://bugs.webkit.org/show_bug.cgi?id=185282
<rdar://problem/38728319>
Reviewed by Tim Horton.
Web Touch events currently never time out, which blocks the user from interacting with the UI Process at all.
We should allow these events to time out so that the user can interact with the rest of the UI.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEventSynchronously):
- 11:52 AM Changeset in webkit [231369] by
-
- 4 edits in trunk
REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=184196
<rdar://problem/39054481>
Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2018-05-04
Reviewed by Tim Horton.
Source/WebKit:
Remove an unnecessary call to NSClassFromString, now that trunk WebKit only supports iOS 11.3+.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertTextSuggestion:]):
Tools:
Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
earlier than 11.3. Also re-enables these tests.
- TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(TestWebKitAPI::TEST):
(-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
(+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
- 11:50 AM Changeset in webkit [231368] by
-
- 4 edits in trunk
Web Inspector: Canvas tab: Determine isFunction by looking at the prototype
https://bugs.webkit.org/show_bug.cgi?id=184990
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction._prototypeForType):
(WI.RecordingAction.prototype.async.swizzle):
LayoutTests:
- inspector/canvas/recording-2d-expected.txt:
- 11:44 AM Changeset in webkit [231367] by
-
- 24 edits2 deletes in trunk
Unreviewed, rolling out r231331.
Caused a few tests to assert
Reverted changeset:
"Stop using an iframe's id as fallback if its name attribute
is not set"
https://bugs.webkit.org/show_bug.cgi?id=11388
https://trac.webkit.org/changeset/231331
- 11:37 AM Changeset in webkit [231366] by
-
- 2 edits in trunk/Source/WebCore
Use more references in updateTracksOfType
https://bugs.webkit.org/show_bug.cgi?id=185305
Reviewed by Eric Carlson.
No change of behavior.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::updateTracksOfType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
- 11:35 AM Changeset in webkit [231365] by
-
- 7 edits in trunk/Source/WebKit
NetworkProcessProxy::didReceiveAuthenticationChallenge should take an AuthenticationChallenge r-value
https://bugs.webkit.org/show_bug.cgi?id=185302
Reviewed by Geoffrey Garen.
Pass AuthenticationChallenge as an r-value since it comes from IPC.
No change of behavior.
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
- UIProcess/Network/NetworkProcessProxy.h:
- 11:01 AM Changeset in webkit [231364] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/contentextensions/make-https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184476
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 11:01 AM Changeset in webkit [231363] by
-
- 2 edits in trunk/LayoutTests
Mark media/navigate-with-pip-should-not-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173119
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:46 AM Changeset in webkit [231362] by
-
- 2 edits in trunk/JSTests
Disable tests on systems with limited memory
https://bugs.webkit.org/show_bug.cgi?id=185296
Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-05-04
Reviewed by Saam Barati.
Test doesn't work with a limited amount of memory. I tried to reduce memory usage
but then it was hard to reproduce the failure the test was originally made to test.
- stress/array-reverse-doesnt-clobber.js:
- 10:38 AM Changeset in webkit [231361] by
-
- 6 edits6 adds in trunk
Text shaping in the simple path is flipped in the y direction
https://bugs.webkit.org/show_bug.cgi?id=185062
<rdar://problem/39778678>
Reviewed by Simon Fraser.
Source/WebCore:
Shaping in our simple codepath occurs in an "increasing-y-goes-up" coordinate system, but our painting
code uses an "increasing-y-goes-down" coordinate system. We weren't fixing up the coordinate systems
because we never noticed. This is because the simple codepath is only designed for kerning and ligatures,
neither of which move glyphs vertically in the common case.
Test: fast/text/vertical-displacement-simple-codepath.html
- platform/graphics/Font.cpp:
(WebCore::Font::applyTransforms const):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):
Tools:
Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
- Scripts/webkitpy/common/config/contributors.json:
LayoutTests:
This test renders a font which uses our fast text codepath but also includes vertical
displacements inside its liga feature. The test makes sure that the vertical displacement
occurs in the correct direction.
The test fonts were created by Ulrike Rausch of LiebeFonts specifically for the purpose
of testing. Huge thanks to her!! Figuring out this bug would not have been possible if
not for her huge help!
- fast/text/resources/LiebeTest-calt.woff: Added.
- fast/text/resources/LiebeTest-dlig.woff: Added.
- fast/text/resources/LiebeTest-liga.woff: Added.
- fast/text/resources/LiebeTest-swsh.woff: Added.
- fast/text/vertical-displacement-simple-codepath-expected.html: Added.
- fast/text/vertical-displacement-simple-codepath.html: Added.
- 10:36 AM Changeset in webkit [231360] by
-
- 2 edits in trunk/Tools
Test262-Runner: place the processCLI inside the main call
https://bugs.webkit.org/show_bug.cgi?id=185304
Patch by Leo Balter <Leo Balter> on 2018-05-04
Reviewed by Michael Saboff.
- Scripts/test262/Runner.pm:
(main):
- 10:32 AM Changeset in webkit [231359] by
-
- 80 edits1 delete in trunk
Serialize all URLs with double-quotes per CSSOM spec
https://bugs.webkit.org/show_bug.cgi?id=184935
Patch by Chris Nardi <cnardi@chromium.org> on 2018-05-04
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Update expectations for using double quotes when serializing URLs.
- web-platform-tests/cssom/serialize-values-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
Source/WebCore:
According to https://drafts.csswg.org/cssom/#serialize-a-url, all URLs should be serialized as strings,
which means they should have double quotes around the text of the URL. Update our implementation to match
this (and Firefox/Chrome). Also remove isCSSTokenizerURL() as this method is no longer needed.
Tests: Many LayoutTests updated to use double quotes.
- css/CSSMarkup.cpp:
(WebCore::serializeString): Remove FIXME as this was already fixed in a previous patch.
(WebCore::serializeURL): Remove FIXME and update implementation.
LayoutTests:
Update tests to use double quotes when serializing URLs, and fixes for using double quotes in the test.
- css3/calc/cross-fade-calc.html:
- css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt:
- css3/filters/backdrop/backdropfilter-property-computed-style.html:
- css3/filters/backdrop/backdropfilter-property-parsing-expected.txt:
- css3/filters/backdrop/backdropfilter-property-parsing.html:
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-computed-style.html:
- css3/filters/filter-property-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/filter-property-parsing.html:
- css3/filters/filter-property.html:
- css3/filters/unprefixed-expected.txt:
- css3/filters/unprefixed.html:
- fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt:
- fast/backgrounds/background-shorthand-after-set-backgroundSize.html:
- fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
- fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
- fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
- fast/backgrounds/multiple-backgrounds-computed-style.html:
- fast/css/background-position-serialize-expected.txt:
- fast/css/cursor-parsing-expected.txt:
- fast/css/cursor-parsing-image-set-expected.txt:
- fast/css/cursor-parsing-image-set.html:
- fast/css/cursor-parsing.html:
- fast/css/getComputedStyle/computed-style-border-image-expected.txt:
- fast/css/getComputedStyle/computed-style-border-image.html:
- fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
- fast/css/getComputedStyle/computed-style-cross-fade.html:
- fast/css/getComputedStyle/computed-style-properties-expected.txt:
- fast/css/getComputedStyle/computed-style-properties.html:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html:
- fast/css/image-set-parsing.html:
- fast/css/image-set-setting-expected.txt:
- fast/css/image-set-setting.html:
- fast/css/image-set-unprefixed-expected.txt:
- fast/css/image-set-unprefixed.html:
- fast/css/invalid-cursor-property-crash.html:
- fast/css/parse-border-image-repeat-null-crash-expected.txt:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/css/url-with-multi-byte-unicode-escape-expected.txt:
- fast/css/url-with-multi-byte-unicode-escape.html:
- fast/filter-image/parse-filter-image-expected.txt:
- fast/filter-image/parse-filter-image.html:
- fast/innerHTML/innerHTML-uri-resolution.html:
- fast/inspector-support/cssURLQuotes-expected.txt:
- fast/inspector-support/cssURLQuotes.html:
- fast/masking/parsing-clip-path-iri-expected.txt:
- fast/masking/parsing-clip-path-iri.html:
- fast/masking/parsing-mask-expected.txt:
- fast/masking/parsing-mask.html:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-shape-outside.html:
- fast/shapes/parsing/parsing-test-utils.js:
(removeBaseURL):
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/ios/fast/css/image-set-unprefixed-expected.txt: Removed.
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- resources/image-preload-helper.js:
(preloadImagesFromStyle):
- svg/css/svg-attribute-parser-mode-expected.txt:
- svg/css/svg-attribute-parser-mode.html:
- svg/custom/marker-getPropertyValue-expected.txt:
- svg/custom/marker-getPropertyValue.svg:
- 10:24 AM Changeset in webkit [231358] by
-
- 2 edits in trunk/Source/WebCore
LayoutTests/fast/mediastream/change-tracks-media-stream-being-played.html is crashing after r231304
https://bugs.webkit.org/show_bug.cgi?id=185303
Reviewed by Eric Carlson.
We need to stop observing the audio track like we do for video track once we are no longer interested in it.
Covered by test no longer crashing.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
- 10:21 AM Changeset in webkit [231357] by
-
- 2 edits in trunk/LayoutTests
Improve test at media/modern-media-controls/airplay-button/airplay-button-on.html to not hardcode the -apple-wireless-playback-target-active color
https://bugs.webkit.org/show_bug.cgi?id=185297
<rdar://problem/39737716>
Patch by Antoine Quint <Antoine Quint> on 2018-05-04
Reviewed by Dean Jackson.
Create an element and set its "color" property to "-apple-wireless-playback-target-active" so we can use
getComputedStyle() to query the applied value instead of hard-coding the expected color.
- media/modern-media-controls/airplay-button/airplay-button-on.html:
- 9:51 AM Changeset in webkit [231356] by
-
- 2 edits in trunk/Source/WebKit
Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
https://bugs.webkit.org/show_bug.cgi?id=185262
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-05-04
Reviewed by Chris Dumez.
Fix an assertion failure by setting UI process privileges in constructor of WebsiteDataStore
because UI process may use the cookie API before creating a WebView.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
- 9:30 AM Changeset in webkit [231355] by
-
- 8 edits1 copy in trunk/Source/WebCore
[LFC] Set the invalidation root as the result of style change.
https://bugs.webkit.org/show_bug.cgi?id=185301
Reviewed by Antti Koivisto.
Compute/propagate the update type on the ancestor chain and return the invalidation root
so that LayoutContext could use it as the entry point for the next layout frame.
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::updateLayout):
(WebCore::Layout::LayoutContext::styleChanged):
- layout/LayoutContext.h: order is not important.
- layout/blockformatting/BlockInvalidation.cpp:
(WebCore::Layout::invalidationStopsAtFormattingContextBoundary):
(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):
- layout/blockformatting/BlockInvalidation.h:
- layout/inlineformatting/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::invalidate):
- layout/inlineformatting/InlineInvalidation.h:
- 9:15 AM Changeset in webkit [231354] by
-
- 2 edits in trunk/Source/WebKit
Adjust sandbox rules for simulator.
https://bugs.webkit.org/show_bug.cgi?id=185275
Reviewed by Brent Fulgham.
Enable rules related to CoreMedia for minimal simulator.
- WebProcess/com.apple.WebProcess.sb.in:
- 8:35 AM Changeset in webkit [231353] by
-
- 2 edits in trunk/Source/WTF
OptionsSet initializer list constructor should be constexpr
https://bugs.webkit.org/show_bug.cgi?id=185298
Reviewed by Anders Carlsson.
- wtf/OptionSet.h:
(WTF::OptionSet::OptionSet):
- 8:18 AM Changeset in webkit [231352] by
-
- 3 edits2 adds in trunk
PeerConnection should have its connectionState closed even if doing gathering
https://bugs.webkit.org/show_bug.cgi?id=185267
Reviewed by Darin Adler.
Source/WebCore:
Test: webrtc/addICECandidate-closed.html
In case m_iceConnectionState is closed, m_connectionState should also be set to closed
and RTCPeerConnection should be closed so as to reject any other call.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::updateConnectionState):
LayoutTests:
- webrtc/addICECandidate-closed-expected.txt: Added.
- webrtc/addICECandidate-closed.html: Added.
- 6:26 AM Changeset in webkit [231351] by
-
- 2 edits in trunk/Source/WebCore
[MSE][GStreamer] Delete properly the stream from the WebKitMediaSource
https://bugs.webkit.org/show_bug.cgi?id=185242
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-04
Reviewed by Xabier Rodriguez-Calvar.
When the sourceBuffer is removed from mediasource, the appropriate stream is not
properly deleted from WebKitMediaSource, because the appsrc and parser elements
of the stream are not removed from the WebKitMediaSource bin.
This patch avoids the regression of r231089, see https://bugs.webkit.org/show_bug.cgi?id=185071
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcFreeStream):
- 3:14 AM Changeset in webkit [231350] by
-
- 9 edits in trunk
[GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
https://bugs.webkit.org/show_bug.cgi?id=174730
Reviewed by Michael Catanzaro.
Source/WebCore:
Export ResourceRequestBase::hasHTTPHeaderField().
- platform/network/ResourceRequestBase.h:
Source/WebKit:
The problem is that we don't send any User-Agent HTTP header for downloads started by WebProcessPool::download().
- UIProcess/API/glib/WebKitDownload.cpp:
(webkitDownloadUpdateRequest): Helper to update the cached request.
(webkitDownloadStarted): Updated the cached request if we have one.
(webkit_download_get_request): Use webkitDownloadUpdateRequest().
- UIProcess/API/glib/WebKitDownloadClient.cpp:
- UIProcess/API/glib/WebKitDownloadPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::download): Set the User-Agent HTTP header if there isn't any.
Tools:
Update unit tests to check that User-Agent header is included in HTTP download requests.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadRemoteFile):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(testDownloadMIMEType):
(testContextMenuDownloadActions):
- 3:12 AM Changeset in webkit [231349] by
-
- 4 edits in trunk
[GTK] Some event tests failing after r230817
https://bugs.webkit.org/show_bug.cgi?id=185072
Reviewed by Michael Catanzaro.
Source/WebKit:
Do not send mouse move events to the WebProcess for crossing events during testing. WTR never generates crossing
events and they can confuse tests.
Fixes: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
fast/css/user-drag-none.html
fast/events/context-activated-by-key-event.html
fast/events/drag-selects-image.html
fast/events/dropzone-005.html
fast/events/mouse-click-events.html
fast/events/mouse-cursor-change.html
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCrossingNotifyEvent):
LayoutTests:
Remove expectations for tests that are passing now.
- platform/gtk/TestExpectations:
