Timeline
May 6, 2018:
- 10:24 PM Changeset in webkit [231404] by
-
- 5 edits in trunk/Source/WTF
[WTF] Embed default atomic string table in Thread
https://bugs.webkit.org/show_bug.cgi?id=185349
Reviewed by Darin Adler.
Do not need to allocate AtomicStringTable separate from Thread
since the table's lifetime is completely the same as Thread.
This patch just embeds it as a data member of Thread.
- wtf/Threading.cpp:
(WTF::Thread::initializeInThread):
(WTF::Thread::didExit):
- wtf/Threading.h:
- wtf/text/AtomicStringTable.cpp:
(WTF::AtomicStringTable::create): Deleted.
(WTF::AtomicStringTable::destroy): Deleted.
- wtf/text/AtomicStringTable.h:
- 7:46 PM Changeset in webkit [231403] by
-
- 16 edits in trunk/Source
[JSC] Remove "using namespace std;" from JSC, bmalloc, WTF
https://bugs.webkit.org/show_bug.cgi?id=185362
Reviewed by Sam Weinig.
Source/bmalloc:
- bmalloc/Allocator.cpp:
- bmalloc/Deallocator.cpp:
Source/JavaScriptCore:
"namespace std" may include many names. It can conflict with names defined by our code,
and the other platform provided headers. For example, std::byte conflicts with Windows'
::byte.
This patch removes "using namespace std;" from JSC and bmalloc.
- API/JSClassRef.cpp:
(OpaqueJSClass::create):
- bytecode/Opcode.cpp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
- heap/Heap.cpp:
(JSC::Heap::updateAllocationLimits):
- interpreter/Interpreter.cpp:
- jit/JIT.cpp:
- parser/Parser.cpp:
- runtime/JSArray.cpp:
- runtime/JSLexicalEnvironment.cpp:
- runtime/JSModuleEnvironment.cpp:
- runtime/Structure.cpp:
- shell/DLLLauncherMain.cpp:
(getStringValue):
(applePathFromRegistry):
(appleApplicationSupportDirectory):
(copyEnvironmentVariable):
(prependPath):
(fatalError):
(directoryExists):
(modifyPath):
(getLastErrorString):
(wWinMain):
- 7:46 PM Changeset in webkit [231402] by
-
- 4 edits in trunk/Source/WTF
[WTF] Use static initializers for WTF::Mutex and WTF::ThreadCondition
https://bugs.webkit.org/show_bug.cgi?id=185361
Reviewed by Sam Weinig.
Use static initializers for WTF::Mutex and WTF::ThreadCondition to make
constructors of them simple and constexpr.
- wtf/ThreadingPrimitives.h:
- wtf/ThreadingPthreads.cpp:
(WTF::Mutex::Mutex): Deleted.
(WTF::ThreadCondition::ThreadCondition): Deleted.
- wtf/ThreadingWin.cpp:
(WTF::Mutex::Mutex): Deleted.
(WTF::ThreadCondition::ThreadCondition): Deleted.
- 7:09 PM Changeset in webkit [231401] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Add assertions for stale Display::Box geometry
https://bugs.webkit.org/show_bug.cgi?id=185357
Reviewed by Antti Koivisto.
Ensure that we don't access stale geometry of other boxes during layout.
For example, in order to layout a block child we need the containing block's content box top/left and width (but not the height)
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::invalidateTop):
(WebCore::Display::Box::invalidateLeft):
(WebCore::Display::Box::invalidateWidth):
(WebCore::Display::Box::invalidateHeight):
(WebCore::Display::Box::hasValidPosition const):
(WebCore::Display::Box::hasValidSize const):
(WebCore::Display::Box::hasValidGeometry const):
(WebCore::Display::Box::invalidatePosition):
(WebCore::Display::Box::invalidateSize):
(WebCore::Display::Box::setHasValidPosition):
(WebCore::Display::Box::setHasValidSize):
(WebCore::Display::Box::setHasValidGeometry):
(WebCore::Display::Box::rect const):
(WebCore::Display::Box::top const):
(WebCore::Display::Box::left const):
(WebCore::Display::Box::bottom const):
(WebCore::Display::Box::right const):
(WebCore::Display::Box::topLeft const):
(WebCore::Display::Box::bottomRight const):
(WebCore::Display::Box::size const):
(WebCore::Display::Box::width const):
(WebCore::Display::Box::height const):
(WebCore::Display::Box::setRect):
(WebCore::Display::Box::setTopLeft):
(WebCore::Display::Box::setTop):
(WebCore::Display::Box::setLeft):
(WebCore::Display::Box::setSize):
(WebCore::Display::Box::setWidth):
(WebCore::Display::Box::setHeight):
- 1:00 PM Changeset in webkit [231400] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Add BlockFormattingContext::computeStaticPosition
https://bugs.webkit.org/show_bug.cgi?id=185352
Reviewed by Antti Koivisto.
This is the core logic for positioning inflow boxes in a block formatting context (very naive though).
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
- layout/displaytree/DisplayBox.h:
May 5, 2018:
- 6:06 PM Changeset in webkit [231399] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA phase should only do clobber asserts in debug
https://bugs.webkit.org/show_bug.cgi?id=185354
Reviewed by Saam Barati.
Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
unless asserts are enabled.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- 4:45 PM Changeset in webkit [231398] by
-
- 6 edits in trunk/Source/WebCore
Cleanup XMLHttpRequestUpload a little
https://bugs.webkit.org/show_bug.cgi?id=185344
Patch by Sam Weinig <sam@webkit.org> on 2018-05-05
Reviewed by Yusuke Suzuki.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitAdditionalChildren):
Use auto to reduce redundancy.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::upload):
- xml/XMLHttpRequest.h:
Switch upload() to return a reference.
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h:
Cleanup formatting, modernize and switch XMLHttpRequest member from a pointer
to a reference.
- 3:42 PM Changeset in webkit [231397] by
-
- 2 edits in trunk/Source/WebCore
Draw a drop-shadow behind the system preview badge
https://bugs.webkit.org/show_bug.cgi?id=185356
<rdar://problem/40004936>
Reviewed by Wenson Hsieh.
Draw a very subtle drop-shadow under the system
preview badge so that it is more visible on a pure
white background.
I also moved some code around to make it more clear
and improved comments.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
