⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 13, 2018:

9:36 PM Changeset in webkit [231748] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

6:12 PM Changeset in webkit [231747] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.17.5

Tag Safari-606.1.17.5.

5:15 PM Changeset in webkit [231746] by bshafiei@apple.com
  • 3 edits in branches/safari-606.1.17-branch/Source/WebKit

Cherry-pick r231744. rdar://problem/40196581

WebKit2_Sim-7606.1.17.4 introduced dep cycle
​https://bugs.webkit.org/show_bug.cgi?id=185588
<rdar://problem/40196581>

Reviewed by Tim Horton.

Soft link AssetViewer.framework to avoid a dependency cycle.

  • Configurations/WebKit.xcconfig:
  • UIProcess/ios/WKSystemPreviewView.mm: (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@231744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:39 PM Changeset in webkit [231745] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

12:29 PM Changeset in webkit [231744] by dino@apple.com
  • 3 edits in trunk/Source/WebKit

WebKit2_Sim-7606.1.17.4 introduced dep cycle
​https://bugs.webkit.org/show_bug.cgi?id=185588
<rdar://problem/40196581>

Reviewed by Tim Horton.

Soft link AssetViewer.framework to avoid a dependency cycle.

  • Configurations/WebKit.xcconfig:
  • UIProcess/ios/WKSystemPreviewView.mm:

(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):

11:57 AM Changeset in webkit [231743] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Disable pointer poisoning
​https://bugs.webkit.org/show_bug.cgi?id=185586

Reviewed by Yusuke Suzuki.

This seems like a 0.3% speed-up on microbenchmarks. It seems like it may be a small speed-up on
other tests, too.

  • wtf/Platform.h:
11:16 AM Changeset in webkit [231742] by Caio Lima
  • 2 edits in trunk/JSTests

[BigInt] stress/big-int-spec-to-primitive.js test is failing
​https://bugs.webkit.org/show_bug.cgi?id=185582

Reviewed by Yusuke Suzuki.

This patch is removing the use of numberOfDFGCompiles from
stress/big-int-spec-to-primitive.js because it makes this est fail
sometimes.

  • stress/big-int-spec-to-primitive.js:
9:54 AM Changeset in webkit [231741] by fpizlo@apple.com
  • 9 edits
    1 add in trunk/Source/JavaScriptCore

CachedCall::call() should be faster
​https://bugs.webkit.org/show_bug.cgi?id=185583

Reviewed by Yusuke Suzuki.

CachedCall is an optimization for String.prototype.replace(r, f) where f is a function.
Unfortunately, because of a combination of abstraction and assertions, this code path had a
lot of overhead. This patch reduces this overhead by:

  • Turning off some assertions. These assertions don't look to have security value; they're mostly for sanity. I turned off stack alignment checks and VM state checks having to do with whether the JSLock is held. The JSLock checks are not relevant when doing a cached call, considering that the caller would have already been strongly assuming that the JSLock is held.


  • Making more things inlineable.


This looks like a small (4% ish) speed-up on SunSpider/string-unpack-code.

(JSC::CachedCall::call):

  • interpreter/Interpreter.cpp:

(JSC::checkedReturn): Deleted.

  • interpreter/Interpreter.h:

(JSC::Interpreter::checkedReturn):

  • interpreter/InterpreterInlines.h:

(JSC::Interpreter::execute):

  • jit/JITCode.cpp:

(JSC::JITCode::execute): Deleted.

  • jit/JITCodeInlines.h: Added.

(JSC::JITCode::execute):

  • llint/LowLevelInterpreter.asm:
  • runtime/StringPrototype.cpp:
7:28 AM Changeset in webkit [231740] by commit-queue@webkit.org
  • 22 edits in trunk

[INTL] Improve spec & test262 compliance for Intl APIs
​https://bugs.webkit.org/show_bug.cgi?id=185578

Patch by Andy VanWagoner <​andy@vanwagoner.family> on 2018-05-13
Reviewed by Yusuke Suzuki.

JSTests:

Remove intl402 failures that have been fixed.

  • test262/expectations.yaml:
  • stress/regress-178385.js: toStringTag is configurable, but not writable.

Source/JavaScriptCore:

Use putDirectIndex over push for lists to arrays.
Update default options to construct with a null prototype.
Define constructor and toStringTag on prototypes.
Add proper time clipping.
Remove some outdated comment spec text, use url instead.

  • runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

  • runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::finishCreation):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::finishCreation):

  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::finishCreation):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):
(JSC::IntlDateTimeFormatFuncFormatDateTime):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::finishCreation):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::finishCreation):

  • runtime/IntlObject.cpp:

(JSC::lookupSupportedLocales):
(JSC::supportedLocales):
(JSC::intlObjectFuncGetCanonicalLocales):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::resolvedOptions):

  • runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructor::finishCreation):

LayoutTests:

Update Intl tests for prototype changes.

  • js/intl-collator-expected.txt:
  • js/intl-datetimeformat-expected.txt:
  • js/intl-numberformat-expected.txt:
  • js/script-tests/intl-collator.js:
  • js/script-tests/intl-datetimeformat.js:
  • js/script-tests/intl-numberformat.js:
2:25 AM Changeset in webkit [231739] by krit@webkit.org
  • 13 edits
    4 adds in trunk

Implement SVGGeometryElement's isPointInFill and isPointInStroke
​https://bugs.webkit.org/show_bug.cgi?id=185580

Reviewed by Antti Koivisto.

Implement isPointInFill and isPointInStroke methods for
SVGGeometryElement interface from SVG2.

​https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

Source/WebCore:

Tests: svg/dom/SVGGeometry-isPointInFill.xhtml

svg/dom/SVGGeometry-isPointInStroke.xhtml

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

(WebCore::RenderSVGShape::isPointInFill): Take the winding rule given by

fill-rule to test if a given point is in the fill area of a path.

(WebCore::RenderSVGShape::isPointInStroke): Take stroke properties into

account to check if a point is on top of the stroke area.

  • rendering/svg/RenderSVGShape.h:
  • svg/SVGGeometryElement.cpp:

(WebCore::SVGGeometryElement::isPointInFill):
(WebCore::SVGGeometryElement::isPointInStroke):
(WebCore::SVGGeometryElement::createElementRenderer): Deleted. This is getting implemented

by inheriting classes. No need to create RenderSVGPath here.

  • svg/SVGGeometryElement.h:
  • svg/SVGGeometryElement.idl:

LayoutTests:

  • svg/dom/SVGGeometry-isPointInFill-expected.txt: Added.
  • svg/dom/SVGGeometry-isPointInFill.xhtml: Added.
  • svg/dom/SVGGeometry-isPointInStroke-expected.txt: Added.
  • svg/dom/SVGGeometry-isPointInStroke.xhtml: Added.

May 12, 2018:

6:00 PM Changeset in webkit [231738] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.17.4

Tag Safari-606.1.17.4.

5:03 PM Changeset in webkit [231737] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline a layout test after r231717

  • fast/events/extrazoom/change-focus-during-change-event-expected.txt:
4:55 PM Changeset in webkit [231736] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

10:10 AM Changeset in webkit [231735] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

Use WeakPtr for m_enclosingPaginationLayer in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=185566
<rdar://problem/36486052>

Reviewed by Simon Fraser.

Since RenderLayer does not own the enclosing pagination layout, it should
construct a weak pointer instead of holding on to a raw pointer.

Unable to create a reliably reproducible test case.

  • page/mac/EventHandlerMac.mm:

(WebCore::scrollableAreaForEventTarget):
(WebCore::scrollableAreaForContainerNode):
(WebCore::EventHandler::platformPrepareForWheelEvents):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::weakPtrFactory const):
(WebCore::ScrollableArea::createWeakPtr): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updatePagination):

  • rendering/RenderLayer.h:
Note: See TracTimeline for information about the timeline view.