Timeline

May 27, 2018:

10:31 PM Changeset in webkit [232239] by mitz@apple.com

• 53 edits in trunk

Reverted the changes made for ​https://webkit.org/b/186016

They broke the USE(APPLE_INTERNAL_SDK) Sierra build.

10:04 PM Changeset in webkit [232238] by mitz@apple.com

• 2 edits in trunk/Source/WebCore/PAL

Tried to fix the pre-High Sierra USE(APPLE_INTERNAL_SDK) build

• pal/spi/cg/CoreGraphicsSPI.h: #undef confirm, which is defined by ApplicationServicesPriv.h.

9:31 PM Changeset in webkit [232237] by mitz@apple.com

• 2 edits in trunk/Source/WebCore/PAL

Tried to fix the 32-bit USE(APPLE_INTERNAL_SDK) build.

• pal/spi/mac/QuickDrawSPI.h: Import ApplicationServicesPriv.h instead of QuickDrawPriv.h.

9:21 PM Changeset in webkit [232236] by ddkilzer@apple.com

• 16 edits
  2 adds
  1 delete in trunk/Source

[iOS] Fix warnings about leaks found by clang static analyzer
<​https://webkit.org/b/186009>
<rdar://problem/40574267>

Reviewed by Daniel Bates.

Source/ThirdParty/libwebrtc:

• Source/third_party/opus/src/src/opus_compare.c:
• Source/third_party/opus/src/src/opus_demo.c:

(main):

• Free allocated memory on early returns.
• Source/third_party/usrsctp/usrsctplib/user_mbuf.c:

(clust_constructor_dup):
(mb_ctor_clust):

• Free allocated memory if m is NULL.
• Source/third_party/usrsctp/usrsctplib/user_socket.c:

(usrsctp_connect): Free sa memory if getsockaddr() returns an
error, but still allocates memory for sa.

• WebKit/patch-opus.diff: Add patch for opus changes.
• WebKit/patch-usrsctp: Rename empty file to patch-usrsctp.diff.
• WebKit/patch-usrsctp.diff: Add patch for usrsctp changes.
• libwebrtc.xcodeproj/project.pbxproj: Remove opus_compare.c,

opus_demo.c, and repacketizer_demo.c from opus target. This
code is for stand-alone tools, and although it may be removed
during dead code linking, we don't need to spend time compiling
it.

Source/WebCore:

• Modules/webauthn/cocoa/LocalAuthenticator.mm:

(WebCore::LocalAuthenticator::makeCredential):
(WebCore::LocalAuthenticator::getAssertion):
(WebCore::LocalAuthenticator::issueClientCertificate const):

• Don't leak CF objects in early return paths, and get rid of retained* variables, by making original variables use RetainPtr<>.
• bridge/objc/WebScriptObject.mm:

(+[WebUndefined allocWithZone:]): Modernize WebUndefined by
using NeverDestroyed<RetainPr<WebUndefined>> type. Explicitly
retain the object returned on each call.
(+[WebUndefined undefined]): Explicitly autorelease the object
returned. Note that neither of these changes fixes the static
analyzer warnings in this source file.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::exernalDeviceDisplayNameForPlayer): Use RetainPtr<> to
stop leaking NSString objects in a loop.

• platform/ios/wak/WAKWindow.h:

(-[WAKWindow _newFirstResponderAfterResigning]): Mark as
NS_RETURNS_NOT_RETAINED like the corresponding AppKit method
since this doesn't return a new object. This fixes some
false-positive leaks warnings.

Source/WebKit:

• UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeySequence): Fix
leak of two WebEvent objects that happened in a loop.

• UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
Fix leak of a UIImage.

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm:

(-[WebHTMLView doCommandBySelector:]): Fix use of an
uninitialized boolean variable (eventWasHandled) that only
happened on iOS.

9:17 PM Changeset in webkit [232235] by mitz@apple.com

• 52 edits in trunk

[Cocoa] Avoid importing directly from subumbrella frameworks
​https://bugs.webkit.org/show_bug.cgi?id=186016

Reviewed by Sam Weinig.

Source/WebCore:

• Configurations/WebCore.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• editing/mac/DictionaryLookup.mm: Import Quartz.h instead of a PDFKit header.
• html/HTMLKeygenElement.cpp: Removed "using namespace WebCore" from this WebCore implementation file.
• platform/mac/PlatformEventFactoryMac.mm: Import Carbon.h instead of HIToolbox headers.
• platform/mac/PlatformScreenMac.mm: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
• platform/mediastream/CaptureDeviceManager.cpp: Enclosed the definitions in the WebCore namespace and removed "using namespace WebCore" from this WebCore implementation file.
• platform/text/mac/TextEncodingRegistryMac.mm: Import Carbon.h instead of CarbonCore.h.

Source/WebCore/PAL:

• Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
• pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
• pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.

Source/WebKit:

• Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• UIProcess/Automation/mac/WebAutomationSessionMac.mm: Import Carbon.h instead of an HIToolbox header.
• UIProcess/Cocoa/WebViewImpl.mm: Ditto.
• UIProcess/mac/WKPrintingView.mm: Import Quartz.h instead of a PDFKit header.
• UIProcess/mac/WKTextInputWindowController.mm: Import Carbon.h instead of an HIToolbox header.
• WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h: Import Quartz.h instead of a PDFKit header.
• WebProcess/Plugins/PDF/PDFLayerControllerSPI.h: Ditto.
• WebProcess/Plugins/PDF/PDFPlugin.mm: Ditto.
• WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: Ditto.
• WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: Ditto.
• WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Ditto.
• WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: Ditto.
• WebProcess/WebPage/mac/WebPageMac.mm: Ditto.

Source/WebKitLegacy/mac:

• Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
• Carbon/CarbonWindowAdapter.mm: Ditto.
• Carbon/CarbonWindowFrame.m: Ditto.
• Carbon/HIViewAdapter.h: Ditto.
• Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
• WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
• WebView/WebPDFView.h: Ditto.

Tools:

• DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a LaunchServices header.
• DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
• TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an HIToolbox header.
• WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
• WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a LaunchServices header.

8:49 PM Changeset in webkit [232234] by Fujii Hironori

• 4 edits
  2 adds in trunk/Tools

[Win][MiniBrowser] Add MainWindow class
​https://bugs.webkit.org/show_bug.cgi?id=185814

Reviewed by Per Arne Vollan.

This is a sub task of Bug 184770. Added a new class MainWindow to
represent the main window which will be shared among WK1 and WK2.

This change is partial so that it's easy to review this patch.
I'll move more functions into MainWindow.cpp, and remove more
global variables in forthcoming patches.

• MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
• MiniBrowser/win/Common.cpp: Removed MainWindow related global

variables hMainWnd, hURLBarWnd, hBackButtonWnd and
hForwardButtonWnd. Added a new global variable gMainWindow.
(WndProc): Moved to MainWindow.cpp.
(resizeSubViews): Ditto.
(ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
(ToggleMenuItem): Ditto.
(CustomUserAgent): Follow the global variables removal.
(DisplayAuthDialog): Ditto.
(loadURL): Ditto.
(WndProc): Renamed to MainWindow::WndProc.

• MiniBrowser/win/MainWindow.cpp: Added.

(MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
(MainWindow::init): Extracted MainWindow initialization code from wWinMain.
(MainWindow::resizeSubViews): Moved from Common.cpp.
(MainWindow::WndProc): Ditto.

• MiniBrowser/win/MainWindow.h: Added.

(MainWindow::hwnd):
(MainWindow::browserWindow):

• MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::init):
(MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
(MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.

• MiniBrowser/win/MiniBrowser.h:
• MiniBrowser/win/WinMain.cpp:

(wWinMain): Extracted MainWindow initialization code into MainWindow::init.
(MyRegisterClass): Moved to MainWindow.cpp.

8:21 PM Changeset in webkit [232233] by Fujii Hironori

• 5 edits in trunk/Source

REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=186027

Unreviewed build fix

Source/WebCore:

No new tests (No behavior change).

• platform/network/curl/AuthenticationChallengeCurl.cpp:

(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):

• platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::willSetupSslCtx):

Source/WebKitLegacy/win:

• WebMutableURLRequest.cpp:

(WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
(WebMutableURLRequest::setClientCertificate):

8:19 PM Changeset in webkit [232232] by Caio Lima

• 28 edits
  3 adds in trunk

[ESNext][BigInt] Implement "+" and "-" unary operation
​https://bugs.webkit.org/show_bug.cgi?id=182214

Reviewed by Yusuke Suzuki.

JSTests:

• stress/big-int-negate-basic.js: Added.
• stress/big-int-negate-jit.js: Added.
• stress/big-int-unary-plus.js: Added.

Source/JavaScriptCore:

This Patch is implementing support to "-" unary operation on BigInt.
It is also changing the logic of ASTBuilder::makeNegateNode to
calculate BigInt literals with properly sign, avoiding
unecessary operation. It required a refactoring into
JSBigInt::parseInt to consider the sign as parameter.

We are also introducing a new DFG Node called ValueNegate to handle BigInt negate
operations. With the introduction of BigInt, it is not true
that every negate operation returns a Number. As ArithNegate is a
node that considers its result is always a Number, like all other
Arith<Operation>, we decided to keep this consistency and use ValueNegate when
speculation indicates that the operand is a BigInt.
This design is following the same distinction between ArithAdd and
ValueAdd. Also, this new node will make simpler the introduction of
optimizations when we create speculation paths for BigInt in future
patches.

In the case of "+" unary operation on BigInt, the current semantic we already have
is correctly, since it needs to throw TypeError because of ToNumber call[1].
In such case, we are adding tests to verify other edge cases.

[1] - ​https://tc39.github.io/proposal-bigint/#sec-unary-plus-operator

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addBigIntConstant):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::BigIntNode::jsValue const):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::arithNodeFlags):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueNegate):
(JSC::DFG::SpeculativeJIT::compileArithNegate):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
(JSC::FTL::DFG::LowerDFGToB3::compileArithNegate):

• jit/JITOperations.cpp:
• parser/ASTBuilder.h:

(JSC::ASTBuilder::createBigIntWithSign):
(JSC::ASTBuilder::createBigIntFromUnaryOperation):
(JSC::ASTBuilder::makeNegateNode):

• parser/NodeConstructors.h:

(JSC::BigIntNode::BigIntNode):

• parser/Nodes.h:
• runtime/CommonSlowPaths.cpp:

(JSC::updateArithProfileForUnaryArithOp):
(JSC::SLOW_PATH_DECL):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::parseInt):

• runtime/JSBigInt.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::strictEqualSlowCaseInline):

7:51 PM Changeset in webkit [232231] by mitz@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Tried to fix the 32-bit !ASSERT_DISABLED build after r232211.

• jit/JITOperations.cpp:

7:22 PM Changeset in webkit [232230] by Fujii Hironori

• 4 edits in trunk/Tools

[Win][MiniBrowser] Remove URL argument of MiniBrowser::init
​https://bugs.webkit.org/show_bug.cgi?id=185969

Reviewed by Alex Christensen.

MiniBrowser::init takes URL argument, but it's used only for
loading default HTML if URL is not given.

• Add a new method MiniBrowser::loadHTMLString
• Remove loadHTMLString process from MiniBrowser::prepareViews

• MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::init): Removed requestedURL argument.
(MiniBrowser::prepareViews): Ditto.
(MiniBrowser::loadHTMLString): New.
(MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.

• MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
• MiniBrowser/win/WinMain.cpp:

(wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.

5:49 PM Changeset in webkit [232229] by commit-queue@webkit.org

• 39 edits in trunk/Source

Modernize RenderStyleConstants.h - Part 3
​https://bugs.webkit.org/show_bug.cgi?id=186015

Patch by Sam Weinig <​sam@webkit.org> on 2018-05-27
Reviewed by Yusuke Suzuki.

Source/WebCore:

Modernized the third and final set of enums in RenderStyleConstants.h by:

• Converting them to enum classes
• Renaming them to remove unnecessary prefix 'E's
• Renaming values to take advantage of enum class scoping (e.g. StyleDifferenceEqual -> StyleDifference::Equal)

Modernizes the following enums:

TextDecoration
TextDecorationSkip (renamed from TextDecorationSkipItems)
TextUnderlinePosition
HangingPunctuation
SpeakAs (renamed from ESpeakAs)
TextEmphasisPosition (renamed from TextEmphasisPositions)

This final set of enums are mostly (TextUnderlinePosition isn't really) used as bitmasks,
so this change also converts their uses to use OptionSet.

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::speakAsProperty const):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::speakAsProperty const):
(WebCore::AccessibilityRenderObject::hasPlainText const):
(WebCore::AccessibilityRenderObject::hasUnderline const):

• accessibility/AccessibilityRenderObject.h:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributeStringSetStyle):

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase baseAccessibilitySpeechHint]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetStyle):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::speakAsToCSSValue):
(WebCore::hangingPunctuationToCSSValue):

• css/CSSLineBoxContainValue.h:
• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator HangingPunctuation const):
(WebCore::CSSPrimitiveValue::operator TextDecoration const):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition const):
(WebCore::CSSPrimitiveValue::operator SpeakAs const):
(WebCore::CSSPrimitiveValue::operator ESpeakAs const): Deleted.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextDecoration):
(WebCore::StyleBuilderConverter::valueToEmphasisPosition):
(WebCore::StyleBuilderConverter::convertTextEmphasisPosition):
(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
(WebCore::StyleBuilderConverter::valueToDecorationSkip):
(WebCore::StyleBuilderConverter::convertTextDecorationSkip):
(WebCore::StyleBuilderConverter::convertSpeakAs):
(WebCore::StyleBuilderConverter::convertHangingPunctuation):

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::getTextDecorationAttributesRespectingTypingStyle const):

• editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedStringFromRange):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine const):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine const):

• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.cpp:

(WebCore::emphasisPositionHasNeitherLeftNorRight):
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintMarkedTextDecoration):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration const):

• rendering/RenderElement.h:
• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addCell):

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):
(WebCore::SimpleLineLayout::canUseForWithReason):

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

• rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::collectStylesForRenderer):
(WebCore::TextDecorationPainter::stylesForRenderer):

• rendering/TextDecorationPainter.h:
• rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):

• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::changeAffectsVisualOverflow const):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textDecorationsInEffect const):
(WebCore::RenderStyle::textDecoration const):
(WebCore::RenderStyle::textDecorationSkip const):
(WebCore::RenderStyle::hangingPunctuation const):
(WebCore::RenderStyle::textEmphasisPosition const):
(WebCore::RenderStyle::speakAs const):
(WebCore::RenderStyle::addToTextDecorationsInEffect):
(WebCore::RenderStyle::setTextDecorationsInEffect):
(WebCore::RenderStyle::setTextDecoration):
(WebCore::RenderStyle::setTextDecorationSkip):
(WebCore::RenderStyle::setSpeakAs):
(WebCore::RenderStyle::setTextEmphasisPosition):
(WebCore::RenderStyle::setHangingPunctuation):
(WebCore::RenderStyle::initialHangingPunctuation):
(WebCore::RenderStyle::initialTextDecoration):
(WebCore::RenderStyle::initialTextDecorationSkip):
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::initialSpeakAs):
(WebCore::RenderStyle::initialTextEmphasisPosition):

• rendering/style/RenderStyleConstants.h:

(WebCore::operator|): Deleted.
(WebCore::operator|=): Deleted.

• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):

• rendering/style/StyleVisualData.cpp:

(WebCore::StyleVisualData::StyleVisualData):

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::findRendererDefininingTextDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):

• rendering/svg/SVGInlineTextBox.h:
• style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView updateTextTouchBar]):
Update for new enum name.

9:50 AM Changeset in webkit [232228] by ddkilzer@apple.com

• 4 edits
  2 adds in trunk/Tools

svn-apply fails when a patch has an empty file
<​https://webkit.org/b/29684>

Reviewed by Daniel Bates.

Prior to this change, applying the following patches resulted in:

• svn: add empty file (failure)
• svn: delete empty file (failure)
• svn: rename empty file (failure)
• git: add empty file (false-positive success)
• git: delete empty file (success)
• git: rename empty file (failure)

• Scripts/VCSUtils.pm:

(parseSvnDiffHeader): Handle the case when there is no patch
following the header. If the file exists and is empty, that
means it's a deletion. If the file does not exist, that means
it's an addition. Everything else is a fatal error.

• Scripts/svn-apply:

(patch):

• Only apply a patch for deletion if it has one or more text chunks.
• Add a case to handle adding an empty file (an addition with no text chunks), and verify the file doesn't exist yet.
• Any unhandled patch is a fatal error.
• Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:

Add tests for adding an empty file and deleting an empty file.

• Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.

Used by parseSvnDiffHeader.pl unit test for "add an empty file"
test case.

May 26, 2018:

1:59 PM Changeset in webkit [232227] by fpizlo@apple.com

• 3 edits in trunk/Source/WTF

testair sometimes crashes due to races in initialization of ARC4RandomNumberGenerator
​https://bugs.webkit.org/show_bug.cgi?id=186014

Reviewed by Yusuke Suzuki.

testair launches a bunch of threads and the threads do B3 things that use random numbers.
Sometimes two threads will initialize the random number generator at the same time, because
that's what happens when you use static NeverDestroyed<>.

This changes that code to use std::call_once to initialize the shared
ARC4RandomNumberGenerator.

Also, this adds a diagnostic message to the lock's assertion. This assertion was the symptom
of the race, and knowing the state of the lock when the assertion fired gave a darn good clue
about what was going on: the lock's value was 0 at time of unlock, implying that another
thread reinitialized the lock to zero by rerunning the constructor.

• wtf/CryptographicallyRandomNumber.cpp:
• wtf/LockAlgorithmInlines.h:

(WTF::Hooks>::unlockSlow):

11:17 AM Changeset in webkit [232226] by Yusuke Suzuki

• 10 edits in trunk

[JSC] Rename Array#flatten to flat
​https://bugs.webkit.org/show_bug.cgi?id=186012

Reviewed by Saam Barati.

JSTests:

• stress/array-flatten.js:

(shouldThrow):

• test262/expectations.yaml:

Source/JavaScriptCore:

Rename Array#flatten to Array#flat. This rename is done in TC39 since flatten
conflicts with the mootools' function name.

• builtins/ArrayPrototype.js:

(globalPrivate.flatIntoArray):
(flat):
(globalPrivate.flatIntoArrayWithCallback):
(flatMap):
(globalPrivate.flattenIntoArray): Deleted.
(flatten): Deleted.
(globalPrivate.flattenIntoArrayWithCallback): Deleted.

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

LayoutTests:

• inspector/model/remote-object-get-properties-expected.txt:
• js/Object-getOwnPropertyNames-expected.txt:
• js/script-tests/Object-getOwnPropertyNames.js:

8:26 AM Changeset in webkit [232225] by Alan Bujtas

• 8 edits
  1 delete in trunk/Source/WebCore

[LFC] Implement margin computation
​https://bugs.webkit.org/show_bug.cgi?id=186008

Reviewed by Antti Koivisto.

• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeMargin const):
(WebCore::Layout::FormattingContext::marginTop const): Deleted.
(WebCore::Layout::FormattingContext::marginLeft const): Deleted.
(WebCore::Layout::FormattingContext::marginBottom const): Deleted.
(WebCore::Layout::FormattingContext::marginRight const): Deleted.

• layout/FormattingContext.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::computeMargin const):
(WebCore::Layout::BlockFormattingContext::marginTop const): Deleted.
(WebCore::Layout::BlockFormattingContext::marginBottom const): Deleted.

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeight):
(WebCore::Layout::BlockFormattingContext::Geometry::computedMargin):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::_isMarginBottomCollapsedWithParent):
(WebCore::Layout::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginTopCollapsedWithParentMarginBottom):
(WebCore::Layout::BlockMarginCollapse::marginTop): Deleted.
(WebCore::Layout::BlockMarginCollapse::marginBottom): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginBottomCollapsedWithParent): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginTopCollapsedWithParentMarginBottom): Deleted.

• layout/blockformatting/BlockMarginCollapse.h: Removed.

3:55 AM Changeset in webkit [232224] by Yusuke Suzuki

• 185 edits
  24 copies
  5 moves
  80 adds
  2 deletes in trunk/JSTests

Upgrade test262 to May 24 version
​https://bugs.webkit.org/show_bug.cgi?id=185937

Reviewed by Darin Adler.

• test262/expectations.yaml:
• test262/harness/doneprintHandle.js:

(DONE):

• test262/latest-changes-summary.txt:
• test262/test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-non-enumerable-global-init.js: Copied from JSTests/test262/test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-global-init.js.
• test262/test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-global-init.js:
• test262/test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-non-enumerable-global-init.js: Added.
• test262/test/annexB/language/global-code/block-decl-global-existing-global-init.js: Added.

(262.evalScript.f):

• test262/test/annexB/language/global-code/block-decl-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.f):

• test262/test/annexB/language/global-code/if-decl-else-decl-a-global-existing-global-init.js: Added.

(262.evalScript.true.f):
(else._f):

• test262/test/annexB/language/global-code/if-decl-else-decl-a-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.true.f):
(else._f):

• test262/test/annexB/language/global-code/if-decl-else-decl-b-global-existing-global-init.js: Added.

(262.evalScript.false._f):
(else.f):

• test262/test/annexB/language/global-code/if-decl-else-decl-b-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.false._f):
(else.f):

• test262/test/annexB/language/global-code/if-decl-else-stmt-global-existing-global-init.js: Added.

(262.evalScript.true.f):

• test262/test/annexB/language/global-code/if-decl-else-stmt-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.true.f):

• test262/test/annexB/language/global-code/if-decl-no-else-global-existing-global-init.js: Added.

(262.evalScript.true.f):

• test262/test/annexB/language/global-code/if-decl-no-else-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.true.f):

• test262/test/annexB/language/global-code/if-stmt-else-decl-global-existing-global-init.js: Added.

(else.f):

• test262/test/annexB/language/global-code/if-stmt-else-decl-global-existing-non-enumerable-global-init.js: Added.

(else.f):

• test262/test/annexB/language/global-code/switch-case-global-existing-global-init.js: Added.

(262.evalScript.switch.case.1):
(262.evalScript.switch):

• test262/test/annexB/language/global-code/switch-case-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.switch.case.1):
(262.evalScript.switch):

• test262/test/annexB/language/global-code/switch-dflt-global-existing-global-init.js: Added.

(262.evalScript.switch.default):
(262.evalScript.switch):

• test262/test/annexB/language/global-code/switch-dflt-global-existing-non-enumerable-global-init.js: Added.

(262.evalScript.switch.default):
(262.evalScript.switch):

• test262/test/built-ins/Array/prototype/flat/array-like-objects.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/array-like-objects.js.
• test262/test/built-ins/Array/prototype/flat/bound-function-call.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/bound-function-call.js.
• test262/test/built-ins/Array/prototype/flat/empty-array-elements.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/empty-array-elements.js.
• test262/test/built-ins/Array/prototype/flat/empty-object-elements.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/empty-object-elements.js.
• test262/test/built-ins/Array/prototype/flat/length.js: Added.
• test262/test/built-ins/Array/prototype/flat/name.js: Added.
• test262/test/built-ins/Array/prototype/flat/non-numeric-depth-should-not-throw.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/non-numeric-depth-should-not-throw.js.
• test262/test/built-ins/Array/prototype/flat/non-object-ctor-throws.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/non-object-ctor-throws.js.
• test262/test/built-ins/Array/prototype/flat/null-undefined-elements.js: Added.
• test262/test/built-ins/Array/prototype/flat/null-undefined-input-throws.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/null-undefined-input-throws.js.
• test262/test/built-ins/Array/prototype/flat/positive-infinity.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/positive-infinity.js.
• test262/test/built-ins/Array/prototype/flat/prop-desc.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/prop-desc.js.
• test262/test/built-ins/Array/prototype/flat/symbol-object-create-null-depth-throws.js: Renamed from JSTests/test262/test/built-ins/Array/prototype/flatten/symbol-object-create-null-depth-throws.js.
• test262/test/built-ins/Array/prototype/flatten/length.js: Removed.
• test262/test/built-ins/Array/prototype/flatten/name.js: Removed.
• test262/test/built-ins/Array/prototype/flatten/null-undefined-elements.js: Removed.
• test262/test/built-ins/AsyncGeneratorPrototype/next/name.js:
• test262/test/built-ins/AsyncGeneratorPrototype/return/name.js:
• test262/test/built-ins/AsyncGeneratorPrototype/throw/name.js:
• test262/test/built-ins/Math/acosh/nan-returns.js:
• test262/test/built-ins/Math/asinh/asinh-specialVals.js:
• test262/test/built-ins/Math/atanh/atanh-specialVals.js:
• test262/test/built-ins/Math/cbrt/cbrt-specialValues.js:
• test262/test/built-ins/Math/cbrt/prop-desc.js:
• test262/test/built-ins/Math/cosh/cosh-specialVals.js:
• test262/test/built-ins/Math/expm1/expm1-specialVals.js:
• test262/test/built-ins/Math/log10/Log10-specialVals.js:
• test262/test/built-ins/Math/log2/log2-basicTests.js:
• test262/test/built-ins/Math/sign/sign-specialVals.js:
• test262/test/built-ins/Math/sinh/sinh-specialVals.js:
• test262/test/built-ins/Math/tanh/tanh-specialVals.js:
• test262/test/built-ins/Math/trunc/trunc-sampleTests.js:
• test262/test/built-ins/Math/trunc/trunc-specialVals.js:
• test262/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-dollar1.js: Added.
• test262/test/built-ins/Object/internals/DefineOwnProperty/consistent-writable-regexp-dollar1.js: Added.
• test262/test/intl402/Intl/getCanonicalLocales/descriptor.js:
• test262/test/intl402/Intl/getCanonicalLocales/duplicates.js:
• test262/test/intl402/Locale/constructor-getter-order.js: Added.

(new.Intl.Locale.toString):
(get language):
(get script):
(get region):
(get calendar):
(get collation):
(get hourCycle):
(get caseFirst):
(get numeric):
(get numberingSystem):

• test262/test/intl402/Locale/constructor-locale-object.js: Added.
• test262/test/intl402/Locale/constructor-non-iana-canon.js: Added.
• test262/test/intl402/Locale/constructor-options-casefirst-invalid.js: Added.

(valueOf):
(const.invalidCaseFirstOption.of.invalidCaseFirstOptions.new.Intl.Locale):

• test262/test/intl402/Locale/constructor-options-casefirst-valid.js: Added.

(toString):

• test262/test/intl402/Locale/constructor-options-collation-invalid.js: Added.

(const.invalidCollationOption.of.invalidCollationOptions.new.Intl.Locale):

• test262/test/intl402/Locale/constructor-options-collation-valid.js: Added.
• test262/test/intl402/Locale/constructor-options-hourcycle-invalid.js: Added.

(const.invalidHourCycleOption.of.invalidHourCycleOptions.new.Intl.Locale):

• test262/test/intl402/Locale/constructor-options-hourcycle-valid.js: Added.

(toString):

• test262/test/intl402/Locale/constructor-options-language-grandfathered.js: Added.
• test262/test/intl402/Locale/constructor-options-language-valid.js:

(toString):

• test262/test/intl402/Locale/constructor-options-numberingsystem-invalid.js: Added.

(const.invalidNumberingSystemOption.of.invalidNumberingSystemOptions.new.Intl.Locale):

• test262/test/intl402/Locale/constructor-options-numberingsystem-valid.js: Added.
• test262/test/intl402/Locale/constructor-options-numeric-valid.js: Added.

(valueOf):

• test262/test/intl402/Locale/constructor-options-region-valid.js:
• test262/test/intl402/Locale/constructor-options-script-valid.js:

(toString):

• test262/test/intl402/Locale/constructor-parse-twice.js: Added.
• test262/test/intl402/Locale/constructor-tag-tostring.js: Added.

(CustomError):
(WrongCustomError):
(const.errors.get Symbol):
(throw.new.CustomError):
(throw.new.CustomError.get toString):
(throw.new.CustomError.get valueOf):
(throw.new.WrongCustomError.get valueOf):
(throw.new.WrongCustomError):

• test262/test/intl402/Locale/constructor-unicode-ext-invalid.js: Added.
• test262/test/intl402/Locale/constructor-unicode-ext-valid.js: Added.

(canonical.of.Object.entries):

• test262/test/intl402/Locale/extensions-grandfathered.js: Added.

(of.testData.value.of.Object.entries):

• test262/test/intl402/Locale/extensions-private.js: Added.
• test262/test/intl402/Locale/getters-grandfathered.js: Added.
• test262/test/intl402/Locale/getters-missing.js: Added.
• test262/test/intl402/Locale/getters-privateuse.js: Added.
• test262/test/intl402/Locale/getters.js: Added.
• test262/test/intl402/Locale/invalid-tag-throws-symbol.js:
• test262/test/intl402/Locale/likely-subtags-grandfathered.js: Added.
• test262/test/intl402/Locale/prop-desc.js:
• test262/test/intl402/Locale/prototype/baseName/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/calendar/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/caseFirst/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/collation/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/constructor/prop-desc.js: Copied from JSTests/test262/test/intl402/Locale/prototype/constructor.js.
• test262/test/intl402/Locale/prototype/hourCycle/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/language/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/maximize/length.js:
• test262/test/intl402/Locale/prototype/maximize/prop-desc.js:
• test262/test/intl402/Locale/prototype/minimize/length.js: Copied from JSTests/test262/test/intl402/Locale/prototype/maximize/length.js.
• test262/test/intl402/Locale/prototype/minimize/name.js: Added.
• test262/test/intl402/Locale/prototype/minimize/prop-desc.js: Copied from JSTests/test262/test/intl402/Locale/prototype/constructor.js.
• test262/test/intl402/Locale/prototype/numberingSystem/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/numeric/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/region/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/script/prop-desc.js: Added.
• test262/test/intl402/Locale/prototype/toString/prop-desc.js: Renamed from JSTests/test262/test/intl402/Locale/prototype/constructor.js.
• test262/test/intl402/Locale/prototype/toStringTag/toStringTag.js: Renamed from JSTests/test262/test/intl402/Locale/prototype/toStringTag.js.
• test262/test/intl402/Number/prototype/toLocaleString/length.js:
• test262/test/intl402/NumberFormat/length.js:
• test262/test/intl402/NumberFormat/name.js:
• test262/test/intl402/NumberFormat/prop-desc.js:
• test262/test/intl402/PluralRules/length.js:
• test262/test/intl402/PluralRules/name.js:
• test262/test/intl402/PluralRules/prop-desc.js: Copied from JSTests/test262/test/intl402/NumberFormat/prop-desc.js.
• test262/test/language/expressions/addition/bigint-and-number.js:
• test262/test/language/expressions/addition/bigint-arithmetic.js:

(testAdd): Deleted.

• test262/test/language/expressions/addition/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/addition/bigint-toprimitive.js:
• test262/test/language/expressions/addition/bigint-wrapped-values.js:
• test262/test/language/expressions/bitwise-and/bigint-and-number.js:
• test262/test/language/expressions/bitwise-and/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/bitwise-and/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.0b011n.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.0b011n.valueOf):
(assert.sameValue.toString):
(assert.sameValue.0b011n.toString):

• test262/test/language/expressions/bitwise-and/bigint-toprimitive.js:
• test262/test/language/expressions/bitwise-and/bigint-wrapped-values.js:
• test262/test/language/expressions/bitwise-not/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.toString):

• test262/test/language/expressions/bitwise-or/bigint-and-number.js:
• test262/test/language/expressions/bitwise-or/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/bitwise-or/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.0b011n.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.0b011n.valueOf):
(assert.sameValue.toString):
(assert.sameValue.0b011n.toString):

• test262/test/language/expressions/bitwise-or/bigint-toprimitive.js:
• test262/test/language/expressions/bitwise-or/bigint-wrapped-values.js:
• test262/test/language/expressions/bitwise-xor/bigint-and-number.js:
• test262/test/language/expressions/bitwise-xor/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/bitwise-xor/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.0b011n.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.0b011n.valueOf):
(assert.sameValue.toString):
(assert.sameValue.0b011n.toString):

• test262/test/language/expressions/bitwise-xor/bigint-toprimitive.js:
• test262/test/language/expressions/bitwise-xor/bigint-wrapped-values.js:
• test262/test/language/expressions/division/bigint-and-number.js:
• test262/test/language/expressions/division/bigint-arithmetic.js:

(testDiv): Deleted.

• test262/test/language/expressions/division/bigint-complex-infinity.js:
• test262/test/language/expressions/division/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/division/bigint-toprimitive.js:
• test262/test/language/expressions/division/bigint-wrapped-values.js:
• test262/test/language/expressions/does-not-equals/bigint-and-bigint.js:
• test262/test/language/expressions/does-not-equals/bigint-and-boolean.js:
• test262/test/language/expressions/does-not-equals/bigint-and-incomparable-primitive.js:
• test262/test/language/expressions/does-not-equals/bigint-and-non-finite.js:
• test262/test/language/expressions/does-not-equals/bigint-and-number-extremes.js:
• test262/test/language/expressions/does-not-equals/bigint-and-number.js:
• test262/test/language/expressions/does-not-equals/bigint-and-object.js:

(assert.sameValue.0n.valueOf):
(assert.sameValue.valueOf):
(assert.sameValue.0n.toString):
(assert.sameValue.toString):
(assert.sameValue.900719925474099101n.valueOf):
(assert.sameValue.900719925474099101n.toString):

• test262/test/language/expressions/does-not-equals/bigint-and-string.js:
• test262/test/language/expressions/equals/bigint-and-bigint.js:
• test262/test/language/expressions/equals/bigint-and-boolean.js:
• test262/test/language/expressions/equals/bigint-and-incomparable-primitive.js:
• test262/test/language/expressions/equals/bigint-and-non-finite.js:
• test262/test/language/expressions/equals/bigint-and-number-extremes.js:
• test262/test/language/expressions/equals/bigint-and-number.js:
• test262/test/language/expressions/equals/bigint-and-object.js:

(assert.sameValue.0n.valueOf):
(assert.sameValue.valueOf):
(assert.sameValue.0n.toString):
(assert.sameValue.toString):
(assert.sameValue.900719925474099101n.valueOf):
(assert.sameValue.900719925474099101n.toString):

• test262/test/language/expressions/equals/bigint-and-string.js:
• test262/test/language/expressions/exponentiation/bigint-and-number.js:
• test262/test/language/expressions/exponentiation/bigint-arithmetic.js:

(testExpt): Deleted.

• test262/test/language/expressions/exponentiation/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/exponentiation/bigint-negative-exponent-throws.js: Renamed from JSTests/test262/test/language/expressions/exponentiation/bigint-exp-operator-negative-throws.js.
• test262/test/language/expressions/exponentiation/bigint-toprimitive.js:
• test262/test/language/expressions/exponentiation/bigint-wrapped-values.js:
• test262/test/language/expressions/exponentiation/bigint-zero-base-zero-exponent.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-bigint.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-incomparable-string.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-non-finite.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-number-extremes.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-number.js:
• test262/test/language/expressions/greater-than-or-equal/bigint-and-string.js:
• test262/test/language/expressions/greater-than/11.8.2-1.js:

(obj1.valueOf):
(obj2.valueOf):

• test262/test/language/expressions/greater-than/11.8.2-2.js:

(obj1.valueOf):
(obj2.toString):

• test262/test/language/expressions/greater-than/11.8.2-3.js:

(obj1.toString):
(obj2.valueOf):

• test262/test/language/expressions/greater-than/11.8.2-4.js:

(obj1.toString):
(obj2.toString):

• test262/test/language/expressions/greater-than/bigint-and-bigint.js:
• test262/test/language/expressions/greater-than/bigint-and-boolean.js:
• test262/test/language/expressions/greater-than/bigint-and-incomparable-string.js:
• test262/test/language/expressions/greater-than/bigint-and-non-finite.js:
• test262/test/language/expressions/greater-than/bigint-and-number-extremes.js:
• test262/test/language/expressions/greater-than/bigint-and-number.js:
• test262/test/language/expressions/greater-than/bigint-and-string.js:
• test262/test/language/expressions/greater-than/bigint-and-symbol.js: Added.
• test262/test/language/expressions/left-shift/bigint-and-number.js:
• test262/test/language/expressions/left-shift/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/left-shift/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.toString):
(assert.sameValue.0b101n.Symbol.toPrimitive):
(assert.sameValue.0b101n.valueOf):
(assert.sameValue.0b101n.toString):
(valueOf):

• test262/test/language/expressions/left-shift/bigint-toprimitive.js:
• test262/test/language/expressions/left-shift/bigint-wrapped-values.js:
• test262/test/language/expressions/less-than-or-equal/11.8.3-1.js:

(obj1.valueOf):
(obj2.valueOf):

• test262/test/language/expressions/less-than-or-equal/11.8.3-2.js:

(obj1.valueOf):
(obj2.toString):

• test262/test/language/expressions/less-than-or-equal/11.8.3-3.js:

(obj1.toString):
(obj2.valueOf):

• test262/test/language/expressions/less-than-or-equal/11.8.3-4.js:

(obj1.toString):
(obj2.toString):

• test262/test/language/expressions/less-than-or-equal/11.8.3-5.js: Removed.
• test262/test/language/expressions/less-than-or-equal/bigint-and-bigint.js:
• test262/test/language/expressions/less-than-or-equal/bigint-and-incomparable-string.js:
• test262/test/language/expressions/less-than-or-equal/bigint-and-non-finite.js:
• test262/test/language/expressions/less-than-or-equal/bigint-and-number-extremes.js:
• test262/test/language/expressions/less-than-or-equal/bigint-and-number.js:
• test262/test/language/expressions/less-than-or-equal/bigint-and-string.js:
• test262/test/language/expressions/less-than/bigint-and-bigint.js:
• test262/test/language/expressions/less-than/bigint-and-boolean.js:
• test262/test/language/expressions/less-than/bigint-and-incomparable-string.js:
• test262/test/language/expressions/less-than/bigint-and-non-finite.js:
• test262/test/language/expressions/less-than/bigint-and-number-extremes.js:
• test262/test/language/expressions/less-than/bigint-and-number.js:
• test262/test/language/expressions/less-than/bigint-and-string.js:
• test262/test/language/expressions/less-than/bigint-and-symbol.js: Added.
• test262/test/language/expressions/modulus/bigint-and-number.js:
• test262/test/language/expressions/modulus/bigint-arithmetic.js:

(testMod): Deleted.

• test262/test/language/expressions/modulus/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/modulus/bigint-modulo-zero.js:
• test262/test/language/expressions/modulus/bigint-toprimitive.js:
• test262/test/language/expressions/modulus/bigint-wrapped-values.js:
• test262/test/language/expressions/multiplication/bigint-and-number.js:
• test262/test/language/expressions/multiplication/bigint-arithmetic.js:

(testMul): Deleted.

• test262/test/language/expressions/multiplication/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/multiplication/bigint-toprimitive.js:
• test262/test/language/expressions/multiplication/bigint-wrapped-values.js:
• test262/test/language/expressions/right-shift/bigint-and-number.js:
• test262/test/language/expressions/right-shift/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/right-shift/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.toString):
(assert.sameValue.0b101n.Symbol.toPrimitive):
(assert.sameValue.0b101n.valueOf):
(assert.sameValue.0b101n.toString):
(valueOf):

• test262/test/language/expressions/right-shift/bigint-toprimitive.js:
• test262/test/language/expressions/right-shift/bigint-wrapped-values.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-bigint.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-boolean.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-incomparable-primitive.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-non-finite.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-number-extremes.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-number.js:
• test262/test/language/expressions/strict-does-not-equals/bigint-and-object.js:

(assert.sameValue.0n.valueOf):
(assert.sameValue.valueOf):
(assert.sameValue.0n.toString):
(assert.sameValue.toString):
(assert.sameValue.900719925474099101n.valueOf):
(assert.sameValue.900719925474099101n.toString):

• test262/test/language/expressions/strict-does-not-equals/bigint-and-string.js:
• test262/test/language/expressions/strict-equals/bigint-and-bigint.js:
• test262/test/language/expressions/strict-equals/bigint-and-boolean.js:
• test262/test/language/expressions/strict-equals/bigint-and-incomparable-primitive.js:
• test262/test/language/expressions/strict-equals/bigint-and-non-finite.js:
• test262/test/language/expressions/strict-equals/bigint-and-number-extremes.js:
• test262/test/language/expressions/strict-equals/bigint-and-number.js:
• test262/test/language/expressions/strict-equals/bigint-and-object.js:

(assert.sameValue.0n.valueOf):
(assert.sameValue.valueOf):
(assert.sameValue.0n.toString):
(assert.sameValue.toString):
(assert.sameValue.900719925474099101n.valueOf):
(assert.sameValue.900719925474099101n.toString):

• test262/test/language/expressions/strict-equals/bigint-and-string.js:
• test262/test/language/expressions/subtraction/bigint-and-number.js:
• test262/test/language/expressions/subtraction/bigint-arithmetic.js:

(testSub): Deleted.

• test262/test/language/expressions/subtraction/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/subtraction/bigint-toprimitive.js:
• test262/test/language/expressions/subtraction/bigint-wrapped-values.js:
• test262/test/language/expressions/unary-minus/bigint-non-primitive.js:

(assert.sameValue.Symbol.toPrimitive):
(assert.sameValue.valueOf):
(assert.sameValue.toString):

• test262/test/language/expressions/unary-plus/bigint-throws.js:
• test262/test/language/expressions/unsigned-right-shift/bigint-and-number.js:
• test262/test/language/expressions/unsigned-right-shift/bigint-errors.js:

(Symbol.toPrimitive):
(0n.Symbol.toPrimitive):
(valueOf):
(0n.valueOf):
(toString):
(0n.toString):

• test262/test/language/expressions/unsigned-right-shift/bigint-non-primitive.js:

(Symbol.toPrimitive):
(valueOf):
(toString):
(0b101n.Symbol.toPrimitive):
(0b101n.valueOf):
(0b101n.toString):
(valueOf.valueOf):

• test262/test/language/expressions/unsigned-right-shift/bigint-toprimitive.js:
• test262/test/language/expressions/unsigned-right-shift/bigint-wrapped-values.js:
• test262/test/language/literals/numeric/numeric-followed-by-ident.js: Added.
• test262/test/language/literals/string/line-continuation-double.js: Added.
• test262/test/language/literals/string/line-continuation-single.js: Added.
• test262/test262-Revision.txt: