Timeline

Jun 13, 2018:

11:39 PM Changeset in webkit [232832] by Adrian Perez de Castro

• 10 edits in trunk

[WPE] Trying to access the remote inspector hits an assertion in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=186588

Reviewed by Carlos Garcia Campos.

Make both the WPE and GTK+ ports use /org/webkit/inspector as base prefix
for resource paths, which avoids needing a switcheroo depending on the port.

Source/JavaScriptCore:

• inspector/remote/glib/RemoteInspectorUtils.cpp:

Source/WebKit:

• UIProcess/API/wpe/WebKit2InspectorGResourceBundle.xml:
• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

• UIProcess/wpe/WebInspectorProxyWPE.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

• WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::localizedStringsURL):
(WebKit::RemoteWebInspectorUI::localizedStringsURL):

Tools:

• WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::inspectorTestStubURL):

• glib/generate-inspector-gresource-manifest.py:

11:09 PM Changeset in webkit [232831] by Carlos Garcia Campos

• 7 edits
  5 adds in releases/WebKitGTK/webkit-2.20

Merge r230662 - Function.prototype.caller shouldn't return generator bodies
​https://bugs.webkit.org/show_bug.cgi?id=184630

Reviewed by Yusuke Suzuki.
JSTests:

• stress/function-caller-async-arrow-function-body.js: Added.
• stress/function-caller-async-function-body.js: Added.
• stress/function-caller-async-generator-body.js: Added.
• stress/function-caller-generator-body.js: Added.
• stress/function-caller-generator-method-body.js: Added.

Source/JavaScriptCore:

Function.prototype.caller no longer returns generator bodies. Those are meant to be
private.

Also added some builtin debugging tools so that it's easier to do the investigation that I
did.

• builtins/BuiltinNames.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::callerGetter):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncBuiltinDescribe):

• runtime/JSGlobalObjectFunctions.h:

9:56 PM Changeset in webkit [232830] by Kocsen Chung

• 8 edits in tags/Safari-606.1.21

Revert r231850. rdar://problem/41113111

9:56 PM Changeset in webkit [232829] by Kocsen Chung

• 1 edit in tags/Safari-606.1.21/Tools/ChangeLog

Revert r231999. rdar://problem/41113111

9:56 PM Changeset in webkit [232828] by Kocsen Chung

• 8 edits in tags/Safari-606.1.21/Source

Revert r232741. rdar://problem/41108295

9:14 PM Changeset in webkit [232827] by youenn@apple.com

• 5 edits in trunk/Source/ThirdParty/libwebrtc

Eliminate static initializers in libwebrtc.dylib
​https://bugs.webkit.org/show_bug.cgi?id=186570

Reviewed by Darin Adler.

• Source/webrtc/rtc_base/flags.h: Changed macro to create the static into a function.
• Source/webrtc/rtc_base/logging.cc: Ditto.

Made sure that the scope is created on instantiation of the first Log instance that might use it.

• Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:
• Source/webrtc/system_wrappers/source/runtime_enabled_features_default.cc:

7:51 PM Changeset in webkit [232826] by bshafiei@apple.com

• 7 edits in branches/safari-606.1.20.40-branch/Source

Versioning.

7:39 PM Changeset in webkit [232825] by bshafiei@apple.com

• 1 copy in tags/Safari-606.1.20.40.2

Tag Safari-606.1.20.40.2.

7:31 PM Changeset in webkit [232824] by Chris Dumez

• 9 edits in trunk/Source

Crash under SWServer::unregisterConnection(Connection&)
​https://bugs.webkit.org/show_bug.cgi?id=186584
<rdar://problem/40931680>

Reviewed by Youenn Fablet.

Source/WebCore:

The crash was due to SWServer::Connection objects outliving their SWServer, even
though SWServer::Connection::m_server is a C++ reference. This was possible because
SWServer does not own the connections, StorageToWebProcessConnection does. This
started crashing recently, after r232423, because SWServer can get destroyed now.
The SWServer might get destroyed before the StorageToWebProcessConnection, in which
case the SWServer::Connection objects will get destroyed later. We were crashing
because the SWServer::Connection destructor tries to unregister the connection from
the SWServer (which is dead).

To address the issue, the SWServer now owns the connections. StorageToWebProcessConnection
merely has weak pointers to the connections.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::addConnection):
(WebCore::SWServer::removeConnection):
(WebCore::SWServer::resolveRegistrationReadyRequests):

• workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::~Connection):
(WebCore::SWServer::Connection::server):
(WebCore::SWServer::connection):

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::forEachConnection):
(WebCore::SWServerRegistration::notifyClientsOfControllerChange):
(WebCore::SWServerRegistration::controlClient):

Source/WebKit:

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection):
(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didReceiveSyncMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::unregisterSWConnections):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):

• StorageProcess/StorageToWebProcessConnection.h:

6:36 PM Changeset in webkit [232823] by Alan Bujtas

• 6 edits
  2 adds in trunk

[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
​https://bugs.webkit.org/show_bug.cgi?id=186585
<rdar://problem/30685325>

Reviewed by Tim Horton.

Source/WebCore:

Use the existing "override viewport size for viewport units" mechanism to compute the preferred
viewport unit values for the Mail Viewer html content.

Test: fast/dynamic/mail-autosize-viewport-unit.html

• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
(WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
(WebCore::FrameView::viewportSizeForCSSViewportUnits const):

• page/FrameView.h:

LayoutTests:

• fast/dynamic/mail-autosize-viewport-unit-expected.txt: Added.
• fast/dynamic/mail-autosize-viewport-unit.html: Added.

6:23 PM Changeset in webkit [232822] by Kocsen Chung

• 8 edits in branches/safari-606.1.20.40-branch

Revert r231850. rdar://problem/39111626

6:23 PM Changeset in webkit [232821] by Kocsen Chung

• 1 edit in branches/safari-606.1.20.40-branch/Tools/ChangeLog

Revert r231999. rdar://problem/39111626

6:04 PM Changeset in webkit [232820] by clopez@igalia.com

• 2 edits
  7 adds in trunk/Tools

[GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
​https://bugs.webkit.org/show_bug.cgi?id=166885

Reviewed by Michael Catanzaro.

This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.

It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.

• BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunBenchmarkTests):

• Scripts/browserperfdash-benchmark: Added.
• Scripts/webkitpy/browserperfdash/README: Added.
• Scripts/webkitpy/browserperfdash/init.py: Added.
• Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.

(parse_args):
(BrowserPerfDashRunner):
(BrowserPerfDashRunner.init):
(BrowserPerfDashRunner._parse_config_file):
(BrowserPerfDashRunner._get_test_version_string):
(BrowserPerfDashRunner._get_test_data_json_string):
(BrowserPerfDashRunner._upload_result):
(BrowserPerfDashRunner.run):
(format_logger):
(main):

• Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.

(FakeBenchmarkRunner):
(FakeBenchmarkRunner.init):
(FakeBenchmarkRunner.execute):
(BrowserPerfDashRunnerTest):
(BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
(BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
(BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):

• Scripts/webkitpy/browserperfdash/config-file-example.txt: Added.

4:46 PM Changeset in webkit [232819] by Kocsen Chung

• 8 edits in branches/safari-606.1.20.20-branch

Revert r231850. rdar://problem/39111626

4:46 PM Changeset in webkit [232818] by Kocsen Chung

• 1 edit in branches/safari-606.1.20.20-branch/Tools/ChangeLog

Revert r231999. rdar://problem/39111626

4:20 PM Changeset in webkit [232817] by dino@apple.com

• 14 edits in trunk

Disable AR support in WKWebView clients
​https://bugs.webkit.org/show_bug.cgi?id=186611
<rdar://problem/39544684>

Reviewed by Jon Lee.

Since it hasn't been adequately tested, System Preview (AR) should
be disabled by default for WKWebViews.

Source/WebCore:

Add a new RuntimeEnabledFeature to control this, and guard for
this case everywhere we use system previews.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isSystemPreviewLink const):
(WebCore::HTMLAnchorElement::handleClick):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isSystemPreviewImage const):

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::isSystemPreviewImage const):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled):
(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

Source/WebKit:

Add a new WebPreference, and SPI into WKWebViewConfiguration. Also
don't register the WebViewContentProvider if the feature is
disabled.

• Shared/WebPreferences.yaml:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _contentProviderRegistry]):
(-[WKWebViewConfiguration _systemPreviewEnabled]):
(-[WKWebViewConfiguration _setSystemPreviewEnabled:]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/Cocoa/WKWebViewContentProviderRegistry.h:
• UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry initWithConfiguration:]):
(-[WKWebViewContentProviderRegistry init]): Deleted.

3:51 PM Changeset in webkit [232816] by caitp@igalia.com

• 8 edits in trunk/Source/JavaScriptCore

[LLInt] use loadp consistently for get_from_scope/put_to_scope
​https://bugs.webkit.org/show_bug.cgi?id=132333

Reviewed by Mark Lam.

Using loadis for register indexes and loadp for constant scopes /
symboltables makes sense, but is problematic for big-endian
architectures.

Consistently treating the operand as a pointer simplifies determining
how to access the operand, and helps avoid bad accesses and crashes on
big-endian ports.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

• bytecode/Instruction.h:
• jit/JITOperations.cpp:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):

3:22 PM Changeset in webkit [232815] by youenn@apple.com

• 19 edits in trunk/Source

Supported plugin check should be based on plugin identifier
​https://bugs.webkit.org/show_bug.cgi?id=186578
<rdar://problem/40523828>

Reviewed by Darin Adler.

Source/WebCore:

Rename SupportedPluginName in SupportedPluginIdentifier.
Add cross-platform support for plug-in identifier.

Update built-in PDF plug-in to check its identifier instead of its name.
This is stronger as the name may change according localization.

• loader/EmptyClients.cpp:
• plugins/PluginData.cpp:

(WebCore::isBuiltInPDFPlugIn):
(WebCore::PluginData::initPlugins):

• plugins/PluginData.h:

(WebCore::operator==):
(WebCore::isSupportedPlugin):
(WebCore::SupportedPluginIdentifier::decode):
(WebCore::SupportedPluginIdentifier::encode const):
(WebCore::SupportedPluginName::decode): Deleted.
(WebCore::SupportedPluginName::encode const): Deleted.

• plugins/PluginInfoProvider.h:

Source/WebKit:

Refactoring to move from Plugin name to Plugin identifier.
Set built-in pdf plugin identifier.
This allows making sure that the PDF plug-in check might not change according localization.

• Scripts/webkit/messages.py:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PluginInfo>::encode):
(IPC::ArgumentCoder<PluginInfo>::decode):

• UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::supportedPluginIdentifiers):
(WebKit::PluginInfoStore::addSupportedPlugin):
(WebKit::PluginInfoStore::supportedPluginNames): Deleted.

• UIProcess/Plugins/PluginInfoStore.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pluginInfo):

• WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::webVisiblePluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):

• WebProcess/Plugins/WebPluginInfoProvider.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebPluginInfoProvider.h:
• WebCoreSupport/WebPluginInfoProvider.mm:

(WebPluginInfoProvider::pluginInfo):
(WebPluginInfoProvider::webVisiblePluginInfo):

3:16 PM Changeset in webkit [232814] by Chris Dumez

• 29 edits in trunk

PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
​https://bugs.webkit.org/show_bug.cgi?id=186545

Reviewed by Brady Eidson.

Source/WebCore:

Move frame navigation logging for ITP purposes from the WebProcess to the UIProcess.
This information was previously logged in DocumentLoader::willSendRequest() and was getting
sync'd to the UIProcess at regular intervals or when the layout tests call testRunner's
statisticsNotifyObserver(). We now do the logging directly in the UIProcess, in
WebPageProxy::decidePolicyForNavigationAction (which was getting called via IPC from
DocumentLoader::willSendRequest()).

This is more efficient and will also be needed soon due to the way process swap on navigation
deals with cross-origin redirects. On cross-origin redirect of the main frame, PSON cancels
the load and started a new load to the redirected to URL in the new WebProcess. As a result,
the new WebProcess is not aware that the load is a redirect, which is information that ITP
requires. By moving the ITP logging to the UIProcess, we still have access to this
information.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):
Stop logging the navigation now that it is logged in the UIProcess.

• loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):

• loader/FrameLoaderClient.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/PolicyChecker.h:

We now pass the full redirect request to the decidePolicyForNavigationAction
delegate instead of a simple isRedirect boolean, so that we have the redirect
response URL in the UIProcess for ITP logging.

• loader/ResourceLoadObserver.cpp:

(WebCore::areDomainsAssociated):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

• loader/ResourceLoadObserver.h:
• loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::areDomainsAssociated):
(WebCore::ResourceLoadStatistics::reduceTimeResolution):

• loader/ResourceLoadStatistics.h:
• Remove ResourceLoadObserver::logFrameNavigation() now that it is on the WebResourceLoadStatisticsStore.
• Move some code from ResourceLoadObserver to ResourceLoadStatistics so that it can be called from the UIProcess and to avoid code duplication.

Source/WebKit:

Move frame navigation logging for ITP purposes from the WebProcess to the UIProcess.
This information was previously logged in DocumentLoader::willSendRequest() and was getting
sync'd to the UIProcess at regular intervals or when the layout tests call testRunner's
statisticsNotifyObserver(). We now do the logging directly in the UIProcess, in
WebPageProxy::decidePolicyForNavigationAction (which was getting called via IPC from
DocumentLoader::willSendRequest()).

This is more efficient and will also be needed soon due to the way process swap on navigation
deals with cross-origin redirects. On cross-origin redirect of the main frame, PSON cancels
the load and started a new load to the redirected to URL in the new WebProcess. As a result,
the new WebProcess is not aware that the load is a redirect, which is information that ITP
requires. By moving the ITP logging to the UIProcess, we still have access to this
information.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• We now pass the full redirect response the the delegate method instead of a simple

isRedirect boolean.

• Log the navigation in the WebResourceLoadStatisticsStore for ITP purposes.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::areDomainsAssociated):
Equivalent of ResourceLoadObserver's areDomainsAssociated(). Most of the logic was moved
to ResourceLoadStatistics::areDomainsAssociated() to avoid code duplication.

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
This is called whenever a WebProcess sends new resource load statistics to the UIProcess.
Whenever this happens, we call processStatisticsAndDataRecords() right away, which is
sometimes the tests currently rely on. As a result, we can cancels any pending statistics
processing request that was scheduled by logFrameNavigation().

(WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsProcessingRequestIfNecessary):
(WebKit::WebResourceLoadStatisticsStore::cancelPendingStatisticsProcessingRequest):
Whenever a navigation is logged and statistics have been updated, we need to make sure we
schedule a "timer" to process the new data. We do this at most every 5 seconds for performance
reasons. This 5 second interval matches what the ResourceLoadObserver is using in the WebProcess
to notify the UIProcess of new data.

(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
This code was moved from ResourceLoadObserver to WebResourceLoadStatisticsStore now that we
do this logging in the UIProcess instead of the WebProcess. One difference with WebCore is
that we use WebPageProxy::pageLoadState().url() as mainFrameURL instead of
WebPageProxy::mainFrame().url(). The reason for that is that WebPageProxy::mainFrame().url()
becomes empty in case of process swap but ITP still needs the actual main frame URL when the
navigation was triggered. WebPageProxy::pageLoadState().url() gives us this information.

• UIProcess/WebResourceLoadStatisticsStore.h:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

We now pass the full redirect response the the delegate method instead of a simple
isRedirect boolean.

Source/WebKitLegacy/mac:

Update client delegate now that parameter type has changed.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

Update client delegate now that parameter type has changed.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Attempt to mark the test as non-flaky now that it no longer relies on sync'ing from the WebProcess
to the UIProcess.

• platform/wk2/TestExpectations:

2:54 PM Changeset in webkit [232813] by david_fenton@apple.com

• 2 edits in trunk/Tools

Unreviewed, add myself as a WebKit committer.

• Scripts/webkitpy/common/config/contributors.json:

2:48 PM Changeset in webkit [232812] by Ryan Haddad

• 2 edits in trunk/LayoutTests

[macOS Debug WK1] LayoutTest fast/parser/xml-error-adopted.xml is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=186581

Unreviewed test gardening.

Patch by David Fenton <​david_fenton@apple.com> on 2018-06-13

• platform/mac-wk1/TestExpectations:

2:26 PM Changeset in webkit [232811] by Nikita Vasilyev

• 2 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: open source Dark Mode
​https://bugs.webkit.org/show_bug.cgi?id=186606

Reviewed by Timothy Hatcher.

The dark mode is currently only available on macOS Mojave via prefers-dark-interface CSS media query.

• UserInterface/Main.html:
• UserInterface/Views/DarkMode.css: Added.

(@media (prefers-dark-interface)):
(:root):
(body.window-inactive):
(body.window-inactive *):
(#main):
(.tree-outline.dom li.selected .selection-area):
(.tab-bar > .item > .icon):
(.go-to-arrow):
(.resource-link,):
(.expand-list-button):
(:matches(img, canvas).show-grid):
(.formatted-object,):
(.formatted-null,):
(.editing):
(.editing, .editing *):
(.text-editor > .CodeMirror .execution-line):
(.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext),):
(.details-section > .header):
(.details-section > .header > label):
(.details-section .details-section,):
(.details-section .details-section:not(.collapsed) > .header):
(.details-section > .content > .group > .row.simple > .label):
(.details-section > .content > .group:nth-child(even)):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(.data-grid th):
(.data-grid td .subtitle):
(.data-grid:matches(:focus, .force-focus) tr.selected td .subtitle):
(body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):
(.data-grid tr.editable .cell-content > input):
(.data-grid td.spanning):
(.object-tree,):
(.object-preview .name):
(.object-preview > .size):
(.tab-bar):
(.tab-bar > .item):
(.tab-bar > .item > .title):
(.tab-bar > .item:not(.disabled).selected):
(.tab-bar:not(.animating) > .item:not(.selected):hover):
(.tab-bar > .item > .close):
(body.window-inactive .tab-bar):
(body.window-inactive .tab-bar > .item):
(body.window-inactive .tab-bar > .item.selected):
(body.window-inactive .tab-bar > .item > .title):
(body .toolbar):
(body.window-inactive .toolbar):
(body.latest-mac .toolbar .item.button,):
(body.latest-mac .toolbar .search-bar > input[type="search"]):
(body.latest-mac .toolbar .search-bar > input[type="search"]:focus):
(body.latest-mac .toolbar .search-bar > input[type="search"]::placeholder):
(body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::placeholder):
(body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::-webkit-search-results-button):
(body.latest-mac .toolbar .dashboard-container):
(body.latest-mac .toolbar .item.button:active):
(body.latest-mac.window-inactive .toolbar .item.button,):
(.navigation-bar .item.divider):
(.toolbar .item.button):
(.toolbar .item.button:not(.disabled):active):
(.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated)):
(.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated)):
(.toolbar .dashboard.default > .item > div):
(.toolbar .dashboard.default > .item.enabled > div):
(.toolbar .dashboard.default > .item.enabled:hover):
(.toolbar .dashboard.default > .item.enabled:hover > div):
(.toolbar .dashboard.default > .resourcesCount > img,):
(body.latest-mac .toolbar .dashboard .item.button):
(.dashboard-container .advance-arrow):
(.toolbar .dashboard.debugger):
(.dashboard.debugger .navigation-bar .item.button > .glyph):
(.dashboard.debugger > .location .function-name):
(.dashboard.debugger > .location .go-to-link):
(.dashboard.debugger > .divider):
(.popover .edit-breakpoint-popover-content > label.toggle):
(.popover .edit-breakpoint-popover-content > table > tr > th):
(.breakpoint-action-block-body):
(.breakpoint-action-block-body > .description):
(.breakpoint-action-append-button,):
(.popover .xhr-breakpoint-content > .editor-wrapper > .editor):
(.navigation-bar .item.button):
(.spreadsheet-style-declaration-editor .property:not(.disabled) .value):
(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration .selector:focus,):
(.spreadsheet-css-declaration.locked .origin::after):
(.spreadsheet-css-declaration .origin .go-to-link,):
(.spreadsheet-style-declaration-editor :matches(.name, .value).editing):
(.spreadsheet-style-declaration-editor .property.has-warning):
(.spreadsheet-style-declaration-editor .property.has-warning .warning):
(.spreadsheet-css-declaration .media-label):
(.quick-console):
(.syntax-highlighted,):
(.cm-s-default,):
(.CodeMirror .jump-to-symbol-highlight,):
(.console-prompt):
(.completion-suggestions):
(.completion-suggestions-container > .item):
(.CodeMirror-cursor):
(.CodeMirror .CodeMirror-gutters):
(.cm-s-default .cm-link):
(.cm-s-default .cm-m-xml.cm-attribute,):
(.cm-s-default .cm-meta):
(.cm-s-default .cm-variable-3):
(.cm-s-default .cm-builtin):
(.tree-outline .item .subtitle):
(.object-tree-property .getter,):
(.item.object-tree-property.prototype-property):
(.object-tree-property.prototype-property:hover,):
(.object-tree-property .value.error):
(.tree-outline.dom):
(.tree-outline.dom li.selected + ol.children.expanded):
(.tree-outline.dom .shadow):
(.tree-outline.dom li.parent.shadow + ol.children.expanded,):
(.showing-find-banner .tree-outline.dom .search-highlight):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter:hover):
(.sidebar > .panel.details.css-style > .content > .pseudo-classes > .group > label):
(.spreadsheet-css-declaration.locked):
(.spreadsheet-css-declaration .selector.style-attribute):
(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) .content > *):
(.inline-swatch):
(.spreadsheet-style-panel .section-header):
(.spreadsheet-style-panel .section-header .node-link:hover):
(.computed-style-properties.details-section):
(.details-section.style-box-model:not(.collapsed) > :matches(.header, .content)):
(.table,):
(.table > .header > .sortable:active):
(.table > .header > :matches(.sort-ascending, .sort-descending)):
(.table > .header > :matches(.sort-ascending, .sort-descending)::after):
(.scope-bar > li):
(.timeline-overview > .navigation-bar.timelines):
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),):
(.time-icon .icon):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple):
(.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple .arrows):
(.content-view.settings .navigation-bar):
(.content-view.settings .navigation-bar .item.radio.button.text-only.selected):
(.new-tab.tab.content-view):
(.filter-bar > input[type="search"]):
(.filter-bar > input[type="search"]::placeholder):
(.filter-bar > input[type="search"]:focus):
(.content-view.resource.image):
(.console-messages):
(.console-item):
(.console-messages:focus .console-item.selected):
(.console-messages:focus .console-item.selected + .console-item):
(.console-session:first-of-type .console-session-header):
(.console-session:not(:first-of-type) .console-session-header):
(.console-messages a):
(.console-messages a:hover):
(.console-messages:focus .console-item.selected::after):
(.console-error-level):
(.console-error-level:not(.filtered-out, .filtered-out-by-search), .console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
(.console-warning-level):
(.console-warning-level:not(.filtered-out, .filtered-out-by-search), .console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted):
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
(.source-code.text-editor > .CodeMirror .error):
(.source-code.text-editor > .CodeMirror .warning):
(.source-code.text-editor > .CodeMirror .issue-widget):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning > .arrow):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error > .arrow):
(.console-message .syntax-highlighted):
(.console-warning-level .console-message-text):
(.console-error-level .console-message-text):
(.console-user-command > .console-message-text):
(.console-message .repeat-count):
(.call-frame .subtitle,):
(.call-frame:hover .subtitle .source-link,):
(.call-frame .separator):
(.quick-console.showing-log):
(.find-banner.console-find-banner > input[type=search]:not(:placeholder-shown)):
(.network-resource-detail):
(.network-resource-detail .item.close > .glyph):
(.network .network-resource-detail .navigation-bar .item.radio.button.text-only.selected):
(.resource-headers .value):
(.network-table .cell.domain > .lock):
(.resource-sizes > .content .label):
(.popover.waterfall-popover):
(.resource-timing-breakdown > table > tr.header:not(.total-row) > td):
(.resource-timing-breakdown > table > tr > td.label,):
(.resource-timing-breakdown > table hr):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):
(.content-view.tab.canvas .navigation-bar > .item .canvas-overview .icon):
(.web-socket.content-view .data-grid table.data tr.revealed):
(.web-socket.content-view .data-grid.variable-height-rows table.data tr.outgoing):
(.web-socket.content-view .data-grid.variable-height-rows table.data tr.non-text-frame):
(.item.action:not(.initial-state)::before):
(.tree-outline .item.action.visual:not(.selected, .invalid)):
(.item.action:not(.initial-state) > .icon):
(.tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon):
(.content-view.tab.canvas .navigation-bar > .item .canvas-overview .icon,):
(.content-view.canvas > .preview > img,):
(.content-view.canvas-overview):
(.content-view.canvas-overview .content-view.canvas):
(.content-view.canvas-overview .content-view.canvas.is-recording):
(.content-view.canvas-overview .content-view.canvas.is-recording > header):
(.content-view.canvas-overview .content-view.canvas > header > .titles > .title):
(.content-view.canvas-overview .content-view.canvas > header > .titles > .subtitle,):
(.content-view.canvas-overview .content-view.canvas > footer > .recordings::before):
(.content-view.canvas-overview .content-view.canvas.is-recording > header > .titles > .subtitle):
(.content-view.canvas:not(.tab)):
(.content-view:not(.tab).recording):
(.content-view:not(.tab).recording > header > .slider-container):
(.content-view:not(.tab).recording > header > .slider-container > input[type=range]):
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified):
(.progress-view > .titles > .title):
(.progress-view > .titles > .subtitle):
(.indeterminate-progress-spinner):
(.content-view.shader-program > .text-editor.shader):
(.content-view.shader-program > .text-editor.shader > .type-title):
(.item.shader-program .status > img):
(.open-resource-dialog):
(.open-resource-dialog > .field > input):
(.open-resource-dialog > .field > input::placeholder):
(.open-resource-dialog > .tree-outline .item.selected):
(.open-resource-dialog > .field::before):

2:21 PM Changeset in webkit [232810] by mark.lam@apple.com

• 2 edits in trunk/LayoutTests

Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=186372

Not reviewed.

Speculative fix to green the bots plus improved the error message logging to get
more info if this fails again.

• js/error-should-not-strong-reference-global-object.html:

2:07 PM WebKitGTK/2.20.x edited by Michael Catanzaro

(diff)

1:57 PM Changeset in webkit [232809] by mark.lam@apple.com

• 3 edits in trunk/Source/WebCore

FloatingPointEnvironment is only needed for ARM CPUs.
​https://bugs.webkit.org/show_bug.cgi?id=186567
<rdar://problem/40929441>

Reviewed by Michael Saboff.

No new tests. This behavior is already covered by existing tests.

• platform/ios/wak/FloatingPointEnvironment.cpp:
• platform/ios/wak/FloatingPointEnvironment.h:

(WebCore::FloatingPointEnvironment::enableDenormalSupport):
(WebCore::FloatingPointEnvironment::saveMainThreadEnvironment):
(WebCore::FloatingPointEnvironment::propagateMainThreadEnvironment):
(WebCore::FloatingPointEnvironment::singleton):

1:47 PM Changeset in webkit [232808] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

Crash during interrupted process termination
​https://bugs.webkit.org/show_bug.cgi?id=185373
<rdar://problem/40019480>

Reviewed by Alex Christensen.

It's possible to encounter a crash if a user agent feature (such as Safari's responsiveness timer) decides
to kill a Web Process around the same time that a user decides to trigger a new page load. One of the two
termination operations may attempt to call methods on a nulled process pointer.

We can avoid this by holding our own reference to the terminating process until the termination steps have
been completed.

• UIProcess/API/C/WKPage.cpp:

(WKPageTerminate): Ref<> the active process while the termination call is performed.

• UIProcess/API/Cocoa/WKWebView.mm:

([WKWebView _killWebContentProcessAndResetState]): Ditto.

1:29 PM Changeset in webkit [232807] by BJ Burg

• 2 edits in trunk/Source/WebKit

[Cocoa] Web Automation: wrong modifiers sent for 'Help' virtual key
​https://bugs.webkit.org/show_bug.cgi?id=186600
<rdar://problem/41088912>

Reviewed by Timothy Hatcher.

This fixes a hang when running W3C test:

special_keys.py::test_webdriver_special_key_sends_keydown[HELP-expected2]

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::eventModifierFlagsForVirtualKey):
The help modifier doesn't seem to be used when pressing the Help key.
I verified this using the Help key on the Keyboard Viewer, since no
keyboards from the past decade actually have this physical button.

1:26 PM Changeset in webkit [232806] by timothy@apple.com

• 12 edits in trunk

Input form controls have a white background in dark mode, when they should not.

​https://bugs.webkit.org/show_bug.cgi?id=186577
rdar://problem/39258325

Reviewed by Tim Horton.

Source/WebCore:

• DerivedSources.make: Allow WTF_PLATFORM_MAC ifdefs to preprocess in html.css.
• css/CSSValueKeywords.in: Added -apple-system-control-background.
• css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent): Allow dark mode media query in user agent stylesheets.
(WebCore::isFeatureValidWithoutValue): Ditto.

• css/MediaQueryParserContext.cpp:

(WebCore::MediaQueryParserContext::MediaQueryParserContext): Transfer the CSSParserMode from CSSParserContext.

• css/MediaQueryParserContext.h:
• css/html.css: Set color and background-color to semantic colors for input, textarea, and select.

Make input background-color transparent in dark mode to match AppKit.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const): Added -apple-system-control-background.
(WebCore::RenderThemeMac::paintTextField): Adjust the drawing rect to match new artwork in macOS 10.14.

LayoutTests:

• fast/css/apple-system-control-colors-expected.txt: Updated.
• fast/css/apple-system-control-colors.html: Added -apple-system-control-background.
• platform/gtk/fast/css/apple-system-control-colors-expected.txt: Updated.

1:24 PM Changeset in webkit [232805] by wilander@apple.com

• 3 edits in trunk/LayoutTests

Add console logging to test case to help investigate flaky timeouts
​https://bugs.webkit.org/show_bug.cgi?id=186603
<rdar://problem/41096614>

Unreviewed test gardening.

• http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
• http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html:

Now has step-by-step console logging so that (hopefully) the flaky timeouts don't produce empty output.

1:01 PM Changeset in webkit [232804] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

12:59 PM Changeset in webkit [232803] by Kocsen Chung

• 1 copy in tags/Safari-606.1.21

Tag Safari-606.1.21.

12:10 PM Changeset in webkit [232802] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers
​https://bugs.webkit.org/show_bug.cgi?id=186336
<rdar://problem/40808099>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-06-13
Reviewed by Simon Fraser.

Source/WebCore:

When showing a composited RenderLayer for the first time, the images in
this layer have to be decoded synchronously to avoid unwanted flashing.

To create a layout test for this patch, FrameDecodingDurationForTesting
needs to be generalized for large and animated images. The decoding thread
now forces the decoding time to be at least equal to
FrameDecodingDurationForTesting.

Test: fast/images/async-image-composited-show.html

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImages const):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::advanceAnimation):

• platform/graphics/BitmapImage.h:
• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::startAsyncDecodingQueue):

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::setFrameDecodingDurationForTesting):
(WebCore::ImageSource::frameDecodingDurationForTesting const):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

• fast/images/async-image-composited-show-expected.html: Added.
• fast/images/async-image-composited-show.html: Added.

12:07 PM Changeset in webkit [232801] by keith_miller@apple.com

• 10 edits in trunk/Source

AutomaticThread should have a way to provide a thread name
​https://bugs.webkit.org/show_bug.cgi?id=186604

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add names for JSC's automatic threads.

• dfg/DFGWorklist.cpp:
• heap/Heap.cpp:
• jit/JITWorklist.cpp:
• runtime/VMTraps.cpp:
• wasm/WasmWorklist.cpp:

Source/WTF:

AutomaticThread now has a virtual method to get a name, which can be
overridden to provide a custom name to the thread.

• wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::start):

• wtf/AutomaticThread.h:
• wtf/WorkerPool.cpp:

12:04 PM Changeset in webkit [232800] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

CFGSimplificationPhase should de-dupe jettisonedBlocks
​https://bugs.webkit.org/show_bug.cgi?id=186583

Reviewed by Filip Pizlo.

When making the predecessors list unique in r232741, it revealed a bug inside
of CFG simplification, where we try to remove the same predecessor more than
once from a blocks predecessors list. We built the list of blocks to remove
from the list of successors, which is not unique, causing us to try to remove
the same predecessor more than once. The solution here is to just add to this
list of blocks to remove only if the block is not already in the list.

• dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

11:51 AM Changeset in webkit [232799] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

CSS "background-color" style no longer affects natively rendered text fields
​https://bugs.webkit.org/show_bug.cgi?id=186597
<rdar://problem/41050528>

Reviewed by Tim Horton.

AppKit currently does not support rendering background color to the edges of a text field cell. This means that
in WebCore, when natively rendering text inputs with background color, we need to only draw the bezels of a text
field, such that the background color we paint behind the text field will be shown. Currently, the way we
accomplish this is by intercepting an internal NSTextField method that computes drawing options for CoreUI, and
inserting a "borders only" => true entry.

However, in a recent build of macOS Mojave, AppKit tweaked -_coreUIDrawOptionsWithFrame:inView:includeFocus: to
add an extra argument (such that it's now -_coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:), which
negates the above workaround. To fix this in the short term, augment the workaround to apply to the latest macOS
Mojave as well. A longer-term fix is already tracked in <rdar://problem/11385461>, which would allow WebKit to
simply specify a background color on the text field cell, and have AppKit render it properly to the edges of the
bezels.

Covered by a test that is currently failing on Mojave: fast/forms/hidpi-textfield-background-bleeding.html

• rendering/RenderThemeMac.mm:

(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:]):

11:32 AM Changeset in webkit [232798] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Always use Nuke & Set procedure for x86
​https://bugs.webkit.org/show_bug.cgi?id=186592

Reviewed by Keith Miller.

We always use nukeStructureAndStoreButterfly for Contiguous -> ArrayStorage conversion if the architecture is x86.
By doing so, we can concurrently load structure and butterfly at least in x86 environment even in non-collector
threads.

• runtime/JSObject.cpp:

(JSC::JSObject::convertContiguousToArrayStorage):

11:29 AM Changeset in webkit [232797] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Mark some flaky tests and expected failures.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

11:22 AM Changeset in webkit [232796] by commit-queue@webkit.org

• 17 edits in trunk

[WPE] Build getUserMedia support
​https://bugs.webkit.org/show_bug.cgi?id=186547

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-06-13
Reviewed by Alejandro G. Castro.

.:

• Source/cmake/OptionsWPE.cmake: Build MediaStream support

Source/WebCore:

Enable mediastream tests.

• PlatformWPE.cmake: Build MediaStream support.
• SourcesGTK.txt: Moved GStreamer related files to GStreamer.cmake.
• SourcesWPE.txt: Removed platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp

which is now in GStreamer.cmake.

• platform/GStreamer.cmake: Build more MediaStream/webrtc related files.
• platform/graphics/ImageBuffer.cpp: Handle the fact that toBGRAData is

now built directly into the Cairo backend and not GTK anymore.

• platform/graphics/cairo/ImageBufferCairo.cpp: Implement toBGRAData
• platform/graphics/gtk/ImageBufferGtk.cpp: Removed toBGRAData as it is

now implemented in the Cairo backend itself.

• platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Switch an

ASSERT to RELEASE_ASSERT when adding the GhostPad to itself. This was making
test fail when built in RELEASE mode.
(WebCore::webkitMediaStreamSrcChain): Minor variable name change to make it
more accurate.
(WebCore::webkitMediaStreamSrcAddPad): Now add the ghost pad to the element
before setting its chain function, making things clearer.
(WebCore::webkitMediaStreamSrcSetupSrc): Remove extra new line.

Source/WebKit:

• SourcesWPE.txt: Compile files necessary for MediaStream/webrtc.

LayoutTests:

• platform/gtk/TestExpectations: Mark some tests as potentially passing (they fail only

when built in debug mode).

• platform/wpe/TestExpectations: Enable MediaStream tests.

10:58 AM Changeset in webkit [232795] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GStreamer] fast/canvas/webgl crashes
​https://bugs.webkit.org/show_bug.cgi?id=186590

Reviewed by Carlos Alberto Lopez Perez.

After r232747 the sample managed by the player can be empty,
without buffer. So we need to check for this before mapping video
frames. Also use the GstVideoFrameHolder in more places to reduce
copy-paste churn.

• platform/graphics/gstreamer/ImageGStreamer.h:
• platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):

10:06 AM Changeset in webkit [232794] by aestes@apple.com

• 4 edits in trunk/Source/WebKit

[iOS] Synchronize PDF resizing with device rotation
​https://bugs.webkit.org/show_bug.cgi?id=186587
<rdar://problem/40922462>

Reviewed by Darin Adler.

Both -beginPDFViewRotation and -endPDFViewRotation need to be called as part of
the transition coordinator's -animateAlongsideTransition: block to be synchronized
with rotation. Additionally, updateBlock needs to be invoked between the two calls
so that PDFKit can capture the frame geometry before and after the update.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _beginAnimatedResizeWithUpdates:]):

• UIProcess/Cocoa/WKWebViewContentProvider.h:
• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_beginAnimatedResizeWithUpdates:]):
(-[WKPDFView web_beginAnimatedResize]): Renamed to web_beginAnimatedResizeWithUpdates:.
(-[WKPDFView web_endAnimatedResize]): Deleted.

9:35 AM Changeset in webkit [232793] by clopez@igalia.com

• 4 edits
  3 copies
  9 moves
  42 deletes in trunk/LayoutTests

Update expectations for WebCryptoAPI generateKey tests
​https://bugs.webkit.org/show_bug.cgi?id=186591

Unreviewed test gardening.

These tests were split and moved around several times, and expectation
files for old names stuck around.

LayoutTests/imported/w3c:

This also removes the placeholder failures.worker.html and
successes.worker.html files, because the tests were removed.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2018-06-13

• web-platform-tests/WebCryptoAPI/generateKey/failures.worker-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/successes.worker-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/successes.worker.html: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_aes-cbc-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_failures-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-OAEP-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-KW-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDSA-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_HMAC-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-OAEP-expected.txt: Removed.
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5-expected.txt: Removed.

LayoutTests:

Patch by Ms2ger <​Ms2ger@igalia.com> on 2018-06-13

• TestExpectations: Remove reference to long-removed test.
• platform/gtk/TestExpectations: Remove reference to long-removed test.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.any-expected.txt: Copied from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.any-expected.txt: Copied from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any-expected.txt: Copied from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker-expected.txt.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes.worker-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDSA.worker-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDSA.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDSA.https-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.any-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.any-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.worker-expected.txt.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_ECDSA.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.worker-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDSA.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDSA.https-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https-expected.txt: Removed.

9:16 AM Changeset in webkit [232792] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

A few layout tests are failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=186562

Unreviewed test gardening.

• platform/win/TestExpectations:

8:56 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com

(diff)

8:46 AM Changeset in webkit [232791] by Philippe Normand

• 3 edits in trunk/Source/WebCore

Unreviewed GTK build fix for --cmakeargs=-DUSE_GSTREAMER_GL=OFF

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

6:39 AM Changeset in webkit [232790] by Philippe Normand

• 3 edits in trunk/Source/WebCore

[GStreamer] Video freezes when GStreamerGL is not installed
​https://bugs.webkit.org/show_bug.cgi?id=184925

Reviewed by Žan Doberšek.

At runtime when the GStreamer opengl plugin isn't available the
player will fallback to the internal WebKit video sink. The
VideoFrameHolder was refactored to handle both cases (opengl,
non-opengl).

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::~GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::frame const):
(WebCore::GstVideoFrameHolder::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::GstVideoFrameHolder::isValid const): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Deleted.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

3:50 AM Changeset in webkit [232789] by clopez@igalia.com

• 3 edits in trunk/Tools

[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=186523

Unreviewed follow-up fix after r232748

• Scripts/webkitpy/common/config/ports.py:

(JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_jsconly_port):

Jun 12, 2018:

11:24 PM Changeset in webkit [232788] by sbarati@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
​https://bugs.webkit.org/show_bug.cgi?id=186071

Reviewed by Mark Lam.

• API/JSVirtualMachine.mm:

(-[JSVirtualMachine shrinkFootprint]): Deleted.

• API/JSVirtualMachinePrivate.h:

7:59 PM Changeset in webkit [232787] by Alan Bujtas

• 3 edits
  2 adds in trunk

Complex text handling should opt out of bounded text layout.
​https://bugs.webkit.org/show_bug.cgi?id=186571
<rdar://problem/41060908>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/text/complex-long-text-crash.html

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

LayoutTests:

• fast/text/complex-long-text-crash-expected.txt: Added.
• fast/text/complex-long-text-crash.html: Added.

6:55 PM Changeset in webkit [232786] by commit-queue@webkit.org

• 5 edits in trunk/Tools

webkitpy: Implement coredumpctl support on linux
​https://bugs.webkit.org/show_bug.cgi?id=184039

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-06-12
Reviewed by Daniel Bates.

And start using an Executive to run subprocesses
in GDBCrashLogGenerator.

Unit tests adapted to the new API and still passing.

• Scripts/webkitpy/port/linux_get_crash_log.py:

(GDBCrashLogGenerator):
(GDBCrashLogGenerator._get_trace_from_systemd):
(GDBCrashLogGenerator.generate_crash_log):

6:09 PM Changeset in webkit [232785] by Kocsen Chung

• 7 edits in branches/safari-606.1.20.40-branch/Source

Versioning.

5:37 PM Changeset in webkit [232784] by Ryan Haddad

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r232774.

Breaks internal builds.

Reverted changeset:

"Complex text handling should opt out of bounded text layout."
​https://bugs.webkit.org/show_bug.cgi?id=186571
​https://trac.webkit.org/changeset/232774

5:27 PM Changeset in webkit [232783] by achristensen@apple.com

• 3 edits
  10271 adds in trunk/LayoutTests

Import the 2.0.0 version of Khronos WebGL conformance suite
​https://bugs.webkit.org/show_bug.cgi?id=181293
<rdar://problem/40654103>

Patch by Justin Fan <Justin Fan> on 2018-06-07
Reviewed by Dean Jackson.

Original description and patch by Zan Dobersek <​zdobersek@igalia.com>.
Retrying patch with up-to-date revision of conformance suite:

"Import the 2.0.0 version of the WebGL conformance suite that's
maintained under the Khronos organization on GitHub:
​https://github.com/KhronosGroup/WebGL.git

The following revision of this repository has been used for importing:
8ea92581353d18f50d25159489897ae634eb23b1

For importing purposes, the generate-webgl-tests.py script is modified
to import tests at version 2.0.0 or below. 2.0 is now used as the
default version for importing purposes. Additionally, the
GreaterThanOrEqualToVersion function is fixed to correctly compare 2.x
versions against 1.x.

The following generate-webgl-tests.py invocation was used:
$ python generate-webgl-tests.py -e -w ~/WebGL/conformance-suites/2.0.0

The 2.0.0 version of the conformance suite is composed of three parts:

• tests under conformance/ cover WebGL1 functionality,
• tests under conformance2/ cover WebGL2 functionality,
• tests under deqp/ are a port of the dEQP suite.

webkit-webgl-test-harness.js file is added under webgl/2.0.0/resources/
to properly integrate the imported tests with the WebKit testing
facilities.

The complete suite is for now skipped on all platforms. WebGL1 tests
should be passing in majority, with failures in that part of the suite
mirroring the ones experienced in the current 1.0.2 and 1.0.3 suites.
The WebGL2 support is still incomplete, and the conformance2/ pass rate
will reflect that. dEQP in majority utilizes WebGL2, so the pass rate
is similarly poor.

List of imported conformance suite files is omitted for brevity."

• TestExpectations: Skip the WebGL 1 (conformance) and WebGL 2 (conformance2) tests
• webgl/2.0.0/conformance: Added.
• webgl/2.0.0/conformance2: Added.
• webgl/2.0.0/deqp: Added.
• webgl/2.0.0/resources: Added.
• webgl/2.0.0/resources/webkit-webgl-test-harness.js:

(window.layoutTestController.window.console.log):
(window.layoutTestController.window.console.error):
(log):
(window.webglTestHarness.reportResults):
(window.webglTestHarness.notifyFinished):

• webgl/generate-webgl-tests.py:

(GreaterThanOrEqualToVersion):

• webgl/resources/js-test-pre.js:

(window.console.log):
(window.console.error):
(initNonKhronosFramework):
(this.initTestingHarness):
(nonKhronosFrameworkNotifyDone):
(reportTestResultsToHarness):
(notifyFinishedToHarness):
(_logToConsole):
(enableJSTestPreVerboseLogging):
(description):
(_addSpan):
(debug):
(escapeHTML):
(testPassed):
(testFailed):
(areArraysEqual):
(isMinusZero):
(isResultCorrect):
(stringify):
(evalAndLog):
(shouldBe):
(shouldNotBe):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldEvaluateTo):
(shouldBeNonZero):
(shouldBeNonNull):
(shouldBeUndefined):
(shouldBeDefined):
(shouldBeGreaterThanOrEqual):
(expectTrue):
(shouldThrow):
(assertMsg):
(gc.gcRec):
(gc):
(finishTest):

• webgl/resources/webgl-test-harness.js:

(log):
(try.request.onreadystatechange):
(loadTextFileAsynchronous):
(getMajorVersion):
(getURLWithOptions):
(greaterThanOrEqualToVersion):
(copyObject):
(toCamelCase):
(getFileListImpl):
(getFileList):
(FilterURL):
(TestFile):
(Test):
(TestHarness):
(TestHarness.prototype.addFiles_):
(TestHarness.prototype.runTests):
(TestHarness.prototype.setTimeout):
(TestHarness.prototype.clearTimeout):
(TestHarness.prototype.startNextTest):
(TestHarness.prototype.startTest):
(TestHarness.prototype.getTest):
(TestHarness.prototype.reportResults):
(TestHarness.prototype.dequeTest):
(TestHarness.prototype.notifyFinished):
(TestHarness.prototype.timeout):
(TestHarness.prototype.setTimeoutDelay):
(WebGLTestHarnessModule):

5:08 PM Changeset in webkit [232782] by Kocsen Chung

• 1 copy in tags/Safari-606.1.20.40.1

Tag Safari-606.1.20.40.1.

4:30 PM Changeset in webkit [232781] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Unreviewed, rebaseline RSA-PSS tests for High Sierra.

• platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any-expected.txt: Add missing whitespace.
• platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker-expected.txt: Ditto.

3:28 PM Changeset in webkit [232780] by Said Abou-Hallawa

• 2 edits in trunk/LayoutTests

Unreviewed followup for r232736
​https://bugs.webkit.org/show_bug.cgi?id=185698

Consider the case when the SVG animation starts before requestAnimationFrame()
is called. Store the value of animItem and compare it later with the value
of animItem after detaching it from the animated animList.

• svg/dom/animated-tearoff-list-remove-target.html:

3:10 PM Changeset in webkit [232779] by Kocsen Chung

• 3 edits
  2 adds in branches/safari-606.1.20.40-branch

Cherry-pick r232774. rdar://problem/40801429

Complex text handling should opt out of bounded text layout.
​https://bugs.webkit.org/show_bug.cgi?id=186571
<rdar://problem/40801429>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/text/complex-long-text-crash.html

• platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

LayoutTests:

• fast/text/complex-long-text-crash-expected.txt: Added.
• fast/text/complex-long-text-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@232774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:50 PM Changeset in webkit [232778] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

iOS WK1: Occasional crash in FrameView::setScrollPosition
​https://bugs.webkit.org/show_bug.cgi?id=186575

Reviewed by David Kilzer.

The bug was caused by ScrollView::platformSetScrollPosition releasing the web thread lock
and DumpRenderTree requesting a new page load thereby destroying FrameView.

Fixed the crash by keeping FrameView alive while scrollToFocusedElementTimerFired is getting called.

No new tests since the bug is caught by existing layout tests under guard malloc.

• page/FrameView.cpp:

(WebCore::FrameView::scrollToFocusedElementTimerFired):

2:45 PM Changeset in webkit [232777] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark inspector/console/webcore-logging.html as flaky on mac-wk2 debug.
​https://bugs.webkit.org/show_bug.cgi?id=186425

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:37 PM Changeset in webkit [232776] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/video-buffering-allowed.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=186574

Unreviewed test gardening.

• TestExpectations:

2:37 PM Changeset in webkit [232775] by commit-queue@webkit.org

• 2 edits in trunk/Tools

test262/Runner.pm: fix one test (can't find jsc)
​https://bugs.webkit.org/show_bug.cgi?id=186573

Patch by Valerie R Young <​valerie@bocoup.com> on 2018-06-12
Reviewed by Michael Saboff.

• Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:

fix subtest to use mock JSC

2:14 PM Changeset in webkit [232774] by Alan Bujtas

• 3 edits
  2 adds in trunk

Complex text handling should opt out of bounded text layout.
​https://bugs.webkit.org/show_bug.cgi?id=186571
<rdar://problem/40801429>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/text/complex-long-text-crash.html

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

LayoutTests:

• fast/text/complex-long-text-crash-expected.txt: Added.
• fast/text/complex-long-text-crash.html: Added.

2:09 PM Changeset in webkit [232773] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, fix the Windows build after r232757

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren):

1:50 PM Changeset in webkit [232772] by commit-queue@webkit.org

• 1 edit
  4 adds in trunk/LayoutTests

Rebaseline WebCrypto API tests for High Sierra after r232641.
​https://bugs.webkit.org/show_bug.cgi?id=186565

Unreviewed test gardening.

Patch by David Fenton <​david_fenton@apple.com> on 2018-06-12

• platform/mac-sierra/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any-expected.txt: Added.
• platform/mac-sierra/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker-expected.txt: Added.
• platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any-expected.txt: Added.
• platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.https.any.worker-expected.txt: Added.

1:15 PM Changeset in webkit [232771] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Turn CSS Spring Animations and Link Preload off by default for production builds.
​https://bugs.webkit.org/show_bug.cgi?id=186548
<rdar://problem/41023774>

Reviewed by Eric Carlson.

• Shared/WebPreferences.yaml: Switch these features from 'on' to

DEFAULT_EXPERIMENTAL_FEATURES_ENABLED.

1:07 PM Changeset in webkit [232770] by Wenson Hsieh

• 12 edits
  4 adds
  2 deletes in trunk

[WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=186442
<rdar://problem/40879364>

Reviewed by Tim Horton.

Source/WebKit:

Upstream most of the work around form controls on watchOS. Also, rename WKFormControlListViewController.* to
its intended name, WKQuickboardListViewController.*.

• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/forms/WKDatePickerViewController.h:
• UIProcess/ios/forms/WKDatePickerViewController.mm:

(datePickerSetButtonHeight):
(datePickerVerticalMargin):
(-[WKDatePickerWheelLabel initWithFrame:]):
(-[WKDatePickerWheelLabel lastSelectedDate]):
(-[WKDatePickerWheelLabel setLastSelectedDate:]):
(-[WKDatePickerWheelLabel needsUpdateForIndex:selectedDate:]):
(-[WKDatePickerWheel initWithStyle:]):
(-[WKDatePickerWheel initWithController:style:]):
(-[WKDatePickerWheel gestureRecognized:]):
(-[WKDatePickerWheel setDrawsFocusOutline:]):
(-[WKDatePickerWheel drawsFocusOutline]):
(-[WKDatePickerWheel gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKDatePickerViewController initWithDelegate:]):
(-[WKDatePickerViewController viewDidLoad]):
(-[WKDatePickerViewController prefersStatusBarHidden]):
(-[WKDatePickerViewController viewWillAppear:]):
(-[WKDatePickerViewController viewDidAppear:]):
(-[WKDatePickerViewController viewDidDisappear:]):
(-[WKDatePickerViewController _handleStatusBarNavigation]):
(-[WKDatePickerViewController viewWillLayoutSubviews]):
(-[WKDatePickerViewController becomeFirstResponder]):
(-[WKDatePickerViewController defaultMinimumDate]):
(-[WKDatePickerViewController defaultMaximumDate]):
(-[WKDatePickerViewController _valueForInput]):
(-[WKDatePickerViewController _dateFromInitialText]):
(-[WKDatePickerViewController _setButtonPressed]):
(-[WKDatePickerViewController _updateSelectedPickerViewIndices]):
(-[WKDatePickerViewController _configurePickerView:]):
(-[WKDatePickerViewController setMinimumDate:]):
(-[WKDatePickerViewController minimumDate]):
(-[WKDatePickerViewController setMaximumDate:]):
(-[WKDatePickerViewController maximumDate]):
(-[WKDatePickerViewController setDate:]):
(-[WKDatePickerViewController setDateFromComponents:]):
(-[WKDatePickerViewController setDay:month:year:era:]):
(-[WKDatePickerViewController date]):
(-[WKDatePickerViewController _dateComponentForDay:month:year:era:]):
(-[WKDatePickerViewController _adjustDateToValidDateIfNecessary]):
(-[WKDatePickerViewController _createAndConfigureGranularityLabelWithText:]):
(-[WKDatePickerViewController _canonicalizeAndUpdateSelectedDate]):
(-[WKDatePickerViewController numberOfItemsInPickerView:]):
(-[WKDatePickerViewController pickerView:viewForItemAtIndex:]):
(-[WKDatePickerViewController didBeginInteractingWithDatePicker:]):
(-[WKDatePickerViewController pickerView:didSelectItemAtIndex:]):
(-[WKDatePickerViewController pickerViewWillBeginSelection:]):
(-[WKDatePickerViewController pickerViewDidEndSelection:]):
(-[WKDatePickerViewController _dayFromIndex:]):
(-[WKDatePickerViewController _eraAndYearFromIndex:]):
(-[WKDatePickerViewController _monthFromIndex:]):
(-[WKDatePickerViewController _indexFromDay:]):
(-[WKDatePickerViewController _indexFromYear:era:]):
(-[WKDatePickerViewController _indexFromMonth:]):

• UIProcess/ios/forms/WKFormControlListViewController.h: Removed.
• UIProcess/ios/forms/WKFormControlListViewController.mm: Removed.
• UIProcess/ios/forms/WKNumberPadViewController.h:
• UIProcess/ios/forms/WKNumberPadViewController.mm:

(inputLabelFontSize):
(-[WKNumberPadViewController initWithDelegate:initialText:inputMode:]):
(-[WKNumberPadViewController dealloc]):
(-[WKNumberPadViewController viewDidLoad]):
(-[WKNumberPadViewController viewWillDisappear:]):
(-[WKNumberPadViewController viewWillLayoutSubviews]):
(-[WKNumberPadViewController _reloadHeaderViewFromInputText]):
(-[WKNumberPadViewController didSelectKey:]):
(-[WKNumberPadViewController _handleKeyPress:]):
(-[WKNumberPadViewController _cancelInput]):
(-[WKNumberPadViewController _deleteLastInputCharacter]):
(-[WKNumberPadViewController _deleteButtonPressed]):
(-[WKNumberPadViewController _cancelDeletionTimers]):
(-[WKNumberPadViewController _startDeletionTimer]):
(-[WKNumberPadViewController _deletionTimerFired]):
(-[WKNumberPadViewController addContentViewAnimations:]):

• UIProcess/ios/forms/WKQuickboardListViewController.h: Added.
• UIProcess/ios/forms/WKQuickboardListViewController.mm: Added.

(-[WKQuickboardListItemCell topToLabelBaselineSpecValue]):
(-[WKQuickboardListItemCell baselineToBottomSpecValue]):
(-[WKQuickboardListViewController initWithDelegate:]):
(-[WKQuickboardListViewController updateContextViewIfNeeded]):
(-[WKQuickboardListViewController prefersStatusBarHidden]):
(-[WKQuickboardListViewController viewDidLoad]):
(-[WKQuickboardListViewController viewWillAppear:]):
(-[WKQuickboardListViewController viewDidDisappear:]):
(-[WKQuickboardListViewController _handleStatusBarNavigation]):
(-[WKQuickboardListViewController reloadContextView]):
(-[WKQuickboardListViewController actionController]):
(-[WKQuickboardListViewController languageControllerDidChangePrimaryLanguage:]):
(-[WKQuickboardListViewController headerContentViewHeight]):
(-[WKQuickboardListViewController headerContentView]):
(configureStatusBarForController):

• UIProcess/ios/forms/WKSelectMenuListViewController.h:
• UIProcess/ios/forms/WKSelectMenuListViewController.mm:

(-[WKSelectMenuItemCell initWithStyle:reuseIdentifier:]):
(-[WKSelectMenuItemCell imageView]):
(-[WKSelectMenuListViewController initWithDelegate:]):
(-[WKSelectMenuListViewController viewDidLoad]):
(-[WKSelectMenuListViewController acceptButtonTappedWithCompletion:]):
(-[WKSelectMenuListViewController shouldShowTrayView]):
(-[WKSelectMenuListViewController didSelectListItem:]):
(-[WKSelectMenuListViewController numberOfListItems]):
(-[WKSelectMenuListViewController heightForListItem:width:]):
(-[WKSelectMenuListViewController cellForListItem:]):
(-[WKSelectMenuListViewController selectItemAtIndex:]):

• UIProcess/ios/forms/WKTimePickerViewController.h:
• UIProcess/ios/forms/WKTimePickerViewController.mm:

(-[WKTimePickerViewController initWithDelegate:]):
(-[WKTimePickerViewController dateFormatter]):
(-[WKTimePickerViewController timeValueForFormControls]):
(-[WKTimePickerViewController dateComponentsFromInitialValue]):
(-[WKTimePickerViewController viewDidAppear:]):
(-[WKTimePickerViewController viewDidLoad]):
(-[WKTimePickerViewController becomeFirstResponder]):
(-[WKTimePickerViewController setHour:minute:]):
(-[WKTimePickerViewController leftButtonWOTAction]):
(-[WKTimePickerViewController rightButtonWOTAction]):

• WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Upstream a couple of internal test expectations on watchOS.

• fast/viewport/extrazoom/viewport-adaptations-after-navigation-expected.txt: Added.
• fast/viewport/extrazoom/viewport-disable-extra-zoom-adaptations-expected.txt: Added.

12:28 PM Changeset in webkit [232769] by Kocsen Chung

• 4 edits in branches/safari-606.1.20.40-branch

Cherry-pick r232580. rdar://problem/38881568

Don't start service worker fetch when there is substitute data
​https://bugs.webkit.org/show_bug.cgi?id=186349
<rdar://problem/38881568>

Reviewed by Youenn Fablet.

Loading content via WKWebView.loadData may also end up starting a main resource service worker fetch.
This breaks DocumentWriter assumptions.

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::tryLoadingRequestFromApplicationCache): (WebCore::DocumentLoader::tryLoadingSubstituteData):

Factor substitute resource loading out from tryLoadingRequestFromApplicationCache.

(WebCore::DocumentLoader::startLoadingMainResource):

If we have substitute data already (typically from WKWebView.loadData), allow service worker registration
but load the main resource using the substitute data.

(WebCore::DocumentLoader::handleSubstituteDataLoadSoon): Deleted.

Merge to tryLoadingSubstituteData.

• loader/DocumentLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@232580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:28 PM Changeset in webkit [232768] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

Make Modern EME An Experimental Feature Again
​https://bugs.webkit.org/show_bug.cgi?id=186569
<rdar://problem/41054402>

Reviewed by Eric Carlson.

• Shared/WebPreferences.yaml:

11:54 AM Changeset in webkit [232767] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[watchOS] Enable NetworkActivityTracker
​https://bugs.webkit.org/show_bug.cgi?id=186568
<rdar://problem/41050624>

Reviewed by Tim Horton.

• NetworkProcess/NetworkActivityTracker.h:

11:53 AM Changeset in webkit [232766] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Add a API test for r232601
​https://bugs.webkit.org/show_bug.cgi?id=186417

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:

(immediateSubviewOfClass):
(TEST):
Ensure that we put the view hierarchy back together (move WKContentView
out of the animated resize view) and unhide WKContentView after a
resize-with-hidden-content.

11:40 AM Changeset in webkit [232765] by bshafiei@apple.com

• 7 edits in branches/safari-606.1.20.40-branch/Source

Versioning.

11:38 AM Changeset in webkit [232764] by bshafiei@apple.com

• 7 edits in branches/safari-606.1.20.30-branch/Source

Versioning.

11:35 AM Changeset in webkit [232763] by bshafiei@apple.com

• 7 edits in branches/safari-606.1.20.20-branch/Source

Versioning.

11:06 AM Changeset in webkit [232762] by bshafiei@apple.com

• 1 copy in branches/safari-606.1.20.40-branch

New branch.

11:06 AM Changeset in webkit [232761] by bshafiei@apple.com

• 1 copy in branches/safari-606.1.20.30-branch

New branch.

11:06 AM Changeset in webkit [232760] by bshafiei@apple.com

• 1 copy in branches/safari-606.1.20.20-branch

New branch.

10:53 AM Changeset in webkit [232759] by Antti Koivisto

• 9 edits in trunk/Source/WebKit

Add performance logging for slow cache retrieves
​https://bugs.webkit.org/show_bug.cgi?id=186520
<rdar://problem/41002070>

Reviewed by Chris Dumez.

We sometimes see slow cache retrieves in logs. Add some more logging to better analyze these cases.

This patch adds timings to all cache storage retrieve operations and passes them up to the client.
We then log the timings on NetworkResourceLoader levels if needed. Items logged include

• total retrieve time
• dispatch delay and number of resources dispatched before this one
• record I/O time
• blob I/O time
• whether cache shrink was in progress
• whether cache synchronization was in progress
• cancellation

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::logSlowCacheRetrieveIfNeeded):

Log if the retrieve took more than 1s.

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::readRecord):

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::completeRetrieve):
(WebKit::NetworkCache::Cache::retrieveData):

• NetworkProcess/cache/NetworkCache.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):

SpeculativeLoadManager does not records specific timings yet but at least we do log when they occur.

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::ReadOperation::cancel):
(WebKit::NetworkCache::Storage::ReadOperation::finish):

Record timing info in ReadOperations.

(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::retrieveFromMemory):
(WebKit::NetworkCache::Storage::retrieve):

• NetworkProcess/cache/NetworkCacheStorage.h:

10:31 AM Changeset in webkit [232758] by bshafiei@apple.com

• 4 edits in branches/safari-606.1.20-branch

Cherry-pick r232580. rdar://problem/38881568

Don't start service worker fetch when there is substitute data
​https://bugs.webkit.org/show_bug.cgi?id=186349
<rdar://problem/38881568>

Reviewed by Youenn Fablet.

Loading content via WKWebView.loadData may also end up starting a main resource service worker fetch.
This breaks DocumentWriter assumptions.

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::tryLoadingRequestFromApplicationCache): (WebCore::DocumentLoader::tryLoadingSubstituteData):

Factor substitute resource loading out from tryLoadingRequestFromApplicationCache.

(WebCore::DocumentLoader::startLoadingMainResource):

If we have substitute data already (typically from WKWebView.loadData), allow service worker registration
but load the main resource using the substitute data.

(WebCore::DocumentLoader::handleSubstituteDataLoadSoon): Deleted.

Merge to tryLoadingSubstituteData.

• loader/DocumentLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@232580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:25 AM Changeset in webkit [232757] by Wenson Hsieh

• 3 edits
  2 adds in trunk

REGRESSION(r228724): Occasional crash when executing ReplaceSelectionCommand at the end of the document
​https://bugs.webkit.org/show_bug.cgi?id=186555
<rdar://problem/39703004>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r228724 removed a null check for m_lastNodeInserted in InsertedNodes::pastLastLeaf(). This null check was
guarding against the case where m_firstNodeInserted might exist, but m_lastNodeInserted is null, which may
happen when inserting content at the end of the document, since InsertedNodes::willRemoveNodePreservingChildren
may cause m_lastNodeInserted to be null. This is because the removed node may be at the very end of the document
_and also_ not have any children, which means that both node->lastChild() as well as
NodeTraversal::nextSkippingChildren(*node) will be null.

After getting into this state, we subsequently crash when attempting to compute InsertedNodes::pastLastLeaf().
To fix this, avoid accidentally clearing out m_lastNodeInserted; if the last inserted node has neither a child
nor a next node, seek backwards to the previous node in the DOM instead, and clamp to the first inserted node,
such that the last inserted node's document position is at or after the first inserted node's position.

Test: editing/execCommand/insert-apple-style-span-at-document-end.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren):

LayoutTests:

Add a new layout test demonstrating the crash. The test passes if the right text is inserted into the DOM, and
we don't hit a crash.

• editing/execCommand/insert-apple-style-span-at-document-end-expected.txt: Added.
• editing/execCommand/insert-apple-style-span-at-document-end.html: Added.

10:22 AM Changeset in webkit [232756] by commit-queue@webkit.org

• 1 edit
  16 adds in trunk/Tools

test262/Runner.pm: add unit tests
​https://bugs.webkit.org/show_bug.cgi?id=185783

Patch by Valerie R Young <​valerie@bocoup.com> on 2018-06-12
Reviewed by Michael Saboff.

• Scripts/webkitperl/test262_unittest/README: Added.
• Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
• Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
• Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail-new-error.pl: Added.
• Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail.pl: Added.
• Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-pass.pl: Added.
• Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
• Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
• Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.

(f):

• Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
• Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
• Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.

(f):

• Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.

10:16 AM Changeset in webkit [232755] by commit-queue@webkit.org

• 2 edits in trunk/Tools

test262/Runner.pm: minor updates
​https://bugs.webkit.org/show_bug.cgi?id=186399

• If harness files cannot be found in a CLI supplied

test262 path, then default to webkit's test262 harness files.

• Lazily create the test262-results directory (only right before

writing to it)

• If an expectation file is supplied via the CLI, save to the

supplied location instead of the default webkit location
(JSTest/test262/expectation.yaml).

Patch by Valerie R Young <​valerie@bocoup.com> on 2018-06-12
Reviewed by Michael Saboff.

• Scripts/test262/Runner.pm:

(processCLI):
(main):
(compileTest):
(processResult):
(getHarness):
(summarizeResults):

8:28 AM Changeset in webkit [232754] by commit-queue@webkit.org

• 6 edits in trunk

Hash deviceId and groupId of MediaTrackCapabilities.
​https://bugs.webkit.org/show_bug.cgi?id=186471

Patch by Jianjun Zhu <​jianjun.zhu@intel.com> on 2018-06-12
Reviewed by Eric Carlson.

This change makes the identifier for the source of the MediaStreamTrack
has the same value returned by enumerateDevices(). It also prevents real
device ID being leaked.

Source/WebCore:

(WebCore::MediaStreamTrack::getCapabilities const):

• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

• fast/mediastream/MediaStreamTrack-getCapabilities.html:

8:20 AM Changeset in webkit [232753] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed WPE build fix after r232749.

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

7:42 AM Changeset in webkit [232752] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Add vertical margin computation for inflow non-replaced box and for the (10.6.6) complicated cases.
​https://bugs.webkit.org/show_bug.cgi?id=186469

Reviewed by Antti Koivisto.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

7:23 AM Changeset in webkit [232751] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

A few layout tests are failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=186562

Unreviewed test gardening.

• platform/win/TestExpectations:

5:09 AM Changeset in webkit [232750] by Yusuke Suzuki

• 2 edits in trunk/JSTests

Update test262 for Array#sort
​https://bugs.webkit.org/show_bug.cgi?id=186458

• test262/expectations.yaml:

5:07 AM Changeset in webkit [232749] by Philippe Normand

• 6 edits
  1 delete in trunk

[GStreamer] Bump required version to 1.8.3
​https://bugs.webkit.org/show_bug.cgi?id=186558

Reviewed by Xabier Rodriguez-Calvar.

.:

• Source/cmake/GStreamerChecks.cmake: Bump to 1.8.3 which is the

version shipped in the current Ubuntu LTS we support (16.04).

Source/WebCore:

• platform/GStreamer.cmake: Remove useless file.
• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcChangeState): Remove useless version check.

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:

Removed. createDecryptor() is dead code since the decryptors moved
to the MSE playback pipeline.

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::GStreamerEMEUtilities::keySystemToUuid):

4:40 AM Changeset in webkit [232748] by clopez@igalia.com

• 8 edits
  1 add in trunk/Tools

[JSCOnly] Add a MIPS32el JSCOnly EWS
​https://bugs.webkit.org/show_bug.cgi?id=186523

Reviewed by Michael Catanzaro.

Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.

• QueueStatusServer/config/queues.py:
• QueueStatusServer/model/queues.py:

(Queue.display_name):

• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(WpePort.run_webkit_tests_command):
(JscOnlyPort):
(JscOnlyPort.build_jsc_command):

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_wincairo_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_jsconly_port):

• Scripts/webkitpy/port/factory.py:

(PortFactory):

• Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.

(JscOnlyPort):
(JscOnlyPort.init):

• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(test_ews_name):

2:43 AM Changeset in webkit [232747] by Philippe Normand

• 2 edits in trunk/Source/WebCore

[GStreamer] flush video sample upon DRAIN query
​https://bugs.webkit.org/show_bug.cgi?id=186481

Patch by Philippe Normand <​philn@igalia.com> on 2018-06-11
Reviewed by Xabier Rodriguez-Calvar.

Use the appsink sink pad pad probe for both event and drain query
management. This patch is partially based on
​https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/d3a336523d123119fe1dd53da5d9006c92cf078c
by Enrique Ocaña González <​eocanha@igalia.com>.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink):

12:55 AM Changeset in webkit [232746] by zandobersek@gmail.com

• 7 edits
  7 adds in trunk

Add run-web-platform-tests script
​https://bugs.webkit.org/show_bug.cgi?id=183356

Reviewed by Carlos Alberto Lopez Perez.

.:

Store port-specific test expectations and test manifest files for the
web-platform-tests test runs under the top-level WebPlatformTests
directory.

TestExpectations.json file lists all the failing or disabled tests
or subtests that are to be expected in the test run. This information is
parsed in the run-web-platform-tests script and used to build
test-specific metadata files (ending with .ini) inside a temporary
directory that is then used during the test run. JSON format is used to
follow the WebDriver test suite in how it manages expectations, and to
avoid having to manually manage .ini files for every deviant test case.

TestManifest.ini file is used to fine-tune which tests are to be enabled
by default. For the GTK+ port, we currently disable all tests by default
but then specifically enable tests under the 2dcontext and WebCryptoAPI
directories. This will allow for gradual enabling of further tests.

• WebPlatformTests/gtk/TestExpectations.json: Added.
• WebPlatformTests/gtk/TestManifest.ini: Added.

Tools:

Add the run-web-platform-tests script that allows running WebKit builds
against the external web-platform-tests project.

The script sets up all the port-specific information, including the
display driver. If no web-platform-tests repository location is
specified, the TestDownloader utility is used to clone the repository,
and path to that clone is leveraged instead.

Port-specific TestManifest.ini and TestExpectations.json file paths are
then constructed, bailing if any of the files is missing. The JSON file
is then used to construct the metadata file tree, creating an .ini file
for each test that is disabled, has a certain expectation, or has
subtests that themselves have certain expectations. This metadata tree
is built under the build directory, and is purged and reconstructed for
each separate run.

Lastly, the WPT python module is imported from the web-platform-tests
source location, and wpt.main() is invoked along with all the necessary
arguments that set up a web-platform-tests suite run using the WebKit
product.

• Scripts/run-web-platform-tests: Added.
• Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_bindings_tests_command):
(MockPort):
(MockPort.wpt_metadata_directory):
(MockPort.wpt_manifest_file):

• Scripts/webkitpy/port/base.py:

(Port.wpt_metadata_directory):
(Port):
(Port.wpt_manifest_file):

• Scripts/webkitpy/w3c/common.py:

(is_file_exportable):
(WPTPaths):
(WPTPaths.checkout_directory):
(WPTPaths.wpt_checkout_path):

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.clone_tests):
(TestDownloader):
(TestDownloader.download_tests):

• Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter.init):

• Scripts/webkitpy/w3c/wpt_runner.py: Added.

(main):
(parse_args):
(create_webdriver):
(spawn_wpt):
(WPTRunner):
(WPTRunner.init):
(WPTRunner._prepare_wpt_checkout):
(WPTRunner._generate_metadata_directory):
(WPTRunner.run):

• Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added.

(WPTRunnerTest):
(WPTRunnerTest.MockTestDownloader):
(WPTRunnerTest.MockTestDownloader.default_options):
(WPTRunnerTest.MockTestDownloader.init):
(WPTRunnerTest.MockTestDownloader.clone_tests):
(WPTRunnerTest.MockWebDriver):
(WPTRunnerTest.MockWebDriver.create):
(WPTRunnerTest.MockWebDriver.binary_path):
(WPTRunnerTest.MockWebDriver.browser_path):
(WPTRunnerTest.MockWebDriver.browser_args):
(WPTRunnerTest.MockSpawnWPT):
(WPTRunnerTest.MockSpawnWPT.init):
(WPTRunnerTest.MockSpawnWPT.call):
(WPTRunnerTest.TestInstance):
(WPTRunnerTest.TestInstance.init):
(WPTRunnerTest.TestInstance.prepare_mock_files_for_run):
(WPTRunnerTest.test_prepare_wpt_checkout):
(WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
(WPTRunnerTest.test_generate_metadata_directory):
(WPTRunnerTest.test_run):
(WPTRunnerTest.test_run_with_specified_options):
(WPTRunnerTest.test_run_with_args):

12:00 AM Changeset in webkit [232745] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.21.4

WebKitGTK+ 2.21.4