⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 15, 2018:

10:20 PM Changeset in webkit [232901] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Better pack MediaQuery
​https://bugs.webkit.org/show_bug.cgi?id=186716

Reviewed by Simon Fraser.

Better pack MediaQuery to reduce its size from 48 bytes to 40 and save
some memory.

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery):

  • css/MediaQuery.h:
7:53 PM Changeset in webkit [232900] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Annotate shrinkFootprintWhenIdle with NS_AVAILABLE
​https://bugs.webkit.org/show_bug.cgi?id=186687
<rdar://problem/40071332>

Reviewed by Keith Miller.

  • API/JSVirtualMachinePrivate.h:
6:59 PM Changeset in webkit [232899] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
​https://bugs.webkit.org/show_bug.cgi?id=186705
<rdar://problem/41173637>

Reviewed by Simon Fraser.

Call shrinkToFit on RefPtr<StyleRuleBase> vectors in CSSParserImpl, after we're
done parsing and before constructing StyleRuleMedia, StyleRuleSupports and
deferred rules in StyleRuleGroup.

  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parseDeferredRuleList):
(WebCore::CSSParserImpl::consumeMediaRule):
(WebCore::CSSParserImpl::consumeSupportsRule):

5:24 PM Changeset in webkit [232898] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

MediaQuerySet wastes a lot of vector capacity
​https://bugs.webkit.org/show_bug.cgi?id=186696
<rdar://problem/41172850>

Reviewed by Simon Fraser.

Call shrinkToFit() on the MediaQuerySet after we're done parsing it
to avoid wasting memory.

  • css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::parseInternal):

4:54 PM Changeset in webkit [232897] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

CachedRawResource wastes 57K of Vector capacity
​https://bugs.webkit.org/show_bug.cgi?id=186703
<rdar://problem/41173515>

Reviewed by Simon Fraser.

Use 0 as minimum capacity for CachedRawResource::m_redirectChain, instead of the
default value of 16. m_redirectChain usually contains very few items so 16 is
wasteful, especially considering that m_redirectChain contains fairly large
objects (std::pair<ResourceRequest, ResourceResponse>). CachedRawResource are
stored in the memory cache so it is important to not use more memory than
necessary.

We are also not worried about the performance cost of allocations here since
this vector is only populated on HTTP redirects.

  • loader/cache/CachedRawResource.h:
4:37 PM Changeset in webkit [232896] by bshafiei@apple.com
  • 1 copy in tags/Safari-605.3.8

Tag Safari-605.3.8.

3:16 PM Changeset in webkit [232895] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

Unreviewed, temporarily(?) revert some GTK crash expectations

These tests are not crashing on the GTK release bot, only on EWS. I want to see backtraces
and make sure they weren't just victims of our memory pressure handler. We can restore
these expectations again if they continue to crash on the EWS, in which case we need to
acquire backtraces for them.

  • platform/gtk/TestExpectations:
2:36 PM Changeset in webkit [232894] by Jonathan Bedard
  • 2 edits in trunk/Source/WebCore/PAL

Complex text handling should opt out of bounded text layout (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=186571
<rdar://problem/40801429>

Reviewed by Zalan Bujtas.

  • pal/spi/cocoa/CoreTextSPI.h: Add declaration for OpenSource Mojave builds.
2:34 PM Changeset in webkit [232893] by Basuke Suzuki
  • 2 edits in trunk/Tools

Unreviewed, add myself as a WebKit committer.

  • Scripts/webkitpy/common/config/contributors.json:
1:52 PM Changeset in webkit [232892] by Antti Koivisto
  • 9 edits
    2 adds in trunk

Semantic colors should not be transformed by color-filter
​https://bugs.webkit.org/show_bug.cgi?id=186566
<rdar://problem/40705739>

Reviewed by Simon Fraser.

Source/WebCore:

Test: css3/color-filters/color-filter-ignore-semantic.html

  • platform/graphics/Color.h:

(WebCore::Color::Color):
(WebCore::Color::isSemantic const):
(WebCore::Color::setIsSemantic):

Add a bit to Color to indicate it originated from a semantic color name.
Note that a color compares unequal to the semantic version of the same color.

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::transformColor const):

  • platform/graphics/mac/ColorMac.h:
  • platform/graphics/mac/ColorMac.mm:

(WebCore::semanticColorFromNSColor):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const):

Set the bit for semantic system colors.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

Fix up the output to avoid unneccary render tree dump changes.

LayoutTests:

  • css3/color-filters/color-filter-ignore-semantic-expected.html: Added.
  • css3/color-filters/color-filter-ignore-semantic.html: Added.
1:11 PM Changeset in webkit [232891] by Chris Dumez
  • 9 edits in trunk

Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test
​https://bugs.webkit.org/show_bug.cgi?id=186681

Reviewed by Brady Eidson.

Source/WebCore:

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::RegistrationDatabase):
(WebCore::RegistrationDatabase::importRecords):

  • workers/service/server/RegistrationDatabase.h:

Rename m_session to m_sessionID for clarity.

  • workers/service/server/RegistrationStore.cpp:

(WebCore::RegistrationStore::~RegistrationStore):
Drop bad assertion now that the RegistrationDatabase is refcounted
and can outlive the RegistrationStore. The RegistrationDatabase will
take care of closing / destroying the SQLiteDatabase on the background
thread when destroyed.

Source/WebKit:

Make sure StorageProcess::unregisterSWServerConnection() does not unnecessarily
create a SWServer. Otherwise, we were in quick session destroying the SWServer
and then re-constructing it for the same sessionID, merely to try ot unregister
a SWServerConnection.

  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::existingSWOriginStoreForSession const):
(WebKit::StorageProcess::unregisterSWServerConnection):

  • StorageProcess/StorageProcess.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
12:57 PM Changeset in webkit [232890] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make ForceOSRExit CFG pruning in bytecode parser more aggressive by making the original block to ignore be the plan's osrEntryBytecodeIndex
​https://bugs.webkit.org/show_bug.cgi?id=186648

Reviewed by Michael Saboff.

This patch is neutral on SunSpider/bitops-bitwise-and. That test originally
regressed with my first version of ForceOSRExit CFG pruning. This patch makes
ForceOSRExit CFG pruning more aggressive by not ignoring everything that
can reach any loop_hint, but only ignoring blocks that can reach a loop_hint
if it's the plan's osr entry bytecode target. The goal is to get a speedometer
2 speedup with this change on iOS.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

12:52 PM Changeset in webkit [232889] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark tests that are failing on the EWS test queue (v3)

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations:
12:36 PM Changeset in webkit [232888] by Basuke Suzuki
  • 9 edits
    2 deletes in trunk/Source

[WinCairo] Move unrelated features of WorkQueueWin into IPC::Connection
​https://bugs.webkit.org/show_bug.cgi?id=186582

Source/WebKit:

Add EventListener private class to handle signaled tasks for I/O.
Originally they were in WTF::WorkQueueWin, but those features were not related
to WorkQueue and only used in IPC::ConnectionWin. Moved logic is more specialized
than old generalized logic. That was unneeded generalization.

Reviewed by Brent Fulgham.

  • Platform/IPC/Connection.h:

(IPC::Connection::EventListener::state):

  • Platform/IPC/win/ConnectionWin.cpp:

(IPC::Connection::platformInitialize):
(IPC::Connection::platformInvalidate):
(IPC::Connection::readEventHandler):
(IPC::Connection::writeEventHandler):
(IPC::Connection::invokeReadEventHandler):
(IPC::Connection::invokeWriteEventHandler):
(IPC::Connection::open):
(IPC::Connection::sendOutgoingMessage):
(IPC::Connection::EventListener::open):
(IPC::Connection::EventListener::callback):
(IPC::Connection::EventListener::close):

Source/WTF:

Remove unrelated feature from WorkQueueWin.

Reviewed by Brent Fulgham.

  • wtf/PlatformWin.cmake: Remove WorkItemContext.*
  • wtf/WorkQueue.cpp:
  • wtf/WorkQueue.h:
  • wtf/win/Win32Handle.h:
  • wtf/win/WorkItemContext.cpp: Removed.
  • wtf/win/WorkItemContext.h: Removed.
  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::handleCallback): Deleted.
(WTF::WorkQueue::registerHandle): Deleted.
(WTF::WorkQueue::unregisterAndCloseHandle): Deleted.
(WTF::WorkQueue::unregisterWaitAndDestroyItemSoon): Deleted.
(WTF::WorkQueue::unregisterWaitAndDestroyItemCallback): Deleted.

12:33 PM Changeset in webkit [232887] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

Crash in both StorageProcess and UIProcess when using custom WKWebsiteDataStores for data management.
<rdar://problem/41019893> and ​https://bugs.webkit.org/show_bug.cgi?id=186682

Patch by Brady Eidson <​beidson@apple.com> on 2018-06-15
Reviewed by Chris Dumez.

  • UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::didClose): Protect this and the process pool as the cleanup that follows

might cause either to get destroyed.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply): Protect the operating WebsiteDataStore while async operations

are in flight. Otherwise if the data store is destroyed, the SessionIDs for those operations will get
destroyed before they complete.

(WebKit::WebsiteDataStore::removeData): Ditto.

12:28 PM Changeset in webkit [232886] by beidson@apple.com
  • 6 edits
    3 adds in trunk

Crash in both StorageProcess and UIProcess when using custom WKWebsiteDataStores for data management.
<rdar://problem/41019893> and ​https://bugs.webkit.org/show_bug.cgi?id=186682

Reviewed by Chris Dumez.

Source/WebKit:

  • UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::didClose): Protect this and the process pool as the cleanup that follows

might cause either to get destroyed.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply): Protect the operating WebsiteDataStore while async operations

are in flight. Otherwise if the data store is destroyed, the SessionIDs for those operations will get
destroyed before they complete.

(WebKit::WebsiteDataStore::removeData): Ditto.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

11:58 AM Changeset in webkit [232885] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Fix adding error in browserperfdash_runner.

Unreviewed follow-up fix after r232820.

  • Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:

(BrowserPerfDashRunner.run):

11:47 AM Changeset in webkit [232884] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
​https://bugs.webkit.org/show_bug.cgi?id=186683

Reviewed by Brent Fulgham.

Instead of DisplayRefreshMonitorMac having a RefPtr to WebPage, it should have a weak pointer.
Having a RefPtr could in theory create reference cycles. This potential problem has not been
observed in practice, but it is safer to use a weak pointer.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/DrawingAreaMac.cpp:

(WebKit::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::~DisplayRefreshMonitorMac):
(WebKit::DisplayRefreshMonitorMac::requestRefreshCallback):

11:31 AM Changeset in webkit [232883] by Michael Catanzaro
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r232816.

Suggested by Caitlin:
"this patch clearly does get some things wrong, and it's not
easy to find what those things are"

Reverted changeset:

"[LLInt] use loadp consistently for
get_from_scope/put_to_scope"
​https://bugs.webkit.org/show_bug.cgi?id=132333
​https://trac.webkit.org/changeset/232816

10:35 AM Changeset in webkit [232882] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

Unreviewed GTK test gardening

  • platform/gtk/TestExpectations:
10:35 AM Changeset in webkit [232881] by clopez@igalia.com
  • 6 edits in trunk

[GTK][WKE] Disable memory pressure handling when running layout tests (WTR)
​https://bugs.webkit.org/show_bug.cgi?id=186663

Reviewed by Michael Catanzaro.

Source/WebKit:

r196943 added a mechanism to disable the memory pressure handling
on Mac. This patch enables using that mechanism also for GTK/WPE.
To do that the environment variable WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR
should bet set to 1.
We want to use this on the layout tests to avoid flaky tests caused
by accumulated leaks on the WebProcess by different tests.

  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Tools:

Disable memory pressure handling when running tests via WTR by
setting WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR=1 on the environment.

  • WebKitTestRunner/gtk/main.cpp:

(main):

  • WebKitTestRunner/wpe/main.cpp:

(main):

10:32 AM Changeset in webkit [232880] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r232799): Form controls are blank in dark mode.

​https://bugs.webkit.org/show_bug.cgi?id=186677
rdar://problem/41162899

Reviewed by Wenson Hsieh.

  • rendering/RenderThemeMac.mm:

(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
Dark mode controls don't have borders, just a semi-transparent background of shadows.
In the dark mode case we can't disable borders, or we will not paint anything for the control.

10:32 AM Changeset in webkit [232879] by pvollan@apple.com
  • 4 edits in trunk/Source/WebKit

Rollout r231818, as it introduced regression on tickets.com.
​https://bugs.webkit.org/show_bug.cgi?id=186675

Unreviewed, rolling out.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):

  • UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::pause): Deleted.
(WebKit::DisplayLink::resume): Deleted.

  • UIProcess/mac/DisplayLink.h:
10:17 AM Changeset in webkit [232878] by timothy@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

Update results for fast/css/apple-system-control-colors.html

​https://bugs.webkit.org/show_bug.cgi?id=186668

Unreviewed test gardening.

  • fast/css/apple-system-control-colors-expected.txt: Updated for 10.13.
  • platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt: Copied from LayoutTests/fast/css/apple-system-control-colors-expected.txt.
10:16 AM Changeset in webkit [232877] by Jonathan Bedard
  • 7 edits in trunk/Tools

Add iOS 12 and watchOS 5 to webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=186285

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

Trigger the right build queues for iOS 12 on check-in.

  • Scripts/webkitpy/common/version_name_map.py:

(VersionNameMap.init): Add iOS 12, tvOS 12 and watchOS 5.

  • Scripts/webkitpy/common/version_name_map_unittest.py:

(VersionMapTestCase.test_ios_name_by_version): Test iOS 12 version-name mapping.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):

  • Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):

9:26 AM Changeset in webkit [232876] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC] Fix static position left/top
​https://bugs.webkit.org/show_bug.cgi?id=186640

Reviewed by Antti Koivisto.

In visual formatting model, we normally go like [top, left] while LayoutPoint takes [x, y]. Let's make this less error prone.

  • layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::Position::operator LayoutPoint const):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):

9:19 AM Changeset in webkit [232875] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=180171

Unreviewed.

As per dashboard, test is no longer flaky.
There might be a need to update it when bots have VCP support enabled.

  • platform/mac/TestExpectations:

Removed flaky expectation.

9:16 AM Changeset in webkit [232874] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Crash under WebCore::SWServer::registrationStoreImportComplete()
​https://bugs.webkit.org/show_bug.cgi?id=186644
<rdar://problem/40982257>

Reviewed by Brady Eidson.

Fix lifetime management issues with RegistrationDatabase. RegistrationDatabase
was previously subclassing CrossThreadTaskHandler. CrossThreadTaskHandler
currently is not safe for objects that can get destroyed (such as
RegistrationDatabase). This is because it does not keep the object alive
when going to the background thread or back to the main thread. This would
cause crashes such as the one in the radar.

To address the issue, stop subclassing CrossThreadTaskHandler and use a
simple WorkQueue instead. RegistrationDatabase is now ThreadSafeRefCounted
and we take care of ref'ing it whenever we dispatch a task to the work queue
or back to the main thread. Because the RegistrationDatabase can now outlive
the RegistrationStore, m_store is now a WeakPtr.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::RegistrationDatabase):
(WebCore::RegistrationDatabase::~RegistrationDatabase):
(WebCore::RegistrationDatabase::postTaskToWorkQueue):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::importRecordsIfNecessary):
(WebCore::RegistrationDatabase::pushChanges):
(WebCore::RegistrationDatabase::clearAll):
(WebCore::RegistrationDatabase::importRecords):
(WebCore::RegistrationDatabase::addRegistrationToStore):
(WebCore::RegistrationDatabase::databaseFailedToOpen):
(WebCore::RegistrationDatabase::databaseOpenedAndRecordsImported):

  • workers/service/server/RegistrationDatabase.h:

(WebCore::RegistrationDatabase::create):

  • workers/service/server/RegistrationStore.cpp:

(WebCore::RegistrationStore::RegistrationStore):
(WebCore::RegistrationStore::~RegistrationStore):
(WebCore::RegistrationStore::pushChangesToDatabase):
(WebCore::RegistrationStore::clearAll):

  • workers/service/server/RegistrationStore.h:
9:12 AM Changeset in webkit [232873] by youenn@apple.com
  • 4 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/service-workers/service-worker/fetch-frame-resource.https.html is flaky due to the order of some console log messages
​https://bugs.webkit.org/show_bug.cgi?id=186661

Unreviewed.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt:

LayoutTests:

9:03 AM Changeset in webkit [232872] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions
​https://bugs.webkit.org/show_bug.cgi?id=185611

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-06-15
Reviewed by Chris Dumez.

Otherwise we might segfault.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getLaunchOptions):

9:00 AM Changeset in webkit [232871] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC] Align compute functions styles.
​https://bugs.webkit.org/show_bug.cgi?id=186649

Reviewed by Antti Koivisto.

Improve code readability.

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
(WebCore::Layout::computedValueIfNotAuto): Deleted.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):

8:01 AM Changeset in webkit [232870] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC] Add FormattingContextLayout logging channel
​https://bugs.webkit.org/show_bug.cgi?id=186637

Reviewed by Antti Koivisto.

Add some basic layout logging (-WebCoreLogging "FormattingContextLayout").

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

  • layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::TreeBuilder::showLayoutTree):
(WebCore::Layout::printLayoutTreeForLiveDocuments):

  • layout/layouttree/LayoutTreeBuilder.h:
  • platform/Logging.h:
7:50 AM Changeset in webkit [232869] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[WPE][GTK][WebGL] Layout test fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=181659
<rdar://problem/39175593>

Unreviewed. Miguel has verified that it's OK for this test to fail, so skip it.

  • platform/gtk/TestExpectations:
5:30 AM Changeset in webkit [232868] by graouts@webkit.org
  • 5 edits in trunk

[Web Animations] CSS Animations should take precedence over CSS Transitions
​https://bugs.webkit.org/show_bug.cgi?id=186651

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark some progressions in the Mozilla CSS Animations and CSS Transitions tests.

  • css-animations/test_element-get-animations-expected.txt:
  • css-transitions/test_document-get-animations-expected.txt:

Source/WebCore:

Ensure CSS Animations override CSS Transitions by modifying the order in which animations are returned by animationsForElement().

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationsForElement const):

Jun 14, 2018:

11:28 PM Changeset in webkit [232867] by sbarati@apple.com
  • 2 edits in trunk/Tools

sun spider compile time benchmark fails in run-jsc-benchmarks with JSC_validateOptions=1
​https://bugs.webkit.org/show_bug.cgi?id=186647

Reviewed by Yusuke Suzuki.

Let's use unset JSC_useBlah instead of export JSC_useBlah= to clear environment
variables. The latter was causing crashes with when JSC_validateOptions was true.

  • Scripts/run-jsc-benchmarks:
7:11 PM Changeset in webkit [232866] by clopez@igalia.com
  • 3 edits in trunk/Tools

[GTK][buildbot] Raise timeouts for the step benchmark-test on the GTK perf bot
​https://bugs.webkit.org/show_bug.cgi?id=186635

Reviewed by Michael Catanzaro.

The current maximum timeout for a run-benchmark test is 1800 (Motionmark plan),
but the buildbot default timeout for the whole step without text output is 1200.
That means that a timeout on a single test can cause a whole step abort because
the buildbot one will trigger first.

Set the benchmark-test step timeout to 2000 to avoid this.

When this benchmark-test was added in r197505 it was already added with a higher
timeout than default (1500) due to the above problem, but it seems this has been
ignored so far because buildbot won't accept the timeout to be set on the class
definition (not even on the class constructor).
The new timeout has to be defined in the addStep call itself.
I have double-checked that by testing locally with the script run-buildbot-test.py
And this upstream issue confirms that ​https://github.com/buildbot/buildbot/issues/3887

  • BuildSlaveSupport/build.webkit.org-config/factories.py:

(BuildAndPerfTestFactory.init):
(DownloadAndPerfTestFactory.init):

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunBenchmarkTests):

6:53 PM Changeset in webkit [232865] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark tests that are failing on the EWS test queue (v2)

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations:
6:20 PM Changeset in webkit [232864] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Use new jQuery file layout
​https://bugs.webkit.org/show_bug.cgi?id=186636

Patch by Roy Reapor <​rreapor@apple.com> on 2018-06-14
Reviewed by Aakash Jain.

Tools:

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
  • TestResultServer/static-dashboards/run-embedded-unittests.html:

Websites/webkit.org:

  • ajax/libs/jqueryui/jquery-ui-1.8.15.css: Removed.
  • ajax/libs/jqueryui/jquery-ui-1.8.15.min.js: Removed.
6:05 PM Changeset in webkit [232863] by youenn@apple.com
  • 22 edits in trunk/Source

Make NetworkProcess get cache storage parameters at creation of the CacheStorage engine
​https://bugs.webkit.org/show_bug.cgi?id=186166

Reviewed by Alex Christensen.

Source/WebCore:

Covered by existing tests.

  • platform/network/NetworkStorageSession.h:

(WebCore::NetworkStorageSession::cacheStorageDirectory const): Deleted.
(WebCore::NetworkStorageSession::setCacheStorageDirectory): Deleted.
(WebCore::NetworkStorageSession::cacheStoragePerOriginQuota const): Deleted.
(WebCore::NetworkStorageSession::setCacheStoragePerOriginQuota): Deleted.

Source/WebKit:

Make CacheStorage::Engine creation asynchronous.
Update Engine public methods be static methods taking a SessionID, which will be used to create the engine.

Add IPC methods to retrieve cache storage parameters from NetworkProcess to UIProcess.

Add NetworkProcessProxy ability to compute the cache storage parameters based on the SessionID.
For that purpose, make NetworkProcessProxy store a map of SessionID-to-WebsiteDataStore.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::cacheStorageParameters):
(WebKit::NetworkProcess::setCacheStorageParameters):
(WebKit::NetworkProcess::cacheStorageDirectory const): Deleted.
(WebKit::NetworkProcess::cacheStoragePerOriginQuota const): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):
(WebKit::CacheStorage::Engine::representation):
(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):
(WebKit::CacheStorage::Engine::Engine):
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::defaultEngine): Deleted.

  • NetworkProcess/cache/CacheStorageEngine.h:

(WebKit::CacheStorage::Engine::shouldPersist const):
(WebKit::CacheStorage::Engine::weakPtrFactory):
(WebKit::CacheStorage::Engine::create): Deleted.

  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):
(WebKit::CacheStorageEngineConnection::clearMemoryRepresentation):
(WebKit::CacheStorageEngineConnection::engineRepresentation):

  • NetworkProcess/cache/CacheStorageEngineConnection.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
(WebKit::WebsiteDataStoreParameters::privateSessionParameters):

  • Shared/WebsiteDataStoreParameters.h:

(): Deleted.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::removeSession):
(WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
(WebKit::WebProcessPool::pageEndUsingWebsiteDataStore):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::~WebsiteDataStore):

5:23 PM Changeset in webkit [232862] by Basuke Suzuki
  • 4 edits in trunk/Tools

[Win][MiniBrowser] Change to use WebKit by default if it's available
​https://bugs.webkit.org/show_bug.cgi?id=186633

When MiniBrowser is built with WebKit, use it by default. Also add command
line switch for WebKitLegacy.

Reviewed by Youenn Fablet.

  • MiniBrowser/win/Common.cpp:

(parseCommandLine):
(dllLauncherEntryPoint): Deleted.

  • MiniBrowser/win/Common.h:
  • MiniBrowser/win/WinMain.cpp:

(wWinMain):
(dllLauncherEntryPoint):

5:18 PM Changeset in webkit [232861] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark tests that are failing on the EWS test queue

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations:
5:07 PM Changeset in webkit [232860] by Basuke Suzuki
  • 2 edits in trunk/Source/WebKit

[Win] Add IPC error case for broken pipe
​https://bugs.webkit.org/show_bug.cgi?id=186445

Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.

Reviewed by Ryosuke Niwa.

  • Platform/IPC/win/ConnectionWin.cpp:

(IPC::Connection::readEventHandler):

4:53 PM Changeset in webkit [232859] by Matt Lewis
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r232823.

This caused both test timeouts and api failures.

Reverted changeset:

"[Mail] Use the Mail Viewer width as the base for resolving
horizontal viewport units"
​https://bugs.webkit.org/show_bug.cgi?id=186585
​https://trac.webkit.org/changeset/232823

4:21 PM Changeset in webkit [232858] by youenn@apple.com
  • 11 edits in trunk/Source/ThirdParty/libwebrtc

Activate -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
​https://bugs.webkit.org/show_bug.cgi?id=186615

Reviewed by Darin Adler.

Update xcconfig files to activate these compile flags.
Also enable -Wthread-safety since libwebrtc code is using some related attributes.
Update libwebrtc code base to accomodate these flags.

  • Configurations/libwebrtc.xcconfig:
  • Configurations/opus.xcconfig:
  • Configurations/usrsctp.xcconfig:
  • Source/webrtc/modules/audio_processing/beamformer/array_util.h:

(webrtc::DegreesToRadians): Make function constexpr.

  • Source/webrtc/modules/rtp_rtcp/source/rtp_utility.cc:

Make sure the destructor is never called.

  • Source/webrtc/rtc_base/logging.cc:

Update code to move streams_ from a static class member to a regular static function variable.

  • Source/webrtc/rtc_base/logging.h:
  • Source/webrtc/system_wrappers/source/clock.cc:

Make sure the destructor is never called.

3:08 PM Changeset in webkit [232857] by youenn@apple.com
  • 2 edits in trunk/Tools

TestWebKitAPI.WebKit.WKNavigationResponsePDFType fails after r232815
​https://bugs.webkit.org/show_bug.cgi?id=186631

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:

(TEST): Update PDF plug-in identifier.

2:48 PM Changeset in webkit [232856] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(232741): Crash running ARES-6
​https://bugs.webkit.org/show_bug.cgi?id=186630

Reviewed by Saam Barati.

The de-duplicating work in r232741 caused a bug in breakCriticalEdge() where it
treated edges between identical predecessor->successor pairs independently.
This fixes the issue by handling such edges once, using the added intermediate
pad for all instances of the edges between the same pairs.

  • dfg/DFGCriticalEdgeBreakingPhase.cpp:

(JSC::DFG::CriticalEdgeBreakingPhase::run):
(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge): Deleted.

2:44 PM Changeset in webkit [232855] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[test262-runner] Improve displayed settings, use rel paths
​https://bugs.webkit.org/show_bug.cgi?id=186626

Patch by Leo Balter <Leo Balter> on 2018-06-14
Reviewed by Michael Saboff.

Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.

  • Scripts/test262/Runner.pm:

(processCLI):
(getBuildPath):

2:41 PM Changeset in webkit [232854] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Test262-Runner: Add more information in the summarized stats
​https://bugs.webkit.org/show_bug.cgi?id=185749

Patch by Leo Balter <Leo Balter> on 2018-06-14
Reviewed by Michael Saboff.

This patch adds extra information in the summarized stats for the given results for each run.
This includes a total of files, a total of executed files and a time information per path and feature.

  • Scripts/test262/Runner.pm:

(summarizeResults):

2:40 PM Changeset in webkit [232853] by commit-queue@webkit.org
  • 2 edits in trunk/JSTests

Test262-Runner: Update config list with some failing tests
​https://bugs.webkit.org/show_bug.cgi?id=185628

Patch by Leo Balter <Leo Balter> on 2018-06-14
Reviewed by Michael Saboff.

The config list is updated to match some slow / hanging tests that are currenctly failing
due to the length used in Array or Array like objects.

This also adds matching bugs for known features that are still in progress and not enabled
yet.

  • test262/config.yaml:
2:11 PM Changeset in webkit [232852] by n_wang@apple.com
  • 3 edits
    2 adds in trunk

AX: Crash in AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 536
​https://bugs.webkit.org/show_bug.cgi?id=186629

Reviewed by Chris Fleizach.

Source/WebCore:

This crashed when we passed a null node to ancestorsOfType. Fixed it
by adding a null check.

Test: accessibility/hidden-object-text-value-crash.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement const):

LayoutTests:

  • accessibility/hidden-object-text-value-crash-expected.txt: Added.
  • accessibility/hidden-object-text-value-crash.html: Added.
1:26 PM Changeset in webkit [232851] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Minor layout fix for WebKit Feature Status Page
​https://bugs.webkit.org/show_bug.cgi?id=186539

Reviewed by Timothy Hatcher.

  • wp-content/themes/webkit/status.php: Added padding below the bottom paragraph.
1:06 PM Changeset in webkit [232850] by wilander@apple.com
  • 5 edits
    4 adds in trunk

Resource Load Statistics: Shortcut classification for redirect to prevalent resource
​https://bugs.webkit.org/show_bug.cgi?id=186627
<rdar://problem/41132308>

Reviewed by Brent Fulgham.

Source/WebKit:

This patch shortcuts classification of redirect collusion so that we more seldom
have to rely on the recursive backtrace of the redirect graph. The initial
implementation of Resource Load Statistics actually had this classification method.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::markAsPrevalentIfHasRedirectedToPrevalent):

Iterates through a non-classified resource's data for where it has redirected
and classifies it as prevalent if has redirected to

(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):

Now calls WebResourceLoadStatisticsStore::markAsPrevalentIfHasRedirectedToPrevalent()
before regular classification steps.

  • UIProcess/WebResourceLoadStatisticsStore.h:

LayoutTests:

  • http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-to-prevalent-expected.txt: Added.
  • http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-to-prevalent.html: Added.
  • http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-to-prevalent-expected.txt: Added.
  • http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-to-prevalent.html: Added.
  • platform/wk2/TestExpectations:

New tests marked as [ Pass ].

12:59 PM Changeset in webkit [232849] by youenn@apple.com
  • 5 edits
    3 adds in trunk

Apply CSP checks before Content blocker checks in NetworkLoadChecker as done by CachedResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=186550

Reviewed by Alex Christensen.

Source/WebKit:

Do CSP checks and URL upgrade before content blocker checks.

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::continueCheckingRequest):

LayoutTests:

  • http/tests/contentextensions/fetch-redirect-blocked-expected.txt: Added.
  • http/tests/contentextensions/fetch-redirect-blocked.html: Added.
  • http/tests/contentextensions/fetch-redirect-blocked.html.json: Added.
  • http/tests/contentextensions/resources/subresource-redirect.php:
12:58 PM Changeset in webkit [232848] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Plug-in Process crashing on Mojave (affects Flash, others)
​https://bugs.webkit.org/show_bug.cgi?id=186628
<rdar://problem/41120462>

Reviewed by Eric Carlson.

Add the missing “com.apple.security.cs.allow-unsigned-executable-memory” entitlement. Also alphabetize
the entitlements file to make it easier to read.

  • Configurations/PluginService.entitlements:
12:16 PM Changeset in webkit [232847] by timothy@apple.com
  • 8 edits in trunk

Expose more semantic system colors.

​https://bugs.webkit.org/show_bug.cgi?id=186609
rdar://problem/39287277

Reviewed by Tim Horton.

Source/WebCore:

Add the following semantic colors:

-apple-system-control-accent
-apple-system-even-alternating-content-background
-apple-system-odd-alternating-content-background
-apple-system-selected-content-background
-apple-system-unemphasized-selected-content-background
-apple-system-selected-text
-apple-system-unemphasized-selected-text
-apple-system-selected-text-background
-apple-system-unemphasized-selected-text-background
-apple-system-placeholder-text
-apple-system-find-highlight-background
-apple-system-separator

  • css/CSSValueKeywords.in:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const):

Source/WebCore/PAL:

  • pal/spi/cocoa/NSColorSPI.h: Added findHighlightColor and placeholderTextColor.

LayoutTests:

  • fast/css/apple-system-control-colors.html: Updated for new colors.
  • fast/css/apple-system-control-colors-expected.txt: Ditto.
11:04 AM Changeset in webkit [232846] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Eliminate static initializers in libwebrtc.dylib
​https://bugs.webkit.org/show_bug.cgi?id=186570
<rdar://problem/41054874>

Reviewed by Darin Adler.

  • Source/webrtc/rtc_base/flags.h:

Fix memory corruption error by having the actual flag value be static.

11:02 AM Changeset in webkit [232845] by aakash_jain@apple.com
  • 1 edit
    65 adds in trunk/Websites/webkit.org

jQuery UI image assets are missing on webkit.org website.
​https://bugs.webkit.org/show_bug.cgi?id=185949

Patch by Roy Reapor <​rreapor@apple.com> on 2018-06-14
Reviewed by Aakash Jain.

  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_flat_75_ffffff_40x100.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_glass_65_ffffff_1x400.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_glass_75_dadada_1x400.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_glass_95_fef1ec_1x400.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-icons_222222_256x240.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-icons_2e83ff_256x240.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-icons_454545_256x240.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-icons_888888_256x240.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/images/ui-icons_cd0a0a_256x240.png: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery-ui.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.accordion.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.all.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.autocomplete.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.base.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.button.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.core.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.datepicker.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.dialog.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.progressbar.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.resizable.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.selectable.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.slider.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.tabs.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/themes/base/jquery.ui.theme.min.css: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery-ui.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.blind.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.bounce.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.clip.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.core.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.drop.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.explode.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fade.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.fold.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.highlight.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.pulsate.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.scale.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.shake.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.slide.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.effects.transfer.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.accordion.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.autocomplete.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.button.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.core.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.datepicker.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.dialog.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.draggable.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.droppable.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.mouse.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.position.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.progressbar.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.resizable.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.selectable.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.slider.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.sortable.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.tabs.min.js: Added.
  • ajax/libs/jqueryui/1.8.15/ui/jquery.ui.widget.min.js: Added.
10:57 AM Changeset in webkit [232844] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Enable tests on the GTK EWS queue
​https://bugs.webkit.org/show_bug.cgi?id=186559

Reviewed by Michael Catanzaro.

Enable testing for the gtk-wk2 EWS queue.

  • Scripts/webkitpy/common/config/ews.json:
10:57 AM Changeset in webkit [232843] by Basuke Suzuki
  • 3 edits in trunk/Source/WebKitLegacy/win

[Win] Fix build break after r232815 (SupportedPluginIdentifier)
​https://bugs.webkit.org/show_bug.cgi?id=186623

Reviewed by Youenn Fablet.

  • WebCoreSupport/WebPluginInfoProvider.cpp:

(WebPluginInfoProvider::pluginInfo):
(WebPluginInfoProvider::webVisiblePluginInfo):

  • WebCoreSupport/WebPluginInfoProvider.h:
10:49 AM Changeset in webkit [232842] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] WebAVPlayerController isPlayingOnSecondScreen should be declared read-write
​https://bugs.webkit.org/show_bug.cgi?id=186621
<rdar://problem/40243303>

Reviewed by Jer Noble.

  • platform/ios/WebAVPlayerController.h:
10:49 AM Changeset in webkit [232841] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[test262-runner] Test output should summarize tests that are
unexpectedly passing/failing.
​https://bugs.webkit.org/show_bug.cgi?id=186527

Patch by Valerie R Young <​valerie@bocoup.com> on 2018-06-14
Reviewed by Michael Saboff.

  • Scripts/test262/Runner.pm:

(main):

In verbose mode, a summary of all new failing tests
and all new passing tests are printed at the end of
the script output.

8:55 AM WebKitGTK/Gardening/Calendar edited by magomez@igalia.com
(diff)
7:31 AM Changeset in webkit [232840] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening after r232834.

  • platform/gtk/TestExpectations:
7:27 AM Changeset in webkit [232839] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[LFC] Miscellaneous fixes to be able to layout <div> with fixed width/height
​https://bugs.webkit.org/show_bug.cgi?id=186616

Reviewed by Antti Koivisto.

  1. Move box horizontally/vertically when relevant margin is computed.
  2. Fix isStretchedToViewport() logic and make sure that the width/height is adjusted with the margin when the box is stretchy.
  3. Fix isPaddingApplicable() and add "GenericElement" for elements that don't need special handling.

With this patch LFC produces the correct geometry for the following content:
<html><body><div style="width: 100px; height: 100px;"></div></body></html>

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeInFlowWidthAndMargin const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::isStretchedToViewport):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

  • layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::moveHorizontally):
(WebCore::Display::Box::moveVertically):
(WebCore::Display::Box::Rect::setWidth):
(WebCore::Display::Box::Rect::setHeight):
(WebCore::Display::Box::Rect::moveHorizontally):
(WebCore::Display::Box::Rect::moveVertically):

  • layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isPaddingApplicable const):

  • layout/layouttree/LayoutBox.h:
  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

3:27 AM Changeset in webkit [232838] by Adrian Perez de Castro
  • 1 copy in releases/WPE WebKit/webkit-2.20.1

WPE WebKit 2.20.1

3:24 AM Changeset in webkit [232837] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.20/Source

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.20.1 release.

3:24 AM Changeset in webkit [232836] by Adrian Perez de Castro
  • 10 edits in releases/WebKitGTK/webkit-2.20

Merged r232832 - [WPE] Trying to access the remote inspector hits an assertion in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=186588

Reviewed by Carlos Garcia Campos.

Make both the WPE and GTK+ ports use /org/webkit/inspector as base prefix
for resource paths, which avoids needing a switcheroo depending on the port.

Source/JavaScriptCore:

  • inspector/remote/glib/RemoteInspectorUtils.cpp:

Source/WebKit:

  • UIProcess/API/wpe/WebKit2InspectorGResourceBundle.xml:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/wpe/WebInspectorProxyWPE.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

  • WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::localizedStringsURL):
(WebKit::RemoteWebInspectorUI::localizedStringsURL):

Tools:

  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::inspectorTestStubURL):

  • glib/generate-inspector-gresource-manifest.py:
3:24 AM Changeset in webkit [232835] by Adrian Perez de Castro
  • 8 edits in releases/WebKitGTK/webkit-2.20/Source/JavaScriptCore

Merged r232816 - [LLInt] use loadp consistently for get_from_scope/put_to_scope
​https://bugs.webkit.org/show_bug.cgi?id=132333

Patch by Caitlin Potter <​caitp@igalia.com> on 2018-06-13
Reviewed by Mark Lam.

Using loadis for register indexes and loadp for constant scopes /
symboltables makes sense, but is problematic for big-endian
architectures.

Consistently treating the operand as a pointer simplifies determining
how to access the operand, and helps avoid bad accesses and crashes on
big-endian ports.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

  • bytecode/Instruction.h:
  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):

2:23 AM WebKitGTK/2.20.x edited by Adrian Perez de Castro
(diff)
1:57 AM Changeset in webkit [232834] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK][WPE] MiniBrowsers should be able to ignore TLS errors
​https://bugs.webkit.org/show_bug.cgi?id=186557

Reviewed by Carlos Garcia Campos.

Add the --ignore-tls-errors flags to the GTK and WPE MiniBrowsers.
Enabling the flag enforces ignoring of TLS errors that occur during
load. This is primarily useful for loading test cases from the wpt or
run-webkit-httpd servers where testing-purpose certificates are used.

  • MiniBrowser/gtk/main.c:

(main):

  • MiniBrowser/wpe/main.cpp:

(main):

1:41 AM WebKitGTK/2.20.x edited by Adrian Perez de Castro
(diff)
1:21 AM WebKitGTK/2.20.x edited by tpopela@redhat.com
(diff)
12:23 AM Changeset in webkit [232833] by Carlos Garcia Campos
  • 17 edits in trunk/Source

[GTK][WPE] WebDriver: handle acceptInsecureCertificates capability
​https://bugs.webkit.org/show_bug.cgi?id=186560

Reviewed by Brian Burg.

Source/JavaScriptCore:

Add SessionCapabilities struct to Client class and unify requestAutomationSession() methods into a single one
that always receives the session capabilities.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::receivedAutomationSessionRequestMessage): Move the parsing of mac capabilities from
WebKit here and fill the SessionCapabilities instead.

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::requestAutomationSession): Pass SessionCapabilities to the client.

  • inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::startAutomationSession): Process SessionCapabilities.

  • inspector/remote/glib/RemoteInspectorServer.h:

Source/WebDriver:

Send session capabilities as part of the StartAutomationSession message. For now only acceptInsecureCerts
capability is sent.

  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::startAutomationSession):

  • gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformCapabilities): Remove default value of acceptInsecureCerts, since that's
now handled by the browser.

  • wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformCapabilities): Ditto.

Source/WebKit:

  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionCreate): Check the acceptInsecureCertificates capability and set the TLS error policy in
the WebContext accordingly if needed.

  • UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
  • UIProcess/API/glib/WebKitWebContext.cpp:
  • UIProcess/Cocoa/AutomationClient.h:
  • UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::requestAutomationSession): Use SessionCapabilities to fill the session configuration.
(WebKit::AutomationClient::requestAutomationSessionWithCapabilities): Deleted.

Note: See TracTimeline for information about the timeline view.