Timeline

Jun 27, 2018:

11:55 PM Fuchsia edited by abarth@webkit.org

(diff)

9:46 PM Fuchsia edited by abarth@webkit.org

(diff)

9:45 PM Fuchsia created by abarth@webkit.org

9:25 PM Changeset in webkit [233300] by timothy@apple.com

• 5 edits in trunk/Source

Don't expose new semantic -apple-system color keywords on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=187080
rdar://problem/41505699

Reviewed by Tim Horton.

• DerivedSources.make: Use gnu++14, since gnu++17 is giving errors on macOS 10.12.

Source/WebCore:

• css/CSSValueKeywords.in: Define new semantic colors only on macOS.

9:19 PM Changeset in webkit [233299] by dbates@webkit.org

• 6 edits
  11 adds in trunk/Tools

Add some tests for lldb_webkit.py
​https://bugs.webkit.org/show_bug.cgi?id=183744

Reviewed by Alexey Proskuryakov.

Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
and WTF::String objects.

The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
on Mac.

• Makefile: Build the simple test tool lldbWebKitTester on Mac.
• Scripts/build-lldbwebkittester: Added.

(buildProjectOrDie):

• Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module

from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
the file and take advantage of Python's default error semantics to throw an exception
if the import fails instead of handling it ourself. This has the side effect that we
now always import the LLDB Python module even if this script is invoked with --help.
If this turns out to be a significant annoyance then we can look to dynamically import
the module as we did before this change.
(webkit_build_dir):
(main):
(developer_dir): Deleted.
(import_lldb): Deleted.

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect

that fact that test-webkitpy does not support class and module fixtures. This is because
test-webkitpy currently implements parallelism by breaking down existing test classes
into individual test methods itself and having each worker run exactly one test method (via
unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
setUpModule()/setUpClass() are called for each test method as opposed to once per test
class/test module.
(remove_dir): Ditto.

• Scripts/webkitpy/common/system/systemhost.py:

(SystemHost):
(SystemHost.path_to_lldb_python_directory): Added.

• Scripts/webkitpy/test/main.py:

(_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
(_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
lldbWebKitTester on Mac.
(main): Add Tools/lldb to the test search path if the platform has lldb.py.
(Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
(Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
If we will run these tests then build lldbWebKitTester if it has not already been built as the
unit tests depend on this program.

• lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
• lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
• lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
• lldb/lldbWebKitTester/Makefile: Added.
• lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
• lldb/lldbWebKitTester/main.cpp: Added.

(breakForTestingSummaryProviders):
(utf16String):
(testSummaryProviders):
(main):

• lldb/lldb_webkit_unittest.py: Added.

(destroy_cached_debug_session):
(LLDBDebugSession):
(LLDBDebugSession.setup):
(LLDBDebugSession.tearDown):
(TestSummaryProviders):
(TestSummaryProviders.setUpClass):
(TestSummaryProviders._sbFrame):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):

8:05 PM Changeset in webkit [233298] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC] Compute both the collapsed and the non-collapsed margin values.
​https://bugs.webkit.org/show_bug.cgi?id=187129

Reviewed by Antti Koivisto.

For validation purposes only at this point.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):

6:57 PM Changeset in webkit [233297] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Align inFlowNonReplacedHeightAndMargin() style with the rest of the compute functions.
​https://bugs.webkit.org/show_bug.cgi?id=187126

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

6:29 PM Changeset in webkit [233296] by Megan Gardner

• 7 edits in trunk/Source/WebKit

Fix IBeam issues with iPad apps on Mac
​https://bugs.webkit.org/show_bug.cgi?id=186900

Reviewed by Wenson Hsieh.

• Shared/ios/InteractionInformationAtPosition.h:
• Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Add functionality to determine what a caret rect should be, but as it is
expensive, it should only be done for this platform.

• Shared/ios/InteractionInformationRequest.cpp:

(WebKit::InteractionInformationRequest::isApproximateForRequest):

• Shared/ios/InteractionInformationRequest.h:

As there is no way to premptively request information on hover, we need to use
the last cached information, but only if it is close to the point we are about
to request information for. So having a way to determine if a point is very close
to a previous point is a good idea.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _currentPositionInformationIsApproximateForRequest:]):
(-[WKContentView closestPositionToPoint:]):

UIKit is using this function to determine if we should show an Ibeam or not.
So we need to implement it, at least for this platform.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

Pass up the calculated caret rect, but only for iPad apps on Mac.

6:10 PM Changeset in webkit [233295] by Yusuke Suzuki

• 4 edits in trunk/Source

[GTK][WPE] Use LazyNeverDestroyed<XErrorTrapper> to remove static initializers
​https://bugs.webkit.org/show_bug.cgi?id=187089

Reviewed by Michael Catanzaro.

Source/WebCore:

Do not allow copying since XErrorTrapper's logic relies on the address of XErrorTrapper.

• platform/graphics/x11/XErrorTrapper.h:

Source/WebKit:

Use LazyNeverDestroyed<XErrorTrapper> instead of global std::unique_ptr<XErrorTrapper>.
Since this variable's exit time destructor is not important in this code, using
LazyNeverDestroyed<XErrorTrapper> is fine. This removes the last static initializer
of libwebkit2gtk.so.

• PluginProcess/unix/PluginProcessMainUnix.cpp:

6:04 PM Changeset in webkit [233294] by abarth@webkit.org

• 4 edits
  1 add in trunk

Add Fuchsia support to build-jsc
​https://bugs.webkit.org/show_bug.cgi?id=187086

Reviewed by Yusuke Suzuki.

.:

Add Fuchsia port to cmake build system. After this patch, the build
errors out due to a missing sysroot.

• CMakeLists.txt:
• Source/cmake/OptionsFuchsia.cmake: Added.

Tools:

Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
build-jsc kick off a cmake for Fuchsia.

• Scripts/webkitdirs.pm:

(determineSourceDir):
(argumentsForConfiguration):
(determineXcodeSDK):
(findMatchingArguments):
(determinePortName):
(isFuchsia):
(setupAppleWinEnv):
(wrapperPrefixIfNeeded):
(relaunchIOSSimulator):
(debugMiniBrowser):

5:32 PM Changeset in webkit [233293] by Kocsen Chung

• 2 edits in tags/Safari-606.1.23/Source/WebCore

Cherry-pick r233279. rdar://problem/41539197

Crash under SWServer::unregisterServiceWorkerClient()
​https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>

Reviewed by Youenn Fablet.

Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.

To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.

• workers/service/server/SWServer.cpp: (WebCore::SWServer::~SWServer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@233279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:25 PM Changeset in webkit [233292] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/blink/storage/indexeddb/blob-delete-objectstore-db.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172864

Unreviewed test gardening.

• TestExpectations:

5:18 PM Changeset in webkit [233291] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Add some more register state information when we crash in repatchPutById
​https://bugs.webkit.org/show_bug.cgi?id=187112

Reviewed by Mark Lam.

This will help us gather info when we end up seeing a ObjectPropertyConditionSet
with an offset that is different than what the put tells us.

• jit/Repatch.cpp:

(JSC::tryCachePutByID):

5:15 PM Changeset in webkit [233290] by youenn@apple.com

• 2 edits in trunk/LayoutTests

Rebase LayoutTests/http/tests/contentextensions/subresource-redirect-blocked-expected.txt after r233269
​https://bugs.webkit.org/show_bug.cgi?id=187125

Unreviewed.

• http/tests/contentextensions/subresource-redirect-blocked-expected.txt:

4:46 PM Changeset in webkit [233289] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Align inFlowNonReplacedWidthAndMargin() style with the rest of the compute functions.
​https://bugs.webkit.org/show_bug.cgi?id=187124

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):

4:43 PM Changeset in webkit [233288] by dbates@webkit.org

• 4 edits in trunk/Tools

style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
​https://bugs.webkit.org/show_bug.cgi?id=187120

Reviewed by David Kilzer.

Teach the style queue how to refetch a patch from the status server as we did for non-Style
EWS queues.

• Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
only check if the bug associated with the patch we are processing is closed if the attachment has a
non-None Bug object.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...

• Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._refetch_patch): ... to here.
(StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().

4:28 PM Changeset in webkit [233287] by krit@webkit.org

• 5 edits
  2 adds in trunk

-webkit-clip-path wrong offset for clipPath references
​https://bugs.webkit.org/show_bug.cgi?id=129246

Reviewed by Simon Fraser.

Source/WebCore:

Compute the correct offset for reference clip-paths by reusing
some of the logic from basic shapes.
Makes reference based clip-path interoperable and follows the
spec.

Test: css3/masking/clip-path-reference-2.html

• rendering/RenderLayer.cpp:

(WebCore::computeReferenceBox):
(WebCore::RenderLayer::computeClipPath const):
(WebCore::RenderLayer::setupClipPath):

LayoutTests:

Add test for reference clip-path offset. Correct a broken test.
All tests in the repo for references are interoperable between Gecko, Blink
and WebKit now.

• css3/masking/clip-path-reference-2-expected.html: Added.
• css3/masking/clip-path-reference-2.html: Added.
• css3/masking/clip-path-reference-userSpaceOnUse-expected.html:
• css3/masking/clip-path-reference-userSpaceOnUse.html:

4:22 PM Changeset in webkit [233286] by Tadeu Zagallo

• 2 edits in trunk/Tools

Unreviewed, add myself as a WebKit committer.

• Scripts/webkitpy/common/config/contributors.json:

4:13 PM Changeset in webkit [233285] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.println to print.
​https://bugs.webkit.org/show_bug.cgi?id=187119

Reviewed by Keith Miller.

$vm.callFrame()'s JSDollarVMCallFrame::finishCreation()
should be checking for codeBlock instead of !codeBlock
before using the codeBlock.

I also renamed some other "print" functions to use "dump" instead
to match their underlying C++ code that they will call e.g.
CodeBlock::dumpSource().

• tools/JSDollarVM.cpp:

(WTF::JSDollarVMCallFrame::finishCreation):
(JSC::functionDumpSourceFor):
(JSC::functionDumpBytecodeFor):
(JSC::doPrint):
(JSC::functionDataLog):
(JSC::functionPrint):
(JSC::functionDumpCallFrame):
(JSC::functionDumpStack):
(JSC::JSDollarVM::finishCreation):
(JSC::functionPrintSourceFor): Deleted.
(JSC::functionPrintBytecodeFor): Deleted.
(JSC::doPrintln): Deleted.
(JSC::functionPrintln): Deleted.
(JSC::functionPrintCallFrame): Deleted.
(JSC::functionPrintStack): Deleted.

• tools/VMInspector.cpp:

(JSC::DumpFrameFunctor::DumpFrameFunctor):
(JSC::DumpFrameFunctor::operator() const):
(JSC::VMInspector::dumpCallFrame):
(JSC::VMInspector::dumpStack):
(JSC::VMInspector::dumpValue):
(JSC::PrintFrameFunctor::PrintFrameFunctor): Deleted.
(JSC::PrintFrameFunctor::operator() const): Deleted.
(JSC::VMInspector::printCallFrame): Deleted.
(JSC::VMInspector::printStack): Deleted.
(JSC::VMInspector::printValue): Deleted.

• tools/VMInspector.h:

3:53 PM Changeset in webkit [233284] by youenn@apple.com

• 2 edits
  8 adds in trunk/Source/WebKit

Add a sandbox profile for some additional bank plugins
​https://bugs.webkit.org/show_bug.cgi?id=187105

Reviewed by Brent Fulgham.

• Resources/PlugInSandboxProfiles/cfca.com.npCryptoKit.CGB.MAC.sb: Added.
• Resources/PlugInSandboxProfiles/cfca.com.npP11CertEnroll.MAC.CGB.sb: Added.
• Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb: Added.
• Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb: Added.
• Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb: Added.
• Resources/PlugInSandboxProfiles/com.cfca.npSecEditCtl.MAC.BOC.plugin.sb: Added.
• Resources/PlugInSandboxProfiles/com.cmbchina.CMBSecurity.sb: Added.
• Resources/PlugInSandboxProfiles/com.ftsafe.NPAPI-Core-Safe-SoftKeybaord.plugin.rfc1034identifier.sb: Added.
• WebKit.xcodeproj/project.pbxproj:

3:49 PM Changeset in webkit [233283] by Jonathan Bedard

• 3 edits in trunk/Source/WebCore/PAL

Build fix after r233266
​https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>

Unreviewed build fix.

• pal/cf/CoreMediaSoftLink.cpp: Do not soft-link CMSampleBufferCallForEachSample for

iOS 12 and up on iPhone device and simulator.

• pal/cf/CoreMediaSoftLink.h: Ditto.

3:43 PM Changeset in webkit [233282] by bshafiei@apple.com

• 7 edits in trunk/Source

Versioning.

3:25 PM Changeset in webkit [233281] by Antti Koivisto

• 6 edits
  2 adds in trunk

Don't invoke post resolution callbacks when resolving computed style
​https://bugs.webkit.org/show_bug.cgi?id=187113
<rdar://problem/41365766>

Reviewed by Geoff Garen.

Source/WebCore:

Post-resolution callbacks should only be invoked when we resolve the full document style,
not when resolving computed style for a single element.

Tests: fast/dom/object-computed-style-event.html

• dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

• dom/Element.cpp:

(WebCore::Element::resolveComputedStyle):

Also ref the ancestor stack to be safe.

• style/StyleTreeResolver.cpp:

(WebCore::Style::PostResolutionCallbackDisabler::PostResolutionCallbackDisabler):
(WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):

Add an option to not drain the callback queue on destruction. In this mode we
just block network loads.

• style/StyleTreeResolver.h:

LayoutTests:

• fast/dom/object-computed-style-event-expected.txt: Added.
• fast/dom/object-computed-style-event.html: Added.

3:14 PM Changeset in webkit [233280] by timothy@apple.com

• 13 edits in trunk

Find on page selection color isn't adapted for dark mode.
​https://bugs.webkit.org/show_bug.cgi?id=187072
rdar://problem/40354841

Reviewed by Tim Horton.

Source/WebCore:

• page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Use [NSColor findHighlightColor].

• platform/mac/LocalDefaultSystemAppearance.h:

(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): Added.

• platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Set m_usingDarkAppearance.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Use TextPaintPhase::Decoration since this
matches step three of InlineTextBox::paint ("Paint fancy decorations"). This allows TextMatch to
paint a forground and not end up painting during this "fancy decorations" phase.
(WebCore::InlineTextBox::resolveStyleForMarkedText): Set the fillColor for TextMarker to force a
dark text color which will draw over the yellow highlight.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Added support for TextPaintPhase::Decoration.
Seperate DocumentMarker::TelephoneNumber and DocumentMarker::TextMatch. Have DocumentMarker::TextMatch
support Forground and Background phases.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):
(WebCore::RenderTheme::activeTextSearchHighlightColor const): Added. Call the platfrom version.
(WebCore::RenderTheme::inactiveTextSearchHighlightColor const): Added. Ditto.
(WebCore::RenderTheme::platformActiveTextSearchHighlightColor const): Added StyleColor::Options.
(WebCore::RenderTheme::platformInactiveTextSearchHighlightColor const): Ditto.

• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformInactiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformColorsDidChange): Clear new color caches.
(WebCore::RenderThemeMac::systemColor const): Cache system colors by light and dark mode.

LayoutTests:

• fast/css/apple-system-control-colors-expected.txt: Updated.
• fast/text/mark-matches-broken-line-rendering-expected.html: Ditto.
• fast/text/mark-matches-rendering-expected.html: Ditto.

2:43 PM Changeset in webkit [233279] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Crash under SWServer::unregisterServiceWorkerClient()
​https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>

Reviewed by Youenn Fablet.

Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.

To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::~SWServer):

2:26 PM Changeset in webkit [233278] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add logging to try to diagnose where we get a null structure.
​https://bugs.webkit.org/show_bug.cgi?id=187106

Reviewed by Mark Lam.

Add a logging to JSObject::toPrimitive to help diagnose a nullptr
structure crash.

This code should be removed when we fix <rdar://problem/33451840>

• runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):

• runtime/JSObject.h:

(JSC::JSObject::getPropertySlot):

2:15 PM Changeset in webkit [233277] by youenn@apple.com

• 9 edits in trunk/Source

NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess
​https://bugs.webkit.org/show_bug.cgi?id=186551

Reviewed by Daniel Bates.

Source/WebCore:

No change of behavior.
Add a way to set the client receiving any CSP warning/error notification.

• page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::setClient):

Source/WebKit:

Removed the need for NetworkLoadChecker to reference a NetworkConnectionToWebProcess.
Instead a CSP client is given to NetworkLoadChecker when needed.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::check):
(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::contentSecurityPolicy):
(WebKit::NetworkLoadChecker::addConsoleMessage): Deleted.
(WebKit::NetworkLoadChecker::sendCSPViolationReport): Deleted.
(WebKit::NetworkLoadChecker::enqueueSecurityPolicyViolationEvent): Deleted.

• NetworkProcess/NetworkLoadChecker.h:
• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):

• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):

• NetworkProcess/PingLoad.h:

2:10 PM Changeset in webkit [233276] by dbates@webkit.org

• 3 edits in trunk/Tools

webkit-patch should ignore non-ASCII characters in the status server API key
​https://bugs.webkit.org/show_bug.cgi?id=187107

Reviewed by Lucas Forschler.

The API key should only consists of ASCII characters. If it contains any
non-ASCII characters then log a warning and ignore them.

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.set_api_key): Force conversion to ASCII.

• Scripts/webkitpy/tool/main.py:

(WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
characters and logging a warning.

1:10 PM Changeset in webkit [233275] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Do not collapse margin with the parent when element has border/padding.
​https://bugs.webkit.org/show_bug.cgi?id=187114

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):

1:01 PM Changeset in webkit [233274] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Fix Windows build after r233268.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::hasContents const):

• platform/graphics/ca/win/PlatformCALayerWin.h:

12:59 PM Changeset in webkit [233273] by youenn@apple.com

• 1 edit
  1 move
  6 adds in trunk/LayoutTests/imported/w3c

Add Cross-Origin-Resource-Policy tests for workers and service workers
​https://bugs.webkit.org/show_bug.cgi?id=187030

Reviewed by Chris Dumez.

• web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy/fetch.html.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker.html: Added.

12:23 PM Changeset in webkit [233272] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC] Out-of-flow positioned element's height depends on its containing block's height.
​https://bugs.webkit.org/show_bug.cgi?id=187082

Reviewed by Antti Koivisto.

We can't really compute the final height of an out-of-flow element until after its containing block's height is computed.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

• layout/FormattingContext.h:
• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::updateLayout):
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

• layout/LayoutContext.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

• layout/layouttree/LayoutContainer.h:

(WebCore::Layout::Container::outOfFlowDescendants const):
(WebCore::Layout::Container::outOfFlowDescendants): Deleted.

12:19 PM Changeset in webkit [233271] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebKit

[Wincairo] Add support for context menus to non-legacy minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=186815.

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2018-06-27
Reviewed by Ryosuke Niwa.

• UIProcess/WebPageProxy.h:
• UIProcess/win/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewWidget):

• UIProcess/win/PageClientImpl.h:
• UIProcess/win/WebContextMenuProxyWin.cpp:

(WebKit::WebContextMenuProxyWin::show):
(WebKit::createMenu):
(WebKit::createMenuItem):
(WebKit::populate):
(WebKit::WebContextMenuProxyWin::showContextMenuWithItems):
(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin):
(WebKit::WebContextMenuProxyWin::~WebContextMenuProxyWin):

• UIProcess/win/WebContextMenuProxyWin.h:
• UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::viewWidget):

• UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc):
(WebKit::WebView::onMenuCommand):

• UIProcess/win/WebView.h:

11:34 AM Changeset in webkit [233270] by Kocsen Chung

• 1 copy in tags/Safari-606.1.23

Tag Safari-606.1.23.

11:23 AM Changeset in webkit [233269] by youenn@apple.com

• 9 edits
  3 adds in trunk

Disable content blockers in NetworkLoadChecker except for ping loads
​https://bugs.webkit.org/show_bug.cgi?id=187083
<rdar://problem/41440083>

Reviewed by Chris Dumez.

Source/WebCore:

Add internals API to reload a frame without content extensions.

Test: http/tests/contentextensions/reload-without-contentextensions.html

• testing/Internals.cpp:

(WebCore::Internals::reloadWithoutContentExtensions):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::processContentExtensionRulesForLoad):

• NetworkProcess/NetworkLoadChecker.h:

(WebKit::NetworkLoadChecker::enableContentExtensionsCheck):

• NetworkProcess/PingLoad.cpp:

LayoutTests:

• http/tests/contentextensions/reload-without-contentextensions-expected.txt: Added.
• http/tests/contentextensions/reload-without-contentextensions.html: Added.
• http/tests/contentextensions/reload-without-contentextensions.html.json: Added.

11:22 AM Changeset in webkit [233268] by Simon Fraser

• 18 edits
  3 adds in trunk

​https://hackernoon.com/ uses lots of layer backing store
​https://bugs.webkit.org/show_bug.cgi?id=186909
rdar://problem/40257540

Reviewed by Tim Horton.

Source/bmalloc:

Drive-by typo fix.

• bmalloc/Scavenger.cpp:

(bmalloc::dumpStats):

Source/WebCore:

The existing "backing store detached" logic, which was used to eliminate backing store
for compositing layers outside the viewport, had a number of bugs that allowed layers
to have backing store when they should not.

Specifically, any code path that ended up in setNeedsDisplay{InRect}() in PlatformCALayer
could trigger backing store creation on layers that should have never had any.

Rather than monkeypatch all the GraphicsLayerCA call sites that call setNeedsDisplay{InRect}(),
just bail early from the PlatformCALayer* methods that trigger repaints.

Tests didn't catch this because they just dumped the state of the backingStoreAttached flag. To fix this,
create backingStoreAttachedForTesting() which also tests whether the layer has contents.

Test: compositing/backing/backing-store-attachment-outside-viewport.html

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties const):
(showGraphicsLayerTree):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::backingStoreAttachedForTesting const):

• platform/graphics/GraphicsLayerClient.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreAttachedForTesting const):
(WebCore::GraphicsLayerCA::setNeedsDisplay):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::setNeedsDisplay):
(PlatformCALayerCocoa::setNeedsDisplayInRect):
(PlatformCALayerCocoa::hasContents const):

Source/WebKit:

PlatformCALayerRemote was actually holding onto backing stores for layers with
backing store detached, which could increase memory use. When told that backing stores
are not attached, explicitly throw away the backing, and re-create it (via setNeedsDisplay)
when attached. This is now similar to what PlatformLayerCACocoa does.

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemote::setNeedsDisplay):
(WebKit::PlatformCALayerRemote::hasContents const):

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

LayoutTests:

New test.

• compositing/backing/backing-store-attachment-outside-viewport-expected.txt: Added.
• compositing/backing/backing-store-attachment-outside-viewport.html: Added.

11:07 AM Changeset in webkit [233267] by ddkilzer@apple.com

• 10 edits in trunk/Source/WebCore

Fix clang static analyzer warnings: Branch condition evaluates to a garbage value
<​https://webkit.org/b/186968>

Reviewed by Zalan Bujtas.

This patch changes two stack-allocated bool variables into
std::optional<bool> since the functions that set the variable
may return early without setting it. It also changes one
stack-allocated pointer to be initialized to nullptr.

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
Update for change to CSSPropertyAnimation::getPropertyAtIndex()
argument type.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard): Initialize
cachedImage stack pointer to nullptr since getImage() has an
early return that doesn't set cachedImage.

• editing/mac/EditorMac.mm:

(WebCore::Editor::writeImageToPasteboard): Ditto.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::getPropertyAtIndex):

• page/animation/CSSPropertyAnimation.h:

(WebCore::CSSPropertyAnimation::getPropertyAtIndex):

• Change method to take std::optional<bool> instead of bool as second argument since the method may return early without setting isShorthand.

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions): Update for
change to CSSPropertyAnimation::getPropertyAtIndex() argument
type.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Also
rename local emphasisMarkIsOver to emphasisMarkIsAbove to
match other call sites.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):

• Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

• Change method to take std::optional<bool> instead of bool as second argument since the method may return early without setting above.

(WebCore::InlineTextBox::paintMarkedTextForeground):

• Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
• rendering/InlineTextBox.h:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

• Change method to take std::optional<bool> instead of bool.

11:02 AM Changeset in webkit [233266] by Jonathan Bedard

• 17 edits
  1 copy
  19 adds in trunk

Enable WebKit iOS 12 build
​https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>

Reviewed by David Kilzer.

Source/WebCore/PAL:

• pal/cf/CoreMediaSoftLink.cpp: Condition some CoreMedia functions on version.
• pal/cf/CoreMediaSoftLink.h: Ditto.
• pal/spi/cocoa/NSXPCConnectionSPI.h: Use XPCSPI.h instead of xpc.h.
• pal/spi/ios/QuickLookSPI.h: QLItem adopts QLPreviewItem.
• pal/spi/ios/SystemPreviewSPI.h: Fix compiler errors.

Source/WebKit:

• Platform/spi/ios/PDFKitSPI.h: Added PDFKit SPI.
• Platform/spi/ios/UIKitSPI.h: Add new UIKit SPI and UICompositingMode enumeration.
• UIProcess/ios/WKPDFView.mm: Use PDFKitSPI header.
• UIProcess/ios/WKSystemPreviewView.mm: Use CoreGraphicsSPI.h.
• UIProcess/ios/fullscreen/WKFullscreenStackView.mm: Use QuartzCoreSPI.h.

Source/WTF:

• wtf/spi/darwin/XPCSPI.h: Add endpoint and connection declarations.

Tools:

• Scripts/configure-xcode-for-ios-development:

(copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/12: Added.

10:59 AM Changeset in webkit [233265] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

CSS Animation Triggers is not an experimental feature, should be globally off by default

Reviewed by Dean Jackson.

• Shared/WebPreferences.yaml:

10:41 AM Changeset in webkit [233264] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Promote the Secure Context API feature from experimental-yet-on-by-default to always-on

Reviewed by Dan Bates.

• Shared/WebPreferences.yaml:

Secure Context API is on by default, it's not experimental anymore.

10:38 AM Changeset in webkit [233263] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Make Link Preload an on-by-default feature
​https://bugs.webkit.org/show_bug.cgi?id=187104

Reviewed by Ryosuke Niwa.

• Shared/WebPreferences.yaml:

This should be on, not experimental. It already shipped on in the past.

10:01 AM Changeset in webkit [233262] by rmorisset@apple.com

• 2 edits in trunk/Tools

[WSL] Add a control-flow stack to the execution rules in WSL.ott
​https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

The goal of this is to enable (future) rules about uniform control flow for barriers.
It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.

9:36 AM Changeset in webkit [233261] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Regression(r233208): Completion handler does not get called on GTK port
​https://bugs.webkit.org/show_bug.cgi?id=187099

Reviewed by Antti Koivisto.

Make sure UpdatePrevalentDomainsToPartitionOrBlockCookiesHandler's completion handler
gets called on non-COCOA ports.

• UIProcess/WebResourceLoadStatisticsStore.h:

9:18 AM Changeset in webkit [233260] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Move formatting context root layout logic to a dedicated function.
​https://bugs.webkit.org/show_bug.cgi?id=187097

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):

• layout/blockformatting/BlockFormattingContext.h:

9:13 AM Changeset in webkit [233259] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Compute static position for out-of-flow elements only when required.
​https://bugs.webkit.org/show_bug.cgi?id=187096

Reviewed by Antti Koivisto.

Computing static position for out-of-flow elements could be somewhat expensive, so let's not do it unless we actually need it.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned): Deleted.

9:13 AM Changeset in webkit [233258] by Ms2ger@igalia.com

• 2 edits in trunk/WebDriverTests

[GTK][WPE] Update expectations for WebDriver tests.
​https://bugs.webkit.org/show_bug.cgi?id=187098

Unreviewed gardening.

• TestExpectations.json:

9:10 AM Changeset in webkit [233257] by n_wang@apple.com

• 3 edits
  2 adds
  2 deletes in trunk

AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
​https://bugs.webkit.org/show_bug.cgi?id=187076

Reviewed by Chris Fleizach.

Source/WebCore:

We shouldn't set keyboard focus when assistive technology takes focus since
this is causing website incompatibility issues by causing focus to be lost.

Test: accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):

LayoutTests:

• accessibility/ios-simulator/accessibility-focus-do-not-set-focus-expected.txt: Added.
• accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html: Added.
• accessibility/ios-simulator/dom-focus-fires-on-correct-element-expected.txt: Removed.
• accessibility/ios-simulator/dom-focus-fires-on-correct-element.html: Removed.

8:14 AM Changeset in webkit [233256] by rmorisset@apple.com

• 2 edits in trunk/Tools

[WSL] Fix minor formatting issues in the grammar section
​https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

8:07 AM Changeset in webkit [233255] by Michael Catanzaro

• 4 edits in trunk/Source/ThirdParty

MIME type subclass check should guard against small strings
​https://bugs.webkit.org/show_bug.cgi?id=186977

Reviewed by Carlos Garcia Campos.

Sadly, this code is duplicated between two different files because it is not good.

• xdgmime/README.webkit:
• xdgmime/src/xdgmime.c:

(ends_with):
(xdg_mime_is_super_type):

• xdgmime/src/xdgmimecache.c:

(ends_with):
(is_super_type):

8:04 AM Changeset in webkit [233254] by rmorisset@apple.com

• 3 edits in trunk/Tools

[WSL] Put the full grammar in the Sphinx document
​https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

Put the grammar's production rules in the Sphinx document, along with a few comments and the rules for desugaring.
Also includes a bit of clean-up of the antlr rules.

4:19 AM Changeset in webkit [233253] by mark.lam@apple.com

• 3 edits
  1 add in trunk

DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties.
​https://bugs.webkit.org/show_bug.cgi?id=187091
<rdar://problem/41395624>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/regress-187091.js: Added.

Source/JavaScriptCore:

Previously, when compileReallocatePropertyStorage() and compileAllocatePropertyStorage()
take their slow paths, the slow path would jump back to the fast path right after
the emitted code which clears the unused property values. As a result, the
unused properties are not initialized. We've fixed this by adding the slow path
generators before we emit the code to clear the unused properties.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

3:05 AM Changeset in webkit [233252] by Yusuke Suzuki

• 3 edits
  1 add in trunk

[JSC] ArrayPatternNode::emitDirectBinding does not return assignment target value if dst is nullptr
​https://bugs.webkit.org/show_bug.cgi?id=185943

Reviewed by Mark Lam.

JSTests:

• stress/direct-binding-return-result.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

ArrayPatternNode::emitDirectBinding should return a register with an assignment target instead of filling
the result with undefined if dst is nullptr. While dst == ignoredResult() means we do not require
the result, dst == nullptr just means "dst is required, but a register for dst is not allocated.".
This patch fixes emitDirectBinding to return an appropriate value with an allocated register for dst.

ArrayPatternNode::emitDirectBinding() should be removed later since it does not follow array spreading protocol,
but it should be done in a separate patch since it would be performance sensitive.

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

2:34 AM Changeset in webkit [233251] by emilio

• 2 edits in trunk/Source/WebCore

Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
​https://bugs.webkit.org/show_bug.cgi?id=186881

Reviewed by Antti Koivisto.

Every caller does this already.

No new tests, no change in behavior.

• style/StyleTreeResolver.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::TreeResolver::resolveComposedTree):

1:27 AM Changeset in webkit [233250] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

When trying to print a very long email on iOS, the print preview is blank
​https://bugs.webkit.org/show_bug.cgi?id=187077
<rdar://problem/41107013>

Reviewed by Timothy Hatcher.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,
(as opposed to Connection::sendSync's default timeout of ∞ seconds).
The printing path already waits ∞ seconds for the final PDF, but currently
uses the default 1 second timeout for page count computation. If page
count computation takes more than 1 second, the preview will be blank.
Since the print preview is generated asynchronously, we really want
to wait until it's done, and not give up after 1 second.

1:19 AM Changeset in webkit [233249] by Yusuke Suzuki

• 2 edits in trunk/Source/ThirdParty/libwebrtc

[GTK][WPE] Remove gflags from libwebrtc build
​https://bugs.webkit.org/show_bug.cgi?id=187078

Reviewed by Alejandro G. Castro.

gflags is used only in libyuv unit tests. So the Apple ports do not build & link it.
GTK and WPE can do the same thing: not building gflags. By doing so, we can achieve
the following results.

1. Remove static initializers defined for gflags.
2. Reduce binary size.

• CMakeLists.txt:

1:16 AM Changeset in webkit [233248] by tpopela@redhat.com

• 4 edits in trunk/Source/WebCore

[GStreamer] Coverity scan issues
​https://bugs.webkit.org/show_bug.cgi?id=187087

Reviewed by Xabier Rodriguez-Calvar.

Fix uninitialized members.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:

1:13 AM Changeset in webkit [233247] by zandobersek@gmail.com

• 3 edits
  1 add in trunk/Source/WebCore

[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
​https://bugs.webkit.org/show_bug.cgi?id=187033

Reviewed by Michael Catanzaro.

Move the GCryptUtilities helpers that operate on libgcrypt values and
constants into a separate source file. This limits a bit the amount of
inlining the compiler might feel compelled to do, and the resulting
shared library is 8kB smaller in size.

• crypto/gcrypt/GCryptUtilities.cpp: Copied from Source/WebCore/crypto/gcrypt/GCryptUtilities.h.

(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::mpiLength):
(WebCore::mpiData):
(WebCore::mpiZeroPrefixedData):
(WebCore::mpiSignedData):

• crypto/gcrypt/GCryptUtilities.h:

(WebCore::hmacAlgorithm): Deleted.
(WebCore::digestAlgorithm): Deleted.
(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::mpiLength): Deleted.
(WebCore::mpiData): Deleted.
(WebCore::mpiZeroPrefixedData): Deleted.
(WebCore::mpiSignedData): Deleted.

• platform/SourcesGCrypt.txt:

Jun 26, 2018:

10:06 PM Changeset in webkit [233246] by Wenson Hsieh

• 4 edits in trunk/Source

[iPad apps on macOS] Unable to interact with video elements that have started playing
​https://bugs.webkit.org/show_bug.cgi?id=187073
<rdar://problem/40591107>

Reviewed by Tim Horton.

Source/WebCore/PAL:

Define an SPI method on CALayer. See WebKit ChangeLog for more detail.

• pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

On iOS, we currently force remote hosting contexts to be non-interactive by passing in kCAContextIgnoresHitTest
when creating the CAContext. However, this flag is not respected by CoreAnimation when running iOS apps on macOS.
This means all HID events dispatched over a video that has been played (which causes WebKit to insert a
CALayerHost-backed WKRemoteView in the view hierarchy) will be routed to the context ID of the video's CAContext
rather than the context ID of the key window containing the WKWebView.

This subsequently causes all gesture recognizers (hover, touch, tap, long press) to fail recognition when
running iOS apps on macOS. To address this, we set a flag on WKRemoteView's CALayerHost to prevent hit-testing
to the remote layer. This allows us to avoid routing HID events to the wrong context, and instead target the
main UIWindow.

Manually verified that click, touch, and mouseenter/mouseleave events are dispatched when interacting over a
video element.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

10:01 PM Changeset in webkit [233245] by Yusuke Suzuki

• 37 edits in trunk/Source

[JSC] Pass VM& to functions more
​https://bugs.webkit.org/show_bug.cgi?id=186241

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch threads VM& to functions requiring VM& more.

• API/JSObjectRef.cpp:

(JSObjectIsConstructor):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:

(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

• bytecode/CodeBlockJettisoningWatchpoint.h:
• bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

• bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
• bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::fireInternal):

• bytecode/StructureStubClearingWatchpoint.h:
• bytecode/Watchpoint.cpp:

(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAllWatchpoints):

• bytecode/Watchpoint.h:
• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:
• dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

• dfg/DFGAdaptiveStructureWatchpoint.h:
• dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setupGetByIdPrototypeCache):

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):

• runtime/ECMAScriptSpecInternalFunctions.cpp:

(JSC::esSpecIsConstructor):

• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::AllocationProfileClearingWatchpoint::fireInternal):

• runtime/FunctionRareData.h:
• runtime/InferredStructureWatchpoint.cpp:

(JSC::InferredStructureWatchpoint::fireInternal):

• runtime/InferredStructureWatchpoint.h:
• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructureSlow):

• runtime/InternalFunction.h:

(JSC::InternalFunction::createSubclassStructure):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isConstructor const):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isConstructor):
(JSC::JSCell::methodTable const):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:

(JSC::ObjectPropertyChangeAdaptiveWatchpoint::ObjectPropertyChangeAdaptiveWatchpoint):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::finishCreation):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::setObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

Source/WebCore:

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

9:45 PM Changeset in webkit [233244] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit

Unreviewed, rolling out r233232.
​https://bugs.webkit.org/show_bug.cgi?id=187081

"This is breaking launching some plugins" (Requested by youenn
on #webkit).

Reverted changeset:

"Remove quarantine for Webex plugin"
​https://bugs.webkit.org/show_bug.cgi?id=187050
​https://trac.webkit.org/changeset/233232

9:36 PM Changeset in webkit [233243] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Rearrange some WebPreferences; move two experimental prefs into the experimental section

• Shared/WebPreferences.yaml:

8:10 PM Changeset in webkit [233242] by mark.lam@apple.com

• 3 edits
  1 add in trunk

eval() is wrong about the LiteralParser never throwing any exceptions.
​https://bugs.webkit.org/show_bug.cgi?id=187074
<rdar://problem/41461099>

Reviewed by Saam Barati.

JSTests:

• stress/regress-187074.js: Added.

Source/JavaScriptCore:

Added the missing exception check, and removed an erroneous assertion.

• interpreter/Interpreter.cpp:

(JSC::eval):

8:03 PM Changeset in webkit [233241] by Simon Fraser

• 3 edits in trunk/Source/WebCore

CSSGradientValue's color stops vector wastes 12KB on theverge.com
​https://bugs.webkit.org/show_bug.cgi?id=186988

Reviewed by Sam Weinig.

Shrink the color stops vector when we're done parsing the stops.

• css/CSSGradientValue.h:

(WebCore::CSSGradientValue::doneAddingStops):

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):

7:10 PM Changeset in webkit [233240] by Chris Dumez

• 9 edits in trunk

Deal better with the network process crashing on startup
​https://bugs.webkit.org/show_bug.cgi?id=187065
<rdar://problem/41451622>

Reviewed by Geoffrey Garen.

Source/WebKit:

When a network process crashes on startup, we would not attempt to relaunch it. If there were web
processes waiting for a connection to this network process, we would send them an invalid connection
identifier which would cause them to forcefully crash.

Instead, we now apply the same policy whether a network process crashes on startup or later:

• We attempt to relaunch the network process
• If there were pending connections from WebContent processes, we ask the new Network process instead.

As a result, WebContent processes no longer crash in this case. Instead, they wait for a valid
connection to the network process.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _makeNextNetworkProcessLaunchFailForTesting]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::didFinishLaunching):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::networkProcessCrashed):

• UIProcess/WebProcessPool.h:

Tools:

Add layout test coverage.

• TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:

(-[MonitorWebContentCrashNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
(-[MonitorWebContentCrashNavigationDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):

6:58 PM Changeset in webkit [233239] by Yusuke Suzuki

• 11 edits
  1 delete in trunk

Remove static initializers more
​https://bugs.webkit.org/show_bug.cgi?id=186969

Reviewed by Michael Catanzaro.

Source/WebCore:

This patch removes static initializers more. They typically exists in GTK port.

No behavior change.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/ResourceUsageData.cpp: Removed.
• page/ResourceUsageData.h:

Remove ResourceUsageData constructors since default constructors are enough.

(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):

• platform/gtk/PasteboardHelper.cpp:

(WebCore::markupPrefix):
(WebCore::removeMarkupPrefix):
(WebCore::PasteboardHelper::fillSelectionData):
Use NeverDestroyed<> and static functions.

• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::defaultVolumeCapability):
(WebCore::GStreamerAudioCaptureSource::capabilities const):
CapabilityValueOrRange's constructor is not constexpr.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::initialAcceptLanguages):
(WebCore::proxySettings):
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setupProxy):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::SoupNetworkSession::setInitialAcceptLanguages):
Use NeverDestroyed<> and static functions.

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::assignedUrlsCache):
(WTR::dumpResourceURL):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didInitiateLoadForResource):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue):
Use NeverDestroyed<> and static functions.

6:29 PM Changeset in webkit [233238] by youenn@apple.com

• 6 edits
  32 adds in trunk/LayoutTests

Import wpt CORP tests
​https://bugs.webkit.org/show_bug.cgi?id=187027

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/common/get-host-info.sub.js:
• web-platform-tests/fetch/cross-origin-resource-policy/fetch-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/image-loads-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/image-loads.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/resources/green.png: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/resources/hello.py: Added.

(main):

• web-platform-tests/fetch/cross-origin-resource-policy/resources/iframe.py: Added.

(main):

• web-platform-tests/fetch/cross-origin-resource-policy/resources/iframeFetch.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/resources/image.py: Added.

(main):

• web-platform-tests/fetch/cross-origin-resource-policy/resources/redirect.py: Added.

(main):

• web-platform-tests/fetch/cross-origin-resource-policy/resources/script.py: Added.

(main):

• web-platform-tests/fetch/cross-origin-resource-policy/resources/w3c-import.log: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.js: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.js: Added.

(promise_test.t.return.new.Promise):
(promise_test.t.finally):

• web-platform-tests/fetch/cross-origin-resource-policy/script-loads-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/script-loads.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.js: Added.

(string_appeared_here.forEach.incorrectHeaderValue.promise_test.t.return.fetch.crossOriginURL.encodeURIComponent):

• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/w3c-import.log: Added.

LayoutTests:

Skipping tests for WK1.

• platform/ios-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

6:23 PM Changeset in webkit [233237] by dbates@webkit.org

• 9 edits
  3 adds in trunk

REGRESSION (r231479): Unable to buy Odeon cinema tickets in STP (bogus 'X-Frame-Options' to 'SAMEORIGIN')
​https://bugs.webkit.org/show_bug.cgi?id=186090
<rdar://problem/40692595>

Reviewed by Andy Estes.

Source/WebCore:

Fix up Content Security Policy logic for checking the frame ancestors now that we
exclude the frame that initiated the load request.

Test: http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html

• page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowFrameAncestors const):

• page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::checkFrameAncestors):

Source/WebKit:

Fixes an issue where a page P delivered with "X-Frame-Options: SAMEORIGIN" loaded in a sub-
frame would be blocked if we were redirected to it in response to the cross-origin POST
request regardless of whether P is same-origin with its parent document.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions): Compare the origin
of the top frame's document as opposed to the source origin. The latter represents the
origin of the document that initiated the navigation, which can be cross-origin, and
should not be considered when applying "X-Frame-Options: SAMEORIGIN". This check exists
as a performance optimization to avoid traversing over all frame ancestors only to find
out that the innermost frame (the one that made this request) is cross-origin with the
top-most frame.

• NetworkProcess/NetworkResourceLoader.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): Exclude the origin of the
frame that is making the load request from the list of ancestor origins. This makes the
X-Frame-Options algorithm in WebKit2 match the logic we do in FrameLoader::shouldInterruptLoadForXFrameOptions().

LayoutTests:

Add a test to ensure that we allow a same-origin page with "X-Frame-Options: SAMEORIGIN" to
load as a result of a redirected cross-origin POST request.

• http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow-expected.txt: Added.
• http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html: Added.
• http/tests/security/XFrameOptions/resources/post-form-to-x-frame-options-parent-same-origin-allow.html: Added.
• http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi:

6:08 PM Changeset in webkit [233236] by sbarati@apple.com

• 25 edits in trunk

JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
​https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells can't
be allocated from HeapCell::Kind::Auxiliary. This patch adds a new HeapCell::Kind
called JSCellWithInteriorPointers. It behaves like JSCell in all ways, except
conservative scan knows to treat it like a butterfly in when we we may be
pointing into the middle of it.

The way we were crashing on the stress GC bots is that our conservative marking
won't do cell visiting for things that are Auxiliary. This meant that if the
stack were the only thing pointing to a JSImmutableButterfly when a GC took place,
that JSImmutableButterfly would not be visited. This is now fixed.

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

• debugger/Debugger.cpp:
• heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):

• heap/Heap.cpp:

(JSC::GatherHeapSnapshotData::operator() const):
(JSC::RemoveDeadHeapSnapshotNodes::operator() const):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::deleteAllCodeBlocks):

• heap/HeapCell.cpp:

(WTF::printInternal):

• heap/HeapCell.h:

(JSC::isJSCellKind):
(JSC::hasInteriorPointers):

• heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::didAddToDirectory):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

• runtime/JSGlobalObject.cpp:
• runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::subspaceFor):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:
• tools/CellProfile.h:

(JSC::CellProfile::CellProfile):
(JSC::CellProfile::isJSCell const):

• tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateCell):

LayoutTests:

Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.

• editing/selection/navigation-clears-editor-state-expected.txt:
• editing/selection/navigation-clears-editor-state.html:
• fast/dom/reference-cycle-leaks.html:
• fast/misc/resources/test-observegc.js:
• fast/misc/test-observegc-expected.txt:
• platform/mac-wk2/plugins/refcount-leaks-expected.txt:
• plugins/refcount-leaks-expected.txt:
• plugins/refcount-leaks.html:

6:07 PM Changeset in webkit [233235] by aakash_jain@apple.com

• 7 edits in trunk/Tools

[ews-build] Add support for compiling WebKit
​https://bugs.webkit.org/show_bug.cgi?id=187019

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit): Added, class to compile WebKit.
(CleanBuild): Added, class to clean up the build.
(KillOldProcesses): Added, class to kill old processes.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
• BuildSlaveSupport/ews-build/config.json: Renamed ios-11-simulator to ios-simulator-11, to match with build.webkit.org code.

Added configuration, architecture which is required for compiling. Renamed Release to release as the tools expect lower-case release.

• BuildSlaveSupport/ews-build/factories.py: Added BuildFactory.
• BuildSlaveSupport/ews-build/loadConfig.py: Renamed configuraton value to lower-case as tools expect lower-case values.
• BuildSlaveSupport/ews-build/loadConfig_unittest.py: Ditto.

5:43 PM Changeset in webkit [233234] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Skip some unnecessary work in Interpreter::getStackTrace().
​https://bugs.webkit.org/show_bug.cgi?id=187070

Reviewed by Michael Saboff.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):

5:41 PM Changeset in webkit [233233] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

[iOS] Rebaseline two webanimations tests after r233164
​https://bugs.webkit.org/show_bug.cgi?id=187071

Unreviewed gardening

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

• platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
• platform/ios/webanimations/opacity-animation-yields-compositing-span-expected.txt: Added.

5:31 PM Changeset in webkit [233232] by youenn@apple.com

• 6 edits in trunk/Source/WebKit

Remove quarantine for Webex plugin
​https://bugs.webkit.org/show_bug.cgi?id=187050
rdar://problem/41478189

Reviewed by Brent Fulgham.

Update the Plugin Info.plist to not do quarantine of downloaded files by default.
Update PluginProcess implementation to reenable quarantine for all plug-ins except cisco webex plug-in.

• PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
• PluginProcess/PluginProcess.h:
• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::shouldOverrideQuarantine):

• Shared/ChildProcess.h:

(WebKit::ChildProcess::shouldOverrideQuarantine):

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

5:25 PM Changeset in webkit [233231] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Ensure element fullscreen animation is always visible.
​https://bugs.webkit.org/show_bug.cgi?id=187068
rdar://problem/36187369

Patch by Jeremy Jones <​jeremyj@apple.com> on 2018-06-26
Reviewed by Eric Carlson.

The fullscreen animation is important for communicating to users that they are no longer in inline mode.
If fullscreen animation's inline rect is not visible, animate from a point in the middle of the screen.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(WebKit::safeInlineRect):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

5:22 PM Changeset in webkit [233230] by youenn@apple.com

• 2 edits
  1 add in trunk/Source/WebKit

Add a sandbox profile for com.google.o1dbrowserplugin plugin
​https://bugs.webkit.org/show_bug.cgi?id=187067

Reviewed by Brent Fulgham.

• Resources/PlugInSandboxProfiles/com.google.o1dbrowserplugin.sb: Added.
• WebKit.xcodeproj/project.pbxproj:

5:16 PM Changeset in webkit [233229] by aakash_jain@apple.com

• 5 edits in trunk/Tools

[ews-build] Add support for WebKitPerl-Tests-EWS
​https://bugs.webkit.org/show_bug.cgi?id=187023

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
• BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
• BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.

5:10 PM Changeset in webkit [233228] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[build.webkit.org] Rename badly named variable kls to schedulerType
​https://bugs.webkit.org/show_bug.cgi?id=186926

Reviewed by Lucas Forschler.

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig): Renamed kls to schedulerType.

4:22 PM Changeset in webkit [233227] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Promote two more experimental features to traditional features
​https://bugs.webkit.org/show_bug.cgi?id=187063

Reviewed by Dean Jackson.

• Shared/WebPreferences.yaml:

Promote some shipped/default-on features to non-experimental.

3:28 PM Changeset in webkit [233226] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Rollout macOS sandbox change in r232276
​https://bugs.webkit.org/show_bug.cgi?id=186904
<rdar://problem/41350969>

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2018-06-26
Reviewed by Brent Fulgham.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

3:20 PM Changeset in webkit [233225] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Tap highlight displayed when tapping a field that is already focussed
​https://bugs.webkit.org/show_bug.cgi?id=187004
<rdar://problem/41428008>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-06-26
Reviewed by Tim Horton.

In the case where fast-clicking is enabled, _singleTapCommited: could be invoked
before the tap highlight request, causing _potentialTapInProgress to be set to NO.
This results in the early return for preventing multiple tap highlights on an
assisted node to be skipped. Since a tap highlight should never be shown for an
input field that is already focussed, _potentialTapInProgress can be removed from
the early return condition.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):

3:18 PM Changeset in webkit [233224] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION (r232314): Flaky Test: imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
​https://bugs.webkit.org/show_bug.cgi?id=186161

Unreviewed gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

• TestExpectations:

2:45 PM Changeset in webkit [233223] by Kocsen Chung

• 1 copy in tags/Safari-606.1.22.2

Tag Safari-606.1.22.2.

2:42 PM Changeset in webkit [233222] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Simplify NetworkStorageSession::getAllStorageAccessEntries()
​https://bugs.webkit.org/show_bug.cgi?id=187016

Reviewed by Youenn Fablet.

Iterate over the HashMaps' values instead of iterating over their keys and then looking them
up in the HashMap.

• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::getAllStorageAccessEntries const):

2:15 PM Changeset in webkit [233221] by Kocsen Chung

• 7 edits in branches/safari-606.1.22-branch/Source

Versioning.

2:13 PM Changeset in webkit [233220] by dbates@webkit.org

• 3 edits in trunk/Tools

EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
​https://bugs.webkit.org/show_bug.cgi?id=187061

Reviewed by Per Arne Vollan.

When EWS invokes webkit-patch to perform an operation (e.g. apply an attachment)
it should pass the command line option --status-host-uses-http, if EWS was
started with this command line option, so that we query the status server over
HTTP in child "webkit-patch" processes as we do in the main EWS process.

• Scripts/webkitpy/common/net/statusserver_mock.py:

(MockStatusServer.init):

• Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.run_webkit_patch):

1:54 PM Changeset in webkit [233219] by dbates@webkit.org

• 4 edits in trunk/Tools

webkit-patch: Make attachment commands work with status-server hosted attachments
​https://bugs.webkit.org/show_bug.cgi?id=187056

Reviewed by Per Arne Vollan.

Allow the EWS bots to apply, build, test, check-style, and (in the future) land
attachments hosted on the status server. We only download an attachment from the
status server if we do not have sufficient permission to download it from Bugzilla
(e.g. security-sensitive patches).

A valid status server API key is required to run these commands by hand. Otherwise,
the status server will not provide attachment data.

• Scripts/webkitpy/common/net/statusserver_mock.py:

(MockStatusServer.fetch_attachment): Log a message for testing purposes.

• Scripts/webkitpy/tool/commands/download.py:

(ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Fetch the attachment
from the status server if we do not have permission to fetch it from Bugzilla.

• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Update expected result when
using a custom work item and when fetching an attachment from the status server.
(_test_ews): Modified to take use_security_sensitive_patch (defaults to False) as
to whether to use a security-sensitive patch when testing.
(test_ewses_with_security_sensitive_patch): Added.

1:38 PM Changeset in webkit [233218] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Rearrange some WebPreferences; move two non-experimental prefs out of the experimental section

• Shared/WebPreferences.yaml:

1:37 PM Changeset in webkit [233217] by mark.lam@apple.com

• 3 edits
  1 add in trunk

ASSERTION FAILED: length > butterfly->vectorLength() in JSObject::ensureLengthSlow().
​https://bugs.webkit.org/show_bug.cgi?id=187060
<rdar://problem/41452767>

Reviewed by Keith Miller.

JSTests:

• stress/regress-187060.js: Added.

Source/JavaScriptCore:

JSObject::ensureLengthSlow() may be called only because it needs to do a copy on
write conversion. Hence, we can return early after the conversion if the vector
length is already sufficient to cover the requested length.

• runtime/JSObject.cpp:

(JSC::JSObject::ensureLengthSlow):

12:39 PM Changeset in webkit [233216] by sbarati@apple.com

• 2 edits in trunk/Source/bmalloc

Unreviewed followup. Fix the watchos build after r233192.

This patch also correct the changelog entry below to have the correct
bug and title info.

• bmalloc/ProcessCheck.mm:

12:27 PM Changeset in webkit [233215] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Promote some experimental features to traditional features
​https://bugs.webkit.org/show_bug.cgi?id=187047

Reviewed by Simon Fraser.

• Shared/WebPreferences.yaml:

Reindent.
Promote some shipped/default-on features to non-experimental.

12:14 PM Changeset in webkit [233214] by eric.carlson@apple.com

• 13 edits in trunk/Source

[Mac] AirPlay picker uses incorrect theme in Dark mode
​https://bugs.webkit.org/show_bug.cgi?id=187054
<rdar://problem/41291093>

Reviewed by Timothy Hatcher.

Source/WebCore:

• Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Add useDefaultAppearance parameter.

• Modules/mediasession/WebMediaSessionManager.h:

• platform/graphics/MediaPlaybackTargetPicker.cpp:

(WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.

• platform/graphics/MediaPlaybackTargetPicker.h:

• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Choose theme based on
useDefaultAppearance parameter.

• platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker): Log parameter.

• platform/mock/MediaPlaybackTargetPickerMock.h:

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPlaybackTargetPicker): Pass m_defaultAppearance.

Source/WebKitLegacy/mac:

• WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().

12:14 PM Changeset in webkit [233213] by commit-queue@webkit.org

• 13 edits in trunk

Unreviewed, rolling out r233184.
​https://bugs.webkit.org/show_bug.cgi?id=187059

"It regressed JetStream between 5-8%" (Requested by saamyjoon
on #webkit).

Reverted changeset:

"JSImmutableButterfly can't be allocated from a subspace with
HeapCell::Kind::Auxiliary"
​https://bugs.webkit.org/show_bug.cgi?id=186878
​https://trac.webkit.org/changeset/233184

12:13 PM Changeset in webkit [233212] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=187048

Unreviewed gardening.

• platform/gtk/TestExpectations:

11:45 AM Changeset in webkit [233211] by dbates@webkit.org

• 2 edits in trunk/Tools

contributors.json fails to parse after r233209

Removing trailing ',' that caused this file to be malformed. Also ran
"validate-committer-lists -c" to canonicalize the style of this file.

• Scripts/webkitpy/common/config/contributors.json:

11:40 AM Changeset in webkit [233210] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

11:28 AM Changeset in webkit [233209] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Add Aditya to contributors.json as a contributor

• Scripts/webkitpy/common/config/contributors.json:

11:26 AM Changeset in webkit [233208] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
​https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>

Reviewed by Brady Eidson.

Follow-up fix after r233180 to address an API test crash. We need to keep the
NetworkProcessProxy alive during the async updatePrevalentDomainsToPartitionOrBlockCookies
request to make sure it completes.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):

11:16 AM Changeset in webkit [233207] by Brent Fulgham

• 9 edits
  3 copies
  1 add in trunk

Provide a way for Injected Bundles to indicate classes approved for NSSecureCoding
​https://bugs.webkit.org/show_bug.cgi?id=186788
<rdar://problem/41094167>

Reviewed by Chris Dumez.

Source/WebKit:

InjectedBundles support a mechanism to serialize data between the UIProcess and the
WebContent process hosting the bundle. In some cases, we want to be able to serialize
a custom data object that is not part of WebKit's native data types.

After switching to strict NSSecureCoding, WebKit clients attempting to serialize these
custom objects trigger a failure.

This patch makes it possible for the InjectedBundle author to specify one (or more) data
classes that are allowed to be serialized between the two processes.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleExtendClassesForParameterCoder): Added.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(createWKArray): Added.
(-[WKWebProcessPlugInController extendClassesForParameterCoder:]): Added.

• WebProcess/InjectedBundle/InjectedBundle.h:
• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::extendClassesForParameterCoder): Added.
(WebKit::InjectedBundle::classesForCoder): New helper function.
(WebKit::InjectedBundle::setBundleParameter): Modified to use the new set of valid
classes for NSSecureCoding.

Tools:

Add a new test case to exercise the class check during NSSecureCoding.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h: Added.
• TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm: Added.

(-[CustomBundleObject initWithValue:]):
(+[CustomBundleObject supportsSecureCoding]):
(-[CustomBundleObject copyWithZone:]):
(-[CustomBundleObject initWithCoder:]):
(-[CustomBundleObject encodeWithCoder:]):

• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):

• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm: Added.

(TestWebKitAPI::CustomBundleParameterTest::CustomBundleParameterTest):
(TestWebKitAPI::CustomBundleParameterTest::didCreatePage):

11:00 AM Changeset in webkit [233206] by clopez@igalia.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
​https://bugs.webkit.org/show_bug.cgi?id=187051

Reviewed by Mark Lam.

Revert r233065 changes over UnlinkedCodeBlock.h to allow
clang-3.8 to be able to compile this back (with libstdc++5)

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::decompressArrayAllocationProfile):

10:50 AM Changeset in webkit [233205] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Layout Test http/tests/resourceLoadStatistics/prevalent-resource-without-user-interaction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=187053

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

• platform/wk2/TestExpectations:

10:38 AM Changeset in webkit [233204] by Ryan Haddad

• 2 edits in trunk/Source/JavaScriptCore

Fix testapi build when DFG_JIT is disabled
​https://bugs.webkit.org/show_bug.cgi?id=187038

Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-26
Reviewed by Mark Lam.

r233158 added a new API and tests for configuring the number of JIT threads, but
the API is only available when DFG_JIT is enabled and so should the tests.

• API/tests/testapi.mm:

(runJITThreadLimitTests):

10:06 AM Changeset in webkit [233203] by eric.carlson@apple.com

• 5 edits in trunk

Enable mock capture devices on the iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=186846
<rdar://problem/41289134>

Reviewed by Youenn Fablet.

Source/WebKit:

• Shared/WebPreferences.yaml: Use DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED.
• Shared/WebPreferencesDefaultValues.h: Define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED, set to

true in the iOS simulator only.

LayoutTests:

• platform/ios/TestExpectations: Unskip fast/mediastream/getUserMedia-default.html.

9:58 AM Changeset in webkit [233202] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Do not forget to set stream on track switching
​https://bugs.webkit.org/show_bug.cgi?id=187049

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-06-26
Reviewed by Philippe Normand.

This was an overlooked issue introduced in Bug #186678

This is already tested, but we currently run only tests against playbin2

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::enableTrack):

9:45 AM Changeset in webkit [233201] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Fixed positioning is a subcategory of absolute positioning.
​https://bugs.webkit.org/show_bug.cgi?id=187043

Reviewed by Antti Koivisto.

​https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
property has the value 'absolute' or 'fixed'.

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isAbsolutelyPositioned const):

• layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isOutOfFlowPositioned const):

8:39 AM WebKitGTK/2.20.x edited by Michael Catanzaro

(diff)

8:27 AM Changeset in webkit [233200] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r233143.
​https://bugs.webkit.org/show_bug.cgi?id=187046

broke media/video-ended-event-negative-playback.html
(Requested by philn on #webkit).

Reverted changeset:

"[GStreamer] Remove useless workaround"
​https://bugs.webkit.org/show_bug.cgi?id=186921
​https://trac.webkit.org/changeset/233143

7:23 AM Changeset in webkit [233199] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Layout Test imported/mozilla/css-animations/test_animation-pausing.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=187041

Unreviewed test gardening.

• platform/win/TestExpectations:

6:36 AM Changeset in webkit [233198] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC] Computed height for in-flow non-replaced should not include padding and border.
​https://bugs.webkit.org/show_bug.cgi?id=187031

Reviewed by Antti Koivisto.

In certain cases the height of a non-replaced in-flow box is computed using the bottom position of its last in-flow child.
The in-flow child's bottom position is in the coordinate system of the containing block's border box (border box's top left is 0, 0) ->
it includes both the (top) border and the padding of the containing block.

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

6:01 AM Changeset in webkit [233197] by fred.wang@free.fr

• 5 edits
  196 adds in trunk/LayoutTests

Import WPT tests for webmessaging
​https://bugs.webkit.org/show_bug.cgi?id=187001

Patch by Frederic Wang <​fwang@igalia.com> on 2018-06-26
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/webmessaging/Channel_postMessage_Blob-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_Blob.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_clone_port-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_clone_port.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_clone_port_error-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_clone_port_error.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_event_properties-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_event_properties.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array.htm: Added.
• web-platform-tests/webmessaging/Channel_postMessage_target_source-expected.txt: Added.
• web-platform-tests/webmessaging/Channel_postMessage_target_source.htm: Added.
• web-platform-tests/webmessaging/META.yml: Added.
• web-platform-tests/webmessaging/MessageEvent-expected.txt: Added.
• web-platform-tests/webmessaging/MessageEvent-trusted-expected.txt: Added.
• web-platform-tests/webmessaging/MessageEvent-trusted-worker.js: Added.
• web-platform-tests/webmessaging/MessageEvent-trusted.html: Added.
• web-platform-tests/webmessaging/MessageEvent.html: Added.
• web-platform-tests/webmessaging/MessageEvent_onmessage_postMessage_infinite_loop.html: Added.
• web-platform-tests/webmessaging/MessageEvent_properties.htm: Added.
• web-platform-tests/webmessaging/MessagePort_initial_disabled-expected.txt: Added.
• web-platform-tests/webmessaging/MessagePort_initial_disabled.htm: Added.
• web-platform-tests/webmessaging/MessagePort_onmessage_start-expected.txt: Added.
• web-platform-tests/webmessaging/MessagePort_onmessage_start.htm: Added.
• web-platform-tests/webmessaging/README.md: Added.
• web-platform-tests/webmessaging/Transferred_objects_unusable.sub.htm: Added.
• web-platform-tests/webmessaging/broadcastchannel/basics-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/basics.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/blobs-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/blobs.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/interface-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/interface.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/origin.window.js: Added.
• web-platform-tests/webmessaging/broadcastchannel/resources/origin.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/resources/sandboxed.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/resources/w3c-import.log: Added.
• web-platform-tests/webmessaging/broadcastchannel/resources/worker.js: Added.

(handler):

• web-platform-tests/webmessaging/broadcastchannel/sandbox-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/sandbox.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/w3c-import.log: Added.
• web-platform-tests/webmessaging/broadcastchannel/workers.html: Added.
• web-platform-tests/webmessaging/event.data.sub.htm: Added.
• web-platform-tests/webmessaging/event.origin.sub.htm: Added.
• web-platform-tests/webmessaging/event.ports.sub.htm: Added.
• web-platform-tests/webmessaging/event.source.htm: Added.
• web-platform-tests/webmessaging/event.source.xorigin.sub.htm: Added.
• web-platform-tests/webmessaging/message-channels/001-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/001.html: Added.
• web-platform-tests/webmessaging/message-channels/002-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/002.html: Added.
• web-platform-tests/webmessaging/message-channels/003-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/003.html: Added.
• web-platform-tests/webmessaging/message-channels/004-1.html: Added.
• web-platform-tests/webmessaging/message-channels/004-2.html: Added.
• web-platform-tests/webmessaging/message-channels/004-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/004.html: Added.
• web-platform-tests/webmessaging/message-channels/close-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/close.html: Added.
• web-platform-tests/webmessaging/message-channels/w3c-import.log: Added.
• web-platform-tests/webmessaging/message-channels/worker-expected.txt: Added.
• web-platform-tests/webmessaging/message-channels/worker.html: Added.
• web-platform-tests/webmessaging/messageerror-expected.txt: Added.
• web-platform-tests/webmessaging/messageerror.html: Added.
• web-platform-tests/webmessaging/postMessage_ArrayBuffer.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_Date.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_Document-expected.txt: Added.
• web-platform-tests/webmessaging/postMessage_Document.htm: Added.
• web-platform-tests/webmessaging/postMessage_Function-expected.txt: Added.
• web-platform-tests/webmessaging/postMessage_Function.htm: Added.
• web-platform-tests/webmessaging/postMessage_MessagePorts_sorigin.htm: Added.
• web-platform-tests/webmessaging/postMessage_MessagePorts_xorigin.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_arrays.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_asterisk_xorigin.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_dup_transfer_objects-expected.txt: Added.
• web-platform-tests/webmessaging/postMessage_dup_transfer_objects.htm: Added.
• web-platform-tests/webmessaging/postMessage_invalid_targetOrigin-expected.txt: Added.
• web-platform-tests/webmessaging/postMessage_invalid_targetOrigin.htm: Added.
• web-platform-tests/webmessaging/postMessage_objects.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_origin_mismatch.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_origin_mismatch_xorigin.sub.htm: Added.
• web-platform-tests/webmessaging/postMessage_solidus_sorigin.htm: Added.
• web-platform-tests/webmessaging/postMessage_solidus_xorigin.sub.htm: Added.
• web-platform-tests/webmessaging/w3c-import.log: Added.
• web-platform-tests/webmessaging/with-ports/001-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/001.html: Added.
• web-platform-tests/webmessaging/with-ports/002-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/002.html: Added.
• web-platform-tests/webmessaging/with-ports/003-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/003.html: Added.
• web-platform-tests/webmessaging/with-ports/004-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/004.html: Added.
• web-platform-tests/webmessaging/with-ports/005-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/005.html: Added.
• web-platform-tests/webmessaging/with-ports/006-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/006.html: Added.
• web-platform-tests/webmessaging/with-ports/007-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/007.html: Added.
• web-platform-tests/webmessaging/with-ports/010-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/010.html: Added.
• web-platform-tests/webmessaging/with-ports/011-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/011.html: Added.
• web-platform-tests/webmessaging/with-ports/012-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/012.html: Added.
• web-platform-tests/webmessaging/with-ports/013-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/013.html: Added.
• web-platform-tests/webmessaging/with-ports/014-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/014.html: Added.
• web-platform-tests/webmessaging/with-ports/015-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/015.html: Added.
• web-platform-tests/webmessaging/with-ports/016-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/016.html: Added.
• web-platform-tests/webmessaging/with-ports/017-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/017.html: Added.
• web-platform-tests/webmessaging/with-ports/018-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/018.html: Added.
• web-platform-tests/webmessaging/with-ports/019-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/019.html: Added.
• web-platform-tests/webmessaging/with-ports/020.html: Added.
• web-platform-tests/webmessaging/with-ports/021.html: Added.
• web-platform-tests/webmessaging/with-ports/023-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/023.html: Added.
• web-platform-tests/webmessaging/with-ports/024-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/024.html: Added.
• web-platform-tests/webmessaging/with-ports/025-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/025.html: Added.
• web-platform-tests/webmessaging/with-ports/026-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/026.html: Added.
• web-platform-tests/webmessaging/with-ports/027-expected.txt: Added.
• web-platform-tests/webmessaging/with-ports/027.html: Added.
• web-platform-tests/webmessaging/with-ports/w3c-import.log: Added.
• web-platform-tests/webmessaging/without-ports/001-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/001.html: Added.
• web-platform-tests/webmessaging/without-ports/002-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/002.html: Added.
• web-platform-tests/webmessaging/without-ports/003-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/003.html: Added.
• web-platform-tests/webmessaging/without-ports/004-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/004.html: Added.
• web-platform-tests/webmessaging/without-ports/005-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/005.html: Added.
• web-platform-tests/webmessaging/without-ports/006-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/006.html: Added.
• web-platform-tests/webmessaging/without-ports/007-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/007.html: Added.
• web-platform-tests/webmessaging/without-ports/008-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/008.html: Added.
• web-platform-tests/webmessaging/without-ports/009-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/009.html: Added.
• web-platform-tests/webmessaging/without-ports/010-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/010.html: Added.
• web-platform-tests/webmessaging/without-ports/011-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/011.html: Added.
• web-platform-tests/webmessaging/without-ports/012-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/012.html: Added.
• web-platform-tests/webmessaging/without-ports/013-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/013.html: Added.
• web-platform-tests/webmessaging/without-ports/014-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/014.html: Added.
• web-platform-tests/webmessaging/without-ports/015-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/015.html: Added.
• web-platform-tests/webmessaging/without-ports/016-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/016.html: Added.
• web-platform-tests/webmessaging/without-ports/017-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/017.html: Added.
• web-platform-tests/webmessaging/without-ports/018-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/018.html: Added.
• web-platform-tests/webmessaging/without-ports/019-1.html: Added.
• web-platform-tests/webmessaging/without-ports/019-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/019.html: Added.
• web-platform-tests/webmessaging/without-ports/020-1.html: Added.
• web-platform-tests/webmessaging/without-ports/020.html: Added.
• web-platform-tests/webmessaging/without-ports/021.html: Added.
• web-platform-tests/webmessaging/without-ports/023-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/023.html: Added.
• web-platform-tests/webmessaging/without-ports/024-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/024.html: Added.
• web-platform-tests/webmessaging/without-ports/025-1.js: Added.

(test):

• web-platform-tests/webmessaging/without-ports/025-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/025.html: Added.
• web-platform-tests/webmessaging/without-ports/026-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/026.html: Added.
• web-platform-tests/webmessaging/without-ports/027-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/027.html: Added.
• web-platform-tests/webmessaging/without-ports/028-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/028.html: Added.
• web-platform-tests/webmessaging/without-ports/029-expected.txt: Added.
• web-platform-tests/webmessaging/without-ports/029.html: Added.
• web-platform-tests/webmessaging/without-ports/w3c-import.log: Added.

LayoutTests:

Skip some webmessaging tests timing out.

• TestExpectations:

5:30 AM Changeset in webkit [233196] by zandobersek@gmail.com

• 4 edits in trunk

Crash in WebAnimation::runPendingPlayTask
​https://bugs.webkit.org/show_bug.cgi?id=186189

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Avoid crashes on nullopt std::optional dereference in the
runPendingPlayTask() and runPendingPauseTask() methods of the
WebAnimation class by defaulting to a Seconds(0) value.

In both cases the std::optional value is the current time retrieved from
the associated DocumentTimeline object. But there's no guarantee that
the timeline is active and the resulting time value is resolved (i.e.
not nullopt). Dereferencing the nullopt Seconds value doesn't cause a
problem on configurations still building as C++14 and the fallback
std::optional implementation provided by WTF -- no signal is raised, and
a 0 value is returned. Configurations building as C++17 on the other
hand use the stdlib-provided std::optional that does raise a signal on
invalid access, leading to crashes.

The default-to-Seconds(0) solution avoids crashes on configurations
that build with C++17 support enabled, and thus match configurations
that are still using WTF's std::optional. This still doesn't address the
underlying problem of retrieving current time from an inactive document
timeline and using it as ready time for the pending play/pause task
execution.

runPendingPlayTask() change addresses crashes in the following tests:

• fast/animation/css-animation-resuming-when-visible.html
• fast/animation/css-animation-resuming-when-visible-with-style-change.html
• imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
• imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html

runPendingPauseTask() change addresses crashes in the following tests:

• animations/multiple-animations-timing-function.html

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::runPendingPauseTask):

LayoutTests:

• platform/wpe/TestExpectations: Remove crashing expectations for fixed tests.

2:50 AM Changeset in webkit [233195] by Fujii Hironori

• 2 edits in trunk/Source/WebKit

[Win] 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains::<lambda_9d761a6dc12d95db7fa2d6f3f5aa26fa>'
​https://bugs.webkit.org/show_bug.cgi?id=187035

Unreviewed build fix.

MSVC can't compile the code using this in a generalized lambda
capture in another lambda.

In this case, there is no need to copy protectedThis for the
inner lambda. Move protectedThis of the outer lambda to the
inner as well as completionHandler.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
Moved protectedThis from the outer lambda to the inner.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
Ditto.

2:44 AM Changeset in webkit [233194] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Web Animations] Show the feature as "Supported in Preview"
​https://bugs.webkit.org/show_bug.cgi?id=187037

Patch by Antoine Quint <Antoine Quint> on 2018-06-26
Reviewed by Dean Jackson.

Web Animations are enabled by default in STP.

• features.json:

2:12 AM Changeset in webkit [233193] by magomez@igalia.com

• 6 edits in trunk/Source

[GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
​https://bugs.webkit.org/show_bug.cgi?id=179304

Reviewed by Michael Catanzaro.

Source/WebCore:

When adding new CoordinatedGraphicsLayers to the tree, check that they have the appropriate
CompositingCoordinator. If that's not the case, set the appropriate one to the layer and its
children and set the state of those layers so they are rendered properly.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Add a way to attach to the CompositingCoordinator layers that were not created by it.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::attachLayer):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

12:38 AM Changeset in webkit [233192] by sbarati@apple.com

• 5 edits in trunk/Source/bmalloc

Wasm: Any function argument of type Void should be a validation error
​https://bugs.webkit.org/show_bug.cgi?id=186794
<rdar://problem/41140257>

Reviewed by Keith Miller.

We have evidence showing that processes with small heaps using the
JS API are more space efficient when using system malloc. Our main
hypothesis as to why this is, is that when dealing with small heaps,
one malloc can be more efficient at optimizing memory usage than
two mallocs.

• bmalloc/BPlatform.h:
• bmalloc/Environment.cpp:

(bmalloc::isNanoMallocEnabled):
(bmalloc::Environment::computeIsDebugHeapEnabled):

• bmalloc/ProcessCheck.h:

(bmalloc::shouldProcessUnconditionallyUseBmalloc):

• bmalloc/ProcessCheck.mm:

(bmalloc::shouldProcessUnconditionallyUseBmalloc):