Context Navigation

← Previous Period
Next Period →

Timeline

Jul 5, 2018:

11:43 PM Changeset in webkit [233570] by bshafiei@apple.com

2 edits in branches/safari-606.1.24-branch/Source/WebCore

Cherry-pick r233557. rdar://problem/41870910

REGRESSION(r233496): Crash in WebCore::VideoTrack::clearClient()
https://bugs.webkit.org/show_bug.cgi?id=187377

Reviewed by Simon Fraser.

Clear m_client of an audio track or a video track before removing it from the list
since TrackListBase::m_inbandTracks may hold the last ref to the track.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removeAudioTrack): (WebCore::HTMLMediaElement::removeVideoTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:43 PM Changeset in webkit [233569] by bshafiei@apple.com

3 edits in branches/safari-606.1.24-branch/Source/WebKit

Cherry-pick r233546. rdar://problem/41867306

Upstream hover gesture implementation
https://bugs.webkit.org/show_bug.cgi?id=187366

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView cleanupInteraction]): (-[WKContentView _removeDefaultGestureRecognizers]): (-[WKContentView _addDefaultGestureRecognizers]): (-[WKContentView _hoverGestureRecognizerChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:40 PM Changeset in webkit [233568] by bshafiei@apple.com

7 edits in branches/safari-606.1.24-branch/Source

Versioning.

11:31 PM Changeset in webkit [233567] by bshafiei@apple.com

1 copy in branches/safari-606.1.24-branch

New branch.

11:28 PM Changeset in webkit [233566] by Carlos Garcia Campos

1 edit
1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Remove platform expectations for imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html

Since r233512 we are getting the same results as other ports.

platform/gtk/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt: Removed.

11:12 PM Changeset in webkit [233565] by bshafiei@apple.com

7 edits in tags/Safari-606.1.24/Source

Versioning.

10:57 PM Changeset in webkit [233564] by Dewei Zhu

3 edits in trunk/Websites/perf.webkit.org

MeasurementSet should merge last four segments into two if values are identical.
https://bugs.webkit.org/show_bug.cgi?id=187311

Reviewed by Ryosuke Niwa.

If last four segments has the same value, MeasurmentSet should merge them.

public/v3/models/measurement-set.js: Added the logic to conditionally merge last segments.

(MeasurementSet.prototype.fetchSegmentation):

unit-tests/measurement-set-tests.js: Added a unit test for this change.

10:50 PM Changeset in webkit [233563] by youenn@apple.com

14 edits
2 adds in trunk

REGRESSION (r230843): Flash doesn't work; Produces blue box on page
https://bugs.webkit.org/show_bug.cgi?id=187346
<rdar://problem/41773974>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce clearPagesPluginData used by WebProcess when a plugin policy changes.
Add a new internals API to get the plugin count as navigator.plugin is filtering plugins.

Test: http/tests/plugins/plugin-allow-then-reload.html

plugins/PluginData.h:
plugins/PluginInfoProvider.cpp:

(WebCore::PluginInfoProvider::clearPagesPluginData):

plugins/PluginInfoProvider.h:
testing/Internals.cpp:

(WebCore::Internals::pluginCount):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Reset page plugins when the load client policies are updated.
This will ensure that pages will rebuild their plugin lists based on the new policies.

WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):
(WebKit::WebPluginInfoProvider::clearPluginClientPolicies):

Tools:

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setBlockAllPlugins):
When not blocked, set the load policy to allow once.

WebKitTestRunner/TestController.h:

LayoutTests:

Skip new test on WK1 since it does not have the ability to block plugins.

http/tests/plugins/plugin-allow-then-reload-expected.txt: Added.
http/tests/plugins/plugin-allow-then-reload.html: Added.
platform/mac-wk1/TestExpectations:

10:48 PM Changeset in webkit [233562] by beidson@apple.com

19 edits
2 adds in trunk

IndexedDB operations in a Page fail after a StorageProcess crash.
<rdar://problem/41626526> and https://bugs.webkit.org/show_bug.cgi?id=187123

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-after-storage-crash.html

When the connection to a StorageProcess goes away, explicitly tell all of the WebPages
in the WebProcess about it.

This puts Documents/Workers in an error mode where requests fail instead of timeout.
It also clears the Page's connection so *new* Documents and Workers will get a fresh
new connection that works.

Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::callResultFunctionLater):
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::createObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::deleteObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::renameObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::clearObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::createIndex):
(WebCore::IDBClient::IDBConnectionToServer::deleteIndex):
(WebCore::IDBClient::IDBConnectionToServer::renameIndex):
(WebCore::IDBClient::IDBConnectionToServer::putOrAdd):
(WebCore::IDBClient::IDBConnectionToServer::getRecord):
(WebCore::IDBClient::IDBConnectionToServer::getAllRecords):
(WebCore::IDBClient::IDBConnectionToServer::getCount):
(WebCore::IDBClient::IDBConnectionToServer::deleteRecord):
(WebCore::IDBClient::IDBConnectionToServer::openCursor):
(WebCore::IDBClient::IDBConnectionToServer::iterateCursor):
(WebCore::IDBClient::IDBConnectionToServer::establishTransaction):
(WebCore::IDBClient::IDBConnectionToServer::commitTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebCore::IDBClient::IDBConnectionToServer::abortTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didFireVersionChangeEvent):
(WebCore::IDBClient::IDBConnectionToServer::confirmDidCloseFromServer):
(WebCore::IDBClient::IDBConnectionToServer::connectionToServerLost):
(WebCore::IDBClient::IDBConnectionToServer::openDBRequestCancelled):
(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionPendingClose):
(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionClosed):
(WebCore::IDBClient::IDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames):

Modules/indexeddb/client/IDBConnectionToServer.h:

Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::serverConnectionLostError):

page/Page.cpp:

(WebCore::Page::setSessionID):
(WebCore::Page::idbConnection):
(WebCore::Page::optionalIDBConnection):
(WebCore::Page::clearIDBConnection):

page/Page.h:

Source/WebKit:

When the connection to a StorageProcess goes away, explicitly tell all of the WebPages
in the WebProcess about it.

This puts Documents/Workers in an error mode where requests fail instead of timeout.
It also clears the Page's connection so *new* Documents and Workers will get a fresh
new connection that works.

UIProcess/API/C/WKContext.cpp:

(WKContextTerminateStorageProcess):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _terminateStorageProcess]):

UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::terminateForTesting):

UIProcess/Storage/StorageProcessProxy.h:

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::terminateStorageProcessForTesting):
(WebKit::WebProcessPool::terminateStorageProcess): Deleted.

UIProcess/WebProcessPool.h:

WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didClose):

WebProcess/Storage/WebToStorageProcessConnection.h:

(WebKit::WebToStorageProcessConnection::existingIDBConnectionToServerForIdentifier):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webToStorageProcessConnectionClosed):

LayoutTests:

storage/indexeddb/modern/opendatabase-after-storage-crash.html: Added.

9:56 PM Changeset in webkit [233561] by Simon Fraser

2 edits in trunk/Source/WebKit

Address two possible causes of missing tiles in iOS Safari, and add logging to gather more data about other possible causes
https://bugs.webkit.org/show_bug.cgi?id=187376
rdar://problem/40941118

Reviewed by Tim Horton.

We have continual reports of users experiencing missing tiles in MobileSafari, where loading a page
shows the tiles at the top, but we don't render new tiles as the user scrolls down. This is consistent
with failing to dispatch visible content rect updates via -[WKWebView _updateVisibleContentRects].

This patch addresses two possible (but unlikely) causes. First, it resets _currentlyAdjustingScrollViewInsetsForKeyboard
after a web process crash. Second, it catches exceptions thrown by [webView _updateVisibleContentRects]
and resets _hasScheduledVisibleRectUpdate.

This patch also adds release logging that fires if over 1s has elapsed between scheduling
a visible content rect update and trying to re-schedule, and logging for all reasons that
-_updateVisibleContentRects returns early.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _addUpdateVisibleContentRectPreCommitHandler]):
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
(-[WKWebView _updateVisibleContentRects]):

8:20 PM Changeset in webkit [233560] by rniwa@webkit.org

8 edits
2 adds in trunk

Youtube video pages crash after a couple of minutes
https://bugs.webkit.org/show_bug.cgi?id=187316

Reviewed by Antti Koivisto.

Source/WebCore:

The crash was caused by HTMLMediaElement::stopWithoutDestroyingMediaPlayer invoking updatePlaybackControlsManager,
which traverses all media players across different documents including the one in the main frame while its iframe
is getting removed (to update the Touch Bar's media control).

Fixed the bug by making this code async in both stopWithoutDestroyingMediaPlayer and ~HTMLMediaElement. To do this,
this patch moves the timer to update the playback controls manager from HTMLMediaElement to Page since scheduling
a timer owned by HTMLMediaElement in its destructor wouldn't work as the timer would get destructed immediately.

Also replaced the call to clientWillPausePlayback by a call to stopSession in stopWithoutDestroyingMediaPlayer
since the former also updates the layout synchronously via updateNowPlayingInfo; the latter function schedules
a timer via scheduleUpdateNowPlayingInfo instead.

Test: media/remove-video-best-media-element-in-main-frame-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call scheduleUpdatePlaybackControlsManager now that timer has been
moved to Page.
(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager): Made this return a RefPtr instead of
a raw pointer while we're at it.
(WebCore::HTMLMediaElement::clearMediaPlayer): Call scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): Ditto. Also invoke stopSession instead of
clientWillPausePlayback on MediaSession since clientWillPausePlayback will synchronously try to update the layout.
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::schedulePlaybackControlsManagerUpdate): Renamed from scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::updatePlaybackControlsManager): Moved to Page::playbackControlsManagerUpdateTimerFired.

html/HTMLMediaElement.h:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::schedulePlaybackControlsManagerUpdate): Added.
(WebCore::Page::playbackControlsManagerUpdateTimerFired): Moved from HTMLMediaElement::updatePlaybackControlsManager.

page/Page.h:
testing/Internals.cpp:

(WebCore::Internals::bestMediaElementForShowingPlaybackControlsManager):

testing/Internals.h:

LayoutTests:

Added a regression test to remove an iframe with a video while there is a main content
which is eligible to be shown in the Touch Bar.

media/remove-video-best-media-element-in-main-frame-crash-expected.txt: Added.
media/remove-video-best-media-element-in-main-frame-crash.html: Added.

7:44 PM Changeset in webkit [233559] by Kocsen Chung

1 copy in tags/Safari-606.1.24.1

Tag Safari-606.1.24.1.

7:39 PM Changeset in webkit [233558] by Kocsen Chung

7 edits in tags/Safari-606.1.24/Source

Versioning.

7:32 PM Changeset in webkit [233557] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r233496): Crash in WebCore::VideoTrack::clearClient()
https://bugs.webkit.org/show_bug.cgi?id=187377

Reviewed by Simon Fraser.

Clear m_client of an audio track or a video track before removing it from the list
since TrackListBase::m_inbandTracks may hold the last ref to the track.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):

6:56 PM Changeset in webkit [233556] by Fujii Hironori

4 edits in trunk

REGRESSION(r233495) [cairo] drawGlyphsShadow should use the fast path for zero blur-radius
https://bugs.webkit.org/show_bug.cgi?id=187336

Reviewed by Carlos Garcia Campos.

Source/WebCore:

drawGlyphsShadow has a fast path to draw a shadow without a shadow
layer. Since r233495, it is not used for zero blur-radius shadow.

In Bug 187244, I changed ShadowState::isRequired not to check
blur-radius is zero. This is not a right fix.

This change reverts r233495.

No new tests (Covered by existing tests).

platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::ShadowState::isRequired const): Return false if
'blur' is zero.
(WebCore::Cairo::fillRectWithRoundedHole): Use
ShadowState::isVisible instead of ShadowState::isRequired to check
a shadow should be drawn.

LayoutTests:

platform/gtk/TestExpectations: Unmarked fast/text/multiple-text-shadow-overflow-layout-rect.html.

6:35 PM Changeset in webkit [233555] by sbarati@apple.com

3 edits in trunk/LayoutTests

[mac-wk1] Layout Test editing/selection/navigation-clears-editor-state.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=187309

Reviewed by Mark Lam.

Try to make this test less flaky by making percents threshold of freed
objects smaller.

editing/selection/navigation-clears-editor-state-expected.txt:
editing/selection/navigation-clears-editor-state.html:

5:43 PM Changeset in webkit [233554] by youenn@apple.com

4 edits in trunk/LayoutTests

Layout Test http/tests/workers/service/basic-messageport.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182630

Reviewed by Alex Christensen.

Test is flaky due to a race between serviceWorkerClient.postMessage and MessagePort.postMessage.
Both are going through UIProcess but MessagePort events are grabbed asynchronously.
Fixed the test to not expect order between these two message exchange channels.

http/tests/workers/service/basic-messageport-expected.txt:
http/tests/workers/service/resources/basic-messageport.js:

(channel.port1.onmessage):
(then):

platform/mac-wk2/TestExpectations:

5:40 PM Changeset in webkit [233553] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
https://bugs.webkit.org/show_bug.cgi?id=187363
<rdar://problem/41106306>

Patch by Olivia Barnett <obarnett@apple.com> on 2018-07-05
Reviewed by Tim Horton.

Added extra check to prevent keyboard scrolling when the select box is open.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _scrollOffsetForEvent:]):

5:38 PM Changeset in webkit [233552] by timothy@apple.com

44 edits in trunk/Source

Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
https://bugs.webkit.org/show_bug.cgi?id=187369
rdar://problem/41870420

Reviewed by Tim Horton.

Source/WebCore:

Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):

css/MediaQueryEvaluator.cpp:

(WebCore::prefersDarkInterfaceEvaluate):

css/StyleColor.h:
dom/Document.cpp:

(WebCore::Document::useDarkAppearance const):
(WebCore::Document::styleColorOptions const):
(WebCore::Document::useDefaultAppearance const): Deleted.

dom/Document.h:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

page/Page.cpp:

(WebCore::Page::useDarkAppearance const):
(WebCore::Page::defaultAppearance const): Deleted.

page/Page.h:

(WebCore::Page::setUseDarkAppearance):
(WebCore::Page::setDefaultAppearance): Deleted.

platform/Theme.h:
platform/graphics/MediaPlaybackTargetPicker.h:
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker):

platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):

platform/mac/LocalDefaultSystemAppearance.h:
platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):

platform/mac/ThemeMac.h:
platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::paint):

platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker):

platform/mock/MediaPlaybackTargetPickerMock.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::resolveStyleForMarkedText):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor const):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors const):
(WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const):
(WebCore::RenderThemeMac::colorCache const):
(WebCore::RenderThemeMac::systemColor const):
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary):
(WebCore::RenderThemeMac::paintSliderThumb):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

Source/WebKit:

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _effectiveAppearanceIsDark]):
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setUseSystemAppearance:]):
(-[WKWebView effectiveAppearanceDidChange]):
(-[WKWebView _defaultAppearance]): Deleted.

UIProcess/API/mac/WKView.mm:

(-[WKView _effectiveAppearanceIsDark]):
(-[WKView effectiveAppearanceDidChange]):
(-[WKView _setUseSystemAppearance:]):
(-[WKView _defaultAppearance]): Deleted.
(-[WKView _setDefaultAppearance:]): Deleted.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::effectiveAppearanceIsDark):
(WebKit::WebViewImpl::setUseDarkAppearance):
(WebKit::WebViewImpl::useDefaultAppearance): Deleted.
(WebKit::WebViewImpl::setDefaultAppearance): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setUseDarkAppearance):
(WebKit::WebPageProxy::showPlaybackTargetPicker):
(WebKit::WebPageProxy::setDefaultAppearance): Deleted.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::defaultAppearance const): Deleted.

UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]):

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::paintControlForLayerInContext):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_credentialsMessenger):
(WebKit::WebPage::drawRect):
(WebKit::WebPage::setUseDarkAppearance):
(WebKit::WebPage::setDefaultAppearance): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _effectiveAppearanceIsDark]):
(-[WebView _updateDefaultAppearance]):
(-[WebView _defaultAppearance]): Deleted.

5:25 PM Changeset in webkit [233551] by david_fenton@apple.com

2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187372

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

5:19 PM Changeset in webkit [233550] by ddkilzer@apple.com

3 edits in trunk/Source/bmalloc

Build fix (r233547): Disable IsoHeaps when Gigacage is off
<https://webkit.org/b/187160>

bmalloc/PerThread.cpp: Add #if !HAVE_PTHREAD_MACHDEP_H/#endif

around variables only used when that macro is 0. Include what
you use: Cache.h and Heap.h.

bmalloc/PerThread.h: Include <memory> for std::once_flag.

4:24 PM Changeset in webkit [233549] by commit-queue@webkit.org

8 edits
2 deletes in trunk

Unreviewed, rolling out r233539.
https://bugs.webkit.org/show_bug.cgi?id=187368

Changes made for youtube crashes has caused 15 api failures
(Requested by Truitt on #webkit).

Reverted changeset:

"Youtube video pages crash after a couple of minutes"
https://bugs.webkit.org/show_bug.cgi?id=187316
https://trac.webkit.org/changeset/233539

4:17 PM Changeset in webkit [233548] by BJ Burg

2 edits in trunk/Source/WebKit

REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
https://bugs.webkit.org/show_bug.cgi?id=187367
<rdar://problem/41861346>

Reviewed by Timothy Hatcher.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.

4:12 PM Changeset in webkit [233547] by msaboff@apple.com

5 edits
1 add in trunk/Source/bmalloc

Disable IsoHeaps when Gigacage is off
https://bugs.webkit.org/show_bug.cgi?id=187160

Reviewed by Saam Barati.

Updated determineMallocFallbackState to base enabling of Iso Heaps on Gigacage
being enabled. We do this because if Gigacage is disabled, it may be due to lack
of address space.

To work around a compiler issue uncovered by the change above, I added explicit
instantiation of PerThread's static variables. Defined the same explicit
instantiated static variables with export scope in the new file PerThread.cpp
to eliminate separate variables allocations in each linked framework / library.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::determineMallocFallbackState):

bmalloc/PerThread.cpp: Added.
bmalloc/PerThread.h:

3:28 PM Changeset in webkit [233546] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Upstream hover gesture implementation
https://bugs.webkit.org/show_bug.cgi?id=187366

Reviewed by Wenson Hsieh.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView _hoverGestureRecognizerChanged:]):

3:20 PM Changeset in webkit [233545] by Chris Dumez

3 edits in trunk/Source/WebCore

Update Element API to use qualifiedName instead of name/localName where applicable
https://bugs.webkit.org/show_bug.cgi?id=187347

Reviewed by Darin Adler.

Update Element API to use qualifiedName instead of name/localName where applicable. Naming
is now consistent with the IDL and the specification:

https://dom.spec.whatwg.org/#element

Our implementation properly deals with qualified names already, even though the parameters
were named localName.

dom/Element.cpp:

(WebCore::Element::getAttribute const):
(WebCore::Element::toggleAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::getAttributeNode):
(WebCore::Element::hasAttribute const):

dom/Element.h:

3:20 PM Changeset in webkit [233544] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit

Fix some -Wdocumentation warnings in WebKit
https://bugs.webkit.org/show_bug.cgi?id=187318

Reviewed by Dan Bernstein.

Fix most of the -Wdocumentation warnings in WebKit. The remaining
ones are slightly mysterious, so we can't turn the warning on yet.

Configurations/BaseTarget.xcconfig:

Define U_HIDE_DEPRECATED_API. It's defined in all other WebKit projects,
and the doc comments in the deprecated ICU API have some errors.

UIProcess/API/Cocoa/WKUIDelegate.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Adjust comments or parameter names to be consistent with each other.

2:51 PM Changeset in webkit [233543] by Kocsen Chung

7 edits in trunk/Source

Versioning.

2:46 PM Changeset in webkit [233542] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

Unreviewed, rolling out r233417 and r233418.
https://bugs.webkit.org/show_bug.cgi?id=187364

Introduced an occasional crash on Google Drive (Requested by
rniwa on #webkit).

Reverted changesets:

"WTF's internal std::optional implementation should abort() on
bad optional access"
https://bugs.webkit.org/show_bug.cgi?id=186536
https://trac.webkit.org/changeset/233417

"WTF's internal std::optional implementation should abort() on
bad optional access"
https://bugs.webkit.org/show_bug.cgi?id=186536
https://trac.webkit.org/changeset/233418

2:43 PM Changeset in webkit [233541] by Kocsen Chung

4 edits in tags/Safari-606.1.24

Revert r233417. rdar://problem/41863878

2:35 PM Changeset in webkit [233540] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

ProgramExecutable may be collected as we checkSyntax on it
https://bugs.webkit.org/show_bug.cgi?id=187359
<rdar://problem/41832135>

Reviewed by Mark Lam.

The bug was we were passing in a reference to the SourceCode field on ProgramExecutable as
the ProgramExecutable itself may be collected. The fix here is to make a copy
of the field instead of passing in a reference inside of ParserError::toErrorObject.

No new tests here as this was already caught by our iOS JSC testers.

parser/ParserError.h:

(JSC::ParserError::toErrorObject):

2:02 PM Changeset in webkit [233539] by rniwa@webkit.org

9 edits
2 adds in trunk

Youtube video pages crash after a couple of minutes
https://bugs.webkit.org/show_bug.cgi?id=187316

Reviewed by Antti Koivisto.

Source/WebCore:

Test: media/remove-video-best-media-element-in-main-frame-crash.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call scheduleUpdatePlaybackControlsManager now that timer has been
moved to Page.
(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager): Made this return a RefPtr instead of
a raw pointer while we're at it.
(WebCore::HTMLMediaElement::clearMediaPlayer): Call scheduleUpdatePlaybackControlsManager.
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer): Ditto. Also invoke stopSession instead of
clientWillPausePlayback on MediaSession since clientWillPausePlayback will synchronously try to update the layout.
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::scheduleUpdatePlaybackControlsManager):
(WebCore::HTMLMediaElement::updatePlaybackControlsManager): Moved to Page::schedulePlaybackControlsManagerUpdate.

html/HTMLMediaElement.h:
page/Page.cpp:

(WebCore::Page::schedulePlaybackControlsManagerUpdate): Added.

page/Page.h:
testing/Internals.cpp:

(WebCore::Internals::bestMediaElementForShowingPlaybackControlsManager):

testing/Internals.h:

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

Added a regression test to remove an iframe with a video while there is a main content
which is eligible to be shown in the Touch Bar.

media/remove-video-best-media-element-in-main-frame-crash-expected.txt: Added.
media/remove-video-best-media-element-in-main-frame-crash.html: Added.

1:41 PM Changeset in webkit [233538] by Chris Dumez

2 edits in trunk/Source/WebKit

Regression(r232886): WebsiteDataStore objects may get destroyed on a background thread
https://bugs.webkit.org/show_bug.cgi?id=187356
<rdar://problem/41854555>

Reviewed by Geoffrey Garen.

As of r232886, CallbackAggregators in WebsiteDataStore hold a Ref<> to their WebsiteDataStore. This
is an issue because CallbackAggregator objects can get destroyed on a background thread and may be
the last ones holding a ref to the data store. When this happens, the WebsiteDataStore would get
destroyed on a background store and potentially cause crashes. Note that even if the callback
aggregator would not be the last one to hold a ref to the store, it still would not be safe to deref
the store on the background thread since WebsiteDataStore is not ThreadSafeRefCounted.

To address the issue, this patch updates the CallbackAggregators' destructor to deref their data
store member on the main thread. Note that we could also have WebsiteDataStore subclass
ThreadSafeRefCounted<T, DestructionThread::Main> but the data store technically does not need to
be ThreadSafeRefCounted at the moment.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

1:28 PM Changeset in webkit [233537] by Alan Bujtas

4 edits
2 adds in trunk

Do not assume that hypen's width can be computed using the simplified text measure codepath.
https://bugs.webkit.org/show_bug.cgi?id=187352
<rdar://problem/40821283>

Reviewed by Simon Fraser.

Source/WebCore:

Just because the text content is qualified for simplified text measure, it does not necessarily mean the hyphen is simple enough as well.

Test: fast/text/hyphen-is-complex-crash.html

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):

rendering/SimpleLineLayoutTextFragmentIterator.h:

LayoutTests:

fast/text/hyphen-is-complex-crash-expected.txt: Added.
fast/text/hyphen-is-complex-crash.html: Added.

12:45 PM Changeset in webkit [233536] by mitz@apple.com

2 edits in trunk/Source/WebKit

[macOS] REGRESSION: Development WebContent service has restricted entitlements, rendering it useless for development
https://bugs.webkit.org/show_bug.cgi?id=187355

Reviewed by Anders Carlsson.

Configurations/WebContentService.Development.xcconfig: Set WK_USE_RESTRICTED_ENTITLEMENTS to NO for the Development service.

12:42 PM Changeset in webkit [233535] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Video sometimes flickers when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=187193
<rdar://problem/40153865>

Unreviewed, fix a broken API test.

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory): None should set the category to AVAudioSessionCategoryAmbient,
because it signals that WebKit is not playing audio so we want allow other apps to play.

12:39 PM Changeset in webkit [233534] by pvollan@apple.com

2 edits in trunk/Source/WebCore

Use ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=187334

Reviewed by Alex Christensen.

Use ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) instead of MAC_OS_X_VERSION_MIN_REQUIRED when deciding
to use NSTimer or NSAnimation for scrollbar animation.

No new tests. No change in behavior.

platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation startAnimation]):
(-[WebScrollbarPartAnimation setCurrentProgress:setCurrentProgress:]):

12:28 PM Changeset in webkit [233533] by Wenson Hsieh

2 edits in trunk/LayoutTests

[WK1] editing/spelling/markers.html times out on High Sierra after r233439
https://bugs.webkit.org/show_bug.cgi?id=187351

Reviewed by Tim Horton.

This is currently timing out on High Sierra, because the verifyUnexpectedMarkers portion of the
test fails to actually make use of the override spell checking results. Fix this by passing the
results when calling the function.

editing/spelling/markers.html:

12:11 PM Changeset in webkit [233532] by timothy@apple.com

5 edits in trunk/Source/WebCore

Don't invert text color for selections in light mode.
https://bugs.webkit.org/show_bug.cgi?id=187349
rdar://problem/41297946

Reviewed by Tim Horton.

Fix color caching in RenderTheme so we don't cache a dark mode color
for a light appearance, or vise versa. Use the new color caching
in RenderThemeMac, and clear the color caches in purgeCaches.

Allow supportsSelectionForegroundColors to conditionalize on StyleColor::Options.
Return true only in dark mode.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::activeSelectionBackgroundColor const):
(WebCore::RenderTheme::inactiveSelectionBackgroundColor const):
(WebCore::RenderTheme::activeSelectionForegroundColor const):
(WebCore::RenderTheme::inactiveSelectionForegroundColor const):
(WebCore::RenderTheme::activeListBoxSelectionBackgroundColor const):
(WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderTheme::activeListBoxSelectionForegroundColor const):
(WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor const):
(WebCore::RenderTheme::purgeCaches):
(WebCore::RenderTheme::platformColorsDidChange):
(WebCore::RenderTheme::activeTextSearchHighlightColor const):
(WebCore::RenderTheme::inactiveTextSearchHighlightColor const):

rendering/RenderTheme.h:

(WebCore::RenderTheme::supportsSelectionForegroundColors const):
(WebCore::RenderTheme::supportsListBoxSelectionForegroundColors const):
(WebCore::RenderTheme::colorCache const):
(WebCore::RenderTheme::purgeCaches): Deleted.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::purgeCaches):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors const):
(WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::colorCache const):
(WebCore::RenderThemeMac::systemColor const):

11:36 AM Changeset in webkit [233531] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] Bindings-tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187330

Reviewed by David Kilzer.

BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests): Passed --json-output parameter to run-bindings-tests.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

11:18 AM Changeset in webkit [233530] by Alan Bujtas

2 edits in trunk/Source/WebCore

SimpleLineLayout::FlowContents wastes 54KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186709
<rdar://problem/41173793>

Reviewed by Simon Fraser.

The size of the m_segments vector in SimpleLineLayoutFlowContents is alway pre-computed and don't change after the initial append.

Not testable.

rendering/SimpleLineLayoutFlowContents.h:

10:52 AM Changeset in webkit [233529] by Kocsen Chung

1 copy in tags/Safari-606.1.24

Tag Safari-606.1.24.

10:49 AM Changeset in webkit [233528] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] WebKitPy-Tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187331

Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.

10:25 AM Changeset in webkit [233527] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] WebKitPy-Tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187331

Reviewed by David Kilzer.

BuildSlaveSupport/ews-build/steps.py:

(RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

10:22 AM Changeset in webkit [233526] by Kocsen Chung

7 edits in tags/Safari-605.3.8.1/Source

Versioning.

10:20 AM Changeset in webkit [233525] by n_wang@apple.com

3 edits
2 adds in trunk

AX: setValue on text controls should send out key events
https://bugs.webkit.org/show_bug.cgi?id=186690
<rdar://problem/41169985>

Reviewed by Chris Fleizach.

Source/WebCore:

Use Editor's insertText function when the text control element is being
focused, so that the InputEvent will be dispatched properly.

Test: accessibility/mac/set-value-editable-dispatch-events.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setValue):

LayoutTests:

accessibility/mac/set-value-editable-dispatch-events-expected.txt: Added.
accessibility/mac/set-value-editable-dispatch-events.html: Added.

10:09 AM Changeset in webkit [233524] by Kocsen Chung

1 copy in tags/Safari-605.3.8.1

New tag.

10:07 AM Changeset in webkit [233523] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test svg/animations/animateMotion-additive-2c.svg and svg/animations/animateMotion-additive-2d.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=187345

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-05

platform/mac-wk2/TestExpectations:

9:59 AM Changeset in webkit [233522] by Kocsen Chung

7 edits in branches/safari-605-branch/Source

Versioning.

9:05 AM Changeset in webkit [233521] by Chris Dumez

2 edits in trunk/Source/WebCore

ASSERT(m_dictionaryStack.size() == 1) assertion hit in ~KeyedDecoderCF() when decoding fails
https://bugs.webkit.org/show_bug.cgi?id=187152

Reviewed by Brent Fulgham.

Whenever a call to KeyedDecoderCF::beginArrayElement() succeeds (returns true), it
appends an item to m_dictionaryStack which is expected to get popped later on via
a matching call to KeyedDecoderCF::endArrayElement(). The ASSERT(m_dictionaryStack.size() == 1)
assertion in the destructor protects against a begin / end mismatch.

However, there was a bug in KeyedDecoder::decodeObjects(), which would cause us to return early
after a call to beginArrayElement() when the lambda function call returns false, causing us
not to call the matching endArrayElement() in this case. This patch addresses the issue by
calling endArrayElement() before returning early.

This bug was uncovered by r233309 which slightly changed the ITP encoding / decoding format.
Because empty HashCountedSets are now expected to be encoded as empty array, decoding of old
data fails and we hit the buggy code path.

platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeObjects):

8:46 AM Changeset in webkit [233520] by Antti Koivisto

16 edits
2 adds in trunk/Source/WebCore

Move CSSParserContext to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=187342

Reviewed by Zalan Bujtas.

Move it out from CSSParserMode.h and CSSParser.cpp.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
contentextensions/ContentExtensionParser.cpp:
css/PropertySetCSSStyleDeclaration.h:
css/StyleProperties.h:
css/StyleSheetContents.h:
css/parser/CSSDeferredParser.h:
css/parser/CSSParser.cpp:

(WebCore::strictCSSParserContext): Deleted.
(WebCore::CSSParserContext::CSSParserContext): Deleted.
(WebCore::operator==): Deleted.

css/parser/CSSParser.h:
css/parser/CSSParserContext.cpp: Added.

(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

Also add the missing textAutosizingEnabled bit.

css/parser/CSSParserContext.h: Copied from Source/WebCore/css/parser/CSSParserMode.h.

(WebCore::CSSParserContextHash::hash):

Also add the missing bits to the hash function.

(WebCore::isQuirksModeBehavior): Deleted.
(WebCore::isUASheetBehavior): Deleted.
(WebCore::isUnitLessValueParsingEnabledForMode): Deleted.
(WebCore::isCSSViewportParsingEnabledForMode): Deleted.
(WebCore::strictToCSSParserMode): Deleted.
(WebCore::isStrictParserMode): Deleted.

css/parser/CSSParserIdioms.h:
css/parser/CSSParserImpl.h:
css/parser/CSSParserMode.h:

(WebCore::CSSParserContext::completeURL const): Deleted.
(WebCore::operator!=): Deleted.
(WebCore::CSSParserContextHash::hash): Deleted.
(WebCore::CSSParserContextHash::equal): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::constructDeletedValue): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::isDeletedValue): Deleted.
(WTF::HashTraits<WebCore::CSSParserContext>::emptyValue): Deleted.

css/parser/CSSPropertyParserHelpers.h:
css/parser/CSSSelectorParser.cpp:
css/parser/CSSVariableParser.cpp:

7:56 AM Changeset in webkit [233519] by graouts@webkit.org

6 edits in trunk

[Web Animations] The ready promise should initially be resolved
https://bugs.webkit.org/show_bug.cgi?id=187341
<rdar://problem/41844711>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt:
web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt:

Source/WebCore:

The Web Animations spec mandates that the ready promise is initially resolved.

animation/WebAnimation.cpp:

(WebCore::WebAnimation::WebAnimation):

7:18 AM Changeset in webkit [233518] by commit-queue@webkit.org

4 edits
1 delete in trunk/Source/WebKit

[GTK] Remove soup/DownloadSoupErrors.h
https://bugs.webkit.org/show_bug.cgi?id=187339

This header is not used anymore.

Patch by Rob Buis <rbuis@igalia.com> on 2018-07-05
Reviewed by Frédéric Wang.

NetworkProcess/Downloads/soup/DownloadSoupErrors.h: Removed.
NetworkProcess/soup/NetworkDataTaskSoup.cpp:
PlatformGTK.cmake:

6:43 AM Changeset in webkit [233517] by Philippe Normand

2 edits in trunk/Tools

[Flatpak] Add gst-libav to dependencies
https://bugs.webkit.org/show_bug.cgi?id=187340

Reviewed by Žan Doberšek.

flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git

clones because the FFMPeg git server doesn't support shallow
clones.

5:41 AM Changeset in webkit [233516] by Carlos Garcia Campos

4 edits in trunk/Source/WebDriver

[GTK][WPE] Add --host option to WebDriver process
https://bugs.webkit.org/show_bug.cgi?id=187288

Reviewed by Žan Doberšek.

We currently allow to pass a port number and the server always listens for connections on localhost. We should
allow to optionally pass a host IP address to be able to use WebDriver remotely.

HTTPServer.h:
WebDriverService.cpp:

(WebDriver::printUsageStatement): Update usage to include --host option.
(WebDriver::WebDriverService::run): Parse --host option and pass it to HTTPServer::listen().

soup/HTTPServerSoup.cpp:

(WebDriver::soupServerListen): Helper to call soup_server_listen_local(), soup_server_listen_all() or
soup_server_listen() depending on the given host.
(WebDriver::HTTPServer::listen): Use soupServerListen() helper.

4:42 AM Changeset in webkit [233515] by svillar@igalia.com

3 edits in trunk/Source/WebCore

[WebVR] Fix VRDisplayEvent implementation
https://bugs.webkit.org/show_bug.cgi?id=187337

Reviewed by Žan Doberšek.

VRDisplayEvent implementation had two issues. First there were no attributes storing the
VRDisplay the event refers to. Secondly the VRDisplayEventReason is not mandatory so it
should be handled via an optional.

Modules/webvr/VRDisplayEvent.cpp:

(WebCore::VRDisplayEvent::VRDisplayEvent):
(WebCore::VRDisplayEvent::display const): Deleted.
(WebCore::VRDisplayEvent::reason const): Deleted.

Modules/webvr/VRDisplayEvent.h:

1:07 AM Changeset in webkit [233514] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
https://bugs.webkit.org/show_bug.cgi?id=187322

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-05
Reviewed by Žan Doberšek.

flatpak/flatpakutils.py:

(WebkitFlatpak.init):

12:40 AM Changeset in webkit [233513] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed, rolling out r233511.

Proper fix provided in bug #187322

Reverted changeset:

"Unreviewed. Fixing a call in flatpakutils.py to
PortFactory.get(),"
https://trac.webkit.org/changeset/233511

Jul 4, 2018:

11:54 PM Changeset in webkit [233512] by Carlos Garcia Campos

11 edits
2 adds in trunk

REGRESSION(r233325): [GTK] Broke 40 animations tests
https://bugs.webkit.org/show_bug.cgi?id=187264

Reviewed by Žan Doberšek.

Source/WebCore:

This is because DocumentAnimationScheduler uses DisplayRefreshMonitor, that is only used by GTK port when
accelerated compositing is enabled. Add a GTK display refresh monitor implementation to be used as the default.

PlatformGTK.cmake: Add new file to compilation.
platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor): Create DisplayRefreshMonitorGtk in GTK.

platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp: Added.

(WebCore::DisplayRefreshMonitorGtk::DisplayRefreshMonitorGtk):
(WebCore::DisplayRefreshMonitorGtk::~DisplayRefreshMonitorGtk):
(WebCore::onFrameClockUpdate):
(WebCore::DisplayRefreshMonitorGtk::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorGtk::displayLinkFired):

platform/graphics/gtk/DisplayRefreshMonitorGtk.h: Added.

(WebCore::DisplayRefreshMonitorGtk::create):

Source/WebKit:

Use a different PlatformDisplayID for compositing in the GTK port. This way, when entering AC a window screen
changed is emitted and the GTK default display refresh monitor is destroyed, ensuring the one created by the
threaded compositor is used.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::create): Remove unused WebPage parameter and add PlatformDisplayID.
(WebKit::ThreadedCompositor::ThreadedCompositor): Create the display refresh monitor with the given displayID.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor): Pass the given displayID to the parent constructor.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:

(WebKit::ThreadedDisplayRefreshMonitor::create): Add PlatformDisplayID parameter.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Use compositingDisplayID when
creating the threaded compositor and notify about the window screen change.
(WebKit::ThreadedCoordinatedLayerTreeHost::setIsDiscardable): Use primaryDisplayID when leaving AC and
compositingDisplayID when re-entering.

LayoutTests:

Remove expectations for tests that are passing now.

platform/gtk/TestExpectations:

10:48 PM Changeset in webkit [233511] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
enforcing the passed platform argument to always be lowercase, as is
expected from the PortFactory code.

flatpak/flatpakutils.py:

(WebkitFlatpak.clean_args):

8:50 PM Changeset in webkit [233510] by Antti Koivisto

7 edits
2 adds in trunk

Reparse user stylesheets when _useSystemAppearance changes
https://bugs.webkit.org/show_bug.cgi?id=187312
<rdar://problem/38565834>

Reviewed by Tim Horton.

Source/WebCore:

This setting may affect user stylesheet parsing. Reparse if it changes.

Test: fast/media/use-system-appearance-user-stylesheet-parsing.html

page/Page.cpp:

(WebCore::Page::setUseSystemAppearance):

page/Page.h:

(WebCore::Page::setUseSystemAppearance): Deleted.

testing/Internals.cpp:

(WebCore::Internals::setUseSystemAppearance):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/media/use-system-appearance-user-stylesheet-parsing-expected.txt: Added.
fast/media/use-system-appearance-user-stylesheet-parsing.html: Added.

1:12 PM Changeset in webkit [233509] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

RealtimeIncomingVideoSources: Call stop() directly in the destructor
https://bugs.webkit.org/show_bug.cgi?id=187303

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Youenn Fablet.

Avoiding to call stopProducingData when we are not actually producing data.

This fixes tests that will run once the WPE/GTK PeerConnection implementation is merged.

platform/mediastream/RealtimeIncomingVideoSource.h:

(WebCore::RealtimeIncomingVideoSource::~RealtimeIncomingVideoSource):

1:08 PM Changeset in webkit [233508] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=187304

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Philippe Normand.

We let parsebin build the StreamCollection for us and pass extra metadata through the
TAG_EVENT pushing the collection ourself is not bringing anything but adds extra work in the
MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.

MediaStream layout tests already test that code path.

platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(WebCore::webkitMediaStreamSrcPadProbeCb):

11:45 AM Changeset in webkit [233507] by aboya@igalia.com

3 edits in trunk/LayoutTests

Unreviewed GTK test gardening.
https://bugs.webkit.org/show_bug.cgi?id=187328

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

8:47 AM Changeset in webkit [233506] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/libwebrtc

[libwebrtc] Allow IP mismatch for local connections on localhost
https://bugs.webkit.org/show_bug.cgi?id=187302

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Youenn Fablet.

The rest of the code allows it, but there was an unecessary assert

Source/webrtc/p2p/base/tcpport.cc:

7:17 AM Changeset in webkit [233505] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 60

Added a tag for Safari Technology Preview release 60.

5:54 AM Changeset in webkit [233504] by guijemont@igalia.com

2 edits in trunk/Source/WTF

FunctionTraits: Make cCallArity() constant on 32-bits.
https://bugs.webkit.org/show_bug.cgi?id=187292

Reviewed by Yusuke Suzuki.

On X86, in Source/JavaScriptCore/jit/CCallHelpers.h we have a
static_assert that uses cCallArity(), so it needs to be constant to
avoid a compilation error. This is achieved by changing an ASSERT into
a static_assert.

wtf/FunctionTraits.h:

(WTF::slotsForCCallArgument):

2:49 AM Changeset in webkit [233503] by fred.wang@free.fr

2 edits in trunk/Source/WebCore

[WebIDL] Remove custom bindings for HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=173444

Unreviewed, add missing bugzilla link for FIXME comments.

Patch by Frederic Wang <fwang@igalia.com> on 2018-07-04

dom/Document.cpp:

(WebCore::Document::closeForBindings):
(WebCore::Document::write):
(WebCore::Document::writeln):

2:43 AM Changeset in webkit [233502] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

A WKWebView in a UIViewController that is presented modally and uses a file picker will be incorrectly dismissed by the system
https://bugs.webkit.org/show_bug.cgi?id=185257
<rdar://problem/40819252>

Patch by Olivia Barnett <obarnett@apple.com> on 2018-07-04
Reviewed by Tim Horton.

Call to dismiss the presented modal was being called on the parent and not the child, which caused the file picker to be incorrectly dismissed along with the modal. A test for this bug-fix could not be completed without additional tools as TestWebKitAPI is not a UI application.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _dismissDisplayAnimated:]):

2:06 AM Changeset in webkit [233501] by timothy_horton@apple.com

67 edits in trunk

Introduce PLATFORM(IOSMAC)
https://bugs.webkit.org/show_bug.cgi?id=187315

Reviewed by Dan Bernstein.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/WebCore.xcconfig:
Modules/geolocation/ios/GeolocationPositionIOS.mm:

(WebCore::GeolocationPosition::GeolocationPosition):

page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::platformReleaseMemory):

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::routingContextUID const):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldDisableSleep):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):

platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderRegistrationInfoList itemProvider]):

Source/WebCore/PAL:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
pal/cf/CoreMediaSoftLink.cpp:
pal/cf/CoreMediaSoftLink.h:
pal/spi/mac/AVFoundationSPI.h:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/NetworkService.xcconfig:
Configurations/WebContentService.xcconfig:
Configurations/WebKit.xcconfig:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::sourceApplicationAuditData const):

NetworkProcess/ios/NetworkProcessIOS.mm:
NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::initializeProcessName):
(WebKit::overrideSystemProxies):

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForExternalHostingProcess):

Platform/spi/ios/UIKitSPI.h:
Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::initializeSandbox):

Shared/ios/InteractionInformationAtPosition.h:
Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setApplicationIsDaemon):
(WebKit::enableSandboxStyleFileQuarantine):

Shared/mac/CodeSigning.mm:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webViewPrintFormatter]):

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

UIProcess/_WKWebViewPrintFormatter.mm:
UIProcess/_WKWebViewPrintFormatterInternal.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _didExitStableState]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):
(-[WKContentView setSelectedTextRange:]):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView _updateChangedSelection:]):

UIProcess/ios/WKLegacyPDFView.mm:
UIProcess/ios/WKPDFView.mm:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox):

config.h:

Source/WebKitLegacy/ios:

Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
wtf/FeatureDefines.h:
wtf/Platform.h:

Tools:

TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:58 AM Changeset in webkit [233500] by graouts@webkit.org

7 edits in trunk

[Web Animations] Make WPT test at timing-model/timelines/timelines.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186508
<rdar://problem/41000260>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Record WPT test progressions.

web-platform-tests/web-animations/interfaces/Animation/finished-expected.txt:
web-platform-tests/web-animations/timing-model/timelines/timelines-expected.txt:

Source/WebCore:

The remaining failing assertion in this test assumes that the ready promise for an animation is fired
prior to requestAnimationFrame callbacks being fired in the current event loop such that registering
the requestAnimationFrame() call within the ready promise has its callback fired with the same timeline
time. To ensure that is true, we perform a microtask checkpoint as soon as we're done running pending
tasks, which will resolve the ready promise for any play-pending animations.

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations):

LayoutTests:

We're now passing this test reliably.

TestExpectations:

12:43 AM Changeset in webkit [233499] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

50 failing WebDriver tests after r233417
https://bugs.webkit.org/show_bug.cgi?id=187263

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-07-04
Reviewed by Frédéric Wang.

A std::optional value is used while being std::nullopt. This is because the wrong input source is used when
transitioning keyboard input states.

Context Navigation

Timeline

Jul 5, 2018:

Jul 4, 2018:

Download in other formats: