Timeline

Jul 12, 2018:

11:22 PM Changeset in webkit [233794] by Wenson Hsieh

• 9 edits
  1 copy in trunk

Make it easier to hit the significant rendered text layout milestone on pages with main article elements
​https://bugs.webkit.org/show_bug.cgi?id=187578
<rdar://problem/42104637>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Our current heuristics for triggering the significant rendered text layout milestone are very conservative, with
the intention of avoiding false positives. In practice, we can relax some of these constraints when we've
detected the presence of a main article element on the page. (e.g. in New York Times articles). See per-method
changes below for more detail.

Test: RenderingProgressTests.DidRenderSignificantAmountOfText

• dom/Document.cpp:

(WebCore::Document::registerArticleElement):
(WebCore::Document::unregisterArticleElement):
(WebCore::Document::updateMainArticleElementAfterLayout):

As a post layout task, update the main article element by looping through the articles (up to a maximum limit of
10) in search of an article element that is several times larger than the second largest article element.

• dom/Document.h:

Store a set containing the article elements in the document, as well as the current main article on the page.

(WebCore::Document::hasMainArticleElement const):

• html/Element.cpp:

(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::removedFromAncestor):

Keep track of the article elements that exist in the document whenever elements with the article tag are added
to or removed from the document.

• page/FrameView.cpp:

Add new minimum thresholds for firing the significant rendered text milestone when there exists a main article.

(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):

Take the main article element into consideration when determining whether to fire the significant text
layout milestone.

Tools:

Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
articles).

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
• TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
• TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:

(TEST):

8:13 PM Changeset in webkit [233793] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

JavaScript URL gives incorrect result when frame is navigated
​https://bugs.webkit.org/show_bug.cgi?id=187203
<rdar://problem/41438443>

Reviewed by David Kilzer.

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):

7:06 PM Changeset in webkit [233792] by Matt Baker

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
​https://bugs.webkit.org/show_bug.cgi?id=187612
<rdar://problem/42131910>

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/TypeTokenAnnotator.js:

(WI.TypeTokenAnnotator.prototype.insertAnnotations):
(WI.TypeTokenAnnotator.prototype._insertTypeToken):
(WI.TypeTokenAnnotator.prototype._insertToken):
Use line/column locations, instead of offsets, from the AST when calculating
token positions for CodeMirror. Once in CodeMirror's string space, we
can safely convert to/from offsets.

• UserInterface/Models/ScriptSyntaxTree.js:

Retrieve line/column locations for AST nodes, in addition to offsets.
Offsets into the original file are still needed for getting type information
from the profiler in the backend.

(WI.ScriptSyntaxTree):
(WI.ScriptSyntaxTree.prototype.filterByRange):
Filter by positions, which can be safely used from CodeMirror, instead of offsets.

(WI.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WI.ScriptSyntaxTree.prototype.filterByRange.filterForNodesInRange): Deleted.

• UserInterface/Models/SourceCodePosition.js:

Add convenience methods for comparing line/column positions, and for
converting to the format expected by CodeMirror. SourceCodePosition could
be made to interoperate with CodeMirror by exposing properties line
and ch, but making the conversion explicit improves code readability.

(WI.SourceCodePosition.prototype.equals):
(WI.SourceCodePosition.prototype.isBefore):
(WI.SourceCodePosition.prototype.isAfter):
(WI.SourceCodePosition.prototype.isWithin):
(WI.SourceCodePosition.prototype.toCodeMirror):
(WI.SourceCodePosition):

• UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.visibleRangePositions):
(WI.TextEditor.prototype.originalPositionToCurrentPosition):
(WI.TextEditor.prototype.currentOffsetToCurrentPosition):
(WI.TextEditor.prototype.currentPositionToCurrentOffset):
(WI.TextEditor.prototype.setInlineWidget):

6:20 PM Changeset in webkit [233791] by Fujii Hironori

• 2 edits in trunk/Tools

Change my status to be a WebKit reviewer.

Unreviewed status update.

• Scripts/webkitpy/common/config/contributors.json:

6:16 PM Changeset in webkit [233790] by Fujii Hironori

• 2 edits in trunk/Tools

Unreviewed contributors.json update

Just run "validate-committer-lists -c" to canonicalize the style.

• Scripts/webkitpy/common/config/contributors.json:

5:28 PM Changeset in webkit [233789] by achristensen@apple.com

• 9 edits in trunk

Reduce size of WebCore::URL
​https://bugs.webkit.org/show_bug.cgi?id=186820

Reviewed by Yusuke Suzuki and Youenn Fablet.

Source/WebCore:

We were using 32 bits for the length of the port, which is always between 0 and 5 inclusive
because port numbers are missing or between 0 and 65535. Let's just use 3 bits here.
We were using 32 bits for the length of the scheme, which is usually 3-5 characters and can be
longer for some custom schemes, but I've never seen one more than 20 characters. If we assume
schemes are always less than 64MB, we can save 8 bytes per URL!

No change in behavior, just less memory use!

To restore the IPC encoding to how it was before r221165, I just encode the string and reparse it.

• platform/URL.cpp:

(WebCore::URL::invalidate):
(WebCore::URL::lastPathComponent const):
(WebCore::URL::port const):
(WebCore::URL::protocolHostAndPort const):
(WebCore::URL::path const):
(WebCore::URL::removePort):
(WebCore::URL::setPort):
(WebCore::URL::setHostAndPort):
(WebCore::URL::setPath):

• platform/URL.h:

(WebCore::URL::encode const):
(WebCore::URL::decode):
(WebCore::URL::hasPath const):
(WebCore::URL::pathStart const):

• platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):
(WebCore::URLParser::parsePort):
(WebCore::URLParser::parseHostAndPort):
(WebCore::URLParser::allValuesEqual):
(WebCore::URLParser::internalValuesConsistent):

• workers/service/server/RegistrationDatabase.cpp:

Increment the service worker registration schema version because of the URL encoding change.

Source/WebKit:

• NetworkProcess/cache/NetworkCacheStorage.h:

Increment cache version because of URL encoding change.

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

5:03 PM Changeset in webkit [233788] by Chris Dumez

• 3 edits in trunk/Source/WebKit

[Cocoa] Make sure NetworkProcess::createNetworkConnectionToWebProcess() returns a valid mach port
​https://bugs.webkit.org/show_bug.cgi?id=187625

Reviewed by Youenn Fablet.

Make sure NetworkProcess::createNetworkConnectionToWebProcess() returns a valid mach port to help
debug <rdar://problem/41995022>.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):

4:46 PM Changeset in webkit [233787] by Chris Dumez

• 3 edits in trunk/Source/WebKit

PingLoad does not need to ref the NetworkConnectionToWebProcess
​https://bugs.webkit.org/show_bug.cgi?id=187624

Reviewed by Youenn Fablet.

PingLoad does not need to ref the NetworkConnectionToWebProcess and keep it alive longer than it needs to be.
Instead, ref the IPC::Connection which is lighter weight and gets invalidated when the NetworkConnectionToWebProcess
is destroyed.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad): Deleted.

• NetworkProcess/NetworkConnectionToWebProcess.h:

4:37 PM Changeset in webkit [233786] by beidson@apple.com

• 9 edits in trunk

Make process-swap-on-navigation an experimental feature.
<rdar://problem/41995053> and ​https://bugs.webkit.org/show_bug.cgi?id=187558

Reviewed by Chris Dumez.

Source/WebKit:

• Shared/WebPreferences.yaml:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetProcessSwapOnNavigationEnabled):
(WKPreferencesGetProcessSwapOnNavigationEnabled):

• UIProcess/API/C/WKPreferencesRef.h:

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage): If the new web page has PSON enabled via WebPreferences,

absorb that setting into this process pool's configuration.

Tools:

Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetPreferencesToConsistentValues):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):

4:29 PM Changeset in webkit [233785] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Simplify code in NetworkConnectionToWebProcess::didReceiveMessage()
​https://bugs.webkit.org/show_bug.cgi?id=187621

Reviewed by Youenn Fablet.

Simplify code in NetworkConnectionToWebProcess::didReceiveMessage() by not using HashMap iterators and
calling get() directly.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):

3:24 PM Changeset in webkit [233784] by Chris Dumez

• 4 edits in trunk/Source

Make sure WebProcess::ensureNetworkProcessConnection() is always called on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=187607

Reviewed by Alex Christensen.

Add release assertion to make sure that ensureNetworkProcessConnection() is always called on the main
thread. Calling it on a background thread would not be safe. It would not be safe because:

1. We check if we have a network process connection and then create one if we don't without any locking.
2. It is not safe to construct or use a NetworkProcessConnection object from a non-main thread

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):

3:21 PM Changeset in webkit [233783] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Assert that the IPC::Connection is valid in Connection::dispatchMessage(Decoder&)
​https://bugs.webkit.org/show_bug.cgi?id=187617

Reviewed by Youenn Fablet.

Assert that the IPC::Connection is valid in Connection::dispatchMessage(Decoder&) as
m_client would be stale otherwise.

• Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchMessage):

2:34 PM Changeset in webkit [233782] by youenn@apple.com

• 23 edits
  2 adds in trunk

Add a FrameLoaderClient willInjectUserScriptForFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=187565

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/contentextensions/injected-script-callback.html.

• loader/FrameLoaderClient.h:
• page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):
Calling the new callback whenever being about to inject a new script.

Source/WebKit:

Introduce a new WKBundlePageLoaderClient callback that is called everytime a user script is injected.
Implement WebFrameLoaderClient::willInjectUserScript by calling this new callback.

• WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::willInjectUserScriptForFrame):

• WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(setUpPageLoaderClient):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willInjectUserScriptForFrame):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willInjectUserScript):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Added new test runner API to check for willInjectUserScriptForFrame callback.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::resetUserScriptInjectedCount):
(WTR::InjectedBundle::increaseUserScriptInjectedCount):
(WTR::InjectedBundle::userScriptInjectedCount const):

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::willInjectUserScriptForFrame):

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::userScriptInjectedCount const):
(WTR::TestRunner::injectUserScript):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::injectUserScript):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::injectUserScript):

LayoutTests:

• http/tests/contentextensions/injected-script-callback-expected.txt: Added.
• http/tests/contentextensions/injected-script-callback.html: Added.

2:24 PM Changeset in webkit [233781] by commit-queue@webkit.org

• 22 edits in trunk/Source/WebKit

[iOS] When bringing MobileSafari to the foreground, images are drawn asynchronously after removing a snapshot that included them
​https://bugs.webkit.org/show_bug.cgi?id=187374
<rdar://problem/41249545>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-07-12
Reviewed by Tim Horton.

UIProcess should block committing all the layer tree transactions for
immediate update until it receives a one whose activityStateChangeID is
greater than or equal to the one it sends with SetActivityState message.

• Scripts/webkit/messages.py:

Fix the messages code generator to include DrawingAreaInfo.h for the WebKit
typedef ActivityStateChangeID.

• Shared/DrawingAreaInfo.h:

Define ActivityStateChangeID to be uint64_t. Add a definition for the case
when the UIProcess won't be blocked for a reply back from the WebProcess.

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::activityStateChangeID const):
(WebKit::RemoteLayerTreeTransaction::setActivityStateChangeID):
Add a member for activityStateChangeID in the LayerTreeTransaction.

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):
Make LayerTreeTransaction know how to encode and decode activityStateChangeID.

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForDidUpdateActivityState):

• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
Make the DrawingArea in the UIProcess wait the layer tree with a certain
activityStateChangeID.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::waitForDidUpdateActivityState):
If m_activityStateChangeWantsSynchronousReply is true, generate a new
activityStateChangeID and send it in the SetActivityState message.

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::takeNextActivityStateChangeID):
A simple way to generate a new activityStateChangeID.

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateActivityState):
Fix the UIProcess functions' prototype for Mac.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::activityStateDidChange):

• WebProcess/WebPage/AcceleratedDrawingArea.h:

Fix the UIProcess functions' prototype for GTK.

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::activityStateDidChange):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:

Replace wantsDidUpdateActivityState with activityStateChangeID. Treat
activityStateChangeID == ActivityStateChangeAsynchronous as if
wantsDidUpdateActivityState == false.

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Make the WebPrcess pass the activityStateChangeID which it receives from
the SetActivityState message to the LayerTreeTransaction.

(WebKit::RemoteLayerTreeDrawingArea::activityStateDidChange):
When receiving the SetActivityState, treat activityStateChangeID !=
ActivityStateChangeAsynchronous as if wantsDidUpdateActivityState == true.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setActivityState):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Replace the boolean wantsDidUpdateActivityState with activityStateChangeID
in the SetActivityState message.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired):
Fix the WebProcess functions' prototype for Mac.

1:11 PM Changeset in webkit [233780] by Antti Koivisto

• 4 edits in trunk/Source/WebKit

REGRESSION (r232356): After zooming a page in and out, it's possible to temporarily have missing tiles (google.com, apple.com)
​https://bugs.webkit.org/show_bug.cgi?id=187553
<rdar://problem/41863803>

Reviewed by Simon Fraser.

We ignore zoom scale from UI process if it doesn't match the last remote layer tree transaction. However nothing
guarantees that we receive the real scale again until user interacts with the page. This means the web process
scale and the UI process scale can be wildly out of sync.

This problem becomes more likely to be visible when

• we are under memory pressure so we don't update tiles during zooming and rely on the one final update afterwards
• the page generates lots of layer tree transactions

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):

Remember the last transaction where we actually changed the page scale.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::scaleFromUIProcess const):

Only reject the UI process scale if there has been a scale changing transaction meanwhile.
The transaction id test was added in r218149 and the problem it fixed remains fixed. This change also matches better
what it was purpoted to implement.

12:52 PM Changeset in webkit [233779] by Ross Kirsling

• 4 edits in trunk/LayoutTests/dom/xhtml/level3/core

UTF-16 XHTML files need svn:mime-type to be handled correctly by Windows SVN
​https://bugs.webkit.org/show_bug.cgi?id=187571

Reviewed by Alex Christensen.

svn propsets cannot be committed with webkit-patch land.
This commit actually does what the previous one claimed to.

• dom/xhtml/level3/core/documentgetinputencoding03.xhtml:
• dom/xhtml/level3/core/entitygetinputencoding02.xhtml:
• dom/xhtml/level3/core/entitygetxmlversion02.xhtml:
• dom/xhtml/level3/core/external_foo.ent:

Added property svn:mime-type and removed property svn:eol-style (to align with documentgetxmlencoding03.xhtml).

12:46 PM Changeset in webkit [233778] by Megan Gardner

• 7 edits in trunk/Source

Keep Selections within Shadow DOM boundaries
​https://bugs.webkit.org/show_bug.cgi?id=187556
<rdar://problem/41664567>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Expose needed functionality to WebKit to help with determing editing and shadow dom boundries.

Only exposing functionality to WebKit.

• dom/TreeScope.h:
• editing/Editing.h:
• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustPositionForEnd const):
(WebCore::VisibleSelection::adjustPositionForStart const):
(WebCore::adjustPositionForEnd): Deleted.
(WebCore::adjustPositionForStart): Deleted.

• editing/VisibleSelection.h:

Source/WebKit:

Update rangeForPosition to take into account both editing and shadow DOM boundries.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPoint):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::rangeForPosition): Deleted.

12:14 PM Changeset in webkit [233777] by sihui_liu@apple.com

• 5 edits
  3 adds in trunk

IndexedDB: database file of subframe cannot be removed
​https://bugs.webkit.org/show_bug.cgi?id=187564

Reviewed by Youenn Fablet.

Source/WebCore:

For IndexedDB, if openingOrigin is different from mainFrameOrigin, there will be another
layer in the database file path.
IDBServer should delete database files recursively to make sure all files are removed.

Covered by modified test: WebKit.WebsiteDataStoreCustomPaths.

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::removeAllDatabasesForOriginPath):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

12:07 PM Changeset in webkit [233776] by Ross Kirsling

• 1 edit in trunk/LayoutTests/ChangeLog

UTF-16 XHTML files need svn:mime-type to be handled correctly by Windows SVN
​https://bugs.webkit.org/show_bug.cgi?id=187571

Reviewed by Alex Christensen.

• dom/xhtml/level3/core/documentgetinputencoding03.xhtml:
• dom/xhtml/level3/core/entitygetinputencoding02.xhtml:
• dom/xhtml/level3/core/entitygetxmlversion02.xhtml:
• dom/xhtml/level3/core/external_foo.ent:

Added property svn:mime-type and removed property svn:eol-style (to align with documentgetxmlencoding03.xhtml).

11:37 AM Changeset in webkit [233775] by timothy@apple.com

• 2 edits in trunk/Tools

Make WebKit.LinkColorWithSystemAppearance work across system versions.
​https://bugs.webkit.org/show_bug.cgi?id=187573

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:

(TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.

11:35 AM Changeset in webkit [233774] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

Revert: iOS port should define HAVE_RUNLOOP_TIMER
<​https://webkit.org/b/187370>

• wtf/Platform.h: This is only needed on macOS when using

-[WebView scheduleInRunLoop:forMode:] and
-[WebView unscheduleFromRunLoop:forMode:] to make WK1 WebViews
load synchronously using -loadHTMLString: or -loadData:.

11:27 AM Changeset in webkit [233773] by msaboff@apple.com

• 6 edits
  1 add in trunk/Source/bmalloc

Disable IsoHeaps when Gigacage is off
​https://bugs.webkit.org/show_bug.cgi?id=187160

Reviewed by Saam Barati.

Relanding change sets 233547 and 233550 with the added fix that Gigacage is also
enabled for DumpRenderTree.

Updated determineMallocFallbackState to base enabling of Iso Heaps on Gigacage
being enabled. We do this because if Gigacage is disabled, it may be due to lack
of address space.

To work around a compiler issue uncovered by the change above, I added explicit
instantiation of PerThread's static variables. Defined the same explicit
instantiated static variables with export scope in the new file PerThread.cpp
to eliminate separate variables allocations in each linked framework / library.

• CMakeLists.txt:
• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::determineMallocFallbackState):

• bmalloc/PerThread.cpp: Added.
• bmalloc/PerThread.h:
• bmalloc/ProcessCheck.mm:

(bmalloc::gigacageEnabledForProcess):

10:39 AM Changeset in webkit [233772] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Need to handle CodeBlock::replacement() being null.
​https://bugs.webkit.org/show_bug.cgi?id=187569
<rdar://problem/41468692>

Reviewed by Saam Barati.

CodeBlock::replacement() may return a nullptr. Some of our code already checks
for this while others do not. We should add null checks in all the places that
need it.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::numberOfDFGCompiles):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):

• dfg/DFGOperations.cpp:
• dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

• jit/JITOperations.cpp:

10:03 AM Changeset in webkit [233771] by jer.noble@apple.com

• 9 edits in trunk/Source/WebKit

REGRESSION (r230163): Videos cannot be seen full screen in Complete Anatomy app
​https://bugs.webkit.org/show_bug.cgi?id=187527
<rdar://problem/40511527>

Reviewed by Ryosuke Niwa.

Do not enable element fullscreen mode unless apps specifically opt-in. The Fullscreen API is
an experimental feature on iOS, but not on Mac, but we can't simply not return the ExperimentalFeature
object from the list of experimental features, as this keeps Safari from being able to apply a
NSUserDefault value for that feature. Instead, add a property to API::ExperimentalFeature and
_WKExperimentalFeature called "hidden", which signals to clients whether to display the feature
in their UI.

• Scripts/GeneratePreferences.rb:
• Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:
• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.h:
• UIProcess/API/APIExperimentalFeature.cpp:

(API::ExperimentalFeature::create):
(API::ExperimentalFeature::ExperimentalFeature):

• UIProcess/API/APIExperimentalFeature.h:
• UIProcess/API/Cocoa/_WKExperimentalFeature.h:
• UIProcess/API/Cocoa/_WKExperimentalFeature.mm:

(-[_WKExperimentalFeature isHidden]):

10:00 AM Changeset in webkit [233770] by ap@apple.com

• 2 edits in trunk/Source/WebKit

[Mac] Run Unlock Keychain more reliably
​https://bugs.webkit.org/show_bug.cgi?id=187604

Reviewed by Dan Bernstein.

Move unlocking to a separate target, and make it a dependency for all targets that
produce binaries.

This is more than strictly required to fix the build, but this way, we won't need
to remember about keychain when project structure changes. Another consideration that
wasn't initially apparent to me is that is should be possible to build any target,
not just "All", so projects aren't necessarily built in the same order even now.

• WebKit.xcodeproj/project.pbxproj:

9:02 AM Changeset in webkit [233769] by pvollan@apple.com

• 17 edits in trunk/Source

Add compile guard for enabling NSRunLoop in the WebContent process.
​https://bugs.webkit.org/show_bug.cgi?id=187563

Reviewed by Chris Dumez.

Source/WebCore:

No new tests, no change in behavior.

• platform/mac/EventLoopMac.mm:

(WebCore::EventLoop::cycle):

Source/WebKit:

Also, replace MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) where appropriate.

• Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForExternalHostingProcess):

• Shared/ChildProcess.h:
• Shared/mac/ChildProcessMac.mm:
• Shared/mac/HangDetectionDisablerMac.mm:

(WebKit::setClientsMayIgnoreEvents):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::shouldLeakBoost):

• UIProcess/WebProcessPool.h:
• WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::stopRunLoop):

Source/WTF:

• wtf/FeatureDefines.h:

8:02 AM WebKitGTK/Gardening/Calendar/2018Logs edited by magomez@igalia.com

(diff)

7:35 AM Changeset in webkit [233768] by magomez@igalia.com

• 3 edits in trunk/LayoutTests

Unreviewed GTK+ and WPE gardening after r233765.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

7:23 AM Changeset in webkit [233767] by Alan Bujtas

• 3 edits
  2 adds in trunk

Newly added float should trigger full layout on the block.
​https://bugs.webkit.org/show_bug.cgi?id=187251
<rdar://problem/41726137>

Reviewed by David Kilzer.

Source/WebCore:

RenderBlockFlow::determineStartPosition() is one of the places where we decide the extent of the line layout for the current block.
In here we try to figure out the first line in the block that requires layout. In certain cases when floats are present,
(due to their intrusive behavior) we just trigger a full layout on the entire block.
One of the special cases is when a new float is added to the block. determineStartPosition() checks for such floats (floats inserted
after the "last known float") and marks the block for full layout. However it missed the case when other, unrelated mutations happened
in addition to this newly inserted float. This patch fixes this case by checking if the floats after the "last know float" actually need layout.

Test: fast/inline/new-float-needs-layout-when-line-is-dirty.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::determineStartPosition):

LayoutTests:

• fast/inline/new-float-needs-layout-when-line-is-dirty-expected.txt: Added.
• fast/inline/new-float-needs-layout-when-line-is-dirty.html: Added.

6:19 AM Changeset in webkit [233766] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Add pads to the GstFlowCombiner in MediaStreamSrc
​https://bugs.webkit.org/show_bug.cgi?id=187552

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-07-12
Reviewed by Alejandro G. Castro.

This was overlooked and it is the way the API is supposed to be used.

• platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(WebCore::webkitMediaStreamSrcAddPad):

1:43 AM Changeset in webkit [233765] by Yusuke Suzuki

• 43 edits in trunk/Source

[JSC] Thread VM& to JSCell::methodTable(VM&)
​https://bugs.webkit.org/show_bug.cgi?id=187548

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch threads VM& to methodTable(VM&) and remove methodTable().
We add VM& parameter to estimatedSize() to thread VM& in estimatedSize implementations.

• API/APICast.h:

(toJS):

• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::className):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::estimatedSize):

• bytecode/CodeBlock.h:
• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::estimatedSize):

• bytecode/UnlinkedCodeBlock.h:
• debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::className):

• debugger/DebuggerScope.h:
• heap/Heap.cpp:

(JSC::GatherHeapSnapshotData::GatherHeapSnapshotData):
(JSC::GatherHeapSnapshotData::operator() const):
(JSC::Heap::gatherExtraHeapSnapshotData):

• heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

• runtime/ClassInfo.h:
• runtime/DirectArguments.cpp:

(JSC::DirectArguments::estimatedSize):

• runtime/DirectArguments.h:
• runtime/HashMapImpl.cpp:

(JSC::HashMapImpl<HashMapBucket>::estimatedSize):

• runtime/HashMapImpl.h:
• runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::estimatedSize):

• runtime/JSArrayBuffer.h:
• runtime/JSBigInt.cpp:

(JSC::JSBigInt::estimatedSize):

• runtime/JSBigInt.h:
• runtime/JSCell.cpp:

(JSC::JSCell::dump const):
(JSC::JSCell::estimatedSizeInBytes const):
(JSC::JSCell::estimatedSize):
(JSC::JSCell::className):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:
• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::estimatedSize):

• runtime/JSObject.cpp:

(JSC::JSObject::estimatedSize):
(JSC::JSObject::className):
(JSC::JSObject::toStringName):
(JSC::JSObject::calculatedClassName):

• runtime/JSObject.h:
• runtime/JSProxy.cpp:

(JSC::JSProxy::className):

• runtime/JSProxy.h:
• runtime/JSString.cpp:

(JSC::JSString::estimatedSize):

• runtime/JSString.h:
• runtime/RegExp.cpp:

(JSC::RegExp::estimatedSize):

• runtime/RegExp.h:
• runtime/WeakMapImpl.cpp:

(JSC::WeakMapImpl<WeakMapBucket>::estimatedSize):

• runtime/WeakMapImpl.h:

Source/WebCore:

• bindings/js/JSDOMConstructorBase.h:

(WebCore::JSDOMConstructorBase::className):

• bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginElementCustomGetCallData):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceName::estimatedSize):

• bindings/scripts/test/JS/JSInterfaceName.h:

1:40 AM Changeset in webkit [233764] by yousuke.kimoto@sony.com

• 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, add myself as a WebKit committer.

• Scripts/webkitpy/common/config/contributors.json:

Jul 11, 2018:

10:56 PM Changeset in webkit [233763] by Carlos Garcia Campos

• 9 edits in trunk

[WPE] Pass the backend library name as command line parameter to the web process
​https://bugs.webkit.org/show_bug.cgi?id=186841

Reviewed by Žan Doberšek.

Source/WebKit:

• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess): Add --backend-library parameter when launching the web process.

• WebProcess/wpe/WebProcessMainWPE.cpp: Call wpe_loader_init() with the library passed as --backend-library parameter.

Tools:

• MiniBrowser/wpe/main.cpp:

(main): Stop using WPE_BACKEND_LIBRARY env var.

• Scripts/run-wpe-tests:

(WPETestRunner.init): Ditto.

• Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server): Ditto.

• wpe/backends/ViewBackend.cpp:

(WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.

• wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.

10:40 PM Changeset in webkit [233762] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r233714.
​https://bugs.webkit.org/show_bug.cgi?id=187579

it made tests time out (Requested by pizlo on #webkit).

Reverted changeset:

"Change the reoptimization backoff base to 1.3 from 2"
​https://bugs.webkit.org/show_bug.cgi?id=187540
​https://trac.webkit.org/changeset/233714

10:27 PM Changeset in webkit [233761] by youenn@apple.com

• 3 edits
  2 adds in trunk

MediaDevices should derive from EventTarget in its IDL
​https://bugs.webkit.org/show_bug.cgi?id=187575

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/mediastream/MediaDevices-addEventListener.html

• Modules/mediastream/MediaDevices.idl:

LayoutTests:

• fast/mediastream/MediaDevices-addEventListener-expected.txt: Added.
• fast/mediastream/MediaDevices-addEventListener.html: Added.

10:18 PM Changeset in webkit [233760] by Carlos Garcia Campos

• 10 edits in trunk

[GLIB] Add API to allow creating variadic functions
​https://bugs.webkit.org/show_bug.cgi?id=187517

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

Add a _variadic alternate method for jsc_class_add_constructor, jsc_class_add_method and
jsc_value_new_function. In that case the callback always receives a GPtrArray of JSCValue.

• API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::create): Make the parameters optional.
(JSC::JSCCallbackFunction::JSCCallbackFunction): Ditto.
(JSC::JSCCallbackFunction::call): Handle the case of parameters being nullopt by creating a GPtrArray of
JSCValue for the arguments.
(JSC::JSCCallbackFunction::construct): Ditto.

• API/glib/JSCCallbackFunction.h:
• API/glib/JSCClass.cpp:

(jscClassCreateConstructor): Make the parameters optional.
(jsc_class_add_constructor_variadic): Pass nullopt as parameters to jscClassCreateConstructor.
(jscClassAddMethod): Make the parameters optional.
(jsc_class_add_method_variadic): Pass nullopt as parameters to jscClassAddMethod.

• API/glib/JSCClass.h:
• API/glib/JSCValue.cpp:

(jsc_value_object_define_property_accessor): Update now that parameters are optional.
(jscValueFunctionCreate): Make the parameters optional.
(jsc_value_new_function_variadic): Pass nullopt as parameters to jscValueFunctionCreate.

• API/glib/JSCValue.h:
• API/glib/docs/jsc-glib-4.0-sections.txt:

Tools:

Add test cases.

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCFunction):
(fooCreateWithFooV):
(multiplyFooV):

10:13 PM Changeset in webkit [233759] by Carlos Garcia Campos

• 6 edits in trunk

[GLIB] Add jsc_context_get_global_object() to GLib API
​https://bugs.webkit.org/show_bug.cgi?id=187515

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

This wasn't exposed because we have convenient methods in JSCContext to get and set properties on the global
object. However, getting the global object could be useful in some cases, for example to give it a well known
name like 'window' in browsers and GJS.

• API/glib/JSCContext.cpp:

(jsc_context_get_global_object):

• API/glib/JSCContext.h:
• API/glib/docs/jsc-glib-4.0-sections.txt:

Tools:

Add test cases.

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCGlobalObject):
(main):

10:11 PM Changeset in webkit [233758] by Carlos Garcia Campos

• 7 edits in trunk

[GLIB] Handle G_TYPE_STRV in glib API
​https://bugs.webkit.org/show_bug.cgi?id=187512

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

Add jsc_value_new_array_from_strv() and handle G_TYPE_STRV types in function parameters.

• API/glib/JSCContext.cpp:

(jscContextGValueToJSValue):
(jscContextJSValueToGValue):

• API/glib/JSCValue.cpp:

(jsc_value_new_array_from_strv):

• API/glib/JSCValue.h:
• API/glib/docs/jsc-glib-4.0-sections.txt:

Tools:

Add test cases.

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCTypes):
(joinFunction):
(testJSCFunction):

9:08 PM Changeset in webkit [233757] by aakash_jain@apple.com

• 4 edits in trunk/Tools

[ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
​https://bugs.webkit.org/show_bug.cgi?id=187549

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory.init):

• BuildSlaveSupport/ews-build/steps.py:

(CompileJSCOnlyToT): Build ToT without patch.
(CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
(RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
(ReRunJavaScriptCoreTests): Re-runs JSC tests.
(ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
(ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
(RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
(RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

9:06 PM Changeset in webkit [233756] by jonlee@apple.com

• 4 edits in trunk/Source

Update iOS fullscreen alert text
​https://bugs.webkit.org/show_bug.cgi?id=187576
rdar://problem/42052284

Reviewed by Ryosuke Niwa.

Source/WebCore:

• English.lproj/Localizable.strings:

Source/WebKit:

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _showPhishingAlert]): Update text and string keys.

8:37 PM Changeset in webkit [233755] by commit-queue@webkit.org

• 6 edits in trunk

Unreviewed, rolling out r233742.
​https://bugs.webkit.org/show_bug.cgi?id=187577

Binary incompatible change with respect to Service Worker
registration map (Requested by dydz on #webkit).

Reverted changeset:

"Reduce size of WebCore::URL"
​https://bugs.webkit.org/show_bug.cgi?id=186820
​https://trac.webkit.org/changeset/233742

8:36 PM Changeset in webkit [233754] by rniwa@webkit.org

• 3 edits in trunk/LayoutTests

Layout Test editing/selection/navigation-clears-editor-state.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=187389

Reviewed by Wenson Hsieh.

Use 200 iterations like we did before r233701 and mark it as SLOW.

• TestExpectations:
• editing/selection/navigation-clears-editor-state.html:

7:57 PM Changeset in webkit [233753] by rniwa@webkit.org

• 22 edits
  2 adds in trunk

REGRESSION (231276): Attempting to copy an image fails
​https://bugs.webkit.org/show_bug.cgi?id=187212
Source/WebCore:

<rdar://problem/41540074>

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.

Renamed methods to make it clear that one URL and one title are being passed in.

Test: editing/mac/pasteboard/can-copy-url-without-title.html

• platform/PasteboardStrategy.h:
• platform/PlatformPasteboard.h:
• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::setURL):

• platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setURL):

Source/WebKit:

<rdar://problem/41540074>

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.

r210683 introduced logic to prevent file URLs from being copied to the clipboard
in unexpected cases. In order to achieve this functionality,
checkURLReceivedFromWebProcess was called on all items in the pathnames array
passed into WebPasteboardProxy::setPasteboardPathnamesForType. However, this
method is a misnomer, as the pathnames array always contains exactly one URL and
one title for the URL.

Renamed methods to make it clear that one URL and one title are being passed in
and updated logic to ensure that checkURLReceivedFromWebProcess is only called
on the URL and not the title.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PasteboardURL>::encode):
(IPC::ArgumentCoder<PasteboardURL>::decode):

• Shared/WebCoreArgumentCoders.h:
• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::setPasteboardURL):

• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::setURL):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

<rdar://problem/41540074>

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.

Renamed methods to make it clear that one URL and one title are being passed in.

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::setURL):

Tools:

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.
<rdar://problem/41540074>

Augmented test to include a URL where the lastPathComponent looks similar to a
file URL.

• TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
• TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:

(TestWebKitAPI::TEST):

LayoutTests:

<rdar://problem/41540074>

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-11
Reviewed by Ryosuke Niwa.

Added test to ensure that we can copy a URL without a title, and the URL's
lastPathComponent appears like a file URL.

• editing/mac/pasteboard/can-copy-url-without-title-expected.txt: Added.
• editing/mac/pasteboard/can-copy-url-without-title.html: Added.
• platform/mac-wk1/TestExpectations: The added test is WK2-only due to webkit.org/b/187230.

7:32 PM Changeset in webkit [233752] by commit-queue@webkit.org

• 19 edits
  1 add in trunk

Add SPI for immediate injection of user scripts
​https://bugs.webkit.org/show_bug.cgi?id=173342
<rdar://problem/29202285>

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-07-11
Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.

Source/WebCore:

The new SPI is WKUserContentController._addUserScriptImmediately.
It is covered by new API tests.
Existing functionality remains unchanged unless the new SPI is adopted.

• page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptImmediately):
Move injection functionality to allow us to call it directly from the new SPI.

• page/Frame.h:
• page/Page.cpp:

(WebCore::Page::forEachPage):

• page/Page.h:

Source/WebKit:

• UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserScript):

• UIProcess/API/C/WKUserContentControllerRef.cpp:

(WKUserContentControllerAddUserScript):

• UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController addUserScript:]):
(-[WKUserContentController _addUserScriptImmediately:]):

• UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
• UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addUserScript):

• UIProcess/UserContent/WebUserContentControllerProxy.h:
• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserScripts):
(WebKit::WebUserContentController::addUserScriptInternal):
If we are to inject the script internally, inject it into the appropriate pages.
If we're injecting into the top frame only, there's no need to traverse the frame tree.
(WebKit::WebUserContentController::addUserScript):

• WebProcess/UserContent/WebUserContentController.h:
• WebProcess/UserContent/WebUserContentController.messages.in:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:

(waitForMessage):
(TEST):

7:09 PM Changeset in webkit [233751] by Simon Fraser

• 6 edits in trunk/Source/WebKit

[iOS WK2] Address a possible cause of missing tiles
​https://bugs.webkit.org/show_bug.cgi?id=187570
rdar://problem/40941118

Reviewed by Tim Horton.

If the web process crashes, it's possible for the user to trigger a scroll before
the process is re-launched. The pre-commit handler will bail early on the _isValid
check without clearing _hasScheduledVisibleRectUpdate, so that remains YES and we
get stuck doing no more visible content rect updates.

Fix by adding -[WKWebView _didRelaunchProcess] (WKContentView got this already), and
in that clear state that could have been set in the UI process while the web process
connection was invalid.

Also add more release logging around process termination, crash and relaunch.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processDidExit]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
(-[WKWebView _updateVisibleContentRects]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::processDidTerminate):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didFinishLaunching):

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didRelaunchProcess):

6:35 PM Changeset in webkit [233750] by mmaxfield@apple.com

• 1 edit
  1 delete in trunk/Tools

Move WHLSL spec work to the W3C GPUWeb GitHub repository

See ​https://github.com/gpuweb/WHLSL

• WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
• WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
• WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
• WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
• WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.

5:52 PM Changeset in webkit [233749] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Release logging dumps "Cleaning up dragging state…" every time gesture recognizers are reset in WKContentView
​https://bugs.webkit.org/show_bug.cgi?id=187562

Reviewed by Tim Horton.

Tweaks up a release logging statement, such that it only logs when performing a drag or drop.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpDragSourceSessionState]):

5:44 PM Changeset in webkit [233748] by dino@apple.com

• 2 edits in trunk/Tools

Force WKTR to use the light appearance
​https://bugs.webkit.org/show_bug.cgi?id=187572
<rdar://problem/42097805>

Reviewed by Simon Fraser.

Set the NSAppearance on the NSWindow to light mode.

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.

5:18 PM Changeset in webkit [233747] by Ross Kirsling

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening.

• platform/wincairo/TestExpectations:

5:08 PM Changeset in webkit [233746] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit

Unreviewed, rolling out r233741.
​https://bugs.webkit.org/show_bug.cgi?id=187568

"WKTR vs exp features, booooooo" (Requested by bradee-oh on
#webkit).

Reverted changeset:

"Make process-swap-on-navigation an experimental feature."
​https://bugs.webkit.org/show_bug.cgi?id=187558
​https://trac.webkit.org/changeset/233741

4:30 PM Changeset in webkit [233745] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Layout Test media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=187420

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-11

• platform/mac/TestExpectations:

2:20 PM Changeset in webkit [233744] by bshafiei@apple.com

• 1 copy in tags/Safari-606.1.24.40.2

Tag Safari-606.1.24.40.2.

2:09 PM Changeset in webkit [233743] by Ryan Haddad

• 2 edits in trunk/JSTests

Skip JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js
​https://bugs.webkit.org/show_bug.cgi?id=187559

Unreviewed test gardening.

• stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js:

1:48 PM Changeset in webkit [233742] by commit-queue@webkit.org

• 6 edits in trunk

Reduce size of WebCore::URL
​https://bugs.webkit.org/show_bug.cgi?id=186820

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-07-11
Reviewed by Yusuke Suzuki.

Source/WebCore:

We were using 32 bits for the length of the port, which is always between 0 and 5 inclusive
because port numbers are missing or between 0 and 65535. Let's just use 3 bits here.
We were using 32 bits for the length of the scheme, which is usually 3-5 characters and can be
longer for some custom schemes, but I've never seen one more than 20 characters. If we assume
schemes are always less than 64MB, we can save 8 bytes per URL!

No change in behavior, just less memory use!

• platform/URL.cpp:

(WebCore::URL::invalidate):
(WebCore::URL::lastPathComponent const):
(WebCore::URL::port const):
(WebCore::URL::protocolHostAndPort const):
(WebCore::URL::path const):
(WebCore::URL::removePort):
(WebCore::URL::setPort):
(WebCore::URL::setHostAndPort):
(WebCore::URL::setPath):

• platform/URL.h:

(WebCore::URL::encode const):
(WebCore::URL::decode):
(WebCore::URL::hasPath const):
(WebCore::URL::pathStart const):

• platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):
(WebCore::URLParser::parsePort):
(WebCore::URLParser::parseHostAndPort):
(WebCore::URLParser::allValuesEqual):
(WebCore::URLParser::internalValuesConsistent):

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

1:47 PM Changeset in webkit [233741] by beidson@apple.com

• 4 edits in trunk/Source/WebKit

Make process-swap-on-navigation an experimental feature.
<rdar://problem/41995053> and ​https://bugs.webkit.org/show_bug.cgi?id=187558

Reviewed by Geoff Garen.

• Shared/WebPreferences.yaml:

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::updateBoolValueForExperimentalFeatureKey):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage): If the new web page has PSON enabled via WebPreferences,

absorb that setting into this process pool's configuration.

1:29 PM Changeset in webkit [233740] by Yusuke Suzuki

• 10 edits
  1 add in trunk

Iterator of Array.keys() returns object in wrong order
​https://bugs.webkit.org/show_bug.cgi?id=185197

Reviewed by Keith Miller.

JSTests:

We align the shape of our iterator result to the spec: {value,done} instead of {done,value}.

• stress/iterator-field-order.js: Added.

(shouldBe):
(shouldBe.JSON.stringify.array.values.next):
(shouldBe.JSON.stringify.array.keys.next):
(shouldBe.JSON.stringify.array.entries.next):
(async.asyncIterator):
(iterator.next.then):
(generator):
(shouldBe.JSON.stringify.generator.next):
(shouldBe.JSON.stringify.map.keys.next):
(shouldBe.JSON.stringify.map.values.next):
(shouldBe.JSON.stringify.map.entries.next):
(set new):

Source/JavaScriptCore:

• builtins/ArrayIteratorPrototype.js:

(globalPrivate.arrayIteratorValueNext):
(globalPrivate.arrayIteratorKeyNext):
(globalPrivate.arrayIteratorKeyValueNext):

• builtins/AsyncFromSyncIteratorPrototype.js:
• builtins/AsyncGeneratorPrototype.js:

(globalPrivate.asyncGeneratorResolve):

• builtins/GeneratorPrototype.js:

(globalPrivate.generatorResume):

• builtins/MapIteratorPrototype.js:

(globalPrivate.mapIteratorNext):

• builtins/SetIteratorPrototype.js:

(globalPrivate.setIteratorNext):

• builtins/StringIteratorPrototype.js:

(next):

• runtime/IteratorOperations.cpp:

(JSC::createIteratorResultObjectStructure):
(JSC::createIteratorResultObject):

12:36 PM Changeset in webkit [233739] by youenn@apple.com

• 14 edits
  2 adds
  15 deletes in trunk

Fix remaining Cross-Origin-Resource-Policy failures, if any
​https://bugs.webkit.org/show_bug.cgi?id=186761
<rdar://problem/41209829>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Fixed some tests for correctness.

• web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker-expected.txt:
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any-expected.txt:
• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.js:

(promise_test):

• web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker-expected.txt:
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window-expected.txt: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.html: Added.
• web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.js:
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any-expected.txt:
• web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker-expected.txt:

Source/WebCore:

Add case-sensitive check for CORP header value, as per fetch specification.
Add HTTP->HTTPS check for same-site case, as per fetch specification.
​https://fetch.spec.whatwg.org/#cross-origin-resource-policy-check

Test: imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.html

• loader/CrossOriginAccessControl.cpp:

(WebCore::shouldCrossOriginResourcePolicyCancelLoad):

• platform/network/HTTPParsers.cpp:

(WebCore::parseCrossOriginResourcePolicyHeader):

Tools:

• TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:

(TestWebKitAPI::TEST):

2018-07-11 Aakash Jain <​aakash_jain@apple.com>

[ews-build] EWS should unapply the patch and build ToT when patch fails to build
​https://bugs.webkit.org/show_bug.cgi?id=187358

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-build/factories.py:

(BuildFactory.init):

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
(CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
(CompileWebKitToT): Build ToT without patch.
(CompileWebKitToT.doStepIf): Run this step only if patch failed to build.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.

LayoutTests:

Remove redundant tests with WPT.

• http/wpt/cross-origin-resource-policy/fetch-expected.txt: Removed.
• http/wpt/cross-origin-resource-policy/fetch-in-iframe-expected.txt: Removed.
• http/wpt/cross-origin-resource-policy/fetch-in-iframe.html: Removed.
• http/wpt/cross-origin-resource-policy/fetch.html: Removed.
• http/wpt/cross-origin-resource-policy/iframe-loads-expected.txt: Removed.
• http/wpt/cross-origin-resource-policy/iframe-loads.html: Removed.
• http/wpt/cross-origin-resource-policy/image-loads-expected.txt: Removed.
• http/wpt/cross-origin-resource-policy/image-loads.html: Removed.
• http/wpt/cross-origin-resource-policy/resources/hello.py: Removed.
• http/wpt/cross-origin-resource-policy/resources/iframe.py: Removed.
• http/wpt/cross-origin-resource-policy/resources/iframeFetch.html: Removed.
• http/wpt/cross-origin-resource-policy/resources/redirect.py: Removed.
• http/wpt/cross-origin-resource-policy/resources/script.py: Removed.
• http/wpt/cross-origin-resource-policy/script-loads-expected.txt: Removed.
• http/wpt/cross-origin-resource-policy/script-loads.html: Removed.

12:29 PM Changeset in webkit [233738] by jer.noble@apple.com

• 5 edits in trunk

Disable all network caching for HLS streams.
​https://bugs.webkit.org/show_bug.cgi?id=187544
<rdar://problem/41863600>

Reviewed by Chris Dumez.

Source/WebKit:

Revert the behavior added in r215263 where Media responses are cached if they are from
a resource whose expected content length is <4MB.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeStoreDecision):
(WebKit::NetworkCache::expectedTotalResourceSizeFromContentRange): Deleted.

LayoutTests:

• http/tests/cache/disk-cache/disk-cache-media-small-expected.txt:
• http/tests/cache/disk-cache/disk-cache-media-small.html:

12:22 PM Changeset in webkit [233737] by Ross Kirsling

• 2 edits in trunk/Source/WebCore

[WinCairo] MIME type registry doesn't explicitly recognize *.xht
​https://bugs.webkit.org/show_bug.cgi?id=187555

Reviewed by Konstantin Tokarev.

Follow-up to r233715 -- WinCairo bots are failing on *.xht layout tests as they lack a registry key for this filetype.
(Hopefully this is the last one to add.)

• platform/win/MIMETypeRegistryWin.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
Add *.xht to the list of recognized filetypes.

11:50 AM Changeset in webkit [233736] by Kocsen Chung

• 1 copy in tags/Safari-606.1.25

Tag Safari-606.1.25.

11:34 AM Changeset in webkit [233735] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

11:10 AM Changeset in webkit [233734] by aakash_jain@apple.com

• 4 edits in trunk/Tools

2018-07-11 Aakash Jain <​aakash_jain@apple.com>

[ews-build] EWS should unapply the patch and build ToT when patch fails to build
​https://bugs.webkit.org/show_bug.cgi?id=187358

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-build/factories.py:

(BuildFactory.init):

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
(CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
(CompileWebKitToT): Build ToT without patch.
(CompileWebKitToT.doStepIf): Run this step only if patch failed to build.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.

10:29 AM Changeset in webkit [233733] by rmorisset@apple.com

• 3 edits in trunk/Tools

[WSL] WIP, some work on the spec.

10:13 AM Changeset in webkit [233732] by bshafiei@apple.com

• 7 edits in branches/safari-606.1.24.40-branch/Source

Versioning.

9:40 AM Changeset in webkit [233731] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
​https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>

Unreviewed build fix after r233729 and r233730.

• animation/KeyframeEffectReadOnly.cpp:

(WebCore::processIterableKeyframes):

9:34 AM Changeset in webkit [233730] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
​https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>

Unreviewed build fix after r233729.

• animation/KeyframeEffectReadOnly.cpp:

(WebCore::processIterableKeyframes):

8:54 AM Changeset in webkit [233729] by graouts@webkit.org

• 6 edits in trunk

[Web Animations] Make WPT test at interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html pass reliably
​https://bugs.webkit.org/show_bug.cgi?id=186501
<rdar://problem/41000224>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark 2 new WPT progressions.

• web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:

Source/WebCore:

There were two remaining assertions that we were failing in this WPT test file, both related to processing iterable keyframes.
The first one was failing because didn't correctly propagate the TypeError exception in the forEachInIterable() callback. The
second one was failing because we didn't use the "process a keyframe-like object" procedure when processing iterable keyframes
and, as such, we didn't correctly sort property alphabetically before reading their values.

To fix this second issue, we make processIterableKeyframes() use processKeyframeLikeObject(). To do so, we update processKeyframeLikeObject()
to accept a new boolean flag to match the "allow lists" flag from the specification. We also ensure we sort the properties *before*
reading from them which we didn't use to do previously.

• animation/KeyframeEffectReadOnly.cpp:

(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):

• animation/KeyframeEffectReadOnly.h:
• animation/KeyframeEffectReadOnly.idl:

6:30 AM Changeset in webkit [233728] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

SimpleLineLayout::FlowContents wastes 54KB of Vector capacity on nytimes.com
​https://bugs.webkit.org/show_bug.cgi?id=186709
<rdar://problem/41173793>

Reviewed by Simon Fraser.

The size of the m_segments vector in SimpleLineLayoutFlowContents is alway pre-computed and don't change after the initial append.

Not testable.

• rendering/SimpleLineLayoutFlowContents.h:

3:02 AM Changeset in webkit [233727] by Ms2ger@igalia.com

• 4 edits in trunk

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=187551

Unreviewed gardening.

WebDriverTests:

• TestExpectations.json:
  • imported/selenium/py/test/selenium/webdriver/common: fixed in r233548
  • imported/w3c/webdriver/tests/actions/key.py: fixed in r233499
  • imported/w3c/webdriver/tests/actions/special_keys.py: properly escape test names

LayoutTests:

• platform/gtk/TestExpectations: Mark new test as failing: it depends on mac-only code.

1:18 AM Changeset in webkit [233726] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

[WPE] AC for fixed-position elements is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=187514

Reviewed by Carlos Garcia Campos.

Enable accelerated compositing for fixed-position elements when using
AcceleratedDrawingArea and AC is force-enabled. This effectively enables
this option for the WPE port which is using the AcceleratedDrawingArea
implementation and not DrawingAreaImpl like the GTK+ port.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::updatePreferences):

12:59 AM Changeset in webkit [233725] by chris.reid@sony.com

• 2 edits in trunk/Source/WebKit

[Win][WebKit] Disable accelerated compositing until it is supported
​https://bugs.webkit.org/show_bug.cgi?id=187503

Reviewed by Žan Doberšek.

• UIProcess/win/WebView.cpp:

12:59 AM Changeset in webkit [233724] by Yusuke Suzuki

• 2 edits in trunk/JSTests

Unreviewed, clean up test262 expectations

• test262/expectations.yaml: