Context Navigation

← Previous Period
Next Period →

Timeline

Jul 16, 2018:

10:07 PM Changeset in webkit [233884] by Dewei Zhu

2 edits in trunk/Websites/perf.webkit.org

CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
https://bugs.webkit.org/show_bug.cgi?id=187675

Reviewed by Ryosuke Niwa.

This change will fix the bug that no notification will be sent for any test groups except the
first one in any custom perf-try A/B task.

public/v3/components/custom-configuration-test-group-form.js:

(CustomConfigurationTestGroupForm.prototype.startTesting): Conditionally includes taskName based on
whether or not analysis task is created.

9:44 PM Changeset in webkit [233883] by Megan Gardner

2 edits in trunk/Source/WebCore

Correctly adjust scroll offsets when a page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=187673
<rdar://problem/41712829>

Reviewed by Wenson Hsieh.

Will add test later.

Make sure that distance is scaled by the pageScaleFactor, to
make sure that we scroll correctly when we are zoomed in.

page/ios/EventHandlerIOS.mm:

(WebCore::autoscrollAdjustmentFactorForScreenBoundaries):

9:22 PM Changeset in webkit [233882] by Simon Fraser

61 edits
58 deletes in trunk

Roll out r233873 and r233875 since they caused 8 new layout test crashes.

TestExpectations:
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key-expected.txt: Removed.
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html: Removed.
http/wpt/crypto/aes-cbc-crash.any-expected.txt: Removed.
http/wpt/crypto/aes-cbc-crash.any.html: Removed.
http/wpt/crypto/aes-cbc-crash.any.js: Removed.
http/wpt/crypto/aes-cbc-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/aes-cbc-crash.any.worker.html: Removed.
http/wpt/crypto/aes-ctr-crash.any-expected.txt: Removed.
http/wpt/crypto/aes-ctr-crash.any.html: Removed.
http/wpt/crypto/aes-ctr-crash.any.js: Removed.
http/wpt/crypto/aes-ctr-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/aes-ctr-crash.any.worker.html: Removed.
http/wpt/crypto/aes-gcm-crash.any-expected.txt: Removed.
http/wpt/crypto/aes-gcm-crash.any.html: Removed.
http/wpt/crypto/aes-gcm-crash.any.js: Removed.
http/wpt/crypto/aes-gcm-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/aes-gcm-crash.any.worker.html: Removed.
http/wpt/crypto/derive-hmac-key-crash.any-expected.txt: Removed.
http/wpt/crypto/derive-hmac-key-crash.any.html: Removed.
http/wpt/crypto/derive-hmac-key-crash.any.js: Removed.
http/wpt/crypto/derive-hmac-key-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/derive-hmac-key-crash.any.worker.html: Removed.
http/wpt/crypto/ecdsa-crash.any-expected.txt: Removed.
http/wpt/crypto/ecdsa-crash.any.html: Removed.
http/wpt/crypto/ecdsa-crash.any.js: Removed.
http/wpt/crypto/ecdsa-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/ecdsa-crash.any.worker.html: Removed.
http/wpt/crypto/hkdf-crash.any-expected.txt: Removed.
http/wpt/crypto/hkdf-crash.any.html: Removed.
http/wpt/crypto/hkdf-crash.any.js: Removed.
http/wpt/crypto/hkdf-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/hkdf-crash.any.worker.html: Removed.
http/wpt/crypto/pbkdf2-crash.any-expected.txt: Removed.
http/wpt/crypto/pbkdf2-crash.any.html: Removed.
http/wpt/crypto/pbkdf2-crash.any.js: Removed.
http/wpt/crypto/pbkdf2-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/pbkdf2-crash.any.worker.html: Removed.
http/wpt/crypto/resources/common.js: Removed.
http/wpt/crypto/rsa-oaep-crash.any-expected.txt: Removed.
http/wpt/crypto/rsa-oaep-crash.any.html: Removed.
http/wpt/crypto/rsa-oaep-crash.any.js: Removed.
http/wpt/crypto/rsa-oaep-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/rsa-oaep-crash.any.worker.html: Removed.
http/wpt/crypto/rsa-pss-crash.any-expected.txt: Removed.
http/wpt/crypto/rsa-pss-crash.any.html: Removed.
http/wpt/crypto/rsa-pss-crash.any.js: Removed.
http/wpt/crypto/rsa-pss-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/rsa-pss-crash.any.worker.html: Removed.
http/wpt/crypto/unwrap-ec-key-crash.any-expected.txt: Removed.
http/wpt/crypto/unwrap-ec-key-crash.any.html: Removed.
http/wpt/crypto/unwrap-ec-key-crash.any.js: Removed.
http/wpt/crypto/unwrap-ec-key-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html: Removed.
http/wpt/crypto/unwrap-rsa-key-crash.any-expected.txt: Removed.
http/wpt/crypto/unwrap-rsa-key-crash.any.html: Removed.
http/wpt/crypto/unwrap-rsa-key-crash.any.js: Removed.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker-expected.txt: Removed.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html: Removed.

8:38 PM Changeset in webkit [233881] by rniwa@webkit.org

2 edits in trunk

Update ReadMe.md line 68
https://bugs.webkit.org/show_bug.cgi?id=187533

Reviewed by Wenson Hsieh.

ReadMe.md:

8:33 PM Changeset in webkit [233880] by rniwa@webkit.org

3 edits in trunk/LayoutTests

[ WK2 ] Layout Test editing/selection/update-selection-by-style-change.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187649

Reviewed by Wenson Hsieh.

Force update the selection before ending the test.

editing/selection/update-selection-by-style-change.html:

7:50 PM Changeset in webkit [233879] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API directly
https://bugs.webkit.org/show_bug.cgi?id=187713
<rdar://problem/41759548>

Reviewed by Simon Fraser.

Turn this into a debug assertion in WebKit1 on iOS since JSC API doesn't grab the web thread lock,
which means that Timer can get destroyed without the web thread lock in the main thread.

platform/Timer.cpp:

(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):

7:17 PM Changeset in webkit [233878] by commit-queue@webkit.org

3 edits in trunk/Tools

Fix API Test failures introduced by r233865
https://bugs.webkit.org/show_bug.cgi?id=187720

Unreviewed APITest fix after r233865.

Fullscreen can now only be initiated from a window that is on screen.

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-16

TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:

(TestWebKitAPI::TEST):

7:03 PM Changeset in webkit [233877] by Simon Fraser

20 edits
2 adds in trunk

Add color filter for transforming colors in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=187717
Source/WebCore:

rdar://problem/41146650

Reviewed by Dean Jackson.

Add a new filter function for use in -apple-color-filter for transforming colors
when in Dark Mode. The filter is called apple-invert-lightness(), and takes no parameters.
It's based on a lightness invert in HSL space, with some adjustments to improve the contrast
of some colors on dark backgrounds, so does a much better job that using invert() with hue-rotate().

Test: css3/color-filters/color-filter-apple-invert-lightness.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForFilter):

css/CSSValueKeywords.in:
css/StyleResolver.cpp:

(WebCore::filterOperationForType):
(WebCore::StyleResolver::createFilterOperations):

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeFilterImage):
(WebCore::CSSPropertyParserHelpers::isPixelFilterFunction):
(WebCore::CSSPropertyParserHelpers::isColorFilterFunction):
(WebCore::CSSPropertyParserHelpers::consumeFilterFunction):
(WebCore::CSSPropertyParserHelpers::consumeFilter):
(WebCore::CSSPropertyParserHelpers::isValidPrimitiveFilterFunction): Deleted.

css/parser/CSSPropertyParserHelpers.h:
page/FrameView.cpp:

(WebCore::FrameView::paintContents):

platform/graphics/Color.cpp:
platform/graphics/ColorUtilities.cpp:

(WebCore::sRGBToLinearComponents):
(WebCore::linearToSRGBComponents):
(WebCore::sRGBToLinearColorComponentForLuminance):
(WebCore::luminance):
(WebCore::sRGBToHSL):
(WebCore::calcHue):
(WebCore::HSLToSRGB):
(WebCore::ColorMatrix::ColorMatrix):

platform/graphics/ColorUtilities.h:
platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(PlatformCAFilters::filterValueForOperation):
(PlatformCAFilters::colorMatrixValueForFilter):

platform/graphics/filters/FEColorMatrix.cpp:
platform/graphics/filters/FilterOperation.cpp:

(WebCore::InvertLightnessFilterOperation::operator== const):
(WebCore::InvertLightnessFilterOperation::blend):
(WebCore::InvertLightnessFilterOperation::transformColor const):
(WebCore::operator<<):

platform/graphics/filters/FilterOperation.h:
rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

Source/WebKit:

Reviewed by Dean Jackson.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FilterOperation>::encode):
(IPC::decodeFilterOperation):

LayoutTests:

rdar://problem/41146650

Reviewed by Dean Jackson.

css3/color-filters/color-filter-apple-invert-lightness-expected.html: Added.
css3/color-filters/color-filter-apple-invert-lightness.html: Added.
css3/color-filters/color-filter-parsing-expected.txt:
css3/color-filters/color-filter-parsing.html:

6:10 PM Changeset in webkit [233876] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Black flash in content area when returning to Mail
https://bugs.webkit.org/show_bug.cgi?id=187719
<rdar://problem/42165340>

Reviewed by Wenson Hsieh.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground):
This still reproduces sometimes even after r233723, because:

If a pending commit arrives after ApplicationDidEnterBackground (when we
ask the web content process to freeze the layer tree), and after
ApplicationDidFinishSnapshottingAfterEnteringBackground (when we hide
WKContentView), but before the process sleeps, it will cause WKContentView
to be unhidden (potentially including layers with empty surfaces as contents).
Nothing will re-hide WKContentView. Instead, we should wait for the next
*pending* commit, which will necessarily not come until after the application
returns to the foreground because of the strict IPC ordering between
the message that freezes the layer tree and the "next commit" mechanism.

6:03 PM Changeset in webkit [233875] by jiewen_tan@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, build fix for r233873.

crypto/SubtleCrypto.cpp:

(WebCore::crossThreadCopyImportParams):

5:54 PM Changeset in webkit [233874] by Kocsen Chung

1 copy in tags/Safari-606.1.26

Tag Safari-606.1.26.

5:31 PM Changeset in webkit [233873] by jiewen_tan@apple.com

61 edits
60 adds in trunk

[WebCrypto] Crypto operations should copy their parameters before hoping to another thread
https://bugs.webkit.org/show_bug.cgi?id=187501
<rdar://problem/41438160>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch aims at making all captured variables in all crypto lambdas that need to be passed
to a worker thread thread safe, which includes:
1) changing ref counted objects to thread safe ref counted object.
2) adding isolatedCopy methods to non ref counted classes, so they can be called by CrossThreadCopy().

In addition to above changes, this patch also does the following things:
1) change the name CryptoAlgorithm::dispatchOperation => CryptoAlgorithm::dispatchOperationInWorkQueue
to make it clear that lambdas will be passed to a secondary thread.
2) make CryptoAlgorithmParameters as const parameters for all methods.

Tests: crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html

http/wpt/crypto/aes-cbc-crash.any.html
http/wpt/crypto/aes-cbc-crash.any.worker.html
http/wpt/crypto/aes-ctr-crash.any.html
http/wpt/crypto/aes-ctr-crash.any.worker.html
http/wpt/crypto/aes-gcm-crash.any.html
http/wpt/crypto/aes-gcm-crash.any.worker.html
http/wpt/crypto/derive-hmac-key-crash.any.html
http/wpt/crypto/derive-hmac-key-crash.any.worker.html
http/wpt/crypto/ecdsa-crash.any.html
http/wpt/crypto/ecdsa-crash.any.worker.html
http/wpt/crypto/hkdf-crash.any.html
http/wpt/crypto/hkdf-crash.any.worker.html
http/wpt/crypto/pbkdf2-crash.any.html
http/wpt/crypto/pbkdf2-crash.any.worker.html
http/wpt/crypto/rsa-oaep-crash.any.html
http/wpt/crypto/rsa-oaep-crash.any.worker.html
http/wpt/crypto/rsa-pss-crash.any.html
http/wpt/crypto/rsa-pss-crash.any.worker.html
http/wpt/crypto/unwrap-ec-key-crash.any.html
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html
http/wpt/crypto/unwrap-rsa-key-crash.any.html
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html

crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::importKey):
(WebCore::dispatchAlgorithmOperation):
(WebCore::CryptoAlgorithm::dispatchOperationInWorkQueue):
(WebCore::CryptoAlgorithm::dispatchOperation): Deleted.

crypto/CryptoAlgorithm.h:
crypto/SubtleCrypto.cpp:

(WebCore::crossThreadCopyImportParams):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::importKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.h:
crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):
(WebCore::CryptoAlgorithmAES_CFB::importKey):

crypto/algorithms/CryptoAlgorithmAES_CFB.h:
crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::parametersAreValid):
(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):
(WebCore::CryptoAlgorithmAES_CTR::importKey):

crypto/algorithms/CryptoAlgorithmAES_CTR.h:
crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::importKey):

crypto/algorithms/CryptoAlgorithmAES_GCM.h:
crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::importKey):

crypto/algorithms/CryptoAlgorithmAES_KW.h:
crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):
(WebCore::CryptoAlgorithmECDH::importKey):

crypto/algorithms/CryptoAlgorithmECDH.h:
crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):
(WebCore::CryptoAlgorithmECDSA::importKey):

crypto/algorithms/CryptoAlgorithmECDSA.h:
crypto/algorithms/CryptoAlgorithmHKDF.cpp:

(WebCore::CryptoAlgorithmHKDF::deriveBits):
(WebCore::CryptoAlgorithmHKDF::importKey):

crypto/algorithms/CryptoAlgorithmHKDF.h:
crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::importKey):

crypto/algorithms/CryptoAlgorithmHMAC.h:
crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:

(WebCore::CryptoAlgorithmPBKDF2::deriveBits):
(WebCore::CryptoAlgorithmPBKDF2::importKey):

crypto/algorithms/CryptoAlgorithmPBKDF2.h:
crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):
(WebCore::CryptoAlgorithmRSA_PSS::importKey):

crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

crypto/mac/CryptoAlgorithmHKDFMac.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h:
crypto/parameters/CryptoAlgorithmAesCtrParams.h:
crypto/parameters/CryptoAlgorithmAesGcmParams.h:
crypto/parameters/CryptoAlgorithmEcKeyParams.h:
crypto/parameters/CryptoAlgorithmEcdsaParams.h:
crypto/parameters/CryptoAlgorithmHkdfParams.h:
crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
crypto/parameters/CryptoAlgorithmRsaPssParams.h:

LayoutTests:

crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html is an exception of this series of tests as
it only aims to test the correct behavoir of suggested algorithms. This patch aslo does some test
gardening.

TestExpectations:
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key-expected.txt: Added.
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html: Added.
http/wpt/crypto/aes-cbc-crash.any-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.html: Added.
http/wpt/crypto/aes-cbc-crash.any.js: Added.
http/wpt/crypto/aes-cbc-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.worker.html: Added.
http/wpt/crypto/aes-ctr-crash.any-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.html: Added.
http/wpt/crypto/aes-ctr-crash.any.js: Added.
http/wpt/crypto/aes-ctr-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.worker.html: Added.
http/wpt/crypto/aes-gcm-crash.any-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.html: Added.
http/wpt/crypto/aes-gcm-crash.any.js: Added.
http/wpt/crypto/aes-gcm-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.worker.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any.js: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker.html: Added.
http/wpt/crypto/ecdsa-crash.any-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.html: Added.
http/wpt/crypto/ecdsa-crash.any.js: Added.
http/wpt/crypto/ecdsa-crash.any.worker-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.worker.html: Added.
http/wpt/crypto/hkdf-crash.any-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.html: Added.
http/wpt/crypto/hkdf-crash.any.js: Added.
http/wpt/crypto/hkdf-crash.any.worker-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.worker.html: Added.
http/wpt/crypto/pbkdf2-crash.any-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.html: Added.
http/wpt/crypto/pbkdf2-crash.any.js: Added.
http/wpt/crypto/pbkdf2-crash.any.worker-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.worker.html: Added.
http/wpt/crypto/resources/common.js: Added.
http/wpt/crypto/rsa-oaep-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.html: Added.
http/wpt/crypto/rsa-oaep-crash.any.js: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker.html: Added.
http/wpt/crypto/rsa-pss-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.html: Added.
http/wpt/crypto/rsa-pss-crash.any.js: Added.
http/wpt/crypto/rsa-pss-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.js: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.js: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker-expected.txt: Added.

5:17 PM Changeset in webkit [233872] by commit-queue@webkit.org

28 edits in trunk

Source/WebCore:
[iOS] When bringing MobileSafari to the foreground, images, which are pending decoding, won't be drawn into the flush immediate transaction
https://bugs.webkit.org/show_bug.cgi?id=187375

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-07-16
Reviewed by Simon Fraser.

An immediate-paint transaction should force all the images which are pending
decoding to be repainted.

To do that, FrameView::paintControlTints() will be re-factored to a new
generic function such that it takes PaintInvalidationReasons. The new function
which is named 'traverseForPaintInvalidation' will traverse the render tree
for a specific PaintInvalidationReasons.

invalidateImagesWithAsyncDecodes() will stop the asynchronous decoding for
the underlying image and repaint all the clients which are waiting for the
decoding to finish.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
(WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::imageFrameAvailable):
(WebCore::CachedImage::addPendingImageDrawingClient): Deleted.

loader/cache/CachedImage.h:
page/FrameView.cpp:

(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::traverseForPaintInvalidation):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::paintControlTints): Deleted.

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

platform/Scrollbar.cpp:

(WebCore::Scrollbar::paint):

platform/graphics/BitmapImage.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::performingPaintInvalidation const):
(WebCore::GraphicsContext::invalidatingControlTints const):
(WebCore::GraphicsContext::invalidatingImagesWithAsyncDecodes const):
(WebCore::GraphicsContext::updatingControlTints const): Deleted.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::paintLayer):

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::paint):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

testing/Internals.cpp:

(WebCore::Internals::invalidateControlTints):
(WebCore::Internals::paintControlTints): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:
[iOS] When bringing MobileSafari to the foreground, images, which are pending decoding, won't be drawn into the immediate-paint transaction
https://bugs.webkit.org/show_bug.cgi?id=187375

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-07-16
Reviewed by Simon Fraser.

For immediate-paint transaction, we should force all the images which are
pending decoding to be repainted before building this transaction.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updateControlTints):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

LayoutTests:
[iOS] When bringing MobileSafari to the foreground, images, which are pending decoding, won't be drawn into the immediate-paint transaction
https://bugs.webkit.org/show_bug.cgi?id=187375

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-07-16
Reviewed by Simon Fraser.

The Internals API paintControlTints() is now renamed to invalidateControlTints()
to be consistent with the new enum values and with the new name of the
C++ function.

fast/css/webkit-mask-crash-fieldset-legend.html:
fast/css/webkit-mask-crash-figure.html:
fast/css/webkit-mask-crash-table.html:
fast/css/webkit-mask-crash-td-2.html:
fast/css/webkit-mask-crash-td.html:

4:53 PM Changeset in webkit [233871] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[ MacOS WK1 Debug ] Layout Test svg/custom/linking-uri-01-b.svg is flakey
https://bugs.webkit.org/show_bug.cgi?id=187711

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-16

platform/mac-wk1/TestExpectations:

4:46 PM Changeset in webkit [233870] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the build.

rendering/RenderThemeMac.mm:

4:34 PM Changeset in webkit [233869] by dino@apple.com

39 edits
2 adds in trunk

Allow removal of white backgrounds
https://bugs.webkit.org/show_bug.cgi?id=187574
<rdar://problem/41146792>

Reviewed by Simon Fraser.

Source/WebCore:

Add a drawing mode that turns white backgrounds into transparent
regions, such that a hosting app can see through to its window.

Test: css3/color-filters/punch-out-white-backgrounds.html

page/Settings.yaml: New Setting.

rendering/InlineFlowBox.cpp: Draw with a destination out blend mode

if the background is white and we are punching out backgrounds, which means
that it will erase the destination.
(WebCore::InlineFlowBox::paintBoxDecorations):

rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBackground): Ditto.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Save and restore
the composition mode if necessary.

Source/WebKit:

Add a new WebPreference for punching out white backgrounds.

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPunchOutWhiteBackgroundsInDarkMode):
(WKPreferencesGetPunchOutWhiteBackgroundsInDarkMode):

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _punchOutWhiteBackgroundsInDarkMode]):
(-[WKWebViewConfiguration _setPunchOutWhiteBackgroundsInDarkMode:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Source/WebKitLegacy/mac:

Add a new WebPreference for punching out white backgrounds.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
(-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Add a new menu item for punching out white backgrounds in MiniBrowser.
In WebKitTestRunner, expose the new setting and hook that up to
drawing a background in the WebView.

MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.

MiniBrowser/mac/SettingsController.h: Ditto.
MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
(-[SettingsController punchOutWhiteBackgroundsInDarkMode]):

MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]): Set the new preference.

WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.

(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.

(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and

set its SPI.
(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.

(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

WebKitTestRunner/TestController.cpp: Reset and copy the new preference.

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView): If the option for punching
out the background was set, tell the WebView to not draw its background.

4:11 PM Changeset in webkit [233868] by david_fenton@apple.com

61 edits
3 deletes in trunk

Unreviewed, rolling out r233867.

caused build failures on High Sierra, Sierra and iOS

Reverted changeset:

"[WebCrypto] Crypto operations should copy their parameters
before hoping to another thread"
https://bugs.webkit.org/show_bug.cgi?id=187501
https://trac.webkit.org/changeset/233867

2:58 PM Changeset in webkit [233867] by jiewen_tan@apple.com

61 edits
60 adds in trunk

[WebCrypto] Crypto operations should copy their parameters before hoping to another thread
https://bugs.webkit.org/show_bug.cgi?id=187501
<rdar://problem/41438160>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html

http/wpt/crypto/aes-cbc-crash.any.html
http/wpt/crypto/aes-cbc-crash.any.worker.html
http/wpt/crypto/aes-ctr-crash.any.html
http/wpt/crypto/aes-ctr-crash.any.worker.html
http/wpt/crypto/aes-gcm-crash.any.html
http/wpt/crypto/aes-gcm-crash.any.worker.html
http/wpt/crypto/derive-hmac-key-crash.any.html
http/wpt/crypto/derive-hmac-key-crash.any.worker.html
http/wpt/crypto/ecdsa-crash.any.html
http/wpt/crypto/ecdsa-crash.any.worker.html
http/wpt/crypto/hkdf-crash.any.html
http/wpt/crypto/hkdf-crash.any.worker.html
http/wpt/crypto/pbkdf2-crash.any.html
http/wpt/crypto/pbkdf2-crash.any.worker.html
http/wpt/crypto/rsa-oaep-crash.any.html
http/wpt/crypto/rsa-oaep-crash.any.worker.html
http/wpt/crypto/rsa-pss-crash.any.html
http/wpt/crypto/rsa-pss-crash.any.worker.html
http/wpt/crypto/unwrap-ec-key-crash.any.html
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html
http/wpt/crypto/unwrap-rsa-key-crash.any.html
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html

crypto/CryptoAlgorithm.cpp:

crypto/CryptoAlgorithm.h:
crypto/SubtleCrypto.cpp:

crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::importKey):

crypto/algorithms/CryptoAlgorithmAES_CBC.h:
crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):
(WebCore::CryptoAlgorithmAES_CFB::importKey):

crypto/algorithms/CryptoAlgorithmAES_CFB.h:
crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::parametersAreValid):
(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):
(WebCore::CryptoAlgorithmAES_CTR::importKey):

crypto/algorithms/CryptoAlgorithmAES_CTR.h:
crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::importKey):

crypto/algorithms/CryptoAlgorithmAES_GCM.h:
crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::importKey):

crypto/algorithms/CryptoAlgorithmAES_KW.h:
crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):
(WebCore::CryptoAlgorithmECDH::importKey):

crypto/algorithms/CryptoAlgorithmECDH.h:
crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):
(WebCore::CryptoAlgorithmECDSA::importKey):

crypto/algorithms/CryptoAlgorithmECDSA.h:
crypto/algorithms/CryptoAlgorithmHKDF.cpp:

(WebCore::CryptoAlgorithmHKDF::deriveBits):
(WebCore::CryptoAlgorithmHKDF::importKey):

crypto/algorithms/CryptoAlgorithmHKDF.h:
crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::importKey):

crypto/algorithms/CryptoAlgorithmHMAC.h:
crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:

(WebCore::CryptoAlgorithmPBKDF2::deriveBits):
(WebCore::CryptoAlgorithmPBKDF2::importKey):

crypto/algorithms/CryptoAlgorithmPBKDF2.h:
crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):
(WebCore::CryptoAlgorithmRSA_PSS::importKey):

crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

crypto/mac/CryptoAlgorithmHKDFMac.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h:
crypto/parameters/CryptoAlgorithmAesCtrParams.h:
crypto/parameters/CryptoAlgorithmAesGcmParams.h:
crypto/parameters/CryptoAlgorithmEcKeyParams.h:
crypto/parameters/CryptoAlgorithmEcdsaParams.h:
crypto/parameters/CryptoAlgorithmHkdfParams.h:
crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
crypto/parameters/CryptoAlgorithmRsaPssParams.h:

LayoutTests:

TestExpectations:
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key-expected.txt: Added.
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html: Added.
http/wpt/crypto/aes-cbc-crash.any-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.html: Added.
http/wpt/crypto/aes-cbc-crash.any.js: Added.
http/wpt/crypto/aes-cbc-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.worker.html: Added.
http/wpt/crypto/aes-ctr-crash.any-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.html: Added.
http/wpt/crypto/aes-ctr-crash.any.js: Added.
http/wpt/crypto/aes-ctr-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.worker.html: Added.
http/wpt/crypto/aes-gcm-crash.any-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.html: Added.
http/wpt/crypto/aes-gcm-crash.any.js: Added.
http/wpt/crypto/aes-gcm-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.worker.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any.js: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker.html: Added.
http/wpt/crypto/ecdsa-crash.any-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.html: Added.
http/wpt/crypto/ecdsa-crash.any.js: Added.
http/wpt/crypto/ecdsa-crash.any.worker-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.worker.html: Added.
http/wpt/crypto/hkdf-crash.any-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.html: Added.
http/wpt/crypto/hkdf-crash.any.js: Added.
http/wpt/crypto/hkdf-crash.any.worker-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.worker.html: Added.
http/wpt/crypto/pbkdf2-crash.any-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.html: Added.
http/wpt/crypto/pbkdf2-crash.any.js: Added.
http/wpt/crypto/pbkdf2-crash.any.worker-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.worker.html: Added.
http/wpt/crypto/resources/common.js: Added.
http/wpt/crypto/rsa-oaep-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.html: Added.
http/wpt/crypto/rsa-oaep-crash.any.js: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker.html: Added.
http/wpt/crypto/rsa-pss-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.html: Added.
http/wpt/crypto/rsa-pss-crash.any.js: Added.
http/wpt/crypto/rsa-pss-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.js: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.js: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker-expected.txt: Added.

2:15 PM Changeset in webkit [233866] by commit-queue@webkit.org

25 edits
3 copies
5 adds in trunk

[Datalist][macOS] Add suggestions UI for TextFieldInputTypes
https://bugs.webkit.org/show_bug.cgi?id=186531

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-16
Reviewed by Tim Horton.

Source/WebCore:

Tests: fast/forms/datalist/datalist-show-hide.html

fast/forms/datalist/datalist-textinput-keydown.html

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): The suggestions view takes precedence when handling arrow key events.

Source/WebKit:

Created WebDataListSuggestionsDropdownMac as a wrapper around the suggestions
view. The suggestions for TextFieldInputTypes are displayed using an NSTableView
in it's own child window. This is done so that suggestions can be presented
outside of the page if the parent window's size is too small. The maximum number
of suggestions that are visible at one time is 6, with additional suggestions made
available by scrolling.

Suggestions in the view can be selected via click or by using arrow keys. If the
input element associated with the suggestions is blurred, or the page is moved in
any way, the suggestions view is hidden.

Added IPC messages to the UIProcess to enable the display of the suggestions view.
This required a new ArgumentCoder for DataListSuggestionInformation.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DataListSuggestionInformation>::encode):
(IPC::ArgumentCoder<DataListSuggestionInformation>::decode):

Shared/WebCoreArgumentCoders.h:
UIProcess/PageClient.h:
UIProcess/WebDataListSuggestionsDropdown.cpp: Copied from Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h.

(WebKit::WebDataListSuggestionsDropdown::WebDataListSuggestionsDropdown):
(WebKit::WebDataListSuggestionsDropdown::~WebDataListSuggestionsDropdown):
(WebKit::WebDataListSuggestionsDropdown::close):

UIProcess/WebDataListSuggestionsDropdown.h: Copied from Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h.

(WebKit::WebDataListSuggestionsDropdown::Client::~Client):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::pageDidScroll):
(WebKit::WebPageProxy::showDataListSuggestions):
(WebKit::WebPageProxy::handleKeydownInDataList):
(WebKit::WebPageProxy::endDataListSuggestions):
(WebKit::WebPageProxy::didCloseSuggestions):
(WebKit::WebPageProxy::didSelectOption):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::closeOverlayedViews):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDataListSuggestionsDropdown):

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::createDataListSuggestionsDropdown):

UIProcess/mac/WebDataListSuggestionsDropdownMac.h: Copied from Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h.
UIProcess/mac/WebDataListSuggestionsDropdownMac.mm: Added.

(WebKit::WebDataListSuggestionsDropdownMac::create):
(WebKit::WebDataListSuggestionsDropdownMac::~WebDataListSuggestionsDropdownMac):
(WebKit::WebDataListSuggestionsDropdownMac::WebDataListSuggestionsDropdownMac):
(WebKit::WebDataListSuggestionsDropdownMac::show):
(WebKit::WebDataListSuggestionsDropdownMac::didSelectOption):
(WebKit::WebDataListSuggestionsDropdownMac::selectOption):
(WebKit::WebDataListSuggestionsDropdownMac::handleKeydownWithIdentifier):
(WebKit::WebDataListSuggestionsDropdownMac::close):
(-[WKDataListSuggestionCell initWithFrame:]):
(-[WKDataListSuggestionCell setText:]):
(-[WKDataListSuggestionCell setActive:]):
(-[WKDataListSuggestionCell drawRect:]):
(-[WKDataListSuggestionCell mouseEntered:]):
(-[WKDataListSuggestionCell mouseExited:]):
(-[WKDataListSuggestionCell acceptsFirstResponder]):
(-[WKDataListSuggestionTable initWithElementRect:]):
(-[WKDataListSuggestionTable setVisibleRect:]):
(-[WKDataListSuggestionTable currentActiveRow]):
(-[WKDataListSuggestionTable setActiveRow:]):
(-[WKDataListSuggestionTable reload]):
(-[WKDataListSuggestionTable acceptsFirstResponder]):
(-[WKDataListSuggestionTable enclosingScrollView]):
(-[WKDataListSuggestionTable removeFromSuperviewWithoutNeedingDisplay]):
(-[WKDataListSuggestionsView initWithInformation:inView:]):
(-[WKDataListSuggestionsView currentSelectedString]):
(-[WKDataListSuggestionsView updateWithInformation:]):
(-[WKDataListSuggestionsView moveSelectionByDirection:]):
(-[WKDataListSuggestionsView invalidate]):
(-[WKDataListSuggestionsView dropdownRectForElementRect:]):
(-[WKDataListSuggestionsView showSuggestionsDropdown:]):
(-[WKDataListSuggestionsView selectedRow:]):
(-[WKDataListSuggestionsView numberOfRowsInTableView:]):
(-[WKDataListSuggestionsView tableView:heightOfRow:]):
(-[WKDataListSuggestionsView tableView:viewForTableColumn:row:]):

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebDataListSuggestionPicker.cpp:

(WebKit::WebDataListSuggestionPicker::handleKeydownWithIdentifier):
(WebKit::WebDataListSuggestionPicker::didSelectOption):
(WebKit::WebDataListSuggestionPicker::didCloseSuggestions):
(WebKit::WebDataListSuggestionPicker::close):
(WebKit::WebDataListSuggestionPicker::displayWithActivationType):

WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h:

Tools:

Added isShowingDatalistSuggestions testing hook in order to enable testing of the
visibility of the suggestions view.

DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::isShowingDataListSuggestions const):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::isShowingDataListSuggestions const):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::isShowingDataListSuggestions const):

LayoutTests:

Added tests to verify that the suggestions are correctly shown and hidden, and that
suggestions can be selected and inserted into an input field.

fast/forms/datalist/datalist-show-hide-expected.txt: Added.
fast/forms/datalist/datalist-show-hide.html: Added.
fast/forms/datalist/datalist-textinput-keydown-expected.txt: Added.
fast/forms/datalist/datalist-textinput-keydown.html: Added.
platform/ios/TestExpectations:
resources/ui-helper.js:

(window.UIHelper.isShowingDataListSuggestions):

1:39 PM Changeset in webkit [233865] by commit-queue@webkit.org

14 edits
2 adds in trunk

Fullscreen requires active document.
https://bugs.webkit.org/show_bug.cgi?id=186226
rdar://problem/36187413

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-16
Reviewed by Jer Noble.

Source/WebCore:

Test: media/no-fullscreen-when-hidden.html

This change guarantees the document to be visible for both element fullscreen and video fullscreen.

User gesture is not enough to guarantee that the document is visible when fullscreen is initiated
because JavaScript can spin wait before initiating fullscreen. During that spin the page or window might
be hidden.

Document::hidden() can't be relied upon because it won't update while JavaScript spins.

This change adds a sync call to the UI process to get the current UI visibility state.

dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreen):

page/ChromeClient.h:

Source/WebKit:

This change guarantees the document to be visible for both element fullscreen and video fullscreen.

Document::hidden() can't be relied upon because it won't update while JavaScript spins.

This change adds a sync call to the UI process to get the current UI visibility state.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getIsViewVisible):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::isViewVisible):

WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

This change guarantees the document to be visible for both element fullscreen and video fullscreen.

Document::hidden() can't be relied upon because it won't update while JavaScript spins.

This change adds a sync call to the UI process to get the current UI visibility state.

media/no-fullscreen-when-hidden.html: Added.
media/video-test.js:

(eventName.string_appeared_here.thunk):
(runWithKeyDown):

platform/ios-wk1/TestExpectations:
platform/mac-wk1/TestExpectations:

1:32 PM Changeset in webkit [233864] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

REGRESSION (r233502): Camera in <input type=file> becomes unresponsive after attempting to dismiss it
https://bugs.webkit.org/show_bug.cgi?id=187706
<rdar://problem/42137088>

Reviewed by Wenson Hsieh.

UIProcess/ios/forms/WKFileUploadPanel.mm:

Remove an unused member.

(-[WKFileUploadPanel _dismissDisplayAnimated:]):
Allow us to dismiss the camera view controller in addition to the menu.

1:23 PM Changeset in webkit [233863] by commit-queue@webkit.org

7 edits in trunk/Source

Reduce size of NetworkLoadMetrics and therefore ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=187671

Patch by Alex Christensen <achristensen@webkit.org> on 2018-07-16
Reviewed by Darin Adler.

Source/WebCore:

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::toProtocol):
(WebCore::InspectorNetworkAgent::buildObjectForMetrics):

platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::reset):
(WebCore::NetworkLoadMetrics::clearNonTimingData):

Source/WebKit:

Shared/WebCoreArgumentCoders.h:

1:10 PM Changeset in webkit [233862] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
https://bugs.webkit.org/show_bug.cgi?id=187709

Reviewed by Mark Lam.

UnlinkedCodeBlock::shrinkToFit accidentally misses m_constantIdentifierSets shrinking.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::shrinkToFit):

1:06 PM Changeset in webkit [233861] by Matt Baker

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix execution highlighting after r233820
https://bugs.webkit.org/show_bug.cgi?id=187703
<rdar://problem/42246167>

Reviewed by Joseph Pecoraro.

UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):

UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.currentPositionToOriginalPosition):
(WI.TextEditor.prototype._updateExecutionRangeHighlight):

12:49 PM Changeset in webkit [233860] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[JSC] Make SourceParseMode small
https://bugs.webkit.org/show_bug.cgi?id=187705

Reviewed by Mark Lam.

Each SourceParseMode is distinct. So we do not need to make it a set-style (power of 2 style).
Originally, this is done to make SourceParseModeSet faster because it is critical in our parser.
But we can keep SourceParseModeSet fast by 1U << mode | set. And we can make SourceParseMode
within 5 bits. This reduces the size of UnlinkedCodeBlock from 288 to 280.

parser/ParserModes.h:

(JSC::SourceParseModeSet::SourceParseModeSet):
(JSC::SourceParseModeSet::contains):
(JSC::SourceParseModeSet::mergeSourceParseModes):

12:09 PM Changeset in webkit [233859] by Kocsen Chung

1 copy in branches/safari-606-branch

New Branch.

11:57 AM Changeset in webkit [233858] by commit-queue@webkit.org

4 edits
16 adds in trunk

AX: Audit Tab should have an Audit Manager
https://bugs.webkit.org/show_bug.cgi?id=184071
<rdar://problem/38946364>

Patch by Aaron Chu <aaron_chu@apple.com> on 2018-07-16
Reviewed by Brian Burg.

Source/WebInspectorUI:

This implements the AuditManager for the audit feature. This patch revolves
around building out an AuditManager that facilitates an audit. The AuditManager
is responsible for managing and storing AuditReports and AuditTestSuites. It is
also tasked to decide how to run a test -- whether as a test case or as a test
suite. This patch also includes 4 models with which the AuditManager works to
perform an audit and to generate a report. These models include AuditTestCase,
which as a collection is stored inside an AuditTestSuite; and AuditResult,
which, as a collection is stored inside an AuditReport.

UserInterface/Controllers/AuditManager.js: Added.

(WI.AuditManager):
(WI.AuditManager.prototype.get testSuites):
(WI.AuditManager.prototype.get reports):
(WI.AuditManager.prototype.async.runAuditTestByRepresentedObject):
(WI.AuditManager.prototype.reportForId):
(WI.AuditManager.prototype.removeAllReports):
(WI.AuditManager.prototype.async._runTestCase):

UserInterface/Main.html:
UserInterface/Models/AuditReport.js: Added.

(WI.AuditReport):
(WI.AuditReport.prototype.get representedTestCases):
(WI.AuditReport.prototype.get representedTestSuite):
(WI.AuditReport.prototype.get resultsData):
(WI.AuditReport.prototype.get isWritable):
(WI.AuditReport.prototype.get failedCount):
(WI.AuditReport.prototype.addResult):
(WI.AuditReport.prototype.close):

UserInterface/Models/AuditResult.js: Added.

(WI.AuditResult):
(WI.AuditResult.prototype.get testResult):
(WI.AuditResult.prototype.get name):
(WI.AuditResult.prototype.get logLevel):
(WI.AuditResult.prototype.get failed):

UserInterface/Models/AuditTestCase.js: Added.

(WI.AuditTestCase.prototype.get id):
(WI.AuditTestCase.prototype.get name):
(WI.AuditTestCase.prototype.get suite):
(WI.AuditTestCase.prototype.get test):
(WI.AuditTestCase.prototype.get setup):
(WI.AuditTestCase.prototype.get tearDown):
(WI.AuditTestCase.prototype.get errorDetails):
(WI.AuditTestCase):

UserInterface/Models/AuditTestSuite.js: Added.

(WI.AuditTestSuite):
(WI.AuditTestSuite.testCaseDescriptors):
(WI.AuditTestSuite.prototype.get id):
(WI.AuditTestSuite.prototype.get name):
(WI.AuditTestSuite.prototype.get testCases):
(WI.AuditTestSuite.prototype._buildTestCasesFromDescriptors):

UserInterface/Test.html:

LayoutTests:

Test cases for AuditManager, AuditTestCase, AuditTestSuite, AuditResult and AuditReport.

inspector/audit/audit-manager-expected.txt: Added.
inspector/audit/audit-manager.html: Added.
inspector/audit/audit-report-expected.txt: Added.
inspector/audit/audit-report.html: Added.
inspector/audit/audit-test-case-expected.txt: Added.
inspector/audit/audit-test-case.html: Added.
inspector/audit/audit-test-suite-expected.txt: Added.
inspector/audit/audit-test-suite.html: Added.
inspector/audit/resources/audit-test-fixtures.js: Added.

(TestPage.registerInitializer.window.testSuiteFixture1):
(TestPage.registerInitializer.window.testSuiteFixture1.testCaseDescriptors):
(TestPage.registerInitializer.window.testSuiteFixture2):
(TestPage.registerInitializer.window.testSuiteFixture2.testCaseDescriptors):
(TestPage.registerInitializer):

11:55 AM Changeset in webkit [233857] by Chris Dumez

3 edits in trunk/Source/WebCore

Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread
https://bugs.webkit.org/show_bug.cgi?id=187702

Reviewed by Youenn Fablet.

Make sure LibWebRTCMediaEndpoint is always constructed and destructed on the main thread since
it has a Timer data member and it would not be safe otherwise. LibWebRTCMediaEndpoint is
ThreadSafeRefCounted and frequently passed to other threads.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

11:52 AM Changeset in webkit [233856] by Yusuke Suzuki

2 edits in trunk/Tools

Add --target-path option to dump-class-layout
https://bugs.webkit.org/show_bug.cgi?id=187687

Reviewed by Simon Fraser.

We add an escape hatch to dump-class-layout for specifying target path directly.
This --target-path allows us to use dump-class-layout in the other ports
like JSCOnly.

We can dump class layout if we build the target with clang by using the following command.

Tools/Scripts/dump-class-layout \

--architecture=x86_64 \
--target-path=path/to/libJavaScriptCore.so \
JavaScriptCore \
ScopeNode

Scripts/dump-class-layout:

(main):

11:49 AM Changeset in webkit [233855] by Yusuke Suzuki

10 edits
3 adds in trunk

[JSC] Generator and AsyncGeneratorMethod's prototype is incorrect
https://bugs.webkit.org/show_bug.cgi?id=187585

Reviewed by Darin Adler.

JSTests:

stress/default-proto-for-async-generator.js: Added.

(shouldBe):
(async.asyncGenerator):

stress/default-proto-for-generator.js: Added.

(shouldBe):
(generator):

stress/prototype-for-async-generator.js: Added.

(shouldBe):
(async.asyncGenerator):
(A.prototype.async.asyncGenerator):
(A):

test262/expectations.yaml:

Source/JavaScriptCore:

This patch fixes Generator and AsyncGenerator's prototype issues.

Generator's default prototype is incorrect when generator.prototype = null is performed.

We fix this by changing JSFunction::prototypeForConstruction.

AsyncGeneratorMethod is not handled. We change the name isAsyncGeneratorFunctionParseMode

to isAsyncGeneratorWrapperParseMode since it is aligned to Generator's code. And use it well
to fix prototype issues for AsyncGeneratorMethod.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPutAsyncGeneratorFields):
(JSC::BytecodeGenerator::emitNewFunction):

bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

parser/Parser.cpp:

(JSC::getAsynFunctionBodyParseMode):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):

parser/ParserModes.h:

(JSC::isAsyncGeneratorParseMode):
(JSC::isAsyncGeneratorWrapperParseMode):
(JSC::isAsyncGeneratorFunctionParseMode): Deleted.

runtime/FunctionExecutable.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::prototypeForConstruction):
(JSC::JSFunction::getOwnPropertySlot):

11:42 AM Changeset in webkit [233854] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

jsc shell's noFTL utility test function should be more robust.
https://bugs.webkit.org/show_bug.cgi?id=187704
<rdar://problem/42231988>

Reviewed by Michael Saboff and Keith Miller.

jsc.cpp:

(functionNoFTL):

only setNeverFTLOptimize() if the function is actually a JS function.

11:35 AM Changeset in webkit [233853] by sihui_liu@apple.com

7 edits in trunk

IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
https://bugs.webkit.org/show_bug.cgi?id=187631
<rdar://problem/42164227>

Reviewed by Brady Eidson.

Source/WebCore:

When asked to delete database for an origin, we deleted the databases whose mainFrameOrigin
is that origin. Given that the origin may create IndexedDB from subframes, we should delete
databases whose openingOrigin is that origin too.

Covered by modified API test: WebKit.WebsiteDataStoreCustomPaths.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):

Source/WebKit:

We need to return all origins, both openingOrigin and mainFrameOrigin, of IndexedDB so users
could be better aware of which origins are using databases and decide what they want to
remove.

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::indexedDatabaseOrigins):

StorageProcess/StorageProcess.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

11:28 AM Changeset in webkit [233852] by Kocsen Chung

7 edits in trunk/Source

Versioning.

10:59 AM Changeset in webkit [233851] by Simon Fraser

29 edits in trunk/Source/WebCore

Shrink some font-related classes and enums
https://bugs.webkit.org/show_bug.cgi?id=187686

Reviewed by Myles Maxfield.

Use enum class for enums in TextFlags.h and make them one byte big.

Re-order members of Font to shrink it from 360 to 328 bytes.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode const):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps const):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode const):

platform/graphics/Font.cpp:

(WebCore::Font::Font):
(WebCore::Font::verticalRightOrientationFont const):

platform/graphics/Font.h:
platform/graphics/FontCascade.cpp:

(WebCore::offsetToMiddleOfGlyph):

platform/graphics/FontCascade.h:

(WebCore::FontCascade::advancedTextRenderingMode const):

platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
(WebCore::FontCascadeFonts::glyphDataForVariant):
(WebCore::glyphPageFromFontRanges):

platform/graphics/FontDescription.cpp:

(WebCore::FontCascadeDescription::FontCascadeDescription):

platform/graphics/FontDescription.h:

(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::setOrientation):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontCascadeDescription::setFontSmoothing):
(WebCore::FontCascadeDescription::initialSmallCaps):
(WebCore::FontCascadeDescription::initialFontSmoothing):
(WebCore::FontCascadeDescription::initialTextRenderingMode):

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::isForTextCombine const):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):

platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::showGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::fontForCombiningCharacterSequence const):

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):
(WebCore::Font::platformBoundsForGlyph const):
(WebCore::Font::platformWidthForGlyph const):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::hash const):
(WebCore::mapFontWidthVariantToCTFeatureSelector):
(WebCore::FontPlatformData::ctFont const):
(WebCore::FontPlatformData::description const):

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::buildScaledFont):

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):
(WebCore::Font::platformWidthForGlyph const):

platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::fontFeatures):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::Font::getCFStringAttributes const):

platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/win/FontCascadeDirect2D.cpp:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/win/GlyphPageTreeNodeDirect2D.cpp:

(WebCore::GlyphPage::fill):

platform/graphics/win/SimpleFontDataDirect2D.cpp:

(WebCore::Font::platformInit):
(WebCore::Font::platformBoundsForGlyph const):
(WebCore::Font::platformWidthForGlyph const):

platform/text/TextFlags.h:
rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineTextIfNeeded):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

rendering/TextPainter.cpp:

(WebCore::TextPainter::paintTextWithShadows):

rendering/TextPainter.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::fontAndGlyphOrientation):

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

10:51 AM Changeset in webkit [233850] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[ iOS ] Layout Test fast/forms/submit-change-fragment.html is a flaky Timeout
https://bugs.webkit.org/show_bug.cgi?id=187699

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-16

platform/ios-simulator-wk2/TestExpectations:

9:54 AM Changeset in webkit [233849] by Ryan Haddad

2 edits in trunk/LayoutTests

[ EWS ] http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html is Crashing on Win-EWS
https://bugs.webkit.org/show_bug.cgi?id=187700

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-07-16

platform/win/TestExpectations:

9:37 AM Changeset in webkit [233848] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Console filter field buttons should be darker
https://bugs.webkit.org/show_bug.cgi?id=187626
<rdar://problem/42142744>

Reviewed by Brian Burg.

UserInterface/Views/FindBanner.css:

(@media (prefers-dark-interface)):
(.find-banner > button.segmented):
(.find-banner > button.segmented > .glyph):

9:29 AM Changeset in webkit [233847] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: selected item background color is too light
https://bugs.webkit.org/show_bug.cgi?id=187691
<rdar://problem/42225308>

Reviewed by Brian Burg.

UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(:root):
(.tree-outline.dom li.elements-drag-over .selection-area):
(.tree-outline.dom:focus li.selected .selection-area):

7:24 AM Changeset in webkit [233846] by svillar@igalia.com

14 edits
2 copies in trunk/Source/WebCore

[WebVR] Add support for connect/disconnect and mount/unmount device events
https://bugs.webkit.org/show_bug.cgi?id=187343

Reviewed by Žan Doberšek.

WebVR specs define a series of events as part of the Window Interface Extension. We're
adding support for the connect/disconnect and mount/unmount events both at the module level
and the platform level using OpenVR.

In order to do that we need to keep lists of VRPlatformDisplays at platform level and
VRDisplays at bindings level. We then update those lists accordingly to detect potential
additions/removals, and emit the corresponding signals. A new client interface
VRPlatformDisplayClient was also defined so that VRPlatformDisplay implementations could
notify their clients (typically a VRDisplay).

Last but not least, NavigatorWebVR was updated so it supplements Navigator instead of
supplementing Page.

Modules/webvr/NavigatorWebVR.cpp: Supplement Navigator not Page.

(WebCore::NavigatorWebVR::getVRDisplays): Keep a list of VRDisplays and update them
conveniently, also emitting the required events under certain conditions (like device
disconnection).
(WebCore::NavigatorWebVR::supplementName): New method.
(WebCore::NavigatorWebVR::from): Ditto.

Modules/webvr/NavigatorWebVR.h: Supplement Navigator not Page.
Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::create): Moved suspendIfNeeded() to constructor.
(WebCore::VRDisplay::VRDisplay): Set itself as VRPlatformDisplay client.
(WebCore::VRDisplay::~VRDisplay): Unset as VRPlatformDisplay client.
(WebCore::VRDisplay::VRPlatformDisplayConnected): Dispatch event on DOM window.
(WebCore::VRDisplay::VRPlatformDisplayDisconnected): Ditto.
(WebCore::VRDisplay::VRPlatformDisplayMounted): Ditto.
(WebCore::VRDisplay::VRPlatformDisplayUnmounted): Ditto.

Modules/webvr/VRDisplay.h: Extend from VRPlatformDisplayClient.

(WebCore::VRDisplay::document):

Modules/webvr/VRDisplayEvent.cpp: Updated Copyright.
Modules/webvr/VRDisplayEvent.h: Ditto.
Sources.txt: Added the two new files.
WebCore.xcodeproj/project.pbxproj: Ditto.
platform/vr/VRManager.cpp:

(WebCore::VRManager::getVRDisplays): Keep a list of VRPlatformDisplays and update them conveniently,
also emitting the required events under certain conditions (like device disconnection).

platform/vr/VRManager.h:
platform/vr/VRPlatformDisplay.cpp: New file with common implementations for VRPlatformDisplays.

(WebCore::VRPlatformDisplay::setClient):
(WebCore::VRPlatformDisplay::notifyVRPlatformDisplayEvent):

platform/vr/VRPlatformDisplay.h: Added a generic method to notify about different

events. Added the client pointer.

platform/vr/VRPlatformDisplayClient.h: New file. VRPlatformDisplay implementations will

call the client methods in the event of some circumstances happening.
(WebCore::VRPlatformDisplayClient::VRPlatformDisplayConnected):
(WebCore::VRPlatformDisplayClient::VRPlatformDisplayDisconnected):
(WebCore::VRPlatformDisplayClient::VRPlatformDisplayMounted):
(WebCore::VRPlatformDisplayClient::VRPlatformDisplayUnmounted):

platform/vr/openvr/VRPlatformDisplayOpenVR.cpp:

(WebCore::VRPlatformDisplayOpenVR::updateDisplayInfo): Poll the device for new events to
detect connection/disconnections or device activations/deactivations (HMD
mounted/unmounted).

platform/vr/openvr/VRPlatformDisplayOpenVR.h:

5:24 AM Changeset in webkit [233845] by zandobersek@gmail.com

4 edits
2 adds in trunk/Source/WebCore

[Nicosia] Add Nicosia::PlatformLayer, Nicosia::CompositionLayer classes
https://bugs.webkit.org/show_bug.cgi?id=187693

Reviewed by Carlos Garcia Campos.

Add the Nicosia::PlatformLayer class. This will be the base platform
layer class from which different derivatives will be created, addressing
different use cases. The generic PlatformLayer type alias will point to
this class in the future.

First class deriving from Nicosia::PlatformLayer is
Nicosia::CompositionLayer, purpose of which will be to mirror the state
that's stored in the platform-specific GraphicsLayer derivative. It will
also allow making thread-safe updates to that state.

CoordinatedGraphicsLayer implementation now spawns a CompositionLayer
object and tracks state changes in a separate
CompositionLayer::LayerState::Delta object. During flushing, the changed
state is applied to the layer's pending state before the delta is nulled
out. The updated state isn't used anywhere yet, but future changes will
implement committing this state into the rendering pipeline.

There's bits of state not yet being managed by CompositionLayer, e.g.
debug visuals, filters and animations. These will be addressed later.

The m_solidColor member variable is added to CoordinatedGraphicsLayer in
order to properly store the solid color value. Normally this would be
contained by the parent GraphicsLayer class, but no such member variable
exists there.

platform/TextureMapper.cmake:
platform/graphics/nicosia/NicosiaPlatformLayer.cpp: Added.

(Nicosia::PlatformLayer::PlatformLayer):
(Nicosia::CompositionLayer::CompositionLayer):

platform/graphics/nicosia/NicosiaPlatformLayer.h: Added.

(Nicosia::PlatformLayer::isCompositionLayer const):
(Nicosia::PlatformLayer::id const):
(Nicosia::CompositionLayer::create):
(Nicosia::CompositionLayer::LayerState::Flags::Flags):
(Nicosia::CompositionLayer::updateState):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setPosition):
(WebCore::CoordinatedGraphicsLayer::setAnchorPoint):
(WebCore::CoordinatedGraphicsLayer::setSize):
(WebCore::CoordinatedGraphicsLayer::setTransform):
(WebCore::CoordinatedGraphicsLayer::setChildrenTransform):
(WebCore::CoordinatedGraphicsLayer::setPreserves3D):
(WebCore::CoordinatedGraphicsLayer::setMasksToBounds):
(WebCore::CoordinatedGraphicsLayer::setDrawsContent):
(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setContentsOpaque):
(WebCore::CoordinatedGraphicsLayer::setBackfaceVisibility):
(WebCore::CoordinatedGraphicsLayer::setOpacity):
(WebCore::CoordinatedGraphicsLayer::setContentsRect):
(WebCore::CoordinatedGraphicsLayer::setContentsTileSize):
(WebCore::CoordinatedGraphicsLayer::setContentsTilePhase):
(WebCore::CoordinatedGraphicsLayer::setContentsToSolidColor):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

4:58 AM Changeset in webkit [233844] by Carlos Garcia Campos

6 edits in trunk

[GLIB] Add API to evaluate code using a given object to store global symbols
https://bugs.webkit.org/show_bug.cgi?id=187639

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

Add jsc_context_evaluate_in_object(). It returns a new object as an out parameter. Global symbols in the
evaluated script are added as properties to the new object instead of to the context global object. This is
similar to JS::Evaluate in spider monkey when a scopeChain parameter is passed, but JSC doesn't support using a
scope for assignments, so we have to create a new context and get its global object. This patch also updates
jsc_context_evaluate_with_source_uri() to receive the starting line number for consistency with the new
jsc_context_evaluate_in_object().

API/glib/JSCContext.cpp:

(jsc_context_evaluate): Pass 0 as line number to jsc_context_evaluate_with_source_uri().
(evaluateScriptInContext): Helper function to evaluate a script in a JSGlobalContextRef.
(jsc_context_evaluate_with_source_uri): Use evaluateScriptInContext().
(jsc_context_evaluate_in_object): Create a new context and set the main context global object as extension
scope of it. Evaluate the script in the new context and get its global object to be returned as parameter.

API/glib/JSCContext.h:
API/glib/docs/jsc-glib-4.0-sections.txt:

Tools:

Add a new test case.

TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCEvaluateInObject):
(testJSCExceptions):
(main):

Jul 15, 2018:

11:43 PM Changeset in webkit [233843] by zandobersek@gmail.com

3 edits in trunk/Tools

[webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
https://bugs.webkit.org/show_bug.cgi?id=187353

Reviewed by Youenn Fablet.

When using run-web-platform-tests, allow specifying custom WPT metadata
directory. This will avoid generating such metadata-filled directory
from the port-specific JSON expectations file, and instead will search
for the metadata files and the include manifest inside the specified
directory. The MANIFEST.json file will also be generated under there.

Rationale for this change is prototyping using custom metadata
directories and avoiding generating all this content from a JSON file.
Using this by default in the future would avoid sporradic changes in how
WPT handles metadata .ini files and releases us from the obligation of
adjusting the generator for every such change. This would also allow
managing this metadata content in a separate repository, avoiding
polluting the main webkit.org repository with thousands of .ini files.

If this turns out to be the preferable way of managing the metadata
content, the JSON files under WebPlatformTests/ and the related code in
wpt_runner.py would be removed.

Scripts/webkitpy/w3c/wpt_runner.py:

(parse_args):
(WPTRunner._wpt_run_paths):
(WPTRunner.run):

Scripts/webkitpy/w3c/wpt_runner_unittest.py:

(WPTRunnerTest.test_run_with_specified_options):

10:22 PM Changeset in webkit [233842] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit

[SOUP] http/tests/misc/bubble-drag-events.html crashes
https://bugs.webkit.org/show_bug.cgi?id=182352

Reviewed by Youenn Fablet.

PingLoad is not refcounted and deletes itself when the load finishes. The problem is that the network data
task can also finish the load, causing the PingLoad to be deleted early. We tried to fix it in r233032 in the
network data task soup implementation, but it caused regressions.

NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::didReceiveChallenge): Create a weak ref for the ping load before calling the operation completion
handler and return early after the completion handler if it was deleted.
(WebKit::PingLoad::didReceiveResponseNetworkSession): Ditto.

NetworkProcess/PingLoad.h:
NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueAuthenticate): Revert r233032.

10:19 PM Changeset in webkit [233841] by Wenson Hsieh

2 edits in trunk/Source/WebCore

[iOS apps on macOS] Playing embedded Twitter videos in the News app crashes the web process
https://bugs.webkit.org/show_bug.cgi?id=187690
<rdar://problem/41869703>

Reviewed by Tim Horton.

Work around unexpected behavior when soft-linking AVFoundation. After using dlopen_preflight to check for the
existence of a library prior to loading the library using dlopen, dlsym subsequently returns null for some
symbols that would otherwise be available. This causes us to RELEASE_ASSERT later down the road when we try to
load AVAudioSessionModeDefault in AudioSessionIOS.mm.

To fix this for now, simply check for the library directly instead of using the more lightweight preflight
check. See clone: <rdar://problem/42224780> for more detail.

Context Navigation

Timeline

Jul 16, 2018:

Jul 15, 2018:

Download in other formats: