Timeline

Aug 11, 2018:

9:13 PM Changeset in webkit [234785] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews-build] Separate queues for Builders and Testers - iOS
​https://bugs.webkit.org/show_bug.cgi?id=188396

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.

Also added ews121 and ews122 to match with current EWS configuration.

• BuildSlaveSupport/ews-build/factories.py:

(TestsFactory): Base classes for various Test factories.
(TestsFactory.getProduct): Download and extract the archive.

2:04 PM Changeset in webkit [234784] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Disable JIT on IA-32 without SSE2
​https://bugs.webkit.org/show_bug.cgi?id=188476

Patch by Karo Gyoker <​karogyoker2+webkit@gmail.com> on 2018-08-11
Reviewed by Yusuke Suzuki.

On IA-32 CPUs without SSE2 most of the webpages cannot load
if the JIT is turned on.

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

7:04 AM Changeset in webkit [234783] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [pt_BR] Updated Brazilian Portuguese translation
​https://bugs.webkit.org/show_bug.cgi?id=188482

Patch by Rafael Fontenelle <​rafaelff@gnome.org> on 2018-08-11
Rubber-stamped by Michael Catanzaro.

• pt_BR.po:

Aug 10, 2018:

11:47 PM Changeset in webkit [234782] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Use OptionSet for various RenderLayer flags
​https://bugs.webkit.org/show_bug.cgi?id=188472
<rdar://problem/43153059>

Followup, fix some mistakes.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::~RenderLayerBacking):

7:55 PM Changeset in webkit [234781] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebKit

[Cocoa] WebKit::PlatformPopupMenuData should use member initialization
<​https://webkit.org/b/188478>
<rdar://problem/43154363>

Reviewed by Joseph Pecoraro.

• Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
implementation. This constructor caused the warning by never
initializing its member variables.

• Shared/PlatformPopupMenuData.h:

(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):

• Use default constructor.

(WebKit::PlatformPopupMenuData::shouldPopOver):
(WebKit::PlatformPopupMenuData::hideArrows):
(WebKit::PlatformPopupMenuData::menuSize):

• Add struct member initialization.

7:43 PM Changeset in webkit [234780] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Web Inspector: console.log fires getters for deep properties
​https://bugs.webkit.org/show_bug.cgi?id=187542
<rdar://problem/42873158>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Saam Barati.

Source/JavaScriptCore:

• inspector/InjectedScriptSource.js:

(RemoteObject.prototype._isPreviewableObject):
Avoid getters/setters when checking for simple properties to preview.
Here we avoid invoking object[property] if it could be a user getter.

LayoutTests:

• inspector/injected-script/avoid-getter-invocation-expected.txt: Added.
• inspector/injected-script/avoid-getter-invocation.html: Added.

7:21 PM Changeset in webkit [234779] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

LayoutTest inspector/worker/debugger-pause.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=164833
<rdar://problem/29295404>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Brian Burg.

• inspector/worker/debugger-pause.html:

Add a microtask turn to ensure the workerTarget's mainResource is setup.
There were times it might not get setup, but a single turn appears
reliable enough.

• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:

This test always passes for me in Release and Debug. Reset expectations.

7:01 PM Changeset in webkit [234778] by rniwa@webkit.org

• 4 edits in trunk/Source

[macOS] Multiple third party apps crash due to the thread safety check in TimerBase::setNextFireTime
​https://bugs.webkit.org/show_bug.cgi?id=188480

Reviewed by Simon Fraser.

Source/WebCore:

Suppress the release assert in WebKit1 on macOS (isInWebProcess is always true in non-Cocoa platforms).

In the future, we should consider throwing Objective-C exceptions when third party apps call WebKit1
or WebKit2 APIs in non-main threads.

• platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck): Extracted out of ~TimerBase and setNextFireTime.
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):

Source/WTF:

Added the SDK version for macOS Mojave.

• wtf/spi/darwin/dyldSPI.h:

4:31 PM Changeset in webkit [234777] by keith_miller@apple.com

• 6 edits in trunk

Slicing an ArrayBuffer with a long number returns an ArrayBuffer with byteLength zero
​https://bugs.webkit.org/show_bug.cgi?id=185127

Reviewed by Saam Barati.

JSTests:

Rebaseline the expectations.

• test262/expectations.yaml:

Source/JavaScriptCore:

Previously, we would truncate the indicies passed to slice to an
int. This meant that the value was not getting properly clamped
later.

This patch also removes a non-spec compliant check that slice was
passed at least one argument.

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::clampIndex const):
(JSC::ArrayBuffer::slice const):

• runtime/ArrayBuffer.h:

(JSC::ArrayBuffer::clampValue): Deleted.
(JSC::ArrayBuffer::clampIndex const): Deleted.

• runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):

4:03 PM Changeset in webkit [234776] by Chris Dumez

• 6 edits
  3 adds in trunk

Crash under NetworkResourceLoader::convertToDownload()
​https://bugs.webkit.org/show_bug.cgi?id=188479
<rdar://problem/42201724>

Reviewed by Alex Christensen.

Source/WebKit:

In NetworkResourceLoader::convertToDownload(), if m_networkLoad is null then we're trying
to convert a load that came from the disk cache. Since we do not currently support converting
such a load, cancel the current load and start a fresh download.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::convertToDownload):

LayoutTests:

Add layout test coverage which reproduces the crash by:

1. Loading a cacheable plugin while plugins are enabled so that the plugin goes into the disk cache
2. Load the plugin again with plugins disabled so that we try to convert the load to a download

• http/tests/download/convert-cached-load-to-download-expected.txt: Added.
• http/tests/download/convert-cached-load-to-download.html: Added.
• http/tests/plugins/resources/mock-plugin-cacheable.pl: Added.

3:59 PM Changeset in webkit [234775] by Kocsen Chung

• 7 edits in branches/safari-606.1.36.0-branch/Source

Versioning.

3:58 PM Changeset in webkit [234774] by Kocsen Chung

• 7 edits in branches/safari-606.1.36.1-branch/Source

Versioning.

3:35 PM Changeset in webkit [234773] by Kocsen Chung

• 1 copy in tags/Safari-606.1.36.1.4

Tag Safari-606.1.36.1.4.

2:55 PM Changeset in webkit [234772] by Kocsen Chung

• 1 copy in tags/Safari-606.1.36.0.2

Tag Safari-606.1.36.0.2.

2:53 PM Changeset in webkit [234771] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()
​https://bugs.webkit.org/show_bug.cgi?id=188459

Reviewed by Chris Dumez.

It is unnessary for CachedFrameBase::restore() to explicitly resume animations on the
document as it calls Document::resume(), which already does this.

No functionality changed. So, no new tests.

• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

2:48 PM Changeset in webkit [234770] by dbates@webkit.org

• 2 edits in trunk/Tools

webkit-patch setup-git-clone should set Git core editor to commit-log-editor
​https://bugs.webkit.org/show_bug.cgi?id=188473

Reviewed by Ryosuke Niwa.

Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
so that the Git commit message is generated from the ChangeLog for developers that manually
generate their ChangeLog using prepare-ChangeLog.

• Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):

1:29 PM Changeset in webkit [234769] by Ross Kirsling

• 2 edits in trunk/LayoutTests

[WinCairo] More unreviewed gardening.

• platform/wincairo/TestExpectations:

12:51 PM Changeset in webkit [234768] by Antti Koivisto

• 13 edits in trunk/Source

Use OptionSet for various RenderLayer flags
​https://bugs.webkit.org/show_bug.cgi?id=188472

Reviewed by Simon Fraser.

Source/WebCore:

Typesafe flags.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• page/FrameView.cpp:

(WebCore::updateLayerPositionFlags):
(WebCore::FrameView::paintContents):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::paint):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::filterPainter const):
(WebCore::RenderLayer::hasFilterThatIsPainting const):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(RenderLayer::paintLayerByApplyingTransform):
(RenderLayer::paintList):
(RenderLayer::updatePaintingInfoForFragments):
(RenderLayer::paintTransformedLayerIntoFragments):
(RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::paintLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::paintList): Deleted.
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree const): Deleted.
(WebCore::RenderLayer::collectFragments): Deleted.
(WebCore::RenderLayer::updatePaintingInfoForFragments): Deleted.
(WebCore::RenderLayer::paintTransformedLayerIntoFragments): Deleted.
(WebCore::RenderLayer::paintBackgroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragments): Deleted.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Deleted.
(WebCore::RenderLayer::paintOutlineForFragments): Deleted.
(WebCore::RenderLayer::paintMaskForFragments): Deleted.
(WebCore::RenderLayer::paintChildClippingMaskForFragments): Deleted.
(WebCore::RenderLayer::paintOverflowControlsForFragments): Deleted.
(WebCore::RenderLayer::hitTest): Deleted.
(WebCore::RenderLayer::enclosingElement const): Deleted.
(WebCore::RenderLayer::enclosingFragmentedFlowAncestor const): Deleted.
(WebCore::computeZOffset): Deleted.
(WebCore::RenderLayer::createLocalTransformState const): Deleted.
(WebCore::isHitCandidate): Deleted.
(WebCore::RenderLayer::hitTestLayer): Deleted.
(WebCore::RenderLayer::hitTestContentsForFragments const): Deleted.
(WebCore::RenderLayer::hitTestResizerInFragments const): Deleted.
(WebCore::RenderLayer::hitTestTransformedLayerInFragments): Deleted.
(WebCore::RenderLayer::hitTestLayerByApplyingTransform): Deleted.
(WebCore::RenderLayer::hitTestContents const): Deleted.
(WebCore::RenderLayer::hitTestList): Deleted.
(WebCore::RenderLayer::updateClipRects): Deleted.
(WebCore::RenderLayer::clipRects const): Deleted.
(WebCore::RenderLayer::calculateClipRects const): Deleted.
(WebCore::showLayerTree): Deleted.

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::paintIntoLayer):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

• rendering/RenderLayerCompositor.h:
• rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

Source/WTF:

• wtf/MathExtras.h:

(hasOneBitSet):
(hasZeroOrOneBitsSet):
(hasTwoOrMoreBitsSet):

Make constexpr.

• wtf/OptionSet.h:

(WTF::OptionSet::OptionSet):

Always use constexpr, no need for separate debug versions with C++14.

12:35 PM Changeset in webkit [234767] by Basuke Suzuki

• 6 edits in trunk/LayoutTests

[LayoutTests] Suppress warning messages generated by the test scripts.
​https://bugs.webkit.org/show_bug.cgi?id=188455

Reviewed by Fujii Hironori.

The messages such as warnings shouldn't be out on error log if that can be avoidable.

• http/tests/cookies/resources/cookie-utility.php:
• http/tests/xmlhttprequest/resources/access-control-allow-lists.php:
• http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
• http/tests/xmlhttprequest/resources/post-echo.cgi:
• http/tests/xmlhttprequest/web-apps/004-test.cgi:

12:05 PM Changeset in webkit [234766] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
​https://bugs.webkit.org/show_bug.cgi?id=188461
<rdar://problem/33555052>

Reviewed by Chris Dumez.

When we try to schedule shutdown for database, we should cancel the timer so no
scheduleShutdownForClose will be running after this.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):

11:56 AM Changeset in webkit [234765] by Truitt Savell

• 5 edits in trunk/Tools

Unreviewed, rolling out r234749.

Caused all perf tests to fail in Sierra

Reverted changeset:

"[webkitpy][Win] LayoutTests: test names should be Unix style,
separated by slash not backslash"
​https://bugs.webkit.org/show_bug.cgi?id=187973
​https://trac.webkit.org/changeset/234749

11:23 AM Changeset in webkit [234764] by commit-queue@webkit.org

• 4 edits in trunk/PerformanceTests

Add ability to ignore process prewarming for launch time benchmark
​https://bugs.webkit.org/show_bug.cgi?id=188462

Patch by Ben Richards <​benton_richards@apple.com> on 2018-08-10
Reviewed by Ryosuke Niwa.

Added a flag to the new tab benchmark that will open a blank tab before the tab to be measured in order to ignore process prewarming.

• LaunchTime/launch_time.py:

(DefaultLaunchTimeHandler):
(DefaultLaunchTimeHandler.on_receive_stop_time): Deleted.
(DefaultLaunchTimeHandler.on_receive_stop_signal):
(DefaultLaunchTimeHandler.do_HEAD):
(DefaultLaunchTimeHandler.do_GET):
(DefaultLaunchTimeHandler.do_POST):
(LaunchTimeBenchmark):
(LaunchTimeBenchmark._standard_deviation): Fixed divide by zero bug when '-n' is set to 1
(LaunchTimeBenchmark.open_tab): Added option to open a blank tab
(LaunchTimeBenchmark.run):

• LaunchTime/new_tab.py:

(NewTabBenchmark.initialize):
(NewTabBenchmark.run_iteration):
(NewTabBenchmark.will_parse_arguments):
(NewTabBenchmark.did_parse_arguments):
(NewTabBenchmark.ResponseHandler.Handler.get_test_page):
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(NewTabBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(NewTabBenchmark):

• LaunchTime/startup.py:

(StartupBenchmark.ResponseHandler.Handler.get_test_page):
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_time): Deleted.
(StartupBenchmark.ResponseHandler.Handler.on_receive_stop_signal):
(StartupBenchmark):

10:42 AM Changeset in webkit [234763] by yusukesuzuki@slowstart.org

• 5 edits
  2 adds in trunk

Date.UTC should not return NaN with only Year param
​https://bugs.webkit.org/show_bug.cgi?id=188378

Reviewed by Keith Miller.

JSTests:

• ChakraCore.yaml:
• ChakraCore/test/Date/dateutc.baseline-jsc: Added.
• stress/date-utc-optional.js: Added.

(shouldBe):

• test262/expectations.yaml:

Source/JavaScriptCore:

Date.UTC requires one argument for |year|. But the other ones are optional.
This patch fix this handling.

• runtime/DateConstructor.cpp:

(JSC::millisecondsFromComponents):

10:39 AM Changeset in webkit [234762] by dbates@webkit.org

• 3 edits
  5 adds in trunk

Once <object> is hidden, its content won't be displayed again if its URL has fragment identifier ("#").
​https://bugs.webkit.org/show_bug.cgi?id=187990

Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue where an HTML object element that behaves like an iframe and references a resource
whose URL contains a fragment would not be repainted when its CSS display property changes.

Rendering of an <object> that behaves like an iframe is handled by a widget (FrameView). When
the CSS display property for an <object> is set to "none" we detach the widget from its renderer
as part of destroying the render tree for the <object>. Subsequently changing the CSS display
to a non-"none"/"contents" value will create a new renderer for <object> R. For an <object> that
behaves like an iframe, we navigate to the resource associated with the <object> reusing the
existing Frame F object created when we first displayed the <object>. Unlike the case where
the URL of the resource does not contain a fragment, navigating to a fragment in the same document
uses a different code path that does not re-associate the FrameView of F with R before it scrolls
the view; => the FrameView of F is not in the view hierarchy. Therefore we do not paint anything
for the content of the <object> and hence the scroll is not observable. Instead we need to ensure
that the FrameView of F installed in the view hierarchy when navigating to an anchor in the same
document.

As a side benefit of this fix we now also repaint an <object> that is programmatically navigated
to a different anchor in the same document.

Tests: fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html

fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

Add tests to ensure that we repaint an <object>, whose resource URL contains a fragment, when
its CSS display property changes as well as when its navigated to a different anchor in the same
document.

• fast/repaint/object-as-iframe-hide-and-show-document-at-anchor-expected.txt: Added.
• fast/repaint/object-as-iframe-hide-and-show-document-at-anchor.html: Added.
• fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint-expected.txt: Added.
• fast/repaint/object-as-iframe-navigate-to-same-document-anchor-repaint.html: Added.
• fast/repaint/resources/red-square-on-top-of-green-square.html: Added.

10:08 AM Changeset in webkit [234761] by ajuma@chromium.org

• 10 edits in trunk

[IntersectionObserver] Implement rootMargin parsing
​https://bugs.webkit.org/show_bug.cgi?id=188469

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update expectations for newly passing test cases.

• web-platform-tests/intersection-observer/observer-attributes-expected.txt:
• web-platform-tests/intersection-observer/observer-exceptions-expected.txt:

Source/WebCore:

Parse IntersectionObserver's rootMargin argument and throw an exception if it's invalid.
Change the stored rootMargin from a String to a LengthBox so that future patches can
use this value in intersection logic.

Tested by: imported/w3c/web-platform-tests/intersection-observer/observer-attributes.html

imported/w3c/web-platform-tests/intersection-observer/observer-exceptions.html
intersection-observer/intersection-observer-interface.html

• page/IntersectionObserver.cpp:

(WebCore::parseRootMargin):
(WebCore::IntersectionObserver::create):
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::rootMargin const):

• page/IntersectionObserver.h:

(WebCore::IntersectionObserver::create): Deleted.
(WebCore::IntersectionObserver::rootMargin const): Deleted.

• page/IntersectionObserver.idl:

LayoutTests:

• intersection-observer/intersection-observer-interface-expected.txt:
• intersection-observer/intersection-observer-interface.html:

9:46 AM Changeset in webkit [234760] by Kocsen Chung

• 10 edits in branches/safari-606.1.36.0-branch

Cherry-pick r234730. rdar://problem/43144157

REGRESSION (r232083): WKWebView loses first-party cookies on iOS
​https://bugs.webkit.org/show_bug.cgi?id=188443
<rdar://problem/42991584>

Patch by Sihui Liu <​sihui_liu@apple.com> on 2018-08-09
Reviewed by Chris Dumez.

Source/WebKit:

Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode):
• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::platformInitializeNetworkProcess):

Tools:

Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.

• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:45 AM Changeset in webkit [234759] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKit

Incorrect log message in NetworkSession when creating NetworkDataTask
​https://bugs.webkit.org/show_bug.cgi?id=188463

Reviewed by Chris Dumez.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

9:31 AM Changeset in webkit [234758] by david_fenton@apple.com

• 2 edits in trunk/Tools

Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
​https://bugs.webkit.org/show_bug.cgi?id=188470.

Unreviewed test gardening, disabling the tests.

• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:

(TEST_F):

9:26 AM Changeset in webkit [234757] by Truitt Savell

• 4 edits in trunk/PerformanceTests

Unreviewed, rolling out r234750.

Caused 185 perf test failures.

Reverted changeset:

"Add ability to ignore process prewarming for launch time
benchmark"
​https://bugs.webkit.org/show_bug.cgi?id=188462
​https://trac.webkit.org/changeset/234750

9:10 AM Changeset in webkit [234756] by commit-queue@webkit.org

• 7 edits in trunk

Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
​https://bugs.webkit.org/show_bug.cgi?id=188458

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-10
Reviewed by Alex Christensen.

Tools:

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):

• TestResultServer/static-dashboards/flakiness_dashboard.js:

LayoutTests:

• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

9:02 AM Changeset in webkit [234755] by Ryan Haddad

• 2 edits in branches/safari-606.1.36.1-branch/Tools

Cherry-pick r234734. rdar://problem/42387347

REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=188397

Reviewed by Tim Horton.

After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.

• WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):

git-svn-id: ​http://svn.webkit.org/repository/webkit/trunk@234734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:52 AM Changeset in webkit [234754] by Ryan Haddad

• 2 edits in branches/safari-606-branch/Tools

Cherry-pick r234734. rdar://problem/42387347

REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=188397

Reviewed by Tim Horton.

After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
user defaults related to scrollbars in the UI process as we do in the WebProcess.

• WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):

git-svn-id: ​http://svn.webkit.org/repository/webkit/trunk@234734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:17 AM Changeset in webkit [234753] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebDriver

[GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
​https://bugs.webkit.org/show_bug.cgi?id=188465

Reviewed by Žan Doberšek.

We only want to use --automation when no options or no browser binary is provided, because we fallback to
MiniBrowser and we know it needs --automation flag.

• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::launchBrowser): Handle the case of browser arguments being std::nullopt.

• gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformParseCapabilities const): Initialize browser arguments to std:nullopt if
browser binary was provided.

• wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformParseCapabilities const): Ditto.

12:57 AM Changeset in webkit [234752] by Ross Kirsling

• 4 edits
  21 adds in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

• platform/wincairo/TestExpectations:
• platform/wincairo/editing/selection/5057506-expected.png: Added.
• platform/wincairo/editing/selection/caret-ltr-right-expected.txt:
• platform/wincairo/editing/selection/caret-rtl-right-expected.txt:
• platform/wincairo/editing/selection/doubleclick-crash-expected.txt: Added.
• platform/wincairo/editing/selection/editable-links-expected.txt: Added.
• platform/wincairo/editing/selection/extend-by-character-006-expected.txt: Added.
• platform/wincairo/editing/selection/extend-by-sentence-001-expected.txt: Added.
• platform/wincairo/editing/selection/extend-by-word-001-expected.txt: Added.
• platform/wincairo/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
• platform/wincairo/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
• platform/wincairo/editing/selection/extend-selection-bidi-expected.txt: Added.
• platform/wincairo/editing/selection/focus-body-expected.txt: Added.
• platform/wincairo/editing/selection/move-by-line-001-expected.txt: Added.
• platform/wincairo/editing/selection/move-by-word-001-expected.txt: Added.
• platform/wincairo/editing/selection/select-all-001-expected.txt: Added.
• platform/wincairo/editing/selection/select-all-002-expected.txt: Added.
• platform/wincairo/editing/selection/select-all-003-expected.txt: Added.
• platform/wincairo/editing/selection/select-all-004-expected.txt: Added.
• platform/wincairo/editing/selection/unrendered-001-expected.txt: Added.
• platform/wincairo/editing/selection/unrendered-002-expected.txt: Added.
• platform/wincairo/editing/selection/unrendered-003-expected.txt: Added.
• platform/wincairo/editing/selection/unrendered-004-expected.txt: Added.
• platform/wincairo/editing/selection/unrendered-005-expected.txt: Added.