⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 15, 2018:

10:38 PM Changeset in webkit [234912] by commit-queue@webkit.org
  • 37 edits
    4 adds in trunk

NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
​https://bugs.webkit.org/show_bug.cgi?id=186870
Source/WebCore:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-15
Reviewed by Alex Christensen.

Add the ProtectionSpaceAuthenticationSchemeOAuth type.

  • platform/network/ProtectionSpaceBase.cpp:

(WebCore::ProtectionSpaceBase::isPasswordBased const): Return yes because the oauth challenge
expects a token in return.

  • platform/network/ProtectionSpaceBase.h:
  • platform/network/cocoa/ProtectionSpaceCocoa.mm:

(WebCore::scheme):
(WebCore::ProtectionSpace::nsSpace const):

Source/WebCore/PAL:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-15
Reviewed by Alex Christensen.

  • pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the

internal SDK.

Source/WebKit:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-15
Reviewed by Alex Christensen.

Correctly expose the OAuth protection space type in API.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):

  • UIProcess/API/C/WKProtectionSpaceTypes.h:

Tools:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-15
Reviewed by Alex Christensen.

  • WebKitTestRunner/TestController.cpp:

(WTR::toString):
(WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
(WTR::TestController::didReceiveAuthenticationChallenge):

LayoutTests:

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-15
Reviewed by Alex Christensen.

Ensure the exposed authentication type to clients is OAuth.

  • http/tests/loading/oauth-expected.txt: Added.
  • http/tests/loading/oauth.html: Added.
  • http/tests/loading/resources/oauth-subresource.php: Added.
10:35 PM Changeset in webkit [234911] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.36.0-branch/Source

Versioning.

8:34 PM Changeset in webkit [234910] by commit-queue@webkit.org
  • 23 edits
    5 adds in trunk

We should cache the compiled sandbox profile in a data vault
​https://bugs.webkit.org/show_bug.cgi?id=184991

Patch by Ben Richards <​benton_richards@apple.com> on 2018-08-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Added functionality to FileHandle so that it can lock a file while open.
Added a function to FileSystem to delete non empty directories.

  • platform/FileHandle.cpp:

(WebCore::FileHandle::FileHandle):
(WebCore::FileHandle::open):
(WebCore::FileHandle::close):

  • platform/FileHandle.h:
  • platform/FileSystem.h:
  • platform/cocoa/FileSystemCocoa.mm:

(WebCore::FileSystem::deleteNonEmptyDirectory):

Source/WebKit:

This patch changes a few things (note: data vaults and sandbox entitlements are only used in internal builds):
(1) Instead of compiling a sandbox every time a process is launched, processes now look for a cached sandbox

in a process specific data vault on macOS platforms. (ChildProcessMac.mm)

(2) If a valid cached sandbox is not found, a process will create the data vault (or ensure that it exists),

compile a sandbox, and cache it.

(3) In order to create process specific data vaults, each process now has their own <process name>-OSX-sandbox.entitlements

file which contains an entitlement with a process specific "storage class" which ensures that each process
can only ever access its own data vault. (See the article on confluence "Data Vaults and Restricted Files" for more info)

(4) The sandbox entitlements file for the Network and WebContent services are loaded dynamically

through Scripts/<process name>-process-entitlements.sh which is triggered in a new build phase for each service.
The Storage process sandbox entitlements are loaded directly in Configurations/StorageService.xcconfig.
The reason that the sandbox entitlements are applied dynamically is so that these sandbox entitlements
are only applied when WK_USE_RESTRICTED_ENTITLEMENTS is YES. This means that open source builds will still work.

  • Configurations/Network-OSX-sandbox.entitlements: Added.
  • Configurations/Storage-OSX-sandbox.entitlements: Added.
  • Configurations/StorageService.xcconfig:
  • Configurations/WebContent-OSX-sandbox.entitlements: Added.
  • Configurations/WebKit.xcconfig:
  • NetworkProcess/NetworkProcess.h:
  • PluginProcess/PluginProcess.h:
  • Scripts/process-network-sandbox-entitlements.sh: Added.
  • Scripts/process-webcontent-sandbox-entitlements.sh: Added.
  • Shared/ChildProcess.h:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

  • Shared/SandboxInitializationParameters.h:

(WebKit::SandboxInitializationParameters::setOverrideSandboxProfilePath):
(WebKit::SandboxInitializationParameters::overrideSandboxProfilePath const):
(WebKit::SandboxInitializationParameters::setSandboxProfile):
(WebKit::SandboxInitializationParameters::sandboxProfile const):
(): Deleted.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::SandboxProfileDeleter::operator()):
(WebKit::SandboxParametersDeleter::operator()):
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::fileContents):
(WebKit::processStorageClass):
(WebKit::setAndSerializeSandboxParameters):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::sandboxDirectory):
(WebKit::sandboxFilePath):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::writeSandboxDataToCacheFile):
(WebKit::compileAndCacheSandboxProfile):
(WebKit::tryApplyCachedSandbox):
(WebKit::webKit2Bundle):
(WebKit::getSandboxProfileOrProfilePath):
(WebKit::compileAndApplySandboxSlowCase):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::ChildProcess::initializeSandbox):

  • Shared/mac/SandboxInitialiationParametersMac.mm:

(WebKit::SandboxInitializationParameters::SandboxInitializationParameters):

  • StorageProcess/StorageProcess.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.h:

Source/WTF:

Added trace points for sandbox initialization and exposed functions needed for sandbox caching

  • wtf/SystemTracing.h:
  • wtf/spi/darwin/SandboxSPI.h:

Tools:

Added trace points for sandbox initialization

  • Tracing/SystemTracePoints.plist:
6:21 PM Changeset in webkit [234909] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.36.0.3

Tag Safari-606.1.36.0.3.

5:04 PM Changeset in webkit [234908] by Ross Kirsling
  • 2 edits in trunk/Source/WebKit

[WinCairo] Unreviewed build fix after r234896.

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::tryHttpAuthentication):

4:46 PM Changeset in webkit [234907] by bshafiei@apple.com
  • 3 edits in branches/safari-606.1.36.0-branch/Source

Apply patch. rdar://problem/43354873

4:46 PM Changeset in webkit [234906] by bshafiei@apple.com
  • 5 edits in branches/safari-606.1.36.1-branch/Source

Cherry-pick r234905. rdar://problem/43347925

Can't share an app on AppStore to WeChat due to a release assert
​https://bugs.webkit.org/show_bug.cgi?id=188621
<rdar://problem/43343976>

Reviewed by Geoffrey Garen.

Disable the thread safety check when the app is not linked on or after iOS 12 since this release assert
is getting hit by third party applications on iOS in UI process.

Source/WebCore:

  • platform/Timer.cpp: (WebCore::shouldSuppressThreadSafetyCheck): Added a SDK check.

Source/WebKit:

  • UIProcess/Cocoa/VersionChecks.h: (WebKit::SDKVersion::FirstWithMainThreadReleaseAssertionInWebPageProxy): Added. It's iOS 12 or macOS 10.14 Mojave.
  • UIProcess/WebProcessProxy.cpp: (WebKit::isMainThreadOrCheckDisabled): Added. Returns true whether when we're in the main thread or if the app is not linked on or after iOS 12 or macOS 10.14 Mojave. (WebKit::globalPageMap): (WebKit::m_isInPrewarmedPool): (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores): (WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData): (WebKit::WebProcessProxy::didFinishLaunching):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:37 PM Changeset in webkit [234905] by rniwa@webkit.org
  • 5 edits in trunk/Source

Can't share an app on AppStore to WeChat due to a release assert
​https://bugs.webkit.org/show_bug.cgi?id=188621
<rdar://problem/43343976>

Reviewed by Geoffrey Garen.

Disable the thread safety check when the app is not linked on or after iOS 12 since this release assert
is getting hit by third party applications on iOS in UI process.

Source/WebCore:

  • platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck): Added a SDK check.

Source/WebKit:

  • UIProcess/Cocoa/VersionChecks.h:

(WebKit::SDKVersion::FirstWithMainThreadReleaseAssertionInWebPageProxy): Added. It's iOS 12 or macOS 10.14 Mojave.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::isMainThreadOrCheckDisabled): Added. Returns true whether when we're in the main thread or if the app
is not linked on or after iOS 12 or macOS 10.14 Mojave.
(WebKit::globalPageMap):
(WebKit::m_isInPrewarmedPool):
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebProcessProxy::didFinishLaunching):

4:11 PM Changeset in webkit [234904] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.36.1-branch/Source

Versioning.

3:48 PM Changeset in webkit [234903] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Remove WKNavigationDelegatePrivate's canAuthenticateAgainstProtectionSpace
​https://bugs.webkit.org/show_bug.cgi?id=188622

Reviewed by Timothy Hatcher.

It's been deprecated for a release now, nobody uses it, and it's a concept from NSURLConnection, which we don't use any more in WebKit2.

  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::canAuthenticateAgainstProtectionSpace):

3:10 PM Changeset in webkit [234902] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 63

Added a tag for Safari Technology Preview release 63.

3:03 PM Changeset in webkit [234901] by chris.reid@sony.com
  • 6 edits in trunk

[Curl] Implement default cookie path handling correctly as outlined in RFC6265.
​https://bugs.webkit.org/show_bug.cgi?id=188609

Reviewed by Alex Christensen.

Curl implementation of default cookie path was wrong so that some cookies cannot be accessible.
It should be generated as outlined in: ​https://tools.ietf.org/html/rfc6265#section-5.1.4

Source/WebCore:

Tests: http/tests/cookies/http-get-cookie-set-in-js.html

  • platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::setCookie):

  • platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::defaultPathForURL):

  • platform/network/curl/CookieUtil.h:

LayoutTests:

  • platform/wincairo/TestExpectations:
    • http/tests/cookies/http-get-cookie-set-in-js.html [ Pass ]
1:59 PM Changeset in webkit [234900] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
​https://bugs.webkit.org/show_bug.cgi?id=188569
<rdar://problem/34201095>

Reviewed by Megan Gardner.

Source/WebKit:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange):
Speculative fix; the crashes indicate font is null, but we just checked it,
so it must be getting made null by convertFont:toSize:. Check again!

Source/WebKitLegacy/mac:

  • WebView/WebImmediateActionController.mm:

(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
Speculative fix; the crashes indicate font is null, but we just checked it,
so it must be getting made null by convertFont:toSize:. Check again!

1:45 PM Changeset in webkit [234899] by ajuma@chromium.org
  • 3 edits in trunk/LayoutTests

Disable IntersectionObserver tests on Windows for now
​https://bugs.webkit.org/show_bug.cgi?id=188613

Unreviewed test gardening.

The experimental feature for IntersectionObserver is off by default, and
Windows WebKit API would have to change to enable it, so just skip the
tests for now.

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
1:42 PM Changeset in webkit [234898] by Aditya Keerthi
  • 23 edits
    1 copy
    10 adds in trunk

[Datalist] Add button to TextFieldInputs with a datalist
​https://bugs.webkit.org/show_bug.cgi?id=187741

Reviewed by Tim Horton.

Source/WebCore:

TextFieldInputs that have an associated datalist element should be drawn as
combo boxes. However, we cannot use NSComboBox for this control, as NSComboBox
is not height-resizable. Furthermore, the input should also be able to contain
additional elements, such as the stepper for type=number and the cancel button
for type=search. For these reasons, we draw a button at the end of the input,
mimicking appearance of a combo box.

The list-button -webkit-appearance value was added to display the new button.

Tests: fast/forms/datalist/datalist-searchinput-appearance.html

fast/forms/datalist/datalist-textinput-appearance.html

  • Resources/ListButtonArrow.png: Added.
  • Resources/ListButtonArrow@2x.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/html.css:

(input::-webkit-list-button):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataListButtonElement const):

  • html/HTMLInputElement.h:
  • html/InputType.h:

(WebCore::InputType::dataListButtonElement const):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::needsContainer const):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
(WebCore::TextFieldInputType::listAttributeTargetChanged):
(WebCore::TextFieldInputType::dataListButtonElement const):
(WebCore::TextFieldInputType::dataListButtonElementWasClicked):
(WebCore::TextFieldInputType::didCloseSuggestions):

  • html/TextFieldInputType.h:
  • html/shadow/DataListButtonElement.cpp: Added.

(WebCore::DataListButtonElement::create):
(WebCore::DataListButtonElement::DataListButtonElement):
(WebCore::DataListButtonElement::~DataListButtonElement):
(WebCore::DataListButtonElement::defaultEventHandler):

  • html/shadow/DataListButtonElement.h: Added.
  • platform/ThemeTypes.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustListButtonStyle const):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(-[WebListButtonCell drawWithFrame:inView:]):
(WebCore::RenderThemeMac::paintListButtonForInput):
(WebCore::RenderThemeMac::adjustListButtonStyle const):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::listButton const):

Source/WebCore/PAL:

  • pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor().

Source/WebInspectorUI:

Add keyword completion for 'list-button'.

  • UserInterface/External/CodeMirror/css.js:
  • UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

Added tests to verify appearance of TextFieldInputs with a datalist.

  • fast/forms/datalist/datalist-searchinput-appearance.html: Added.
  • fast/forms/datalist/datalist-textinput-appearance.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/fast/forms/datalist/datalist-searchinput-appearance-expected.png: Added.
  • platform/mac/fast/forms/datalist/datalist-searchinput-appearance-expected.txt: Added.
  • platform/mac/fast/forms/datalist/datalist-textinput-appearance-expected.png: Added.
  • platform/mac/fast/forms/datalist/datalist-textinput-appearance-expected.txt: Added.
1:22 PM Changeset in webkit [234897] by Ryan Haddad
  • 36 edits
    4 deletes in trunk

Unreviewed, rolling out r234870.

The test introduced with this change is a flaky failure.

Reverted changeset:

"NSURLAuthenticationMethodOAuth challenges are surfaced to
clients in -didReceiveAuthenticationChallenge as
NSURLAuthenticationMethodDefault"
​https://bugs.webkit.org/show_bug.cgi?id=186870
​https://trac.webkit.org/changeset/234870

1:15 PM Changeset in webkit [234896] by achristensen@apple.com
  • 19 edits in trunk/Source/WebKit

NetworkCORSPreflightChecker should proceed in case of ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested even though the WebKit app is not implementing the didReceiveAuthenticationChallenge/didReceiveAuthenticationChallengeInFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=188592
<rdar://problem/43210331>

Reviewed by Youenn Fablet.

Do a canAuthenticateAgainstProtectionSpace check in NetworkCORSPreflightChecker like we do in NetworkLoad.
Use CompletionHandlers to make the now 3 different canAuthenticateAgainstProtectionSpace checks look the same from the NetworkProcess.

  • NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):

  • NetworkProcess/NetworkCORSPreflightChecker.h:
  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didReceiveChallenge):

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::didReceiveChallenge):

  • NetworkProcess/PingLoad.h:
  • NetworkProcess/PreconnectTask.cpp:

(WebKit::PreconnectTask::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::PreconnectTask::continueCanAuthenticateAgainstProtectionSpace): Deleted.

  • NetworkProcess/PreconnectTask.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didReceiveChallenge):

12:44 PM Changeset in webkit [234895] by Basuke Suzuki
  • 2 edits in trunk/LayoutTests

[Curl] Test gardening
​https://bugs.webkit.org/show_bug.cgi?id=188610

Unreviewed test gardening.

Unskip http/tests/cookies.

  • platform/wincairo/TestExpectations:
12:33 PM Changeset in webkit [234894] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove evernote hacks
​https://bugs.webkit.org/show_bug.cgi?id=188591

Reviewed by Joseph Pecoraro.

The hack was added in 2012 and the evernote app seems to work now.
It's probably not needed anymore.

  • API/JSValueRef.cpp:

(JSValueUnprotect):
(evernoteHackNeeded): Deleted.

11:59 AM Changeset in webkit [234893] by rniwa@webkit.org
  • 4 edits in trunk

connectedCallback is invoked by the HTML parser after child nodes had been inserted
​https://bugs.webkit.org/show_bug.cgi?id=183931
<rdar://problem/38843548>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaselined the test now that all test cases pass.

  • web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt:

Source/WebCore:

Invoke the custom element reactions after constructing and inserting a custom element as specifed in step 3.3 of:
​https://html.spec.whatwg.org/multipage/parsing.html#insert-a-foreign-element

The bug here was that HTMLConstructionSite::insertCustomElement uses attachLater so that even though the task
to insert the custom element was created, it didn't get executed until after CustomElementReactionStack in
HTMLDocumentParser::runScriptsForPausedTreeBuilder had been popped off of the stack.

Test: imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertCustomElement): Fixed the bug by manually executing the scheduled tasks.
This will enqueue any custom element reactions while CustomElementReactionStack in runScriptsForPausedTreeBuilder
is still in the stack.

11:50 AM Changeset in webkit [234892] by Basuke Suzuki
  • 4 edits in trunk

[Curl] Don't send Content-Type header for POST request when body is null.
​https://bugs.webkit.org/show_bug.cgi?id=188588

Reviewed by Youenn Fablet.

Source/WebCore:

The Content-Type header was sent by libcurl automatically. Suppress that behavior
when body is null.

Tests: http/tests/xmlhttprequest/methods.html

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupPOST):

LayoutTests:

  • platform/wincairo/TestExpectations:
10:59 AM Changeset in webkit [234891] by Megan Gardner
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, change my status to be a WebKit reviewer
and added expertise.

  • Scripts/webkitpy/common/config/contributors.json:
10:48 AM Changeset in webkit [234890] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Remove failing assertion introduced in r234873
​https://bugs.webkit.org/show_bug.cgi?id=188581

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):
The assertion is correct but failing because VectorTraits<String> is incorrect.
I'll re-add it and fix VectorTraits<String> in a separate patch.

10:29 AM Changeset in webkit [234889] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r?): the probe sidebar doesn't show up when adding probes
​https://bugs.webkit.org/show_bug.cgi?id=188594

Reviewed by Brian Burg.

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.set inspectedProbeSets):
(WI.ProbeDetailsSidebarPanel.prototype.initialLayout):
Add checks to ensure that DOM elements for each probe section exist before trying to
add/remove them from the sidebar. This can happen if probes are inspected before the sidebar
is shown for the first time.

  • UserInterface/Views/ProbeSetDataGrid.js:

(WI.ProbeSetDataGrid):
(WI.ProbeSetDataGrid.columnIdentifierForProbe): Added.
(WI.ProbeSetDataGrid.prototype._setupProbe):
(WI.ProbeSetDataGrid.prototype._teardownProbe):
(WI.ProbeSetDataGrid.prototype._probeExpressionChanged):

  • UserInterface/Views/ProbeSetDataGridNode.js:

(WI.ProbeSetDataGridNode.prototype.set frame):
Provide better column identifiers for each probe's WI.DataGrid. It's possible for the
numeric probe ID value to be stringified when passing it into the constructor of
WI.DataGrid, which will not match the original numeric value on later retrieval.

8:41 AM Changeset in webkit [234888] by Jonathan Bedard
  • 2 edits in trunk/Tools

WebKitTestRunner should support watch devices
​https://bugs.webkit.org/show_bug.cgi?id=188570

Reviewed by Alex Christensen.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
8:17 AM Changeset in webkit [234887] by Michael Catanzaro
  • 5 edits in trunk/Source

[WPE][GTK] WaylandCompositor fails to properly remove surface from its page map
​https://bugs.webkit.org/show_bug.cgi?id=188520

Reviewed by Alex Christensen.

Source/WebKit:

willDestroySurface overwrites the surface pointer in the map's iterator in an attempt to
change the value of the surface pointer in the map, but it doesn't work because changing
the iterator does not change the map itself. There's no need to fix this function: it's
better to use WeakPtr instead.

  • UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::getTexture):
(WebKit::WaylandCompositor::bindSurfaceToWebPage):
(WebKit::WaylandCompositor::unregisterWebPage):
(WebKit::WaylandCompositor::willDestroySurface): Deleted.

  • UIProcess/gtk/WaylandCompositor.h:

Source/WTF:

Add a comment pointing to CanMakeWeakPtr, since it's useful and I very nearly missed it.

  • wtf/WeakPtr.h:
7:32 AM Changeset in webkit [234886] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test editing/input/press-tab-during-ime-composition.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=188600

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:26 AM Changeset in webkit [234885] by Wenson Hsieh
  • 15 edits
    2 deletes in trunk

[Attachment SPI] Remove attachment display mode options
​https://bugs.webkit.org/show_bug.cgi?id=188596

Reviewed by Dan Bernstein.

Source/WebCore:

Remove the ability to specify an "in-place" or "icon" representation for attachment elements, as well as logic
needed to allow an attachment element to render image or video elements in a shadow root. The requirements that
initially drove this effort are obviated by r227068, which allows Mail to intercept and provide a custom scheme
for images inserted into the document via rich editing operations.

Removed some existing API tests in _WKAttachmentTests that exercised this functionality.

  • editing/Editor.cpp:

(WebCore::Editor::insertAttachmentFromFile):

  • editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):

  • html/AttachmentTypes.h:

(WebCore::AttachmentDisplayOptions::encode const):
(WebCore::AttachmentDisplayOptions::decode):

Remove logic for encoding the attachment display mode. While this leaves AttachmentDisplayOptions completely
empty, I haven't removed AttachmentDisplayOptions as well in this patch, since it's not clear that we won't be
needing any mechanism for influencing the display of attachment elements inserted via native SPI.

(): Deleted.

  • html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::createElementRenderer):
(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::parseAttribute):
(WebCore::HTMLAttachmentElement::invalidateShadowRootChildrenIfNecessary): Deleted.
(WebCore::HTMLAttachmentElement::attachmentRenderer const): Deleted.
(WebCore::HTMLAttachmentElement::updateDisplayMode): Deleted.
(WebCore::HTMLAttachmentElement::ensureInnerImage): Deleted.
(WebCore::HTMLAttachmentElement::ensureInnerVideo): Deleted.
(WebCore::HTMLAttachmentElement::innerImage const): Deleted.
(WebCore::HTMLAttachmentElement::innerVideo const): Deleted.
(WebCore::HTMLAttachmentElement::populateShadowRootIfNecessary): Deleted.

Remove logic for building the shadow root to house inline media elements.

  • html/HTMLAttachmentElement.h:

The renderer of the attachment element is once again always a RenderAttachment, so we can remove
attachmentRenderer() altogether and revert to overriding renderer() to return a RenderAttachment*.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • rendering/RenderAttachment.h:

(WebCore::HTMLAttachmentElement::renderer const):

Source/WebKit:

Remove attachment display mode from WebKit. Note that _WKAttachmentDisplayOptions needs to remain in the private
header for source compatibility with Mail.

  • UIProcess/API/Cocoa/_WKAttachment.mm:

(-[_WKAttachmentDisplayOptions coreDisplayOptions]): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAttachmentDisplayOptions):

Tools:

Remove API tests and API test helpers for verifying the behavior of in-place media attachment elements.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
(TestWebKitAPI::TEST):
(testVideoData): Deleted.
(displayOptionsWithMode): Deleted.
(-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]): Deleted.

LayoutTests:

Remove a layout test which verified that attachment elements with -webkit-appearance: none would render
child elements. This was only used to implement in-place attachment display modes.

  • fast/attachment/attachment-without-appearance-expected.html: Removed.
  • fast/attachment/attachment-without-appearance.html: Removed.
  • platform/gtk/TestExpectations:
7:13 AM Changeset in webkit [234884] by ajuma@chromium.org
  • 8 edits
    2 adds in trunk

[IntersectionObserver] Do not hold a strong reference to the root element
​https://bugs.webkit.org/show_bug.cgi?id=188575

Reviewed by Simon Fraser.

Source/WebCore:

Make IntersectionObserver have only a raw pointer to its root element rather than
a reference, so that an otherwise-unreachable root isn't kept alive. Add logic to
to clear this pointer when the root element gets deleted.

Test: intersection-observer/root-element-deleted.html

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::disconnectFromIntersectionObservers):
(WebCore::Element::ensureIntersectionObserverData):
(WebCore::Element::intersectionObserverData):

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::intersectionObserverData):
(WebCore::ElementRareData::setIntersectionObserverData):

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::create):
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::rootDestroyed):

  • page/IntersectionObserver.h:

(WebCore::IntersectionObserver::root const):

LayoutTests:

  • intersection-observer/root-element-deleted-expected.txt: Added.
  • intersection-observer/root-element-deleted.html: Added.

Aug 14, 2018:

11:15 PM Changeset in webkit [234883] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/Source/WebCore

[Nicosia] Add Nicosia::BackingStoreTextureMapperImpl
​https://bugs.webkit.org/show_bug.cgi?id=188548

Reviewed by Carlos Garcia Campos.

Add the Nicosia::BackingStoreTextureMapperImpl class, the
TextureMapper-specific implementation that will extend the BackingStore
class.

Purpose of this class is to manage content of painted layers. In the
LayerState object that will be exposed to the CoordinatedGraphicsLayer
owner we keep the current and previous TiledBackingStore objects that
will be used for painting. A TileUpdate object is used to store all tile
creation, removal and update changes that happen during the painting
that's performed during the CoordinatedGraphicsLayer flush.

At the point of synchronization under the Nicosia::Scene object, these
updates will be moved over to the pending TileUpdate object that will
then be accessed during the composition step. For that purpose we keep
in the CompositionState member object a reference to the
CoordinatedBackingStore object that will get updated with the tile
creation, removal and update changes (if there are any). The composition
step will use the takeUpdate() method to retrieve all these changes and
apply them outside of the point of synchronization (avoiding this sync
step to take too long).

This will be integrated into the CoordinatedGraphicsLayer class at a
later point, when the switch to the new infrastructure can be made in
one go.

  • platform/TextureMapper.cmake:
  • platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.cpp: Added.

(Nicosia::BackingStoreTextureMapperImpl::createFactory):
(Nicosia::BackingStoreTextureMapperImpl::tiledBackingStoreHasPendingTileCreation):
(Nicosia::BackingStoreTextureMapperImpl::createTile):
(Nicosia::BackingStoreTextureMapperImpl::updateTile):
(Nicosia::BackingStoreTextureMapperImpl::removeTile):
(Nicosia::BackingStoreTextureMapperImpl::flushUpdate):
(Nicosia::BackingStoreTextureMapperImpl::takeUpdate):

  • platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.h: Added.
11:10 PM Changeset in webkit [234882] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Table should not center rows when scrolling them into view
​https://bugs.webkit.org/show_bug.cgi?id=188593
<rdar://problem/43311660>

Reviewed by Devin Rousso.

  • UserInterface/Views/Table.js:

(WI.Table.prototype._handleKeyDown):

9:47 PM Changeset in webkit [234881] by Devin Rousso
  • 3 edits in trunk/Tools

Unreviewed, change my emails.

  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
9:46 PM Changeset in webkit [234880] by Fujii Hironori
  • 13 edits in trunk/Source

Unreviewed, rolling out r234874 and r234876.

WinCairo port can't compile

Reverted changesets:

"[JSC] Add GPRReg::InvalidGPRReg and FPRReg::InvalidFPRReg"
​https://bugs.webkit.org/show_bug.cgi?id=188589
​https://trac.webkit.org/changeset/234874

"Unreviewed, attempt to fix CLoop build"
​https://bugs.webkit.org/show_bug.cgi?id=188589
​https://trac.webkit.org/changeset/234876

9:08 PM Changeset in webkit [234879] by sbarati@apple.com
  • 7 edits in trunk

HashMap<Ref<P>, V> asserts when V is not zero for its empty value
​https://bugs.webkit.org/show_bug.cgi?id=188582

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/SparseArrayValueMap.h:

Source/WTF:

The issue happened when we'd fill the hash table buffer with empty values. We
would iterate the buffer and invoke placement new with the incoming value being the
empty value. For Ref, this means that, we'd call its move constructor, which calls
leakRef(), which asserts that the Ref's pointer is not null. We'd like to keep
this assert since it catches bugs where you leakRef() more than once or WTFMove
an already moved Ref.

This patch fixes this issue by adding a new trait for constructing an empty
value. We use that in HashTable instead of directly calling placement new.

  • wtf/HashTable.h:

(WTF::HashTableBucketInitializer<false>::initialize):

  • wtf/HashTraits.h:

(WTF::GenericHashTraits::constructEmptyValue):
(WTF::HashTraits<Ref<P>>::constructEmptyValue):
(WTF::KeyValuePairHashTraits::constructEmptyValue):

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

7:59 PM Changeset in webkit [234878] by Alan Bujtas
  • 10 edits
    2 adds in trunk

[LFC][Floating] Add support for negative clearance.
​https://bugs.webkit.org/show_bug.cgi?id=188555

Reviewed by Simon Fraser.

Source/WebCore:

  1. Compute clearance to avoid float(s) (border box needs to avoid floats)
  2. Reset vertical margins to non-collapsed values.
  3. Adjust clearance with the new margins.
  4. Take the adjusted clearance and move the box vertically if needed.

Test: fast/block/block-only/margin-collapse-with-clearance.html

  • layout/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

  • layout/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopLeftToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor):
(WebCore::Layout::FormattingContext::mapToAncestor): Deleted.

  • layout/FormattingContext.h:
  • layout/LayoutUnits.h:

(WebCore::Layout::Position::Position):
(WebCore::Layout::Position::moveBy):

  • layout/displaytree/DisplayBox.h:

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/block-only/margin-collapse-with-clearance-expected.txt: Added.
  • fast/block/block-only/margin-collapse-with-clearance.html: Added.
7:42 PM Changeset in webkit [234877] by Fujii Hironori
  • 7 edits in trunk/Source

Unreviewed, rolling out r234859.

Windows ports can't compile

Reverted changeset:

"Use a Variant instead of a union in CSSSelector"
​https://bugs.webkit.org/show_bug.cgi?id=188559
​https://trac.webkit.org/changeset/234859

6:18 PM Changeset in webkit [234876] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix CLoop build
​https://bugs.webkit.org/show_bug.cgi?id=188589

  • assembler/MacroAssembler.h:
5:55 PM Changeset in webkit [234875] by sihui_liu@apple.com
  • 4 edits
    1 add in trunk

Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
​https://bugs.webkit.org/show_bug.cgi?id=188576
<rdar://problem/43148977>

Reviewed by Alex Christensen.

Source/WebKit:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Added.

(TEST):

5:50 PM Changeset in webkit [234874] by yusukesuzuki@slowstart.org
  • 12 edits in trunk/Source

[JSC] Add GPRReg::InvalidGPRReg and FPRReg::InvalidFPRReg
​https://bugs.webkit.org/show_bug.cgi?id=188589

Reviewed by Mark Lam.

Source/JavaScriptCore:

Since GPRReg(RegisterID) and FPRReg(FPRegisterID) do not include -1 in their enum values,
UBSan dumps bunch of warnings "runtime error: load of value 4294967295, which is not a valid value for type 'RegisterID'".

  1. We add InvalidGPRReg and InvalidFPRReg to enum values of GPRReg and FPRReg to suppress the above warnings.
  2. We make GPRReg and FPRReg int8_t enums.
  3. We replace #define InvalidGPRReg ((JSC::GPRReg)-1) to static constexpr GPRReg InvalidGPRReg { GPRReg::InvalidGPRReg };.
  • assembler/ARM64Assembler.h:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/MIPSAssembler.h:
  • assembler/X86Assembler.h:
  • jit/FPRInfo.h:
  • jit/GPRInfo.h:

(JSC::JSValueRegs::JSValueRegs):
(JSC::JSValueRegs::tagGPR const):
(JSC::JSValueRegs::payloadGPR const):
(JSC::JSValueSource::JSValueSource):
(JSC::JSValueSource::unboxedCell):
(JSC::JSValueSource::operator bool const):
(JSC::JSValueSource::base const):
(JSC::JSValueSource::tagGPR const):
(JSC::JSValueSource::payloadGPR const):
(JSC::JSValueSource::hasKnownTag const):

Source/WebCore:

No behavior change.

  • cssjit/FunctionCall.h:

(WebCore::FunctionCall::FunctionCall):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):

5:30 PM Changeset in webkit [234873] by achristensen@apple.com
  • 15 edits in trunk

isValidCSSSelector is unsafe to be called from a non-main thread
​https://bugs.webkit.org/show_bug.cgi?id=188581
<rdar://problem/40517358>

Reviewed by Sam Weinig.

Source/WebCore:

Parsing and determining whether the css selectors are valid is fast enough to do before
hopping to the background thread for the slow NFA/DFA operations and writing to disk.
Doing it on the main thread avoids the thread safety issues in the CSSParser's use of strings.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/ContentExtensionCompiler.h:
  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::isValidCSSSelector):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):

  • contentextensions/ContentExtensionParser.h:
  • contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::Trigger::isolatedCopy const):
(WebCore::ContentExtensions::Action::isolatedCopy const):

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::isEmpty const):
(WebCore::ContentExtensions::Trigger::operator== const):
(WebCore::ContentExtensions::Action::Action):
(WebCore::ContentExtensions::ContentExtensionRule::isolatedCopy const):
(WebCore::ContentExtensions::ContentExtensionRule::operator== const):
(WebCore::ContentExtensions::vectorIsolatedCopy):

Source/WebKit:

  • UIProcess/API/APIContentRuleListStore.cpp:

(API::compiledToFile):
(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
(API::ContentRuleListStore::compileContentRuleList):
(API::ContentRuleListStore::removeContentRuleList):
(API::ContentRuleListStore::getContentRuleListSource):

  • UIProcess/API/APIContentRuleListStore.h:
  • UIProcess/API/Cocoa/WKContentRuleListStore.mm:

Source/WTF:

  • wtf/Vector.h:

(WTF::minCapacity>::isolatedCopy):

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::InMemoryCompiledContentExtension::create):
(TestWebKitAPI::checkCompilerError):

5:13 PM Changeset in webkit [234872] by Ryan Haddad
  • 2 edits in branches/safari-606-branch/LayoutTests

Cherry-pick r234869. rdar://problem/42387347

Unreviewed test gardening for mac-wk1.

  • platform/mac-wk1/TestExpectations:
5:11 PM Changeset in webkit [234871] by Ryan Haddad
  • 2 edits in branches/safari-606.1.36.1-branch/LayoutTests

Cherry-pick r234869. rdar://problem/42387347

Unreviewed test gardening for mac-wk1.

  • platform/mac-wk1/TestExpectations:
5:10 PM Changeset in webkit [234870] by commit-queue@webkit.org
  • 36 edits
    4 adds in trunk

NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
​https://bugs.webkit.org/show_bug.cgi?id=186870
Source/WebCore:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-14
Reviewed by Alex Christensen.

Add the ProtectionSpaceAuthenticationSchemeOAuth type.

  • platform/network/ProtectionSpaceBase.cpp:

(WebCore::ProtectionSpaceBase::isPasswordBased const): Return yes because the oauth challenge
expects a token in return.

  • platform/network/ProtectionSpaceBase.h:
  • platform/network/cocoa/ProtectionSpaceCocoa.mm:

(WebCore::scheme):
(WebCore::ProtectionSpace::nsSpace const):

Source/WebCore/PAL:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-14
Reviewed by Alex Christensen.

  • pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the

internal SDK.

Source/WebKit:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-14
Reviewed by Alex Christensen.

Correctly expose the OAuth protection space type in API.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):

  • UIProcess/API/C/WKProtectionSpaceTypes.h:

Tools:

<rdar://problem/41314410>

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-14
Reviewed by Alex Christensen.

  • WebKitTestRunner/TestController.cpp:

(WTR::toString):
(WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
(WTR::TestController::didReceiveAuthenticationChallenge):

LayoutTests:

Patch by Ansh Shukla <​ansh_shukla@apple.com> on 2018-08-14
Reviewed by Alex Christensen.

Ensure the exposed authentication type to clients is OAuth.

  • http/tests/loading/oauth-expected.txt: Added.
  • http/tests/loading/oauth.html: Added.
  • http/tests/loading/resources/oauth-subresource.php: Added.
4:56 PM Changeset in webkit [234869] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening for mac-wk1.

  • platform/mac-wk1/TestExpectations:
4:56 PM Changeset in webkit [234868] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark legacy-animation-engine/animations/combo-transform-translate+scale.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=185308

Unreviewed test gardening.

4:34 PM Changeset in webkit [234867] by Basuke Suzuki
  • 1 edit
    1 add in trunk/LayoutTests

[Curl] Test gardening
​https://bugs.webkit.org/show_bug.cgi?id=188587

Unreviewed test gardening.

Added platform dependent expected result.

  • platform/wincairo/http/tests/xmlhttprequest/methods-expected.txt: Added.
4:26 PM Changeset in webkit [234866] by rniwa@webkit.org
  • 1 edit
    1 copy
    1 add in trunk/Websites/browserbench.org

Add MotionMark 1.1 to browserbench
​https://bugs.webkit.org/show_bug.cgi?id=188585
<rdar://problem/43308076>

Patch by Jon Lee <​jonlee@apple.com> on 2018-08-14
Rubber-stamped by Ryosuke Niwa.

  • MotionMark1.1/: Added.
4:22 PM Changeset in webkit [234865] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Remove api misuse check so that custom webcontent service identifier can be set at runtime
​https://bugs.webkit.org/show_bug.cgi?id=188579

Patch by Ben Richards <​benton_richards@apple.com> on 2018-08-14
Reviewed by Ryosuke Niwa.

Changed API misuse check so that a custom bundle identifier can be set at runtime with a debug flag

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

4:17 PM Changeset in webkit [234864] by Basuke Suzuki
  • 7 edits in trunk

[Curl] Implement platform default timeout interval.
​https://bugs.webkit.org/show_bug.cgi?id=188565

Reviewed by Alex Christensen.

Source/WebCore:

Curl port didn't implement platform default timeout interval. It treated
zero value for timeout interval as no timeout.

Add platform dependent timeout interval into CurlContext and use that if
timeout and default timeout aren't supplied.

Tests: http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html

  • platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::setTimeout):

  • platform/network/curl/CurlContext.h:

(WebCore::CurlContext::defaultTimeoutInterval const):

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::timeoutInterval const):
(WebCore::CurlRequest::didCompleteTransfer):

  • platform/network/curl/CurlRequest.h:

LayoutTests:

  • platform/wincairo/TestExpectations:
    • xmlhttprequest/on-network-timeout-error-during-preflight.html
3:43 PM Changeset in webkit [234863] by Ross Kirsling
  • 5 edits in trunk/Tools

[webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
​https://bugs.webkit.org/show_bug.cgi?id=187973

Patch by Fujii Hironori <Fujii Hironori> on 2018-08-14
Reviewed by Alex Christensen.

In LayoutTests, test names have been canonicalized in Unix style
since Bug 63597, for example 'fast/css/001.html'. But Bug 179219,
Bug 179572, Bug 180660, and Bug 181814 have changed to use
os.path.seq instead of slash if Windows Python is used.

Revert parts of those changes. Change relative_test_filename to
return a slash-separated test name as chromium_win.py used to do.

This change fixes all 41 test-webkitpy failures in WinCairo port.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_line): Do not convert test names with normpath.

  • Scripts/webkitpy/port/base.py:

(Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
(Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
(Port.abspath_for_test): Replace self.TEST_PATH_SEPARATOR with self.host.filesystem.sep.

  • Scripts/webkitpy/port/driver.py:

(Driver): Use '/' instead of os.sep.

  • Scripts/webkitpy/port/win.py:

(WinCairoPort): Do not override TEST_PATH_SEPARATOR.

2:15 PM Changeset in webkit [234862] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=188578

Unreviewed test gardening.

  • platform/ios/TestExpectations:
1:13 PM Changeset in webkit [234861] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews-build] Add build step to run WK1 layout-test
​https://bugs.webkit.org/show_bug.cgi?id=188498

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(RunWebKit1Tests): Class to run WebKit1Tests.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
12:04 PM Changeset in webkit [234860] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak] Fix --cmakeargs
​https://bugs.webkit.org/show_bug.cgi?id=188567

Patch by Patrick Griffis <Patrick Griffis> on 2018-08-14
Reviewed by Michael Catanzaro.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.setup_dev_env):

11:24 AM Changeset in webkit [234859] by achristensen@apple.com
  • 7 edits in trunk/Source

Use a Variant instead of a union in CSSSelector
​https://bugs.webkit.org/show_bug.cgi?id=188559

Reviewed by Antti Koivisto.

Source/WebCore:

No change in behavior. This just makes some of the existing problems more obvious and easy to fix.

I moved m_caseInsensitiveAttributeValueMatching to RareData because it's only used with RareData.
I only have m_isForPage when assertions are enabled because it's only used for an assertion.
The rest is pretty straightforward translating union syntax to Variant syntax.
I use RefPtr for now where I could use Ref because it's never null to make copying easier, but that's temporary.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setAttribute):
(WebCore::CSSSelector::setArgument):
(WebCore::CSSSelector::setLangArgumentList):
(WebCore::CSSSelector::setSelectorList):
(WebCore::CSSSelector::setNth):
(WebCore::CSSSelector::matchNth const):
(WebCore::CSSSelector::nthA const):
(WebCore::CSSSelector::nthB const):
(WebCore::CSSSelector::RareData::RareData):

  • css/CSSSelector.h:

(WebCore::CSSSelector::argument const):
(WebCore::CSSSelector::langArgumentList const):
(WebCore::CSSSelector::selectorList const):
(WebCore::CSSSelector::attribute const):
(WebCore::CSSSelector::attributeCanonicalLocalName const):
(WebCore::CSSSelector::setValue):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName const):
(WebCore::CSSSelector::tagLowercaseLocalName const):
(WebCore::CSSSelector::value const):
(WebCore::CSSSelector::serializingValue const):
(WebCore::CSSSelector::attributeValueMatchingIsCaseInsensitive const):
(WebCore::CSSSelector::RareData::create): Deleted.

  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parsePageSelector):

  • css/parser/CSSParserSelector.h:

Source/WTF:

  • wtf/Variant.h:

Add packing macros to make it so Variant-containing structures don't always have 7 bytes of padding per Variant.

10:59 AM Changeset in webkit [234858] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add missing availability macro.
​https://bugs.webkit.org/show_bug.cgi?id=188563

Reviewed by Mark Lam.

  • API/JSValueRef.h:
10:56 AM Changeset in webkit [234857] by yusukesuzuki@slowstart.org
  • 9 edits in trunk

Unhandled Promise Rejection logging in workers should not emit ErrorEvent to host Worker object
​https://bugs.webkit.org/show_bug.cgi?id=188551

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.worker-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.dedicatedworker-expected.txt:

Source/WebCore:

Previously we dispatched ErrorEvent on the Worker object of the host side when the unhandled promise
rejection happens in the worker. But that was wrong. We should not dispatch such an event and we
should just log the error message.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::reportUnhandledPromiseRejection):

LayoutTests:

  • http/wpt/workers/promise-unhandled-rejection.any.worker-expected.txt:
  • js/dom/unhandled-promise-rejection-bindings-type-error-in-workers-expected.txt:
10:54 AM Changeset in webkit [234856] by commit-queue@webkit.org
  • 11 edits in trunk/Tools

Enhancement request: Make export-w3c-test-changes add the PR to "See Also" links
​https://bugs.webkit.org/show_bug.cgi?id=186140

Patch by Darshan Kadu <​dkadu@igalia.com> on 2018-08-14
Reviewed by Youenn Fablet.

Added an optional parameter see_also to post_comment_to_bug function and used it for adding see_also variable's content in "See Also"

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.post_comment_to_bug):
Modified mock for see_also parameter

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.post_comment_to_bug):
Made following unit tests to have see_also in bug comment

  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:

(SheriffTest.test_post_blame_comment_on_bug):

  • Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
  • Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter.make_pull_request):

  • Scripts/webkitpy/w3c/test_exporter_unittest.py:

(TestExporterTest.MockBugzilla.post_comment_to_bug):
(TestExporterTest.test_export):

10:46 AM Changeset in webkit [234855] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
​https://bugs.webkit.org/show_bug.cgi?id=188560

Reviewed by Keith Miller.

While GetByIdStatus() / GetByIdStatus(status) constructors do not set m_wasSeenInJIT,
it is loaded unconditionally in GetByIdStatus::slowVersion. This access to the
uninitialized member field is caught in UBSan. This patch fixes it by adding an initializer
m_wasSeenInJIT { false }.

  • bytecode/GetByIdStatus.h:
10:45 AM Changeset in webkit [234854] by yusukesuzuki@slowstart.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, follow-up patch for comments
​https://bugs.webkit.org/show_bug.cgi?id=188265

  • bindings/js/JSExecState.cpp:

(WebCore::JSExecState::didLeaveScriptContext):
Do nothing if context is nullptr. It is OK since we do not need to drain microtasks / rejected
promise events after ScriptExecutionContext is gone.

  • dom/Microtasks.cpp:

(WebCore::MicrotaskQueue::contextQueue):
Drop unnecessary assertion since it is subsumed by downcast<>.

10:23 AM Changeset in webkit [234853] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

[DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
​https://bugs.webkit.org/show_bug.cgi?id=188557

Reviewed by Mark Lam.

DFGPredictionPropagationPhase should set PrimaryPass before processing invariants since
processing for ArithRound etc.'s invariants requires m_pass load. This issue is found
in UBSan's result.

  • dfg/DFGPredictionPropagationPhase.cpp:
10:16 AM Changeset in webkit [234852] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Should not rotate constant with 64
​https://bugs.webkit.org/show_bug.cgi?id=188556

Reviewed by Mark Lam.

To defend against JIT splaying, we rotate a constant with a randomly generated seed.
But if a seed becomes 64, the following code performs value << 64 where value's type
is uint64_t, and it causes undefined behaviors (UBs). This patch limits the seed in the
range of [0, 64) not to generate code causing UBs. This is found by UBSan.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::generateRotationSeed):
(JSC::MacroAssembler::rotationBlindConstant):

10:12 AM Changeset in webkit [234851] by ajuma@chromium.org
  • 2 edits in trunk/Source/WebCore

Follow-up: [IntersectionObserver] Implement rootMargin parsing
​https://bugs.webkit.org/show_bug.cgi?id=188469

Address review feedback from Darin Adler.

  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::rootMargin const):
Use StringBuilder::appendLiteral instead of ::append to append a literal.

9:53 AM Changeset in webkit [234850] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Add support for max_builds parameter for workers
​https://bugs.webkit.org/show_bug.cgi?id=188531

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig): Added support for max_builds.

9:48 AM Changeset in webkit [234849] by Antti Koivisto
  • 6 edits in trunk/Source/WebKit

RemoteLayerTreeTransaction should use OptionSet for change flags
​https://bugs.webkit.org/show_bug.cgi?id=188547

Reviewed by Simon Fraser.

  • Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::resetChangedProperties):

Also remove unused everChangedProperties.

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

8:15 AM Changeset in webkit [234848] by graouts@webkit.org
  • 3 edits
    2 adds in trunk

[Web Animations] Crash under AnimationTimeline::cancelOrRemoveDeclarativeAnimation()
​https://bugs.webkit.org/show_bug.cgi?id=188519
<rdar://problem/43237889>

Reviewed by Eric Carlson.

Source/WebCore:

Test: webanimations/css-animation-effect-target-change-and-animation-removal-crash.html

We would crash because we blindly assumed an animation that was found in the previous style must be in the list of running animations
but in fact it could have been removed already due to the element being removed from the DOM or its effect target changing, etc. So when
we iterate over names of animations that were found in the previous style but not in the new style, we must make a null check to ensure
that there is an animation to remove. Adding an ASSERT() in AnimationTimeline::cancelOrRemoveDeclarativeAnimation() will also clarify the
expectation here.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSAnimationsForElement):
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation):

LayoutTests:

Add a test where we clone the effect to be mutable and set a new target. At this stage the animation is no longer listed in the
m_elementToCSSAnimationByName map on AnimationTimeline. Then we remove the animation and force a style recalc for this element,
"anim" will be in the old style but not in the new style and we used to attempt to get an animation matching that name from
m_elementToCSSAnimationByName but it would be null, which would lead to a crash. Now we check that we indeed have such an animation
before proceeding.

  • webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html: Added.
  • webanimations/css-animation-effect-target-change-and-animation-removal-crash.html: Added.
7:22 AM Changeset in webkit [234847] by Alan Bujtas
  • 6 edits
    2 adds in trunk

Source/WebCore:
[LFC][Floating] Adjust vertical position with non-collapsed previous sibling margin.
​https://bugs.webkit.org/show_bug.cgi?id=188543

Reviewed by Antti Koivisto.

This patch ensures that the inital vertical position for a float is adjusted with the non-collapsed sibling margin.

<div id=A style="margin-bottom: 20px;"></div>
<div id=B style='float: left'></div>
<div id=C style="margin-top: 10px;"></div>

While computing the static position for element "B", we simply call marginBottom() on A.
In the case above, A's margin bottom is collapsed with C's margin top and the value is 0 (C.marginTop() is 20px).
However CSS spec says that in block formatting context, the non-collapsed margin should be used instead to offset the float box.
(The reason why this should not be part of the BlockMarginCollapse::marginBottom() logic is because it can not differentiate the context of
sibling float/sibling inflow. When we margin collapse, we always do it in the context of inflow boxes.)

Test: fast/block/block-only/float-and-siblings-with-margins.html

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):

  • layout/blockformatting/BlockFormattingContext.h:

Tools:
[LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
​https://bugs.webkit.org/show_bug.cgi?id=188543

Reviewed by Antti Koivisto.

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:
[LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
​https://bugs.webkit.org/show_bug.cgi?id=188543

Reviewed by Antti Koivisto.

  • fast/block/block-only/float-and-siblings-with-margins-expected.txt: Added.
  • fast/block/block-only/float-and-siblings-with-margins.html: Added.
6:04 AM Changeset in webkit [234846] by yusukesuzuki@slowstart.org
  • 30 edits
    24 adds in trunk

Worker should support unhandled promise rejections
​https://bugs.webkit.org/show_bug.cgi?id=188265

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_keys.https.worker-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/workers/interfaces.worker-expected.txt:
  • web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:

Source/WebCore:

This patch adds PromiseRejectionEvent support in workers.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::promiseRejectionTracker):
Move promiseRejectionTracker handler from JSDOMWindowBase to JSDOMGlobalObject
to share it with WorkerGlobalScope.

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::promiseRejectionTracker): Deleted.
Moved to JSDOMGlobalObject.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSExecState.cpp:

(WebCore::JSExecState::didLeaveScriptContext):
PromiseRejectionTracker is driven in workers too.

  • bindings/js/JSPromiseRejectionEventCustom.cpp: Added.

(WebCore::JSPromiseRejectionEvent::visitAdditionalChildren):
Marking PromiseRejectionEvent::m_reason.

  • bindings/js/JSWorkerGlobalScopeBase.cpp:

Configure promiseRejectionTracker.

  • dom/Microtasks.cpp:

(WebCore::MicrotaskQueue::contextQueue):

  • dom/Microtasks.h:
  • dom/PromiseRejectionEvent.cpp:

(WebCore::PromiseRejectionEvent::PromiseRejectionEvent):

  • dom/PromiseRejectionEvent.h:
  • dom/PromiseRejectionEvent.idl:

Expose it to worker scope. The custom mark function is required since we start
using JSValueInWrappedObject. And the constructor no longer requires ExecState.

  • dom/RejectedPromiseTracker.cpp:

(WebCore::RejectedPromiseTracker::reportUnhandledRejections):
(WebCore::RejectedPromiseTracker::reportRejectionHandled):
Remove state argument for PromiseRejectionEvent::create.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::removeRejectedPromiseTracker):

  • dom/ScriptExecutionContext.h:

In worker thread, we should delete PromiseRejectionTracker before destroying VM
because PromiseRejectionTracker's destruction requires VM. If we destroy VM first,
PromiseRejectionTracker's destruction causes crashing. In main thread, we do not
need to handle this case since we never destroy VM.

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::prepareForTermination):
(WebCore::WorkerGlobalScope::removeMicrotaskQueue): Deleted.

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScope.idl:

Add onunhandledrejection and onrejectionhandled event handler attributes.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):
We call WorkerGlobalScope::prepareForTermination, which cleans up Worker's objects touching VM.

LayoutTests:

  • fast/dom/reference-cycle-leaks-expected.txt:
  • http/wpt/workers/promise-unhandled-rejection.any-expected.txt: Added.
  • http/wpt/workers/promise-unhandled-rejection.any.html: Added.
  • http/wpt/workers/promise-unhandled-rejection.any.js: Added.

(promise_test):

  • http/wpt/workers/promise-unhandled-rejection.any.worker-expected.txt: Added.
  • http/wpt/workers/promise-unhandled-rejection.any.worker.html: Added.
  • js/dom/unhandled-promise-rejection-basic-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-basic-in-workers.html: Added.
  • js/dom/unhandled-promise-rejection-bindings-type-error-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-bindings-type-error-in-workers.html: Added.
  • js/dom/unhandled-promise-rejection-handle-during-event-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-handle-during-event-in-workers.html: Added.
  • js/dom/unhandled-promise-rejection-handle-in-handler-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-handle-in-handler-in-workers.html: Added.
  • js/dom/unhandled-promise-rejection-handle-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-handle-in-workers.html: Added.
  • js/dom/unhandled-promise-rejection-order-in-workers-expected.txt: Added.
  • js/dom/unhandled-promise-rejection-order-in-workers.html: Added.
  • js/resources/unhandled-promise-rejection-basic-in-workers.js: Added.

(global.onunhandledrejection):

  • js/resources/unhandled-promise-rejection-bindings-type-error-in-workers.js: Added.

(global.onunhandledrejection):
(catch):
(setTimeout):

  • js/resources/unhandled-promise-rejection-handle-during-event-in-workers.js: Added.

(global.onunhandledrejection):

  • js/resources/unhandled-promise-rejection-handle-in-handler-in-workers.js: Added.

(global.onunhandledrejection):
(global.onrejectionhandled):

  • js/resources/unhandled-promise-rejection-handle-in-workers.js: Added.

(global.onunhandledrejection):
(global.onrejectionhandled):

  • js/resources/unhandled-promise-rejection-order-in-workers.js: Added.

(global.onunhandledrejection):

5:41 AM Changeset in webkit [234845] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix WebDriver tests after r234839.

New pytest requires to autoinstall more_itertools and six too.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pytest):

5:40 AM Changeset in webkit [234844] by tpopela@redhat.com
  • 2 edits in trunk/Tools

[GTK] Minibrowser: Add labels for buttons
​https://bugs.webkit.org/show_bug.cgi?id=188549

Reviewed by Carlos Garcia Campos.

So they are accessible easier (i.e. while testing WebKitGTK+ through Minibrowser in Dogtail).

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewIsLoadingChanged):
(browserWindowSetupEditorToolbar):
(browser_window_init):

4:26 AM Changeset in webkit [234843] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix WebDriver tests after r234839.

New pytest requires to autoinstall atomicwrites too.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pytest):

2:57 AM Changeset in webkit [234842] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix WebDriver tests after r234839.

New pytest requires to autoinstall pluggy and funcsigs too.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pytest):

2:04 AM Changeset in webkit [234841] by Carlos Garcia Campos
  • 2 edits in trunk/WebDriverTests

Unreviewed gardening. Update several test expectations after r234839.

1:29 AM Changeset in webkit [234840] by commit-queue@webkit.org
  • 6 edits in trunk

Fetch: content-length header is being added to the safe-list
​https://bugs.webkit.org/show_bug.cgi?id=185473

Patch by Rob Buis <​rbuis@igalia.com> on 2018-08-14
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Sync with wpt change:
​https://github.com/web-platform-tests/wpt/commit/407ecdff87af8aeceaa07cbc71aac9ec355d4334

  • web-platform-tests/fetch/api/cors/cors-filtering-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-filtering-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-filtering.js:

Source/WebCore:

Content-Length is a CORS-safelisted reponse header:
​https://fetch.spec.whatwg.org/#cors-safelisted-response-header-name

Tests: web-platform-tests/fetch/api/cors/cors-filtering.html

web-platform-tests/fetch/api/cors/cors-filtering-worker.html

  • platform/network/HTTPParsers.cpp:

(WebCore::isCrossOriginSafeHeader):

12:08 AM Changeset in webkit [234839] by Carlos Garcia Campos
  • 145 edits
    9 copies
    47 adds
    2 deletes in trunk

Unreviewed. Update W3C WebDriver imported tests.

Tools:

Bump pytest version to 3.6.2.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pytest):

WebDriverTests:

  • imported/w3c/importer.json:
  • imported/w3c/tools/webdriver/README.md:
  • imported/w3c/tools/webdriver/webdriver/init.py:
  • imported/w3c/tools/webdriver/webdriver/client.py:
  • imported/w3c/tools/webdriver/webdriver/error.py:
  • imported/w3c/tools/webdriver/webdriver/protocol.py:
  • imported/w3c/tools/webdriver/webdriver/transport.py:
  • imported/w3c/tools/wptrunner/README.rst:
  • imported/w3c/tools/wptrunner/docs/conf.py:
  • imported/w3c/tools/wptrunner/docs/usage.rst:
  • imported/w3c/tools/wptrunner/requirements.txt:
  • imported/w3c/tools/wptrunner/requirements_chrome.txt:
  • imported/w3c/tools/wptrunner/requirements_chrome_android.txt:
  • imported/w3c/tools/wptrunner/requirements_edge.txt:
  • imported/w3c/tools/wptrunner/requirements_firefox.txt:
  • imported/w3c/tools/wptrunner/requirements_ie.txt:
  • imported/w3c/tools/wptrunner/requirements_opera.txt:
  • imported/w3c/tools/wptrunner/requirements_safari.txt:
  • imported/w3c/tools/wptrunner/requirements_sauce.txt:
  • imported/w3c/tools/wptrunner/tox.ini:
  • imported/w3c/tools/wptrunner/wptrunner.default.ini:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/init.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/base.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/chrome.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/chrome_android.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/edge.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/fennec.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/ie.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/opera.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/safari.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/sauce.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/sauce_setup/edge-prerun.bat:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/sauce_setup/safari-prerun.sh:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/servodriver.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/webkit.py:
  • imported/w3c/tools/wptrunner/wptrunner/environment.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/init.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executorsafari.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executorservodriver.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/protocol.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/init.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/reftest-wait_marionette.js:
  • imported/w3c/tools/wptrunner/wptrunner/executors/testharness_webdriver.js:
  • imported/w3c/tools/wptrunner/wptrunner/font.py:
  • imported/w3c/tools/wptrunner/wptrunner/formatters.py:
  • imported/w3c/tools/wptrunner/wptrunner/manifestexpected.py:
  • imported/w3c/tools/wptrunner/wptrunner/manifestupdate.py:
  • imported/w3c/tools/wptrunner/wptrunner/metadata.py:
  • imported/w3c/tools/wptrunner/wptrunner/products.py:
  • imported/w3c/tools/wptrunner/wptrunner/stability.py:
  • imported/w3c/tools/wptrunner/wptrunner/testloader.py:
  • imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/browsers/test_sauce.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_chunker.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_formatters.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_products.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_stability.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_update.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_wpttest.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/update/init.py:
  • imported/w3c/tools/wptrunner/wptrunner/update/metadata.py:
  • imported/w3c/tools/wptrunner/wptrunner/update/sync.py:
  • imported/w3c/tools/wptrunner/wptrunner/update/tree.py:
  • imported/w3c/tools/wptrunner/wptrunner/update/update.py:
  • imported/w3c/tools/wptrunner/wptrunner/vcs.py:
  • imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptlogging.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/init.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/backends/conditional.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/parser.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/serializer.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/tests/test_conditional.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/tests/test_serializer.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptmanifest/tests/test_static.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
  • imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
  • imported/w3c/webdriver/META.yml: Added.
  • imported/w3c/webdriver/OWNERS: Removed.
  • imported/w3c/webdriver/tests/accept_alert/accept.py:
  • imported/w3c/webdriver/tests/actions/control_click.py: Added.
  • imported/w3c/webdriver/tests/actions/key.py:
  • imported/w3c/webdriver/tests/actions/modifier_click.py:
  • imported/w3c/webdriver/tests/actions/mouse.py:
  • imported/w3c/webdriver/tests/actions/support/keys.py:
  • imported/w3c/webdriver/tests/add_cookie/add.py:
  • imported/w3c/webdriver/tests/back/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/back/back.py: Added.
  • imported/w3c/webdriver/tests/back/conftest.py: Added.
  • imported/w3c/webdriver/tests/close_window/close.py:
  • imported/w3c/webdriver/tests/close_window/user_prompts.py:
  • imported/w3c/webdriver/tests/conftest.py:
  • imported/w3c/webdriver/tests/delete_all_cookies/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/delete_all_cookies/delete.py: Added.
  • imported/w3c/webdriver/tests/delete_cookie/delete.py:
  • imported/w3c/webdriver/tests/delete_cookie/user_prompts.py:
  • imported/w3c/webdriver/tests/delete_session/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/delete_session/delete.py: Added.
  • imported/w3c/webdriver/tests/dismiss_alert/dismiss.py:
  • imported/w3c/webdriver/tests/element_clear/clear.py:
  • imported/w3c/webdriver/tests/element_click/click.py: Added.
  • imported/w3c/webdriver/tests/element_click/file_upload.py: Added.
  • imported/w3c/webdriver/tests/element_click/interactability.py: Added.
  • imported/w3c/webdriver/tests/element_click/navigate.py: Added.
  • imported/w3c/webdriver/tests/element_click/scroll_into_view.py: Added.
  • imported/w3c/webdriver/tests/element_click/support/close_window.html: Added.
  • imported/w3c/webdriver/tests/element_click/support/input.html: Added.
  • imported/w3c/webdriver/tests/element_send_keys/init.py:
  • imported/w3c/webdriver/tests/element_send_keys/conftest.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/events.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/file_upload.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/form_controls.py:
  • imported/w3c/webdriver/tests/element_send_keys/send_keys.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/execute_async_script/collections.py:
  • imported/w3c/webdriver/tests/execute_async_script/execute_async.py: Added.
  • imported/w3c/webdriver/tests/execute_async_script/user_prompts.py:
  • imported/w3c/webdriver/tests/execute_script/cyclic.py:
  • imported/w3c/webdriver/tests/execute_script/execute.py: Added.
  • imported/w3c/webdriver/tests/execute_script/user_prompts.py:
  • imported/w3c/webdriver/tests/find_element/find.py:
  • imported/w3c/webdriver/tests/find_element_from_element/find.py:
  • imported/w3c/webdriver/tests/find_elements/find.py:
  • imported/w3c/webdriver/tests/find_elements_from_element/find.py:
  • imported/w3c/webdriver/tests/forward/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/forward/conftest.py: Added.
  • imported/w3c/webdriver/tests/forward/forward.py: Added.
  • imported/w3c/webdriver/tests/forward/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/fullscreen_window/fullscreen.py:
  • imported/w3c/webdriver/tests/fullscreen_window/user_prompts.py:
  • imported/w3c/webdriver/tests/get_active_element/get.py:
  • imported/w3c/webdriver/tests/get_alert_text/get.py:
  • imported/w3c/webdriver/tests/get_current_url/get.py:
  • imported/w3c/webdriver/tests/get_current_url/user_prompts.py:
  • imported/w3c/webdriver/tests/get_element_attribute/get.py:
  • imported/w3c/webdriver/tests/get_element_property/get.py:
  • imported/w3c/webdriver/tests/get_element_property/user_prompts.py:
  • imported/w3c/webdriver/tests/get_element_tag_name/get.py:
  • imported/w3c/webdriver/tests/get_element_tag_name/user_prompts.py:
  • imported/w3c/webdriver/tests/get_element_text/get.py:
  • imported/w3c/webdriver/tests/get_named_cookie/get.py:
  • imported/w3c/webdriver/tests/get_timeouts/get.py:
  • imported/w3c/webdriver/tests/get_title/get.py:
  • imported/w3c/webdriver/tests/get_title/user_prompts.py:
  • imported/w3c/webdriver/tests/get_window_rect/get.py:
  • imported/w3c/webdriver/tests/get_window_rect/user_prompts.py:
  • imported/w3c/webdriver/tests/interface.html:
  • imported/w3c/webdriver/tests/is_element_selected/selected.py:
  • imported/w3c/webdriver/tests/is_element_selected/user_prompts.py:
  • imported/w3c/webdriver/tests/maximize_window/maximize.py:
  • imported/w3c/webdriver/tests/maximize_window/user_prompts.py:
  • imported/w3c/webdriver/tests/minimize_window/minimize.py:
  • imported/w3c/webdriver/tests/minimize_window/user_prompts.py:
  • imported/w3c/webdriver/tests/navigate_to/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/navigate_to/navigate.py: Added.
  • imported/w3c/webdriver/tests/new_session/conftest.py:
  • imported/w3c/webdriver/tests/new_session/create_alwaysMatch.py:
  • imported/w3c/webdriver/tests/new_session/create_firstMatch.py:
  • imported/w3c/webdriver/tests/new_session/default_values.py:
  • imported/w3c/webdriver/tests/new_session/invalid_capabilities.py:
  • imported/w3c/webdriver/tests/new_session/merge.py:
  • imported/w3c/webdriver/tests/new_session/page_load_strategy.py: Added.
  • imported/w3c/webdriver/tests/new_session/platform_name.py: Added.
  • imported/w3c/webdriver/tests/new_session/response.py:
  • imported/w3c/webdriver/tests/new_session/timeouts.py: Added.
  • imported/w3c/webdriver/tests/page_source/source.py:
  • imported/w3c/webdriver/tests/refresh/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/refresh/refresh.py: Added.
  • imported/w3c/webdriver/tests/refresh/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/send_alert_text/send.py:
  • imported/w3c/webdriver/tests/set_timeouts/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/set_timeouts/set.py: Added.
  • imported/w3c/webdriver/tests/set_window_rect/resizing_and_positioning.py: Removed.
  • imported/w3c/webdriver/tests/set_window_rect/set.py:
  • imported/w3c/webdriver/tests/set_window_rect/user_prompts.py:
  • imported/w3c/webdriver/tests/status/status.py:
  • imported/w3c/webdriver/tests/support/init.py:
  • imported/w3c/webdriver/tests/support/asserts.py:
  • imported/w3c/webdriver/tests/support/fixtures.py:
  • imported/w3c/webdriver/tests/switch_to_frame/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/switch_to_frame/switch.py: Added.
  • imported/w3c/webdriver/tests/switch_to_parent_frame/switch.py:
  • imported/w3c/webdriver/tests/switch_to_window/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/init.py.
  • imported/w3c/webdriver/tests/switch_to_window/switch.py: Added.
Note: See TracTimeline for information about the timeline view.