Timeline

Aug 18, 2018:

8:28 PM Changeset in webkit [235015] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

Let Xcode have its way with the WebCore project

• WebCore.xcodeproj/project.pbxproj:
• Let Xcode sort recently added resources by unique ID.
• Manually change the mainGroup name from "WebKit" to "WebCore". There's no need to do this other than to make the inside of the proverbial cabinet match the outside. It's been this way since the project file was committed in r9857.

4:45 PM Changeset in webkit [235014] by ajuma@chromium.org

• 37 edits
  2 adds in trunk

[IntersectionObserver] Fire an initial dummy notification
​https://bugs.webkit.org/show_bug.cgi?id=188670

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline tests now that an initial notification is fired.

• web-platform-tests/intersection-observer/bounding-box-expected.txt:
• web-platform-tests/intersection-observer/client-rect-expected.txt:
• web-platform-tests/intersection-observer/containing-block-expected.txt:
• web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt:
• web-platform-tests/intersection-observer/disconnect-expected.txt:
• web-platform-tests/intersection-observer/display-none-expected.txt:
• web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt:
• web-platform-tests/intersection-observer/iframe-no-root-expected.txt:
• web-platform-tests/intersection-observer/inline-client-rect-expected.txt:
• web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt:
• web-platform-tests/intersection-observer/multiple-targets-expected.txt:
• web-platform-tests/intersection-observer/multiple-thresholds-expected.txt:
• web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt:
• web-platform-tests/intersection-observer/remove-element-expected.txt:
• web-platform-tests/intersection-observer/root-margin-expected.txt:
• web-platform-tests/intersection-observer/same-document-no-root-expected.txt:
• web-platform-tests/intersection-observer/same-document-root-expected.txt:
• web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt:
• web-platform-tests/intersection-observer/shadow-content-expected.txt:
• web-platform-tests/intersection-observer/text-target-expected.txt:
• web-platform-tests/intersection-observer/timestamp-expected.txt:
• web-platform-tests/intersection-observer/unclipped-root-expected.txt:
• web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt:
• web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt:

Source/WebCore:

Add logic to track ongoing intersection observations. Create an IntersectionObserverRegistration
and fire a single dummy notification for each one.

Test: intersection-observer/root-element-moved.html
Also tested by existing tests in imported/w3c/web-platform-tests/intersection-observer.

• dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::addIntersectionObserver):
(WebCore::Document::removeIntersectionObserver):
(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::notifyIntersectionObserversTimerFired):

• dom/Document.h:

(WebCore::Document::numberOfIntersectionObservers const):

• dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument):
(WebCore::Element::disconnectFromIntersectionObservers):

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::create):
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::observe):
(WebCore::IntersectionObserver::unobserve):
(WebCore::IntersectionObserver::disconnect):
(WebCore::IntersectionObserver::takeRecords):
(WebCore::IntersectionObserver::targetDestroyed):
(WebCore::IntersectionObserver::removeTargetRegistration):
(WebCore::IntersectionObserver::removeAllTargets):
(WebCore::IntersectionObserver::rootDestroyed):
(WebCore::IntersectionObserver::appendQueuedEntry):
(WebCore::IntersectionObserver::notify):

• page/IntersectionObserver.h:

(WebCore::IntersectionObserver::trackingDocument):
(WebCore::IntersectionObserver:: const):
(WebCore::IntersectionObserver::hasObservationTargets const):

• page/IntersectionObserver.idl:
• testing/Internals.cpp:

(WebCore::Internals::numberOfIntersectionObservers const):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• intersection-observer/root-element-deleted.html: Add additional assertions.
• intersection-observer/root-element-moved-expected.txt: Added.
• intersection-observer/root-element-moved.html: Added.

4:32 PM Changeset in webkit [235013] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[watchOS] NetworkProximityManager should use WTF_MAKE_FAST_ALLOCATED
​https://bugs.webkit.org/show_bug.cgi?id=188723

Reviewed by Sam Weinig.

• NetworkProcess/watchos/NetworkProximityManager.h:

4:20 PM Changeset in webkit [235012] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[watchOS] Add more assertions to NetworkProximityAssertion
​https://bugs.webkit.org/show_bug.cgi?id=188721

Reviewed by Wenson Hsieh.

• NetworkProcess/watchos/NetworkProximityAssertion.mm:

(WebKit::NetworkProximityAssertion::hold):
(WebKit::NetworkProximityAssertion::release):
(WebKit::NetworkProximityAssertion::releaseTimerFired):

3:59 PM Changeset in webkit [235011] by Wenson Hsieh

• 12 edits in trunk

[iOS] Paste is missing from callout bar when pasteboard only contains custom data
​https://bugs.webkit.org/show_bug.cgi?id=184271
<rdar://problem/39256708>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Export a couple of WebCore functions for use in WebKit.

• dom/Document.h:
• platform/Pasteboard.h:

Source/WebKit:

Currently, the "paste:" selector action cannot be performed during editing if the pasteboard only contains
custom pasteboard data. This is because logic in -[WKContentView canPerformActionForWebView:withSender:] only
checks against a list of pasteboard types which does not include the type identifier for custom pasteboard data.
To fix this, we allow pasting only in the case where none of the other type identifiers exist in the pasteboard,
as long as the custom pasteboard data type identifier is present, and the custom pasteboard data's origin
matches the origin of the focused frame's document.

Test: PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly

• Shared/EditorState.cpp:

(WebKit::EditorState::encode const):
(WebKit::EditorState::decode):

• Shared/EditorState.h:

Add a originIdentifierForPasteboard field, and add support for encoding it when propagating EditorState via IPC.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):

If none of the conventional pasteboard type identifiers for rich or plain text editing are present, check to see
if we have custom pasteboard data; if so, only allow pasting if the custom pasteboard data's origin matches that
of the focused frame's document origin.

Additionally refactor a bit of logic by pulling out _page->editorState() into a separate local variable, used
throughout the rest of the method.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

Send the focused frame's document origin to the UI process via EditorState.

Tools:

Add a new API test to verify that on both iOS and macOS, copied custom pasteboard data can only be pasted in a
matching origin. Additionally verify that on iOS, the web view is capable of performing the "paste:" selector.

• TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:

(TestWebKitAPI::TEST):
(imagePath): Deleted.
(writeTypesAndDataToPasteboard): Deleted.
(setUpWebView): Deleted.
(markupString): Deleted.

Make this test file no longer exclusive to macOS.

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]):

Tweak this helper to also take in a baseURL. Defaults to using the TestWebKitAPI bundle resource URL.

(-[TestWKWebView synchronouslyLoadHTMLString:]):

1:09 PM Abandoned documents edited by Simon Fraser

(diff)

1:07 PM Abandoned documents edited by Simon Fraser

(diff)

1:04 PM Abandoned documents edited by Simon Fraser

(diff)

8:00 AM Changeset in webkit [235010] by Michael Catanzaro

• 2 edits in trunk

Adjust CMAKE_MODULE_LINKER_FLAGS for asan
​https://bugs.webkit.org/show_bug.cgi?id=188699

Reviewed by Konstantin Tokarev.

• Source/cmake/WebKitCompilerFlags.cmake:

Aug 17, 2018:

11:47 PM Changeset in webkit [235009] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Pack booleans in Event into a bitfield
​https://bugs.webkit.org/show_bug.cgi?id=188713

Reviewed by Daniel Bates.

Use bitfields for booleans in Event class.

• dom/Event.cpp:

(WebCore::Event::Event):

• dom/Event.h:

(WebCore::Event::IsComposed): Added.
(WebCore::Event): Packed booleans into a bitfield.

9:03 PM Changeset in webkit [235008] by Kocsen Chung

• 3 edits
  1 add in branches/safari-606.1.36.1-branch

Cherry-pick r235007. rdar://problem/43445973

intersectionOfPastValuesAtHead must filter values after they've observed an invalidation point
​https://bugs.webkit.org/show_bug.cgi?id=188707
<rdar://problem/43015442>

Reviewed by Mark Lam.

JSTests:

• stress/cfa-expected-values-must-set-clobbered-to-false.js: Added. (foo): (let.comp.valueOf): (result):

Source/JavaScriptCore:

We use the values in intersectionOfPastValuesAtHead to verify that it is safe to
OSR enter at the head of a block. We verify it's safe to OSR enter by checking
that each incoming value is compatible with its corresponding AbstractValue.

The bug is that we were sometimes filtering the intersectionOfPastValuesAtHead
with abstract values that were clobbererd. This meant that the value we're
verifying with at OSR entry effectively has an infinite structure set because
it's clobbered. So, imagine we have code like this:
`
---> We OSR enter here, and we're clobbered here
InvalidationPoint
GetByOffset(@base)
`

The abstract value for @base inside intersectionOfPastValuesAtHead has a
clobberred structure set, so we'd allow an incoming object with any
structure. However, this is wrong because the invalidation point is no
longer fulfilling its promise that it filters the structure that @base has.

We fix this by filtering the AbstractValues in intersectionOfPastValuesAtHead
as if the incoming value may be live past an InvalidationPoint.
This places a stricter requirement that to safely OSR enter at any basic
block, all incoming values must be compatible as if they lived past
the execution of an invalidation point.

• dfg/DFGCFAPhase.cpp: (JSC::DFG::CFAPhase::run):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:05 PM Changeset in webkit [235007] by sbarati@apple.com

• 3 edits
  1 add in trunk

intersectionOfPastValuesAtHead must filter values after they've observed an invalidation point
​https://bugs.webkit.org/show_bug.cgi?id=188707
<rdar://problem/43015442>

Reviewed by Mark Lam.

JSTests:

• stress/cfa-expected-values-must-set-clobbered-to-false.js: Added.

(foo):
(let.comp.valueOf):
(result):

Source/JavaScriptCore:

We use the values in intersectionOfPastValuesAtHead to verify that it is safe to
OSR enter at the head of a block. We verify it's safe to OSR enter by checking
that each incoming value is compatible with its corresponding AbstractValue.

The bug is that we were sometimes filtering the intersectionOfPastValuesAtHead
with abstract values that were clobbererd. This meant that the value we're
verifying with at OSR entry effectively has an infinite structure set because
it's clobbered. So, imagine we have code like this:
`
---> We OSR enter here, and we're clobbered here
InvalidationPoint
GetByOffset(@base)
`

The abstract value for @base inside intersectionOfPastValuesAtHead has a
clobberred structure set, so we'd allow an incoming object with any
structure. However, this is wrong because the invalidation point is no
longer fulfilling its promise that it filters the structure that @base has.

We fix this by filtering the AbstractValues in intersectionOfPastValuesAtHead
as if the incoming value may be live past an InvalidationPoint.
This places a stricter requirement that to safely OSR enter at any basic
block, all incoming values must be compatible as if they lived past
the execution of an invalidation point.

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):

6:31 PM Changeset in webkit [235006] by timothy_horton@apple.com

• 18 edits
  2 adds in trunk/Source/WebKit

Start bringing up Unified Sources in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=188703

Reviewed by Simon Fraser.

• Configurations/BaseTarget.xcconfig:

Add SRCROOT to the include path, so unified sources can find the source files.

• Shared/APIWebArchive.mm:

(API::releaseWebArchiveData):
(API::WebArchive::data):
(API::releaseCFData): Deleted.

• Shared/APIWebArchiveResource.mm:

(API::releaseWebArchiveResourceData):
(API::WebArchiveResource::data):
(API::releaseCFData): Deleted.
Disambiguate two static methods by renaming them.

• Shared/cf/ArgumentCodersCF.cpp:

Leave a comment about the bizarreness of this file.

• Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::decode):

• Shared/WebPlatformTouchPoint.cpp:
• Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::decode):

• Shared/WebPreferencesStore.cpp:
• Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::createArrayFromLayerList):
(WebKit::WebRenderLayer::WebRenderLayer):

• Shared/gtk/WebEventFactory.cpp:
• Shared/mac/WebCoreArgumentCodersMac.mm:
• Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

• Shared/mac/WebMemorySampler.mac.mm:

(WebKit::WebMemorySampler::sampleWebKit const):

• UIProcess/API/APIAutomationSessionClient.h:

(API::AutomationSessionClient::sessionIdentifier const):
(API::AutomationSessionClient::messageOfCurrentJavaScriptDialogOnPage):

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::setNeedsDisplay):
(WebKit::RemoteLayerBackingStore::backingStoreSize const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::drawInContext):
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setRootLayerID):
(WebKit::RemoteLayerTreeTransaction::setDestroyedLayerIDs):
(WebKit::RemoteLayerTreeTransaction::setLayerIDsWithNewlyUnreachableBackingStore):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::description const):

• Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
Get rid of lots of using namespace.

• Sources.txt: Added.
• SourcesCocoa.txt: Added.
• WebKit.xcodeproj/project.pbxproj:

Set up unified sources.
Right now, we only unify Platform/ and Shared/[^API].

6:06 PM Changeset in webkit [235005] by Kocsen Chung

• 7 edits in branches/safari-606.1.36.1-branch/Source

Versioning.

5:43 PM Changeset in webkit [235004] by Aditya Keerthi

• 14 edits in trunk/Source

[Datalist][iOS] Display suggestions for input[type=color]
​https://bugs.webkit.org/show_bug.cgi?id=188669

Reviewed by Tim Horton.

Source/WebCore:

Expose suggestedColors() in HTMLInputElement in order to allow the UIProcess to
access the list of suggested colors from a <datalist> element.

• html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestedColors const):

• html/ColorInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::suggestedColors const):

• html/HTMLInputElement.h:
• html/InputType.cpp:

(WebCore::InputType::suggestedColors const):

• html/InputType.h:
• platform/ColorChooserClient.h:

Source/WebKit:

An input[type=color] element that has an associated datalist element should
display the color values provided on iOS. Similar to macOS, we now support 1-12
suggested colors, that will be displayed at the top of the color picker.

Also ensured that we get rounded corners on both sides of a color swatch if it is
the only one in its row.

• Shared/AssistedNodeInformation.cpp: Added suggestedColors field.

(WebKit::AssistedNodeInformation::encode const):
(WebKit::AssistedNodeInformation::decode):

• Shared/AssistedNodeInformation.h:
• UIProcess/ios/forms/WKFormColorPicker.mm:

(+[WKColorPicker defaultTopColorMatrix]):
(-[WKColorPicker initWithView:]): Use the list of suggestedColors if it exists.
(-[WKColorPicker drawSelectionIndicatorForColorButton:]):

• WebProcess/WebCoreSupport/WebColorChooser.cpp:

(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::reattachColorChooser):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

5:25 PM Changeset in webkit [235003] by wilander@apple.com

• 2 edits
  4 adds in trunk/LayoutTests

Resource Load Statistics: Add layout test for web workers importing cross-site scripts
​https://bugs.webkit.org/show_bug.cgi?id=188706
<rdar://problem/43437050>

Reviewed by Alex Christensen.

• http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import-expected.txt: Added.
• http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import.html: Added.
• http/tests/resourceLoadStatistics/resources/iframe-report-back-loaded.html:

Fixed typo in URL.

• http/tests/resourceLoadStatistics/resources/script-revealing-cookies.php: Added.
• http/tests/resourceLoadStatistics/resources/worker-importing-localhost-script.js: Added.

5:20 PM Changeset in webkit [235002] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Clean up CSSSelectorList after r234825
​https://bugs.webkit.org/show_bug.cgi?id=188566

Patch by Alex Christensen <​achristensen@webkit.org> on 2018-08-17
Reviewed by Megan Gardner.

This is responding to Darin's feedback in ​https://bugs.webkit.org/show_bug.cgi?id=188539

• css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::operator=): Deleted.

• css/CSSSelectorList.h:

(WebCore::CSSSelectorList::CSSSelectorList):

• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parsePageSelector):

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumeComplexSelectorList):
(WebCore::CSSSelectorParser::consumeCompoundSelectorList):

5:11 PM Changeset in webkit [235001] by Ryan Haddad

• 4 edits in trunk/Source/WebKit

Unreviewed, rolling out r234991.

Caused an assertion failure on the bots.

Reverted changeset:

"Pass webPageID and webFrameID to NetworkLoad for speculative
loads"
​https://bugs.webkit.org/show_bug.cgi?id=188682
​https://trac.webkit.org/changeset/234991

5:09 PM Changeset in webkit [235000] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Remove Adobe SSO exception now that StorageAccess API is available
​https://bugs.webkit.org/show_bug.cgi?id=188710
<rdar://problem/35056707>

Reviewed by Alex Christensen.

Remove custom quirk now that proper API exists to allow the same functions.

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
(WebCore::resourceNeedsSSOQuirk): Deleted.

5:00 PM Changeset in webkit [234999] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Replace canBubble and cancelable booleans in Event by enum classes
​https://bugs.webkit.org/show_bug.cgi?id=188692
<rdar://problem/43411944>

Rubber-stamped by Alex Christensen.

Make these enum classes uint8_t.

• dom/Event.h:

4:24 PM Changeset in webkit [234998] by achristensen@apple.com

• 27 edits
  1 add in trunk/Source

Add some plumbing for safe browsing
​https://bugs.webkit.org/show_bug.cgi?id=188709

Reviewed by Tim Horton.

Source/WebCore:

No change in behavior. Just passing around unused booleans.
We will need this for a way to load a page even though safe browsing says it's unsafe.

• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setShouldSkipSafeBrowsingCheck):
(WebCore::FrameLoadRequest::shouldSkipSafeBrowsingCheck):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):

• loader/FrameLoader.h:

(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadWithNavigationAction):

• loader/FrameLoaderClient.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/PolicyChecker.h:
• loader/ShouldSkipSafeBrowsingCheck.h: Added.

Source/WebKit:

Also adding a URL to SafeBrowsingResult because we'll need it.
Also adding a bool to LoadParameters because we will need to do special things
when loading the safe browsing warning, like adding a way to skip the safe browsing check.

• Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

• Shared/LoadParameters.h:
• UIProcess/Cocoa/SafeBrowsingResultCocoa.mm:

(WebKit::SafeBrowsingResult::SafeBrowsingResult):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::beginSafeBrowsingCheck):

• UIProcess/SafeBrowsingResult.h:

(WebKit::SafeBrowsingResult::url const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebCoreSupport/WebFrameLoaderClient.h:

2:59 PM Abandoned documents edited by Simon Fraser

(diff)

2:52 PM Abandoned documents created by Simon Fraser

2:43 PM Changeset in webkit [234997] by Jonathan Bedard

• 5 edits in trunk/Tools

Add back --wtf-only to run-api-tests
​https://bugs.webkit.org/show_bug.cgi?id=187893
<rdar://problem/42483983>

Reviewed by Aakash Jain.

When doing WTF development, it is not necessary to build or run all of the API
tests. Generally, if a user has specified a specific binary (or binaries) that
they are interested in testing, it is not necessary to check all API test binaries.

• Scripts/webkitpy/api_tests/manager.py:

(Manager._collect_tests): Only use the binaries matching the program arguments
when collecting tests.
(Manager._binaries_for_arguments): Generate a list of binaries which match the
program arguments.
(Manager.run): Pass a list binaries to check.

• Scripts/webkitpy/api_tests/run_api_tests.py:

(parse_args):

• Scripts/webkitpy/port/base.py:

(Port.check_api_test_build): If the caller specifies which API test binaries it
requires, only check the ones specified.
(Port.path_to_api_test_binaries): Allow the caller to only build the WTF API tests.
(Port._build_api_tests): Allow the caller to only build the WTF API tests.

• Scripts/webkitpy/port/win.py:

(WinPort.path_to_api_test_binaries):

2:43 PM WikiStart edited by Simon Fraser

(diff)

2:28 PM Changeset in webkit [234996] by Devin Rousso

• 2 edits in trunk/LayoutTests

Marked inspector/dom-debugger/event-breakpoint-with-navigation.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=188708

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

2:24 PM Changeset in webkit [234995] by rniwa@webkit.org

• 165 edits in trunk/Source

Replace canBubble and cancelable booleans in Event by enum classes
​https://bugs.webkit.org/show_bug.cgi?id=188692

Reviewed by Alex Christensen.

Source/WebCore:

Replaced booleans indicating whether an event can bubble and an event is cancelable
by two enum classes: CanBubble and IsCancelable.

No new tests since there should be no behavioral changes.

• Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp:

(WebCore::WebKitPlaybackTargetAvailabilityEvent::WebKitPlaybackTargetAvailabilityEvent):

• Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp:

(WebCore::ApplePayPaymentAuthorizedEvent::ApplePayPaymentAuthorizedEvent):

• Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp:

(WebCore::ApplePayPaymentMethodSelectedEvent::ApplePayPaymentMethodSelectedEvent):

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::didCancelPaymentSession):

• Modules/applepay/ApplePayShippingContactSelectedEvent.cpp:

(WebCore::ApplePayShippingContactSelectedEvent::ApplePayShippingContactSelectedEvent):

• Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:

(WebCore::ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent):

• Modules/applepay/ApplePayValidateMerchantEvent.cpp:

(WebCore::ApplePayValidateMerchantEvent::ApplePayValidateMerchantEvent):

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::updateKeyStatuses):

• Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp:

(WebCore::WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent):

• Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp:

(WebCore::WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent):

• Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:

(WebCore::WebKitMediaKeySession::addKeyTimerFired):
(WebCore::WebKitMediaKeySession::sendError):

• Modules/gamepad/GamepadEvent.cpp:

(WebCore::GamepadEvent::GamepadEvent):

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::connectionToServerLost):

• Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onError):
(WebCore::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
(WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
(WebCore::IDBOpenDBRequest::onSuccess):

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):

• Modules/indexeddb/IDBRequestCompletionEvent.cpp:

(WebCore::IDBRequestCompletionEvent::IDBRequestCompletionEvent):

• Modules/indexeddb/IDBRequestCompletionEvent.h:

(WebCore::IDBRequestCompletionEvent::create):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::fireOnComplete):
(WebCore::IDBTransaction::fireOnAbort):

• Modules/indexeddb/IDBVersionChangeEvent.cpp:

(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::skipToNextTrack):
(WebCore::MediaSession::skipToPreviousTrack):

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::scheduleEvent):

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::scheduleEvent):

• Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::scheduleEvent):

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::scheduledEventTimerFired):

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalRemoveTrack):

• Modules/mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):

• Modules/mediastream/MediaStreamEvent.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::trackMutedChanged):

• Modules/mediastream/MediaStreamTrackEvent.cpp:

(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):

• Modules/mediastream/MediaStreamTrackEvent.h:
• Modules/mediastream/OverconstrainedErrorEvent.h:

(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::fireICECandidateEvent):
(WebCore::PeerConnectionBackend::doneGatheringCandidates):
(WebCore::PeerConnectionBackend::updateSignalingState):

• Modules/mediastream/RTCDTMFToneChangeEvent.cpp:

(WebCore::RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent):

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::didChangeReadyState):
(WebCore::RTCDataChannel::didDetectError):
(WebCore::RTCDataChannel::bufferedAmountIsDecreasing):

• Modules/mediastream/RTCDataChannelEvent.cpp:

(WebCore::RTCDataChannelEvent::create):
(WebCore::RTCDataChannelEvent::RTCDataChannelEvent):

• Modules/mediastream/RTCDataChannelEvent.h:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::updateConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

• Modules/mediastream/RTCPeerConnectionIceEvent.cpp:

(WebCore::RTCPeerConnectionIceEvent::create):
(WebCore::RTCPeerConnectionIceEvent::RTCPeerConnectionIceEvent):

• Modules/mediastream/RTCPeerConnectionIceEvent.h:
• Modules/mediastream/RTCTrackEvent.cpp:

(WebCore::RTCTrackEvent::create):
(WebCore::RTCTrackEvent::RTCTrackEvent):

• Modules/mediastream/RTCTrackEvent.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::addDataChannel):

• Modules/notifications/Notification.cpp:

(WebCore::Notification::dispatchShowEvent):
(WebCore::Notification::dispatchClickEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::dispatchErrorEvent):

• Modules/paymentrequest/MerchantValidationEvent.cpp:

(WebCore::MerchantValidationEvent::MerchantValidationEvent):

• Modules/paymentrequest/PaymentRequestUpdateEvent.cpp:

(WebCore::PaymentRequestUpdateEvent::PaymentRequestUpdateEvent):

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::postEvent):

• Modules/speech/SpeechSynthesisEvent.cpp:

(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::setState):

• Modules/webaudio/AudioProcessingEvent.cpp:

(WebCore::AudioProcessingEvent::AudioProcessingEvent):

• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::finish):

• Modules/webaudio/OfflineAudioCompletionEvent.cpp:

(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):

• Modules/websockets/CloseEvent.h:

(WebCore::CloseEvent::CloseEvent):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::dispatchOrQueueErrorEvent):

• Modules/webvr/VRDisplayEvent.cpp:

(WebCore::VRDisplayEvent::VRDisplayEvent):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::dispatchAccessibilityEventWithType const):

• accessibility/AccessibleSetValueEvent.cpp:

(WebCore::AccessibleSetValueEvent::AccessibleSetValueEvent):

• animation/AnimationPlaybackEvent.cpp:

(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):

• dom/AbortSignal.cpp:

(WebCore::AbortSignal::abort):

• dom/AnimationEvent.cpp:

(WebCore::AnimationEvent::AnimationEvent):

• dom/BeforeLoadEvent.h:
• dom/BeforeTextInsertedEvent.cpp:

(WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent):

• dom/BeforeUnloadEvent.cpp:

(WebCore::BeforeUnloadEvent::BeforeUnloadEvent):

• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

• dom/CompositionEvent.cpp:

(WebCore::CompositionEvent::CompositionEvent):

• dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

• dom/DeviceMotionEvent.cpp:

(WebCore::DeviceMotionEvent::DeviceMotionEvent):

• dom/DeviceOrientationEvent.cpp:

(WebCore::DeviceOrientationEvent::DeviceOrientationEvent):

• dom/Document.cpp:

(WebCore::Document::setReadyState):
(WebCore::Document::visibilityStateChanged):
(WebCore::Document::finishedParsing):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
(WebCore::Document::orientationChanged):

• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::enqueueScrollEvent):
(WebCore::DocumentEventQueue::enqueueResizeEvent):

• dom/DocumentEventQueue.h:
• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):
(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):
(WebCore::Element::dispatchWebKitImageReadyEventForTesting):

• dom/ErrorEvent.cpp:

(WebCore::ErrorEvent::ErrorEvent):

• dom/Event.cpp:

(WebCore::Event::Event):
(WebCore::Event::create):

• dom/Event.h:
• dom/FocusEvent.cpp:

(WebCore::FocusEvent::FocusEvent):

• dom/FocusEvent.h:
• dom/HashChangeEvent.h:
• dom/InputEvent.cpp:

(WebCore::InputEvent::create):
(WebCore::InputEvent::InputEvent):

• dom/InputEvent.h:
• dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

• dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):

• dom/MouseEvent.h:
• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

• dom/MouseRelatedEvent.h:
• dom/MutationEvent.cpp:

(WebCore::MutationEvent::MutationEvent):

• dom/MutationEvent.h:
• dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::dispatchInputEvent):

• dom/OverflowEvent.cpp:

(WebCore::OverflowEvent::OverflowEvent):

• dom/PageTransitionEvent.cpp:

(WebCore::PageTransitionEvent::PageTransitionEvent):

• dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):

• dom/ProgressEvent.cpp:

(WebCore::ProgressEvent::ProgressEvent):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::dispatchErrorEvent):

• dom/SecurityPolicyViolationEvent.h:
• dom/SimulatedClick.cpp:
• dom/TextEvent.cpp:

(WebCore::TextEvent::TextEvent):

• dom/TransitionEvent.cpp:

(WebCore::TransitionEvent::TransitionEvent):

• dom/UIEvent.cpp:

(WebCore::UIEvent::UIEvent):

• dom/UIEvent.h:

(WebCore::UIEvent::create):

• dom/UIEventWithKeyState.h:

(WebCore::UIEventWithKeyState::UIEventWithKeyState):

• dom/WebKitAnimationEvent.cpp:

(WebCore::WebKitAnimationEvent::WebKitAnimationEvent):

• dom/WebKitTransitionEvent.cpp:

(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):

• dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

• editing/Editor.cpp:

(WebCore::dispatchBeforeInputEvent):
(WebCore::dispatchBeforeInputEvents):
(WebCore::Editor::willApplyEditing const):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::dispatchSelectStart):

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::dispatchPendingEvent):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::checkValidity):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareForSubmission):
(WebCore::HTMLFormElement::reset):

• html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::onSearch):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::dispatchPendingEvent):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::notifyAboutPlaying):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::layoutSizeChanged):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::checkSnapshotStatus):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::dispatchLoadEvent):

• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::dispatchSlotChangeEvent):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::errorEventTimerFired):

• html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::dispatchPendingEvent):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectionChanged):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::didCompleteLoad):

• html/MediaController.cpp:

(WebCore::MediaController::scheduleEvent):

• html/canvas/WebGLContextEvent.cpp:

(WebCore::WebGLContextEvent::WebGLContextEvent):

• html/canvas/WebGLContextEvent.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::dispatchContextChangedEvent):

• html/parser/HTMLScriptRunner.cpp:

(WebCore::createScriptLoadEvent):

• html/track/TrackEvent.cpp:

(WebCore::TrackEvent::TrackEvent):

• html/track/TrackEvent.h:
• html/track/TrackListBase.cpp:

(WebCore::TrackListBase::scheduleTrackEvent):
(WebCore::TrackListBase::scheduleChangeEvent):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingErrorEvent):

• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::createApplicationCacheEvent):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::languagesChanged):
(WebCore::DOMWindow::dispatchLoadEvent):

• page/EventHandler.cpp:

(WebCore::dispatchSelectStart):
(WebCore::EventHandler::dispatchDragEvent):

• page/EventSource.cpp:

(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::abortConnectionAttempt):

• page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::FocusController::setFocusedFrame):

• page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

• page/Page.cpp:

(WebCore::networkStateChanged):

• page/Performance.cpp:

(WebCore::Performance::resourceTimingBufferFullTimerFired):

• page/PointerLockController.cpp:

(WebCore::PointerLockController::enqueueEvent):

• page/VisualViewport.cpp:

(WebCore::VisualViewport::enqueueResizeEvent):
(WebCore::VisualViewport::enqueueScrollEvent):

• storage/StorageEvent.cpp:

(WebCore::StorageEvent::StorageEvent):

• svg/SVGElement.cpp:

(WebCore::SVGElement::sendSVGLoadEventIfPossible):

• svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::dispatchLoadEvent):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::notifyFinished):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::dispatchPendingEvent):

• workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):

• workers/service/ExtendableEvent.cpp:

(WebCore::ExtendableEvent::ExtendableEvent):

• workers/service/ExtendableEvent.h:
• workers/service/ExtendableMessageEvent.cpp:

(WebCore::ExtendableMessageEvent::ExtendableMessageEvent):

• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::scheduleTaskToUpdateState):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::scheduleTaskToFireUpdateFoundEvent):

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::notifyNetworkStateChange):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener):

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

Source/WebKitLegacy/ios:

• WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

• WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

• WebView/WebView.mm:

(-[WebView _dispatchUnloadEvent]):

1:27 PM Changeset in webkit [234994] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[Xcode] Fix up file reference paths in Source/WebKit/NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=188700

Rubber-stamped by Dan Bernstein.

• WebKit.xcodeproj/project.pbxproj:

11:56 AM Changeset in webkit [234993] by Simon Fraser

• 3 edits in trunk/LayoutTests

Modernize results.html
​https://bugs.webkit.org/show_bug.cgi?id=188690

Reviewed by Alexey Proskuryakov.

results.html, which is used to show layout test results, had some very old-school
HTML string building to create the tables of test results, making it hard to hack on.

Modernize it, using ES6 classes for the major actors, and using DOM API to build most
of the content.

The page is functionally the same (other than the addition of a missing 'History" column header).

• fast/harness/results-expected.txt:
• fast/harness/results.html:

11:55 AM Changeset in webkit [234992] by Kocsen Chung

• 1 copy in tags/Safari-606.1.36.10.1

Tag Safari-606.1.36.10.1.

11:11 AM Changeset in webkit [234991] by achristensen@apple.com

• 4 edits in trunk/Source/WebKit

Pass webPageID and webFrameID to NetworkLoad for speculative loads
​https://bugs.webkit.org/show_bug.cgi?id=188682

Reviewed by Youenn Fablet.

This also removes an authentication shortcut I introduced in r234941

• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):

• Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

11:10 AM Changeset in webkit [234990] by achristensen@apple.com

• 5 edits in trunk/Source/WebKit

Simplify server trust authentication flow
​https://bugs.webkit.org/show_bug.cgi?id=188684

Reviewed by Youenn Fablet.

We unnecessarily had the allowsSpecificHTTPSCertificateForHost check at two different abstraction levels.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didReceiveChallenge):

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::allowsSpecificHTTPSCertificateForHost): Deleted.

• NetworkProcess/NetworkSession.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

11:09 AM Changeset in webkit [234989] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix API tests after r234985
​https://bugs.webkit.org/show_bug.cgi?id=188679

• UIProcess/API/C/WKPage.cpp:

(encodingOf):
(dataFrom):
The encoding of null strings had changed, which is no big deal because there's no data in that encoding,
but switching it back fixes the tests.

10:56 AM Changeset in webkit [234988] by Kocsen Chung

• 7 edits in branches/safari-606.1.36.10-branch/Source

Versioning.

10:46 AM Changeset in webkit [234987] by Kocsen Chung

• 1 copy in branches/safari-606.1.36.10-branch

New branch.

10:27 AM Changeset in webkit [234986] by jer.noble@apple.com

• 2 edits in trunk/Tools

REGRESSION (234743) Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio
​https://bugs.webkit.org/show_bug.cgi?id=188470
<rdar://problem/43144969>

Reviewed by Alex Christensen.

On a loaded server, the WebContent process may send the "playing" message before the
UIProcess has a chance to register a listener for that message. Restructure the tests
so that the listener is registered before the page is loaded.

• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:

(PreferredAudioBufferSize::runPlayingTestWithPageNamed):
(TEST_F):

9:41 AM Changeset in webkit [234985] by achristensen@apple.com

• 12 edits in trunk/Source/WebKit

Replace WebPageProxy::loadAlternateHTMLString with loadAlternateHTML
​https://bugs.webkit.org/show_bug.cgi?id=188679

Reviewed by Carlos Garcia Campos.

• Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

• Shared/LoadParameters.h:
• UIProcess/API/C/WKPage.cpp:

(encodingOf):
(dataFrom):
(loadString):
(WKPageLoadAlternateHTMLString):
(WKPageLoadAlternateHTMLStringWithUserData):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _loadAlternateHTMLString:baseURL:forUnreachableURL:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadAlternateHTMLString): Deleted.

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadAlternateHTMLString):

8:26 AM Changeset in webkit [234984] by yusukesuzuki@slowstart.org

• 14 edits in trunk/Source

[JSC] Add GPRReg::InvalidGPRReg and FPRReg::InvalidFPRReg
​https://bugs.webkit.org/show_bug.cgi?id=188589

Patch by Yusuke Suzuki <​yusukesuzuki@slowstart.org> and Fujii Hironori <Fujii Hironori> on 2018-08-17
Reviewed by Mark Lam.
And reviewed by Yusuke Suzuki for Hironori's change.

Source/JavaScriptCore:

Since GPRReg(RegisterID) and FPRReg(FPRegisterID) do not include -1 in their enum values,
UBSan dumps bunch of warnings "runtime error: load of value 4294967295, which is not a valid value for type 'RegisterID'".

• We add InvalidGPRReg and InvalidFPRReg to enum values of GPRReg and FPRReg to suppress the above warnings.
• We make GPRReg and FPRReg int8_t enums.
• We replace #define InvalidGPRReg ((JSC::GPRReg)-1) to static constexpr GPRReg InvalidGPRReg { GPRReg::InvalidGPRReg };.
• We add operator+/- definition for RegisterIDs as a MSVC workaround. MSVC fails to resolve operator+ and operator- if enum : int8_t is used instead of enum.

• assembler/ARM64Assembler.h:
• assembler/ARMAssembler.h:
• assembler/ARMv7Assembler.h:
• assembler/MIPSAssembler.h:
• assembler/MacroAssembler.h:
• assembler/X86Assembler.h:
• jit/CCallHelpers.h:

(JSC::CCallHelpers::clampArrayToSize):

• jit/FPRInfo.h:
• jit/GPRInfo.h:

(JSC::JSValueRegs::JSValueRegs):
(JSC::JSValueRegs::tagGPR const):
(JSC::JSValueRegs::payloadGPR const):
(JSC::JSValueSource::JSValueSource):
(JSC::JSValueSource::unboxedCell):
(JSC::JSValueSource::operator bool const):
(JSC::JSValueSource::base const):
(JSC::JSValueSource::tagGPR const):
(JSC::JSValueSource::payloadGPR const):
(JSC::JSValueSource::hasKnownTag const):

Source/WebCore:

• cssjit/FunctionCall.h:

(WebCore::FunctionCall::FunctionCall):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):

• html/HTMLKeygenElement.cpp:

Remove using namespace WebCore not to introduce operator+/- which makes the resolution of operator+/- for RegisterID ambiguous.

7:07 AM Changeset in webkit [234983] by Philippe Normand

• 3 edits in trunk/Source/WebCore

[GStreamer] reduce position queries frequency
​https://bugs.webkit.org/show_bug.cgi?id=188645

Patch by Philippe Normand <​philn@igalia.com> on 2018-08-17
Reviewed by Xabier Rodriguez-Calvar.

There is no need to perform dozens of position queries per second.
One every 300ms is enough.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

6:19 AM Changeset in webkit [234982] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[SOUP] Handle OAuth authentication after r234912
​https://bugs.webkit.org/show_bug.cgi?id=188651

Reviewed by Carlos Garcia Campos.

Update this switch to consider the new OAuth enum value added in r234912. I suppose OAuth is
used for HTTP Auth now. It will be a one-time compatibility break as passwords previously
stored with type "Unknown" will no longer be accessible.

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::authTypeFromProtectionSpaceAuthenticationScheme):

6:15 AM Changeset in webkit [234981] by Michael Catanzaro

• 9 edits in trunk/Source/WebKit

Unreviewed, rolling out r234259.

Caused excessive CPU usage

Reverted changeset:

"[GTK][WPE] Improve the way request displayRefresh
notifications"
​https://bugs.webkit.org/show_bug.cgi?id=188005
​https://trac.webkit.org/changeset/234259

6:04 AM Changeset in webkit [234980] by ddkilzer@apple.com

• 3 edits in trunk/Source/WTF

WTF's internal std::optional implementation should release assert on all bad accesses
<​https://webkit.org/b/187669>

Reviewed by Ryosuke Niwa.

• wtf/Assertions.h:

(RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT): Add macro definitions.

• wtf/Optional.h:

(std::optional::operator -> const):
(std::optional::operator ->):
(std::optional::operator * const):
(std::optional::operator *):
(std::optional::value const):
(std::optional::value):
(std::optional<T::operator-> const):
(std::optional<T::operator* const):
(std::optional<T::value const):

• Change ASSERT_UNDER_CONSTEXPR_CONTEXT() macros to RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT() macros.

2:59 AM Changeset in webkit [234979] by Ms2ger@igalia.com

• 3 edits in trunk/Source/WebCore

[GTK] Never return an uninitialized ImageGStreamer object.
​https://bugs.webkit.org/show_bug.cgi?id=188305

Reviewed by Philippe Normand.

The single caller was already checking for a null return value, so
make that check actually do something. Also remove the null-check on
the return value of image(), which asserted that it would never return
null.

Test: fast/canvas/canvas-createPattern-video-loading.html

• platform/graphics/gstreamer/ImageGStreamer.h:

(WebCore::ImageGStreamer::createImage): Return null if m_image wasn't created.
(WebCore::ImageGStreamer::image): Return a reference.
(WebCore::ImageGStreamer::rect): Always assert that m_image is present.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::paint): Update for new signature.

1:54 AM Changeset in webkit [234978] by Philippe Normand

• 2 edits in trunk/Source/WebCore

[GStreamer] Enable fpsdisplaysink only when MEDIA_STATISTICS is enabled
​https://bugs.webkit.org/show_bug.cgi?id=188648

Patch by Philippe Normand <​philn@igalia.com> on 2018-08-17
Reviewed by Xabier Rodriguez-Calvar.

The fpsdisplaysink is useful only when MEDIA_STATISTICS is turned on.
The text overlay is now enabled when GST_DEBUG tracing is enabled for the player.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

1:52 AM Changeset in webkit [234977] by Philippe Normand

• 2 edits in trunk/Source/WebCore

[GStreamer][MSE] Disable last-sample support in AppendPipeline
​https://bugs.webkit.org/show_bug.cgi?id=188649

Patch by Philippe Normand <​philn@igalia.com> on 2018-08-17
Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline): This property isn't
used by the append pipeline. So as a micro-optimization, it is now
disabled.