Context Navigation

← Previous Period
Next Period →

Timeline

Sep 3, 2018:

9:25 PM Changeset in webkit [235607] by aestes@apple.com

9 edits in trunk

[Payment Request] Remove PaymentAddress.languageCode
https://bugs.webkit.org/show_bug.cgi?id=189254

Reviewed by Sam Weinig.

Source/WebCore:

PaymentAddress.languageCode is marked as "at risk" in the latest Payment Request Editor's
Draft (30 August 2018). Firefox has already removed it, and Chrome is considering it.

There is some compatibility risk in removing this attribute, but considering we never
populated it with a meaningful value, the risk seems very low. If we learn about
compatibility problems, we can address them by evangelising or even reverting this change.

Updated existing tests.

Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convert):

Modules/paymentrequest/PaymentAddress.cpp:

(WebCore::PaymentAddress::PaymentAddress):

Modules/paymentrequest/PaymentAddress.h:
Modules/paymentrequest/PaymentAddress.idl:

LayoutTests:

http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt:
http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:

8:36 PM Changeset in webkit [235606] by aestes@apple.com

8 edits
6 copies in trunk/Source/WebCore

[Payment Request] Add a stub for PaymentResponse.retry
https://bugs.webkit.org/show_bug.cgi?id=189253

Reviewed by Sam Weinig.

Implemented the AddressErrors, PayerErrorFields, and PaymentValidationErrors dictionaries as
defined in the Payment Request API W3C Editor's Draft of 30 August 2018.

Also added a stub implementation of PaymentResponse.retry. This method will be implemented
with tests in a follow-up patch.

CMakeLists.txt:
DerivedSources.make:
Modules/paymentrequest/AddressErrors.h: Added.
Modules/paymentrequest/AddressErrors.idl: Added.
Modules/paymentrequest/PayerErrorFields.h: Added.
Modules/paymentrequest/PayerErrorFields.idl: Added.
Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::retry):

Modules/paymentrequest/PaymentResponse.h:
Modules/paymentrequest/PaymentResponse.idl:
Modules/paymentrequest/PaymentValidationErrors.h: Added.
Modules/paymentrequest/PaymentValidationErrors.idl: Added.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

7:48 PM Changeset in webkit [235605] by mark.lam@apple.com

11 edits
1 add in trunk

The watchdog sometimes fails to terminate a script.
https://bugs.webkit.org/show_bug.cgi?id=189227
<rdar://problem/39932857>

Reviewed by Saam Barati.

JSTests:

stress/regress-189227-watchdog-on-infinite-loop.js: Added.

Source/JavaScriptCore:

Consider the following scenario:

We have an infinite loop bytecode sequence as follows:

[ 13] loop_hint
[ 14] check_traps
[ 15] jmp -2(->13)

The VM tiers up from LLInt -> BaselineJIT -> DFG -> FTL.

Note that op_check_traps is represented as a CheckTraps node in the DFG and FTL.
When we're not using pollingTraps (JSC_usePollingTraps is false by default),
we emit no code for CheckTraps, but only record an InvalidationPoint there.

The watchdog fires, and invalidates all InvalidationPoints in the FTL CodeBlock.

InvalidationPoints OSR exits to the next instruction by design. In this case,
that means the VM will resumes executing at the op_jmp, which jumps to the
op_loop_hint opcode. At the loop_hint, the VM discovers that the function is
already hot, and attempts to tier up. It immediately discovers that a replacement
CodeBlock is available because we still haven't jettisoned the DFG CodeBlock
nor the FTL CodeBlock that was previously compiled for this function.

Note that jettisoning a CodeBlock necessarily means the VM will invalidate
its InvalidationPoints (if the CodeBlock is DFG/FTL). However, the reverse
is not true: merely invalidating the InvalidationPoints does not necessarily
mean that the CodeBlock is jettisoned.

VMTraps::tryInstallTrapBreakpoints() runs from a separate thread. Hence,
it is only safe for it to invalidate a CodeBlock's InvalidationPoints. It
is not safe for the CodeBlock to be jettisoned from another thread. Instead,
the VMTraps mechanism relies on the script thread running to an op_check_traps
in the baseline JIT code where it will do the necessary jettisoning of optimized
CodeBlocks.

Since the op_check_traps never get executed, the VM will perpetually tier up in
the op_loop_hint, OSR exit to the op_jmp, jump to the op_loop_hint, and repeat.
Consequently, the watchdog fails to terminate this script.

In this patch, we fix this by making the DFG BytecodeParser emit an InvalidationPoint
node directly (when the VM is not configured to use polling traps). This ensures
that the check traps invalidation point will OSR exit to the op_check_traps opcode
in the baseline JIT.

In this patch, we also change VMTraps::tryInstallTrapBreakpoints() to use
CallFrame::unsafeCodeBlock() instead of CallFrame::codeBlock(). This is because
we don't really know if the frame is properly set up. We're just conservatively
probing the stack. ASAN does not like this probing. Using unsafeCodeBlock() here
will suppress the false positive ASAN complaint.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckTraps):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):

runtime/VMTraps.cpp:

(JSC::VMTraps::tryInstallTrapBreakpoints):

4:48 PM Changeset in webkit [235604] by aestes@apple.com

2 edits in trunk/Source/WebCore

[Payment Request] MerchantValidationEvent should be enabled by the PaymentRequest setting
https://bugs.webkit.org/show_bug.cgi?id=189250

Reviewed by Daniel Bates.

Modules/paymentrequest/MerchantValidationEvent.idl:

4:29 PM Changeset in webkit [235603] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

CallFrame::unsafeCallee() should use an ASAN suppressed Register::asanUnsafePointer().
https://bugs.webkit.org/show_bug.cgi?id=189247

Reviewed by Saam Barati.

interpreter/CallFrame.h:

(JSC::ExecState::unsafeCallee const):

interpreter/Register.h:

(JSC::Register::asanUnsafePointer const):
(JSC::Register::unsafePayload const):

4:17 PM Changeset in webkit [235602] by youenn@apple.com

8 edits in trunk

REGRESSION: Layout Test http/tests/security/bypassing-cors-checks-for-extension-urls.html is Flaky
https://bugs.webkit.org/show_bug.cgi?id=187658
<rdar://problem/42306442>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test is flaky as a previous test was setting the isRunningUserScripts state on the Page and it was never reset.
This patch moves this state to the topDocument so that it will be reset for every navigation.
Covered by existing test being no longer flaky.

dom/Document.h:

(WebCore::Document::setAsRunningUserScripts):
(WebCore::Document::isRunningUserScripts const):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

page/Page.h:

(WebCore::Page::setAsRunningUserScripts): Deleted.
(WebCore::Page::isRunningUserScripts const): Deleted.

testing/Internals.cpp:

(WebCore::Internals::setAsRunningUserScripts):

LayoutTests:

platform/mac-wk2/TestExpectations:

12:18 PM Changeset in webkit [235601] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE] Add more WPE bots to dashboard
https://bugs.webkit.org/show_bug.cgi?id=189245

Patch by Pablo Saavedra <Pablo Saavedra> on 2018-09-03
Reviewed by Daniel Bates.

There are two missing bots which are not listed in the dashboard for
a while: WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests)

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

10:16 AM Changeset in webkit [235600] by aestes@apple.com

19 edits
2 copies
22 adds
2 deletes in trunk

[Payment Request] Implement the MerchantValidationEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=189235

Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

Updated payment-request web platform tests to 0313d9f.

resources/TestRepositories:
resources/import-expectations.json:
web-platform-tests/payment-request/MerchantValidationEvent/complete-method-manual.https.html: Added.
web-platform-tests/payment-request/MerchantValidationEvent/constructor.http-expected.txt: Added.
web-platform-tests/payment-request/MerchantValidationEvent/constructor.http.html: Added.
web-platform-tests/payment-request/MerchantValidationEvent/constructor.https-expected.txt: Added.
web-platform-tests/payment-request/MerchantValidationEvent/constructor.https.html: Added.
web-platform-tests/payment-request/MerchantValidationEvent/w3c-import.log: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.http-expected.txt: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.http.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.https-expected.txt: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updateWith-call-immediate-manual.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updateWith-duplicate-shipping-options-manual.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updateWith-incremental-update-manual.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updateWith-method-abort-update-manual.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updateWith-state-checks-manual.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updatewith-method.https-expected.txt: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html: Added.
web-platform-tests/payment-request/PaymentRequestUpdateEvent/w3c-import.log: Added.
web-platform-tests/payment-request/allowpaymentrequest/common.sub.js:

(window.onmessage.e.t.step):
(string_appeared_here.forEach):
(window.onmessage): Deleted.

web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html:
web-platform-tests/payment-request/onmerchantvalidation-attribute.https-expected.txt: Added.
web-platform-tests/payment-request/onmerchantvalidation-attribute.https.html: Added.
web-platform-tests/payment-request/w3c-import.log:

Source/WebCore:

Implemented the constructor for MerchantValidationEvent as defined in the Payment Request API W3C Editor's Draft of 30 August 2018.

Updated the payment-request web platform tests to include MerchantValidationEvent tests.

Tests: imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.http.html

imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.https.html
imported/w3c/web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.http.html
imported/w3c/web-platform-tests/payment-request/PaymentRequestUpdateEvent/constructor.https.html
imported/w3c/web-platform-tests/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html
imported/w3c/web-platform-tests/payment-request/onmerchantvalidation-attribute.https.html

CMakeLists.txt:
DerivedSources.make:
Modules/paymentrequest/MerchantValidationEvent.cpp:

(WebCore::MerchantValidationEvent::create):
(WebCore::MerchantValidationEvent::MerchantValidationEvent):
(WebCore::MerchantValidationEvent::complete):

Modules/paymentrequest/MerchantValidationEvent.h:
Modules/paymentrequest/MerchantValidationEvent.idl:
Modules/paymentrequest/MerchantValidationEventInit.h: Added.
Modules/paymentrequest/MerchantValidationEventInit.idl: Added.
Modules/paymentrequest/PaymentRequest.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Skipped new manual tests.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

6:41 AM Changeset in webkit [235599] by fred.wang@free.fr

5 edits
4 deletes in trunk/LayoutTests

Remove duplicate directory web-platform-tests/cssom-view
https://bugs.webkit.org/show_bug.cgi?id=189241

LayoutTests/imported/w3c:

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-03
Reviewed by Daniel Bates.

cssom-view tests were moved into web-platform-tests/css at r232903 but the old
directory and expectation were left. This patch finishes the migration.

resources/import-expectations.json:
web-platform-tests/css/cssom-view/scrollingElement-expected.txt: Removed.
web-platform-tests/cssom-view/CaretPosition-001-expected.txt: Removed.
web-platform-tests/cssom-view/CaretPosition-001.html: Removed.
web-platform-tests/cssom-view/DOMRectList-expected.txt: Removed.
web-platform-tests/cssom-view/DOMRectList.html: Removed.
web-platform-tests/cssom-view/HTMLBody-ScrollArea_quirksmode-expected.txt: Removed.
web-platform-tests/cssom-view/HTMLBody-ScrollArea_quirksmode.html: Removed.
web-platform-tests/cssom-view/MediaQueryList-001-expected.txt: Removed.
web-platform-tests/cssom-view/MediaQueryList-001.html: Removed.
web-platform-tests/cssom-view/MediaQueryList-with-empty-string-expected.txt: Removed.
web-platform-tests/cssom-view/MediaQueryList-with-empty-string.html: Removed.
web-platform-tests/cssom-view/OWNERS: Removed.
web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001-expected.txt: Removed.
web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html: Removed.
web-platform-tests/cssom-view/cssom-getBoundingClientRect-001-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-getBoundingClientRect-001.html: Removed.
web-platform-tests/cssom-view/cssom-getBoundingClientRect-002-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-getBoundingClientRect-002.html: Removed.
web-platform-tests/cssom-view/cssom-getClientRects-002-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-getClientRects-002.html: Removed.
web-platform-tests/cssom-view/cssom-getClientRects-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-getClientRects.html: Removed.
web-platform-tests/cssom-view/cssom-view-img-attributes-001-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-view-img-attributes-001.html: Removed.
web-platform-tests/cssom-view/cssom-view-window-screen-interface-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-view-window-screen-interface.html: Removed.
web-platform-tests/cssom-view/cssom-view/media-query-list-interface-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht: Removed.
web-platform-tests/cssom-view/cssom-view/w3c-import.log: Removed.
web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt: Removed.
web-platform-tests/cssom-view/cssom-view/window-interface.xht: Removed.
web-platform-tests/cssom-view/elementFromPoint-001-expected.txt: Removed.
web-platform-tests/cssom-view/elementFromPoint-001.html: Removed.
web-platform-tests/cssom-view/elementFromPoint-002-expected.txt: Removed.
web-platform-tests/cssom-view/elementFromPoint-002.html: Removed.
web-platform-tests/cssom-view/elementFromPoint-003-expected.txt: Removed.
web-platform-tests/cssom-view/elementFromPoint-003.html: Removed.
web-platform-tests/cssom-view/elementFromPoint-expected.txt: Removed.
web-platform-tests/cssom-view/elementFromPoint.html: Removed.
web-platform-tests/cssom-view/elementFromPosition-expected.txt: Removed.
web-platform-tests/cssom-view/elementFromPosition.html: Removed.
web-platform-tests/cssom-view/elementScroll-expected.txt: Removed.
web-platform-tests/cssom-view/elementScroll.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-iframes-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-iframes.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-invalid-cases-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-shadowroot-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-simple-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-simple.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-svg-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-svg.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint-table-expected.txt: Removed.
web-platform-tests/cssom-view/elementsFromPoint-table.html: Removed.
web-platform-tests/cssom-view/elementsFromPoint.html: Removed.
web-platform-tests/cssom-view/historical-expected.txt: Removed.
web-platform-tests/cssom-view/historical.html: Removed.
web-platform-tests/cssom-view/htmlelement-offset-width-001-expected.txt: Removed.
web-platform-tests/cssom-view/htmlelement-offset-width-001.html: Removed.
web-platform-tests/cssom-view/iframe.html: Removed.
web-platform-tests/cssom-view/interfaces-expected.txt: Removed.
web-platform-tests/cssom-view/interfaces.html: Removed.
web-platform-tests/cssom-view/matchMedia-expected.txt: Removed.
web-platform-tests/cssom-view/matchMedia.xht: Removed.
web-platform-tests/cssom-view/matchMediaAddListener-expected.txt: Removed.
web-platform-tests/cssom-view/matchMediaAddListener.html: Removed.
web-platform-tests/cssom-view/mouseEvent-expected.txt: Removed.
web-platform-tests/cssom-view/mouseEvent.html: Removed.
web-platform-tests/cssom-view/negativeMargins-expected.txt: Removed.
web-platform-tests/cssom-view/negativeMargins.html: Removed.
web-platform-tests/cssom-view/offsetParent_element_test-expected.txt: Removed.
web-platform-tests/cssom-view/offsetParent_element_test.html: Removed.
web-platform-tests/cssom-view/offsetTopLeftInScrollableParent-expected.txt: Removed.
web-platform-tests/cssom-view/offsetTopLeftInScrollableParent.html: Removed.
web-platform-tests/cssom-view/resources/elementsFromPoint.js: Removed.
web-platform-tests/cssom-view/resources/iframe1.html: Removed.
web-platform-tests/cssom-view/resources/iframe2.html: Removed.
web-platform-tests/cssom-view/resources/w3c-import.log: Removed.
web-platform-tests/cssom-view/scrollIntoView-shadow-expected.txt: Removed.
web-platform-tests/cssom-view/scrollIntoView-shadow.html: Removed.
web-platform-tests/cssom-view/scrollIntoView-smooth-expected.txt: Removed.
web-platform-tests/cssom-view/scrollIntoView-smooth.html: Removed.
web-platform-tests/cssom-view/scrollWidthHeight-expected.txt: Removed.
web-platform-tests/cssom-view/scrollWidthHeight.xht: Removed.
web-platform-tests/cssom-view/scrollWidthHeightWhenNotScrollable-expected.txt: Removed.
web-platform-tests/cssom-view/scrollWidthHeightWhenNotScrollable.xht: Removed.
web-platform-tests/cssom-view/scrolling-no-browsing-context-expected.txt: Removed.
web-platform-tests/cssom-view/scrolling-no-browsing-context.html: Removed.
web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks-expected.txt: Removed.
web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html: Removed.
web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001-expected.html: Removed.
web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001.html: Removed.
web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002-expected.html: Removed.
web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002.html: Removed.
web-platform-tests/cssom-view/scrollingElement.html: Removed.
web-platform-tests/cssom-view/scrollintoview-expected.txt: Removed.
web-platform-tests/cssom-view/scrollintoview.html: Removed.
web-platform-tests/cssom-view/support/1x1-green.png: Removed.
web-platform-tests/cssom-view/support/1x1-lime.png: Removed.
web-platform-tests/cssom-view/support/1x1-maroon.png: Removed.
web-platform-tests/cssom-view/support/1x1-navy.png: Removed.
web-platform-tests/cssom-view/support/1x1-red.png: Removed.
web-platform-tests/cssom-view/support/1x1-white.png: Removed.
web-platform-tests/cssom-view/support/60x60-gg-rr.png: Removed.
web-platform-tests/cssom-view/support/60x60-green.png: Removed.
web-platform-tests/cssom-view/support/60x60-red.png: Removed.
web-platform-tests/cssom-view/support/README: Removed.
web-platform-tests/cssom-view/support/a-green.css: Removed.
web-platform-tests/cssom-view/support/b-green.css: Removed.
web-platform-tests/cssom-view/support/c-red.css: Removed.
web-platform-tests/cssom-view/support/cat.png: Removed.
web-platform-tests/cssom-view/support/import-green.css: Removed.
web-platform-tests/cssom-view/support/import-red.css: Removed.
web-platform-tests/cssom-view/support/pattern-grg-rgr-grg.png: Removed.
web-platform-tests/cssom-view/support/pattern-grg-rrg-rgg.png: Removed.
web-platform-tests/cssom-view/support/pattern-rgr-grg-rgr.png: Removed.
web-platform-tests/cssom-view/support/pattern-tr.png: Removed.
web-platform-tests/cssom-view/support/ruler-h-50%.png: Removed.
web-platform-tests/cssom-view/support/ruler-h-50px.png: Removed.
web-platform-tests/cssom-view/support/ruler-v-100px.png: Removed.
web-platform-tests/cssom-view/support/ruler-v-50px.png: Removed.
web-platform-tests/cssom-view/support/square-purple.png: Removed.
web-platform-tests/cssom-view/support/square-teal.png: Removed.
web-platform-tests/cssom-view/support/square-white.png: Removed.
web-platform-tests/cssom-view/support/support/README: Removed.
web-platform-tests/cssom-view/support/support/swatch-green.png: Removed.
web-platform-tests/cssom-view/support/support/swatch-red.png: Removed.
web-platform-tests/cssom-view/support/support/w3c-import.log: Removed.
web-platform-tests/cssom-view/support/swatch-blue.png: Removed.
web-platform-tests/cssom-view/support/swatch-green.png: Removed.
web-platform-tests/cssom-view/support/swatch-lime.png: Removed.
web-platform-tests/cssom-view/support/swatch-orange.png: Removed.
web-platform-tests/cssom-view/support/swatch-red.png: Removed.
web-platform-tests/cssom-view/support/swatch-teal.png: Removed.
web-platform-tests/cssom-view/support/swatch-white.png: Removed.
web-platform-tests/cssom-view/support/swatch-yellow.png: Removed.
web-platform-tests/cssom-view/support/test-bl.png: Removed.
web-platform-tests/cssom-view/support/test-br.png: Removed.
web-platform-tests/cssom-view/support/test-inner-half-size.png: Removed.
web-platform-tests/cssom-view/support/test-outer.png: Removed.
web-platform-tests/cssom-view/support/test-tl.png: Removed.
web-platform-tests/cssom-view/support/test-tr.png: Removed.
web-platform-tests/cssom-view/support/w3c-import.log: Removed.
web-platform-tests/cssom-view/ttwf-js-cssomview-getclientrects-length-expected.txt: Removed.
web-platform-tests/cssom-view/ttwf-js-cssomview-getclientrects-length.html: Removed.
web-platform-tests/cssom-view/w3c-import.log: Removed.
web-platform-tests/cssom-view/window-screen-height-expected.txt: Removed.
web-platform-tests/cssom-view/window-screen-height-immutable-expected.txt: Removed.
web-platform-tests/cssom-view/window-screen-height-immutable.html: Removed.
web-platform-tests/cssom-view/window-screen-height.html: Removed.
web-platform-tests/cssom-view/window-screen-width-expected.txt: Removed.
web-platform-tests/cssom-view/window-screen-width-immutable-expected.txt: Removed.
web-platform-tests/cssom-view/window-screen-width-immutable.html: Removed.
web-platform-tests/cssom-view/window-screen-width.html: Removed.

LayoutTests:

Patch by Frederic Wang <fwang@free.fr> on 2018-09-03
Reviewed by Daniel Bates.

cssom-view tests were moved into web-platform-tests/css at r232903 but the old
directory and expectation were left. This patch finishes the migration.

TestExpectations:
platform/ios-simulator/imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001-expected.txt: Removed.
platform/ios-simulator/imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/cssom-view/elementFromPoint-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/cssom-view/scrollIntoView-smooth-expected.txt: Removed.
platform/ios/TestExpectations:

4:17 AM Changeset in webkit [235598] by Philippe Normand

5 edits in trunk/Source/WebCore

[GStreamer] elements registration clean-ups
https://bugs.webkit.org/show_bug.cgi?id=189192

Reviewed by Xabier Rodriguez-Calvar.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):
(WebCore::registerWebKitGStreamerElements): Deleted.

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::mimeTypeCache):
(WebCore::initializeGStreamerAndRegisterWebKitMSEElement): Deleted.
(WebCore::MediaPlayerPrivateGStreamerMSE::isAvailable): Deleted.

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

2:24 AM WebKitGTK/2.22.x edited by Carlos Garcia Campos

(diff)

2:06 AM Changeset in webkit [235597] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.22.0

WebKitGTK+ 2.22.0

2:06 AM Changeset in webkit [235596] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.0 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.22.0.

1:29 AM Changeset in webkit [235595] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.22/Tools

Merge r235588 - [WPE] 2.21.91 fails to build with ENABLE_MINIBROWSER
https://bugs.webkit.org/show_bug.cgi?id=189006

Reviewed by Darin Adler.

The MiniBrowser source code is missing from the tarball. Oops! Add it.

wpe/manifest.txt.in:

1:29 AM Changeset in webkit [235594] by Carlos Garcia Campos

7 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit

Merge r235529 - [GTK] Touchscreen pinch to zoom should scale the page like other platforms
https://bugs.webkit.org/show_bug.cgi?id=188746

Changes the pinch-to-zoom gesture to magnify/scale the page, rather than zooming in. Also resets this magnification when the zoom level is changed.

Patch by Justin Michaud <justin@justinmichaud.com> on 2018-08-30
Reviewed by Michael Catanzaro.

UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_set_zoom_level):

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::zoom): Deleted.

UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:
UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::ZoomGesture::handleZoom):
(WebKit::GestureController::ZoomGesture::scaleChanged):

UIProcess/gtk/GestureController.h:

1:29 AM Changeset in webkit [235593] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit

Merge r235499 - [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members
https://bugs.webkit.org/show_bug.cgi?id=189149

Reviewed by Michael Catanzaro.

Reorder members to shrink the size of AttachmentInfo so that
we can attach more attachments.

Platform/IPC/unix/ConnectionUnix.cpp:

1:29 AM Changeset in webkit [235592] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore

Merge r235373 - [GTK][JSC] Add warn_unused_result attribute to some APIs
https://bugs.webkit.org/show_bug.cgi?id=188983

Patch by Patrick Griffis <Patrick Griffis> on 2018-08-27
Reviewed by Michael Catanzaro.

API/glib/JSCValue.h:

1:29 AM Changeset in webkit [235591] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.22

Merge r235194 - Don't use WTF_CPU_MIPS when building for mips64
https://bugs.webkit.org/show_bug.cgi?id=188858

Reviewed by Michael Catanzaro.

CMakeLists.txt: Use WTF_CPU_MIPS64 for this architecture.

Sep 2, 2018:

8:41 PM Changeset in webkit [235590] by Alan Bujtas

3 edits
2 adds in trunk

REGRESSION (r191336): RenderFlexibleBox::adjustChildSizeForMinAndMax crashes in std::optional<>::value()
https://bugs.webkit.org/show_bug.cgi?id=189232
<rdar://problem/43886373>

Reviewed by Brent Fulgham.

Source/WebCore:

It's not guaranteed that RenderFlexibleBox::computeMainAxisExtentForChild() always returns with a valid value.

Test: fast/flexbox/crash-when-min-max-content-is-not-computed.html