Timeline

Sep 6, 2018:

10:55 PM Changeset in webkit [235780] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

ShadowRoot should have its own node flag
​https://bugs.webkit.org/show_bug.cgi?id=189392

Reviewed by Antti Koivisto.

Added IsShadowRootFlag and IsDocumentNodeFlag, and removed IsDocumentFragmentFlag and IsStyledElementFlag.
Also re-ordered flags to group flags used by subclasses below ones directly used by Node in
accordinate with the comment.

No new tests since there should be no behavioral change.

• dom/ContainerNode.h:

(WebCore::Node::isTreeScope const): Deleted.

• dom/Node.h:

(WebCore::Node::isStyledElement const): Check if this is a HTML, SVG, or MathML element instead.
(WebCore::Node::isDocumentNode const): Simply check IsDocumentNodeFlag.
(WebCore::Node::isTreeScope const): Check if this is a document or a shadow root Instead of comparing
the tree scope to this.
(WebCore::Node::isDocumentFragment const): Check if this is a container node which is neither document,
element, nor shadow root.
(WebCore::Node::isShadowRoot const): Simply check IsShadowRootFlag. This is the change needed to fix
the blockign bug 166748.
(WebCore::Node::flagIsShadowRoot): Added. Will be used in the bug 166748.

10:54 PM Changeset in webkit [235779] by bshafiei@apple.com

• 7 edits
  2 adds in branches/safari-606-branch

Cherry-pick r235721. rdar://problem/44212406

Source/WebCore:
The width of an empty or nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

If a page has an empty TextRun and attempts to paint it we can crash with a nullptr.

This patch recognizes that an empty TextRun should always produce a zero width, rather than
attempt to compute this value from font data. It also prevents ListBox from attempting to
paint a null string.

Test: fast/text/null-string-textrun.html

• platform/graphics/FontCascade.cpp: (WebCore::FontCascade::widthOfTextRange const): An empty TextRun has zero width. (WebCore::FontCascade::width const): Ditto.
• platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): ASSERT that the supplied String is non-null. (WebCore::TextRun::setText): Ditto.
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Don't attempt to paint a null string.

Source/WTF:
The width of an empty or nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

Most accessors in WTFString.cpp, such as isAllASCII(), hash(), etc., perform a nullptr check
before using m_impl, but is8Bit() does not.

This patch adds a check in the is8Bit() implementation to be consistent with other methods,
and to address a small number of crashes observed in testing.

• wtf/text/WTFString.h: (WTF::String::is8Bit const):

LayoutTests:
The width of a nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

• fast/text/null-string-textrun-expected.txt: Added.
• fast/text/null-string-textrun.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:40 PM Changeset in webkit [235778] by yusukesuzuki@slowstart.org

• 3 edits in trunk/Source/JavaScriptCore

[WebAssembly] Optimize JS to Wasm call by removing Vector allocation
​https://bugs.webkit.org/show_bug.cgi?id=189353

Reviewed by Mark Lam.

JS to Wasm call always allocates Vector for the arguments. This is really costly if the wasm function is small.
This patch adds an initial size parameter to the Vector to avoid allocations for small sized arguments.

• runtime/ArgList.h:
• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

9:24 PM Changeset in webkit [235777] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC] Inline replaced height calculation should use "used value"
​https://bugs.webkit.org/show_bug.cgi?id=189395

Reviewed by Antti Koivisto.

Use the already assigned width value (aka used value) instead of the computed value when computing the inline's height.
see ​https://www.w3.org/TR/CSS22/cascade.html#value-stages for "used" and "computed" value.

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

9:24 PM Changeset in webkit [235776] by yusukesuzuki@slowstart.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Clean up StructureStubClearingWatchpoint
​https://bugs.webkit.org/show_bug.cgi?id=189156

Reviewed by Saam Barati.

Cleaning up StructureStubClearingWatchpoint by holding StructureStubClearingWatchpoint in Bag
in WatchpointsOnStructureStubInfo. This removes hacky linked list code for StructureStubClearingWatchpoint.

• bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::WatchpointsOnStructureStubInfo::addWatchpoint):
(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint): Deleted.
(JSC::StructureStubClearingWatchpoint::push): Deleted.
(JSC::WatchpointsOnStructureStubInfo::~WatchpointsOnStructureStubInfo): Deleted.

• bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):

8:04 PM Changeset in webkit [235775] by Wenson Hsieh

• 43 edits in trunk/Source

Refactor WebCore::EditAction to be an 8-bit enum class
​https://bugs.webkit.org/show_bug.cgi?id=189383

Reviewed by Dan Bernstein.

Source/WebCore:

Currently, EditAction.h defines an EditAction as an enum. This patch changes EditAction to instead be an 8-bit-
wide enum class, and renames all EditAction values from EditAction(*) to EditAction::(*).

No change in behavior.

• editing/ApplyStyleCommand.h:

(WebCore::ApplyStyleCommand::create):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::apply):
(WebCore::deleteSelectionEditingActionForEditingAction):

• editing/CompositeEditCommand.h:

(WebCore::EditCommandComposition::wasCreateLinkCommand const):

• editing/CreateLinkCommand.h:
• editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):

• editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

• editing/DictationCommand.cpp:

(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):

• editing/EditAction.h:

(): Deleted.

• editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

• editing/EditCommand.h:
• editing/Editor.cpp:

(WebCore::inputEventDataForEditingStyleAndAction):
(WebCore::ClearTextCommand::editingAction const):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):

• editing/Editor.h:
• editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeInsertFragment):
(WebCore::executeBackColor):
(WebCore::executeFontName):
(WebCore::executeFontSize):
(WebCore::executeFontSizeDelta):
(WebCore::executeForeColor):
(WebCore::executeJustifyCenter):
(WebCore::executeJustifyFull):
(WebCore::executeJustifyLeft):
(WebCore::executeJustifyRight):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
(WebCore::executeStrikethrough):
(WebCore::executeSubscript):
(WebCore::executeSuperscript):
(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):
(WebCore::executeUnderline):
(WebCore::executeUnscript):

• editing/FormatBlockCommand.h:
• editing/IndentOutdentCommand.h:
• editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):

• editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::editingAction const):

• editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

• editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

• editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

• editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):
(WebCore::MoveSelectionCommand::editingAction const):

• editing/RemoveFormatCommand.h:
• editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):

• editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand):
(WebCore::ReplaceRangeWithTextCommand::doApply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

• editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

• editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
(WebCore::SpellingCorrectionCommand::doApply):

• editing/TextInsertionBaseCommand.h:
• editing/TypingCommand.cpp:

(WebCore::editActionForTypingCommand):
(WebCore::editActionIsDeleteByTyping):
(WebCore::TypingCommand::isBeforeInputEventCancelable const):
(WebCore::TypingCommand::inputEventData const):
(WebCore::TypingCommand::inputEventDataTransfer const):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::insertParagraphSeparator):

• editing/UnlinkCommand.h:
• editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::DictationCommandIOS):

• editing/ios/EditorIOS.mm:

(WebCore::Editor::removeUnchangeableStyles):

• page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

Source/WebKit:

• UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFontAttributes):
(WebKit::WebPage::changeFont):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

• WebView/WebHTMLView.mm:

(-[WebHTMLView pasteFont:]):
(-[WebHTMLView changeFont:]):
(-[WebHTMLView changeAttributes:]):
(-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
(-[WebHTMLView changeColor:]):

• WebView/WebView.mm:

(-[WebView setTypingStyle:]):

Source/WebKitLegacy/win:

• WebCoreSupport/WebEditorClient.cpp:

(undoNameForEditAction):

7:36 PM Changeset in webkit [235774] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Fix the build for non-Cocoa platforms after r235772.

• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

• platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):
(WebCore::Gradient::fill):

7:27 PM Changeset in webkit [235773] by Alan Bujtas

• 8 edits
  2 adds in trunk

[LFC] Add support for min/max-height percentage values.
​https://bugs.webkit.org/show_bug.cgi?id=189391

Reviewed by Antti Koivisto.

Source/WebCore:

The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height), and this element
is not absolutely positioned, the percentage value is treated as '0' (for 'min-height') or 'none' (for 'max-height').

Test: fast/block/block-only/min-max-height-percentage.html

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/block/block-only/min-max-height-percentage-expected.txt: Added.
• fast/block/block-only/min-max-height-percentage.html: Added.

6:36 PM Changeset in webkit [235772] by Megan Gardner

• 17 edits
  10 adds in trunk

Add Support for Conic Gradients
​https://bugs.webkit.org/show_bug.cgi?id=189329
<rdar://problem/21444701>

Reviewed by Simon Fraser.

Source/WebCore:

Add support for rendering CSS conic gradients.
The parsing work was already done, this just hooks up the data we have
with the CG functionality for conic gradients. Add the needed plumbing
to allow for this additional type and fill in the creation of
a conic gradient.

Tests: fast/gradients/conic-repeating.html

fast/gradients/conic.html

• css/CSSGradientValue.cpp:

(WebCore::createGradient):
(WebCore::LinearGradientAdapter::gradientLength const):
(WebCore::RadialGradientAdapter::gradientLength const):
(WebCore::ConicGradientAdapter::ConicGradientAdapter):
(WebCore::ConicGradientAdapter::gradientLength const):
(WebCore::ConicGradientAdapter::maxExtent const):
(WebCore::ConicGradientAdapter::normalizeStopsAndEndpointsOutsideRange):

Compute what the color stops should be if they extend past 0-1

(WebCore::CSSGradientValue::computeStops):
(WebCore::CSSConicGradientValue::createGradient):
(WebCore::LinearGradientAdapter::startPoint const): Deleted.
(WebCore::LinearGradientAdapter::endPoint const): Deleted.
(WebCore::RadialGradientAdapter::startPoint const): Deleted.
(WebCore::RadialGradientAdapter::endPoint const): Deleted.

Start and End points weren't very universal. All we really need from these
gradientAdapters is their length, so just ask for that instead.

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

• platform/graphics/Gradient.cpp:

(WebCore::Gradient::create):
(WebCore::Gradient::Gradient):
(WebCore::Gradient::type const):
(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

• platform/graphics/Gradient.h:
• platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

Source/WebCore/PAL:

Define the CG functionality for conic gradients.

• pal/spi/cg/CoreGraphicsSPI.h:

Source/WebKit:

Connect up web preferences to allow conic gradients to be turned on in the
experimental features menu.

• Shared/WebPreferences.yaml:

LayoutTests:

Simple tests to see if conic gradients are rendered properly.

• fast/gradients/conic-expected.html: Added.
• fast/gradients/conic-repeating-expected.html: Added.
• fast/gradients/conic-repeating.html: Added.
• fast/gradients/conic.html: Added.

5:24 PM Changeset in webkit [235771] by Simon Fraser

• 4 edits in trunk/Tools

Log when leak detection changes the test result
​https://bugs.webkit.org/show_bug.cgi?id=189293

Reviewed by Jon Lee.

When you have an "Leak" expectation in TestExpectations, it's confusing to see a test unexpectedly pass,
but then show up as an expected fail at the end (because leak detection happens at the end of a shard).
So log when leak detection changes a test result.

• Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._annotate_results_with_additional_failures):

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

5:21 PM Changeset in webkit [235770] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.21.92

Release WPE WebKit 2.21.92

5:05 PM Changeset in webkit [235769] by Wenson Hsieh

• 17 edits
  2 adds in trunk

[macOS] [WK2] Support changing attributes for selected text (text shadow, underline, strike-through)
​https://bugs.webkit.org/show_bug.cgi?id=189356
<rdar://problem/44185674>

Reviewed by Tim Horton.

Source/WebCore:

Add support for encoding and decoding FontAttributeChanges, so that we can send FontAttributeChanges over IPC in
WebKit2. Also change m_verticalAlign to a new VerticalAlignChange enum type, so that it's no longer tied to the
CSS property values of "vertical-align", and can be encoded/decoded separately from VerticalAlign in
RenderStyleConstants.

Test: FontManagerTests.ChangeAttributesWithFontEffectsBox

• editing/FontAttributeChanges.cpp:

(WebCore::FontAttributeChanges::createEditingStyle const):

• editing/FontAttributeChanges.h:

(WebCore::FontAttributeChanges::setVerticalAlign):
(WebCore::FontShadow::encode const):
(WebCore::FontShadow::decode):
(WebCore::FontAttributeChanges::encode const):
(WebCore::FontAttributeChanges::decode):

• platform/mac/WebCoreNSFontManagerExtras.mm:

(WebCore::computedFontAttributeChanges):

Source/WebKit:

Implement -[WKWebView changeAttributes:], so that WKWebView can carry out more types of font style changes via
NSFontPanel. This patch makes it possible to (1) change text shadow, (2) add or remove strike-through, and (3)
add or remove underlines from selected text using the font panel.

This builds on the mechanisms introduced in r235748 to compute font attribute changes in the UI process and
propagate this information to the web process, where we're able to create and apply an EditingStyle to the
current selection.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView changeAttributes:]):

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::changeFontAttributesFromSender):

• UIProcess/WebPageProxy.h:
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::changeFontAttributes):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Add boilerplate IPC support.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFontAttributes):

Tools:

Adds a new API test to verify that some font attributes (text shadow, underline, and strike-through) can be
added and removed using NSFontPanel.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FontManagerTests.mm:

Add the new API test.

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/mac/NSFontPanelTesting.h: Added.
• TestWebKitAPI/mac/NSFontPanelTesting.mm: Added.

Introduce a new file that extends NSFontPanel with some additional testing functionality. This includes the
ability to interact with the text shadow toggle button, choose the text shadow blur radius and opacity, and
change underline and strike-through styles.

(findSubviewOfClass):
(findMenuItemWithTitle):
(-[NSFontPanel fontEffectsBox]):

NSFontEffectsBox (an internal AppKit class) is the sender in the case where -changeAttributes: is invoked
through interaction with the font panel. To simulate this for testing, grab this font effects box and pass it
directory to -changeAttributes:.

(-[NSFontPanel chooseUnderlineMenuItemWithTitle:]):
(-[NSFontPanel chooseStrikeThroughMenuItemWithTitle:]):

The supported values for these menu items are "none" and "single", which adds a single underline or
strike-through to selected text. We grab these menu items by asking for the font panel's NSToolbar, and finding
the relevant menu items via toolbar item identifiers.

(-[NSFontPanel _didChangeAttributes]):
(-[NSFontPanel shadowBlurSlider]):
(-[NSFontPanel shadowOpacitySlider]):
(-[NSFontPanel shadowToggleButton]):
(-[NSFontPanel toggleShadow]):
(-[NSFontPanel shadowOpacity]):
(-[NSFontPanel setShadowOpacity:]):
(-[NSFontPanel shadowBlur]):
(-[NSFontPanel setShadowBlur:]):
(-[NSFontPanel _toolbarItemWithIdentifier:]):

4:52 PM Changeset in webkit [235768] by bshafiei@apple.com

• 7 edits in branches/safari-606-branch/Source

Versioning.

4:50 PM Changeset in webkit [235767] by bshafiei@apple.com

• 1 copy in tags/Safari-606.2.1

Tag Safari-606.2.1.

4:47 PM Changeset in webkit [235766] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.92 release.

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.21.92.

4:44 PM Changeset in webkit [235765] by msaboff@apple.com

• 3 edits
  1 add in trunk

Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=189380

Reviewed by Saam Barati.

JSTests:

New test.

• stress/math-pow-nan-to-zero-spec-type.js: Added.

(func):
(test):

Source/JavaScriptCore:

Account for the case where in Math.pow(NaN, y) where y could be 0.

• bytecode/SpeculatedType.cpp:

(JSC::typeOfDoublePow):

4:25 PM Changeset in webkit [235764] by Simon Fraser

• 10 edits in trunk/Tools

run-webkit-tests prints confusing messages when test expectations list results that are not compatible with the run options
​https://bugs.webkit.org/show_bug.cgi?id=189219

Reviewed by Jon Lee.

If you call run-webkit-tests without --pixel-tests, and a non-ref test is marked as ImageOnlyFailure,
it will be reported as unexpectedly passing. This is more confusing if you run without --world-leaks, yet
tests are marked as [ Leak ] in TestExpectations.

Fix by filtering out expectations that don't apply given the run options. So without --pixel-tests,
a non-ref ImageOnlyFailure becomes a Pass, and without --world-leaks, a Leak becomes a Pass.

Add various unit tests to test the various combinations.

• Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner._annotate_results_with_additional_failures):

• Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel.get_expectations_or_pass):
(TestExpectationsModel):
(TestExpectationsModel.expectations_to_string):
(TestExpectationsModel.get_expectations_string):
(TestExpectations.filtered_expectations_for_test):
(TestExpectations):
(TestExpectations.matches_an_expected_result):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
• Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

• Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):
(SummarizedResultsTest.setUp):
(SummarizedResultsTest.test_summarized_results_include_passes):
(SummarizedResultsTest):
(SummarizedResultsTest.test_summarized_results_world_leaks_disabled):

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
• Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:

(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results_with_options):
(BuildBotPrinterTests.test_print_results):

• Scripts/webkitpy/port/test.py:

(unit_test_list):

3:39 PM Changeset in webkit [235763] by Alan Bujtas

• 10 edits
  6 adds in trunk

[LFC][BFC] Add support for min(max)-height
​https://bugs.webkit.org/show_bug.cgi?id=189377

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/CSS22/visudet.html#min-max-heights for details.

Tests: fast/block/block-only/absolute-position-min-max-height.html

fast/block/block-only/float-min-max-height.html
fast/block/block-only/inflow-min-max-height.html

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

• layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/block/block-only/absolute-position-min-max-height-expected.txt: Added.
• fast/block/block-only/absolute-position-min-max-height.html: Added.
• fast/block/block-only/float-min-max-height-expected.txt: Added.
• fast/block/block-only/float-min-max-height.html: Added.
• fast/block/block-only/inflow-min-max-height-expected.txt: Added.
• fast/block/block-only/inflow-min-max-height.html: Added.

3:32 PM Changeset in webkit [235762] by Dewei Zhu

• 3 edits in trunk/Tools

BenchmarkResults.format should support specifying depth of tests to show.
​https://bugs.webkit.org/show_bug.cgi?id=189135

Reviewed by Ryosuke Niwa.

Added the option to specify the depth of tests to show.

• Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults):
(BenchmarkResults.format): Added 'max_depth' option.
(BenchmarkResults._format_tests): Added unit tests for 'max_depth'.

3:25 PM Changeset in webkit [235761] by Simon Fraser

• 3 edits in trunk/Tools

An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures
​https://bugs.webkit.org/show_bug.cgi?id=189368

Reviewed by Alexey Proskuryakov.

Include FailureDocumentLeak in ALL_FAILURE_CLASSES (with a fairly redundant test),
which should fix EWS showing leaks in Bugzilla.

• Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureDocumentLeak.init):

• Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_all_failure_classes):

3:10 PM Changeset in webkit [235760] by eric.carlson@apple.com

• 12 edits in trunk/Source/WebCore

[MediaStream] Include supported frame rates in video capture presets
​https://bugs.webkit.org/show_bug.cgi?id=189351
<rdar://problem/44188917>

Reviewed by Youenn Fablet.

No new tests, no functionality changed.

Include frame rates as well as width/height in video capture presets, so the mock video
capture devices model real camera devices more closely.

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setSizeAndFrameRate): Renamed from applySizeAndFrameRate. Use
setSize instead of setWidth and setHeight.
(WebCore::RealtimeMediaSource::applyConstraints): applySizeAndFrameRate -> setSizeAndFrameRate.
(WebCore::RealtimeMediaSource::applySizeAndFrameRate): Deleted.
(WebCore::RealtimeMediaSource::setWidth): Deleted.
(WebCore::RealtimeMediaSource::setHeight): Deleted.

• platform/mediastream/RealtimeMediaSource.h:

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::setSupportedPresets): New.
(WebCore::updateMinMax):
(WebCore::RealtimeVideoSource::addSupportedCapabilities const): Calculate capabilities from
presets.
(WebCore::RealtimeVideoSource::supportsSizeAndFrameRate): Use bestSupportedSizeAndFrameRate.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate):
(WebCore::RealtimeVideoSource::setSizeAndFrameRate):
(WebCore::RealtimeVideoSource::setSupportedFrameRates): Deleted.
(WebCore::RealtimeVideoSource::bestSupportedCaptureSizeForWidthAndHeight): Deleted.
(WebCore::RealtimeVideoSource::applySizeAndFrameRate): Deleted.
(WebCore::RealtimeVideoSource::supportsFrameRate): Deleted.

• platform/mediastream/RealtimeVideoSource.h:

(WebCore::RealtimeVideoSource::setSupportedCaptureSizes): Deleted.

• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoCaptureSource::stopProducingData):

• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSizeAndFrameRate):
(WebCore::AVVideoCaptureSource::applySizeAndFrameRate): Deleted.

• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream):

• platform/mock/MockMediaDevice.h:

(WebCore::MockCameraProperties::encode const):
(WebCore::MockCameraProperties::decode):
(WebCore::MockDisplayProperties::encode const):
(WebCore::MockDisplayProperties::decode):

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::capabilities const):
(WebCore::MockRealtimeVideoSource::settings const):

2:52 PM WebKitGTK/StableRelease edited by Adrian Perez de Castro

Add link to the 2.22.x releases wiki page (diff)

2:48 PM Changeset in webkit [235759] by dbates@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

[iOS] Add a test to ensure that DOM keyup events have the correct details
​https://bugs.webkit.org/show_bug.cgi?id=189327

Reviewed by Wenson Hsieh.

Until we fix <rdar://problem/35282761> DOM keyup events will have incorrect details on iOS
when dispatched in response to a hardware keyboard press. For now, land expected failure results.

• fast/events/ios/keyup-expected.txt: Added.
• fast/events/ios/keyup.html: Added.
• resources/ui-helper.js:

(window.UIHelper.typeCharacter): Escape backslash characters in order to build up
a well-formed UI script to evaluate.

2:37 PM Changeset in webkit [235758] by Antti Koivisto

• 11 edits
  2 adds in trunk/Source

Actively prewarm processes created for prewarm pool
​https://bugs.webkit.org/show_bug.cgi?id=189364

Reviewed by Chris Dumez.

Source/WebCore:

Do some basic prewarming for newly created processes.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):

• css/CSSDefaultStyleSheets.h:
• page/Frame.cpp:

(WebCore::Frame::Frame):

• page/ProcessWarming.cpp: Added.

(WebCore::ProcessWarming::initializeNames):

Factor name initialization into a function.

(WebCore::ProcessWarming::prewarm):

Prewarm

• names
• settings (system fonts)
• user agent stylesheet
• JavaScript VM
• telephone number detection

• page/ProcessWarming.h: Added.

Source/WebKit:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prewarm):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

2:14 PM Changeset in webkit [235757] by youenn@apple.com

• 9 edits in trunk/Source/WebCore

Move replaceTrack logic to RTCRtpSender backend
​https://bugs.webkit.org/show_bug.cgi?id=189359

Reviewed by Eric Carlson.

Move replaceTrack handling from LibWebRTCPeerConnectionBackend to LibWebRTCRtpSenderBackend.
This will allow using SetTrack when fully implementing unified plan.
No change of behavior.

• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack):

• Modules/mediastream/RTCRtpSender.h:
• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/RTCRtpSenderBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack): Deleted.
(WebCore::LibWebRTCPeerConnectionBackend::enqueueReplaceTrackTask): Deleted.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::updateTrackSource):
(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:

2:09 PM Changeset in webkit [235756] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Unreviewed, rolling out r235755.
​https://bugs.webkit.org/show_bug.cgi?id=189367

Didn't address the review comment (Requested by rniwa on
#webkit).

Reverted changeset:

"BenchmarkResults.format should support specifying depth of
tests to show."
​https://bugs.webkit.org/show_bug.cgi?id=189135
​https://trac.webkit.org/changeset/235755

1:47 PM Changeset in webkit [235755] by Dewei Zhu

• 3 edits in trunk/Tools

BenchmarkResults.format should support specifying depth of tests to show.
​https://bugs.webkit.org/show_bug.cgi?id=189135

Reviewed by Ryosuke Niwa.

Added the option to specify the depth of tests to show.

• Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults):
(BenchmarkResults.format): Added 'max_depth' option.
(BenchmarkResults._format_tests): Added unit tests for 'max_depth'.

1:42 PM Changeset in webkit [235754] by aestes@apple.com

• 10 edits in trunk

[Apple Pay] Rename the -apple-pay-button-type value "checkout" to "check-out"
​https://bugs.webkit.org/show_bug.cgi?id=189366
<rdar://problem/44193218>

Reviewed by Sam Weinig.

Source/WebCore:

The button title is "Check out with Apple Pay", so we should use the verb phrase "check out"
rather than the noun "checkout" for naming this value.

Updated http/tests/ssl/applepay/ApplePayButtonV4.html.

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):

• css/CSSValueKeywords.in:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

• rendering/RenderThemeCocoa.mm:

(WebCore::toPKPaymentButtonType):

• rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

• UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

• http/tests/ssl/applepay/ApplePayButtonV4.html:

1:36 PM Changeset in webkit [235753] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[WHLSL] Call arguments should be copied as soon as they are evaluated
​https://bugs.webkit.org/show_bug.cgi?id=189360

Patch by Thomas Denney <​tdenney@apple.com> on 2018-09-06
Reviewed by Myles C. Maxfield.

Previously all call arguments were evaluated and then their results were
copied into new buffers for the call. However, the results are not
necessarily independent, so the result should be copied immediately
after evaluation.

• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitCallExpression): Move location of copy.
(Evaluator):

• WebGPUShadingLanguageRI/Test.js: Add new test to verify correct

behavior.

12:59 PM Changeset in webkit [235752] by jer.noble@apple.com

• 17 edits in trunk/Source

Don't pause playback when locking screen if video is being displayed on second screen.
​https://bugs.webkit.org/show_bug.cgi?id=189321

Reviewed by Eric Carlson.

Source/WebCore:

Expand the existing behavior when AirPlaying to an external device to playing to a local
external screen. Don't pause when the screen locks, and don't stop buffering in that mode either.

Add a KVO-observer to the WebAVPlayerController's playingOnSecondScreen property, and pass
that observed value on to the media element.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget):
(WebCore::HTMLMediaElement::setPlayingOnSecondScreen):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
(WebCore::HTMLMediaElement::processingUserGestureForMedia const):
(WebCore::HTMLMediaElement::mediaState const):
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundLoadingRestriction const):
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless const): Deleted.
(WebCore::HTMLMediaElement::canPlayToWirelessPlaybackTarget const): Deleted.
(WebCore::HTMLMediaElement::isPlayingToWirelessPlaybackTarget const): Deleted.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless const):
(WebCore::HTMLMediaElement::isPlayingToExternalTarget const):

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canPlayToWirelessPlaybackTarget const): Deleted.

• html/MediaElementSession.h:
• platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSessionClient::setWirelessPlaybackTarget):
(WebCore::PlatformMediaSessionClient::isPlayingOnSecondScreen const):
(WebCore::PlatformMediaSession::canPlayToWirelessPlaybackTarget const): Deleted.
(WebCore::PlatformMediaSessionClient::canPlayToWirelessPlaybackTarget const): Deleted.

• platform/cocoa/PlaybackSessionModel.h:
• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::setPlayingOnSecondScreen):

• platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController init]):
(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController observeValueForKeyPath:ofObject:change:context:]):

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::setPlayingOnSecondScreen):

Source/WebKit:

Pass the "isPlayingOnSecondScreen" value across the process boundary.

• UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
• UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::setPlayingOnSecondScreen):
(WebKit::PlaybackSessionManagerProxy::setPlayingOnSecondScreen):

• WebProcess/cocoa/PlaybackSessionManager.h:
• WebProcess/cocoa/PlaybackSessionManager.messages.in:
• WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::setPlayingOnSecondScreen):

12:58 PM Changeset in webkit [235751] by mark.lam@apple.com

• 1 edit
  1 move in trunk/JSTests

Gardening: Move regress-189185.js under JSTests/wasm.
​https://bugs.webkit.org/show_bug.cgi?id=189347

Unreviewed.

• stress/regress-189185.js: Removed.
• wasm/regress/regress-189185.js: Copied from JSTests/stress/regress-189185.js.

12:58 PM Changeset in webkit [235750] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WHLSL] The test suite should log the compile time for the standard library
​https://bugs.webkit.org/show_bug.cgi?id=189354

Patch by Thomas Denney <​tdenney@apple.com> on 2018-09-06
Reviewed by Myles C. Maxfield.

The test suite previously only logged the time for test execution, and
not the compile time for the standard library.

• WebGPUShadingLanguageRI/Test.js:

12:48 PM Changeset in webkit [235749] by commit-queue@webkit.org

• 11 edits in trunk/Source

Group options of scrollRectToVisible into a struct
​https://bugs.webkit.org/show_bug.cgi?id=189352

Patch by Frederic Wang <​fwang@igalia.com> on 2018-09-06
Reviewed by Simon Fraser.

Source/WebCore:

RenderLayer::scrollRectToVisible and RenderObject::scrollRectToVisible have several
parameters to configure the type of scrolling. This patch groups the const options into a
single struct to make easier to handle them in the future. For example, an #ifdefed scroll
behavior option will be added in bug 188043. This refactoring can maybe help too for other
scroll extensions (e.g. bug 176454 and bug 161611).

No new tests, behavior unchanged.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToMakeVisible const): Pass options via a struct.

• dom/Element.cpp:

(WebCore::Element::scrollIntoView): Ditto.
(WebCore::Element::scrollIntoViewIfNeeded): Ditto.
(WebCore::Element::scrollIntoViewIfNotVisible): Ditto.

• editing/FrameSelection.cpp: Include RenderLayer.h in all WebKit ports in order to define

ScrollRectToVisibleOptions.
(WebCore::FrameSelection::revealSelection): Pass options via a struct.

• page/FrameView.cpp:

(WebCore::FrameView::scrollToFocusedElementInternal): Ditto.
(WebCore::FrameView::scrollToAnchor): Ditto.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible): Pass options via a struct. Note that
absoluteRect and insideFixed are modified in this function.
(WebCore::RenderLayer::autoscroll): Pass options via a struct.

• rendering/RenderLayer.h: Add ScrollRectToVisibleOptions and use it in order to pass

scrollRectToVisible options.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::scrollRectToVisible): Pass options via a struct

• rendering/RenderObject.h: Forward-declare ScrollRectToVisibleOptions and use in order to

pass scrollRectToVisible options.

Source/WebKitLegacy/mac:

• WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.

(-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
(-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.

12:46 PM Changeset in webkit [235748] by Wenson Hsieh

• 20 edits
  6 adds in trunk

[macOS] Cannot change font size at selection until font panel is shown
​https://bugs.webkit.org/show_bug.cgi?id=189295
<rdar://problem/35593389>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, attempting to alter the font size of currently selected editable text in WKWebView via menu items
will fail if the font panel has never been shown. This is because WebViewImpl::changeFontFromFontPanel, which is
responsible for converting the current font at the selection to the new font using -[NSFontManager convertFont:]
bails as a result of NSFontManager's currently selected font always being nil.

WKWebView is responsible for keeping NSFontManager up-to-date with the currently selected font; in fact, this
was initially the case in r180465, which introduced NSFontManager support in WebKit2 by propagating EditorState
updates that contained font information for the current selection. However, this regressed performance due to
selected font computation triggering extra layout passes; r180768 addressed this by introducing a mechanism for
requesting the font at the current selection, and only updating NSFontManager with the new selected font when
the shared font panel is visible (determined by KVO on NSFontPanel). However, this again regressed WKWebView
launch performance, due to KVO registration always forcing the shared NSFontPanel to be created. r182037
addressed this by only registering for KVO on the font panel if the WKWebView has been made editable (SPI on
WKWebView).

This leads to two issues when attempting to alter font attributes using macOS UI: (1) in web views that have not
been made editable using SPI, showing the font panel and attempting to change the font fails due to the selected
font staying nil, because we've never begun registering for KVO notifications on the font panel so we don't try
to keep the font manager up to date. (2) Even if the web view is made editable, if the font panel is never
shown, then the font manager still won't be kept up to date with the current selection, so changing fonts using
menu items still does not work.

We fix both of these problems by refactoring font manager support on WebKit2 such that an up-to-date selected
font in the UI process is no longer necessary in order to alter the font at the current selection. To do this,
we figure out what changes the NSFontManager would've made to the currently selected font in the UI process, and
then propagate this information to the web process, where we convert this information into an EditingStyle which
we apply to the current selection.

The code to both determine the attributes changed by NSFontManager and to convert these attributes into editing
styles to be applied via Editor already exists in WebKitLegacy, in WebHTMLView.mm. This patch moves this
existing logic into WebCore and teases it apart into two portions: the first portion probes NSFontManager to
determine which aspects of the font changed and constructs FontChanges, which captures these differences. The
second portion maps FontChanges to an EditingStyle, which can then be applied to the current selection. In
WebKitLegacy, we construct FontChanges using the font manager, and then immediately use it to create and apply
an EditingStyle. In WebKit, we construct FontChanges in the UI process using the font manager, and then send
this over to the web process via WebPage::changeFont, which then creates and applies the EditingStyle.

Note that this patch also introduces FontAttributeChanges, which is similar in concept to FontChanges, but
captures a broader range of changes possible via NSFontPanel. This was done so that we can eliminate all of the
font manager probing code (along with the two specimen fonts) from WebHTMLView, but is also necessary in order
to allow changing font shadow, strikethrough, and underlines via the font panel to work in WebKit2. This will be
fixed in a followup, by making FontAttributeChanges IPC encodable and by making WKWebView/WKView respond to the
-changeAttributes: selector.

Changes in behavior to WebKit2 are covered by new API tests; legacy WebKit behavior should remain unchanged.

Tests: FontManagerTests.ChangeFontSizeWithMenuItems

FontManagerTests.ChangeFontWithPanel

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/Editor.h:

Remove applyFontStyles.

• editing/FontAttributeChanges.cpp: Added.

(WebCore::FontChanges::platformFontFamilyNameForCSS const):

Given a font family name and a font name, returns the string to use as the "font-family" style property value.
Originally from WebHTMLView.mm.

(WebCore::FontChanges::createEditingStyle const):

Converts font changes to an EditingStyle that can be used to apply these changes.

(WebCore::FontChanges::createStyleProperties const):

Introduce FontChanges, which encapsulates changes which are to be applied to the font in the current selection.

(WebCore::cssValueListForShadow):
(WebCore::FontAttributeChanges::createEditingStyle const):

Converts font attribute changes to an EditingStyle that can be used to apply these changes.

• editing/FontAttributeChanges.h: Added.

Introduce FontAttributeChanges, which encapsulates changes which are to be applied to the font attributes in the
current selection. This includes a set of FontChanges, as well as additional attributes such as strike-through
and underlines.

(WebCore::FontChanges::setFontName):
(WebCore::FontChanges::setFontFamily):
(WebCore::FontChanges::setFontSize):
(WebCore::FontChanges::setFontSizeDelta):
(WebCore::FontChanges::setBold):
(WebCore::FontChanges::setItalic):
(WebCore::FontAttributeChanges::setVerticalAlign):
(WebCore::FontAttributeChanges::setBackgroundColor):
(WebCore::FontAttributeChanges::setForegroundColor):
(WebCore::FontAttributeChanges::setShadow):
(WebCore::FontAttributeChanges::setStrikeThrough):
(WebCore::FontAttributeChanges::setUnderline):
(WebCore::FontAttributeChanges::setFontChanges):

Setters for FontChanges and FontAttributeChanges. Initially, most of these values are optional, indicating that
there should be no change.

(WebCore::FontChanges::encode const):
(WebCore::FontChanges::decode):

Add encoding/decoding support to FontChanges, so that it can be sent over IPC for WebKit2.

• editing/cocoa/FontAttributeChangesCocoa.mm: Added.

(WebCore::FontChanges::platformFontFamilyNameForCSS const):

Helper method to determine whether the font family or the font name should be used, by looking up the PostScript
font name using a FontDescriptor and comparing it against the result of -[NSFont fontName]. This logic was
originally in WebHTMLView.mm.

• editing/mac/EditorMac.mm:

(WebCore::Editor::applyFontStyles): Deleted.

• platform/mac/WebCoreNSFontManagerExtras.h: Added.
• platform/mac/WebCoreNSFontManagerExtras.mm: Added.

Add helper functions to compute FontChanges and FontAttributeChanges from NSFontManager.

(WebCore::firstFontConversionSpecimen):
(WebCore::secondFontConversionSpecimen):

Two "specimen fonts" used to determine what changes NSFontManager or NSFontPanel makes when performing font or
font attribute conversion. Moved from WebHTMLView.mm.

(WebCore::computedFontChanges):
(WebCore::computedFontAttributeChanges):

Moved here from WebHTMLView.mm. Instead of converting font attributes to NSStrings and setting properties on
DOMCSSStyleDeclaration, we instead specify properties on MutableStyleProperties using CSSValues.

Source/WebKit:

Refactors NSFontManager support in WebKit2. See WebCore ChangeLog for more details.

• Scripts/webkit/messages.py:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView changeFont:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView changeFont:]):

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::changeFontFromFontManager):
(WebKit::WebViewImpl::changeFontFromFontPanel): Deleted.

Renamed this from changeFontFromFontPanel to changeFontFromFontManager. This new name is more accurate in the
case where a menu item is used to alter the font, which doesn't involve NSFontPanel at all.

• UIProcess/WebPageProxy.h:
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::changeFont):
(WebKit::WebPageProxy::setFont): Deleted.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFont):
(WebKit::WebPage::setFont): Deleted.

Source/WebKitLegacy/mac:

Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
WebCore ChangeLog for more details.

• WebView/WebHTMLView.mm:

(-[WebHTMLView changeFont:]):
(-[WebHTMLView changeAttributes:]):
(-[WebHTMLView _originalFontA]): Deleted.
(-[WebHTMLView _originalFontB]): Deleted.
(fontNameForDescription): Deleted.
(-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
(-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
(-[WebHTMLView _styleForAttributeChange:]): Deleted.

Tools:

Add API tests to simulate using menu items to increase or decrease font size, and also simulate using
NSFontPanel to specify the font family, font size, and other traits.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FontManagerTests.mm: Added.

(-[TestWKWebView selectedText]):
(-[TestWKWebView selectNextWord]):
(-[TestWKWebView stylePropertyAtSelectionStart:]):
(-[TestWKWebView stylePropertyAtSelectionEnd:]):
(webViewForFontManagerTesting):
(menuItemCellForFontAction):
(TestWebKitAPI::TEST):

11:58 AM WebKitGTK/2.22.x edited by berto@igalia.com

(diff)

11:52 AM Changeset in webkit [235747] by bshafiei@apple.com

• 7 edits in tags/Safari-607.1.5.2/Source

Versioning.

11:49 AM Changeset in webkit [235746] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.5.2

Tag Safari-607.1.5.2.

11:07 AM Changeset in webkit [235745] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/JavaScriptCore

Cherry-pick r235742. rdar://problem/44169344

Gardening: only visit m_cachedStructureID if it's not null.
​https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Not reviewed.

• runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::visitChildren):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:03 AM Changeset in webkit [235744] by Alan Bujtas

• 10 edits
  6 adds in trunk

[LFC][BFC] Add support for min(max)-width
​https://bugs.webkit.org/show_bug.cgi?id=189358

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/CSS22/visudet.html#min-max-widths for details.

Tests: fast/block/block-only/absolute-position-min-max-width.html

fast/block/block-only/float-min-max-width.html
fast/block/block-only/inflow-min-max-width.html

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):

• layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/block/block-only/absolute-position-min-max-width-expected.txt: Added.
• fast/block/block-only/absolute-position-min-max-width.html: Added.
• fast/block/block-only/float-min-max-width-expected.txt: Added.
• fast/block/block-only/float-min-max-width.html: Added.
• fast/block/block-only/inflow-min-max-width-expected.txt: Added.
• fast/block/block-only/inflow-min-max-width.html: Added.

10:59 AM Changeset in webkit [235743] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[MediaStream] Initialize AVVideoCapture video presets
​https://bugs.webkit.org/show_bug.cgi?id=189355

Reviewed by Youenn Fablet.

No new tests, no functionality changed.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::AVVideoCaptureSource): Don't try to load symbols if they
aren't available.

10:46 AM Changeset in webkit [235742] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: only visit m_cachedStructureID if it's not null.
​https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Not reviewed.

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

9:56 AM Changeset in webkit [235741] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebKit

Use more generic names than "overflow" for functions that can be used for subframes
​https://bugs.webkit.org/show_bug.cgi?id=179125

Patch by Frederic Wang <​fwang@igalia.com> on 2018-09-06
Reviewed by Simon Fraser..

Some functions will be used by subframes when iframe scrolling is implemented on iOS (see
bug 149264). Currently they are only used for "overflow" nodes. This patch renames them to
use a more generic "scrolling node" name.

• UIProcess/PageClient.h:
• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):

• UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartPanGesture):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartScroll):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidEndScroll):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::scrollingNodeScrollViewWillStartPanGesture):
(WebKit::PageClientImpl::scrollingNodeScrollViewDidScroll):
(WebKit::PageClientImpl::scrollingNodeScrollWillStartScroll):
(WebKit::PageClientImpl::scrollingNodeScrollDidEndScroll):
(WebKit::PageClientImpl::overflowScrollViewWillStartPanGesture): Deleted.
(WebKit::PageClientImpl::overflowScrollViewDidScroll): Deleted.
(WebKit::PageClientImpl::overflowScrollWillStartScroll): Deleted.
(WebKit::PageClientImpl::overflowScrollDidEndScroll): Deleted.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _scrollingNodeScrollingWillBegin]):
(-[WKContentView _scrollingNodeScrollingDidEnd]):
(-[WKContentView _overflowScrollingWillBegin]): Deleted.
(-[WKContentView _overflowScrollingDidEnd]): Deleted.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::scrollingNodeScrollViewWillStartPanGesture):
(WebKit::WebPageProxy::scrollingNodeScrollViewDidScroll):
(WebKit::WebPageProxy::scrollingNodeScrollWillStartScroll):
(WebKit::WebPageProxy::scrollingNodeScrollDidEndScroll):
(WebKit::WebPageProxy::overflowScrollViewWillStartPanGesture): Deleted.
(WebKit::WebPageProxy::overflowScrollViewDidScroll): Deleted.
(WebKit::WebPageProxy::overflowScrollWillStartScroll): Deleted.
(WebKit::WebPageProxy::overflowScrollDidEndScroll): Deleted.

• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::didStartOverflowScroll):
(WebKit::WebChromeClient::didEndOverflowScroll):

9:41 AM Changeset in webkit [235740] by tpopela@redhat.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Build broken after r234975 on s390x, ppc64le, armv7hl
​https://bugs.webkit.org/show_bug.cgi?id=189078

Reviewed by Mark Lam.

Caused by the GCC bug - ​https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70124.
Using the ternary operator instead of std::max() fixes it.

• heap/RegisterState.h:

9:12 AM Changeset in webkit [235739] by Chris Dumez

• 3 edits in trunk/Source/WebKit

WebKit/Platform/IPC/mac/ConnectionMac.mm:222: _dispatch_bug_kevent_vanished
​https://bugs.webkit.org/show_bug.cgi?id=189314
<rdar://problem/41248286>

Reviewed by Anders Carlsson.

There is a short period in time when m_isServer is true, after open() has been
called, but before we've receive the InitializeConnection IPC, where m_receiveSource
has been initialized but m_isConnected is still false. If platformInvalidate() gets
called during this period of time, we would fail to cancel / release m_receiveSource
and we would forcefully deallocate m_receivePort, leading to the libdispatch simulated
crashes.

To address the issue, platformInvalidate() now properly cancels / releases
m_receiveSource if present, and only deallocates m_receivePort manually if m_receiveSource
has not been initialized (i.e. open() has not been called yet).

• Platform/IPC/Connection.h:
• Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInvalidate):
(IPC::Connection::clearReceiveSource):

9:01 AM Changeset in webkit [235738] by mmaxfield@apple.com

• 11 edits
  1 copy in trunk/Tools

[WHLSL] The parser is too slow
​https://bugs.webkit.org/show_bug.cgi?id=189014

Reviewed by Filip Pizlo.

This patch includes three changes:

1. Migrate from using try/catch to simply returning the WSyntaxError. This means that each parser call has to check for this sentinel value. The lexer still can throw if it encounters an unknown token or an unmatched "/*" token (which is rare).
2. After removing try/catch, making the sentinel values not inherit from Error (the Error constructor was taking lots of time)
3. Previously, every time the parser failed (which is many times per expression) it was running a regex over the entire source text to figure out where the error occurred. Instead, we can preprocess the text string to find these line numbers ahead of time.

Together, these make the parser 75x faster. Parsing the standard library goes from 2.5
hours down to 2 minutes. Because it's now a reasonable length, this patch uncomments
the bulk of the standard library.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/Lexer.js:

(Lexer):
(Lexer.prototype.lineNumberForIndex):

• WebGPUShadingLanguageRI/Parse.js:

(fail):
(backtrackingScope):
(testScope):
(genericConsume):
(consumeEndOfTypeArgs):
(parseTerm):
(parseConstexpr):
(parseTypeArguments):
(parseType.getAddressSpace):
(parseType):
(parseTypeDef):
(genericParseLeft):
(parseCallExpression.let.parseArguments):
(isCallExpression):
(parseSuffixOperator):
(parsePossibleSuffix):
(parsePreIncrement):
(parsePossiblePrefix):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(parsePostIncrement):
(parseEffectfulExpression):
(genericParseCommaExpression):
(parseEffectfulStatement):
(parseReturn):
(parseBreak):
(parseContinue):
(parseIfStatement):
(parseWhile):
(parseFor):
(parseDo):
(parseVariableDecls):
(parseSwitchCase):
(parseSwitchStatement):
(parseStatement):
(parseBlockBody):
(parseBlock):
(parseParameter):
(parseFuncName):
(parseFuncDecl):
(parseFuncDef):
(parseField):
(parseStructType):
(parseNativeFunc):
(parseNative):
(parseRestrictedFuncDef):
(parseEnumMember):
(parseEnumType):
(parse):

• WebGPUShadingLanguageRI/SPIRV.html:
• WebGPUShadingLanguageRI/StandardLibrary.js:

(let.standardLibrary):

• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(checkFail.doPrep): Deleted.

• WebGPUShadingLanguageRI/WLexicalError.js: Added.

(WLexicalError):

• WebGPUShadingLanguageRI/index.html:

8:00 AM Changeset in webkit [235737] by magomez@igalia.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening after r235732.

• platform/gtk/TestExpectations:

6:51 AM Changeset in webkit [235736] by ajuma@chromium.org

• 8 edits
  6 adds in trunk

IntersectionObserver leaks documents
​https://bugs.webkit.org/show_bug.cgi?id=189128

Reviewed by Simon Fraser.

Source/WebCore:

Currently, Documents own IntersectionObservers while IntersectionObservers own callbacks
that have strong references to Documents. To break this cycle, make Documents only have
weak pointers to IntersectionObservers. Instead, manage the lifetime of an
IntersectionObserver as an ActiveDOMObject, overriding hasPendingActivity to keep
the observer alive while there are ongoing observations.

However, there is a still a potential reference cycle. The callback keeps global
references alive, so if there's a global reference to the observer in JavaScript,
we have an observer->callback->observer cycle, keeping the callback (and hence the Document)
alive. To break this cycle, make IntersectionObserver release the callback when its
Document is stopped.

With these changes, there are no longer any leaks reported with run-webkit-tests --world-leaks
on LayoutTests/intersection-observer and LayoutTests/imported/w3c/web-platform-tests/intersection-observer.

Tests: intersection-observer/no-document-leak.html

intersection-observer/observer-and-callback-without-js-references.html

• dom/Document.cpp:

(WebCore::Document::addIntersectionObserver):
(WebCore::Document::removeIntersectionObserver):

• dom/Document.h:
• dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument):

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::observe):
(WebCore::IntersectionObserver::rootDestroyed):
(WebCore::IntersectionObserver::createTimestamp const):
(WebCore::IntersectionObserver::notify):
(WebCore::IntersectionObserver::hasPendingActivity const):
(WebCore::IntersectionObserver::activeDOMObjectName const):
(WebCore::IntersectionObserver::canSuspendForDocumentSuspension const):
(WebCore::IntersectionObserver::stop):

• page/IntersectionObserver.h:

(WebCore::IntersectionObserver::trackingDocument const):
(WebCore::IntersectionObserver::trackingDocument): Deleted.

• page/IntersectionObserver.idl:

LayoutTests:

• intersection-observer/no-document-leak-expected.txt: Added.
• intersection-observer/no-document-leak.html: Added.
• intersection-observer/observer-and-callback-without-js-references-expected.txt: Added.
• intersection-observer/observer-and-callback-without-js-references.html: Added.
• intersection-observer/resources/no-document-leak-frame.html: Added.

6:40 AM Changeset in webkit [235735] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

[LFC] Adapt to the new const WeakPtr<>
​https://bugs.webkit.org/show_bug.cgi?id=189334

Reviewed by Antti Koivisto.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):

• layout/FormattingContext.h:
• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::initializeRoot):

• layout/LayoutContext.h:
• layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):

• layout/floats/FloatAvoider.h:
• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::FloatingState):

• layout/floats/FloatingState.h:
• layout/layouttree/LayoutContainer.cpp:

(WebCore::Layout::Container::addOutOfFlowDescendant):

• layout/layouttree/LayoutContainer.h:

(WebCore::Layout::Container::outOfFlowDescendants const):

6:27 AM Changeset in webkit [235734] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[test262] Do not call keys on a reference
​https://bugs.webkit.org/show_bug.cgi?id=189301

Patch by Xan Lopez <Xan Lopez> on 2018-09-06
Reviewed by Keith Miller.

• Scripts/test262/Runner.pm:

(UpdateResults):

5:38 AM Changeset in webkit [235733] by ddkilzer@apple.com

• 3 edits
  1 add in trunk/Tools

svn-create-patch fails when svn mv is used on directory trees
<​https://webkit.org/b/14590>

Reviewed by Daniel Bates.

• Scripts/VCSUtils.pm: Export parseSvnDiffStartLine() for

svn-create-patch.
(parseDiffStartLine): Use parseSvnDiffStartLine().
(parseGitDiffStartLine): Document a prerequisite. Fix a bug
when parsing git patches using git diff --no-prefix non-native
line endings. Found by new tests written for
Scripts/webkitperl/VCSUtils_unittest/parseDiffStartLine.pl.
(parseSvnDiffStartLine): Add. Extract logic from
parseDiffStartLine() for use with svn-create-patch.

• Scripts/svn-create-patch: Update copyright and license.

(generateDiff): Return early for moved directories since
individual files within the directory are handled separately.
(generateFileList): Keep track of moved directories in the
@additionWithHistoryDirectories array, then process this array
in reverse order to create delete/add patches for each file in
a moved directory. This also prevents duplicate patches.
(manufacturePatchForAdditionWithHistory): Fix a long-standing
bug where the path used to describe property changes contained
the original (moved-from) path instead of the new (moved-to)
path. This could cause svn-apply to fail mysteriously when
trying to apply an empty patch created by the property change
containing the moved-from path.

• Scripts/webkitperl/VCSUtils_unittest/parseDiffStartLine.pl: Add.

Tests for parseDiffStartLine(), parseGitDiffStartLine() and
parseSvnDiffStartLine().

3:50 AM Changeset in webkit [235732] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Extra ASSERTs at MainThreadNotifier
​https://bugs.webkit.org/show_bug.cgi?id=188786

Reviewed by Carlos Garcia Campos.

We add a couple of checks in debug mode: there is only one bit on
per notification and ensure a notifier was invalidated before
being destroyed.

• platform/graphics/gstreamer/MainThreadNotifier.h:

2:36 AM Changeset in webkit [235731] by mark.lam@apple.com

• 57 edits
  3 copies
  2 deletes in branches/safari-606-branch

Cherry-pick r235254, r235419, r235666. rdar://problem/44169332

JSTests:

2018-08-27 Mark Lam <​mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
​https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

• stress/regress-188577.js: Added.

Source/JavaScriptCore:

2018-08-23 Mark Lam <​mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
​https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

Also introduced CallFrame::isGlobalExec() which makes use of one property of
GlobalExecs to identify them i.e. GlobalExecs have null callerFrame and returnPCs.
CallFrame::initGlobalExec() ensures this.

In contrast, normal CallFrames always have a callerFrame (because they must at
least be preceded by a VM EntryFrame) and a returnPC (at least return to the
VM entry glue).

• API/APIUtils.h: (handleExceptionIfNeeded): (setException):
• API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
• API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): (JSGlobalContextCopyName): (JSGlobalContextSetName): (JSGlobalContextGetRemoteInspectionEnabled): (JSGlobalContextSetRemoteInspectionEnabled): (JSGlobalContextGetIncludesNativeCallStackWhenReportingExceptions): (JSGlobalContextSetIncludesNativeCallStackWhenReportingExceptions): (JSGlobalContextGetDebuggerRunLoop): (JSGlobalContextSetDebuggerRunLoop): (JSGlobalContextGetAugmentableInspectorController):
• API/JSValue.mm: (reportExceptionToInspector):
• API/glib/JSCClass.cpp: (jscContextForObject):
• API/glib/JSCContext.cpp: (jsc_context_evaluate_in_object):
• debugger/Debugger.cpp: (JSC::Debugger::pauseIfNeeded):
• debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::vmEntryGlobalObject const): (JSC::DebuggerCallFrame::evaluateWithScopeExtension):
• interpreter/CallFrame.cpp: (JSC::CallFrame::vmEntryGlobalObject): Deleted.
• interpreter/CallFrame.h: (JSC::ExecState::scope const): (JSC::ExecState::noCaller): (JSC::ExecState::isGlobalExec const):
• interpreter/Interpreter.cpp: (JSC::notifyDebuggerOfUnwinding): (JSC::Interpreter::notifyDebuggerOfExceptionToBeThrown): (JSC::Interpreter::debug):
• runtime/CallData.cpp: (JSC::profiledCall):
• runtime/Completion.cpp: (JSC::evaluate): (JSC::profiledEvaluate): (JSC::evaluateWithScopeExtension): (JSC::loadAndEvaluateModule): (JSC::loadModule): (JSC::linkAndEvaluateModule): (JSC::importModule):
• runtime/ConstructData.cpp: (JSC::profiledConstruct):
• runtime/Error.cpp: (JSC::getStackTrace):
• runtime/VM.cpp: (JSC::VM::throwException): (JSC::VM::vmEntryGlobalObject const):
• runtime/VM.h:

2018-08-27 Mark Lam <​mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
​https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

1. Introduced CallFrame::convertToStackOverflowFrame() which converts the current (top) CallFrame (which may not have a valid callee) into a StackOverflowFrame.

The StackOverflowFrame is a sentinel frame that the low level code (exception
throwing code, stack visitor, and stack unwinding code) will know to skip
over. The StackOverflowFrame will also have a valid JSCallee so that client
code can compute the globalObject or VM from this frame.

As a result, client code that throws StackOverflowErrors no longer need to
compute the caller frame to throw from: it just converts the top frame into
a StackOverflowFrame and everything should *Just Work*.

2. NativeCallFrameTracerWithRestore is now obsolete.

Instead, client code should always call convertToStackOverflowFrame() on the
frame before instantiating a NativeCallFrameTracer with it.

This means that topCallFrame will always point to the top CallFrame (which
may be a StackOverflowFrame), and topEntryFrame will always point to the top
EntryFrame. We'll never temporarily point them to the previous EntryFrame
(which we used to do with NativeCallFrameTracerWithRestore).

3. genericUnwind() and Interpreter::unwind() will now always unwind from the top CallFrame, and will know how to handle a StackOverflowFrame if they see one.

This obsoletes the UnwindStart flag.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• debugger/Debugger.cpp: (JSC::Debugger::pauseIfNeeded):
• interpreter/CallFrame.cpp: (JSC::CallFrame::callerFrame const): (JSC::CallFrame::unsafeCallerFrame const): (JSC::CallFrame::convertToStackOverflowFrame): (JSC::CallFrame::callerFrame): Deleted. (JSC::CallFrame::unsafeCallerFrame): Deleted.
• interpreter/CallFrame.h: (JSC::ExecState::iterate):
• interpreter/CallFrameInlines.h: Added. (JSC::CallFrame::isStackOverflowFrame const): (JSC::CallFrame::isWasmFrame const):
• interpreter/EntryFrame.h: Added. (JSC::EntryFrame::vmEntryRecordOffset): (JSC::EntryFrame::calleeSaveRegistersBufferOffset):
• interpreter/FrameTracers.h: (JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore): Deleted. (JSC::NativeCallFrameTracerWithRestore::~NativeCallFrameTracerWithRestore): Deleted.
• interpreter/Interpreter.cpp: (JSC::Interpreter::unwind):
• interpreter/Interpreter.h:
• interpreter/StackVisitor.cpp: (JSC::StackVisitor::StackVisitor):
• interpreter/StackVisitor.h: (JSC::StackVisitor::visit): (JSC::StackVisitor::topEntryFrameIsEmpty const):
• interpreter/VMEntryRecord.h: (JSC::VMEntryRecord::callee const): (JSC::EntryFrame::vmEntryRecordOffset): Deleted. (JSC::EntryFrame::calleeSaveRegistersBufferOffset): Deleted.
• jit/AssemblyHelpers.h:
• jit/JITExceptions.cpp: (JSC::genericUnwind):
• jit/JITExceptions.h:
• jit/JITOperations.cpp:
• llint/LLIntOffsetsExtractor.cpp:
• llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/CallData.cpp:
• runtime/CommonSlowPaths.cpp: (JSC::throwArityCheckStackOverflowError): (JSC::SLOW_PATH_DECL):
• runtime/CommonSlowPathsExceptions.cpp: Removed.
• runtime/CommonSlowPathsExceptions.h: Removed.
• runtime/Completion.cpp: (JSC::evaluateWithScopeExtension):
• runtime/JSGeneratorFunction.h:
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren):
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::stackOverflowFrameCallee const):
• runtime/VM.cpp: (JSC::VM::throwException):
• runtime/VM.h:
• runtime/VMInlines.h: (JSC::VM::topJSCallFrame const):

2018-09-05 David Kilzer <​ddkilzer@apple.com>

REGRESSION (r235419): DFGCFG.h is missing from JavaScriptCore Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fix was made manually.

• JavaScriptCore.xcodeproj/project.pbxproj: (dfg/DFGCFG.h): Revert accidental change in r235419 by restoring name and path values to file reference.

Source/WebCore:

2018-08-23 Mark Lam <​mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
​https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

No new tests needed because this patch does not introduce new functionality.

• bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
• bindings/js/JSDOMGlobalObject.cpp: (WebCore::callerGlobalObject): (WebCore::toJSDOMGlobalObject): Deleted.
• bindings/js/JSDOMWindowBase.cpp: (WebCore::firstDOMWindow):
• bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
• bridge/objc/WebScriptObject.mm: (WebCore::addExceptionToConsole):
• bridge/objc/objc_instance.mm: (ObjcInstance::moveGlobalExceptionToExecState):
• bridge/objc/objc_runtime.mm: (JSC::Bindings::convertValueToObjcObject):
• bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue):
• testing/Internals.cpp: (WebCore::Internals::cloneArrayBuffer):

Source/WebKitLegacy/mac:

2018-08-23 Mark Lam <​mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
​https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

• WebView/WebScriptDebugger.mm: (WebScriptDebugger::sourceParsed):

LayoutTests:

2018-08-27 Mark Lam <​mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
​https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

• http/tests/misc/large-js-program-expected.txt:

1:11 AM Changeset in webkit [235730] by bshafiei@apple.com

• 3 edits
  1 add in branches/safari-606-branch

Cherry-pick r235715. rdar://problem/44169344

JSPropertyNameEnumerator::visitChildren() needs to visit its m_cachedStructureID.
​https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Reviewed by Filip Pizlo.

JSTests:

• stress/regress-189124.js: Added.

Source/JavaScriptCore:

It is assumed that the Structure for the m_cachedStructureID will remain alive
while the m_cachedStructureID is in use. This prevents the structureID from being
re-used for a different Structure.

• runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::visitChildren):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235729] by bshafiei@apple.com

• 3 edits
  2 adds in branches/safari-606-branch

Cherry-pick r235537. rdar://problem/44169516

CounterMaps should hold a unique_ptr of CounterMap.
​https://bugs.webkit.org/show_bug.cgi?id=189174
<rdar://problem/43686458>

Reviewed by Ryosuke Niwa.

Source/WebCore:

In certain cases calls to CounterMaps might lead to unexpected deletion of the CounterMap object.

Test: fast/css/counters/crash-when-cloning-body.html

• rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree):

LayoutTests:

• fast/css/counters/crash-when-cloning-body-expected.txt: Added.
• fast/css/counters/crash-when-cloning-body.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235728] by bshafiei@apple.com

• 4 edits
  1 add in branches/safari-606-branch

Cherry-pick r235177. rdar://problem/44169333

The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.
​https://bugs.webkit.org/show_bug.cgi?id=188298
<rdar://problem/42888427>

Reviewed by Saam Barati.

JSTests:

• stress/bug-188298.js: Added.

Source/JavaScriptCore:

In the event that both targets of a Branch is the same block, then even if we'll
always take one path of the branch, the other target is not unreachable because
it is the same target as the one in the taken path. Hence, it should not be
jettisoned.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Added DFGCFG.h which is in use and should have been added to the project.
• dfg/DFGCFGSimplificationPhase.cpp: (JSC::DFG::CFGSimplificationPhase::run):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235727] by bshafiei@apple.com

• 1 edit
  2 adds in branches/safari-606-branch/LayoutTests

Cherry-pick r233902. rdar://problem/44168991

Rebaseline imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker.html for Sierra after r233898.

Unreviewed test gardening.

• platform/mac-sierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Added.
• platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@233902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235726] by bshafiei@apple.com

• 6 edits in branches/safari-606-branch/LayoutTests

Cherry-pick r233900. rdar://problem/44168991

Unreviewed, test gardening after r233898.

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/wpe/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@233900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235725] by bshafiei@apple.com

• 62 edits
  60 adds in branches/safari-606-branch

Cherry-pick r233898. rdar://problem/44168991

[WebCrypto] Crypto operations should copy their parameters before hoping to another thread
​https://bugs.webkit.org/show_bug.cgi?id=187501
<rdar://problem/41438160>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch aims at making all captured variables in all crypto lambdas that need to be passed
to a worker thread thread safe, which includes:
1) changing ref counted objects to thread safe ref counted object.
2) adding isolatedCopy methods to non ref counted classes, so they can be called by CrossThreadCopy().

In addition to above changes, this patch also does the following things:
1) change the name CryptoAlgorithm::dispatchOperation => CryptoAlgorithm::dispatchOperationInWorkQueue
to make it clear that lambdas will be passed to a secondary thread.
2) make CryptoAlgorithmParameters as const parameters for all methods.
3) add null checks on BufferSource.length() and .data().

Tests: crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html

http/wpt/crypto/aes-cbc-crash.any.html
http/wpt/crypto/aes-cbc-crash.any.worker.html
http/wpt/crypto/aes-ctr-crash.any.html
http/wpt/crypto/aes-ctr-crash.any.worker.html
http/wpt/crypto/aes-gcm-crash.any.html
http/wpt/crypto/aes-gcm-crash.any.worker.html
http/wpt/crypto/derive-hmac-key-crash.any.html
http/wpt/crypto/derive-hmac-key-crash.any.worker.html
http/wpt/crypto/ecdsa-crash.any.html
http/wpt/crypto/ecdsa-crash.any.worker.html
http/wpt/crypto/hkdf-crash.any.html
http/wpt/crypto/hkdf-crash.any.worker.html
http/wpt/crypto/pbkdf2-crash.any.html
http/wpt/crypto/pbkdf2-crash.any.worker.html
http/wpt/crypto/rsa-oaep-crash.any.html
http/wpt/crypto/rsa-oaep-crash.any.worker.html
http/wpt/crypto/rsa-pss-crash.any.html
http/wpt/crypto/rsa-pss-crash.any.worker.html
http/wpt/crypto/unwrap-ec-key-crash.any.html
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html
http/wpt/crypto/unwrap-rsa-key-crash.any.html
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html

• bindings/js/BufferSource.h: (WebCore::BufferSource::data const): (WebCore::BufferSource::length const):
• crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::encrypt): (WebCore::CryptoAlgorithm::decrypt): (WebCore::CryptoAlgorithm::sign): (WebCore::CryptoAlgorithm::verify): (WebCore::CryptoAlgorithm::deriveBits): (WebCore::CryptoAlgorithm::importKey): (WebCore::dispatchAlgorithmOperation): (WebCore::CryptoAlgorithm::dispatchOperationInWorkQueue): (WebCore::CryptoAlgorithm::dispatchOperation): Deleted.
• crypto/CryptoAlgorithm.h:
• crypto/SubtleCrypto.cpp: (WebCore::crossThreadCopyImportParams): (WebCore::SubtleCrypto::encrypt): (WebCore::SubtleCrypto::decrypt): (WebCore::SubtleCrypto::sign): (WebCore::SubtleCrypto::verify): (WebCore::SubtleCrypto::deriveKey): (WebCore::SubtleCrypto::deriveBits): (WebCore::SubtleCrypto::importKey): (WebCore::SubtleCrypto::wrapKey): (WebCore::SubtleCrypto::unwrapKey):
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::encrypt): (WebCore::CryptoAlgorithmAES_CBC::decrypt): (WebCore::CryptoAlgorithmAES_CBC::importKey):
• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp: (WebCore::CryptoAlgorithmAES_CFB::encrypt): (WebCore::CryptoAlgorithmAES_CFB::decrypt): (WebCore::CryptoAlgorithmAES_CFB::importKey):
• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp: (WebCore::parametersAreValid): (WebCore::CryptoAlgorithmAES_CTR::encrypt): (WebCore::CryptoAlgorithmAES_CTR::decrypt): (WebCore::CryptoAlgorithmAES_CTR::importKey):
• crypto/algorithms/CryptoAlgorithmAES_CTR.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: (WebCore::CryptoAlgorithmAES_GCM::encrypt): (WebCore::CryptoAlgorithmAES_GCM::decrypt): (WebCore::CryptoAlgorithmAES_GCM::importKey):
• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp: (WebCore::CryptoAlgorithmAES_KW::importKey):
• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp: (WebCore::CryptoAlgorithmECDH::deriveBits): (WebCore::CryptoAlgorithmECDH::importKey):
• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmECDSA.cpp: (WebCore::CryptoAlgorithmECDSA::sign): (WebCore::CryptoAlgorithmECDSA::verify): (WebCore::CryptoAlgorithmECDSA::importKey):
• crypto/algorithms/CryptoAlgorithmECDSA.h:
• crypto/algorithms/CryptoAlgorithmHKDF.cpp: (WebCore::CryptoAlgorithmHKDF::deriveBits): (WebCore::CryptoAlgorithmHKDF::importKey):
• crypto/algorithms/CryptoAlgorithmHKDF.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::sign): (WebCore::CryptoAlgorithmHMAC::verify): (WebCore::CryptoAlgorithmHMAC::importKey):
• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmPBKDF2.cpp: (WebCore::CryptoAlgorithmPBKDF2::deriveBits): (WebCore::CryptoAlgorithmPBKDF2::importKey):
• crypto/algorithms/CryptoAlgorithmPBKDF2.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::encrypt): (WebCore::CryptoAlgorithmRSA_OAEP::decrypt): (WebCore::CryptoAlgorithmRSA_OAEP::importKey):
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp: (WebCore::CryptoAlgorithmRSA_PSS::sign): (WebCore::CryptoAlgorithmRSA_PSS::verify): (WebCore::CryptoAlgorithmRSA_PSS::importKey):
• crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
• crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CFB::platformEncrypt): (WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
• crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CTR::platformEncrypt): (WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
• crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp: (WebCore::CryptoAlgorithmAES_GCM::platformEncrypt): (WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
• crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
• crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp: (WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
• crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
• crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_PSS::platformSign): (WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
• crypto/mac/CryptoAlgorithmAES_CFBMac.cpp: (WebCore::CryptoAlgorithmAES_CFB::platformEncrypt): (WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
• crypto/mac/CryptoAlgorithmAES_CTRMac.cpp: (WebCore::CryptoAlgorithmAES_CTR::platformEncrypt): (WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
• crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: (WebCore::CryptoAlgorithmAES_GCM::platformEncrypt): (WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
• crypto/mac/CryptoAlgorithmHKDFMac.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
• crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp: (WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
• crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp: (WebCore::CryptoAlgorithmRSA_PSS::platformSign): (WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
• crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h:
• crypto/parameters/CryptoAlgorithmAesCtrParams.h:
• crypto/parameters/CryptoAlgorithmAesGcmParams.h:
• crypto/parameters/CryptoAlgorithmEcKeyParams.h:
• crypto/parameters/CryptoAlgorithmEcdsaParams.h:
• crypto/parameters/CryptoAlgorithmHkdfParams.h:
• crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
• crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
• crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
• crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
• crypto/parameters/CryptoAlgorithmRsaPssParams.h:

LayoutTests:

crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html is an exception of this series of tests as
it only aims to test the correct behavoir of suggested algorithms. This patch aslo does some test
gardening.

• TestExpectations:
• crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key-expected.txt: Added.
• crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html: Added.
• http/wpt/crypto/aes-cbc-crash.any-expected.txt: Added.
• http/wpt/crypto/aes-cbc-crash.any.html: Added.
• http/wpt/crypto/aes-cbc-crash.any.js: Added.
• http/wpt/crypto/aes-cbc-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/aes-cbc-crash.any.worker.html: Added.
• http/wpt/crypto/aes-ctr-crash.any-expected.txt: Added.
• http/wpt/crypto/aes-ctr-crash.any.html: Added.
• http/wpt/crypto/aes-ctr-crash.any.js: Added.
• http/wpt/crypto/aes-ctr-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/aes-ctr-crash.any.worker.html: Added.
• http/wpt/crypto/aes-gcm-crash.any-expected.txt: Added.
• http/wpt/crypto/aes-gcm-crash.any.html: Added.
• http/wpt/crypto/aes-gcm-crash.any.js: Added.
• http/wpt/crypto/aes-gcm-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/aes-gcm-crash.any.worker.html: Added.
• http/wpt/crypto/derive-hmac-key-crash.any-expected.txt: Added.
• http/wpt/crypto/derive-hmac-key-crash.any.html: Added.
• http/wpt/crypto/derive-hmac-key-crash.any.js: Added.
• http/wpt/crypto/derive-hmac-key-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/derive-hmac-key-crash.any.worker.html: Added.
• http/wpt/crypto/ecdsa-crash.any-expected.txt: Added.
• http/wpt/crypto/ecdsa-crash.any.html: Added.
• http/wpt/crypto/ecdsa-crash.any.js: Added.
• http/wpt/crypto/ecdsa-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/ecdsa-crash.any.worker.html: Added.
• http/wpt/crypto/hkdf-crash.any-expected.txt: Added.
• http/wpt/crypto/hkdf-crash.any.html: Added.
• http/wpt/crypto/hkdf-crash.any.js: Added.
• http/wpt/crypto/hkdf-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/hkdf-crash.any.worker.html: Added.
• http/wpt/crypto/pbkdf2-crash.any-expected.txt: Added.
• http/wpt/crypto/pbkdf2-crash.any.html: Added.
• http/wpt/crypto/pbkdf2-crash.any.js: Added.
• http/wpt/crypto/pbkdf2-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/pbkdf2-crash.any.worker.html: Added.
• http/wpt/crypto/resources/common.js: Added.
• http/wpt/crypto/rsa-oaep-crash.any-expected.txt: Added.
• http/wpt/crypto/rsa-oaep-crash.any.html: Added.
• http/wpt/crypto/rsa-oaep-crash.any.js: Added.
• http/wpt/crypto/rsa-oaep-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/rsa-oaep-crash.any.worker.html: Added.
• http/wpt/crypto/rsa-pss-crash.any-expected.txt: Added.
• http/wpt/crypto/rsa-pss-crash.any.html: Added.
• http/wpt/crypto/rsa-pss-crash.any.js: Added.
• http/wpt/crypto/rsa-pss-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/rsa-pss-crash.any.worker.html: Added.
• http/wpt/crypto/unwrap-ec-key-crash.any-expected.txt: Added.
• http/wpt/crypto/unwrap-ec-key-crash.any.html: Added.
• http/wpt/crypto/unwrap-ec-key-crash.any.js: Added.
• http/wpt/crypto/unwrap-ec-key-crash.any.worker-expected.txt: Added.
• http/wpt/crypto/unwrap-ec-key-crash.any.worker.html: Added.
• http/wpt/crypto/unwrap-rsa-key-crash.any-expected.txt: Added.
• http/wpt/crypto/unwrap-rsa-key-crash.any.html: Added.
• http/wpt/crypto/unwrap-rsa-key-crash.any.js: Added.
• http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html: Added.
• http/wpt/crypto/unwrap-rsa-key-crash.any.worker-expected.txt: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@233898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:28 AM Changeset in webkit [235724] by bshafiei@apple.com

• 7 edits in tags/Safari-607.1.5.1/Source

Versioning.

12:25 AM Changeset in webkit [235723] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.5.1

Tag Safari-607.1.5.1.

Sep 5, 2018:

10:08 PM Changeset in webkit [235722] by youenn@apple.com

• 5 edits in trunk/Source/WebCore

Move ownership of outgoing source to RTCRtpSender backend
​https://bugs.webkit.org/show_bug.cgi?id=189310

Reviewed by Alex Christensen.

RTCRtpSender should own the source so that it can replace/stop it.
Since this is libwebrtc specific, the source is actually owned by the backend.
Simplified replaceTrack a bit based on that.

No change of behavior.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doStop):
(WebCore::updateTrackSource):
(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):
(WebCore::LibWebRTCPeerConnectionBackend::applyRotationForOutgoingVideoSources):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:

9:07 PM Changeset in webkit [235721] by Brent Fulgham

• 7 edits
  2 adds in trunk

Source/WebCore:
The width of an empty or nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

If a page has an empty TextRun and attempts to paint it we can crash with a nullptr.

This patch recognizes that an empty TextRun should always produce a zero width, rather than
attempt to compute this value from font data. It also prevents ListBox from attempting to
paint a null string.

Test: fast/text/null-string-textrun.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthOfTextRange const): An empty TextRun has zero width.
(WebCore::FontCascade::width const): Ditto.

• platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): ASSERT that the supplied String is non-null.
(WebCore::TextRun::setText): Ditto.

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground): Don't attempt to paint a null string.

Source/WTF:
The width of an empty or nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

Most accessors in WTFString.cpp, such as isAllASCII(), hash(), etc., perform a nullptr check
before using m_impl, but is8Bit() does not.

This patch adds a check in the is8Bit() implementation to be consistent with other methods,
and to address a small number of crashes observed in testing.

• wtf/text/WTFString.h:

(WTF::String::is8Bit const):

LayoutTests:
The width of a nullptr TextRun should be zero
​https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

• fast/text/null-string-textrun-expected.txt: Added.
• fast/text/null-string-textrun.html: Added.

9:06 PM Changeset in webkit [235720] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LFC][BFC] ComputeFloat* methods should take a const FloatingContext&
​https://bugs.webkit.org/show_bug.cgi?id=189333

Reviewed by Antti Koivisto.

Only layoutFormattingContextRoot() needs a non-const FloatingContext& object (to add the floating box to the floating state).

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):

• layout/blockformatting/BlockFormattingContext.h:

9:01 PM Changeset in webkit [235719] by youenn@apple.com

• 7 edits
  1 add in trunk/Source/WebCore

Introduce a backend for RTCRtpTransceiver
​https://bugs.webkit.org/show_bug.cgi?id=189322

Reviewed by Eric Carlson.

Introduce RTCRtpTransceiverBackend to implement the transceiver functionality using libwebrtc.
Remove provisional mids as it will be done by the webrtc backend.

No observable change of behavior yet since there is no transceiver backend yet.

• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
(WebCore::RTCRtpTransceiver::mid const):
(WebCore::RTCRtpTransceiver::direction const):
(WebCore::RTCRtpTransceiver::setDirection):
(WebCore::RTCRtpTransceiver::stop):
(WebCore::RTCRtpTransceiver::getNextMid): Deleted.
(WebCore::RTCRtpTransceiver::directionString const): Deleted.

• Modules/mediastream/RTCRtpTransceiver.h:

(WebCore::RTCRtpTransceiver::create):
(WebCore::RTCRtpTransceiver::provisionalMid const): Deleted.
(WebCore::RTCRtpTransceiver::setMid): Deleted.

• Modules/mediastream/RTCRtpTransceiverBackend.h: Added.
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::createReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::completeAddTransceiver):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• WebCore.xcodeproj/project.pbxproj:

8:46 PM Changeset in webkit [235718] by don.olmstead@sony.com

• 4 edits
  1 add in trunk

[CMake] Allow port specific options on gtest
​https://bugs.webkit.org/show_bug.cgi?id=189313

Reviewed by Alex Christensen.

Source/ThirdParty:

Allows a port to configure options within gtest for its platform.
The library type can be set otherwise it defaults to shared. Also the
compile definitions are propogated to TestWebKitAPI through a global
property.

• gtest/CMakeLists.txt:
• gtest/PlatformWin.cmake: Added.

Tools:

Use the global property set by the gtest CMake file to add to the
compilation definitions for TestWebKitAPI rather than repeating the
logic.

• TestWebKitAPI/CMakeLists.txt:

7:54 PM Changeset in webkit [235717] by Fujii Hironori

• 2 edits in trunk/Websites/webkit.org

Update code style guidelines for using namespace inside a namespace definition
​https://bugs.webkit.org/show_bug.cgi?id=189298

Reviewed by Ryosuke Niwa.

"using namespace" statements should be inside namespace definitions for
unified source builds.

• code-style.md(#using-position):

6:42 PM Changeset in webkit [235716] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

[LFC] Pass in const LayoutContext& to geometry methods when possible
​https://bugs.webkit.org/show_bug.cgi?id=189331

Reviewed by Antti Koivisto.

Only layout and layout-like methods (intrinsic width computation -> shrink to fit -> out-of-flow/floating boxes) should take a
non-const LayoutContext&. Other geometry functions should not mutate the the context.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutContext::establishedFormattingState const):
(WebCore::Layout::LayoutContext::createFormattingStateForFormattingRootIfNeeded):
(WebCore::Layout::LayoutContext::formattingContext const):
(WebCore::Layout::LayoutContext::establishedFormattingState): Deleted.
(WebCore::Layout::LayoutContext::formattingContext): Deleted.

• layout/LayoutContext.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):

• layout/inlineformatting/InlineFormattingContext.h:

4:51 PM Changeset in webkit [235715] by mark.lam@apple.com

• 3 edits
  1 add in trunk

JSPropertyNameEnumerator::visitChildren() needs to visit its m_cachedStructureID.
​https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Reviewed by Filip Pizlo.

JSTests:

• stress/regress-189124.js: Added.

Source/JavaScriptCore:

It is assumed that the Structure for the m_cachedStructureID will remain alive
while the m_cachedStructureID is in use. This prevents the structureID from being
re-used for a different Structure.

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

3:30 PM Changeset in webkit [235714] by youenn@apple.com

• 22 edits in trunk

Expose RTCRtpSender.setParameters
​https://bugs.webkit.org/show_bug.cgi?id=189307

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCRtpSender-replaceTrack-expected.txt:
• web-platform-tests/webrtc/RTCRtpSender-setParameters-expected.txt:

Source/ThirdParty/libwebrtc:

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:

Source/WebCore:

Implement RTCRtpSender.setParameters.
This is an incomplete implementation as we need to refresh parameters as per the spec and testing is much easier with full transceiver support.
Implementation uses sender backend to set the parameters at libwebrtc level.
Fix the case of a stopped sender/transceiver in which case promise should be rejected.
Covered by rebased and modified tests.

• Modules/mediastream/RTCRtpParameters.h:
• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::setParameters):

• Modules/mediastream/RTCRtpSender.h:
• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/RTCRtpSenderBackend.h:
• Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RTCRtpTransceiver::stop):

• Modules/mediastream/RTCRtpTransceiver.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::LibWebRTCRtpReceiverBackend::getParameters):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::getParameters const):
(WebCore::LibWebRTCRtpSenderBackend::setParameters):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::toRTCEncodingParameters):
(WebCore::fromRTCEncodingParameters):
(WebCore::toRTCHeaderExtensionParameters):
(WebCore::fromRTCHeaderExtensionParameters):
(WebCore::toRTCCodecParameters):
(WebCore::toRTCRtpParameters):
(WebCore::fromRTCRtpParameters):

• Modules/mediastream/libwebrtc/LibWebRTCUtils.h:

LayoutTests:

• webrtc/video-getParameters.html:

3:25 PM Changeset in webkit [235713] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Remove some logging that I committed by mistake.

• rendering/RenderLayerFilters.cpp:

(WebCore::RenderLayerFilters::RenderLayerFilters):
(WebCore::RenderLayerFilters::~RenderLayerFilters):

3:18 PM Changeset in webkit [235712] by Ross Kirsling

• 6 edits in trunk

[ESNext] Symbol.prototype.description
​https://bugs.webkit.org/show_bug.cgi?id=186686

Reviewed by Keith Miller.

JSTests:

• stress/symbol-description.js:

Add tests for empty and null symbol cases.

• test262/config.yaml:

Enable Symbol.prototype.description tests.

Source/JavaScriptCore:

Symbol.prototype.description was implemented in r232404, but has one small bug:
It should return undefined for a null symbol.

• runtime/Symbol.cpp:

(JSC::Symbol::description const):

• runtime/SymbolPrototype.cpp:

(JSC::symbolProtoGetterDescription):
Address the null symbol case.

3:08 PM Changeset in webkit [235711] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC] Construct the Display::Box objects on demand.
​https://bugs.webkit.org/show_bug.cgi?id=189320

Reviewed by Antti Koivisto.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

• layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::initializeRoot):
(WebCore::Layout::LayoutContext::displayBoxForLayoutBox const):
(WebCore::Layout::LayoutContext::createDisplayBox): Deleted.

• layout/LayoutContext.h:

(WebCore::Layout::LayoutContext::displayBoxForLayoutBox const): Deleted.

• layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

• layout/displaytree/DisplayBox.h:

2:57 PM Changeset in webkit [235710] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r235489): WKSharingServicePickerDelegate.mm accidentally added back to Sources in WebKit project

• WebKit.xcodeproj/project.pbxproj:

(WKSharingServicePickerDelegate.mm): Let Xcode have its way with
the WebKit project file by removing this file from Sources.
It's already included in a UnifedSource file, so it should not
have been added back to Sources during merge conflict resolution
for r235489.

2:57 PM Changeset in webkit [235709] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r204222): UIProces/Gamepad/mac is missing in WebKit Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fixes applied manually.

• WebKit.xcodeproj/project.pbxproj:

(UIProces/Gamepad/mac): Fix path to "mac" directory, then remove
its now-redundant name.
(UIGamepadProviderMac.mm): Change path to be relative to its
group after the above change.

2:57 PM Changeset in webkit [235708] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r143543): PluginProcess/EntryPoint/XPCService/PluginService is missing in WebKit Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fixes applied manually.

• WebKit.xcodeproj/project.pbxproj:

(PluginProcess/EntryPoint/XPCService/PluginService): Remove path
to PluginService.64 directory, which was removed in r143543, so
that this becomes a virtual folder that inherits its path from
its parent.
(PluginService.32-64.Info.plist): Change path to be relative to
its group after the above change. Delete redundant name value.

2:57 PM Changeset in webkit [235707] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.5

Tag Safari-607.1.5.

2:52 PM Changeset in webkit [235706] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r235133. rdar://problem/44144065

Increment NetworkCache::Storage::lastStableVersion after r233742
​https://bugs.webkit.org/show_bug.cgi?id=188798
<rdar://43561761>

Reviewed by Geoffrey Garen.

• NetworkProcess/cache/NetworkCacheStorage.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235705] by bshafiei@apple.com

• 3 edits
  1 add in branches/safari-606-branch

Cherry-pick r235007. rdar://problem/44144079

intersectionOfPastValuesAtHead must filter values after they've observed an invalidation point
​https://bugs.webkit.org/show_bug.cgi?id=188707
<rdar://problem/43015442>

Reviewed by Mark Lam.

JSTests:

• stress/cfa-expected-values-must-set-clobbered-to-false.js: Added. (foo): (let.comp.valueOf): (result):

Source/JavaScriptCore:

We use the values in intersectionOfPastValuesAtHead to verify that it is safe to
OSR enter at the head of a block. We verify it's safe to OSR enter by checking
that each incoming value is compatible with its corresponding AbstractValue.

The bug is that we were sometimes filtering the intersectionOfPastValuesAtHead
with abstract values that were clobbererd. This meant that the value we're
verifying with at OSR entry effectively has an infinite structure set because
it's clobbered. So, imagine we have code like this:
`
---> We OSR enter here, and we're clobbered here
InvalidationPoint
GetByOffset(@base)
`

The abstract value for @base inside intersectionOfPastValuesAtHead has a
clobberred structure set, so we'd allow an incoming object with any
structure. However, this is wrong because the invalidation point is no
longer fulfilling its promise that it filters the structure that @base has.

We fix this by filtering the AbstractValues in intersectionOfPastValuesAtHead
as if the incoming value may be live past an InvalidationPoint.
This places a stricter requirement that to safely OSR enter at any basic
block, all incoming values must be compatible as if they lived past
the execution of an invalidation point.

• dfg/DFGCFAPhase.cpp: (JSC::DFG::CFAPhase::run):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@235007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235704] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234908. rdar://problem/44144086

[WinCairo] Unreviewed build fix after r234896.

• NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::tryHttpAuthentication):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235703] by bshafiei@apple.com

• 5 edits in branches/safari-606-branch/Source

Cherry-pick r234905. rdar://problem/44144059

Can't share an app on AppStore to WeChat due to a release assert
​https://bugs.webkit.org/show_bug.cgi?id=188621
<rdar://problem/43343976>

Reviewed by Geoffrey Garen.

Disable the thread safety check when the app is not linked on or after iOS 12 since this release assert
is getting hit by third party applications on iOS in UI process.

Source/WebCore:

• platform/Timer.cpp: (WebCore::shouldSuppressThreadSafetyCheck): Added a SDK check.

Source/WebKit:

• UIProcess/Cocoa/VersionChecks.h: (WebKit::SDKVersion::FirstWithMainThreadReleaseAssertionInWebPageProxy): Added. It's iOS 12 or macOS 10.14 Mojave.
• UIProcess/WebProcessProxy.cpp: (WebKit::isMainThreadOrCheckDisabled): Added. Returns true whether when we're in the main thread or if the app is not linked on or after iOS 12 or macOS 10.14 Mojave. (WebKit::globalPageMap): (WebKit::m_isInPrewarmedPool): (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::shutDown): (WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores): (WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData): (WebKit::WebProcessProxy::didFinishLaunching):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235702] by bshafiei@apple.com

• 19 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234896. rdar://problem/44144086

NetworkCORSPreflightChecker should proceed in case of ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested even though the WebKit app is not implementing the didReceiveAuthenticationChallenge/didReceiveAuthenticationChallengeInFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=188592
<rdar://problem/43210331>

Reviewed by Youenn Fablet.

Do a canAuthenticateAgainstProtectionSpace check in NetworkCORSPreflightChecker like we do in NetworkLoad.
Use CompletionHandlers to make the now 3 different canAuthenticateAgainstProtectionSpace checks look the same from the NetworkProcess.

• NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
• NetworkProcess/NetworkCORSPreflightChecker.h:
• NetworkProcess/NetworkDataTask.h:
• NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::didReceiveChallenge):
• NetworkProcess/NetworkLoad.h:
• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::canAuthenticateAgainstProtectionSpace): (WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): (WebKit::NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace): Deleted.
• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::didReceiveChallenge):
• NetworkProcess/PingLoad.h:
• NetworkProcess/PreconnectTask.cpp: (WebKit::PreconnectTask::canAuthenticateAgainstProtectionSpaceAsync): (WebKit::PreconnectTask::continueCanAuthenticateAgainstProtectionSpace): Deleted.
• NetworkProcess/PreconnectTask.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::didReceiveChallenge):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235701] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/WebCore

Cherry-pick r234890. rdar://problem/44144063

Remove failing assertion introduced in r234873
​https://bugs.webkit.org/show_bug.cgi?id=188581

• contentextensions/ContentExtensionCompiler.cpp: (WebCore::ContentExtensions::compileRuleList): The assertion is correct but failing because VectorTraits<String> is incorrect. I'll re-add it and fix VectorTraits<String> in a separate patch.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235700] by bshafiei@apple.com

• 15 edits in branches/safari-606-branch

Cherry-pick r234873. rdar://problem/44144063

isValidCSSSelector is unsafe to be called from a non-main thread
​https://bugs.webkit.org/show_bug.cgi?id=188581
<rdar://problem/40517358>

Reviewed by Sam Weinig.

Source/WebCore:

Parsing and determining whether the css selectors are valid is fast enough to do before
hopping to the background thread for the slow NFA/DFA operations and writing to disk.
Doing it on the main thread avoids the thread safety issues in the CSSParser's use of strings.

• contentextensions/ContentExtensionCompiler.cpp: (WebCore::ContentExtensions::compileRuleList):
• contentextensions/ContentExtensionCompiler.h:
• contentextensions/ContentExtensionParser.cpp: (WebCore::ContentExtensions::isValidCSSSelector): (WebCore::ContentExtensions::loadEncodedRules): (WebCore::ContentExtensions::parseRuleList):
• contentextensions/ContentExtensionParser.h:
• contentextensions/ContentExtensionRule.cpp: (WebCore::ContentExtensions::Trigger::isolatedCopy const): (WebCore::ContentExtensions::Action::isolatedCopy const):
• contentextensions/ContentExtensionRule.h: (WebCore::ContentExtensions::Trigger::isEmpty const): (WebCore::ContentExtensions::Trigger::operator== const): (WebCore::ContentExtensions::Action::Action): (WebCore::ContentExtensions::ContentExtensionRule::isolatedCopy const): (WebCore::ContentExtensions::ContentExtensionRule::operator== const): (WebCore::ContentExtensions::vectorIsolatedCopy):

Source/WebKit:

• UIProcess/API/APIContentRuleListStore.cpp: (API::compiledToFile): (API::ContentRuleListStore::lookupContentRuleList): (API::ContentRuleListStore::getAvailableContentRuleListIdentifiers): (API::ContentRuleListStore::compileContentRuleList): (API::ContentRuleListStore::removeContentRuleList): (API::ContentRuleListStore::getContentRuleListSource):
• UIProcess/API/APIContentRuleListStore.h:
• UIProcess/API/Cocoa/WKContentRuleListStore.mm:

Source/WTF:

• wtf/Vector.h: (WTF::minCapacity>::isolatedCopy):

Tools:

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: (TestWebKitAPI::InMemoryCompiledContentExtension::create): (TestWebKitAPI::checkCompilerError):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235699] by bshafiei@apple.com

• 4 edits in branches/safari-606-branch/Source

Cherry-pick r234778. rdar://problem/44144053

[macOS] Multiple third party apps crash due to the thread safety check in TimerBase::setNextFireTime
​https://bugs.webkit.org/show_bug.cgi?id=188480

Reviewed by Simon Fraser.

Source/WebCore:

Suppress the release assert in WebKit1 on macOS (isInWebProcess is always true in non-Cocoa platforms).

In the future, we should consider throwing Objective-C exceptions when third party apps call WebKit1
or WebKit2 APIs in non-main threads.

• platform/Timer.cpp: (WebCore::shouldSuppressThreadSafetyCheck): Extracted out of ~TimerBase and setNextFireTime. (WebCore::TimerBase::~TimerBase): (WebCore::TimerBase::setNextFireTime):

Source/WTF:

Added the SDK version for macOS Mojave.

• wtf/spi/darwin/dyldSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235698] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/WebCore

Cherry-pick r234766. rdar://problem/44144088

CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
​https://bugs.webkit.org/show_bug.cgi?id=188461
<rdar://problem/33555052>

Reviewed by Chris Dumez.

When we try to schedule shutdown for database, we should cancel the timer so no
scheduleShutdownForClose will be running after this.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235697] by bshafiei@apple.com

• 10 edits in branches/safari-606-branch

Cherry-pick r234730. rdar://problem/44144081

REGRESSION (r232083): WKWebView loses first-party cookies on iOS
​https://bugs.webkit.org/show_bug.cgi?id=188443
<rdar://problem/42991584>

Patch by Sihui Liu <​sihui_liu@apple.com> on 2018-08-09
Reviewed by Chris Dumez.

Source/WebKit:

Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode):
• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::platformInitializeNetworkProcess):

Tools:

Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.

• TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235696] by bshafiei@apple.com

• 7 edits
  2 adds in branches/safari-606-branch

Cherry-pick r234718. rdar://problem/44144071

REGRESSION (r228260): Events handled by input method invoke default event handler
​https://bugs.webkit.org/show_bug.cgi?id=188370

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by the default event handler being invoked for the "virtual" keydown events
generated for input methods. Namely, when Japanese or Chinese input methods swallows TAB key,
WebKit should not invoke the default event handler and move the focus during input composition.

Fixed the bug by adding a new boolean on Event indicating whether the default event handler
should be invoked, and restoring the behavior prior to r228260 for these virtual keydown events.

Test: editing/input/press-tab-during-ime-composition.html

• dom/Event.h: (WebCore::Event::isDefaultEventHandlerIgnored const): Added. (WebCore::Event::setIsDefaultEventHandlerIgnored): Added.
• dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Don't invoke the default event handler if isDefaultEventHandlerIgnored is set.
• page/EventHandler.cpp: (WebCore::EventHandler::internalKeyEvent): Set isDefaultEventHandlerIgnored. This restores WebKit's behavior prior to r228260.

LayoutTests:

Added a regression test. Due to the lack of adequate support of textInputController in WebKitTestRunner,
the test is only enabled in WebKit1. The WTR fix is tracked by ​https://webkit.org/b/188428.

• editing/input/press-tab-during-ime-composition-expected.txt: Added.
• editing/input/press-tab-during-ime-composition.html: Added.
• platform/ios/TestExpectations:
• platform/wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235695] by bshafiei@apple.com

• 7 edits in branches/safari-606-branch/Source

Cherry-pick r234652. rdar://problem/43009928

[macOS] Scrollbars are not visible when using 3rd party mouse
​https://bugs.webkit.org/show_bug.cgi?id=188372

Reviewed by Simon Fraser.

Source/WebCore/PAL:

Added declaration of NSScrollerImpPair class method. This method updates all NSScrollerImpPairs
with a new recommended scroller style.

• pal/spi/mac/NSScrollerImpSPI.h:

Source/WebKit:

The scrollbars are not visible because they are not updated with the recommended scroller style
when a 3rd party mouse is used. They still have the overlay style, but the system is
recommending the legacy style in this case. The UI process is currently notifying the WebProcess
about changes in the scroller style, but the current style is not set in the WebProcess on
startup. This patch sets the initial scroller style in the WebProcess by passing it as part of
the WebProcess creation parameters. Also, to make sure hot-plugging of a 3rd party mouse is
is visually changing the scroller style of the current page, a class method in NSScrollerImpPair
is called to update all NSScrollerImpPairs with the new recommended style. This method was
previously called by AppKit, but after blocking WindowServer access, AppKit is no longer calling
this method. This has been manually tested by using a 3rd party mouse.

• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::scrollerStylePreferenceChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235694] by bshafiei@apple.com

• 7 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234626. rdar://problem/43009898

Regression(NetworkLoadChecker): CORS preflights are no longer able to deal with client certificate authentication
​https://bugs.webkit.org/show_bug.cgi?id=188355
<rdar://problem/42546319>

Reviewed by Alex Christensen.

Before we started using the NetworkLoadChecker to do CORS-preflighting in the Network process, challenges would
use the NetworkLoad::completeAuthenticationChallenge() code path with isAllowedToAskUserForCredentials to set
to false. This would call:

1. completionHandler(AuthenticationChallengeDisposition::UseCredential, { }); for TLS handshakes (server trust evaluation & client certification authentication)
2. NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge() otherwise

However, NetworkCORSPreflightChecker::didReceiveChallenge() was behaving differently and calling:

1. completionHandler(AuthenticationChallengeDisposition::RejectProtectionSpace, { }); for server trust evaluations
2. completionHandler(AuthenticationChallengeDisposition::Cancel, { }); otherwise

Restore previous behavior by aligning NetworkCORSPreflightChecker::didReceiveChallenge() with
NetworkLoad::completeAuthenticationChallenge() when isAllowedToAskUserForCredentials is set to false. This means
we end up asking the AuthenticationManager for client certificate authentication instead or cancelling the
preflight.

This fixes CORS-preflighting on some internal sites.

• NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
• NetworkProcess/NetworkCORSPreflightChecker.h:
• NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::NetworkLoadChecker): (WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
• NetworkProcess/NetworkLoadChecker.h:
• NetworkProcess/NetworkResourceLoader.cpp:
• NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::PingLoad):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [235693] by bshafiei@apple.com

• 2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234611. rdar://problem/43009906

Fix IPC::Connection leak in StorageManager
​https://bugs.webkit.org/show_bug.cgi?id=188321
<rdar://problem/42748485>

Reviewed by Alex Christensen.

When a StorageMap is destroyed on WebContent process side, StorageManager::destroyStorageMap()
gets called via IPC with a (IPC::Connection, StorageMapID) pair. Normally, it removes this
pair from m_storageAreasByConnection. However, if this is a *transient* StorageMap (sessionStorage),
then we keep the pair in the map and we merely remove the StorageMapID as a listener from the
StorageArea. We do this so that:

1. The StorageArea stays alive so that it can be reused later on for the same security origin, on the same IPC::Connection (logic for this is in StorageManager::createTransientLocalStorageMap()
2. Removing the StorageMapID as a listener from the StorageArea is important because StorageArea::m_eventListeners holds a strong reference to the IPC::Connection in a std::pair with the StorageMapID (HashSet<std::pair<RefPtr<IPC::Connection>, uint64_t>> m_eventListeners).

As mentioned in 1 above, in StorageManager::createTransientLocalStorageMap(), there is logic to
check if there is already an existing StorageArea for the given IPC::Connection that is transient
and is for the same security origin. In this case, we could avoid constructing a new StorageArea
and we would:

1. Add a new entry to m_storageAreasByConnection with the key (connection, newStorageMapID), using same same StorageArea as value.
2. Remove the previous (connection, oldStorageMapID) key from m_storageAreasByConnection.

Step 2 here is wrong and is updated in this patch. It is only safe to remove the previous
(connection, oldStorageMapID) if this oldStorageMapID no longer exists (i.e. destroyStorageMap()
was already called for it). This patch thus adds a check before removing (connection, oldStorageMapID)
from the HashMap to make sure that the oldStorageMapID is no longer a listener of the StorageArea).

This would cause leaks in the following case:

1. We construct a StorageArea for (connection1, storageMapId1)
2. We ask for a StorageArea for (connection1, storageMapId2) and decide to reuse the existing StorageArea since it has the same SecurityOrigin.
3. As a result of step2, we would remove (connection1, storageMapId1) from m_storageAreasByConnection and add (connection1, storageMapId2), even though there is still a StorageMap with storageMapId1 on WebContent process side.
4. Later on, we would try to call destroyStorageMap(connection1, storageMap1), it would fail to find it in m_storageAreasByConnection and return early. It would therefore fail to remove storageMapId1 as a listener of the StorageArea which still exists. -> This would leak the IPC::Connection that there would be a std::pair<RefPtr<IPC::Connection>, StorageMapID> with value (connection1, storageMap1) which would get leaked and it would ref the IPC::Connection.

This code should really be refactored to be less leak prone but I have kept the patch minimal for now
to facilitate cherry-picking.

Note that this would reproduce very easily on sina.com.cn, when clicking bold links at the top, which
opens new tabs to different pages in the same WebContent process. When closing all Safari windows, the
IPC::Connection for this WebContent process would stay alive.

• UIProcess/WebStorage/StorageManager.cpp: (WebKit::StorageManager::StorageArea::hasListener const): (WebKit::StorageManager::createTransientLocalStorageMap):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [235692] by bshafiei@apple.com

• 5 edits in branches/safari-606-branch/Source/JavaScriptCore

Cherry-pick r234649. rdar://problem/43009920

Use a more specific PtrTag for PlatformRegisters PC and LR.
​https://bugs.webkit.org/show_bug.cgi?id=188366
<rdar://problem/42984123>

Reviewed by Keith Miller.

Also fixed a bug in linkRegister(), which was previously returning the PC instead
of LR. It now returns LR.

• runtime/JSCPtrTag.h:
• runtime/MachineContext.h: (JSC::MachineContext::instructionPointer): (JSC::MachineContext::linkRegister):
• runtime/VMTraps.cpp: (JSC::SignalContext::SignalContext):
• tools/SigillCrashAnalyzer.cpp: (JSC::SignalContext::SignalContext):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:34 PM Changeset in webkit [235691] by bshafiei@apple.com

• 6 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234651. rdar://problem/43009912

[Wi-Fi Assertions] suspendWiFiAssertions() should be able to delay sending ProcessReadyToSuspend
​https://bugs.webkit.org/show_bug.cgi?id=188373
<rdar://problem/42857398>

Reviewed by Tim Horton.

• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::actualPrepareToSuspend):
• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformPrepareToSuspend): (WebKit::NetworkProcess::platformProcessDidTransitionToBackground):
• NetworkProcess/curl/NetworkProcessCurl.cpp: (WebKit::NetworkProcess::platformPrepareToSuspend):
• NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::platformPrepareToSuspend):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@234651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:25 PM Changeset in webkit [235690] by commit-queue@webkit.org

• 17 edits in trunk

Add infrastructure to dump resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=189213

Patch by Woodrow Wang <​woodrow_wang@apple.com> on 2018-09-05
Source/WebCore:

Reviewed by Daniel Bates.

The dumping functionality is not currently used, but will be included in tests for
<​https://bugs.webkit.org/show_bug.cgi?id=187773>.

• loader/ResourceLoadStatistics.h:

Source/WebKit:

Reviewed by Daniel Bates.

The dumping functionality is not currently used, but will be included in tests for
<​https://bugs.webkit.org/show_bug.cgi?id=187773>.

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreDumpResourceLoadStatistics):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::dumpResourceLoadStatistics const):

• UIProcess/ResourceLoadStatisticsMemoryStore.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::dumpResourceLoadStatistics):

• UIProcess/WebResourceLoadStatisticsStore.h:

Tools:

Reviewed by Daniel Bates.

The dumping functionality is not currently used, but will be included in tests for
<​https://bugs.webkit.org/show_bug.cgi?id=187773>.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDumpResourceLoadStatistics):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::resourceStatisticsStringResultCallback):
(WTR::TestController::dumpResourceLoadStatistics):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::setDumpResourceLoadStatistics):

• WebKitTestRunner/TestInvocation.h:

2:15 PM Changeset in webkit [235689] by Wenson Hsieh

• 2 edits in trunk/Tools

[macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
​https://bugs.webkit.org/show_bug.cgi?id=189315

Reviewed by Tim Horton.

Fix the test failure by explicitly enabling custom pasteboard data.

• TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:

(TEST):

2:15 PM Changeset in webkit [235688] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r235006): Let Xcode have its way with the WebKit project

• WebKit.xcodeproj/project.pbxproj: Let Xcode remove empty

settings.

2:15 PM Changeset in webkit [235687] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r110214): Remove deleted WebProcess/Fullscreen/mac folder from WebKit Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Folder removed via Xcode.

• WebKit.xcodeproj/project.pbxproj:

(WebProcess/Fullscreen/mac): Remove empty folder. Directory no
longer exists. WebFullScreenManagerMac.{h,mm} files were
removed in r110214.

1:51 PM Changeset in webkit [235686] by Ryan Haddad

• 2 edits in trunk/Source/WebCore

Unreviewed, fix the build with recent SDKs.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::exernalDeviceDisplayNameForPlayer):

1:38 PM Changeset in webkit [235685] by keith_miller@apple.com

• 7 edits in trunk/Source/JavaScriptCore

RELEASE_ASSERT at ../../Source/JavaScriptCore/heap/MarkedSpace.h:83
​https://bugs.webkit.org/show_bug.cgi?id=188917

Reviewed by Mark Lam.

Our allocators should be able to handle allocating a zero-sized object.
Zero-sized objects will be allocated into the smallest size class.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithSize):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize):

• heap/MarkedSpace.h:

(JSC::MarkedSpace::sizeClassToIndex):
(JSC::MarkedSpace::indexToSizeClass):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitAllocateVariableSized):

• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

1:21 PM Changeset in webkit [235684] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Fix DeferredSourceDump to capture the caller bytecodeIndex instead of CodeOrigin.
​https://bugs.webkit.org/show_bug.cgi?id=189300
<rdar://problem/39681779>

Reviewed by Saam Barati.

At the time a DeferredSourceDump is instantiated, it captures a CodeOrigin value
which points to a InlineCallFrame in the DFG::Plan's m_inlineCallFrames set. The
DeferredSourceDump is later used to dump source even if the compilation fails.
This is intentional so that we can use this tool to see what source fails to
compile as well.

The DFG::Plan may have been destructed by then, and since the compilation failed,
the InlineCallFrame is also destructed. This means DeferredSourceDump::dump()
may be end up accessing freed memory.

DeferredSourceDump doesn't really need a CodeOrigin. All it wants is the caller
bytecodeIndex for the call to an inlined function. Hence, we can fix this issue
by changing DeferredSourceDump to capture the caller bytecodeIndex instead.

In this patch, we also change DeferredSourceDump's m_codeBlock and m_rootCodeBlock
to be Strong references to ensure that the CodeBlocks are kept alive until they
can be dumped.

• bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::dumpCompiledSourcesIfNeeded):

• bytecode/DeferredSourceDump.cpp:

(JSC::DeferredSourceDump::DeferredSourceDump):
(JSC::DeferredSourceDump::dump):

• bytecode/DeferredSourceDump.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

12:03 PM Changeset in webkit [235683] by commit-queue@webkit.org

• 9 edits in trunk

Added runtime feature flag for web API statistics
​https://bugs.webkit.org/show_bug.cgi?id=189211

Patch by Woodrow Wang <​woodrow_wang@apple.com> on 2018-09-05
Reviewed by Daniel Bates.

Source/WebCore:

Added functionality to get and set the runtime flag.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAPIStatisticsEnabled):
(WebCore::RuntimeEnabledFeatures::webAPIStatisticsEnabled const):

Source/WebKit:

Added functionality to set the runtime flag with a JavaScript exposed function
for testing.

• Shared/WebPreferences.yaml:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

Added functionality to set the runtime flag with a JavaScript exposed function
for testing.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAPIStatisticsEnabled):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

11:54 AM Changeset in webkit [235682] by youenn@apple.com

• 7 edits in trunk/Source/WebCore

Move replaceTrack logic to LibWebRTCPeerConnectionBackend
​https://bugs.webkit.org/show_bug.cgi?id=189281

Reviewed by Eric Carlson.

Move replaceTrack handling code from RTCPeerConnection to LibWebRTCPeerConnectionBackend.
This makes the logic easier to understand.
Future refactoring will further try to put more handling in RTCRtpSenderBackend.
No change of behavior.

• Modules/mediastream/RTCPeerConnection.cpp:
• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::tryUpdatingTrackSource):
(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):
(WebCore::LibWebRTCPeerConnectionBackend::enqueueReplaceTrackTask):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

11:52 AM Changeset in webkit [235681] by Alan Bujtas

• 12 edits in trunk/Source/WebCore

[LFC] LayoutContext::displayBoxForLayoutBox() should return a Display::Box&
​https://bugs.webkit.org/show_bug.cgi?id=189311

Reviewed by Antti Koivisto.

When the layout logic needs a Display::Box, we must have already created one for the associated Layout::Box.
(It does not necessarily mean that evey Layout::Box has a Display::Box. For example in case of inline formatting context,
we don't create a Display::Box for every inline box, but the formatting logic does not require such pairs.)

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopLeftToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

• layout/LayoutContext.h:

(WebCore::Layout::LayoutContext::displayBoxForLayoutBox const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::append):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):

11:33 AM Changeset in webkit [235680] by david_fenton@apple.com

• 2 edits in trunk/JSTests

[32-bit JSC tests] Exception: ReferenceError: Can't find variable: WebAssembly.
​https://bugs.webkit.org/show_bug.cgi?id=189312.

Unreviewed test gardening.

• stress/regress-189185.js:

11:13 AM Changeset in webkit [235679] by Truitt Savell

• 2 edits in trunk/LayoutTests

Rebaseline test after changes in ​https://trac.webkit.org/changeset/235669/webkit deleted the expectation.
​https://bugs.webkit.org/show_bug.cgi?id=188816

Unreviewed Test Gardening.

• platform/mac-wk1/imported/w3c/web-platform-tests/xhr/send-network-error-async-events.sub-expected.txt:

10:58 AM Changeset in webkit [235678] by Ross Kirsling

• 5 edits
  2 adds in trunk/Tools

Add WinCairo to bot watcher's dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=189273

Reviewed by Aakash Jain.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows10@2x.png: Added.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.windows-10 img.logo): Added.
(table.queue-grid tr.platform.windows-8 img.logo): Deleted.
(table.queue-grid tr.platform.windows-xp img.logo): Deleted.
Add Win10 section to dashboard. Remove unused WinXP and Win8 sections.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):
Add WinCairo build, test, and EWS bots to Win10 section of dashboard.

10:54 AM Changeset in webkit [235677] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC] Drop Display:Box from FormattingContext::compute* functions
​https://bugs.webkit.org/show_bug.cgi?id=189309

Reviewed by Antti Koivisto.

They are redundant and could get out of sync.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

• layout/FormattingContext.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

• layout/blockformatting/BlockFormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):

• layout/inlineformatting/InlineFormattingContext.h:

10:40 AM Changeset in webkit [235676] by bshafiei@apple.com

• 7 edits in trunk/Source

Versioning.

10:26 AM Changeset in webkit [235675] by jer.noble@apple.com

• 10 edits in trunk/Source

Add MediaCapabilities as an Experimental Feature
​https://bugs.webkit.org/show_bug.cgi?id=189209

Reviewed by Eric Carlson.

Source/WebCore:

Move mediaCapabilitiesEnabled out of RuntimeEnabledFeatures. It already (also) exists in Settings.

• Modules/mediacapabilities/MediaCapabilities.idl:
• Modules/mediacapabilities/MediaCapabilitiesInfo.idl:
• Modules/mediacapabilities/NavigatorMediaCapabilities.idl:
• Modules/mediacapabilities/ScreenLuminance.idl:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMediaCapabilitiesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaCapabilitiesEnabled const): Deleted.

Source/WebKit:

• Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

RuntimeEnabledFeature -> Setting.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

10:11 AM Changeset in webkit [235674] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Cancelled fullscreen exit gesture leaves bad state for next exit request.
​https://bugs.webkit.org/show_bug.cgi?id=189278

Patch by Jeremy Jones <​jeremyj@apple.com> on 2018-09-05
Reviewed by Jer Noble.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _dismissFullscreenViewController]):

10:03 AM Changeset in webkit [235673] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebCore

Add functionality to encode and decode a uint64_t in KeyedCoding
​https://bugs.webkit.org/show_bug.cgi?id=189216

Patch by Woodrow Wang <​woodrow_wang@apple.com> on 2018-09-05
Reviewed by Daniel Bates.

I've added this functionality in order to be able to encode and decode the raw uint64_t
representation of an OptionSet for my patch here <​https://bugs.webkit.org/show_bug.cgi?id=187773>.

The changes in the KeyedEncoder/KeyedDecoder for Glib were made because they are derived classes
of KeyedCoding which contains pure virtual functions that need to be implemented.

• platform/KeyedCoding.h:
• platform/cf/KeyedDecoderCF.cpp:

(WebCore::KeyedDecoderCF::decodeUInt64):

• platform/cf/KeyedDecoderCF.h:
• platform/cf/KeyedEncoderCF.cpp:

(WebCore::KeyedEncoderCF::encodeUInt64):

• platform/cf/KeyedEncoderCF.h:
• platform/glib/KeyedDecoderGlib.cpp:

(WebCore::KeyedDecoderGlib::decodeUInt64):

• platform/glib/KeyedDecoderGlib.h:
• platform/glib/KeyedEncoderGlib.cpp:

(WebCore::KeyedEncoderGlib::encodeUInt64):

• platform/glib/KeyedEncoderGlib.h:

9:49 AM Changeset in webkit [235672] by ddkilzer@apple.com

• 2 edits in trunk/Tools

REGRESSION (r209470): EditingHistory folder is missing in EditingHistory Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fixes were made manually.

• EditingHistory/EditingHistory.xcodeproj/project.pbxproj:

(EditingHistory): Change the path of the folder to
"EditingHistory", then remove the now-redundant name.
(EditingHistory/Resources/DumpEditingHistory.js): Remove
redundant file reference since another file reference exists at
the top of the project file list, and that file reference is the
one used in the "Copy Bundle Resources" build phase.
(EditingHistory/Resources/EditingHistoryUtil.js): Ditto.

9:20 AM Changeset in webkit [235671] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GTK] ASSERT(!m_nicosia.imageBacking) when starting any YouTube video
​https://bugs.webkit.org/show_bug.cgi?id=189215

Reviewed by Carlos Garcia Campos.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
Manually clear out any layer-side state of any image backing that is
associated with this layer, much like we do for backing stores.

8:56 AM Changeset in webkit [235670] by eric.carlson@apple.com

• 34 edits in trunk/Source

[MediaStream] Simplify logic when changing RealtimeMediaSource settings
​https://bugs.webkit.org/show_bug.cgi?id=189284
<rdar://problem/44117948>

Reviewed by Youenn Fablet.

Source/WebCore:

Remove all "apply<setting>" methods from RealtimeMediaSource and derived classes, and
add a bitfield to settingsDidChange so classes can do setting-specific setup and
configuration by overriding settingsDidChange.

No new tests, no functionality changed.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasResized):

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
• platform/mediastream/MediaConstraints.h:

(WebCore::NumericConstraint::fitnessDistance const):
(WebCore::NumericConstraint::valueForDiscreteCapabilityValues const):

• platform/mediastream/RealtimeIncomingVideoSource.h:

(): Deleted.

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::RealtimeMediaSource):
(WebCore::RealtimeMediaSource::settingsDidChange):
(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::applyNumericConstraint):
(WebCore::RealtimeMediaSource::applyConstraint):
(WebCore::RealtimeMediaSource::applyConstraints):
(WebCore::RealtimeMediaSource::setSize):
(WebCore::RealtimeMediaSource::setWidth):
(WebCore::RealtimeMediaSource::setHeight):
(WebCore::RealtimeMediaSource::setFrameRate):
(WebCore::RealtimeMediaSource::setAspectRatio):
(WebCore::RealtimeMediaSource::setFacingMode):
(WebCore::RealtimeMediaSource::setVolume):
(WebCore::RealtimeMediaSource::setSampleRate):
(WebCore::RealtimeMediaSource::setSampleSize):
(WebCore::RealtimeMediaSource::setEchoCancellation):

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceSettings.cpp:

(WebCore::RealtimeMediaSourceSettings::diff const):

• platform/mediastream/RealtimeMediaSourceSettings.h:

(WebCore::RealtimeMediaSourceSettings::allFlags):

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::applySize): Deleted.
(WebCore::RealtimeVideoSource::applyFrameRate): Deleted.

• platform/mediastream/RealtimeVideoSource.h:
• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSource::settingsDidChange):
(WebCore::GStreamerAudioCaptureSource::applySampleRate): Deleted.

• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoCaptureSource::settingsDidChange):
(WebCore::GStreamerVideoCaptureSource::applySize): Deleted.
(WebCore::GStreamerVideoCaptureSource::applyFrameRate): Deleted.

• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::settingsDidChange):
(WebCore::AVVideoCaptureSource::setPreset):
(WebCore::AVVideoCaptureSource::setFrameRate):
(WebCore::AVVideoCaptureSource::applySizeAndFrameRate):
(WebCore::AVVideoCaptureSource::processNewFrame):
(WebCore::AVVideoCaptureSource::applySize): Deleted.
(WebCore::AVVideoCaptureSource::applyFrameRate): Deleted.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::settingsDidChange):
(WebCore::CoreAudioCaptureSource::applySampleRate): Deleted.
(WebCore::CoreAudioCaptureSource::applyEchoCancellation): Deleted.

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::settingsDidChange):
(WebCore::DisplayCaptureSourceCocoa::startProducingData):
(WebCore::DisplayCaptureSourceCocoa::applySize): Deleted.
(WebCore::DisplayCaptureSourceCocoa::applyFrameRate): Deleted.

• platform/mediastream/mac/DisplayCaptureSourceCocoa.h:
• platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
• platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::settingsDidChange):
(WebCore::MockRealtimeAudioSourceMac::applySampleRate): Deleted.

• platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
• platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::settingsDidChange):
(WebCore::MockRealtimeVideoSourceMac::applySize): Deleted.

• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::processNewSample):

• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::ScreenDisplayCaptureSourceMac::settingsDidChange):
(WebCore::ScreenDisplayCaptureSourceMac::applySize): Deleted.
(WebCore::ScreenDisplayCaptureSourceMac::applyFrameRate): Deleted.

• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::settingsDidChange):

• platform/mock/MockRealtimeAudioSource.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::settingsDidChange):
(WebCore::MockRealtimeVideoSource::applySize): Deleted.

• platform/mock/MockRealtimeVideoSource.h:

Source/WebKit:

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::Source::setSettings):

8:22 AM Changeset in webkit [235669] by Ms2ger@igalia.com

• 5 edits
  4 adds in trunk/LayoutTests

GTK-focused gardening
​https://bugs.webkit.org/show_bug.cgi?id=189305

Unreviewed test gardening.

• TestExpectations: Remove passing test.
• fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html: Speculative fix for r235484.
• platform/gtk/http/tests/inspector/network/resource-request-headers-expected.txt: Added.
• platform/gtk/http/tests/loading/oauth-expected.txt: Added.
• platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt: Updated for r235354.
• platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Updated for r235245.

7:42 AM Changeset in webkit [235668] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][BFC] Move MarginCollapse class under BlockFormattingContext::Geometry
​https://bugs.webkit.org/show_bug.cgi?id=189296

Reviewed by Antti Koivisto.

Margin collapsing is part of geometry after all.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginTop):

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParentMarginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBottom):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginTopCollapsedWithParentMarginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBottomFromLastChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginTop): Deleted.

7:36 AM Changeset in webkit [235667] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC] Make BlockFormattingContext::Geometry a subclass of FormattingContext::Geometry
​https://bugs.webkit.org/show_bug.cgi?id=189294

Reviewed by Antti Koivisto.

This simplifies some of the call sites.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):

7:19 AM Changeset in webkit [235666] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r235419): DFGCFG.h is missing from JavaScriptCore Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fix was made manually.

• JavaScriptCore.xcodeproj/project.pbxproj:

(dfg/DFGCFG.h): Revert accidental change in r235419 by restoring
name and path values to file reference.

5:31 AM Changeset in webkit [235665] by ddkilzer@apple.com

• 2 edits in trunk/Tools

REGRESSION (r160736): Bundle folder is missing in MiniBrowser Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Folder fix was made manually.

• MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:

(Bundle): Change the path of the folder to "mac/Bundle", and set
the name back to "Bundle".
(Bundle/Info.plist): Change file reference to be relative to its
group. Accomplished using Xcode after fixing the folder path.
(Bundle/MiniBrowserBundle_Prefix.pch): Ditto.

5:09 AM Changeset in webkit [235664] by ddkilzer@apple.com

• 2 edits in trunk/Tools

REGRESSION (r184033): ContentExtensionTester folder is missing in ContentExtensionTester Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fixes were made manually.

• ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:

(ContentExtensionTester): Change the path of the folder to map
to "." (which exists and is where main.m is located), and then
set the folder's name back to "ContentExtensionTester".
(main.m): Change file reference to be relative to its group now
that the group's path is fixed.

4:46 AM Changeset in webkit [235663] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKitLegacy

REGRESSION (r235585): WebDownloadInternal.h is missing from WebKitLegacy Xcode project
<​https://bugs.webkit.org/show_bug.cgi?id=189072>

Found using tidy-Xcode-project-file (see Bug 188754).

• WebKitLegacy.xcodeproj/project.pbxproj: Remove references to

WebDownloadInternal.h since the header was removed in r235585.

2:44 AM WebKitGTK/2.22.x edited by berto@igalia.com

(diff)

1:14 AM Changeset in webkit [235662] by mark.lam@apple.com

• 3 edits
  1 add in trunk

isAsyncGeneratorMethodParseMode() should check for SourceParseMode::AsyncGeneratorWrapperMethodMode.
​https://bugs.webkit.org/show_bug.cgi?id=189292
<rdar://problem/38907433>

Reviewed by Saam Barati.

JSTests:

• stress/regress-189292.js: Added.

Source/JavaScriptCore:

Previously, isAsyncGeneratorMethodParseMode() was checking for AsyncGeneratorWrapperFunctionMode
instead of AsyncGeneratorWrapperMethodMode. This patch fixes it
to check for AsyncGeneratorWrapperMethodMode (to match what is expected as indicated
in the name isAsyncGeneratorMethodParseMode).

• parser/ParserModes.h:

(JSC::isAsyncGeneratorMethodParseMode):

12:52 AM Changeset in webkit [235661] by mark.lam@apple.com

• 2 edits in trunk/Source/WTF

Remove unused bad_optional_access implementation.
​https://bugs.webkit.org/show_bug.cgi?id=189297

Reviewed by David Kilzer.

This is a speculative fix for resolving build errors arising from conflicting
definitions of bad_optional_access when building WebKit with the latest clang.

• wtf/Optional.h:

(std::bad_optional_access::bad_optional_access): Deleted.