Timeline
Sep 23, 2018:
- 6:20 PM Changeset in webkit [236394] by
-
- 1 copy in tags/Safari-606.2.102
Tag Safari-606.2.102.
- 1:52 PM Changeset in webkit [236393] by
-
- 2 edits in trunk/Source/WebCore
Add missing includes in TextCodecReplacement.cpp
https://bugs.webkit.org/show_bug.cgi?id=189894
Patch by Frederic Wang <fwang@igalia.com> on 2018-09-23
Reviewed by Darin Adler.
No new tests, behavior unchanged.
- platform/text/TextCodecReplacement.cpp: Add missing headers.
- 1:39 AM WebKitGTK/2.22.x edited by
- (diff)
Sep 22, 2018:
- 9:49 PM Changeset in webkit [236392] by
-
- 3 edits in trunk/LayoutTests
Unreviewed - Skip pointer events tests on legacy WebKit.
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 9:22 PM Changeset in webkit [236391] by
-
- 2 edits in trunk/Source/WebCore
[ARM] Building FELightingNEON.cpp fails due to missing lightVector member
https://bugs.webkit.org/show_bug.cgi?id=189890
Reviewed by Darin Adler.
No new tests needed.
- platform/graphics/cpu/arm/filters/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon): Adapt to new layout of "struct PaintingData" after r225122.
- 4:49 PM Changeset in webkit [236390] by
-
- 12 edits2 copies in trunk/Tools
[WHSL] Need grammar to specify kernel group size
https://bugs.webkit.org/show_bug.cgi?id=189108
Reviewed by Dean Jackson.
In HLSL, compute functions are annotated with their workgroup size.
For example,
[numthreads(3, 4, 5)] compute void foo(...) { ... }
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/Func.js:
(Func):
(Func.prototype.get attributeBlock):
- WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
(FuncAttribute):
- WebGPUShadingLanguageRI/FuncDef.js:
(FuncDef):
- WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
(FuncNumThreadsAttribute):
(FuncNumThreadsAttribute.prototype.get x):
(FuncNumThreadsAttribute.prototype.get y):
(FuncNumThreadsAttribute.prototype.get z):
- WebGPUShadingLanguageRI/LateChecker.js:
(LateChecker.prototype._checkShaderType):
- WebGPUShadingLanguageRI/Parse.js:
(parseAttributeBlock):
(parseFuncDecl):
(parseFuncDef):
(parseNativeFunc):
- WebGPUShadingLanguageRI/SPIRV.html:
- WebGPUShadingLanguageRI/StatementCloner.js:
(StatementCloner.prototype.visitFuncDef):
(StatementCloner.prototype.visitFuncNumThreadsAttribute):
(StatementCloner):
- WebGPUShadingLanguageRI/Test.html:
- WebGPUShadingLanguageRI/Test.js:
(tests.numThreads):
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitFunc):
(Visitor.prototype.visitFuncNumThreadsAttribute):
(Visitor):
- WebGPUShadingLanguageRI/index.html:
- 4:42 PM Changeset in webkit [236389] by
-
- 3 edits in trunk/LayoutTests
Tests checking document GC in case of ActiveDOMObjects are flaky
https://bugs.webkit.org/show_bug.cgi?id=189413
<rdar://problem/44243231>
Reviewed by Eric Carlson.
Media controls prevent in some cases to collect the document.
Remove the controls to remove a source of flakiness for this test.
- http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm:
- platform/mac/TestExpectations:
- 4:34 PM Changeset in webkit [236388] by
-
- 4 edits in trunk/Tools
Native functions which accept pointers need to do null checks
https://bugs.webkit.org/show_bug.cgi?id=189883
Reviewed by Dean Jackson.
Simply guard all the places where we write through an author-provided pointer.
- WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics.):
- WebGPUShadingLanguageRI/Test.js:
(tests.textureDimensionsNull):
- 4:22 PM Changeset in webkit [236387] by
-
- 4 edits in trunk/Tools
[WHLSL] Implement atomic operations and barriers
https://bugs.webkit.org/show_bug.cgi?id=189025
Reviewed by Dean Jackson.
In the interpreter, atomic operations don't need to be atomic.
- WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics.):
- WebGPUShadingLanguageRI/StandardLibrary.js:
(let.standardLibrary):
- WebGPUShadingLanguageRI/Test.js:
(tests.atomics):
- 5:54 AM Changeset in webkit [236386] by
-
- 3 edits in trunk/Source/WebCore
[Cairo] Null-check cairo_pattern_t gradient objects
https://bugs.webkit.org/show_bug.cgi?id=189820
Reviewed by Alex Christensen.
Cairo-specific implementation of Gradient::createPlatformGradient() can
now return a nullptr value when a conic gradient is described by the
Gradient object. Cairo doesn't have a way to create cairo_pattern_t
objects for such gradients.
Null-checks are now done on return values of createPlatformGradient(),
in order to avoid proceeding to paint a null cairo_pattern_t object.
- platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::fill):
- platform/graphics/cairo/GraphicsContextImplCairo.cpp:
(WebCore::GraphicsContextImplCairo::fillRect):
- 5:43 AM Changeset in webkit [236385] by
-
- 2 edits in trunk/Tools
[WPE] Be very permissive in the MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=189800
This is just a test tool and we should make
it just work, security and privacy is not really
a primary focus here.
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-09-22
Reviewed by Žan Doberšek.
- MiniBrowser/wpe/main.cpp:
(decidePermissionRequest):
(main):
- 1:13 AM Changeset in webkit [236384] by
-
- 6 edits4 adds in trunk
Cannot start a drag inside a shadow tree when an inclusive-ancestor of its shadow host is a draggable element
https://bugs.webkit.org/show_bug.cgi?id=136836
Reviewed by Wenson Hsieh.
Source/WebCore:
Fixed the bug by simply generalizing the existing code path existed for video / input type=color.
Tests: fast/shadow-dom/dragging-element-inside-shadow-tree.html
fast/shadow-dom/dragging-element-with-shadow-tree.html
- page/DragController.cpp:
(WebCore::DragController::startDrag):
LayoutTests:
Added regression tests for dragging a element with a shadow tree, which is fixed in this bug
as well as dragging an element inside a shadow tree, which was already functional but had no tests.
- TestExpectations:
- fast/shadow-dom/dragging-element-inside-shadow-tree-expected.txt: Added.
- fast/shadow-dom/dragging-element-inside-shadow-tree.html: Added.
- fast/shadow-dom/dragging-element-with-shadow-tree-expected.txt: Added.
- fast/shadow-dom/dragging-element-with-shadow-tree.html: Added.
- platform/ios/TestExpectations: Don't mark the entirety of fast/shadow-dom as PASS.
- platform/mac-wk1/TestExpectations:
- 12:56 AM Changeset in webkit [236383] by
-
- 2 edits in trunk/Source/WebCore
FontDataCache should use Ref<Font> instead of a RefPtr<Font>
https://bugs.webkit.org/show_bug.cgi?id=189861
Reviewed by Antti Koivisto.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::fontForPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
- 12:28 AM Changeset in webkit [236382] by
-
- 5 edits1 add in trunk
The sampling should not use Strong<CodeBlock> in its machineLocation field
https://bugs.webkit.org/show_bug.cgi?id=189319
Reviewed by Filip Pizlo.
JSTests:
- stress/sampling-profiler-richards.js: Added.
Source/JavaScriptCore:
The sampling profiler has a CLI mode where we gather information about inline
call frames. That data structure was using a Strong<CodeBlock>. We were
constructing this Strong<CodeBlock> during GC concurrently to processing all
the Strong handles. This is a bug since we end up corrupting that data
structure. This patch fixes this by just making this data structure use the
sampling profiler's mechanism for holding onto and properly visiting heap pointers.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):
These CLI helpers needed a DeferGC otherwise we may end up deadlocking when we
cause a GC to happen while already holding the sampling profiler's
lock.
