Context Navigation

← Previous Period
Next Period →

Timeline

Sep 29, 2018:

10:40 AM Changeset in webkit [236644] by commit-queue@webkit.org

11 edits in trunk

Unreviewed, rolling out r236631.
https://bugs.webkit.org/show_bug.cgi?id=190112

Caused various eventSender tests, including fast/css/pseudo-
active-style-sharing*, to fail (Requested by smfr on #webkit).

Reverted changeset:

"Regression(r236512): http/tests/navigation/keyboard-events-
during-provisional-navigation.html is flaky"
https://bugs.webkit.org/show_bug.cgi?id=190052
https://trac.webkit.org/changeset/236631

5:11 AM Changeset in webkit [236643] by commit-queue@webkit.org

3 edits
2 adds in trunk

[css-grid] Properly align items next to collapsed tracks with gutters
https://bugs.webkit.org/show_bug.cgi?id=190089

Patch by Oriol Brufau <Oriol Brufau> on 2018-09-29
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import grid-gutters-013.html and reference from WPT.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-013.html

web-platform-tests/css/css-grid/alignment/grid-gutters-013-expected.xht: Added.
web-platform-tests/css/css-grid/alignment/grid-gutters-013.html: Added.

Source/WebCore:

gridAreaPositionForInFlowChild could return a wrong end position for
grid items adjacent to a collapsed track, because it didn't take into
account that gutters collapse in that case. Therefore, "center" or
"end" alignments displayed the item at the wrong position.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-013.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridAreaPositionForInFlowChild const):

4:52 AM Changeset in webkit [236642] by youenn@apple.com

2 edits
1249 adds in trunk/Source/ThirdParty/libwebrtc

Add yasm as third party tool for libwebrtc compilation
https://bugs.webkit.org/show_bug.cgi?id=190025

Reviewed by Eric Carlson.

Add yasm source code and build the yasm executable as it is needed for libvpx compilati

Source/third_party/yasm-1.3.0: Added.
libwebrtc.xcodeproj/project.pbxproj:

2:49 AM Changeset in webkit [236641] by Chris Dumez

2 edits in trunk/Source/WebKit

[PSON] Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=190084
<rdar://problem/44844561>

Reviewed by Antti Koivisto.

Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage(), as a
result of calling WebPage::tearDownDrawingAreaForSuspend().

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

2:43 AM Changeset in webkit [236640] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer][MSE] Use GObject for GST_TRACE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=190045

Reviewed by Philippe Normand.

Passing a non-GObject object to GST_TRACE_OBJECT() can be
theoretically misunderstood by the GStreamer logging function, so this
patch avoids that.

platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe):
(WebCore::AppendPipeline::handleEndOfAppend):
(WebCore::AppendPipeline::consumeAppsinkAvailableSamples):
(WebCore::AppendPipeline::pushNewBuffer):

Sep 28, 2018:

11:55 PM Changeset in webkit [236639] by mmaxfield@apple.com

3 edits in trunk/Tools

[WHLSL] Fix build after r236635
https://bugs.webkit.org/show_bug.cgi?id=189210

Unreviewed.

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics.):

WebGPUShadingLanguageRI/Test.js:

(tests.atomicsNull):
(tests.numThreads):
(tests.textureDimensionsNull):

11:29 PM Changeset in webkit [236638] by bshafiei@apple.com

14 edits in branches/safari-606-branch

Cherry-pick r236615. rdar://problem/44883290

[Apple Pay] Remove the "in-store" button type
https://bugs.webkit.org/show_bug.cgi?id=190079

Reviewed by Tim Horton.

Source/WebCore:

According to <https://developer.apple.com/design/human-interface-guidelines/apple-pay/buttons-and-marks/buttons/>,
this button is meant only for certain kinds of native apps. It shouldn't be available on the web.

Updated http/tests/ssl/applepay/ApplePayButton.html.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):
css/CSSValueKeywords.in:
css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
rendering/RenderThemeCocoa.mm: (WebCore::toPKPaymentButtonType):
rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

http/tests/ssl/applepay/ApplePayButton.html:
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.png:
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:55 PM Changeset in webkit [236637] by Caio Lima

31 edits
6 adds in trunk

[ESNext][BigInt] Implement support for "&"
https://bugs.webkit.org/show_bug.cgi?id=186228

Reviewed by Yusuke Suzuki.

JSTests:

stress/big-int-bitwise-and-general.js: Added.

(assert):
(assert.sameValue):

stress/big-int-bitwise-and-jit.js: Added.

(let.assert.sameValue):
(bigIntBitAnd):

stress/big-int-bitwise-and-memory-stress.js: Added.

(assert):

stress/big-int-bitwise-and-to-primitive-precedence.js: Added.

(assert.sameValue):
(let.o.Symbol.toPrimitive):
(catch):

stress/big-int-bitwise-and-type-error.js: Added.

(assert):
(assertThrowTypeError):
(let.o.valueOf):
(o.valueOf):
(o.toString):
(o.Symbol.toPrimitive):

stress/big-int-bitwise-and-wrapped-value.js: Added.

(assert.sameValue):
(testBitAnd):
(let.o.Symbol.toPrimitive):
(o.valueOf):
(o.toString):

Source/JavaScriptCore:

This patch introduces support of BigInt into bitwise "&" operation.
We are also introducing the ValueBitAnd DFG node, that is responsible
to take care of JIT for non-Int32 operands. With the introduction of this
new node, we renamed the BitAnd node to ArithBitAnd. The ArithBitAnd
follows the behavior of ArithAdd and other arithmetic nodes, where
the Arith<op> version always results in Number (in the case of
ArithBitAnd, its is always an Int32).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitBinaryOp):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::propagate):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueBitwiseOp):
(JSC::DFG::SpeculativeJIT::compileBitwiseOp):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::bitOp):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileArithBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileBitAnd): Deleted.

jit/JIT.h:
jit/JITArithmetic.cpp:

(JSC::JIT::emitBitBinaryOpFastPath):
(JSC::JIT::emit_op_bitand):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/JSBigInt.cpp:

(JSC::JSBigInt::JSBigInt):
(JSC::JSBigInt::initialize):
(JSC::JSBigInt::createZero):
(JSC::JSBigInt::createFrom):
(JSC::JSBigInt::bitwiseAnd):
(JSC::JSBigInt::absoluteBitwiseOp):
(JSC::JSBigInt::absoluteAnd):
(JSC::JSBigInt::absoluteOr):
(JSC::JSBigInt::absoluteAndNot):
(JSC::JSBigInt::absoluteAddOne):
(JSC::JSBigInt::absoluteSubOne):

runtime/JSBigInt.h:
runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::JSValue::toBigIntOrInt32 const):

8:29 PM Changeset in webkit [236636] by commit-queue@webkit.org

3 edits
2 adds in trunk

Angled gradient backgrounds in body render vertically when body height is 0
https://bugs.webkit.org/show_bug.cgi?id=177232
<rdar://problem/34548230>.

Patch by Zamiul Haque <zhaque@apple.com> on 2018-09-28
Reviewed by Tim Horton.

Source/WebCore:

Specifically, gradients displayed at an angle (ie. 45 degrees) are rendered
as if they are vertical when the body tag containing the gradient
has a height of 0. Other browsers do not render under these circumstances,
so WebKit was modified to follow in suit. The problem was due to layout sizes for
fill tiles being calculated with a minimum height of 1px. A simple change of the
minimum height and width to 0px was enough to bring about the desired behavior.

Tests: angled-background-repeating-gradient-rendering-vertical.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize const):

LayoutTests:

Added tests to make sure that angled background gradients inside of a
body tag of height 0 render as empty white screens.

angled-background-repeating-gradient-rendering-vertical.html: Added.
angled-background-repeating-gradient-rendering-vertical-expected.html: Added.

7:27 PM Changeset in webkit [236635] by mmaxfield@apple.com

5 edits in trunk/Tools

[WHLSL] Allow uniform buffers to be used in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=189210

Reviewed by Filip Pizlo.

Every lvalue is associated with an address space, and the propagation of these address spaces
matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
of this, so this patch just goes the last few yards. It also updates the standard library to
allow for writing into all writable address spaces for out-params.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitAssignment):
(Checker.prototype._finishVisitingPropertyAccess):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics.):
(Intrinsics.checkFalse):
(Intrinsics):

WebGPUShadingLanguageRI/StandardLibrary.js:

(let.standardLibrary):

WebGPUShadingLanguageRI/Test.js:

(tests.threadArrayRefLoad):
(tests.threadArrayRefLoadIntLiteral):
(tests.deviceArrayRefLoad):
(tests.threadArrayRefStore):
(tests.deviceArrayRefStore):
(tests.deviceArrayRefStoreIntLiteral):
(tests.threadPointerLoad):
(tests.threadPointerStore):
(tests.devicePointerLoad):
(tests.devicePointerStore):
(tests.arrayLoad):
(tests.constantAddressSpace):
(tests.standardLibraryDevicePointers):
(tests.threadArrayLoad): Deleted.
(tests.threadArrayLoadIntLiteral): Deleted.
(tests.deviceArrayLoad): Deleted.
(tests.threadArrayStore): Deleted.
(tests.deviceArrayStore): Deleted.
(tests.deviceArrayStoreIntLiteral): Deleted.

7:12 PM Changeset in webkit [236634] by Wenson Hsieh

27 edits in trunk

No DOM API to instantiate an attachment for an img element
https://bugs.webkit.org/show_bug.cgi?id=189934
<rdar://problem/44743222>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds support for HTMLAttachmentElement.getAttachmentIdentifier, a function that internal WebKit clients can use
to ensure that an image element is backed by a unique _WKAttachment. See below for more details.

Tests: WKAttachmentTests.AddAttachmentToConnectedImageElement

WKAttachmentTests.ChangeFileWrapperForPastedImage
WKAttachmentTests.ConnectImageWithAttachmentToDocument

dom/Document.cpp:

(WebCore::Document::registerAttachmentIdentifier):

Add a new hook to register an empty _WKAttachment in the UI process with a given identifier. Used when creating
a new empty attachment to back an image element.

dom/Document.h:
editing/Editor.cpp:

(WebCore::Editor::registerAttachmentIdentifier):
(WebCore::Editor::notifyClientOfAttachmentUpdates):

editing/Editor.h:
html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::getAttachmentIdentifier):

Creates an attachment element to back the image element, if an attachment does not already exist, and returns
the unique identifier. This also causes an empty corresponding _WKAttachment to be created in the client, whose
file wrapper determines the contents of the image.

(WebCore::HTMLAttachmentElement::ensureUniqueIdentifier):
(WebCore::HTMLAttachmentElement::hasEnclosingImage const):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

Add a helper that updates the source of the enclosing image element given a content type and image data, by
creating a new blob and blob URL.

html/HTMLAttachmentElement.h:
html/HTMLAttachmentElement.idl:
html/HTMLImageElement.idl:

Rename webkitAttachmentIdentifier to just attachmentIdentifier.

page/EditorClient.h:

(WebCore::EditorClient::registerAttachmentIdentifier):
(WebCore::EditorClient::didInsertAttachmentWithIdentifier):

Source/WebKit:

Makes some adjustments to support using _WKAttachment's file wrapper to change the contents of any image element
hosting the attachment in its shadow root. To do this, we add some plumbing to allow the UI process to update an
attachment element's enclosing image with data from its file wrapper.

UIProcess/API/APIAttachment.cpp:

(API::Attachment::isEmpty const):
(API::Attachment::enclosingImageData const):

Helper method that creates a SharedBuffer representing image data for the attachment. Only returns a non-null
value for attachment elements that are enclosed within an image.

UIProcess/API/APIAttachment.h:
UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::enclosingImageData const):
(API::Attachment::isEmpty const):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _attachmentForIdentifier:]):

Add new SPI to request a _WKAttachment for a given unique identifier. Currently, this is only used for testing.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::platformRegisterAttachment):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::registerAttachmentIdentifier):
(WebKit::WebPageProxy::didInsertAttachmentWithIdentifier):

Plumb whether or not the attachment is enclosed by an image from the web process to the UI process.

(WebKit::WebPageProxy::didRemoveAttachmentWithIdentifier):
(WebKit::WebPageProxy::didInsertAttachment): Deleted.
(WebKit::WebPageProxy::didRemoveAttachment):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerAttachmentIdentifier):
(WebKit::WebEditorClient::didInsertAttachmentWithIdentifier):

Update attachment attributes after inserting an attachment. This ensures that an attachment that was created and
later inserted via script into the document will be synced with state in the UI process, if the client has
changed the contents of the attachment.

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateAttachmentAttributes):

Plumb attachment data from the UI process to the web process.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Adds 3 new API tests in WKAttachmentTests:

AddAttachmentToConnectedImageElement verifies that an image element that's already in the document can gain an
attachment element via HTMLAttachmentElement.getAttachmentIdentifier.

ChangeFileWrapperForPastedImage verifies that an image that has been pasted produces a _WKAttachment in the UI
process, and changing the file wrapper of that _WKAttachment changes the pasted image.

ConnectImageWithAttachmentToDocument verifies that script can create an image element, ensure that it has an
attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
then result in an image element with the contents of the _WKAttachment's file wrapper.

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[TestWKWebView imageElementSize]):
(-[TestWKWebView waitForImageElementSizeToBecome:]):
(TestWebKitAPI::TEST):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.

7:03 PM Changeset in webkit [236633] by Chris Dumez

6 edits in trunk

The return value of an OnBeforeUnloadEventHandler should always be coerced into a DOMString
https://bugs.webkit.org/show_bug.cgi?id=190090

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling-expected.txt:

Source/WebCore:

The return value of an OnBeforeUnloadEventHandler should always be coerced into a DOMString:

In particular, this means that returning false in an OnBeforeUnloadEventHandler should NOT
cancel the event when the event is a CustomEvent (and not a BeforeUnloadEvent). This is
because the return value cannot be false at:

https://html.spec.whatwg.org/#the-event-handler-processing-algorithm (Step 5. Otherwise case).

No new tests, rebaselined existing test.

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

Update test that was returning a value in a beforeunload event listener instead of using an
event handler. The test needs to use an event handler (window.onbeforeunload) as an event
listener does not have a return value. I have verified that our behavior is consistent with
Chrome and Firefox on this test, both with an event listener and an event handler.

fast/loader/form-submission-after-beforeunload-cancel.html:

6:53 PM Changeset in webkit [236632] by Simon Fraser

8 edits in trunk

RenderLayer::removeOnlyThisLayer() should not call updateLayerPositions()
https://bugs.webkit.org/show_bug.cgi?id=190093

Reviewed by Dean Jackson and Zalan Bujtas.

Source/WebCore:

It's wrong for RenderLayer::removeOnlyThisLayer() to call updateLayerPositions(),
because this is called at style update time, and layout will be stale.

It was added (see webkit.org/b/25252) so that opacity changes, which can destroy layers, correctly update
descendants. However, RenderStyle::changeRequiresLayout() checks for opacity <=> no opacity
changes and triggers layout accordingly, which will result in a full post-layout
updateLayerPositions().

This also revealed that changes to the "isolate" property fail to trigger any kind of style recalc or layout;
we need it to trigger layout (for now) because it affects z-order.

Covered by existing tests.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::removeOnlyThisLayer):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout const):

LayoutTests:

The ordering of the repaints changes.

blend-mode-turn-off-isolation-no-effect.html now issues a repaint, which is expected now.
Isolation is so rare that this is not a problem.

css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt:
css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt:
fast/repaint/absolute-position-change-containing-block-expected.txt:

6:38 PM Changeset in webkit [236631] by Chris Dumez

10 edits in trunk

Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190052

Reviewed by Ryosuke Niwa.

Source/WebKit:

Introduce a new IPC::SendOption indicating that the IPC should always be sent asynchronously,
even if the connection is in fully synchronous mode. This is used by WebKitTestRunner for
all text outputting (e.g. console.log) is asynchronous, and thus in order.

Platform/IPC/Connection.cpp:

(IPC::Connection::sendMessage):

Platform/IPC/Connection.h:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePagePostMessageIgnoringFullySynchronousMode):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::postMessageIgnoringFullySynchronousMode):

WebProcess/WebPage/WebPage.h:

Tools:

The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
to log those events. It also uses console.log() before sending those events to indicate what the test is about
to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
so that it can log the message.
The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
handler to be transformed into synchronous IPC.
As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
messages may end up being out of order, leading to flakiness.

To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::outputText):

6:36 PM Changeset in webkit [236630] by wilander@apple.com

2 edits in trunk/Source/WebKit

Skip debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain()
https://bugs.webkit.org/show_bug.cgi?id=190097
<rdar://problem/44877080>

Reviewed by Chris Dumez.

The change in https://bugs.webkit.org/show_bug.cgi?id=190055 causes a
re-classification that may trigger a debug assertion in
ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain().
We should skip the assertion for statistics model version 14 to avoid
this.

UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain const):

6:00 PM Changeset in webkit [236629] by commit-queue@webkit.org

2 edits in trunk

cmake cannot run if python 2 isn't available
https://bugs.webkit.org/show_bug.cgi?id=190075

Patch by Mike Gorse <mgorse@alum.wpi.edu> on 2018-09-28
Reviewed by Michael Catanzaro.

Source/cmake/WebKitCommon.cmake: Set Python_ADDITIONAL_VERSIONS

to 3, so that a python3 binary will be found.

5:48 PM Changeset in webkit [236628] by mmaxfield@apple.com

14 edits
1 move
1 delete in trunk/Tools

[WHLSL] Pointers should have automatically-generated equality checks
https://bugs.webkit.org/show_bug.cgi?id=189986

Reviewed by Filip Pizlo.

C allows for pointer equality, and we need it so people can do null checks.
This is generated the same way all our other NativeFuncs are generated - by Checker
creating NativeFuncs inside CallExpression.resolve().

This patch also does some general cleanup.

WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.

The last thing it was doing was making sure that only primitive types are in resources, but
it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
still have to add a check to make sure resources can't live within resources, but I expect
that will be done in the same place that semantics are checked.

WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:

(allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
Name the global struct for debugging purposes.

WebGPUShadingLanguageRI/CallExpression.js:

(CallExpression.prototype._resolveByInstantiation): Cleanup
(CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
(CallExpression.prototype._resolveWithOperatorLength): Ditto
(CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
generate pointer equality NativeFuncs.

WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
WebGPUShadingLanguageRI/LateChecker.js: Removed.
WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.

(layoutBuffers):

WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
WebGPUShadingLanguageRI/NativeFunc.js:
WebGPUShadingLanguageRI/OperatorArrayRefLength.js:

(OperatorArrayRefLength.prototype.instantiateImplementation):
(OperatorArrayRefLength):

WebGPUShadingLanguageRI/Prepare.js:

(let.prepare):

WebGPUShadingLanguageRI/SPIRV.html:
WebGPUShadingLanguageRI/Test.html:
WebGPUShadingLanguageRI/Test.js:

(tests.ternaryExpression):
(tests.break): Speed up testing time
(tests.doWhile): Ditto
(tests.forLoop): Ditto
(tests.atomics): Ditto
(tests.atomicsNull): Ditto
(tests.pointerEquality): Test pointer equality
(tests.standardLibraryDevicePointers):
(tests.devicePtrPtr): Deleted.
(tests.threadgroupPtrPtr): Deleted.
(tests.constantPtrPtr): Deleted.

WebGPUShadingLanguageRI/index.html:

5:22 PM Changeset in webkit [236627] by Devin Rousso

6 edits
3 adds in trunk

Web Inspector: crash in InspectorNetworkAgent::didReceiveResponse when loading denied x-frame resources
https://bugs.webkit.org/show_bug.cgi?id=190046

Reviewed by Joseph Pecoraro.

Source/WebKit:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
Send the sanitized ResourceResponse with the message so WebInspector is able to access it.

WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.cpp:
WebProcess/Network/WebResourceLoader.messages.in:

(WebKit::WebResourceLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied):

LayoutTests:

http/tests/inspector/network/resources/x-frame-options.php: Added.
http/tests/inspector/network/x-frame-options-expected.txt: Added.
http/tests/inspector/network/x-frame-options.html: Added.

5:15 PM Changeset in webkit [236626] by realdawei@apple.com

2 edits
2 deletes in trunk/Source/ThirdParty/libwebrtc

Unreviewed, rolling out r236620.

broke internal Mac and iOS builds

Reverted changeset:

"Add yasm as third party tool for libwebrtc compilation"
https://bugs.webkit.org/show_bug.cgi?id=190025
https://trac.webkit.org/changeset/236620

5:02 PM Changeset in webkit [236625] by jiewen_tan@apple.com

31 edits
3 copies
5 adds
8 deletes in trunk

[WebAuthN] Polish WebAuthN auto-test environment
https://bugs.webkit.org/show_bug.cgi?id=189283
<rdar://problem/44117828>

Reviewed by Chris Dumez.

Source/WebCore:

This patch removes the old mocking mechanism.

Tests: http/wpt/webauthn/public-key-credential-create-with-invalid-parameters.https.html

http/wpt/webauthn/public-key-credential-get-with-invalid-parameters.https.html
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::mockAuthenticatorCoordinator const): Deleted.

testing/Internals.h:
testing/Internals.idl:
testing/MockAuthenticatorCoordinator.cpp: Removed.
testing/MockAuthenticatorCoordinator.h: Removed.
testing/MockAuthenticatorCoordinator.idl: Removed.

Source/WebKit:

This patch changes MockWebAuthenticationConfiguration.local to optional such that tests can express
absence of local authenticators.

UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):

UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getUserConsent const):
(WebKit::MockLocalConnection::getAttestation const):

UIProcess/WebAuthentication/Mock/MockLocalService.cpp:

(WebKit::MockLocalService::platformStartDiscovery const):

UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:

Tools:

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration):

LayoutTests:

This patch does the following few things:

Update tests that employ old mocking mechnism to the new one.
Move tests from http/tests/webauthn to http/wpt/webauthn. As a result, we have one unified place for

all WebAuthN tests: http/wpt/webauthn.

Add a helper function to check DOMException message as well.

TestExpectations:
http/tests/webauthn/public-key-credential-create-with-invalid-parameters.https-expected.txt: Removed.
http/tests/webauthn/public-key-credential-get-with-invalid-parameters.https-expected.txt: Removed.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors-2.https-expected.txt: Removed.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors-2.https.html: Removed.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt: Removed.
http/tests/webauthn/public-key-credential-same-origin-with-ancestors.https.html: Removed.
http/tests/webauthn/resources/last-layer-frame.https.html: Removed.
http/tests/webauthn/resources/util.js: Removed.
http/wpt/credential-management/credentialscontainer-store-basics.https.html:
http/wpt/webauthn/idl.https.html:
http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
http/wpt/webauthn/public-key-credential-create-failure.https.html:
http/wpt/webauthn/public-key-credential-create-success.https-expected.txt: Removed.
http/wpt/webauthn/public-key-credential-create-success.https.html: Removed.
http/wpt/webauthn/public-key-credential-create-with-invalid-parameters.https-expected.txt: Added.
http/wpt/webauthn/public-key-credential-create-with-invalid-parameters.https.html: Renamed from LayoutTests/http/tests/webauthn/public-key-credential-create-with-invalid-parameters.https.html.
http/wpt/webauthn/public-key-credential-get-failure-local.https.html:
http/wpt/webauthn/public-key-credential-get-failure.https-expected.txt:
http/wpt/webauthn/public-key-credential-get-failure.https.html:
http/wpt/webauthn/public-key-credential-get-success.https-expected.txt: Removed.
http/wpt/webauthn/public-key-credential-get-success.https.html: Removed.
http/wpt/webauthn/public-key-credential-get-with-invalid-parameters.https-expected.txt: Added.
http/wpt/webauthn/public-key-credential-get-with-invalid-parameters.https.html: Renamed from LayoutTests/http/tests/webauthn/public-key-credential-get-with-invalid-parameters.https.html.
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt: Added.
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html: Added.
http/wpt/webauthn/resources/last-layer-frame.https.html: Added.
http/wpt/webauthn/resources/second-layer-frame.https.html: Renamed from LayoutTests/http/tests/webauthn/resources/second-layer-frame.https.html.
http/wpt/webauthn/resources/util.js:
platform/gtk/TestExpectations:
platform/ios-wk1/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:
platform/wpe/TestExpectations:

4:31 PM Changeset in webkit [236624] by jer.noble@apple.com

39 edits
1 copy in trunk

Refactoring: eliminate raw pointer usage in Fullscreen code
https://bugs.webkit.org/show_bug.cgi?id=188747
<rdar://problem/43541164>

Reviewed by Alex Christensen.

Source/WebCore:

Two sources of raw pointers in the Fullscreen code:

Model classes (PlaybackSessionModel and VideoFullscreenModel) aren't ref-able, so they are passed around as raw references.
Observer classes (PlaybackSessionModelClient and VideoFullscreenModelClient, and VideoFullscreenChangeObserver) are also passed around as raw pointers, but shouldn't be ref-able.

Make Model classes ref-able by adding ref() and deref() which call virtual refModel and
derefModel methods, overridden by implementing subclasses. Make every concrete observer
inherit from CanMakeWeakPtr, and every registration method take WeakPtr wrappers around
the client interface.

Since every Interface class now holds a strong reference to its Model classes, and each
Model class holds a weak reference to all its clients, no explicit invalidate() method
is necessary.

Notes:

Since the weak pointer methods need to be able to downcast to the abstract base class, observers need to inherit publically (rather than privately) from those base classes.
Media element Models should compose EventListener rather than inheriting from it, since EventListener has its own RefCount.
WeakPtrs can't be held in HashSets (because they change value, and therefore hash, when their underlying object is destroyed), so clients should be stored in a Vector instead.
Interfaces should be given all required Refs at creation time, so that they can store those parameters as Refs instead of RefPtrs.

platform/cocoa/PlaybackSessionInterface.h:

(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface): Deleted.

platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModel::ref):
(WebCore::PlaybackSessionModel::deref):
(WebCore::PlaybackSessionModel::~PlaybackSessionModel): Deleted.

platform/cocoa/PlaybackSessionModelMediaElement.h:
platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::PlaybackSessionModelMediaElement):
(WebCore::PlaybackSessionModelMediaElement::~PlaybackSessionModelMediaElement):
(WebCore::PlaybackSessionModelMediaElement::setMediaElement):
(WebCore::PlaybackSessionModelMediaElement::updateForEventName):
(WebCore::PlaybackSessionModelMediaElement::addClient):
(WebCore::PlaybackSessionModelMediaElement::removeClient):
(WebCore::PlaybackSessionModelMediaElement::updateMediaSelectionOptions):
(WebCore::PlaybackSessionModelMediaElement::updateMediaSelectionIndices):
(WebCore::PlaybackSessionModelMediaElement::handleEvent): Deleted.

platform/cocoa/VideoFullscreenChangeObserver.h:

(WebCore::VideoFullscreenChangeObserver::~VideoFullscreenChangeObserver): Deleted.

platform/cocoa/VideoFullscreenModel.h:

(WebCore::VideoFullscreenModel::ref):
(WebCore::VideoFullscreenModel::deref):
(WebCore::VideoFullscreenModel::~VideoFullscreenModel): Deleted.

platform/cocoa/VideoFullscreenModelVideoElement.h:
platform/cocoa/VideoFullscreenModelVideoElement.mm:

(VideoFullscreenModelVideoElement::VideoFullscreenModelVideoElement):
(VideoFullscreenModelVideoElement::setVideoElement):
(VideoFullscreenModelVideoElement::addClient):
(VideoFullscreenModelVideoElement::removeClient):
(VideoFullscreenModelVideoElement::setHasVideo):
(VideoFullscreenModelVideoElement::setVideoDimensions):
(VideoFullscreenModelVideoElement::willEnterPictureInPicture):
(VideoFullscreenModelVideoElement::didEnterPictureInPicture):
(VideoFullscreenModelVideoElement::failedToEnterPictureInPicture):
(VideoFullscreenModelVideoElement::willExitPictureInPicture):
(VideoFullscreenModelVideoElement::didExitPictureInPicture):
(VideoFullscreenModelVideoElement::handleEvent): Deleted.

platform/ios/PlaybackSessionInterfaceAVKit.h:

(WebCore::PlaybackSessionInterfaceAVKit::create):
(WebCore::PlaybackSessionInterfaceAVKit::playbackSessionModel const):
(): Deleted.

platform/ios/PlaybackSessionInterfaceAVKit.mm:

(WebCore::PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::~PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::invalidate): Deleted.

platform/ios/VideoFullscreenInterfaceAVKit.h:
platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer resolveBounds]):
(-[WebAVPlayerLayer setVideoGravity:]):
(VideoFullscreenInterfaceAVKit::create):
(VideoFullscreenInterfaceAVKit::VideoFullscreenInterfaceAVKit):
(VideoFullscreenInterfaceAVKit::~VideoFullscreenInterfaceAVKit):
(VideoFullscreenInterfaceAVKit::setVideoFullscreenChangeObserver):
(VideoFullscreenInterfaceAVKit::applicationDidBecomeActive):
(VideoFullscreenInterfaceAVKit::setupFullscreen):
(VideoFullscreenInterfaceAVKit::presentingViewController):
(VideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
(VideoFullscreenInterfaceAVKit::preparedToExitFullscreen):
(VideoFullscreenInterfaceAVKit::willStartPictureInPicture):
(VideoFullscreenInterfaceAVKit::didStartPictureInPicture):
(VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture):
(VideoFullscreenInterfaceAVKit::willStopPictureInPicture):
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
(VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
(VideoFullscreenInterfaceAVKit::doSetup):
(VideoFullscreenInterfaceAVKit::setMode):
(VideoFullscreenInterfaceAVKit::clearMode):
(VideoFullscreenInterfaceAVKit::setVideoFullscreenModel): Deleted.
(VideoFullscreenInterfaceAVKit::invalidate): Deleted.

platform/ios/WebAVPlayerController.h:
platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController delegate]):
(-[WebAVPlayerController playbackSessionInterface]):
(-[WebAVPlayerController setPlaybackSessionInterface:]):

platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::didCleanupFullscreen):
(VideoFullscreenControllerContext::addClient):
(VideoFullscreenControllerContext::removeClient):
(VideoFullscreenControllerContext::willEnterPictureInPicture):
(VideoFullscreenControllerContext::didEnterPictureInPicture):
(VideoFullscreenControllerContext::failedToEnterPictureInPicture):
(VideoFullscreenControllerContext::willExitPictureInPicture):
(VideoFullscreenControllerContext::didExitPictureInPicture):
(VideoFullscreenControllerContext::setUpFullscreen):

platform/mac/PlaybackSessionInterfaceMac.h:
platform/mac/PlaybackSessionInterfaceMac.mm:

(WebCore::PlaybackSessionInterfaceMac::create):
(WebCore::PlaybackSessionInterfaceMac::PlaybackSessionInterfaceMac):
(WebCore::PlaybackSessionInterfaceMac::playbackSessionModel const):
(WebCore::PlaybackSessionInterfaceMac::rateChanged):
(WebCore::PlaybackSessionInterfaceMac::beginScrubbing):
(WebCore::PlaybackSessionInterfaceMac::endScrubbing):
(WebCore::PlaybackSessionInterfaceMac::setPlayBackControlsManager):
(WebCore::PlaybackSessionInterfaceMac::updatePlaybackControlsManagerTiming):
(WebCore::PlaybackSessionInterfaceMac::~PlaybackSessionInterfaceMac): Deleted.
(WebCore::PlaybackSessionInterfaceMac::invalidate): Deleted.

platform/mac/VideoFullscreenInterfaceMac.h:

(WebCore::VideoFullscreenInterfaceMac::create):
(WebCore::VideoFullscreenInterfaceMac::videoFullscreenModel const):
(WebCore::VideoFullscreenInterfaceMac::playbackSessionModel const):
(WebCore::VideoFullscreenInterfaceMac::videoFullscreenChangeObserver const):

platform/mac/VideoFullscreenInterfaceMac.mm:

(-[WebVideoFullscreenInterfaceMacObjC setUpPIPForVideoView:withFrame:inWindow:]):
(-[WebVideoFullscreenInterfaceMacObjC boundsDidChangeForVideoViewContainer:]):
(-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]):
(-[WebVideoFullscreenInterfaceMacObjC pipActionPlay:]):
(-[WebVideoFullscreenInterfaceMacObjC pipActionPause:]):
(-[WebVideoFullscreenInterfaceMacObjC pipActionStop:]):
(WebCore::VideoFullscreenInterfaceMac::VideoFullscreenInterfaceMac):
(WebCore::VideoFullscreenInterfaceMac::~VideoFullscreenInterfaceMac):
(WebCore::VideoFullscreenInterfaceMac::setVideoFullscreenChangeObserver):
(WebCore::VideoFullscreenInterfaceMac::setMode):
(WebCore::VideoFullscreenInterfaceMac::clearMode):
(WebCore::VideoFullscreenInterfaceMac::invalidate):
(WebCore::VideoFullscreenInterfaceMac::requestHideAndExitPiP):
(WebCore::VideoFullscreenInterfaceMac::setVideoFullscreenModel): Deleted.

platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager seekToTime:toleranceBefore:toleranceAfter:]):
(-[WebPlaybackControlsManager setCurrentAudioTouchBarMediaSelectionOption:]):
(-[WebPlaybackControlsManager setCurrentLegibleTouchBarMediaSelectionOption:]):
(-[WebPlaybackControlsManager togglePlayback]):
(-[WebPlaybackControlsManager setPlaying:]):
(-[WebPlaybackControlsManager isPlaying]):
(-[WebPlaybackControlsManager togglePictureInPicture]):

Source/WebKit:

Adopt those Ref and WeakPtr changes made in WebCore.

UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::addClient):
(WebKit::PlaybackSessionModelContext::removeClient):
(WebKit::PlaybackSessionModelContext::durationChanged):
(WebKit::PlaybackSessionModelContext::currentTimeChanged):
(WebKit::PlaybackSessionModelContext::bufferedTimeChanged):
(WebKit::PlaybackSessionModelContext::rateChanged):
(WebKit::PlaybackSessionModelContext::seekableRangesChanged):
(WebKit::PlaybackSessionModelContext::canPlayFastReverseChanged):
(WebKit::PlaybackSessionModelContext::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionModelContext::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionModelContext::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionModelContext::legibleMediaSelectionIndexChanged):
(WebKit::PlaybackSessionModelContext::externalPlaybackChanged):
(WebKit::PlaybackSessionModelContext::wirelessVideoPlaybackDisabledChanged):
(WebKit::PlaybackSessionModelContext::mutedChanged):
(WebKit::PlaybackSessionModelContext::volumeChanged):
(WebKit::PlaybackSessionModelContext::pictureInPictureActiveChanged):
(WebKit::PlaybackSessionManagerProxy::invalidate):
(WebKit::PlaybackSessionManagerProxy::createModelAndInterface):
(WebKit::PlaybackSessionManagerProxy::removeClientForContext):

UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenModelContext::create):
(WebKit::VideoFullscreenModelContext::VideoFullscreenModelContext):
(WebKit::VideoFullscreenModelContext::addClient):
(WebKit::VideoFullscreenModelContext::removeClient):
(WebKit::VideoFullscreenModelContext::willEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::didEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::failedToEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::willExitPictureInPicture):
(WebKit::VideoFullscreenModelContext::didExitPictureInPicture):
(WebKit::VideoFullscreenManagerProxy::invalidate):
(WebKit::VideoFullscreenManagerProxy::createModelAndInterface):
(WebKit::VideoFullscreenManagerProxy::removeClientForContext):
(WebKit::VideoFullscreenModelContext::~VideoFullscreenModelContext): Deleted.

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
(WKFullScreenViewControllerVideoFullscreenModelClient::setInterface):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController _togglePiPAction:]):

UIProcess/mac/WKFullScreenWindowController.mm:

(WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface):

WebProcess/cocoa/PlaybackSessionManager.h:
WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionInterfaceContext::PlaybackSessionInterfaceContext):
(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::createModelAndInterface):
(WebKit::PlaybackSessionManager::removeContext):
(WebKit::PlaybackSessionInterfaceContext::~PlaybackSessionInterfaceContext): Deleted.

WebProcess/cocoa/VideoFullscreenManager.h:

(WebKit::VideoFullscreenInterfaceContext::create):
(WebKit::VideoFullscreenInterfaceContext::createWeakPtr):

WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenInterfaceContext::VideoFullscreenInterfaceContext):
(WebKit::VideoFullscreenManager::~VideoFullscreenManager):
(WebKit::VideoFullscreenManager::createModelAndInterface):
(WebKit::VideoFullscreenManager::removeContext):

Source/WebKitLegacy/mac:

PlaybackSessionInterface no longer has an invalidate() method.

WebView/WebView.mm:

(-[WebView _clearPlaybackControlsManager]):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/WeakPtrContainer.h: Added.

LayoutTests:

Test was causing false pass results due to the webkitPresentationMode being correctly set
to "inline" during the close() operation; modify the test to only perform the close()
operation when the presetation mode is changed to "picture-in-picture".

media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html:
media/controls/ipad/resources/picture-in-picture.html:

4:18 PM Changeset in webkit [236623] by Chris Dumez

35 edits
1 delete in trunk

Drop support for cross-origin-window-policy header
https://bugs.webkit.org/show_bug.cgi?id=190081

Reviewed by Ryosuke Niwa.

Source/WebCore:

Drop support for cross-origin-window-policy header as this was never enabled and its design has
some issues we have not resolved. An alternative is being worked on but will be substantially
different so there is not much value in keeping this code around.

bindings/js/JSDOMBindingSecurity.cpp:
bindings/js/JSDOMBindingSecurity.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::addCrossOriginWindowPropertyNames):
(WebCore::addScopedChildrenIndexes):
(WebCore::addCrossOriginWindowOwnPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):

bindings/js/JSDOMWindowCustom.h:
bindings/js/JSRemoteDOMWindowCustom.cpp:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateOperationBodyDefinition):

bindings/scripts/IDLAttributes.json:
dom/Document.cpp:

(WebCore::Document::canNavigate):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

page/AbstractDOMWindow.cpp:

(WebCore::AbstractDOMWindow::AbstractDOMWindow):

page/AbstractDOMWindow.h:
page/DOMWindow.idl:
page/Settings.yaml:
platform/network/HTTPParsers.cpp:
platform/network/HTTPParsers.h:

Source/WebKit:

Shared/WebPreferences.yaml:
UIProcess/API/C/WKPreferences.cpp:
UIProcess/API/C/WKPreferencesRef.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::frameBecameRemote):

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::crossOriginWindowPolicySupportEnabled):
(WebPreferences::setCrossOriginWindowPolicySupportEnabled):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

190081_DropCrossOriginWindowPolicy

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

http/wpt/cross-origin-window-policy/allow-postmessage-expected.txt: Removed.
http/wpt/cross-origin-window-policy/allow-postmessage-from-deny-expected.txt: Removed.
http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html: Removed.
http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html.headers: Removed.
http/wpt/cross-origin-window-policy/allow-postmessage.html: Removed.
http/wpt/cross-origin-window-policy/cross-origin-window-policy-header-expected.txt: Removed.
http/wpt/cross-origin-window-policy/cross-origin-window-policy-header.html: Removed.
http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target-expected.txt: Removed.
http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target.html: Removed.
http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target-expected.txt: Removed.
http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target.html: Removed.
http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html: Removed.
http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html.headers: Removed.
http/wpt/cross-origin-window-policy/resources/destination.html: Removed.
http/wpt/cross-origin-window-policy/resources/navigate-parent-via-anchor.html: Removed.
http/wpt/cross-origin-window-policy/resources/navigation-from-subframe-frame.py: Removed.
http/wpt/cross-origin-window-policy/resources/serve-cross-origin-window-policy-header.py: Removed.
http/wpt/cross-origin-window-policy/resources/utils.js: Removed.

4:13 PM Changeset in webkit [236622] by aestes@apple.com

2 edits in trunk/Source/WebInspectorUI

REGRESSION (r236091): CSSKeywordCompletions.js has "checkout" instead of "check-out" as a value for -apple-pay-button-type
https://bugs.webkit.org/show_bug.cgi?id=190096

Reviewed by Ryosuke Niwa.

I changed "checkout" to "check-out" in r235754, but it somehow got flipped back to "checkout" in r236091.

UserInterface/Models/CSSKeywordCompletions.js:

4:09 PM Changeset in webkit [236621] by Chris Dumez

4 edits in trunk/Source/WebKit

Do not do automatic process prewarming while under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=190082
<rdar://problem/39771424>

Reviewed by Geoffrey Garen.

Do not do automatic process prewarming while under memory pressure and
also terminate any prewarmed process when receiving a memory warning.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::prewarmProcess):
(WebKit::WebProcessPool::didReachGoodTimeToPrewarm):
(WebKit::WebProcessPool::handleMemoryPressureWarning):

UIProcess/WebProcessPool.h:
UIProcess/ios/WebMemoryPressureHandlerIOS.mm:

(WebKit::installMemoryPressureHandler):

4:05 PM Changeset in webkit [236620] by youenn@apple.com

2 edits
1252 adds in trunk/Source/ThirdParty/libwebrtc

Add yasm as third party tool for libwebrtc compilation
https://bugs.webkit.org/show_bug.cgi?id=190025

Reviewed by Eric Carlson.

Add yasm source code and build the yasm executable as it is needed for libvpx compilation.

Source/third_party/yasm-1.3.0: Added.
libwebrtc.xcodeproj/project.pbxproj:

4:02 PM Changeset in webkit [236619] by dbates@webkit.org

9 edits in trunk/Source

[iOS] Allow programmatic focus when hardware keyboard is attached
https://bugs.webkit.org/show_bug.cgi?id=190017
<rdar://problem/42270463>

Reviewed by Wenson Hsieh.

Source/WebCore:

Add support for checking if the embedding client is WebKitTestRunner and export isDumpRenderTree()
so that we can make use of it from WebKit. We will make use of these functions to keep the current
behavior of disallowing programmatic focus when running tests in these apps. This is needed to
keep testing deterministic. Otherwise, test results would be dependent on whether a hardware
keyboard is attached. When running tests in Simulator.app the hardware keyboard may also not be
connected (i.e. Hardware > Keyboard > Connect Hardware Keyboard is disabled).

platform/RuntimeApplicationChecks.h:
platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isWebKitTestRunner): Added.

Source/WebKit:

Make the experience of using iOS with a hardware keyboard more desktop-like by allowing
programmatic focusing of editable elements.

Platform/spi/ios/UIKitSPI.h: Forward declare SPI.
Shared/NativeWebKeyboardEvent.h:
Shared/ios/NativeWebKeyboardEventIOS.mm:

(WebKit::isInHardwareKeyboardMode): Returns whether we are in hardware keyboard mode. In DumpRenderTree
and WebKitTestRunner this function always returns false to keep test results deterministic.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
Allow starting an input session if we are in hardware keyboard mode.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const): Send the full editor state if we are in hardware
keyboard mode regardless of whether layout has been performed so that UIProcess can update UI,
including the position of the caret, immediately.

3:32 PM Changeset in webkit [236618] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r236609): API tests for mso list preservation are failing
https://bugs.webkit.org/show_bug.cgi?id=190095

Reviewed by Wenson Hsieh.

The regression was caused by appendNodeToPreserveMSOList called after an early return for not having renderer.
Clearly, comment & style elements coming from a MS word document wouldn't have a renderer.

Fixed the bug by changing the order.

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

3:32 PM Changeset in webkit [236617] by yusukesuzuki@slowstart.org

10 edits
1 move in trunk

[WTF] Make isMainThread more reliable
https://bugs.webkit.org/show_bug.cgi?id=189880

Reviewed by Mark Lam.

Source/cmake/OptionsCommon.cmake:

Source/WTF:

isMainThread() relied on Thread::current(). This API becomes broken in Windows
when the Thread is about to be destroyed since TLS is already cleared. This causes
a bug since isMainThread() is called in Thread::didExit in Windows.

This patch makes this isMainThread more reliable in all the platforms. In Windows,
we use Thread::currentID() instead of Thread::current() since Thread::currentID
uses Win32 GetCurrentThreadId directly. In the other system, we use pthread_main_np
or pthread_self instead.

We also move holdLock code inside if (shouldRemoveThreadFromThreadGroup()). If
the other thread takes a mutex and destroyed, this holdLock waits forever. This problem
only happens in Windows since Windows calls TLS destructor for the main thread.

WTF.xcodeproj/project.pbxproj:
wtf/MainThread.cpp:

(WTF::initializeMainThread):
(): Deleted.
(WTF::isMainThread): Deleted.
(WTF::isMainThreadIfInitialized): Deleted.

wtf/Platform.h:
wtf/PlatformMac.cmake:
wtf/Threading.cpp:

(WTF::Thread::didExit):

wtf/cocoa/MainThreadCocoa.mm: Renamed from Source/WTF/wtf/mac/MainThreadMac.mm.
wtf/generic/MainThreadGeneric.cpp:

(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):
(WTF::isMainThreadIfInitialized):

wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):
(WTF::isMainThreadIfInitialized):

3:12 PM Changeset in webkit [236616] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Build fix after r236612.

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection):

3:08 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

3:06 PM Changeset in webkit [236615] by aestes@apple.com

14 edits in trunk

[Apple Pay] Remove the "in-store" button type
https://bugs.webkit.org/show_bug.cgi?id=190079

Reviewed by Tim Horton.

Source/WebCore:

According to <https://developer.apple.com/design/human-interface-guidelines/apple-pay/buttons-and-marks/buttons/>,
this button is meant only for certain kinds of native apps. It shouldn't be available on the web.

Updated http/tests/ssl/applepay/ApplePayButton.html.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):

css/CSSValueKeywords.in:
css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

rendering/RenderThemeCocoa.mm:

(WebCore::toPKPaymentButtonType):

rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

http/tests/ssl/applepay/ApplePayButton.html:
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.png:
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.txt:

3:01 PM Changeset in webkit [236614] by realdawei@apple.com

2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance
https://bugs.webkit.org/show_bug.cgi?id=189641

Unreviewed, skip tests that are timing out.

Patch by Dawei Fenton <realdawei@apple.com> on 2018-09-28

TestExpectations:

2:56 PM Changeset in webkit [236613] by Chris Dumez

9 edits in trunk

document.open() should throw errors for cross-origin calls
https://bugs.webkit.org/show_bug.cgi?id=189371
<rdar://problem/44282700>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline existing WPT tests now that more checks are passing.

web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window-expected.txt:
web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-side-effects-same-origin-domain.sub.window-expected.txt:

Source/WebCore:

document.open() / document.write() should throw errors for cross-origin calls as per:

https://html.spec.whatwg.org/#document-open-steps (Step 4)

No new tests, rebaselined existing tests.

dom/Document.cpp:

(WebCore::Document::open):
(WebCore::Document::write):
(WebCore::Document::writeln):

dom/Document.h:

LayoutTests:

Tweak a couple of existing tests to reflect behavior change.

fast/dom/HTMLDocument/document-open-return-value.html:
fast/parser/tokenizer-close-during-document-write.html:

2:08 PM Changeset in webkit [236612] by rniwa@webkit.org

15 edits in trunk/Source

Rename createMarkup to serializePreservingVisualAppearance
https://bugs.webkit.org/show_bug.cgi?id=190086

Reviewed by Wenson Hsieh.

Source/WebCore:

Renamed the function to clarify what it does. Also removed the unused Range::toHTML.

dom/Range.cpp:

(WebCore::Range::toHTML const): Deleted.

dom/Range.h:
editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs):

editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::selectionInHTMLFormat):

editing/gtk/EditorGtk.cpp:

(WebCore::Editor::writeSelectionToPasteboard):

editing/markup.cpp:

(WebCore::serializePreservingVisualAppearance):
(WebCore::createMarkup): Deleted.

editing/markup.h:
editing/wpe/EditorWPE.cpp:

(WebCore::Editor::writeSelectionToPasteboard):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject):

Source/WebKit:

WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection):

Source/WebKitLegacy/mac:

DOM/WebDOMOperations.mm:

(-[DOMRange markupString]):

2:03 PM Changeset in webkit [236611] by Simon Fraser

3 edits in trunk/Source/WebCore

Remove some unused RenderLayer code
https://bugs.webkit.org/show_bug.cgi?id=190078

Reviewed by Zalan Bujtas.

The 'outOfFlowDescendantContainingBlocks' code was related to the accelerated overflow scrolling code that
I removed recently.

updateDescendantsLayerListsIfNeeded() is never called.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderLayer.h:

1:38 PM Changeset in webkit [236610] by commit-queue@webkit.org

39 edits
1 delete in trunk

Unreviewed, rolling out r236605.
https://bugs.webkit.org/show_bug.cgi?id=190087

caused three API test timeouts (Requested by jernoble on
#webkit).

Reverted changeset:

"Refactoring: eliminate raw pointer usage in Fullscreen code"
https://bugs.webkit.org/show_bug.cgi?id=188747
https://trac.webkit.org/changeset/236605

1:03 PM Changeset in webkit [236609] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Simplify StyledMarkupAccumulator::traverseNodesForSerialization
https://bugs.webkit.org/show_bug.cgi?id=190073

Reviewed by Antti Koivisto.

Simplified the range traversal algorithm in traverseNodesForSerialization as it was too complicated
to support shadow DOM for copy and paste.

Instead of using NodeTraversal::next to traverse past ancestors and then figuring out which ancestor
must be closed or to wrap the existing markup with, new code collects the list of ancestors as we
traverse out of them.

Also extracted lambdas for generating markup and deciding whether to skip a node as well as keeping
track of the depth of the current markup. This further reduces the code complexity of the actual
node traversal algorithm. Keeping track of the depth allows us to now generate ancestor elements'
closing tags without keeping a stack of ancestor nodes we opened at all times.

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

1:02 PM Changeset in webkit [236608] by BJ Burg

2 edits in trunk/Source/WTF

Replace recently added line comments in Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=190062
<rdar://problem/44838618>

Reviewed by Joseph Pecoraro.

This breaks some Apple-internal tooling. For now, work around it by
changing the comment style. On the other side, the issue will be fixed
more permanently by adopting the approach from r230213.

wtf/Compiler.h: Use multiline comments.

12:47 PM Changeset in webkit [236607] by rniwa@webkit.org

13 edits in trunk/Source/WebCore

Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode()
https://bugs.webkit.org/show_bug.cgi?id=190069

Reviewed by Zalan Bujtas.

Removed Node::offsetInCharacters() and replaced every use of it by isCharacterDataNode()
because their implementations are identical.

Note that offsetInCharacters() sounds like a function which returns some kind of an offset
but it doesn't. It returns true when called on a CharacterData and false elsewhere.

accessibility/AXObjectCache.cpp:

(WebCore::characterOffsetsInOrder):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):

dom/CharacterData.cpp:

(WebCore::CharacterData::offsetInCharacters const): Deleted.

dom/CharacterData.h:
dom/Node.cpp:

(WebCore::Node::offsetInCharacters const): Deleted.

dom/Node.h:
dom/Position.cpp:

(WebCore::Position::parentAnchoredEquivalent const):

dom/Position.h:

(WebCore::lastOffsetInNode):
(WebCore::minOffsetForNode):
(WebCore::offsetIsBeforeLastNodeOffset):

dom/Range.cpp:

(WebCore::Range::firstNode const):
(WebCore::Range::pastLastNode const):

dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::setOffset):
(WebCore::RangeBoundaryPoint::setToEndOfNode):

editing/Editing.cpp:

(WebCore::lastOffsetForEditing):

editing/TextIterator.cpp:

(WebCore::nextInPreOrderCrossingShadowBoundaries):
(WebCore::TextIterator::node const):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):

page/DOMSelection.cpp:

(WebCore::DOMSelection::extend):

11:46 AM Changeset in webkit [236606] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Gardening: speculative build fix.
<rdar://problem/44869924>

Not reviewed.

assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

11:39 AM Changeset in webkit [236605] by jer.noble@apple.com

39 edits
1 copy in trunk

Refactoring: eliminate raw pointer usage in Fullscreen code
https://bugs.webkit.org/show_bug.cgi?id=188747
<rdar://problem/43541164>

Reviewed by Alex Christensen.

Source/WebCore:

Two sources of raw pointers in the Fullscreen code:

Model classes (PlaybackSessionModel and VideoFullscreenModel) aren't ref-able, so they are passed around as raw references.
Observer classes (PlaybackSessionModelClient and VideoFullscreenModelClient, and VideoFullscreenChangeObserver) are also passed around as raw pointers, but shouldn't be ref-able.

Since every Interface class now holds a strong reference to its Model classes, and each
Model class holds a weak reference to all its clients, no explicit invalidate() method
is necessary.

Notes:

Since the weak pointer methods need to be able to downcast to the abstract base class, observers need to inherit publically (rather than privately) from those base classes.
Media element Models should compose EventListener rather than inheriting from it, since EventListener has its own RefCount.
WeakPtrs can't be held in HashSets (because they change value, and therefore hash, when their underlying object is destroyed), so clients should be stored in a Vector instead.
Interfaces should be given all required Refs at creation time, so that they can store those parameters as Refs instead of RefPtrs.

platform/cocoa/PlaybackSessionInterface.h:

(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface): Deleted.

platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModel::ref):
(WebCore::PlaybackSessionModel::deref):
(WebCore::PlaybackSessionModel::~PlaybackSessionModel): Deleted.

platform/cocoa/PlaybackSessionModelMediaElement.h:
platform/cocoa/PlaybackSessionModelMediaElement.mm:

platform/cocoa/VideoFullscreenChangeObserver.h:

(WebCore::VideoFullscreenChangeObserver::~VideoFullscreenChangeObserver): Deleted.

platform/cocoa/VideoFullscreenModel.h:

(WebCore::VideoFullscreenModel::ref):
(WebCore::VideoFullscreenModel::deref):
(WebCore::VideoFullscreenModel::~VideoFullscreenModel): Deleted.

platform/cocoa/VideoFullscreenModelVideoElement.h:
platform/cocoa/VideoFullscreenModelVideoElement.mm:

platform/ios/PlaybackSessionInterfaceAVKit.h:

(WebCore::PlaybackSessionInterfaceAVKit::create):
(WebCore::PlaybackSessionInterfaceAVKit::playbackSessionModel const):
(): Deleted.

platform/ios/PlaybackSessionInterfaceAVKit.mm:

platform/ios/VideoFullscreenInterfaceAVKit.h:
platform/ios/VideoFullscreenInterfaceAVKit.mm:

platform/ios/WebAVPlayerController.h:
platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController delegate]):
(-[WebAVPlayerController playbackSessionInterface]):
(-[WebAVPlayerController setPlaybackSessionInterface:]):

platform/ios/WebVideoFullscreenControllerAVKit.mm:

platform/mac/PlaybackSessionInterfaceMac.h:
platform/mac/PlaybackSessionInterfaceMac.mm:

platform/mac/VideoFullscreenInterfaceMac.h:

platform/mac/VideoFullscreenInterfaceMac.mm:

platform/mac/WebPlaybackControlsManager.mm:

Source/WebKit:

Adopt those Ref and WeakPtr changes made in WebCore.

UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

UIProcess/mac/WKFullScreenWindowController.mm:

(WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface):

WebProcess/cocoa/PlaybackSessionManager.h:
WebProcess/cocoa/PlaybackSessionManager.mm:

WebProcess/cocoa/VideoFullscreenManager.h:

(WebKit::VideoFullscreenInterfaceContext::create):
(WebKit::VideoFullscreenInterfaceContext::createWeakPtr):

WebProcess/cocoa/VideoFullscreenManager.mm:

Source/WebKitLegacy/mac:

PlaybackSessionInterface no longer has an invalidate() method.

WebView/WebView.mm:

(-[WebView _clearPlaybackControlsManager]):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/WeakPtrContainer.h: Added.

LayoutTests:

media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html:
media/controls/ipad/resources/picture-in-picture.html:

11:18 AM Changeset in webkit [236604] by guijemont@igalia.com

3 edits in trunk/Source/JavaScriptCore

[JSC] [Armv7] Add a copy function argument to MacroAssemblerARMv7::link() and pass it down to the assembler's linking functions.
https://bugs.webkit.org/show_bug.cgi?id=190080

Reviewed by Mark Lam.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::linkJumpT1):
(JSC::ARMv7Assembler::linkJumpT2):
(JSC::ARMv7Assembler::linkJumpT3):
(JSC::ARMv7Assembler::linkJumpT4):
(JSC::ARMv7Assembler::linkConditionalJumpT4):
(JSC::ARMv7Assembler::linkBX):
(JSC::ARMv7Assembler::linkConditionalBX):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::link):

10:35 AM Changeset in webkit [236603] by bshafiei@apple.com

2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r236571. rdar://problem/44852809

[iOS] Allow access to VoiceServices features needed for accessibility
https://bugs.webkit.org/show_bug.cgi?id=190019
<rdar://problem/43621111>

Reviewed by Chris Fleizach.

Revise the sandbox to allow access to relevant WebSpeech features.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:24 AM Changeset in webkit [236602] by bshafiei@apple.com

7 edits in tags/Safari-607.1.8.1/Source

Versioning.

10:21 AM Changeset in webkit [236601] by bshafiei@apple.com

1 copy in tags/Safari-607.1.8.1

Tag Safari-607.1.8.1.

10:04 AM Changeset in webkit [236600] by Chris Dumez

4 edits in trunk/Source/WebCore

Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
https://bugs.webkit.org/show_bug.cgi?id=190077
<rdar://problem/44812613>

Reviewed by Zalan Bujtas.

Drop iOS specific quirk in SettingsBase::scriptEnabledChanged() that would dirty style after the
"JavaScriptEnabled" setting's state is toggled. I do not see a good reason to do this given that
scripts would not get executed until a reload.

If we find out after dropping this that this is actually useful for some reason, then we can
always bring it back and consider making this non-iOS specific, as well as documenting why this
it is needed.

page/Settings.yaml:
page/SettingsBase.cpp:

(WebCore::SettingsBase::scriptEnabledChanged): Deleted.

page/SettingsBase.h:

8:56 AM Changeset in webkit [236599] by commit-queue@webkit.org

7 edits
2 adds in trunk

[WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
https://bugs.webkit.org/show_bug.cgi?id=189991

Patch by Koby Boyango <koby.b@mce.systems> on 2018-09-28
Reviewed by Yusuke Suzuki.

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/text/ExternalStringImpl.cpp: Added.
wtf/text/ExternalStringImpl.h: Added.
wtf/text/StringImpl.cpp:
wtf/text/StringImpl.h:

Tools:

TestWebKitAPI/Tests/WTF/StringImpl.cpp:

8:43 AM Changeset in webkit [236598] by Chris Dumez

2 edits
1 add in trunk/LayoutTests

REGRESSION (r236573): [iOS] Layout test editing/pasteboard/emacs-ctrl-a-k-y.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190067

Unreviewed, re-land ios-specific expected result for this test as they were inadvertently
dropped in r236573.

platform/ios-wk2/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt: Added.
platform/ios/TestExpectations:

8:31 AM Changeset in webkit [236597] by Ross Kirsling

2 edits in trunk/JSTests

JSC test stress/jsc-read.js doesn't support CRLF
https://bugs.webkit.org/show_bug.cgi?id=190063

Reviewed by Yusuke Suzuki.

In order to run this test via Windows command prompt, we can't assume that the final newline will be LF.

stress/jsc-read.js:

(test):

1:04 AM Changeset in webkit [236596] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: image resources without content are still shown when the Images folder is selected
https://bugs.webkit.org/show_bug.cgi?id=190072

Reviewed by Matt Baker.

UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.showGenericNoContentMessage):
Treat paths that result in a "Resource has no content" message as a "content error".

12:06 AM Changeset in webkit [236595] by Fujii Hironori

2 edits in trunk/Source/WebKit

[WinCairo] error C2027: use of undefined type 'WTF::EnumTraits<E>' while compiling AuthenticationChallengeProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=190071

Unreviewed build fix for WinCairo port.

AuthenticationChallengeDisposition was not defined in this file.

UIProcess/Authentication/AuthenticationChallengeProxy.cpp: Include "AuthenticationChallengeDisposition.h".

12:01 AM Changeset in webkit [236594] by mark.lam@apple.com

3 edits in branches/safari-606-branch

Cherry-pick r236554. rdar://problem/44855120

2018-09-27 Mark Lam <mark.lam@apple.com>

JITMathIC should not use integer offsets into machine code.
https://bugs.webkit.org/show_bug.cgi?id=190030
<rdar://problem/44803307>

Reviewed by Saam Barati.

We'll replace them with CodeLocation smart pointers instead.

jit/JITMathIC.h: (JSC::isProfileEmpty):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed