Timeline

Oct 1, 2018:

11:59 PM Changeset in webkit [236714] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix a typo for execution context identifier
​https://bugs.webkit.org/show_bug.cgi?id=190185

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-01
Reviewed by Matt Baker.

• UserInterface/Protocol/MainTarget.js:

(WI.MainTarget):

• UserInterface/Protocol/WorkerTarget.js:

(WI.WorkerTarget):

11:53 PM Changeset in webkit [236713] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Function.toString() should also copy the source code Functions that are class definitions.
​https://bugs.webkit.org/show_bug.cgi?id=190186
<rdar://problem/44733360>

Reviewed by Saam Barati.

JSTests:

• stress/regress-190186.js: Added.

Source/JavaScriptCore:

Previously, if the Function is a class definition, functionProtoFuncToString()
would create a String using StringView::toStringWithoutCopying(), and use that
String to make a JSString. This is not a problem if the underlying SourceProvider
(that backs the characters in that StringView) is immortal. However, this is
not always the case in practice.

This patch fixes this issue by changing functionProtoFuncToString() to create the
String using StringView::toString() instead, which makes a copy of the underlying
characters buffer. This detaches the resultant JSString from the SourceProvider
characters buffer that it was created from, and ensure that the underlying
characters buffer of the string will be alive for the entire lifetime of the
JSString.

• runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

10:24 PM Changeset in webkit [236712] by Ross Kirsling

• 2 edits in trunk/Tools

[Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
​https://bugs.webkit.org/show_bug.cgi?id=190150

Reviewed by Fujii Hironori.

• DumpRenderTree/win/DumpRenderTree.cpp:

(setWebPreferencesForTestOptions):
DRT has been recognizing this field, but not propagating its value to WebPreferences.

9:58 PM Changeset in webkit [236711] by Ross Kirsling

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening.

• platform/wincairo/TestExpectations:

9:03 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

8:29 PM Changeset in webkit [236710] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Removed a failing test expectation on imported/w3c/web-platform-tests/shadow-dom/slotchange.html
since we haven't seen a single failure after the fix in r236440.

• platform/mac/TestExpectations:

7:27 PM Changeset in webkit [236709] by Devin Rousso

• 6 edits
  3 deletes in trunk/Source

Web Inspector: remove analyzer manager
​https://bugs.webkit.org/show_bug.cgi?id=190162

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

• UserInterface/Main.html:
• UserInterface/Base/Main.js:

(WI.loaded):

• UserInterface/Controllers/AnalyzerManager.js: Removed.
• UserInterface/Models/AnalyzerMessage.js: Removed.

• Scripts/copy-user-interface-resources.pl:
• UserInterface/External/ESLint/LICENSE: Removed.
• UserInterface/External/ESLint/eslint.js: Removed.

Source/WebKit:

• InspectorGResources.cmake:

Remove eslint.

7:15 PM Changeset in webkit [236708] by mmaxfield@apple.com

• 5 edits
  3 copies
  1 add in trunk/LayoutTests

[Cocoa] Update delete-emoji expected results
​https://bugs.webkit.org/show_bug.cgi?id=190182

Unreviewed.

Simply update the expected results.

• platform/mac-highsierra/editing/deleting/delete-emoji-1-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-1-expected.txt.
• platform/mac-highsierra/editing/deleting/delete-emoji-9-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-9-expected.txt.
• platform/mac-highsierra/editing/deleting/delete-emoji-expected.txt: Copied from LayoutTests/platform/mac/editing/deleting/delete-emoji-expected.txt.
• platform/mac/TestExpectations:
• platform/mac/editing/deleting/delete-emoji-1-expected.txt:
• platform/mac/editing/deleting/delete-emoji-9-expected.txt:
• platform/mac/editing/deleting/delete-emoji-expected.txt:

6:59 PM Changeset in webkit [236707] by rniwa@webkit.org

• 13 edits in trunk

Add a new variant of serializePreservingVisualAppearance which takes VisibleSelection
​https://bugs.webkit.org/show_bug.cgi?id=190108

Reviewed by Wenson Hsieh.

Source/WebCore:

Added a version of serializePreservingVisualAppearance which takes VisibleSelection so that we can avoid creating
a range simply to get the first node and the end node of the selection later. This simple change also fixes a bug
demonstrated in editing/pasteboard/paste-table-003.html.

Test: editing/pasteboard/paste-table-003.html

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::selectionInHTMLFormat): Adopt the new variant.

• editing/gtk/EditorGtk.cpp:

(WebCore::Editor::writeSelectionToPasteboard): Ditto.

• editing/markup.cpp:

(WebCore::serializePreservingVisualAppearance): Added.

• editing/markup.h:
• editing/wpe/EditorWPE.cpp:

(WebCore::Editor::writeSelectionToPasteboard): Ditto.

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection): Ditto.

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection): Ditto.

Source/WebKit:

Adopt the new variant which directly takes VisibleSelection.

• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection):

LayoutTests:

Rebaselined the test since the bug that interchange new lines are inserted in the last table cell is fixed.
Also updated the description in the test to reflect this change.

• editing/pasteboard/paste-table-003-expected.txt:
• editing/pasteboard/paste-table-003.html:

6:37 PM Changeset in webkit [236706] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: add an experimental setting for multi-property selection
​https://bugs.webkit.org/show_bug.cgi?id=190053
<rdar://problem/44842787>

Reviewed by Matt Baker.

This patch only adds a setting. It doesn't change property selection behavior.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

6:36 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

6:32 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

6:31 PM Changeset in webkit [236705] by Nikita Vasilyev

• 23 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: use the same CSS variables for dark and light modes
​https://bugs.webkit.org/show_bug.cgi?id=189766
<rdar://problem/44619650>

Use --text-color and --background-color CSS variables for both dark and light modes.

Reviewed by Matt Baker.

• UserInterface/Views/BreakpointPopoverController.css:

(.popover .edit-breakpoint-popover-content > label.toggle):
Color of the label matches the color of the popover, no need to specify it.

(.edit-breakpoint-popover-condition):
(@media (prefers-dark-interface)):
(.popover .edit-breakpoint-popover-content > table > tr > th):

• UserInterface/Views/CompletionSuggestionsView.css:

(.completion-suggestions-container > .item):
(@media (prefers-dark-interface)):
(.completion-suggestions):

• UserInterface/Views/ComputedStyleDetailsPanel.css:

(.details-section:matches(.computed-style-properties, .computed-style-box-model):not(.collapsed) > :matches(.header, .content)):
(.computed-style-properties .property:hover .go-to-arrow):
(@media (prefers-dark-interface)): Deleted.
(.computed-style-properties.details-section): Deleted.
(.details-section.style-box-model:not(.collapsed) > :matches(.header, .content)): Deleted.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom):
(@media (prefers-dark-interface)):

• UserInterface/Views/DataGrid.css:

(.data-grid th):
(body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):
(@media (prefers-dark-interface)):

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(@media (prefers-dark-interface)):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .new-rule):

• UserInterface/Views/InlineSwatch.css:

(.inline-swatch):
(.inline-swatch-variable-popover .CodeMirror pre):
(@media (prefers-dark-interface)): Deleted.

• UserInterface/Views/NetworkResourceDetailView.css:

(.network-resource-detail):
(.network .network-resource-detail .navigation-bar .item.radio.button.text-only.selected):
(@media (prefers-dark-interface)):
(.resource-headers .value): Deleted.
Move this rule to ResourceHeadersContentView.css.

• UserInterface/Views/ObjectPreviewView.css:

(.object-preview):
(@media (prefers-dark-interface)):
(.object-preview .name):

• UserInterface/Views/ObjectTreeView.css:

(.object-tree):
(.object-tree-property :matches(.formatted-string, .formatted-regexp)):
(@media (prefers-dark-interface)): Deleted.
(.object-tree,): Deleted.

(.object-preview .name): Deleted.
(.object-preview > .size): Deleted.
Move these rules to ObjectPreviewView.css.

• UserInterface/Views/QuickConsole.css:

(.quick-console):
(@media (prefers-dark-interface)):

• UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers .value):
(.resource-headers.showing-find-banner .search-highlight):
(@media (prefers-dark-interface)): Deleted.

• UserInterface/Views/ResourceTimingBreakdownView.css:

(.resource-timing-breakdown > table > tr.header:not(.total-row) > td):
(@media (prefers-dark-interface)):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property:not(.disabled) .value):
(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) .content > *):
(@media (prefers-dark-interface)):
(.spreadsheet-style-declaration-editor .property.has-warning .warning):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .media-label):
(.spreadsheet-css-declaration .selector:focus,):
(@media (prefers-dark-interface)):
(.spreadsheet-css-declaration .origin .go-to-link,):

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content > .rules .section-header .node-link:hover):
(@media (prefers-dark-interface)):
(.sidebar > .panel.details.css-style > .content > .rules .section-header):

• UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.cm-s-default,):
(@media (prefers-dark-interface)):
(.syntax-highlighted,): Deleted.

• UserInterface/Views/Table.css:

(.table):
(.table > .header):

• UserInterface/Views/TimelineOverview.css:

(.timeline-overview > .navigation-bar.timelines):
(@media (prefers-dark-interface)):

• UserInterface/Views/TimelineRecordingContentView.css:

(.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple):
(.content-view.timeline-recording > .content-browser > .navigation-bar > .item.scope-bar.default-item-selected > .multiple .arrows):
(.content-view.timeline-recording > .content-browser .recording-progress > .status > .indeterminate-progress-spinner):
(@media (prefers-dark-interface)): Deleted.

• UserInterface/Views/Variables.css:

(:root):
(@media (prefers-dark-interface)):

• UserInterface/Views/XHRBreakpointPopover.css:

(.popover .xhr-breakpoint-content > .editor-wrapper > .editor):
(@media (prefers-dark-interface)):

6:12 PM Changeset in webkit [236704] by Kocsen Chung

• 1 copy in tags/Safari-606.2.104

Tag Safari-606.2.104.

5:21 PM Changeset in webkit [236703] by achristensen@apple.com

• 3 edits
  1 delete in trunk/Source/WebCore

Don't read from WebCore's bundle for IDNScriptWhiteList
​https://bugs.webkit.org/show_bug.cgi?id=190157

Reviewed by Dan Bernstein.

No change in behavior. This increases performance by not reading from the WebCore bundle,
and it makes it so that URL-related functionality can be moved to a place without
a bundle for resources.

• Resources/IDNScriptWhiteList.txt: Removed.
• WebCore.xcodeproj/project.pbxproj:
• platform/mac/WebCoreNSURLExtras.mm:

(WebCore::whiteListIDNScripts):
(WebCore::allCharactersInIDNScriptWhiteList):
(WebCore::readIDNScriptWhiteListFile): Deleted.

5:16 PM Changeset in webkit [236702] by achristensen@apple.com

• 4 edits in trunk

Unreviewed, rolling out r236551.

Fails URL validating too aggressively

Reverted changeset:

"URLWithUserTypedString should return nil for URLs deemed to
be invalid by WebCore::URL"
​https://bugs.webkit.org/show_bug.cgi?id=189979
​https://trac.webkit.org/changeset/236551

5:07 PM Changeset in webkit [236701] by aestes@apple.com

• 6 edits in trunk/Source

[watchOS] Adopt NSURLSessionCompanionProxyPreference
​https://bugs.webkit.org/show_bug.cgi?id=190177
<rdar://problem/43402114>

Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Source/WTF:

• wtf/FeatureDefines.h:

4:46 PM Changeset in webkit [236700] by Chris Dumez

• 4 edits
  2 moves in trunk/Source/WebKit

[Mac] The UIProcess should listen to memory pressure signals
​https://bugs.webkit.org/show_bug.cgi?id=190166

Reviewed by Simon Fraser.

The UIProcess should listen to memory pressure signals on Mac in order to free memory, similarly to what we already
do on iOS. The memory pressure handler currently discards view snapshots and prewarmed processes.

• SourcesCocoa.txt:
• UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.h: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.h.
• UIProcess/Cocoa/WebMemoryPressureHandlerCocoa.mm: Renamed from Source/WebKit/UIProcess/ios/WebMemoryPressureHandlerIOS.mm.

(WebKit::installMemoryPressureHandler):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize):

• WebKit.xcodeproj/project.pbxproj:

4:45 PM Changeset in webkit [236699] by Chris Dumez

• 2 edits in trunk/PerformanceTests

Regression(r236613): Parser/HTML5-8266-ParseOnly.html performance tests no longer runs
​https://bugs.webkit.org/show_bug.cgi?id=190174

Reviewed by Ryosuke Niwa.

Update iframe's sandbox to use 'allow-same-origin' so that the iframe is treated as same-origin and so that
the top frame can call document.open() / document.write() on the subframe. This test was also failing in
Firefox without this change.

• Parser/HTML5-8266-ParseOnly.html:

4:28 PM Changeset in webkit [236698] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKit

Fix Internal iOS Build after r236690
​https://bugs.webkit.org/show_bug.cgi?id=190171

Reviewed by Alex Christensen.

• Platform/ExtraPrivateSymbolsForTAPI.h:

4:23 PM Changeset in webkit [236697] by keith_miller@apple.com

• 81 edits in trunk/Source

Create a RELEASE_AND_RETURN macro for ExceptionScopes
​https://bugs.webkit.org/show_bug.cgi?id=190163

Reviewed by Mark Lam.

The new RELEASE_AND_RETURN does all the work for cases
where you want to return the result of some expression
without explicitly checking for an exception. This is
much like the existing RETURN_IF_EXCEPTION macro.

Source/JavaScriptCore:

• dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithSize):

• interpreter/Interpreter.cpp:

(JSC::eval):

• jit/JITOperations.cpp:

(JSC::getByVal):

• jsc.cpp:

(functionDollarAgentReceiveBroadcast):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::varargsSetup):

• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::toJSON const):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::hostResolveImportedModule):

• runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

• runtime/ArrayPrototype.cpp:

(JSC::getProperty):
(JSC::fastJoin):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoPrivateFuncConcatMemcpy):

• runtime/BigIntConstructor.cpp:

(JSC::toBigInt):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opInByVal):

• runtime/ConstructData.cpp:

(JSC::construct):

• runtime/DateConstructor.cpp:

(JSC::dateParse):

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToPrimitiveSymbol):

• runtime/DirectArguments.h:
• runtime/ErrorConstructor.cpp:

(JSC::Interpreter::constructWithErrorConstructor):

• runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

• runtime/ExceptionScope.h:
• runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

• runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

• runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::defineOwnProperty):

• runtime/GetterSetter.cpp:

(JSC::callGetter):

• runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):

• runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorFuncCompare):
(JSC::IntlCollatorPrototypeFuncResolvedOptions):

• runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):

• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatFuncFormatDateTime):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

• runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):

• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatFuncFormatNumber):
(JSC::IntlNumberFormatPrototypeFuncFormatToParts):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

• runtime/IntlObject.cpp:

(JSC::intlNumberOption):

• runtime/IntlObjectInlines.h:

(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):

• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::resolvedOptions):

• runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructorFuncSupportedLocalesOf):

• runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototypeFuncSelect):
(JSC::IntlPluralRulesPrototypeFuncResolvedOptions):

• runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::setLength):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

• runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoGetterFuncByteLength):
(JSC::sharedArrayBufferProtoGetterFuncByteLength):

• runtime/JSArrayInlines.h:

(JSC::toLength):

• runtime/JSBoundFunction.cpp:

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::toIndex const):
(JSC::JSValue::toPropertyKey const):
(JSC::JSValue::get const):
(JSC::JSValue::getPropertySlot const):
(JSC::JSValue::getOwnPropertySlot const):
(JSC::JSValue::equalSlowCaseInline):

• runtime/JSDataView.cpp:

(JSC::JSDataView::put):
(JSC::JSDataView::defineOwnProperty):

• runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructGenericTypedArrayView):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::set):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):

• runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncProtoGetter):

• runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::then):

• runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::put):

• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::provideFetch):
(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::requestImportModule):
(JSC::JSModuleLoader::getModuleNamespaceObject):
(JSC::moduleLoaderRequestedModules):

• runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Stringifier::toJSON):
(JSC::Walker::walk):
(JSC::JSONProtoFuncStringify):

• runtime/JSObject.cpp:

(JSC::ordinarySetSlow):
(JSC::JSObject::putInlineSlow):
(JSC::JSObject::toPrimitive const):
(JSC::JSObject::hasInstance):
(JSC::JSObject::toNumber const):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::defineOwnNonIndexProperty):

• runtime/JSObject.h:

(JSC::JSObject::get const):

• runtime/JSObjectInlines.h:

(JSC::JSObject::getPropertySlot const):
(JSC::JSObject::putInlineForJSObject):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/NativeErrorConstructor.cpp:

(JSC::Interpreter::constructWithNativeErrorConstructor):

• runtime/ObjectConstructor.cpp:

(JSC::constructObject):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptors):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

• runtime/Operations.cpp:

(JSC::jsAddSlowCase):

• runtime/Operations.h:

(JSC::jsString):
(JSC::jsLess):
(JSC::jsLessEq):

• runtime/ParseInt.h:

(JSC::toStringView):

• runtime/ProxyConstructor.cpp:

(JSC::constructProxyObject):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::getOwnPropertySlotCommon):
(JSC::ProxyObject::performPut):
(JSC::ProxyObject::putByIndexCommon):
(JSC::performProxyCall):
(JSC::performProxyConstruct):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):
(JSC::reflectObjectDefineProperty):
(JSC::reflectObjectGet):
(JSC::reflectObjectGetOwnPropertyDescriptor):
(JSC::reflectObjectGetPrototypeOf):
(JSC::reflectObjectOwnKeys):
(JSC::reflectObjectSet):

• runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

• runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):
(JSC::RegExpObject::matchGlobal):

• runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTestFast):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncToString):

• runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

• runtime/SetConstructor.cpp:

(JSC::constructSet):

• runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayEntry::put):

• runtime/StringConstructor.cpp:

(JSC::stringFromCharCode):
(JSC::stringFromCodePoint):

• runtime/StringObject.cpp:

(JSC::StringObject::put):
(JSC::StringObject::putByIndex):
(JSC::StringObject::defineOwnProperty):

• runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
(JSC::operationStringProtoFuncReplaceRegExpEmptyStr):
(JSC::replaceUsingStringSearch):
(JSC::repeatCharacter):
(JSC::replace):
(JSC::stringProtoFuncReplaceUsingRegExp):
(JSC::stringProtoFuncReplaceUsingStringSearch):
(JSC::stringProtoFuncSplitFast):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::toLocaleCase):
(JSC::trimString):
(JSC::stringProtoFuncIncludes):
(JSC::builtinStringIncludesInternal):
(JSC::normalize):
(JSC::stringProtoFuncNormalize):

• runtime/SymbolPrototype.cpp:

(JSC::symbolProtoFuncToString):
(JSC::symbolProtoFuncValueOf):

• tools/JSDollarVM.cpp:

(WTF::functionWasmStreamingParserAddBytes):
(JSC::functionGetPrivateProperty):

• wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::constructJSWebAssemblyCompileError):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::constructJSWebAssemblyModule):
(JSC::WebAssemblyModuleConstructor::createModule):

• wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::constructJSWebAssemblyTable):

• wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::callWebAssemblyWrapperFunction):

Source/WebCore:

No new tests since this is a refactor.

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):

4:12 PM Changeset in webkit [236696] by Adrian Perez de Castro

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.22

[MSE][GStreamer] Reset running time in PlaybackPipeline::flush()
​https://bugs.webkit.org/show_bug.cgi?id=190076

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/media-source/media-source-seek-redundant-append.html

PlaybackPipeline::flush() is called when already enqueued frames are
appended again. This may be caused by a quality change or just a
redundant append. Either way, the pipeline has to be flushed and
playback begin again, but without changing the player position by
much.

There are two kinds of time to consider here: stream time (i.e. the
time of a frame as written in the file, e.g. a frame may have stream
time 0:01:00), and running time (i.e. how much time since playback
started should pass before the frame should be played, e.g. if we
started playing at 0:00:59 that same frame would have a running time
of just 1 second).

Notice how running time depends on where and when playback starts.
Running time can also be optionally resetted after a flush. (This is
indeed done currently by most demuxers after a seek.)

Instead of resetting running time, PlaybackPipeline used to modify the
first GstSegment emitted after the flush. A GstSegment declares the
mapping between stream time and running time for the following frames.
There, PlaybackPipeline used to set base (the running time at which
the segment starts) to the position reported by a position query
(which is stream time).

This, of course, only worked when playback (or the last seek) started
at stream time 0:00:00, since that's the only case where running time
equals stream time. In other cases delays as long as the difference
between these timelines would appear. This is demonstrated in the
attached test, where seeks and appends are made in such an order that
the difference is more than 5 minutes, making the playback stall for

5 minutes before playing 1 second of audio.

This patch fixes the problem by resetting running time with the flush
and not modifying GstSegment.base anymore (it will be left as zero,
which is now correct since the running time has been reset).

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::flush):
(WebCore::segmentFixerProbe): Deleted.

LayoutTests:

A test where a seek is followed by a redundant append is added. This
test timed out in the GStreamer MSE implementation before the
accompanying patch fixed it.

The MIME type declared in test-48khz-manifest.json has also been
changed, from non-standard audio/x-m4a to `audio/mp4;
codecs="mp4a.40.2"`, as implied by the MSE specs. This should not
affect other tests because no other tests were reading this type
string before.

• media/media-source/content/test-48khz-manifest.json:
• media/media-source/media-source-seek-redundant-append-expected.txt: Added.
• media/media-source/media-source-seek-redundant-append.html: Added.
• media/video-test.js:

4:12 PM Changeset in webkit [236695] by Adrian Perez de Castro

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.22

Merged patch for #190085 - [MSE] Use tolerance when growing the coded frame group
​https://bugs.webkit.org/show_bug.cgi?id=190085

Patch by Alicia Boya García <​aboya@igalia.com> on 2018-10-01
Reviewed by NOBODY (OOPS!).

build-releng/../LayoutTests:

A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.

• media/media-source/media-source-append-acb-tolerance.html: Added.

build-releng/../Source/WebCore:

Test: media/media-source/media-source-append-acb-tolerance.html

This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.

This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).

This fixes a stall when seeking back and forth in YouTube with WebM
video.

A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

3:59 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

3:53 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

3:43 PM Changeset in webkit [236694] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Attempt to fix the watchOS build after <​https://trac.webkit.org/changeset/236678>
(​https://bugs.webkit.org/show_bug.cgi?id=189974)

Explicitly cast index to unsigned to make the operator[] call unambiguous.

• platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

2:53 PM Changeset in webkit [236693] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

ASAN failure in ~GCReachableRef()
​https://bugs.webkit.org/show_bug.cgi?id=190113

Reviewed by Darin Adler.

The bug was caused by ~GCReachableRef accessing Ref after it had been poisoned for ASAN
in Ref::leakRef via Ref(Ref&& other). Fixed the bug by using RefPtr instead since that's
the simplest solution here although we could unpoison Ref temporarily as done in ~Ref.

• dom/GCReachableRef.h:

(WebCore::GCReachableRef::GCReachableRef):
(WebCore::GCReachableRef::~GCReachableRef):
(WebCore::GCReachableRef::operator-> const):
(WebCore::GCReachableRef::get const):
(WebCore::GCReachableRef::operator T& const):
(WebCore::GCReachableRef::operator! const):
(WebCore::GCReachableRef::isNull const): Deleted.

2:25 PM Changeset in webkit [236692] by Ryan Haddad

• 3 edits
  1 add in trunk/LayoutTests

Unreviewed, rebaseline tests after r236632.

• platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
• platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt:
• platform/ios/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.

1:59 PM Changeset in webkit [236691] by Wenson Hsieh

• 7 edits in trunk

[iOS] Add SPI to customize the input accessory view when focusing an element
​https://bugs.webkit.org/show_bug.cgi?id=190152
<rdar://problem/42754975>

Reviewed by Dan Bernstein.

Source/WebKit:

Adds SPI on WKFormInputSession to customize the input accessory view, alongside the input view. See below for
more details.

Test: KeyboardInputTests.CustomInputViewAndInputAccessoryView

• UIProcess/API/Cocoa/_WKFormInputSession.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession customInputAccessoryView]):
(-[WKFormInputSession setCustomInputAccessoryView:]):

Reload input views when the custom input accessory view changes.

(-[WKContentView requiresAccessoryView]):

If a custom input accessory view is specified, return YES.

(-[WKContentView inputAccessoryView]):

Return the custom input accessory view if present, and fall back to the default web form accessory view.

Tools:

Add an API test to verify that setting a custom input accessory view and custom input view on the form input
session when focusing an element overrides the first responder's (i.e. WKContentView's) -inputView and
-inputAccessoryView.

• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(webViewWithAutofocusedInput):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/ios/TestInputDelegate.h:
• TestWebKitAPI/Tests/ios/TestInputDelegate.mm:

(-[TestInputDelegate setWillStartInputSessionHandler:]):
(-[TestInputDelegate willStartInputSessionHandler]):
(-[TestInputDelegate _webView:willStartInputSession:]):

1:44 PM Changeset in webkit [236690] by sihui_liu@apple.com

• 54 edits
  7 deletes in trunk

Remove StorageProcess
​https://bugs.webkit.org/show_bug.cgi?id=189975

Reviewed by Geoffrey Garen.

Source/WebCore:

Clean up code. No behavior change.

• English.lproj/Localizable.strings:

Source/WebKit:

• CMakeLists.txt:
• Configurations/Storage-OSX-sandbox.entitlements: Removed.
• Configurations/StorageService.xcconfig: Removed.
• Configurations/WebKit.xcconfig:
• DerivedSources.make:
• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::putOrAdd):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):

• PlatformGTK.cmake:
• PlatformMac.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:
• Shared/ProcessExecutablePath.h:
• Shared/Storage/StorageProcessCreationParameters.cpp: Removed.
• Shared/Storage/StorageProcessCreationParameters.h: Removed.
• Shared/glib/ProcessExecutablePathGLib.cpp:

(WebKit::executablePathOfStorageProcess): Deleted.

• Sources.txt:
• SourcesCocoa.txt:
• SourcesGTK.txt:
• SourcesWPE.txt:
• StorageProcess/EntryPoint/mac/XPCService/StorageService/Info.plist: Removed.
• StorageProcess/EntryPoint/mac/XPCService/StorageServiceEntryPoint.mm: Removed.
• StorageProcess/EntryPoint/unix/StorageProcessMain.cpp: Removed.
• StorageProcess/EntryPoint/win/StorageProcessMain.cpp: Removed.
• StorageProcess/StorageProcess.cpp: Removed.
• StorageProcess/StorageProcess.h: Removed.
• StorageProcess/StorageProcess.messages.in: Removed.
• StorageProcess/StorageToWebProcessConnection.cpp: Removed.
• StorageProcess/StorageToWebProcessConnection.h: Removed.
• StorageProcess/StorageToWebProcessConnection.messages.in: Removed.
• StorageProcess/glib/StorageProcessMainGLib.cpp: Removed.
• StorageProcess/ios/StorageProcessIOS.mm: Removed.
• StorageProcess/mac/StorageProcessMac.mm: Removed.
• StorageProcess/mac/com.apple.WebKit.Storage.sb.in: Removed.
• StorageProcess/unix/StorageProcessMainUnix.h: Removed.
• StorageProcess/win/StorageProcessMainWin.cpp: Removed.
• StorageProcess/win/StorageProcessMainWin.h: Removed.
• UIProcess/API/C/WKContext.cpp:

(WKContextTerminateStorageProcess): Deleted.
(WKContextGetDatabaseProcessIdentifier): Deleted.

• UIProcess/API/C/WKContext.h:
• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _terminateStorageProcess]): Deleted.
(-[WKProcessPool _storageProcessIdentifier]): Deleted.

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::processName):

• UIProcess/Storage/StorageProcessProxy.cpp: Removed.
• UIProcess/Storage/StorageProcessProxy.h: Removed.
• UIProcess/Storage/StorageProcessProxy.messages.in: Removed.
• UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::storageProcessDidCrash): Deleted.

• UIProcess/WebContextClient.h:
• UIProcess/WebContextSupplement.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::sendMemoryPressureEvent):
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore): Deleted.
(WebKit::WebProcessPool::getStorageProcessConnection): Deleted.
(WebKit::WebProcessPool::storageProcessCrashed): Deleted.
(WebKit::WebProcessPool::storageProcessIdentifier): Deleted.
(WebKit::WebProcessPool::terminateStorageProcessForTesting): Deleted.

• UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToStorageProcess): Deleted.
(WebKit::WebProcessPool::sendToStorageProcessRelaunchingIfNecessary): Deleted.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getStorageProcessConnection): Deleted.

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::storageProcessParameters): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Storage/WebServiceWorkerProvider.cpp:
• WebProcess/Storage/WebToStorageProcessConnection.cpp: Removed.
• WebProcess/Storage/WebToStorageProcessConnection.h: Removed.
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcess::webToStorageProcessConnectionClosed): Deleted.
(WebKit::WebProcess::ensureWebToStorageProcessConnection): Deleted.

• WebProcess/WebProcess.h:
• webkitglib-symbols.map:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::terminateStorageProcess): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):
(WTR::TestController::databaseProcessName): Deleted.
(WTR::TestController::databaseProcessDidCrash): Deleted.
(WTR::TestController::terminateStorageProcess): Deleted.

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Since Service Worker management is in netowrk process now, we should terminate network
process instead of storage process.

• http/wpt/service-workers/persistent-importScripts.html:

1:38 PM Changeset in webkit [236689] by david_quesada@apple.com

• 7 edits in trunk/Source/WebKit

Add missing Objective-C versions of downloads SPI
​https://bugs.webkit.org/show_bug.cgi?id=190149
rdar://problem/44915592

Reviewed by Alex Christensen.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _downloadURLRequest:]):
(-[WKProcessPool _resumeDownloadFromData:path:]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/API/Cocoa/_WKDownload.h:
• UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload resumeData]):

• UIProcess/API/Cocoa/_WKDownloadInternal.h:
• UIProcess/Cocoa/DownloadClient.mm:

Move the DownloadProxy's WrapperTraits out of DownloadClient, and into the internal
header so it can be used from other classes (i.e. WKProcessPool here).

1:09 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

1:07 PM Changeset in webkit [236688] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Merge r236679 - [MSE][GStreamer] Set a minimum sample duration
​https://bugs.webkit.org/show_bug.cgi?id=190125

Reviewed by Xabier Rodriguez-Calvar.

The last sample of the audio track in the asset used in this test
player has a tiny duration (100 ns):

​http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest

So small, we were truncating it to zero. We're not supposed to have
frames with zero duration. Instead, lets set a minimum frame duration
for those fringe cases.

• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):

12:57 PM Changeset in webkit [236687] by achristensen@apple.com

• 3 edits in trunk/Source/WebKit

Fix internal build after r236665
​https://bugs.webkit.org/show_bug.cgi?id=189850

• UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h:
• WebKit.xcodeproj/project.pbxproj:

12:57 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

12:47 PM Changeset in webkit [236686] by jiewen_tan@apple.com

• 14 edits
  1 add in trunk

[WebAuthN] Import a JS CBOR coder
​https://bugs.webkit.org/show_bug.cgi?id=189877
<rdar://problem/44701124>

Reviewed by Chris Dumez.

Source/WebKit:

Update MockWebAuthenticationConfiguration to have userCertificateBase64 and intermediateCACertificateBase64
as Local's memeber such that tests can pass those certificates to MockLocalConnection instead of letting it
holds some static ones.

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):

• UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getAttestation const):

• UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:

Tools:

Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
only if acceptAttestation is true.

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration):

LayoutTests:

This patch import a 3rd party JS CBOR coder from ​https://github.com/paroga/cbor-js.
The library is MIT licensed, which should be fine to use within WebKit.

As a benefit from the library, tests are updated to check CBOR binaries.

• http/wpt/credential-management/credentialscontainer-store-basics.https.html:
• http/wpt/webauthn/idl.https.html:
• http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
• http/wpt/webauthn/public-key-credential-create-success-local.https.html:
• http/wpt/webauthn/public-key-credential-get-failure-local.https.html:
• http/wpt/webauthn/public-key-credential-get-success-local.https.html:
• http/wpt/webauthn/resources/cbor.js: Added.
• http/wpt/webauthn/resources/util.js:

12:46 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

12:45 PM Changeset in webkit [236685] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Merge r236666 - [WPE] fix buffer over-read in RenderThemeWPE::mediaControlsStyleSheet()
​https://bugs.webkit.org/show_bug.cgi?id=190139

Patch by Olivier Blin <Olivier Blin> on 2018-10-01
Reviewed by Michael Catanzaro.

Like done upstream for EFL in r210213
​https://bugs.webkit.org/show_bug.cgi?id=166622

This has been detected by a charactersAreAllASCII() assert failure.

This is because ASCIILiteral() is wrongly used in mediaControlsStyleSheet().
mediaControlsBaseUserAgentStyleSheet is a char array, not a null-terminated string.
It is thus incorrect to use StringImpl::createFromLiteral() that calls
strlen() to get the string length.

The String::ConstructFromLiteral constructor can not be used, since it
skips the last character.

• platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::mediaControlsStyleSheet):
Explicitely pass the size to the String constructor.

12:41 PM WebKitGTK/2.22.x edited by Michael Catanzaro

(diff)

12:40 PM Changeset in webkit [236684] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/JSTests

Split NaN-check into separate test
​https://bugs.webkit.org/show_bug.cgi?id=190010

Patch by Dominik Infuehr <​dinfuehr@igalia.com> on 2018-10-01
Reviewed by Saam Barati.

DataView exposes NaN-representation, which is not necessarily the same on each
architecture. Therefore move the check of the NaN-representation into its own
file such that we can disable this test on MIPS where NaN-representation can be
different on older CPUs.

• stress/dataview-jit-set-nan.js: Added.

(assert):
(test.storeLittleEndian):
(test.storeBigEndian):
(test.store):
(test):

• stress/dataview-jit-set.js:

(test5):

12:17 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

12:17 PM Changeset in webkit [236683] by Adrian Perez de Castro

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.22

Merge r236566 - [MSE] Fix unwanted sample erase from the decode queue
​https://bugs.webkit.org/show_bug.cgi?id=180643

Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-source/media-source-append-acb-no-frame-lost.html

This bug reproduced when unordered appends were made. For instance, if
the application appended [0, 10) and then [20, 30), the frame at 20
would be wrongly discarded from the decode queue.

Later the application could append [10, 20) and the gap at [20, 21)
would persist in the decode queue, even if the frame remained in the
track buffer table.

Thanks to Daniel Zhang for reporting the issue.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::provideMediaData):

LayoutTests:

Added a test case for the fixed bug.

• media/media-source/media-source-append-acb-no-frame-lost.html: Added.

12:17 PM Changeset in webkit [236682] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Merge r236409 - [MSE][GStreamer] Pull demuxed samples in batches
​https://bugs.webkit.org/show_bug.cgi?id=189871

Reviewed by Xabier Rodriguez-Calvar.

After this patch, only the notifications of "new samples available"
(appsink-new-sample bus messages) travel from the streaming thread to
the main thread through the bus and the main thread is the responsible
of pulling as many samples as it can from appsink. Before, the samples
were pulled from appsink in the non-main thread and traveled to the
main thread through the bus one by one.

This reduces drastically the amount of context switches and waiting
time in the streaming thread, resulting in a noticeable performance
improvement.

This fixes stutter while loading YouTube videos.

• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::clearPlayerPrivate):
(WebCore::AppendPipeline::handleApplicationMessage):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::consumeAppSinkAvailableSamples):
(WebCore::AppendPipeline::resetPipeline):
(WebCore::AppendPipeline::handleNewAppsinkSample):

• platform/graphics/gstreamer/mse/AppendPipeline.h:

12:17 PM Changeset in webkit [236681] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Merge r236395 - [MSE][GStreamer] Don't update duration when it was not previously NaN
​https://bugs.webkit.org/show_bug.cgi?id=189869

Reviewed by Xabier Rodriguez-Calvar.

This is what the spec mandates. The spec doesn't say anything about
updating duration when it had been previously set, even if the new
init segment says that the duration is growing.

This fixes MSE YTTV 2018 69.MediaSourceDurationVP9.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

11:57 AM Changeset in webkit [236680] by Chris Dumez

• 9 edits in trunk

Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=190052

Reviewed by Ryosuke Niwa.

Source/WebKit:

• Platform/IPC/Connection.cpp:

(IPC::Connection::sendMessage):

• Platform/IPC/Connection.h:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePagePostMessageIgnoringFullySynchronousMode):

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::postMessageIgnoringFullySynchronousMode):

• WebProcess/WebPage/WebPage.h:

Tools:

The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
to log those events. It also uses console.log() before sending those events to indicate what the test is about
to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
so that it can log the message.
The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
handler to be transformed into synchronous IPC.
As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
messages may end up being out of order, leading to flakiness.

To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::outputText):

11:38 AM Changeset in webkit [236679] by aboya@igalia.com

• 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Set a minimum sample duration
​https://bugs.webkit.org/show_bug.cgi?id=190125

Reviewed by Xabier Rodriguez-Calvar.

The last sample of the audio track in the asset used in this test
player has a tiny duration (100 ns):

​http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest

So small, we were truncating it to zero. We're not supposed to have
frames with zero duration. Instead, lets set a minimum frame duration
for those fringe cases.

• platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):

11:35 AM Changeset in webkit [236678] by dbates@webkit.org

• 17 edits
  4 adds in trunk

[iOS] Special keys are misidentified in DOM keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=189974

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch fixes two issues:

1. Special keyboard keys would be misidentified in dispatched DOM keyboard events.
2. DOM keypress events may not be dispatched for some special keys.

UIKit uses special input strings to identify the Page Up, Page Down, Escape, Up Arrow, Down Arrow,
Left Arrow, and Right Arrow keys. It also uses ASCII control characters to represent some other
special keys, including Num Lock / Clear, Home, End, Forward Delete, and F1, ..., F24. We need
to explicitly handle these special keyboard keys in order to be able to identify the key that
was pressed as well as to correctly disambiguate a key down to know whether to dispatch a DOM
keypress event for the key.

Unlike UIKit, AppKit reserves Unicode Private Use Area (PUA) code points in 0xF700–0xF8FF to
represent special keyboard keys. This makes it straightforward to disambiguate such keys using
the input string of the keyboard event alone. To simplify the implementation for iOS
we normalize the input string be AppKit compatible. See the explaination for WebCore::windowsKeyCodeForCharCode()
below for more details on why this is done.

Tests: fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element.html

fast/events/ios/keypress-keys-in-non-editable-element.html

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:

Do not use unified source build strategy when building WebEvent.mm as it makes
use of SoftLinking macros that are incompatible with this strategy.

• platform/ios/KeyEventIOS.mm:

(WebCore::windowsKeyCodeForCharCode): Recognize some special AppKit special char codes.
These special char codes are generated by WebKit. WebKit uses the same special char codes
as AppKit as a convenience instead of defining our own constants for the same purpose.
Encoding the special UIKit input strings (e.g. up arrow) as distinct char codes allows us
to use integer arithmetic and switch blocks to map characters to Windows virtual key
codes as opposed to special cased branches to perform pointer or string comparisions.
The latter would be necessary in Modern WebKit in order for key down events to be properly
disambiguated to dispatch a DOM keypress event because pointers are not perserved, though
what they point to is, when sending the WebEvent from UIProcess to the WebProcess and
vice versa.
(WebCore::isFunctionKey): Convenience function that determines whether the specified char
code corresponds to a function key on the keyboard. The term "function key" is taken from
AppKit parlance to describe a special keyboard key. These keys include F1, F2, ..., F24,
and cursor keys among other special keyboard keys.
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Write in terms of isFunctionKey().

• platform/ios/PlatformEventFactoryIOS.h:
• platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::keyIdentifierForKeyEvent): Remove code to handle UIKit special input strings as
we now map such special input strings to char codes and hence can use the default code path.
(WebCore::keyForKeyEvent): Ditto.
(WebCore::codeForKeyEvent): Remove code to compute the Window virtual key code corresponding
to a UIKit special key command now that we map such special input strings to char codes and
subsequently map the char codes to the Windows virtual key code (see -[WebEvent initWithKeyEventType:...]
constructors). So, we can now use WebEvent.keyCode directly to compute the DOM UIEvents code
for the event.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): Remove code to fix up
WebEvent.keyCode to account for UIKit special input strings now that we map such special key
commands to char codes and subsequently map the char codes to the Windows virtual key code (see -[WebEvent initWithKeyEventType:...]
constructors). So, we can now take WebEvent.keyCode verbatim to be the Window virtual key code.
(WebCore::convertSpecialKeyToCharCode): Deleted.
(WebCore::keyCodeForEvent): Deleted.

• platform/ios/WebEvent.mm:

(normalizedStringWithAppKitCompatibilityMapping): Added; converts a UIKit character string
to the corresponding AppKit-compatible one (if not already compatible). See the explaination
for WebCore::windowsKeyCodeForCharCode() above for more details on why this is done.

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Normalize the character strings to be AppKit compatible.

Source/WebCore/PAL:

Forward declare or define more SPI.

• pal/spi/cocoa/IOKitSPI.h:
• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Take the key code of WebEvent to be the key code for the new WebKeyboardEvent verbatim
now that we normalize the character strings of the WebEvent to account for the special
UIKit input strings.

• Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

Tools:

Add support for testing keys Forward Delete and Num Lock / Clear.

• WebKitTestRunner/ios/HIDEventGenerator.mm:

(hidUsageCodeForCharacter):

LayoutTests:

Add tests to ensure that we do not regress key identification for special keys.

Update the expected results for test fast/events/ios/keydown-keyup-special-keys-in-non-editable-element.html
now that we correctly identify some more keys.

• fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element-expected.txt: Added.
• fast/events/ios/keydown-keyup-arrow-keys-in-non-editable-element.html: Added.
• fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt:
• fast/events/ios/keypress-keys-in-non-editable-element-expected.txt: Added.
• fast/events/ios/keypress-keys-in-non-editable-element.html: Added.
• resources/ui-helper.js:

(window.UIHelper.typeCharacter): Actually type the specified character in DumpRenderTree.

11:32 AM Changeset in webkit [236677] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Optimize RenderStyle::diff() and clean up the code
​https://bugs.webkit.org/show_bug.cgi?id=190104

Reviewed by Dan Bernstein.

RenderStyle::changeRequiresLayout() and related should only check values on
m_rareNonInheritedData and m_rareInheritedData after checking for pointer equality.
To reduce the chances of future changes regressing this, move code comparing values
on StyleRare[Non]InheritedData into dedication functions.

In addition, the transform comparison double-compared the transformOperations,
because m_rareNonInheritedData->transform != other.m_rareNonInheritedData->transform
is a deep comparison, and it was followed by *m_rareNonInheritedData->transform != *other.m_rareNonInheritedData->transform.
Change the first to be a pointer comparison.

• rendering/style/RenderStyle.cpp:

(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::rareInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::rareNonInheritedDataChangeRequiresLayerRepaint):
(WebCore::RenderStyle::changeRequiresLayerRepaint const):
(WebCore::rareNonInheritedDataChangeRequiresRepaint):
(WebCore::rareInheritedDataChangeRequiresRepaint):
(WebCore::RenderStyle::changeRequiresRepaint const):

11:27 AM Changeset in webkit [236676] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

11:27 AM Changeset in webkit [236675] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix an internal build after r236665
​https://bugs.webkit.org/show_bug.cgi?id=189850

• WebKit.xcodeproj/project.pbxproj:

Make WKNSURLAuthenticationChallenge.h a private header.

11:16 AM Changeset in webkit [236674] by achristensen@apple.com

• 18 edits in trunk

URL should not use TextEncoding internally
​https://bugs.webkit.org/show_bug.cgi?id=190111

Reviewed by Andy Estes.

Source/WebCore:

That dependency makes it impossible to move or use elsewhere.
Using TextEncoding was overkill because we know the credentials are UTF-8 percent-encoded in a parsed URL.
No change in behavior as verified by new API tests.

• page/SecurityOrigin.cpp:
• page/csp/ContentSecurityPolicySourceList.cpp:
• platform/URL.cpp:

(WebCore::decodeEscapeSequencesFromParsedURL):
(WebCore::URL::user const):
(WebCore::URL::pass const):
(WebCore::URL::fileSystemPath const):
(WebCore::decodeURLEscapeSequences): Deleted.

• platform/URL.h:
• platform/network/DataURLDecoder.cpp:
• platform/text/TextEncoding.cpp:

(WebCore::decodeURLEscapeSequences):

• platform/text/TextEncoding.h:

Source/WebKit:

• UIProcess/WebInspectorProxy.cpp:

Source/WebKitLegacy/mac:

• Misc/WebNSURLExtras.mm:

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::testUserPass):
(TestWebKitAPI::TEST_F):

11:08 AM Changeset in webkit [236673] by commit-queue@webkit.org

• 3 edits
  5 adds in trunk

<form> in quirks mode should have margin-block-end: 1em
​https://bugs.webkit.org/show_bug.cgi?id=157788

Patch by Simon Pieters <​zcorpan@gmail.com> on 2018-10-01
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html: Added.
• web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt: Added.

Source/WebCore:

Change the default style for forms to take writing-mode into account
in quirks mode. Matches the behavior of Gecko and Edge and the HTML
standard.

Spec: ​https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3

Test: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html

• css/quirks.css:

(form):

11:06 AM Changeset in webkit [236672] by bshafiei@apple.com

• 7 edits in branches/safari-606-branch/Source

Versioning.

10:59 AM Changeset in webkit [236671] by commit-queue@webkit.org

• 7 edits in trunk/Source

Unify implementation in VideoFullscreenInterfaceAVKit
​https://bugs.webkit.org/show_bug.cgi?id=190091
rdar://problem/44734523

Patch by Jeremy Jones <​jeremyj@apple.com> on 2018-10-01
Reviewed by Jer Noble.

Source/WebCore:

No new tests because no behavior change.

Unified code in VideoFullscreenInterfaceAVKit now that new code path is proven and include
any changes that had been made in the old path.

• platform/ios/VideoFullscreenInterfaceAVKit.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerViewControllerDelegate playerViewControllerShouldStartPictureInPictureFromInlineWhenEnteringBackground:]):
(VideoFullscreenInterfaceAVKit::preparedToExitFullscreen):
(VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::requestUpdateInlineRect):
(VideoFullscreenControllerContext::requestVideoContentLayer):
(VideoFullscreenControllerContext::returnVideoContentLayer):
(VideoFullscreenControllerContext::didSetupFullscreen):
(VideoFullscreenControllerContext::didExitFullscreen):

Source/WebKit:

Unified code in VideoFullscreenInterfaceAVKit now that new code path is proven and include
any changes that had been made in the old path.

• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
• WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::supportsVideoFullscreenStandby const):
(WebKit::VideoFullscreenManager::didSetupFullscreen):
(WebKit::VideoFullscreenManager::didExitFullscreen):

10:44 AM Changeset in webkit [236670] by graouts@webkit.org

• 6 edits in trunk/Source/WebCore

[Web Animations] Ensure renderers with accelerated animations have layers
​https://bugs.webkit.org/show_bug.cgi?id=189990

Reviewed by Simon Fraser.

In r236501 we added code that would make a RenderBox and a RenderInline query the document timeline for whether a given element has
accelerated animations running on it. Since the calls to requiresLayer() are in a hot path, we instead keep a list of elements with
exclusively accelerated animations running.

No new tests, this is already covered by webanimations/accelerated-animation-with-delay.html and webanimations/opacity-animation-yields-compositing-span.html
which respectively check that we can apply an accelerated animation to a non-positioned block and an inline element.

• animation/AnimationTimeline.h:
• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::animationWasAddedToElement):
(WebCore::DocumentTimeline::animationWasRemovedFromElement):
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement): Iterate over an element's animations to determine
whether all of its animations are running accelerated, then update the HashSet containing elements running accelerated animations to remove or
add this element.
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated const): Make a simple contains() call on the HashSet containing elements
running accelerated animations.

• animation/DocumentTimeline.h:
• animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):
(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):

• rendering/RenderBoxModelObject.h:

10:41 AM Changeset in webkit [236669] by dbates@webkit.org

• 3 edits in trunk/Source/WebKit

[iOS] Wrong key event may be sent to UIKit
​https://bugs.webkit.org/show_bug.cgi?id=189992

Reviewed by Simon Fraser.

Retain a clone of a received UIEvent if it is for a hardware key event so as to ensure that we
notify the UIKit keyboard code of the correct keyboard event.

Currently the UIProcess retains the UIEvent associated with a keyboard event so as to defer
notifying the UIKit keyboard code (via -_handleKeyUIEvent) about a received keyboard event until
after the WebProcess has processed the raw key event. If this UIEvent is for a hardware keyboard
event then it is not sufficient to retain it to preserve its value because UIKit uses a singleton
UIEvent for all hardware keyboard events ;=> its value will be clobbered as each hardware keyboard
event is received. Instead we need to explicitly clone a UIEvent for a hardware key event before
retaining it.

• Platform/spi/ios/UIKitSPI.h: Forward declare SPI.
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView handleKeyEvent:]): Clone the UIEvent if it is for a hardware key event.

10:40 AM Changeset in webkit [236668] by aboya@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Fix abort in gst_sample_get_info()
​https://bugs.webkit.org/show_bug.cgi?id=190135

Reviewed by Philippe Normand.

A flush can occur before any frame has finished decoding -- especially
in tests, where actions on the player often occur in quick succession.

Therefore, the code must not assume by the time a flush occurs any
frame has reached the sink. This patch fixes a case when such wrong
assumption was causing gst_sample_get_info() to abort (crashing
WebKit).

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink):

10:22 AM Changeset in webkit [236667] by dbates@webkit.org

• 6 edits in trunk/Tools

LLDB tests may use wrong configuration of lldbWebKitTester
​https://bugs.webkit.org/show_bug.cgi?id=189011

Reviewed by Dean Jackson.

Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
Additionally, add back the unit tests originally added in r235376 (​https://bugs.webkit.org/show_bug.cgi?id=188936).

Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
the Python unittest module, the Python multiprocessing module, and the general principle of unit
tests - to test code in isolation). The unit tests make use of the value of this environment
variable to launch lldbWebKitTester binary.

• Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error

out if this script is invoked for a non-Mac platform.

• Scripts/webkitpy/test/main.py:

(Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
LLDB_WEBKIT_TESTER_EXECUTABLE.
(_build_lldb_webkit_tester): Deleted.

• lldb/dump_class_layout_unittest.py:

(TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
this is the only call site that needs the Host object now.
(TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.

• lldb/lldbWebKitTester/main.cpp:

(testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (​https://bugs.webkit.org/show_bug.cgi?id=188936).

• lldb/lldb_webkit_unittest.py:

(LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
variable LLDB_WEBKIT_TESTER_EXECUTABLE.
(TestSummaryProviders):
(TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
(TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
(TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
(TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
(TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
(TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
Add back the unit tests originally added in r235376 (​https://bugs.webkit.org/show_bug.cgi?id=188936).

10:19 AM Changeset in webkit [236666] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WPE] fix buffer over-read in RenderThemeWPE::mediaControlsStyleSheet()
​https://bugs.webkit.org/show_bug.cgi?id=190139

Patch by Olivier Blin <Olivier Blin> on 2018-10-01
Reviewed by Michael Catanzaro.

Like done upstream for EFL in r210213
​https://bugs.webkit.org/show_bug.cgi?id=166622

This has been detected by a charactersAreAllASCII() assert failure.

This is because ASCIILiteral() is wrongly used in mediaControlsStyleSheet().
mediaControlsBaseUserAgentStyleSheet is a char array, not a null-terminated string.
It is thus incorrect to use StringImpl::createFromLiteral() that calls
strlen() to get the string length.

The String::ConstructFromLiteral constructor can not be used, since it
skips the last character.

• platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::mediaControlsStyleSheet):
Explicitely pass the size to the String constructor.

10:16 AM Changeset in webkit [236665] by achristensen@apple.com

• 32 edits in trunk/Source/WebKit

Deprecate ObjC SPI in Deprecated Xcode group
​https://bugs.webkit.org/show_bug.cgi?id=189850

Reviewed by Andy Estes.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/mac/ObjCObjectGraph.mm:

(WebKit::typeFromObject):
(WebKit::ObjCObjectGraph::encode):
(WebKit::ObjCObjectGraph::decode):

• UIProcess/API/Cocoa/WKBrowsingContextController.h:
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(didStartProvisionalNavigation):
(didReceiveServerRedirectForProvisionalNavigation):
(didFailProvisionalNavigation):
(didCommitNavigation):
(didFinishNavigation):
(didFailNavigation):
(canAuthenticateAgainstProtectionSpace):
(didReceiveAuthenticationChallenge):
(processDidCrash):
(setUpPagePolicyClient):

• UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
• UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h:
• UIProcess/API/Cocoa/WKBrowsingContextHistoryDelegate.h:
• UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
• UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h:
• UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
• UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h:
• UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:

(-[WKNSURLAuthenticationChallengeSender cancelAuthenticationChallenge:]):
(-[WKNSURLAuthenticationChallengeSender continueWithoutCredentialForAuthenticationChallenge:]):
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]):
(-[WKNSURLAuthenticationChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WKNSURLAuthenticationChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

• UIProcess/API/Cocoa/WKNavigationData.h:
• UIProcess/API/Cocoa/WKNavigationDataInternal.h:
• UIProcess/API/Cocoa/WKProcessGroup.h:
• UIProcess/API/Cocoa/WKProcessGroup.mm:

(didCreateConnection):
(getInjectedBundleInitializationUserData):
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):

• UIProcess/API/Cocoa/WKTypeRefWrapper.h:
• UIProcess/API/Cocoa/WKView.h:

(WK_CLASS_DEPRECATED_WITH_REPLACEMENT):

• UIProcess/API/Cocoa/_WKThumbnailView.h:
• UIProcess/API/Cocoa/_WKThumbnailView.mm:
• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/Gamepad/mac/UIGamepadProviderMac.mm:

(WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput):

• UIProcess/ios/WKContentView.h:
• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

9:41 AM Changeset in webkit [236664] by Ryan Haddad

• 2 edits in trunk/LayoutTests

REGRESSION (r235948?): Layout Test media/media-controls-accessibility.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=189674

Unreviewed test gardening..

• platform/mac/TestExpectations: Remove flaky expectation.

9:17 AM Changeset in webkit [236663] by rwlbuis@webkit.org

• 5 edits in trunk

Patch for landing

9:17 AM Changeset in webkit [236662] by youenn@apple.com

• 7 edits in trunk

[macOS Sierra] Layout Test http/wpt/cache-storage/cache-put-keys.https.any.worker.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=184204

Reviewed by Chris Dumez.

Source/WebKit:

NetworkCache::Storage by default limits the length to read to 1500 milliseconds.
This is good for the HTTP cache since networking might be faster.
It does not work for DOM cache which needs to get these resources even if it takes a long time.

Since this is disabled by a Mode::Testing option, use it for DOMCache after renaming it to Mode::AvoidRandomness.

Add a bunch of release logging to help debugging error cases.

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::retrieveOriginFromDirectory):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::writeCachesToDisk):
(WebKit::CacheStorage::Caches::readRecord):

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::open):

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::shrinkIfNeeded):

• NetworkProcess/cache/NetworkCacheStorage.h:

LayoutTests:

• platform/mac-wk2/TestExpectations:

9:10 AM Changeset in webkit [236661] by Chris Dumez

• 11 edits in trunk

Make crossOriginObject.then undefined for promises
​https://bugs.webkit.org/show_bug.cgi?id=190094

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Make crossOriginObject.then undefined for promises. This allows promises to work better with cross-origin WindowProxy
and Location objects.

Specification:

• ​https://github.com/whatwg/html/pull/3242
• ​https://github.com/whatwg/dom/issues/536

This aligns our behavior with Blink and Gecko.

No new tests, rebaselined existing test.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::addCrossOriginWindowOwnPropertyNames):

• bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::addCrossOriginLocationOwnPropertyNames):

LayoutTests:

Update existing tests to reflect behavior change.

• http/tests/navigation/process-swap-window-open-expected.txt:
• http/tests/navigation/process-swap-window-open.html:
• http/wpt/cross-origin-window-policy/resources/utils.js:

(testCrossOriginOption):

8:12 AM Changeset in webkit [236660] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Add a JSONStringify overload that receives a JSValue space
​https://bugs.webkit.org/show_bug.cgi?id=190131

Patch by Koby Boyango <​koby.b@mce-sys.com> on 2018-10-01
Reviewed by Yusuke Suzuki.

• runtime/JSONObject.cpp:
• runtime/JSONObject.h:

6:49 AM Changeset in webkit [236659] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Source/WebKit

[WPE] Remove WebKit2InspectorGResourceBundle.xml
​https://bugs.webkit.org/show_bug.cgi?id=190132

Patch by Olivier Blin <Olivier Blin> on 2018-10-01
Reviewed by Michael Catanzaro.

• UIProcess/API/wpe/WebKit2InspectorGResourceBundle.xml: Removed.

This is unused since legacy INSPECTOR_SERVER implementation has
been removed in r217924.

6:47 AM Changeset in webkit [236658] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[SOUP] Fix the build for libsoup > 2.61.90
​https://bugs.webkit.org/show_bug.cgi?id=190126

Patch by Xan Lopez <Xan Lopez> on 2018-10-01
Reviewed by Michael Catanzaro.

• platform/network/soup/SocketStreamHandleImplSoup.cpp:

6:26 AM Changeset in webkit [236657] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WPE] Update install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=190127

Patch by Olivier Blin <Olivier Blin> on 2018-10-01
Reviewed by Michael Catanzaro.

• wpe/install-dependencies:

libxrandr-dev is needed for gstreamer-vaapi in jhbuild
It is used by gstvaapidisplay_x11.c.
Add it only for Apt, already ok for Pacman and DNF.

Install libevent-dev for WebRTC (like GTK)

Install libasound2-dev for WebRTC.
Add it only for Apt, already ok for Pacam and DNF.

Install libgbm-dev for HeadlessViewBackend, which uses gbm.h

6:11 AM Changeset in webkit [236656] by aboya@igalia.com

• 4 edits
  2 adds in trunk

[MSE][GStreamer] Reset running time in PlaybackPipeline::flush()
​https://bugs.webkit.org/show_bug.cgi?id=190076

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/media-source/media-source-seek-redundant-append.html

PlaybackPipeline::flush() is called when already enqueued frames are
appended again. This may be caused by a quality change or just a
redundant append. Either way, the pipeline has to be flushed and
playback begin again, but without changing the player position by
much.

There are two kinds of time to consider here: stream time (i.e. the
time of a frame as written in the file, e.g. a frame may have stream
time 0:01:00), and running time (i.e. how much time since playback
started should pass before the frame should be played, e.g. if we
started playing at 0:00:59 that same frame would have a running time
of just 1 second).

Notice how running time depends on where and when playback starts.
Running time can also be optionally resetted after a flush. (This is
indeed done currently by most demuxers after a seek.)

Instead of resetting running time, PlaybackPipeline used to modify the
first GstSegment emitted after the flush. A GstSegment declares the
mapping between stream time and running time for the following frames.
There, PlaybackPipeline used to set base (the running time at which
the segment starts) to the position reported by a position query
(which is stream time).

This, of course, only worked when playback (or the last seek) started
at stream time 0:00:00, since that's the only case where running time
equals stream time. In other cases delays as long as the difference
between these timelines would appear. This is demonstrated in the
attached test, where seeks and appends are made in such an order that
the difference is more than 5 minutes, making the playback stall for

5 minutes before playing 1 second of audio.

This patch fixes the problem by resetting running time with the flush
and not modifying GstSegment.base anymore (it will be left as zero,
which is now correct since the running time has been reset).

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::flush):
(WebCore::segmentFixerProbe): Deleted.

LayoutTests:

A test where a seek is followed by a redundant append is added. This
test timed out in the GStreamer MSE implementation before the
accompanying patch fixed it.

The MIME type declared in test-48khz-manifest.json has also been
changed, from non-standard audio/x-m4a to `audio/mp4;
codecs="mp4a.40.2"`, as implied by the MSE specs. This should not
affect other tests because no other tests were reading this type
string before.

• media/media-source/content/test-48khz-manifest.json:
• media/media-source/media-source-seek-redundant-append-expected.txt: Added.
• media/media-source/media-source-seek-redundant-append.html: Added.
• media/video-test.js:

5:33 AM Changeset in webkit [236655] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[WTF][JSCONLY] Use MainThreadWin on Windows in the JSCOnly port
​https://bugs.webkit.org/show_bug.cgi?id=190121

Patch by Koby Boyango <​koby.b@mce-sys.com> on 2018-10-01
Reviewed by Yusuke Suzuki.

This fixes JSCOnly build on Windows after r236617.

• wtf/PlatformJSCOnly.cmake:

4:56 AM Changeset in webkit [236654] by Caio Lima

• 2 edits in trunk

'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS
​https://bugs.webkit.org/show_bug.cgi?id=190118

Reviewed by Yusuke Suzuki.

We define HAVE_PTHREAD_MAIN_NP in WTF/wtf/Platform.h when the OS is
Darwin. In such case, we don't need to check symbols for
pthread_main_np when generating build for this system.

• Source/cmake/OptionsCommon.cmake:

4:41 AM Changeset in webkit [236653] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak] Add libunwind in the sandbox
​https://bugs.webkit.org/show_bug.cgi?id=190123

Allowing us to get proper traces in GStreamer trace grabing
debug functions.

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-10-01
Reviewed by Philippe Normand.

• flatpak/org.webkit.WebKit.yaml:

4:26 AM Changeset in webkit [236652] by commit-queue@webkit.org

• 7 edits in trunk

Unreviewed, rolling out r236647.
​https://bugs.webkit.org/show_bug.cgi?id=190124

Breaking test stress/big-int-to-string.js (Requested by
caiolima_ on #webkit).

Reverted changeset:

"[BigInt] BigInt.proptotype.toString is broken when radix is
power of 2"
​https://bugs.webkit.org/show_bug.cgi?id=190033
​https://trac.webkit.org/changeset/236647

2:25 AM Changeset in webkit [236651] by yusukesuzuki@slowstart.org

• 4 edits in trunk/Source/JavaScriptCore

[WebAssembly] Move type conversion code of JSToWasm return type to JS wasm wrapper
​https://bugs.webkit.org/show_bug.cgi?id=189498

Reviewed by Saam Barati.

To call JS-to-Wasm code we need to convert the result value from wasm function to
the JS type. Previously this is done by callWebAssemblyFunction by using swtich
over signature.returnType(). But since we know the value of signature.returnType()
at compiling phase, we can emit a small conversion code directly to JSToWasm glue
and remove this switch from callWebAssemblyFunction.

In JSToWasm glue code, we do not have tag registers. So we use DoNotHaveTagRegisters
in boxInt32 and boxDouble. Since boxDouble does not have DoNotHaveTagRegisters version,
we add an implementation for that.

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::boxDouble):

• wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

1:04 AM Changeset in webkit [236650] by graouts@webkit.org

• 4 edits in trunk/LayoutTests

[Web Animations] Fix test regressions after enabling Web Animations with CSS Integration
​https://bugs.webkit.org/show_bug.cgi?id=190032

Unreviewed. We need to opt into the legacy animation engine for these tests to fix some crashes in other
tests due to webkit.org/b/186946.

• legacy-animation-engine/animations/cross-fade-webkit-mask-image.html:
• legacy-animation-engine/transitions/delay.html:
• legacy-animation-engine/transitions/transition-timing-function.html:

Sep 30, 2018:

10:30 PM Changeset in webkit [236649] by rniwa@webkit.org

• 7 edits in trunk/Source/WebCore

Use Position instead of Range in createMarkupInternal
​https://bugs.webkit.org/show_bug.cgi?id=190107

Reviewed by Darin Adler.

Use two Position's indicating start and end instead of Range in createMarkupInternal and StylizedMarkupAccumulator
in order to support copy & paste across shadow boundaries in the bug 157443. This patch also removes the use of
Range in MarkupAccumulator since all uses of range is via StylizedMarkupAccumulator.

Also renamed createMarkupInternal to serializePreservingVisualAppearanceInternal to match the rename in r236612.

• dom/Position.cpp:

(WebCore::Position::firstNode const): Added.

• dom/Position.h:
• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::MarkupAccumulator): No longer takes Range.
(WebCore::MarkupAccumulator::appendText): Removed the code to truncate string at the boundary points of the range.

• editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator): Made this class non-copyable.

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Now takes and stores two positions.

(WebCore::StyledMarkupAccumulator::appendText): Use textContentRespectingRange in the case annotation is disabled
instead of calling to MarkupAccumulator::appendText, which no longer respects boundary offsets.

(WebCore::StyledMarkupAccumulator::renderedTextRespectingRange): Renamed from renderedText. Updated to respect
boundary offsets defined by m_start and m_end Positions instead of m_range Range.

(WebCore::StyledMarkupAccumulator::textContentRespectingRange): Renamed from stringValueForRange. Ditto.

(WebCore::StyledMarkupAccumulator::serializeNodes): Now computes startNode and pastEnd nodes from start and end
Positions. Note that the end position is always the next node in the tree order for a character node
and computeNodeAfterPosition returns nullptr for a character data.

(WebCore::highestAncestorToWrapMarkup): Now takes two positions instead of a range.

(WebCore::serializePreservingVisualAppearanceInternal): Renamed from createMarkupInternal. Removed the obsolete
comments which were added for DOMRange in WebKitLegacy.

(WebCore::serializePreservingVisualAppearance):

(WebCore::sanitizedMarkupForFragmentInDocument): Create positions instead of a range to pass to
serializePreservingVisualAppearanceInternal.

(WebCore::serializeFragment):

• editing/markup.h:
• page/PageSerializer.cpp:

(WebCore::PageSerializer::SerializerMarkupAccumulator): Removed the unnecessary WebCore namespace qualifier.

3:07 PM Changeset in webkit [236648] by commit-queue@webkit.org

• 8 edits in trunk

AudioNode.connect should return passed destination node
​https://bugs.webkit.org/show_bug.cgi?id=188834

Patch by Walker Henderson <​wjahenderson@gmail.com> on 2018-09-30
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt:

Source/WebCore:

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect): Deleted.

• Modules/webaudio/AudioBasicInspectorNode.h:
• Modules/webaudio/AudioNode.cpp:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/AudioNode.idl:

11:18 AM Changeset in webkit [236647] by Caio Lima

• 7 edits in trunk

[BigInt] BigInt.proptotype.toString is broken when radix is power of 2
​https://bugs.webkit.org/show_bug.cgi?id=190033

Reviewed by Yusuke Suzuki.

JSTests:

• stress/big-int-to-string.js:

Source/JavaScriptCore:

The implementation of JSBigInt::toStringToGeneric doesn't handle power
of 2 radix when JSBigInt length is >= 2. To handle such cases, we
implemented JSBigInt::toStringBasePowerOfTwo that follows the
algorithm that groups bits using mask of (2 ^{n) - 1 to extract every
digit.}

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::toString):
(JSC::JSBigInt::toStringBasePowerOfTwo):

• runtime/JSBigInt.h:

Source/WTF:

• wtf/MathExtras.h:

(WTF::ctz32):

7:32 AM Changeset in webkit [236646] by eric.carlson@apple.com

• 19 edits in trunk

[MediaStream] Clean up RealtimeMediaSource settings change handling
​https://bugs.webkit.org/show_bug.cgi?id=189998
<rdar://problem/44797884>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, updated webrtc/video-disabled-black.html.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::Source):
(WebCore::CanvasCaptureMediaStreamTrack::Source::settings):
(WebCore::CanvasCaptureMediaStreamTrack::Source::settingsDidChange):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasResized):

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
• platform/mediastream/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
(WebCore::RealtimeIncomingVideoSource::settings):
(WebCore::RealtimeIncomingVideoSource::settingsDidChange):

• platform/mediastream/RealtimeIncomingVideoSource.h:
• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::settingsDidChange):
(WebCore::RealtimeMediaSource::notifySettingsDidChangeObservers):
(WebCore::RealtimeMediaSource::setSize):
(WebCore::RealtimeMediaSource::setFrameRate):
(WebCore::RealtimeMediaSource::setAspectRatio):
(WebCore::RealtimeMediaSource::setFacingMode):
(WebCore::RealtimeMediaSource::setVolume):
(WebCore::RealtimeMediaSource::setSampleRate):
(WebCore::RealtimeMediaSource::setSampleSize):
(WebCore::RealtimeMediaSource::setEchoCancellation):

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSource::settingsDidChange):

• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoCaptureSource::settingsDidChange):

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::settingsDidChange):

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::settingsDidChange):

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::settingsDidChange):

• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::processNewSample):

• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::settingsDidChange):

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::settingsDidChange):

Source/WebKit:

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::Source::setSettings):

LayoutTests:

• webrtc/video-disabled-black.html:

12:02 AM Changeset in webkit [236645] by eric.carlson@apple.com

• 26 edits
  2 adds in trunk/Source

[MediaStream] Use display-specific capture factories
​https://bugs.webkit.org/show_bug.cgi?id=190043
<rdar://problem/44834412>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, no change in functionality.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::AudioCaptureFactory::~AudioCaptureFactory): Deleted.
(WebCore::RealtimeMediaSource::VideoCaptureFactory::~VideoCaptureFactory): Deleted.

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::createMediaStream):
(WebCore::RealtimeMediaSourceCenter::getDisplayMediaDevices):

• platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):

• platform/mediastream/RealtimeMediaSourceFactory.cpp: Added.

(WebCore::SingleSourceFactory::setActiveSource):
(WebCore::SingleSourceFactory::unsetActiveSource):

• platform/mediastream/RealtimeMediaSourceFactory.h: Added.

(WebCore::SingleSourceFactory::activeSource):
(WebCore::VideoCaptureFactory::setVideoCapturePageState):
(WebCore::DisplayCaptureFactory::setDisplayCapturePageState):

• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::libWebRTCVideoCaptureSourceFactory):
(WebCore::libWebRTCDisplayCaptureSourceFactory):
(WebCore::GStreamerVideoCaptureSource::factory):
(WebCore::GStreamerVideoCaptureSource::displayFactory):

• platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:

(WebCore::RealtimeMediaSourceCenterLibWebRTC::audioCaptureSourceFactory):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::audioFactory):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::videoFactory):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::displayCaptureFactory):

• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::setupCaptureSession):

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::factory):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::videoCaptureSourceFactory):
(WebCore::RealtimeMediaSourceCenterMac::displayCaptureSourceFactory):
(WebCore::RealtimeMediaSourceCenterMac::audioCaptureSourceFactory):
(WebCore::RealtimeMediaSourceCenterMac::audioFactory):
(WebCore::RealtimeMediaSourceCenterMac::videoFactory):
(WebCore::RealtimeMediaSourceCenterMac::displayCaptureFactory):

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):
(): Deleted.
(WebCore::mockAudioCaptureSourceFactory): Deleted.
(WebCore::MockRealtimeAudioSource::factory): Deleted.

• platform/mock/MockRealtimeAudioSource.h:
• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeVideoSourceFactory::setVideoCapturePageState):
(WebCore::MockRealtimeMediaSourceCenter::audioFactory):
(WebCore::MockRealtimeMediaSourceCenter::videoFactory):
(WebCore::MockRealtimeMediaSourceCenter::displayCaptureFactory):

• platform/mock/MockRealtimeMediaSourceCenter.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(): Deleted.
(WebCore::MockRealtimeVideoSourceFactory::setVideoCapturePageState): Deleted.
(WebCore::mockVideoCaptureSourceFactory): Deleted.
(WebCore::MockRealtimeVideoSource::factory): Deleted.

• platform/mock/MockRealtimeVideoSource.h:

Source/WebKit:

• WebProcess/cocoa/UserMediaCaptureManager.h: