Timeline

Oct 17, 2018:

9:35 PM Changeset in webkit [237247] by bshafiei@apple.com

• 3 edits in tags/Safari-607.1.11/Source/WebKitLegacy/mac

Revert r237137. rdar://problem/45361541

9:28 PM Changeset in webkit [237246] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.11

Tag Safari-607.1.11.

8:48 PM Changeset in webkit [237245] by Wenson Hsieh

• 57 edits
  16 copies
  3 moves
  60 adds
  1 delete in trunk

Enable the datalist element by default on iOS and macOS
​https://bugs.webkit.org/show_bug.cgi?id=190594
<rdar://problem/45281159>

Reviewed by Ryosuke Niwa and Tim Horton.

LayoutTests/imported/w3c:

Rebaseline some web platform tests.

• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
• web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
• web-platform-tests/html/semantics/forms/the-datalist-element/datalistoptions-expected.txt:
• web-platform-tests/html/semantics/forms/the-input-element/hidden-expected.txt:
• web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
• web-platform-tests/html/semantics/forms/the-input-element/text-expected.txt:
• web-platform-tests/shadow-dom/input-element-list-expected.txt:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rebaselined existing layout tests.

• Configurations/FeatureDefines.xcconfig:
• bindings/js/WebCoreBuiltinNames.h:
• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

• css/CSSDefaultStyleSheets.h:
• css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectDocumentWrappers):

• css/html.css:

Remove color input and datalist style rules from the default UA stylesheet.

(input[type="color"]::-webkit-color-swatch-wrapper): Deleted.

• html/HTMLDataListElement.idl:

Make HTMLDataListElement runtime-enabled.

• html/HTMLTagNames.in:
• html/RangeInputType.cpp:

Make a slight adjustment here so that inputs of type range respect the list attribute. Fixes a few layout tests
that add a datalist to an input of type range. See <​https://bugs.webkit.org/show_bug.cgi?id=190613> for more
details.

(WebCore::RangeInputType::shouldRespectListAttribute):

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldRespectListAttribute):

• page/RuntimeEnabledFeatures.h:

Add a runtime-enabled feature for the datalist element. Additionally, make the runtime-enabled feature for input
type color false by default, so that it's off in WebKitLegacy.

(WebCore::RuntimeEnabledFeatures::dataListElementEnabled const):
(WebCore::RuntimeEnabledFeatures::setDataListElementEnabled):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::colorInputStyleSheet const):

Add new style-sheet hooks for datalist and input type color, so that style rules for color inputs and datalists
can be added at runtime only if the feature is enabled. This ensures that in WebKitLegacy (or other ports where
either or both elements are disabled), we don't still apply rules for datalist and input[type="color"]. Notably,
this allows fallback content inside datalist elements to still work in WebKitLegacy (which would otherwise be
hidden when using the default stylesheet since display: none is applied to datalist by default). This also
prevents inputs of type color from having a smaller size, no outline, and the appearance of a color well on
macOS.

(WebCore::RenderTheme::dataListStyleSheet const):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::platformColorInputStyleSheet const):

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformColorInputStyleSheet const):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Platform/spi/ios/UIKitSPI.h:

Add SPI to UITextSuggestion.

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.h:
• UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(-[WKDataListSuggestionCell setText:]):
(-[WKDataListSuggestionTable initWithElementRect:]):

Fix the 32-bit macOS build with ENABLE(DATALIST_ELEMENT).

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• TestExpectations:

Mark a couple of datalist tests as failures, with corresponding Bugzilla links.

• fast/forms/datalist/datalist-fallback-content-expected.html:
• fast/forms/datalist/datalist-fallback-content.html:

Refactor this ref test. This was checking that a text input field with an associated datalist with fallback
content looks identical to an text input field without a datalist, but this simply isn't the case with our
current implementation due to the presence of the list button. Instead, add a div to cover the list button in
both cases, and further augment this test to check that inputs of type color behave the same.

• fast/forms/datalist/range-snap-to-datalist-expected.txt: Added.

Add missing expectations for this test that were never checked in. Since sliderTickSnappingThreshold simply
returns 0, this test behaves as expected, though behavior here may change when we add a make the "snapping
threshold" nonzero.

• fast/forms/datalist/validity-assertion-inserting-into-datalist-expected.txt: Renamed from LayoutTests/fast/forms/validity-assertion-inserting-into-datalist-expected.txt.
• fast/forms/datalist/validity-assertion-inserting-into-datalist.html: Renamed from LayoutTests/fast/forms/validity-assertion-inserting-into-datalist.html.
• fast/selectors/read-only-read-write-input-basics-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/ios-simulator/fast/forms/datalist/datalist-searchinput-appearance-expected.txt: Added.
• platform/ios-simulator/fast/forms/datalist/datalist-textinput-appearance-expected.txt: Added.

Add missing expectations.

• platform/ios-wk1/TestExpectations:

Don't run datalist tests in WebKitLegacy by marking them as [ WontFix ].

• platform/ios-wk2/accessibility/roles-exposed-expected.txt: Added.
• platform/ios-wk2/fast/borders/empty-outline-border-assert-expected.txt: Added.
• platform/ios-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
• platform/ios-wk2/fast/forms/label/labelable-elements-expected.txt: Added.
• platform/ios-wk2/fast/forms/label/readwrite-readonly-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt.
• platform/ios-wk2/fast/selectors/read-only-read-write-input-basics-expected.txt: Copied from LayoutTests/fast/selectors/read-only-read-write-input-basics-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt: Added.
• platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt: Added.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Added.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Added.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/shadow-dom/input-element-list-expected.txt: Added.
• platform/ios-wk2/mathml/presentation/foreign-element-in-token-expected.txt: Added.

Add baselines for WebKit2, where we enable the datalist element and color inputs.

• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:

Don't run datalist tests in WebKitLegacy by marking them as [ WontFix ].

• platform/mac-wk2/accessibility/roles-exposed-expected.txt: Copied from LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt.
• platform/mac-wk2/fast/borders/empty-outline-border-assert-expected.txt: Added.
• platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
• platform/mac-wk2/fast/forms/label/labelable-elements-expected.txt: Added.
• platform/mac-wk2/fast/forms/label/readwrite-readonly-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt.
• platform/mac-wk2/fast/selectors/read-only-read-write-input-basics-expected.txt: Copied from LayoutTests/fast/selectors/read-only-read-write-input-basics-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt: Added.
• platform/mac-wk2/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt: Added.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Added.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Added.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt.
• platform/mac-wk2/imported/w3c/web-platform-tests/shadow-dom/input-element-list-expected.txt: Added.
• platform/mac-wk2/mathml/presentation/foreign-element-in-token-expected.txt: Added.

Add baselines for WebKit2, where we enable the datalist element and color inputs.

• platform/mac/TestExpectations:
• platform/mac/accessibility/roles-exposed-expected.txt:
• platform/mac/fast/selectors/read-only-read-write-input-basics-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:

Re-rebaseline test expectations that involve input type color, now that color inputs are off by default in WebKitLegacy.

• platform/win/TestExpectations:

Remove various datalist test skips and failures on macOS and iOS; ensure that the test failures that are still
present are tracked with links to Bugzilla.

8:18 PM Changeset in webkit [237244] by keith_miller@apple.com

• 3 edits
  1 add in trunk

JSTests:
AI does not clear Phantom allocation nodes.
​https://bugs.webkit.org/show_bug.cgi?id=190694

Reviewed by Saam Barati.

• stress/ftl-ai-filter-phantoms-should-clear-clear-value.js: Added.

(Day):
(DaysInYear):
(TimeInYear):
(TimeFromYear):
(DayFromYear):
(InLeapYear):
(YearFromTime):
(WeekDay):
(DaylightSavingTA):
(GetSecondSundayInMarch):
(TimeInMonth):

Source/JavaScriptCore:
[BigInt] Add ValueSub into DFG
​https://bugs.webkit.org/show_bug.cgi?id=186176

Patch by Caio Lima <Caio Lima> on 2018-10-17
Reviewed by Yusuke Suzuki.

We are introducing in this patch a new node called ValueSub. This node
is necessary due to introduction of BigInt, making subtraction
operations result in non-Number values in some cases. In such case, ValueSub is
responsible to handle Untyped and BigInt operations.
In addition, we are also creating a speculative path when both
operands are BigInt. According to a simple BigInt subtraction microbenchmark,
this represents a speedup of ~1.2x faster.

big-int-simple-sub 14.6427+-0.5652 ^{11.9559+-0.6485} definitely 1.2247x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::addSpeculationMode):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileArithSub):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):

7:47 PM Changeset in webkit [237243] by commit-queue@webkit.org

• 15 edits
  2 adds in trunk

Parse paint() and store paint callbacks for CSS Painting API
​https://bugs.webkit.org/show_bug.cgi?id=190657

Patch by Justin Michaud <Justin Michaud> on 2018-10-17
Reviewed by Dean Jackson.

Source/WebCore:

Implement support for parsing paint() images in css, and store CSS paint callback objects in the paint definition map.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSPaintWorkletGlobalScopeCustom.cpp:

(WebCore::JSCSSPaintWorkletGlobalScope::visitAdditionalChildren):
(WebCore::JSCSSPaintWorkletGlobalScope::registerPaint):

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize const):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::isPending const):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque const):
(WebCore::CSSImageGeneratorValue::loadSubimages):

• css/CSSPaintImageValue.cpp: Added.

(WebCore::CSSPaintImageValue::customCSSText const):

• css/CSSPaintImageValue.h: Added.
• css/CSSPaintWorkletGlobalScope.h:
• css/CSSPaintWorkletGlobalScope.idl:
• css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

(WebCore::CSSValue::isPaintImageValue const):

• css/CSSValueKeywords.in:
• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeCustomPaint):
(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):
(WebCore::CSSPropertyParserHelpers::isGeneratedImage):

• platform/mediastream/mac/RealtimeVideoUtilities.h:

LayoutTests:

• fast/css-custom-paint/basic-expected.txt:
• fast/css-custom-paint/basic.html:

6:14 PM Changeset in webkit [237242] by Caio Lima

• 21 edits
  2 adds in trunk

[BigInt] Add ValueSub into DFG
​https://bugs.webkit.org/show_bug.cgi?id=186176

Reviewed by Yusuke Suzuki.

JSTests:

• stress/big-int-subtraction-jit.js:
• stress/value-sub-big-int-prediction-propagation.js: Added.
• stress/value-sub-big-int-untyped.js: Added.

Source/JavaScriptCore:

We are introducing in this patch a new node called ValueSub. This node
is necessary due to introduction of BigInt, making subtraction
operations result in non-Number values in some cases. In such case, ValueSub is
responsible to handle Untyped and BigInt operations.
In addition, we are also creating a speculative path when both
operands are BigInt. According to a simple BigInt subtraction microbenchmark,
this represents a speedup of ~1.2x faster.

big-int-simple-sub 14.6427+-0.5652 ^{11.9559+-0.6485} definitely 1.2247x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::addSpeculationMode):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileArithSub):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):

4:56 PM Changeset in webkit [237241] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

The parser should not emit a ApplyFunctionCallDotNode for Reflect.apply.
​https://bugs.webkit.org/show_bug.cgi?id=190671
<rdar://problem/45201145>

Reviewed by Saam Barati.

The bytecode generator does not currently know how to inline Reflect.apply (see
​https://bugs.webkit.org/show_bug.cgi?id=190668). Hence, it's a waste of time to
emit the ApplyFunctionCallDotNode since the function check against Function.apply
that it will generate will always fail.

Also fixed CallVariant::dump() to be able to handle dumping a non-executable
callee. Reflect.apply used to trip this up. Any object with an apply property
invoked as a function could also trip this up. This is now fixed.

• bytecode/CallVariant.cpp:

(JSC::CallVariant::dump const):

• bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::makeFunctionCallNode):

4:54 PM Changeset in webkit [237240] by Ryan Haddad

• 3 edits in trunk/Source/WebCore

[MediaStream] Consolidate all image conversion and resizing into one class
​https://bugs.webkit.org/show_bug.cgi?id=190519
<rdar://problem/45224307>

Try to fix the iOSMac build after r237236.

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-10-17

• platform/graphics/cv/ImageTransferSessionVT.h:
• platform/graphics/cv/ImageTransferSessionVT.mm:

4:30 PM Changeset in webkit [237239] by Justin Fan

• 7 edits
  17 adds in trunk

[WebGPU] Implement WebGPU bindings up through WebGPUDevice creation
​https://bugs.webkit.org/show_bug.cgi?id=190653

Reviewed by Dean Jackson.

Source/WebCore:

Test: webgpu/webgpu-enabled.html

Add WebGPU Sketch bindings for window.webgpu, WebGPUAdapter, WebGPUAdapterDescriptor,
and WebGPUDevice creation. Based off IDL commit version b6c61ee.
​https://github.com/gpuweb/gpuweb/blob/master/design/sketch.webidl

• CMakeLists.txt:
• DerivedSources.make:
• Modules/webgpu/DOMWindowWebGPU.cpp: Added.

(WebCore::DOMWindowWebGPU::DOMWindowWebGPU):
(WebCore::DOMWindowWebGPU::supplementName):
(WebCore::DOMWindowWebGPU::from):
(WebCore::DOMWindowWebGPU::webgpu):
(WebCore::DOMWindowWebGPU::webgpu const):

• Modules/webgpu/DOMWindowWebGPU.h: Added.
• Modules/webgpu/DOMWindowWebGPU.idl: Added.
• Modules/webgpu/WebGPU.cpp: Added.

(WebCore::WebGPU::create):
(WebCore::WebGPU::requestAdapter const):

• Modules/webgpu/WebGPU.h: Added.
• Modules/webgpu/WebGPU.idl: Added.
• Modules/webgpu/WebGPUAdapter.cpp: Added.

(WebCore::WebGPUAdapter::create):
(WebCore::WebGPUAdapter::WebGPUAdapter):
(WebCore::WebGPUAdapter::createDevice):

• Modules/webgpu/WebGPUAdapter.h: Added.
• Modules/webgpu/WebGPUAdapter.idl: Added.
• Modules/webgpu/WebGPUAdapterDescriptor.h: Added.
• Modules/webgpu/WebGPUAdapterDescriptor.idl: Added.
• Modules/webgpu/WebGPUDevice.cpp: Added.

(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::WebGPUDevice):

• Modules/webgpu/WebGPUDevice.h: Added.

(WebCore::WebGPUDevice::adapter const):

• Modules/webgpu/WebGPUDevice.idl: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Small test to validate creation of a WebGPUDevice when WebGPU is enabled.

• webgpu/webgpu-enabled.html: Added.

4:10 PM Changeset in webkit [237238] by aestes@apple.com

• 6 edits
  2 adds in trunk

[Apple Pay] Increment the API version to 5
​https://bugs.webkit.org/show_bug.cgi?id=190686
<rdar://problem/45348523>

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePaySessionV5.html

• testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::supportsVersion):

Source/WebKit:

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::supportsVersion):

LayoutTests:

• http/tests/ssl/applepay/ApplePaySessionV5-expected.txt: Added.
• http/tests/ssl/applepay/ApplePaySessionV5.html: Added.
• platform/mac-wk2/TestExpectations:

4:06 PM Changeset in webkit [237237] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Unreviewed, rolling out r237208.
​https://bugs.webkit.org/show_bug.cgi?id=190691

Caused the API test that was changed to failure continuously
(Requested by Truitt on #webkit).

Reverted changeset:

"[Media] Use nanoseconds as MaximumTimeScale"
​https://bugs.webkit.org/show_bug.cgi?id=190631
​https://trac.webkit.org/changeset/237208

2:55 PM Changeset in webkit [237236] by eric.carlson@apple.com

• 23 edits
  2 adds
  2 deletes in trunk/Source/WebCore

[MediaStream] Consolidate all image conversion and resizing into one class
​https://bugs.webkit.org/show_bug.cgi?id=190519
<rdar://problem/45224307>

Reviewed by Youenn Fablet.

No new tests, no functional change.

• SourcesCocoa.txt: Add ImageTransferSessionVT.
• WebCore.xcodeproj/project.pbxproj: Ditto.

• platform/MediaSample.h:

(WebCore::MediaSample::videoPixelFormat const): New.

• platform/cocoa/VideoToolboxSoftLink.cpp: Add new kVTPixelTransferProperty keys.
• platform/cocoa/VideoToolboxSoftLink.h:

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:

(WebCore::MediaSampleAVFObjC::create): Remove unimplemented variant.

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::videoPixelFormat const): New.

• platform/graphics/cv/ImageTransferSessionVT.h: Added.

(WebCore::ImageTransferSessionVT::create):

• platform/graphics/cv/ImageTransferSessionVT.mm: Added.

(WebCore::ImageTransferSessionVT::ImageTransferSessionVT):
(WebCore::ImageTransferSessionVT::~ImageTransferSessionVT):
(WebCore::ImageTransferSessionVT::setSize):
(WebCore::ImageTransferSessionVT::createPixelBuffer):
(WebCore::ImageTransferSessionVT::createCMSampleBuffer):
(WebCore::roundUpToMacroblockMultiple):
(WebCore::ImageTransferSessionVT::ioSurfacePixelBufferCreationOptions):
(WebCore::ImageTransferSessionVT::createMediaSample):

• platform/graphics/cv/PixelBufferResizer.h: Removed.
• platform/graphics/cv/PixelBufferResizer.mm: Removed.

• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::prefersPreset):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection): Remove
the resizing logic, it is handled by the base class.

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::capabilities):
(WebCore::DisplayCaptureSourceCocoa::settingsDidChange):
(WebCore::DisplayCaptureSourceCocoa::setIntrinsicSize):
(WebCore::DisplayCaptureSourceCocoa::emitFrame): Remove resizing logic, just use a transfer
session to create an image from the capture source native output format.
(WebCore::DisplayCaptureSourceCocoa::sampleBufferFromPixelBuffer): Deleted.
(WebCore::roundUpToMacroblockMultiple): Deleted.
(WebCore::DisplayCaptureSourceCocoa::pixelBufferFromIOSurface): Deleted.

• platform/mediastream/mac/DisplayCaptureSourceCocoa.h:

• platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
• platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer): Use image transfer session.
(WebCore::MockRealtimeVideoSourceMac::CMSampleBufferFromPixelBuffer): Deleted.
(WebCore::MockRealtimeVideoSourceMac::pixelBufferFromCGImage const): Deleted.
(WebCore::MockRealtimeVideoSourceMac::setSizeAndFrameRateWithPreset): Deleted.

• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
• platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream):
(WebCore::ScreenDisplayCaptureSourceMac::generateFrame): Return the IOSurface directly.

• platform/mediastream/mac/WindowDisplayCaptureSourceMac.h:
• platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm:

(WebCore::WindowDisplayCaptureSourceMac::generateFrame): Return the CGImage directly.
(WebCore::WindowDisplayCaptureSourceMac::pixelBufferFromCGImage): Deleted.

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::capabilities): Only the camera supports device ID.
(WebCore::MockRealtimeVideoSource::settings): Ditto.

2:09 PM Changeset in webkit [237235] by bshafiei@apple.com

• 7 edits in trunk/Source

Versioning.

2:06 PM Changeset in webkit [237234] by eric.carlson@apple.com

• 9 edits in trunk/Source/WebCore

[MediaStream] Clean up capture source factory management
​https://bugs.webkit.org/show_bug.cgi?id=190502
<rdar://problem/45212447>

Reviewed by Youenn Fablet.

No new tests, no functional change.

• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
(WebCore::RealtimeMediaSourceCenter::audioFactory):
(WebCore::RealtimeMediaSourceCenter::setVideoFactory):
(WebCore::RealtimeMediaSourceCenter::unsetVideoFactory):
(WebCore::RealtimeMediaSourceCenter::videoFactory):
(WebCore::RealtimeMediaSourceCenter::setDisplayCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::unsetDisplayCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::displayCaptureFactory):

• platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory): Deleted.
(): Deleted.

• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:

(WebCore::RealtimeMediaSourceCenterLibWebRTC::audioFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::videoFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::displayCaptureFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterLibWebRTC::audioCaptureSourceFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterLibWebRTC::audioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterLibWebRTC::videoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterLibWebRTC::displayCaptureFactory): Deleted.

• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::audioFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterMac::videoFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterMac::displayCaptureFactoryPrivate):
(WebCore::RealtimeMediaSourceCenterMac::videoCaptureSourceFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::displayCaptureSourceFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::audioCaptureSourceFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::audioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::videoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::displayCaptureFactory): Deleted.

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::audioFactoryPrivate):
(WebCore::MockRealtimeMediaSourceCenter::videoFactoryPrivate):
(WebCore::MockRealtimeMediaSourceCenter::displayCaptureFactoryPrivate):
(WebCore::MockRealtimeMediaSourceCenter::audioFactory): Deleted.
(WebCore::MockRealtimeMediaSourceCenter::videoFactory): Deleted.
(WebCore::MockRealtimeMediaSourceCenter::displayCaptureFactory): Deleted.

• platform/mock/MockRealtimeMediaSourceCenter.h:

1:37 PM Changeset in webkit [237233] by achristensen@apple.com

• 23 edits in trunk/Source

BackForwardClient needs to be able to support UIProcess-only back/forward lists
​https://bugs.webkit.org/show_bug.cgi?id=190675

Reviewed by Chris Dumez.

Source/WebCore:

Return a RefPtr<HistoryItem> instead of a HistoryItem so that we will be able to return a
HistoryItem that has been created instead of a pointer to a HistoryItem that is owned by something else.
Also use unsigned for the back and forward list counts because they can never be negative.

• history/BackForwardClient.h:
• history/BackForwardController.cpp:

(WebCore::BackForwardController::backItem):
(WebCore::BackForwardController::currentItem):
(WebCore::BackForwardController::forwardItem):
(WebCore::BackForwardController::canGoBackOrForward const):
(WebCore::BackForwardController::goBackOrForward):
(WebCore::BackForwardController::goBack):
(WebCore::BackForwardController::goForward):
(WebCore::BackForwardController::count const):
(WebCore::BackForwardController::backCount const):
(WebCore::BackForwardController::forwardCount const):
(WebCore::BackForwardController::itemAtIndex):

• history/BackForwardController.h:

(WebCore::BackForwardController::backItem): Deleted.
(WebCore::BackForwardController::currentItem): Deleted.
(WebCore::BackForwardController::forwardItem): Deleted.

• loader/EmptyClients.cpp:
• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleHistoryNavigation):

Source/WebKit:

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::itemAtIndex const):
(WebKit::WebBackForwardList::backListCount const):
(WebKit::WebBackForwardList::forwardListCount const):

• UIProcess/WebBackForwardList.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::backForwardBackListCount):
(WebKit::WebPageProxy::backForwardForwardListCount):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount const):
(WebKit::WebBackForwardListProxy::forwardListCount const):

• WebProcess/WebPage/WebBackForwardListProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dumpHistoryForTesting):

Source/WebKitLegacy/mac:

• History/BackForwardList.h:
• History/BackForwardList.mm:

(BackForwardList::backItem):
(BackForwardList::currentItem):
(BackForwardList::forwardItem):
(BackForwardList::backListCount const):
(BackForwardList::forwardListCount const):
(BackForwardList::itemAtIndex):

• History/WebBackForwardList.mm:

(-[WebBackForwardList backItem]):
(-[WebBackForwardList currentItem]):
(-[WebBackForwardList forwardItem]):
(-[WebBackForwardList itemAtIndex:]):

Source/WebKitLegacy/win:

• BackForwardList.cpp:

(BackForwardList::backItem):
(BackForwardList::currentItem):
(BackForwardList::forwardItem):
(BackForwardList::backListCount const):
(BackForwardList::forwardListCount const):
(BackForwardList::itemAtIndex):

• BackForwardList.h:

12:46 PM Changeset in webkit [237232] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Quickly Open to line/column does should have caret indicating where the position is
​https://bugs.webkit.org/show_bug.cgi?id=190643

Reviewed by Matt Baker.

• UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.set selectedTextRange):
(WI.TextEditor.prototype.revealPosition):
Ensure that CodeMirror is focused before attempting to setSelection.
Drive-by: allow selections past the "end" of the line (since there is a \n or \r).

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.dialogWasDismissedWithRepresentedObject):
Remove the extra focus call after dismissing the WI.GoToLineDialog since it is now
handled by WI.TextEditor via revealPosition.

12:06 PM Changeset in webkit [237231] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[Web Animations] Do not create a DocumentTimeline to suspend or resume animations
​https://bugs.webkit.org/show_bug.cgi?id=190660

Patch by Antoine Quint <Antoine Quint> on 2018-10-17
Reviewed by Dean Jackson.

We check that there is an existing timeline before trying to suspend or resume its animations, otherwise
we're creating a DocumentTimeline when nothing requires for it to exist. We also have to check that we
suspend animations when a DocumentTimeline is created while the page is not visible.

No new tests as there is no change in behavior here.

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):

• dom/Document.cpp:

(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::resume):

• page/Frame.cpp:

(WebCore::Frame::clearTimers):

• page/Page.cpp:

(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

12:00 PM Changeset in webkit [237230] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Tiling CSS gradients is slow
​https://bugs.webkit.org/show_bug.cgi?id=190615

Reviewed by Tim Horton.

Painting blocks the main thread on CG rendering queue to make a copy of the backing store.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):

Also use sinkIntoImage for bitmap image pattern drawing.

• platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern):

Sink the gradient into an Image after generating it. Unlike ImageBuffer, painting it doesn't involve inefficient copies.
Previous isCompatibleWithContext test is replaced with an equivalent scale factor test.

• platform/graphics/GradientImage.h:

11:31 AM Changeset in webkit [237229] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r237024.
​https://bugs.webkit.org/show_bug.cgi?id=190673

"It regressed ARES6 on iOS devices by 4-8%" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"Increase executable memory pool from 64MB to 128MB for ARM64"
​https://bugs.webkit.org/show_bug.cgi?id=190453
​https://trac.webkit.org/changeset/237024

11:11 AM Changeset in webkit [237228] by Chris Dumez

• 14 edits in trunk/Source/WebCore

Update more DOMWindow getters to return references instead of raw pointers
​https://bugs.webkit.org/show_bug.cgi?id=190654

Reviewed by Youenn Fablet.

Update more DOMWindow getters to return references instead of raw pointers, since they
can no longer return null after recent refactoring.

• Modules/gamepad/GamepadManager.cpp:

(WebCore::navigatorGamepadFromDOMWindow):

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::heapSnapshot):

• dom/Document.cpp:

(WebCore::Document::location const):
(WebCore::Document::dispatchPopstateEvent):

• dom/Event.cpp:

(WebCore::Event::timeStampForBindings const):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto const):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance const):
(WebCore::DOMWindow::nowTimestamp const):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::visualViewport):
(WebCore::DOMWindow::styleMedia):

• page/DOMWindow.h:
• page/FrameView.cpp:

(WebCore::FrameView::updateLayoutViewport):

• page/History.cpp:

(WebCore::History::stateObjectAdded):

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::createTimestamp const):

• page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::PerformanceObserver):

• platform/cocoa/VideoFullscreenModelVideoElement.mm:

(WebCore::VideoFullscreenModelVideoElement::requestFullscreenMode):

11:07 AM Changeset in webkit [237227] by youenn@apple.com

• 1 edit
  2 deletes in trunk/Source/ThirdParty/libwebrtc

Remove unneeded .rej files from libwebrtc
​https://bugs.webkit.org/show_bug.cgi?id=190670

Reviewed by Mark Lam.

• Source/third_party/boringssl/src/.github/PULL_REQUEST_TEMPLATE.rej: Removed.
• Source/third_party/boringssl/src/third_party/googletest/.gitignore.rej: Removed.

10:54 AM Changeset in webkit [237226] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

REGRESSION (r237075): webrtc/video-replace-muted-track.html is Crashing
​https://bugs.webkit.org/show_bug.cgi?id=190646

Reviewed by Eric Carlson.

Do not use VCP pixel buffer pool at all.
RealtimeOutgoingVideoSource makes sure to send the frame in the right format.
Tested by ensuring test no longer crashes.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionIfNeededWithFrame:]):
(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

10:52 AM Changeset in webkit [237225] by Chris Fleizach

• 6 edits
  2 adds in trunk

AX: Certain tags should identify their context to iOS API
​https://bugs.webkit.org/show_bug.cgi?id=190622
<rdar://problem/45308194>

Reviewed by Zalan Bujtas.

Source/WebCore:

Convey the semantic meaning of <code> tag to the iOS API so VoiceOver can make use of it.

Tests: accessibility/ios-simulator/text-context-attributes.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityTextualContext]):
(AXAttributeStringSetStyle):

Tools:

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::stringAttributeValue):

• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

• accessibility/ios-simulator/text-context-attributes.html: Added.
• accessibility/ios-simulator/text-context-attributes-expcted.txt: Added.

10:51 AM Changeset in webkit [237224] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Remove unused code from RealtimeOutgoingVideoSourceCocoa
​https://bugs.webkit.org/show_bug.cgi?id=190666

Reviewed by Eric Carlson.

No change of behavior, removed no longer used code.

• platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

(): Deleted.

10:50 AM Changeset in webkit [237223] by yusukesuzuki@slowstart.org

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Use WTF::Function instead of std::function
​https://bugs.webkit.org/show_bug.cgi?id=190665

Reviewed by Keith Miller.

We should use WTF::Function as much as possible. It allocates memory from bmalloc instead of standard malloc.

• runtime/JSNativeStdFunction.h:

10:49 AM Changeset in webkit [237222] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Remove debug logging from generate_offsets_extractor.rb
​https://bugs.webkit.org/show_bug.cgi?id=190667

Reviewed by Mark Lam.

• offlineasm/generate_offset_extractor.rb:

10:20 AM Changeset in webkit [237221] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix windows build.

• offlineasm/generate_offset_extractor.rb:

8:48 AM Changeset in webkit [237220] by yusukesuzuki@slowstart.org

• 8 edits in trunk/Source/JavaScriptCore

[JSC] More aggressively use constexpr in LowLevelInterpreter.asm for constant values
​https://bugs.webkit.org/show_bug.cgi?id=190659

Reviewed by Keith Miller.

Asking the actual constant value to the JSC binary is always the best way to get the correct value.
The value is correctly updated once the original value is changed. We would like to encourage this
approach more in LowLevelInterpreter.asm.

This patch expands the coverage of this approach. We make ObservedType, ResultType, and ArithProfile
constexpr-friendly to produce the magic value used in LowLevelInterpreter.asm at compiling time.
This change allows us to easily extend ArithProfile in the future to adopt BigInt efficiently.

We additionally use constexpr for several constant values in LowLevelInterpreter.asm.

• assembler/MaxFrameExtentForSlowPathCall.h:

Use this value in LowLevelInterpreter.asm directly. We also make them constexpr. And we add CPU(ARM64E).

• bytecode/ArithProfile.h:

(JSC::ObservedType::ObservedType):
(JSC::ObservedType::sawInt32 const):
(JSC::ObservedType::isOnlyInt32 const):
(JSC::ObservedType::sawNumber const):
(JSC::ObservedType::isOnlyNumber const):
(JSC::ObservedType::sawNonNumber const):
(JSC::ObservedType::isOnlyNonNumber const):
(JSC::ObservedType::isEmpty const):
(JSC::ObservedType::bits const):
(JSC::ObservedType::withInt32 const):
(JSC::ObservedType::withNumber const):
(JSC::ObservedType::withNonNumber const):
(JSC::ObservedType::withoutNonNumber const):
(JSC::ObservedType::operator== const):
(JSC::ArithProfile::ArithProfile):
(JSC::ArithProfile::fromInt):
(JSC::ArithProfile::observedUnaryInt):
(JSC::ArithProfile::observedUnaryNumber):
(JSC::ArithProfile::observedBinaryIntInt):
(JSC::ArithProfile::observedBinaryNumberInt):
(JSC::ArithProfile::observedBinaryIntNumber):
(JSC::ArithProfile::observedBinaryNumberNumber):
(JSC::ArithProfile::lhsObservedType const):
(JSC::ArithProfile::rhsObservedType const):
(JSC::ArithProfile::bits const):
Make ObservedType and ArithProfile constexpr-friendly.

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):
Make several ASSERTs to STATIC_ASSERTs. Remove some unnecessary checks.

• llint/LLIntOffsetsExtractor.cpp:
• llint/LowLevelInterpreter.asm:

Remove unused constant values. Use constexpr more and more aggressively.

• parser/ResultType.h:

(JSC::ResultType::ResultType):
(JSC::ResultType::isInt32 const):
(JSC::ResultType::definitelyIsNumber const):
(JSC::ResultType::definitelyIsString const):
(JSC::ResultType::definitelyIsBoolean const):
(JSC::ResultType::definitelyIsBigInt const):
(JSC::ResultType::mightBeNumber const):
(JSC::ResultType::isNotNumber const):
(JSC::ResultType::mightBeBigInt const):
(JSC::ResultType::isNotBigInt const):
(JSC::ResultType::nullType):
(JSC::ResultType::booleanType):
(JSC::ResultType::numberType):
(JSC::ResultType::numberTypeIsInt32):
(JSC::ResultType::stringOrNumberType):
(JSC::ResultType::addResultType):
(JSC::ResultType::stringType):
(JSC::ResultType::bigIntType):
(JSC::ResultType::unknownType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forLogicalOp):
(JSC::ResultType::forBitOp):
(JSC::ResultType::bits const):
Make ResultType constexpr-friendly.

• runtime/JSCJSValue.h:

Use offsetof instead of OBJECT_OFFSETOF. It is OK since EncodedValueDescriptor is POD.
This change makes TagOffset and PayloadOffset macros constexpr-friendly while OBJECT_OFFSETOF
cannot be used in constexpr since it uses reinterpret_cast.

7:10 AM Changeset in webkit [237219] by keith_miller@apple.com

• 8 edits
  2 adds in trunk/Source/JavaScriptCore

Unreviewed revert Fujii's revert in r237214 with new WinCairo build fix.

6:52 AM Changeset in webkit [237218] by ajuma@chromium.org

• 18 edits in trunk

Flaky IntersectionObserver web platform tests involving style updates
​https://bugs.webkit.org/show_bug.cgi?id=189091

Reviewed by Simon Fraser.

Source/WebCore:

Update intersection observations when flushing layers from the WebProcess
to the UIProcess to make the timing of these updates more predictable, and
more consistent with the IntersectionObserver spec, since the spec expects
these updates to happen as part of the "Update the rendering" step in the
HTML EventLoop.

Getting a similar approach to work with WK1 seems to add more complexity than it's
worth, since flushes don't happen for scrolls handled by platform widgets, and
flushes for other invalidations only happen when in compositing mode.

The only remaining timer-driven intersection observation update is for handling
the initial observation on a newly added target, which needs to happen even if
there are no changes triggering a flush.

Tested by the following tests no longer being flaky:

imported/w3c/web-platform-tests/intersection-observer/bounding-box.html
imported/w3c/web-platform-tests/intersection-observer/display-none.html
imported/w3c/web-platform-tests/intersection-observer/containing-block.html

• dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::scheduleForcedIntersectionObservationUpdate):
(WebCore::Document::scheduleIntersectionObservationUpdate): Deleted.

• dom/Document.h:
• page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::viewportContentsChanged):

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::observe):

• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::willDisplayPage):
(WebCore::Page::addDocumentNeedingIntersectionObservationUpdate):
(WebCore::Page::updateIntersectionObservations):
(WebCore::Page::scheduleForcedIntersectionObservationUpdate):

• page/Page.h:

Source/WebKit:

Add a WebPage::willDisplayPage bottleneck that gets called when flushing layers
or, in the non-composited case, when rendering the page into a bitmap.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::updateBackingStoreState):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willDisplayPage):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

LayoutTests:

Remove expectation for tests that are no longer flaky.

Skip IntersectionObserver tests on WK1.

• TestExpectations:
• platform/mac-wk1/TestExpectations:

4:07 AM Changeset in webkit [237217] by cturner@igalia.com

• 3 edits
  1 add in trunk

[EME] Sanity check key ID length in the keyids init data format
​https://bugs.webkit.org/show_bug.cgi?id=190629

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

• web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:

Added new baseline.

Source/WebCore:

Covered by web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html

• Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids): Ensure the decoded key id length
is at least 1 byte and no more than 512 bytes.

4:00 AM Changeset in webkit [237216] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[EME] media/encrypted-media/mock-MediaKeySystemAccess.html crashes in CDM::createInstance
​https://bugs.webkit.org/show_bug.cgi?id=190578

Reviewed by Xabier Rodriguez-Calvar.

• platform/gtk/TestExpectations:

Oct 16, 2018:

9:16 PM Changeset in webkit [237215] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

GetIndexedPropertyStorage can GC.
​https://bugs.webkit.org/show_bug.cgi?id=190625
<rdar://problem/45309366>

Reviewed by Saam Barati.

This is because if the ArrayMode type is String, the DFG and FTL will be emitting
a call to operationResolveRope, and operationResolveRope can GC. This patch
updates doesGC() to reflect this.

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

8:01 PM Changeset in webkit [237214] by Fujii Hironori

• 8 edits
  2 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r237188, r237189, and r237197.

It breaks WinCairo Debug builds and Release LayoutTests

Reverted changesets:

​https://bugs.webkit.org/show_bug.cgi?id=189708
​https://trac.webkit.org/changeset/237188

"Unreviewed, forgot to add untracked files."
​https://trac.webkit.org/changeset/237189

"isASTErroneous in offlineasm should de-macroify before
looking for Errors"
​https://bugs.webkit.org/show_bug.cgi?id=190634
​https://trac.webkit.org/changeset/237197

7:19 PM Changeset in webkit [237213] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Fix xdg-desktop-portal permissions from a sandbox
​https://bugs.webkit.org/show_bug.cgi?id=190619

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-16
Reviewed by Michael Catanzaro.

We have to generate a /.flatpak-info file for xdg-desktop-portal
to properly treat us as a sandboxed application.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::createSealedMemFdWithData):
(WebKit::argsToFd):
(WebKit::XDGDBusProxyLauncher::setPermissions):
(WebKit::createFlatpakInfo):
(WebKit::bubblewrapSpawn):

6:53 PM Changeset in webkit [237212] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌃G to jump to line in CSS file wipes the line
​https://bugs.webkit.org/show_bug.cgi?id=190645

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-16
Reviewed by Devin Rousso.

• UserInterface/Base/Main.js:
• UserInterface/Views/Dialog.js:

(WI.Dialog.prototype.dismiss):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.dialogWasDismissed): Deleted.
Rename the handler when dismissing a dialog with a value so that
it is clear this is only on a successful value and not an invalid value.
Dialog now only calls this delegate with a valid value. This addresses
exceptions seen when the GoToLineDialog was dimissed via Escape and
an unexpected null value was being handled in the delegate.

• UserInterface/Views/GoToLineDialog.js:

(WI.GoToLineDialog.prototype._handleKeydownEvent):

• UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._handleKeydownEvent):
Prevent default on the event whenever we dismiss the dialog.
Without this, the key event was also being sent to the editor.
In this case, that meant an "Enter" key was replacing the new
selection in the TextEditor with a newline!

5:27 PM Changeset in webkit [237211] by Chris Dumez

• 4 edits
  2 adds in trunk

Regression(r236795) Check boxes are sometimes checked when they should not be
​https://bugs.webkit.org/show_bug.cgi?id=190651
<rdar://problem/45319934>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r236795 mistakenly dropped the statement resetting m_reflectsCheckedAttribute to true
in HTMLInputElement::parseAttribute() because it looked like a no-op given that we
made sure it was true a couple of line above. However, I overlooked that calling
HTMLInputElement::setChecked() sets m_reflectsCheckedAttribute to false.

This patch thus re-introduces the statement. It also renames m_reflectsCheckedAttribute
to m_dirtyCheckednessFlag and reverses its value in order to match the specification
more closely:

• ​https://html.spec.whatwg.org/#concept-input-checked-dirty-flag

Test: fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):

• html/HTMLInputElement.h:

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag-expected.txt: Added.
• fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html: Added.

4:59 PM Changeset in webkit [237210] by sihui_liu@apple.com

• 14 edits in trunk

Add a switch for Web SQL
​https://bugs.webkit.org/show_bug.cgi?id=190271

Reviewed by Ryosuke Niwa.

Source/WebCore:

Web SQL is still enabled by default.

• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/SQLError.idl:
• Modules/webdatabase/SQLResultSet.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• bindings/js/WebCoreBuiltinNames.h:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebSQLDisabled):
(WebCore::RuntimeEnabledFeatures::webSQLEnabled const):

Source/WebKit:

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebSQLDisabled):
(WKPreferencesGetWebSQLDisabled):

• UIProcess/API/C/WKPreferencesRef.h:

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

4:43 PM Changeset in webkit [237209] by Chris Dumez

• 11 edits in trunk

window.performance should not become null after the window loses its browsing context
​https://bugs.webkit.org/show_bug.cgi?id=190636

Reviewed by Ryosuke Niwa.

Source/WebCore:

window.performance should not become null after the window loses its browsing context. This
WebKit behavior does not match the HTML specification nor the behavior of other browsers.

Also note that the attribute is not nullable in the specification:

• ​https://www.w3.org/TR/navigation-timing/#sec-window.performance-attribute

No new tests, updated existing test.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::performance const):

• page/Performance.cpp:

(WebCore::Performance::Performance):

• page/Performance.h:
• platform/GenericTaskQueue.h:

(WebCore::TaskDispatcher::TaskDispatcher):
(WebCore::TaskDispatcher::postTask):
(WebCore::GenericTaskQueue::GenericTaskQueue):
(WebCore::GenericTaskQueue::isClosed const):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

LayoutTests:

Extend layout test coverage.

• http/tests/dom/cross-origin-detached-window-properties-expected.txt:
• http/tests/dom/cross-origin-detached-window-properties.html:
• http/tests/dom/same-origin-detached-window-properties-expected.txt:
• http/tests/dom/same-origin-detached-window-properties.html:

4:18 PM Changeset in webkit [237208] by aboya@igalia.com

• 2 edits in trunk/Source/WTF

[Media] Use nanoseconds as MaximumTimeScale
​https://bugs.webkit.org/show_bug.cgi?id=190631

1e9 is a much more useful timescale than the previous one 2^{31-1.
Unlike 2}31-1, which is a prime number, nanosecond scale is pretty
common among some formats like WebM and frameworks like GStreamer
where base 10 timescale is common... and it's those big timescales the
ones that are usually scaled up to MaximumTimeScale.

Reviewed by Jer Noble.

• wtf/MediaTime.cpp:

4:12 PM Changeset in webkit [237207] by jer.noble@apple.com

• 6 edits
  1 add in trunk/Source

Refactoring: Convert HTMLMediaElement::scheduleDelayedAction() to individually schedulable & cancelable tasks
​https://bugs.webkit.org/show_bug.cgi?id=188208

Reviewed by Eric Carlson.

Rather than have a single, monolithic, zero-duration-timer based dispatch for
a bunch of methods to be performed in a future run-loop, convert them all to
use a DeferrableTask, which in turn is a kind of GenericTaskQueue which can
enqueue only a single task at a time. Convert some other zero-duration-timer
and GenericTaskQueue dispatches to this new DeferrableTask.

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::scheduleCheckPlaybackTargetCompatability):
(WebCore::HTMLMediaElement::checkPlaybackTargetCompatablity):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::scheduleConfigureTextTracks):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::scheduleMediaEngineWasUpdated):
(WebCore::HTMLMediaElement::mediaEngineWasUpdated):
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
(WebCore::HTMLMediaElement::scheduleUpdatePlayState):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::setPlaying):
(WebCore::HTMLMediaElement::setPausedInternal):
(WebCore::HTMLMediaElement::cancelPendingTasks):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::contextDestroyed):
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebCore::HTMLMediaElement::dispatchEvent):
(WebCore::HTMLMediaElement::removeEventListener):
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
(WebCore::HTMLMediaElement::didBecomeFullscreenElement):
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured):
(WebCore::HTMLMediaElement::scheduleUpdateMediaState):
(WebCore::HTMLMediaElement::updateMediaState):
(WebCore::HTMLMediaElement::playbackControlsManagerBehaviorRestrictionsTimerFired):
(WebCore::setFlags): Deleted.
(WebCore::clearFlags): Deleted.
(WebCore::actionName): Deleted.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Deleted.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Deleted.

• html/HTMLMediaElement.h:
• html/HTMLMediaElementEnums.h:
• platform/DeferrableTask.h: Added.

(WebCore::DeferrableTask::DeferrableTask):
(WebCore::DeferrableTask::scheduleTask):
(WebCore::DeferrableTask::close):
(WebCore::DeferrableTask::cancelTask):
(WebCore::DeferrableTask::hasPendingTask const):

3:58 PM Changeset in webkit [237206] by Dewei Zhu

• 2 edits in trunk/Websites/perf.webkit.org

Unreviewed, rolling out r236996.

Temporarily rollout to fix a manifest generation bug.
"lastModified" field for certain platform & metric configurations may be missing.

Reverted changeset:

"ManifestGenerator shouldn't need more than 1GB of memory or
run for 30 seconds"
​https://bugs.webkit.org/show_bug.cgi?id=190393
​https://trac.webkit.org/changeset/236996

3:31 PM Changeset in webkit [237205] by achristensen@apple.com

• 17 edits
  4 deletes in trunk

Remove InjectedBundleBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=190640

Reviewed by Chris Dumez.

Source/WebKit:

These objects are only used in testing now, so I made a replacement to be used for testing,
WKBundlePageDumpHistoryForTesting and WKBundleClearHistoryForTesting.
The existence of these objects is problematic with process swapping and the true back/forward list being in the UIProcess.

• Sources.txt:
• WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:

(WKBundleBackForwardListGetTypeID):
(WKBundleBackForwardListCopyItemAtIndex):
(WKBundleBackForwardListGetBackListCount):
(WKBundleBackForwardListGetForwardListCount):
(WKBundleBackForwardListClear):

• WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h:
• WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemGetTypeID):
(WKBundleBackForwardListItemIsSame):
(WKBundleBackForwardListItemCopyURL):
(WKBundleBackForwardListItemCopyTarget):
(WKBundleBackForwardListItemIsTargetItem):
(WKBundleBackForwardListItemCopyChildren):

• WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageDumpHistoryForTesting):
(WKBundleClearHistoryForTesting):
(WKBundlePageGetBackForwardList):

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp: Removed.
• WebProcess/InjectedBundle/InjectedBundleBackForwardList.h: Removed.
• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp: Removed.
• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h: Removed.
• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::dumpHistoryItem):
(WebKit::WebPage::dumpHistoryForTesting):
(WebKit::WebPage::clearHistory):
(WebKit::WebPage::didReceiveSyncMessage):
(WebKit::WebPage::backForwardList): Deleted.

• WebProcess/WebPage/WebPage.h:

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::dumpBackForwardListsForAllPages):

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::prepare):
(WTR::InjectedBundlePage::dumpHistory):
(WTR::hasPrefix): Deleted.
(WTR::compareByTargetName): Deleted.
(WTR::dumpBackForwardListItem): Deleted.
(WTR::InjectedBundlePage::dumpBackForwardList): Deleted.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearBackForwardList):

2:53 PM Changeset in webkit [237204] by timothy@apple.com

• 24 edits
  4 adds in trunk

Add <meta name="supported-color-schemes"> to control what color schemes the page supports
​https://bugs.webkit.org/show_bug.cgi?id=190526
rdar://problem/45230140

Reviewed by Dean Jackson.

Source/WebCore:

Test: css-dark-mode/supported-color-schemes.html

• dom/Document.cpp:

(WebCore::isColorSchemeSeparator): Added.
(WebCore::processColorSchemes): Added.
(WebCore::Document::processSupportedColorSchemes): Added.
(WebCore::Document::useDarkAppearance const): Take system appearance and document's
suppoerted color shcemes into account.

• dom/Document.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragment): Update use of LocalDefaultSystemAppearance.

• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process): Added supported-color-schemes behind runtime feature check.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint): Update use of LocalDefaultSystemAppearance.

• platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink): Update use of LocalDefaultSystemAppearance.

• platform/mac/LocalDefaultSystemAppearance.h:
• platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
Drop the need for useSystemAppearance. This is accounted for in Document::useDarkAppearance.

• platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::paint): Update use of LocalDefaultSystemAppearance.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents): Update use of LocalDefaultSystemAppearance.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents): Update use of LocalDefaultSystemAppearance.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Use document instead of page.

• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::drawLineForDocumentMarker): Update use of LocalDefaultSystemAppearance.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor const): Update use of LocalDefaultSystemAppearance.
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor const): Ditto.
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): Ditto.
(WebCore::RenderThemeMac::transformSelectionBackgroundColor const): Ditto.
(WebCore::RenderThemeMac::supportsSelectionForegroundColors const): Ditto.
(WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const): Ditto.
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): Ditto.
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): Ditto.
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): Ditto.
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor const): Ditto.
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): Ditto.
(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Ditto.
(WebCore::RenderThemeMac::colorCache const): Ditto.
(WebCore::RenderThemeMac::systemColor const): Ditto.
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary): Ditto.
(WebCore::RenderThemeMac::paintSliderThumb): Ditto.
(WebCore::RenderThemeMac::usingDarkAppearance const): No need to limit to macOS here.

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw): Update use of LocalDefaultSystemAppearance.

Source/WebKit:

• UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]): Update use of LocalDefaultSystemAppearance.

• WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::paintControlForLayerInContext): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRect): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(_WebCreateFragment): Update use of LocalDefaultSystemAppearance.

LayoutTests:

• css-dark-mode/supported-color-schemes-expected.txt: Added.
• css-dark-mode/supported-color-schemes.html: Added.

2:33 PM Changeset in webkit [237203] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Remove superfluous VIDEO build guard
​https://bugs.webkit.org/show_bug.cgi?id=190624

Patch by Rob Buis <​rbuis@igalia.com> on 2018-10-16
Reviewed by Michael Catanzaro.

Remove some instances where the VIDEO build guard is included within another VIDEO build guard.

No new tests. No change in behavior.

• platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

2:01 PM Changeset in webkit [237202] by youenn@apple.com

• 17 edits in trunk

Support RTCConfiguration.certificates
​https://bugs.webkit.org/show_bug.cgi?id=190603

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCCertificate-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-constructor-expected.txt:
• web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/ThirdParty/libwebrtc:

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:

Source/WebCore:

Update RTCConfiguration to have a certificates member.
Add the conversion from RTCCertificate to libwebrtc certificates.
Add check to ensure that certificates are not expired.
Add check to ensure that certificates passed to setConfiguration were
the same as the ones passed to RTCPeerConnection constructor.
Once these checks are done, we reuse the certificates created at
RCPeerConnection creation time when setting the configuration again.

Covered by rebased WPT test.

• Modules/mediastream/RTCConfiguration.h:
• Modules/mediastream/RTCConfiguration.idl:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::certificatesFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::setConfiguration):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration):

• platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

• platform/mediastream/MediaEndpointConfiguration.h:

1:18 PM Changeset in webkit [237201] by Ryan Haddad

• 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r237163.

Introduced layout test failures on iOS Simulator.

Reverted changeset:

"[CG] Adopt CG SPI for non-even cornered rounded rects"
​https://bugs.webkit.org/show_bug.cgi?id=190155
​https://trac.webkit.org/changeset/237163

1:09 PM Changeset in webkit [237200] by dinfuehr@igalia.com

• 2 edits in trunk/JSTests

[JSC] stress/array-prototype-concat-of-long-spliced-arrays2.js times out on arm and mips
​https://bugs.webkit.org/show_bug.cgi?id=190611

Reviewed by Saam Barati.

Reduce array length just like in array-prototype-concat-of-long-spliced-arrays.js
to improve test runtime. On ARM/MIPS this test even timed out when running all
tests.

• stress/array-prototype-concat-of-long-spliced-arrays2.js:

(test):

1:07 PM Changeset in webkit [237199] by dinfuehr@igalia.com

• 2 edits in trunk/Tools

Unreviewed, added myself to contributors.json.

• Scripts/webkitpy/common/config/contributors.json:

12:23 PM Changeset in webkit [237198] by Devin Rousso

• 20 edits in trunk

Web Inspector: Canvas: capture previously saved states and add them to the recording payload
​https://bugs.webkit.org/show_bug.cgi?id=190473

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Recording.json:

Add states key to InitialState object.

Source/WebCore:

Updated existing tests: inspector/canvas/recording-2d.html

inspector/model/recording.html

Instead of sending a single object of the current state of the context, send an array of
objects, one for each restore point.

• html/canvas/CanvasRenderingContext2DBase.h:
• html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::stateStack): Added.

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::stringIndexForKey): Added.
(WebCore::InspectorCanvas::buildInitialState):

Source/WebInspectorUI:

Instead of sending a single object of the current state of the context, send an array of
objects, one for each restore point. When replaying, recreate each restore point before
applying the selected action(s).

• UserInterface/Models/Recording.js:

(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.toJSON):
(WI.Recording.prototype.async._process):
(WI.Recording.prototype.async._swizzleState): Added.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.deriveCurrentState): Added.
(WI.RecordingAction.prototype.get states): Added.
(WI.RecordingAction.prototype.process):
(WI.RecordingAction.prototype.get state): Deleted.
Drive-by: when processing, also check to see if any values in the current state changed
outside of those expected in _stateModifiers (e.g. restore may modify some state values).

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):

• UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
Default to showing the most recent (current) state.

• UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.initialLayout): Added.
(WI.CanvasTabContentView.prototype._addCanvas):
(WI.CanvasTabContentView.prototype._removeCanvas):
(WI.CanvasTabContentView.prototype._addRecording): Added.
(WI.CanvasTabContentView.prototype._recordingImportedOrStopped):
(WI.CanvasTabContentView.prototype._recordingAdded): Deleted.

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.get importedRecordings): Added.
(WI.CanvasManager.prototype.importRecording):
Drive-by: store imported recordings on WI.CanvasManager so that if the Canvas tab is
closed we can still show the list of imported recordings.

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-2d.html:
• inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer):
(TestPage.registerInitializer.async.logRecording): Added.
(TestPage.registerInitializer.logRecording): Deleted.

• inspector/model/recording-expected.txt:
• inspector/model/recording.html:

12:16 PM Changeset in webkit [237197] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

isASTErroneous in offlineasm should de-macroify before looking for Errors
​https://bugs.webkit.org/show_bug.cgi?id=190634

Reviewed by Mark Lam.

If a macro isn't usable in a configuration it might still cause us to
think the ast is invalid. This change runs the de-macroifier before
looking for errors.

Also, it adds a missing include to Printer.h.

• assembler/Printer.h:
• offlineasm/settings.rb:

12:13 PM Changeset in webkit [237196] by Devin Rousso

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas recording sidebar scroll position lost after switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=190482

Reviewed by Joseph Pecoraro.

• UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.removeSidebarPanel):
(WI.Sidebar.prototype.set selectedSidebarPanel):
Call hidden before setting selected to false, as that sets display: none; on the
element, which sets the scrollTop to 0.

• UserInterface/Views/SidebarPanel.js:

(WI.SidebarPanel.prototype.shown):
(WI.SidebarPanel.prototype.hidden):
(WI.SidebarPanel.prototype.get scrollElement): Added.
Allow subclasses to specify the scrolling element for saving/restoring the scroll position.

• UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype.get scrollElement): Added.

• UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement): Added.

12:09 PM Changeset in webkit [237195] by Devin Rousso

• 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Should be a way to go directly from an event in the overview view to the specialized timeline for that event
​https://bugs.webkit.org/show_bug.cgi?id=135307
<rdar://problem/17273966>

Reviewed by Joseph Pecoraro.

When a WI.TimelineRecordBar is clicked, call up the delegate chain to the overview and
adjust the currently selected WI.TimelineRecordBar among the WI.TimelineOverviewGraphs.
Similarly, selecting a WI.DataGridNode in any WI.TimelineView subclass will use the same
logic to select the corresponding WI.TimelineRecordBar.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype.reset):
(WI.TimelineOverview.prototype._recordSelected):

• UserInterface/Views/TimelineOverviewGraph.js:

(WI.TimelineOverviewGraph):
(WI.TimelineOverviewGraph.prototype.set selectedRecord):
(WI.TimelineOverviewGraph.prototype.get selectedRecordBar): Added.
(WI.TimelineOverviewGraph.prototype.set selectedRecordBar): Added.
(WI.TimelineOverviewGraph.prototype.timelineRecordBarClicked): Added.
(WI.TimelineOverviewGraph.prototype._needsSelectedRecordLayout):

• UserInterface/Views/TimelineRecordBar.js:

(WI.TimelineRecordBar):
(WI.TimelineRecordBar.prototype.get selected): Added.
(WI.TimelineRecordBar.prototype.set selected): Added.
(WI.TimelineRecordBar.prototype._handleClick): Added.

• UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.selected > .segment): Added.
Add a delegate that is notified whenever the element is clicked.

• UserInterface/Views/TimelineDataGridNode.js:

(WI.TimelineDataGridNode.prototype.refreshGraph.createBar):

• UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WI.LayoutTimelineOverviewGraph.prototype.updateSelectedRecord):
(WI.LayoutTimelineOverviewGraph.prototype._updateRowLayout.createBar):

• UserInterface/Views/NetworkTimelineOverviewGraph.js:

(WI.NetworkTimelineOverviewGraph.prototype.layout.createBar):

• UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WI.ScriptTimelineOverviewGraph.prototype.layout.createBar):
(WI.ScriptTimelineOverviewGraph.prototype.updateSelectedRecord):

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype.showTimelineViewForTimeline):

11:57 AM Changeset in webkit [237194] by Ryan Haddad

• 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed attempt to fix the Windows build after r237112.

• Plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

11:28 AM Changeset in webkit [237193] by Alan Coon

• 7 edits in branches/safari-606-branch/Source

Versioning.

11:04 AM Changeset in webkit [237192] by commit-queue@webkit.org

• 32 edits
  5 copies
  9 adds in trunk

Implement feature flag and bindings for CSS Painting API
​https://bugs.webkit.org/show_bug.cgi?id=190237

Patch by Justin Michaud <Justin Michaud> on 2018-10-16
Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add feature flag and bindings for CSS Painting API. This adds a new property,
CSS.paintWorkletGlobalScope, which will be a temporary way to access the paint
worklet global scope untill CSS.paintWorklet is implemented.

There are a few small changes, mostly adding headers and "using" declarations,
that were required to get this to build. This is probably related to unified sources.

Tests: fast/css-custom-paint/basic.html

fast/css-custom-paint/registerPaintBindings.html

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSPaintWorkletGlobalScopeCustom.cpp: Added.

(WebCore::throwInvalidModificationError):
(WebCore::JSCSSPaintWorkletGlobalScope::registerPaint):

• bindings/js/JSEventListener.cpp:
• bindings/js/JSRemoteDOMWindowCustom.cpp:
• bindings/js/JSWebMetalRenderPassAttachmentDescriptorCustom.cpp:
• bindings/js/WebCoreBuiltinNames.h:
• css/CSSPaintCallback.h: Copied from Source/WebCore/css/MediaQueryParserContext.cpp.

(WebCore::CSSPaintCallback::~CSSPaintCallback):

• css/CSSPaintCallback.idl: Added.
• css/CSSPaintWorkletGlobalScope.cpp: Copied from Source/WebCore/css/MediaQueryParserContext.cpp.

(WebCore::CSSPaintWorkletGlobalScope::create):
(WebCore::CSSPaintWorkletGlobalScope::CSSPaintWorkletGlobalScope):
(WebCore::CSSPaintWorkletGlobalScope::devicePixelRatio):
(WebCore::CSSPaintWorkletGlobalScope::addRegisteredPaint):

• css/CSSPaintWorkletGlobalScope.h: Copied from Source/WebCore/css/MediaQueryParserContext.cpp.

(WebCore::CSSPaintWorkletGlobalScope::paintDefinitionMap):

• css/CSSPaintWorkletGlobalScope.idl: Added.
• css/DOMCSSPaintWorklet.cpp: Copied from Source/WebCore/css/MediaQueryParserContext.cpp.

(WebCore::DOMCSSPaintWorklet::ensurePaintWorkletGlobalScope):
(WebCore::DOMCSSPaintWorklet::from):
(WebCore::DOMCSSPaintWorklet::supplementName):

• css/DOMCSSPaintWorklet.h: Copied from Source/WebCore/css/MediaQueryParserContext.cpp.
• css/DOMCSSPaintWorklet.idl: Added.
• css/MediaQueryParserContext.cpp:
• css/StyleBuilder.h:
• dom/Document.cpp:

(WebCore::Document::ensureCSSPaintWorkletGlobalScope):

• dom/Document.h:
• features.json:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSPaintingAPIEnabled):
(WebCore::RuntimeEnabledFeatures::cssPaintingAPIEnabled const):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferences.yaml:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Add basic tests for the CSS Painting API registerPaint function,
and test the custom bindings.

• fast/css-custom-paint/basic-expected.txt: Added.
• fast/css-custom-paint/basic.html: Added.
• fast/css-custom-paint/registerPaintBindings-expected.txt: Added.
• fast/css-custom-paint/registerPaintBindings.html: Added.
• platform/ios-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

10:57 AM WebKitGTK/2.22.x edited by Philippe Normand

(diff)

10:54 AM Changeset in webkit [237191] by Philippe Normand

• 4 edits in trunk/Source/WebKit

[GLib] Build error with RemoteInspector disabled
​https://bugs.webkit.org/show_bug.cgi?id=190623

Reviewed by Michael Catanzaro.

Compilation guards added to ensure the build still works when the
Remote WebInspector has been disabled.

• UIProcess/API/glib/WebKitAutomationSession.cpp:
• UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
• UIProcess/RemoteWebInspectorProxy.cpp:

10:52 AM Changeset in webkit [237190] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Fix sandbox on distros with suid bubblewrap
​https://bugs.webkit.org/show_bug.cgi?id=190616

Patch by Patrick Griffis <Patrick Griffis> on 2018-10-16
Reviewed by Michael Catanzaro.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

10:49 AM Changeset in webkit [237189] by keith_miller@apple.com

• 1 edit
  2 adds in trunk/Source/JavaScriptCore

Unreviewed, forgot to add untracked files.

• llint/LLIntSettingsExtractor.cpp: Added.

(main):

• offlineasm/generate_settings_extractor.rb: Added.

10:44 AM Changeset in webkit [237188] by keith_miller@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Unreviewed, reland ​https://bugs.webkit.org/show_bug.cgi?id=189708 with build fix.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy):

• offlineasm/generate_offset_extractor.rb:
• offlineasm/offsets.rb:
• offlineasm/settings.rb:

10:29 AM Changeset in webkit [237187] by pvollan@apple.com

• 14 edits
  4 adds in trunk

[WebVTT] Support inline WebVTT styles
​https://bugs.webkit.org/show_bug.cgi?id=190369

Reviewed by Eric Carlson.

Source/WebCore:

Add support for inline WebVTT styles, see ​https://w3c.github.io/webvtt/#styling. The parsed
style strings from the VTT file are added to an optional vector of style strings in the
TextTrack class. These styles are then added as HTMLStyleElement children to the parent of
the cue span element.

Test: media/track/track-cue-css.html

• html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::newStyleSheetsParsed):

• html/track/InbandGenericTextTrack.h:
• html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newStyleSheetsParsed):

• html/track/InbandWebVTTTextTrack.h:
• html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newStyleSheetsAvailable):

• html/track/LoadableTextTrack.h:
• html/track/TextTrack.h:

(WebCore::TextTrack::styleSheets const):

• html/track/VTTCue.cpp:

(WebCore::VTTCue::getDisplayTree):

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::getNewCues):
(WebCore::WebVTTParser::getStyleSheets):
(WebCore::WebVTTParser::parse):
(WebCore::WebVTTParser::collectWebVTTBlock):
(WebCore::WebVTTParser::collectStyleSheet):
(WebCore::WebVTTParser::checkStyleSheet):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):

• html/track/WebVTTParser.h:
• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::newStyleSheetsParsed):
(WebCore::TextTrackLoader::getNewStyleSheets):

• loader/TextTrackLoader.h:

LayoutTests:

• media/track/captions-webvtt/css-styling.vtt: Added.
• media/track/captions-webvtt/no-css-styling.vtt: Added.
• media/track/track-cue-css-expected.html: Added.
• media/track/track-cue-css.html: Added.

9:47 AM Changeset in webkit [237186] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: sequences of spaces longer than 16 don't show a dot
​https://bugs.webkit.org/show_bug.cgi?id=190528

Reviewed by Matt Baker.

• UserInterface/Views/CodeMirrorAdditions.js:

Create a new CSS rule and add it to a unique <style> whenever a whitespace sequence with
a length is seen for the first time.

• UserInterface/Views/CodeMirrorOverrides.css:

(.show-whitespace-characters .CodeMirror .cm-whitespace-1::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-2::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-3::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-4::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-5::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-6::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-7::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-8::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-9::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-10::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-11::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-12::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-13::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-14::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-15::before): Deleted.
(.show-whitespace-characters .CodeMirror .cm-whitespace-16::before): Deleted.

9:24 AM Changeset in webkit [237185] by Chris Dumez

• 19 edits in trunk

window.navigator should not become null after the window loses its browsing context
​https://bugs.webkit.org/show_bug.cgi?id=190595

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test which is not failing differently. The last check of this test is checking that
navigator.serviceWorker returns null after the frame has been detached. The test has been written
this way because this is how Chromium behaves. However, Firefox keeps returning the
ServiceWorkerContainer, as we do. Also, the specification indicates the the attribute cannot
return null (since the attribute is not nullable):

• ​https://w3c.github.io/ServiceWorker/#navigator-serviceworker

• web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:

Source/WebCore:

window.navigator should not become null after the window loses its browsing context.
This does not match the HTML specification or the behavior of other browsers.

No new tests, updated existing tests.

• Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::geolocation const):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::navigator):

• page/Navigator.cpp:

(WebCore::Navigator::Navigator):

• page/Navigator.h:
• page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase):

• page/NavigatorBase.h:
• page/WorkerNavigator.cpp:

(WebCore::WorkerNavigator::WorkerNavigator):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):

• workers/service/ServiceWorkerContainer.h:

LayoutTests:

Extend layout test coverage.

• fast/frames/detached-frame-property-expected.txt:
• fast/frames/detached-frame-property.html:
• http/tests/dom/cross-origin-detached-window-properties-expected.txt:
• http/tests/dom/cross-origin-detached-window-properties.html:
• http/tests/dom/same-origin-detached-window-properties-expected.txt:
• http/tests/dom/same-origin-detached-window-properties.html:

8:58 AM Changeset in webkit [237184] by achristensen@apple.com

• 24 edits in trunk/Source

Replace HistoryItem* with HistoryItem& where possible
​https://bugs.webkit.org/show_bug.cgi?id=190617

Reviewed by Chris Dumez.

Source/WebCore:

• history/BackForwardClient.h:
• history/BackForwardController.cpp:

(WebCore::BackForwardController::setCurrentItem):

• history/BackForwardController.h:
• history/HistoryItem.cpp:

(WebCore::defaultNotifyHistoryItemChanged):
(WebCore::HistoryItem::setAlternateTitle):
(WebCore::HistoryItem::setURLString):
(WebCore::HistoryItem::setOriginalURLString):
(WebCore::HistoryItem::setReferrer):
(WebCore::HistoryItem::setTitle):
(WebCore::HistoryItem::setTarget):
(WebCore::HistoryItem::setShouldRestoreScrollPosition):
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::notifyChanged):

• history/HistoryItem.h:
• loader/EmptyClients.cpp:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadSameDocumentItem):

• loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::recursiveUpdateForCommit):
(WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
(WebCore::HistoryController::setCurrentItem):
(WebCore::HistoryController::createItem):
(WebCore::HistoryController::itemsAreClones const):
(WebCore::HistoryController::currentFramesMatchItem const):

• loader/HistoryController.h:

Source/WebKit:

• WebProcess/WebCoreSupport/SessionStateConversion.h:
• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WK2NotifyHistoryItemChanged):
(WebKit::WebBackForwardListProxy::goToItem):

• WebProcess/WebPage/WebBackForwardListProxy.h:

Source/WebKitLegacy/mac:

• History/BackForwardList.h:
• History/BackForwardList.mm:

(BackForwardList::goToItem):

• History/WebBackForwardList.mm:

(-[WebBackForwardList goToItem:]):

• History/WebHistoryItem.mm:

(WKNotifyHistoryItemChanged):

• History/WebHistoryItemInternal.h:

Source/WebKitLegacy/win:

• BackForwardList.cpp:

(BackForwardList::goToItem):

• BackForwardList.h:
• WebBackForwardList.cpp:

(WebBackForwardList::goToItem):

8:49 AM Changeset in webkit [237183] by cturner@igalia.com

• 1 edit
  14 adds in trunk/LayoutTests/imported/w3c

[EME] Add some ClearKey baselines for passing tests
​https://bugs.webkit.org/show_bug.cgi?id=190579

Reviewed by Unreviewed test gardening.

• web-platform-tests/encrypted-media/clearkey-check-initdata-type.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-events-session-closed-event.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-events.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-invalid-license.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-keystatuses.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.https-expected.txt: Added.
• web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.https-expected.txt: Added.

8:39 AM Changeset in webkit [237182] by achristensen@apple.com

• 6 edits in trunk/Source

Remove unused WebHistoryItem._transientPropertyForKey
​https://bugs.webkit.org/show_bug.cgi?id=190606

Reviewed by Chris Dumez.

Source/WebCore:

This is unnecessary complexity in HistoryItem.

• history/HistoryItem.h:
• history/mac/HistoryItemMac.mm:

(WebCore::HistoryItem::getTransientProperty const): Deleted.
(WebCore::HistoryItem::setTransientProperty): Deleted.

Source/WebKitLegacy/mac:

• History/WebHistoryItem.mm:
• History/WebHistoryItemPrivate.h:

8:21 AM Changeset in webkit [237181] by Basuke Suzuki

• 4 edits
  1 add in trunk/Source/WebCore

[Curl] Separate SSL Class for platform dependent way of setup.
​https://bugs.webkit.org/show_bug.cgi?id=190597

Reviewed by Alex Christensen.

SSL setup is very platform dependent. This patch separate the class to allow
platform-dependent setup at the SSL handle instantiation.

No new tests because there's no behaviro changes.

• PlatformWinCairo.cmake:
• platform/network/curl/CurlSSLHandle.cpp:

(WebCore::CurlSSLHandle::CurlSSLHandle):
(WebCore::CurlSSLHandle::getCACertPathEnv): Moved.

• platform/network/curl/CurlSSLHandle.h:
• platform/network/win/CurlSSLHandleWin.cpp:

(WebCore::getCACertPathEnv):
(WebCore::CurlSSLHandle::platformInitialize):

7:54 AM Changeset in webkit [237180] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[EME] Multiple ClearKey tests crashing in gst_qtdemux_request_protection_context
​https://bugs.webkit.org/show_bug.cgi?id=190577

Reviewed by Michael Catanzaro.

• platform/gtk/TestExpectations:

4:01 AM Changeset in webkit [237179] by Philippe Normand

• 2 edits in trunk/Tools

Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix

• gstreamer/jhbuild.modules:

3:04 AM Changeset in webkit [237178] by Philippe Normand

• 2 edits in trunk/Tools

[GTK][JHBuild] Disable libmount support in glib

Rubber-stamped by Alejandro G. Castro.

This feature doesn't seem required for our setup.

• gtk/jhbuild.modules:

2:44 AM Changeset in webkit [237177] by Philippe Normand

• 2 edits in trunk/Source/WebKit

Unreviewed, another GTK build fix after r237146

• UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):

1:47 AM Changeset in webkit [237176] by Philippe Normand

• 2 edits in trunk

Unreviewed, GTK bots build fix

• Source/cmake/OptionsGTK.cmake: Disable Sandbox support until the

bots have all the needed dependencies installed.

12:52 AM Changeset in webkit [237175] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, add missing include.

• runtime/BasicBlockLocation.h:

12:39 AM Changeset in webkit [237174] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Source/ThirdParty/libwebrtc

[GTK][WPE] Make libwebrtc compile using the system opus library
​https://bugs.webkit.org/show_bug.cgi?id=190573

Patch by Alejandro G. Castro <​alex@igalia.com> on 2018-10-16
Reviewed by Philippe Normand.

We found some situations where gstreamer gets confused when it
tries to use opus because it finds opus symbols compiled for
liwebrtc. We are going to try the option to use the system opus
library also for libwebrtc.

• CMakeLists.txt: Added opus dependency.
• cmake/FindOpus.cmake: Added the hints to find the opus library

in the compilation.

12:19 AM Changeset in webkit [237173] by keith_miller@apple.com

• 57 edits in trunk/Source

Support arm64 CPUs with a 32-bit address space
​https://bugs.webkit.org/show_bug.cgi?id=190273

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This patch adds support for arm64_32 in the LLInt. In order to
make this work we needed to add a new type that reflects the size
of a cpu register. This type is called CPURegister or UCPURegister
for the unsigned version. Most places that used void* or intptr_t
to refer to a register have been changed to use this new type.

• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/ARM64Assembler.h:

(JSC::isInt):
(JSC::is4ByteAligned):
(JSC::PairPostIndex::PairPostIndex):
(JSC::PairPreIndex::PairPreIndex):
(JSC::ARM64Assembler::readPointer):
(JSC::ARM64Assembler::readCallTarget):
(JSC::ARM64Assembler::computeJumpType):
(JSC::ARM64Assembler::linkCompareAndBranch):
(JSC::ARM64Assembler::linkConditionalBranch):
(JSC::ARM64Assembler::linkTestAndBranch):
(JSC::ARM64Assembler::loadRegisterLiteral):
(JSC::ARM64Assembler::loadStoreRegisterPairPostIndex):
(JSC::ARM64Assembler::loadStoreRegisterPairPreIndex):
(JSC::ARM64Assembler::loadStoreRegisterPairOffset):
(JSC::ARM64Assembler::loadStoreRegisterPairNonTemporal):
(JSC::isInt7): Deleted.
(JSC::isInt11): Deleted.

• assembler/CPU.h:

(JSC::isAddress64Bit):
(JSC::isAddress32Bit):

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):

• assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssemblerARM64::collectCPUFeatures):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load):
(JSC::MacroAssemblerARM64::store):
(JSC::MacroAssemblerARM64::isInIntRange): Deleted.

• assembler/Printer.h:
• assembler/ProbeContext.h:

(JSC::Probe::CPUState::gpr):
(JSC::Probe::CPUState::spr):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):

• b3/B3ConstPtrValue.h:
• b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::isArgValidForRep):

• b3/air/AirArg.h:

(JSC::B3::Air::Arg::stackSlot const):
(JSC::B3::Air::Arg::special const):

• b3/air/testair.cpp:
• b3/testb3.cpp:

(JSC::B3::testStoreConstantPtr):
(JSC::B3::testInterpreter):
(JSC::B3::testAddShl32):
(JSC::B3::testLoadBaseIndexShift32):

• bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptCallArgumentHandler::appendArgument):

• bindings/ScriptFunctionCall.h:
• bytecode/CodeBlock.cpp:

(JSC::roundCalleeSaveSpaceAsVirtualRegisters):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::restoreCalleeSavesFor):
(JSC::DFG::saveCalleeSavesFor):
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassembleWithUDis86):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileWeakMapGet):

• heap/MachineStackMarker.cpp:

(JSC::copyMemory):

• interpreter/CallFrame.h:

(JSC::ExecState::returnPC const):
(JSC::ExecState::hasReturnPC const):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::returnPCOffset):
(JSC::ExecState::isGlobalExec const):
(JSC::ExecState::setReturnPC):

• interpreter/CalleeBits.h:

(JSC::CalleeBits::boxWasm):
(JSC::CalleeBits::isWasm const):
(JSC::CalleeBits::asWasmCallee const):

• interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):

• interpreter/VMEntryRecord.h:
• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::clearStackFrame):

• jit/RegisterAtOffset.h:

(JSC::RegisterAtOffset::offsetAsIndex const):

• jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LLIntOfflineAsmConfig.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/arm64.rb:
• offlineasm/asm.rb:
• offlineasm/ast.rb:
• offlineasm/backends.rb:
• offlineasm/parser.rb:
• offlineasm/x86.rb:
• runtime/BasicBlockLocation.cpp:

(JSC::BasicBlockLocation::dumpData const):
(JSC::BasicBlockLocation::emitExecuteCode const):

• runtime/BasicBlockLocation.h:
• runtime/HasOwnPropertyCache.h:
• runtime/JSBigInt.cpp:

(JSC::JSBigInt::inplaceMultiplyAdd):
(JSC::JSBigInt::digitDiv):

• runtime/JSBigInt.h:
• runtime/JSObject.h:
• runtime/Options.cpp:

(JSC::jitEnabledByDefault):

• runtime/Options.h:
• runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

• runtime/SamplingProfiler.cpp:

(JSC::CFrameWalker::walk):

• runtime/SlowPathReturnType.h:

(JSC::encodeResult):
(JSC::decodeResult):

• tools/SigillCrashAnalyzer.cpp:

(JSC::SigillCrashAnalyzer::dumpCodeBlock):

Source/WebCore:

Fix missing namespace annotation.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAddStyleRelation):

Source/WTF:

Use WTF_CPU_ADDRESS64/32 to decide if the system is running on arm64_32.

• wtf/MathExtras.h:

(getLSBSet):

• wtf/Platform.h: