Timeline

Oct 21, 2018:

7:06 PM Changeset in webkit [237313] by Fujii Hironori

• 3 edits in trunk/Source/WebKitLegacy/win

[Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=190744

Reviewed by Alex Christensen.

clang-cl reports compilation warnings for inconsistent 'override'
keyword usage.

WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
This can't be marked 'override' if !USE(CA).

• WebView.cpp:

(WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).

• WebView.h: Marked all overriding member function declarations of WebView 'override'.

Declare flushPendingGraphicsLayerChanges only if USE(CA).

Oct 20, 2018:

2:07 PM Changeset in webkit [237312] by dbates@webkit.org

• 3 edits in trunk/LayoutTests

Unskip test fast/writing-mode/english-rl-text-with-spelling-marker.html in iOS WebKit2

Following r235149 we mark spelling errors in iOS WebKit2.

• platform/ios-wk1/TestExpectations: Skip in legacy WebKit until we fix <​https://webkit.org/b/188762>.
• platform/ios/TestExpectations: Unskip test.

6:15 AM Changeset in webkit [237311] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

MediaRecorder should fire a stop event when all tracks are ended
​https://bugs.webkit.org/show_bug.cgi?id=190642

Patch by YUHAN WU <​yuhan_wu@apple.com> on 2018-10-20
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt: Added.
• web-platform-tests/mediacapture-record/MediaRecorder-stop.html: Added.

Source/WebCore:

This patch only implements to fire the stop event when all tracks are ended.
We will need to fire a dataavailable event when all tracks are ended.

Test: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::trackEnded):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediarecorder/MediaRecorder.idl:
• WebCore.xcodeproj/project.pbxproj:
• dom/EventNames.h:

12:00 AM Changeset in webkit [237310] by mitz@apple.com

• 2 edits
  4 deletes in trunk/Tools

[macOS] MiniBrowser has an unused injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=190770

Reviewed by Tim Horton.

• MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
• MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target, the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
• MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
• MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
• MiniBrowser/mac/Bundle: Removed.