Timeline
Oct 25, 2018:
- 10:06 PM Changeset in webkit [237446] by
-
- 6 edits in trunk
[PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
https://bugs.webkit.org/show_bug.cgi?id=190915
<rdar://problem/45059069>
Reviewed by Geoffrey Garen.
Source/WebCore:
- history/PageCache.cpp:
(WebCore::canCacheFrame):
Make sure we do not put into PageCache a page whose main frame is showing the initial empty document.
We usually do not try to put those into PageCache because we do not have a HistoryItem to save the
PageCache entry on. However, when we process-swap on a navigation with the history locked, the new
process has a HistoryItem and is initially showing the initial empty document before continuing
the load from the previous process. Note that saving the initial empty document in PageCache would
lead to crashes later on previous the initial empty document's Window is taken and reused for the
next load.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
Stop assuming that we're continuing a client-side redirect when lockHistory is Yes. It is
lockBackForwardList that is actually Yes when we're doing a client-side redirect.
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
Stop using calling the completion handler with an invalid URL when the policy decision is 'Suspend' and
use 'about:blank' instead. Without this change, FrameLoader::continueLoadAfterNavigationPolicy() would
not load 'about:blank' when its AllowNavigationToInvalidURL parameter is No.
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 9:51 PM Changeset in webkit [237445] by
-
- 13 edits in trunk/Source/JavaScriptCore
Unreviewed, partial rolling in r237254
https://bugs.webkit.org/show_bug.cgi?id=190340
We do not use the added function right now to investigate what is the reason of the regression.
If it causes the regression, it seems that Parser.cpp's inlining decision seems culprit.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):
- parser/ParserModes.h:
- parser/ParserTokens.h:
(JSC::JSTextPosition::JSTextPosition):
(JSC::JSTokenLocation::JSTokenLocation): Deleted.
- parser/SourceCodeKey.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
- runtime/CodeCache.h:
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/FunctionExecutable.h:
- 7:03 PM Changeset in webkit [237444] by
-
- 1 copy in tags/Safari-606.3.3
Tag Safari-606.3.3.
- 5:59 PM Changeset in webkit [237443] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/websocket/tests/hybi/handshake-ok-with-legacy-sec-websocket-response-headers.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=173041
Unreviewed test gardening.
- platform/ios/TestExpectations: Mark test as flaky.
- 5:44 PM Changeset in webkit [237442] by
-
- 1 edit89 adds in trunk/PerformanceTests
Check in corresponding C code in JetStream 2
https://bugs.webkit.org/show_bug.cgi?id=190733
Rubber-stamped by Filip Pizlo.
- JetStream2/simple/float-mm.c: Added.
- JetStream2/wasm/HashSet.cpp: Added.
- JetStream2/wasm/gcc-loops.cpp: Added.
- JetStream2/wasm/quicksort.c: Added.
- JetStream2/wasm/TSF: Added.
- JetStream2/wasm/TSF/build.sh: Added.
- JetStream2/wasm/TSF/config.h: Added.
- JetStream2/wasm/TSF/gpc.h: Added.
- JetStream2/wasm/TSF/gpc_code_gen_util.c: Added.
- JetStream2/wasm/TSF/gpc_instruction.c: Added.
- JetStream2/wasm/TSF/gpc_instruction_dispatch.gen: Added.
- JetStream2/wasm/TSF/gpc_instruction_size.gen: Added.
- JetStream2/wasm/TSF/gpc_instruction_stack_effects.gen: Added.
- JetStream2/wasm/TSF/gpc_instruction_static_size.gen: Added.
- JetStream2/wasm/TSF/gpc_instruction_to_string.gen: Added.
- JetStream2/wasm/TSF/gpc_int_common.h: Added.
- JetStream2/wasm/TSF/gpc_intable.c: Added.
- JetStream2/wasm/TSF/gpc_internal.h: Added.
- JetStream2/wasm/TSF/gpc_interpreter.gen: Added.
- JetStream2/wasm/TSF/gpc_program.c: Added.
- JetStream2/wasm/TSF/gpc_proto.c: Added.
- JetStream2/wasm/TSF/gpc_stack_height.c: Added.
- JetStream2/wasm/TSF/gpc_threaded.c: Added.
- JetStream2/wasm/TSF/gpc_worklist.h: Added.
- JetStream2/wasm/TSF/tsf.h: Added.
- JetStream2/wasm/TSF/tsf_adaptive_reader.c: Added.
- JetStream2/wasm/TSF/tsf_asprintf.c: Added.
- JetStream2/wasm/TSF/tsf_atomics.h: Added.
- JetStream2/wasm/TSF/tsf_buf_reader.c: Added.
- JetStream2/wasm/TSF/tsf_buf_writer.c: Added.
- JetStream2/wasm/TSF/tsf_buffer.c: Added.
- JetStream2/wasm/TSF/tsf_build_defines.h: Added.
- JetStream2/wasm/TSF/tsf_config.h: Added.
- JetStream2/wasm/TSF/tsf_config_stub.h: Added.
- JetStream2/wasm/TSF/tsf_copier.c: Added.
- JetStream2/wasm/TSF/tsf_define_helpers.c: Added.
- JetStream2/wasm/TSF/tsf_define_helpers.h: Added.
- JetStream2/wasm/TSF/tsf_destructor.c: Added.
- JetStream2/wasm/TSF/tsf_error.c: Added.
- JetStream2/wasm/TSF/tsf_format.h: Added.
- JetStream2/wasm/TSF/tsf_fsdb.c: Added.
- JetStream2/wasm/TSF/tsf_fsdb_protocol.c: Added.
- JetStream2/wasm/TSF/tsf_fsdb_protocol.h: Added.
- JetStream2/wasm/TSF/tsf_generator.c: Added.
- JetStream2/wasm/TSF/tsf_gpc_code_gen.c: Added.
- JetStream2/wasm/TSF/tsf_indent.h: Added.
- JetStream2/wasm/TSF/tsf_internal.h: Added.
- JetStream2/wasm/TSF/tsf_internal_config.h: Added.
- JetStream2/wasm/TSF/tsf_internal_config_stub.h: Added.
- JetStream2/wasm/TSF/tsf_inttypes.h: Added.
- JetStream2/wasm/TSF/tsf_io.c: Added.
- JetStream2/wasm/TSF/tsf_io_utils.c: Added.
- JetStream2/wasm/TSF/tsf_ir.c: Added.
- JetStream2/wasm/TSF/tsf_ir.h: Added.
- JetStream2/wasm/TSF/tsf_ir_different.c: Added.
- JetStream2/wasm/TSF/tsf_ir_different.h: Added.
- JetStream2/wasm/TSF/tsf_ir_speed.c: Added.
- JetStream2/wasm/TSF/tsf_limits.c: Added.
- JetStream2/wasm/TSF/tsf_named_type.c: Added.
- JetStream2/wasm/TSF/tsf_native.c: Added.
- JetStream2/wasm/TSF/tsf_parser.c: Added.
- JetStream2/wasm/TSF/tsf_primitive.c: Added.
- JetStream2/wasm/TSF/tsf_ra_type_man.c: Added.
- JetStream2/wasm/TSF/tsf_reflect.c: Added.
- JetStream2/wasm/TSF/tsf_region.h: Added.
- JetStream2/wasm/TSF/tsf_serial_in_man.c: Added.
- JetStream2/wasm/TSF/tsf_serial_out_man.c: Added.
- JetStream2/wasm/TSF/tsf_serial_protocol.h: Added.
- JetStream2/wasm/TSF/tsf_sha1.c: Added.
- JetStream2/wasm/TSF/tsf_sha1.h: Added.
- JetStream2/wasm/TSF/tsf_sha1_writer.c: Added.
- JetStream2/wasm/TSF/tsf_sort.c: Added.
- JetStream2/wasm/TSF/tsf_st.c: Added.
- JetStream2/wasm/TSF/tsf_st.h: Added.
- JetStream2/wasm/TSF/tsf_st_typetable.c: Added.
- JetStream2/wasm/TSF/tsf_stream_file_input.c: Added.
- JetStream2/wasm/TSF/tsf_stream_file_output.c: Added.
- JetStream2/wasm/TSF/tsf_type.c: Added.
- JetStream2/wasm/TSF/tsf_type_in_map.c: Added.
- JetStream2/wasm/TSF/tsf_type_out_map.c: Added.
- JetStream2/wasm/TSF/tsf_type_table.c: Added.
- JetStream2/wasm/TSF/tsf_types.h: Added.
- JetStream2/wasm/TSF/tsf_util.h: Added.
- JetStream2/wasm/TSF/tsf_version.c: Added.
- JetStream2/wasm/TSF/tsf_zip_abstract.c: Added.
- JetStream2/wasm/TSF/tsf_zip_abstract.h: Added.
- JetStream2/wasm/TSF/tsf_zip_attr.c: Added.
- JetStream2/wasm/TSF/tsf_zip_reader.c: Added.
- JetStream2/wasm/TSF/tsf_zip_writer.c: Added.
- 5:39 PM Changeset in webkit [237441] by
-
- 2 edits in trunk/Source/WebCore
Fix build after r237431 for platforms that don't support FULLSCREEN_API
Need the bug URL (OOPS!).
Reviewed by Joseph Pecoraro.
No new tests. No change in behavior.
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::addEventListenersToNode):
- 5:21 PM Changeset in webkit [237440] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Visual Studio 2017
- API/tests/testapi.c:
(testMarkingConstraintsAndHeapFinalizers):
(main):
- 5:11 PM Changeset in webkit [237439] by
-
- 14 edits in branches/safari-606-branch
Revert r237373. rdar://problem/45567354
- 5:11 PM Changeset in webkit [237438] by
-
- 3 edits in branches/safari-606-branch/Source/JavaScriptCore
Revert r236604. rdar://problem/45567354
- 5:11 PM Changeset in webkit [237437] by
-
- 2 edits in branches/safari-606-branch/Source/JavaScriptCore
Revert r236606. rdar://problem/45567354
- 4:59 PM Changeset in webkit [237436] by
-
- 4 edits2 adds in trunk
Web Inspector: Canvas Recording loading goes significantly slower when "Frame" tree element is expanded
https://bugs.webkit.org/show_bug.cgi?id=190497
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
Save the
WI.TreeElementthat are in the DOM, and compare that with anyWI.TreeElement
that would be added to the DOM. If all of the following are true, don't edit the DOM:
- no focused
WI.TreeElementthat isn't currently visible (we would scroll otherwise) - the set of previously visible
WI.TreeElements (e.g. not used for scroll padding) has at least one of theWI.TreeElements that would be added from this update- this means that the user hasn't scrolled beyond the padding
WI.TreeElement
- this means that the user hasn't scrolled beyond the padding
- there are no
WI.TreeElements that would be added from this update that were NOT added in a previous update- this covers the case that a
WI.TreeElementis inserted in the visible area
- this covers the case that a
- UserInterface/Base/Utilities.js:
- UserInterface/Views/TreeOutline.js:
(WI.TreeOutline):
(WI.TreeOutline.prototype.registerScrollVirtualizer):
(WI.TreeOutline.prototype.updateVirtualizedElements.walk):
(WI.TreeOutline.prototype.updateVirtualizedElements):
LayoutTests:
- inspector/unit-tests/set-utilities-expected.txt: Added.
- inspector/unit-tests/set-utilities.html: Added.
- 4:55 PM Changeset in webkit [237435] by
-
- 2 edits in trunk/Source/WebInspectorUI
JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
https://bugs.webkit.org/show_bug.cgi?id=190922
<rdar://problem/45569827>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-25
Reviewed by Devin Rousso.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.requestDocument):
Feature check for agents that may not exist in a JSContext.
- 4:47 PM Changeset in webkit [237434] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 4:42 PM Changeset in webkit [237433] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/iframes/display-none-subframe.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=186406
Unreviewed.
Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-25
- platform/mac-wk1/TestExpectations: Mark test flaky.
- 4:09 PM Changeset in webkit [237432] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add corner rounding to the network timing "blocks"
https://bugs.webkit.org/show_bug.cgi?id=190379
Reviewed by Timothy Hatcher.
- UserInterface/Views/NetworkTableContentView.css:
(.waterfall .block):
(body[dir=ltr] .waterfall .block): Added.
(body[dir=rtl] .waterfall .block): Added.
(.network-table .waterfall .block + .block): Added.
(.network-table .waterfall .block.filler + .block, .network-table .waterfall .block:not(.request, .response) + :matches(.request, .response)): Added.
(.network-table .waterfall .block:last-child): Added.
- 3:59 PM Changeset in webkit [237431] by
-
- 21 edits in trunk
Web Inspector: display fullscreen enter/exit events in Timelines and Network node waterfalls
https://bugs.webkit.org/show_bug.cgi?id=189874
<rdar://problem/44700000>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Allow
datato be passed to the frontend withdidFireEvent.
Source/WebCore:
Updated existing test: http/tests/inspector/dom/didFireEvent.html
- inspector/agents/InspectorDOMAgent.h:
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::EventFiredCallback::handleEvent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::addEventListenersToNode):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::eventDidResetAfterDispatch): Added.
Prevent the same event from being sent to the frontend more than once.
- dom/Event.cpp:
(WebCore::Event::resetAfterDispatch):
- dom/Document.cpp:
(WebCore::Document::Document):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::eventDidResetAfterDispatch): Added.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::eventDidResetAfterDispatchImpl): Added.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Protocol/DOMObserver.js:
(WI.DOMObserver.prototype.didFireEvent):
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.didFireEvent):
Allowdatato be passed to the frontend withdidFireEvent.
- UserInterface/Models/DOMNode.js:
(WI.DOMNode):
(WI.DOMNode.getFullscreenDOMEvents): Added.
(WI.DOMNode.prototype.didFireEvent):
(WI.DOMNode.prototype._handleDOMNodeDidFireEvent): Added.
(WI.DOMNode.prototype._addDOMEvent):
(WI.DOMNode.prototype._shouldListenForEventListeners): Added.
If an event is fired on an ancestor of this node, also record that event in this node's
domEvents, including theoriginatornode.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
- UserInterface/Views/NetworkTableContentView.css:
(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-fullscreen): Added.
- UserInterface/Views/DOMEventsBreakdownView.js:
(WI.DOMEventsBreakdownView.prototype.initialLayout):
(WI.DOMEventsBreakdownView.prototype._populateTable):
- UserInterface/Views/DOMEventsBreakdownView.css:
(.dom-events-breakdown .graph > .area.fullscreen): Added.
(.dom-events-breakdown .inherited > .name, .dom-events-breakdown .inherited > .graph > .point): Added.
(.dom-events-breakdown:not(.has-inherited) .originator): Added.
LayoutTests:
- http/tests/inspector/dom/didFireEvent-expected.txt:
- http/tests/inspector/dom/didFireEvent.html:
- 3:57 PM Changeset in webkit [237430] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network: more aggressively snap timing blocks together
https://bugs.webkit.org/show_bug.cgi?id=190439
Reviewed by Timothy Hatcher.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.appendBlock):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
If the time difference between the end of the previous block and the start of this block
would result in less than 2px of space, extend the next block back to the previous block.
- 3:23 PM Changeset in webkit [237429] by
-
- 18 edits in trunk/Source
Cleanup: inline constexpr is redundant as constexpr implies inline
https://bugs.webkit.org/show_bug.cgi?id=190819
Reviewed by Mark Lam.
Source/bmalloc:
- bmalloc/Algorithm.h:
(bmalloc::max):
(bmalloc::min):
(bmalloc::mask):
(bmalloc::test):
(bmalloc::isPowerOfTwo):
(bmalloc::roundDownToMultipleOf):
(bmalloc::sizeOf):
(bmalloc::bitCount):
(bmalloc::log2):
- bmalloc/Bits.h:
(bmalloc::bitsArrayLength):
- bmalloc/Sizes.h:
(bmalloc::Sizes::maskSizeClass):
Source/JavaScriptCore:
- bytecode/ArrayProfile.h:
(JSC::asArrayModes):
- runtime/IndexingType.h:
(JSC::isCopyOnWrite):
- runtime/MathCommon.h:
(JSC::maxSafeInteger):
(JSC::minSafeInteger):
- runtime/StackAlignment.h:
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
Source/WTF:
- wtf/Bitmap.h:
(WTF::WordType>::Bitmap):
- wtf/LEBDecoder.h:
(WTF::LEBDecoder::maxByteLength):
- wtf/MathExtras.h:
(defaultMinimumForClamp):
(defaultMaximumForClamp):
(clampToAccepting64):
(isLessThan):
(isLessThanEqual):
(isGreaterThan):
(isGreaterThanEqual):
(WTF::roundUpToPowerOfTwo):
(WTF::maskForSize):
- wtf/Optional.h:
- wtf/PtrTag.h:
(WTF::tagCodePtr):
(WTF::untagCodePtr):
(WTF::retagCodePtr):
(WTF::removeCodePtrTag):
- wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):
- wtf/Variant.h:
(WTF::operator==):
(WTF::operator!=):
(WTF::operator>=):
(WTF::operator<=):
(WTF::operator>):
(WTF::operator<):
- wtf/text/StringImpl.h:
(WTF::StringImplShape::StringImplShape):
(WTF::StringImpl::StaticStringImpl::StaticStringImpl):
- 2:17 PM EnvironmentVariables edited by
- Add sandbox envvars (diff)
- 1:49 PM Changeset in webkit [237428] by
-
- 7 edits in tags/Safari-607.1.10.5/Source
Versioning.
- 1:09 PM Changeset in webkit [237427] by
-
- 1 copy in tags/Safari-607.1.10.5
New tag.
- 1:04 PM Changeset in webkit [237426] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=175597
XMLHttpRequest should not sniff content encoding
Actually, the discussion in Bugzilla claims that it should always have worked on
iOS. Not sure why the test was not enabled from the start.
- platform/ios/TestExpectations:
- 1:01 PM Changeset in webkit [237425] by
-
- 2 edits in trunk/LayoutTests
Update test results for https://bugs.webkit.org/show_bug.cgi?id=175597
XMLHttpRequest should not sniff content encoding
This code doesn't work like planned on macOS High Sierra, and I'm not sure what's
up with iOS and other platforms. But I can to re-enable the test for Mojave.
- platform/mac/TestExpectations: As expected, this test is passing on macOS Mojave.
- 12:55 PM Changeset in webkit [237424] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, silence a -Wreturn-type warning
When every return is supposed to be covered by a switch statement, a release assert or CRASH
is required by GCC.
- Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
(WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):
- 12:53 PM Changeset in webkit [237423] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, another try at fixing the GTK build with sandbox enabled
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::memfd_create): Deleted.
- 12:51 PM Changeset in webkit [237422] by
-
- 2 edits in trunk/Tools
Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
https://bugs.webkit.org/show_bug.cgi?id=190896
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-25
Reviewed by Matt Baker.
- Scripts/webkitpy/common/config/watchlist:
- 12:17 PM Changeset in webkit [237421] by
-
- 8 edits in trunk/Source
[Web Animations] Turn Web Animations CSS Integration off by default
https://bugs.webkit.org/show_bug.cgi?id=190901
Reviewed by Dean Jackson.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
- 10:44 AM Changeset in webkit [237420] by
-
- 3 edits in trunk/LayoutTests
[High Sierra/Sierra Release] Layout Test media/track/track-cue-css.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=190876
Reviewed by Alexey Proskuryakov.
This is a speculative fix; avoid an unnecessary video seek step in test.
- media/track/track-cue-css-expected.html:
- media/track/track-cue-css.html:
- 10:41 AM Changeset in webkit [237419] by
-
- 12 edits in trunk
HashMap should support selecting a random entry
https://bugs.webkit.org/show_bug.cgi?id=190814
Reviewed by Antti Koivisto.
Source/WTF:
In some cases, remove(begin()) is not quite good enough as a random
eviction strategy. (See https://bugs.webkit.org/show_bug.cgi?id=190792.)
So, let's support real random eviction.
(And by "real" I mean "pseudo".)
- wtf/HashCountedSet.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
- wtf/ListHashSet.h:
(WTF::ListHashSet::random):
(WTF::ListHashSet::random const):
- wtf/LoggingHashMap.h:
- wtf/LoggingHashSet.h: Plumb through the random() iterator.
- wtf/HashTable.h:
(WTF::HashTable::random):
(WTF::HashTable::random const): Implement the random() iterator.
makeIterator() already supports starting from any bucket, so this is
pretty easy.
In the subtle case where we select end(), we choose to wrap around and
return begin(). We expect that clients don't really think of the end()
bucket as being in the domain of the random search. Also, we don't want
to annoy clients who know their tables are non-empty with needless
checks for end().
- wtf/RandomNumber.cpp:
(WTF::weakRandomUint32):
- wtf/RandomNumber.h: Added a free function for weak random numbers so
that clients that want cheap random numbers aren't required to allocate
storage for a WeakRandom generator.
Tools:
Unit testing is fun and easy!
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::ZeroHash::hash):
(TestWebKitAPI::TEST):
- 10:09 AM Changeset in webkit [237418] by
-
- 4 edits in trunk
Source/WebCore:
Changed "Under Development" status to use "In Development" instead
https://bugs.webkit.org/show_bug.cgi?id=187615
Reviewed by Joseph Pecoraro.
- features.json: Updated CSS Painting API Level 1 and CSS Properties and Values API Level 1.
Websites/webkit.org:
Added support for "deprecated" feature status
https://bugs.webkit.org/show_bug.cgi?id=187615
Reviewed by Joseph Pecoraro.
- wp-content/themes/webkit/status.php:
- 10:06 AM Changeset in webkit [237417] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, try to fix GTK build with sandbox enabled
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
- 9:33 AM Changeset in webkit [237416] by
-
- 2 edits in trunk/Source/WebKitLegacy
[CMake][Ninja][Win] midl.exe fails to create, open and write a temporary file in parallel build in Docker container
https://bugs.webkit.org/show_bug.cgi?id=187725
Reviewed by Michael Catanzaro.
- PlatformWin.cmake: Added USES_TERMINAL to serialize midl.exe
executions.
- 8:55 AM Changeset in webkit [237415] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Follow-up fixes to the certificate coders
https://bugs.webkit.org/show_bug.cgi?id=190900
Reviewed by Michael Catanzaro.
Cleanup the GRefPtr mess I created earlier. Also we now bail out
if any certificate in the chain has no data instead of returning a
cropped chain.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<CertificateInfo>::encode):
(IPC::ArgumentCoder<CertificateInfo>::decode):
- 7:53 AM Changeset in webkit [237414] by
-
- 2 edits in trunk
[GTK] Reenable the sandbox
Previously reviewed by, er, myself. This just reverts the sabotague as our bots should have
the required deps now. Hopefully.
- Source/cmake/OptionsGTK.cmake:
- 7:15 AM Changeset in webkit [237413] by
-
- 3 edits2 adds in trunk
REGRESSION (236779) scandinaviandesigns.com product pages auto redirect to product image
https://bugs.webkit.org/show_bug.cgi?id=190891
<rdar://problem/45296796>
Reviewed by Antti Koivisto.
Source/WebCore:
When a radio element gets clicked, we should only fire the 'input' and 'change' if the checked state
of the radio element has changed.
Test: fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html
- html/RadioInputType.cpp:
(WebCore::RadioInputType::didDispatchClick):
LayoutTests:
Add layout test coverage.
- fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes-expected.txt: Added.
- fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html: Added.
- 7:03 AM Changeset in webkit [237412] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2018-10-25
- platform/ios-wk1/TestExpectations: Add failures for tests requiring findString.
- platform/ios-wk1/fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Added. Adjust
expectation to handle whitespace difference.
- platform/ios-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added. The
scrolling tree is not displayed on WK1.
- 5:46 AM Changeset in webkit [237411] by
-
- 2 edits8 adds in trunk/LayoutTests
Add more tests for the Find UI
https://bugs.webkit.org/show_bug.cgi?id=190823
Patch by Frederic Wang <fwang@igalia.com> on 2018-10-25
Reviewed by Antonio Gomes.
We add more tests for iOS's find UI to cover cases fixed by r224284. Equivalent tests for
subframes currently fails when frame flattening is disabled, they will be handled in bug
184297.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.png: Added.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.txt: Added.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.png: Added.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.txt: Added.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit.html: Added.
Test with a match at the limit of the scrolling element.
- platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position.html: Added. Test
with a match at the middle of the scrolling element.
- platform/ios/fast/scrolling/find-text-in-overflow-node.html: Use names for parameters to
make it more explicit.
- platform/ios/fast/scrolling/find-text-in-subframe-expected.txt: Added.
- platform/ios/fast/scrolling/find-text-in-subframe.html: Added. Test with a subframe instead
of an overflow node.
- 5:07 AM WebKitGTK/2.22.x edited by
- (diff)
- 4:09 AM Changeset in webkit [237410] by
-
- 13 edits in trunk/Source/WebKit
[GTK][AC] Resizing the window doesn't always update the visible rect
https://bugs.webkit.org/show_bug.cgi?id=189743
Reviewed by Michael Catanzaro.
Disassociate resizing that can be done on an AcceleratedSurface object
between "host resizes" and "client resizes".
The former is done from ThreadedCoordinatedLayerTreeHost directly, and
is currently used only for GTK on X11, where a new pixmap object is
created on each resize, which affects the context ID that is based on
that pixmap object's address.
The latter is done from the composition thread. It's used for GTK on
Wayland and WPE. In both cases, the underlying window object does not
change on each resize, but it's necessary to perform the actual resize
on the composition thread.
So far it hasn't been performed there, which ended up pushing sizes of
the WebKit view and the underlying window object out of sync during
resizing, leaving parts of window unrendered.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::renderLayerTree):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- WebProcess/WebPage/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::hostResize):
(WebKit::AcceleratedSurface::resize): Deleted.
- WebProcess/WebPage/AcceleratedSurface.h:
(WebKit::AcceleratedSurface::clientResize):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:
(WebKit::AcceleratedSurfaceWayland::clientResize):
(WebKit::AcceleratedSurfaceWayland::resize): Deleted.
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:
- WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:
(WebKit::AcceleratedSurfaceX11::hostResize):
(WebKit::AcceleratedSurfaceX11::resize): Deleted.
- WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h:
- WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:
(WebKit::AcceleratedSurfaceWPE::clientResize):
(WebKit::AcceleratedSurfaceWPE::resize): Deleted.
- WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.h:
- 1:34 AM Changeset in webkit [237409] by
-
- 6 edits in trunk/Source/WebCore
InspectorCanvas is not getting cleared properly for OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=190894
<rdar://problem/45498435>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-25
Reviewed by Simon Fraser.
Covered by existing tests not crashing with guard malloc.
InspectorCanvasAgents tracks all CanvasRenderingContexts and needs to
remove its reference when the containing CanvasBase goes away. It does
this by registering as a notification observer, but if it can't map
from the CanvasBase back to the rendering context we were failing to
remove our reference. Enforce CanvasBase classes to notify observers
of destruction while they still have their CanvasRenderingContext.
- html/CanvasBase.cpp:
(WebCore::CanvasBase::~CanvasBase):
(WebCore::CanvasBase::notifyObserversCanvasDestroyed):
- html/CanvasBase.h:
Assert that subclasses notify observers of the canvas being destroyed,
since they will need to do this before m_context is cleared.
- html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::~CustomPaintCanvas):
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::~OffscreenCanvas):
Follow the new expected pattern of notifying observers before clearing
the context. HTMLCanvasElement already followed this pattern.
- inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::canvasDestroyed):
Add an assertion that would catch this earlier.
- 12:24 AM Changeset in webkit [237408] by
-
- 7 edits in trunk/LayoutTests
[WPT] Update resource-timing WPT tests to use the right cross origin
https://bugs.webkit.org/show_bug.cgi?id=190554
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- web-platform-tests/resource-timing/resource_TAO_cross_origin_redirect_chain-expected.txt:
- web-platform-tests/resource-timing/resource_TAO_cross_origin_redirect_chain.html:
- web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain-expected.txt:
- web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html:
LayoutTests:
Oct 24, 2018:
- 11:12 PM Changeset in webkit [237407] by
-
- 2 edits in trunk/Tools
REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
https://bugs.webkit.org/show_bug.cgi?id=190897
- TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(TestWebKitAPI::TEST):
Disable the test for now.
- 10:02 PM Changeset in webkit [237406] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 68
Added a tag for Safari Technology Preview release 68.
- 5:19 PM Changeset in webkit [237405] by
-
- 18 edits in trunk
Clean up some obsolete macOS version guards
https://bugs.webkit.org/show_bug.cgi?id=190887
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wouldTaintOrigin const):
Source/WebCore/PAL:
- pal/spi/mac/TUCallSPI.h:
Source/WebKit:
- PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Source/WebKitLegacy/mac:
- Misc/WebNSPasteboardExtras.mm:
(+[NSPasteboard _web_dragTypesForURL]):
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::respondToChangedSelection):
- WebView/WebPDFView.mm:
(-[WebPDFView _clipViewForPDFDocumentView]):
Tools:
- TestWebKitAPI/cocoa/TestWKWebView.mm:
(simulated_forceClickAssociatedEventsMask):
(-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
- 4:52 PM Changeset in webkit [237404] by
-
- 1 copy in tags/Safari-606.3.2
Tag Safari-606.3.2.
- 3:51 PM Changeset in webkit [237403] by
-
- 6 edits2 adds in trunk
Attachment filenames with RTL characters should format similar to Finder
https://bugs.webkit.org/show_bug.cgi?id=190736
<rdar://problem/44735946>
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/attachment/attachment-title-with-rtl.html
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const):
- html/HTMLAttachmentElement.h:
Add attachmentTitleForDisplay(), which wraps the non-extension part of
attachmentTitle in BiDi isolates, matching Finder's behavior.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderAttachmentInfo::buildWrappedLines):
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
- rendering/RenderThemeMac.mm:
(WebCore::AttachmentLayout::layOutTitle):
Adopt attachmentTitleForDisplay, and ask CoreText to use a subrange of
the original string for the last line, instead of splitting the string
ourselves. This ensures that BiDi control characters are respected
even in the last line of the string.
LayoutTests:
- fast/attachment/attachment-title-with-rtl-expected.html: Added.
- fast/attachment/attachment-title-with-rtl.html: Added.
Add a test that directionality marks in the attachment's title are
isolated from the file extension.
- 3:28 PM Changeset in webkit [237402] by
-
- 24 edits in trunk
Turn on Conic Gradients
https://bugs.webkit.org/show_bug.cgi?id=190810
Reviewed by Tim Horton.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Added tests previously, only switching feature from experimental to always avaiable.
- Configurations/FeatureDefines.xcconfig:
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
- css/parser/CSSParserContext.h:
(WebCore::CSSParserContextHash::hash):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeConicGradient):
- page/Settings.yaml:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
Remove conic gradients from experimental features and turn it on always.
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
No longer necessary to manually turn on conic gradients for testing.
- http/wpt/css/css-images-4/conic-gradient-parsing.html:
- 3:12 PM Changeset in webkit [237401] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: popovers for function source code are malformed
https://bugs.webkit.org/show_bug.cgi?id=190859
Reviewed by Joseph Pecoraro.
Previously, the
WI.Popoverwould be drawn twice: once when the
WI.CodeMirrorTokenTrackingControllerdetermines that the user has hovered on a function
token, and once again when the source for that function is formatted (after being retrieved).
In the case that the formatter is able to return the prettified source within a frame (or
two), theWI.Popoveris still in the middle of animating to its new size, meaning that the
changes made by the formattedupdatewill be overridden on the next rAF (creates a flash).
- UserInterface/Views/Popover.js:
(WI.Popover.prototype):
(WI.Popover.prototype._animateFrame.drawBackground):
(WI.Popover.prototype._drawBackground):
Add a member variable to make sure that there is only ever one rAF firing at a time.
Drive-by: rework the background code to only use one canvas.
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Don't show theWI.Popoveruntil the formatter has finished prettifying the function's
source code, as otherwise there is brief moment that the popover appears and is empty.
- 2:35 PM Changeset in webkit [237400] by
-
- 2 edits in trunk/Source/JavaScriptCore
2018-10-24 Michael Saboff <msaboff@apple.com>
Increase executable memory pool from 64MB to 128MB for ARM64
https://bugs.webkit.org/show_bug.cgi?id=190453
Unreviewed, rolling back in r237024.
The original change did impact ARES-6 performance by 4-8%. That will
be investigated separately.
- 2:01 PM Changeset in webkit [237399] by
-
- 9 edits in trunk/Source/bmalloc
Add BPLATFORM(IOS_FAMILY)
https://bugs.webkit.org/show_bug.cgi?id=190878
Reviewed by Saam Barati.
- bmalloc/AvailableMemory.cpp:
(bmalloc::memorySizeAccordingToKernel):
(bmalloc::computeAvailableMemory):
- bmalloc/AvailableMemory.h:
(bmalloc::isUnderMemoryPressure):
- bmalloc/BPlatform.h:
- bmalloc/Gigacage.h:
- bmalloc/Logging.cpp:
(bmalloc::logVMFailure):
- bmalloc/VMAllocate.h:
(bmalloc::vmPageSizePhysical):
- bmalloc/bmalloc.h:
- bmalloc/darwin/MemoryStatusSPI.h:
- 1:41 PM Changeset in webkit [237398] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 1:19 PM Changeset in webkit [237397] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r237232): changing resources via up/down blurs the TreeOutline in Resources
https://bugs.webkit.org/show_bug.cgi?id=190862
Reviewed by Matt Baker.
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.set selectedTextRange):
Don'tfocusunless theactiveElementis not a WebInspector element (e.g. <body>),
meaning that the previously focused element has been removed from the DOM and no longer
needs to keep the focus.
- 12:27 PM Changeset in webkit [237396] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: CSP request payload on medium.com is unreadable, should be pretty-printed
https://bugs.webkit.org/show_bug.cgi?id=190354
<rdar://problem/45090894>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.set string.update):
(WI.TextEditor.prototype._attemptToDetermineMIMEType): Added.
If the content doesn't already have a MIME type, attempt to determine one by trying to
format it as "javascript" (e.g. request JSON that is simply missing a MIME type).
- UserInterface/Views/TextContentView.js:
(WI.TextContentView):
(WI.TextContentView.prototype._handleTextEditorMIMETypeChanged): Added.
- UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView):
(WI.TextResourceContentView.prototype._handleTextEditorMIMETypeChanged): Added.
- UserInterface/Views/ScriptContentView.js:
(WI.ScriptContentView):
(WI.ScriptContentView.prototype._handleTextEditorMIMETypeChanged): Added.
Enable the "Pretty Print" navigation button if the MIME type changes to something that is
able to be formatted.
Drive-by: reorder the creation of the "Pretty Print" button so that it exists if
_attemptToDetermineMIMETypefinishes synchronously.
- 11:49 AM Changeset in webkit [237395] by
-
- 5 edits5 adds in trunk
Only report resource timing to parent frame for the first iframe load
https://bugs.webkit.org/show_bug.cgi?id=190498
<rdar://problem/44347398>
Reviewed by Youenn Fablet.
Source/WebCore:
Only the first iframe navigation or the first iframe navigation after about:blank should be reported.
https://www.w3.org/TR/resource-timing-2/#resources-included-in-the-performanceresourcetiming-interface
Test: http/tests/misc/resource-timing-navigation-in-restored-iframe.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- loader/FrameLoader.h:
(WebCore::FrameLoader::shouldReportResourceTimingToParentFrame):
(WebCore::FrameLoader::setShouldReportResourceTimingToParentFrame): Deleted.
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
LayoutTests:
The layout test is from Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/1186215.
- http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt: Added.
- http/tests/misc/resource-timing-navigation-in-restored-iframe.html: Added.
- http/tests/misc/resources/alert-then-back.html: Added.
- http/tests/misc/resources/navigate-on-message.html: Added.
- http/tests/misc/resources/post-message-to-parent.html: Added.
- 11:46 AM Changeset in webkit [237394] by
-
- 17 edits in trunk/Source/WebCore
Cure Windows Direct2D Backend of a nasty case of bitrot
https://bugs.webkit.org/show_bug.cgi?id=190875
<rdar://problem/45523268>
Reviewed by Zalan Bujtas.
The Direct2D backend has drifted out of date with the rest of WebKit.
This patch updates things so we can get a runnable build.
- platform/graphics/FontPlatformData.h:
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::create):
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageDecoder.h:
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::setTargetContext):
- platform/graphics/opentype/OpenTypeMathData.cpp:
(WebCore::OpenTypeMathData::OpenTypeMathData): Need non-default constructor to make Visual
Studio happy.
- platform/graphics/win/GradientDirect2D.cpp:
(WebCore::Gradient::generateGradient):
- platform/graphics/win/GraphicsContextDirect2D.cpp: Update for new display list implementation.
(WebCore::GraphicsContextPlatformPrivate::setAlpha):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipBounds const):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM const):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext const):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext const):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
- platform/graphics/win/GraphicsLayerDirect2D.cpp:
(WebCore::GraphicsLayer::create):
(): Deleted.
- platform/graphics/win/ImageBufferDataDirect2D.cpp:
(WebCore::ImageBufferData::putData):
- platform/graphics/win/ImageBufferDataDirect2D.h:
- platform/graphics/win/ImageBufferDirect2D.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/win/ImageDecoderDirect2D.cpp:
(WebCore::ImageDecoderDirect2D::bytesDecodedToDetermineProperties const):
(WebCore::ImageDecoderDirect2D::encodedDataStatus const):
(WebCore::ImageDecoderDirect2D::repetitionCount const):
(WebCore::ImageDecoderDirect2D::frameOrientationAtIndex const):
(WebCore::ImageDecoderDirect2D::frameDurationAtIndex const):
(WebCore::ImageDecoderDirect2D::frameAllowSubsamplingAtIndex const):
(WebCore::ImageDecoderDirect2D::frameHasAlphaAtIndex const):
(WebCore::ImageDecoderDirect2D::createFrameImageAtIndex):
(WebCore::ImageDecoderDirect2D::setData):
(WebCore::ImageDecoderDirect2D::bytesDecodedToDetermineProperties): Deleted.
(WebCore::ImageDecoderDirect2D::createFrameImageAtIndex const): Deleted.
- platform/graphics/win/ImageDecoderDirect2D.h:
- platform/graphics/win/ImageDirect2D.cpp:
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/graphics/win/PatternDirect2D.cpp:
(WebCore::Pattern::createPlatformPattern const):
- 11:42 AM Changeset in webkit [237393] by
-
- 17 edits in trunk/Source
Cleanup: MIMETypeRegistry functions
https://bugs.webkit.org/show_bug.cgi?id=190838
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-10-24
Reviewed by Simon Fraser.
Source/WebCore:
Modernize the initialization of the lists in MIMETypeRegistry. Make the
functions that return these list be self-contained. Use NeverDestroy<> to
allocate the local static variable. Use std::initializer_list() and
makeNeverDestroyed() to initialize NeverDestroy<> variables only once.
supportedImageResourceMIMETypes will be deleted and all the calls to it
will be replaced by supportedImageMIMETypes because they are identical.
- loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes): This function
is called while initializing the supportedNonImageMIMETypes(). So it
should not have a direct call to it. Instead, supportedNonImageMIMETypes
is passed to it.
- loader/archive/ArchiveFactory.h:
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::supportedImageMIMETypes):
(WebCore::supportedImageMIMETypesForEncoding):
(WebCore::supportedJavaScriptMIMETypes):
(WebCore::MIMETypeRegistry::supportedNonImageMIMETypes):
(WebCore::MIMETypeRegistry::supportedMediaMIMETypes):
(WebCore::pdfMIMETypes):
(WebCore::MIMETypeRegistry::unsupportedTextMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::isPDFMIMEType):
(WebCore::MIMETypeRegistry::systemPreviewMIMETypes):
(WebCore::MIMETypeRegistry::isSystemPreviewMIMEType):
(WebCore::initializeSupportedImageMIMETypes): Deleted.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Deleted.
(WebCore::initializeSupportedJavaScriptMIMETypes): Deleted.
(WebCore::initializePDFMIMETypes): Deleted.
(WebCore::initializeSupportedNonImageMimeTypes): Deleted.
(WebCore::initializeSupportedMediaMIMETypes): Deleted.
(WebCore::initializeUnsupportedTextMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): Deleted.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getPDFMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes): Deleted.
(WebCore::MIMETypeRegistry::getSystemPreviewMIMETypes): Deleted.
- platform/MIMETypeRegistry.h:
- platform/graphics/Image.cpp:
(WebCore::Image::supportsType):
- platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoderCG::encodedDataStatus const):
- platform/graphics/cg/UTIRegistry.cpp:
(WebCore::supportedDefaultImageSourceTypes):
(WebCore::isSupportImageSourceType):
(WebCore::allowedImageUTIs): Deleted.
(WebCore::isAllowedImageUTI): Deleted.
- platform/graphics/cg/UTIRegistry.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::write):
Source/WebKit:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry initWithConfiguration:]):
Source/WebKitLegacy/mac:
- Misc/WebNSPasteboardExtras.mm:
(-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
because they were identical.
- WebView/WebHTMLRepresentation.mm:
(+[WebHTMLRepresentation supportedMediaMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
- WebView/WebView.mm:
(+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
(+[WebView _registerViewClass:representationClass:forURLScheme:]):
(+[WebView registerViewClass:representationClass:forMIMEType:]):
- 11:26 AM Changeset in webkit [237392] by
-
- 2 edits in trunk/LayoutTests
[macOS] Layout Test legacy-animation-engine/animations/suspend-resume-animation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=190883
Unreviewed test gardening.
- platform/mac/TestExpectations: Mark test as flaky.
- 11:24 AM Changeset in webkit [237391] by
-
- 2 edits in trunk/LayoutTests
Marked webgl/1.0.2/conformance/glsl/misc/shader-with-reserved-words.html as a flaky timout.
https://bugs.webkit.org/show_bug.cgi?id=170877
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:44 AM Changeset in webkit [237390] by
-
- 3 edits in trunk/Tools
[WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
https://bugs.webkit.org/show_bug.cgi?id=190328
Patch by Pablo Saavedra <Pablo Saavedra> on 2018-10-24
Reviewed by Michael Catanzaro.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformWPE.cmake:
- 10:18 AM Changeset in webkit [237389] by
-
- 4 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r236227. rdar://problem/45491949
Crash under WebPageProxy::decidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=189763
<rdar://problem/44597111>
Reviewed by Alex Christensen.
Update WebNavigationState::navigation() / WebNavigationState::takeNavigation()
to return a pointer instead of a reference as we have evidence that they can
return null. I kept the debug assertions to try and catch the cases where we
return null but at least we stop crashing in release builds.
- UIProcess/WebNavigationState.cpp: (WebKit::WebNavigationState::navigation): (WebKit::WebNavigationState::takeNavigation):
- UIProcess/WebNavigationState.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:56 AM Changeset in webkit [237388] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r236747. rdar://problem/45491954
Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
https://bugs.webkit.org/show_bug.cgi?id=190178
Reviewed by Chris Dumez.
This would help debug rdar://problem/44902833.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:56 AM Changeset in webkit [237387] by
-
- 8 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234791. rdar://problem/45491958
CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient(WebCore::IDBServer::UniqueIDBDatabaseConnection&)
https://bugs.webkit.org/show_bug.cgi?id=188474
Reviewed by Chris Dumez.
UniqueIDBDatabaseConnection is refcounted by UniqueIDBDatabaseTransaction and it refcounts
UniqueIDBDatabaseTransaction. This cycle could make UniqueIDBDatabaseConnection outlives
UniqueIDBDatabase, so its reference to UniqueIDBDatabase may be stale. Calling a function
on a stale object is probably the reason of recent various storage process crashes in
indexedDB.
This patch makes m_database a WeakPtr and adds assertions that could help us debug the
crashes.
- Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince): (WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction): (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp: (WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection): (WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection): (WebCore::IDBServer::UniqueIDBDatabaseConnection::abortTransactionWithoutCallback): (WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient): (WebCore::IDBServer::UniqueIDBDatabaseConnection::confirmDidCloseFromServer): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didFireVersionChangeEvent): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didFinishHandlingVersionChange): (WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction): (WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction): (WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: (WebCore::IDBServer::UniqueIDBDatabaseConnection::database):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp: (WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::~UniqueIDBDatabaseTransaction): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::abort): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::commit): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::createObjectStore): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteObjectStore): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::renameObjectStore): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::clearObjectStore): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::createIndex): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteIndex): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::renameIndex): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::putOrAdd): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::getRecord): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::getAllRecords): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::getCount): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteRecord): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::openCursor): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::iterateCursor): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::objectStoreIdentifiers):
- Modules/indexeddb/shared/IDBResultData.cpp: (WebCore::IDBResultData::openDatabaseSuccess): (WebCore::IDBResultData::openDatabaseUpgradeNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:39 AM Changeset in webkit [237386] by
-
- 4 edits in trunk
[PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=190846
<rdar://problem/45058938>
Reviewed by Antti Koivisto.
Source/WebCore:
When a page gets suspended after a process-swap, we navigate it to about:blank from inside the navigation
policy handler, by overriding the request URL. This normally works fine because we usually process-swap
on standard navigation. However, when we would process-swap on a back/forward navigation, we would end
up using the back/forward navigation load type to do the about:blank load. This would have repercussions
because history navigations update the current history item with the new URL (in this case 'about:blank').
To avoid the issue, switch to a standard load type whenever the client asks us to suspend and we load
'about:blank' as a result.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 9:33 AM Changeset in webkit [237385] by
-
- 4 edits in trunk/LayoutTests
Marking Multiple tests as flakey at once
https://bugs.webkit.org/show_bug.cgi?id=190847
Unreviewed Test Gardening
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 8:38 AM Changeset in webkit [237384] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r237257): [iOS] Crashes in com.apple.WebKit: WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit
https://bugs.webkit.org/show_bug.cgi?id=190804
Reviewed by Alex Christensen.
Fix null-dereference of the drawing area in RemoteScrollingCoordinator::scheduleTreeStateCommit.
With process-swap-on-navigation enabled, suspended pages' drawing area gets torn down.
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
- 7:32 AM Changeset in webkit [237383] by
-
- 2 edits1 add in trunk/Tools
[GTK] TestSSL failing because of missing libsoup patch
https://bugs.webkit.org/show_bug.cgi?id=190869
Reviewed by Michael Catanzaro.
- gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
- gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
- 7:27 AM Changeset in webkit [237382] by
-
- 4 edits2 adds in trunk/Source/WTF
[Win] Add function call name information to stack traces
https://bugs.webkit.org/show_bug.cgi?id=190761
Reviewed by Fujii Hironori.
Add symbol information to stack traces using dbghelp.dll
This library will use symbols files from these sources:
- The current working directory
- The directory containing the application's executable
- _NT_SYMBOL_PATH environment variable
- _NT_ALTERNATE_SYMBOL_PATH environment variable
This functionality is currently only enabled in debug mode since dbghelp is not threadsafe.
The DbgHelper class attempts to synchronize calls to dbghelp.dll but external code
can still attempt to call the library at the same time as WebKit.
- wtf/CMakeLists.txt:
- wtf/PlatformWin.cmake:
- wtf/StackTrace.cpp:
- wtf/win/DbgHelperWin.cpp: Added.
- wtf/win/DbgHelperWin.h: Added.
- 7:15 AM Changeset in webkit [237381] by
-
- 4 edits in trunk
[macOS Debug WK2] Layout Test http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=190650
<rdar://problem/45341914>
Reviewed by Alex Christensen.
Source/WebCore:
In computeErrors, we intend to ignore errors when computing paymentMethodErrors. But we
weren't clearing exceptions generated from calling convert(), so they would end up being
logged as unhandled promise rejections.
Changed ApplePayPaymentHandler::computeErrors() to use a CatchScope to clear exceptions when
decoding paymentMethodErrors.
Also changed ApplePayShippingAddressChangeEventErrorsV3.https.html to catch promise
rejections from calling PaymentRequest.abort().
Covered by existing test.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::computeErrors const):
LayoutTests:
- http/tests/resources/payment-request.js:
(updateDetailsOnShippingAddressChange):
- 6:45 AM Changeset in webkit [237380] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Cleanups to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=190867
Reviewed by Žan Doberšek.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<CertificateInfo>::decode):
- 3:20 AM Changeset in webkit [237379] by
-
- 2 edits in trunk/Source/WebCore
topPrivatelyControlledDomain is slow
https://bugs.webkit.org/show_bug.cgi?id=190792
Reviewed by Alex Christensen and Chris Dumez.
It calls into some slowish CFNetwork code and ends up showing up in profiles.
- platform/mac/PublicSuffixMac.mm:
(WebCore::topPrivatelyControlledDomain):
Add a cache that avoids calls into frameworks.
- 3:03 AM Changeset in webkit [237378] by
-
- 5 edits in trunk/Source/WebCore
Use WeakPtr and GenericTaskQueue within ObjC classes used by MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=190790
Reviewed by Alex Christensen.
Move towards using WeakPtr callbacks instead of raw pointers within the utility objects used by
MediaPlayerPrivateAVFoundationObjC. Additionally, accessing WeakPtr off the thread which created
the pointer is not allowed, so use a GenericTaskQueue to schedule callbacks instead. Make
GenericTaskQueue<Timer> thread-safe by locking around access to m_pendingTasks, and by making
incrementing the pending task count atomic.
- platform/GenericTaskQueue.cpp:
(WebCore::TaskDispatcher<Timer>::postTask):
(WebCore::TaskDispatcher<Timer>::sharedLock):
(WebCore::TaskDispatcher<Timer>::sharedTimerFired):
(WebCore::TaskDispatcher<Timer>::dispatchOneTask):
(WebCore::TaskDispatcher<Timer>::pendingDispatchers):
- platform/GenericTaskQueue.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
(-[WebCoreAVFMovieObserver initWithPlayer:]):
(-[WebCoreAVFMovieObserver disconnect]):
(-[WebCoreAVFMovieObserver metadataLoaded]):
(-[WebCoreAVFMovieObserver didEnd:]):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFLoaderDelegate initWithPlayer:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
(-[WebCoreAVFPullDelegate initWithPlayer:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFMovieObserver initWithCallback:]): Deleted.
(-[WebCoreAVFLoaderDelegate initWithCallback:]): Deleted.
(-[WebCoreAVFLoaderDelegate setCallback:]): Deleted.
(-[WebCoreAVFPullDelegate initWithCallback:]): Deleted.
(-[WebCoreAVFPullDelegate setCallback:]): Deleted.
- 2:10 AM Changeset in webkit [237377] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Cleanups to the certificate encoder
https://bugs.webkit.org/show_bug.cgi?id=190865
Reviewed by Žan Doberšek.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<CertificateInfo>::encode):
- 2:05 AM Changeset in webkit [237376] by
-
- 11 edits2 adds in trunk
TextTrack cues should be updated more often than every 250ms.
https://bugs.webkit.org/show_bug.cgi?id=190827
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-timing.html
TextTracks cues are recalculated on the playback timer, which fires at least every 250ms.
In addition to this timer, add a method to MediaPlayer to provide a task which will be
performed at a particular media time, and use this new method to request cues be updated
at the next interesting media time. The next interesting time would be either when the
soonest current cue will end, or when the next non-current cue will start, whichever is
earlier.
(Determining the "next non-current cue" requires new API on PODIntervalTree, as that class
does not have iterators per-se.)
- html/HTMLMediaElement.cpp:
(WebCore::compareCueIntervalEndTime):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
- platform/PODIntervalTree.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::performTaskAtMediaTime):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::performTaskAtMediaTime):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
LayoutTests:
Add a LayoutTest which plays back 6s of captions, each 50 ms in duration, and uses
when the "enter" and "exit" were fired (in media time) to check whether they were missed
or not. The test succeeds if fewer than 50 of the 120 cues were missed.
- media/track/track-cue-missing-expected.txt: Added.
- media/track/track-cue-missing.html: Added.
