Timeline

Nov 1, 2018:

11:35 PM Changeset in webkit [237721] by jiewen_tan@apple.com

• 11 edits
  1 delete in trunk/Source

Replace CommonRandom SPI with API
​https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

• bmalloc/CryptoRandom.cpp:

(bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

• crypto/CommonCryptoUtilities.h:
• crypto/mac/CryptoKeyMac.cpp:

(WebCore::CryptoKey::randomData):

• crypto/mac/SerializedCryptoKeyWrapMac.mm:

(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):

• page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/RandomDevice.cpp:

(WTF::RandomDevice::cryptographicallyRandomValues):

• wtf/spi/darwin/CommonCryptoSPI.h: Removed.

9:11 PM Changeset in webkit [237720] by Devin Rousso

• 5 edits in trunk

Web Inspector: View: introduce a didLayoutSubtree
​https://bugs.webkit.org/show_bug.cgi?id=191176

Reviewed by Matt Baker.

Source/WebInspectorUI:

Introduce logic to allow subclasses of WI.View to perform logic after every WI.View in
their subtree has finished layout.

• UserInterface/Views/View.js:

(WI.View.prototype.didLayoutSubtree): Added.
(WI.View.prototype._layoutSubtree):

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype.didLayoutSubtree): Added.

LayoutTests:

• inspector/view/resources/test-view.js:

(TestPage.registerInitializer.WI.TestView.prototype.layout):
(TestPage.registerInitializer.WI.TestView.prototype.didLayoutSubtree): Added.

8:50 PM Changeset in webkit [237719] by bshafiei@apple.com

• 7 edits in tags/Safari-607.1.12.1/Source

Versioning.

8:48 PM Changeset in webkit [237718] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.12.1

Tag Safari-607.1.12.1.

8:35 PM Changeset in webkit [237717] by Chris Dumez

• 34 edits in trunk/Source/WebCore

[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
​https://bugs.webkit.org/show_bug.cgi?id=191162

Reviewed by Alex Christensen.

Rename CallWith=ScriptState to CallWith=ExecState in our Web IDL as ScriptState is no longer a thing
in modern WebKit. The implementation is actually passed an ExecState nowadays.

• Modules/applepay/ApplePaySession.idl:
• Modules/encryptedmedia/MediaKeyStatusMap.idl:
• Modules/fetch/FetchBody.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/IDBIndex.idl:
• Modules/indexeddb/IDBKeyRange.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• animation/Animatable.idl:
• animation/KeyframeEffect.idl:
• animation/KeyframeEffectReadOnly.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):
(GenerateConstructorDefinition):

• bindings/scripts/IDLAttributes.json:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjWithExecStateAttributeGetter):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttributeSetter):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpacesBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces):
(WebCore::jsTestObjWithScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpacesBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): Deleted.

• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestPromiseRejectionEvent.idl:
• crypto/SubtleCrypto.idl:
• dom/Element.idl:
• dom/ErrorEvent.idl:
• dom/MessagePort.idl:
• dom/MouseEvent.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLFrameElement.idl:
• html/OffscreenCanvas.idl:
• html/track/DataCue.idl:
• inspector/CommandLineAPIHost.idl:
• page/DOMWindow.idl:
• page/RemoteDOMWindow.idl:
• page/WindowOrWorkerGlobalScope.idl:
• testing/Internals.idl:
• workers/DedicatedWorkerGlobalScope.idl:
• workers/Worker.idl:

7:04 PM Changeset in webkit [237716] by Ross Kirsling

• 2 edits in trunk/Tools

build-jsc --wincairo should update WinCairo libraries
​https://bugs.webkit.org/show_bug.cgi?id=191170

Reviewed by Fujii Hironori.

• Scripts/build-jsc:

6:24 PM Changeset in webkit [237715] by Alan Coon

• 1 copy in tags/Safari-606.3.4.0.1

Tag Safari-606.3.4.0.1.

6:13 PM Changeset in webkit [237714] by Fujii Hironori

• 18 edits
  2 moves in trunk/Source

Rename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid conflicting with ICU's unicode/utf8.h
​https://bugs.webkit.org/show_bug.cgi?id=189693

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• API/JSClassRef.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
• API/JSStringRef.cpp: Ditto.
• runtime/JSGlobalObjectFunctions.cpp: Ditto.
• wasm/WasmParser.h: Ditto.

Source/WebCore:

No new tests because there's no behaviro changes.

• platform/SharedBuffer.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
• xml/XSLTProcessorLibxslt.cpp: Ditto.
• xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.

Source/WebKit:

• Shared/API/APIString.h: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.

Source/WTF:

• WTF.xcodeproj/project.pbxproj: Replaced unicode/UTF8.{cpp,h} with unicode/UTF8Conversion.{cpp,h}.
• wtf/CMakeLists.txt: Ditto.
• wtf/text/AtomicStringImpl.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
• wtf/text/StringImpl.cpp: Ditto.
• wtf/text/StringView.cpp: Ditto.
• wtf/text/WTFString.cpp: Ditto.
• wtf/unicode/UTF8Conversion.cpp: Renamed from Source/WTF/wtf/unicode/UTF8.cpp.
• wtf/unicode/UTF8Conversion.h: Renamed from Source/WTF/wtf/unicode/UTF8.h.

5:58 PM Changeset in webkit [237713] by Alan Coon

• 2 edits in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237582. rdar://problem/45747609

5:58 PM Changeset in webkit [237712] by Alan Coon

• 3 edits
  1 delete in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237583. rdar://problem/45747609

5:51 PM Changeset in webkit [237711] by wilander@apple.com

• 4 edits
  1 add in trunk

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
​https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.

(-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
(-[KeyboardEventListener handleEvent:]):
(TestWebKitAPI::TEST):

5:46 PM Changeset in webkit [237710] by Alan Coon

• 7 edits in tags/Safari-607.1.10.8/Source

Versioning.

5:44 PM Changeset in webkit [237709] by Alan Coon

• 1 copy in tags/Safari-607.1.10.8

New tag.

5:27 PM Changeset in webkit [237708] by Devin Rousso

• 7 edits in trunk/Source

Web Inspector: Network: remove unnecessary media event tracking
​https://bugs.webkit.org/show_bug.cgi?id=191174

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, as this simply removes some event listeners for the WebInspector frontend.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::addEventListenersToNode):

Source/WebInspectorUI:

Renames "Group by Node" to "Group Media Requests" for clarity.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.showRepresentedObject):
(WI.NetworkTableContentView.prototype.networkDetailViewClose):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._entryForDOMNode):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
(WI.NetworkTableContentView.prototype._restoreSelectedRow):
(WI.NetworkTableContentView.prototype._handleResourceEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleNodeEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):

• UserInterface/Views/NetworkTableContentView.css:

(.network-table .data-container .cell.name .range): Added.
(.network-table .data-container .cell.name .range::before): Added.
(.network-table:focus .data-container li.selected .cell.name .range): Added.
(@media (prefers-dark-interface) .network-table .data-container .cell.name .range): Added.
Always display the "Byte Range" title as a "subtitle", regardless of the media requests
setting being toggled.
Drive-by: update the position of the waterfall popover whenever the time range changes.
Drive-by: close the details view if a node is selected and the media requests setting is
turned off.

• UserInterface/Views/Popover.js:

(WI.Popover.prototype.resize): Added.
(WI.Popover.prototype.handleEvent):

• Localizations/en.lproj/localizedStrings.js:

5:02 PM Changeset in webkit [237707] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

• Configurations/JavaScriptCore.xcconfig:

4:49 PM Changeset in webkit [237706] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
​https://bugs.webkit.org/show_bug.cgi?id=191020

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler):
Since undefined is not a number, it isn't less than 0, which caused us to divide by
undefined (equivalent to dividing by 0), resulting in NaN.

4:24 PM Changeset in webkit [237705] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
​https://bugs.webkit.org/show_bug.cgi?id=191173

Reviewed by Devin Rousso.

WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.

• UserInterface/Base/Main.js:

(WI.loaded):
(WI.contentLoaded):

4:22 PM Changeset in webkit [237704] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit

Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
​https://bugs.webkit.org/show_bug.cgi?id=191124

Reviewed by Tim Horton.

Remove the platform guard around the call to -_setUpSQLiteDatabaseTrackerClient as the
implementation of that message is already guarded.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

4:19 PM Changeset in webkit [237703] by Ryan Haddad

• 2 edits in trunk/Source/WebKit

Unreviewed, attempt to fix the build with recent SDKs.

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

2:40 PM Changeset in webkit [237702] by Chris Dumez

• 13 edits in trunk

Location object sans browsing context
​https://bugs.webkit.org/show_bug.cgi?id=191060

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

• web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt:

Rebase WPT test now that all checks are passing.

• web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js:

Fix bug in WPT test (​https://github.com/web-platform-tests/wpt/pull/13854)

• web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:

Source/WebCore:

As per ​https://github.com/whatwg/html/pull/4076, a Location object's URL should be "about:blank" when
it does not have a browsing context (Frame), not "".

No new tests, rebaselined existing tests.

• page/Location.cpp:

(WebCore::Location::url const):
(WebCore::Location::href const):
(WebCore::Location::protocol const):
(WebCore::Location::host const):
(WebCore::Location::hostname const):
(WebCore::Location::port const):
(WebCore::Location::pathname const):
(WebCore::Location::search const):
(WebCore::Location::origin const):
(WebCore::Location::hash const):

LayoutTests:

Update existing tests to reflect behavior change.

• http/tests/dom/same-origin-detached-window-properties-expected.txt:
• http/tests/dom/same-origin-detached-window-properties.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
• http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:

2:19 PM Changeset in webkit [237701] by Ross Kirsling

• 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

(Also remove one outdated global test failure.)

• TestExpectations:
• platform/wincairo/TestExpectations:

2:11 PM Changeset in webkit [237700] by sihui_liu@apple.com

• 48 edits
  3 adds in trunk

Add a storage limit for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=190598
<rdar://problem/44654715>

Reviewed by Chris Dumez.

Source/WebCore:

Set a storage limit in IndexedDB for each pair of mainFrameOrigin and openingOrigin.
IndexedDB will return a QuotaExceededError if limit is reached.

If the size of free disk space is over 1 GB, the default limit is 500 MB; otherwise it is
half the free disk space.

Test: storage/indexeddb/storage-limit.html

• Modules/indexeddb/server/IDBBackingStore.h:
• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::setPerOriginQuota):

• Modules/indexeddb/server/IDBServer.h:

(WebCore::IDBServer::IDBServer::perOriginQuota const):

• Modules/indexeddb/server/MemoryIDBBackingStore.h:
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::quotaForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::maximumSize const):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):

• Modules/indexeddb/server/SQLiteIDBBackingStore.h:
• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::setQuota):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit:

Add SPI for testing.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::setIDBPerOriginQuota):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/API/C/WKContext.cpp:

(WKContextSetIDBPerOriginQuota):

• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setIDBPerOriginQuota):

• UIProcess/WebProcessPool.h:

Source/WebKitLegacy:

• Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):
(WebDatabaseProvider::setIDBPerOriginQuota):

• Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

• Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager setIDBPerOriginQuota:]):

• Storage/WebDatabaseManagerPrivate.h:

Source/WebKitLegacy/win:

• Interfaces/IWebDatabaseManager.idl:
• WebDatabaseManager.cpp:

(WebDatabaseManager::setIDBPerOriginQuota):

• WebDatabaseManager.h:

Tools:

Add API for testing.

• DumpRenderTree/TestRunner.cpp:

(setIDBPerOriginQuotaCallback):
(TestRunner::staticFunctions):

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setIDBPerOriginQuota):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setIDBPerOriginQuota):

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setIDBPerOriginQuota):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::setIDBPerOriginQuota):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Some tests will fail after adding storage limit to IndexedDB, so we need to reduce their
size and rebase their expectations.

• storage/indexeddb/key-type-array-expected.txt:
• storage/indexeddb/key-type-array-private-expected.txt:
• storage/indexeddb/modern/idbkey-array-equality-expected.txt:
• storage/indexeddb/modern/idbkey-array-equality-private-expected.txt:
• storage/indexeddb/modern/resources/idbkey-array-equality.js:

(request.onsuccess):
(request.onerror):
(doAdd):

• storage/indexeddb/prefetch-invalidation-expected.txt:
• storage/indexeddb/prefetch-invalidation-private-expected.txt:
• storage/indexeddb/resources/key-type-array.js:

(testValidArrayKeys.getreq.onsuccess):
(testValidArrayKeys.putreq.onsuccess):
(testValidArrayKeys.testArrayPutGet):

• storage/indexeddb/resources/prefetch-invalidation.js:

(cursorRequest.onsuccess):
(continue50Times):
(continue100Times): Deleted.

• storage/indexeddb/resources/storage-limit.js: Added.

(prepareDatabase):
(onOpenSuccess.request.onerror):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):

• storage/indexeddb/storage-limit-expected.txt: Added.
• storage/indexeddb/storage-limit.html: Added.

1:53 PM Changeset in webkit [237699] by Chris Dumez

• 6 edits in trunk

[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
​https://bugs.webkit.org/show_bug.cgi?id=191076

Reviewed by Geoffrey Garen.

Source/WebKit:

WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping.
The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading
the wrong URL.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):

• UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONNavigationDelegate init]):
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

1:46 PM Changeset in webkit [237698] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.

• platform/mac-wk1/TestExpectations:

1:35 PM Changeset in webkit [237697] by Justin Michaud

• 34 edits
  6 adds in trunk

CSS Custom Properties API Should Support syntax="*" and "<length>", and handle cycles properly
​https://bugs.webkit.org/show_bug.cgi?id=191042

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
• web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
• web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt:
• web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt:
• web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles-expected.txt:
• web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:

Source/WebCore:

Refactor code so that:

• All properties applied in StyleResolver::applyMatchedProperties are only applied once.
• Custom properties are only resolved once, in StyleResolver, when they are applied to the RenderStyle. They were previously resolved every time they were referenced, and again in RenderStyle.
• The font-size property is applied after its variable references, but before custom properties that depend on it.
• Cycles are detected at the same time as resolution.
• MutableStyleProperties' custom properties cannot be set from Javascript or WebKitLegacy if they do not parse for the property's type. If they contain var(--...) references, however, then they can be set because we cannot check if the references are valid from setProperty. This behaviour matches chrome, but is not documented in the spec.
• Custom property values have more explicit resolved/unresolved state.
• RenderStyle only ever holds resolved custom properties, and StyleResolver::CascadedProperties only holds unresolved properties.

Tests: css-custom-properties-api/crash.html

css-custom-properties-api/cycles.html
css-custom-properties-api/inline.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):

• css/CSSCustomPropertyValue.cpp:

(WebCore::CSSCustomPropertyValue::equals const):
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
(WebCore::CSSCustomPropertyValue::checkVariablesForCycles const): Deleted.
(WebCore::CSSCustomPropertyValue::resolveVariableReferences const): Deleted.
(WebCore::CSSCustomPropertyValue::setResolvedTypedValue): Deleted.

• css/CSSCustomPropertyValue.h:
• css/CSSRegisteredCustomProperty.cpp:

(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty):

• css/CSSRegisteredCustomProperty.h:
• css/CSSVariableData.cpp:

(WebCore::CSSVariableData::CSSVariableData):
(WebCore::CSSVariableData::consumeAndUpdateTokens): Deleted.
(WebCore::CSSVariableData::checkVariablesForCycles const): Deleted.
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const): Deleted.
(WebCore::CSSVariableData::resolveVariableFallback const): Deleted.
(WebCore::CSSVariableData::resolveVariableReference const): Deleted.
(WebCore::CSSVariableData::resolveVariableReferences const): Deleted.
(WebCore::CSSVariableData::resolveTokenRange const): Deleted.

• css/CSSVariableData.h:

(WebCore::CSSVariableData::create):
(WebCore::CSSVariableData::createResolved): Deleted.
(WebCore::CSSVariableData::needsVariableResolution const): Deleted.
(WebCore::CSSVariableData::CSSVariableData): Deleted.

• css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):
(WebCore::CSSVariableReferenceValue::checkVariablesForCycles const): Deleted.

• css/CSSVariableReferenceValue.h:

(WebCore::CSSVariableReferenceValue::create):
(WebCore::CSSVariableReferenceValue::equals const):
(WebCore::CSSVariableReferenceValue::variableDataValue const): Deleted.

• css/DOMCSSRegisterCustomProperty.cpp:

(WebCore::DOMCSSRegisterCustomProperty::registerProperty):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialCustomProperty):
(WebCore::StyleBuilderCustom::applyValueCustomProperty):

• css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setCustomProperty):

• css/StyleProperties.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedCustomProperty):
(WebCore::StyleResolver::applyCascadedProperties):

• css/StyleResolver.h:
• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

• css/parser/CSSParser.h:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::CSSPropertyParser):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::parseSingleValue):

• css/parser/CSSPropertyParser.h:
• css/parser/CSSVariableParser.cpp:

(WebCore::CSSVariableParser::parseDeclarationValue):

• dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::checkVariablesInCustomProperties): Deleted.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

• rendering/style/StyleCustomPropertyData.h:

(WebCore::StyleCustomPropertyData::operator== const):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
(): Deleted.

LayoutTests:

• css-custom-properties-api/crash-expected.txt: Added.
• css-custom-properties-api/crash.html: Added.
• css-custom-properties-api/cycles-expected.txt: Added.
• css-custom-properties-api/cycles.html: Added.
• css-custom-properties-api/inline-expected.txt: Added.
• css-custom-properties-api/inline.html: Added.

12:49 PM Changeset in webkit [237696] by guijemont@igalia.com

• 28 edits in trunk

Skip tests on arm/mips that time out now we're running on CLoop

Unreviewed gardening.

Since the JIT is temporarily disabled on 32-bit platforms, these tests
time out on the bots and need to be disabled. There's more tests
disabled on arm because the timeout is longer on the mips bot (as the
device is slower to start with), so many of the tests don't time out
there.

JSTests:

• microbenchmarks/getter-richards.js: disable on arm and mips.
• stress/op_add.js: disable on arm.
• stress/op_bitand.js: disable on arm.
• stress/op_bitor.js: disable on arm.
• stress/op_bitxor.js: disable on arm.
• stress/op_lshift-ConstVar.js: disable on arm.
• stress/op_lshift-VarConst.js: disable on arm.
• stress/op_lshift-VarVar.js: disable on arm.
• stress/op_mod-ConstVar.js: disable on arm.
• stress/op_mod-VarConst.js: disable on arm.
• stress/op_mod-VarVar.js: disable on arm.
• stress/op_mul-ConstVar.js: disable on arm.
• stress/op_mul-VarConst.js: disable on arm.
• stress/op_mul-VarVar.js: disable on arm.
• stress/op_rshift-ConstVar.js: disable on arm.
• stress/op_rshift-VarConst.js: disable on arm.
• stress/op_rshift-VarVar.js: disable on arm.
• stress/op_sub-ConstVar.js: disable on arm.
• stress/op_sub-VarConst.js: disable on arm.
• stress/op_sub-VarVar.js: disable on arm.
• stress/op_urshift-ConstVar.js: disable on arm.
• stress/op_urshift-VarConst.js: disable on arm.
• stress/op_urshift-VarVar.js: disable on arm.
• stress/spread-forward-call-varargs-stack-overflow.js: disable on arm.
• stress/value-to-boolean.js: disable on arm and mips.

LayoutTests:

• js/script-tests/regress-139548.js: disable on arm and mips.

12:13 PM Changeset in webkit [237695] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r237652): Web Inspector: dumpInspectorProtocolMessages is always enabled
​https://bugs.webkit.org/show_bug.cgi?id=191161

Reviewed by Joseph Pecoraro.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):

12:12 PM Changeset in webkit [237694] by Devin Rousso

• 4 edits in trunk/LayoutTests

Web Inspector: fix debug WK1 test failures for WI.ObjectStore
​https://bugs.webkit.org/show_bug.cgi?id=191158

Reviewed by Joseph Pecoraro.

• inspector/unit-tests/objectStore/delete.html:
• inspector/unit-tests/objectStore/deleteObject.html:
• inspector/unit-tests/objectStore/resources/objectStore-utilities.js:

(TestPage.registerInitializer):

11:58 AM Changeset in webkit [237693] by Chris Dumez

• 5 edits
  18 adds
  3 deletes in trunk/LayoutTests

Resync html/browsers/history/the-location-interface web platform tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=191139

Reviewed by Alex Christensen.

Resync html/browsers/history/the-location-interface web platform tests from upstream 8295368c82.

• web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/location_assign-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/location_assign.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Added.

(test):
(bcLessLocation):
(forEach.testSetup.testSetup.values.forEach.value.test):
(string_appeared_here.forEach.method.string_appeared_here.forEach.value.test):

• web-platform-tests/html/browsers/history/the-location-interface/non-automated/w3c-import.log:
• web-platform-tests/html/browsers/history/the-location-interface/per-global.window-expected.txt: Added.
• web-platform-tests/html/browsers/history/the-location-interface/per-global.window.html: Added.
• web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-1.html: Removed.
• web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-expected.txt: Removed.
• web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html: Removed.
• web-platform-tests/html/browsers/history/the-location-interface/resources/reload_post_1-1.py: Added.

(main):

• web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log:
• web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:

11:57 AM Changeset in webkit [237692] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Toggle selected properties by pressing Space or Command+/
​https://bugs.webkit.org/show_bug.cgi?id=181145
<rdar://problem/36203388>

Reviewed by Brian Burg.

Pressing Space key or Command-/ toggles (comments out or uncomments) selected properties.

This patch only works with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get selectionRange):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.update): Renamed from _update.
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.applyFilter):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
Make update method public. No other changes were made.

11:49 AM Changeset in webkit [237691] by commit-queue@webkit.org

• 6 edits in trunk

[CG] Adopt CG SPI for non-even cornered rounded rects
​https://bugs.webkit.org/show_bug.cgi?id=190155

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-11-01
Reviewed by Simon Fraser.

Source/WebCore:

Instead of creating bezier curves for the non-even corners of the rounded
rects, we should use the optimized SPI provided by CG.

• platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

Source/WebCore/PAL:

• pal/spi/cg/CoreGraphicsSPI.h:

LayoutTests:

This test fails on iOS simulator because of just one pixel difference
between drawing a shadow of the element and drawing a copy of the element.
This failure happens on iOS and does not happen on macOS because we don't
use accelerated drawing for macOS testing but we use it for iOS testing.

• platform/ios/TestExpectations:

11:33 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

11:32 AM Changeset in webkit [237690] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.22/Tools

Merged r237680 - Fix build with VIDEO and WEB_AUDIO disabled
​https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

• MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

11:32 AM Changeset in webkit [237689] by Adrian Perez de Castro

• 8 edits in releases/WebKitGTK/webkit-2.22

Merged r237677 - Fix build with VIDEO and WEB_AUDIO disabled
​https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

• Modules/mediasource/VideoPlaybackQuality.cpp:
• Modules/mediasource/VideoPlaybackQuality.h:
• Modules/mediasource/VideoPlaybackQuality.idl:
• dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

• inspector/agents/InspectorDOMAgent.h:
• rendering/RenderThemeGtk.cpp:

Tools:

• MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

11:18 AM Changeset in webkit [237688] by youenn@apple.com

• 4 edits in trunk

RTCTrackEvent.streams should be SameObject
​https://bugs.webkit.org/show_bug.cgi?id=191130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:

Source/WebCore:

Mimick SameObject using CachedAttribute.
Covered by rebased test.

• Modules/mediastream/RTCTrackEvent.idl:

11:02 AM Changeset in webkit [237687] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Prevent homepage animation for users that prefer reduced motion
​https://bugs.webkit.org/show_bug.cgi?id=188211

Reviewed by Timothy Hatcher.

• wp-content/themes/webkit/front-header.php:

10:35 AM Changeset in webkit [237686] by Alan Coon

• 7 edits in branches/safari-606.3.4.2-branch/Source

Versioning.

10:33 AM Changeset in webkit [237685] by Alan Coon

• 7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

10:30 AM Changeset in webkit [237684] by Alan Coon

• 7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

10:09 AM Changeset in webkit [237683] by Chris Dumez

• 5 edits
  3 adds in trunk

[PSON] Unable to submit a file in FormData cross-site
​https://bugs.webkit.org/show_bug.cgi?id=191138

Reviewed by Alex Christensen.

Source/WebKit:

When PSON is enabled, we are unable to submit a file in FormData cross-site. Although we encode the
request body over IPC since r237639, we're missing the right sandbox extensions for its to work for
files.

Update FormDataReference encoder to pass along the necessary sandbox extensions for files in the
FormData, and have its decoder consume those extensions so that the recipient has access to those
files. Also update LoadParameters's IPC encoder / decoder to encoder an IPC::FormDataReference
(which encodes both FormData and sandbox extensions) instead of a FormData.

• Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):

• Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

LayoutTests:

Add layout test coverage.

• http/tests/misc/form-submit-file-cross-site-expected.txt:
• http/tests/misc/form-submit-file-cross-site.html:

9:40 AM Changeset in webkit [237682] by Claudio Saavedra

• 2 edits in trunk/Source/WebKit

ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
​https://bugs.webkit.org/show_bug.cgi?id=191152

Reviewed by Chris Dumez.

The statistics file is not created unconditionally, so
make sure it exists before logging an error.

• UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.

9:11 AM Changeset in webkit [237681] by Devin Rousso

• 3 edits in trunk/LayoutTests

Unreviewed test fix after r237670.

• inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
• inspector/canvas/setRecordingAutoCaptureFrameCount.html:

8:21 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

8:19 AM Changeset in webkit [237680] by Adrian Perez de Castro

• 2 edits in trunk/Tools

Fix build with VIDEO and WEB_AUDIO disabled
​https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

• MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

7:20 AM Changeset in webkit [237679] by Alan Bujtas

• 12 edits
  2 adds in trunk

[LFC][IFC] Add support for inline-block elements.
​https://bugs.webkit.org/show_bug.cgi?id=191143

Reviewed by Antti Koivisto.

Source/WebCore:

This patch add support for laying out non-shrink-to-width inline-block elements.

Test: fast/inline/simple-inline-block.html

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

• layout/layouttree/LayoutInlineContainer.cpp:

(WebCore::Layout::InlineContainer::establishesInlineFormattingContext const):

• layout/layouttree/LayoutInlineContainer.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/inline/simple-inline-block-expected.txt: Added.
• fast/inline/simple-inline-block.html: Added.
• platform/ios/TestExpectations:

6:35 AM Changeset in webkit [237678] by Claudio Saavedra

• 2 edits
  1 add in trunk/Tools

[WPE] Add missing libsoup patch to jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=191149

Reviewed by Žan Doberšek.

• wpe/jhbuild.modules:
• wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.

5:14 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

4:29 AM WebKitGTK/2.22.x edited by Claudio Saavedra

(diff)

4:27 AM Changeset in webkit [237677] by Claudio Saavedra

• 10 edits in trunk

Fix build with VIDEO and WEB_AUDIO disabled
​https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

• Modules/mediasource/VideoPlaybackQuality.cpp:
• Modules/mediasource/VideoPlaybackQuality.h:
• Modules/mediasource/VideoPlaybackQuality.idl:
• dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

• inspector/agents/InspectorDOMAgent.h:
• rendering/RenderThemeGtk.cpp:

Tools:

• MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

3:03 AM Changeset in webkit [237676] by Claudio Saavedra

• 2 edits in trunk/Source/WebKit

[GLIB] Silent a build warning when not using Wayland

Unreviewed.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

2:27 AM Changeset in webkit [237675] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
​https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>

Patch by YUHAN WU <​yuhan_wu@apple.com> on 2018-11-01
Reviewed by Youenn Fablet.

Remove share FileReader object between three asynchronous tests which might cause flaky failure.
We will need to fix all the falky failures in this test after we implement timeslice.

• http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:

1:51 AM Changeset in webkit [237674] by fred.wang@free.fr

• 2 edits in trunk/Source/WebKit

[WebAuthN] Make AuthenticatorManager
​https://bugs.webkit.org/show_bug.cgi?id=189279

Unreviewed build fix.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-01

• UIProcess/WebAuthentication/Cocoa/LocalConnection.h: Add missing headers.

Oct 31, 2018:

9:30 PM Changeset in webkit [237673] by bshafiei@apple.com

• 1 copy in branches/safari-606.3.4.2-branch

New branch.

9:30 PM Changeset in webkit [237672] by bshafiei@apple.com

• 1 copy in branches/safari-606.3.4.1-branch

New branch.

9:18 PM Changeset in webkit [237671] by bshafiei@apple.com

• 1 copy in branches/safari-606.3.4.0-branch

New branch.

9:13 PM Changeset in webkit [237670] by Devin Rousso

• 25 edits
  2 adds in trunk

Web Inspector: Canvas: create a setting for auto-recording newly created contexts
​https://bugs.webkit.org/show_bug.cgi?id=190856

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/Canvas.json:

Add setRecordingAutoCaptureFrameCount command for setting the number of frames to record
immediately after a context is created.

• inspector/protocol/Recording.json:

Add creation value for Initiator enum.

Source/WebCore:

Test: inspector/canvas/setRecordingAutoCaptureFrameCount.html

• inspector/agents/InspectorCanvasAgent.h:

(WebCore::InspectorCanvasAgent::RecordingOptions): Added.

• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::setRecordingAutoCaptureFrameCount): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):
(WebCore::InspectorCanvasAgent::startRecording): Added.
Unify the different functions that are able to start a recording to use a single path.

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::setFrameCount): Added.
(WebCore::InspectorCanvas::overFrameCount const): Added.

Source/WebInspectorUI:

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.supportsRecordingAutoCapture): Added.
(WI.CanvasManager.prototype.setRecordingAutoCaptureFrameCount): Added.

• UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingStarted):
(WI.Canvas.prototype.recordingFinished):

• UserInterface/Models/Recording.js:

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.get navigationItems):
(WI.CanvasOverviewContentView.prototype.initialLayout): Added.
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount): Added.
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureEnabledChanged): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged): Added.

• UserInterface/Views/CanvasOverviewContentView.css:

(.navigation-bar > .item.canvas-recording-auto-capture > label): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Added.
(.popover-content > .tree-outline .item.recording > .icon): Deleted.
(.popover-content > .tree-outline .item.recording:hover): Deleted.
(.popover-content > .tree-outline .item.recording:hover > .icon): Deleted.
Drive-by: removed unused CSS rules.

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._updateProgressView):
(WI.CanvasContentView.prototype._updateViewRelatedItems):

• UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype._recordingImportedOrStopped):

• UserInterface/Views/CheckboxNavigationItem.js:

(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype._handleLabelClick): Added.

• UserInterface/Base/Setting.js:

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.window.startRecording):
(TestPage.registerInitializer.handleRecordingProgress):

• inspector/canvas/recording-2d.html:
• inspector/canvas/recording-bitmaprenderer.html:
• inspector/canvas/recording-webgl-snapshots.html:
• inspector/canvas/recording-webgl.html:

• inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt: Added.
• inspector/canvas/setRecordingAutoCaptureFrameCount.html: Added.

9:12 PM Changeset in webkit [237669] by Devin Rousso

• 15 edits in trunk/Source

Web Inspector: display low-power enter/exit events in Timelines and Network node waterfalls
​https://bugs.webkit.org/show_bug.cgi?id=190641
<rdar://problem/45319049>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Add videoLowPowerChanged event that is fired when InspectorDOMAgent is able to determine
whether a video element's low power state has changed.

Source/WebCore:

No new tests, as low power mode is indeterminate. Should not affect functionality.

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::addEventListenersToNode):
(WebCore::InspectorDOMAgent::mediaMetricsTimerFired): Added.

Source/WebInspectorUI:

• UserInterface/Protocol/DOMObserver.js:

(WI.DOMObserver.prototype.videoLowPowerChanged): Added.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.videoLowPowerChanged): Added.

• UserInterface/Models/DOMNode.js:

(WI.DOMNode):
(WI.DOMNode.prototype.get lowPowerRanges): Added.
(WI.DOMNode.prototype.videoLowPowerChanged): Added.
(WI.DOMNode.prototype.canEnterLowPowerMode): Added.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._populateDomainCell):
(WI.NetworkTableContentView.prototype._tryLinkResourceToDOMNode):
(WI.NetworkTableContentView.prototype._handleNodeLowPowerChanged): Added.

• UserInterface/Views/NetworkTableContentView.css:

(.network-table :not(.header) .cell.waterfall .waterfall-container > .area):
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.low-power): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-fullscreen): Deleted.

• UserInterface/Views/DOMNodeEventsContentView.js:

(WI.DOMNodeEventsContentView):
(WI.DOMNodeEventsContentView.prototype.initialLayout):
(WI.DOMNodeEventsContentView.prototype.closed): Deleted.
(WI.DOMNodeEventsContentView.prototype._handleDOMNodeDidFireEvent): Deleted.

• UserInterface/Views/DOMEventsBreakdownView.js:

(WI.DOMEventsBreakdownView):
(WI.DOMEventsBreakdownView.prototype.initialLayout):
(WI.DOMEventsBreakdownView.prototype.layout): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeDidFireEvent): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeLowPowerChanged): Added.
(WI.DOMEventsBreakdownView.prototype.addEvent): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable.percentOfTotalTime): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable): Deleted.

• UserInterface/Views/DOMEventsBreakdownView.css:

(.dom-events-breakdown .graph > .area): Added.
(.dom-events-breakdown .graph > .area.fullscreen):
(.dom-events-breakdown .graph > .area.low-power): Added.

• Localizations/en.lproj/localizedStrings.js:

9:08 PM Changeset in webkit [237668] by Justin Michaud

• 2 edits in trunk/Tools

Add Justin Michaud to the list of WebKit Committers
​https://bugs.webkit.org/show_bug.cgi?id=191142

• Scripts/webkitpy/common/config/contributors.json:

7:11 PM Changeset in webkit [237667] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
​https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>

Reviewed by Dean Jackson.

Followup to r237648: also make sure that we insecurely unarchive NSFileWrapper on platforms that don't support
secure archiving of file wrappers.

• UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::updateFromSerializedRepresentation):

6:18 PM Changeset in webkit [237666] by Fujii Hironori

• 2 edits in trunk/Source/WebKitLegacy/win

[Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
​https://bugs.webkit.org/show_bug.cgi?id=191105

Reviewed by Brent Fulgham.

• DOMHTMLClasses.h:

(DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
instead of own setNodeValue.

6:18 PM Changeset in webkit [237665] by Devin Rousso

• 8 edits
  14 adds in trunk

Web Inspector: Audit: save imported audits across WebInspector sessions
​https://bugs.webkit.org/show_bug.cgi?id=190858
<rdar://problem/45527625>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Base/ObjectStore.js: Added.

(WI.ObjectStore):
(WI.ObjectStore.supported):
(WI.ObjectStore._open):
(WI.ObjectStore.get _databaseName):
(WI.ObjectStore.prototype.associateObject):
(WI.ObjectStore.prototype.async getAll):
(WI.ObjectStore.prototype.async add):
(WI.ObjectStore.prototype.async addObject):
(WI.ObjectStore.prototype.async delete):
(WI.ObjectStore.prototype.async deleteObject):
(WI.ObjectStore.prototype._resolveKeyPath):
(WI.ObjectStore.prototype.async _operation.listener):
(WI.ObjectStore.prototype.async _operation):
Wrapper for a global IndexedDB instance for all of WebInspector (per level). Instances of
WI.ObjectStore are able to control a given IDBObjectStore using a promise-based API.

*NOTE*: due to the constraint that IDBObjectStores are only able to be created when the
owner IndexedDB is "upgrade"d, all WI.ObjectStore must be declared before the database
is opened for the first time. Additionally, any time a new WI.ObjectStore is added, the
version needs to be incremented to ensure that the "upgrade" event fires.

To use any of the *Object functions, one must implement a toJSON on the object provided.
This is so that WI.ObjectStore is able to add the resulting identifier value to the owner
object while storing its toJSON value in the IndexedDB (e.g. for objects that have cycles).

• UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.import):
(WI.AuditManager.prototype.loadStoredTests): Added.
(WI.AuditManager.prototype.removeTest): Added.
(WI.AuditManager.prototype._addTest):

• UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView.prototype.initialLayout): Added.
Attempt to load stored audits when the Audit tab is first shown (lazy-load).

• UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved): Added.

• UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement.prototype.ondelete):
Only allow top-level audits to be deleted, as that is what matches the WI.ObjectStore.

• UserInterface/Main.html:
• UserInterface/Test.html:

LayoutTests:

• inspector/unit-tests/objectStore/add-expected.txt: Added.
• inspector/unit-tests/objectStore/add.html: Added.
• inspector/unit-tests/objectStore/addObject-expected.txt: Added.
• inspector/unit-tests/objectStore/addObject.html: Added.
• inspector/unit-tests/objectStore/basic-expected.txt: Added.
• inspector/unit-tests/objectStore/basic.html: Added.
• inspector/unit-tests/objectStore/delete-expected.txt: Added.
• inspector/unit-tests/objectStore/delete.html: Added.
• inspector/unit-tests/objectStore/deleteObject-expected.txt: Added.
• inspector/unit-tests/objectStore/deleteObject.html: Added.
• inspector/unit-tests/objectStore/resources/objectStore-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject.prototype.toJSON):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createSuite):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createObjectStore):
(TestPage.registerInitializer.InspectorTest.ObjectStore.add):
(TestPage.registerInitializer.InspectorTest.ObjectStore.addObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.delete):
(TestPage.registerInitializer.InspectorTest.ObjectStore.deleteObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.logValues):
(TestPage.registerInitializer.InspectorTest.ObjectStore.wrapTest):

6:03 PM Changeset in webkit [237664] by dino@apple.com

• 2 edits in trunk/Source/WebKit

Forward original fragment identifier into System Preview
​https://bugs.webkit.org/show_bug.cgi?id=191141
<rdar://problem/45717542>

Reviewed by Wenson Hsieh.

If the URL used by the page includes a fragment identifier, use
it when telling QuickLook to open a local file.

• UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didFinish): Append original fragment identifier
to the destination URL.

5:39 PM Changeset in webkit [237663] by Kocsen Chung

• 1 copy in tags/Safari-607.1.12

Tag Safari-607.1.12.

5:39 PM Changeset in webkit [237662] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

5:37 PM Changeset in webkit [237661] by commit-queue@webkit.org

• 16 edits in trunk/Source/WebInspectorUI

Web Inspector: Move a few remaining global WI settings to WI.settings
​https://bugs.webkit.org/show_bug.cgi?id=191137

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-31
Reviewed by Brian Burg.

Move and better name some of the WI.settings created in Main.js
to WI.settings, alongside other global settings.

• UserInterface/Base/Main.js:

(WI.loaded):
Move settings, and register for settings changes in contentLoaded.

• UserInterface/Base/Setting.js:

New settings, and sort values.

• UserInterface/Test/Test.js:

(WI.loaded):
Update setting values for tests.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.initializeTarget):

• UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager.prototype.initializeTarget):

• UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.get children):
(WI.DOMNode.prototype.get nextSibling):
(WI.DOMNode.prototype.get previousSibling):
(WI.DOMNode.prototype.get childNodeCount):

• UserInterface/Protocol/Target.js:

(WI.Target.prototype.initialize):

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype._togglePaintFlashing):
(WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
(WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged):
(WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting):

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.close):
(WI.DOMTreeOutline.prototype._revealAndSelectNode):

• UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout):
(WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers):

• UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.closed):
(WI.Layers3DContentView.prototype._showPaintRectsSettingChanged):
(WI.Layers3DContentView.prototype._togglePaintFlashing):

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.closed):
(WI.NetworkTableContentView.prototype._resourceCachingDisabledSettingChanged):
(WI.NetworkTableContentView.prototype._toggleDisableResourceCache):

• UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView):
(WI.ScriptContentView.prototype.closed):
(WI.ScriptContentView.prototype._contentDidPopulate):
(WI.ScriptContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.shown):
(WI.SourceCodeTextEditor.prototype._proceedPopulateWithContent):
(WI.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
(WI.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled):

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView):
(WI.TextResourceContentView.prototype.closed):
(WI.TextResourceContentView.prototype._contentDidPopulate):
(WI.TextResourceContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
Renamed setting.

4:57 PM Changeset in webkit [237660] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: missing contextmenu items for links
​https://bugs.webkit.org/show_bug.cgi?id=191021

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._handleLinkContextMenu): Added.
If the token is subtype of "link", add contextmenu items to the wrapper element.

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL.showResourceWithOptions):
(WI.appendContextMenuItemsForURL):
Drive-by: don't assume that options will be provided.

• Localizations/en.lproj/localizedStrings.js:

3:52 PM Changeset in webkit [237659] by Nikita Vasilyev

• 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: implement copying and deletion of multiple properties
​https://bugs.webkit.org/show_bug.cgi?id=191037
<rdar://problem/45650078>

Reviewed by Brian Burg.

This patch should only work with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.

Mousedown on a property (1) and moving the mouse cursor to another property (2) should select properties 1, 2, and
all properties between them until mouseup is fired.

Once selected:

• Pressing Command-C should copy the selected properties.
• Pressing Delete should remove the properties.

• UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype.get formattedText):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property):
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus):
(@media (prefers-dark-interface)):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.deselectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._hasSelectedProperties):
Property selection is defined as two numbers: anchorIndex and focusIndex.
The property with focusIndex is actually focused. The focus outline is replaced by a more subtle left blue border.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration.selecting,):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowMouseUp):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
Implement copying the same way it's done for DataGrid: by adding copyHandler property to the focused element.
Add tabIndex=-1 so the property element can be focused.

(WI.SpreadsheetStyleProperty.prototype.get property):
(WI.SpreadsheetStyleProperty.prototype.get selected):
(WI.SpreadsheetStyleProperty.prototype.set selected):
(WI.SpreadsheetStyleProperty.prototype.remove):
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
(WI.SpreadsheetStyleProperty.prototype._handleNamePaste):

3:44 PM Changeset in webkit [237658] by Alan Bujtas

• 2 edits in trunk/Source/WebKit

[iOS] Do not paint tap highlight unless it is above a certain threshold
​https://bugs.webkit.org/show_bug.cgi?id=191134
<rdar://problem/43615142>

Flashing a large portion of the screen on every tap looks unpleasant.
This patch impoves the existing heuristic by adding area check and a % threshold.

Reviewed by Tim Horton.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showTapHighlight]):
(highlightedQuadsAreSmallerThanRect): Deleted.

3:05 PM Changeset in webkit [237657] by aboya@igalia.com

• 3 edits
  2 adds in trunk

[MSE] Use tolerance when growing the coded frame group
​https://bugs.webkit.org/show_bug.cgi?id=190085

Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-source/media-source-append-acb-tolerance.html

This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.

This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).

This fixes a stall when seeking back and forth in YouTube with WebM
video.

A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.

• media/media-source/media-source-append-acb-tolerance.html: Added.

3:00 PM Changeset in webkit [237656] by Devin Rousso

• 11 edits in trunk

Web Inspector: Audit: attempt to re-link DOM nodes for imported results
​https://bugs.webkit.org/show_bug.cgi?id=191044
<rdar://problem/45687364>

Reviewed by Brian Burg.

Source/WebInspectorUI:

When importing a WI.AuditTestCaseResult, attempt to querySelector for each item in
data.domNodes. If a node is found, replace it with that node and show a tree instead.

• UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.async fromPayload): Added.
(WI.AuditTestCase.fromPayload): Deleted.

• UserInterface/Models/AuditTestGroup.js:

(WI.AuditTestGroup.async fromPayload): Added.
(WI.AuditTestGroup.fromPayload): Deleted.

• UserInterface/Models/AuditTestCaseResult.js:

(WI.AuditTestCaseResult.async fromPayload): Added.
(WI.AuditTestCaseResult.fromPayload): Deleted.

• UserInterface/Models/AuditTestGroupResult.js:

(WI.AuditTestGroupResult.async fromPayload): Added.
(WI.AuditTestGroupResult.fromPayload): Deleted.

• UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.import):

LayoutTests:

• inspector/model/auditTestCase.html:
• inspector/model/auditTestCaseResult.html:
• inspector/model/auditTestGroup.html:
• inspector/model/auditTestGroupResult.html:

2:52 PM Changeset in webkit [237655] by jer.noble@apple.com

• 3 edits
  2 adds in trunk

MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
​https://bugs.webkit.org/show_bug.cgi?id=191129

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-istypesupported-case-sensitive.html

According to RFC 2045: "All media type values, subtype values, and parameter names as
defined are case-insensitive. However, parameter values are case-sensitive unless otherwise
specified for the specific parameter." So rather than fold the entire ContentType into lower-
case, leave the original string intact and require clients to enforce case-insensitivity.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::isTypeSupported):

LayoutTests:

• media/media-source/media-source-istypesupported-case-sensitive-expected.txt: Added.
• media/media-source/media-source-istypesupported-case-sensitive.html: Added.

2:51 PM Changeset in webkit [237654] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
access of m_cdmInstance.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):

2:48 PM Changeset in webkit [237653] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Follow-up review comment to r237652.

Reviewed by Brian Burg.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):

2:19 PM Changeset in webkit [237652] by Joseph Pecoraro

• 24 edits in trunk/Source/WebInspectorUI

Web Inspector: Separate target initialization from frontend initialization
​https://bugs.webkit.org/show_bug.cgi?id=191052
<rdar://problem/45658384>

Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
Create the targets after the rest of frontend initialization. This is a step
toward a frontend opening and being told about multiple targets instead of
knowing in advance a single target it is connected to. All backend
messages during frontend initialization now happen with an explicit target.

• UserInterface/Controllers/ApplicationCacheManager.js:

(WI.ApplicationCacheManager):
(WI.ApplicationCacheManager.prototype.initializeTarget):
(WI.ApplicationCacheManager.prototype.initialize):

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager):
(WI.CSSManager.prototype.initializeTarget):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.initializeTarget):

• UserInterface/Controllers/ConsoleManager.js:

(WI.ConsoleManager):
(WI.ConsoleManager.prototype.initializeLogChannels):

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager):
(WI.DOMManager.prototype.initializeTarget):

• UserInterface/Controllers/DOMStorageManager.js:

(WI.DOMStorageManager):
(WI.DOMStorageManager.prototype.initializeTarget):

• UserInterface/Controllers/DatabaseManager.js:

(WI.DatabaseManager):
(WI.DatabaseManager.prototype.initializeTarget):

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.restoreBreakpointsSoon): Deleted.

• UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.initializeTarget):

• UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager):
(WI.IndexedDBManager.prototype.initializeTarget):

• UserInterface/Controllers/LayerTreeManager.js:

(WI.LayerTreeManager.prototype.initializeTarget):

• UserInterface/Controllers/MemoryManager.js:

(WI.MemoryManager.prototype.initializeTarget):

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager):
(WI.NetworkManager.prototype.initializeTarget):

• UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager):
(WI.RuntimeManager.prototype.initializeTarget):

• UserInterface/Controllers/TargetManager.js:

(WI.TargetManager):
(WI.TargetManager.prototype.initializeTargetsWithMainTarget):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager):
(WI.TimelineManager.prototype.initializeTarget):
(WI.TimelineManager.prototype.set enabledTimelineTypes):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):

• UserInterface/Controllers/WorkerManager.js:

(WI.WorkerManager):
(WI.WorkerManager.prototype.initializeTarget):
Move Target initialization out of the constructor into a top level
initializeTarget function. This will be expected to be called
by any target that the frontend connects to.

(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Drive-by fix. Update all targets if the setting changes.

(WI.WorkerManager.prototype.workerCreated):
Call initialize on the new target.

• UserInterface/Models/CSSCompletions.js:

(WI.CSSCompletions.initializeCSSCompletions):
(WI.CSSCompletions.requestCSSCompletions): Deleted.
Rename requestCSSCompletions to initializeCSSCompletions to try
and standardize on "initialize" being used for most frontend one
time initialization tasks. This being one such operation that
only needs to be performed once on a target that supports it.

• UserInterface/Protocol/Target.js:

(WI.Target):
(WI.Target.prototype.initialize):
Perform explicit target initialization, such as initializing
the state of all backend domains / agents. This is done by asking
each of the managers to do initialization work for this target.

(WI.Target.prototype.get ApplicationCacheAgent):
(WI.Target.prototype.get CSSAgent):
(WI.Target.prototype.get CanvasAgent):
(WI.Target.prototype.get ConsoleAgent):
(WI.Target.prototype.get DOMAgent):
(WI.Target.prototype.get DOMDebuggerAgent):
(WI.Target.prototype.get DOMStorageAgent):
(WI.Target.prototype.get DatabaseAgent):
(WI.Target.prototype.get DebuggerAgent):
(WI.Target.prototype.get HeapAgent):
(WI.Target.prototype.get IndexedDBAgent):
(WI.Target.prototype.get InspectorAgent):
(WI.Target.prototype.get LayerTreeAgent):
(WI.Target.prototype.get MemoryAgent):
(WI.Target.prototype.get NetworkAgent):
(WI.Target.prototype.get PageAgent):
(WI.Target.prototype.get RecordingAgent):
(WI.Target.prototype.get RuntimeAgent):
(WI.Target.prototype.get ScriptProfilerAgent):
(WI.Target.prototype.get ServiceWorkerAgent):
(WI.Target.prototype.get TargetAgent):
(WI.Target.prototype.get TimelineAgent):
(WI.Target.prototype.get WorkerAgent):
Accessors for all of the agents on a Target.

• UserInterface/Protocol/WorkerTarget.js:

(WI.WorkerTarget):
This is now automatically done in the base class.

• UserInterface/Test/Test.js:

(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
New necessary top level hooks, and initialize more like Main.js.

2:04 PM Changeset in webkit [237651] by aboya@igalia.com

• 45 edits in trunk/LayoutTests

[MSE] WebKit tests: Use fixed point in makeASample()
​https://bugs.webkit.org/show_bug.cgi?id=191128

Reviewed by Jer Noble.

This patch modifies the utility function makeASample() so as to accept
time values in arbitrary time scales.

Previously makeASample() accepted optionally a time scale, but still
required to receive all time values as seconds, therefore requiring a
division at call time in order to use the function, which could cause
rounding errors (see ​https://bugs.webkit.org/show_bug.cgi?id=190085#c20).

• media/media-source/media-source-append-acb-no-frame-lost-expected.txt:
• media/media-source/media-source-append-acb-no-frame-lost.html:
• media/media-source/media-source-append-buffer-with-append-window.html:
• media/media-source/media-source-append-media-segment-without-init.html:
• media/media-source/media-source-append-nonsync-sample-after-abort.html:
• media/media-source/media-source-append-out-of-order.html:
• media/media-source/media-source-append-overlapping-dts-expected.txt:
• media/media-source/media-source-append-overlapping-dts.html:
• media/media-source/media-source-canplaythrough.html:
• media/media-source/media-source-duplicate-seeked.html:
• media/media-source/media-source-duration-after-append.html:
• media/media-source/media-source-end-of-stream-buffered.html:
• media/media-source/media-source-end-of-stream-readyState.html:
• media/media-source/media-source-fastseek.html:
• media/media-source/media-source-fudge-factor.html:
• media/media-source/media-source-monitor-source-buffers.html:
• media/media-source/media-source-overlapping-append-buffered.html:
• media/media-source/media-source-overlapping-append-expected.txt:
• media/media-source/media-source-overlapping-append.html:
• media/media-source/media-source-overlapping-decodetime-expected.txt:
• media/media-source/media-source-overlapping-decodetime.html:
• media/media-source/media-source-play.html:
• media/media-source/media-source-range-end-frame-not-removed-expected.txt:
• media/media-source/media-source-range-end-frame-not-removed.html:
• media/media-source/media-source-range-start-frame-replaced-expected.txt:
• media/media-source/media-source-range-start-frame-replaced.html:
• media/media-source/media-source-remove-decodeorder-crash.html:
• media/media-source/media-source-remove-too-much.html:
• media/media-source/media-source-remove.html:
• media/media-source/media-source-restrictions.html:
• media/media-source/media-source-sample-wrong-track-id.html:
• media/media-source/media-source-seek-back-expected.txt:
• media/media-source/media-source-seek-back.html:
• media/media-source/media-source-seek-complete.html:
• media/media-source/media-source-sequence-timestamps-expected.txt:
• media/media-source/media-source-sequence-timestamps.html:
• media/media-source/media-source-small-gap.html:
• media/media-source/media-source-timeoffset-expected.txt:
• media/media-source/media-source-timeoffset.html:
• media/media-source/media-source-timestampoffset-rounding-error.html:
• media/media-source/media-source-timestampoffset-then-zero-expected.txt:
• media/media-source/media-source-timestampoffset-then-zero.html:
• media/media-source/media-source-video-playback-quality.html:
• media/media-source/mock-media-source.js:

(makeASample):

1:26 PM Changeset in webkit [237650] by commit-queue@webkit.org

• 5 edits in trunk

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
​https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>

Patch by YUHAN WU <​yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.

Source/WebCore:

Add a include to fix the unified build error.

No tests since no new functionality.

• Modules/webgpu/WebGPUDevice.cpp:

LayoutTests:

Increase the timer of recording to 2 seconds until we support timeslice in order to reduce flakiness.

• http/wpt/mediarecorder/MediaRecorder-dataavailable.html:
• http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:

1:23 PM Changeset in webkit [237649] by jer.noble@apple.com

• 14 edits in trunk/Source/WebCore

[EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE
​https://bugs.webkit.org/show_bug.cgi?id=190946

Reviewed by Eric Carlson.

Use separate AVContentKeySessions per CDMInstanceSession (rather than one AVContentKeySession per
CDMInstance).

• Add a mechanism for sending a message out from platform/CDMInstance to MediaKeySession without requiring MediaKeySession to send a callback first.

• Move all the AVContentKeySession delegate methods from CDMInstanceFairPlayStreamingAVFObjC to CDMInstanceSessionFairPlayStreamingAVFObjC.

• Add a mechanism for requesting the correct CDMInstanceSession for a given KeyID.

• Support key renewal through a "renew" message.

• Remember the keyID in SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID() and ask for the correct CDMInstanceSession for that keyID in attemptToDecrypt().

• Pass the CDMInstance down from MediaPlayerPrivateMediaSourceAVFObjC -> SourceBufferPrivateAVFObjC.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::sendMessage):

• Modules/encryptedmedia/MediaKeySession.h:
• platform/encryptedmedia/CDMInstanceSession.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(-[WebCoreFPSContentKeySessionDelegate initWithParent:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::createSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::~CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::keyIDsForRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyIDs):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::nextRequest):
(WebCore::requestStatusToCDMStatus):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitingForKey const):

• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceAttached):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceDetached):
(WebCore::MediaSourcePrivateAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaSourcePrivateAVFObjC::waitingForKey const):
(WebCore::MediaSourcePrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
(WebCore::SourceBufferPrivateAVFObjC::attemptToDecrypt):
(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

1:16 PM Changeset in webkit [237648] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
​https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>

Reviewed by Dean Jackson.

On macOS 10.12, we don't attempt secure archival at all because SECURE_ARCHIVER_API is turned off, and on macOS
10.14, NSFileWrapper supports secure coding. However, on macOS 10.13, SECURE_ARCHIVER_API is on despite
NSFileWrapper not being securely codable, so we're unable to serialize attachment data.

To fix this, we only use the secure archiver on ≥ macOS 10.14 and ≥ iOS 12.

• UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::createSerializedRepresentation const):

1:08 PM Changeset in webkit [237647] by commit-queue@webkit.org

• 18 edits
  6 adds in trunk

Add credit card autofill button
​https://bugs.webkit.org/show_bug.cgi?id=191051
<rdar://problem/45657011>

Patch by Zach Li <​zacharyli323@gmail.com> on 2018-10-31
Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

• css/html.css:

(input::-webkit-credit-card-auto-fill-button):
Add credit card autofill button.
(input::-webkit-credit-card-auto-fill-button:hover):
(input::-webkit-credit-card-auto-fill-button:active):

• html/HTMLTextFormControlElement.h:
• html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):

• platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillCreditCardLabel):

• platform/LocalizedStrings.h:
• testing/Internals.cpp:

(WebCore::toAutoFillButtonType):
(WebCore::toInternalsAutoFillButtonType):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:

Introduce a new button type for credit card autofill.

• WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

• WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

LayoutTests:

• fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
• fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html: Added.
• fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
• fast/forms/auto-fill-button/last-auto-fill-button-type.html:
• platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
• platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png: Added.
• platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.

1:05 PM Changeset in webkit [237646] by Chris Dumez

• 8 edits
  6 adds in trunk/LayoutTests/imported/w3c

Resync XHR Web Platform Tests from upstream 44dd29fb0d
​https://bugs.webkit.org/show_bug.cgi?id=191116

Reviewed by Youenn Fablet.

• web-platform-tests/xhr/getallresponseheaders-expected.txt:
• web-platform-tests/xhr/getallresponseheaders.htm:
• web-platform-tests/xhr/getresponseheader.any-expected.txt:
• web-platform-tests/xhr/getresponseheader.any.js:

(forEach.testValues.async_test.t.client.onload.t.step_func_done):
(async_test.t.client.onload.t.step_func_done): Deleted.

• web-platform-tests/xhr/getresponseheader.any.worker-expected.txt:
• web-platform-tests/xhr/resources/header-content-length-twice.asis: Added.
• web-platform-tests/xhr/resources/headers-double-empty.asis: Added.
• web-platform-tests/xhr/resources/headers-some-are-empty.asis: Added.
• web-platform-tests/xhr/resources/w3c-import.log:
• web-platform-tests/xhr/setrequestheader-combining.window-expected.txt: Added.
• web-platform-tests/xhr/setrequestheader-combining.window.html: Added.
• web-platform-tests/xhr/setrequestheader-combining.window.js: Added.

(test):

• web-platform-tests/xhr/w3c-import.log:

11:44 AM Changeset in webkit [237645] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

Adjust inlining threshold for new bytecode format
​https://bugs.webkit.org/show_bug.cgi?id=191115

Reviewed by Saam Barati.

The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.

• runtime/Options.h:

11:25 AM Changeset in webkit [237644] by Devin Rousso

• 15 edits in trunk

Web Inspector: Audit: show metadata for results
​https://bugs.webkit.org/show_bug.cgi?id=190853
<rdar://problem/45527623>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.prototype.async run):
Capture timestamps around the RunetimeAgent.evaluate call, as well as the URL of the page.

• UserInterface/Models/AuditTestCaseResult.js:

(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get metadata): Added.
(WI.AuditTestCaseResult.prototype.toJSON):

• UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):

• UserInterface/Views/AuditTestCaseContentView.css:

(.content-view.audit-test-case > header h1): Added.
(.content-view.audit-test-case > header h1 > img): Added.
(.content-view.audit-test-case > header > .metadata): Added.
(.content-view.audit-test-case > header > .metadata > .source > time): Added.
(.content-view.audit-test-case > header > .metadata > .source > a): Added.
(.content-view.audit-test-case > header > .metadata > .duration): Added.
(.content-view.audit-test-case > header > h1): Deleted.
(.content-view.audit-test-case > header > h1 > img): Deleted.
Display any metadata information where the WI.ScopeBar is for WI.AuditTestGroupContentViews.

• UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test > header):
(.content-view.audit-test > header > .information): Added.

• UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > header):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .information): Deleted.
Move common CSS rules to common parent class.

• UserInterface/Base/Utilities.js:

LayoutTests:

• inspector/model/auditTestCaseResult-expected.txt:
• inspector/model/auditTestCaseResult.html:
• inspector/model/auditTestGroupResult-expected.txt:
• inspector/model/auditTestGroupResult.html:
• inspector/unit-tests/string-utilities-expected.txt:
• inspector/unit-tests/string-utilities.html:

10:26 AM Changeset in webkit [237643] by eric.carlson@apple.com

• 7 edits in trunk

[MediaStream] Don't reveal device IDs until the user has granted permission to capture
​https://bugs.webkit.org/show_bug.cgi?id=191112
<rdar://problem/45699932>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, existing tests updated.

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start): Don't reveal device ID or group ID until the user
has granted permssion to capture.

LayoutTests:

• TestExpectations: Skip http/tests/media/media-stream/enumerate-devices-source-id-persistent.html

and http/tests/media/media-stream/enumerate-devices-source-id.html for now, they don't make sense
with these changes and will be updated to pass in a future patch.

• fast/mediastream/MediaStreamTrack-getCapabilities.html:
• fast/mediastream/get-user-media-device-id-expected.txt:
• fast/mediastream/get-user-media-device-id.html:

10:19 AM Changeset in webkit [237642] by commit-queue@webkit.org

• 17 edits
  4 copies
  10 adds in trunk

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
​https://bugs.webkit.org/show_bug.cgi?id=190778

Patch by YUHAN WU <​yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-record/BlobEvent-constructor-expected.txt:
• web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution-expected.txt: Added.
• web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html: Added.
• web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
• web-platform-tests/mediacapture-record/MediaRecorder-stop.html:
• web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html: Added.

Source/WebCore:

Implement JavaScript dispatch event dataavailable and JavaScript exposed method stop().
Implement a mock string as the output buffer of MediaRecorder.
Remove the declaration of timecode in BlobEvent since it has not been implemented in MediaRecorder and MediaRecorderPrivate.

Tests: http/wpt/mediarecorder/MediaRecorder-dataavailable.html

http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html
imported/w3c/web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html

• CMakeLists.txt:
• Modules/mediarecorder/BlobEvent.cpp: Added.

(WebCore::BlobEvent::create):
(WebCore::BlobEvent::BlobEvent):
(WebCore::BlobEvent::eventInterface const):

• Modules/mediarecorder/BlobEvent.h:
• Modules/mediarecorder/BlobEvent.idl:
• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::stop):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::stopRecordingInternal):
(WebCore::MediaRecorder::didAddOrRemoveTrack):
(WebCore::MediaRecorder::trackEnded):
(WebCore::MediaRecorder::sampleBufferUpdated):
(WebCore::MediaRecorder::audioSamplesAvailable):
(WebCore::MediaRecorder::scheduleDeferredTask):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediarecorder/MediaRecorder.idl:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/EventNames.h:
• dom/EventNames.in:
• platform/mediarecorder/MediaRecorderPrivate.h: Added.
• platform/mediarecorder/MediaRecorderPrivateMock.cpp: Added.

(WebCore::MediaRecorderPrivateMock::sampleBufferUpdated):
(WebCore::MediaRecorderPrivateMock::audioSamplesAvailable):
(WebCore::MediaRecorderPrivateMock::generateMockString):
(WebCore::MediaRecorderPrivateMock::fetchData):

• platform/mediarecorder/MediaRecorderPrivateMock.h: Added.

LayoutTests:

These tests are used to check if MediaRecorder can generate both video and audio buffers through mock source.

• http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-dataavailable.html: Added.
• http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html: Added.
• platform/win/TestExpectations:

9:39 AM Changeset in webkit [237641] by Tadeu Zagallo

• 3 edits
  1 add in trunk

REGRESSION(r237547): Exception handlers should be aware of wide opcodes
​https://bugs.webkit.org/show_bug.cgi?id=191108
<rdar://problem/45690700>

Reviewed by Saam Barati.

JSTests:

• stress/wide-op_catch.js: Added.

(catch):

Source/JavaScriptCore:

When linking the handler, we need to check whether the target op_catch is
wide or narrow in order to chose the right code pointer for the handler.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

9:33 AM Changeset in webkit [237640] by guijemont@igalia.com

• 2 edits in trunk/Tools

Don't run JIT tests on 32-bit platforms
​https://bugs.webkit.org/show_bug.cgi?id=191074

Reviewed by Michael Catanzaro.

• Scripts/run-jsc-stress-tests:

9:23 AM Changeset in webkit [237639] by Chris Dumez

• 8 edits
  2 adds in trunk

[PSON] When process-swapping for a POST request the HTTP body gets dropped
​https://bugs.webkit.org/show_bug.cgi?id=191046
<rdar://problem/45229732>

Reviewed by Alex Christensen.

Source/WebKit:

For performance reasons, the ResourceRequest IPC encoder does not encode the request's HTTP body (aka form data).
When we decide to process-swap for a POST request in WebPageProxy::decidePolicyForNavigationAction(), the request
we pass the new WebProcess thus no longer has a HTTP body and the load will likely fail in the new process.

To address the issue, we now pass the request body along with the request when sending the DecidePolicyForNavigationActionAsync
/ DecidePolicyForNavigationActionSync IPC from the WebProcess to the UIProcess. No action is needed for the
LoadRequest IPC to the new WebProcess since the LoadParameters' IPC encoder takes care of encoding the request's
body already.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

LayoutTests:

Add layout test coverage.

• http/tests/misc/form-post-textplain-cross-site-expected.txt: Added.
• http/tests/misc/form-post-textplain-cross-site.html: Added.

9:09 AM Changeset in webkit [237638] by dinfuehr@igalia.com

• 6 edits in trunk/Source/JavaScriptCore

Align entries in metadata table
​https://bugs.webkit.org/show_bug.cgi?id=191062

Reviewed by Filip Pizlo.

Entries in the metadata table need to be aligned on some 32-bit
architectures.

• bytecode/MetadataTable.h:

(JSC::MetadataTable::forEach):

• bytecode/Opcode.cpp:

(JSC::metadataAlignment):

• bytecode/Opcode.h:
• bytecode/UnlinkedMetadataTableInlines.h:

(JSC::UnlinkedMetadataTable::finalize):

• generator/Section.rb:

8:19 AM Changeset in webkit [237637] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
​https://bugs.webkit.org/show_bug.cgi?id=191110

Reviewed by Michael Catanzaro.

Covered by existing tests.

Turns out that this method is expected to reject domains that
are not registrable. Also sync with the Mac implementation in
that given domains that are not all ASCII should be returned
back as is. This fixes the remaining Public Suffix API tests.

• platform/soup/PublicSuffixSoup.cpp:

(WebCore::topPrivatelyControlledDomain):

8:08 AM Changeset in webkit [237636] by Antti Koivisto

• 11 edits
  4 deletes in trunk/Source

Remove LayerFlushScheduler
​https://bugs.webkit.org/show_bug.cgi?id=191103

Reviewed by Anders Carlsson.

Source/WebCore:

It is only used in WK1.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ca/LayerFlushScheduler.cpp: Removed.
• platform/graphics/ca/LayerFlushScheduler.h: Removed.
• platform/graphics/ca/LayerFlushSchedulerClient.h: Removed.
• platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Removed.

Source/WebKitLegacy/mac:

Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
all the virtual cruft.

• WebView/WebViewData.h:

(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
(): Deleted.

• WebView/WebViewData.mm:

(currentRunLoop):
(WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::schedule):
(WebViewLayerFlushScheduler::invalidate):
(WebViewLayerFlushScheduler::layerFlushCallback):

7:21 AM Changeset in webkit [237635] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Missing from r237634

• layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::formattingContext):

6:51 AM Changeset in webkit [237634] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC] Do not pass LayoutState& to compute* and layout* functions
​https://bugs.webkit.org/show_bug.cgi?id=191100

Reviewed by Antti Koivisto.

Reduce noise by removing LayoutState& parameter where possible.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

• layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

• layout/blockformatting/BlockFormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeFloatPosition const):
(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

• layout/inlineformatting/InlineFormattingContext.h:

6:50 AM Changeset in webkit [237633] by Alan Bujtas

• 14 edits in trunk/Source/WebCore

[LFC] FormattingContext class should take FormattingState&
​https://bugs.webkit.org/show_bug.cgi?id=191099

Reviewed by Antti Koivisto.

This is in preparation for not passing LayoutState& into every layout functions.
FormattingContext has FormattingState now and LayoutState can be acquired through FormattingState.
LayoutState <- FormattingState <- FormattingContext

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::formattingState const):
(WebCore::Layout::FormattingContext::layoutState const):

• layout/FormattingContext.h:
• layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::FormattingState):

• layout/FormattingState.h:

(WebCore::Layout::FormattingState::layoutState const):

• layout/LayoutFormattingState.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::BlockFormattingContext):

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::BlockFormattingState):
(WebCore::Layout::BlockFormattingState::formattingContext):
(WebCore::Layout::BlockFormattingState::formattingContext const): Deleted.

• layout/blockformatting/BlockFormattingState.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::InlineFormattingState):
(WebCore::Layout::InlineFormattingState::formattingContext):
(WebCore::Layout::InlineFormattingState::formattingContext const): Deleted.

• layout/inlineformatting/InlineFormattingState.h:

6:43 AM Changeset in webkit [237632] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

[LFC] The *FormattingState class should provide the *FormattingContext.
​https://bugs.webkit.org/show_bug.cgi?id=191089

Reviewed by Antti Koivisto.

BlockFormattingState provides the BlockFormattingContext object, while InlineFormattingState provides the InlineFormattingContext.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

• layout/FormattingState.h:
• layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::formattingContext const): Deleted.

• layout/LayoutFormattingState.h:
• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

• layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::formattingContext const):

• layout/blockformatting/BlockFormattingState.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

• layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::formattingContext const):

• layout/inlineformatting/InlineFormattingState.h:

6:37 AM Changeset in webkit [237631] by Alan Bujtas

• 38 edits
  2 moves in trunk/Source/WebCore

[LFC] Rename LayoutContext to LayoutState
​https://bugs.webkit.org/show_bug.cgi?id=191080

Reviewed by Antti Koivisto.

LayoutContext naming was a bit misleading since none of the other *FormattingContext classes (BlockFormattingContext etc) hold states.
(LayoutContext.cpp -> LayoutFormattingState.cpp because LayoutState.cpp name is already taken.)

Now the current state is as follows:

LayoutState has

1. Layout tree
2. State content for each formatting subtrees
3. Display tree

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopLeftToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

• layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::FormattingState):

• layout/FormattingState.h:

(WebCore::Layout::FormattingState::setInstrinsicWidthConstraints):
(WebCore::Layout::FormattingState::instrinsicWidthConstraints const):

• layout/LayoutFormattingState.cpp: Renamed from Source/WebCore/layout/LayoutContext.cpp.

(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot):
(WebCore::Layout::LayoutState::updateLayout):
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):
(WebCore::Layout::LayoutState::styleChanged):
(WebCore::Layout::LayoutState::markNeedsUpdate):
(WebCore::Layout::LayoutState::formattingStateForBox const):
(WebCore::Layout::LayoutState::establishedFormattingState const):
(WebCore::Layout::LayoutState::createFormattingStateForFormattingRootIfNeeded):
(WebCore::Layout::LayoutState::formattingContext const):

• layout/LayoutFormattingState.h: Renamed from Source/WebCore/layout/LayoutContext.h.

(WebCore::Layout::LayoutState::setInQuirksMode):
(WebCore::Layout::LayoutState::hasDisplayBox const):
(WebCore::Layout::LayoutState::inQuirksMode const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const): Deleted.

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::hasPrecomputedMarginTop):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

• layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::isStretchedToInitialContainingBlock):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginTop):

• layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::BlockFormattingState):

• layout/blockformatting/BlockFormattingState.h:
• layout/blockformatting/BlockInvalidation.cpp:

(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):

• layout/blockformatting/BlockInvalidation.h:
• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBottom):

• layout/displaytree/DisplayBox.h:
• layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):

• layout/floats/FloatAvoider.h:
• layout/floats/FloatBox.cpp:

(WebCore::Layout::FloatBox::FloatBox):

• layout/floats/FloatBox.h:
• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFloatAvoiding const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

• layout/floats/FloatingContext.h:

(WebCore::Layout::FloatingContext::layoutState const):
(WebCore::Layout::FloatingContext::layoutContext const): Deleted.

• layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::FloatingState):
(WebCore::Layout::FloatingState::constraints const):

• layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::create):
(WebCore::Layout::FloatingState::layoutState const):
(WebCore::Layout::FloatingState::layoutContext const): Deleted.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeFloatPosition const):
(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

• layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::InlineFormattingState):

• layout/inlineformatting/InlineFormattingState.h:
• layout/inlineformatting/InlineInvalidation.cpp:

(WebCore::Layout::InlineInvalidation::invalidate):

• layout/inlineformatting/InlineInvalidation.h:
• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::InlineLineBreaker):
(WebCore::Layout::InlineLineBreaker::runWidth const):

• layout/inlineformatting/InlineLineBreaker.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):

• layout/layouttree/LayoutTreeBuilder.h:
• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

3:10 AM Changeset in webkit [237630] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=191063

Patch by Jim Mason <​jmason@ibinx.com> on 2018-10-31
Reviewed by Yusuke Suzuki.

• wasm/WasmFaultSignalHandler.cpp:

2:56 AM Changeset in webkit [237629] by Antti Koivisto

• 3 edits in trunk/Source/WebKit

Stop using LayerFlushScheduler in WK2
​https://bugs.webkit.org/show_bug.cgi?id=191065

Reviewed by Tim Horton.

Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver
directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback):
(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver):

12:29 AM Changeset in webkit [237628] by Claudio Saavedra

• 4 edits in trunk/Source/WebKit

[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
​https://bugs.webkit.org/show_bug.cgi?id=190956

Reviewed by Youenn Fablet.

Similarly to what was done for the IPC coders, serialize
the entire certificate chain in the cache coder. Bump
the cache version due to the caching format changes.

• NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr<GByteArray> coders.
• NetworkProcess/cache/NetworkCacheCodersSoup.cpp:

(WTF::Persistence::certificatesDataListFromCertificateInfo):
(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::encode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::decode):

• NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.