⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 5, 2018:

11:11 PM Changeset in webkit [237848] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[WPE] Remove BackingStore, BackingStoreCairo implementation files from build
​https://bugs.webkit.org/show_bug.cgi?id=191269

Reviewed by Michael Catanzaro.

  • SourcesWPE.txt: Drop the BackingStore.cpp and BackingStoreCairo.cpp

files from the WPE build. These are not used at all in WPE configuration
as they are only used by the GTK+ port for non-AC functionality.

11:09 PM Changeset in webkit [237847] by zandobersek@gmail.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Place Fontconfig-specific RefPtr specializations in RefPtrFontconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=191267

Reviewed by Michael Catanzaro.

Move the Fontconfig-specific RefPtr specialization declarations from
RefPtrCairo.h to RefPtrFontconfig.h, with definitions moved to the new
RefPtrFontconfig.cpp implementation file. These specializations are
not tied to Cairo in any way.

  • platform/FreeType.cmake:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cairo/RefPtrCairo.cpp:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:
  • platform/graphics/freetype/RefPtrFontconfig.cpp: Added.

(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/graphics/freetype/RefPtrFontconfig.h: Copied from Source/WebCore/platform/graphics/cairo/RefPtrCairo.h.
11:01 PM Changeset in webkit [237846] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

[CMake] Fix WebCore/Modules includes
​https://bugs.webkit.org/show_bug.cgi?id=191287

Reviewed by Fujii Hironori.

No new tests. No change in behavior.

Add in applicationmanifest to the list of includes and sort the
modules directory.

  • CMakeLists.txt:
8:35 PM Changeset in webkit [237845] by mmaxfield@apple.com
  • 17 edits in trunk

Cache glyph paths and share underline skipping code between all the ports
​https://bugs.webkit.org/show_bug.cgi?id=191239

Reviewed by Alex Christensen.

PerformanceTests:

Measures the performance of drawing a whole lot of underlines

  • Layout/underline.html: Added.

Source/WebCore:

I was hoping that caching the glyph paths was going to be a performance progression,
but it turns out that the additional overhead of WebCore::Path compensated for it.
In total, the performance is the same (my testing says that this patch is a 1%
progression, but that's within the noise).

Because the ink skipping logic is now shared among all ports, Windows now gets it for
free.

Test: PerformanceTests/Layout/underline.html

  • platform/graphics/Font.cpp:

(WebCore::Font::pathForGlyph const):

  • platform/graphics/Font.h:
  • platform/graphics/FontCascade.cpp:

(WebCore::computeUnderlineType):
(WebCore::GlyphIterationState::GlyphIterationState):
(WebCore::findIntersectionPoint):
(WebCore::updateX):
(WebCore::findPathIntersections):
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
(WebCore::GlyphToPathTranslator::containsMorePaths):
(WebCore::GlyphToPathTranslator::path):
(WebCore::GlyphToPathTranslator::extents):
(WebCore::GlyphToPathTranslator::underlineType):
(WebCore::GlyphToPathTranslator::advance):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap::existingMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::existingMetricsForGlyph const):
(WebCore::GlyphMetricsMap<std::optional<Path>>::unknownMetrics):

  • platform/graphics/TextRun.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformPathForGlyph const):
(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::CairoGlyphToPathTranslator::path): Deleted.
(WebCore::CairoGlyphToPathTranslator::extents): Deleted.
(WebCore::CairoGlyphToPathTranslator::underlineType): Deleted.
(WebCore::CairoGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::MacGlyphToPathTranslator::path): Deleted.
(WebCore::MacGlyphToPathTranslator::extents): Deleted.
(WebCore::MacGlyphToPathTranslator::underlineType): Deleted.
(WebCore::MacGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformPathForGlyph const):

  • rendering/TextDecorationPainter.cpp:

(WebCore::drawSkipInkUnderline):
(WebCore::TextDecorationPainter::paintTextDecoration):

Source/WTF:

Remove CSS3_TEXT_DECORATION_SKIP_INK. It's now interoperable and part of the Web Platform.

  • wtf/Platform.h:
8:32 PM Changeset in webkit [237844] by mmaxfield@apple.com
  • 23 edits in trunk/Source/WebCore

Clean up text decoration drawing code
​https://bugs.webkit.org/show_bug.cgi?id=191245

Reviewed by Zalan Bujtas.

This is some general clean up of the text decorations code. There is no behavior change.

This patch modifies GraphicsContext::drawLineForText() & friends to accept a FloatRect instead of a FloatPoint + float width.
This is helpful because it allows for easier bounding box calculations.
This patch also removes some redundant computations that the skip:ink codepath was performing.
This patch also refactors the wavy decoration parameters to not use out params.

No new tests because there is no behavior change.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::computeUnderlineBoundsForText):
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextImpl.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawLinesForText::apply const):
(WebCore::DisplayList::DrawLinesForText::localBounds const):
(WebCore::DisplayList::operator<<):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawLinesForText::create):
(WebCore::DisplayList::DrawLinesForText::thickness const):
(WebCore::DisplayList::DrawLinesForText::DrawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintMarkedTextDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline const):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

  • rendering/TextDecorationPainter.cpp:

(WebCore::strokeWavyTextDecoration):
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::drawSkipInkUnderline): Deleted.

  • rendering/TextDecorationPainter.h:

(WebCore::TextDecorationPainter::setInlineTextBox):
(WebCore::TextDecorationPainter::setWidth):
(WebCore::TextDecorationPainter::setFont): Deleted.
(WebCore::TextDecorationPainter::setBaseline): Deleted.

  • style/InlineTextBoxStyle.cpp:

(WebCore::getWavyStrokeParameters):
(WebCore::visualOverflowForDecorations):

  • style/InlineTextBoxStyle.h:
8:30 PM Changeset in webkit [237843] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after r237835
​https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

  • rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness::operator== const):

8:07 PM Changeset in webkit [237842] by Wenson Hsieh
  • 10 edits
    2 adds in trunk

[iOS] Swatch appears squished and off-center in inputs of type color
​https://bugs.webkit.org/show_bug.cgi?id=191279
<rdar://problem/45816319>

Reviewed by Tim Horton.

Source/WebCore:

This patch makes some small adjustments to color inputs on iOS to bring them closer to the intended design.
See comments below for more details.

Tests: fast/forms/color/color-input-uses-color-well-appearance.html

fast/forms/color/input-appearance-color.html

  • css/html.css:

Adjust the UA stylesheet for color inputs on iOS.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintDecorations):

When painting decorations for ColorWellPart, treat it as a standard button instead of the square button
appearance.

(WebCore::RenderTheme::colorInputStyleSheet const):

Add -webkit-appearance: color-well; to the stylesheet for color inputs. Previously, this was special-cased on
iOS, where color input elements had appearances of textfield; however, this patch makes some adjustments to
RenderThemeIOS, allowing us to use color-well on iOS.

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::platformUsesColorWellAppearance const): Deleted.

Remove this from RenderTheme. This is no longer necessary, since all platforms now use
-webkit-appearance: color-well;.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustButtonStyle const):

When painting buttons for color inputs, don't add rounded corners that are present by default for regular
buttons.

LayoutTests:

  • fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html: Added.
  • fast/forms/color/color-input-uses-color-well-appearance.html: Added.

Add a test to verify that setting -webkit-appearance: textfield; on a color input causes the color input to
render differently from a color input with a default appearance.

  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:

In the WebKit2 port of iOS, enable a handful of color input tests that are currently disabled.

  • platform/ios/fast/forms/color/input-appearance-color-expected.txt:

Rebaseline an existing test on iOS.

6:30 PM Changeset in webkit [237841] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.1.1

Tag Safari-606.3.4.1.1.

5:59 PM Changeset in webkit [237840] by Alan Coon
  • 1 edit in branches/safari-606.3.4.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

Apply patch. rdar://problem/45523764.

5:03 PM Changeset in webkit [237839] by bshafiei@apple.com
  • 8 edits
    2 adds in branches/safari-606.3.4.0-branch

Cherry-pick r237837. rdar://problem/45811371

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::setInterruptedForTesting):
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::beginInterruption): (WebCore::CoreAudioCaptureSource::endInterruption):
  • testing/Internals.cpp: (WebCore::Internals::setMediaStreamSourceInterrupted):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [237838] by bshafiei@apple.com
  • 7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

4:45 PM Changeset in webkit [237837] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setInterruptedForTesting):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::beginInterruption):
(WebCore::CoreAudioCaptureSource::endInterruption):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaStreamSourceInterrupted):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.
4:21 PM Changeset in webkit [237836] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Generalize trailing SDK specifier (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo):
(TestPlatformInfo.test_available_sdks):

4:11 PM Changeset in webkit [237835] by mmaxfield@apple.com
  • 18 edits
    6 adds in trunk

Parsing support for text-underline-offset and text-decoration-thickness
​https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

Source/WebCore:

Before we can implement the properties properly, we have to parse them.

​https://github.com/w3c/csswg-drafts/issues/3118#issuecomment-432297480 describes the grammar:

text-underline-position: auto | [ [ under | from-font]
[ left | right ] ]

text-underline-offset: auto | <length>
text-decoration-thickness: auto | from-font | <length>

This patch also takes the opportunity to update the grammar of text-underline-position to match the spec,
and to add an alias to the unprefixed version.

We still don't support the left and right values on text-underline-position. We should add those eventually.

Tests: fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html

fast/css3-text/css3-text-decoration/text-underline-offset-parse.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::textUnderlineOffsetToCSSValue):
(WebCore::textDecorationThicknessToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition const):
(WebCore::CSSPrimitiveValue::operator OptionSet<TextUnderlinePosition> const): Deleted.

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
(WebCore::StyleBuilderConverter::convertTextUnderlineOffset):
(WebCore::StyleBuilderConverter::convertTextDecorationThickness):

  • css/StyleResolver.cpp:

(WebCore::shouldApplyPropertyInParseOrder):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTextUnderlineOffset):
(WebCore::consumeTextDecorationThickness):
(WebCore::CSSPropertyParser::parseSingleValue):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textUnderlinePosition const):
(WebCore::RenderStyle::textUnderlineOffset const):
(WebCore::RenderStyle::textDecorationThickness const):
(WebCore::RenderStyle::setTextUnderlinePosition):
(WebCore::RenderStyle::setTextUnderlineOffset):
(WebCore::RenderStyle::setTextDecorationThickness):
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::initialTextUnderlineOffset):
(WebCore::RenderStyle::initialTextDecorationThickness):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/TextDecorationThickness.h: Added.

(WebCore::TextDecorationThickness::createWithAuto):
(WebCore::TextDecorationThickness::createFromFont):
(WebCore::TextDecorationThickness::createWithLength):
(WebCore::TextDecorationThickness::isAuto const):
(WebCore::TextDecorationThickness::isFromFont const):
(WebCore::TextDecorationThickness::isLength const):
(WebCore::TextDecorationThickness::setLengthValue):
(WebCore::TextDecorationThickness::lengthValue const):
(WebCore::TextDecorationThickness::operator== const):
(WebCore::TextDecorationThickness::operator!= const):
(WebCore::TextDecorationThickness::TextDecorationThickness):
(WebCore::operator<<):

  • rendering/style/TextUnderlineOffset.h: Added.

(WebCore::TextUnderlineOffset::createWithAuto):
(WebCore::TextUnderlineOffset::createWithLength):
(WebCore::TextUnderlineOffset::isAuto const):
(WebCore::TextUnderlineOffset::isLength const):
(WebCore::TextUnderlineOffset::setLengthValue):
(WebCore::TextUnderlineOffset::lengthValue const):
(WebCore::TextUnderlineOffset::lengthOr const):
(WebCore::TextUnderlineOffset::operator== const):
(WebCore::TextUnderlineOffset::operator!= const):
(WebCore::TextUnderlineOffset::TextUnderlineOffset):
(WebCore::operator<<):

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

  • style/InlineTextBoxStyle.h:

LayoutTests:

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html: Update the

test for the new grammar of text-underline-position

  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse.html: Added.
4:09 PM Changeset in webkit [237834] by mmaxfield@apple.com
  • 20 edits
    9 adds in trunk

Spelling dots are drawn in the wrong place
​https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

  • Dots should not be clipped.
  • Dots should be horizontally centered.
  • Dots should be drawn behind the text.
  • Distance from the baseline to the top of the dot should be 11.035% of font size.
  • Dot diameter should be 13.247% of the font size.
  • Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
  • The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html

editing/spelling/spelling-dots-position-3.html
editing/spelling/spelling-dots-position.html
editing/spelling/spelling-dots-repaint.html

  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,

because there is no guarantee the spelling dots will lie inside the layout rect of the element.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.

  • rendering/InlineFlowBox.h: Comments should explain why, not say what.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.

  • rendering/InlineTextBox.h: Declare the helper methods.
  • rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of

spelling dots opt us out of SLL.

(WebCore::SimpleLineLayout::canUseForWithReason):

  • rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printReason):

  • rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

  • editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,

this is a version of Ahem with a very small descent, so that the dots don't intersect
with the text itself.

  • editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-expected.html: Added.
  • editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in

the wrong place.

  • editing/spelling/spelling-dots-repaint-expected.html: Added.
  • editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element

with spelling dots, and then deleting the element from the document. The spelling
dots should be removed too.

  • fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
  • fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate

for new spelling dot positions.

3:59 PM Changeset in webkit [237833] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
​https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:
3:11 PM Changeset in webkit [237832] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=191278

Unreviewed test gardening.

2:03 PM Changeset in webkit [237831] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: turn off Start button when all tests are removed
​https://bugs.webkit.org/show_bug.cgi?id=191235

Reviewed by Matt Baker.

  • UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):

1:38 PM Changeset in webkit [237830] by Chris Dumez
  • 7 edits in trunk

Use same limit for page cache and suspended pages
​https://bugs.webkit.org/show_bug.cgi?id=191266

Reviewed by Geoffrey Garen.

Source/WebKit:

Use same limit for page cache and suspended pages as they serve the same purpose.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _maximumSuspendedPageCount]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateMaxSuspendedPageCount):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::addSuspendedPageProxy):

  • UIProcess/WebProcessPool.h:

Tools:

Update API tests accordingly.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12:43 PM Changeset in webkit [237829] by ajuma@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests/imported/w3c

[IntersectionObserver] Update WPTs to the latest upstream version
​https://bugs.webkit.org/show_bug.cgi?id=191274

Reviewed by Simon Fraser.

  • web-platform-tests/intersection-observer/bounding-box-expected.txt:
  • web-platform-tests/intersection-observer/bounding-box.html:
  • web-platform-tests/intersection-observer/target-in-different-window-expected.txt: Added.
  • web-platform-tests/intersection-observer/target-in-different-window.html: Added.
  • web-platform-tests/intersection-observer/w3c-import.log:
12:36 PM Changeset in webkit [237828] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp

Another attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:26 PM Changeset in webkit [237827] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:03 PM Changeset in webkit [237826] by Basuke Suzuki
  • 2 edits in trunk/Tools

[style] Exclude style check for auto generated files.
​https://bugs.webkit.org/show_bug.cgi?id=191118

Reviewed by Eric Carlson.

Some files checked in to the repository are generated by other tools. In this patch,
"MiniBrowserLibResource.h" is the file generated and managed by resource editor of
VisualStudio.

There's no need to check these files because it's not practical to fix the style errors
or it's hard to maintain those fixes.

  • Scripts/webkitpy/style/checkers/cpp.py:

(is_generated_file):
(CppChecker.check):

11:58 AM Changeset in webkit [237825] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash under DOMWindow::postMessageTimerFired()
​https://bugs.webkit.org/show_bug.cgi?id=191217
<rdar://problem/40888466>

Reviewed by Geoffrey Garen.

Source/WebCore:

Protect the frame in DOMWindow::postMessageTimerFired() before calling dispatchEvent() as dispatching the
event may cause JS to run and this JS may cause the frame to be destroyed, in which case we will crash
when trying to use the frame on the next line.

Test: fast/dom/Window/remove-frame-in-message-event-handler.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/remove-frame-in-message-event-handler-expected.txt: Added.
  • fast/dom/Window/remove-frame-in-message-event-handler.html: Added.
11:38 AM Changeset in webkit [237824] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=190680

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

  • flatpak/org.webkit.WebKit.yaml:
11:35 AM Changeset in webkit [237823] by don.olmstead@sony.com
  • 6 edits in trunk/Source/JavaScriptCore

Fix typos in closing ENABLE guards
​https://bugs.webkit.org/show_bug.cgi?id=191273

Reviewed by Keith Miller.

  • ftl/FTLForOSREntryJITCode.h:
  • ftl/FTLJITCode.h:
  • jsc.cpp:
  • wasm/WasmMemoryInformation.h:
  • wasm/WasmPageCount.h:
11:35 AM Changeset in webkit [237822] by dbates@webkit.org
  • 2 edits in trunk/Tools

[lldb-webkit] Fix formatting nits in Document and Frame summary strings
​https://bugs.webkit.org/show_bug.cgi?id=191094

Reviewed by Andy Estes.

Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
Document summary and add closing brace '}' to both Frame and Document summary strings to make
them look pretty.

  • lldb/lldb_webkit.py:

(WebCoreFrame_SummaryProvider):
(WebCoreDocument_SummaryProvider):

11:21 AM Changeset in webkit [237821] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make static_asserts in APICast into bitwise_cast
​https://bugs.webkit.org/show_bug.cgi?id=191272

Reviewed by Filip Pizlo.

  • API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

11:18 AM Changeset in webkit [237820] by Wenson Hsieh
  • 6 edits in trunk

[iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
​https://bugs.webkit.org/show_bug.cgi?id=191240
<rdar://problem/44872806>

Reviewed by Tim Horton.

Source/WebKit:

Allow WKWebView clients to override WKContentView's default input assistant item by plumbing the call to
-inputAssistantItem through -[WKWebView inputAssistantItem], such that if a client asks WKWebView for its
input assistant item and changes its leading or trailing bar button groups, the changes will be reflected by
WKContentView; additionally, this allows clients to achieve the same effect by overriding -inputAssistantItem
on WKWebView.

Test: KeyboardInputTests.ModifyInputAssistantItemBarButtonGroups

KeyboardInputTests.OverrideInputAssistantItemBarButtonGroups

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView inputAssistantItem]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAssistantItem]):

Route the call to [super inputAssistantItem] through -[WKWebView inputAssistantItem], so that the input
assistant item may be overridden via WKWebView.

(-[WKContentView inputAssistantItemForWebView]):

Tools:

Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
overriding -[WKWebView inputAssistantItem].

  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
(-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
(+[InputAssistantItemTestingWebView barButtonIcon]):
(+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
(+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
(-[InputAssistantItemTestingWebView inputAssistantItem]):
(TestWebKitAPI::TEST):

11:15 AM Changeset in webkit [237819] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects
​https://bugs.webkit.org/show_bug.cgi?id=190035

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

We can't rely on GStreamer timestamps to pass to EncodedImages after encoding
because libWebRTC doesn't use the timestamp we fed it but does
some computation on the input timestamp in the images we pass in before it passes
them back to the encoder. Then internally LibWebRTC relies on those exact timestamps
passed into the encoder to do checks and compute RTP timestamps so we need to carefully
pass the exact timestamps to LibWebRTC (in practice we still use GStreamer timestamps in
all the GStreamer processing pipelines as the WebRTC object basically wraps the "same"
GstSample all around, but we are not synced on the clock anyway).

  • platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:

(WebCore::LibWebRTCVideoFrameFromGStreamerSample):

  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::newSampleCallback):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::newSampleCallback):

11:12 AM Changeset in webkit [237818] by Wenson Hsieh
  • 6 edits
    2 adds in trunk

[iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
​https://bugs.webkit.org/show_bug.cgi?id=191226
<rdar://problem/45781765>

Reviewed by Tim Horton.

Source/WebCore:

When _setViewScale: SPI is used to adjust the layout scale factor of the page, we multiply minimum, initial
and maximum scales by the given layout scale factor to adjust for a larger or smaller minimum layout size.
However, in the case where the layout size scale factor is greater than 1 and we're also forcing the viewport to
be scalable, we override the default minimum scale with 1 (i.e. forceAlwaysUserScalableMinimumScale). This
means that the might be off by a small margin due to rounding error when computing the content width and view
width (see: r237743).

This means that in the case where (1) the viewport is forced to be user-scalable, and (2) we're ignoring meta
viewport parameters, and (3) _viewScale exceeds 1, we may end up computing a slightly different minimum scale
than the default minimum scale multiplied by the layout size scale factor; subsequently, the page scale factor
will be slightly different from initial scale, such that we'll no longer zoom to the new initial scale when
changing view scale.

This patch adjusts forceAlwaysUserScalableMinimumScale and forceAlwaysUserScalableMaximumScale to take the
current layout scale factor into account when computing min and max scales when the viewport is forced to be
always scalable.

Test: fast/viewport/ios/minimum-scale-after-changing-view-scale.html

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::minimumScale const):

  • page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::maximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMaximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMinimumScale const):

Turn these from constant values to const functions on ViewportConfiguration, which factor in the current
viewport layout size scale factor.

Tools:

Add a missing check for shouldIgnoreMetaViewport when comparing TestOptions, to ensure that "ignore meta
viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Add a new layout test that sets the view scale to several values greater than or equal to 1 and verifies that
the minimum scale and resulting scroll view scale are exactly the same as the view scale, when (1) the "ignores
meta viewport" preference is enabled, and (2) the viewport is forced to be always scalable.

  • fast/viewport/ios/minimum-scale-after-changing-view-scale-expected.txt: Added.
  • fast/viewport/ios/minimum-scale-after-changing-view-scale.html: Added.
11:01 AM Changeset in webkit [237817] by Matt Baker
  • 5 edits in trunk

Web Inspector: Table selection should not require that rows be in the cache
​https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

  • inspector/table/table-selection-expected.txt:
  • inspector/table/table-selection.html:
10:37 AM Changeset in webkit [237816] by dino@apple.com
  • 6 edits
    1 add in trunk/Source/WebCore

Expose a constructor for PointerEvent from PlatformTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=191238
<rdar://problem/45795682>

Reviewed by Antoine Quint.

Implement a constructor that takes a PlatformTouchEvent to
create a PointerEvent. At the moment the code to call this
constructor will live in WebKitAdditions, so no new tests
yet.

  • SourcesCocoa.txt: Add PointerEventIOS.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventNames.h: Add macros for pointerdown, pointermove,

pointerup, pointercancel.

  • dom/PointerEvent.cpp: Remove JSC namespace.
  • dom/PointerEvent.h: Add create and constructor that takes

a PlatformTouchEvent.

  • dom/ios/PointerEventIOS.cpp: Added.
10:09 AM Changeset in webkit [237815] by Alan Coon
  • 9 edits
    2 adds in tags/Safari-607.1.12.2

Cherry-pick r237774. rdar://problem/45377609

Mac production builds should sign the network process xpc service with entitlements
​https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
  • Configurations/NetworkService.xcconfig: Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process, except with the corresponoding network process entitlements file.
  • UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _networkProcessHasEntitlementForTesting:]):
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):
  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj: Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [237814] by Alan Coon
  • 4 edits
    1 add in tags/Safari-607.1.12.2

Cherry-pick r237711. rdar://problem/44176965

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
​https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

  • loader/ResourceLoadObserver.cpp: (WebCore::ResourceLoadObserver::logSubresourceLoading): (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added. (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]): (-[KeyboardEventListener handleEvent:]): (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:07 AM Changeset in webkit [237813] by Ryan Haddad
  • 17 edits in trunk/Source

Unreviewed, rolling out r237785.

Introduced layout test and API test failures on macOS and iOS.

Reverted changeset:

"[iOS] Issue initial paint soon after the visuallyNonEmpty
milestone is fired."
​https://bugs.webkit.org/show_bug.cgi?id=191078
​https://trac.webkit.org/changeset/237785

10:03 AM Changeset in webkit [237812] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r237784 and r237788.
​https://bugs.webkit.org/show_bug.cgi?id=191270

Caused mediastream layout test failures (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
​https://bugs.webkit.org/show_bug.cgi?id=191227
​https://trac.webkit.org/changeset/237784

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
​https://bugs.webkit.org/show_bug.cgi?id=191227
​https://trac.webkit.org/changeset/237788

9:54 AM Changeset in webkit [237811] by Chris Dumez
  • 10 edits
    4 adds in trunk/LayoutTests

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=191214

Reviewed by Geoff Garen.

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests from
upstream c583bcd7eb.

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.js: Added.

(test.frame.contentWindow.onpagehide):
(test.frame.contentDocument.onvisibilitychange):
(test.frame.contentWindow.onbeforeunload):
(test.frame.contentWindow.onunload):
(test):
(async_test):

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:
9:47 AM Changeset in webkit [237810] by Lucas Forschler
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

9:43 AM Changeset in webkit [237809] by msaboff@apple.com
  • 2 edits in trunk/JSTests

Unreviewed build fix for linux.

  • stress/regexp-compile-oom.js: Disabled for non-darwin OSes.
9:34 AM Changeset in webkit [237808] by Devin Rousso
  • 12 edits
    1 add in trunk

Web Inspector: show save/restore stack for recorded 2D Canvases
​https://bugs.webkit.org/show_bug.cgi?id=175283
<rdar://problem/34040756>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Instead of using plain objects for holding the WI.Recording's state, use a model object
so that more data can be passed around. When visualizing the state, show any previously
saved states in a WI.DetailsSection underneath the current state. If there are no saved
states (meaning there is only the current state), don't use a WI.DetailsSection.

  • UserInterface/Models/RecordingState.js: Added.

(WI.RecordingState):
(WI.RecordingState.fromContext):
(WI.RecordingState.async swizzleInitialState):
(WI.RecordingState.prototype.get source):
(WI.RecordingState.prototype.has):
(WI.RecordingState.prototype.get return):
(WI.RecordingState.prototype.toJSON):
(WI.RecordingState.prototype.[Symbol.iterator]):

  • UserInterface/Models/Recording.js:

(WI.Recording.prototype.async _process):
(WI.Recording.prototype.async _swizzleState): Deleted.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):
(WI.RecordingAction.deriveCurrentState): Deleted.

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement):
(WI.RecordingStateDetailsSidebarPanel.prototype.sizeDidChange): Added.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.isColorProperty): Deleted.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.createInlineSwatch): Deleted.

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.css:

(.sidebar > .panel.details.recording-state > .content .details-section > .header .source): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr.modified): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected).non-standard .name-column): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected) .unavailable): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid .inline-swatch): Added.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected).non-standard): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected) .unavailable): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid .inline-swatch): Deleted.

  • UserInterface/Main.html:
  • UserInterface/Test.html:
  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • inspector/canvas/recording-2d.html:
  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.log):
(TestPage.registerInitializer.async logRecording):

9:33 AM Changeset in webkit [237807] by Alan Coon
  • 7 edits in tags/Safari-607.1.12.2/Source

Versioning.

9:27 AM Changeset in webkit [237806] by Alan Coon
  • 1 copy in tags/Safari-607.1.12.2

New tag.

8:45 AM Changeset in webkit [237805] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test runner fails to respect default build type
​https://bugs.webkit.org/show_bug.cgi?id=190247

Reviewed by Carlos Garcia Campos.

Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.

  • glib/api_test_runner.py:

(TestRunner.init):

8:16 AM WebKitGTK/2.22.x edited by Michael Catanzaro
(diff)
8:08 AM Changeset in webkit [237804] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer][WebRTC] Error out when simulcast is activated
​https://bugs.webkit.org/show_bug.cgi?id=190678

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Implementing it is not for now yet.
Source/WebCore:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::InitEncode):

LayoutTests:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
8:07 AM Changeset in webkit [237803] by dinfuehr@igalia.com
  • 12 edits in trunk

Enable LLInt on ARMv7/Linux
​https://bugs.webkit.org/show_bug.cgi?id=191190

Reviewed by Yusuke Suzuki.

After enabling the new bytecode format in r237547, C_LOOP was
forced on all 32-bit platforms. Now enable LLInt again on
.:

ARMv7-Thumb2/Linux by default.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

ARMv7-Thumb2/Linux.

This adds a callee-saved register in ARMv7/Linux for the metadataTable and
stores/restores it on LLInt function calls. It also introduces the globaladdr-
instruction for the ARM-offlineasm to access the opcode-table.

  • jit/GPRInfo.h:
  • jit/RegisterSet.cpp:

(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • offlineasm/arm.rb:
  • offlineasm/asm.rb:
  • offlineasm/instructions.rb:

Source/WTF:

ARMv7-Thumb2/Linux by default.

  • wtf/Platform.h:
7:32 AM Changeset in webkit [237802] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
​https://bugs.webkit.org/show_bug.cgi?id=191241

Reviewed by Eric Carlson.

Moving the logic to observe the audio source to the point where the
RealtimeOutgoingAudioSource subclass is fully initialized.
Covered by existing tests.

  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::observeSource):

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::RealtimeOutgoingAudioSourceLibWebRTC):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):

7:09 AM Changeset in webkit [237801] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
​https://bugs.webkit.org/show_bug.cgi?id=190674

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
it can use to implement encoding for different formats exposing a trimmed down unified API.

It also adds proper handling of H264 profiles.

The added files follow GStreamer coding style as we aim at upstreaming the element
in the future.

Source/WebCore:

This is a refactoring so current tests already cover it.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: Added.

(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_bitrate):
(gst_webrtc_video_encoder_set_format):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(setup_x264enc):
(setup_vp8enc):
(setup_openh264enc):
(set_bitrate_kbit_per_sec):
(set_bitrate_bit_per_sec):
(gst_webrtc_video_encoder_class_init):
(gst_webrtc_video_encoder_init):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.h: Added.
  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::ImplementationName const):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):

Tools:

Reviewed by Philippe Normand.

  • Scripts/webkitpy/style/checker.py:
7:05 AM Changeset in webkit [237800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
​https://bugs.webkit.org/show_bug.cgi?id=190676

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Avoiding to have h264parse make assumption (which might be wrong at some
point).

  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

6:50 AM Changeset in webkit [237799] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Do not sync libwerbtc stream on the clock
​https://bugs.webkit.org/show_bug.cgi?id=190677

The approach here is basically to let libwebrtc do all the
synchronisation for us, and the same way as it is done in apple ports,
we basically try to display what libwebrtc outputs as fast as possible.

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Manually tested

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setSyncOnSink):
(WebCore::MediaPlayerPrivateGStreamer::syncOnClock):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
6:47 AM Changeset in webkit [237798] by ajuma@chromium.org
  • 4 edits in trunk

[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
​https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

  • web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

  • dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):

5:55 AM Changeset in webkit [237797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove some virtual methods in CachedRawResource
​https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

  • loader/cache/CachedRawResource.h:
4:19 AM Changeset in webkit [237796] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

2:46 AM Changeset in webkit [237795] by Michael Catanzaro
  • 2 edits in trunk/Tools

REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191225

Reviewed by Alejandro G. Castro.

Fix a memory leak causing this test to fail.

  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):

2:00 AM Changeset in webkit [237794] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

[GStreamer] Move elements registration to GStreamerCommon
​https://bugs.webkit.org/show_bug.cgi?id=191189

Reviewed by Xabier Rodriguez-Calvar.

It was a bit odd to have this in the base player class and to have
sub-classes calling a static function of the super-class.

Covered by existing tests.

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamerAndRegisterWebKitElements):

  • platform/graphics/gstreamer/GStreamerCommon.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

1:34 AM Changeset in webkit [237793] by Fujii Hironori
  • 2 edits in trunk/Source/JavaScriptCore

[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
​https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

  • jit/JIT.h: Changed is64BitType from a template class method to a

template inner class.

1:08 AM Changeset in webkit [237792] by zandobersek@gmail.com
  • 10 edits
    14 adds in trunk/LayoutTests

Unreviewed WPE gardening. Updating or adding various baselines. Also
adding new failure expectations for tests that need a closer look.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • platform/wpe/fast/block/basic/height-percentage-simple-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-image-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
  • platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • platform/wpe/fast/history: Added.
  • platform/wpe/fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Added.
  • platform/wpe/fast/inline-block/14498-positionForCoordinates-expected.txt:
  • platform/wpe/fast/inline/simple-inline-block-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-float1-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats2-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats3-expected.txt: Added.
  • platform/wpe/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/context/context-hidden-alpha-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/get-extension-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-image-data-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:
12:03 AM Changeset in webkit [237791] by Michael Catanzaro
  • 2 edits in trunk

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
​https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:

Nov 4, 2018:

10:50 PM Changeset in webkit [237790] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[webkitpy] Support WPE in the run-web-platform-tests script
​https://bugs.webkit.org/show_bug.cgi?id=191183

Reviewed by Alex Christensen.

  • Scripts/webkitpy/w3c/wpt_runner.py:

(parse_args): Support --wpe as an argument that specifies WPE as the
target port. Additionally, the --display-server flag now accepts
headless as a valid value, enabling the WPE WebDriver to run in
headless mode.

8:38 PM Changeset in webkit [237789] by Fujii Hironori
  • 6 edits in trunk

[Win] Use C++14, not C++17
​https://bugs.webkit.org/show_bug.cgi?id=191101

Reviewed by Alex Christensen.

.:

Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
<​https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>

  • Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.

Source/WTF:

  • wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version

instead of _MSC_FULL_VER.

Tools:

std::basic_string::data() returns a read-only const buffer in
C++14.

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.

8:29 PM Changeset in webkit [237788] by Fujii Hironori
  • 3 edits in trunk/Source/WebKit

[MediaStream] User should not be prompted again after denying getDisplayMedia request
​https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
  • UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.
6:15 PM Changeset in webkit [237787] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove ENABLE_OPENCL fully
​https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::applyAll): Deleted.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

1:19 PM Changeset in webkit [237786] by Wenson Hsieh
  • 6 edits in trunk/Tools

[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
​https://bugs.webkit.org/show_bug.cgi?id=191231

Reviewed by Simon Fraser.

Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
it can be shared between iOS-family and macOS platforms. See below for more details.

No change in behavior.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::overridePreference):

Add a method stub for DumpRenderTree.

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:
  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):

Unify these method implementations.

(WTR::UIScriptController::removeViewFromWindow):
(WTR::UIScriptController::addViewToWindow):

Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.

(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::findString):
(WTR::UIScriptController::contentsOfUserInterfaceItem const):

Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::overridePreference): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.

8:38 AM Changeset in webkit [237785] by Alan Bujtas
  • 17 edits in trunk/Source

[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
​https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

  1. Improve visuallyNonEmpty milestone confidence level.

Ignore whitespace and non visible text content.
Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
Check if the html/body is actually visible.

  1. Issue initial paint soon after the milestone fires.

Use a 0ms timer to flush the initial paint.
Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling)

  1. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint.
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.

  • platform/graphics/FontCascade.h:
  • rendering/RenderText.cpp: Check whether the text is actually visible at this point.

(WebCore::RenderText::RenderText):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):

  • WebProcess/WebPage/AcceleratedDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

8:04 AM Changeset in webkit [237784] by eric.carlson@apple.com
  • 5 edits in trunk

[MediaStream] User should not be prompted again after denying getDisplayMedia request
​https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

7:46 AM Changeset in webkit [237783] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][BFC] Add support for percentage height in quirks mode.
​https://bugs.webkit.org/show_bug.cgi?id=191232

Reviewed by Antti Koivisto.

Source/WebCore:

In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.

Test: fast/block/basic/quirk-mode-percent-height.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):

  • layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • fast/block/basic/quirk-mode-percent-height.html: Added.
  • platform/ios/TestExpectations:
7:44 AM Changeset in webkit [237782] by Alan Bujtas
  • 8 edits
    2 adds in trunk

[LFC][BCF] Add support for block level non-replaced inflow height percentage
​https://bugs.webkit.org/show_bug.cgi?id=191229

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/basic/child-block-level-box-with-height-percent.html

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • fast/block/basic/child-block-level-box-with-height-percent.html: Added.
  • platform/ios/TestExpectations:
7:30 AM Changeset in webkit [237781] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource should use DestructionThread::Main
​https://bugs.webkit.org/show_bug.cgi?id=191230

Reviewed by Eric Carlson.

Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
7:05 AM Changeset in webkit [237780] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore

[GTK] Cannot make debug builds of JSC using release 2.22.3
​https://bugs.webkit.org/show_bug.cgi?id=191233

Unreviewed build fix.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
Use context.asStructureForInContext() instead of explicit cast and
remove the unneeded assertion, which is already done in the helper
function.

2:28 AM Changeset in webkit [237779] by youenn@apple.com
  • 10 edits
    3 adds in trunk

IDB should allow storing RTCCertificate
​https://bugs.webkit.org/show_bug.cgi?id=191077

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added.
  • web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added.

Source/WebCore:

Add support for serialization/deserialization of RTCCertificate.
Store the origin in RTCCertificate and make sure that a certificate
with a different origin cannot be used to create a RTCPeerConnection.

Test: imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::generateCertificate):

  • Modules/mediastream/RTCCertificate.cpp:

(WebCore::RTCCertificate::create):
(WebCore::RTCCertificate::RTCCertificate):

  • Modules/mediastream/RTCCertificate.h:

(WebCore::RTCCertificate::origin const):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::certificatesFromConfiguration):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:

(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):

  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::CachedString::takeString):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

Nov 4, 2018:

12:55 AM Changeset in webkit [237778] by youenn@apple.com
  • 11 edits
    1 add in trunk

Add support for RTCMuxPolicy
​https://bugs.webkit.org/show_bug.cgi?id=191188

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt:
  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/WebCore:

Add support for RTCMuxPolicy dictionary option for both constructor and setConfiguration.
Make sure setConfiguration throws if trying to change this policy.
Pipe this parameter up to libwebrtc.
Covered by rebased test.

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::rtcpMuxPolicyfromConfiguration):
(WebCore::configurationFromMediaEndpointConfiguration):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mediastream/RTCPMuxPolicy.h: Added.
Note: See TracTimeline for information about the timeline view.