Timeline

Nov 12, 2018:

11:41 PM Changeset in webkit [238125] by commit-queue@webkit.org

• 9 edits in trunk

Implement Cache API support for WPE/GTK
​https://bugs.webkit.org/show_bug.cgi?id=178316

Patch by Darshan Kadu <​darsh7807@gmail.com> on 2018-11-12
Reviewed by Michael Catanzaro.

Source/WebKit:

Added a new API function WKWebsiteDataStoreSetCacheStoragePerOriginQuota which sets the
cache limit per origin.

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetCacheStoragePerOriginQuota):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

LayoutTests:

Removed the http/wpt/cache-storage/cache-quota.any.html from the TestExpectations which
were marked faliure.

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

11:35 PM Changeset in webkit [238124] by commit-queue@webkit.org

• 9 edits in trunk

Content-Type parameter values should allow empty quoted strings
​https://bugs.webkit.org/show_bug.cgi?id=191388

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-12
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Include improved expected test result and updated mime-type test:
​https://github.com/whatwg/mimesniff/pull/79

• web-platform-tests/mimesniff/mime-types/charset-parameter.window-expected.txt:
• web-platform-tests/mimesniff/mime-types/parsing.any-expected.txt:
• web-platform-tests/mimesniff/mime-types/parsing.any.worker-expected.txt:
• web-platform-tests/mimesniff/mime-types/resources/mime-types.json:
• web-platform-tests/xhr/overridemimetype-blob-expected.txt:

Source/WebCore:

According to RFC 2045 and ​https://mimesniff.spec.whatwg.org/#parsing-a-mime-type empty
quoted strings are acceptable for Content-Type parameter values. They
are accepted by Firefox and Chrome implementations as well.

Test: web-platform-tests/xhr/overridemimetype-blob.html

• platform/network/ParsedContentType.cpp:

(WebCore::parseToken):
(WebCore::parseQuotedString):
(WebCore::parseContentType):

• platform/network/ParsedContentType.h:

11:21 PM Changeset in webkit [238123] by chris.reid@sony.com

• 7 edits in trunk

[Curl] Reject entire cookie if the domain fails a tailmatch.
​https://bugs.webkit.org/show_bug.cgi?id=191406

Reviewed by Youenn Fablet.

Source/WebCore:

Currently we don't put domain attribute of cookie when it fails a tailmatch. As Firefox
and Chrome do, we are going to reject the entire cookie if the domain fails a tailmatch instead.
Also cleanup Cookie database implementation to make them testable better.

Tests: TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp

• platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::canAcceptCookie): Added.
(WebCore::CookieJarDB::setCookie):

• platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieAttributes):
(WebCore::CookieUtil::parseCookieHeader):

• platform/network/curl/CookieUtil.h:

Tools:

Added unittests for Curl cookie implementation.

• TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:

(TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):

11:07 PM Changeset in webkit [238122] by Devin Rousso

• 36 edits
  3 copies
  3 moves
  4 adds in trunk

Web Inspector: Network: show secure certificate details per-request
​https://bugs.webkit.org/show_bug.cgi?id=191447
<rdar://problem/30019476>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add Security domain to hold security related protocol types.

• CMakeLists.txt:
• DerivedSources.make:
• inspector/protocol/Network.json:
• inspector/protocol/Security.json: Added.
• inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator):

Source/WebCore:

Test: http/tests/inspector/network/resource-response-security.html

• loader/ResourceLoader.h:

(WebCore::ResourceLoader::shouldIncludeCertificateInfo const):

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldIncludeCertificateInfo const): Added.
Always save certificate information when WebInspector is open.

• platform/network/CertificateInfoBase.h: Added.

(WebCore::CertificateInfoBase::containsNonRootSHA1SignedCertificate const):
(WebCore::CertificateInfoBase::summaryInfo const):
(WebCore::CertificateInfoBase::isEmpty const):

• platform/network/cf/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.

• platform/network/cf/CertificateInfoCFNet.cpp: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):
(WebCore::CertificateInfo::summaryInfo const): Added.

• platform/network/curl/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.
(WebCore::CertificateInfo::isEmpty const): Added.

• platform/network/soup/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.
(WebCore::CertificateInfo::isEmpty const): Added.
Create base class for CertificateInfo so that InspectorNetworkAgent doesn't need to have
platform-specific code in its implementation.

• platform/network/cocoa/CertificateInfoCocoa.mm: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.
• platform/network/curl/CertificateInfoCFNet.cpp: Renamed from Source/WebCore/platform/network/curl/CertificateInfo.cpp.
• platform/network/soup/CertificateInfoSoup.cpp: Renamed from Source/WebCore/platform/network/soup/CertificateInfo.cpp.

• inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::certificateInfo const): Added.
(WebCore::NetworkResourcesData::ResourceData::setCertificateInfo): Added.

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):

• PlatformAppleWin.cmake:
• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/Curl.cmake:
• platform/SourcesSoup.txt:

Source/WebInspectorUI:

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.resourceRequestWasServedFromMemoryCache):
(WI.NetworkManager.prototype.resourceRequestDidReceiveResponse):

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.get responseSecurity): Added.
(WI.Resource.prototype.get loadedSecurely): Added.
(WI.Resource.prototype.updateForResponse):

• UserInterface/Views/NetworkResourceDetailView.js:

(WI.NetworkResourceDetailView):
(WI.NetworkResourceDetailView.prototype.initialLayout):
(WI.NetworkResourceDetailView.prototype.showContentViewForIdentifier):

• UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details .go-to-arrow): Added.
(.content-view.resource-details.showing-find-banner .search-highlight): Added.

• UserInterface/Views/ResourceSecurityContentView.js: Added.

(WI.ResourceSecurityContentView):
(WI.ResourceSecurityContentView.prototype.initialLayout):
(WI.ResourceSecurityContentView.prototype.layout):
(WI.ResourceSecurityContentView.prototype.closed):
(WI.ResourceSecurityContentView.prototype.get supportsSearch):
(WI.ResourceSecurityContentView.prototype.get numberOfSearchResults):
(WI.ResourceSecurityContentView.prototype.get hasPerformedSearch):
(WI.ResourceSecurityContentView.prototype.set automaticallyRevealFirstSearchResult):
(WI.ResourceSecurityContentView.prototype.performSearch):
(WI.ResourceSecurityContentView.prototype.searchCleared):
(WI.ResourceSecurityContentView.prototype.revealPreviousSearchResult):
(WI.ResourceSecurityContentView.prototype.revealNextSearchResult):
(WI.ResourceSecurityContentView.prototype._refreshCetificateSection):
(WI.ResourceSecurityContentView.prototype._perfomSearchOnKeyValuePairs):
(WI.ResourceSecurityContentView.prototype._revealSearchResult):
(WI.ResourceSecurityContentView.prototype._handleResourceResponseReceived):

• UserInterface/Views/ResourceSecurityContentView.css: Added.

(body[dir] .resource-security > section.certificate > .details):
(.resource-security .details .key):
(.resource-security .dns-name + .dns-name > .key,):
(.resource-security .show-more):
(@media (prefers-dark-interface) body[dir] .resource-security > section.certificate > .details):
(@media (prefers-dark-interface) .resource-security .details .key):

• UserInterface/Views/ResourceCookiesContentView.js:

(WI.ResourceCookiesContentView.prototype._refreshRequestCookiesSection):
(WI.ResourceCookiesContentView.prototype._refreshResponseCookiesSection):
(WI.ResourceCookiesContentView.prototype._markIncompleteSectionWithMessage): Deleted.
(WI.ResourceCookiesContentView.prototype._markIncompleteSectionWithLoadingIndicator): Deleted.

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
(WI.ResourceHeadersContentView.prototype._refreshRedirectHeadersSections):
(WI.ResourceHeadersContentView.prototype._refreshRequestHeadersSection):
(WI.ResourceHeadersContentView.prototype._refreshResponseHeadersSection):
(WI.ResourceHeadersContentView.prototype._refreshQueryStringSection):
(WI.ResourceHeadersContentView.prototype._refreshRequestDataSection):
(WI.ResourceHeadersContentView.prototype._markIncompleteSectionWithMessage): Deleted.
(WI.ResourceHeadersContentView.prototype._markIncompleteSectionWithLoadingIndicator): Deleted.
(WI.ResourceHeadersContentView.prototype._appendKeyValuePair): Deleted.

• UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers .h1-status > .key,):
(body[dir] .resource-headers > section.error > .details): Deleted.
(.resource-headers > section.error .key): Deleted.
(.resource-headers .details): Deleted.
(.resource-headers .details .pair): Deleted.
(body[dir=rtl] .resource-headers .details .pair): Deleted.
(.resource-headers .details .key): Deleted.
(.resource-headers .value): Deleted.
(.resource-headers .go-to-arrow): Deleted.
(.resource-headers.showing-find-banner .search-highlight): Deleted.

• UserInterface/Views/ResourceDetailsSection.js:

(WI.ResourceDetailsSection.prototype.markIncompleteSectionWithMessage): Added.
(WI.ResourceDetailsSection.prototype.markIncompleteSectionWithLoadingIndicator): Added.
(WI.ResourceDetailsSection.prototype.appendKeyValuePair): Added.

• UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section > .details): Added.
(.resource-details > section > .details > .pair): Added.
(body[dir=rtl] .resource-details > section > .details > .pair): Added.
(.resource-details > section > .details > .pair > .key): Added.
(.resource-details > section > .details > .pair > .value): Added.
(body[dir] .resource-details > section.error > .details): Added.
(.resource-details > section.error > .details > .pair > .key): Added.
Move commonly used functions/styles from container classes onto this object.

• UserInterface/Main.html:
• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• http/tests/inspector/network/resource-response-security-expected.txt: Added.
• http/tests/inspector/network/resource-response-security.html: Added.

• platform/gtk/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wpe/TestExpectations:

9:13 PM Changeset in webkit [238121] by Matt Baker

• 6 edits in trunk

Web Inspector: Table should support shift-extending the row selection
​https://bugs.webkit.org/show_bug.cgi?id=189718
<rdar://problem/44577942>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Allow the table selection to be extended by shift-clicking a row, or by
holding shift and pressing either the up or down arrow key. If both command
and shift are pressed, shift is ignored. The selection behavior is modeled
after AppKit's NSTableView.

• UserInterface/Base/IndexSet.js:

(WI.IndexSet.prototype.addRange):
(WI.IndexSet.prototype.deleteRange):
(WI.IndexSet.prototype.equals):
(WI.IndexSet.prototype.difference):

• UserInterface/Views/Table.js:

(WI.Table):
(WI.Table.prototype.set allowsMultipleSelection):
(WI.Table.prototype.reloadData):
(WI.Table.prototype.selectRow):
(WI.Table.prototype.deselectRow):
(WI.Table.prototype._handleKeyDown):
Holding shift and pressing either the up or down arrow key extends the
selection to the next unselected row adjacent to the anchor row, or causes
the anchor row to be deselected, decreasing the selection. The table chooses
the action to take based on the direction of movement (up or down), and
the currently selected rows.

(WI.Table.prototype._selectRowsFromArrowKey):
(WI.Table.prototype._handleMouseDown.normalizeRange):
(WI.Table.prototype._handleMouseDown):
Clicking a row while holding down shift extends the selection to include
the rows between the anchor row (exclusive) and clicked row (inclusive).
The anchor row is equal to the value of _selectedRowIndex prior to
clicking a new row.

(WI.Table.prototype._deselectAllAndSelect):
(WI.Table.prototype._removeRows):
(WI.Table.prototype._toggleSelectedRowStyle):
(WI.Table.prototype._updateSelectedRows):
Helper method for updating the selection to the specified rows, and updating
DOM styles for rows that are added to or removed from the selection.

LayoutTests:

• inspector/unit-tests/index-set-expected.txt:
• inspector/unit-tests/index-set.html:

Add tests for new IndexSet methods addRange, deleteRange, equals, and difference.

8:43 PM Changeset in webkit [238120] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: inline swatches don't work when Multiple Properties Selection is enabled
​https://bugs.webkit.org/show_bug.cgi?id=191165
<rdar://problem/45737972>

Reviewed by Devin Rousso.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

• UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
click is fired after mouseup and inline swatches are activated by click event.
Changing this to click allows swatches to activate before editing starts.

(WI.SpreadsheetTextField.prototype._handleMouseDown):
Clicking on the field that is being edited should't restart editing. It should move the text caret.

6:38 PM Changeset in webkit [238119] by Alan Bujtas

• 7 edits
  2 adds in trunk

Do not collapse the soon-to-be-parent anon block when we shuffle around the marker item renderer.
​https://bugs.webkit.org/show_bug.cgi?id=191554
<rdar://problem/45825265>

Reviewed by Antti Koivisto.

Source/WebCore:

While moving the marker item renderer to its correct subtree, we accidentally remove the soon-to-be parent anonymous block.
Moving a renderer is a 2 step process:

1. Detach the renderer from its current parent
2. Attach it to its new parent.

During step #1, we check if there is a chance to collapse anonymous blocks. In this case the soon-to-be-parent is a sibling anonymous block which, after detaching the marker sibling
is not needed anymore (except we use it as the new parent).

Test: fast/inline/marker-list-item-move-should-not-crash.html

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::detach):

• rendering/updating/RenderTreeBuilder.h:
• rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::detach):

• rendering/updating/RenderTreeBuilderBlock.h:
• rendering/updating/RenderTreeBuilderList.cpp:

(WebCore::RenderTreeBuilder::List::updateItemMarker):

LayoutTests:

• fast/inline/marker-list-item-move-should-not-crash-expected.txt: Added.
• fast/inline/marker-list-item-move-should-not-crash.html: Added.

6:32 PM Changeset in webkit [238118] by ap@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Fix another ChangeLog typo for testing. Thanks for making so many!

6:25 PM Changeset in webkit [238117] by Kocsen Chung

• 1 copy in tags/Safari-606.3.4.1.3

Tag Safari-606.3.4.1.3.

6:12 PM Changeset in webkit [238116] by ap@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Fix a random typo in ChangeLog to test post-commit hook.

5:08 PM Changeset in webkit [238115] by achristensen@apple.com

• 14 edits in trunk

[iOS] Implement safe browsing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=191441

Reviewed by Tim Horton.

Source/WebKit:

In r237863 I implemented this for Mac. This refines the UI and implements it for iOS.

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextHandlesSafeBrowsing):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _clearSafeBrowsingWarning]):
(-[WKWebView layoutSubviews]):
(-[WKWebView setFrameSize:]):
(+[WKWebView _handlesSafeBrowsing]):
(-[WKWebView _safeBrowsingWarningForTesting]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/Cocoa/PageClientImplCocoa.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::allocFileWrapperInstance const):
(WebKit::PageClientImplCocoa::serializableFileWrapperClasses const):

• UIProcess/Cocoa/WKSafeBrowsingWarning.h:
• UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(confirmMalwareSentinel):
(visitUnsafeWebsiteSentinel):
(colorForItem):
(addLinkAndReplace):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(makeButton):
(makeTitleLabel):
(setBackground):
(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingResult:completionHandler:]):
(-[WKSafeBrowsingWarning addContent]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(-[WKSafeBrowsingWarning layoutText]):
(-[WKSafeBrowsingWarning textView:clickedOnLink:atIndex:]):
(-[WKSafeBrowsingWarning layout]):
(-[WKSafeBrowsingWarning layoutSubviews]):
(-[WKSafeBrowsingWarning textView:shouldInteractWithURL:inRange:interaction:]):
(-[WKSafeBrowsingWarning didMoveToWindow]):
(-[WKSafeBrowsingWarning clickedOnLink:]):
(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
(-[WKSafeBrowsingTextView intrinsicContentSize]):
(colorNamed): Deleted.
(+[WKSafeBrowsingTextView viewWithAttributedString:linkTarget:]): Deleted.
(+[WKSafeBrowsingTextView viewWithString:]): Deleted.
(-[WKSafeBrowsingTextView clickedOnLink:atIndex:]): Deleted.

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):
(WebKit::PageClientImpl::requestPasswordForQuickLookDocument):

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::showShareSheet):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(checkTitleAndClick):
(TEST):

4:31 PM Changeset in webkit [238114] by jfernandez@igalia.com

• 7 edits in trunk/Source/WebCore

[css-grid] Refactoring to make more explicit the orthogonal items' pre-layout logic
​https://bugs.webkit.org/show_bug.cgi?id=191358

Reviewed by Manuel Rego Casasnovas.

These changes are just a refactoring to ease the integration of the new Baseline Alignment
logic in a follow up patch.

We need to properly estimate the grid area size of orthogonal items so that we can perform
an accurate pre-layout. This is important because orthogonal items will synthesize their baseline
if they participate in any baseline alignment context.

No new tests, since no behavior change has been introduced in this patch.

• rendering/Grid.cpp:

(WebCore::Grid::setNeedsItemsPlacement):

• rendering/Grid.h:
• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::isRelativeGridLengthAsAuto const):
(WebCore::GridTrackSizingAlgorithm::isRelativeSizedTrackAsAuto const):
(WebCore::GridTrackSizingAlgorithm::gridTrackSize const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::run):
(WebCore::GridTrackSizingAlgorithm::reset):

• rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrackSizingAlgorithmStrategy::gridTrackSize const):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::overrideSizeChanged):
(WebCore::hasRelativeBlockAxisSize):
(WebCore::RenderGrid::updateGridAreaLogicalSize const):
(WebCore::RenderGrid::layoutGridItems):

• rendering/RenderGrid.h:

3:42 PM Changeset in webkit [238113] by rniwa@webkit.org

• 2 edits in trunk

Add HTTPS git remote to ReadMe.md
​https://bugs.webkit.org/show_bug.cgi?id=191561

Reviewed by Zalan Bujtas.

• ReadMe.md:

3:34 PM Changeset in webkit [238112] by sihui_liu@apple.com

• 6 edits in trunk

imported/w3c/web-platform-tests/IndexedDB/keygenerator-explicit.html crashing on iOS device
​https://bugs.webkit.org/show_bug.cgi?id=191500

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/IndexedDB/keygenerator-explicit-expected.txt:

Source/WebCore:

When double value is bigger than maximum unsigned int, converting double to unsigned int has
different behaviors on macOS and iOS. On macOS, the result would be 0 while on iOS it would be
maximum unsigned int.

Covered by existing test.

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):

LayoutTests:

The test should not crash now.

• platform/ios-device/TestExpectations:

3:18 PM Changeset in webkit [238111] by basuke.suzuki@sony.com

• 10 edits
  2 adds in trunk

[Curl] Add API Test for Curl cookie backend.
​https://bugs.webkit.org/show_bug.cgi?id=191493

Reviewed by Youenn Fablet.

Source/WebCore:

Refactoring for cookie backend interface.

Tests: TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp

• platform/FileSystem.h:
• platform/network/curl/CookieJarCurlDatabase.cpp:

(WebCore::cookiesForSession):
(WebCore::CookieJarCurlDatabase::setCookiesFromDOM const):
(WebCore::CookieJarCurlDatabase::setCookiesFromHTTPResponse const):
(WebCore::CookieJarCurlDatabase::getRawCookies const):

• platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::openDatabase):
(WebCore::CookieJarDB::checkSQLiteReturnCode):
(WebCore::CookieJarDB::isEnabled const):
(WebCore::CookieJarDB::searchCookies):
(WebCore::CookieJarDB::setCookie):
(WebCore::CookieJarDB::deleteCookie):
(WebCore::CookieJarDB::deleteCookieInternal):
(WebCore::CookieJarDB::deleteCookies):
(WebCore::CookieJarDB::deleteAllCookies):
(WebCore::CookieJarDB::executeSimpleSql):
(WebCore::CookieJarDB::isEnabled): Deleted.

• platform/network/curl/CookieJarDB.h:
• platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieHeader):

• platform/network/curl/CookieUtil.h:
• platform/win/FileSystemWin.cpp:

(WebCore::FileSystem::generateTemporaryPath):
(WebCore::FileSystem::openTemporaryFile):
(WebCore::FileSystem::createTemporaryDirectory):
(WebCore::FileSystem::deleteNonEmptyDirectory):

Tools:

Add unit test to TestWebCore.

• TestWebKitAPI/PlatformWin.cmake:
• TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.

2:44 PM Changeset in webkit [238110] by bshafiei@apple.com

• 7 edits in branches/safari-606-branch/Source

Versioning.

2:10 PM Changeset in webkit [238109] by sbarati@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Unreviewed. Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=191555

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

• bytecode/UnlinkedFunctionExecutable.h:
• parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):

• runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

• runtime/CodeCache.h:
• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::fromGlobalCode):

• runtime/FunctionExecutable.h:

2:04 PM Changeset in webkit [238108] by timothy_horton@apple.com

• 50 edits
  11 adds in trunk

Make it possible to edit images inline
​https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html

editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

• page/Settings.yaml:

Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

• html/HTMLImageElement.h:

Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

• rendering/RenderImage.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):

• rendering/RenderLayerCompositor.h:

Make editable images require compositing implicitly.

Source/WebKit:

• Platform/spi/ios/PencilKitSPI.h: Added.
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

• Shared/WebPreferences.yaml:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a preference to enable editable images.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.

(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

• UIProcess/ios/WKDrawingView.h: Added.
• UIProcess/ios/WKDrawingView.mm: Added.

(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

• WebKit.xcodeproj/project.pbxproj:
• SourcesCocoa.txt:

Add the new files.

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

• DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

• TestRunnerShared/UIScriptContext/UIScriptController.h:
• TestRunnerShared/spi/PencilKitTestSPI.h: Added.
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

• TestExpectations:
• editing/images/basic-editable-image-expected.txt: Added.
• editing/images/basic-editable-image.html: Added.
• editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
• editing/images/reparent-editable-image-maintains-strokes.html: Added.
• platform/ios-wk2/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

1:42 PM Changeset in webkit [238107] by Ryan Haddad

• 2 edits in trunk/Tools

[MediaStream] Screen capture should be an experimental feature on OSX only
​https://bugs.webkit.org/show_bug.cgi?id=191552

Unreviewed test gardening.

• TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.

1:41 PM Changeset in webkit [238106] by don.olmstead@sony.com

• 199 edits in trunk

Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
​https://bugs.webkit.org/show_bug.cgi?id=189230
<rdar://problem/44050379>

Reviewed by Joseph Pecoraro.

Runs all png images through zopflipng. This results in a smaller file
size and takes care of this issue as a byproduct.

Source/WebCore:

• Modules/modern-media-controls/images/iOS/​airplay-placard@1x.png:
• Modules/modern-media-controls/images/iOS/​airplay-placard@2x.png:
• Modules/modern-media-controls/images/iOS/​airplay-placard@3x.png:
• Modules/modern-media-controls/images/iOS/​invalid-placard@1x.png:
• Modules/modern-media-controls/images/iOS/​invalid-placard@2x.png:
• Modules/modern-media-controls/images/iOS/​invalid-placard@3x.png:
• Modules/modern-media-controls/images/iOS/​pip-placard@1x.png:
• Modules/modern-media-controls/images/iOS/​pip-placard@2x.png:
• Modules/modern-media-controls/images/iOS/​pip-placard@3x.png:
• Modules/modern-media-controls/images/macOS/​airplay-placard@1x.png:
• Modules/modern-media-controls/images/macOS/​airplay-placard@2x.png:
• Modules/modern-media-controls/images/macOS/​invalid-placard@1x.png:
• Modules/modern-media-controls/images/macOS/​invalid-placard@2x.png:
• Modules/modern-media-controls/images/macOS/​pip-placard@1x.png:
• Modules/modern-media-controls/images/macOS/​pip-placard@2x.png:
• Resources/AttachmentPlaceholder.png:
• Resources/AttachmentPlaceholder@2x.png:
• Resources/ListButtonArrow.png:
• Resources/ListButtonArrow@2x.png:
• Resources/missingImage.png:
• Resources/​missingImage@2x.png:
• Resources/​missingImage@3x.png:
• Resources/moveCursor.png:
• Resources/northEastSouthWestResizeCursor.png:
• Resources/northSouthResizeCursor.png:
• Resources/northWestSouthEastResizeCursor.png:
• Resources/nullPlugin.png:
• Resources/​nullPlugin@2x.png:
• Resources/panIcon.png:
• Resources/textAreaResizeCorner.png:
• Resources/​textAreaResizeCorner@2x.png:
• Resources/urlIcon.png:

Source/WebInspectorUI:

• UserInterface/Images/ApplicationCache.png:
• UserInterface/Images/ApplicationCache@2x.png:
• UserInterface/Images/ApplicationCacheManifest.png:
• UserInterface/Images/ApplicationCacheManifest@2x.png:
• UserInterface/Images/Breakpoint.png:
• UserInterface/Images/Breakpoint@2x.png:
• UserInterface/Images/BreakpointInactive.png:
• UserInterface/Images/BreakpointInactive@2x.png:
• UserInterface/Images/ClippingCSS.png:
• UserInterface/Images/​ClippingCSS@2x.png:
• UserInterface/Images/ClippingCSSLarge.png:
• UserInterface/Images/​ClippingCSSLarge@2x.png:
• UserInterface/Images/ClippingGeneric.png:
• UserInterface/Images/ClippingGeneric@2x.png:
• UserInterface/Images/ClippingGenericLarge.png:
• UserInterface/Images/ClippingGenericLarge@2x.png:
• UserInterface/Images/ClippingJS.png:
• UserInterface/Images/​ClippingJS@2x.png:
• UserInterface/Images/ClippingJSLarge.png:
• UserInterface/Images/​ClippingJSLarge@2x.png:
• UserInterface/Images/ColorIcon.png:
• UserInterface/Images/ColorIcon@2x.png:
• UserInterface/Images/Cookie.png:
• UserInterface/Images/Cookie@2x.png:
• UserInterface/Images/Database.png:
• UserInterface/Images/Database@2x.png:
• UserInterface/Images/DatabaseTable.png:
• UserInterface/Images/DatabaseTable@2x.png:
• UserInterface/Images/DocumentCSS.png:
• UserInterface/Images/​DocumentCSS@2x.png:
• UserInterface/Images/DocumentCSSLarge.png:
• UserInterface/Images/​DocumentCSSLarge@2x.png:
• UserInterface/Images/DocumentFont.png:
• UserInterface/Images/DocumentFont@2x.png:
• UserInterface/Images/DocumentFontLarge.png:
• UserInterface/Images/DocumentFontLarge@2x.png:
• UserInterface/Images/DocumentGL.png:
• UserInterface/Images/​DocumentGL@2x.png:
• UserInterface/Images/DocumentGeneric.png:
• UserInterface/Images/DocumentGeneric@2x.png:
• UserInterface/Images/DocumentGenericLarge.png:
• UserInterface/Images/DocumentGenericLarge@2x.png:
• UserInterface/Images/DocumentImage.png:
• UserInterface/Images/DocumentImage@2x.png:
• UserInterface/Images/DocumentImageLarge.png:
• UserInterface/Images/DocumentImageLarge@2x.png:
• UserInterface/Images/DocumentJS.png:
• UserInterface/Images/​DocumentJS@2x.png:
• UserInterface/Images/DocumentJSLarge.png:
• UserInterface/Images/​DocumentJSLarge@2x.png:
• UserInterface/Images/DocumentMarkup.png:
• UserInterface/Images/DocumentMarkup@2x.png:
• UserInterface/Images/DocumentMarkupLarge.png:
• UserInterface/Images/DocumentMarkupLarge@2x.png:
• UserInterface/Images/FolderGeneric.png:
• UserInterface/Images/FolderGeneric@2x.png:
• UserInterface/Images/GradientStop.png:
• UserInterface/Images/GradientStop@2x.png:
• UserInterface/Images/GradientStopSelected.png:
• UserInterface/Images/GradientStopSelected@2x.png:
• UserInterface/Images/HoverMenuButton.png:
• UserInterface/Images/HoverMenuButton@2x.png:
• UserInterface/Images/InstructionPointer.png:
• UserInterface/Images/InstructionPointer@2x.png:
• UserInterface/Images/LocalStorage.png:
• UserInterface/Images/LocalStorage@2x.png:
• UserInterface/Images/SessionStorage.png:
• UserInterface/Images/SessionStorage@2x.png:
• UserInterface/Images/SliderThumb.png:
• UserInterface/Images/SliderThumb@2x.png:
• UserInterface/Images/SliderThumbPressed.png:
• UserInterface/Images/SliderThumbPressed@2x.png:
• UserInterface/Images/WebSocket.png:
• UserInterface/Images/WebSocket@2x.png:
• UserInterface/Images/WebSocketLarge.png:
• UserInterface/Images/WebSocketLarge@2x.png:
• UserInterface/Images/WorkerScript.png:
• UserInterface/Images/WorkerScript@2x.png:
• UserInterface/Images/WorkerScriptLarge.png:
• UserInterface/Images/WorkerScriptLarge@2x.png:

Source/WebKit:

• Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/​StartPictureInPictureButton@1x.png:
• Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/​StartPictureInPictureButton@2x.png:
• Resources/ios/iOS.xcassets/StartPictureInPictureButton.imageset/​StartPictureInPictureButton@3x.png:
• Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/​StopPictureInPictureButton@1x.png:
• Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/​StopPictureInPictureButton@2x.png:
• Resources/ios/iOS.xcassets/StopPictureInPictureButton.imageset/​StopPictureInPictureButton@3x.png:

Source/WebKitLegacy/win:

• WebKit.resources/deleteButton.png:
• WebKit.resources/deleteButtonPressed.png:
• WebKit.resources/fsVideoAudioVolumeHigh.png:
• WebKit.resources/fsVideoAudioVolumeLow.png:
• WebKit.resources/fsVideoExitFullscreen.png:
• WebKit.resources/fsVideoPause.png:
• WebKit.resources/fsVideoPlay.png:
• WebKit.resources/missingImage.png:
• WebKit.resources/nullplugin.png:
• WebKit.resources/panEastCursor.png:
• WebKit.resources/panIcon.png:
• WebKit.resources/panNorthCursor.png:
• WebKit.resources/panNorthEastCursor.png:
• WebKit.resources/panNorthWestCursor.png:
• WebKit.resources/panSouthCursor.png:
• WebKit.resources/panSouthEastCursor.png:
• WebKit.resources/panSouthWestCursor.png:
• WebKit.resources/panWestCursor.png:
• WebKit.resources/searchCancel.png:
• WebKit.resources/searchCancelPressed.png:
• WebKit.resources/searchMagnifier.png:
• WebKit.resources/searchMagnifierResults.png:
• WebKit.resources/textAreaResizeCorner.png:
• WebKit.resources/verticalTextCursor.png:
• WebKit.resources/zoomInCursor.png:
• WebKit.resources/zoomOutCursor.png:

Tools:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​ElCapitan@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​GTK@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​HighSierra@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS10@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS10Simulator@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS11@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS11Simulator@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS12@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS12Simulator@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS9@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS9Simulator@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOSDevice@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOSSimulator@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Mavericks@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Mojave@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​MountainLion@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​PlatformRing@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Sierra@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​WPE@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows10@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows7@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows8@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​WindowsXP@2x.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Yosemite@2x.png:

1:25 PM Changeset in webkit [238105] by jfernandez@igalia.com

• 9 edits
  143 adds in trunk/LayoutTests

[css-grid] Import additional grid layout tests and update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=191515

Reviewed by Dean Jackson.

Imported several tests from Blink and update TextExpectaions.

• TestExpectations: Adding specific bugs for the expected failures.
• fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash-expected.txt: Added.
• fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash.html: Added.
• fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html: Added.
• fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html: Added.
• fast/css-grid-layout/crash-large-positions-expected.txt: Added.
• fast/css-grid-layout/crash-large-positions.html: Added.
• fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid-expected.txt: Added.
• fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html: Added.
• fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt: Added.
• fast/css-grid-layout/floating-not-effect-on-grid-items.html: Added.
• fast/css-grid-layout/grid-align-baseline-expected.txt: Added.
• fast/css-grid-layout/grid-align-baseline-vertical-expected.txt: Added.
• fast/css-grid-layout/grid-align-baseline-vertical.html: Added.
• fast/css-grid-layout/grid-align-baseline.html: Added.
• fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash-expected.txt: Added.
• fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash.html: Added.
• fast/css-grid-layout/grid-auto-repeat-positioned-container-expected.html: Added.
• fast/css-grid-layout/grid-auto-repeat-positioned-container.html: Added.
• fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.txt: Added.
• fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html: Added.
• fast/css-grid-layout/grid-container-percentage-columns-expected.txt:
• fast/css-grid-layout/grid-container-percentage-columns.html:
• fast/css-grid-layout/grid-container-percentage-rows-expected.txt: Added.
• fast/css-grid-layout/grid-container-percentage-rows.html: Added.
• fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin-expected.html: Added.
• fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin.html: Added.
• fast/css-grid-layout/grid-container-scroll-accounts-for-sizing-expected.html:
• fast/css-grid-layout/grid-container-scroll-accounts-for-sizing.html:
• fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width-expected.txt: Added.
• fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html: Added.
• fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content-expected.txt: Added.
• fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content.html: Added.
• fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt: Added.
• fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html: Added.
• fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt:
• fast/css-grid-layout/grid-crash-remove-positioned-item.html:
• fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Added.
• fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Added.
• fast/css-grid-layout/grid-item-border-overflow-paint-expected.html: Added.
• fast/css-grid-layout/grid-item-border-overflow-paint.html: Added.
• fast/css-grid-layout/grid-item-change-alignment-from-stretch-expected.txt: Added.
• fast/css-grid-layout/grid-item-change-alignment-from-stretch.html: Added.
• fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html: Added.
• fast/css-grid-layout/grid-item-grid-container-percentage-rows.html: Added.
• fast/css-grid-layout/grid-item-overflow-expected.html: Added.
• fast/css-grid-layout/grid-item-overflow-paint-expected.html: Added.
• fast/css-grid-layout/grid-item-overflow-paint.html: Added.
• fast/css-grid-layout/grid-item-overflow.html: Added.
• fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Added.
• fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Added.
• fast/css-grid-layout/grid-item-scroll-position-expected.txt: Added.
• fast/css-grid-layout/grid-item-scroll-position.html: Added.
• fast/css-grid-layout/grid-margins-not-collapse-expected.html: Added.
• fast/css-grid-layout/grid-margins-not-collapse.html: Added.
• fast/css-grid-layout/grid-painting-item-overflow-expected.html: Added.
• fast/css-grid-layout/grid-painting-item-overflow.html: Added.
• fast/css-grid-layout/grid-painting-items-only-once-expected.html: Added.
• fast/css-grid-layout/grid-painting-items-only-once.html: Added.
• fast/css-grid-layout/grid-painting-respect-dom-order-expected.html: Added.
• fast/css-grid-layout/grid-painting-respect-dom-order.html: Added.
• fast/css-grid-layout/grid-painting-rtl-expected.html: Added.
• fast/css-grid-layout/grid-painting-rtl.html: Added.
• fast/css-grid-layout/grid-self-baseline-01-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-01.html: Added.
• fast/css-grid-layout/grid-self-baseline-02-b-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-02-b.html: Added.
• fast/css-grid-layout/grid-self-baseline-02-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-02.html: Added.
• fast/css-grid-layout/grid-self-baseline-03-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-03.html: Added.
• fast/css-grid-layout/grid-self-baseline-04-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-04.html: Added.
• fast/css-grid-layout/grid-self-baseline-05-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-05.html: Added.
• fast/css-grid-layout/grid-self-baseline-06-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-06.html: Added.
• fast/css-grid-layout/grid-self-baseline-07-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-07.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-01-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-01.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-02-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-02.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-03-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-03.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-04-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-04.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-05-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-05.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-06.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-horiz-07.html: Added.
• fast/css-grid-layout/grid-self-baseline-two-dimensional-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-two-dimensional.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-01-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-02-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-03-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-04-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-05-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-06-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-07-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-01-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-02-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-03-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-04-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-05-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-06-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-07-expected.html: Added.
• fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html: Added.
• fast/css-grid-layout/grid-shorthands-style-format-expected.txt: Added.
• fast/css-grid-layout/grid-shorthands-style-format.html: Added.
• fast/css-grid-layout/grid-strict-ordering-crash-2-expected.txt: Added.
• fast/css-grid-layout/grid-strict-ordering-crash-2.html: Added.
• fast/css-grid-layout/named-grid-areas-dynamic-with-media-query-expected.html: Added.
• fast/css-grid-layout/named-grid-areas-dynamic-with-media-query.html: Added.
• fast/css-grid-layout/negative-growth-share-as-infinity-crash-expected.txt: Added.
• fast/css-grid-layout/negative-growth-share-as-infinity-crash.html: Added.
• fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area-expected.html: Added.
• fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area.html: Added.
• fast/css-grid-layout/positioned-grid-container-item-percentage-size-expected.html: Added.
• fast/css-grid-layout/positioned-grid-container-item-percentage-size.html: Added.
• fast/css-grid-layout/positioned-grid-container-percentage-tracks-expected.txt: Added.
• fast/css-grid-layout/positioned-grid-container-percentage-tracks.html: Added.
• fast/css-grid-layout/preferred-width-computed-after-layout-expected.txt: Added.
• fast/css-grid-layout/preferred-width-computed-after-layout.html: Added.
• fast/css-grid-layout/quirks-mode-percent-resolution-grid-item-expected.txt: Added.
• fast/css-grid-layout/quirks-mode-percent-resolution-grid-item.html: Added.
• fast/css-grid-layout/resources/blue-100x50.png: Added.
• fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridPositionDefinitionsValues):

• fast/css-grid-layout/scrolled-grid-painting-expected.html: Added.
• fast/css-grid-layout/scrolled-grid-painting-overflow-expected.html: Added.
• fast/css-grid-layout/scrolled-grid-painting-overflow.html: Added.
• fast/css-grid-layout/scrolled-grid-painting.html: Added.
• fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash-expected.txt: Added.
• fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash.html: Added.
• fast/css-grid-layout/stale-grid-layout-2-expected.txt: Added.
• fast/css-grid-layout/stale-grid-layout-expected.txt: Added.
• fast/css-grid-layout/vertical-align-do-not-effect-grid-items-expected.html: Added.
• fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html: Added.

1:19 PM Changeset in webkit [238104] by timothy_horton@apple.com

• 13 edits in trunk/Tools

Modernize WebKit Tools Xcode projects for localization's sake
​https://bugs.webkit.org/show_bug.cgi?id=191495

Reviewed by Alexey Proskuryakov.

• ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
• FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
• ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
• MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
• MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
• WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:

These are less important because they're not localized, but since
I made the style checker complain, it now complains any time anyone
touches any of these projects... so upgrade them.

11:59 AM Changeset in webkit [238103] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Check for specific process instead of using data migrator
​https://bugs.webkit.org/show_bug.cgi?id=191551
<rdar://problem/45993156>

Rubber-stamped by Aakash Jain.

It's possible for the data migrator process to be stuck, but for a simulator to be
usable. Use device-specific processes to detect when a device is usable.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._wait_until_device_is_usable):
(SimulatedDeviceManager):
(SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
since this implies that a device is booted.
(SimulatedDeviceManager.swap): Ditto.
(SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
process indicating the device is usable can be found.
(SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.

• Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that

it triggers the logic in is_usable()

11:49 AM Changeset in webkit [238102] by youenn@apple.com

• 12 edits in trunk

RealtimeOutgoing A/V sources should observe their sources only if having a sink
​https://bugs.webkit.org/show_bug.cgi?id=191490

Reviewed by Eric Carlson.

Source/WebCore:

Observe the source that generates media based on the sinks:

• Do not observe at creation time
• For first sink, start observing
• When no more sink, stop observing

Apply this principle for both outgoing audio and video sources.
Add locks for the sinks to ensure thread-safety.
Make sinks HashSet which is more robust.

Do some refactoring to better isolate generic outgoing sources from Cocoa/GTK implementations.

Covered by existing tests and updated webrtc/remove-track.html.

• platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::~RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::stop):
(WebCore::RealtimeOutgoingAudioSource::AddSink):
(WebCore::RealtimeOutgoingAudioSource::RemoveSink):
(WebCore::RealtimeOutgoingAudioSource::sendAudioFrames):

• platform/mediastream/RealtimeOutgoingAudioSource.h:
• platform/mediastream/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::~RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::observeSource):
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::stop):
(WebCore::RealtimeOutgoingVideoSource::AddOrUpdateSink):
(WebCore::RealtimeOutgoingVideoSource::RemoveSink):

• platform/mediastream/RealtimeOutgoingVideoSource.h:

(WebCore::RealtimeOutgoingVideoSource::isSilenced const):

• platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):

• platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceCocoa::pullAudioData):

• platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
• platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

(WebCore::RealtimeOutgoingVideoSourceCocoa::sampleBufferUpdated):

LayoutTests:

• webrtc/remove-track-expected.txt:
• webrtc/remove-track.html:

Add tests and fixed some flakiness issues on existing tests in the file.

11:23 AM Changeset in webkit [238101] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit

[MediaStream] Screen capture should be an experimental feature on OSX only
​https://bugs.webkit.org/show_bug.cgi?id=191552
<rdar://problem/45994142>

Reviewed by Youenn Fablet.

• Shared/WebPreferences.yaml: Make ScreenCaptureEnabled.condition ENABLE(MEDIA_STREAM) && PLATFORM(MAC).

11:12 AM Changeset in webkit [238100] by youenn@apple.com

• 9 edits in trunk

Support setting stream ids when adding a transceiver
​https://bugs.webkit.org/show_bug.cgi?id=191307

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Add support for streams in RTCTransceiverInit.
Add plumbing down to libwebrtc.
Covered by rebased tests.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::fromRtpTransceiverInit):

LayoutTests:

• TestExpectations:

11:07 AM Changeset in webkit [238099] by Alan Coon

• 6 edits in tags/Safari-607.1.13.2/Source

Cherry-pick r238031. rdar://problem/45848446

LLInt VectorSizeOffset should be based on offset extraction
​https://bugs.webkit.org/show_bug.cgi?id=191468

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This patch also adds some usings to LLIntOffsetsExtractor that
make it possible to use the bare names of Vector/RefCountedArray
in offsets extraction.

• llint/LLIntOffsetsExtractor.cpp:
• llint/LowLevelInterpreter.asm:

Source/WTF:

Make things friends with LLIntOffsetsExtractor.

• wtf/RefCountedArray.h:
• wtf/Vector.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:58 AM Changeset in webkit [238098] by commit-queue@webkit.org

• 20 edits
  5 copies
  10 adds in trunk

Resurrect WebKitTestRunner for Windows port
​https://bugs.webkit.org/show_bug.cgi?id=189257

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2018-11-12
Reviewed by Fujii Hironori.

.:

• Source/cmake/OptionsWin.cmake:

Source/WebKit:

• PlatformWin.cmake:

Tools:

Implement WebKitTestRunner for WinCairo.

• PlatformWin.cmake:
• Scripts/build-webkittestrunner:
• WebKitTestRunner/CMakeLists.txt:
• WebKitTestRunner/EventSenderProxy.h:
• WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::rangeToStr):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.

(WTR::AccessibilityController::resetToConsistentState):
(WTR::AccessibilityController::accessibleElementById):
(WTR::AccessibilityController::platformName):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):

• WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex const):
(WTR::AccessibilityUIElement::selectedChildrenCount const):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::uiElementAttributeValue const):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::computedRoleString):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation const):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue const):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isPressActionSupported):
(WTR::AccessibilityUIElement::isIncrementActionSupported):
(WTR::AccessibilityUIElement::isDecrementActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired const):
(WTR::AccessibilityUIElement::isFocused const):
(WTR::AccessibilityUIElement::isSelected const):
(WTR::AccessibilityUIElement::isSelectedOptionActive const):
(WTR::AccessibilityUIElement::isExpanded const):
(WTR::AccessibilityUIElement::isChecked const):
(WTR::AccessibilityUIElement::isIndeterminate const):
(WTR::AccessibilityUIElement::hierarchicalLevel const):
(WTR::AccessibilityUIElement::speakAs):
(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::ariaDropEffects const):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild const):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
(WTR::AccessibilityUIElement::removeSelectionAtIndex const):
(WTR::AccessibilityUIElement::clearSelectedChildren const):
(WTR::AccessibilityUIElement::accessibilityValue const):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable const):
(WTR::AccessibilityUIElement::isSelectable const):
(WTR::AccessibilityUIElement::isMultiSelectable const):
(WTR::AccessibilityUIElement::isVisible const):
(WTR::AccessibilityUIElement::isOffScreen const):
(WTR::AccessibilityUIElement::isCollapsed const):
(WTR::AccessibilityUIElement::isIgnored const):
(WTR::AccessibilityUIElement::isSingleLine const):
(WTR::AccessibilityUIElement::isMultiLine const):
(WTR::AccessibilityUIElement::hasPopup const):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::supportedActions const):
(WTR::AccessibilityUIElement::pathDescription const):
(WTR::AccessibilityUIElement::mathPostscriptsDescription const):
(WTR::AccessibilityUIElement::mathPrescriptsDescription const):
(WTR::AccessibilityUIElement::classList const):
(WTR::AccessibilityUIElement::characterAtOffset):
(WTR::AccessibilityUIElement::wordAtOffset):
(WTR::AccessibilityUIElement::lineAtOffset):
(WTR::AccessibilityUIElement::sentenceAtOffset):

• WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::activateFonts):
(WTR::installFakeHelvetica):
(WTR::uninstallFakeHelvetica):

• WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::InjectedBundle::platformInitialize):

• WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
• WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
• WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::inspectorTestStubURL):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::installFakeHelvetica):

• WebKitTestRunner/PlatformWebView.h:
• WebKitTestRunner/PlatformWin.cmake: Added.
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::createTestURL):

• WebKitTestRunner/TestInvocation.cpp:
• WebKitTestRunner/WebKitTestRunnerPrefix.h:
• WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):

• WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.

(WTR::registerWindowClass):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::didInitializeClients):
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::makeWebViewFirstResponder):
(WTR::generateCairoSurfaceFromBitmap):
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::changeWindowScaleIfNeeded):
(WTR::PlatformWebView::setNavigationGesturesEnabled):
(WTR::PlatformWebView::forceWindowFramesChanged):
(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

• WebKitTestRunner/win/TestControllerWin.cpp: Added.

(WTR::exceptionFilter):
(WTR::runRunLoopUntil):
(WTR::TestController::notifyDone):
(WTR::TestController::setHidden):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformPreferences):
(WTR::TestController::platformDestroy):
(WTR::toWK):
(WTR::TestController::platformInitializeContext):
(WTR::TestController::platformRunUntil):
(WTR::TestController::platformDidCommitLoadForFrame):
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
(WTR::TestController::runModal):
(WTR::TestController::platformContext):
(WTR::TestController::platformLibraryPathForTesting):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::platformResetPreferencesToConsistentValues):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest const):

• WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
• WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(dllLauncherEntryPoint):

10:55 AM Changeset in webkit [238097] by Antti Koivisto

• 9 edits
  2 adds in trunk

Support dynamic pseudo-classes on elements with display: contents
​https://bugs.webkit.org/show_bug.cgi?id=181640
<rdar://problem/36605415>

Reviewed by Dean Jackson.

Source/WebCore:

The code for :hover and :active style invalidation assumes that only elements with renderer need invalidation.

This patch fixes '.display-content-element:hover span' case but not '.display-content-element:hover' case but
includes tests for both. The latter is not super useful anyway (as it only affects rendering with inherited
text properties).

Test: fast/css/display-contents-hover-active.html

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

Traverse up in composed tree instead of render tree when invalidating. This has the same order as render tree
but also includes display:content elements. This also allows removing the special display:none case.

• dom/Element.cpp:

(WebCore::Element::setActive):
(WebCore::Element::setHovered):

Also look into display:contents style for invalidation checks.

(WebCore::Element::renderOrDisplayContentsStyle const):

Make this helper an Element member.

• dom/Element.h:
• dom/Node.cpp:

(WebCore::Node::parentElementInComposedTree const):

Support starting from a PseudoElement. This is consistent with ComposedTreeAncestorIterator.

• rendering/updating/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::nextSiblingRenderer const):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::shouldResolveElement):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::renderOrDisplayContentsStyle): Deleted.

Use the Element::renderOrDisplayContentsStyle() instead.

LayoutTests:

• fast/css/display-contents-hover-active-expected.txt: Added.
• fast/css/display-contents-hover-active.html: Added.

10:09 AM Changeset in webkit [238096] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Pressing Tab or Enter should start editing focused property
​https://bugs.webkit.org/show_bug.cgi?id=191510
<rdar://problem/45970897>

Reviewed by Dean Jackson.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

10:00 AM Changeset in webkit [238095] by commit-queue@webkit.org

• 4 edits in trunk/Source

[Web Animations] Turn Web Animations experimental
​https://bugs.webkit.org/show_bug.cgi?id=191543

Patch by Antoine Quint <Antoine Quint> on 2018-11-12
Reviewed by Dean Jackson.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

Source/WebKit:

• Shared/WebPreferences.yaml:

9:58 AM Changeset in webkit [238094] by Simon Fraser

• 5 edits
  2 adds in trunk

feFlood with alpha color doesn't work correctly
​https://bugs.webkit.org/show_bug.cgi?id=163666

Reviewed by Zalan Bujtas.
Source/WebCore:

FEFlood::platformApplySoftware() erroneously used colorWithOverrideAlpha()
rather than multiplying the flood color with the flood opacity as other browsers do.

Test: svg/filters/feFlood-with-alpha-color.html

• platform/graphics/Color.cpp:

(WebCore::Color::colorWithAlpha const): I tried using colorWithAlphaMultipliedBy() elsewhere,
and it triggered a behavior change, so add a comment.

• platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::stopColorIncludingOpacity const):

LayoutTests:

• svg/filters/feFlood-with-alpha-color-expected.html: Added.
• svg/filters/feFlood-with-alpha-color.html: Added.

9:42 AM Changeset in webkit [238093] by Alan Coon

• 7 edits in tags/Safari-607.1.13.2/Source

Versioning.

9:26 AM Changeset in webkit [238092] by Alan Coon

• 1 copy in tags/Safari-607.1.13.2

New tag.

9:18 AM Changeset in webkit [238091] by eric.carlson@apple.com

• 11 edits
  3 adds in trunk

Require <iframe allow="display"> for an iframe to use getDisplayMedia
​https://bugs.webkit.org/show_bug.cgi?id=191505
<rdar://problem/45968811>

Reviewed by Jer Noble.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt:

Source/WebCore:

Test: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start):

• Modules/mediastream/UserMediaController.cpp:

(WebCore::isAllowedToUse):
(WebCore::UserMediaController::canCallGetUserMedia):
(WebCore::UserMediaController::logGetUserMediaDenial):

• Modules/mediastream/UserMediaController.h:
• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

LayoutTests:

• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
• http/tests/media/media-stream/get-display-media-iframe-allow-attribute-expected.txt: Added.
• http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html: Added.
• http/tests/media/media-stream/resources/get-display-media-devices-iframe.html: Added.
• http/tests/ssl/media-stream/get-user-media-different-host-expected.txt:
• http/tests/ssl/media-stream/get-user-media-nested-expected.txt:

9:14 AM Changeset in webkit [238090] by Simon Fraser

• 22 edits
  1 move
  7 adds in trunk

Make compositing updates incremental
​https://bugs.webkit.org/show_bug.cgi?id=90342

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, updating compositing layers required two full RenderLayer tree traversals,
and all the work was done for every RenderLayer on each composting update. This could be expensive
on pages with lots of RenderLayers.

These changes make compositing updates more incremental. Compositing updates still require
two tree traversals. The first determines which RenderLayers need to be composited (of those which
weren't already made composited at style-change time), because of reasons that can only be determined
post-layout, and indirect reasons including overlap. The second traversal updates the configuration, geometry
and GraphicsLayer tree for the composited layers. Dependencies on both descendant and ancestor state make
it hard to fold these two traversals together.

In order to minimize the work done during these traversals, dirty bits are stored on RenderLayers,
and propagated to ancestor layers in paint order. There are two sets of bits: those related to the first
"compositing requirements" traversal, and those related to the second "update backing and hierarchy" traversal.
When a RenderLayer gets a dirty bit set, bits are propagated to ancestors to indicate that children need
to be visited.

Sadly entire subtrees can't be skipped during the "compositing requirements" traversal becaue we still have
to accumulate overlap rects, but RenderLayerCompositor::traverseUnchangedSubtree() is used to minimize
work in that case. Subtrees can be skipped in the "update backing and hierarchy" traveral. Entire traversals can
be skipped if no change has triggered the need for that traversal.

These changes fix a correctness issue where transform changes now trigger overlap re-evaluation, which causes
more layer geometry updates than before. This regressed the MotionMark "Focus" test, when geometry updates
triggered layer resizes as the filter blur radius changed, which then triggered repaints. This is fixed by
excluding composited filters from the composited bounds (but still taking them into account for overlap).

Care is taken to avoid triggering traversals in non-composited documents (tested by no-updates-in-non-composited-iframe.html).

Code to set the dirty bits is added in various places that change properties that compositing depends on.

These changes also subsume the patch in 176196; we now never consult properties that rely on layout from the
style change code path, and the only call stack for geometry updates is from the "update backing and hierarchy"
traversal, which is always a pre-order traversal.

Tests: compositing/geometry/stacking-context-change-layer-reparent.html

compositing/layer-creation/change-to-overlap.html
compositing/updates/no-updates-in-non-composited-iframe.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChanged): Need to differentiate between a canvas becoming composited
for the first time, and its pixels changing with a new 'CanvasPixelsChanged' value.

• page/FrameView.cpp:

(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):

• page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateBackdropFilters): If we just made a layer for backdrops, we need to update sublayers.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::shouldBeStackingContext const):
(WebCore::RenderLayer::stackingContext const):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::setAncestorsHaveCompositingDirtyFlag):
(WebCore::RenderLayer::contentChanged):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::enclosingCompositingLayer const):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint const):
(WebCore::RenderLayer::clippingRootForPainting const):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):
(WebCore::compositingContainer): Deleted.

• rendering/RenderLayer.h:

(WebCore::RenderLayer::clearZOrderLists):
(WebCore::RenderLayer::paintOrderParent const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::setRequiresBackgroundLayer):
(WebCore::RenderLayerBacking::updateMaskingLayer):
(WebCore::RenderLayerBacking::paintsContent const):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::setCompositedBounds):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::CompositingState::CompositingState):
(WebCore::RenderLayerCompositor::enableCompositingMode):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlagsAfterLayout):
(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::clippingChanged):
(WebCore::styleAffectsLayerGeometry):
(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::RenderLayerCompositor::needsCompositingUpdateForStyleChangeOnNonCompositedLayer const):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer const):
(WebCore::RenderLayerCompositor::computeExtent const):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::rootLayerConfigurationChanged):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::needsToBeComposited const):
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::clippedByAncestor const):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo const):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters const):
(WebCore::RenderLayerCompositor::requiresCompositingForWillChange const):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin const):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
(WebCore::RenderLayerCompositor::styleChangeMayAffectIndirectCompositingReasons):
(WebCore::RenderLayerCompositor::fixedLayerIntersectsViewport const):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::rootOrBodyStyleChanged):
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
(WebCore::operator<<):
(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): Deleted.
(WebCore::checkIfDescendantClippingContextNeedsUpdate): Deleted.
(WebCore::isScrollableOverflow): Deleted.
(WebCore::styleHasTouchScrolling): Deleted.
(WebCore::styleChangeRequiresLayerRebuild): Deleted.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Deleted.
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged): Deleted.
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Deleted.
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): Deleted.

• rendering/RenderLayerCompositor.h:
• rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

Source/WebKitLegacy/mac:

Fix spelling error.

• WebView/WebView.mm:

(-[WebView _setMediaLayer:forPluginView:]):

LayoutTests:

Add some new tests for issues discovered during development.

Filter tests get new results because composited layer bounds are no longer affected
by pixel-moving filters.

• compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
• compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
• compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
• compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
• compositing/geometry/stacking-context-change-layer-reparent-expected.html: Added.
• compositing/geometry/stacking-context-change-layer-reparent.html: Added.
• compositing/layer-creation/change-to-overlap-expected.txt: Added.
• compositing/layer-creation/change-to-overlap.html: Added.
• compositing/updates/no-updates-in-non-composited-iframe-expected.txt: Added.
• compositing/updates/no-updates-in-non-composited-iframe.html: Added.
• compositing/updates/resources/non-composited.html: Added.
• compositing/video/video-clip-change-src.html: This test was timing-sensitive; the behavior differed bases on whether we

happened to do a compositing flush between the first and second video load.

• platform/mac-wk1/TestExpectations: Mark compositing/layer-creation/fixed-overlap-extent.html as flakey; it depends on the

timing of various AppKit-related things that aren't consistent.

8:49 AM Changeset in webkit [238089] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CSSCalcOperation constructor wastes 6KB of Vector capacity on cnn.com
​https://bugs.webkit.org/show_bug.cgi?id=190839

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-12
Reviewed by Frédéric Wang.

The CSSCalcOperation ctor that takes a leftSide and rightSide parameter
wastes memory since it will always have size 2 but claims the
default Vector size. So make sure to reserve an initial capacity of 2.

• css/CSSCalculationValue.cpp:

8:48 AM Changeset in webkit [238088] by yusukesuzuki@slowstart.org

• 5 edits in trunk/Source/WebCore

WTFMove(xxx) is used in arguments while other arguments touch xxx
​https://bugs.webkit.org/show_bug.cgi?id=191544

Reviewed by Alex Christensen.

The order of the evaluation of C++ arguments is undefined. If we use WTFMove(xxx),
xxx should not be touched in the other arguments. This patch fixes such uses in
IDB code.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteIndex):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::scheduleOperation):

• Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):

• Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::registerIndex):

8:18 AM Changeset in webkit [238087] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] Construct dedicated runs when the inline element requires it.
​https://bugs.webkit.org/show_bug.cgi?id=191509

Reviewed by Antti Koivisto.

In certain cases, a run can overlap multiple inline elements like this:

<span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span>

The content above generates one long run <normal text contentbut this one needs dedicated runend of text> <- input to line breaking.
However, since the middle run is positioned, it needs to be moved independently from the rest of the content, hence it needs a dedicated inline run.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::contentRequiresSeparateRun):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

• layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::inlineFormattingState const):

• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::nextRun): mid-word breaking is not implemented yet.

• layout/inlineformatting/InlineRun.h:

(WebCore::Layout::InlineRun::overlapsMultipleInlineItems const):

• layout/inlineformatting/InlineRunProvider.cpp:

(WebCore::Layout::InlineRunProvider::processInlineTextItem):

• layout/inlineformatting/InlineRunProvider.h:

(WebCore::Layout::InlineRunProvider::Run::TextContext::expand):
(WebCore::Layout::InlineRunProvider::Run::textContext):
(WebCore::Layout::InlineRunProvider::Run::TextContext::setStart): Deleted.
(WebCore::Layout::InlineRunProvider::Run::TextContext::setLength): Deleted.

7:12 AM Changeset in webkit [238086] by jer.noble@apple.com

• 3 edits
  2 adds in trunk

[MSE] Frame re-ordering can cause iframes to never be enqueued
​https://bugs.webkit.org/show_bug.cgi?id=191485

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-dropped-iframe.html

Some frame re-ordering techniques result in files where the first frame has a
decode timestamp < 0, but a presentation timestamp >= 0. When appending these
samples to existing content, we can fail to enqueue the first frame because its
DTS overlaps an existing sample, but the presentation timestamp does not.
Rather than try to only enqueue samples whose decode timestamps are > than the
greatest decode end timestamp (minus some fudge factor), allow all frames to be
added to the decode queue if they are strictly ordered greater than the last
enqueued frame.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::provideMediaData):
(WebCore::SourceBuffer::reenqueueMediaForTime):

LayoutTests:

• media/media-source/media-source-dropped-iframe-expected.txt: Added.
• media/media-source/media-source-dropped-iframe.html: Added.

6:55 AM Changeset in webkit [238085] by yusukesuzuki@slowstart.org

• 2 edits in trunk/Source/WebCore

IDBTransaction does not use "RefPtr<IDBTransaction> self"
​https://bugs.webkit.org/show_bug.cgi?id=190436

Reviewed by Alex Christensen.

It seems that RefPtr<IDBTransaction> self; is not effective since it does not capture anything.
Use protectedThis = makeRef(*this) instead.

No behavior change.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):

6:40 AM Changeset in webkit [238084] by aboya@igalia.com

• 7 edits
  2 adds in trunk

[MSE][GStreamer] Introduce AbortableTaskQueue
​https://bugs.webkit.org/show_bug.cgi?id=190902

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

A new synchronization primitive is introduced: AbortableTaskQueue,
which allows to send work to the main thread from a background thread
with the option to perform two-phase cancellation (startAborting() and
finishAborting()).

This new primitive has been used to overhaul GstBus messaging in
AppendPipeline. A lot of code made redundant has been deleted in the
process and lots of internal functions were now able to be made
private. As part of the refactor all glib signals in AppendPipeline
now use lambdas. All usages of WTF::isMainThread() in AppendPipeline
have been replaced by isMainThread() for consistency with the rest of
WebKit.

Two-phase cancellation is still not used in AppendPipeline as of this
patch, but it will be used in a future patch that makes use of
GStreamer flushes to implement correct MSE abort semantics. There are
unit tests to ensure it works correctly, even if it's still not used.

• WebCore.xcodeproj/project.pbxproj:
• platform/AbortableTaskQueue.h: Added.
• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::dumpAppendState):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe):
(WebCore::AppendPipeline::handleAppsinkNewSampleFromAnyThread):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):

• platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::sourceBufferPrivate):
(WebCore::AppendPipeline::appsinkCaps):
(WebCore::AppendPipeline::track):
(WebCore::AppendPipeline::demuxerSrcPadCaps):
(WebCore::AppendPipeline::playerPrivate):

Tools:

Tests for AbortableTaskQueue are included.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::FancyResponse::FancyResponse):
(TestWebKitAPI::FancyResponse::operator=):
(TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):

4:40 AM Changeset in webkit [238083] by calvaris@igalia.com

• 6 edits in trunk/Source/WebCore

[GStreamer][EME] waitingforkey event should consider decryptors' waiting status
​https://bugs.webkit.org/show_bug.cgi?id=191459

Reviewed by Carlos Garcia Campos.

The new cross platform architecture to report waitingforkey and
recover from it requires a more accurate knowledge of what is
going on with the decryptors because events are reported only once
(per key exchange run) and crossplatform only continues if we are
actually ready to continue, meaning that no decryptors are
waiting.

• platform/graphics/gstreamer/GUniquePtrGStreamer.h: Added

GstIterator deleter.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::setWaitingForKey): Bail
out if we are requested to not wait anymore but there are still
waiting decryptors.
(WebCore::MediaPlayerPrivateGStreamerBase::waitingForKey const):
Query the pipeline, just a query after pipeline is built and
manual inspection during build. The query is optimal but sometimes
we can get this request when the pipeline is under construction so
queries do not arrive at the decryptors and we have to deliver it
by ourselves.
(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:
Deleted because it is now inlined.

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webKitMediaClearKeyDecryptorDecrypt): Fixed small compiler warning.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init): Override
query method.
(webkitMediaCommonEncryptionDecryptTransformInPlace): When the
decryptor is going to block to wait, report before. When the
decryptor receives the key, report it got it.
(webkitMediaCommonEncryptionDecryptSinkEventHandler): Do not
handle waitingforkey here.
(webkitMediaCommonEncryptionDecryptorQueryHandler): Report if the
decryptor is waiting.

1:05 AM Changeset in webkit [238082] by Michael Catanzaro

• 4 edits in trunk/Source/WebCore

[GTK] Silence ATK_XY_PARENT warnings
​https://bugs.webkit.org/show_bug.cgi?id=191504

Reviewed by Carlos Garcia Campos.

• accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:

(atkToContents):

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(textExtents):

• accessibility/atk/WebKitAccessibleUtil.cpp:

(contentsRelativeToAtkCoordinateType):

Nov 11, 2018:

6:00 PM Changeset in webkit [238081] by Fujii Hironori

• 2 edits in trunk/Tools

run-bindings-tests is timing out in some WinCairo bots
​https://bugs.webkit.org/show_bug.cgi?id=191348

Reviewed by Alex Christensen.

BuildBot kills run-bindings-tests if it outputs nothing for 20
minutes. run-bindings-tests runs very slowly in WinCairo Docker,
and it takes more than 30 minutes to finish. And, Windows Python
buffers the progress output.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.detect_changes): Call sys.stdout.flush() after the
test case result is output.

5:39 PM Changeset in webkit [238080] by Wenson Hsieh

• 18 edits
  5 adds in trunk

Implement a new edit command to change the enclosing list type
​https://bugs.webkit.org/show_bug.cgi?id=191487
<rdar://problem/45955922>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for a new edit command that changes the type of the enclosing list element around the selection from
unordered to ordered list and vice versa. This new edit command is exposed only to internal WebKit2 clients, via
SPI on WKWebView (-_changeListType:).

This is currently intended for use in Mail compose, but may also be adopted by legacy Notes in the future. As
such, the behavior of this editing command mostly matches shipping behavior in Mail compose (which is currently
implemented entirely by Mail). See below for more details.

Test: editing/execCommand/change-list-type.html

WKWebViewEditActions.ChangeListType

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/ChangeListTypeCommand.cpp: Added.

(WebCore::listConversionTypeForSelection):
(WebCore::ChangeListTypeCommand::listConversionType):

Helper that returns a potential list conversion command that may be executed at the given document's selection,
if any exists. We also use existing logic from Mail here to determine which list to change, by walking up the
DOM from the lowest common ancestor container of the current selection until we hit the first list element.

(WebCore::ChangeListTypeCommand::createNewList):

Helper method to create a new list element to replace the given list, and then clone element data from the given
list to the new list. This addresses an existing bug in Mail, wherein changing list type for an enclosing list
which contains inline style properties drops the inline styles, because existing logic in Mail that implements
this editing command only copies the class attribute of the old list to the new list.

(WebCore::ChangeListTypeCommand::doApply):

Apply the edit command by running the following steps:

• Find the enclosing list element, if any (see above).
• Create a new list element of the opposite type as the enclosing list, and clone over element data from the

list element being replaced.

• Insert the new list next to the original list.
• Move all children of the original list to the new list.
• Remove the original list.
• Set the selection to the end of the new list.

• editing/ChangeListTypeCommand.h: Added.
• editing/EditAction.h:

Add a pair of new edit actions for conversion from unordered list to ordered list and vice versa.

• editing/Editor.cpp:

(WebCore::Editor::changeSelectionListType):

Implement this by creating and applying a new ChangeListTypeCommand.

(WebCore::Editor::canChangeSelectionListType): Deleted.

Remove this for now, since there's no need for it until full support for edit command validation is implemented.

• editing/Editor.h:
• testing/Internals.cpp:

(WebCore::Internals::changeSelectionListType):

• testing/Internals.h:
• testing/Internals.idl:

Add internal hooks to change list type from layout tests.

Source/WebKit:

• UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Remove preflight checks for these list editing commands. These are not necessary because these commands fall
back to being noops if these checks return false. This avoids an extraneous ancestor walk to determine the
enclosing list element when changing list type.

Source/WebKitLegacy/mac:

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

• WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Tools:

Add a new API test to verify that -[WKWebView _changeListType:] is hooked up to the corresponding editing
command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(-[TestWKWebView setPosition:offset:]):
(-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
(TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.

LayoutTests:

Add a new layout test to verify that the list change type editing command can be used to swap between enclosing
ordered and unordered lists. Also exercises undo, redo, changing list types under pre and table elements,
and handling selection within nested list elements.

• editing/execCommand/change-list-type-expected.txt: Added.
• editing/execCommand/change-list-type.html: Added.

2:22 PM Changeset in webkit [238079] by jfernandez@igalia.com

• 29 edits
  73 adds
  3 deletes in trunk/LayoutTests

[css-grid] Import additional grid layout test from the WPT suite
​https://bugs.webkit.org/show_bug.cgi?id=191369

Reviewed by Manuel Rego Casasnovas.

New Grid Layout tests from the WPT suite.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/css/css-grid/META.yml: Added.
• web-platform-tests/css/css-grid/OWNERS: Removed.
• web-platform-tests/css/css-grid/abspos/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/support/style-change.js:

(evaluateStyleChangeMultiple):

• web-platform-tests/css/css-grid/alignment/support/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/test-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/w3c-import.log:
• web-platform-tests/css/css-grid/grid-definition/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-definition/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html: Added.
• web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width-expected.html: Added.
• web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width.html: Added.
• web-platform-tests/css/css-grid/grid-items/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-items/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width-expected.html: Added.
• web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width.html: Added.
• web-platform-tests/css/css-grid/grid-items/w3c-import.log:
• web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002-expected.html: Added.
• web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html: Added.
• web-platform-tests/css/css-grid/grid-model/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-model/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-model/w3c-import.log:
• web-platform-tests/css/css-grid/implicit-grids/w3c-import.log:
• web-platform-tests/css/css-grid/inheritance-expected.txt: Added.
• web-platform-tests/css/css-grid/inheritance.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
• web-platform-tests/css/css-grid/parsing/grid-area-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/w3c-import.log: Added.
• web-platform-tests/css/css-grid/placement/w3c-import.log:
• web-platform-tests/css/css-grid/test-plan/w3c-import.log:
• web-platform-tests/css/css-grid/w3c-import.log:
• web-platform-tests/css/support/META.yml: Added.
• web-platform-tests/css/support/OWNERS: Removed.
• web-platform-tests/css/support/computed-testcommon.js: Added.

(test_computed_value):

• web-platform-tests/css/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/support/inheritance-testcommon.js: Added.

(assert_initial):

• web-platform-tests/css/support/parsing-testcommon.js: Added.

(test_valid_value):

• web-platform-tests/css/support/support/w3c-import.log:
• web-platform-tests/css/support/w3c-import.log:

LayoutTests:

• TestExpectations: Added bugs and ImageOnlyFailure for 3 tests that are failing.

1:32 PM Changeset in webkit [238078] by dbates@webkit.org

• 38 edits in trunk

[iOS] Draw caps lock indicator in password fields
​https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Source/WebCore:

Reviewed by Dean Jackson.

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac.

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

• WebCore.xcodeproj/project.pbxproj:
• page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().

• page/EventHandler.h:
• platform/cocoa/KeyEventCocoa.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.

• platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.

• platform/ios/WebEvent.h:
• platform/ios/WebEvent.mm:

(+[WebEvent modifierFlags]): Added.

• platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.

• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Reviewed by Dean Jackson.

Forward declare some more SPI.

• pal/spi/ios/GraphicsServicesSPI.h:
• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Reviewed by Dean Jackson.

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Reviewed by Dean Jackson.

Update the caps lock state when a hardware keyboard is attached or detached.

• WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Reviewed by Dean Jackson.

Expose some more symbols.

• WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

LayoutTests:

Unreviewed.

Update expected results now that iOS supports showing the caps lock indictor.

• platform/ios/fast/css/text-overflow-input-expected.txt:
• platform/ios/fast/forms/basic-inputs-expected.txt:
• platform/ios/fast/forms/input-appearance-height-expected.txt:
• platform/ios/fast/forms/input-value-expected.txt:
• platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/ios/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

1:29 PM Changeset in webkit [238077] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][BFC] In-flow positioned logic is really formatting context dependent.
​https://bugs.webkit.org/show_bug.cgi?id=191512

Reviewed by Simon Fraser.

Move block formatting context specific code from FormattingContext to BlockFormattingContext.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:

12:00 PM Changeset in webkit [238076] by mitz@apple.com

• 4 edits
  1 add in trunk

ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=191514

Reviewed by Geoffrey Garen.

Source/WebKit:

Test: WebKitCocoa/WKProcessPoolConfiguration.mm

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.

(TEST):

9:13 AM Changeset in webkit [238075] by mmaxfield@apple.com

• 6 edits in trunk

Address post-review comments after r237955
​https://bugs.webkit.org/show_bug.cgi?id=191496

Reviewed by Darin Adler.

Source/WebCore:

• rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

• style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

• style/InlineTextBoxStyle.h:

LayoutTests:

• fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:

12:27 AM Changeset in webkit [238074] by benjamin@webkit.org

• 34 edits
  1 move in trunk

Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
​https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename file.

• API/JSValue.mm:

Source/WebCore:

Rename file.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
• page/mac/EventHandlerMac.mm:
• platform/mac/URLMac.mm:
• platform/mac/WebCoreNSURLExtras.mm:
• platform/mac/WebCoreObjCExtras.mm:
• rendering/RenderThemeMac.mm:

Source/WebKit:

• Platform/mac/StringUtilities.mm:
• UIProcess/ApplicationStateTracker.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

• Carbon/HIWebView.mm:
• Misc/WebNSFileManagerExtras.mm:
• Misc/WebNSURLExtras.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:
• Plugins/WebPluginContainerCheck.mm:
• WebCoreSupport/WebCachedFramePlatformData.h:
• WebCoreSupport/WebDeviceOrientationClient.mm:
• WebView/WebDelegateImplementationCaching.mm:
• WebView/WebHTMLView.mm:
• WebView/WebPDFRepresentation.mm:
• WebView/WebPolicyDelegate.mm:
• WebView/WebView.mm:

Tools:

Update file name.

• DumpRenderTree/mac/DumpRenderTree.mm:
• WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
• WebKitTestRunner/mac/TestControllerMac.mm: