Context Navigation

← Previous Period
Next Period →

Timeline

Nov 21, 2018:

10:39 PM Changeset in webkit [238440] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

Phantom focus/blur events fire on clicking between text input fields when listening with addEventListener
https://bugs.webkit.org/show_bug.cgi?id=179990

Reviewed by Tim Horton.

The bug was caused by TemporarySelectionChange which is used by TextIndicator::createWithRange
to set and restore the selection putting the focus on the newly mouse-down'ed input element
and restoring the focus back to the input element which originally had the focus immediately.

Fixed the bug by avoiding to set the focus since only selection highlights need to be updated here.
Also made TemporarySelectionOption an enum class.

Unfortunately, no new tests since force click testing is broken :( See <rdar://problem/31301721>.

editing/Editor.cpp:

(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
(WebCore::TemporarySelectionChange::setSelection): Extracted. Fixed the bug by adding
FrameSelection::DoNotSetFocus to the option when TemporarySelectionOption::DoNotSetFocus is set.

editing/Editor.h:
page/DragController.cpp:

(WebCore::DragController::performDragOperation):

page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange): Set TemporarySelectionOption::DoNotSetFocus.

9:47 PM Changeset in webkit [238439] by yusukesuzuki@slowstart.org

31 edits
4 deletes in trunk/Source

[JSC] Drop ARM_TRADITIONAL support in LLInt, baseline JIT, and DFG
https://bugs.webkit.org/show_bug.cgi?id=191675

Reviewed by Mark Lam.

Source/JavaScriptCore:

We no longer maintain ARM_TRADITIONAL LLInt and JIT in JSC. This architecture will use
CLoop instead. This patch removes ARM_TRADITIONAL support in LLInt and JIT.

Discussed in https://lists.webkit.org/pipermail/webkit-dev/2018-October/030220.html.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
assembler/ARMAssembler.cpp: Removed.
assembler/ARMAssembler.h: Removed.
assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpCode):

assembler/MacroAssembler.h:

(JSC::MacroAssembler::patchableBranch32):

assembler/MacroAssemblerARM.cpp: Removed.
assembler/MacroAssemblerARM.h: Removed.
assembler/PerfLog.cpp:
assembler/PerfLog.h:
assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):

assembler/testmasm.cpp:

(JSC::isPC):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

bytecode/InlineAccess.h:

(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):

dfg/DFGSpeculativeJIT.h:
disassembler/CapstoneDisassembler.cpp:

(JSC::tryToDisassemble):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall):

jit/AssemblyHelpers.h:
jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsImpl):
(JSC::CCallHelpers::prepareForTailCallSlow):

jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareForTailCall):

jit/HostCallReturnValue.cpp:
jit/JITMathIC.h:

(JSC::isProfileEmpty):

jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):

jit/Repatch.cpp:

(JSC::forceICFailure):

jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
offlineasm/arm.rb:
offlineasm/backends.rb:
yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):

Source/WTF:

wtf/InlineASM.h:
wtf/Platform.h:

9:03 PM Changeset in webkit [238438] by Wenson Hsieh

27 edits
15 adds in trunk

[Cocoa] [WebKit2] Add support for replacing find-in-page text matches
https://bugs.webkit.org/show_bug.cgi?id=191786
<rdar://problem/45813871>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for replacing Find-in-Page matches. See below for details. Covered by new layout tests as well as a
new API test.

Tests: editing/find/find-and-replace-adjacent-words.html

editing/find/find-and-replace-at-editing-boundary.html
editing/find/find-and-replace-basic.html
editing/find/find-and-replace-in-subframes.html
editing/find/find-and-replace-no-matches.html
editing/find/find-and-replace-noneditable-matches.html
editing/find/find-and-replace-replacement-text-input-events.html

API test: WebKit.FindAndReplace

page/Page.cpp:

(WebCore::replaceRanges):
(WebCore::Page::replaceRangesWithText):

Add a helper that, given a list of Ranges, replaces each range with the given text. To do this, we first map
each Range to editing offsets within the topmost editable root for each Range. This results in a map of editable
root to list of editing offsets we need to replace. To apply the replacements, for each editable root in the
map, we iterate over each replacement range (i.e. an offset and length), set the current selection to contain
that replacement range, and use Editor::replaceSelectionWithText. To prevent prior text replacements from
clobbering the offsets of latter text replacement ranges, we also iterate backwards through text replacement
ranges when performing each replacement.

Likewise, we also apply text replacement to each editing container in backwards order: for nodes in the same
frame, we compare their position in the document, and for nodes in different frames, we instead compare their
frames in frame tree traversal order.

We map Ranges to editing offsets and back when performing text replacement because each text replacement may
split or merge text nodes, which causes adjacent Ranges to shrink or extend while replacing text. In an earlier
attempt to implement this, I simply iterated over each Range to replace and carried out text replacement for
each Range. This led to incorrect behavior in some cases, such as replacing adjacent matches. Thus, by computing
the set of text replacement offsets prior to replacing any text, we're able to target the correct ranges for
replacement.

(WebCore::Page::replaceSelectionWithText):

Add a helper method on Page to replace the current selection with some text. This simply calls out to
Editor::replaceSelectionWithText.

page/Page.h:

Source/WebCore/PAL:

Add -replaceMatches:withString:inSelectionOnly:resultCollector:.

pal/spi/mac/NSTextFinderSPI.h:

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView replaceMatches:withString:inSelectionOnly:resultCollector:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::replaceMatches):

UIProcess/WebPageProxy.h:
UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient replaceMatches:withString:inSelectionOnly:resultCollector:]):

Implement this method to opt in to "Replace…" UI on macOS in the find bar. In this API, we're given a list of
matches to replace. We propagate the indices of each match to the web process, where FindController maps them to
corresponding replacement ranges. Currently, the given list of matches is only ever a list containing the first
match, or a list containing all matches.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageFindStringMatches):
(WKBundlePageReplaceStringMatches):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches):

Map match indices to Ranges, and then call into WebCore::Page to do the heavy lifting (see WebCore ChangeLog for
more details). Additionally add a hard find-and-replace limit here to prevent the web process from spinning
indefinitely if there are an enormous number of find matches.

WebProcess/WebPage/FindController.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findStringMatchesFromInjectedBundle):
(WebKit::WebPage::replaceStringMatchesFromInjectedBundle):

Add helpers to exercise find and replace in WebKit2.

(WebKit::WebPage::replaceMatches):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController setFindBarView:]):

Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
the "Replace" option.

TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

Add an API test to exercise find-and-replace API using WKWebView.

(replaceMatches):
(TEST):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::findOptionsFromArray):
(WTR::TestRunner::findString):
(WTR::TestRunner::findStringMatchesInPage):
(WTR::TestRunner::replaceFindMatchesAtIndices):

Add TestRunner hooks to simulate find-in-page and replace.

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Introduce a LayoutTests/editing/find directory to contain tests around FindController, and add 7 new layout
tests. These are currently enabled only for WebKit2 on macOS and iOS.

TestExpectations:
editing/find/find-and-replace-adjacent-words-expected.txt: Added.
editing/find/find-and-replace-adjacent-words.html: Added.

Test find-and-replace with adjacent words.

editing/find/find-and-replace-at-editing-boundary-expected.txt: Added.
editing/find/find-and-replace-at-editing-boundary.html: Added.

Test find-and-replace when one of the find matches straddles an editing boundary. In this case, we verify that
the replacement does not occur, since only part of the word would be replaced.

editing/find/find-and-replace-basic-expected.txt: Added.
editing/find/find-and-replace-basic.html: Added.

Add a basic test that exercises a single text replacement, and "replace all".

editing/find/find-and-replace-in-subframes-expected.txt: Added.
editing/find/find-and-replace-in-subframes.html: Added.

Test find-and-replace when some of the matches are in editable content in subframes. This test additionally
contains matches in shadow content (in this case, text fields) within both the main document and the subframe,
and verifies that text replacement reaches these elements as well.

editing/find/find-and-replace-no-matches-expected.txt: Added.
editing/find/find-and-replace-no-matches.html: Added.

Test find-and-replace when no replacement matches are specified. In this case, we fall back to inserting the
replacement text at the current selection.

editing/find/find-and-replace-noneditable-matches-expected.txt: Added.
editing/find/find-and-replace-noneditable-matches.html: Added.

Test find-and-replace when some of the matches to replace are noneditable, others are editable, and others are
editable but are nested within noneditable elements (i.e. contenteditable=false). In this case, "replace all"
should still replace all fully editable matches.

editing/find/find-and-replace-replacement-text-input-events-expected.txt: Added.
editing/find/find-and-replace-replacement-text-input-events.html: Added.

Tests that find-and-replace emits input events of inputType "insertReplacementText", except when inserting
replacement text at a caret selection.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

7:43 PM Changeset in webkit [238437] by sbarati@apple.com

3 edits
1 add in trunk

DFGSpeculativeJIT should not &= exitOK with mayExit(node)
https://bugs.webkit.org/show_bug.cgi?id=191897
<rdar://problem/45871998>

Reviewed by Mark Lam.

JSTests:

stress/exitok-is-not-the-same-as-mayExit.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

exitOK is a statement about it being legal to exit. mayExit() is about being
conservative and returning false only if an OSR exit *could never* happen.
mayExit() tries to be as smart as possible to see if it can return false.
It can't return false if a runtime exit *could* happen. However, there is
code in the compiler where mayExit() returns false (because it uses data
generated from AI about type checks being proved), but the code we emit in the
compiler backend unconditionally generates an OSR exit, even if that exit may
never execute. For example, let's say we have this IR:

SomeNode(Boolean:@input)

And we always emit code like this as a way of emitting a boolean type check:

jump L1 if input == true
jump L1 if input == false
emit an OSR exit

In such a program, when we generate the above OSR exit, in a validationEnabled()
build, and if @input is proved to be a boolean, we'll end up crashing because we
have the bogus assertion saying !exitOK. This is one reason why things are cleaner
if we don't conflate mayExit() with exitOK.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

7:39 PM Changeset in webkit [238436] by sbarati@apple.com

4 edits
1 add in trunk

Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
https://bugs.webkit.org/show_bug.cgi?id=191895
<rdar://problem/46167406>

Reviewed by Mark Lam.

JSTests:

stress/known-cell-use-needs-type-check-assertion.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

We were asserting that the input edge should have type SpecCell but it should
really be SpecCellCheck since the type filter for KnownCellUse is SpecCellCheck.

This patch cleans up that assertion code by joining a bunch of cases into a
single function call which grabs the type filter for the edge UseKind and
asserts that the incoming edge meets the type filter criteria.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculate):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::speculate):

6:57 PM Changeset in webkit [238435] by yusukesuzuki@slowstart.org

4 edits in trunk/Source/JavaScriptCore

[JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number 4
https://bugs.webkit.org/show_bug.cgi?id=191877

Reviewed by Sam Weinig.

Instead of hard-coding 4 into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.

interpreter/ProtoCallFrame.h:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

6:12 PM Changeset in webkit [238434] by aestes@apple.com

22 edits
2 adds in trunk/Source

[Cocoa] Create a soft-linking file for PassKit
https://bugs.webkit.org/show_bug.cgi?id=191875
<rdar://problem/46203215>

Reviewed by Myles Maxfield.

Source/WebCore:

Modules/applepay/cocoa/PaymentContactCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm: Ditto.
SourcesCocoa.txt: Removed @no-unify from PaymentMerchantSessionCocoa.mm.
WebCore.xcodeproj/project.pbxproj: Removed PaymentMerchantSessionCocoa.mm from the WebCore target.
rendering/RenderThemeCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:
pal/cocoa/PassKitSoftLink.h: Added.
pal/cocoa/PassKitSoftLink.mm: Added. Used _WITH_EXPORT soft-linking macros in order to

make the PAL soft-linking symbols visible to WebKit.

pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
SourcesCocoa.txt: Removed @no-unify from WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm.
UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Ditto.
UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: Ditto.
UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: Included NSAttributedStringSPI.h.
UIProcess/mac/WebProcessProxyMac.mm: Included ProcessPrivilege.h.
WebKit.xcodeproj/project.pbxproj: Removed WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm from the WebKit target.

Source/WTF:

wtf/Platform.h: Defined USE_PASSKIT.
wtf/cocoa/SoftLinking.h: Added _WITH_EXPORT variants of SOFT_LINK_FRAMEWORK_FOR_SOURCE,

SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE, SOFT_LINK_CLASS_FOR_SOURCE,
SOFT_LINK_FUNCTION_FOR_SOURCE, and SOFT_LINK_CONSTANT_FOR_SOURCE.

5:51 PM Changeset in webkit [238433] by mark.lam@apple.com

7 edits
2 adds in trunk

Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.
https://bugs.webkit.org/show_bug.cgi?id=191776
<rdar://problem/46152851>

Reviewed by Saam Barati.

JSTests:

stress/big-wasm-memory-grow-no-max.js:
stress/big-wasm-memory-grow.js:
stress/big-wasm-memory.js:
updated these to expect an OutOfMemoryError.

wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js: Added.

(Binary.prototype.emit_u8):
(Binary.prototype.emit_u32v):
(Binary.prototype.emit_header):
(Binary.prototype.emit_section):
(Binary):
(WasmModuleBuilder):
(WasmModuleBuilder.prototype.addMemory):
(WasmModuleBuilder.prototype.toArray):
(WasmModuleBuilder.prototype.toBuffer):
(WasmModuleBuilder.prototype.instantiate):
(catch):

wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE.js: Added.

(catch):

Source/JavaScriptCore:

wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::tryCreate):

return nullptr if the requested bytes exceed MAX_ARRAY_BUFFER_SIZE. The clients will already do a null check and throw an OutOfMemoryError if needed.

(JSC::Wasm::Memory::grow):

throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.
wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):

throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.

5:27 PM Changeset in webkit [238432] by Fujii Hironori

3 edits in trunk/Source/WebKit

Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp

and InjectedBundleNodeHandle.cpp

WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership

not to be compiled by XCode.

3:25 PM Changeset in webkit [238431] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] LayoutState should always be initialized with the initial containing block.
https://bugs.webkit.org/show_bug.cgi?id=191896

Reviewed by Antti Koivisto.

There should always be only one LayoutState per layout tree (it does not mean that layout always starts at the ICB).
The ICB is a special formatting context root because it does not have a parent formatting context. All the other formatting contexts
first need to be laid out (partially at least e.g margin) in their parent formatting context.
Having a non-null parent formatting context as root could lead to undefined behaviour.

layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot): Deleted.

layout/LayoutFormattingState.h:
layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

3:13 PM Changeset in webkit [238430] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][IFC] Horizontal margins should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191894

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding and border, horizontal margins also force run breaks and offset them.

Test: fast/inline/inline-content-with-margin-left-right.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-margin-left-right-expected.txt: Added.
fast/inline/inline-content-with-margin-left-right.html: Added.

1:33 PM Changeset in webkit [238429] by rniwa@webkit.org

3 edits
2 adds in trunk

Mutation observers doesn't get notified of character data mutation made by the parser
https://bugs.webkit.org/show_bug.cgi?id=191874

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.

Test: fast/dom/MutationObserver/observe-parser-character-data-change.html

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

LayoutTests:

Added a regression test.

fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.

11:10 AM Changeset in webkit [238428] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.22.2

WPE WebKit release 2.22.2

11:09 AM Changeset in webkit [238427] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.2 release.

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.22.2.

10:58 AM Changeset in webkit [238426] by Claudio Saavedra

2 edits in trunk/Source/WebCore

[SOUP] Follow-up robustness improvements to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=191892

Reviewed by Michael Catanzaro.

If at any point the certificate fails to be constructed from
the DER data, bail out. Likewise, if the certificate returned
is NULL, return false from the decoder to notify the failure
to decode it.

platform/network/soup/CertificateInfo.h:

(WTF::Persistence::certificateFromCertificatesDataList):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):

10:38 AM Changeset in webkit [238425] by Caio Lima

9 edits
1 add in trunk

[BigInt] JSBigInt::createWithLength should throw when length is greater than JSBigInt::maxLength
https://bugs.webkit.org/show_bug.cgi?id=190836

Reviewed by Saam Barati and Yusuke Suzuki.

JSTests:

stress/big-int-out-of-memory-tests.js: Added.

Source/JavaScriptCore:

In this patch we are creating a new method called JSBigInt::createWithLengthUnchecked
where we allocate a BigInt trusting the length received as argument.
With this additional method, we now check if length passed to
JSBigInt::tryCreateWithLength is not greater than JSBigInt::maxLength.
When the length is greater than JSBigInt::maxLength, we then throw OOM
exception.
This required us to change the interface of some JSBigInt operations to
receive ExecState* instead of VM&. We changed only operations that
can throw because of OOM.
We beleive that this approach of throwing instead of finishing the
execution abruptly is better because JS programs can catch such
exception and handle this issue properly.

dfg/DFGOperations.cpp:
jit/JITOperations.cpp:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/JSBigInt.cpp:

(JSC::JSBigInt::createZero):
(JSC::JSBigInt::tryCreateWithLength):
(JSC::JSBigInt::createWithLengthUnchecked):
(JSC::JSBigInt::createFrom):
(JSC::JSBigInt::multiply):
(JSC::JSBigInt::divide):
(JSC::JSBigInt::copy):
(JSC::JSBigInt::unaryMinus):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::add):
(JSC::JSBigInt::sub):
(JSC::JSBigInt::bitwiseAnd):
(JSC::JSBigInt::bitwiseOr):
(JSC::JSBigInt::bitwiseXor):
(JSC::JSBigInt::absoluteAdd):
(JSC::JSBigInt::absoluteSub):
(JSC::JSBigInt::absoluteDivWithDigitDivisor):
(JSC::JSBigInt::absoluteDivWithBigIntDivisor):
(JSC::JSBigInt::absoluteLeftShiftAlwaysCopy):
(JSC::JSBigInt::absoluteBitwiseOp):
(JSC::JSBigInt::absoluteAddOne):
(JSC::JSBigInt::absoluteSubOne):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::rightTrim):
(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::createWithLength): Deleted.

runtime/JSBigInt.h:
runtime/Operations.cpp:

(JSC::jsAddSlowCase):

runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):

10:10 AM Changeset in webkit [238424] by Adrian Perez de Castro

1 copy in releases/WebKitGTK/webkit-2.22.4

WebKitGTK release 2.22.4

10:08 AM Changeset in webkit [238423] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.22.4.

9:38 AM Changeset in webkit [238422] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][IFC] Border should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191891

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding, border also forces run breaks and offsets them.

Test: fast/inline/inline-content-with-border-left-right.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-border-left-right-expected.txt: Added.
fast/inline/inline-content-with-border-left-right.html: Added.

9:37 AM Changeset in webkit [238421] by mark.lam@apple.com

4 edits
1 add in trunk

Remove invalid assertion in VMTraps::SignalSender's SignalAction.
https://bugs.webkit.org/show_bug.cgi?id=191856
<rdar://problem/46089992>

Reviewed by Yusuke Suzuki.

JSTests:

stress/regress-191856.js: Added.
this test is skipped for now until we have a fix for webkit.org/b/191855.

Source/JavaScriptCore:

The ASSERT(vm.traps().needTrapHandling()) assertion in SignalSender's SigAction
function is invalid because we can't be sure that the trap has been handled yet
by the time the trap fires. This is because the main thread may also check traps
(in LLInt, baseline JIT and VM runtime code). There's a race to handle the trap.
Hence, the SigAction cannot assume that the trap still needs handling by the time
it is executed. This patch removed the invalid assertion.

Also renamed m_trapSet to m_condition because it is a AutomaticThreadCondition,
and all the ways it is used is as a condvar. The m_trapSet name doesn't seem
appropriate nor meaningful.

runtime/VMTraps.cpp:

(JSC::VMTraps::tryInstallTrapBreakpoints):

Added a !needTrapHandling() check as an optimization: there's no need to install VMTrap breakpoints if someone already beat us to handling the trap (remember, the main thread is racing against the VMTraps signalling thread to handle the trap too). We only need to install the VMTraps breakpoints if we need DFG/FTL compiled code to deopt so that they can check and handle pending traps. If the trap has already been handled, it's better to not deopt any DFG/FTL functions.

(JSC::VMTraps::willDestroyVM):
(JSC::VMTraps::fireTrap):
(JSC::VMTraps::VMTraps):

runtime/VMTraps.h:

9:36 AM Changeset in webkit [238420] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Use contains and containsAll in InlineFormattingContext::splitInlineRunIfNeeded consistently
https://bugs.webkit.org/show_bug.cgi?id=191890

Rearrange the comment numbers to match the logic below.

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

9:24 AM Changeset in webkit [238419] by dino@apple.com

4 edits
85 moves
3 adds in trunk/Source/WebCore

Move WebGPU platform code to platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=191867
<rdar://problem/46190993>

Reviewed by Antoine Quint.

The underlying implementation of WebGPU doesn't need to live in
Modules, since it technically could be used by other parts of the system. It
makes more sense for it to be in platform/graphics/gpu.

Move...

Modules/webgpu/GPU* -> platform/graphics/gpu
Modules/webgpu/cocoa -> platform/graphics/gpu/cocoa
platform/graphics/gpu/GPULegacy* -> platform/graphics/gpu/legacy/
platform/graphics/gpu/cocoa/GPULegacy* -> platform/graphics/gpu/legacy/cocoa

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/gpu/GPUCommandBuffer.h: Renamed from Source/WebCore/Modules/webgpu/GPUCommandBuffer.h.
platform/graphics/gpu/GPUDevice.cpp: Renamed from Source/WebCore/Modules/webgpu/GPUDevice.cpp.

(WebCore::GPUDevice::createShaderModule const):
(WebCore::GPUDevice::createRenderPipeline const):
(WebCore::GPUDevice::createCommandBuffer):
(WebCore::GPUDevice::getQueue):

platform/graphics/gpu/GPUDevice.h: Renamed from Source/WebCore/Modules/webgpu/GPUDevice.h.

(WebCore::GPUDevice::platformDevice const):

platform/graphics/gpu/GPUPipelineDescriptorBase.h: Renamed from Source/WebCore/Modules/webgpu/GPUPipelineDescriptorBase.h.
platform/graphics/gpu/GPUPipelineStageDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h.
platform/graphics/gpu/GPUQueue.h: Renamed from Source/WebCore/Modules/webgpu/GPUQueue.h.

(WebCore::GPUQueue::platformQueue const):

platform/graphics/gpu/GPURenderPipeline.h: Renamed from Source/WebCore/Modules/webgpu/GPURenderPipeline.h.

(WebCore::GPURenderPipeline::platformRenderPipeline const):

platform/graphics/gpu/GPURenderPipelineDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPURenderPipelineDescriptor.h.
platform/graphics/gpu/GPUShaderModule.h: Renamed from Source/WebCore/Modules/webgpu/GPUShaderModule.h.

(WebCore::GPUShaderModule::platformShaderModule const):

platform/graphics/gpu/GPUShaderModuleDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPUShaderModuleDescriptor.h.
platform/graphics/gpu/GPUSwapChain.h: Renamed from Source/WebCore/Modules/webgpu/GPUSwapChain.h.

(WebCore::GPUSwapChain::platformLayer const):

platform/graphics/gpu/GPUTexture.h: Renamed from Source/WebCore/Modules/webgpu/GPUTexture.h.
platform/graphics/gpu/GPUTextureFormatEnum.h: Renamed from Source/WebCore/Modules/webgpu/GPUTextureFormatEnum.h.
platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUCommandBufferMetal.mm.

(WebCore::GPUCommandBuffer::create):
(WebCore::GPUCommandBuffer::GPUCommandBuffer):

platform/graphics/gpu/cocoa/GPUDeviceMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUDeviceMetal.mm.

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):

platform/graphics/gpu/cocoa/GPUQueueMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUQueueMetal.mm.

(WebCore::GPUQueue::create):
(WebCore::GPUQueue::GPUQueue):

platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPURenderPipelineMetal.mm.

(WebCore::setFunctionsForPipelineDescriptor):
(WebCore::GPURenderPipeline::create):
(WebCore::GPURenderPipeline::GPURenderPipeline):

platform/graphics/gpu/cocoa/GPUShaderModuleMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUShaderModuleMetal.mm.

(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::GPUShaderModule):

platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUSwapChainMetal.mm.

(WebCore::GPUSwapChain::create):
(WebCore::GPUSwapChain::GPUSwapChain):
(WebCore::GPUSwapChain::setDevice):
(WebCore::platformTextureFormatForGPUTextureFormat):
(WebCore::GPUSwapChain::setFormat):
(WebCore::GPUSwapChain::reshape):
(WebCore::GPUSwapChain::getNextTexture):
(WebCore::GPUSwapChain::present):

platform/graphics/gpu/cocoa/GPUTextureMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUTextureMetal.mm.

(WebCore::GPUTexture::create):
(WebCore::GPUTexture::GPUTexture):
(WebCore::GPUTexture::createDefaultTextureView):

platform/graphics/gpu/legacy/GPULegacyBuffer.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyBuffer.cpp.

(WebCore::GPULegacyBuffer::~GPULegacyBuffer):
(WebCore::GPULegacyBuffer::length const):

platform/graphics/gpu/legacy/GPULegacyBuffer.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyBuffer.h.

(WebCore::GPULegacyBuffer::contents const):
(WebCore::GPULegacyBuffer::metal const):

platform/graphics/gpu/legacy/GPULegacyCommandBuffer.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandBuffer.cpp.

(WebCore::GPULegacyCommandBuffer::~GPULegacyCommandBuffer):

platform/graphics/gpu/legacy/GPULegacyCommandBuffer.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandBuffer.h.

(WebCore::GPULegacyCommandBuffer::metal const):

platform/graphics/gpu/legacy/GPULegacyCommandQueue.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandQueue.cpp.

(WebCore::GPULegacyCommandQueue::~GPULegacyCommandQueue):

platform/graphics/gpu/legacy/GPULegacyCommandQueue.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandQueue.h.

(WebCore::GPULegacyCommandQueue::metal const):

platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputeCommandEncoder.cpp.

(WebCore::GPULegacyComputeCommandEncoder::~GPULegacyComputeCommandEncoder):

platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputeCommandEncoder.h.
platform/graphics/gpu/legacy/GPULegacyComputePipelineState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputePipelineState.cpp.

(WebCore::GPULegacyComputePipelineState::~GPULegacyComputePipelineState):

platform/graphics/gpu/legacy/GPULegacyComputePipelineState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputePipelineState.h.

(WebCore::GPULegacyComputePipelineState::metal const):

platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilDescriptor.cpp.

(WebCore::GPULegacyDepthStencilDescriptor::~GPULegacyDepthStencilDescriptor):

platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilDescriptor.h.

(WebCore::GPULegacyDepthStencilDescriptor::metal const):

platform/graphics/gpu/legacy/GPULegacyDepthStencilState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilState.cpp.

(WebCore::GPULegacyDepthStencilState::~GPULegacyDepthStencilState):

platform/graphics/gpu/legacy/GPULegacyDepthStencilState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilState.h.

(WebCore::GPULegacyDepthStencilState::metal const):

platform/graphics/gpu/legacy/GPULegacyDevice.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDevice.cpp.

(WebCore::GPULegacyDevice::~GPULegacyDevice):

platform/graphics/gpu/legacy/GPULegacyDevice.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDevice.h.

(WebCore::GPULegacyDevice::layer const):
(WebCore::GPULegacyDevice::metal const):
(WebCore::GPULegacyDevice::markLayerComposited const):

platform/graphics/gpu/legacy/GPULegacyDrawable.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDrawable.cpp.

(WebCore::GPULegacyDrawable::~GPULegacyDrawable):

platform/graphics/gpu/legacy/GPULegacyDrawable.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDrawable.h.
platform/graphics/gpu/legacy/GPULegacyEnums.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyEnums.h.
platform/graphics/gpu/legacy/GPULegacyFunction.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyFunction.cpp.

(WebCore::GPULegacyFunction::~GPULegacyFunction):

platform/graphics/gpu/legacy/GPULegacyFunction.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyFunction.h.

(WebCore::GPULegacyFunction::metal const):

platform/graphics/gpu/legacy/GPULegacyLibrary.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyLibrary.cpp.

(WebCore::GPULegacyLibrary::~GPULegacyLibrary):

platform/graphics/gpu/legacy/GPULegacyLibrary.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyLibrary.h.

(WebCore::GPULegacyLibrary::metal const):

platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderCommandEncoder.cpp.

(WebCore::GPULegacyRenderCommandEncoder::~GPULegacyRenderCommandEncoder):

platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderCommandEncoder.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassAttachmentDescriptor::~GPULegacyRenderPassAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassColorAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::~GPULegacyRenderPassColorAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassColorAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDepthAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::~GPULegacyRenderPassDepthAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDepthAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDescriptor.cpp.

(WebCore::GPULegacyRenderPassDescriptor::~GPULegacyRenderPassDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineColorAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::~GPULegacyRenderPipelineColorAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineColorAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineDescriptor.cpp.

(WebCore::GPULegacyRenderPipelineDescriptor::~GPULegacyRenderPipelineDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineState.cpp.

(WebCore::GPULegacyRenderPipelineState::~GPULegacyRenderPipelineState):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineState.h.
platform/graphics/gpu/legacy/GPULegacySize.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacySize.h.
platform/graphics/gpu/legacy/GPULegacyTexture.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTexture.cpp.

(WebCore::GPULegacyTexture::~GPULegacyTexture):

platform/graphics/gpu/legacy/GPULegacyTexture.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTexture.h.
platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTextureDescriptor.cpp.

(WebCore::GPULegacyTextureDescriptor::~GPULegacyTextureDescriptor):

platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTextureDescriptor.h.
platform/graphics/gpu/legacy/cocoa/GPULegacyBufferMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyBufferMetal.mm.

(WebCore::GPULegacyBuffer::GPULegacyBuffer):

platform/graphics/gpu/legacy/cocoa/GPULegacyCommandBufferMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyCommandBufferMetal.mm.

(WebCore::GPULegacyCommandBuffer::GPULegacyCommandBuffer):
(WebCore::GPULegacyCommandBuffer::presentDrawable const):
(WebCore::GPULegacyCommandBuffer::commit const):

platform/graphics/gpu/legacy/cocoa/GPULegacyCommandQueueMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyCommandQueueMetal.mm.

(WebCore::GPULegacyCommandQueue::GPULegacyCommandQueue):
(WebCore::GPULegacyCommandQueue::label const):
(WebCore::GPULegacyCommandQueue::setLabel const):

platform/graphics/gpu/legacy/cocoa/GPULegacyComputeCommandEncoderMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyComputeCommandEncoderMetal.mm.

(WebCore::MTLSizeMake):
(WebCore::GPULegacyComputeCommandEncoder::GPULegacyComputeCommandEncoder):
(WebCore::GPULegacyComputeCommandEncoder::setComputePipelineState const):
(WebCore::GPULegacyComputeCommandEncoder::setBuffer const):
(WebCore::GPULegacyComputeCommandEncoder::dispatch const):
(WebCore::GPULegacyComputeCommandEncoder::endEncoding const):

platform/graphics/gpu/legacy/cocoa/GPULegacyComputePipelineStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyComputePipelineStateMetal.mm.

(WebCore::GPULegacyComputePipelineState::GPULegacyComputePipelineState):

platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilDescriptorMetal.mm.

(WebCore::GPULegacyDepthStencilDescriptor::GPULegacyDepthStencilDescriptor):
(WebCore::GPULegacyDepthStencilDescriptor::depthWriteEnabled const):
(WebCore::GPULegacyDepthStencilDescriptor::setDepthWriteEnabled const):
(WebCore::GPULegacyDepthStencilDescriptor::depthCompareFunction const):
(WebCore::GPULegacyDepthStencilDescriptor::setDepthCompareFunction const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilStateMetal.mm.

(WebCore::GPULegacyDepthStencilState::GPULegacyDepthStencilState):
(WebCore::GPULegacyDepthStencilState::label const):
(WebCore::GPULegacyDepthStencilState::setLabel const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDeviceMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDeviceMetal.mm.

(WebCore::GPULegacyDevice::GPULegacyDevice):
(WebCore::GPULegacyDevice::disconnect):
(WebCore::GPULegacyDevice::reshape const):
(WebCore::GPULegacyDevice::platformLayer const):
(WebCore::GPULegacyDevice::operator! const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDrawableMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDrawableMetal.mm.

(WebCore::GPULegacyDrawable::GPULegacyDrawable):
(WebCore::GPULegacyDrawable::release):
(WebCore::GPULegacyDrawable::metal const):
(WebCore::GPULegacyDrawable::texture const):

platform/graphics/gpu/legacy/cocoa/GPULegacyFunctionMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyFunctionMetal.mm.

(WebCore::GPULegacyFunction::GPULegacyFunction):
(WebCore::GPULegacyFunction::name const):
(WebCore::GPULegacyFunction::operator! const):

platform/graphics/gpu/legacy/cocoa/GPULegacyLibraryMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyLibraryMetal.mm.

(WebCore::GPULegacyLibrary::GPULegacyLibrary):
(WebCore::GPULegacyLibrary::label const):
(WebCore::GPULegacyLibrary::setLabel const):
(WebCore::GPULegacyLibrary::functionNames const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderCommandEncoderMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderCommandEncoderMetal.mm.

(WebCore::GPULegacyRenderCommandEncoder::GPULegacyRenderCommandEncoder):
(WebCore::GPULegacyRenderCommandEncoder::setRenderPipelineState const):
(WebCore::GPULegacyRenderCommandEncoder::setDepthStencilState const):
(WebCore::GPULegacyRenderCommandEncoder::setVertexBuffer const):
(WebCore::GPULegacyRenderCommandEncoder::setFragmentBuffer const):
(WebCore::GPULegacyRenderCommandEncoder::drawPrimitives const):
(WebCore::GPULegacyRenderCommandEncoder::endEncoding const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassAttachmentDescriptor::GPULegacyRenderPassAttachmentDescriptor):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::loadAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setLoadAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::storeAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setStoreAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setTexture const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassColorAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassColorAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::GPULegacyRenderPassColorAttachmentDescriptor):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::clearColor const):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::setClearColor const):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDepthAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassDepthAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::GPULegacyRenderPassDepthAttachmentDescriptor):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::clearDepth const):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::setClearDepth const):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassDescriptor::GPULegacyRenderPassDescriptor):
(WebCore::GPULegacyRenderPassDescriptor::colorAttachments const):
(WebCore::GPULegacyRenderPassDescriptor::depthAttachment const):
(WebCore::GPULegacyRenderPassDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineColorAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineColorAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::GPULegacyRenderPipelineColorAttachmentDescriptor):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::pixelFormat const):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::setPixelFormat const):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineDescriptorMetal.mm.

(WebCore::GPULegacyRenderPipelineDescriptor::GPULegacyRenderPipelineDescriptor):
(WebCore::GPULegacyRenderPipelineDescriptor::depthAttachmentPixelFormat const):
(WebCore::GPULegacyRenderPipelineDescriptor::setDepthAttachmentPixelFormat const):
(WebCore::GPULegacyRenderPipelineDescriptor::setVertexFunction const):
(WebCore::GPULegacyRenderPipelineDescriptor::setFragmentFunction const):
(WebCore::GPULegacyRenderPipelineDescriptor::colorAttachments const):
(WebCore::GPULegacyRenderPipelineDescriptor::reset const):
(WebCore::GPULegacyRenderPipelineDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineStateMetal.mm.

(WebCore::GPULegacyRenderPipelineState::GPULegacyRenderPipelineState):
(WebCore::GPULegacyRenderPipelineState::label const):
(WebCore::GPULegacyRenderPipelineState::setLabel const):
(WebCore::GPULegacyRenderPipelineState::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyTextureDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm.

(WebCore::GPULegacyTextureDescriptor::GPULegacyTextureDescriptor):
(WebCore::GPULegacyTextureDescriptor::width const):
(WebCore::GPULegacyTextureDescriptor::setWidth const):
(WebCore::GPULegacyTextureDescriptor::height const):
(WebCore::GPULegacyTextureDescriptor::setHeight const):
(WebCore::GPULegacyTextureDescriptor::sampleCount const):
(WebCore::GPULegacyTextureDescriptor::setSampleCount const):
(WebCore::GPULegacyTextureDescriptor::textureType const):
(WebCore::GPULegacyTextureDescriptor::setTextureType const):
(WebCore::GPULegacyTextureDescriptor::storageMode const):
(WebCore::GPULegacyTextureDescriptor::setStorageMode const):
(WebCore::GPULegacyTextureDescriptor::usage const):
(WebCore::GPULegacyTextureDescriptor::setUsage const):
(WebCore::GPULegacyTextureDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyTextureMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyTextureMetal.mm.

(WebCore::GPULegacyTexture::GPULegacyTexture):
(WebCore::GPULegacyTexture::width const):
(WebCore::GPULegacyTexture::height const):
(WebCore::GPULegacyTexture::metal const):

8:52 AM Changeset in webkit [238418] by Michael Catanzaro

2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

[FreeType] Problem under WebCore::FontPlatformData::FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=191595

Unofficially reviewed stable branch commit.

Blacklist cairo 1.15 and 1.16.0 when setting FreeType memory allocation functions. These
broken versions of cairo free memory allocated by FreeType with system free. We can avoid
trouble by using the system allocator instead of bmalloc.

platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::initializeFreeTypeLibrary):

8:37 AM Changeset in webkit [238417] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore

[SOUP] Certificate decoder always returns GByteArray with zero size
https://bugs.webkit.org/show_bug.cgi?id=191888

Reviewed by Žan Doberšek.

No new tests needed.

platform/network/soup/CertificateInfo.h:

(WTF::Persistence::Coder<GRefPtr<GByteArray>>::decode): Add missing
call to g_byte_array_set_size() to make sure byteArray->len has the
correct value.

7:59 AM WikiStart edited by cadubentzen@gmail.com

list remote inspector for WebKitGTK+ and WPE (diff)

7:58 AM RemoteInspectorGTKandWPE created by cadubentzen@gmail.com

Add Remote Inspector page for WebKitGTK+ and WPE

7:53 AM Changeset in webkit [238416] by aboya@igalia.com

2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=191887

platform/gtk/TestExpectations:

7:41 AM Changeset in webkit [238415] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Take nonBreakableStart/End into use.
https://bugs.webkit.org/show_bug.cgi?id=191873

Reviewed by Antti Koivisto.

Source/WebCore:

Offset the final inline runs with the nonBreakableStart/End values.
(This patch also fixes relative positioned run verification.)

Test: fast/inline/inline-content-with-padding-left-right.html

layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-padding-left-right-expected.txt: Added.
fast/inline/inline-content-with-padding-left-right.html: Added.

3:03 AM Changeset in webkit [238414] by dinfuehr@igalia.com

31 edits in trunk

Enable JIT on ARM/Linux
https://bugs.webkit.org/show_bug.cgi?id=191548

Reviewed by Yusuke Suzuki.

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

Source/cmake/WebKitFeatures.cmake:

JSTests:

Disable test on system with limited memory. Program was killed by
the OS before the exception was thrown.

slowMicrobenchmarks/function-constructor-with-huge-strings.js:

Source/bmalloc:

bmalloc/IsoPageInlines.h:

(bmalloc::IsoPage<Config>::startAllocating):

Source/JavaScriptCore:

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getICStatusMap):

bytecode/CodeBlock.h:

(JSC::CodeBlock::metadata):

bytecode/InByIdStatus.cpp:

(JSC::InByIdStatus::computeFor):

bytecode/Instruction.h:

(JSC::Instruction::cast):

bytecode/MetadataTable.h:

(JSC::MetadataTable::forEach):

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::hasExitSite): Deleted.

bytecode/PutByIdStatus.h:
dfg/DFGOSRExit.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

generator/Argument.rb:
generator/Opcode.rb:
jit/GPRInfo.h:
jit/JIT.h:
jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_forward_arguments):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileSetupVarargsFrame): Deleted.

jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):
(JSC::JIT::emitSlow_op_loop_hint):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_instanceof_custom):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emit_op_is_empty):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_cell_with_type):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_set_function_name):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::emitSlow_op_jeq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::emitSlow_op_jneq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_stricteq):
(JSC::JIT::emit_op_nstricteq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emit_op_jstricteq):
(JSC::JIT::emit_op_jnstricteq):
(JSC::JIT::emitSlow_op_jstricteq):
(JSC::JIT::emitSlow_op_jnstricteq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_to_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_identity_with_profile):
(JSC::JIT::emit_op_get_parent_scope):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_get_scope):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_check_tdz):
(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::privateCompileHasIndexedProperty):
(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emit_op_enumerator_structure_pname):
(JSC::JIT::emit_op_enumerator_generic_pname):
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val_direct):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::emit_op_get_from_arguments):
(JSC::JIT::emit_op_put_to_arguments):

jit/RegisterSet.cpp:

(JSC::RegisterSet::vmCalleeSaveRegisters):

llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

llint/LowLevelInterpreter.asm:
runtime/SamplingProfiler.cpp:

(JSC::tryGetBytecodeIndex):

Source/WTF:

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

wtf/Platform.h:

1:11 AM Changeset in webkit [238413] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
https://bugs.webkit.org/show_bug.cgi?id=191630

Reviewed by Michael Catanzaro.

Only flip Y in GlyphToPathTranslator for ports using CG.

platform/graphics/FontCascade.cpp:

(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

12:49 AM Changeset in webkit [238412] by aboya@igalia.com

5 edits in trunk/Source/WebCore

[MSE][GStreamer] Refactor AppendPipeline deinitialization
https://bugs.webkit.org/show_bug.cgi?id=191759

Reviewed by Xabier Rodriguez-Calvar.

AppendPipeline currently has a method, clearPlayerPrivate(), that the
client code uses to deinitialize most of the AppendPipeline... just
before actually destructing it in the next line of code.

Since at that point there should not be alive RefPtr's pointing to the
AppendPipeline there is no need for this kind of pre-deinitialization
in this usage pattern. Instead, we can just rely on C++ destructors,
cleaning the code a bit and removing the potential for the question
"what if clearPlayerPrivate() has been called before?": it has not.

Assertions have been added to ensure that there is only one alive
RefPtr pointing to AppendPipeline, therefore guaranteeing its immediate
destruction.

platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::deinitialize):
(WebCore::AppendPipeline::clearPlayerPrivate): Deleted.

platform/graphics/gstreamer/mse/AppendPipeline.h:
platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):

platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::removedFromMediaSource):

Nov 20, 2018:

9:15 PM Changeset in webkit [238411] by sbarati@apple.com

3 edits
1 add in trunk

Merging an IC variant may lead to the IC status containing overlapping structure sets
https://bugs.webkit.org/show_bug.cgi?id=191869
<rdar://problem/45403453>

Reviewed by Mark Lam.

JSTests:

stress/merging-ic-variants-should-bail-if-structures-overlap.js: Added.

Source/JavaScriptCore:

When merging two IC variant lists, we may end up in a world where we have
overlapping structure sets. We defend against this when we append a new
variant, but we should also defend against it once we merge in a new variant.

Consider this case with MultiPutByOffset, where we merge two PutByIdStatuses
together, P1 and P2.

Let's consider these structures:
s1 = {}
s2 = {p: 0}
s3 = {p: 0, p2: 1}

P1 contains these variants:
Transition: [s1 => s2]
Replace: [s2, s3]

P2 contains:
Replace: [s2]

Because of the ordering of the variants, we may end up combining
P2's replace into P1's transition, forming this new list:
Transition: [(s1, s2) => s2]
Replace: [s2, s3]

Obviously the ideal thing here is to have some ordering when we merge
in variants to choose the most ideal option. It'd be ideal for P2's
Replace to be merged into P1's replace.

If we notice that this is super important, we can implement some kind
of ordering. None of our tests (until this patch) stress this. This patch
just makes it so we defend against this crazy scenario by falling back
to the slow path gracefully. This prevents us from emitting invalid
IR in FTL->B3 lowering by creating a switch with two case labels being
identical values.

bytecode/ICStatusUtils.h:

(JSC::appendICStatusVariant):

5:02 PM Changeset in webkit [238410] by dino@apple.com

2 edits in trunk/Source/WebCore

Removing using namespace WebCore from WebLayer
https://bugs.webkit.org/show_bug.cgi?id=191870
<rdar://problem/46192206>

Rubber-stamped by Sam Weinig.

Remove "using namespace WebCore" from WebLayer.mm
because it will cause type clashes in unified source
builds.

platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplay]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):
(-[WebSimpleLayer display]):
(-[WebSimpleLayer drawInContext:]):

4:12 PM Changeset in webkit [238409] by rniwa@webkit.org

4 edits
2 adds in trunk

Input element gains focus when a selectstart event listener on document prevents the default action
https://bugs.webkit.org/show_bug.cgi?id=191714
<rdar://problem/46174389>

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by WebKit keep firing selectstart upon mousemove after the drag had already started
when preventDefault had been called in the previous firings of selectstart event. Because input element
has its own editable element and fires selectstart on the input element itself, which won't be prevented
by selectstart on docuemnt, this allowed the selection to be set inside the input element even though
the mouse cursor was simply passing over the input element after the drag had already started.

Fixed the bug by not firing selectstart if the default action had been prevented by the initial firing
of selectstart by setting m_mouseDownMayStartDrag to false. This also matches the behaviors of Chrome
and Firefox.

Test: fast/events/selectstart-prevent-default-should-not-focus-input.html

page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Added a regression test.

fast/events/selectstart-prevent-default-should-not-focus-input-expected.txt: Added.
fast/events/selectstart-prevent-default-should-not-focus-input.html: Added.
platform/ios/TestExpectations:

3:46 PM Changeset in webkit [238408] by jeffm@apple.com

4 edits
1 add in trunk

Return nullptr immediately if the key doesn't exist in the HashMap.
https://bugs.webkit.org/show_bug.cgi?id=191841

Reviewed by Chris Dumez.
Source/WebKit:

Shared/API/APIDictionary.h:

Tools:

Add a test that would crash prior to the fix for this bug.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.

(TestWebKitAPI::TEST):

3:38 PM Changeset in webkit [238407] by Michael Catanzaro

3 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Segfaults on https://terminalizer.com/
https://bugs.webkit.org/show_bug.cgi?id=191805

Patch by Zan Dobersek <zdobersek@igalia.com> on 2018-11-20
Reviewed by Michael Catanzaro.

In HarfBuzzFace, the CacheEntry's HashMap object that caches Unicode
codepoints and their corresponding glyph indices should allow zero
values as valid keys since zero is a valid Unicode codepoint.

This change enables properly caching zero codepoints, avoiding
repetitive additions to the HashMap cache that end up in a crash.

platform/graphics/harfbuzz/HarfBuzzFace.h: Move the elongated

GlyphCache type alias to the public section of HarfBuzzFace class
declaration, making it reusable in the helper HarfBuzzFontData struct.

platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

2:09 PM Changeset in webkit [238406] by chris.reid@sony.com

6 edits
1 delete in trunk/Source/WebCore

Remove the need for LocalizedStringsWPE.cpp
https://bugs.webkit.org/show_bug.cgi?id=191854

Reviewed by Michael Catanzaro.

No change in behavior.

Consolidate "Search the Web" as the default search context menu text on non-COCOA ports.

GTK, WPE, and non-CF WIN all had the same default localizedString function
of String::fromUTF8. Move that to LocalizedString.cpp as the default implementation
for all ports not using CF.

en.lproj/Localizable.strings:
platform/LocalizedStrings.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/win/LocalizedStringsWin.cpp:
platform/wpe/LocalizedStringsWPE.cpp: Removed.

11:42 AM Changeset in webkit [238405] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Segfaults on https://terminalizer.com/
https://bugs.webkit.org/show_bug.cgi?id=191805

Patch by Zan Dobersek <zdobersek@igalia.com> on 2018-11-20
Reviewed by Michael Catanzaro.

In HarfBuzzFace, the CacheEntry's HashMap object that caches Unicode
codepoints and their corresponding glyph indices should allow zero
values as valid keys since zero is a valid Unicode codepoint.

This change enables properly caching zero codepoints, avoiding
repetitive additions to the HashMap cache that end up in a crash.

platform/graphics/harfbuzz/HarfBuzzFace.h: Move the elongated

GlyphCache type alias to the public section of HarfBuzzFace class
declaration, making it reusable in the helper HarfBuzzFontData struct.

platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

8:17 AM Changeset in webkit [238404] by Antti Koivisto

6 edits in trunk/Source/WebCore

Update hover state in composed tree
https://bugs.webkit.org/show_bug.cgi?id=191860

Reviewed by Zalan Bujtas.

The code was already mostly switched over from render tree to composed tree.
This patch replaces the remaining common ancestor search code with a DOM based equivalent.

dom/Document.cpp:

(WebCore::findNearestCommonComposedAncestor):
(WebCore::Document::updateHoverActiveState):
(WebCore::nearestCommonHoverAncestor): Deleted.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hoverAncestor const): Deleted.

rendering/RenderBlock.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::hoverAncestor const): Deleted.

No longer needed.

rendering/RenderElement.h:

7:56 AM Changeset in webkit [238403] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC][IFC] Measure run with non-breakable start/end.
https://bugs.webkit.org/show_bug.cgi?id=191850

Reviewed by Antti Koivisto.

Line breaking needs to know the complete width of the run including padding etc.

layout/Verification.cpp:

(WebCore::Layout::collectFlowBoxSubtree):
(WebCore::Layout::collectInlineBoxes):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::runWidth):

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::InlineLineBreaker):
(WebCore::Layout::InlineLineBreaker::runWidth const):
(WebCore::Layout::InlineLineBreaker::textWidth const):

layout/inlineformatting/InlineLineBreaker.h:
layout/inlineformatting/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::hyphenPositionBefore):
(WebCore::Layout::TextUtil::width):
(WebCore::Layout::TextUtil::fixedPitchWidth):
(WebCore::Layout::TextUtil::TextUtil): Deleted.
(WebCore::Layout::TextUtil::width const): Deleted.
(WebCore::Layout::TextUtil::hyphenPositionBefore const): Deleted.
(WebCore::Layout::TextUtil::textWidth const): Deleted.
(WebCore::Layout::TextUtil::fixedPitchWidth const): Deleted.

layout/inlineformatting/text/TextUtil.h:

7:53 AM Changeset in webkit [238402] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] InlineFormattingContext::Line should hold the list of runs for the current line.
https://bugs.webkit.org/show_bug.cgi?id=191845

Reviewed by Antti Koivisto.

Collect the runs in InlineFormattingContext::Line and transfer them to InlineFormattingState during line closing.
(In the most common cases, this is only one extra vector::append() call.)

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::createFinalRuns const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::InlineFormattingContext::splitInlineRunsIfNeeded const): Deleted.

layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Line::hasContent const):
(WebCore::Layout::InlineFormattingContext::Line::runs):

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):
(WebCore::Layout::InlineFormattingContext::Geometry::computeExpansionOpportunities):
(WebCore::Layout::InlineFormattingContext::Geometry::alignRuns):

layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::adjustLogicalLeft):
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight const):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):
(WebCore::Layout::InlineFormattingContext::Line::Line): Deleted.

7:52 AM Changeset in webkit [238401] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Introduce InlineItem::nonBreakableStart/End
https://bugs.webkit.org/show_bug.cgi?id=191839

Reviewed by Antti Koivisto.

Non-breakable start/end marks margin/padding/border space (even when it does not directly come from the associated layout box)

nested content with padding parent</span
<nested content with padding parent> <- inline run has 5px non-breakable start/end.

12 3
<1> <- inline run has 5px non-breakable start and 11px non-breakable end.
<2> <- inline run has 0px non-breakable start and 5px non-breakable end.
<3> <- no non-breakable values.

This is what the runs look like (input to line breaking)
< 1 2 >
< > (whitespace)
<3>
The line breaking treats the paddding/border etc space as part of the run and as non-breaking opportunity.
With the given runs the first position where we can break the line is at the whitespace.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::nonBreakableStart const):
(WebCore::Layout::InlineItem::nonBreakableEnd const):
(WebCore::Layout::InlineItem::addNonBreakableStart):
(WebCore::Layout::InlineItem::addNonBreakableEnd):

7:51 AM Changeset in webkit [238400] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] Move detaching rules from InlineFormattingState to InlineItem
https://bugs.webkit.org/show_bug.cgi?id=191838

Reviewed by Antti Koivisto.

This is in preparation for adding more context to InlineItem. In addition to
detaching rules it will also hold non-breakable start/end information.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::addDetachingRule): Deleted.
(WebCore::Layout::InlineFormattingState::detachingRules const): Deleted.

layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::setDetachingRules): Deleted.

layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::addDetachingRule):
(WebCore::Layout::InlineItem::detachingRules const):

7:48 AM Changeset in webkit [238399] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] InlineRunProvider::append() should just take const InlineItem&.
https://bugs.webkit.org/show_bug.cgi?id=191837

Reviewed by Antti Koivisto.

This allows us to remove the InlineFormattingState dependency as well.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

layout/inlineformatting/InlineRunProvider.cpp:

(WebCore::Layout::InlineRunProvider::InlineRunProvider):
(WebCore::Layout::InlineRunProvider::append):

layout/inlineformatting/InlineRunProvider.h:

7:35 AM Changeset in webkit [238398] by don.olmstead@sony.com

5 edits in trunk/Source/WebKit

WebPasteboard should USE(LIBWPE)
https://bugs.webkit.org/show_bug.cgi?id=191846

Reviewed by Michael Catanzaro.

Add USE(LIBWPE) for Pasteboard related functionality within WebKit.

UIProcess/WebPasteboardProxy.h:
UIProcess/WebPasteboardProxy.messages.in:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:

7:32 AM Changeset in webkit [238397] by don.olmstead@sony.com

4 edits in trunk/Source/WebKit

[WPE] Fix some feature guards in WebKit
https://bugs.webkit.org/show_bug.cgi?id=191847

Reviewed by Michael Catanzaro.

Some feature guards are not present in these files.

UIProcess/API/wpe/PageClientImpl.cpp:
UIProcess/API/wpe/PageClientImpl.h:
UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

7:30 AM Changeset in webkit [238396] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] Enhance debugging by making sure to print the pipeline in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=191586

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-20
Reviewed by Xabier Rodriguez-Calvar.

This is minor changes that do not require tests.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::commitLoad):
(WebCore::MediaPlayerPrivateGStreamer::readyTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::durationMediaTime const):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::paused const):
(WebCore::MediaPlayerPrivateGStreamer::enableTrack):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::maxMediaTimeSeekable const):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes const):
(WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback):
(WebCore::MediaPlayerPrivateGStreamer::downloadBufferFileCreatedCallback):
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
(WebCore::MediaPlayerPrivateGStreamer::setDownloadBuffering):
(WebCore::MediaPlayerPrivateGStreamer::setPreload):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

3:58 AM Changeset in webkit [238395] by Manuel Rego Casasnovas

4 edits
6 adds in trunk

[css-grid] Consider scrollbars in populateGridPositionsForDirection()
https://bugs.webkit.org/show_bug.cgi?id=191656

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Imported tests from WPT.

web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html: Added.
web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html: Added.
web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html: Added.
web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html: Added.
web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html: Added.
web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html: Added.
web-platform-tests/css/css-grid/grid-model/w3c-import.log:

Source/WebCore:

We never care about scrollbars in RenderGrid::populateGridPositionsForDirection(),
that's fine if the scrollbars are at the end (e.g. on the right in horizontal writing mode and LTR direction)
but it causes problems when they're at the beginning (e.g. on the left in horizontal writing mode and RTL direction).

The patch modifies the method so it takes into account scrollbar size
in order to compute the position of the columns/rows depending on the direction and the writing mode.

Tests: imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html

imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::populateGridPositionsForDirection):

1:02 AM Changeset in webkit [238394] by Antti Koivisto

3 edits in trunk/Source/WebKit

Avoid potential longer than expected layer flush delays
https://bugs.webkit.org/show_bug.cgi?id=191833

Reviewed by Dean Jackson.

Layer flush throttling also stops style recalcs and layouts. Layouts schedule layer flushes. Especially
on a slow network we can in principle end up in situation where layer flush timer fires but there is no
flush scheduled and so nothing happens. However there is a pending style recalc or layout that would
actually schedule a flush (in practice various things force style recalcs and this doesn't occur
commonly).

To avoid this we should flush unconditionally when the flush timer fires. This performs any pending
style recalc and layout too. If there is nothing to do the flush will be cheap.

PLT doesn't appear to hit cases affected by this patch and there shouldn't be any impact.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Remove now unnecessary m_hasPendingFlush bit, simplifying the logic.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):

Schedule unconditionally when unfreezing.

(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):

Remove branch that starts the flush timer. It is not needed as either it was already running
or immediate flush is already scheduled and will start the timer anyway.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::adjustLayerFlushThrottling):
(WebKit::TiledCoreAnimationDrawingArea::layerFlushThrottlingTimerFired):

Flush unconditionally.

12:53 AM Changeset in webkit [238393] by rniwa@webkit.org

3 edits
2 adds in trunk

Click on node assigned to slot in button's shadow cause loss of button focus
https://bugs.webkit.org/show_bug.cgi?id=191694
<rdar://problem/46107920>

Reviewed by Wenson Hsieh.

Source/WebCore:

Fixed the bug by traversing the parent in the composed tree when looking for an element to focus.

Test: fast/shadow-dom/focus-slot-parent.html

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Fixed the bug. Also use RefPtr instead of a raw pointer.

LayoutTests:

Added a regression test.

fast/shadow-dom/focus-slot-parent-expected.txt: Added.
fast/shadow-dom/focus-slot-parent.html: Added.

12:15 AM Changeset in webkit [238392] by Fujii Hironori

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=191626
<rdar://problem/46161064>

Context Navigation

Timeline

Nov 21, 2018:

Nov 20, 2018:

Download in other formats: