Context Navigation

← Previous Period
Next Period →

Timeline

Nov 29, 2018:

11:22 PM Changeset in webkit [238728] by Wenson Hsieh

10 edits in trunk

REGRESSION (r238635): Dragging a text selection within WKWebView causes the selection highlight to get into a bad state
https://bugs.webkit.org/show_bug.cgi?id=192165
<rdar://problem/46346682>

Reviewed by Daniel Bates.

Source/WebKit:

Fixes a bug in PageClientImpl::isViewFocused. Consider the following scenario:

WKWebView is hosted within the view hierarchy
First responder is *not* WKContentView
The active focus retain count is nonzero

Before r238635, we would return true, due to condition (3). However, after r238635, we only consider whether the
first responder is WKContentView, since the web view is in the view hierarchy. This breaks scenarios where
WebKit or UIKit attempts to retain focus and later restore the content view to be the first responder (an
example of this is dragging a text selection between editable elements in the same web view).

To fix this, simply bail early and return true if focus is being retained.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewFocused):

Tools:

Fixes 11 API tests that started failing or timing out after r238635. See below for more details.

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::webViewForEditActionTestingWithPageNamed):

Ensure that the web view becomes first responder before executing edit actions.

TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
TestWebKitAPI/Tests/WebKitCocoa/contenteditable-and-textarea.html:

Tweak these tests to allow selected content to overflow the width of the web view. Without this change,
ContentEditableToContentEditable and ContentEditableToTextarea will sometimes fail because the content causes
the body to scroll horizontally, so we miss the drop destination.

TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(loadTestPageAndEnsureInputSession):

Add a new helper to load a test page with a given name, become first responder, and wait until an input session
starts. Use this in various drag and drop tests to reduce code duplication.

TestWebKitAPI/cocoa/DragAndDropSimulator.h:
TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:

(-[DragAndDropSimulator initWithWebView:]):
(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
(-[DragAndDropSimulator _advanceProgress]):

To more accurately emulate UIKit behavior, begin focus preservation when starting a drag, and attempt to clear
the focus preservation token when the drag session ends. This allows us to simulate and test the scenario that
regressed with r238635.

(-[DragAndDropSimulator ensureInputSession]):
(-[DragAndDropSimulator _webView:didStartInputSession:]):
(-[DragAndDropSimulator waitForInputSession]): Deleted.

Refactored into -ensureInputSession. Instead of assuming that an input session has not yet been started, simply
wait for an input session to start if needed.

TestWebKitAPI/ios/UIKitSPI.h:

Add a new SPI declaration.

10:35 PM Changeset in webkit [238727] by commit-queue@webkit.org

14 edits in trunk

Separate paint and scroll offsets for RenderLayerBacking::m_scrollingContentsLayer
https://bugs.webkit.org/show_bug.cgi?id=183040

Source/WebCore:

Currently, scroll offset of RenderLayerBacking::m_scrollingContentsLayer is stored in the
GraphicsLayer::m_offsetFromRenderer member used for paint offset. This patch separates these
two concept by introducing a new GraphicsLayer::m_scrollOffset for the scroll offset. This
makes the API a little bit cleaner, the code easier to understand and might avoid unnecessary
repaints in composited scroll.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-29
Reviewed by Simon Fraser.

No new tests, already covered by existing tests.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setScrollOffset): Setter function to update the scroll offset
of the content layer inside its scrolling parent layer. Ask a repaint if it has changed and
is requested by the caller.
(WebCore::GraphicsLayer::paintGraphicsLayerContents): Take into account the scroll offset
when painting.
(WebCore::GraphicsLayer::dumpProperties const): Dump the scroll offset property.

platform/graphics/GraphicsLayer.h: Include ScrollableArea for the ScrollOffset typedef.

Add member for the scroll offset of the content layer inside its scrolling parent layer.
(WebCore::GraphicsLayer::scrollOffset const): Getter function.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry): Do not include the scroll offset in the
paint offset of m_scrollingContentsLayer since it is now taken into account in
paintGraphicsLayerContents. Update the scroll offset of m_scrollingContentsLayer separately.
Leave the paint offset of m_foregroundLayer unchanged.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Take into account the scroll
offset of m_scrollingContentsLayer when calculating the dirty rect.

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-29
Reviewed by Simon Fraser.

Update expectations containing layer trees of RenderLayerBacking::m_scrollingContentsLayer, to separate offsetFromRenderer and
scrollOffset. We have OLD offsetFromRenderer = NEW offsetFromRenderer - scrollOffset.

compositing/ios/overflow-scroll-touch-tiles-expected.txt:
fast/scrolling/ios/overflow-scroll-touch-expected.txt:
fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt:
platform/ios/compositing/overflow/scrolling-without-painting-expected.txt:
platform/ios/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/ios/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt:
platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt:
platform/ios/fast/scrolling/ios/textarea-scroll-touch-expected.txt:

10:31 PM Changeset in webkit [238726] by timothy_horton@apple.com

13 edits
1 copy in trunk

Inform clients when editable image attachment backing data changes
https://bugs.webkit.org/show_bug.cgi?id=192206
<rdar://problem/46350277>

Reviewed by Wenson Hsieh.

Source/WebKit:

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::invalidateGeneratedFileWrapper):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didInvalidateDataForAttachment:]):

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/Cocoa/PageClientImplCocoa.h:
UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::didInvalidateDataForAttachment):

UIProcess/PageClient.h:

(WebKit::PageClient::didInvalidateDataForAttachment):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didInvalidateDataForAttachment):

UIProcess/WebPageProxy.h:

Plumb file-wrapper-invalidation through from APIAttachment to WKUIDelegate.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[AttachmentUpdateObserver init]):
(-[AttachmentUpdateObserver dataInvalidated]):
(-[AttachmentUpdateObserver _webView:didInvalidateDataForAttachment:]):
(TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentInvalidation):
(webViewForTestingAttachments):
(TestWebKitAPI::forEachViewInHierarchy):
(TestWebKitAPI::findEditableImageCanvas):
(TestWebKitAPI::drawSquareInEditableImage):
(TestWebKitAPI::TEST):

TestWebKitAPI/ios/PencilKitTestSPI.h: Added.

Add a test ensuring that we get an invalidation callback when an editable image is changed.

7:47 PM Changeset in webkit [238725] by Simon Fraser

3 edits
2 adds in trunk

Overflow scrolling layers need to be self-painting
https://bugs.webkit.org/show_bug.cgi?id=192201

Reviewed by Dean Jackson.
Source/WebCore:

Overflow scrolling layers paint their contents, so need to be self-painting in the RenderLayer sense.

Without this change, the overflow in the testcase doesn't get any compositing layers.

Test: compositing/scrolling/overflow-scrolling-layers-are-self-painting.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

LayoutTests:

compositing/scrolling/overflow-scrolling-layers-are-self-painting-expected.txt: Added.
compositing/scrolling/overflow-scrolling-layers-are-self-painting.html: Added.

7:15 PM Changeset in webkit [238724] by eric.carlson@apple.com

8 edits in trunk

[MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents
https://bugs.webkit.org/show_bug.cgi?id=192182

Reviewed by Youenn Fablet.

Source/WebKit:

UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::deviceIdHashSaltForOrigin): Key off of request and top
level documents.
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins): Ditto.

UIProcess/DeviceIdHashSaltStorage.h:

(WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin::HashSaltForOrigin):

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Pass both documents.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.

LayoutTests:

http/tests/media/media-stream/enumerate-devices-source-id-expected.txt:
http/tests/media/media-stream/enumerate-devices-source-id.html:
http/tests/media/media-stream/resources/enumerate-devices-source-id-frame.html:

6:16 PM Changeset in webkit [238723] by chris.reid@sony.com

4 edits in trunk

[Win] listDirectory in FileSystemWin.cpp should not skip all directories
https://bugs.webkit.org/show_bug.cgi?id=192042

Reviewed by Fujii Hironori.

Source/WebCore:

Covered by existing tests.

listDirectory is not returning any child directories which is causing
ASSERT(diskUsage >= databaseFileSize) in SQLiteIDBBackingStore.cpp to fail.

Change listDirectory in FileSystemWin to match FileSystemPOSIX's behavior.
listDirectory should only skip the current and previous directories.

platform/win/FileSystemWin.cpp:

LayoutTests:

Enable storage tests on WinCairo and adding initial test expectations.

platform/wincairo/TestExpectations:

5:50 PM Changeset in webkit [238722] by Ryan Haddad

15 edits
2 deletes in trunk/Source

Unreviewed, rolling out r238713.

Breaks internal builds.

Reverted changeset:

"[Cocoa] Add some WKA extension points"
https://bugs.webkit.org/show_bug.cgi?id=192131
https://trac.webkit.org/changeset/238713

5:45 PM Changeset in webkit [238721] by Kocsen Chung

2 edits in tags/Safari-607.1.15.1/Source/WebKit

Cherry-pick r238712. rdar://problem/46360649

Try to fix the build.

Platform/spi/ios/PencilKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:32 PM Changeset in webkit [238720] by Ryan Haddad

6 edits in trunk

Unreviewed, rolling out r238680.

Caused existing webrtc layout tests to fail an assertion.

Reverted changeset:

"A sender created through addTransceiver and populated using
addTrack should have its source set"
https://bugs.webkit.org/show_bug.cgi?id=192136
https://trac.webkit.org/changeset/238680

5:22 PM Changeset in webkit [238719] by Fujii Hironori

2 edits in trunk/Tools

REGRESSION(r238445)[Buildbot] Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
https://bugs.webkit.org/show_bug.cgi?id=192143

Reviewed by Philippe Normand.

Buildbot can't start since r238445.

Configuration Errors:

Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
Unknown builder 'GTK Linux ARM Release' in scheduler 'trunk'

BuildSlaveSupport/build.webkit.org-config/config.json: Removed deprecated builders.

5:19 PM Changeset in webkit [238718] by Justin Fan

2 edits in trunk/Source/WebCore

Remove dangling WebGPU file references from WebCore project
https://bugs.webkit.org/show_bug.cgi?id=192185

Unreviewed project file gardening.

No new tests.

WebCore.xcodeproj/project.pbxproj:

5:02 PM Changeset in webkit [238717] by Keith Rollin

2 edits in trunk/Source/WebCore

Unreviewed build fix.

r238637 introduced some DerivedSources.make changes that could produce
some invalid .idl files, leading to IDLParser.pm error messages.

DerivedSources.make:

4:59 PM Changeset in webkit [238716] by Kocsen Chung

7 edits in tags/Safari-607.1.15.1/Source

Versioning.

4:55 PM Changeset in webkit [238715] by Simon Fraser

8 edits in trunk/Source

Add an internal feature flag to enable async overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=192184

Reviewed by Tim Horton.

Add a new internal feature flag that will enable async overflow-scrolling for
most overflow:scroll elements. Defaults to off.
Source/WebCore:

Make the "UseAcceleratedTouchScrolling" terminology in RenderLayer etc be more generic,
and refer to async overflow scrolling.

page/Settings.yaml:
rendering/RenderLayer.cpp:

(WebCore::canCreateStackingContext): Remove a line which is not necessary, since -webkit-overflow-scrolling: touch
already triggers non-auto z-index via code in StyleResolver::adjustRenderStyle().
(WebCore::RenderLayer::canUseCompositedScrolling const):
(WebCore::RenderLayer::hasCompositedScrollableOverflow const):
(WebCore::RenderLayer::handleTouchEvent):
(WebCore::RenderLayer::usesAsyncScrolling const):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::showsOverflowControls const):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::canUseAcceleratedTouchScrolling const): Deleted.
(WebCore::RenderLayer::hasTouchScrollableOverflow const): Deleted.

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
(WebCore::RenderLayerCompositor::isAsyncScrollableStickyLayer const):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):

Source/WebKit:

Shared/WebPreferences.yaml:

4:54 PM Changeset in webkit [238714] by Kocsen Chung

1 copy in tags/Safari-607.1.15.1

New tag.

4:50 PM Changeset in webkit [238713] by aestes@apple.com

15 edits
2 adds in trunk/Source

[Cocoa] Add some WKA extension points
https://bugs.webkit.org/show_bug.cgi?id=192131
<rdar://problem/46330293>

Reviewed by Tim Horton.

Source/WebCore:

DerivedSources.make: Added an extension point for derived sources.
Modules/applepay/PaymentCoordinatorClient.h: Added an extension point for

PaymentCoordinatorClient.

SourcesCocoa.txt: Added WebCoreAdditions.mm as a non-unified source.
WebCore.xcodeproj/project.pbxproj: Added WebCoreAdditions.mm.
bindings/js/WebCoreBuiltinNames.h: Added an extension point for built-in names.
page/SettingsBase.h: Added an extension point for settings.
platform/cocoa/WebCoreAdditions.mm: Added.

Source/WebKit:

DerivedSources.make: Added an extension point for WebPreferences.yaml.
Platform/IPC/MessageSender.h:

(IPC::MessageSender::sendWithAsyncReply): Send async messages via IPC::MessageSender.

Platform/cocoa/WebKitAdditions.mm: A an extension point for additional WebKit sources.
SourcesCocoa.txt: Added WebKitAdditions.mm as non-unified source.
UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy): Called finishConstruction.

UIProcess/ApplePay/WebPaymentCoordinatorProxy.h: Added an extension point for

WebPaymentCoordinatorProxy.

WebKit.xcodeproj/project.pbxproj: Added WebKitAdditions.mm.
WebProcess/ApplePay/WebPaymentCoordinator.h: Added an extension point for

WebPaymentCoordinator.

4:45 PM Changeset in webkit [238712] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the build.

Platform/spi/ios/PencilKitSPI.h:

4:39 PM Changeset in webkit [238711] by Matt Baker

7 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: disclosure triangles should be flipped and aligned right
https://bugs.webkit.org/show_bug.cgi?id=192089
<rdar://problem/46316753>

Reviewed by Devin Rousso.

UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .computed-property-item .disclosure-button):
(body[dir=rtl] .computed-style-section .computed-property-item .disclosure-button):

UserInterface/Views/ConsoleMessageView.css:

(.console-message.expandable .console-top-level-message::before):
(body[dir=rtl] .console-message.expandable .console-top-level-message::before):

UserInterface/Views/ErrorObjectView.css:

(.error-object > .formatted-error::before):
(body[dir=rtl] .error-object > .formatted-error::before):
(.error-object .content):

UserInterface/Views/LogContentView.css:

(.console-group-title::before):
(body[dir=ltr] .console-group-title::before):
(body[dir=rtl] .console-group-title::before):

UserInterface/Views/ObjectTreeView.css:

(body[dir=rtl] .object-tree > :matches(.title, .object-preview)::before):

UserInterface/Views/TypeTreeElement.css:

(body[dir=rtl] .item.type-tree-element.parent > .disclosure-button):

4:38 PM Changeset in webkit [238710] by david_quesada@apple.com

22 edits
2 copies
2 adds in trunk

Add SPI to publish NSProgress on active downloads
https://bugs.webkit.org/show_bug.cgi?id=192021
rdar://problem/44405661

Reviewed by Alex Christensen.

Source/WebCore/PAL:

Add an SPI header for NSProgress's publishing and unpublishing methods. In older
SDKs, these methods are explicitly unavailable on platforms other than macOS,
with underscore-prefixed versions available as SPI. In newer SDKs, the unprefixed
versions are SPI and the prefixed versions are deprecated.

PAL.xcodeproj/project.pbxproj:
pal/spi/cocoa/NSProgressSPI.h:

Source/WebKit:

Make it possible for clients to allow other processes to monitor the state of active
downloads. On Cocoa platforms, this can be done by creating an NSProgress, publishing
it on an appropriate file URL (potentially a different file URL than where the download
data is being written), updating properties on it as the download makes progress, and
wiring up a cancellation handler that allows it to be remotely canceled. Interested
clients can then subscribe to progress on that URL and receive a proxy to the progress
that WebKit publishes.

NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::~Download):
(WebKit::Download::platformDestroyDownload):

Add a platform-customizable hook for destructing the Download. DownloadCocoa.mm
will interact with its Objective-C NSProgress instance at this point.

NetworkProcess/Downloads/Download.h:
NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::dataTaskBecameDownloadTask):

See comments for publishDownloadProgress().

(WebKit::DownloadManager::publishDownloadProgress):

If the provided downloadID corresponds to a non-Pending Download, hand the URL
and a matching sandbox extension to the Download so it can create its progress.
Otherwise, store the URL and sandbox extension on the PendingDownload to be used
later when the full Download is created. When this happens, dataTaskBecameDownloadTask()
will tell the PendingDownload about the Download it has become. The PendingDownload
will then relay the progress URL and sandbox extension to the Download.

NetworkProcess/Downloads/DownloadManager.h:
NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::publishProgress):

Store the progress info for later use, when the proper Download is created.

(WebKit::PendingDownload::didBecomeDownload):

If there was a progress URL provided earlier, tell the Download corresponding to this
PendingDownload to publish its progress using that URL.

NetworkProcess/Downloads/PendingDownload.h:
NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::platformDestroyDownload):

When the Download is destroyed (i.e. when the download succeeds, fails, or is canceled),
unpublish the progress, since there is no longer any activity to report.

(WebKit::Download::publishProgress):

Resolve the sandbox extension, create a progress configured to reflect the progress of
this Download's NSURLSessionDownloadTask, and publish it at the given file URL.

NetworkProcess/Downloads/cocoa/WKDownloadProgress.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h.
NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm: Added.

(-[WKDownloadProgress initWithDownloadTask:download:URL:sandboxExtension:]):

Configure this progress, start observing properties on the download task that this
progress will reflect, and connect the cancellation handler of the progress to cancel
the corresponding Download.

(-[WKDownloadProgress publish]):
(-[WKDownloadProgress unpublish]):

Override these methods to consume and revoke the sandbox extension to make sure the
process has access to the progress file while the progress will be published.

(-[WKDownloadProgress dealloc]):
(-[WKDownloadProgress observeValueForKeyPath:ofObject:change:context:]):

When either byte count (number received, or number expected to receive) of the download
task changes, update this progress to reflect that.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::publishDownloadProgress):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:

Allow looking up the services that manages published NSProgresses.

UIProcess/API/Cocoa/_WKDownload.h:
UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload publishProgressAtURL:]):

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::publishProgress):

UIProcess/Downloads/DownloadProxy.h:
WebKit.xcodeproj/project.pbxproj:

Tools:

Add API tests to exercise the progress-publishing functionality in a variety of scenarios.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Added.

(+[DownloadProgressTestProtocol registerProtocolForTestRunner:]):
(+[DownloadProgressTestProtocol unregisterProtocol]):
(+[DownloadProgressTestProtocol canInitWithRequest:]):
(+[DownloadProgressTestProtocol canonicalRequestForRequest:]):
(+[DownloadProgressTestProtocol requestIsCacheEquivalent:toRequest:]):
(-[DownloadProgressTestProtocol startLoading]):
(-[DownloadProgressTestProtocol stopLoading]):
(-[DownloadProgressTestRunner init]):
(-[DownloadProgressTestRunner startLoadingWithProtocol:]):
(-[DownloadProgressTestRunner tearDown]):
(-[DownloadProgressTestRunner _didGetProgress:]):
(-[DownloadProgressTestRunner _didLoseProgress]):
(-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
(-[DownloadProgressTestRunner waitToLoseProgress]):
(-[DownloadProgressTestRunner startDownload:expectedLength:]):
(-[DownloadProgressTestRunner publishProgress]):
(-[DownloadProgressTestRunner receiveData:]):
(-[DownloadProgressTestRunner finishDownloadTask]):
(-[DownloadProgressTestRunner failDownloadTask]):
(-[DownloadProgressTestRunner waitForDownloadDidCreateDestination]):
(-[DownloadProgressTestRunner waitForDownloadFinished]):
(-[DownloadProgressTestRunner waitForDownloadCanceled]):
(-[DownloadProgressTestRunner waitForDownloadFailed]):
(-[DownloadProgressTestRunner waitForUpdatedCompletedUnitCount]):
(-[DownloadProgressTestRunner observeValueForKeyPath:ofObject:change:context:]):
(-[DownloadProgressTestRunner webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[DownloadProgressTestRunner webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[DownloadProgressTestRunner _downloadDidStart:]):
(-[DownloadProgressTestRunner _download:didCreateDestination:]):
(-[DownloadProgressTestRunner _downloadDidFinish:]):
(-[DownloadProgressTestRunner _downloadDidCancel:]):
(-[DownloadProgressTestRunner _download:didFailWithError:]):
(-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
(TEST):

4:34 PM Changeset in webkit [238709] by Alan Coon

7 edits in branches/safari-606.4.1.2-branch/Source

Versioning.

4:32 PM Changeset in webkit [238708] by timothy_horton@apple.com

18 edits
4 adds in trunk/Source

Make drawing tools available when an editable image is focused
https://bugs.webkit.org/show_bug.cgi?id=192172
<rdar://problem/30337960>

Reviewed by Dean Jackson.

Platform/spi/ios/PencilKitSPI.h:

Add some more SPI.

Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode const):
(WebKit::AssistedNodeInformation::decode):

Shared/AssistedNodeInformation.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleStylusSingleTapAtPoint):
(WebKit::isAssistableElement):
(WebKit::WebPage::getAssistedNodeInformation):
Plumb the assisted node's embedded view ID, if available.
Also add a new input type for drawings, and use it when appropriate.

SourcesCocoa.txt:
UIProcess/API/Cocoa/_WKFocusedElementInfo.h:

Add WKInputTypeDrawing.

UIProcess/ios/PencilKitSoftLink.h: Added.
UIProcess/ios/PencilKitSoftLink.mm: Added.

Pull soft-linking out into its own file, to fix unified sources.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView requiresAccessoryView]):
Install a keyboard when a drawing is focused.
Also, deduplicate one "curretUserInterfaceIdiomIsPad"; just fall through.

(-[WKContentView inputView]):
Make a WKInkPickerControl when a drawing is focused.

(-[WKContentView textInputTraits]):
(isAssistableInputType):

UIProcess/ios/WKDrawingView.h:
UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
(-[WKDrawingView PNGRepresentation]):
(-[WKDrawingView loadDrawingFromPNGRepresentation:]):
Adopt PencilKitSoftLink.

(-[WKDrawingView canvasView]):
Expose the internal canvas view for use by WKInkPickerControl.

UIProcess/ios/WKInkPickerControl.h: Copied from Source/WebKit/Platform/spi/ios/PencilKitSPI.h.
UIProcess/ios/WKInkPickerControl.mm: Added.

(-[WKInkPickerView initWithFrame:drawingView:]):
(-[WKInkPickerView didPickInk]):
(-[WKInkPickerView inlineInkPickerDidToggleRuler:]):
(-[WKInkPickerView inlineInkPicker:didSelectTool:]):
(-[WKInkPickerView inlineInkPicker:didSelectColor:]):
(-[WKInkPickerView inkPickerSize]):
(-[WKInkPickerView layoutSubviews]):
(-[WKInkPickerView sizeThatFits:]):
(-[WKInkPickerView viewControllerForPopoverPresentationFromInlineInkPicker:]):
(-[WKInkPickerControl initWithDrawingView:]):
(-[WKInkPickerControl beginEditing]):
(-[WKInkPickerControl endEditing]):
(-[WKInkPickerControl assistantView]):
Install and hook up a PKInlineInkPicker.
Center it in the keyboard.
Plumb changes through to the canvas view.

WebKit.xcodeproj/project.pbxproj:

editing/Editor.cpp:

(WebCore::Editor::insertEditableImage):

editing/Editor.h:
editing/InsertEditableImageCommand.cpp:

(WebCore::InsertEditableImageCommand::insertEditableImage):
(WebCore::InsertEditableImageCommand::doApply):

editing/InsertEditableImageCommand.h:

Add InsertEditableImageCommand::insertEditableImage, which returns the
inserted image element.

html/HTMLImageElement.h:

Make HTMLImageElement focusable if it is editable.

4:28 PM Changeset in webkit [238707] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION (r238090): [ MacOS WK1 ] Layout Test imported/blink/compositing/squashing/squashing-into-ancestor-painted-layer.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191639

Unreviewed test gardening.

platform/mac-wk1/TestExpectations: Mark test as flaky.

4:03 PM Changeset in webkit [238706] by Alan Coon

7 edits in branches/safari-606-branch/Source

Versioning.

4:02 PM Changeset in webkit [238705] by Alan Coon

1 copy in tags/Safari-606.4.2

Tag Safari-606.4.2.

3:51 PM Changeset in webkit [238704] by ap@apple.com

2 edits in trunk/Tools

Exception in bot watcher's dashboard if a hidden platform in no longer configured for display
https://bugs.webkit.org/show_bug.cgi?id=185527

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(updateHiddenPlatforms):

3:28 PM Changeset in webkit [238703] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add logging for some sandbox entries.
https://bugs.webkit.org/show_bug.cgi?id=192126

Reviewed by Brent Fulgham.

Add logging for sandbox entries which are possibly not needed.

WebProcess/com.apple.WebProcess.sb.in:

3:27 PM Changeset in webkit [238702] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix _WKWebsiteDataStoreConfiguration. sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier SPI introduced in r235127
https://bugs.webkit.org/show_bug.cgi?id=192191

Reviewed by Andy Estes.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
When trying to adopt the new SPI and verify it worked, I found that the strings are not copied in one place where they should be.

3:23 PM Changeset in webkit [238701] by Alan Bujtas

7 edits
8 adds in trunk

[LFC][BFC][Quirk] Body and html height stretching.
https://bugs.webkit.org/show_bug.cgi?id=192154

Reviewed by Antti Koivisto.

Source/WebCore:

This patch takes the document box's margin/border/padding into account when stretching html/body to the height of the initial containing block.

Tests: fast/block/block-only/body-height-with-auto-html-height-quirk.html

fast/block/block-only/body-height-with-auto-html-height-quirk2.html
fast/block/block-only/body-height-with-non-auto-html-height-quirk.html
fast/block/block-only/body-height-with-non-auto-html-height-quirk2.html

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginBottom):

layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/block/block-only/body-height-with-auto-html-height-quirk-expected.txt: Added.
fast/block/block-only/body-height-with-auto-html-height-quirk.html: Added.
fast/block/block-only/body-height-with-auto-html-height-quirk2-expected.txt: Added.
fast/block/block-only/body-height-with-auto-html-height-quirk2.html: Added.
fast/block/block-only/body-height-with-non-auto-html-height-quirk-expected.txt: Added.
fast/block/block-only/body-height-with-non-auto-html-height-quirk.html: Added.
fast/block/block-only/body-height-with-non-auto-html-height-quirk2-expected.txt: Added.
fast/block/block-only/body-height-with-non-auto-html-height-quirk2.html: Added.

3:18 PM Changeset in webkit [238700] by Justin Fan

3 edits in trunk/Source/WebCore

[WebGPU] Replace forward declare of WebGPUCommandBuffer with include
https://bugs.webkit.org/show_bug.cgi?id=192179

Unreviewed build fix.

No new tests. No behavior change.

Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:
Modules/webgpu/WebGPUProgrammablePassEncoder.h:

3:08 PM Changeset in webkit [238699] by Alan Bujtas

2 edits in trunk/Source/WebCore

[ContentObservation] Make WKSetObservedContentChange logic more explicit.
https://bugs.webkit.org/show_bug.cgi?id=192183

Reviewed by Simon Fraser.

platform/ios/wak/WKContentObservation.cpp:

(WKSetObservedContentChange):
(WebThreadRemoveObservedDOMTimer):

3:06 PM Changeset in webkit [238698] by youenn@apple.com

23 edits
7 adds in trunk

CSS subresource loads should not be observable from resource timing if the stylesheet is opaque
https://bugs.webkit.org/show_bug.cgi?id=192132

Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce a new ResourceLoaderOptions to determine whether a load is made from a resource that is opaque.
Make use of that option to disable exposing such loads to the web page through resource timing.
The same option might later be used to bypass service workers.

Make use of this option for CSS subresource loads.
When the CSS stylesheet is opaque for the page, set this option.

Test: http/tests/security/clean-origin-exposed-resource-timing.html

http/tests/security/cross-origin-resource-timing.html

css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::CSSCursorImageValue):
(WebCore::CSSCursorImageValue::loadImage):

css/CSSCursorImageValue.h:
css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

css/CSSFontFaceSrcValue.h:
css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore::CSSImageSetValue::loadBestFitImage):

css/CSSImageSetValue.h:
css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):
(WebCore::CSSImageValue::loadImage):

css/CSSImageValue.h:
css/CSSStyleSheet.h:
css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

css/StyleSheetContents.h:
css/parser/CSSParserContext.h:
css/parser/CSSPropertyParser.cpp:

(WebCore::consumeCursor):
(WebCore::consumeFontFaceSrcURI):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeImageSet):
(WebCore::CSSPropertyParserHelpers::consumeImage):

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::initializeStyleSheet):
(WebCore::HTMLLinkElement::setCSSStyleSheet):

html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForPresentationAttribute):

html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute):

loader/ResourceLoaderOptions.h:
loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::shouldAddResourceTiming):

svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::srcValue const):

LayoutTests:

http/tests/security/clean-origin-css-exposed-resource-timing-expected.txt: Added.
http/tests/security/clean-origin-css-exposed-resource-timinge-timing.html: Added.
http/tests/security/cross-origin-css-resource-timing-expected.txt: Added.
http/tests/security/cross-origin-css-resource-timing.html: Added.
http/tests/security/resources/loading-subresources.css: Added.
http/tests/security/resources/imported-loading-subresources.css: Added.

2:59 PM Changeset in webkit [238697] by Megan Gardner

19 edits
2 moves in trunk/Source

Move Lookup Code for better cross platform usage
https://bugs.webkit.org/show_bug.cgi?id=191732

Reviewed by Alex Christensen.

Source/WebCore:

Not currenlty testable

DictionaryLookup uses Reveal now, which is slated to be cross-platform.
That patch gates the parts of DictionaryLookup that currently do not have
an available implementation on iOS. Once Reveal is ready, this code will be
replaced or expanded upon, as appropriate.

editing/mac/DictionaryLookup.h:
editing/mac/DictionaryLookup.mm:

(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

pal/spi/mac/LookupSPI.h:
pal/spi/mac/RevealSPI.h:

Source/WebKit:

Lookup is being replaced by Reveal. This framework should work on all platforms.
The patch moves the code that we expect will be needed for all platforms to the more
general cocoa area. This patch changes no funcationality, and should not change
anything currently. This work will be build on later when Reveal is ready to support
multiple platforms.

Platform/spi/ios/UIKitSPI.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _lookupGestureRecognized:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::dictionaryPopupInfoForRange):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Deleted.
(WebKit::WebPage::dictionaryPopupInfoForRange): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.

2:56 PM Changeset in webkit [238696] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Cocoa] Move ServerTimingParser.* into a better group in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=192180

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-29
Reviewed by Simon Fraser.

WebCore.xcodeproj/project.pbxproj:

2:22 PM Changeset in webkit [238695] by Alan Bujtas

4 edits in trunk/Source/WebCore

[ContentObservation] DOMTimer::install should explicitly check if timer observation is on
https://bugs.webkit.org/show_bug.cgi?id=192181

Reviewed by Simon Fraser.

page/DOMTimer.cpp:

(WebCore::DOMTimer::install):

platform/ios/wak/WKContentObservation.cpp:

(WKIsObservingDOMTimerScheduling):

platform/ios/wak/WKContentObservation.h:

1:58 PM Changeset in webkit [238694] by Jonathan Bedard

9 edits in trunk/Tools

webkitpy: Unify device creation
https://bugs.webkit.org/show_bug.cgi?id=192158
<rdar://problem/46344757>

Reviewed by Lucas Forschler.

Scripts/webkitpy/port/device_port.py:

(DevicePort):
(DevicePort.setup_test_run): Use DEVICE_MANAGER to create devices based on the specified device class.

Scripts/webkitpy/port/ios.py:

(IOSPort): Add DEFAULT_DEVICE_CLASS.

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort):
(IOSDevicePort._create_devices): Deleted.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Deleted.

Scripts/webkitpy/port/watch.py:

(WatchPort): Add DEFAULT_DEVICE_CLASS.

Scripts/webkitpy/port/watch_device.py:

(WatchDevicePort):
(WatchDevicePort._create_devices): Deleted.

Scripts/webkitpy/port/watch_simulator.py:

(WatchSimulatorPort._create_devices): Deleted.

Scripts/webkitpy/xcode/device_type_unittest.py:

(DeviceTypeTest.test_from_string): Test that DeviceTypes without hardware types can be constructed
from strings.

1:50 PM Changeset in webkit [238693] by rniwa@webkit.org

6 edits
2 adds in trunk

Executing "insertunorderedlist" while selecting a contenteditable element inside a shadow dom hangs the browser
https://bugs.webkit.org/show_bug.cgi?id=184049
<rdar://problem/38931033>

Reviewed by Antti Koivisto.

Source/WebCore:

The primary hung was caused by TextIterator::advance traversing the next node in the tree order using
NodeTraversal::next which doesn't take the composed tree into account. Fixed the bug by traversing
the composed tree while sharing code with StylizedMarkupAccumulator.

This revealed a second hang in InsertListCommand::doApply() caused by endingSelection() being null,
which was caused by CompositeEditCommand::moveParagraphs failing to restore the ending selection properly
because it was computing the text indices difference from the beginning of the document until the destination.

Fixed this second bug by computing the indices against the beginning of the root editable element.
Note that editability never crosses a shadow boundary.

Test: editing/execCommand/insert-unordered-list-in-shadow-tree.html

dom/ComposedTreeIterator.h:

(WebCore::nextSkippingChildrenInComposedTreeIgnoringUserAgentShadow): Extracted out of nextSkippingChildren
in markup.cpp.
(WebCore::nextInComposedTreeIgnoringUserAgentShadow): Added.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs): Compute the index from the beginning of the root editable
element as opposed to the beginning of the document.

editing/TextIterator.cpp:

(WebCore::nextNode): Added.
(WebCore::isDescendantOf): Added.
(WebCore::TextIterator::advance): Use the newly added functions to traverse the composed tree when the options
contains TextIteratorTraversesFlatTree.

editing/markup.cpp:

LayoutTests:

Added a regression test for executing InsertUnorderedList inside a shadow tree.

editing/execCommand/insert-ordered-list-in-shadow-tree-expected.txt: Added.
editing/execCommand/insert-ordered-list-in-shadow-tree.html: Added.

1:26 PM Changeset in webkit [238692] by rniwa@webkit.org

5 edits
6 adds in trunk/LayoutTests/imported/w3c

Update web-platform-tests/shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=192137

Reviewed by Antti Koivisto.

Re-imported the shadow DOM tests from wpt.

resources/import-expectations.json:
web-platform-tests/shadow-dom/ShadowRoot-interface.html:
web-platform-tests/shadow-dom/event-dispatch-order.tentative-expected.txt: Added.
web-platform-tests/shadow-dom/event-dispatch-order.tentative.html: Added.
web-platform-tests/shadow-dom/input-type-radio-expected.txt: Added.
web-platform-tests/shadow-dom/input-type-radio.html: Added.
web-platform-tests/shadow-dom/resources/shadow-dom.js:

(dispatchEventWithLog):
(assert_event_path_equals):

web-platform-tests/shadow-dom/slots-outside-shadow-dom-expected.txt: Added.
web-platform-tests/shadow-dom/slots-outside-shadow-dom.html: Added.
web-platform-tests/shadow-dom/w3c-import.log:

1:25 PM Changeset in webkit [238691] by Alan Bujtas

7 edits in trunk/Source

[ContentObservation] Decouple content change and DOM timer scheduling observation
https://bugs.webkit.org/show_bug.cgi?id=192170

Reviewed by Simon Fraser.

Source/WebCore:

This is in preparation for adding style recalc scheduling observation (the main goal here is to simplify the indeterminate change logic).

page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):

page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::mouseMoved):

platform/ios/wak/WKContentObservation.cpp:

(WKStartObservingContentChanges):
(WKStopObservingContentChanges):
(WKStartObservingDOMTimerSchedules):
(WKStopObservingDOMTimerSchedules):
(WKSetObservedContentChange):
(WebThreadAddObservedDOMTimer):
(WKBeginObservingContentChanges): Deleted.

platform/ios/wak/WKContentObservation.h:

Source/WebKit:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

1:22 PM Changeset in webkit [238690] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Make reconcileViewportConstrainedLayerPositions start from a specified scrolling node
https://bugs.webkit.org/show_bug.cgi?id=180002

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-29
Reviewed by Simon Fraser.

For non-programmatic scrolling of frames, AsyncScrollingCoordinator::reconcileScrollingState
currently always call reconcileViewportConstrainedLayerPositions for the main frame
since async subframe scrolling is not supported yet (bug 171667 and bug 149264). This
function in turn calls reconcileLayerPositionForViewportRect on the whole scrolling tree to
readjust position of fixed/sticky descendants. This patch refactors a bit the code so that
the operation is actually only applied to the descendants of the frame's scrolling node,
which would mean a small optimization when subframe are asynchronously scrollable. The code
is already covered by reconcile-layer-position-recursive.html.

No new tests, behavior unchanged and already covered by existing tests.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::reconcileScrollingState): Pass the frame's scrolling
node id.
(WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions): Start
reconciliation from the specified scrolling node and log its ID.

page/scrolling/AsyncScrollingCoordinator.h: Add ScrollingNodeID parameter.
page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::reconcileViewportConstrainedLayerPositions): Ditto.

1:13 PM Changeset in webkit [238689] by Alan Bujtas

10 edits in trunk/Source

Rename *ObservedContentModifier(s) to *ObservedDOMTimer(s)
https://bugs.webkit.org/show_bug.cgi?id=192168

Reviewed by Simon Fraser.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::platformSuspendOrStopActiveDOMObjects):

page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

page/DOMWindow.cpp:

(WebCore::DOMWindow::clearTimeout):

page/Frame.cpp:

(WebCore::Frame::willDetachPage):

platform/ios/wak/WKContentObservation.cpp:

(WKBeginObservingContentChanges):
(WKSetObservedContentChange):
(WebThreadGetObservedDOMTimers):
(WebThreadCountOfObservedDOMTimers):
(WebThreadClearObservedDOMTimers):
(WebThreadContainsObservedDOMTimer):
(WebThreadAddObservedDOMTimer):
(WebThreadRemoveObservedDOMTimer):
(WebThreadCountOfObservedContentModifiers): Deleted.
(WebThreadClearObservedContentModifiers): Deleted.
(WebThreadContainsObservedContentModifier): Deleted.
(WebThreadAddObservedContentModifier): Deleted.
(WebThreadRemoveObservedContentModifier): Deleted.

platform/ios/wak/WKContentObservation.h:
platform/ios/wak/WKContentObservationInternal.h:

Source/WebKitLegacy/ios:

There's only one type of content modifier (DOMTimer).

WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::clearContentChangeObservers):

1:11 PM Changeset in webkit [238688] by eric.carlson@apple.com

6 edits in trunk/Source

[iOS] Tell AirPlay picker when a file has video
https://bugs.webkit.org/show_bug.cgi?id=192155
Source/WebCore/PAL:

Reviewed by Jer Noble.

pal/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

<rdar://problem/43843865>

Reviewed by Jer Noble.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showPlaybackTargetPicker:fromRect:routeSharingPolicy:routingContextUID:]):
Add hasVideo parameter.

UIProcess/ios/forms/WKAirPlayRoutePicker.h:
UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker showFromView:routeSharingPolicy:routingContextUID:hasVideo:]): Add
hasVideo parameter, pass info to MPMediaControlsViewController.
(-[WKAirPlayRoutePicker showFromView:routeSharingPolicy:routingContextUID:]): Deleted.

1:09 PM Changeset in webkit [238687] by Justin Fan

22 edits
2 adds in trunk

[WebGPU] WebGPURenderPassEncoder::setPipeline, draw, and endPass prototypes
https://bugs.webkit.org/show_bug.cgi?id=192134

Reviewed by Dean Jackson.

Source/WebCore:

Wrap up prototype features for WebGPURenderPassEncoder.

Test: webgpu/render-command-encoding.html

Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::beginRenderPass):

Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createRenderPipeline const):

Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:

(WebCore::WebGPUProgrammablePassEncoder::WebGPUProgrammablePassEncoder):
(WebCore::WebGPUProgrammablePassEncoder::endPass): Returns a reference to the WebGPUCommandBuffer that created this encoder.
(WebCore::WebGPUProgrammablePassEncoder::setPipeline):

Modules/webgpu/WebGPUProgrammablePassEncoder.h: Updated to support endPass and setPipeline.
Modules/webgpu/WebGPUProgrammablePassEncoder.idl:
Modules/webgpu/WebGPURenderPassEncoder.cpp:

(WebCore::WebGPURenderPassEncoder::create): Must be provided with the WebGPUCommandBuffer.
(WebCore::WebGPURenderPassEncoder::WebGPURenderPassEncoder):
(WebCore::WebGPURenderPassEncoder::draw):

Modules/webgpu/WebGPURenderPassEncoder.h: Updated to cache a reference to the WebGPUCommandBuffer, and for draw.
Modules/webgpu/WebGPURenderPassEncoder.idl:
Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):

Modules/webgpu/WebGPURenderPipeline.h:

(WebCore::WebGPURenderPipeline::renderPipeline):

Modules/webgpu/WebGPUTexture.cpp:
Modules/webgpu/WebGPUTexture.h: Replaced include with forward declaration.
platform/graphics/gpu/GPUProgrammablePassEncoder.h: Updated to support new WebGPU_PassEncoder functionality.
platform/graphics/gpu/GPURenderPassEncoder.h:

(WebCore::GPURenderPassEncoder::~GPURenderPassEncoder): Now ends encoding on the MTLCommandEncoder, if not already ended, before freeing it.

platform/graphics/gpu/GPURenderPipeline.h: Now remembers the GPUPrimitiveTopology that it was created with.

(WebCore::GPURenderPipeline::primitiveTopology const):

platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm:

(WebCore::GPUProgrammablePassEncoder::endPass): Calls endEncoding on the backing MTLCommandEncoder, if not already ended.

platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:

(WebCore::GPURenderPassEncoder::platformPassEncoder const):
(WebCore::GPURenderPassEncoder::setPipeline): Added.
(WebCore::primitiveTypeForGPUPrimitiveTopology): Added. Helper function to convert GPUPrimitiveTopology to MTLPrimitiveType.
(WebCore::GPURenderPassEncoder::draw): Added. Draws using primitive topology specified during pipeline creation.

platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::setFunctionsForPipelineDescriptor):
(WebCore::GPURenderPipeline::create):
(WebCore::GPURenderPipeline::GPURenderPipeline): Now must store the GPURenderPipelineDescriptor for later reference.

LayoutTests:

Updating the basic rendering test with more commands, and a prototype WPT-based test for WebGPURenderCommandEncoder's
new functionality.

webgpu/js/basic-webgpu-functions.js:

(render):

webgpu/render-command-encoding-expected.txt: Added.
webgpu/render-command-encoding.html: Added.
webgpu/render-passes.html:

1:01 PM Changeset in webkit [238686] by Justin Michaud

29 edits
11 adds in trunk

CSS Painting API should pass 'this' correctly to paint callback, and repaint when properties change.
https://bugs.webkit.org/show_bug.cgi?id=191443

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Export the simpler construct() method for use in WebCore.

runtime/ConstructData.h:

Source/WebCore:

Instantiate a new instance of the paint class, and pass it as 'this' object when the paint callback is called.
Also, this patch makes sure that custom paint elements get repainted when properties that they care about get changed.
Finally, we fix two reference cycles that caused WorkletGlobalScope to never be destroyed.

Tests: fast/css-custom-paint/animate-repaint.html

fast/css-custom-paint/animate.html

bindings/js/JSDOMWrapper.cpp:
bindings/js/JSPaintWorkletGlobalScopeCustom.cpp:

(WebCore::JSPaintWorkletGlobalScope::visitAdditionalChildren):

bindings/js/JSWorkletGlobalScopeBase.cpp:

(WebCore::toJS):

bindings/js/ScriptState.cpp:

(WebCore::execStateFromWorkletGlobalScope):

css/CSSPaintCallback.h:
css/CSSPaintCallback.idl:
css/CSSPaintImageValue.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

dom/Document.cpp:

(WebCore::Document::prepareForDestruction):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::vm):

platform/graphics/CustomPaintImage.cpp:

(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):

platform/graphics/CustomPaintImage.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCustomPaintWatchProperty):
(WebCore::RenderStyle::changeRequiresRepaint const):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):

rendering/style/StyleRareNonInheritedData.h:
testing/Internals.cpp:

(WebCore::Internals::isAnyWorkletGlobalScopeAlive const):

testing/Internals.h:
testing/Internals.idl:
worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::devicePixelRatio const):
(WebCore::PaintWorkletGlobalScope::PaintDefinition::PaintDefinition):
(WebCore::PaintWorkletGlobalScope::registerPaint):

worklets/PaintWorkletGlobalScope.h:

(WebCore::PaintWorkletGlobalScope::~PaintWorkletGlobalScope):

worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::WorkletGlobalScope):
(WebCore::WorkletGlobalScope::~WorkletGlobalScope):
(WebCore::WorkletGlobalScope::prepareForDestruction):
(WebCore::WorkletGlobalScope::allWorkletGlobalScopesSet):
(WebCore::WorkletGlobalScope::isJSExecutionForbidden const):
(WebCore::WorkletGlobalScope::logExceptionToConsole):
(WebCore::WorkletGlobalScope::addConsoleMessage):
(WebCore::WorkletGlobalScope::addMessage):

worklets/WorkletGlobalScope.h:

(WebCore::WorkletGlobalScope::script):
(WebCore::WorkletGlobalScope::responsibleDocument):
(WebCore::WorkletGlobalScope::responsibleDocument const):
(WebCore::WorkletGlobalScope::identifier const): Deleted.
(WebCore::WorkletGlobalScope::responsableDocument): Deleted.
(WebCore::WorkletGlobalScope::responsableDocument const): Deleted.

worklets/WorkletScriptController.cpp:

(WebCore::WorkletScriptController::~WorkletScriptController):
(WebCore::WorkletScriptController::disableEval):
(WebCore::WorkletScriptController::disableWebAssembly):
(WebCore::WorkletScriptController::initScript):

LayoutTests:

fast/css-custom-paint/animate-expected.html: Added.
fast/css-custom-paint/animate-repaint-expected.txt: Added.
fast/css-custom-paint/animate-repaint.html: Added.
fast/css-custom-paint/animate.html: Added.
fast/css-custom-paint/constructor-expected.html: Added.
fast/css-custom-paint/constructor.html: Added.
fast/css-custom-paint/leaks-expected.txt: Added.
fast/css-custom-paint/leaks.html: Added.
fast/css-custom-paint/properties.html:
fast/css-custom-paint/resources/leaks-frame.html: Added.
platform/mac/fast/css-custom-paint/raf-leak-expected.txt: Added.

12:52 PM Changeset in webkit [238685] by ap@apple.com

9 edits in trunk/Source

Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence
https://bugs.webkit.org/show_bug.cgi?id=192041

Reviewed by Tim Horton.

Source/WebCore:

loader/ResourceLoaderOptions.h: Added a FIXME for poor naming of loader options.

There is a lot of code that needs to be cleaned up here.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::applySniffingPoliciesIfNeeded):

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):

Source/WTF:

wtf/Platform.h:

12:42 PM Changeset in webkit [238684] by Jonathan Bedard

2 edits in trunk/Tools

EWS iOS-sim bots sometimes fails to shutdown simulator
https://bugs.webkit.org/show_bug.cgi?id=191864

Reviewed by Aakash Jain.

Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice._shut_down): Increase time to wait for simulated device to
shut down, ignore exit code indicating a device is already shut down.

12:10 PM Changeset in webkit [238683] by youenn@apple.com

4 edits
4 adds in trunk

Updating a service worker during a navigation load sometimes makes the load fail
https://bugs.webkit.org/show_bug.cgi?id=191986
<rdar://problem/46259790>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/resources/trickle.py: Added.

(main):

web-platform-tests/service-workers/service-worker/resources/update-fetch-worker.py: Added.

(main):

web-platform-tests/service-workers/service-worker/update-on-navigation.https-expected.txt: Added.
web-platform-tests/service-workers/service-worker/update-on-navigation.https.html: Added.

Source/WebCore:

Previously, we were registering a document as service worker client at creation of the document.
According the service worker spec, this should be done when handling the fetch event of the corresponding navigation load.
This ensures that the service worker will have a client and will not get updated in the middle of the navigation load.

At navigation load start, we do not have a document yet since it is created when receiving the first bytes.
Instead, we register a temporary document when starting the navigation load and unregister it when the real document is registered.

Test: imported/w3c/web-platform-tests/service-workers/service-worker/update-on-navigation.https.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::registerTemporaryServiceWorkerClient):
(WebCore::DocumentLoader::unregisterTemporaryServiceWorkerClient):
(WebCore::DocumentLoader::loadMainResource):
(WebCore::DocumentLoader::clearMainResource):

loader/DocumentLoader.h:

12:09 PM Changeset in webkit [238682] by Ryan Haddad

19 edits
2 moves in trunk/Source

Unreviewed, rolling out r238678.

Breaks internal builds.

Reverted changeset:

"Move Lookup Code for better cross platform usage"
https://bugs.webkit.org/show_bug.cgi?id=191732
https://trac.webkit.org/changeset/238678

11:59 AM Changeset in webkit [238681] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Addressed a FIXME by removing an unnecessary call to [NSApplication sharedApplication].
https://bugs.webkit.org/show_bug.cgi?id=192099

Patch by Suresh Koppisetty <skoppisetty@apple.com> on 2018-11-29
Reviewed by Geoffrey Garen.

[NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] calls [NSApplication sharedApplication].

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

11:54 AM Changeset in webkit [238680] by youenn@apple.com

6 edits in trunk

A sender created through addTransceiver and populated using addTrack should have its source set
https://bugs.webkit.org/show_bug.cgi?id=192136

Reviewed by Eric Carlson.

Source/WebCore:

In case libwebrtc backend is already created, we need to make sure to
set the track source to the libwebrtc sender backend that is actually
tied to the sender.

Covered by updated test.

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::addTrack):

Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:

LayoutTests:

webrtc/video-replace-track-expected.txt:
webrtc/video-replace-track.html:

11:00 AM Changeset in webkit [238679] by Ryan Haddad

4 edits in trunk/LayoutTests

Unreviewed test gardening, skip three datalist tests that are marked as flaky crashes.

TestExpectations:
platform/ios/TestExpectations:
platform/mac/TestExpectations:

10:54 AM Changeset in webkit [238678] by Megan Gardner

19 edits
2 moves in trunk/Source

Move Lookup Code for better cross platform usage
https://bugs.webkit.org/show_bug.cgi?id=191732

Reviewed by Alex Christensen.

Source/WebCore:

Not currenlty testable

editing/mac/DictionaryLookup.h:
editing/mac/DictionaryLookup.mm:

(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

pal/spi/mac/LookupSPI.h:
pal/spi/mac/RevealSPI.h:

Source/WebKit:

Platform/spi/ios/UIKitSPI.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.

WebProcess/WebPage/mac/WebPageMac.mm:

10:45 AM Changeset in webkit [238677] by sihui_liu@apple.com

9 edits in trunk

IndexedDB: breaks if binary data (Uint8Array) and autoIncrement key in store
https://bugs.webkit.org/show_bug.cgi?id=185869
<rdar://problem/40453623>

Reviewed by Geoffrey Garen.

Source/WebCore:

lexicalGlobalObject is casted to JSDOMGlobalObject in CloneSerializer::dumpArrayBufferView,
so we should use JSDOMGlobalObject instead of JSGlobalObject in IDB database thread.

Covered by modified test: storage/indexeddb/objectstore-autoincrement.html

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::databaseThreadVM):
(WebCore::IDBServer::UniqueIDBDatabase::databaseThreadExecState):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::create):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWrapper.cpp:

(WebCore::JSDOMObject::JSDOMObject):

LayoutTests:

storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-autoincrement-private-expected.txt:
storage/indexeddb/resources/objectstore-autoincrement.js:

(getLincolnAfterInjectedKeySuccess):
(putBobSuccess):
(getBobSuccess):
(addLincolnWithExplicitKeySuccess):
(putAbrahamSuccess):

10:41 AM Changeset in webkit [238676] by sihui_liu@apple.com

3 edits
3 adds in trunk

Unexpected constructor / instanceof behavior when retrieving indexedDB data in an iframe
https://bugs.webkit.org/show_bug.cgi?id=185906
<rdar://problem/40583100>

Reviewed by Geoffrey Garen.

Source/WebCore:

ScriptExecutionContext::execState() returned state of main frame, so deserialization of
IDBValue in iframe used constructors of main frame, which is wrong.

Test: storage/indexeddb/instanceof-iframe.html

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::execState):

LayoutTests:

storage/indexeddb/instanceof-iframe-expected.txt: Added.
storage/indexeddb/instanceof-iframe.html: Added.
storage/indexeddb/resources/instanceof-iframe.js: Added.

(test.else.shouldBe):
(test.else.shouldBeTrue):
(test.else.shouldBeFalse):
(test.else.evalAndLog):
(test):
(callback):

10:36 AM Changeset in webkit [238675] by don.olmstead@sony.com

7 edits
2 moves
1 add
2 deletes in trunk/Source/WebCore

Make generic ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=192128

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Moves ScrollAnimatorGtk into ScrollAnimatorGeneric where it can be used
by other implementations. Fixed some compilation issues around using
this as a default implementation.

Removing ScrollAnimatorSmooth since it is dead code and doesn't even
compile at this time.

Fixing a compilation issue within LowPowerModeNotifierGLib
implementation that appeared due to unified sources changes.

PlatformGTK.cmake:
SourcesGTK.txt:
platform/LowPowerModeNotifier.h:
platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::swipeVelocity const):

platform/ScrollAnimatorSmooth.cpp: Removed.
platform/ScrollAnimatorSmooth.h: Removed.
platform/generic/ScrollAnimatorGeneric.cpp: Renamed from Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp.

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorGeneric::ScrollAnimatorGeneric):
(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):
(WebCore::ScrollAnimatorGeneric::scroll):
(WebCore::ScrollAnimatorGeneric::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorGeneric::computeVelocity):
(WebCore::ScrollAnimatorGeneric::handleWheelEvent):
(WebCore::ScrollAnimatorGeneric::willEndLiveResize):
(WebCore::ScrollAnimatorGeneric::updatePosition):
(WebCore::ScrollAnimatorGeneric::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorGeneric::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorGeneric::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorGeneric::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorGeneric::updateOverlayScrollbarsOpacity):
(WebCore::ScrollAnimatorGeneric::overlayScrollbarAnimationTimerFired):
(WebCore::ScrollAnimatorGeneric::showOverlayScrollbars):
(WebCore::ScrollAnimatorGeneric::hideOverlayScrollbars):
(WebCore::ScrollAnimatorGeneric::mouseEnteredContentArea):
(WebCore::ScrollAnimatorGeneric::mouseExitedContentArea):
(WebCore::ScrollAnimatorGeneric::mouseMovedInContentArea):
(WebCore::ScrollAnimatorGeneric::contentAreaDidShow):
(WebCore::ScrollAnimatorGeneric::contentAreaDidHide):
(WebCore::ScrollAnimatorGeneric::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorGeneric::lockOverlayScrollbarStateToHidden):

platform/generic/ScrollAnimatorGeneric.h: Renamed from Source/WebCore/platform/gtk/ScrollAnimatorGtk.h.
platform/glib/LowPowerModeNotifierGLib.cpp:
platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::swipeVelocity const): Deleted.

10:26 AM Changeset in webkit [238674] by Conrad Shultz

2 edits in trunk/Source/WebKit

Factor out configuration of the file upload image picker
https://bugs.webkit.org/show_bug.cgi?id=192138
<rdar://problem/46334871>

Reviewed by Tim Horton.

By factoring configuration of the picker into its own method, it makes it easier
to apply custom configuration in subclasses in the future.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _configureImagePicker:]):

10:26 AM Changeset in webkit [238673] by dino@apple.com

7 edits
4 adds in trunk

[ES Modules] Allow .mjs content when loaded from file://
https://bugs.webkit.org/show_bug.cgi?id=192100
<rdar://problem/46320065>

Reviewed by Sam Weinig.

Source/WebCore:

Node JS requires ES Module files to be identified by the file
extension of ".mjs" (no relation to Maciej Stachowiak). This new
extension causes issues because it isn't recognised as a JavaScript
file. When using the script tag, the author is able to force the type
of the referenced file using an attribute, but this isn't possible
for the import() function or import statement.

Add a new entry into our table that maps file extensions to MIME types
so that when a .mjs file is loaded from a file:// reference it is
identified as JavaScript.

Test: js/dom/modules/import-mjs-module.html

platform/network/mac/WebCoreURLResponse.mm: Add .mjs to the existing dictionary.

(WebCore::createExtensionToMIMETypeMap):

platform/network/ios/WebCoreURLResponseIOS.mm: Add code just for .mjs.

(WebCore::createExtensionToMIMETypeMap):

Source/WebInspectorUI:

Add a mapping from .mjs to application/javascript.

UserInterface/Base/MIMETypeUtilities.js:

(WI.mimeTypeForFileExtension):

LayoutTests:

Test for both import() function and the import statement loading
from .mjs files.

js/dom/modules/import-mjs-module-expected.txt: Added.
js/dom/modules/import-mjs-module.html: Added.
js/dom/modules/resources/module-simple-A.mjs: Added.
js/dom/modules/resources/module-simple-B.mjs: Added.
platform/win/TestExpectations: Skip this on Windows. Just wait for Windows to recognise the extension.

10:00 AM Changeset in webkit [238672] by Jonathan Bedard

8 edits in trunk/Tools

webkitpy: Unify ios_version/watchos_version code
https://bugs.webkit.org/show_bug.cgi?id=192153
<rdar://problem/46343642>

Reviewed by Lucas Forschler.

Treating watchOS and iOS versions differently makes it harder to share code between the similar ports.

Scripts/webkitpy/port/device_port.py:

(DevicePort):
(DevicePort.device_version): Added.

Scripts/webkitpy/port/ios.py:

(IOSPort.default_baseline_search_path): Use device_version() instead of ios_version().
(IOSPort.ios_version): Deleted.

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.device_version): Renamed from ios_version().
(IOSDevicePort.ios_version): Deleted.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.device_version): Renamed from ios_version().
(IOSSimulatorPort.default_child_processes.booted_ios_devices_filter): Use device_version() instead of ios_version().
(IOSSimulatorPort._create_devices): Ditto.
(IOSSimulatorPort.check_sys_deps): Ditto.
(IOSSimulatorPort.ios_version): Deleted.

Scripts/webkitpy/port/watch.py:

(WatchPort.default_baseline_search_path): Use device_version() instead of watchos_version().
(WatchPort.watchos_version): Deleted.

Scripts/webkitpy/port/watch_device.py:

(WatchDevicePort.device_version): Renamed from watchos_version().
(WatchDevicePort.watchos_version): Deleted.

Scripts/webkitpy/port/watch_simulator.py:

(WatchSimulatorPort.device_version): Renamed from watchos_version().
(WatchSimulatorPort.default_child_processes.filter_booted_watchos_devices): Use device_version() instead of watchos_version().
(WatchSimulatorPort._create_devices): Ditto.
(WatchSimulatorPort.check_sys_deps): Ditto.
(WatchSimulatorPort.watchos_version): Deleted.

9:50 AM Changeset in webkit [238671] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: selecting more than one DOM node causes the scope highlight to contrast
https://bugs.webkit.org/show_bug.cgi?id=192118
<rdar://problem/46325664>

Reviewed by Devin Rousso.

Use an alpha blended border for the "selected" DOM scope highlight,
matching the "hovered" scope highlight.

UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li.selected + ol.children.expanded):

8:41 AM Changeset in webkit [238670] by guijemont@igalia.com

2 edits in trunk/LayoutTests

Gardening: skip test that newly times out on Armv7

Unreviewed Test Gardening.

js/slow-stress/script-tests/marsaglia.js: skip on arm/linux

8:02 AM Changeset in webkit [238669] by magomez@igalia.com

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening after r238665.

platform/gtk/TestExpectations:

7:30 AM Changeset in webkit [238668] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][BFC][Quirk] Width does not need stretching quirk.
https://bugs.webkit.org/show_bug.cgi?id=192135

Reviewed by Antti Koivisto.

In BFC the block box's width (auto) always streches to the content width of the containing block.

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::needsStretching):
(WebCore::Layout::BlockFormattingContext::Quirks::isStretchedToInitialContainingBlock): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedWidth): Deleted.

7:28 AM Changeset in webkit [238667] by Alan Bujtas

11 edits
2 adds in trunk/Source/WebCore

[LFC][Quirk] Move quirk functions to dedicated classes.
https://bugs.webkit.org/show_bug.cgi?id=192133

Reviewed by Antti Koivisto.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::initialContainingBlock): Deleted.
(WebCore::Layout::isStretchedToInitialContainingBlock): Deleted.
(WebCore::Layout::stretchHeightToInitialContainingBlockQuirk): Deleted.
(WebCore::Layout::stretchWidthToInitialContainingBlock): Deleted.

layout/blockformatting/BlockFormattingState.cpp:
layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::isQuirkContainer): Deleted.
(WebCore::Layout::hasMarginTopQuirkValue): Deleted.
(WebCore::Layout::shouldIgnoreMarginTopInQuirkContext): Deleted.
(WebCore::Layout::isMarginTopCollapsedWithParent): Deleted.

layout/inlineformatting/InlineFormattingContext.cpp:
layout/inlineformatting/text/TextUtil.h:

4:34 AM Changeset in webkit [238666] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove some superfluous code in ContentSecurityPolicy::upgradeInsecureRequestIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=192076

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-29
Reviewed by Frédéric Wang.

Since we do an early return if the protocol is not http or ws, the if check
for ws protocol and else statement are not needed, so use an ASSERT instead.

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded const):

3:44 AM Changeset in webkit [238665] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Add ParentRelativeScrollableRect to ScrollingCoordinator::ScrollingGeometry
https://bugs.webkit.org/show_bug.cgi?id=172914

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-29
Reviewed by Simon Fraser.

This patch adds a ParentRelativeScrollableRect ScrollingCoordinator::ScrollingGeometry and
the corresponding set/get/dump APIs. Currently, the setter is never used so the behavior is
unchanged. In the future, this rect will be used for hit testing of subframes during
asynchronous macOS scrolling (but 172917).

No new tests, behavior unchanged.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):

page/scrolling/ScrollingCoordinator.h:
page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setParentRelativeScrollableRect):
(WebCore::ScrollingStateScrollingNode::dumpProperties const):

page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::parentRelativeScrollableRect const):

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeScrollingNode::dumpProperties const):

page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::parentRelativeScrollableRect const):

2:30 AM Changeset in webkit [238664] by commit-queue@webkit.org

4 edits
1 copy
7 moves
18 adds
8 deletes in trunk/LayoutTests/imported/w3c

Import fetch/api/cors tests
https://bugs.webkit.org/show_bug.cgi?id=192092

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-29
Reviewed by Frédéric Wang.

Import to most recent checkout since some old
tests like cors-multiple-origins.js were incorrect.

resources/import-expectations.json:
web-platform-tests/fetch/api/cors/cors-expose-star-worker.html: Removed.
web-platform-tests/fetch/api/cors/cors-expose-star.html: Removed.
web-platform-tests/fetch/api/cors/cors-expose-star.sub.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-expose-star-expected.txt.
web-platform-tests/fetch/api/cors/cors-expose-star.sub.any.html: Added.
web-platform-tests/fetch/api/cors/cors-expose-star.sub.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-expose-star.js.

(sharedHeaders.string_appeared_here.promise_test):
(string_appeared_here.promise_test):

web-platform-tests/fetch/api/cors/cors-expose-star.sub.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-expose-star-worker-expected.txt.
web-platform-tests/fetch/api/cors/cors-expose-star.sub.any.worker.html: Added.
web-platform-tests/fetch/api/cors/cors-filtering-worker.html: Removed.
web-platform-tests/fetch/api/cors/cors-filtering.html: Removed.
web-platform-tests/fetch/api/cors/cors-filtering.sub.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering-expected.txt.
web-platform-tests/fetch/api/cors/cors-filtering.sub.any.html: Added.
web-platform-tests/fetch/api/cors/cors-filtering.sub.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering.js.

(corsFilter):
(corsExposeFilter):

web-platform-tests/fetch/api/cors/cors-filtering.sub.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering-worker-expected.txt.
web-platform-tests/fetch/api/cors/cors-filtering.sub.any.worker.html: Added.
web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt: Removed.
web-platform-tests/fetch/api/cors/cors-multiple-origins-worker.html: Removed.
web-platform-tests/fetch/api/cors/cors-multiple-origins.html: Removed.
web-platform-tests/fetch/api/cors/cors-multiple-origins.js: Removed.
web-platform-tests/fetch/api/cors/cors-multiple-origins.sub.any-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt.
web-platform-tests/fetch/api/cors/cors-multiple-origins.sub.any.html: Added.
web-platform-tests/fetch/api/cors/cors-multiple-origins.sub.any.js: Added.

(corsMultipleOrigins):

web-platform-tests/fetch/api/cors/cors-multiple-origins.sub.any.worker-expected.txt: Added.
web-platform-tests/fetch/api/cors/cors-multiple-origins.sub.any.worker.html: Added.
web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any-expected.txt: Added.
web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.html: Added.
web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.js: Added.

(runTests):

web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker-expected.txt: Added.
web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker.html: Added.
web-platform-tests/fetch/api/cors/cors-preflight.any.js:

(headerNames): Deleted.
(): Deleted.
(corsPreflight): Deleted.

web-platform-tests/fetch/api/cors/resources/corspreflight.js: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight.any.js.

(headerNames):
(corsPreflight):

web-platform-tests/fetch/api/cors/resources/not-cors-safelisted.json: Added.
web-platform-tests/fetch/api/cors/resources/w3c-import.log: Added.
web-platform-tests/fetch/api/cors/sandboxed-iframe-expected.txt: Added.
web-platform-tests/fetch/api/cors/sandboxed-iframe.html: Added.
web-platform-tests/fetch/api/cors/w3c-import.log:

2:19 AM Changeset in webkit [238663] by tpopela@redhat.com

2 edits in trunk/Source/WebKit

[GTK][WPE] Fix BubblewrapLauncher clang warnings
https://bugs.webkit.org/show_bug.cgi?id=192086

Reviewed by Michael Catanzaro.

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindPathVar): Initialize the i variable to 0.
(WebKit::setupSeccomp): Initialize the optional datum_b member.

1:14 AM Changeset in webkit [238662] by tpopela@redhat.com

3 edits in trunk/Source/WebDriver

[WebDriver] Fix clang warnings in Session.cpp
https://bugs.webkit.org/show_bug.cgi?id=192077

Reviewed by Carlos Garcia Campos.

Session.cpp:

(WebDriver::Session::dismissAndNotifyAlert):
(WebDriver::Session::acceptAndNotifyAlert):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementClear):
(WebDriver::Session::handleScriptResult):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::performActions):
(WebDriver::Session::releaseActions):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):

WebDriverService.cpp:

(WebDriver::WebDriverService::deleteSession):

Nov 28, 2018:

9:25 PM Changeset in webkit [238661] by Wenson Hsieh

6 edits in trunk

[iOSMac] Dropping text selections from web content into editable elements crashes the web process
https://bugs.webkit.org/show_bug.cgi?id=192113
<rdar://problem/46323701>

Reviewed by Ryosuke Niwa.

Source/WebCore:

In iOSMac, registering invalid UTIs on NSItemProvider when starting a drag or handling a drop does not work.
Since iOS writes and reads only "Apple Web Archive pasteboard type" (a.k.a. WebArchivePboardType) during drag
and drop as well as copy and paste, we fail to read or write any web archive data, and subsequently fall back to
reading RTF or flat RTFD, both of which are not supported in iOSMac, since UIFoundation links against the
system's macOS WebKit stack.

To fix this, we add support for reading and writing com.apple.webarchive (kUTTypeWebArchive) on iOS, so that
WebKit-based iOSMac applications can understand web archive data from the host running macOS, and the host can
also understand web archive data written by the iOSMac app. Additionally, don't allow reading RTF and flat RTFD
as web content in iOSMac. (Note that writing RTF and flat RTFD is still safe, since it does not depend on
UIFoundation.framework but rather WebCore::HTMLConverter).

Test: DragAndDropTests.ModernWebArchiveType

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragment):

Additionally make sure that we never call into UIFoundation's NSAttributedString to markup conversion codepath
by making createFragment an empty stub on iOSMac.

platform/ios/PasteboardIOS.mm:

(WebCore::supportedImageTypes):
(WebCore::isTypeAllowedByReadingPolicy):
(WebCore::Pasteboard::readPasteboardWebContentDataForType):
(WebCore::Pasteboard::supportedWebContentPasteboardTypes):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

Tools:

Add a test to verify that, when dropping an item with both "com.apple.webarchive" and "public.utf8-plain-text"
representations, the higher fidelity web archive data is used when handling the drop.

TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:

8:39 PM Changeset in webkit [238660] by Joseph Pecoraro

5 edits in trunk/Source

Web Inspector: REGRESSION(?): all "Show *" develop menu items cause the page to crash
https://bugs.webkit.org/show_bug.cgi?id=192016
<rdar://problem/46284417>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

UserInterface/Base/Main.js:

(WI.loaded):
(WI.initializeBackendTarget):
(WI.contentLoaded):
(WI.whenTargetsAvailable):
Don't evaluate any InspectorFrontendAPI commands until the frontend
has initialized a main target and the user interface.

Source/WebKit:

Previously calling the Page's inspectorController.show()
would create a frontend connection on the WebProcess side.
However now the frontend connection is handed to the WebProcess
once the UIProcess creates it. So queue actions that take place
immediately after showing the inspector until we have a frontend
to send the actions to.

WebProcess/WebPage/WebInspector.h:
WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::setFrontendConnection):
(WebKit::WebInspector::closeFrontendConnection):
(WebKit::WebInspector::whenFrontendConnectionEstablished):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showTimelines):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::startElementSelection):
(WebKit::WebInspector::stopElementSelection):

8:20 PM BuildBot edited by Fujii Hironori

(diff)

8:14 PM Changeset in webkit [238659] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit

Consult dummy storage for HTTPS Upgrade, Apply If Appropriate
https://bugs.webkit.org/show_bug.cgi?id=192094
<rdar://problem/45851103> HTTPS Upgrade: Consult dummy storage for HTTPS Upgrade, Apply If Appropriate

Patch by Vivek Seth <v_seth@apple.com> on 2018-11-28
Reviewed by Chris Dumez.

For main page loads upgrade HTTP requests to HTTPS if the hostname belongs to a set of upgradable hostnames.

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded):
(WebKit::NetworkLoadChecker::checkRequest):

NetworkProcess/NetworkLoadChecker.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

7:54 PM Changeset in webkit [238658] by Simon Fraser

2 edits in trunk/Source/WebKit

REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]
https://bugs.webkit.org/show_bug.cgi?id=192127
rdar://problem/44194179

Reviewed by Tim Horton.

_restorePageStateToUnobscuredCenter: could receive an Optional<FloatRect> from the
web process, and unconditionally called .value() even though it may not be engaged.

No repro steps known, so no testcase.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):

6:55 PM Changeset in webkit [238657] by commit-queue@webkit.org

18 edits
2 moves in trunk/Source

Unreviewed, rolling out r238653 and r238656.
https://bugs.webkit.org/show_bug.cgi?id=192130

Breaks iOS build (Requested by smfr on #webkit).

Reverted changesets:

"Move Lookup Code for better cross platform usage"
https://bugs.webkit.org/show_bug.cgi?id=191732
https://trac.webkit.org/changeset/238653

"Attempt to fix the iOS build by only including RevealSPI.h
when it's needed."
https://trac.webkit.org/changeset/238656

6:25 PM Changeset in webkit [238656] by Simon Fraser

2 edits in trunk/Source/WebCore

Attempt to fix the iOS build by only including RevealSPI.h when it's needed.

editing/cocoa/DictionaryLookup.mm:

6:19 PM Changeset in webkit [238655] by achristensen@apple.com

23 edits in trunk/Source

Modernize BlobRegistry::writeBlobsToTemporaryFiles
https://bugs.webkit.org/show_bug.cgi?id=192117

Reviewed by Dean Jackson.

Source/WebCore:

No change in behavior. Just use CompletionHandlers and the new sendWithAsyncReply instead of two way messaging
and manual completion handler management.

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):

platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):

platform/network/BlobRegistryImpl.h:

Source/WebKit:

NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
(WebKit::NetworkBlobRegistry::writeBlobToFilePath):

NetworkProcess/FileAPI/NetworkBlobRegistry.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::writeBlobToFilePath):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::sendWithAsyncReply):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::writeBlobToFilePath):
(WebKit::NetworkProcessProxy::didWriteBlobToFilePath): Deleted.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):

WebProcess/FileAPI/BlobRegistryProxy.h:
WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
(WebKit::NetworkProcessConnection::didWriteBlobsToTemporaryFiles): Deleted.

WebProcess/Network/NetworkProcessConnection.h:
WebProcess/Network/NetworkProcessConnection.messages.in:

6:18 PM Changeset in webkit [238654] by achristensen@apple.com

15 edits
1 add in trunk/Source/WebKit

Move loadThrottleLatency from NetworkProcessCreationParameters to NetworkSessionCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192122

Reviewed by Dean Jackson.

This is part of an effort to reduce global variables in the NetworkProcess.

NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::didReceiveResponse):

NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::loadThrottleLatency const): Deleted.

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::loadThrottleLatency const):

NetworkProcess/NetworkSessionCreationParameters.cpp: Added.

(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

NetworkProcess/NetworkSessionCreationParameters.h:

(WebKit::NetworkSessionCreationParameters::encode const): Deleted.
(WebKit::NetworkSessionCreationParameters::decode): Deleted.

NetworkProcess/cocoa/NetworkSessionCocoa.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::privateSessionParameters):

Sources.txt:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

WebKit.xcodeproj/project.pbxproj:

5:41 PM Changeset in webkit [238653] by Megan Gardner

18 edits
2 moves in trunk/Source

Move Lookup Code for better cross platform usage
https://bugs.webkit.org/show_bug.cgi?id=191732

Reviewed by Alex Christensen.

Source/WebCore:

Not currenlty testable

editing/mac/DictionaryLookup.h:
editing/mac/DictionaryLookup.mm:

(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

pal/spi/mac/LookupSPI.h:
pal/spi/mac/RevealSPI.h:

Source/WebKit:

Platform/spi/ios/UIKitSPI.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.

WebProcess/WebPage/mac/WebPageMac.mm:

5:39 PM Changeset in webkit [238652] by chris.reid@sony.com

2 edits in trunk/Source/WebCore

SQLiteDatabase::open is constantly printing "SQLite database failed to checkpoint: database table is locked" errors
https://bugs.webkit.org/show_bug.cgi?id=192111

Reviewed by Alex Christensen.

Ensure the journal_mode=WAL statement is finalized before wal_checkpoint is executed.

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

5:29 PM Changeset in webkit [238651] by commit-queue@webkit.org

3 edits
8 adds in trunk

Updating href on linearGradient and radialGradient doesn't update its rendering
https://bugs.webkit.org/show_bug.cgi?id=191934

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Mark the gradient renderer for repaint when the value of the 'href'
attribute changes.

Tests: fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html

fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html

svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::svgAttributeChanged):

LayoutTests:

fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html: Added.
fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html: Added.
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html: Added.
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html: Added.
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html: Added.
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html: Added.

5:22 PM Changeset in webkit [238650] by mark.lam@apple.com

4 edits in trunk/Source

ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
https://bugs.webkit.org/show_bug.cgi?id=192110
<rdar://problem/46317746>

Reviewed by Saam Barati.

Source/JavaScriptCore:

config.h:

Source/WTF:

Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC. Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.

wtf/Platform.h:

5:11 PM Changeset in webkit [238649] by Nikita Vasilyev

8 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: enable selection of multiple properties by default
https://bugs.webkit.org/show_bug.cgi?id=192109
<rdar://problem/46323565>

Reviewed by Devin Rousso.

UserInterface/Base/Setting.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Remove the checkbox.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property):
(.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
(.spreadsheet-style-declaration-editor .property.selected):
(.spreadsheet-style-declaration-editor .property.selected:focus):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus): Deleted.
Remove .multiple-properties-selection class.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype._handleFocus): Deleted.

4:09 PM Changeset in webkit [238648] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: empty results folder is shown after clearing filters
https://bugs.webkit.org/show_bug.cgi?id=192106

Reviewed by Matt Baker.

UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Added.

2:36 PM Changeset in webkit [238647] by Alan Coon

5 edits in tags/Safari-607.1.15/Source/JavaScriptCore

Revert r238564. rdar://problem/46321015

2:36 PM Changeset in webkit [238646] by Alan Coon

12 edits in tags/Safari-607.1.15

Revert r238597. rdar://problem/46321159

2:24 PM Changeset in webkit [238645] by Alan Coon

1 copy in tags/Safari-607.1.15

Tag Safari-607.1.15.

2:19 PM Changeset in webkit [238644] by aakash_jain@apple.com

1 edit
1 add in trunk/Tools

[ews-app] Fetch bugs from Bugzilla and submit to Buildbot
https://bugs.webkit.org/show_bug.cgi?id=191947

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/fetcher.py: Added.

2:18 PM Changeset in webkit [238643] by Truitt Savell

2 edits in trunk/LayoutTests

[ Mojave WK1 ] Layout Test fast/images/animated-image-different-dest-size.html fast/images/animated-image-loop-count.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190383

Unreviewed Test Gardening.

platform/mac-wk1/TestExpectations:

2:12 PM Changeset in webkit [238642] by youenn@apple.com

4 edits in trunk/Source/WebCore

imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-transceivers.https.html is flaky on iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=192037

Reviewed by Eric Carlson.

The stats report JS map should be created when resolving the stats promise with WebCore RTCStatsReport.
But resolving the promise might fail in case of a page being suspended.
In that case, no JSRTCStatsReport is created and there is no backing map.
Update the code to reflect that.
Covered by existing test.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::getStats):

Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::LibWebRTCStatsCollector::~LibWebRTCStatsCollector):
(WebCore::LibWebRTCStatsCollector::OnStatsDelivered):

Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:

2:12 PM Changeset in webkit [238641] by achristensen@apple.com

2 edits in trunk/Tools

Fix iOS API test after r238585
https://bugs.webkit.org/show_bug.cgi?id=192022

TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):
On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.

2:11 PM Changeset in webkit [238640] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-app] Configure python logging
https://bugs.webkit.org/show_bug.cgi?id=192005

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/init.py: Configured logging.

2:09 PM Changeset in webkit [238639] by Keith Rollin

12 edits in trunk

Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=192031
<rdar://problem/46286816>

Reviewed by Alex Christensen.

The Generate Derived Sources and Generate Unified Sources build phases
in Xcode need to have their inputs and outputs specified. This
specification will come in the form of .xcfilelist files that will be
attached to these build phases. There is one .xcfilelist file that
lists the input file and one that lists the output files. As part of
this work, the various generate-{derived,unified}-sources scripts that
are executed in these Generate build phases are modified to help in
the creation of these .xcfilelist files. In particular, they can now
be invoked with command-line parameters. These parameters are then
used to alter the normal execution of these scripts, causing them to
produce the .xcfilelist files as opposed to actually generating the
files that are listed in those files.

Source/JavaScriptCore:

Scripts/generate-derived-sources.sh:
Scripts/generate-unified-sources.sh:

Source/WebCore:

No new tests -- no changed functionality.

Scripts/generate-derived-sources.sh:
Scripts/generate-unified-sources.sh:

Source/WebKit:

Scripts/generate-derived-sources.sh:
Scripts/generate-unified-sources.sh:

Tools:

DumpRenderTree/Scripts/generate-derived-sources.sh:
WebKitTestRunner/Scripts/generate-derived-sources.sh:

2:07 PM Changeset in webkit [238638] by Keith Rollin

2 edits in trunk/Source/WTF

Update generate-unified-source-bundles.rb to generate .xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=192029
<rdar://problem/46285918>

Reviewed by Alex Christensen.

Update generate-unified-source-bundles.rb to generate output for
.xcfilelist files. These files are used to indicate the sets of input
and output files to Run Script build phases in Xcode. By invoking
generate-unified-source-bundles.rb with -generate-xcfilelists, the
script generates these .xcfilelist files. These .xcfilelist files can
then be used to specify the inputs and outputs of the Generate Unified
Sources build phases.

Scripts/generate-unified-source-bundles.rb:

2:07 PM Changeset in webkit [238637] by Keith Rollin

9 edits in trunk

Revert print_all_generated_files work in r238008; tighten up target specifications
https://bugs.webkit.org/show_bug.cgi?id=192025
<rdar://problem/46284301>

Reviewed by Alex Christensen.

In r238008, I added a facility for DerivedSources.make makefiles to
print out the list of files that they generate. This output was used
in the generation of .xcfilelist files used to specify the output of
the associated Generate Derived Sources build phases in Xcode. This
approach worked, but it meant that people would need to follow a
specific convention to keep this mechanism working.

Instead of continuing this approach, I'm going to implement a new
facility based on the output of make when passed the -d flag (which
prints dependency information). This new mechanism is completely
automatic and doesn't need maintainers to follow a convention. To that
end, remove most of the work performed in r238008 that supports the
print_all_generated_files target.

At the same time, it's important for the sets of targets and their
dependencies to be complete and correct. Therefore, also include
changes to bring those up-to-date. As part of that, you'll see
prevalent use of a particular technique. Here's an example:

BYTECODE_FILES = \

Bytecodes.h \
BytecodeIndices.h \
BytecodeStructs.h \
InitBytecodes.asm \

#
BYTECODE_FILES_PATTERNS = $(subst .,%,$(BYTECODE_FILES))

all : $(BYTECODE_FILES)

$(BYTECODE_FILES_PATTERNS): $(wildcard $(JavaScriptCore)/generator/*.rb) $(JavaScriptCore)/bytecode/BytecodeList.rb

...

These lines indicate a set of generated files (those specified in
BYTECODE_FILES). These files are generated by the BytecodeList.rb
tool. But, as opposed to the normal rule where a single foo.output is
generated by foo.input plus some additional dependencies, this rule
produces multiple output files from a tool whose connection to the
output files is not immediately clear. A special approach is needed
where a single rule produces multiple output files. The normal way to
implement this is to use an .INTERMEDIATE target. However, we used
this approach in the past and ran into a problem with it, addressing
it with an alternate approach in r210507. The above example shows this
approach. The .'s in the list of target files are replaced with %'s,
and the result is used as the left side of the dependency rule.

Source/JavaScriptCore:

DerivedSources.make:

Source/WebCore:

No new tests -- no changed functionality.

DerivedSources.make:

Source/WebKit:

DerivedSources.make:

Tools:

DumpRenderTree/DerivedSources.make:
WebKitTestRunner/DerivedSources.make:

1:59 PM Changeset in webkit [238636] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-app] Add support to get list of Bugzilla patches needing review
https://bugs.webkit.org/show_bug.cgi?id=191942

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/common/bugzilla.py:

(Bugzilla.get_list_of_patches_needing_reviews): Get list of patches needing review.
(BugzillaBeautifulSoup.fetch_attachment_ids_from_review_queue): Copied from Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
(BugzillaBeautifulSoup._load_query): Ditto.
(BugzillaBeautifulSoup._parse_attachment_ids_request_query): Ditto.

1:55 PM Changeset in webkit [238635] by dbates@webkit.org

6 edits
1 add in trunk

[iOS] Page not defocused when Find-in-page becomes first responder
https://bugs.webkit.org/show_bug.cgi?id=192084
<rdar://problem/46146777>

Reviewed by Tim Horton.

Source/WebKit:

When -becomeFirstResponder and -resignFirstResponder is called the page should become focused
and defocused, respectively. WebKit adjusts it behavior depending on whether it knows it has
focus. This includes decisions about whether to allow an element to be focused. We need to
ensure that WebKit knows whether the web view is focused for it to make good decisions.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewFocused): Check if the content view is the first responder and
hence is accepting keyboard input. Note that picture-in-picture views do not accept keyboard
input.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView becomeFirstResponderForWebView]): Update activity state when the view
becomes focused.
(-[WKContentView resignFirstResponderForWebView]): Update activity state when the view
becomes defocused.

Tools:

Add tests for both Mac and iOS to ensure that when finding a string on the page
that we do not start an input session if a match is found in an <input> and the
WKWebView is not the first responder.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm: Added.

(-[WKWebViewFindStringInputDelegate _webView:didStartInputSession:]):
(-[WKWebViewFindStringFindDelegate findString]):
(-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]):
(-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
(-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]):
(returnNo):
(returnYes):
(viewIsFirstResponder):
(TestWebKitAPI::TEST):

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView): Make the view the first responder before the
window key. This matches the ordering used in PlatformWebView::focus(). No behavior change.

1:49 PM Changeset in webkit [238634] by aakash_jain@apple.com

1 edit
3 adds in trunk/Tools

[ews-app] Add BeautifulSoup
https://bugs.webkit.org/show_bug.cgi?id=191994

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/thirdparty: Added.
BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py: Added.
BuildSlaveSupport/ews-app/ews/thirdparty/init.py: Added.

1:14 PM Changeset in webkit [238633] by achristensen@apple.com

24 edits
1 delete in trunk/Source

Remove dead code from an earlier attempt at implementing safe browsing
https://bugs.webkit.org/show_bug.cgi?id=192067

Reviewed by Chris Dumez.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:
loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

loader/EmptyFrameLoaderClient.h:
loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setShouldSkipSafeBrowsingCheck): Deleted.
(WebCore::FrameLoadRequest::shouldSkipSafeBrowsingCheck): Deleted.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):

loader/FrameLoader.h:

(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadWithNavigationAction):

loader/FrameLoaderClient.h:
loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

loader/PolicyChecker.h:
loader/ShouldSkipSafeBrowsingCheck.h: Removed.

Source/WebKit:

Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

Shared/LoadParameters.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebCoreSupport/WebFrameLoaderClient.h:

1:11 PM Changeset in webkit [238632] by achristensen@apple.com

16 edits in trunk/Source/WebCore

Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=192062

Reviewed by Dean Jackson.

Just adding infrastructure for fixing "the blob bug"

Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::isolatedCopy const):

Modules/indexeddb/IDBDatabaseIdentifier.h:

(WebCore::IDBDatabaseIdentifier::hash const):
(WebCore::IDBDatabaseIdentifier::sessionID const):
(WebCore::IDBDatabaseIdentifier::encode const):
(WebCore::IDBDatabaseIdentifier::decode):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::putOrAddOnServer):

Modules/indexeddb/IDBValue.cpp:

(WebCore::IDBValue::IDBValue):
(WebCore::IDBValue::setAsIsolatedCopy):

Modules/indexeddb/IDBValue.h:

(WebCore::IDBValue::sessionID const):
(WebCore::IDBValue::encode const):
(WebCore::IDBValue::decode):

Modules/indexeddb/server/MemoryIndexCursor.cpp:

(WebCore::IDBServer::MemoryIndexCursor::currentData):

Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:

(WebCore::IDBServer::MemoryObjectStoreCursor::currentData):

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):

Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):

bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueToJSValue):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):

bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValue::sessionID const):

1:09 PM Changeset in webkit [238631] by aakash_jain@apple.com

2 edits
2 adds in trunk/Tools

[ews-app] Add support to download Patch from Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=191943

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/common/bugzilla.py: Added.

(Bugzilla.retrieve_attachment): Retreives the attachment from Bugzilla and saves to disk.
(Bugzilla._fetch_attachment_json):
(Bugzilla.file_path_for_patch):

BuildSlaveSupport/ews-app/ews/common/util.py: Added.

(fetch_data_from_url): Method to fetch data from given url.

BuildSlaveSupport/ews-app/ews/config.py:

1:09 PM Changeset in webkit [238630] by achristensen@apple.com

15 edits in trunk/Source/WebKit

Move logCookieInformation bool from NetworkProcess to NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=192049

Reviewed by Chris Dumez.

Part of an effort to remove globals in the NetworkProcess.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::shouldLogCookieInformation const): Deleted.

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
(WebKit::NetworkResourceLoader::logCookieInformation const):
(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):
(WebKit::NetworkResourceLoader::logCookieInformation):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::logCookieInformation const):

NetworkProcess/NetworkSessionCreationParameters.h:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

NetworkProcess/cocoa/NetworkSessionCocoa.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

12:53 PM Changeset in webkit [238629] by Justin Fan

16 edits
12 copies
3 adds in trunk

[WebGPU] Begin implementation of WebGPURenderPassEncoder and barebones WebGPURenderPassDescriptor
https://bugs.webkit.org/show_bug.cgi?id=191990

Reviewed by Dean Jackson.

Source/WebCore:

Begin implementation of WebGPURenderPassEncoder and its parent interface, WebGPUProgrammablePassEncoder.
Also add code to allow creation of a primitive WebGPURenderPassDescriptor with the sole purpose of providing
a WebGPUTextureView reference to the render pass creation function, WebGPUCommandBuffer::beginRenderPass().

Test: webgpu/render-passes.html

CMakeLists.txt:
DerivedSources.make:
Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::WebGPUCommandBuffer):
(WebCore::WebGPUCommandBuffer::beginRenderPass): Added. Returns a WebGPURenderPassEncoder upon success.

Modules/webgpu/WebGPUCommandBuffer.h:
Modules/webgpu/WebGPUCommandBuffer.idl:
Modules/webgpu/WebGPUProgrammablePassEncoder.cpp: Added.
Modules/webgpu/WebGPUProgrammablePassEncoder.h: Added.
Modules/webgpu/WebGPUProgrammablePassEncoder.idl: Added. Empty (for now) interface parenting WebGPURenderPassEncoder.
Modules/webgpu/WebGPURenderPassDescriptor.h:
Modules/webgpu/WebGPURenderPassDescriptor.idl: Added. Directly handles a WebGPUTextureView attachment; all other color attachment properties set by implementation for now.
Modules/webgpu/WebGPURenderPassEncoder.cpp: Added.

(WebCore::WebGPURenderPassEncoder::create):
(WebCore::WebGPURenderPassEncoder::WebGPURenderPassEncoder):
(WebCore::WebGPURenderPassEncoder::passEncoder const):

Modules/webgpu/WebGPURenderPassEncoder.h: Added. Interface to GPURenderPassEncoder.
Modules/webgpu/WebGPURenderPassEncoder.idl: Added. Allows WebGPU developer to encode commands for the WebGPUCommandBuffer.
Modules/webgpu/WebGPUTextureView.cpp:

(WebCore::WebGPUTextureView::WebGPUTextureView):

Modules/webgpu/WebGPUTextureView.h:

(WebCore::WebGPUTextureView::texture):

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
platform/graphics/gpu/GPUCommandBuffer.h:

(WebCore::GPUCommandBuffer::platformCommandBuffer const):

platform/graphics/gpu/GPUProgrammablePassEncoder.h: Added. Base class for GPURenderPassEncoder.
platform/graphics/gpu/GPURenderPassDescriptor.h: Added.
platform/graphics/gpu/GPURenderPassEncoder.h: Added. Wrapper class for MTLRenderCommandEncoder.
platform/graphics/gpu/GPUTexture.h:

(WebCore::GPUTexture::platformTexture const):

platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm: Added.
platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm: Added.

(WebCore::GPURenderPassEncoder::create): Creates the backing MTLRenderCommandEncoder; returns null if this fails.
(WebCore::GPURenderPassEncoder::GPURenderPassEncoder):
(WebCore::GPURenderPassEncoder::~GPURenderPassEncoder): End encoding before destroying the MTLCommandEncoder to prevent an exception.
(WebCore::GPURenderPassEncoder::platformPassEncoder const):

LayoutTests:

Add tests to ensure proper WebGPURenderPassEncoder creation. To be updated as WebGPURenderPassDescriptor is updated.

webgpu/js/basic-webgpu-functions.js:

(render):

webgpu/render-passes-expected.txt: Added.
webgpu/render-passes.html: Added.

12:28 PM Changeset in webkit [238628] by commit-queue@webkit.org

9 edits in trunk

[XHR] Document.lastModified doesn't work for non-rendered documents
https://bugs.webkit.org/show_bug.cgi?id=179375

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-28
Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

web-platform-tests/xhr/responsexml-document-properties-expected.txt:

Source/WebCore:

Add setOverrideLastModified to override last modified date for
standalone Documents.

Behavior matches Firefox and Chrome.

Test: web-platform-tests/xhr/responsexml-document-properties.htm

dom/Document.cpp:

(WebCore::Document::overrideLastModified):
(WebCore::Document::lastModified const): no need to test m_frame since that's already done in loader().
(WebCore::Document::lastModified): Deleted.

dom/Document.h:
xml/XMLHttpRequest.cpp:

LayoutTests:

Unskip responsexml-document-properties.htm since the dynamic message is gone.

TestExpectations:
platform/wpe/TestExpectations:

12:12 PM Changeset in webkit [238627] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-app] Add methods to update Patch fields
https://bugs.webkit.org/show_bug.cgi?id=191931

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch.set_sent_to_buildbot):
(Patch.set_bug_id):
(Patch.set_obsolete):

11:47 AM Changeset in webkit [238626] by Matt Baker

11 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused DataGrid and TreeOutline code
https://bugs.webkit.org/show_bug.cgi?id=191622
<rdar://problem/46052014>

Reviewed by Devin Rousso.

UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):

UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.insertChildElement):

UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.update):

UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.removeChildrenRecursive): Deleted.

UserInterface/Views/DataGridNode.js:

(WI.DataGridNode.prototype.removeChildren):
(WI.DataGridNode.prototype.removeChildrenRecursive): Deleted.

UserInterface/Views/ErrorObjectView.css:

(.error-object:not(.expanded) .content):
(.error-object .content):
(.error-object:not(.expanded) .tree-outline): Deleted.
(.error-object .tree-outline): Deleted.

UserInterface/Views/ErrorObjectView.js:

(WI.ErrorObjectView):
(WI.ErrorObjectView.prototype.get treeOutline): Deleted.
Use a simple container since TreeOutline features aren't used,
and remove unused property treeOutline.

UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:

(WI.RecordingTraceDetailsSidebarPanel):

UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.removeChildren):
(WI.TreeElement.prototype.removeChildrenRecursive): Deleted.

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline):
(WI.TreeOutline.prototype.removeChildrenRecursive): Deleted.
(WI.TreeOutline.prototype.reattachIfIndexChanged): Deleted.
Removed element parameter now that the only use case has been removed.

11:05 AM Changeset in webkit [238625] by Ryan Haddad

3 edits in trunk/Source/WebKit

Unreviewed, rolling out r238620.

Broke internal builds again.

Reverted changeset:

"Remove @no-unify of InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp"
https://bugs.webkit.org/show_bug.cgi?id=191853
https://trac.webkit.org/changeset/238620

10:56 AM Changeset in webkit [238624] by fred.wang@free.fr

2 edits in trunk/LayoutTests

[iOS Simulator Release WK2] media/no-fullscreen-when-hidden.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=192088

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-28

platform/ios-wk2/TestExpectations: Mark media/no-fullscreen-when-hidden.html as flaky.

10:50 AM Changeset in webkit [238623] by commit-queue@webkit.org

22 edits
4 adds in trunk

Allow WebKit clients to specify a minimum effective width for layout.
https://bugs.webkit.org/show_bug.cgi?id=191499
<rdar://problem/45362678>

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2018-11-28
Reviewed by Wenson Hsieh.

Source/WebCore:

If we ignore the meta viewport (_shouldIgnoreMetaViewport is true), the default layout width will be device
width. For clients that wish to lay out the content with a different width value, we would need to add a way
to specify the effective width for layout.

Tests: fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html

fast/viewport/ios/ipad/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setViewLayoutSize): Add a new argument effectiveWidth.
(WebCore::ViewportConfiguration::nativeWebpageParameters): Make sure minimumScale for nativeWebpageParameters

is small enough so that it won't clamp out the initial scale. If content is wider than the viewport, this
ensures we can still zoom out the page.

(WebCore::ViewportConfiguration::updateConfiguration): update _minimumEffectiveDeviceWidth and apply that to

the layout size scale computation.

(WebCore::ViewportConfiguration::effectiveLayoutSizeScaleFactor): A helper method to return the effective

layout scale factor which is also effected by _minimumEffectiveDeviceWidth.

(WebCore::ViewportConfiguration::updateMinimumLayoutSize): Update m_minimumLayoutSize based on effectiveLayoutSizeScaleFactor().
(WebCore::ViewportConfiguration::description const): Also dump m_minimumEffectiveDeviceWidth.

page/ViewportConfiguration.h: Add a member variable m_minimumEffectiveDeviceWidth.

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm: Add an iVar _minimumEffectiveDeviceWidth.

(-[WKWebView _dispatchSetViewLayoutSize:]): Call the new setViewportConfigurationViewLayoutSize method.
(-[WKWebView _setViewScale:]): Ditto.
(-[WKWebView _setMinimumEffectiveWidth:]): The setter for _minimumEffectiveDeviceWidth.
(-[WKWebView _minimumEffectiveWidth]): Getter for _minimumEffectiveDeviceWidth

UIProcess/API/Cocoa/WKWebViewPrivate.h: Add a property _minimumEffectiveDeviceWidth to WKWebView.
UIProcess/WebPageProxy.h: Change setViewportConfigurationViewLayoutSize to take another argument minimumEffectiveDeviceWidth.
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setViewportConfigurationViewLayoutSize): Also send effectiveWidth to WebContent process.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set the initial effective width to 0 when creating a web page, this tells ViewportConfiguration

to ignore the minimum effective width value.

WebProcess/WebPage/WebPage.h: Change setViewportConfigurationViewLayoutSize to take another argument effectiveWidth.
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setViewportConfigurationViewLayoutSize): Also pass effectiveWidth value to ViewportConfiguration.

Tools:

Allow UIScriptController to set WKWebView's minimum effective width with a new setMinimumEffectiveWidth method.

DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::setMinimumEffectiveWidth):

DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::setViewScale):
(WTR::UIScriptController::setMinimumEffectiveWidth):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setMinimumEffectiveWidth):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::setMinimumEffectiveWidth):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

LayoutTests:

Add two new tests. The first test verifies if we ignore meta viewport, setting a different effective width value
will change the layout width of the page. The second test verifies if we don't ignore meta viewport, we will always
respect that (980pt) and setting a different effective width value won't change the layout width.

fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport-expected.txt: Added.
fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html: Added.
fast/viewport/ios/ipad/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-expected.txt: Added.
fast/viewport/ios/ipad/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html: Added.
resources/ui-helper.js:

(window.UIHelper.setMinimumEffectiveWidth): Add a helper method to set the minimum effective width from a test.
(window.UIHelper):

10:24 AM Changeset in webkit [238622] by stephan.szabo@sony.com

4 edits in trunk/Source/WebCore

Make generic EventHandler methods
https://bugs.webkit.org/show_bug.cgi?id=192032

Reviewed by Michael Catanzaro.

No new tests. No new behavior.

Move mostly generic for non-Apple platform implementations
of methods from EventHandlerGlib into EventHandler. Two
of these also had different Windows implementations, so
to limit behavior change from this, those are currently
overridden for Windows as well as Mac and IOS.

page/EventHandler.cpp:

(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::passMouseMoveEventToSubframe):

page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMousePressEventToSubframe): Deleted.
(WebCore::EventHandler::passMouseReleaseEventToSubframe): Deleted.
(WebCore::EventHandler::widgetDidHandleWheelEvent): Deleted.
(WebCore::EventHandler::tabsToAllFormControls const): Deleted.
(WebCore::EventHandler::focusDocumentView): Deleted.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget): Deleted.
(WebCore::EventHandler::accessKeyModifiers): Deleted.

platform/glib/EventHandlerGLib.cpp:

(WebCore::EventHandler::tabsToAllFormControls const): Deleted.
(WebCore::EventHandler::focusDocumentView): Deleted.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget): Deleted.
(WebCore::EventHandler::passMouseDownEventToWidget): Deleted.
(WebCore::EventHandler::eventActivatedView const): Deleted.
(WebCore::EventHandler::widgetDidHandleWheelEvent): Deleted.
(WebCore::EventHandler::passMousePressEventToSubframe): Deleted.
(WebCore::EventHandler::passMouseMoveEventToSubframe): Deleted.
(WebCore::EventHandler::passMouseReleaseEventToSubframe): Deleted.
(WebCore::EventHandler::accessKeyModifiers): Deleted.

10:16 AM Changeset in webkit [238621] by Alan Coon

7 edits in branches/safari-606-branch/Source

Versioning.

10:16 AM Changeset in webkit [238620] by Fujii Hironori

3 edits in trunk/Source/WebKit

Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp

and InjectedBundleNodeHandle.cpp

WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership

not to be compiled by XCode.

10:05 AM Changeset in webkit [238619] by Michael Catanzaro

3 edits in trunk

[CMake] Automatically disable JIT and enable USE_SYSTEM_MALLOC on unfamiliar architectures
https://bugs.webkit.org/show_bug.cgi?id=186722

Reviewed by Žan Doberšek.

Time for part #2! This change was defeated for GTK and WPE by the code that makes the
options public. We have three options: (a) duplicate the architecture check currently in
WebKitFeatures.cmake in both OptionsGTK.cmake and OptionsWPE.cmake, (b) rely on the result
of that check in OptionsGTK.cmake and OptionsWPE.cmake by using ENABLE_JIT_DEFAULT and
USE_SYSTEM_MALLOC_DEFAULT, a fragile encapsulation violation, or (c) just make the options
private. They have been public up until now because they needed to be turned off on
unsupported architectures. But now they are off by default and enabled only for particular
whitelisted architectures, so they shouldn't be needed anymore.

Note we have to hide ENABLE_SAMPLING_PROFILER as well, since it needs to match the value of
ENABLE_JIT. Again, this is handled properly in WebKitFeatures.cmake, and defeated here in
OptionsGTK.cmake. (This is not a problem for WPE.)

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

9:52 AM Changeset in webkit [238618] by Lucas Forschler

2 edits in trunk/Tools

Fix webkitbot hi command.
https://bugs.webkit.org/show_bug.cgi?id=192080

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

9:51 AM Changeset in webkit [238617] by commit-queue@webkit.org

8 edits in trunk/Source/WebKit

Web Inspector: REGRESSION(r238378): reloading WebInspector after a settings change doesn't re-show WebInspector
https://bugs.webkit.org/show_bug.cgi?id=191971

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-28
Reviewed by Matt Baker.

WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::reopen): Deleted.

WebProcess/WebPage/WebInspector.h:
WebProcess/WebPage/WebInspector.messages.in:

Move reopen out of the WebProcess...

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::reopen):

UIProcess/WebInspectorProxy.h:
UIProcess/WebInspectorProxy.messages.in:

And into the UIProcess where the order of messages won't
be as problematic.

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::reopen):
Send a message to the WebInspectorProxy instead.

9:33 AM Changeset in webkit [238616] by Kocsen Chung

7 edits in trunk/Source

Versioning.

9:28 AM Changeset in webkit [238615] by ap@apple.com

4 edits in trunk/Source

Remove another OS version check from NetworkDataTaskCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=192046

Reviewed by Alex Christensen.

Source/WebKit:

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::statelessCookieStorage):

Source/WTF:

wtf/Platform.h:

9:19 AM Changeset in webkit [238614] by ap@apple.com

6 edits in trunk/Source

Modernize version checks for same site cookie support
https://bugs.webkit.org/show_bug.cgi?id=192054

Reviewed by Tim Horton.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::updateTaskWithFirstPartyForSameSiteCookies):

Also removed runtime checks, which are no longer relevant.

Source/WTF:

wtf/Platform.h:

9:17 AM Changeset in webkit [238613] by Alan Bujtas

5 edits in trunk

[LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
https://bugs.webkit.org/show_bug.cgi?id=192078

Reviewed by Antti Koivisto.

Source/WebCore:

This quirk happens when the body height is 0 which means its vertical margins collapse through (top and bottom margins are adjoining).
However now that we stretch the body they don't collapse through anymore, so we need to use the non-collapsed values instead.

layout/LayoutUnits.h:

(WebCore::Layout::HeightAndMargin::usedMarginValues const):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::stretchHeightToInitialContainingBlock):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

8:50 AM Changeset in webkit [238612] by Keith Rollin

2 edits in trunk/Source/JavaScriptCore

Remove Postprocess Headers dependencies
https://bugs.webkit.org/show_bug.cgi?id=192023
<rdar://problem/46283377>

Reviewed by Mark Lam.

JavaScriptCore's Xcode Postprocess Headers build phase used to have a
dependency on a specific handful of files. In r234227, the script used
in this phase (postprocess-headers.sh) was completely rewritten to
operate on *all* files in JSC's Public and Private headers directories
instead of just this handful. This rewrite makes the previous
dependency specification insufficient, leading to incorrect
incremental builds if the right files weren't touched. Address this by
removing the dependencies completely. This will cause
postprocess-headers.sh to always be executed, even when none of its
files are touch. Running this script all the time is OK, since it has
built-in protections against unnecessarily touching files that haven't
changed.

JavaScriptCore.xcodeproj/project.pbxproj:

7:30 AM Changeset in webkit [238611] by Alan Bujtas

5 edits in trunk

[LFC] Add support for quirk container's collapsing top margin in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=192070

Reviewed by Antti Koivisto.

Source/WebCore:

In quirk mode when the top margin collapsing is computed for a quirk container (body, table cell) and the canditate margin value is
also a quirk value, we just ignore it.

layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isQuirkContainer):
(WebCore::Layout::hasMarginTopQuirkValue):
(WebCore::Layout::shouldIgnoreMarginTopInQuirkContext):
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):

layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isTableCell const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

7:06 AM Changeset in webkit [238610] by ajuma@chromium.org

3 edits
2 adds in trunk

Intersection Observer: rootMargin: gives weird results
https://bugs.webkit.org/show_bug.cgi?id=191975

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Add test coverage.

web-platform-tests/intersection-observer/empty-root-margin-expected.txt: Added.
web-platform-tests/intersection-observer/empty-root-margin.html: Added.

Source/WebCore:

When converting the rootMargin string into a LengthBox, explicitly construct a Length
of size 0px for each dimension, instead of using Length's default constructor. The
default constructor creates a Length with value Auto, which causes us to incorrectly
apply a non-zero rootMargin.

Test: imported/w3c/web-platform-tests/intersection-observer/empty-root-margin.html

page/IntersectionObserver.cpp:

(WebCore::parseRootMargin):

6:56 AM Changeset in webkit [238609] by commit-queue@webkit.org

6 edits
1 add in trunk

[WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
https://bugs.webkit.org/show_bug.cgi?id=192026

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-28
Reviewed by Philippe Normand.

Otherwise we might end up picking a useless one in some applications
(not sure what those application do though).

GStreamer patch proposed as https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/34/diffs

Source/WebCore:

platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:

(WebCore::sortDevices):
(WebCore::GStreamerCaptureDeviceManager::addDevice):
(WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices):

platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h:

Tools:

flatpak/org.webkit.CommonModules.yaml:
gstreamer/jhbuild.modules:
gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Added.

5:50 AM Changeset in webkit [238608] by tpopela@redhat.com

2 edits in trunk/Tools

[GTK] Silence compilation warnings in glib unittests
https://bugs.webkit.org/show_bug.cgi?id=192009

Reviewed by Michael Catanzaro.

Mark the destructor as virtual.

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::~Test):

4:51 AM Changeset in webkit [238607] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WebRTC][GStreamer] Tag all cameras with as 'Unknown' facing mode
https://bugs.webkit.org/show_bug.cgi?id=192028

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-28
Reviewed by Philippe Normand.

platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoCaptureSource::capabilities):

4:41 AM Changeset in webkit [238606] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource
https://bugs.webkit.org/show_bug.cgi?id=192027

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-28
Reviewed by Xabier Rodriguez-Calvar.

Cleaning up a bit the code.

It is a minor refactoring, no new test required.

platform/graphics/gstreamer/GUniquePtrGStreamer.h:
platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::~RealtimeOutgoingAudioSourceLibWebRTC):
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):

platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:

4:40 AM Changeset in webkit [238605] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] Do not run device monitor for device type we do not handle
https://bugs.webkit.org/show_bug.cgi?id=191904

This is useless work and it throws warning about use GstDeviceMonitor without filters.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-28
Reviewed by Philippe Normand.

platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:

(WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices):

12:28 AM Changeset in webkit [238604] by rwlbuis@webkit.org

5 edits in trunk

Block more ports (427, 548, 6697)
https://bugs.webkit.org/show_bug.cgi?id=186092

Reviewed by Frédéric Wang.

Update request-bad-port.html to latest version.

web-platform-tests/fetch/api/request/request-bad-port-expected.txt:
web-platform-tests/fetch/api/request/request-bad-port.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed