⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 1, 2018:

6:03 PM Changeset in webkit [238789] by don.olmstead@sony.com
  • 8 edits in trunk

Cleanup WebKit Features
https://bugs.webkit.org/show_bug.cgi?id=192262

Reviewed by Michael Catanzaro.

.:

Removes unused ENABLE flags from the listing in WebKitFeatures.cmake
and any other associated code. Synced the options in FeatureList.pm to
the feature listing. Sorts the ENABLE flags.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Tools:

Removes obsolete ENABLE options and variable names. Syncs the option's
descriptions with what is present in WebKitFeatures.cmake. Sorts the
options based on the associated define.

  • Scripts/webkitperl/FeatureList.pm:
5:52 PM Changeset in webkit [238788] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Lifetime of HTMLMediaElement is not properly handled in asynchronous actions
https://bugs.webkit.org/show_bug.cgi?id=192087
<rdar://problem/45975230>

Reviewed by Dean Jackson.

The HTMLMediaElement performs operations that allow arbitrary JavaScript to run. We need to make
sure the active media element is protected until those calls complete.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didFinishInsertingNode):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured):
(WebCore::HTMLMediaElement::scheduleConfigureTextTracks):
(WebCore::HTMLMediaElement::scheduleMediaEngineWasUpdated):
(WebCore::HTMLMediaElement::scheduleUpdatePlayState):
(WebCore::HTMLMediaElement::scheduleUpdateMediaState):

2:40 PM Changeset in webkit [238787] by Chris Dumez
  • 14 edits in trunk

[PSON] process-swapping may occur even though opener has handle to openee
https://bugs.webkit.org/show_bug.cgi?id=192277

Reviewed by Antti Koivisto.

Source/WebCore:

Process-swapping may occur even though opener has handle to openee, which is not Web-compatible. The reason
is that we rely on the window not having an opener to process-swap. However, the opener can be disowned,
which does not mean that the opener doesn't still have a handle to its openee.

To address the issue:

  • Renamed openedViaWindowOpenWithOpener flag to openedByDOMWithOpener
  • Make sure this flag gets set if an opener have ever been set for the browsing context
  • Do not process-swap if this flag is set
  • Drop opener from NavigationAction since it does not provide meaningful information to decide whether to process-swap or not.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setOpener):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::openedByDOMWithOpener const):
(WebCore::NavigationAction::setOpenedByDOMWithOpener):
(WebCore::NavigationAction::setOpener): Deleted.
(WebCore::NavigationAction::opener const): Deleted.
(WebCore::NavigationAction::openedViaWindowOpenWithOpener const): Deleted.
(WebCore::NavigationAction::setOpenedViaWindowOpenWithOpener): Deleted.

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

  • page/Page.h:

(WebCore::Page::openedByDOMWithOpener const):
(WebCore::Page::setOpenedByDOMWithOpener):
(WebCore::Page::openedViaWindowOpenWithOpener const): Deleted.
(WebCore::Page::setOpenedViaWindowOpenWithOpener): Deleted.

Source/WebKit:

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):

  • Shared/NavigationActionData.h:
  • UIProcess/API/APINavigation.h:

(API::Navigation::openedByDOMWithOpener const):
(API::Navigation::openedViaWindowOpenWithOpener const): Deleted.
(API::Navigation::opener const): Deleted.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2:09 PM Changeset in webkit [238786] by Simon Fraser
  • 2 edits in trunk/Source/JavaScriptCore

Heap.h refers to the non-existent HeapStatistics
https://bugs.webkit.org/show_bug.cgi?id=187882

Reviewed by Keith Miller.

Just remove the "friend class HeapStatistics".

  • heap/Heap.h:
2:04 PM Changeset in webkit [238785] by ap@apple.com
  • 6 edits in trunk/Source

Modernize version check for _suppressedAutoAddedHTTPHeaders
https://bugs.webkit.org/show_bug.cgi?id=192175

Reviewed by Tim Horton.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h: Curiously, it was forward declared twice, for no

apparent reason.

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Also removed selector check - we only need to support running on 10.13.0 when building
with 10.13.0 SDK.

Source/WTF:

  • wtf/Platform.h:
1:09 PM Changeset in webkit [238784] by Jonathan Bedard
  • 3 edits in trunk/Tools

Unreviewed, rolling out r238764.

Breaks existing layout tests

Reverted changeset:

"webkitpy: Support unicode in MeteredStream"
https://bugs.webkit.org/show_bug.cgi?id=192260
https://trac.webkit.org/changeset/238764

12:08 PM Changeset in webkit [238783] by Simon Fraser
  • 2 edits in trunk/Websites/webkit.org

webkit.org/css-status is broken
https://bugs.webkit.org/show_bug.cgi?id=192278

Reviewed by Zalan Bujtas.

Remove a stray '='.

  • wp-content/themes/webkit/css-status.php:
11:34 AM Changeset in webkit [238782] by chris.reid@sony.com
  • 2 edits in trunk/Source/WebCore

Add generic implementations to FileSystemPOSIX.cpp
https://bugs.webkit.org/show_bug.cgi?id=192263

Reviewed by Yusuke Suzuki.

No new tests, no change in behavior.

Add generic FileSystemPOSIX implementations for:

  • stringFromFileSystemRepresentation
  • fileSystemRepresentation
  • moveFile
  • getVolumeFreeSpace

Also removing an unneeded PLATFORM(GTK) check since GTK is only using FileSystemGlib

  • platform/posix/FileSystemPOSIX.cpp:
8:03 AM Changeset in webkit [238781] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][BFC] Call instrinsicWidthConstraints on the correct formatting state.
https://bugs.webkit.org/show_bug.cgi?id=192274

Reviewed by Antti Koivisto.

When we call intrinsic width on a formatting context root, we need to use the formatting state
that this root constructs and not the one it lives in.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const): it's the caller's responsiblitiy to store the intrinsic values.

7:12 AM Changeset in webkit [238780] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[GStreamer][WebRTC] Build opus decoder support in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=192226

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-12-01
Reviewed by Philippe Normand.

Somehow that was overlooked at some point (it used to work).

  • CMakeLists.txt:
4:23 AM Changeset in webkit [238779] by yusukesuzuki@slowstart.org
  • 6 edits
    3 moves
    2 adds in trunk/Tools

Move URL tests from TestWebKitAPI to TestWTF
https://bugs.webkit.org/show_bug.cgi?id=192275

Reviewed by Keith Miller.

Since URL is moved from WebCore to WTF, we also move tests for them from TestWebKitAPI (TestWebCore) to TestWTF.
But we still have some tests in TestWebCore since only WebCore implements TextEncoding. That part is now decoupled
from URLParser tests and new URLParserTextEncoding.cpp is created.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/PlatformWPE.cmake:
  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/URL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URL.cpp.

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WTF/URLParser.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp.

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: Added.

(TestWebKitAPI::ExpectedParts::isInvalid const):
(TestWebKitAPI::eq):
(TestWebKitAPI::insertTabAtLocation):
(TestWebKitAPI::invalidParts):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):

12:38 AM Changeset in webkit [238778] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Keep TypeMaybeBigInt small
https://bugs.webkit.org/show_bug.cgi?id=192203

Reviewed by Saam Barati.

As BigInt is being implemented, more and more bytecodes start returning BigInt.
It means that ResultType of these bytecodes include TypeMaybeBigInt. However,
TypeMaybeBigInt was large number 0x20, leading to wide instruction since ResultType
easily becomes larger than 32 (e.g. TypeInt32 | TypeMaybeBigInt == 33).

This patch sorts the numbers of TypeMaybeXXX based on the frequency of appearance in
the code.

  • parser/ResultType.h:

Nov 30, 2018:

10:17 PM Changeset in webkit [238777] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix Windows build.

  • UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp:

(WKWebsiteDataStoreEnableCustomNetworkProxySettings):

9:58 PM Changeset in webkit [238776] by Alan Bujtas
  • 2 edits in trunk/Tools

Unreviewed LFC passing test list update.

  • LayoutReloaded/misc/LFC-passing-tests.txt:
8:58 PM Changeset in webkit [238775] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

Fix Windows build.

  • WebView.cpp:
8:49 PM Changeset in webkit [238774] by achristensen@apple.com
  • 5 edits in trunk/Source

Fix Windows build.

Source/WebCore:

  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/curl/PublicSuffixCurl.cpp:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebFrameLoaderClient.h:
8:42 PM Changeset in webkit [238773] by achristensen@apple.com
  • 4 edits in trunk/Source

Fix Windows build.

Source/WebCore:

  • platform/network/curl/CookieJarCurl.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebFrameLoaderClient.h:
8:28 PM Changeset in webkit [238772] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Fix Windows build after r238771
https://bugs.webkit.org/show_bug.cgi?id=190234

  • wtf/URLParser.h:

Just make defaultPortForProtocol public so we don't have to worry about DLL linkage.

7:28 PM Changeset in webkit [238771] by keith_miller@apple.com
  • 774 edits
    5 copies
    11 moves
    1 add in trunk

Move URL from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=190234

Patch by Alex Christensen <achristensen@webkit.org> on 2018-11-30
Reviewed by Keith Miller.

Source/WebCore:

A URL is a low-level concept that does not depend on other classes in WebCore.
We are starting to use URLs in JavaScriptCore for modules.
I need URL and URLParser in a place with fewer dependencies for rdar://problem/44119696

  • Modules/applepay/ApplePaySession.h:
  • Modules/applepay/ApplePayValidateMerchantEvent.h:
  • Modules/applepay/PaymentCoordinator.cpp:
  • Modules/applepay/PaymentCoordinator.h:
  • Modules/applepay/PaymentCoordinatorClient.h:
  • Modules/applepay/PaymentSession.h:
  • Modules/applicationmanifest/ApplicationManifest.h:
  • Modules/beacon/NavigatorBeacon.cpp:
  • Modules/cache/DOMCache.cpp:
  • Modules/fetch/FetchLoader.h:
  • Modules/mediasession/MediaSessionMetadata.h:
  • Modules/mediasource/MediaSourceRegistry.cpp:
  • Modules/mediasource/MediaSourceRegistry.h:
  • Modules/mediastream/MediaStream.cpp:
  • Modules/mediastream/MediaStreamRegistry.cpp:
  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:
  • Modules/notifications/Notification.h:
  • Modules/paymentrequest/MerchantValidationEvent.h:
  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/plugins/PluginReplacement.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/websockets/ThreadableWebSocketChannel.h:
  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketHandshake.cpp:
  • Modules/websockets/WebSocketHandshake.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • PlatformMac.cmake:
  • PlatformWin.cmake:
  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedModuleScriptLoader.h:
  • bindings/js/CachedScriptFetcher.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptModuleLoader.h:
  • bindings/js/ScriptSourceCode.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSInterfaceName.cpp:
  • bindings/scripts/test/JS/JSMapLike.cpp:
  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCEReactions.cpp:
  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
  • bindings/scripts/test/JS/JSTestCallTracer.cpp:
  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
  • bindings/scripts/test/JS/JSTestDOMJIT.cpp:
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
  • bindings/scripts/test/JS/JSTestIterable.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestPluginInterface.cpp:
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
  • bindings/scripts/test/JS/JSTestSerialization.cpp:
  • bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestStringifier.cpp:
  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForPingLoad):
(WebCore::ContentExtensions::applyBlockedStatusToRequest):

  • contentextensions/ContentExtensionsBackend.h:
  • css/CSSValue.h:
  • css/StyleProperties.h:
  • css/StyleResolver.h:
  • css/StyleSheet.h:
  • css/StyleSheetContents.h:
  • css/parser/CSSParserContext.h:

(WebCore::CSSParserContextHash::hash):
(WTF::HashTraits<WebCore::CSSParserContext>::constructDeletedValue):

  • css/parser/CSSParserIdioms.h:
  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDataFromItemList):

  • dom/Document.cpp:

(WebCore::Document::setURL):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::completeURL const):
(WebCore::Document::ensureTemplateDocument):

  • dom/Document.h:

(WebCore::Document::urlForBindings const):

  • dom/Element.cpp:

(WebCore::Element::isJavaScriptURLAttribute const):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::parserContextForElement):

  • dom/Node.cpp:

(WebCore::Node::baseURI const):

  • dom/Node.h:
  • dom/ScriptElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/SecurityContext.h:
  • editing/Editor.cpp:

(WebCore::Editor::pasteboardWriterURL):

  • editing/Editor.h:
  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):

  • editing/cocoa/DataDetection.h:
  • editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::userVisibleString):

  • editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::replaceRichContentWithAttachments):
(WebCore::WebContentReader::readWebArchive):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::plainTextFromPasteboard):
(WebCore::Editor::writeImageToPasteboard):

  • editing/markup.cpp:

(WebCore::removeSubresourceURLAttributes):
(WebCore::createFragmentFromMarkup):

  • editing/markup.h:
  • fileapi/AsyncFileStream.cpp:
  • fileapi/AsyncFileStream.h:
  • fileapi/Blob.h:
  • fileapi/BlobURL.cpp:
  • fileapi/BlobURL.h:
  • fileapi/File.h:
  • fileapi/FileReaderLoader.h:
  • fileapi/ThreadableBlobRegistry.h:
  • history/CachedFrame.h:
  • history/HistoryItem.h:
  • html/DOMURL.cpp:

(WebCore::DOMURL::create):

  • html/DOMURL.h:
  • html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::archiveResourceURL):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed const):
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::setLocation):

  • html/HTMLInputElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:

(WTF::LogArgument<URL>::toString):
(WTF::LogArgument<WebCore::URL>::toString): Deleted.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):

  • html/ImageBitmap.h:
  • html/MediaFragmentURIParser.h:
  • html/PublicURLManager.cpp:
  • html/PublicURLManager.h:
  • html/URLInputType.cpp:
  • html/URLRegistry.h:
  • html/URLSearchParams.cpp:

(WebCore::URLSearchParams::URLSearchParams):
(WebCore::URLSearchParams::toString const):
(WebCore::URLSearchParams::updateURL):
(WebCore::URLSearchParams::updateFromAssociatedURL):

  • html/URLUtils.h:

(WebCore::URLUtils<T>::setHost):
(WebCore::URLUtils<T>::setPort):

  • html/canvas/CanvasRenderingContext.cpp:
  • html/canvas/CanvasRenderingContext.h:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/XSSAuditor.cpp:

(WebCore::semicolonSeparatedValueContainsJavaScriptURL):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::filterInputToken):
(WebCore::XSSAuditor::filterButtonToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::isLikelySafeResource):

  • html/parser/XSSAuditor.h:
  • html/parser/XSSAuditorDelegate.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::openInNewTab):

  • inspector/InspectorInstrumentation.h:
  • inspector/agents/InspectorNetworkAgent.cpp:
  • inspector/agents/InspectorNetworkAgent.h:
  • inspector/agents/InspectorPageAgent.h:
  • inspector/agents/InspectorWorkerAgent.h:
  • loader/ApplicationManifestLoader.h:
  • loader/CookieJar.h:
  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::maybeLoadEmpty):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::serverRedirectSourceForHistory const):

  • loader/DocumentWriter.h:
  • loader/FormSubmission.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::createWindow):

  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::currentItemShouldBeReplaced const):
(WebCore::HistoryController::initializeItem):

  • loader/LinkLoader.h:
  • loader/LoadTiming.h:
  • loader/LoaderStrategy.h:
  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::checkFormForMixedContent const):

  • loader/MixedContentChecker.h:
  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation const):

  • loader/NavigationScheduler.h:
  • loader/PingLoader.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • loader/ResourceLoadInfo.h:
  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::requestStorageAccessUnderOpener):

  • loader/ResourceLoadObserver.h:
  • loader/ResourceLoadStatistics.h:
  • loader/ResourceLoader.h:
  • loader/ResourceTiming.h:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):

  • loader/SubframeLoader.h:
  • loader/SubstituteData.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/ManifestParser.cpp:
  • loader/appcache/ManifestParser.h:
  • loader/archive/ArchiveResourceCollection.h:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection):

  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/MemoryCache.h:
  • loader/icon/IconLoader.h:
  • loader/mac/LoaderNSURLExtras.mm:
  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/ChromeClient.h:
  • page/ClientOrigin.h:
  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isInsecureScriptAccess):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • page/DragController.h:
  • page/EventSource.h:
  • page/Frame.h:
  • page/FrameView.h:
  • page/History.h:
  • page/Location.cpp:

(WebCore::Location::url const):
(WebCore::Location::reload):

  • page/Location.h:
  • page/Page.h:
  • page/PageSerializer.h:
  • page/Performance.h:
  • page/PerformanceResourceTiming.cpp:
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):

  • page/SecurityOrigin.h:
  • page/SecurityOriginData.h:
  • page/SecurityOriginHash.h:
  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::shouldInheritSecurityOriginFromOwner):

  • page/SecurityPolicy.h:
  • page/SettingsBase.h:
  • page/ShareData.h:
  • page/SocketProvider.h:
  • page/UserContentProvider.h:
  • page/UserContentURLPattern.cpp:
  • page/UserContentURLPattern.h:
  • page/UserScript.h:
  • page/UserStyleSheet.h:
  • page/VisitedLinkStore.h:
  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyClient.h:
  • page/csp/ContentSecurityPolicyDirectiveList.h:
  • page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::portMatches const):

  • page/csp/ContentSecurityPolicySource.h:
  • page/csp/ContentSecurityPolicySourceList.cpp:
  • page/csp/ContentSecurityPolicySourceList.h:
  • page/csp/ContentSecurityPolicySourceListDirective.cpp:
  • platform/ContentFilterUnblockHandler.h:
  • platform/ContextMenuItem.h:
  • platform/Cookie.h:
  • platform/CookiesStrategy.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FileStream.h:
  • platform/LinkIcon.h:
  • platform/Pasteboard.cpp:

(WebCore::Pasteboard::canExposeURLToDOMWhenPasteboardContainsFiles):

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h:
  • platform/PasteboardWriterData.cpp:

(WebCore::PasteboardWriterData::setURLData):
(WebCore::PasteboardWriterData::setURL): Deleted.

  • platform/PasteboardWriterData.h:
  • platform/PlatformPasteboard.h:
  • platform/PromisedAttachmentInfo.h:
  • platform/SSLKeyGenerator.h:
  • platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::isBuiltinScheme):

  • platform/SharedBuffer.h:
  • platform/SharedStringHash.cpp:
  • platform/SharedStringHash.h:
  • platform/SourcesSoup.txt:
  • platform/UserAgent.h:
  • platform/UserAgentQuirks.cpp:
  • platform/UserAgentQuirks.h:
  • platform/cocoa/NetworkExtensionContentFilter.h:
  • platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::willSendRequest):

  • platform/glib/SSLKeyGeneratorGLib.cpp: Copied from Source/WebCore/page/ShareData.h.

(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):

  • platform/glib/UserAgentGLib.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/ImageObserver.h:
  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcSetUri):

  • platform/graphics/iso/ISOVTTCue.cpp:
  • platform/graphics/win/GraphicsContextDirect2D.cpp:
  • platform/gtk/DragImageGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PlatformPasteboardGtk.cpp:
  • platform/gtk/SelectionData.h:
  • platform/ios/PasteboardIOS.mm:
  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

  • platform/ios/QuickLook.h:
  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asPlainText const):

  • platform/mac/DragImageMac.mm:
  • platform/mac/FileSystemMac.mm:

(WebCore::FileSystem::setMetadataURL):

  • platform/mac/PasteboardMac.mm:
  • platform/mac/PasteboardWriter.mm:

(WebCore::createPasteboardWriter):

  • platform/mac/PlatformPasteboardMac.mm:
  • platform/mac/PublicSuffixMac.mm:

(WebCore::decodeHostName):

  • platform/mac/SSLKeyGeneratorMac.mm:
  • platform/mac/WebCoreNSURLExtras.h:
  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isArmenianLookalikeCharacter): Deleted.
(WebCore::isArmenianScriptCharacter): Deleted.
(WebCore::isASCIIDigitOrValidHostCharacter): Deleted.
(WebCore::isLookalikeCharacter): Deleted.
(WebCore::whiteListIDNScript): Deleted.
(WebCore::readIDNScriptWhiteListFile): Deleted.
(WebCore::allCharactersInIDNScriptWhiteList): Deleted.
(WebCore::isSecondLevelDomainNameAllowedByTLDRules): Deleted.
(WebCore::isRussianDomainNameCharacter): Deleted.
(WebCore::allCharactersAllowedByTLDRules): Deleted.
(WebCore::mapHostNameWithRange): Deleted.
(WebCore::hostNameNeedsDecodingWithRange): Deleted.
(WebCore::hostNameNeedsEncodingWithRange): Deleted.
(WebCore::decodeHostNameWithRange): Deleted.
(WebCore::encodeHostNameWithRange): Deleted.
(WebCore::decodeHostName): Deleted.
(WebCore::encodeHostName): Deleted.
(WebCore::collectRangesThatNeedMapping): Deleted.
(WebCore::collectRangesThatNeedEncoding): Deleted.
(WebCore::collectRangesThatNeedDecoding): Deleted.
(WebCore::applyHostNameFunctionToMailToURLString): Deleted.
(WebCore::applyHostNameFunctionToURLString): Deleted.
(WebCore::mapHostNames): Deleted.
(WebCore::stringByTrimmingWhitespace): Deleted.
(WebCore::URLByTruncatingOneCharacterBeforeComponent): Deleted.
(WebCore::URLByRemovingResourceSpecifier): Deleted.
(WebCore::URLWithData): Deleted.
(WebCore::dataWithUserTypedString): Deleted.
(WebCore::URLWithUserTypedString): Deleted.
(WebCore::URLWithUserTypedStringDeprecated): Deleted.
(WebCore::hasQuestionMarkOnlyQueryString): Deleted.
(WebCore::dataForURLComponentType): Deleted.
(WebCore::URLByRemovingComponentAndSubsequentCharacter): Deleted.
(WebCore::URLByRemovingUserInfo): Deleted.
(WebCore::originalURLData): Deleted.
(WebCore::createStringWithEscapedUnsafeCharacters): Deleted.
(WebCore::userVisibleString): Deleted.
(WebCore::isUserVisibleURL): Deleted.
(WebCore::rangeOfURLScheme): Deleted.
(WebCore::looksLikeAbsoluteURL): Deleted.

  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/network/BlobPart.h:
  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/CookieRequestHeaderFieldProxy.h:
  • platform/network/CredentialStorage.cpp:
  • platform/network/CredentialStorage.h:
  • platform/network/DataURLDecoder.cpp:
  • platform/network/DataURLDecoder.h:
  • platform/network/FormData.h:
  • platform/network/ProxyServer.h:
  • platform/network/ResourceErrorBase.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::didReceiveResponse):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::redirectedRequest const):

  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.h:
  • platform/network/SocketStreamHandle.h:
  • platform/network/cf/DNSResolveQueueCFNet.cpp:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceErrorCF.cpp:
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:
  • platform/network/curl/CookieJarCurlDatabase.cpp: Added.

(WebCore::cookiesForSession):
(WebCore::CookieJarCurlDatabase::setCookiesFromDOM const):
(WebCore::CookieJarCurlDatabase::setCookiesFromHTTPResponse const):
(WebCore::CookieJarCurlDatabase::cookiesForDOM const):
(WebCore::CookieJarCurlDatabase::cookieRequestHeaderFieldValue const):
(WebCore::CookieJarCurlDatabase::cookiesEnabled const):
(WebCore::CookieJarCurlDatabase::getRawCookies const):
(WebCore::CookieJarCurlDatabase::deleteCookie const):
(WebCore::CookieJarCurlDatabase::getHostnamesWithCookies const):
(WebCore::CookieJarCurlDatabase::deleteCookiesForHostnames const):
(WebCore::CookieJarCurlDatabase::deleteAllCookies const):
(WebCore::CookieJarCurlDatabase::deleteAllCookiesModifiedSince const):

  • platform/network/curl/CookieJarDB.cpp:
  • platform/network/curl/CookieUtil.h:
  • platform/network/curl/CurlContext.h:
  • platform/network/curl/CurlProxySettings.h:
  • platform/network/curl/CurlResponse.h:
  • platform/network/curl/NetworkStorageSessionCurl.cpp:
  • platform/network/curl/ProxyServerCurl.cpp:
  • platform/network/curl/SocketStreamHandleImplCurl.cpp:
  • platform/network/mac/ResourceErrorMac.mm:
  • platform/network/soup/NetworkStorageSessionSoup.cpp:
  • platform/network/soup/ProxyServerSoup.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequest.h:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/SocketStreamHandleImplSoup.cpp:
  • platform/network/soup/SoupNetworkSession.cpp:
  • platform/network/soup/SoupNetworkSession.h:
  • platform/text/TextEncoding.h:
  • platform/win/BString.cpp:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/DragImageWin.cpp:
  • platform/win/PasteboardWin.cpp:
  • plugins/PluginData.h:
  • rendering/HitTestResult.h:
  • rendering/RenderAttachment.cpp:
  • svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::sourceURI const):

  • svg/SVGURIReference.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.h:
  • svg/graphics/SVGImageForContainer.h:
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

  • testing/Internals.mm:

(WebCore::Internals::userVisibleString):

  • testing/MockContentFilter.cpp:

(WebCore::MockContentFilter::willSendRequest):

  • testing/MockPaymentCoordinator.cpp:
  • testing/js/WebCoreTestSupport.cpp:
  • workers/AbstractWorker.h:
  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerInspectorProxy.h:
  • workers/WorkerLocation.h:
  • workers/WorkerScriptLoader.h:
  • workers/WorkerThread.cpp:
  • workers/WorkerThread.h:
  • workers/service/ServiceWorker.h:
  • workers/service/ServiceWorkerClientData.h:
  • workers/service/ServiceWorkerContainer.cpp:
  • workers/service/ServiceWorkerContextData.h:
  • workers/service/ServiceWorkerData.h:
  • workers/service/ServiceWorkerJobData.h:
  • workers/service/ServiceWorkerRegistrationKey.cpp:
  • workers/service/ServiceWorkerRegistrationKey.h:

(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):

  • worklets/WorkletGlobalScope.h:
  • xml/XMLHttpRequest.h:

Source/WebKit:

  • NetworkProcess/Cookies/WebCookieManager.cpp:
  • NetworkProcess/Cookies/WebCookieManager.h:
  • NetworkProcess/Cookies/WebCookieManager.messages.in:
  • NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
  • NetworkProcess/Downloads/Download.h:
  • NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::publishDownloadProgress):

  • NetworkProcess/Downloads/DownloadManager.h:
  • NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::publishProgress):

  • NetworkProcess/Downloads/PendingDownload.h:
  • NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::publishProgress):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::unregisterBlobURL):
(WebKit::NetworkBlobRegistry::blobSize):
(WebKit::NetworkBlobRegistry::filesInBlob):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::didReceiveResponse):

  • NetworkProcess/NetworkDataTaskBlob.cpp:
  • NetworkProcess/NetworkLoadChecker.h:

(WebKit::NetworkLoadChecker::setContentExtensionController):
(WebKit::NetworkLoadChecker::url const):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::writeBlobToFilePath):
(WebKit::NetworkProcess::publishDownloadProgress):
(WebKit::NetworkProcess::preconnectTo):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkSocketStream.cpp:

(WebKit::NetworkSocketStream::create):

  • NetworkProcess/NetworkSocketStream.h:
  • NetworkProcess/PingLoad.h:
  • NetworkProcess/ServiceWorker/WebSWServerConnection.h:
  • NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveRecords):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCache.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::retrieveRecords):

  • NetworkProcess/cache/CacheStorageEngineConnection.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
(WebKit::NetworkCache::Statistics::recordRevalidationSuccess):

  • NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:

(WebKit::NetworkCache::SubresourceInfo::firstPartyForCookies const):

  • NetworkProcess/capture/NetworkCaptureEvent.cpp:

(WebKit::NetworkCapture::Request::operator WebCore::ResourceRequest const):
(WebKit::NetworkCapture::Response::operator WebCore::ResourceResponse const):
(WebKit::NetworkCapture::Error::operator WebCore::ResourceError const):

  • NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::findBestFuzzyMatch):
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
(WebKit::NetworkCapture::Manager::urlIdentifyingCommonDomain):

  • NetworkProcess/capture/NetworkCaptureManager.h:
  • NetworkProcess/capture/NetworkCaptureResource.cpp:

(WebKit::NetworkCapture::Resource::url):
(WebKit::NetworkCapture::Resource::queryParameters):

  • NetworkProcess/capture/NetworkCaptureResource.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::openCFURLRef):
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):

  • Shared/API/APIURL.h:

(API::URL::create):
(API::URL::equals):
(API::URL::URL):
(API::URL::url const):
(API::URL::parseURLIfNecessary const):

  • Shared/API/APIUserContentURLPattern.h:

(API::UserContentURLPattern::matchesURL const):

  • Shared/API/c/WKURLRequest.cpp:
  • Shared/API/c/WKURLResponse.cpp:
  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

  • Shared/API/glib/WebKitURIRequest.cpp:
  • Shared/API/glib/WebKitURIResponse.cpp:
  • Shared/APIWebArchiveResource.mm:

(API::WebArchiveResource::WebArchiveResource):

  • Shared/AssistedNodeInformation.h:
  • Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]):
(): Deleted.

  • Shared/SessionState.h:
  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::itemIsInSameDocument const):

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebErrors.h:
  • Shared/WebHitTestResultData.cpp:
  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::encode):
(IPC::decode):

  • Shared/gtk/WebErrorsGtk.cpp:
  • Shared/ios/InteractionInformationAtPosition.h:
  • UIProcess/API/APIHTTPCookieStore.h:
  • UIProcess/API/APINavigation.cpp:

(API::Navigation::appendRedirectionURL):

  • UIProcess/API/APINavigation.h:

(API::Navigation::takeRedirectChain):

  • UIProcess/API/APINavigationAction.h:
  • UIProcess/API/APINavigationClient.h:

(API::NavigationClient::signedPublicKeyAndChallengeString):
(API::NavigationClient::contentRuleListNotification):
(API::NavigationClient::webGLLoadPolicy const):
(API::NavigationClient::resolveWebGLLoadPolicy const):

  • UIProcess/API/APIUIClient.h:

(API::UIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/API/APIUserScript.cpp:

(API::UserScript::generateUniqueURL):

  • UIProcess/API/APIUserScript.h:
  • UIProcess/API/APIUserStyleSheet.cpp:

(API::UserStyleSheet::generateUniqueURL):

  • UIProcess/API/APIUserStyleSheet.h:
  • UIProcess/API/C/WKOpenPanelResultListener.cpp:

(filePathsFromFileURLs):

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadPlainTextStringWithUserData):
(WKPageSetPageUIClient):
(WKPageSetPageNavigationClient):

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):

  • UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
  • UIProcess/API/Cocoa/WKUserScript.mm:

(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:userContentWorld:]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _showSafeBrowsingWarningWithTitle:warning:details:completionHandler:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration setURLSchemeHandler:forURLScheme:]):
(-[WKWebViewConfiguration urlSchemeHandlerForURLScheme:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
  • UIProcess/API/Cocoa/_WKApplicationManifest.mm:

(-[_WKApplicationManifest initWithCoder:]):
(+[_WKApplicationManifest applicationManifestFromJSON:manifestURL:documentURL:]):

  • UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):

  • UIProcess/API/glib/IconDatabase.cpp:
  • UIProcess/API/glib/WebKitCookieManager.cpp:

(webkit_cookie_manager_get_cookies):

  • UIProcess/API/glib/WebKitFileChooserRequest.cpp:
  • UIProcess/API/glib/WebKitSecurityOrigin.cpp:

(webkit_security_origin_new_for_uri):

  • UIProcess/API/glib/WebKitUIClient.cpp:
  • UIProcess/API/glib/WebKitURISchemeRequest.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_load_plain_text):

  • UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::validateMerchant):

  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKPaymentRequest):

  • UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

  • UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::navigateBrowsingContext):
(WebKit::domainByAddingDotPrefixIfNeeded):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

  • UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didFinish):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::contentRuleListNotification):
(WebKit::NavigationState::NavigationClient::willPerformClientRedirect):
(WebKit::NavigationState::NavigationClient::didPerformClientRedirect):
(WebKit::NavigationState::NavigationClient::signedPublicKeyAndChallengeString):

  • UIProcess/Cocoa/SafeBrowsingResultCocoa.mm: Copied from Source/WebKit/WebProcess/Network/WebSocketProvider.h.

(WebKit::SafeBrowsingResult::SafeBrowsingResult):

  • UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:

(WebKit::reportAnErrorURL):
(WebKit::malwareDetailsURL):
(WebKit::safeBrowsingDetailsText):
(WebKit::SafeBrowsingWarning::SafeBrowsingWarning):

  • UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

(-[_WKPreviewControllerDataSource finish:]):
(WebKit::SystemPreviewController::finish):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::saveDataToFileInDownloadsFolder):
(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):

  • UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:

(-[WKReloadFrameErrorRecoveryAttempter attemptRecovery]):

  • UIProcess/Cocoa/WKSafeBrowsingWarning.h:
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingWarning:completionHandler:]):

  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::WebViewImpl::writeToURLForFilePromiseProvider):

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::publishProgress):

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::setRedirectChain):
(WebKit::DownloadProxy::redirectChain const):

  • UIProcess/FrameLoadState.cpp:

(WebKit::FrameLoadState::didStartProvisionalLoad):
(WebKit::FrameLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::FrameLoadState::didSameDocumentNotification):
(WebKit::FrameLoadState::setUnreachableURL):

  • UIProcess/FrameLoadState.h:

(WebKit::FrameLoadState::url const):
(WebKit::FrameLoadState::setURL):
(WebKit::FrameLoadState::provisionalURL const):
(WebKit::FrameLoadState::unreachableURL const):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::writeBlobToFilePath):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::showSafeBrowsingWarning):

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::hasOnlySecureContent):

  • UIProcess/Plugins/PluginInfoStore.cpp:
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/SafeBrowsingResult.h: Copied from Source/WebKit/UIProcess/SystemPreviewController.h.

(WebKit::SafeBrowsingResult::create):
(WebKit::SafeBrowsingResult::url const):
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::isPhishing const):
(WebKit::SafeBrowsingResult::isMalware const):
(WebKit::SafeBrowsingResult::isUnwantedSoftware const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const):

  • UIProcess/SafeBrowsingWarning.h:

(WebKit::SafeBrowsingWarning::create):

  • UIProcess/SuspendedPageProxy.cpp:
  • UIProcess/SystemPreviewController.h:
  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url const):
(WebKit::WebFrameProxy::provisionalURL const):
(WebKit::WebFrameProxy::unreachableURL const):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebOpenPanelResultListenerProxy.cpp:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadDataWithNavigation):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didChangeProvisionalURLForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::contentRuleListNotification):
(WebKit::WebPageProxy::processDidTerminate):
(WebKit::WebPageProxy::signedPublicKeyAndChallengeString):
(WebKit::WebPageProxy::setURLSchemeHandlerForScheme):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::tryPrewarmWithDomainInformation):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::setPrevalentResourceForDebugMode):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/ios/DragDropInteractionState.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::showSafeBrowsingWarning):

  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):

  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):

  • UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView actionSheetAssistant:shareElementWithURL:rect:]):

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView actionSheetAssistant:shareElementWithURL:rect:]):

  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _updateLocationInfo]):

  • UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::decodeLegacySessionState):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::showSafeBrowsingWarning):

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):

  • UIProcess/win/WebInspectorProxyWin.cpp:
  • WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::showPaymentUI):
(WebKit::WebPaymentCoordinator::validateMerchant):

  • WebProcess/ApplePay/WebPaymentCoordinator.h:
  • WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doRetrieveRecords):

  • WebProcess/Cache/WebCacheStorageConnection.h:
  • WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerFileBlobURL):

  • WebProcess/FileAPI/BlobRegistryProxy.h:
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::willLoadDataRequest):
(API::InjectedBundle::PageLoaderClient::userAgentForURL const):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageHasLocalDataForURL):

  • WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp:

(convertToUTF8String):

  • WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::preconnectTo):

  • WebProcess/Network/WebLoaderStrategy.h:
  • WebProcess/Network/WebSocketProvider.h:
  • WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::WebSocketStream):

  • WebProcess/Network/WebSocketStream.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::clickedLink):

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performURLRequest):
(WebKit::PluginView::performJavaScriptURLRequest):

  • WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::webVisiblePluginInfo):

  • WebProcess/Plugins/WebPluginInfoProvider.h:
  • WebProcess/Storage/WebSWClientConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/UserContent/WebUserContentController.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::signedPublicKeyAndChallengeString const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::shouldForceUniversalAccessFromLocalURL):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::readURLFromPasteboard):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebPage/VisitedLinkTableController.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::allowsFollowingLink const):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):
(WebKit::WebPage::dumpHistoryForTesting):
(WebKit::WebPage::sendCSPViolationReport):
(WebKit::WebPage::addUserScript):
(WebKit::WebPage::addUserStyleSheet):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::frameURL const):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::sendPrewarmInformation):

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::activePagesOrigins):

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:
  • WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKitLegacy/mac:

  • DOM/DOMAttr.mm:
  • DOM/DOMBlob.mm:
  • DOM/DOMCSSCharsetRule.mm:
  • DOM/DOMCSSImportRule.mm:
  • DOM/DOMCSSMediaRule.mm:
  • DOM/DOMCSSPageRule.mm:
  • DOM/DOMCSSPrimitiveValue.mm:
  • DOM/DOMCSSRule.mm:
  • DOM/DOMCSSStyleDeclaration.mm:
  • DOM/DOMCSSStyleRule.mm:
  • DOM/DOMCSSStyleSheet.mm:
  • DOM/DOMCSSValue.mm:
  • DOM/DOMCharacterData.mm:
  • DOM/DOMCounter.mm:
  • DOM/DOMDocument.mm:
  • DOM/DOMDocumentFragment.mm:
  • DOM/DOMDocumentType.mm:
  • DOM/DOMEvent.mm:
  • DOM/DOMFile.mm:
  • DOM/DOMHTMLAnchorElement.mm:
  • DOM/DOMHTMLAppletElement.mm:
  • DOM/DOMHTMLAreaElement.mm:
  • DOM/DOMHTMLBRElement.mm:
  • DOM/DOMHTMLBaseElement.mm:
  • DOM/DOMHTMLBaseFontElement.mm:
  • DOM/DOMHTMLBodyElement.mm:
  • DOM/DOMHTMLButtonElement.mm:
  • DOM/DOMHTMLCanvasElement.mm:
  • DOM/DOMHTMLCollection.mm:
  • DOM/DOMHTMLDivElement.mm:
  • DOM/DOMHTMLDocument.mm:
  • DOM/DOMHTMLElement.mm:
  • DOM/DOMHTMLEmbedElement.mm:
  • DOM/DOMHTMLFieldSetElement.mm:
  • DOM/DOMHTMLFontElement.mm:
  • DOM/DOMHTMLFormElement.mm:
  • DOM/DOMHTMLFrameElement.mm:
  • DOM/DOMHTMLFrameSetElement.mm:
  • DOM/DOMHTMLHRElement.mm:
  • DOM/DOMHTMLHeadElement.mm:
  • DOM/DOMHTMLHeadingElement.mm:
  • DOM/DOMHTMLHtmlElement.mm:
  • DOM/DOMHTMLIFrameElement.mm:
  • DOM/DOMHTMLImageElement.mm:
  • DOM/DOMHTMLInputElement.mm:
  • DOM/DOMHTMLLIElement.mm:
  • DOM/DOMHTMLLabelElement.mm:
  • DOM/DOMHTMLLegendElement.mm:
  • DOM/DOMHTMLLinkElement.mm:
  • DOM/DOMHTMLMapElement.mm:
  • DOM/DOMHTMLMarqueeElement.mm:
  • DOM/DOMHTMLMediaElement.mm:
  • DOM/DOMHTMLMetaElement.mm:
  • DOM/DOMHTMLModElement.mm:
  • DOM/DOMHTMLOListElement.mm:
  • DOM/DOMHTMLObjectElement.mm:
  • DOM/DOMHTMLOptGroupElement.mm:
  • DOM/DOMHTMLOptionElement.mm:
  • DOM/DOMHTMLOptionsCollection.mm:
  • DOM/DOMHTMLParagraphElement.mm:
  • DOM/DOMHTMLParamElement.mm:
  • DOM/DOMHTMLQuoteElement.mm:
  • DOM/DOMHTMLScriptElement.mm:
  • DOM/DOMHTMLSelectElement.mm:
  • DOM/DOMHTMLStyleElement.mm:
  • DOM/DOMHTMLTableCaptionElement.mm:
  • DOM/DOMHTMLTableCellElement.mm:
  • DOM/DOMHTMLTableColElement.mm:
  • DOM/DOMHTMLTableElement.mm:
  • DOM/DOMHTMLTableRowElement.mm:
  • DOM/DOMHTMLTableSectionElement.mm:
  • DOM/DOMHTMLTitleElement.mm:
  • DOM/DOMHTMLUListElement.mm:
  • DOM/DOMHTMLVideoElement.mm:
  • DOM/DOMKeyboardEvent.mm:
  • DOM/DOMMediaList.mm:
  • DOM/DOMMouseEvent.mm:
  • DOM/DOMMutationEvent.mm:
  • DOM/DOMNamedNodeMap.mm:
  • DOM/DOMProcessingInstruction.mm:
  • DOM/DOMRange.mm:
  • DOM/DOMStyleSheet.mm:
  • DOM/DOMText.mm:
  • DOM/DOMTextEvent.mm:
  • DOM/DOMTokenList.mm:
  • DOM/DOMUIEvent.mm:
  • DOM/DOMXPathResult.mm:
  • History/WebHistoryItem.mm:
  • Misc/WebNSURLExtras.mm:

(-[NSURL _web_userVisibleString]):
(-[NSURL _web_URLByRemovingUserInfo]):
(-[NSURL _web_dataForURLComponentType:]):
(-[NSURL _web_schemeData]):
(-[NSURL _web_hostData]):

  • Misc/WebUserContentURLPattern.mm:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:
  • Plugins/WebNetscapePluginStream.h:

(WebNetscapePluginStream::setRequestURL):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::signedPublicKeyAndChallengeString const):

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory):

  • WebCoreSupport/WebPaymentCoordinatorClient.h:
  • WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::showPaymentUI):

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::readURLFromPasteboard):

  • WebCoreSupport/WebPluginInfoProvider.h:
  • WebCoreSupport/WebPluginInfoProvider.mm:

(WebPluginInfoProvider::webVisiblePluginInfo):

  • WebCoreSupport/WebSecurityOrigin.mm:
  • WebCoreSupport/WebVisitedLinkStore.h:
  • WebView/WebDataSource.mm:
  • WebView/WebFrame.mm:

(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]):

  • WebView/WebPDFView.mm:
  • WebView/WebScriptDebugger.mm:
  • WebView/WebViewInternal.h:

Source/WebKitLegacy/win:

  • MarshallingHelpers.cpp:
  • MarshallingHelpers.h:
  • Plugins/PluginDatabase.cpp:
  • Plugins/PluginDatabase.h:
  • Plugins/PluginDatabaseWin.cpp:
  • Plugins/PluginStream.h:
  • Plugins/PluginView.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPluginInfoProvider.cpp:

(WebPluginInfoProvider::webVisiblePluginInfo):

  • WebCoreSupport/WebPluginInfoProvider.h:
  • WebCoreSupport/WebVisitedLinkStore.h:
  • WebDataSource.cpp:
  • WebDownload.h:
  • WebElementPropertyBag.cpp:
  • WebFrame.h:
  • WebHistory.cpp:
  • WebHistory.h:
  • WebHistoryItem.cpp:
  • WebResource.cpp:

(WebResource::WebResource):

  • WebResource.h:
  • WebSecurityOrigin.cpp:
  • WebURLResponse.cpp:

(WebURLResponse::createInstance):

  • WebUserContentURLPattern.cpp:
  • WebView.h:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Forward.h:
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformMac.cmake:
  • wtf/PlatformWPE.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/URL.cpp: Renamed from Source/WebCore/platform/URL.cpp.

(WTF::URL::protocolIs):

  • wtf/URL.h: Renamed from Source/WebCore/platform/URL.h.
  • wtf/URLHash.h: Renamed from Source/WebCore/platform/URLHash.h.

(WTF::URLHash::hash):
(WTF::URLHash::equal):

  • wtf/URLParser.cpp: Renamed from Source/WebCore/platform/URLParser.cpp.

(WTF::URLParser::isInUserInfoEncodeSet):
(WTF::URLParser::parseAuthority):

  • wtf/URLParser.h: Renamed from Source/WebCore/platform/URLParser.h.

(WTF::URLParser::URLParser):
(WTF::URLParser::result):

  • wtf/cf/CFURLExtras.cpp: Renamed from Source/WebCore/platform/cf/CFURLExtras.cpp.
  • wtf/cf/CFURLExtras.h: Renamed from Source/WebCore/platform/cf/CFURLExtras.h.
  • wtf/cf/URLCF.cpp: Renamed from Source/WebCore/platform/cf/URLCF.cpp.
  • wtf/cocoa/NSURLExtras.h: Copied from Source/WebCore/loader/archive/ArchiveResourceCollection.h.
  • wtf/cocoa/NSURLExtras.mm: Copied from Source/WebCore/platform/mac/WebCoreNSURLExtras.mm.

(WTF::isArmenianLookalikeCharacter):
(WTF::isArmenianScriptCharacter):
(WTF::isASCIIDigitOrValidHostCharacter):
(WTF::isLookalikeCharacter):
(WTF::whiteListIDNScript):
(WTF::readIDNScriptWhiteListFile):
(WTF::allCharactersInIDNScriptWhiteList):
(WTF::isSecondLevelDomainNameAllowedByTLDRules):
(WTF::isRussianDomainNameCharacter):
(WTF::allCharactersAllowedByTLDRules):
(WTF::mapHostNameWithRange):
(WTF::hostNameNeedsDecodingWithRange):
(WTF::hostNameNeedsEncodingWithRange):
(WTF::decodeHostNameWithRange):
(WTF::encodeHostNameWithRange):
(WTF::decodeHostName):
(WTF::encodeHostName):
(WTF::collectRangesThatNeedMapping):
(WTF::collectRangesThatNeedEncoding):
(WTF::collectRangesThatNeedDecoding):
(WTF::applyHostNameFunctionToMailToURLString):
(WTF::applyHostNameFunctionToURLString):
(WTF::mapHostNames):
(WTF::stringByTrimmingWhitespace):
(WTF::URLByTruncatingOneCharacterBeforeComponent):
(WTF::URLByRemovingResourceSpecifier):
(WTF::URLWithData):
(WTF::dataWithUserTypedString):
(WTF::URLWithUserTypedString):
(WTF::URLWithUserTypedStringDeprecated):
(WTF::hasQuestionMarkOnlyQueryString):
(WTF::dataForURLComponentType):
(WTF::URLByRemovingComponentAndSubsequentCharacter):
(WTF::URLByRemovingUserInfo):
(WTF::originalURLData):
(WTF::createStringWithEscapedUnsafeCharacters):
(WTF::userVisibleString):
(WTF::isUserVisibleURL):
(WTF::rangeOfURLScheme):
(WTF::looksLikeAbsoluteURL):

  • wtf/cocoa/URLCocoa.mm: Renamed from Source/WebCore/platform/mac/URLMac.mm.

(WTF::URL::URL):
(WTF::URL::createCFURL const):

  • wtf/glib/GUniquePtrSoup.h: Renamed from Source/WebCore/platform/network/soup/GUniquePtrSoup.h.
  • wtf/glib/URLSoup.cpp: Renamed from Source/WebCore/platform/soup/URLSoup.cpp.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
  • TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
  • TestWebKitAPI/Tests/WebCore/URL.cpp:

(TestWebKitAPI::createURL):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
  • TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
  • TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:

(TestWebKitAPI::originalDataAsString):
(TestWebKitAPI::userVisibleString):
(TestWebKitAPI::literalURL):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:

(literalURL):

  • TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
  • TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:

(-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

  • TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::createURLForResource):

  • lldb/lldb_webkit.py:

(lldb_init_module):
(WTFURL_SummaryProvider):
(WTFURLProvider):
(WebCoreURL_SummaryProvider): Deleted.
(WebCoreURLProvider): Deleted.
(WebCoreURLProvider.
init): Deleted.
(WebCoreURLProvider.to_string): Deleted.

7:25 PM Changeset in webkit [238770] by youenn@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Test that CSS subresource loading are exposed to resource timing in case of a CORS loaded CSS stylesheet but not imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=192232

Reviewed by Dean Jackson.

  • http/tests/security/cross-origin-clean-css-resource-timing-expected.txt: Added.
  • http/tests/security/cross-origin-clean-css-resource-timing.html: Added.
  • http/tests/security/resources/loading-subresources.php: Added.
7:09 PM Changeset in webkit [238769] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS] Add more logging of sandbox call entries.
https://bugs.webkit.org/show_bug.cgi?id=192261
rdar://problem/45772445

Reviewed by Dean Jackson.

  • WebProcess/com.apple.WebProcess.sb.in:
6:57 PM Changeset in webkit [238768] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop unused Cross-Origin-Window-Policy from HTTPHeaderNames.in
https://bugs.webkit.org/show_bug.cgi?id=192253

Reviewed by Geoffrey Garen.

  • platform/network/HTTPHeaderNames.in:
5:11 PM Changeset in webkit [238767] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Editable images should always return some data, even if the canvas doesn't have a size yet
https://bugs.webkit.org/show_bug.cgi?id=192265
<rdar://problem/46385911>

Reviewed by Wenson Hsieh.

  • UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView layoutSubviews]):
(emptyImage):
(-[WKDrawingView renderedDrawing]):
(-[WKDrawingView PNGRepresentation]):
Some clients strongly depend on there being some data in an image, even if
it's not of a usable size yet. We'll invalidate the attachment when the
canvas size changes, so it will eventually settle at a usable size (after
the first layer tree commit that includes the editable image).

4:42 PM Changeset in webkit [238766] by dino@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build by using strcmp instead of strcasecmp.

  • jsc.cpp:

(isMJSFile):

4:40 PM Changeset in webkit [238765] by Truitt Savell
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline test after https://trac.webkit.org/changeset/238725/webkit
https://bugs.webkit.org/show_bug.cgi?id=192201

Unreviewed Test Gardening.

  • platform/ios/compositing/scrolling/overflow-scrolling-layers-are-self-painting-expected.txt: Added.
4:32 PM Changeset in webkit [238764] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Support unicode in MeteredStream
https://bugs.webkit.org/show_bug.cgi?id=192260

Reviewed by Stephanie Lewis.

It's possible that the test runner returns unicode characters to be logged when
running layout tests.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.write): Message written to metered stream should be unicode.

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(RegularTest.test_unicode):

4:26 PM Changeset in webkit [238763] by Jonathan Bedard
  • 2 edits in trunk/Tools

REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
https://bugs.webkit.org/show_bug.cgi?id=192257
<rdar://problem/46384671>

Reviewed by Stephanie Lewis.

Follow-up fix for r238749.

  • Scripts/webkitpy/api_tests/manager.py:

(Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.

4:15 PM Changeset in webkit [238762] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Jumping from Computed to Styles should select property
https://bugs.webkit.org/show_bug.cgi?id=192198

Reviewed by Devin Rousso.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property.highlighted): Deleted.
(@keyframes style-property-highlight): Deleted.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.highlightProperty):
Remove unnecessary __propertyView property.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.detached):
(WI.SpreadsheetStyleProperty.prototype.highlight): Deleted.

4:14 PM Changeset in webkit [238761] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix the bytecode code generator scripts to pretty print Bytecodes.h.
https://bugs.webkit.org/show_bug.cgi?id=192258

Reviewed by Keith Miller.

This makes Bytecodes.h more human readable.

  • generator/DSL.rb:
  • generator/Section.rb:
4:11 PM Changeset in webkit [238760] by Justin Fan
  • 10 edits
    2 adds in trunk

[WebGPU] WebGPUQueue::submit and WebGPURenderingContext::present() implementation
https://bugs.webkit.org/show_bug.cgi?id=192254

Reviewed by Dean Jackson.

Source/WebCore:

Final plumbing to render onto an HTMLCanvasElement with WebGPU. Also added ref-test that draws
a green square onto a canvas using WebGPU; reference uses 2D canvas.

Test: webgpu/simple-triangle-strip.html

  • Modules/webgpu/WebGPUCommandBuffer.h:
  • Modules/webgpu/WebGPUSwapChain.h: Needs to override platformLayer() for CanvasBasedRenderingContext.
  • platform/graphics/gpu/GPUQueue.h:
  • platform/graphics/gpu/GPUSwapChain.h:

(WebCore::GPUSwapChain::metalLayer const): Renamed from platformLayer.
(WebCore::GPUSwapChain::platformLayer const): Deleted.

  • platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::submit):

  • platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm:

(WebCore::GPUSwapChain::getNextTexture): Returns the texture of the swap layer's next drawable.
(WebCore::GPUSwapChain::present): Presents the last-returned drawable from getNextTexture, and frees it.
(WebCore::GPUSwapChain::platformLayer const):

LayoutTests:

Update webgpu-basics to render an image into canvas. Also added ref-test that draws
a green square onto a canvas using WebGPU; reference uses 2D canvas.

  • webgpu/js/basic-webgpu-functions.js:

(render):

  • webgpu/simple-triangle-strip-expected.html: Added.
  • webgpu/simple-triangle-strip.html: Added.
  • webgpu/webgpu-basics.html:
4:08 PM Changeset in webkit [238759] by Alan Bujtas
  • 6 edits
    2 adds in trunk

Can’t use RalphLauren.com on iPad because hover menus don’t stay up
https://bugs.webkit.org/show_bug.cgi?id=192236
<rdar://problem/45792118>

Reviewed by Geoffrey Garen.

Source/WebCore:

This patch introduces asynchronous content change observation.

  1. Start observing synchronous content change and timer install as the result of dispatching mouseMoved event.
  2. Start observing synchronous content change and style recalc schedule as the result of a timer callback (installed at #1).
  3. Start observing synchronous content change as the result of a style recalc (scheduled at #2).

This patch also extends the timeout value from 100ms to 250ms. Certain content prefer longer timeouts (see http://briancherne.github.io/jquery-hoverIntent/ for details).

Test: fast/events/touch/ios/hover-when-style-change-is-async.html

  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::updateStyleIfNeeded):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • platform/ios/wak/WKContentObservation.cpp:

(WKStartObservingStyleRecalcScheduling):
(WKStopObservingStyleRecalcScheduling):
(WKIsObservingStyleRecalcScheduling):
(WKSetShouldObserveNextStyleRecalc):
(WKShouldObserveNextStyleRecalc):
(WKSetObservedContentChange):

  • platform/ios/wak/WKContentObservation.h:

LayoutTests:

  • fast/events/touch/ios/hover-when-style-change-is-async-expected.txt: Added.
  • fast/events/touch/ios/hover-when-style-change-is-async.html: Added.
3:33 PM Changeset in webkit [238758] by rniwa@webkit.org
  • 14 edits
    2 adds in trunk

ShadowRoot should have styleSheets property
https://bugs.webkit.org/show_bug.cgi?id=191311
LayoutTests/imported/w3c:

Reviewed by Antti Koivisto.

Rebaselined the tests.

  • web-platform-tests/css/css-scoping/stylesheet-title-002-expected.txt: Rebaselined. The test now

doesn't throw but fails with the actual check the test is intending to check.

  • web-platform-tests/css/cssom/selectorText-modification-restyle-002-expected.txt: Rebaselined

now that all test cases pass.

  • web-platform-tests/shadow-dom/ShadowRoot-interface-expected.txt: Ditto.

Source/WebCore:

Reviewed by Antti Koivisto.

Added the support for ShadowRoot.prototype.styleSheets by making StyleSheetList refer to either
a document or a shadow root. We don't support the named getter in shadow root since that's not
a standard feature: https://drafts.csswg.org/cssom/#the-stylesheetlist-interface

Tests: fast/shadow-dom/shadowroot-stylesheets-wrapper-gc.html

imported/w3c/web-platform-tests/shadow-dom/ShadowRoot-interface.html

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::StyleSheetList): Added a variant which takes ShadowRoot.
(WebCore::StyleSheetList::styleSheets const):
(WebCore::StyleSheetList::ownerNode): Added. The replacement for document() since now the opaque
root could be either a Document or a ShadowRoot.
(WebCore::StyleSheetList::detach): Renamed from detachFromDocument.
(WebCore::StyleSheetList::namedItem const): Added a comment that the named getter is only supported
for Document since it's not in the standard.

  • css/StyleSheetList.h:

(WebCore::StyleSheetList::create): Added a variant which takes ShadowRoot.
(WebCore::StyleSheetList::document): Deleted. Replaced by StyleSheetList::ownerNode in .cpp file.

  • css/StyleSheetList.idl:
  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::styleSheets):

  • dom/Document.idl:
  • dom/DocumentOrShadowRoot.idl: Moved the declaration of styleSheets here from Document.idl.
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot): Call detach.
(WebCore::ShadowRoot::styleSheets):

  • dom/ShadowRoot.h:

LayoutTests:

<rdar://problem/46333290>

Reviewed by Antti Koivisto.

Added a regression test for testing that the JS wrapper of a StyleSheetList does not get collected
as long as its shadow root is alive.

  • fast/shadow-dom/shadowroot-stylesheets-wrapper-gc-expected.txt: Added.
  • fast/shadow-dom/shadowroot-stylesheets-wrapper-gc.html: Added.
2:40 PM Changeset in webkit [238757] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r238599): Multiple Selection: selecting a breakpoint will change the selection to it's parent on the first click
https://bugs.webkit.org/show_bug.cgi?id=192093
<rdar://problem/46318466>

Reviewed by Devin Rousso.

  • UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.select):
TreeElement shouldn't manage the TreeOutline's selection barrier.

  • UserInterface/Views/TreeOutline.js:

(WI.TreeOutline):
(WI.TreeOutline.prototype.get processingSelectionChange):
(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
(WI.TreeOutline.prototype.selectTreeElementInternal):
The selection re-entry barrier processingSelectionChange should be
managed internally by TreeOutline, and exposed as a read-only property.
Fix a bug where the barrier was cleared before dispatching the change
notification, which can cause re-entry as a side effect.

2:37 PM Changeset in webkit [238756] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add the generator directory to the Xcode project.
https://bugs.webkit.org/show_bug.cgi?id=192252

Reviewed by Michael Saboff.

This is so that we can work with these bytecode class generator files easily in Xcode.

2:27 PM Changeset in webkit [238755] by Chris Dumez
  • 6 edits in trunk

[PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
https://bugs.webkit.org/show_bug.cgi?id=192242

Reviewed by Geoffrey Garen.

Source/WebCore:

Move the setting of the openedViaWindowOpenWithOpener & hasOpenedFrames flags on the
NavigationAction from FrameLoader::loadURL(), to PolicyChecker::checkNavigationPolicy()
to make sure those are always accurate and so that the UIProcess can make correct process
swapping decisions.

NavigationAction objects are created in other places than FrameLoader::loadURL() as well.
Even PolicyChecker::checkNavigationPolicy() will create a NavigationAction object if
there is not already one.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::hasOpenedFrames const):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2:23 PM Changeset in webkit [238754] by don.olmstead@sony.com
  • 194 edits in trunk

Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
https://bugs.webkit.org/show_bug.cgi?id=192197

Reviewed by Jiewen Tan.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. No change in behavior.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

  • crypto/CommonCryptoUtilities.cpp:
  • crypto/CommonCryptoUtilities.h:
  • crypto/CryptoAlgorithm.cpp:
  • crypto/CryptoAlgorithm.h:
  • crypto/CryptoAlgorithmIdentifier.h:
  • crypto/CryptoAlgorithmParameters.h:
  • crypto/CryptoAlgorithmParameters.idl:
  • crypto/CryptoAlgorithmRegistry.cpp:
  • crypto/CryptoAlgorithmRegistry.h:
  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:
  • crypto/CryptoKeyFormat.h:
  • crypto/CryptoKeyPair.h:
  • crypto/CryptoKeyPair.idl:
  • crypto/CryptoKeyType.h:
  • crypto/CryptoKeyUsage.h:
  • crypto/CryptoKeyUsage.idl:
  • crypto/JsonWebKey.h:
  • crypto/JsonWebKey.idl:
  • crypto/RsaOtherPrimesInfo.h:
  • crypto/RsaOtherPrimesInfo.idl:
  • crypto/SerializedCryptoKeyWrap.h:
  • crypto/SubtleCrypto.cpp:
  • crypto/SubtleCrypto.h:
  • crypto/SubtleCrypto.idl:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.h:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp:
  • crypto/algorithms/CryptoAlgorithmECDH.h:
  • crypto/algorithms/CryptoAlgorithmECDSA.cpp:
  • crypto/algorithms/CryptoAlgorithmECDSA.h:
  • crypto/algorithms/CryptoAlgorithmHKDF.cpp:
  • crypto/algorithms/CryptoAlgorithmHKDF.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:
  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp:
  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:
  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
  • crypto/gcrypt/SerializedCryptoKeyWrapGCrypt.cpp:
  • crypto/keys/CryptoAesKeyAlgorithm.idl:
  • crypto/keys/CryptoEcKeyAlgorithm.idl:
  • crypto/keys/CryptoHmacKeyAlgorithm.idl:
  • crypto/keys/CryptoKeyAES.cpp:
  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyAlgorithm.idl:
  • crypto/keys/CryptoKeyEC.cpp:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.cpp:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.cpp:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRSAComponents.cpp:
  • crypto/keys/CryptoKeyRSAComponents.h:
  • crypto/keys/CryptoKeyRaw.cpp:
  • crypto/keys/CryptoKeyRaw.h:
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl:
  • crypto/keys/CryptoRsaKeyAlgorithm.idl:
  • crypto/mac/CommonCryptoDERUtilities.cpp:
  • crypto/mac/CommonCryptoDERUtilities.h:
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
  • crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:
  • crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:
  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:
  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:
  • crypto/mac/CryptoAlgorithmECDHMac.cpp:
  • crypto/mac/CryptoAlgorithmECDSAMac.cpp:
  • crypto/mac/CryptoAlgorithmHKDFMac.cpp:
  • crypto/mac/CryptoAlgorithmHMACMac.cpp:
  • crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:
  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
  • crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:
  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:
  • crypto/mac/CryptoDigestAlgorithm.h:
  • crypto/mac/CryptoKeyECMac.cpp:
  • crypto/mac/CryptoKeyMac.cpp:
  • crypto/mac/CryptoKeyRSAMac.cpp:
  • crypto/mac/SerializedCryptoKeyWrapMac.mm:
  • crypto/parameters/AesCbcCfbParams.idl:
  • crypto/parameters/AesCtrParams.idl:
  • crypto/parameters/AesGcmParams.idl:
  • crypto/parameters/AesKeyParams.idl:
  • crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h:
  • crypto/parameters/CryptoAlgorithmAesCtrParams.h:
  • crypto/parameters/CryptoAlgorithmAesGcmParams.h:
  • crypto/parameters/CryptoAlgorithmAesKeyParams.h:
  • crypto/parameters/CryptoAlgorithmEcKeyParams.h:
  • crypto/parameters/CryptoAlgorithmEcdhKeyDeriveParams.h:
  • crypto/parameters/CryptoAlgorithmEcdsaParams.h:
  • crypto/parameters/CryptoAlgorithmHkdfParams.h:
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
  • crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
  • crypto/parameters/CryptoAlgorithmRsaHashedKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
  • crypto/parameters/CryptoAlgorithmRsaPssParams.h:
  • crypto/parameters/EcKeyParams.idl:
  • crypto/parameters/EcdhKeyDeriveParams.idl:
  • crypto/parameters/EcdsaParams.idl:
  • crypto/parameters/HkdfParams.idl:
  • crypto/parameters/HmacKeyParams.idl:
  • crypto/parameters/Pbkdf2Params.idl:
  • crypto/parameters/RsaHashedImportParams.idl:
  • crypto/parameters/RsaHashedKeyGenParams.idl:
  • crypto/parameters/RsaKeyGenParams.idl:
  • crypto/parameters/RsaOaepParams.idl:
  • crypto/parameters/RsaPssParams.idl:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • page/ChromeClient.h:
  • page/Crypto.cpp:

(WebCore::Crypto::Crypto):

  • page/Crypto.h:
  • page/Crypto.idl:
  • platform/GCrypt.cmake:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • workers/WorkerGlobalScope.cpp:
  • workers/WorkerGlobalScope.h:
  • worklets/WorkletGlobalScope.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:
  • pal/PlatformGTK.cmake:
  • pal/PlatformWPE.cmake:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1:55 PM Changeset in webkit [238753] by dino@apple.com
  • 5 edits
    2 adds in trunk

Add first-class support for .mjs files in jsc binary
https://bugs.webkit.org/show_bug.cgi?id=192190
<rdar://problem/46375715>

Reviewed by Keith Miller.

JSTests:

  • stress/simple-module.mjs: Added.
  • stress/simple-script.js: Added.

Source/JavaScriptCore:

Treat files with a .mjs extension as a module, regardless
of whether or not the --module-file argument was given.

  • jsc.cpp:

(printUsageStatement): Update usage.
(isMJSFile): Helper to look for .mjs extensions.
(CommandLine::parseArguments): Pick the appropriate script type.

Tools:

Add .mjs files to the regexp looking for all JS files.

  • Scripts/run-jsc-stress-tests:
1:27 PM Changeset in webkit [238752] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Settings: reload button needs horizontal spacing
https://bugs.webkit.org/show_bug.cgi?id=192231
<rdar://problem/46274363>

Reviewed by Matt Baker.

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings > .settings-view > .container button):
(.content-view.settings > .settings-view > .container > .title):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
Drive-by: replace dir=* attribute rules with -webkit-margin-* properties.

1:18 PM Changeset in webkit [238751] by Wenson Hsieh
  • 5 edits in trunk

Replace "auto fill" with "AutoFill" in some localizable strings
https://bugs.webkit.org/show_bug.cgi?id=192233
<rdar://problem/46311614>

Reviewed by Chris Fleizach.

Source/WebCore:

Replace "autofill" with "AutoFill".

  • en.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillCredentialsLabel):
(WebCore::AXAutoFillContactsLabel):
(WebCore::AXAutoFillStrongPasswordLabel):
(WebCore::AXAutoFillCreditCardLabel):

LayoutTests:

Rebaseline a test.

  • accessibility/auto-fill-types-expected.txt:
1:13 PM Changeset in webkit [238750] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception opening Web Inspector to Debugger Tab
https://bugs.webkit.org/show_bug.cgi?id=192174

Reviewed by Devin Rousso.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.runAfterPendingDispatches):
Dispatch the callback with a timeout if there is no backend target yet
so it doesn't get lost.

  • UserInterface/Protocol/Connection.js:

(InspectorBackend.Connection.prototype.runAfterPendingDispatches):
Change the ambiguous name "script" to the more familiar "callback".

12:13 PM Changeset in webkit [238749] by Jonathan Bedard
  • 15 edits in trunk/Tools

webkitpy: Use DeviceType instead of str to represent device class
https://bugs.webkit.org/show_bug.cgi?id=192160
<rdar://problem/46344845>

Rubber-stamped by Aakash Jain.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._custom_device_for_test): Use DeviceTypes instead of strings to represent device type.
(Manager._set_up_run): Do not set _options.device_class, use device_type instead of device_class.
(Manager.run): Use device_type instead of device_class.
(Manager._print_expectations_for_subset): Ditto.
(Manager.print_expectations): Ditto.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_uses_custom_device): Use DeviceType and actual device definition.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_workers_and_shards): Outputting the device suffix doesn't really help, and means
device type needs to be passed around.

  • Scripts/webkitpy/port/apple.py:

(ApplePort.setup_test_run): Use device_type instead of device_class.

  • Scripts/webkitpy/port/base.py:

(Port):
(Port.setup_test_run): Use device_type instead of device_class.

  • Scripts/webkitpy/port/device_port.py:

(DevicePort):
(DevicePort.setup_test_run): Receive device_type as DeviceType object.
(DevicePort._create_devices): Deleted.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_test_run): Use device_type instead of device_class.

  • Scripts/webkitpy/port/ios.py:

(IOSPort):

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort):
(IOSSimulatorPort.init): Deleted.
(IOSSimulatorPort._set_device_class): Deleted.

  • Scripts/webkitpy/port/test.py:
  • Scripts/webkitpy/port/watch.py:

(WatchPort):

  • Scripts/webkitpy/port/watch_simulator.py:

(WatchSimulatorPort):
(WatchSimulatorPort.init): Deleted.
(WatchSimulatorPort._set_device_class): Deleted.

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_test_run): Use device_type instead of device_class.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._disambiguate_device_type): Using the existing devices for this is
a problem if no such device exists yet. Use the _device_identifier_to_name dictionary instead
since this should have hardware types in the device names.

11:59 AM Changeset in webkit [238748] by rniwa@webkit.org
  • 61 edits in trunk/Source/WebCore

Add CEReactions=NotNeeded on all the relevant IDL files
https://bugs.webkit.org/show_bug.cgi?id=188368
<rdar://problem/42987753>

Rubber-stamped by Antti Koivisto.

Based on a patch written by Frederic Wang. Added CEReactions=NotNeeded to all the places
we don't need CEReactions because we don't implement customized builtins but are marked with
CEReactions in the HTML specification.

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDataElement.idl:
  • html/HTMLDetailsElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLHyperlinkElementUtils.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLMeterElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLProgressElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSlotElement.idl:
  • html/HTMLSourceElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTimeElement.idl:
  • html/HTMLTrackElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
11:58 AM Changeset in webkit [238747] by ap@apple.com
  • 8 edits in trunk/Source

Move USE_CFNETWORK_IGNORE_HSTS to its proper place
https://bugs.webkit.org/show_bug.cgi?id=192173

Reviewed by Tim Horton.

Source/WebCore:

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::schemeWasUpgradedDueToDynamicHSTS):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(updateIgnoreStrictTransportSecuritySettingIfNecessary):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

Source/WTF:

  • wtf/Platform.h: Also renamed it to better match other version checks.
11:37 AM Changeset in webkit [238746] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Remove unused WebProcessCreationParameters.uiProcessCookieStorageIdentifier
https://bugs.webkit.org/show_bug.cgi?id=192157

Reviewed by Chris Dumez.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

11:37 AM Changeset in webkit [238745] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Remove privateBrowsingEnabled from NetworkProcessCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192156

Reviewed by Chris Dumez.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

11:21 AM Changeset in webkit [238744] by basuke.suzuki@sony.com
  • 6 edits
    4 adds in trunk/Source

[Curl] Add API for ProtectionSpace.
https://bugs.webkit.org/show_bug.cgi?id=191648

Reviewed by Alex Christensen.

Source/WebCore:

Create a platform dependent header and implementation files for ProtectionSpace.

No new tests because there's no behavior change.

  • platform/Curl.cmake:
  • platform/network/ProtectionSpace.h:
  • platform/network/curl/ProtectionSpaceCurl.cpp: Added.

(WebCore::ProtectionSpace::certificateInfo const):

  • platform/network/curl/ProtectionSpaceCurl.h: Added.

(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::encodingRequiresPlatformData const):
(WebCore::ProtectionSpace::platformCompare):

Source/WebKit:

Added API to get certificate information from protection space.

  • PlatformWin.cmake:
  • Shared/curl/WebCoreArgumentCodersCurl.cpp:

(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData):

  • UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp: Added.

(WKProtectionSpaceCopyCertificateInfo):

  • UIProcess/API/C/curl/WKProtectionSpaceCurl.h: Added.
10:55 AM Changeset in webkit [238743] by Devin Rousso
  • 42 edits in trunk

Web Inspector: replace all unicode characters with the escaped character code
https://bugs.webkit.org/show_bug.cgi?id=192216
<rdar://problem/46275637>

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/BreakpointPopoverController.js:
  • UserInterface/Debug/UncaughtExceptionReporter.js:
  • UserInterface/Models/AuditTestCase.js:
  • UserInterface/Models/Canvas.js:
  • UserInterface/Models/RecordingAction.js:
  • UserInterface/Models/ScriptTimelineRecord.js:
  • UserInterface/Views/AuditTestCaseContentView.js:
  • UserInterface/Views/AuditTestContentView.js:
  • UserInterface/Views/AuditTestGroupContentView.js:
  • UserInterface/Views/CallFrameView.js:
  • UserInterface/Views/CanvasContentView.js:
  • UserInterface/Views/CanvasOverviewContentView.css:
  • UserInterface/Views/ConsoleMessageView.css:
  • UserInterface/Views/ContextMenuUtilities.js:
  • UserInterface/Views/DOMEventsBreakdownView.js:
  • UserInterface/Views/DataGrid.css:
  • UserInterface/Views/DataGrid.js:
  • UserInterface/Views/DatabaseTableContentView.js:
  • UserInterface/Views/DebuggerDashboardView.css:
  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/ErrorObjectView.js:
  • UserInterface/Views/EventBreakpointPopover.js:
  • UserInterface/Views/InlineSwatch.js:
  • UserInterface/Views/LayerTreeDataGridNode.js:
  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
  • UserInterface/Views/Layers3DContentView.js:
  • UserInterface/Views/LayoutTimelineDataGridNode.js:
  • UserInterface/Views/NetworkTableContentView.css:
  • UserInterface/Views/NetworkTableContentView.js:
  • UserInterface/Views/ObjectPreviewView.js:
  • UserInterface/Views/ProfileDataGridNode.js:
  • UserInterface/Views/ResourceTimelineDataGridNode.js:
  • UserInterface/Views/ScriptDetailsTimelineView.css:
  • UserInterface/Views/TextEditor.css:
  • UserInterface/Views/TreeOutline.css:

LayoutTests:

  • inspector/audit/data-domAttributes-expected.txt:
  • inspector/audit/data-domNodes-expected.txt:
  • inspector/audit/data-errors-expected.txt:
10:50 AM Changeset in webkit [238742] by david_quesada@apple.com
  • 5 edits in trunk

-[WKProcessPool _downloadURLRequest:] should allow specifying the initiating web view
https://bugs.webkit.org/show_bug.cgi?id=192212
rdar://problem/46363706

Reviewed by Alex Christensen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _downloadURLRequest:originatingWebView:]):
(-[WKProcessPool _downloadURLRequest:]): Deleted.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:

(-[DownloadProgressTestRunner startDownload:expectedLength:]):

10:14 AM Changeset in webkit [238741] by Justin Fan
  • 16 edits
    6 copies in trunk

[WebGPU] Flesh out WebGPURenderPassDescriptor to match the WebGPU IDL
https://bugs.webkit.org/show_bug.cgi?id=192213

Reviewed by Dean Jackson.

Source/WebCore:

WebGPU prototype now uses WebGPURenderPassColorAttachmentDescriptor in WebGPURenderPassDescriptor to match the WebGPU Sketch.
WebGPU developer can now also set the clearColor in WebGPURenderPassDescriptor.

No new tests. Older WebGPURenderPass* tests updated.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/webgpu/WebGPUColor.h: Added. Typedef'd to GPUColor.h.
  • Modules/webgpu/WebGPUColor.idl: Added.
  • Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::beginRenderPass): Updated to error check and support the new structure of WebGPURenderPassDescriptor.

  • Modules/webgpu/WebGPURenderPassColorAttachmentDescriptor.h: Added.
  • Modules/webgpu/WebGPURenderPassColorAttachmentDescriptor.idl: Added.
  • Modules/webgpu/WebGPURenderPassDescriptor.h:
  • Modules/webgpu/WebGPURenderPassDescriptor.idl: Updated to match the sketch IDL.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/gpu/GPUColor.h: Added.
  • platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.h: Added. Backing struct for WebGPU.
  • platform/graphics/gpu/GPURenderPassDescriptor.h: Updated to match new WebGPURenderPassDescriptor.
  • platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:

(WebCore::GPURenderPassEncoder::create): Now also uses clearColor set by developer.

LayoutTests:

Updating some tests to match the updated WebGPURenderPassDescriptor.

  • webgpu/js/basic-webgpu-functions.js:

(render):

  • webgpu/render-command-encoding.html:
  • webgpu/render-passes.html:
9:41 AM Changeset in webkit [238740] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Remove invalid character in sandbox introduced in r238703.

Unreviewed sandbox fix.

  • WebProcess/com.apple.WebProcess.sb.in:
9:09 AM Changeset in webkit [238739] by aestes@apple.com
  • 15 edits
    2 adds in trunk/Source

[Cocoa] Add some WKA extension points
https://bugs.webkit.org/show_bug.cgi?id=192131
<rdar://problem/46330293>

Reviewed by Tim Horton.

Source/WebCore:

  • DerivedSources.make: Added an extension point for derived sources.
  • Modules/applepay/PaymentCoordinatorClient.h: Added an extension point for

PaymentCoordinatorClient.

  • SourcesCocoa.txt: Added WebCoreAdditions.mm as a non-unified source.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreAdditions.mm.
  • bindings/js/WebCoreBuiltinNames.h: Added an extension point for built-in names.
  • page/SettingsBase.h: Added an extension point for settings.
  • platform/cocoa/WebCoreAdditions.mm: Added.

Source/WebKit:

  • DerivedSources.make: Added an extension point for WebPreferences.yaml.
  • Platform/IPC/MessageSender.h:

(IPC::MessageSender::sendWithAsyncReply): Send async messages via IPC::MessageSender.

  • Platform/cocoa/WebKitAdditions.mm: A an extension point for additional WebKit sources.
  • SourcesCocoa.txt: Added WebKitAdditions.mm as non-unified source.
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy): Called finishConstruction.

  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.h: Added an extension point for

WebPaymentCoordinatorProxy.

  • WebKit.xcodeproj/project.pbxproj: Added WebKitAdditions.mm.
  • WebProcess/ApplePay/WebPaymentCoordinator.h: Added an extension point for

WebPaymentCoordinator.

8:21 AM Changeset in webkit [238738] by calvaris@igalia.com
  • 7 edits in trunk/Source/WebCore

[GStreamer][EME] CDMInstance should be shipped as a GstContext to the decryptors
https://bugs.webkit.org/show_bug.cgi?id=192075

Reviewed by Philippe Normand.

So far, we were shipping the CDMInstance in an event to the
decryptors and they were requesting it with bus messages when it
was not found. Now we ship it with a GstContext that is set to the
pipeline and read from the decryptors, which is now always
available.

As a consequence of changing this flow, the attemptToDecrypt one
was affected as well because it was tied to CDMInstance
shipment. A workaround was added: when the decryptors send the
waitingForKey, an attemptToDecrypt will be performed. A FIXME was
added for this. A subconsequence is that
attemptToDecryptWithInstance is reworked to rely always in
attemptToDecryptWithLocal instance, the former becomes final and
the latter virtual.

This is a rework, no new tests needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithLocalInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchCDMInstance): Deleted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init):
(webkitMediaCommonEncryptionDecryptTransformInPlace):
(webkitMediaCommonEncryptionDecryptIsCDMInstanceAvailable):
(webkitMediaCommonEncryptionDecryptSinkEventHandler):
(webKitMediaCommonEncryptionDecryptorSetContext):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithLocalInstance):
(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance): Deleted.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
7:26 AM Changeset in webkit [238737] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][BFC] Compute min/maxHeight margins only when they are needed.
https://bugs.webkit.org/show_bug.cgi?id=192223

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/block-only/collapsed-margin-with-min-height.html

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/block-only/collapsed-margin-with-min-height-expected.txt: Added.
  • fast/block/block-only/collapsed-margin-with-min-height.html: Added.
7:24 AM Changeset in webkit [238736] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][BFC] Geometry::inFlowNonReplacedHeightAndMargin should check for empty inline formatting context.
https://bugs.webkit.org/show_bug.cgi?id=192215

Reviewed by Antti Koivisto.

Check if the inline formatting context actually has any lines.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

7:22 AM Changeset in webkit [238735] by Alan Bujtas
  • 6 edits in trunk

[LFC][BFC][MarginCollapsing] Do not use computed display box values for border and padding
https://bugs.webkit.org/show_bug.cgi?id=192214

Reviewed by Antti Koivisto.

Source/WebCore:

Border and padding values are not necessarily computed yet when we try to estimate the margin top value. Estimating margin top is required
to be able to place floats (vertically) sooner than we would compute the final vertical position for a regular block box.

<body><div style="float: left"></div><div><div style="margin: 10px;"></div></div>

In the above example, to estimate a final vertical position of the floating box, we need to know whether the nested div's margin is collapsed
all the way up to the body. However in order to find it out we need to check for borders and paddings (they stop margin collapsing).
At the time when the floating box is being laied out, those <div> block boxes are still far down in the layout queue.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::hasBorder):
(WebCore::Layout::hasPadding):
(WebCore::Layout::hasBorderBefore):
(WebCore::Layout::hasBorderAfter):
(WebCore::Layout::hasPaddingBefore):
(WebCore::Layout::hasPaddingAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:
6:52 AM Changeset in webkit [238734] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][MiniBrowser] Handle Device Info permission requests
https://bugs.webkit.org/show_bug.cgi?id=191585

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-30
Reviewed by Carlos Garcia Campos.

  • MiniBrowser/gtk/BrowserTab.c:

(permissionRequestDataNew):
(permissionRequestDataFree):
(permissionRequestDialogResponse):
(decidePermissionRequest):
(browserTabConstructed):

5:25 AM Changeset in webkit [238733] by Carlos Garcia Campos
  • 1686 edits
    1 copy
    23 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Stop running tests without complex text enforced

Rebaseline tests. Part 3.

5:24 AM Changeset in webkit [238732] by Caio Lima
  • 28 edits
    3 adds in trunk

[BigInt] Implement ValueBitXor into DFG
https://bugs.webkit.org/show_bug.cgi?id=190264

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/big-int-bitwise-xor-jit.js: Added.
  • stress/big-int-bitwise-xor-memory-stress.js: Added.
  • stress/big-int-bitwise-xor-untyped.js: Added.

Source/JavaScriptCore:

This patch is splitting the BitXor node into ArithBitXor and
ValueBitXor. This is necessary due the introduction of
BigInt, since BitXor operations now can result into Int32 or BigInt.
In such case, we use ArithBitXor when operands are Int and fallback to
ValueBitXor when operands are anything else. In the case of
ValueBitXor, we speculate BigInt when op1 and op2 are predicted as
BigInt as well. BigInt specialization consist into call
operationBigIntBitXor function, that calls JSBigInt::bitXor.

  • bytecode/BytecodeList.rb:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::arithProfileForPC):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueBitwiseOp):
(JSC::DFG::SpeculativeJIT::compileBitwiseOp):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::bitOp):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileArithBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileBitXor): Deleted.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_bitxor):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

4:51 AM Changeset in webkit [238731] by Carlos Garcia Campos
  • 1855 edits
    9 adds
    4 deletes in trunk/LayoutTests

Unreviewed GTK+ gardening. Stop running tests without complex text enforced

Rebaseline tests. Part 2.

4:40 AM Changeset in webkit [238730] by Carlos Garcia Campos
  • 1857 edits
    1 copy
    6 adds in trunk

Unreviewed GTK+ gardening. Stop running tests without complex text enforced

Tools:

We have enforced complex text in GTK+ for one release cycle without noticing any major issue nor performance
regression.

  • WebKitTestRunner/gtk/main.cpp:

(main):

LayoutTests:

Rebaseline tests. Part 1.

4:28 AM Changeset in webkit [238729] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebKit

[WebAuthN] Support CTAP HID authenticators on macOS
https://bugs.webkit.org/show_bug.cgi?id=188623

Unreviewed build fix.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-30

  • UIProcess/WebAuthentication/Cocoa/HidConnection.mm: Add missing header.
Note: See TracTimeline for information about the timeline view.