Timeline

Dec 11, 2018:

9:54 PM Changeset in webkit [239098] by Justin Michaud

• 37 edits in trunk

Implement feature flag for CSS Typed OM
​https://bugs.webkit.org/show_bug.cgi?id=192610

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• bindings/js/JSTypedOMCSSStyleValueCustom.cpp:
• css/typedom/StylePropertyMapReadOnly.h:
• css/typedom/StylePropertyMapReadOnly.idl:
• css/typedom/TypedOMCSSImageValue.h:
• css/typedom/TypedOMCSSImageValue.idl:
• css/typedom/TypedOMCSSNumericValue.h:
• css/typedom/TypedOMCSSNumericValue.idl:
• css/typedom/TypedOMCSSStyleValue.h:
• css/typedom/TypedOMCSSStyleValue.idl:
• css/typedom/TypedOMCSSUnitValue.h:
• css/typedom/TypedOMCSSUnitValue.idl:
• css/typedom/TypedOMCSSUnparsedValue.h:
• css/typedom/TypedOMCSSUnparsedValue.idl:
• features.json:
• html/ImageBitmap.cpp:
• html/ImageBitmap.h:
• html/canvas/CanvasDrawImage.idl:
• html/canvas/CanvasFillStrokeStyles.idl:
• html/canvas/CanvasRenderingContext2DBase.cpp:
• html/canvas/CanvasRenderingContext2DBase.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildAction):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSTypedOMEnabled):
(WebCore::RuntimeEnabledFeatures::cssTypedOMEnabled const):

• page/WindowOrWorkerGlobalScope.idl:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferences.yaml:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:18 PM Changeset in webkit [239097] by Fujii Hironori

• 2 edits in trunk/Source/WebKitLegacy

[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
​https://bugs.webkit.org/show_bug.cgi?id=192581

Reviewed by Alex Christensen.

Conventionally, WebKit COM interface adds a new interface with
same name methods with the old interface. For example, both
IWebEditingDelegate and IWebEditingDelegate2 interfaces has
shouldInsertNode method.

This is a part of public API, can't be renamed.

• PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option

for WebKitLegacy

7:58 PM Changeset in webkit [239096] by rniwa@webkit.org

• 4 edits
  2 adds in trunk

connectedCallback is invoked during the removal of the element inside another element's connectedCallback
​https://bugs.webkit.org/show_bug.cgi?id=183586
<rdar://problem/38403504>

Reviewed by Frédéric Wang.

Source/WebCore:

Align WebKit's behavior with Chrome/Firefox with regards to ​https://github.com/w3c/webcomponents/issues/760

After much discussion, it's unclear that there is a clear path forward to fixing the oddness that
the presence of a custom element reaction changes the timing at which another reaction callback gets invoked.
So matching Chrome/Firefox behaviors in this case seems the path of the least resistance to interoperability.

Namely, this patch makes WebKit not insert a custom element to the appropriate element queue when the element
does not have a matching reaction callback. Put it another way, steps 3-5 in would be done before step 6 in:
​https://html.spec.whatwg.org/multipage/custom-elements.html#enqueue-a-custom-element-callback-reaction

1. Let definition be element's custom element definition.
2. Let callback be the value of the entry in definition's lifecycle callbacks with key callbackName.
3. If callback is null, then return
4. If callbackName is "attributeChangedCallback", then:
   1. Let attributeName be the first element of args.
   2. If definition's observed attributes does not contain attributeName, then return.
5. Add a new callback reaction to element's custom element reaction queue, with callback function callback and arguments args.
6. Enqueue an element on the appropriate element queue given element.

Test: fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html

• dom/CustomElementReactionQueue.cpp:

(WebCore::CustomElementReactionQueue::enqueueElementUpgrade):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueuePostUpgradeReactions):
(WebCore::CustomElementReactionQueue::enqueueElementOnAppropriateElementQueue): Renamed from ensureCurrentQueue.

• dom/CustomElementReactionQueue.h:

LayoutTests:

Added a W3C style testharness test.

• fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Added.
• fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Added.

6:54 PM Changeset in webkit [239095] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed, fix bad check in API test added in r239080.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

6:24 PM WPE edited by Michael Catanzaro

Fix capitalization (diff)

5:40 PM Changeset in webkit [239094] by Justin Fan

• 29 edits
  9 copies
  3 adds in trunk

Source/WebCore:
[WebGPU] Implement WebGPUBuffer, and some nullibility consistency in WebGPU
​https://bugs.webkit.org/show_bug.cgi?id=192516

Reviewed by Dean Jackson.

Test: webgpu/buffers.html

Enable basic creation of WebGPUBuffers, and fix nullability inconsitencies in WebGPU implementation.

Add necessary symbols and files for Web/GPUBuffer, Web/GPUBufferUsage, and Web/GPUBufferDescriptor:

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:

• Modules/webgpu/WebGPUBuffer.cpp: Added.

(WebCore::WebGPUBuffer::create):
(WebCore::WebGPUBuffer::WebGPUBuffer):

• Modules/webgpu/WebGPUBuffer.h: Added.

(WebCore::WebGPUBuffer::mapping const):
(WebCore::WebGPUBuffer::unmap): Unimplemented stub, for now, as Metal equivalent is unclear.
(WebCore::WebGPUBuffer::destroy): Unimplemented stub.

• Modules/webgpu/WebGPUBuffer.idl: Added.
• Modules/webgpu/WebGPUBufferDescriptor.h: Added.
• Modules/webgpu/WebGPUBufferDescriptor.idl: Added.
• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createBuffer const): Added.

• platform/graphics/gpu/GPUBuffer.h:

(WebCore::GPUBuffer::platformBuffer const):
(WebCore::GPUBuffer::mapping const):

• platform/graphics/gpu/GPUBufferDescriptor.h: Added.
• platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::createBuffer const): Added.

• platform/graphics/gpu/GPUDevice.h:
• platform/graphics/gpu/cocoa/GPUBufferMetal.mm: Added.

(WebCore::GPUBuffer::create): Attempt to create a page-aligned Gigacage to back the GPUBuffer's ArrayBuffer.
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::~GPUBuffer): Dereference mapped ArrayBuffer first.

Small benign edits, most to make nullability more consistent in WebGPU classes:

• Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::create):
(WebCore::WebGPUCommandBuffer::beginRenderPass):

• Modules/webgpu/WebGPUCommandBuffer.h:
• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::WebGPUDevice::createShaderModule const):
(WebCore::WebGPUDevice::createRenderPipeline const):
(WebCore::WebGPUDevice::createCommandBuffer const):

• Modules/webgpu/WebGPUDevice.h:

(WebCore::WebGPUDevice::device const):

• Modules/webgpu/WebGPUDevice.idl:
• Modules/webgpu/WebGPUQueue.cpp:

(WebCore::WebGPUQueue::create):

• Modules/webgpu/WebGPURenderPassEncoder.cpp:

(WebCore::WebGPURenderPassEncoder::create):

• Modules/webgpu/WebGPURenderPassEncoder.h:
• Modules/webgpu/WebGPUShaderModule.cpp:

(WebCore::WebGPUShaderModule::create):
(WebCore::WebGPUShaderModule::WebGPUShaderModule):

• Modules/webgpu/WebGPUShaderModule.h:

(WebCore::WebGPUShaderModule::module const):

• Modules/webgpu/WebGPUSwapChain.idl: Sync with IDL changes.
• Modules/webgpu/WebGPUTexture.cpp:

(WebCore::WebGPUTexture::create):
(WebCore::WebGPUTexture::createDefaultTextureView):

• Modules/webgpu/WebGPUTextureView.cpp:

(WebCore::WebGPUTextureView::create):

• Modules/webgpu/WebGPUTextureView.h:
• platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::create):

• platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::GPURenderPipeline::create):

• platform/graphics/gpu/cocoa/GPUShaderModuleMetal.mm:

(WebCore::GPUShaderModule::create):

• platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm:

(WebCore::GPUSwapChain::setDevice):

• platform/graphics/gpu/cocoa/GPUTextureMetal.mm:

(WebCore::GPUTexture::GPUTexture):

LayoutTests:
[WebGPU] Implement WebGPUBuffer
​https://bugs.webkit.org/show_bug.cgi?id=192516

Reviewed by Dean Jackson.

Basic test to create a WebGPUBuffer and ensure that its memory is valid.

• webgpu/buffers-expected.txt: Added.
• webgpu/buffers.html: Added.

5:34 PM Changeset in webkit [239093] by Fujii Hironori

• 4 edits in trunk/Source/WTF

[Win][Clang] Fix compilation warnings of WTF
​https://bugs.webkit.org/show_bug.cgi?id=192583

Reviewed by Alex Christensen.

clang-cl reports the following warnings.

[92/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\StackBounds.cpp.obj
..\..\Source\WTF\wtf\StackBounds.cpp(163,48): warning: missing field 'AllocationBase' initializer [-Wmissing-field-initializers]

MEMORY_BASIC_INFORMATION stackOrigin = { 0 };

1 warning generated.
[160/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\win\RunLoopWin.cpp.obj
..\..\Source\WTF\wtf\win\RunLoopWin.cpp(34,54): warning: ISO C++11 does not allow conversion from string literal to 'const LPWSTR' (aka 'wchar_t *const') [-Wwritable-strings]
static const LPWSTR kRunLoopMessageWindowClassName = L"RunLoopMessageWindow";

..\..\Source\WTF\wtf\win\RunLoopWin.cpp(86,32): warning: missing field 'lpfnWndProc' initializer [-Wmissing-field-initializers]

WNDCLASS windowClass = { 0 };

2 warnings generated.
[175/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\DateMath.cpp.obj
..\..\Source\WTF\wtf\DateMath.cpp(125,20): warning: unused function 'getLocalTime' [-Wunused-function]
static inline void getLocalTime(const time_t* localTime, struct tm* localTM)

1 warning generated.

• wtf/DateMath.cpp:

(WTF::getLocalTime): Defined only if used.

• wtf/StackBounds.cpp:

(WTF::StackBounds::currentThreadStackBoundsInternal): Initialize stackOrigin with '{ }'.

• wtf/win/RunLoopWin.cpp: Change the type of kRunLoopMessageWindowClassName to LPCWSTR.

(WTF::RunLoop::registerRunLoopMessageWindowClass): Initialize windowClass with '{ }'.

5:15 PM Changeset in webkit [239092] by Fujii Hironori

• 26 edits in trunk

[Win][Clang] Fix warning -Wmissing-field-initializers
​https://bugs.webkit.org/show_bug.cgi?id=192584

Reviewed by Yusuke Suzuki.

Initialize a struct with '{ }' instead of '= {0}'.

Source/WebCore:

No new tests, no behavior changes.

• platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::lastResortFallbackFont):

• platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::setFileDescriptorData):
(WebCore::setFileContentData):
(WebCore::setUCharData):
(WebCore::setUtf8Data):
(WebCore::setCFData):

• platform/win/CursorWin.cpp:

(WebCore::createSharedCursor):

• platform/win/DefWndProcWindowClass.cpp:

(WebCore::registerClass):

• platform/win/DragImageWin.cpp:

(WebCore::createDragImageIconForCachedImageFilename):

• platform/win/PasteboardWin.cpp:

(WebCore::writeURL):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writePlainTextToDataObject):
(WebCore::writeFileToDataObject):
(WebCore::Pasteboard::writeMarkup):

• platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::show):

• platform/win/SSLKeyGeneratorWin.cpp:

(WebCore::WebCore::signedPublicKeyAndChallengeString):

Source/WebKit:

• UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):

• UIProcess/win/WebView.cpp:

(WebKit::WebView::initializeToolTipWindow):
(WebKit::WebView::setToolTip):

Source/WebKitLegacy/win:

• WebKitMessageLoop.cpp:

(WebKitMessageLoop::run):

• WebView.cpp:

(WebView::onMenuCommand):
(WebView::gesture):
(WebView::setShouldInvertColors):
(WebView::initializeToolTipWindow):
(WebView::setToolTip):
(WebView::fullScreenClientForceRepaint):

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

• DumpRenderTree/win/EventSender.cpp:

(makeMsg):
(replaySavedEvents):
(beginDragWithFilesCallback):

• DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView):

• MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(updateMenuItemForHistoryItem):

• MiniBrowser/win/WinMain.cpp:

(wWinMain):

• TestWebKitAPI/win/HostWindow.cpp:

(TestWebKitAPI::HostWindow::clientRect const):
(TestWebKitAPI::HostWindow::registerWindowClass):

• TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::registerWindowClass):

• WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::registerWindowClass):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::windowSnapshotImage):

4:18 PM Changeset in webkit [239091] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Globally namespaced objects shouldn't use framework-prefixed names
​https://bugs.webkit.org/show_bug.cgi?id=192600

Reviewed by Eric Carlson.

Rename CMSampleBufferIs... -> isCMSampleBuffer...

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::isCMSampleBufferRandomAccess):
(WebCore::isCMSampleBufferNonDisplaying):
(WebCore::MediaSampleAVFObjC::flags const):
(WebCore::CMSampleBufferIsRandomAccess): Deleted.
(WebCore::CMSampleBufferIsNonDisplaying): Deleted.

2:34 PM Changeset in webkit [239090] by Brent Fulgham

• 3 edits
  2 adds in trunk

Don't attempt to compute animated values when there is no relevant animation
​https://bugs.webkit.org/show_bug.cgi?id=192591
<rdar://problem/34336946>

Reviewed by Dean Jackson.

Source/WebCore:

Check if the property is supposed to be animated, or has animatable features, before
attempting to calculate the current animated value.

Test: svg/animations/avoid-calculating-for-non-animating-elements.html

• svg/SVGAnimateElementBase.cpp:

(WebCore::SVGAnimateElementBase::calculateAnimatedValue):

LayoutTests:

• svg/animations/avoid-calculating-for-non-animating-elements-expected.txt: Added.
• svg/animations/avoid-calculating-for-non-animating-elements.html: Added.

2:00 PM Changeset in webkit [239089] by Chris Dumez

• 5 edits in trunk

Unreviewed, fix typos in console log from r239087.

Source/WebCore:

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):

LayoutTests:

• http/tests/events/device-orientation-motion-non-secure-context.html:
• platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt:

1:54 PM Changeset in webkit [239088] by timothy_horton@apple.com

• 6 edits in trunk/Source

WebCore shouldn't have a Objective-C class named NSCursor
​https://bugs.webkit.org/show_bug.cgi?id=192602
<rdar://problem/46615532>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/ios/wak/WAKAppKitStubs.h:
• platform/ios/wak/WAKAppKitStubs.m:

(+[NSCursor setHiddenUntilMouseMoves:]): Deleted.
Get rid of the class.
Also remove a comment that seems to have detached from wherever it's supposed to be.

Source/WebKitLegacy/mac:

• WebView/WebFrameView.mm:

(-[WebFrameView keyDown:keyDown:]):

• WebView/WebHTMLView.mm:

(-[WebHTMLView keyDown:]):
(-[WebHTMLView performKeyEquivalent:]):
Only use NSCursor on macOS.

1:49 PM Changeset in webkit [239087] by Chris Dumez

• 7 edits
  7 adds in trunk

Restrict DeviceMotion / DeviceOrientation APIs to secure contexts
​https://bugs.webkit.org/show_bug.cgi?id=192595
<rdar://problem/46382603>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: http/tests/events/device-orientation-motion-non-secure-context.html

http/tests/events/device-orientation-motion-secure-context.html

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):

• page/SecurityOrigin.h:

(WebCore::SecurityOrigin::setIsPotentiallyTrustworthy):

• testing/Internals.cpp:

(WebCore::Internals::markContextAsInsecure):
(WebCore::Internals::postTask):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Add layout test coverage. Note however that we currently do not have mock data providers
for these APIs.

• http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
• http/tests/events/device-orientation-motion-non-secure-context.html: Added.
• http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.
• http/tests/events/device-orientation-motion-secure-context.html: Added.
• platform/ios/http/tests/events/device-orientation-motion-non-secure-context-expected.txt: Added.
• platform/ios/http/tests/events/device-orientation-motion-secure-context-expected.txt: Added.

1:13 PM Changeset in webkit [239086] by Wenson Hsieh

• 7 edits in trunk/Source/WebCore

[iOS] Send the full list of file upload URLs and types in PasteboardItemInfo
​https://bugs.webkit.org/show_bug.cgi?id=192598
Work towards <rdar://problem/35626913>

Reviewed by Tim Horton.

Refactors PasteboardItemInfo to contain lists of file URLs and corresponding pasteboard types, instead of just
a "preferred" file upload URL and type. See below for more details.

• platform/PasteboardItemInfo.h:

(WebCore::PasteboardItemInfo::pathForContentType const):

Add a helper method to find a file upload URL corresponding to a given type.

(WebCore::PasteboardItemInfo::encode const):
(WebCore::PasteboardItemInfo::decode):

Change pathForFileUpload to pathsForFileUpload, and contentTypeForFileUpload to contentTypesForFileUpload.

• platform/ios/AbstractPasteboard.h:
• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::readRespectingUTIFidelities):

Adjust this to take the file path for the highest fidelity representation in pathsForContentType.

(WebCore::Pasteboard::readFilePaths):

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::informationForItemAtIndex):

• platform/ios/WebItemProviderPasteboard.h:
• platform/ios/WebItemProviderPasteboard.mm:

(-[NSItemProvider web_containsFileURLAndFileUploadContent]):
(-[NSItemProvider web_fileUploadContentTypes]):

Replace web_containsFileUploadContent with web_fileUploadContentTypes, which returns the full list of file
upload content types (rather than just a BOOL indicating whether one or more of these types exist).

(-[WebItemProviderPasteboard fileUploadURLsAtIndex:fileTypes:]):
(-[WebItemProviderPasteboard numberOfFiles]):
(-[NSItemProvider web_containsFileUploadContent]): Deleted.
(-[WebItemProviderPasteboard preferredFileUploadURLAtIndex:fileType:]): Deleted.

Replaced with -fileUploadURLsAtIndex:fileTypes:. This implementation currently just returns the highest
fidelity loaded type identifier, but this is wrong because it doesn't take into account inline data types that
shouldn't be represented as data for file uploads (for instance, it never makes sense to upload the internal
data serialization for an NSURL as a file on the web).

Instead, use existing logic in web_fileUploadContentTypes to determine which file types can be treated as file
uploads, and return all of these file types that we've loaded.

1:12 PM Changeset in webkit [239085] by Alan Coon

• 4 edits
  1 copy
  1 add in branches/safari-606-branch

Cherry-pick r238877. rdar://problem/45997440

Don't report resource timing to parent frame for history items
​https://bugs.webkit.org/show_bug.cgi?id=192273
<rdar://problem/45163764>

Reviewed by Youenn Fablet.

Source/WebCore:

We should not report history items to its parent frame as those are less
interested to its parent and might not be the first navigation in the iframes.

This change aligns the behavior when a cached document is not available for the
history item with the available case as we don't report resource timing for any
cached main document.

Test: http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html

• loader/FrameLoader.cpp: (WebCore::FrameLoader::loadDifferentDocumentItem):

LayoutTests:

• http/tests/misc/resource-timing-navigation-in-restored-iframe-2-expected.txt: Added.
• http/tests/misc/resource-timing-navigation-in-restored-iframe-2.html: Copied from LayoutTests/http/tests/misc/resource-timing-navigation-in-restored-iframe.html.
• http/tests/misc/resource-timing-navigation-in-restored-iframe.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:12 PM Changeset in webkit [239084] by Alan Coon

• 3 edits in branches/safari-606-branch/Source/WebCore

Cherry-pick r238582. rdar://problem/46085283

Refactor duplicate code for calling into media controls
​https://bugs.webkit.org/show_bug.cgi?id=192040
<rdar://problem/46278931>

Reviewed by Youenn Fablet.

No new tests, no functional change.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setupAndCallJS): (WebCore::HTMLMediaElement::updateCaptionContainer): (WebCore::HTMLMediaElement::configureTextTrackDisplay): (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): (WebCore::HTMLMediaElement::setControllerJSProperty): (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): (WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange): (WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
• html/HTMLMediaElement.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:12 PM Changeset in webkit [239083] by Alan Coon

• 3 edits in branches/safari-606-branch/Source/WebCore

Cherry-pick r238232. rdar://problem/46085281

Modernize RTCPeerConnection handling of pendingActivity
​https://bugs.webkit.org/show_bug.cgi?id=191661

Reviewed by Eric Carlson.

makePendingActivity is the modern way to handle set/unset of pending activity.
No change of behavior.

• Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::create): (WebCore::RTCPeerConnection::doStop):
• Modules/mediastream/RTCPeerConnection.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:12 PM Changeset in webkit [239082] by Alan Coon

• 1 edit in branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc

Apply patch. rdar://problem/46603462

12:25 PM Changeset in webkit [239081] by don.olmstead@sony.com

• 4 edits in trunk/Source/WebCore

Resource Load Statistics: Use common implementation within NetworkStorageSession
​https://bugs.webkit.org/show_bug.cgi?id=192592

Reviewed by Alex Christensen.

There's nothing within the resource load statistics implementation contained
in NetworkStorageSessionCFNet that was CF specific. All of the resource load
statistics methods are moved from that file to the root NetworkStorageSession
implementation.

• platform/network/NetworkStorageSession.cpp:

(WebCore::getPartitioningDomain):
(WebCore::NetworkStorageSession::shouldBlockThirdPartyCookies const):
(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::maxAgeCacheCap):
(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
(WebCore::NetworkStorageSession::setPrevalentDomainsToBlockCookiesFor):
(WebCore::NetworkStorageSession::removePrevalentDomains):
(WebCore::NetworkStorageSession::hasStorageAccess const):
(WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
(WebCore::NetworkStorageSession::grantStorageAccess):
(WebCore::NetworkStorageSession::removeStorageAccessForFrame):
(WebCore::NetworkStorageSession::removeStorageAccessForAllFramesOnPage):
(WebCore::NetworkStorageSession::removeAllStorageAccess):
(WebCore::NetworkStorageSession::setCacheMaxAgeCapForPrevalentResources):
(WebCore::NetworkStorageSession::resetCacheMaxAgeCapForPrevalentResources):

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::getPartitioningDomain): Deleted.
(WebCore::NetworkStorageSession::shouldBlockThirdPartyCookies const): Deleted.
(WebCore::NetworkStorageSession::shouldBlockCookies const): Deleted.
(WebCore::NetworkStorageSession::maxAgeCacheCap): Deleted.
(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies): Deleted.
(WebCore::NetworkStorageSession::setPrevalentDomainsToBlockCookiesFor): Deleted.
(WebCore::NetworkStorageSession::removePrevalentDomains): Deleted.
(WebCore::NetworkStorageSession::hasStorageAccess const): Deleted.
(WebCore::NetworkStorageSession::getAllStorageAccessEntries const): Deleted.
(WebCore::NetworkStorageSession::grantStorageAccess): Deleted.
(WebCore::NetworkStorageSession::removeStorageAccessForFrame): Deleted.
(WebCore::NetworkStorageSession::removeStorageAccessForAllFramesOnPage): Deleted.
(WebCore::NetworkStorageSession::removeAllStorageAccess): Deleted.
(WebCore::NetworkStorageSession::setCacheMaxAgeCapForPrevalentResources): Deleted.
(WebCore::NetworkStorageSession::resetCacheMaxAgeCapForPrevalentResources): Deleted.

12:24 PM Changeset in webkit [239080] by Chris Dumez

• 12 edits in trunk

PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
​https://bugs.webkit.org/show_bug.cgi?id=192482
<rdar://problem/46470145>

Reviewed by Antti Koivisto.

Source/WebKit:

It is possible to get 2 parallel decidePolicyForNavigationAction() requests from the
WebProcess when a new load is started before responding to the existing policy
decision. This would lead to several issues with regards to PSON:

• We would decide to swap for the first policy decision and tell the WebProcess to suspend. However, because the WebProcess issued a new decidePolicyForNavigationAction since for the same frame, the previous one is invalidated and the WebProcess would ignore our request to suspend.
• We would hit assertions later on because the navigation has been destroyed and yet we're getting a didStartProvisionalLoad for it.
• swapToWebProcess() was asynchronous so that it would wait for the destination SuspendedPage to finish suspending before asking it to unsuspend. This led to various problems because anything can happen in the UIProcess while we're waiting for the suspension (e.g. another load). Also, we may create the SuspendedPageProxy for the current page too late and start getting IPC from the previous process about the suspension load to about:blank.

To address these issues, the following design is now implemented:

• swapToWebProcess() is no longer asynchronous
• instead, WebProcessPool::processForNavigation() is now asynchronous. This is better because at this point we have not yet told the WebProcess about the policy decision. We already properly deal with the policy decision being made asynchronously. This also allows us to choose another process if the SuspendedPage we'd like to use failed to suspend.
• If the WebProcess receives a PolicyAction::Suspend but ignores it, have it send an IPC to the UIProcess so that the SuspendedPageProxy knows about it. We then destroy the SuspendedPageProxy and make sure it is not used.
• After the asynchronous process selection, if the navigation has been destroy, abort the process-swap to avoid hitting assertions later on due to doing a load for a destroyed navigation.

• UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
Make sure m_whenReadyToConsume completion handler gets called if necessary if the
SuspendedPageProxy gets destroyed. We pass null so that the SuspendedPage is not
used.

(WebKit::SuspendedPageProxy::whenReadyToConsume):
Add whenReadyToConsume() utility method to get a completion handler called when
the SuspendedPageProxy is ready to be used. This basically means we have to wait
for the page to finish its about:blank suspension load. If the suspension fails
then we call the completion handler with null to indicate that the suspended
page is not usable.

(WebKit::SuspendedPageProxy::unsuspendAndConsume):
Rename unsuspend() to unsuspendAndConsume() and make it synchronous. This only gets
called after whenReadyToConsume()'s completion handler has been called and if we
do decide to use the SuspendedPageProxy. It tells the WebProcess to unsuspend and
removes the SuspendedPageProxy from the WebProcessPool.

(WebKit::SuspendedPageProxy::didFinishLoad):
rename m_finishedSuspendingHandler to m_whenReadyToConsume.

(WebKit::SuspendedPageProxy::didFailToSuspend):
Add new didFailToSuspend() that gets called when the WebProcess sends us an IPC telling
us it ignored our request to suspend. We then call m_whenReadyToConsume completion
handler with null and destroy the SuspendedPageProxy.

(WebKit::SuspendedPageProxy::didReceiveMessage):

• UIProcess/SuspendedPageProxy.h:

• UIProcess/WebNavigationState.h:

(WebKit::WebNavigationState::hasNavigation const):
Add utility function to query if a navigation is still valid.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::swapToWebProcess):
Update method so that it is no longer asynchronous. Some of its code was also moved to
continueNavigationInNewProcess() for clarity.

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
Deal with WebProcessPool::processForNavigation() now being asynchronous.

(WebKit::WebPageProxy::continueNavigationInNewProcess):
Update code now that swapToWebProcess() is no longer asynchronous. Some of the swapToWebProcess()
code was also moved here for clarity.

(WebKit::WebPageProxy::didFailToSuspendAfterProcessSwap):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

Add new DidFailToSuspendAfterProcessSwap IPC message.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):

• UIProcess/WebProcessPool.h:

Make asynchronous. If we decide to use a SuspendedPageProxy's process, then call
whenReadyToConsume() on it to wait for it to suspend. If the SuspendedPageProxy
fails to suspend use a new process instead.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):
If we ignore the policy decision and the decision was "Suspend", send the DidFailToSuspendAfterProcessSwap
IPC to the UIProcess so that the SuspendedPageProxy knows about it.

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:27 AM Changeset in webkit [239079] by Devin Rousso

• 2 edits in trunk/Source/WebCore

Web Inspector: overlay bounds rulers don't match element when page is scrolled
​https://bugs.webkit.org/show_bug.cgi?id=192577

Reviewed by Joseph Pecoraro.

When drawing the highlight for a node, the canvas is translated based on the scroll position
of the node. This translation was not applied to the bounds calculations, which meant that
the bounds always drew where the node would have been if it wasn't scrolled.

• inspector/InspectorOverlayPage.js:

(Bounds.prototype.get minX):
(Bounds.prototype.get minY):
(Bounds.prototype.get maxX):
(Bounds.prototype.get maxY):
(Bounds.prototype.offset): Added.
(drawNodeHighlight):
Drive-by: draw bounds for every node being highlighted instead of just the first one.
Drive-by: switch the bounds color to be a semi-transparent red for more visibility/contrast.

11:21 AM Changeset in webkit [239078] by aestes@apple.com

• 38 edits in trunk

Introduce makeBlockPtr for lambdas
​https://bugs.webkit.org/show_bug.cgi?id=192594

Reviewed by Alex Christensen.

Source/WebCore:

Adopted makeBlockPtr.

• platform/cocoa/FileMonitorCocoa.mm:

(WebCore::FileMonitor::FileMonitor):

• platform/graphics/avfoundation/objc/VideoFullscreenLayerManagerObjC.mm:

(WebCore::VideoFullscreenLayerManagerObjC::setVideoFullscreenLayer):

• platform/graphics/gpu/legacy/cocoa/GPULegacyCommandBufferMetal.mm:

(WebCore::GPULegacyCommandBuffer::GPULegacyCommandBuffer):

• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession addDelegateOperation:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]):

Source/WebCore/PAL:

Adopted makeBlockPtr.

• pal/Logging.cpp:

(PAL::registerNotifyCallback):

Source/WebKit:

Adopted makeBlockPtr.

• NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm:

(-[WKDownloadProgress initWithDownloadTask:download:URL:sandboxExtension:]):

• NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:

(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::write):

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::clearDiskCache):
(WebKit::saveCookies):

• NetworkProcess/watchos/NetworkProximityAssertion.mm:

(WebKit::BluetoothProximityAssertion::suspend):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setInputDelegate:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView maybeInstallIconLoadingClient]):

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):

• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

• UIProcess/Cocoa/AutomationSessionClient.mm:

(WebKit::AutomationSessionClient::requestNewPageWithOptions):
(WebKit::AutomationSessionClient::requestSwitchToPage):
(WebKit::AutomationSessionClient::requestHideWindowOfPage):
(WebKit::AutomationSessionClient::requestRestoreWindowOfPage):
(WebKit::AutomationSessionClient::requestMaximizeWindowOfPage):

• UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didReceiveAuthenticationChallenge):
(WebKit::DownloadClient::decideDestinationWithSuggestedFilename):

• UIProcess/Cocoa/IconLoadingDelegate.mm:

(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):
(WebKit::NavigationState::NavigationClient::didReceiveAuthenticationChallenge):

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
(WebKit::UIDelegate::UIClient::requestStorageAccessConfirm):
(WebKit::UIDelegate::UIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel):
(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):
(WebKit::UIDelegate::UIClient::windowFrame):
(WebKit::UIDelegate::UIClient::toolbarsAreVisible):
(WebKit::UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest):
(WebKit::UIDelegate::UIClient::runOpenPanel):
(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):
(WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota):
(WebKit::UIDelegate::UIClient::requestPointerLock):

• UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingWarning clickedOnLink:]):

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::beginSafeBrowsingCheck):

• UIProcess/WebAuthentication/Cocoa/HidConnection.mm:

(WebKit::HidConnection::send):

• UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::getUserConsent const):
(WebKit::LocalConnection::getAttestation const):

• UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::send):

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestPasswordForQuickLookDocument):

• UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):

• UIProcess/mac/ServicesController.mm:

(WebKit::hasCompatibleServicesForItems):
(WebKit::ServicesController::refreshExistingServices):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(PageLoaderClient::didStartProvisionalLoadForFrame):

Source/WTF:

BlockPtr<...>::fromCallable is cumbersome because it requires repeating the callable's
signature as a class template argument. This patch introduces an overload of makeBlockPtr
that deduces the correct BlockPtr instantiation from a lambda's operator() signature.

• wtf/BlockPtr.h:

(WTF::makeBlockPtr):

Adopted makeBlockPtr.

• wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
(WTF::WorkQueue::concurrentApply):

Tools:

Adopted makeBlockPtr and added API tests.

• DumpRenderTree/TestRunner.cpp:

(TestRunner::callUIScriptCallback):

• TestWebKitAPI/Tests/WTF/BlockPtr.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:

(-[DownloadProgressTestRunner init]):
(-[DownloadProgressTestRunner subscribeAndWaitForProgress]):

11:10 AM Changeset in webkit [239077] by Chris Dumez

• 2 edits in trunk/Tools

REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
​https://bugs.webkit.org/show_bug.cgi?id=192361
<rdar://problem/46524903>

Reviewed by Alex Christensen.

Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
fixes the failures for me locally.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

10:45 AM Changeset in webkit [239076] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix an internal build failure after r239014
​https://bugs.webkit.org/show_bug.cgi?id=192205

• UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(fontOfSize):
There's a system that doesn't have safe browsing or UIFontTextStyleLargeTitle.

10:12 AM Changeset in webkit [239075] by mark.lam@apple.com

• 17 edits
  1 copy in branches/safari-606-branch

Cherry-pick r239062. rdar://problem/46603464

2018-12-10 Mark Lam <​mark.lam@apple.com>

PropertyAttribute needs a CustomValue bit.
​https://bugs.webkit.org/show_bug.cgi?id=191993
<rdar://problem/46264467>

Reviewed by Saam Barati.

JSTests:

• stress/regress-191993.js: Added.

Source/JavaScriptCore:

This is because GetByIdStatus needs to distinguish CustomValue properties from
other types, and its only means of doing so is via the property's attributes.
Previously, there's nothing in the property's attributes that can indicate that
the property is a CustomValue.

We fix this by doing the following:

1. Added a PropertyAttribute::CustomValue bit.
2. Added a PropertyAttribute::CustomAccessorOrValue convenience bit mask that is CustomAccessor | CustomValue.

3. Since CustomGetterSetter properties are only set via JSObject::putDirectCustomAccessor(), we added a check in JSObject::putDirectCustomAccessor() to see if the attributes bits include PropertyAttribute::CustomAccessor. If not, then the property must be a CustomValue, and we'll add the PropertyAttribute::CustomValue bit to the attributes bits.

This ensures that the property attributes is sufficient to tell us if the
property contains a CustomGetterSetter.

4. Updated all checks for PropertyAttribute::CustomAccessor to check for PropertyAttribute::CustomAccessorOrValue instead if their intent is to check for the presence of a CustomGetterSetter as opposed to checking specifically for one that is used as a CustomAccessor.

This includes all the Structure transition code that needs to capture the
attributes change when a CustomValue has been added.

5. Filtered out the PropertyAttribute::CustomValue bit in PropertyDescriptor. The fact that we're using a CustomGetterSetter as a CustomValue should remain invisible to the descriptor. This is because the descriptor should describe a CustomValue no differently from a plain value.

6. Added some asserts to ensure that property attributes are as expected, and to document some invariants.

• bytecode/GetByIdStatus.cpp: (JSC::GetByIdStatus::computeFromLLInt): (JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback): (JSC::GetByIdStatus::computeFor):
• bytecode/InByIdStatus.cpp: (JSC::InByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
• bytecode/PropertyCondition.cpp: (JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
• bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::computeFor):
• runtime/JSFunction.cpp: (JSC::getCalculatedDisplayName):
• runtime/JSObject.cpp: (JSC::JSObject::putDirectCustomAccessor): (JSC::JSObject::putDirectNonIndexAccessor): (JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
• runtime/JSObject.h: (JSC::JSObject::putDirectIndex): (JSC::JSObject::fillCustomGetterPropertySlot): (JSC::JSObject::putDirect):
• runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal):
• runtime/PropertyDescriptor.cpp: (JSC::PropertyDescriptor::setDescriptor): (JSC::PropertyDescriptor::setCustomDescriptor): (JSC::PropertyDescriptor::setAccessorDescriptor):
• runtime/PropertySlot.h: (JSC::PropertySlot::setCustomGetterSetter):

Source/WebCore:

This patch revealed a bug in the CodeGenerator where a constructor property is
set with a ReadOnly attribute. This conflicts with the WebIDL link (see clause
12 in ​https://heycam.github.io/webidl/#interface-prototype-object) which states
that it should be [Writable]. The ReadOnly attribute is now removed.

On the WebCore side, this change is covered by existing tests.

• bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp: (WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):

9:39 AM Changeset in webkit [239074] by BJ Burg

• 2 edits in trunk/Source/WebKit

SimulatedInputDispatcher::transitionInputSourceToState() can reuse a moved-from completion handler
​https://bugs.webkit.org/show_bug.cgi?id=191155
<rdar://problem/45745569>

Reviewed by Joseph Pecoraro.

• UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
Add an ASSERT to guard against unexpected inputs where >1 VirtualKey changes per state.
webkitdriver needs to be updated to not produce such states in this scenario, but this will
avoid a runtime crash caused by trying to call a moved-out completion handler a second time.

7:14 AM Changeset in webkit [239073] by Philippe Normand

• 2 edits in trunk/Tools

Unreviewed, WPE build fix after r239028

The FLATPAK_USER_DIR env var is not set early enough, leading to:

Traceback (most recent call last):
File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>

sys.exit(WebkitFlatpak.load_from_args().run())

File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run

if not self.clean_args():

File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args

_log.debug("Using flatpak user dir: %s" % os.environFLATPAK_USER_DIR)

File "/usr/lib/python2.7/UserDict.py", line 40, in getitem

raise KeyError(key)

KeyError: 'FLATPAK_USER_DIR'

• flatpak/flatpakutils.py:

(WebkitFlatpak.clean_args):

6:33 AM Changeset in webkit [239072] by commit-queue@webkit.org

• 58 edits in trunk/Source/WebKit

Unreviewed, rolling out r239071.
​https://bugs.webkit.org/show_bug.cgi?id=192588

Broke WPE build due to undefined references to toAPI() and
toImpl() inside the C API (Requested by magomez on #webkit).

Reverted changeset:

"[meta][WebKit] Remove using namespace WebCore and WebKit in
the global scope for unified source builds"
​https://bugs.webkit.org/show_bug.cgi?id=192449
​https://trac.webkit.org/changeset/239071

Dec 10, 2018:

10:55 PM Changeset in webkit [239071] by Chris Fleizach

• 58 edits in trunk/Source/WebKit

[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
​https://bugs.webkit.org/show_bug.cgi?id=192449

Reviewed by Darin Adler.

• NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:
• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
• NetworkProcess/ios/NetworkProcessIOS.mm:
• NetworkProcess/mac/NetworkProcessMac.mm:
• NetworkProcess/mac/RemoteNetworkingContext.mm:
• Platform/spi/ios/AccessibilitySupportSPI.h:
• PlatformMac.cmake:
• PluginProcess/PluginControllerProxy.cpp:
• PluginProcess/PluginProcess.cpp:
• PluginProcess/WebProcessConnection.cpp:
• Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb:
• Shared/API/c/cf/WKErrorCF.cpp:

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

• Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateCGImage):
(WKImageCreateFromCGImage):

• Shared/ChildProcess.cpp:
• Shared/ContextMenuContextData.cpp:
• Shared/EditorState.cpp:
• Shared/Plugins/NPIdentifierData.cpp:
• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
• Shared/SessionState.cpp:
• Shared/SessionTracker.cpp:
• Shared/ShareableBitmap.cpp:
• Shared/ShareableResource.cpp:
• Shared/VisibleContentRectUpdateInfo.cpp:
• Shared/WebBackForwardListItem.cpp:
• Shared/WebContextMenuItemData.cpp:
• Shared/WebCoreArgumentCoders.cpp:
• Shared/WebHitTestResultData.cpp:
• Shared/WebImage.cpp:
• Shared/WebMediaSessionMetadata.cpp:
• Shared/WebMemorySampler.cpp:
• Shared/WebMouseEvent.cpp:
• Shared/WebRenderObject.cpp:
• Shared/WebSQLiteDatabaseTracker.cpp:
• Shared/WebWheelEvent.cpp:
• Shared/cf/ArgumentCodersCF.cpp:
• Shared/ios/WebPlatformTouchPointIOS.cpp:
• SourcesCocoa.txt:
• UIProcess/API/APIContentRuleListStore.cpp:
• UIProcess/API/APIHitTestResult.cpp:
• UIProcess/API/APINavigation.cpp:
• UIProcess/API/APIOpenPanelParameters.cpp:
• UIProcess/API/APIPageConfiguration.cpp:
• UIProcess/API/C/WKPage.cpp:

(WKPageLoadURLWithShouldOpenExternalURLsPolicy):
(WKPageLoadURLWithUserData):
(WKPageLoadURLRequestWithUserData):
(WKPageSetPaginationMode):
(WKPageGetPaginationMode):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):

• UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
• UIProcess/WebStorage/LocalStorageDatabase.cpp:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
(-[WKContentView dealloc]):
(-[WKContentView page]):
(-[WKContentView updateFixedClippingView:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(-[WKContentView _updateForScreen:]):
(-[WKContentView _accessibilityRegisterUIProcessTokens]):
(-[WKContentView _createDrawingAreaProxy]):
(-[WKContentView _didCommitLayerTree:]):
(-[WKContentView _wk_pageCountForPrintFormatter:]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]):
(hasAssistedNode):
(-[WKContentView setupInteraction]):
(-[WKContentView positionInformation]):
(-[WKContentView _webTouchEventsRecognized:]):
(inflateQuad):
(-[WKContentView _updateTapHighlight]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView inputView]):
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView currentPositionInformation]):
(-[WKContentView doAfterPositionInformationUpdate:forRequest:]):
(-[WKContentView _currentPositionInformationIsValidForRequest:]):
(-[WKContentView _hasValidOutstandingPositionInformationRequest:]):
(-[WKContentView _currentPositionInformationIsApproximatelyValidForRequest:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView webSelectionRectsForSelectionRects:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _stylusSingleTapRecognized:]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView supportedPasteboardTypesForCurrentSelection]):
(-[WKContentView _lookupForWebView:]):
(-[WKContentView _shareForWebView:]):
(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView selectForWebView:]):
(-[WKContentView _accessibilityRetrieveRectsEnclosingSelectionOffset:withGranularity:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
(toGestureType):
(toUIWKGestureType):
(toSelectionTouch):
(toUIWKSelectionTouch):
(toGestureRecognizerState):
(toUIGestureRecognizerState):
(toUIWKSelectionFlags):
(toWKTextGranularity):
(toWKSelectionDirection):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView autocorrectionData]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKContentView _updateAccessory]):
(-[WKContentView selectedTextRange]):
(-[WKContentView setMarkedText:selectedRange:]):
(coreWritingDirection):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView insertText:]):
(-[WKContentView textInputTraits]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:]):
(-[WKContentView assistedNodeInformation]):
(-[WKContentView assistedNodeSelectOptions]):
(isAssistableInputType):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _stopAssistingNode]):
(-[WKContentView updateCurrentAssistedNodeInformation:]):
(-[WKContentView presentViewControllerForCurrentAssistedNode]):
(-[WKContentView actionNameForFocusedFormControlView:]):
(-[WKContentView selectWordForReplacement]):
(-[WKContentView _updateChangedSelection:]):
(-[WKContentView _beginSuppressingSelectionAssistantForReason:]):
(-[WKContentView _stopSuppressingSelectionAssistantForReason:]):
(-[WKContentView _showPlaybackTargetPicker:fromRect:routeSharingPolicy:routingContextUID:]):
(-[WKContentView _showRunOpenPanel:resultListener:]):
(-[WKContentView _showShareSheet:completionHandler:]):
(-[WKContentView positionInformationForActionSheetAssistant:]):
(-[WKContentView updatePositionInformationForActionSheetAssistant:]):
(-[WKContentView _startDrag:item:]):
(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView _didHandleStartDataInteractionRequest:]):
(dropOperationForWebCoreDragOperation):
(-[WKContentView dragDataForDropSession:dragDestinationAction:]):
(-[WKContentView _didConcludeEditDataInteraction:]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _prepareToDragPromisedAttachment:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:]):
(-[WKContentView _autofillContext]):
(-[WKContentView _dragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):
(-[WKContentView allowsLanguageSelectionMenuForListViewController:]):
(-[WKContentView shouldDisplayInputContextViewForListViewController:]):
(-[WKContentView numericInputModeForListViewController:]):
(-[WKContentView textContentTypeForListViewController:]):
(-[WKContentView allowsDictationInputForListViewController:]):
(-[WKContentView _simulateLongPressActionAtLocation:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _presentationRectsForPreviewItemController:]):

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
(WKFullScreenViewControllerVideoFullscreenModelClient::setInterface):
(WKFullScreenViewControllerVideoFullscreenModelClient::interface const):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController _manager]):
(-[WKFullScreenViewController _togglePiPAction:]):

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullscreenAnimationController configureInitialAndFinalStatesForTransition:]):
(-[WKFullScreenWindowController isFullScreen]):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
(-[WKFullScreenWindowController _manager]):

• UIProcess/mac/WebPageProxyMac.mm:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageConnection.cpp:
• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(mediaTimeToCurrentTime):
(-[WKAnimationDelegate initWithLayerID:layerTreeHost:]):

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):

10:50 PM Changeset in webkit [239070] by Brent Fulgham

• 11 edits
  2 copies
  2 adds in trunk

SVGViewSpec objects should mark relevant SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=192567
<rdar://problem/46491325>

Reviewed by Ryosuke Niwa.

Source/WebCore:

SVGViewSpec elements reflect the state of an underlying SVGElement. Teach the mark algorithm to
recognize the relevant SVGElement as active as long as the SVGViewSpec is active.

Update SVGElement so that it can vend WeakPtrs. I also noticed that SVGAttributeOwner used a bare
pointer to the SVGElement, so switched to a WeakPtr.

Test: svg/animations/view-dependency-crash.html

• Sources.txt: Add new files.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/JSSVGViewSpecCustom.cpp: Added.

(WebCore::JSSVGViewSpec::visitAdditionalChildren):

• svg/SVGElement.h:
• svg/SVGPathElement.h:
• svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::SVGViewSpec): Hold a weak pointer (rather than a bare pointer) to the underlying element.

• svg/SVGViewSpec.h:
• svg/SVGViewSpec.idl:
• svg/properties/SVGAttributeOwnerProxy.cpp: Added.

(WebCore::SVGAttributeOwnerProxy::SVGAttributeOwnerProxy): Hold a weak pointer (rather than a bare pointer) to
the underling SVGElement.
(WebCore::SVGAttributeOwnerProxy::element const): Ditto.

• svg/properties/SVGAttributeOwnerProxy.h:

(WebCore::SVGAttributeOwnerProxy::SVGAttributeOwnerProxy): Move implementation to cpp file.
(WebCore::SVGAttributeOwnerProxy::element const): Ditto.

• svg/properties/SVGAttributeOwnerProxyImpl.h: Update for WeakPtr use.

LayoutTests:

• svg/animations/view-dependency-crash-expected.txt: Added.
• svg/animations/view-dependency-crash.html: Added.

9:37 PM Changeset in webkit [239069] by benjamin@webkit.org

• 3 edits
  3 adds in trunk

<rdar://problem/45296285> Content blocker rule "raw" blocks media elements from loading
​https://bugs.webkit.org/show_bug.cgi?id=192439

Reviewed by Dean Jackson.

Source/WebCore:

This broken when WebKit switched to NSURLSession.
In CachedResourceLoader::requestResource(), toResourceType() was turning media load into RAW.

Test: http/tests/contentextensions/video-element-resource-type.html

• loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

LayoutTests:

• http/tests/contentextensions/video-element-resource-type-expected.txt: Added.
• http/tests/contentextensions/video-element-resource-type.html: Added.
• http/tests/contentextensions/video-element-resource-type.html.json: Added.

8:04 PM Changeset in webkit [239068] by don.olmstead@sony.com

• 14 edits in trunk

Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
​https://bugs.webkit.org/show_bug.cgi?id=192573

Reviewed by Simon Fraser.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

Remove ENABLE_RESOURCE_LOAD_STATISTICS from Platform.h and instead rely
on it being set in FeatureDefines.xcconfig.

• wtf/Platform.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:55 PM Changeset in webkit [239067] by Justin Michaud

• 11 edits
  3 copies
  5 adds in trunk

CS Painting API should support multiple worklets.
​https://bugs.webkit.org/show_bug.cgi?id=192335

Reviewed by Dean Jackson.

Source/WebCore:

Adds a new map to support separate paint worklet global scopes (one for each worklet). Also
adds some tests and a fix for a repaint bug that this oncovered, where changing a custom property required
for paint would not trigger a repaint if there had not been a valid value set before.

Test: fast/css-custom-paint/multiple-worklets.html

• css/CSSPaintImageValue.cpp:

(WebCore::CSSPaintImageValue::image):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::paintWorkletGlobalScope):
(WebCore::Document::setPaintWorkletGlobalScope):

• dom/Document.h:

(WebCore::Document::paintWorkletGlobalScope): Deleted.

• rendering/style/RenderStyle.cpp:

(WebCore::changedCustomPaintWatchedProperty):

• worklets/Worklet.cpp:

(WebCore::Worklet::addModule):

• worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::prepareForDestruction):

LayoutTests:

• fast/css-custom-paint/animate-repaint-expected.txt:
• fast/css-custom-paint/animate-repaint.html:
• fast/css-custom-paint/delay-expected.html: Added.
• fast/css-custom-paint/delay-repaint-expected.txt: Copied from LayoutTests/fast/css-custom-paint/animate-repaint-expected.txt.
• fast/css-custom-paint/delay-repaint.html: Copied from LayoutTests/fast/css-custom-paint/animate-repaint.html.
• fast/css-custom-paint/delay.html: Copied from LayoutTests/fast/css-custom-paint/animate-repaint.html.
• fast/css-custom-paint/multiple-worklets-expected.html: Added.
• fast/css-custom-paint/multiple-worklets.html: Added.

7:50 PM Changeset in webkit [239066] by Matt Baker

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r238599): unable to select specific timeline
​https://bugs.webkit.org/show_bug.cgi?id=192443
<rdar://problem/46608087>

Reviewed by Joseph Pecoraro.

When determining the trailing horizontal edge for TreeElement mouse
events, TreeOutline should not assume that its containing DOM element
is only as wide as its <ol> element.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.treeElementFromEvent):

7:46 PM Changeset in webkit [239065] by youenn@apple.com

• 16 edits
  2 deletes in trunk/Source

Remove derived classes of RealtimeMediaSourceCenter
​https://bugs.webkit.org/show_bug.cgi?id=192546

Reviewed by Eric Carlson.

Source/WebCore:

Remove virtual methods of RealtimeMediaSourceCenter and remove derived classes of it.
Instead port specific implementation directly implement the needed default factory methods.

Renamed some methods for improved consistency.
Moved some static variables as RealtimeMediaSourceCenter members.

No change of behavior.

• WebCore.xcodeproj/project.pbxproj:
• page/DeprecatedGlobalSettings.cpp:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::createMediaStream):
(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):
(WebCore::RealtimeMediaSourceCenter::getUserMediaDevices):
(WebCore::RealtimeMediaSourceCenter::setVideoCapturePageState):
(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
(WebCore::RealtimeMediaSourceCenter::audioCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::setVideoFactory):
(WebCore::RealtimeMediaSourceCenter::unsetVideoFactory):
(WebCore::RealtimeMediaSourceCenter::videoCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::setDisplayCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::unsetDisplayCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::displayCaptureFactory):

• platform/mediastream/RealtimeMediaSourceCenter.h:
• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::~RealtimeVideoSource):
(WebCore::RealtimeVideoSource::prepareToProduceData):

• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:

(WebCore::RealtimeMediaSourceCenter::singleton):
(WebCore::RealtimeMediaSourceCenter::defaultAudioCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::defaultVideoCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::defaultDisplayCaptureFactory):

• platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h: Removed.
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::setupCaptureSession):

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::~DisplayCaptureSourceCocoa):
(WebCore::DisplayCaptureSourceCocoa::startProducingData):

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenter::singleton):
(WebCore::RealtimeMediaSourceCenter::defaultAudioCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::defaultVideoCaptureFactory):
(WebCore::RealtimeMediaSourceCenter::defaultDisplayCaptureFactory):

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.h: Removed.
• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
(WebCore::MockRealtimeMediaSourceCenter::audioCaptureFactory):
(WebCore::MockRealtimeMediaSourceCenter::videoCaptureFactory):

• platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit:

pdate code according WebCore changes.

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::initialize):

7:43 PM Changeset in webkit [239064] by youenn@apple.com

• 6 edits in trunk

DataChannels created asynchronously never open and are unusable
​https://bugs.webkit.org/show_bug.cgi?id=192566

Reviewed by Eric Carlson.

Source/WebCore:

For every new data channel (remote or local), we should check the underlying backend state.
This allows firing events if needed.
We were not always doing that which was prohibiting sending some open
events for data channels created after the SCTP connection is set up.

Covered by updated test.

• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:

(WebCore::LibWebRTCDataChannelHandler::channelEvent):
(WebCore::LibWebRTCDataChannelHandler::setClient):
(WebCore::LibWebRTCDataChannelHandler::OnStateChange):
(WebCore::LibWebRTCDataChannelHandler::checkState):

• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:

LayoutTests:

• webrtc/datachannel/basic-expected.txt:
• webrtc/datachannel/basic.html:

7:05 PM Changeset in webkit [239063] by rniwa@webkit.org

• 4 edits in trunk/Source/WebCore

Use WeakPtr to refer to VTTCue in VTTCueBox
​https://bugs.webkit.org/show_bug.cgi?id=192575

Reviewed by Eric Carlson.

Address the FIXME in VTTCue::~VTTCue by clearing VTTCueBox::m_cue when VTTCue goes away.
This is implemented by simply using WeakPtr.

No new tests since there shoul be no behaivoral change.

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

• html/track/VTTCue.cpp:

(WebCore::VTTCueBox::VTTCueBox):
(WebCore::VTTCueBox::getCue const):
(WebCore::VTTCueBox::applyCSSProperties):
(WebCore::VTTCue::~VTTCue):

• html/track/VTTCue.h:

(WebCore::VTTCueBox::fontSizeFromCaptionUserPrefs const):

6:42 PM Changeset in webkit [239062] by mark.lam@apple.com

• 15 edits
  1 add in trunk

PropertyAttribute needs a CustomValue bit.
​https://bugs.webkit.org/show_bug.cgi?id=191993
<rdar://problem/46264467>

Reviewed by Saam Barati.

JSTests:

• stress/regress-191993.js: Added.

Source/JavaScriptCore:

This is because GetByIdStatus needs to distinguish CustomValue properties from
other types, and its only means of doing so is via the property's attributes.
Previously, there's nothing in the property's attributes that can indicate that
the property is a CustomValue.

We fix this by doing the following:

1. Added a PropertyAttribute::CustomValue bit.
2. Added a PropertyAttribute::CustomAccessorOrValue convenience bit mask that is CustomAccessor | CustomValue.

3. Since CustomGetterSetter properties are only set via JSObject::putDirectCustomAccessor(), we added a check in JSObject::putDirectCustomAccessor() to see if the attributes bits include PropertyAttribute::CustomAccessor. If not, then the property must be a CustomValue, and we'll add the PropertyAttribute::CustomValue bit to the attributes bits.

This ensures that the property attributes is sufficient to tell us if the
property contains a CustomGetterSetter.

4. Updated all checks for PropertyAttribute::CustomAccessor to check for PropertyAttribute::CustomAccessorOrValue instead if their intent is to check for the presence of a CustomGetterSetter as opposed to checking specifically for one that is used as a CustomAccessor.

This includes all the Structure transition code that needs to capture the
attributes change when a CustomValue has been added.

5. Filtered out the PropertyAttribute::CustomValue bit in PropertyDescriptor. The fact that we're using a CustomGetterSetter as a CustomValue should remain invisible to the descriptor. This is because the descriptor should describe a CustomValue no differently from a plain value.

6. Added some asserts to ensure that property attributes are as expected, and to document some invariants.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):

• bytecode/InByIdStatus.cpp:

(JSC::InByIdStatus::computeForStubInfoWithoutExitSiteFeedback):

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

• runtime/JSFunction.cpp:

(JSC::getCalculatedDisplayName):

• runtime/JSObject.cpp:

(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):

• runtime/JSObject.h:

(JSC::JSObject::putDirectIndex):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::putDirect):

• runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal):

• runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setCustomDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):

• runtime/PropertySlot.h:

(JSC::PropertySlot::setCustomGetterSetter):

Source/WebCore:

This patch revealed a bug in the CodeGenerator where a constructor property is
set with a ReadOnly attribute. This conflicts with the WebIDL link (see clause
12 in ​https://heycam.github.io/webidl/#interface-prototype-object) which states
that it should be [Writable]. The ReadOnly attribute is now removed.

On the WebCore side, this change is covered by existing tests.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):

5:17 PM Changeset in webkit [239061] by don.olmstead@sony.com

• 4 edits in trunk

[CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
​https://bugs.webkit.org/show_bug.cgi?id=192574

Reviewed by Michael Catanzaro.

.:

• Source/cmake/WebKitFeatures.cmake:

Tools:

• Scripts/webkitperl/FeatureList.pm:

4:35 PM Changeset in webkit [239060] by Ross Kirsling

• 2 edits in trunk

Add test262-results directory to .gitignore.
​https://bugs.webkit.org/show_bug.cgi?id=192547

Reviewed by Dean Jackson.

• .gitignore:

4:32 PM Changeset in webkit [239059] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit

Animated scrolling on Google Maps scrolls the page in addition to moving the map
​https://bugs.webkit.org/show_bug.cgi?id=192521
<rdar://problem/46382007>

Reviewed by Sam Weinig.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
Only do keyboard-based rubber-banding in directions that we can actually
scroll, not directions we can only finger-rubber-band in. This effectively
means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".

4:08 PM Changeset in webkit [239058] by don.olmstead@sony.com

• 2 edits in trunk/Tools

Sync FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=192565

Reviewed by Michael Catanzaro.

• Scripts/webkitperl/FeatureList.pm:

3:56 PM Changeset in webkit [239057] by Antti Koivisto

• 9 edits in trunk/Source

Rename "forced style recalc" to "full style rebuild"
​https://bugs.webkit.org/show_bug.cgi?id=192572

Reviewed by Zalan Bujtas.

Source/WebCore:

The old name is confusing.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::hasValidStyleForProperty):

• dom/Document.cpp:

(WebCore::Document::scheduleStyleRebuild):
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::unscheduleStyleRecalc):
(WebCore::Document::hasPendingStyleRebuild const):
(WebCore::Document::resolveStyle):
(WebCore::Document::needsStyleRecalc const):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::invalidateMatchedPropertiesCacheAndForceStyleRecalc):
(WebCore::Document::setDesignMode):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setAnimatingFullScreen):
(WebCore::Document::setFullscreenControlsHidden):
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::hasPendingForcedStyleRecalc const): Deleted.

• dom/Document.h:
• dom/Element.cpp:

(WebCore::Element::needsStyleInvalidation const):

• page/Page.cpp:

(WebCore::Page::updateStyleAfterChangeInEnvironment):

• style/StyleScope.cpp:

(WebCore::Style::Scope::updateActiveStyleSheets):

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm:

(-[WebHTMLView setNeedsToApplyStyles:]):

3:36 PM Changeset in webkit [239056] by commit-queue@webkit.org

• 15 edits in trunk/Source

Unreviewed, rolling out r239023.
​https://bugs.webkit.org/show_bug.cgi?id=192571

Speculative rollout due to broken perf test (Requested by
deanj on #webkit).

Reverted changeset:

"Enable HTTP and HTTPS proxies on iOS and make it a property
of the NSURLSession"
​https://bugs.webkit.org/show_bug.cgi?id=192374
​https://trac.webkit.org/changeset/239023

3:14 PM Changeset in webkit [239055] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

LinkBuffer::copyCompactAndLinkCode() needs to be aware of ENABLE(SEPARATED_WX_HEAP).
​https://bugs.webkit.org/show_bug.cgi?id=192569
<rdar://problem/45615617>

Reviewed by Saam Barati.

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

3:05 PM Changeset in webkit [239054] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Include CoreGraphics.h from WebCorePrefix.h
​https://bugs.webkit.org/show_bug.cgi?id=192557

Reviewed by Tim Horton.

The theory is that this will improve build time. Let's try and see what bots say.

• WebCorePrefix.h:

2:18 PM Changeset in webkit [239053] by Wenson Hsieh

• 5 edits in trunk

[iOS] Unable to upload data that conforms to "public.item" but not "public.content"
​https://bugs.webkit.org/show_bug.cgi?id=192555
<rdar://problem/35204990>

Reviewed by Tim Horton.

Source/WebCore:

Add support for uploading content that conforms to "public.item" via drag and drop. Currently, iOS WebKit only
supports data that conforms to "public.content", but there exist several types of files that conform to
"public.item" but not "public.content". See below for more detail.

Test: DragAndDropTests.ExternalSourcePKCS12ToSingleFileInput

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):

Update this to include "public.item", and remove "public.folder", which is now redundant because "public.folder"
conforms to "public.item".

• platform/ios/WebItemProviderPasteboard.mm:

(-[NSItemProvider web_containsFileURLAndFileUploadContent]):

Pull out the "contains content that is supported for file uploads" part of this helper method into a separate
method, and use it within -web_containsFileURLAndFileUploadContent. Note that this prevents "public.url"-
conformant data from being uploaded as files (i.e., we never want to upload a URL string *itself* as a file).
Drawing this distinction ensures that we don't confuse item providers that contain just a URL as files when
dropping into a file upload area or file input (see API test: ExternalSourceZIPArchiveAndURLToSingleFileInput
for an example of this corner case).

(-[NSItemProvider web_containsFileUploadContent]):
(-[WebItemProviderPasteboard numberOfFiles]):

Refactor this to use -web_containsFileUploadContent.

Tools:

Add a test to verify that .p12 files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
only support uploading "public.content", so files such as these would not be accepted when dropping into file
inputs, or be exposed as files on DataTransfer.

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::TEST):

2:10 PM Changeset in webkit [239052] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the iOS build after r239039.
​https://bugs.webkit.org/show_bug.cgi?id=192568

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView dropInteraction:sessionDidUpdate:]):

2:03 PM Changeset in webkit [239051] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Move TreeOutlineGroup coordination out of TreeElement
​https://bugs.webkit.org/show_bug.cgi?id=192487
<rdar://problem/46543431>

Reviewed by Devin Rousso.

• UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.select):
(WI.TreeElement.prototype.deselect):

• UserInterface/Views/TreeOutlineGroup.js:

(WI.TreeOutlineGroup):
(WI.TreeOutlineGroup.prototype.itemAdded):
(WI.TreeOutlineGroup.prototype.itemRemoved):
(WI.TreeOutlineGroup.prototype._removeConflictingTreeSelections):
(WI.TreeOutlineGroup.prototype._treeOutlineSelectionDidChange):
(WI.TreeOutlineGroup.groupForTreeOutline): Deleted.
(WI.TreeOutlineGroup.prototype.didSelectTreeElement): Deleted.
make the group responsible for listening to selection changes from the
TreeOutlines it manages, and synchronizing the selection between them.

1:55 PM Changeset in webkit [239050] by ddkilzer@apple.com

• 2 edits in trunk/Tools

Injected bundle for WebKitTestRunner leaks WKTypeRef objects
<​https://webkit.org/b/192481>
<rdar://problem/46539059>

Follow-up to address Darin's feedback.

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::shouldDumpPixels const):
(WTR::TestRunner::whatToDump const):
(WTR::TestRunner::shouldWaitUntilDone const):
(WTR::TestRunner::shouldDumpFrameLoadCallbacks):
(WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
(WTR::TestRunner::secureEventInputIsEnabled const):
(WTR::TestRunner::isStatisticsPrevalentResource):
(WTR::TestRunner::isStatisticsVeryPrevalentResource):
(WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):
(WTR::TestRunner::isStatisticsGrandfathered):
(WTR::TestRunner::hasDOMCache):
(WTR::TestRunner::keyExistsInKeychain):

1:50 PM Changeset in webkit [239049] by achristensen@apple.com

• 3 edits in trunk/Source/WebKit

Fix WatchOS build.

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView actionNameForFocusedFormControlView:]):

1:48 PM Changeset in webkit [239048] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Ref tests don't respect platform specific expectations
​https://bugs.webkit.org/show_bug.cgi?id=192515
<rdar://problem/46564839>

Reviewed by Lucas Forschler.

• Scripts/webkitpy/port/base.py:

(Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
(Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
(Port.expected_filename): Remove irrelevant FIXME, code clean-up.
(Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
search all platform expectations as well.

• Scripts/webkitpy/port/base_unittest.py:

(test_ref_tests_platform_directory):

1:30 PM Changeset in webkit [239047] by Matt Lewis

• 57 edits in trunk/Source/WebKit

Unreviewed, rolling out r239029.

This patch caused internal build failures.

Reverted changeset:

"[meta][WebKit] Remove using namespace WebCore and WebKit in
the global scope for unified source builds"
​https://bugs.webkit.org/show_bug.cgi?id=192449
​https://trac.webkit.org/changeset/239029

1:26 PM Changeset in webkit [239046] by Chris Dumez

• 13 edits in trunk

Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=192509
<rdar://problem/46500832>

Reviewed by Alex Christensen.

Source/WebCore:

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomUserAgent):
(WebCore::DocumentLoader::customUserAgent const):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::userAgent const):

Source/WebKit:

Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess instead of doing
it at resource-level from the injected bundle.

The custom user-agent string can now be set on _WKWebsitePolicies during the
decidePolicyForNavigationAction for the main feame, and will impact this main resource load as well as its
future subresource loads.

• Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

• Shared/WebsitePoliciesData.h:
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies setCustomUserAgent:]):
(-[_WKWebsitePolicies customUserAgent]):

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
(-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
(-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
(-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomUserAgentDelegate webView:didFinishNavigation:]):

1:11 PM Changeset in webkit [239045] by Caio Lima

• 22 edits
  5 adds in trunk

[BigInt] Add ValueMul into DFG
​https://bugs.webkit.org/show_bug.cgi?id=186175

Reviewed by Yusuke Suzuki.

JSTests:

• stress/big-int-mul-jit-osr.js: Added.
• stress/big-int-mul-jit-untyped.js: Added.
• stress/value-mul-fixup-int32-big-int.js: Added.

PerformanceTests:

• BigIntBench/big-int-simple-mul.js: Added.
• BigIntBench/value-mul-type-propagation.js: Added.

Source/JavaScriptCore:

This patch is adding a new DFG node called ValueMul. This node is
responsible to handle multiplication operations that can result into
non-number values. We emit such node during DFGByteCodeParser when the
operands are not numbers. During FixupPhase, we change this
operation to ArithMul if we can speculate Number/Boolean operands.

The BigInt specialization shows a small progression:

noSpec changes

big-int-simple-mul 18.8090+-1.0435 ^{17.4305+-0.2673} definitely 1.0791x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupMultiplication):
(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::arithNodeFlags):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueMul):
(JSC::DFG::SpeculativeJIT::compileArithMul):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileArithMul):

12:56 PM Changeset in webkit [239044] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Safe browsing warning should layout buttons vertically in narrow WKWebViews
​https://bugs.webkit.org/show_bug.cgi?id=192535
<rdar://problem/46308364>

Reviewed by Tim Horton.

They're usually next to each other, but in narrow WKWebViews they currently get clipped.
In order to make it more likely that both buttons are completely visible, put one above
the other if the WKWebView is too narrow to completely show both. This also helps with
languages where the translations of "Go Back" or "Show Details" are rendered wider than English.

• UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(buttonWidth):
(-[WKSafeBrowsingWarning addContent]):

12:46 PM Changeset in webkit [239043] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[GLib] FileSystem::moveFile() should fall back to copying
​https://bugs.webkit.org/show_bug.cgi?id=192562

Reviewed by Michael Catanzaro.

No new tests needed.

• platform/glib/FileSystemGlib.cpp:

(WebCore::FileSystem::moveFile): Use g_file_move() instead of a plain g_rename(), which
provides a fall-back which does copy+delete when a direct move or rename cannot be done.

12:43 PM Changeset in webkit [239042] by Simon Fraser

• 12 edits in trunk

Allow control over child order when adding nodes to the scrolling tree
​https://bugs.webkit.org/show_bug.cgi?id=176914
<rdar://problem/46542237>

Re-land r239010 after over-zealous rollout.

Source/WebCore:

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::attachToStateTree):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::attachToStateTree):

• page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::insertChild):
(WebCore::ScrollingStateNode::indexOfChild const):

• page/scrolling/ScrollingStateNode.h:
• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::nodeTypeAndParentMatch const):
(WebCore::ScrollingStateTree::attachNode):

• page/scrolling/ScrollingStateTree.h:

Source/WebKit:

• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::decode):

LayoutTests:

• platform/mac-wk2/TestExpectations:

12:42 PM Changeset in webkit [239041] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Document should throttle style recalc even when m_pendingStyleRecalcShouldForce is true.
​https://bugs.webkit.org/show_bug.cgi?id=191695

Reviewed by Zalan Bujtas.

• dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

Don't test for m_pendingStyleRecalcShouldForce.

(WebCore::Document::hasPendingStyleRecalc const):
(WebCore::Document::hasPendingForcedStyleRecalc const):

Don't base the pending status of these function on whether the timer is running.
Instead check if the style is invalid.

12:31 PM Changeset in webkit [239040] by commit-queue@webkit.org

• 8 edits in trunk

XMLHttpRequest removes spaces from content-types before processing
​https://bugs.webkit.org/show_bug.cgi?id=8644

Patch by Rob Buis <​rbuis@igalia.com> on 2018-12-10
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test expectations.

• web-platform-tests/mimesniff/mime-types/parsing.any-expected.txt:
• web-platform-tests/mimesniff/mime-types/parsing.any.worker-expected.txt:

Source/WebCore:

Stop trimming white space characters from the middle of
type/subtype value. Also make sure whitespace being parsed
adheres to OWS definition from RFC 7230 Section 3.2.3
(referenced by RFC 7231), i.e. space or HT.

Based on ​http://crrev.com/416586.

Behavior matches Firefox and Chrome.

Tests: http/tests/xmlhttprequest/supported-xml-content-types.html

web-platform-tests/mimesniff/mime-types/parsing.any.html
web-platform-tests/mimesniff/mime-types/parsing.any.worker.html

• platform/network/HTTPParsers.cpp:

(WebCore::extractMIMETypeFromMediaType):

LayoutTests:

Update improved test expectation and remove comment.

• http/tests/xmlhttprequest/supported-xml-content-types-expected.txt:
• http/tests/xmlhttprequest/supported-xml-content-types.html:

12:27 PM Changeset in webkit [239039] by Wenson Hsieh

• 17 edits in trunk

[iOS] Caret is obscured by finger when dragging over an editable element
​https://bugs.webkit.org/show_bug.cgi?id=192499
<rdar://problem/46570101>

Reviewed by Tim Horton.

Source/WebCore:

• page/DragActions.h:

Move DragHandlingMethod to DragActions.h, and drive-by fix some minor issues (i.e. make a couple of enum classes
use 8 bits, fix the indentation levels, and update the copyright year). Also add EnumTraits for
DragHandlingMethod so that it may be encoded over IPC.

• page/DragController.cpp:

(WebCore::dragIsHandledByDocument):

Simplify this helper function.

(WebCore::DragController::tryDocumentDrag):

• page/DragController.h:

Expose the current DragHandlingMethod via a const getter method.

(WebCore::DragController::dragHandlingMethod const):

Source/WebKit:

Add support for setting the precise property of UIDropProposal to YES when dragging over an editable area.
When enabled, this property shifts the drop location up by a small amount, allowing the user to see the drop
caret (currently, this is not the case, and it's difficult to drop text at a precise location on iOS). Changes
are covered by adding to existing API tests.

• Scripts/webkit/messages.py:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Add a new version of -_webView:willUpdateDataInteractionOperationToOperation:forSession: that receives and
returns a UIDropProposal, so that Mail can more easily port over existing logic in its legacy-WebKit-based
compose implementation. iOS Safari is currently the only client of this private delegate, so the old version can
be easily removed once Safari adopts this new version.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformDragControllerAction):

Add plumbing to send the latest drag handling method from WebPage to WebPageProxy.

(WebKit::WebPageProxy::resetCurrentDragInformation):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::currentDragHandlingMethod const):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView dropInteraction:sessionDidUpdate:]):

Call the new UI delegate hook when determining the drop proposal to return to UIKit. Additionally set the
precise bit on the drop proposal in the case where the drop handling method is either "editing rich text" or
"editing plain text".

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

• WebProcess/WebPage/WebPage.h:

Tools:

Augment some existing API tests to check that the precise flag is either on or off on UIDropProposal.

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:

(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator lastKnownDropProposal]):

Rename currentDropProposal to lastKnownDropProposal, and expose it as a readonly property.

(-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
(-[DragAndDropSimulator _advanceProgress]):
(-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
(-[DragAndDropSimulator showCustomActionSheetBlock]):
(-[DragAndDropSimulator setConvertItemProvidersBlock:]):
(-[DragAndDropSimulator convertItemProvidersBlock]):
(-[DragAndDropSimulator setOverridePerformDropBlock:]):
(-[DragAndDropSimulator overridePerformDropBlock]):
(-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
(-[DragAndDropSimulator overrideDragUpdateBlock]):
(-[DragAndDropSimulator setDropCompletionBlock:]):
(-[DragAndDropSimulator dropCompletionBlock]):

Refactor these properties to return and take normal Objective-C blocks, rather than BlockPtrs. However, use
BlockPtr instance variables to manage the lifetimes of these blocks.

(-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
(-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.

Update this to use the new WebKit delegate hook for overriding the drop proposal.

11:53 AM Changeset in webkit [239038] by youenn@apple.com

• 5 edits in trunk/Source

Make mock capture happen in the process used for real capture
​https://bugs.webkit.org/show_bug.cgi?id=192544

Reviewed by Eric Carlson.

Source/WebCore:

MockRealtimeMediaSourceCenter previously was setting its factories whenever mock capture is on.
Add booleans to choose which source (audio, video, display) will actually be toggled on.

Covered by existing tests.

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):

• platform/mock/MockRealtimeMediaSourceCenter.h:

(WebCore::MockRealtimeMediaSourceCenter::setMockAudioCaptureEnabled):
(WebCore::MockRealtimeMediaSourceCenter::setMockVideoCaptureEnabled):
(WebCore::MockRealtimeMediaSourceCenter::setMockDisplayCaptureEnabled):

Source/WebKit:

Make mock capture happen in the right process by only overriding
factories by mock factories for source types that UserMediaCaptureManager will not override.
That way, UserMediaCaptureManager will be used to go to UIProcess, where mock will be used as if it was the real capture.

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::initialize):

11:45 AM Changeset in webkit [239037] by dino@apple.com

• 7 edits in trunk/Source

Use text/javascript as recommended by the HTML specification
​https://bugs.webkit.org/show_bug.cgi?id=192525
<rdar://problem/46569636>

Reviewed by Jon Lee.

The HTML specification says we should use text/javascript for
JavaScript files:
​https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages:javascript-mime-type

Source/WebCore:

• loader/cache/CachedScript.cpp: Replace application/javascript with text/javascript.

(WebCore::CachedScript::CachedScript):

• platform/network/ios/WebCoreURLResponseIOS.mm: Ditto.

(WebCore::createExtensionToMIMETypeMap):

• platform/network/mac/WebCoreURLResponse.mm: Ditto.

(WebCore::createExtensionToMIMETypeMap):

Source/WebInspectorUI:

• UserInterface/Base/MIMETypeUtilities.js:

(WI.mimeTypeForFileExtension):

• UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype._attemptToDetermineMIMEType):

11:37 AM Changeset in webkit [239036] by dino@apple.com

• 6 edits
  2 adds in trunk/Source/WebCore

[iOS] Make WebGPU work with remote layer hosting
​https://bugs.webkit.org/show_bug.cgi?id=192508
<rdar://problem/46560649>

Reviewed by Tim Horton.

WebGPU wasn't working on iOS because we were not correctly
identifying the CALayers for remote hosting. Fix this by
adding a new CALayer type, WebGPULayer. This will also
eventually hold the code to render WebGPU into a canvas.

Covered by the existing reference tests (on device).

• SourcesCocoa.txt: Add new files.
• WebCore.xcodeproj/project.pbxproj: Ditto.

• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: Recognise the WebGPULayer

class for remote hosting.
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):

• platform/graphics/cocoa/WebGPULayer.h: Added. Very simple inheritance

from CAMetalLayer.

• platform/graphics/cocoa/WebGPULayer.mm: Added.

(-[WebGPULayer init]):
(-[WebGPULayer copyImageSnapshotWithColorSpace:]):

• platform/graphics/gpu/GPUSwapChain.h: Reference WebGPULayer rather

than CALayer.

• platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm: Ensure that

the WebGPULayer has a reference back to this object, which it
will use in the future.
(WebCore::GPUSwapChain::create):
(WebCore::GPUSwapChain::GPUSwapChain):

10:06 AM Changeset in webkit [239035] by ap@apple.com

• 4 edits in trunk/Source

Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h
​https://bugs.webkit.org/show_bug.cgi?id=192428

Reviewed by Tim Horton.

Source/WebKit:

• config.h:

Source/WTF:

• wtf/Platform.h:

9:55 AM Changeset in webkit [239034] by ap@apple.com

• 4 edits in trunk/Source

Move more macros out of WebKit's config.h
​https://bugs.webkit.org/show_bug.cgi?id=192430

Reviewed by Tim Horton.

Source/WebKit:

• config.h:

Source/WTF:

• wtf/Platform.h:

9:51 AM Changeset in webkit [239033] by Chris Dumez

• 4 edits in trunk/Source

[macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
​https://bugs.webkit.org/show_bug.cgi?id=192533
rdar://problem/45732710

Patch by Darin Adler <Darin Adler> on 2018-12-10
Reviewed by Anders Carlsson.

Source/WebCore/PAL:

• pal/spi/mac/HIServicesSPI.h: Added kMSHDoNotCreateSendRightOption.

Source/WebKitLegacy/mac:

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.

9:50 AM Changeset in webkit [239032] by Chris Dumez

• 3 edits in trunk/Source/WebKitLegacy/mac

[macOS] Use mach_port_mod_refs instead of mach_port_destroy
​https://bugs.webkit.org/show_bug.cgi?id=192532
rdar://problem/45731047

Patch by Darin Adler <Darin Adler> on 2018-12-10
Reviewed by Chris Dumez.

• Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.

9:17 AM Changeset in webkit [239031] by Truitt Savell

• 6 edits
  2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r238965.

Caused internal iOS build failures

Reverted changeset:

"[iOS] Make WebGPU work with remote layer hosting"
​https://bugs.webkit.org/show_bug.cgi?id=192508
​https://trac.webkit.org/changeset/238965

8:30 AM Changeset in webkit [239030] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

MockLibWebRTCPeerConnectionFactory should isolate copy its test case
​https://bugs.webkit.org/show_bug.cgi?id=192545

Reviewed by Eric Carlson.

Isolate copy the test case member so that it can be destroyed on another thread.
Covered by existing test that should no longer crash.

• testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::useMockRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory):

• testing/MockLibWebRTCPeerConnection.h:

(WebCore::MockLibWebRTCPeerConnectionFactory::create):

8:07 AM Changeset in webkit [239029] by Chris Fleizach

• 57 edits in trunk/Source/WebKit

[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
​https://bugs.webkit.org/show_bug.cgi?id=192449

Reviewed by Darin Adler.

• NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:
• NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
• NetworkProcess/ios/NetworkProcessIOS.mm:
• NetworkProcess/mac/NetworkProcessMac.mm:
• NetworkProcess/mac/RemoteNetworkingContext.mm:
• Platform/spi/ios/AccessibilitySupportSPI.h:
• PlatformMac.cmake:
• PluginProcess/PluginControllerProxy.cpp:
• PluginProcess/PluginProcess.cpp:
• PluginProcess/WebProcessConnection.cpp:
• Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb:
• Shared/API/c/cf/WKErrorCF.cpp:

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

• Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateCGImage):
(WKImageCreateFromCGImage):

• Shared/ChildProcess.cpp:
• Shared/ContextMenuContextData.cpp:
• Shared/EditorState.cpp:
• Shared/Plugins/NPIdentifierData.cpp:
• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
• Shared/SessionState.cpp:
• Shared/SessionTracker.cpp:
• Shared/ShareableBitmap.cpp:
• Shared/ShareableResource.cpp:
• Shared/VisibleContentRectUpdateInfo.cpp:
• Shared/WebBackForwardListItem.cpp:
• Shared/WebContextMenuItemData.cpp:
• Shared/WebCoreArgumentCoders.cpp:
• Shared/WebHitTestResultData.cpp:
• Shared/WebImage.cpp:
• Shared/WebMediaSessionMetadata.cpp:
• Shared/WebMemorySampler.cpp:
• Shared/WebMouseEvent.cpp:
• Shared/WebRenderObject.cpp:
• Shared/WebSQLiteDatabaseTracker.cpp:
• Shared/WebWheelEvent.cpp:
• Shared/cf/ArgumentCodersCF.cpp:
• Shared/ios/WebPlatformTouchPointIOS.cpp:
• SourcesCocoa.txt:
• UIProcess/API/APIContentRuleListStore.cpp:
• UIProcess/API/APIHitTestResult.cpp:
• UIProcess/API/APINavigation.cpp:
• UIProcess/API/APIOpenPanelParameters.cpp:
• UIProcess/API/APIPageConfiguration.cpp:
• UIProcess/API/C/WKPage.cpp:

(WKPageLoadURLWithShouldOpenExternalURLsPolicy):
(WKPageLoadURLWithUserData):
(WKPageLoadURLRequestWithUserData):
(WKPageSetPaginationMode):
(WKPageGetPaginationMode):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):

• UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
• UIProcess/WebStorage/LocalStorageDatabase.cpp:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
(-[WKContentView dealloc]):
(-[WKContentView page]):
(-[WKContentView updateFixedClippingView:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(-[WKContentView _updateForScreen:]):
(-[WKContentView _accessibilityRegisterUIProcessTokens]):
(-[WKContentView _createDrawingAreaProxy]):
(-[WKContentView _didCommitLayerTree:]):
(-[WKContentView _wk_pageCountForPrintFormatter:]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]):
(hasAssistedNode):
(-[WKContentView setupInteraction]):
(-[WKContentView positionInformation]):
(-[WKContentView _webTouchEventsRecognized:]):
(inflateQuad):
(-[WKContentView _updateTapHighlight]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView inputView]):
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView currentPositionInformation]):
(-[WKContentView doAfterPositionInformationUpdate:forRequest:]):
(-[WKContentView _currentPositionInformationIsValidForRequest:]):
(-[WKContentView _hasValidOutstandingPositionInformationRequest:]):
(-[WKContentView _currentPositionInformationIsApproximatelyValidForRequest:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView webSelectionRectsForSelectionRects:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _stylusSingleTapRecognized:]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView supportedPasteboardTypesForCurrentSelection]):
(-[WKContentView _lookupForWebView:]):
(-[WKContentView _shareForWebView:]):
(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView selectForWebView:]):
(-[WKContentView _accessibilityRetrieveRectsEnclosingSelectionOffset:withGranularity:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
(toGestureType):
(toUIWKGestureType):
(toSelectionTouch):
(toUIWKSelectionTouch):
(toGestureRecognizerState):
(toUIGestureRecognizerState):
(toUIWKSelectionFlags):
(toWKTextGranularity):
(toWKSelectionDirection):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView autocorrectionData]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKContentView _updateAccessory]):
(-[WKContentView selectedTextRange]):
(-[WKContentView setMarkedText:selectedRange:]):
(coreWritingDirection):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView insertText:]):
(-[WKContentView textInputTraits]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:]):
(-[WKContentView assistedNodeInformation]):
(-[WKContentView assistedNodeSelectOptions]):
(isAssistableInputType):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _stopAssistingNode]):
(-[WKContentView updateCurrentAssistedNodeInformation:]):
(-[WKContentView presentViewControllerForCurrentAssistedNode]):
(-[WKContentView actionNameForFocusedFormControlView:]):
(-[WKContentView selectWordForReplacement]):
(-[WKContentView _updateChangedSelection:]):
(-[WKContentView _beginSuppressingSelectionAssistantForReason:]):
(-[WKContentView _stopSuppressingSelectionAssistantForReason:]):
(-[WKContentView _showPlaybackTargetPicker:fromRect:routeSharingPolicy:routingContextUID:]):
(-[WKContentView _showRunOpenPanel:resultListener:]):
(-[WKContentView _showShareSheet:completionHandler:]):
(-[WKContentView positionInformationForActionSheetAssistant:]):
(-[WKContentView updatePositionInformationForActionSheetAssistant:]):
(-[WKContentView _startDrag:item:]):
(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView _didHandleStartDataInteractionRequest:]):
(dropOperationForWebCoreDragOperation):
(-[WKContentView dragDataForDropSession:dragDestinationAction:]):
(-[WKContentView _didConcludeEditDataInteraction:]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _prepareToDragPromisedAttachment:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:]):
(-[WKContentView _autofillContext]):
(-[WKContentView _dragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):
(-[WKContentView allowsLanguageSelectionMenuForListViewController:]):
(-[WKContentView shouldDisplayInputContextViewForListViewController:]):
(-[WKContentView numericInputModeForListViewController:]):
(-[WKContentView textContentTypeForListViewController:]):
(-[WKContentView allowsDictationInputForListViewController:]):
(-[WKContentView _simulateLongPressActionAtLocation:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _presentationRectsForPreviewItemController:]):

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
(WKFullScreenViewControllerVideoFullscreenModelClient::setInterface):
(WKFullScreenViewControllerVideoFullscreenModelClient::interface const):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController _manager]):
(-[WKFullScreenViewController _togglePiPAction:]):

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullscreenAnimationController configureInitialAndFinalStatesForTransition:]):
(-[WKFullScreenWindowController isFullScreen]):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController webViewDidRemoveFromSuperviewWhileInFullscreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
(-[WKFullScreenWindowController _manager]):

• UIProcess/mac/WebPageProxyMac.mm:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageConnection.cpp:
• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(mediaTimeToCurrentTime):
(-[WKAnimationDelegate initWithLayerID:layerTreeHost:]):

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):

6:58 AM Changeset in webkit [239028] by Michael Catanzaro

• 2 edits in trunk/Tools

[WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
​https://bugs.webkit.org/show_bug.cgi?id=190241

Reviewed by Carlos Garcia Campos.

run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
Currently this actually creates the directories needed for the flatpak environment. Fix it.

• flatpak/flatpakutils.py:

(WebkitFlatpak.clean_args):
(WebkitFlatpak.run):

6:56 AM Changeset in webkit [239027] by Michael Catanzaro

• 2 edits in trunk/Tools

[GTK] Don't use the slice allocator
​https://bugs.webkit.org/show_bug.cgi?id=192360

Reviewed by Carlos Garcia Campos.

• MiniBrowser/gtk/main.c:

(aboutDataRequestFree):
(aboutDataRequestNew):

1:05 AM Changeset in webkit [239026] by timothy_horton@apple.com

• 6 edits in trunk

WKWebView should support custom tintColor
​https://bugs.webkit.org/show_bug.cgi?id=192518
<rdar://problem/37243261>

Reviewed by Wenson Hsieh.

Source/WebKit:

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView insertionPointColor]):
(-[WKContentView selectionBarColor]):
(-[WKContentView selectionHighlightColor]):
Grab insertion point and selection colors from UITextInputTraits.

(-[WKContentView _updateInteractionTintColor]):
Determine our effective tint color:

• transparent if interaction is disabled
• a CSS-derived color if caret-color style is applied
• the _inheritedInteractionTintColor, which climbs up to the tintColor API

Apply it to our UITextInputTraits.

(-[WKContentView tintColorDidChange]):
(-[WKContentView textInputTraits]):
Call _updateInteractionTintColor whenever we create a new UITextInputTraits
or when the tint color changes.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:

(TestWebKitAPI::TEST):
Add a test that tintColor affects UITextInputTraits' interaction colors.