Timeline

Dec 14, 2018:

11:51 PM Changeset in webkit [239250] by ap@apple.com

• 3 edits in trunk/Tools

Add a style checker rule for Xcode version macros use
​https://bugs.webkit.org/show_bug.cgi?id=192703

Reviewed by Alex Christensen.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_os_version_checks):
(process_line):
(CppChecker):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_os_version_checks):

11:48 PM Changeset in webkit [239249] by Darin Adler

• 2 edits in trunk/Source/WTF

Verify size is valid in USE_SYSTEM_MALLOC version of tryAllocateZeroedVirtualPages
​https://bugs.webkit.org/show_bug.cgi?id=192738
rdar://problem/37502342

Reviewed by Mark Lam.

• wtf/Gigacage.cpp:

(Gigacage::tryAllocateZeroedVirtualPages): Added a RELEASE_ASSERT just
like the one in tryLargeZeroedMemalignVirtual in bmalloc.

11:42 PM Changeset in webkit [239248] by Darin Adler

• 3 edits in trunk/Source/JavaScriptCore

LiteralParser has a bunch of uses of String::format with untrusted data
​https://bugs.webkit.org/show_bug.cgi?id=108883
rdar://problem/13666409

Reviewed by Mark Lam.

• runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex): Use makeString instead of String::format.
(JSC::LiteralParser<CharType>::Lexer::lexStringSlow): Ditto.
(JSC::LiteralParser<CharType>::parse): Ditto.

• runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage): Use string concatenation instead of
String::format.

8:30 PM Changeset in webkit [239247] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Avoid creating and evaluating in the InspectorOverlay page on iOS as it is unused
​https://bugs.webkit.org/show_bug.cgi?id=192724
<rdar://problem/46745911>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-14
Reviewed by Devin Rousso.

iOS never installs the InspectorOverlay page as a page overlay.
It also uses its own node highlighting painting. Avoid any work
and resources associated with the overlay page for iOS.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::evaluateCommandInOverlay):

7:34 PM Changeset in webkit [239246] by Matt Baker

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r238599): Uncaught Exception: TypeError: null is not an object (evaluating 'treeElement.listItemElement.classList')
​https://bugs.webkit.org/show_bug.cgi?id=192090
<rdar://problem/46318614>

Reviewed by Devin Rousso.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
Check that listItemElement is valid before accessing it to update class
names. The selection can change before the TreeElement has been attached.

7:05 PM Changeset in webkit [239245] by keith_miller@apple.com

• 2 edits in trunk/Source/bmalloc

Gigacage runway should immediately follow the primitive cage
​https://bugs.webkit.org/show_bug.cgi?id=192733

Reviewed by Saam Barati.

This patch makes sure that the Gigacage runway is always
immediately after the primitive cage. Since writing outside the
primitive gigacage is likely to be more dangerous than the JSValue
cage. The ordering of the cages is still random however.

• bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):

6:28 PM Changeset in webkit [239244] by mark.lam@apple.com

• 9 edits
  1 add in trunk

CallFrame::convertToStackOverflowFrame() needs to keep the top CodeBlock alive.
​https://bugs.webkit.org/show_bug.cgi?id=192717
<rdar://problem/46660677>

Reviewed by Saam Barati.

JSTests:

• stress/regress-192717.js: Added.

Source/JavaScriptCore:

When throwing a StackOverflowError, we convert the topCallFrame into a
StackOverflowFrame. Previously, we would nullify the codeBlock field in the frame
because a StackOverflowFrame is only a sentinel and doesn't really correspond to
any CodeBlocks. However, this is a problem because the topCallFrame may be the
only remaining place that references the CodeBlock that the stack overflow is
triggered in. The way we handle exceptions in JIT code is to return (from the
runtime operation function throwing the exception) to the JIT code to check for
the exception and if needed, do some clean up before jumping to the exception
handling thunk. As a result, we need to keep that JIT code alive, which means we
need to keep its CodeBlock alive. We only need to keep this CodeBlock alive until
we've unwound (in terms of exception handling) out of it.

We fix this issue by storing the CodeBlock to keep alive in the StackOverflowFrame
for the GC to scan while the frame is still on the stack.

We removed the call to convertToStackOverflowFrame() in
lookupExceptionHandlerFromCallerFrame() because it is redundant.
lookupExceptionHandlerFromCallerFrame() will only every be called after
a StackOverFlowError has been thrown. Hence, the top frame is already
guaranteed to be a StackOverflowFrame, and there should always be a
StackOverFlowError exception pending. We added assertions for these
instead.

• interpreter/CallFrame.cpp:

(JSC::CallFrame::convertToStackOverflowFrame):

• interpreter/CallFrame.h:
• jit/JITOperations.cpp:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::codeBlockFromCallFrameCallee):
(JSC::CommonSlowPaths::arityCheckFor):

• runtime/VM.h:

(JSC::VM::exceptionForInspection const):

5:07 PM Changeset in webkit [239243] by youenn@apple.com

• 8 edits
  2 adds in trunk

MediaRecorderPrivateAVFImpl should have a Ref<MediaRecorderPrivateWriter> as member
​https://bugs.webkit.org/show_bug.cgi?id=192720

Reviewed by Eric Carlson.

Source/WebCore:

Make sure that MediaRecorderPrivateAVFImpl takes a Ref<MediaRecorderPrivateWriter> as member,
as the latter is a ref counted object.
Made some refactoring to return early in case of error.

Also made sure that in the case of a MediaRecorder stopped by a track removal in the recorded stream
the MediaRecorder will stop listening for its tracks.
Otherwise, the tracks will continue calling the MediaRecorder even after it is dead.

Test: http/wpt/mediarecorder/MediaRecorder-onremovetrack.html

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::didAddOrRemoveTrack):
(WebCore::MediaRecorder::setNewRecordingState): Deleted.

• Modules/mediarecorder/MediaRecorder.h:
• platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):
(WebCore::MediaRecorderPrivateAVFImpl::MediaRecorderPrivateAVFImpl):
(WebCore::MediaRecorderPrivateAVFImpl::sampleBufferUpdated):
(WebCore::MediaRecorderPrivateAVFImpl::audioSamplesAvailable):
(WebCore::MediaRecorderPrivateAVFImpl::stopRecording):
(WebCore::MediaRecorderPrivateAVFImpl::fetchData):

• platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::MediaRecorderPrivateWriter):
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::setupWriter): Deleted.

LayoutTests:

• http/wpt/mediarecorder/MediaRecorder-onremovetrack-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-onremovetrack.html: Added.

4:55 PM Changeset in webkit [239242] by Alan Coon

• 9 edits
  1 copy
  2 adds in branches/safari-606-branch

Apply patch. rdar://problem/46603448

4:30 PM Changeset in webkit [239241] by Ryan Haddad

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the build with recent SDKs.

• UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):

4:06 PM Changeset in webkit [239240] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=192716

Reviewed by Eric Carlson.

​https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

4:04 PM Changeset in webkit [239239] by Kocsen Chung

• 1 edit in branches/safari-606-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h

Apply patch. rdar://problem/46085281

3:52 PM Changeset in webkit [239238] by youenn@apple.com

• 9 edits in trunk

getSenders/getReceivers() should not return closed transceiver senders/receivers
​https://bugs.webkit.org/show_bug.cgi?id=192706

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html:
• web-platform-tests/webrtc/RTCRtpTransceiver.https.html:

Source/WebCore:

Updated as per ​https://github.com/w3c/webrtc-pc/commit/85284b76baebf9e149d194e692be16a21768a91a
This forces us to compute the sender/receiver list at getter call time.
Updated the internal call sites of senders to use the list of transceivers instead.

Covered by updated WPT tests.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::getSenders const):
(WebCore::RTCPeerConnection::getReceivers const):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RTCRtpTransceiver::stopped const):
(WebCore::RtpTransceiverSet::append):
(WebCore::RtpTransceiverSet::senders const):
(WebCore::RtpTransceiverSet::receivers const):

• Modules/mediastream/RTCRtpTransceiver.h:

(WebCore::RtpTransceiverSet::senders const): Deleted.
(WebCore::RtpTransceiverSet::receivers const): Deleted.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::findExistingSender):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):

3:23 PM Changeset in webkit [239237] by ddkilzer@apple.com

• 5 edits in trunk/Source

clang-tidy: Fix unnecessary copy of objects for operator==() methods
<​https://webkit.org/b/192712>
<rdar://problem/46739332>

Reviewed by Andy Estes.

Source/JavaScriptCore:

• b3/air/AirAllocateRegistersByGraphColoring.cpp:

(JSC::B3::Air::(anonymous namespace)::AbstractColoringAllocator::InterferenceEdge::operator==):

• Change argument from const to const reference to avoid a copy.

Source/WebCore:

• contentextensions/HashableActionList.h:

(WebCore::ContentExtensions::HashableActionList::operator== const):
(WebCore::ContentExtensions::HashableActionList::operator!= const):

• platform/network/FormData.h:

(WebCore::FormDataElement::EncodedFileData::operator== const):
(WebCore::FormDataElement::EncodedBlobData::operator== const):

• Change arguments from const to const reference to avoid copies.

2:59 PM Changeset in webkit [239236] by jer.noble@apple.com

• 4 edits in trunk/Source/WebCore

CRASH in CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession(WTF::String const&, WTF::Function<void ()>&&)
​https://bugs.webkit.org/show_bug.cgi?id=192713
<rdar://problem/46739706>

Reviewed by Eric Carlson.

A callback is being called twice, and the second time has a null Promise. Instead of these
callbacks being WTF::Function, make them WTF::CompletionHandlers, which self-nullify and
have ASSERTS() that they are called once-and-only-once.

• platform/encryptedmedia/CDMInstanceSession.h:
• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceSessionClearKey::closeSession):

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed):

2:49 PM Changeset in webkit [239235] by jiewen_tan@apple.com

• 4 edits in trunk/Source/WebKit

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 2.

Add some additional temporary logging info. Since the failure cannot be reproduced easily by human, we have to
rely on the test infrastructure to reporoduce it. Once the bug is determined and fixed, we should remove all
logging added in this patch.

• UIProcess/WebAuthentication/Cocoa/HidService.mm:

(WebKit::HidService::deviceAdded):

• UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:

(WebKit::CtapHidAuthenticator::makeCredential):
(WebKit::CtapHidAuthenticator::getAssertion):

• UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:

(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::transact):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):

2:33 PM Changeset in webkit [239234] by Kocsen Chung

• 7 edits in tags/Safari-607.1.16.4/Source

Versioning.

2:30 PM Changeset in webkit [239233] by Kocsen Chung

• 1 copy in tags/Safari-607.1.16.4

New tag.

1:50 PM Changeset in webkit [239232] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
<​https://webkit.org/b/192710>
<rdar://problem/46738962>

Reviewed by Eric Carlson.

• wtf/Logger.h:

(WTF::LogArgument::toString): Make argument a const reference to
avoid the copy.

1:40 PM Changeset in webkit [239231] by commit-queue@webkit.org

• 34 edits
  6 deletes in trunk

Unreviewed, rolling out r239153, r239154, and r239155.
​https://bugs.webkit.org/show_bug.cgi?id=192715

Caused flaky GC-related crashes seen with layout tests
(Requested by ryanhaddad on #webkit).

Reverted changesets:

"[JSC] Optimize Object.keys by caching own keys results in
StructureRareData"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239153

"Unreviewed, build fix after r239153"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239154

"Unreviewed, build fix after r239153, part 2"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239155

1:12 PM Changeset in webkit [239230] by ddkilzer@apple.com

• 7 edits in trunk/Source/WebCore

clang-tidy: Fix unnecessary object copies in WebCore/platform/graphics/avfoundation/objc/
<​https://webkit.org/b/192708>
<rdar://problem/46735907>

Reviewed by Jer Noble.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::toSample):

• Make argument a const reference.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• Update method signatures for implementation changes.
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):

• Make RetainPtr<> argument an rvalue reference and use WTFMove().

(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):

• Make RetainPtr<> argument a const reference.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVolume):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setMuted):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPreservesPitch):

• Change for loop keys to be const references.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• Update method signatures for implementation changes.
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):

• Make Mediatime arguments a const reference.

1:05 PM Changeset in webkit [239229] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[GTK] Unreviewed build fix.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Add missing WebPolicyAction.h include.

12:59 PM Changeset in webkit [239228] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed, fix assertion failure in API test after r239210.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createDocumentLoader):

12:53 PM Changeset in webkit [239227] by keith_miller@apple.com

• 6 edits
  1 add in trunk

Callers of JSString::getIndex should check for OOM exceptions
​https://bugs.webkit.org/show_bug.cgi?id=192709

Reviewed by Mark Lam.

JSTests:

• stress/StringObject-define-length-getter-rope-string-oom.js: Added.

Source/JavaScriptCore:

This patch also allows Strings to OOM when the StringObject wrapper
attempts to look up an own property on the string.

Remove isExtensibleImpl because it's only used in one place and call
isStructureExtensible instead.

• runtime/JSObject.cpp:

(JSC::JSObject::isExtensible):

• runtime/JSObject.h:

(JSC::JSObject::isExtensibleImpl): Deleted.

• runtime/JSString.h:

(JSC::JSString::getStringPropertySlot):

• runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

12:41 PM Changeset in webkit [239226] by Matt Baker

• 7 edits in trunk

Web Inspector: Cookies view should use model objects instead of raw payload data
​https://bugs.webkit.org/show_bug.cgi?id=189533
<rdar://problem/44364183>

Reviewed by Joseph Pecoraro and Devin Rousso.

Source/WebInspectorUI:

• UserInterface/Models/Cookie.js:

(WI.Cookie):
(WI.Cookie.fromPayload):
(WI.Cookie.parseSetCookieResponseHeader):
(WI.Cookie.prototype.get type):
(WI.Cookie.prototype.get name):
(WI.Cookie.prototype.get value):
(WI.Cookie.prototype.get header):
(WI.Cookie.prototype.get expires):
(WI.Cookie.prototype.get maxAge):
(WI.Cookie.prototype.get path):
(WI.Cookie.prototype.get domain):
(WI.Cookie.prototype.get secure):
(WI.Cookie.prototype.get httpOnly):
(WI.Cookie.prototype.get sameSite):
(WI.Cookie.prototype.get size):
(WI.Cookie.prototype.get url):
(WI.Cookie.prototype.expirationDate):
Cleanup Cookie object; add pubic getters for data, url property,
static fromPayload method, and calculate _size if missing.

• UserInterface/Views/CookieStorageContentView.js:

(WI.CookieStorageContentView.prototype.tableDidRemoveRows):
(WI.CookieStorageContentView.prototype._reloadCookies):
Create Cookie objects from the payload instead of using raw payload data.

LayoutTests:

• inspector/unit-tests/cookie-expected.txt:
• inspector/unit-tests/cookie.html:

12:06 PM Changeset in webkit [239225] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[SOUP] Unreviewed build fix after r239219

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse): Remove
handling of PolicyAction::Suspend, which is no longer available.

11:36 AM Changeset in webkit [239224] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit

Unreviewed, apply post-landing review comments after r239221.

• UIProcess/WebPageDebuggable.cpp:

(WebKit::WebPageDebuggable::url const):
Switch to WTF::blankURL() instead of using "about:blank" directly.

11:29 AM Changeset in webkit [239223] by Chris Dumez

• 7 edits in trunk

[PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
​https://bugs.webkit.org/show_bug.cgi?id=192704

Reviewed by Geoffrey Garen.

Source/WebKit:

Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls. This
is because we were failing to pass the ShouldTreatAsContinuingLoad flag to the WebContent process when
doing a LoadData.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadDataWithNavigation):
(WebKit::WebPageProxy::continueNavigationInNewProcess):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):

• WebProcess/WebPage/WebPage.h:

Tools:

Extend existing API test to reproduce the problem.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:05 AM Changeset in webkit [239222] by Simon Fraser

• 4 edits
  4 adds in trunk

REGRESSION (r233268): contents of an animated element inside overflow:hidden disappear
​https://bugs.webkit.org/show_bug.cgi?id=188655
rdar://problem/43382687

Reviewed by Antoine Quint.

Source/WebCore:

The logic that computes animation extent, used by backing store attachment code, failed
to account for the behavior where a keyframe animation with a missing 0% keyframe uses
the transform from the unanimated style. This resulted in the computed extent being wrong,
which caused us to remove the layer's backing store in some scenarios.

Fix both animation code paths to use the renderer style if the first keyframe doesn't
contain a transform.

Tests: compositing/backing/backing-store-attachment-empty-keyframe.html

legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation const):

LayoutTests:

• compositing/backing/backing-store-attachment-empty-keyframe-expected.txt: Added.
• compositing/backing/backing-store-attachment-empty-keyframe.html: Added.
• legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe-expected.txt: Added.
• legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe.html: Added.

10:26 AM Changeset in webkit [239221] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
​https://bugs.webkit.org/show_bug.cgi?id=192691
<rdar://problem/46719798>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-14
Reviewed by Darin Adler.

• UIProcess/WebPageDebuggable.cpp:

(WebKit::WebPageDebuggable::url const):
Instead of an empty string, return "about:blank" in bail cases.
When inspecting the page that matches the contents.

10:24 AM Changeset in webkit [239220] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Set kVTVideoEncoderSpecification_Usage both when creating the compression session and once created
​https://bugs.webkit.org/show_bug.cgi?id=192700

Reviewed by Eric Carlson.

Previously we were setting the usage value once the compression session is created.
We now also set it at creation time.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

10:23 AM Changeset in webkit [239219] by Chris Dumez

• 21 edits
  1 add in trunk/Source

[PSON] Stop exposing PolicyAction::Suspend to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=192701

Reviewed by Brady Eidson.

Source/WebCore:

Drop PolicyAction::Suspend enum value and stop dealing with it in WebCore.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

• loader/FrameLoaderTypes.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):

Source/WebKit:

Introduce a new WebPolicyAction enum that is used at WebKit2 layer and augments
WebCore::PolicyAction with a "Suspend" value.

• NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(toNSURLSessionResponseDisposition):

• Shared/WebPolicyAction.h: Added.
• UIProcess/WebFramePolicyListenerProxy.cpp:

(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):

• UIProcess/WebFramePolicyListenerProxy.h:
• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::setUpPolicyListenerProxy):

• UIProcess/WebFrameProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::toPolicyAction):
(WebKit::WebFrame::didReceivePolicyDecision):

• WebProcess/WebPage/WebFrame.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

10:14 AM Changeset in webkit [239218] by david_quesada@apple.com

• 2 edits in trunk/Source/WebKit

Remove a global 'using namespace WebKit' in WebViewImpl.mm
​https://bugs.webkit.org/show_bug.cgi?id=192690

Reviewed by Tim Horton.

• UIProcess/Cocoa/WebViewImpl.mm:

(-[WKTextListTouchBarViewController initWithWebViewImpl:]):
(-[WKTextListTouchBarViewController _selectList:]):
(-[WKTextListTouchBarViewController setCurrentListType:]):
(-[WKTextTouchBarItemController initWithWebViewImpl:]):

9:58 AM Changeset in webkit [239217] by Alan Bujtas

• 3 edits in trunk/LayoutTests

Unreviewed test gardening.

LFC does not support logical to physical coordinate conversion yet.

• fast/block/block-only/float-avoider-with-margins-expected.txt:
• fast/block/block-only/float-avoider-with-margins.html:

9:53 AM Changeset in webkit [239216] by Kocsen Chung

• 2 edits in tags/Safari-607.1.16.3/Source/WebKit

Cherry-pick r239197. rdar://problem/46546071

[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
​https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-13
Reviewed by Simon Fraser.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close):
• UIProcess/WebPageProxy.h: Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable which broadcasts it as a remote inspector target. Terminate this as soon as the WebPageProxy closes and becomes invalid.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:53 AM Changeset in webkit [239215] by Kocsen Chung

• 2 edits in tags/Safari-607.1.16.3/Source/WebKit

Cherry-pick r239194. rdar://problem/46546071

Unreviewed build fix for tvOS.

• Platform/cocoa/WKCrashReporter.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:53 AM Changeset in webkit [239214] by Kocsen Chung

• 2 edits in tags/Safari-607.1.16.3/Source/WebKit

Cherry-pick r239115. rdar://problem/46546071

Unreviewed build with with recent macOS SDKs.

• Platform/cocoa/WKCrashReporter.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:53 AM Changeset in webkit [239213] by Kocsen Chung

• 2 edits in tags/Safari-607.1.16.3/Source/WebKit

Cherry-pick r239112. rdar://problem/46546071

Unreviewed attempt to fix build with older SDKs after r239110.

• Platform/cocoa/WKCrashReporter.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:53 AM Changeset in webkit [239212] by Kocsen Chung

• 2 edits in tags/Safari-607.1.16.3/Source/WebKit

Cherry-pick r239110. rdar://problem/46546071

Unreviewed, fix build with recent SDKs.

• Platform/cocoa/WKCrashReporter.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:44 AM Changeset in webkit [239211] by youenn@apple.com

• 3 edits
  2 adds in trunk

IDB should store RTCCertificate
​https://bugs.webkit.org/show_bug.cgi?id=192599

Reviewed by Brady Eidson.

Source/WebCore:

In case there is no script execution context, do not create a JS DOM wrapper for RTCCertificate.
Instead, create an empty object so that the deserialization can still succeed.
This should only impact IDB deserialization in the Network Process which does not need the actual JS DOM wrapper.

Test: webrtc/certificates-indexeddb.html

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

• webrtc/certificates-indexeddb-expected.txt: Added.
• webrtc/certificates-indexeddb.html: Added.

9:40 AM Changeset in webkit [239210] by Chris Dumez

• 10 edits in trunk

[PSON] WebsitePolicies are lost on process-swap
​https://bugs.webkit.org/show_bug.cgi?id=192694
<rdar://problem/46715748>

Reviewed by Brady Eidson.

Source/WebKit:

In case of process-swap on navigation, instead of sending the websitePolicies to the old
process, send them to the new process as we trigger the navigation. We tell the new process
that it is continuing a load and it will therefore not re-trigger a decidePolicyForNavigationAction.

• Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

• Shared/LoadParameters.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequestWithNavigation):
(WebKit::WebPageProxy::loadDataWithNavigation):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::createDocumentLoader):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

Extend existing API test to reproduce the issue.

• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

9:32 AM Changeset in webkit [239209] by Kocsen Chung

• 7 edits in tags/Safari-607.1.16.3/Source

Versioning.

9:29 AM Changeset in webkit [239208] by Kocsen Chung

• 1 copy in tags/Safari-607.1.16.3

New tag.

9:18 AM Changeset in webkit [239207] by Michael Catanzaro

• 5 edits
  5 deletes in trunk/Tools

[GTK] Error writing data to TLS socket in some sites when using the jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=192678

Reviewed by Carlos Garcia Campos.

Update our ancient versions of libsoup and glib-networking.

• gtk/install-dependencies:
• gtk/jhbuild.modules:
• gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
• gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
• gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
• gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
• wpe/install-dependencies:
• wpe/jhbuild.modules:
• wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.

8:52 AM Changeset in webkit [239206] by Alan Bujtas

• 19 edits in trunk/Source/WebCore

[LFC][BFC] Transition to logical margin types.
​https://bugs.webkit.org/show_bug.cgi?id=192699

Reviewed by Antti Koivisto.

This is in preparation for moving over to logical types.
(This patch also transitions to singlular margin naming (verticalMargins -> VerticalMargin))

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

• layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

• layout/MarginTypes.h:

(WebCore::Layout::VerticalMargin::usedValues const):

• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::hasPrecomputedMarginBefore):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const): Deleted.
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const): Deleted.
(WebCore::Layout::hasPrecomputedMarginTop): Deleted.

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginBottom): Deleted.

• layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::hasMarginBeforeQuirkValue):
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginBefore):
(WebCore::Layout::hasMarginTopQuirkValue): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginTop): Deleted.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginBeforeCollapsedWithSibling):
(WebCore::Layout::isMarginAfterCollapsedWithSibling):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBeforeCollapsedWithParent):
(WebCore::Layout::isMarginAfterCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBeforeFromFirstChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBefore):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBefore):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBefore):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginAfterCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBeforeCollapsedWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginAfterFromLastChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginAfter):
(WebCore::Layout::isMarginTopCollapsedWithSibling): Deleted.
(WebCore::Layout::isMarginBottomCollapsedWithSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParent): Deleted.
(WebCore::Layout::isMarginBottomCollapsedThrough): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginTopFromFirstChild): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginTopCollapsedWithParentMarginBottom): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBottom): Deleted.

• layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):
(WebCore::Display::Box::marginBox const):
(WebCore::Display::Box::nonCollapsedMarginBox const):

• layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::rectWithMargin const):
(WebCore::Display::Box::estimatedMarginBefore const):
(WebCore::Display::Box::setEstimatedMarginBefore):
(WebCore::Display::Box::top const):
(WebCore::Display::Box::topLeft const):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::marginBefore const):
(WebCore::Display::Box::marginStart const):
(WebCore::Display::Box::marginAfter const):
(WebCore::Display::Box::marginEnd const):
(WebCore::Display::Box::nonCollapsedMarginBefore const):
(WebCore::Display::Box::nonCollapsedMarginAfter const):
(WebCore::Display::Box::nonComputedMarginStart const):
(WebCore::Display::Box::nonComputedMarginEnd const):
(WebCore::Display::Box::estimatedMarginTop const): Deleted.
(WebCore::Display::Box::setEstimatedMarginTop): Deleted.
(WebCore::Display::Box::marginTop const): Deleted.
(WebCore::Display::Box::marginLeft const): Deleted.
(WebCore::Display::Box::marginBottom const): Deleted.
(WebCore::Display::Box::marginRight const): Deleted.
(WebCore::Display::Box::nonCollapsedMarginTop const): Deleted.
(WebCore::Display::Box::nonCollapsedMarginBottom const): Deleted.
(WebCore::Display::Box::nonComputedMarginLeft const): Deleted.
(WebCore::Display::Box::nonComputedMarginRight const): Deleted.

• layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):

• layout/floats/FloatAvoider.h:

(WebCore::Layout::FloatAvoider::marginBefore const):
(WebCore::Layout::FloatAvoider::marginAfter const):
(WebCore::Layout::FloatAvoider::marginStart const):
(WebCore::Layout::FloatAvoider::marginEnd const):
(WebCore::Layout::FloatAvoider::marginBoxWidth const):
(WebCore::Layout::FloatAvoider::marginTop const): Deleted.
(WebCore::Layout::FloatAvoider::marginBottom const): Deleted.
(WebCore::Layout::FloatAvoider::marginLeft const): Deleted.
(WebCore::Layout::FloatAvoider::marginRight const): Deleted.

• layout/floats/FloatBox.cpp:

(WebCore::Layout::FloatBox::rect const):
(WebCore::Layout::FloatBox::horizontalPositionCandidate):
(WebCore::Layout::FloatBox::verticalPositionCandidate):
(WebCore::Layout::FloatBox::initialVerticalPosition const):

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

7:22 AM Changeset in webkit [239205] by Alan Bujtas

• 14 edits
  1 add in trunk/Source/WebCore

[LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.
​https://bugs.webkit.org/show_bug.cgi?id=192692

Reviewed by Antti Koivisto.

This is in preparation for completing block margin collapsing.

• WebCore.xcodeproj/project.pbxproj:
• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

• layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::LayoutState):

• layout/LayoutUnits.h:

(WebCore::Layout::HeightAndMargin::usedMarginValues const): Deleted.

• layout/MarginTypes.h: Added.

(WebCore::Layout::VerticalMargin::nonCollapsedValues const):
(WebCore::Layout::VerticalMargin::collapsedValues const):
(WebCore::Layout::VerticalMargin::setCollapsedValues):
(WebCore::Layout::VerticalMargin::VerticalMargin):
(WebCore::Layout::VerticalMargin::usedValues const):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

• layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):

• layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):

• layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::setHorizontalMargin):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::setHorizontalNonComputedMargin):
(WebCore::Display::Box::verticalMargin const):
(WebCore::Display::Box::marginTop const):
(WebCore::Display::Box::marginLeft const):
(WebCore::Display::Box::marginBottom const):
(WebCore::Display::Box::marginRight const):
(WebCore::Display::Box::nonCollapsedMarginTop const):
(WebCore::Display::Box::nonCollapsedMarginBottom const):
(WebCore::Display::Box::setVerticalNonCollapsedMargin): Deleted.

• layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):

6:38 AM Changeset in webkit [239204] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit

[GTK][WPE] Fix forwarding webkit socket to flatpak sandbox
​https://bugs.webkit.org/show_bug.cgi?id=192622

Patch by Patrick Griffis <Patrick Griffis> on 2018-12-14
Reviewed by Michael Catanzaro.

This fixes running with the sandbox enabled in Flatpak.

• UIProcess/Launcher/glib/FlatpakLauncher.cpp:

(WebKit::flatpakSpawn):

• UIProcess/Launcher/glib/FlatpakLauncher.h:
• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

4:57 AM Changeset in webkit [239203] by Carlos Garcia Campos

• 14 edits in trunk

[WPE] Use new view state API from libwpe
​https://bugs.webkit.org/show_bug.cgi?id=191906

Reviewed by Žan Doberšek.

Source/WebKit:

Remove WKViewSetViewState from the C API.

• UIProcess/API/C/wpe/WKAPICastWPE.h:
• UIProcess/API/C/wpe/WKView.cpp:
• UIProcess/API/C/wpe/WKView.h:
• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::View): Add implementation for activity_state_changed vfunc of the view backend client.):
(WKWPE::View::setViewState): Remove the default flags.

• UIProcess/API/wpe/WPEView.h:

(WKWPE::View::setViewState const): Make it private.

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.

• TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.

• TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
• TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:

(WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
wpe_view_activity_state_focused state flags.
(WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.

• wpe/backends/HeadlessViewBackend.cpp:

(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.

• wpe/backends/WindowViewBackend.cpp:

(WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
received in configure callback.

• wpe/jhbuild.modules: Bump libwpe to 1.1.0

4:14 AM Changeset in webkit [239202] by zandobersek@gmail.com

• 2 edits in trunk/Source/WTF

[GLib] RunLoop::dispatchAfter() GSource requires microsecond precision
​https://bugs.webkit.org/show_bug.cgi?id=192696

Reviewed by Michael Catanzaro.

The GSource we set up in GLib's RunLoop::dispatchAfter() implementation
should support microsecond-precision delays. Such delays are common in
JSC's Watchdog implementation and missing support for them has been
causing test failures in the testapi program as well as some JSC
tests that depend on the termination determination functionality of the
JSC::Watchdog class.

RunLoop::dispatchAfter() is changed to spawn a raw GSource that uses the
existing GSourceFuncs implementation used elsewhere in GLib's RunLoop.
The GSource's ready time is set manually, now with the necessary
microsecond precision.

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::dispatchAfter):

12:09 AM Changeset in webkit [239201] by Fujii Hironori

• 13 edits in trunk/Source/WebCore

[Win][Clang] Fix compilation warnings under Source/WebCore/platform/win
​https://bugs.webkit.org/show_bug.cgi?id=192693

Reviewed by Ross Kirsling.

No new tests, no behavior changes.

• platform/win/ClipboardUtilitiesWin.cpp: Reordered ClipboardDataItem members to match with the initializer list.
• platform/win/CursorWin.cpp:

(WebCore::loadCursorByName): Changed the argument type of 'name' to const char*.

• platform/win/DefWndProcWindowClass.cpp:

(WebCore::defWndProcWindowClassName): Removed an unused variable 'atom'.

• platform/win/DragImageWin.cpp: Removed an unused variable 'MinDragLabelWidthBeforeClip'.
• platform/win/PasteboardWin.cpp:

(WebCore::createGlobalImageFileDescriptor): Removed an unused variable 'hr'.
(WebCore::createGlobalHDropContent): Use reinterpret_cast to suppress warning.

• platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent): Reordered the initializer list.

• platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint): Removed an unused variable 'itemCount'.

• platform/win/PopupMenuWin.h: Marked override methods with 'override'.
• platform/win/SSLKeyGeneratorWin.cpp:

(WebCore::getSupportedKeySizes): Removed WebCore namespace prefix in WebCore namespace.
(WebCore::signedPublicKeyAndChallengeString): Ditto.

• platform/win/SearchPopupMenuDB.cpp:

(WebCore::SearchPopupMenuDB::createPreparedStatement): Use ASSERT_UNUSED instead of ASSERT.

• platform/win/StructuredExceptionHandlerSuppressor.h: Enclosed m_savedExceptionRegistration with #if defined(_M_IX86).
• platform/win/SystemInfo.cpp:

(WebCore::osVersionForUAString): Added default case.

Dec 13, 2018:

11:54 PM Changeset in webkit [239200] by Fujii Hironori

• 4 edits in trunk

[WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
​https://bugs.webkit.org/show_bug.cgi?id=192688

Reviewed by Ross Kirsling.

Source/JavaScriptCore:

These functions are used only in AppleWin port.

• shell/DLLLauncherMain.cpp:

(copyEnvironmentVariable): Moved.
(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
(applePathFromRegistry): Ditto.
(appleApplicationSupportDirectory): Ditto.
(prependPath): Ditto.

Tools:

• win/DLLLauncher/DLLLauncherMain.cpp:

(copyEnvironmentVariable): Moved.
(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
(applePathFromRegistry): Ditto.
(appleApplicationSupportDirectory): Ditto.
(prependPath): Ditto.

11:17 PM Changeset in webkit [239199] by dinfuehr@igalia.com

• 3 edits in trunk/Source/JavaScriptCore

Improve GDB output for LLInt on Linux
​https://bugs.webkit.org/show_bug.cgi?id=192660

Reviewed by Yusuke Suzuki.

Annotate assembly code generated for LLInt with the bytecode operation. When debugging
LLInt assembly code GDB is then able to show which bytecode instruction is implemented by
the current assembly code. This also works for linux-perf.

• llint/LowLevelInterpreter.cpp:
• offlineasm/arm.rb:

9:21 PM Changeset in webkit [239198] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Add a missing exception check.
​https://bugs.webkit.org/show_bug.cgi?id=192626
<rdar://problem/46662163>

Reviewed by Keith Miller.

JSTests:

• stress/regress-192626.js: Added.

Source/JavaScriptCore:

• runtime/ScopedArguments.h:

8:39 PM Changeset in webkit [239197] by Chris Dumez

• 2 edits in trunk/Source/WebKit

[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
​https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-13
Reviewed by Simon Fraser.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

• UIProcess/WebPageProxy.h:

Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.

8:09 PM Changeset in webkit [239196] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
​https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-13
Reviewed by Simon Fraser.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

• UIProcess/WebPageProxy.h:

Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.

8:05 PM Changeset in webkit [239195] by sbarati@apple.com

• 8 edits in trunk/Source

The JSC shell should listen for memory pressure events and respond to them
​https://bugs.webkit.org/show_bug.cgi?id=192647

Reviewed by Keith Miller.

Source/JavaScriptCore:

We want the JSC shell to behave more like the WebContent process when
it comes to running performance tests. One way to make the shell
more like this is to have it respond to memory pressure events in
a similar way as the WebContent process. This makes it easier to run
benchmarks like JetStream2 on the CLI on iOS.

• jsc.cpp:

(jscmain):

• runtime/VM.cpp:

(JSC::VM::drainMicrotasks):

• runtime/VM.h:

(JSC::VM::setOnEachMicrotaskTick):

Source/WTF:

• wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::MemoryPressureHandler):
(WTF::MemoryPressureHandler::setDispatchQueue):
Make it so that we can customize which dispatch queue memory pressure
events get handled on.

• wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::setShouldLogMemoryMemoryPressureEvents):
Make it so that we can disable logging that happens on each memory
pressure event.

• wtf/cocoa/MemoryPressureHandlerCocoa.mm:

(WTF::MemoryPressureHandler::install):
(WTF::MemoryPressureHandler::uninstall):
(WTF::MemoryPressureHandler::holdOff):

7:48 PM Changeset in webkit [239194] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed build fix for tvOS.

• Platform/cocoa/WKCrashReporter.mm:

6:47 PM Changeset in webkit [239193] by Fujii Hironori

• 2 edits in trunk/Tools

Unreviewed. Changed my status to a reviewer.

Patch by Don Olmstead <​don.olmstead@sony.com> on 2018-12-13

• Scripts/webkitpy/common/config/contributors.json:

6:19 PM Changeset in webkit [239192] by youenn@apple.com

• 9 edits in trunk

RTCRtpTransceiver.stopped should be true when applying a remote description with the corresponding m section rejected
​https://bugs.webkit.org/show_bug.cgi?id=192685

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html:

Source/WebCore:

In case the remote description contains a rejected m section,
the corresponding transceiver should be marked as stopped.
Libwebrtc backend has that information so pipe it up to JS.

Covered by updated WPT test.

• Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RTCRtpTransceiver::stopped const):

• Modules/mediastream/RTCRtpTransceiver.h:

(WebCore::RTCRtpTransceiver::stopped const): Deleted.

• Modules/mediastream/RTCRtpTransceiverBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:

(WebCore::LibWebRTCRtpTransceiverBackend::stopped const):

• Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.h:

6:14 PM Changeset in webkit [239191] by mark.lam@apple.com

• 46 edits in trunk/Source

Ensure that StructureFlags initialization always starts with Base::StructureFlags.
​https://bugs.webkit.org/show_bug.cgi?id=192686

Reviewed by Keith Miller.

Source/JavaScriptCore:

This is purely a refactoring effort to make the code consistently start all
StructureFlags initialization with Base::StructureFlags. Previously, sometimes
Base::StructureFlags is appended at the end, and sometimes, it is expressed using
the name of the superclass. This patch makes the code all consistent and easier
to do a quick eye scan audit on to verify that no StructureFlags are forgetting
to inherit Base::StructureFlags.

Also added a static_assert in JSCallbackObject.h and JSBoundFunction.h. Both of
these implement a customHasInstance() method, and rely on ImplementsHasInstance
being included in the StructureFlags, and conversely, ImplementsDefaultHasInstance
has to be excluded.

JSBoundFunction.h is the only case where a bit (ImplementsDefaultHasInstance)
needs to be masked out of the inherited Base::StructureFlags.

• API/JSCallbackObject.h:
• runtime/ArrayConstructor.h:
• runtime/ArrayIteratorPrototype.h:
• runtime/Exception.h:
• runtime/FunctionRareData.h:
• runtime/InferredType.h:
• runtime/InferredTypeTable.h:
• runtime/InferredValue.h:
• runtime/JSBoundFunction.h:
• runtime/MapPrototype.h:
• runtime/SetPrototype.h:
• runtime/StringPrototype.h:
• runtime/SymbolConstructor.h:

Source/WebCore:

No new tests needed because there's no new functionality. Just refactoring.

• bindings/js/JSDOMWindowProperties.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePrototypeDeclaration):

• bindings/scripts/test/JS/JSTestActiveDOMObject.h:
• bindings/scripts/test/JS/JSTestEnabledBySetting.h:
• bindings/scripts/test/JS/JSTestEventTarget.h:
• bindings/scripts/test/JS/JSTestGlobalObject.h:
• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
• bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:
• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestPluginInterface.h:
• bindings/scripts/test/JS/JSTestTypedefs.h:

5:45 PM Changeset in webkit [239190] by rniwa@webkit.org

• 7 edits
  21 adds in trunk

Make HTMLConverter work across shadow boundaries
​https://bugs.webkit.org/show_bug.cgi?id=192640

Reviewed by Wenson Hsieh.

Source/WebCore:

Made HTMLConverter work with shadow boundaries by replacing the various tree traversal functions.

Tests: editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1.html

editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html
editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-3.html

• dom/Position.cpp:

(WebCore::commonShadowIncludingAncestor): Moved from markup.cpp to be shared between HTMLConverter
and serializePreservingVisualAppearanceInternal.

• dom/Position.h:
• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert):
(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverterCaches::colorPropertyValueForNode):
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(HTMLConverter::_processElement):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
(WebCore::attributedStringFromSelection):

• editing/markup.cpp:

(WebCore::commonShadowIncludingAncestor): Moved to Position.cpp.

LayoutTests:

Added tests for generating attributed string out across shadow boundaries based on the tests
of respective names in editing/pasteboard.

• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Added.
• editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html: Added.
• editing/mac/attributed-string/resources/dump-attributed-string.js:

(window.dumpAttributedString): Now takes start and end containers and offsets.
(serializeSubtreeWithShadow): Added. This function serializes the content of shadow roots along with
start and end markers.
(serializeSubtreeWithShadow.serializeCharacterData): Added.
(serializeSubtreeWithShadow.serializeNode): Added.
(serializeSubtreeWithShadow.serializeChildNodes): Added.
(serializeSubtreeWithShadow.serializeShadowRootAndChildNodes): Added.
(dumpAttributedString): Deleted.

• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Added.
• platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Added.

5:17 PM Changeset in webkit [239189] by youenn@apple.com

• 5 edits in trunk

Trying to play a media element synchronously after setting srcObject should succeed without user gesture
​https://bugs.webkit.org/show_bug.cgi?id=192679

Reviewed by Eric Carlson.

Source/WebCore:

Check the srcObject mediaProvider value which is set synchronously.
Covered by updated fast/mediastream/local-audio-playing-event.html.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::hasMediaStreamSrcObject const):

LayoutTests:

• fast/mediastream/local-audio-playing-event-expected.txt:
• fast/mediastream/local-audio-playing-event.html:

4:53 PM Changeset in webkit [239188] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add the JSC_traceBaselineJITExecution option for tracing baseline JIT execution.
​https://bugs.webkit.org/show_bug.cgi?id=192684

Reviewed by Saam Barati.

This dataLogs the bytecode execution order of baseline JIT code when the
JSC_traceBaselineJITExecution option is true.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• runtime/Options.h:

4:19 PM Changeset in webkit [239187] by ddkilzer@apple.com

• 9 edits in trunk/Source/JavaScriptCore

clang-tidy: Fix unnecessary object copies in JavaScriptCore
<​https://webkit.org/b/192680>
<rdar://problem/46708767>

Reviewed by Mark Lam.

• assembler/testmasm.cpp:

(JSC::invoke):

• Make MacroAssemblerCodeRef<JSEntryPtrTag> argument a const reference.

• b3/testb3.cpp:

(JSC::B3::checkDisassembly):

• Make CString argument a const reference.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStringEquality):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):

• Make JITCompiler::JumpList arguments a const reference.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::checkStructure):

• Make RegisteredStructureSet argument a const reference.

• jsc.cpp:

(GlobalObject::moduleLoaderImportModule): Make local auto
variables const references.
(Workers::report): Make String argument a const reference.
(addOption): Make Identifier argument a const reference.
(runJSC): Make CString loop variable a const reference.

4:18 PM Changeset in webkit [239186] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

4:13 PM Changeset in webkit [239185] by mark.lam@apple.com

• 2 edits in trunk/Source/bmalloc

Verify that tryLargeZeroedMemalignVirtual()'s aligned size and alignment values are valid.
​https://bugs.webkit.org/show_bug.cgi?id=192682
<rdar://problem/37751522>

Reviewed by Saam Barati.

• bmalloc/bmalloc.cpp:

(bmalloc::api::tryLargeZeroedMemalignVirtual):

3:25 PM Changeset in webkit [239184] by Wenson Hsieh

• 9 edits in trunk

[iOS] Support dropping contact card data (public.vcard) in editable content
​https://bugs.webkit.org/show_bug.cgi?id=192570
<rdar://problem/35626913>

Reviewed by Tim Horton.

Source/WebCore:

Adds support for accepting vCard (.vcf) data via drop on iOS. See below for more details.

Tests: DragAndDropTests.ExternalSourceContactIntoEditableAreas

DragAndDropTests.ExternalSourceMapItemAndContactToUploadArea
DragAndDropTests.ExternalSourceMapItemIntoEditableAreas
WKAttachmentTestsIOS.InsertDroppedContactAsAttachment
WKAttachmentTestsIOS.InsertDroppedMapItemAsAttachment

• editing/WebContentReader.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attachmentForFilePath):

Pull out logic to create an attachment from a file path out into a static helper. Use this in readFilePaths
as well as readVirtualContactFile.

(WebCore::WebContentReader::readFilePaths):
(WebCore::WebContentReader::readVirtualContactFile):

Add a pasteboard reading method that reads a vCard file (with an optional URL) as web content. The resulting
fragment consists of either an anchor and an attachment element, or just an attachment element if the URL is
empty. In the case of an MKMapItem, the URL is populated, so we generate both elements; when dragging a
contact, there is no associated URL, so we only have an attachment.

• platform/Pasteboard.h:
• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::readPasteboardWebContentDataForType):

Augment this to take the current PasteboardItemInfo as well; use this item information to get a file path for
"public.vcard" data, which is then passed on to the web content reader. Additionally, by returning
ReaderResult::DidNotReadType here, we prevent the web content reader from extracting the plain text contents
of the vCard and dumping it as plain text in the editable element (this would otherwise happen, since
"public.vcard" conforms to "public.text").

(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):

• platform/ios/WebItemProviderPasteboard.mm:

(-[NSItemProvider web_fileUploadContentTypes]):

Prevent the "com.apple.mapkit.map-item" UTI from being considered as file upload content. This special case is
tricky, since "com.apple.mapkit.map-item" conforms to "public.content", yet its corresponding data is only
suitable for deserialization into an MKMapItem.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

Add API tests to verify that registering MKMapItems and CNContacts to item providers and dropping them in
attachment-enabled rich text editable areas inserts attachment elements (and in the case of MKMapItem,
additionally inserts a link).

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::createMapItemForTesting):
(TestWebKitAPI::createContactItemForTesting):

Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
dropped CNContact). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
files.

3:20 PM Changeset in webkit [239183] by Devin Rousso

• 22 edits in trunk/Source

Web Inspector: remove DOM.BackendNodeId and associated commands/events
​https://bugs.webkit.org/show_bug.cgi?id=192478

Reviewed by Matt Baker.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Source/WebCore:

Removing unused code, so no change in functionality.

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode): Deleted.
(WebCore::InspectorDOMAgent::releaseBackendNodeIds): Deleted.
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend): Deleted.

Source/WebInspectorUI:

• Versions/Inspector-iOS-8.0.json:
• Versions/Inspector-iOS-9.0.json:
• Versions/Inspector-iOS-9.3.json:
• Versions/Inspector-iOS-10.0.json:
• Versions/Inspector-iOS-10.3.json:
• Versions/Inspector-iOS-11.0.json:
• Versions/Inspector-iOS-11.3.json:
• Versions/Inspector-iOS-12.0.json:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:

3:17 PM Changeset in webkit [239182] by Chris Dumez

• 22 edits in trunk/Source

[PSON] We should not need to navigate to 'about:blank' to suspend pages
​https://bugs.webkit.org/show_bug.cgi?id=192668
<rdar://problem/46701466>

Reviewed by Alex Christensen.

Source/WebCore:

• history/PageCache.cpp:

(WebCore::PageCache::addIfCacheable):

• history/PageCache.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentLoader.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::setDocumentLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):

• loader/FrameLoaderTypes.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/PolicyChecker.h:

Source/WebKit:

To support PageCache when process-swap on cross-site navigation is enabled,
we've been navigating the previous process to 'about:blank' when swapping.
This would trigger PageCaching of the page in the old process. While
convenient, this design has led to a lot of bugs because we did not really
want a navigation to happen in the old process.

To address the issue, when a WebPage is asked to suspend (for process-swap),
we now attempt to add it to PageCache and save it on the current HistoryItem,
*without* triggering any navigation. Any pending navigation gets cancelled
and we just suspend in place.

Later on, when we want to go back to this HistoryItem, we simply leverage the
existing WebPage::goToBackForwardItem() code path. The only subtlety is that
we're actually asking the WebPage to load a HistoryItem that is the current
one in the History. I had to tweak a some logic / assertions to support this
as this is not something we usually do. However, it actually works with very
little changes and successfully restores the PageCache entry on the current
HistoryItem.

There is no expected overall behavior change and ProcessSwap API tests (which
cover PageCache) still pass. This is merely a simpler design because it avoids
navigating to about:blank.

• UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::didSuspend):
(WebKit::SuspendedPageProxy::didReceiveMessage):

• UIProcess/SuspendedPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSuspendAfterProcessSwap):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

• WebProcess/WebPage/WebDocumentLoader.cpp:

(WebKit::WebDocumentLoader::setNavigationID):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::suspendForProcessSwap):

• WebProcess/WebPage/WebPage.h:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::origin):

3:06 PM Changeset in webkit [239181] by pvollan@apple.com

• 11 edits in trunk

[macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences
​https://bugs.webkit.org/show_bug.cgi?id=192638

Reviewed by Eric Carlson.

Source/WebCore:

It is currently not possible to override caption styles generated from System Preferences with inline
WebVTT styles without adding !important. The reason for this is that the generated styles from
System preferences are author styles which have higher priority than the inline WebVTT styles, which
are user agent styles in the video user agent shadow tree. This can be fixed by moving the generated
styles to the video user agent shadow tree. Inline WebVTT styles will then have higher priority since
they are added after the generated styles. This patch also fixes a problem where inline styles could be
added twice to the video user agent shadow root.

Test: media/track/track-cue-css.html

• dom/ExtensionStyleSheets.cpp:

(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):

• html/track/VTTCue.cpp:

(WebCore::VTTCue::getDisplayTree):

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride):

• page/Page.cpp:

(WebCore::Page::setCaptionUserPreferencesStyleSheet):

LayoutTests:

• media/track/captions-webvtt/css-styling.vtt:
• media/track/captions-webvtt/no-css-styling.vtt:
• media/track/track-css-user-override-expected.txt:
• media/track/track-css-user-override.html:
• media/track/track-cue-css-expected.html:

2:32 PM Changeset in webkit [239180] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Fix leak of AVPlayer boundaryTimeObserver object.
​https://bugs.webkit.org/show_bug.cgi?id=192674

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):

2:31 PM Changeset in webkit [239179] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: experimental settings reload button disappears after changing more than one setting
​https://bugs.webkit.org/show_bug.cgi?id=192645
<rdar://problem/46626204>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView.listenForChange):
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

2:29 PM Changeset in webkit [239178] by Matt Baker

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r238602): Elements: deleting multiple DOM nodes doesn't select the nearest node after deletion
​https://bugs.webkit.org/show_bug.cgi?id=192116
<rdar://problem/46344339>

Reviewed by Devin Rousso.

• UserInterface/Controllers/SelectionController.js:

(WI.SelectionController.prototype.removeSelectedItems):
Finding a new index to select should go through the delegate instead of
naively advancing the index.

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._populateNodeContextMenu):
(WI.DOMTreeElement.prototype.ondelete): Deleted.
The menu item for removing the DOM node is now managed by the parent
DOMTreeOutline, since its UI and behavior now depend on whether there
are multiple elements selected.

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.populateContextMenu):
(WI.DOMTreeOutline.prototype.ondelete.level):
(WI.DOMTreeOutline.prototype.ondelete):
Implement ondelete to remove selected DOM nodes using the delete and
backspace keys. Also used by the DOMTreeOutline's context menu handler.

12:49 PM Changeset in webkit [239177] by ddkilzer@apple.com

• 3 edits in trunk/Source/WTF

clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
<​https://webkit.org/b/192666>
<rdar://problem/46697952>

Reviewed by Alex Christensen.

• wtf/ParallelHelperPool.cpp:

(WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
reference and WTFMove().
(WTF::ParallelHelperClient::setTask): Ditto.
(WTF::ParallelHelperClient::runTaskInParallel): Ditto.
(WTF::ParallelHelperClient::runTask): Use const reference.

• wtf/ParallelHelperPool.h: Update declarations to match

implementations.

12:48 PM Changeset in webkit [239176] by Michael Catanzaro

• 15 edits
  1 add in releases/WebKitGTK/webkit-2.22

Merge r239062 - PropertyAttribute needs a CustomValue bit.
​https://bugs.webkit.org/show_bug.cgi?id=191993
<rdar://problem/46264467>

Reviewed by Saam Barati.

JSTests:

• stress/regress-191993.js: Added.

Source/JavaScriptCore:

This is because GetByIdStatus needs to distinguish CustomValue properties from
other types, and its only means of doing so is via the property's attributes.
Previously, there's nothing in the property's attributes that can indicate that
the property is a CustomValue.

We fix this by doing the following:

1. Added a PropertyAttribute::CustomValue bit.
2. Added a PropertyAttribute::CustomAccessorOrValue convenience bit mask that is CustomAccessor | CustomValue.

3. Since CustomGetterSetter properties are only set via JSObject::putDirectCustomAccessor(), we added a check in JSObject::putDirectCustomAccessor() to see if the attributes bits include PropertyAttribute::CustomAccessor. If not, then the property must be a CustomValue, and we'll add the PropertyAttribute::CustomValue bit to the attributes bits.

This ensures that the property attributes is sufficient to tell us if the
property contains a CustomGetterSetter.

4. Updated all checks for PropertyAttribute::CustomAccessor to check for PropertyAttribute::CustomAccessorOrValue instead if their intent is to check for the presence of a CustomGetterSetter as opposed to checking specifically for one that is used as a CustomAccessor.

This includes all the Structure transition code that needs to capture the
attributes change when a CustomValue has been added.

5. Filtered out the PropertyAttribute::CustomValue bit in PropertyDescriptor. The fact that we're using a CustomGetterSetter as a CustomValue should remain invisible to the descriptor. This is because the descriptor should describe a CustomValue no differently from a plain value.

6. Added some asserts to ensure that property attributes are as expected, and to document some invariants.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):

• bytecode/InByIdStatus.cpp:

(JSC::InByIdStatus::computeForStubInfoWithoutExitSiteFeedback):

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

• runtime/JSFunction.cpp:

(JSC::getCalculatedDisplayName):

• runtime/JSObject.cpp:

(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):

• runtime/JSObject.h:

(JSC::JSObject::putDirectIndex):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::putDirect):

• runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal):

• runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setCustomDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):

• runtime/PropertySlot.h:

(JSC::PropertySlot::setCustomGetterSetter):

Source/WebCore:

This patch revealed a bug in the CodeGenerator where a constructor property is
set with a ReadOnly attribute. This conflicts with the WebIDL link (see clause
12 in ​https://heycam.github.io/webidl/#interface-prototype-object) which states
that it should be [Writable]. The ReadOnly attribute is now removed.

On the WebCore side, this change is covered by existing tests.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):

12:46 PM Changeset in webkit [239175] by Matt Baker

• 7 edits in trunk

Web Inspector: Table selection becomes corrupted when deleting selected cookies
​https://bugs.webkit.org/show_bug.cgi?id=192388
<rdar://problem/46472364>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

• UserInterface/Controllers/SelectionController.js:

(WI.SelectionController):
(WI.SelectionController.prototype.didRemoveItems):
(WI.SelectionController.prototype._updateSelectedItems):
(WI.SelectionController.prototype.didRemoveItem): Deleted.
Replace didRemoveItem with a method taking an IndexSet. Calling the
single-index version while iterating over multiple rows in ascending
order is unsafe, a detail best left to the SelectionController.

• UserInterface/Views/Table.js:

(WI.Table.prototype.removeRow):
(WI.Table.prototype._removeRows):
Notify SelectionController of removed rows.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.insertChild):
(WI.TreeOutline.prototype.removeChildAtIndex):
Remove the child from the element's children after calling _forgetTreeElement,
which needs to calculate the child's index to pass to the SelectionController.

(WI.TreeOutline.prototype.removeChildren):
Remove child items during iteration so that children doesn't contain
detached TreeElements while calling _forgetTreeElement.

(WI.TreeOutline.prototype._rememberTreeElement):
(WI.TreeOutline.prototype._forgetTreeElement):

LayoutTests:

• inspector/table/table-remove-rows-expected.txt:
• inspector/table/table-remove-rows.html:

12:30 PM Changeset in webkit [239174] by Brent Fulgham

• 3 edits
  2 adds in trunk

Don't attempt to animate invalid CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=192630
<rdar://problem/46664433>

Reviewed by Antoine Quint.

Source/WebCore:

Inherited animation properties can cause child elements to think they need to animate CSS properties
that they do not support, leading to nullptr crashes.

Recognize that CSSPropertyInvalid is a potential requested animation property, and handle it
cleanly.

Tests: animations/invalid-property-animation.html

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):

• svg/SVGAnimateElementBase.cpp:

(WebCore::SVGAnimateElementBase::calculateAnimatedValue):

LayoutTests:

• animations/invalid-property-animation-expected.txt: Added.
• animations/invalid-property-animation.html: Added.

11:56 AM Changeset in webkit [239173] by timothy@apple.com

• 10 edits in trunk/Source/WebCore

REGRESSION (r230064): Focus rings on webpages are fainter than in native UI.
​https://bugs.webkit.org/show_bug.cgi?id=192639
rdar://problem/42669297

Reviewed by Tim Horton.

The focus ring color passed to CoreGraphics is expected to be opaque, since they
will apply opacity when drawing (because opacity is normally animated).
We were getting this by accident before when the old RenderThemeMac::systemColor()
used the old convertNSColorToColor(), which ignored alpha on NSColor.
Existing tests use fixed test focus ring color.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::colorFromPrimitiveValue const): Use RenderTheme singleton for focusRingColor().

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal): Ditto.

• platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::drawFocusRingAtTime): Use CGContextStateSaver.

• platform/mac/ThemeMac.mm:

(WebCore::drawCellFocusRingWithFrameAtTime): Force alpha to 1 on the focus ring color. Use CGContextStateSaver.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::paintFocusRing): Use RenderTheme singleton for focusRingColor().

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing): Ditto.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::focusRingColor const): Made const. Cache the result of platformFocusRingColor().

• rendering/RenderTheme.h: Made focusRingColor() a member function instead of static.
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformFocusRingColor const): Force alpha to 1 on the focus ring color.
(WebCore::RenderThemeMac::systemColor const): Use focusRingColor(), instead of caching color here.

11:10 AM Changeset in webkit [239172] by Kocsen Chung

• 2 edits in branches/safari-606-branch/Source/ThirdParty/libwebrtc

Apply patch. rdar://problem/46603452

Check red packet length

11:07 AM Changeset in webkit [239171] by Ross Kirsling

• 2 edits in trunk/Tools

Unreviewed -- update my status to "reviewer".

• Scripts/webkitpy/common/config/contributors.json:

10:08 AM Changeset in webkit [239170] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Remove with-report from 3 services that are currently needed on macOS
​https://bugs.webkit.org/show_bug.cgi?id=192593
<rdar://problem/46604752>

Reviewed by Brent Fulgham.

• WebProcess/com.apple.WebProcess.sb.in:

9:22 AM Changeset in webkit [239169] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[MediaStream] Calculate width or height when constraints contain only the other
​https://bugs.webkit.org/show_bug.cgi?id=192632
<rdar://problem/46665734>

Unreviewed, remove an unneeded assert.

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers):

9:04 AM Changeset in webkit [239168] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Update Credit Card AutoFill button icon
​https://bugs.webkit.org/show_bug.cgi?id=192637
rdar://problem/46545006

Patch by Zach Li <​zachli@apple.com> on 2018-12-13
Reviewed by Chris Dumez.

• css/html.css:

(input::-webkit-credit-card-auto-fill-button):

8:59 AM Changeset in webkit [239167] by youenn@apple.com

• 8 edits
  1 add in trunk

On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
​https://bugs.webkit.org/show_bug.cgi?id=192657

Reviewed by Eric Carlson.

Source/WebKit:

Instead of nullifying the manager, make it a UniqueRef and clear it on closing the page.
This ensures we revoke the sandbox extensions as early as possible and keep the manager lifetime simple.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::~UserMediaPermissionRequestManager):
(WebKit::UserMediaPermissionRequestManager::clear):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userMediaPermissionRequestManager):

Tools:

Add a test that loads a page registering ondevicechange,
load another page in the same process, closes the first page.
Ensure that the process does not crash in that case.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/UserMedia.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::didCrashCallback):

• TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.

8:09 AM Changeset in webkit [239166] by Chris Fleizach

• 7 edits in trunk/Source/WebKit

[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
​https://bugs.webkit.org/show_bug.cgi?id=192449
<rdar://problem/46595508>

Reviewed by Darin Adler.

Part 6: Files in plugin process and UI process.

• PluginProcess/PluginControllerProxy.cpp:
• PluginProcess/PluginProcess.cpp:
• PluginProcess/WebProcessConnection.cpp:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
• UIProcess/WebStorage/LocalStorageDatabase.cpp:
• UIProcess/mac/WebPageProxyMac.mm:

8:00 AM Changeset in webkit [239165] by Adrian Perez de Castro

• 1 copy in releases/WPE WebKit/webkit-2.22.3/webkit-2.22

WPE WebKit 2.22.3

7:59 AM Changeset in webkit [239164] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake for the 2.22.3 release.

.:

• Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

• wpe/NEWS: Add release notes for 2.22.3.

7:34 AM Changeset in webkit [239163] by eric.carlson@apple.com

• 14 edits
  2 adds in trunk

[MediaStream] Calculate width or height when constraints contain only the other
​https://bugs.webkit.org/show_bug.cgi?id=192632
<rdar://problem/46665734>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/constraint-intrinsic-size.html

• platform/graphics/RemoteVideoSample.cpp:

(WebCore::RemoteVideoSample::create): Log errors with RELEASE_LOG_ERROR.

• platform/graphics/cv/ImageTransferSessionVT.h:

(WebCore::ImageTransferSessionVT::pixelFormat const): New.

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setSizeAndFrameRate): Replace current size with new size.
(WebCore::RealtimeMediaSource::setSize): Don't notify about width and height.
(WebCore::RealtimeMediaSource::size const): Use intrinsic size when necessary.
(WebCore::RealtimeMediaSource::setIntrinsicSize): New.
(WebCore::RealtimeMediaSource::remoteVideoSampleAvailable): Deleted.

• platform/mediastream/RealtimeMediaSource.h:

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers): No more remoteVideoSampleAvailable.

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::settings): Report size correctly.
(WebCore::DisplayCaptureSourceCocoa::frameSize const): Use intrinsicSize().
(WebCore::DisplayCaptureSourceCocoa::emitFrame): No more remoteVideoSampleAvailable.
(WebCore::DisplayCaptureSourceCocoa::setIntrinsicSize): Deleted.

• platform/mediastream/mac/DisplayCaptureSourceCocoa.h:

(WebCore::DisplayCaptureSourceCocoa::intrinsicSize const): Deleted.

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource): Report intrinsic size.
(WebCore::MockRealtimeVideoSource::setSizeAndFrameRate): Minor cleanup.
(WebCore::MockRealtimeVideoSource::setSizeAndFrameRateWithPreset): Report intrinsic size.
(WebCore::MockRealtimeVideoSource::drawText): Don't render preset info for display source.

• platform/mock/MockRealtimeVideoSource.h:

Source/WebKit:

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::remoteVideoSampleAvailable): Deleted,
replaced with videoSampleAvailable.

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::Source::remoteVideoSampleAvailable): Use original frame
size if necessary when calculating new frame size.

LayoutTests:

• fast/mediastream/constraint-intrinsic-size-expected.txt: Added.
• fast/mediastream/constraint-intrinsic-size.html: Added.

7:08 AM Changeset in webkit [239162] by Adrian Perez de Castro

• 1 copy in releases/WebKitGTK/webkit-2.22.5

WebKitGTK+ 2.22.5

7:06 AM Changeset in webkit [239161] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.22.5.

6:44 AM Changeset in webkit [239160] by ddkilzer@apple.com

• 3 edits in trunk/Source/WebCore

clang-tidy: loop variable is copied but only used as const reference in Document.cpp, Element.cpp
<​https://webkit.org/b/192661>
<rdar://problem/46694035>

Reviewed by Daniel Bates.

• dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::notifyIntersectionObserversTimerFired):

• dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument):
(WebCore::Element::disconnectFromIntersectionObservers):

• Change loop variables from auto to const auto& to prevent unnecessary copies of WeakPtr<IntersectionObserver> or struct IntersectionObserverRegistration objects.

4:35 AM Changeset in webkit [239159] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/Tools

[GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
​https://bugs.webkit.org/show_bug.cgi?id=192643

Patch by Carlos Eduardo Ramalho <​cadubentzen@gmail.com> on 2018-12-13
Reviewed by Philippe Normand.

This problem happens with Arch Linux users which have libfdk-2.0.0
installed (which is anybody with gst-plugins-bad 1.14.4 installed).

The problem has already been solved upstream at
​https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.

Adding patches while this problem is not in a release yet.

• gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
• gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
• gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.

4:26 AM Changeset in webkit [239158] by Caio Lima

• 22 edits
  5 adds in trunk

[BigInt] Add ValueDiv into DFG
​https://bugs.webkit.org/show_bug.cgi?id=186178

Reviewed by Yusuke Suzuki.

JSTests:

• stress/big-int-div-jit-osr.js: Added.
• stress/big-int-div-jit-untyped.js: Added.
• stress/value-div-fixup-int32-big-int.js: Added.

PerformanceTests:

• BigIntBench/big-int-simple-div.js: Added.
• BigIntBench/value-div-type-propagation.js: Added.

Source/JavaScriptCore:

This patch is introducing a new node type called ValueDiv. This node
is responsible to handle Untyped and Bigint specialization of division
operator, while the ArithDiv variant handles Number/Boolean cases.

BigInt specialization generates following speedup into simple
benchmark:

noSpec changes

big-int-simple-div 10.6013+-0.4682 ^{8.4518+-0.0943} definitely 1.2543x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupArithDiv):
(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::arithNodeFlags):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueDiv):
(JSC::DFG::SpeculativeJIT::compileArithDiv):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileArithDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileArithBitNot):

1:43 AM Changeset in webkit [239157] by Carlos Garcia Campos

• 11 edits
  3 deletes in trunk

[FreeType] Remove HarfBuzzFace
​https://bugs.webkit.org/show_bug.cgi?id=192589

Reviewed by Michael Catanzaro.

Source/WebCore:

This was used to share the common implementation with the chromium port, but now that only freetype based ports
use it, it can be removed and use hb_ft_face_create_cached() instead. We don't need the glyph cache either,
since we are already caching glyphs in Font.

• platform/FreeType.cmake: Remove HarfBuzzFaceCairo.cpp and HarfBuzzFace.cpp.
• platform/graphics/FontPlatformData.h: Remove HarfBuzzFace member.
• platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: Add missing include.
• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::operator=): Remove m_harfBuzzFace handling.
(WebCore::FontPlatformData::createOpenTypeMathHarfBuzzFont const): New funtction to create a hb_font_t for
OpenType math.

• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::floatToHarfBuzzPosition): Moved from HarfBuzzFaceCairo.cpp.
(WebCore::doubleToHarfBuzzPosition): Ditto.
(WebCore::harfBuzzFontFunctions): Also moved from HarfBuzzFaceCairo.cpp, but implement get_nominal/variation
functions when using HarfBuzz >= 1.2.3 and use Font::glyphForCharacter() to make it simpler.
(WebCore::fontFeatures): Moved from HarfBuzzFaceCairo.cpp.
(WebCore::findScriptForVerticalGlyphSubstitution): Moved from HarfBuzzFace.cpp.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Create the HarfBuzz face and font here.

• platform/graphics/harfbuzz/HarfBuzzFace.cpp: Removed.
• platform/graphics/harfbuzz/HarfBuzzFace.h: Removed.
• platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: Removed.
• platform/graphics/harfbuzz/HbUniquePtr.h:

(WebCore::HbPtrDeleter<hb_face_t>::operator() const): Add deleter for hb_face_t.

• platform/graphics/opentype/OpenTypeMathData.cpp:

(WebCore::OpenTypeMathData::OpenTypeMathData): Use FontPlatformData::createOpenTypeMathHarfBuzzFont().

LayoutTests:

Rebaseline test that now matches the firefox output.

• platform/gtk/mathml/opentype/opentype-stretchy-expected.png:
• platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:

1:17 AM Changeset in webkit [239156] by Carlos Garcia Campos

• 19 edits
  2 adds in trunk

[FreeType] Add initial implementation of variation fonts
​https://bugs.webkit.org/show_bug.cgi?id=192151

Reviewed by Michael Catanzaro.

.:

Enable variation fonts in GTK+ port when required dependencies are available.

• Source/cmake/OptionsGTK.cmake:

Source/WebCore:

• css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font): Remove platform ifdefs.

• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData): Ditto.

• platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::isFixedWidth const):

• platform/graphics/cairo/FontCustomPlatformData.h: Use RefPtr for cairo_font_face_t.
• platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::getFontPropertiesFromPattern): Helper function to get several font properties from the fontconfig
pattern.
(WebCore::FontCache::systemFallbackForCharacters): Use getFontPropertiesFromPattern().
(WebCore::FontCache::createFontPlatformData): Pass FC_VARIABLE to the pattern and call buildVariationSettings()
before creating the FontPlatformData to set FC_FONT_VARIATIONS on the pattern.
(WebCore::defaultVariationValues): Parse font variations table.
(WebCore::buildVariationSettings): Build a font variations string from the settings that can be passed to cairo.

• platform/graphics/freetype/FontCacheFreeType.h: Added.
• platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Use RefPtr and make freeTypeFaceKey global.
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove explicit destroy.
(WebCore::defaultFontconfigOptions): Moved here from FontCacheFreeType.
(WebCore::FontCustomPlatformData::fontPlatformData): Call buildVariationSettings() before creating the
FontPlatformData to set FC_FONT_VARIATIONS on the pattern.
(WebCore::FontCustomPlatformData::supportsFormat): Add variation formats.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::setCairoFontOptionsFromFontConfigPattern): Call cairo_font_options_set_variations() with the
FC_FONT_VARIATIONS value from the pattern.
(WebCore::FontPlatformData::FontPlatformData): Use a single constructor that always receives a valid fontconfig
pattern.
(WebCore::FontPlatformData::fcPattern const): Return the fontconfig pattern.
(WebCore::FontPlatformData::platformIsEqual const): Update the condition now that m_pattern can't be nullptr.
(WebCore::FontPlatformData::buildScaledFont): Use m_pattern unconditionally.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformCreateScaledFont const): Update it to use the new FontPlatformData constructor.

• platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::HarfBuzzFace::createFont): Pass variations to HarfBuzz.

• platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

• platform/graphics/win/FontCustomPlatformData.h:

Tools:

Add cairo patch to avoid crashes.

• gtk/jhbuild.modules:
• gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.

LayoutTests:

Unskip variation fonts tests that are now passing in GTK+ port.

• platform/gtk/TestExpectations:

12:37 AM Changeset in webkit [239155] by yusukesuzuki@slowstart.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix after r239153, part 2
​https://bugs.webkit.org/show_bug.cgi?id=190047

• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedOwnKeys const):

12:06 AM Changeset in webkit [239154] by yusukesuzuki@slowstart.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix after r239153
​https://bugs.webkit.org/show_bug.cgi?id=190047

• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedOwnKeys const):