Timeline
Dec 24, 2018:
- 8:40 PM Changeset in webkit [239551] by
-
- 2 edits in trunk/Source/WebCore
Remove "using namespace std;"
https://bugs.webkit.org/show_bug.cgi?id=192973
<rdar://problem/46937309>
Unreviewed Windows port Debug builds fix.
No new tests since no behavior changes.
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Add "std::" prefix to numeric_limits in ASSERT macro.
- 6:14 PM Changeset in webkit [239550] by
-
- 12 edits in trunk/Source/WebKit
[WebKit][Win] Remove using namespace in the global scope
https://bugs.webkit.org/show_bug.cgi?id=192968
Reviewed by Alex Christensen.
Moved using namespace statements in the global scope to inside
namespaces.
<https://webkit.org/code-style-guidelines/#using-position>
- NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
- NetworkProcess/curl/NetworkProcessCurl.cpp:
- NetworkProcess/curl/NetworkSessionCurl.cpp:
- NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
- Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
- Shared/WebWheelEvent.cpp:
- Shared/curl/WebCoreArgumentCodersCurl.cpp:
- Shared/win/NativeWebKeyboardEventWin.cpp:
- Shared/win/WebEventFactory.cpp:
- UIProcess/Automation/WebAutomationSession.cpp:
- 6:00 PM Changeset in webkit [239549] by
-
- 27 edits in trunk/Source
Remove "using namespace std;"
https://bugs.webkit.org/show_bug.cgi?id=192973
Reviewed by Alex Christensen.
Source/WebCore:
Removed "using namespace std" statement, and use std:: prefix.
No new tests since no behavior changes.
- accessibility/win/AXObjectCacheWin.cpp:
- platform/graphics/GraphicsContext3DPrivate.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
- platform/graphics/win/FontWin.cpp:
(WebCore::FontCascade::floatWidthForComplexText const):
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextDirect2D.cpp:
- platform/graphics/win/GraphicsContextWin.cpp:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):
- platform/image-decoders/ScalableImageDecoder.cpp:
- platform/text/LocaleICU.cpp:
- platform/text/win/LocaleWin.cpp:
- platform/win/ScrollbarThemeWin.cpp:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutBlock):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustMenuListButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
Source/WebKit:
- Platform/IPC/win/ConnectionWin.cpp:
Source/WebKitLegacy/win:
- FullscreenVideoController.cpp:
- WebFrame.cpp:
(WebFrame::drawFooter):
- WebHistory.cpp:
- WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
- WebKitQuartzCoreAdditions/CAView.cpp:
- WebView.cpp:
(PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
(PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
(WebView::setCacheModel):
(WebView::maxCacheModelInAnyInstance):
- 11:20 AM Changeset in webkit [239548] by
-
- 26 edits in trunk/Source
Change ScrollingNodeType to an enum class
https://bugs.webkit.org/show_bug.cgi?id=193009
Reviewed by Zalan Bujtas.
Change the ScrollingNodeType enum to an enum class.
No behavior change.
Source/WebCore:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::operator<<):
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isFixedNode const):
(WebCore::ScrollingStateNode::isStickyNode const):
(WebCore::ScrollingStateNode::isFrameScrollingNode const):
(WebCore::ScrollingStateNode::isOverflowScrollingNode const):
- page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::createNode):
(WebCore::ScrollingStateTree::attachNode):
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::isFixedNode const):
(WebCore::ScrollingTreeNode::isStickyNode const):
(WebCore::ScrollingTreeNode::isFrameScrollingNode const):
(WebCore::ScrollingTreeNode::isOverflowScrollingNode const):
- page/scrolling/ScrollingTreeOverflowScrollingNode.cpp:
(WebCore::ScrollingTreeOverflowScrollingNode::ScrollingTreeOverflowScrollingNode):
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeMac.cpp:
(ScrollingTreeMac::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
- platform/graphics/GraphicsLayerClient.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
Source/WebKit:
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::dump):
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
- UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createScrollingTreeNode):
- UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll):
Dec 23, 2018:
- 9:07 PM Changeset in webkit [239547] by
-
- 5 edits in trunk/Source/WebKit
[iOS] Remove some unnecessary editing SPI after <rdar://problem/46047546>
https://bugs.webkit.org/show_bug.cgi?id=193019
Reviewed by Dan Bernstein.
Remove these SPI method declarations, as well as method forwarding in WKContentView. Mail was the only adoptee
of these methods; after <rdar://problem/46047546>, they have moved to the underscore-prefixed versions, so we
we have no need for these erroneously-named SPI methods anymore. There is no change in behavior; verified this
through existing API tests (WKWebViewEditActions), as well as building iOS Mail against WebKit with these
changes to WKWebViewPrivate.h.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):
(-[WKWebView setFont:sender:]): Deleted.
(-[WKWebView setTextColor:sender:]): Deleted.
(-[WKWebView setFontSize:sender:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView setFontForWebView:sender:]): Deleted.
(-[WKContentView setFontSizeForWebView:sender:]): Deleted.
(-[WKContentView setTextColorForWebView:sender:]): Deleted.
- 3:51 PM Changeset in webkit [239546] by
-
- 2 edits in trunk/Source/WebKit
Fix fast/ruby/ruby-base-merge-block-children-crash-2.html after r239543
https://bugs.webkit.org/show_bug.cgi?id=193015
<rdar://problem/46583527>
Reviewed by Tim Horton.
Fix the crash by gracefully handling integer overflow when computing the area of a very large editable element.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _updateChangedSelection:]):
- 2:46 AM Changeset in webkit [239545] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline fast/text/zero-font-size.html after r239539.
- platform/gtk/fast/text/zero-font-size-expected.txt:
- 2:09 AM Changeset in webkit [239544] by
-
- 6 edits2 adds in trunk
[BigInt] Support BigInt in JSON.stringify
https://bugs.webkit.org/show_bug.cgi?id=192624
Reviewed by Saam Barati.
JSTests:
- stress/big-int-json-stringify-to-json.js: Added.
(shouldBe):
(shouldThrow):
(BigInt.prototype.toJSON):
(shouldBe.JSON.stringify):
- stress/big-int-json-stringify.js: Added.
(shouldBe):
(shouldThrow):
Source/JavaScriptCore:
This patch adds BigInt support to JSON.stringify, specified in [1].
[1]: https://tc39.github.io/proposal-bigint/#sec-serializejsonproperty
- runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::toJSONImpl):
(JSC::Stringifier::appendStringifiedValue):
LayoutTests:
The test is wrong according to the spec[1]. valueOf of Boolean object won't be called.
[1]: https://tc39.github.io/ecma262/#sec-serializejsonproperty
- js/resources/JSON-stringify.js:
- js/resources/json2-es5-compat.js:
(str):
