Timeline

Dec 25, 2018:

11:52 PM Changeset in webkit [239552] by Fujii Hironori

• 4 edits in trunk/Source/JavaScriptCore

[JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
​https://bugs.webkit.org/show_bug.cgi?id=193035

Reviewed by Yusuke Suzuki.

Clang-cl reports a compilation warning for implicit conversion
from -64 size_t to int. Replaced '-maxFrameExtentForSlowPathCall'
with '-static_cast<int32_t>(maxFrameExtentForSlowPathCall)'.

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

• jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):

• jit/ThunkGenerators.cpp:

(JSC::slowPathFor):

Dec 24, 2018:

8:40 PM Changeset in webkit [239551] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

Remove "using namespace std;"
​https://bugs.webkit.org/show_bug.cgi?id=192973
<rdar://problem/46937309>

Unreviewed Windows port Debug builds fix.

No new tests since no behavior changes.

• accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Add "std::" prefix to numeric_limits in ASSERT macro.

6:14 PM Changeset in webkit [239550] by Fujii Hironori

• 12 edits in trunk/Source/WebKit

[WebKit][Win] Remove using namespace in the global scope
​https://bugs.webkit.org/show_bug.cgi?id=192968

Reviewed by Alex Christensen.

Moved using namespace statements in the global scope to inside
namespaces.
<​https://webkit.org/code-style-guidelines/#using-position>

• NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
• NetworkProcess/curl/NetworkDataTaskCurl.cpp:
• NetworkProcess/curl/NetworkProcessCurl.cpp:
• NetworkProcess/curl/NetworkSessionCurl.cpp:
• NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
• Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
• Shared/WebWheelEvent.cpp:
• Shared/curl/WebCoreArgumentCodersCurl.cpp:
• Shared/win/NativeWebKeyboardEventWin.cpp:
• Shared/win/WebEventFactory.cpp:
• UIProcess/Automation/WebAutomationSession.cpp:

6:00 PM Changeset in webkit [239549] by Fujii Hironori

• 27 edits in trunk/Source

Remove "using namespace std;"
​https://bugs.webkit.org/show_bug.cgi?id=192973

Reviewed by Alex Christensen.

Source/WebCore:

Removed "using namespace std" statement, and use std:: prefix.

No new tests since no behavior changes.

• accessibility/win/AXObjectCacheWin.cpp:
• platform/graphics/GraphicsContext3DPrivate.cpp:
• platform/graphics/cairo/ImageBufferCairo.cpp:
• platform/graphics/win/FontPlatformDataCairoWin.cpp:
• platform/graphics/win/FontWin.cpp:

(WebCore::FontCascade::floatWidthForComplexText const):

• platform/graphics/win/GraphicsContextCGWin.cpp:
• platform/graphics/win/GraphicsContextCairoWin.cpp:
• platform/graphics/win/GraphicsContextDirect2D.cpp:
• platform/graphics/win/GraphicsContextWin.cpp:
• platform/graphics/win/SimpleFontDataCGWin.cpp:
• platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

• platform/image-decoders/ScalableImageDecoder.cpp:
• platform/text/LocaleICU.cpp:
• platform/text/win/LocaleWin.cpp:
• platform/win/ScrollbarThemeWin.cpp:
• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutBlock):

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustMenuListButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

Source/WebKit:

• Platform/IPC/win/ConnectionWin.cpp:

Source/WebKitLegacy/win:

• FullscreenVideoController.cpp:
• WebFrame.cpp:

(WebFrame::drawFooter):

• WebHistory.cpp:
• WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
• WebKitQuartzCoreAdditions/CAView.cpp:
• WebView.cpp:

(PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
(PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
(WebView::setCacheModel):
(WebView::maxCacheModelInAnyInstance):

11:20 AM Changeset in webkit [239548] by Simon Fraser

• 26 edits in trunk/Source

Change ScrollingNodeType to an enum class
​https://bugs.webkit.org/show_bug.cgi?id=193009

Reviewed by Zalan Bujtas.

Change the ScrollingNodeType enum to an enum class.

No behavior change.

Source/WebCore:

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):

• page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::isFixedNode const):
(WebCore::ScrollingStateNode::isStickyNode const):
(WebCore::ScrollingStateNode::isFrameScrollingNode const):
(WebCore::ScrollingStateNode::isOverflowScrollingNode const):

• page/scrolling/ScrollingStateOverflowScrollingNode.cpp:

(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):

• page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):

• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::createNode):
(WebCore::ScrollingStateTree::attachNode):

• page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::isFixedNode const):
(WebCore::ScrollingTreeNode::isStickyNode const):
(WebCore::ScrollingTreeNode::isFrameScrollingNode const):
(WebCore::ScrollingTreeNode::isOverflowScrollingNode const):

• page/scrolling/ScrollingTreeOverflowScrollingNode.cpp:

(WebCore::ScrollingTreeOverflowScrollingNode::ScrollingTreeOverflowScrollingNode):

• page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::createScrollingTreeNode):

• page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):

• page/scrolling/mac/ScrollingTreeMac.cpp:

(ScrollingTreeMac::createScrollingTreeNode):

• page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):

• platform/graphics/GraphicsLayerClient.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

Source/WebKit:

• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::dump):

• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

• UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode):

• UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll):