⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 7, 2019:

8:27 PM Changeset in webkit [239720] by Chris Dumez
  • 7 edits in trunk/Source

Cannot scoll for 5 seconds after swiping back on quoteunquoteapps.com
​https://bugs.webkit.org/show_bug.cgi?id=193215
<rdar://problem/45108222>

Reviewed by Tim Horton.

When doing the history navigation, if the source and destination history
items are clones then we will not trigger a main frame load. We may
however trigger loads in subframes if needed. This was an issue for the
ViewGestureController because it was expecting a main frame load after
calling WebPageProxy::goToBackForwardItem() in order to determine when
taking down the view snapshot is appropriate.

To address the problem, the ViewGestureController now takes the snapshot
down as soon as the swipe gesture ends when the source and destination
items are clones.

  • Shared/WebBackForwardListItem.cpp:

(WebKit::childItemWithTarget):
(WebKit::WebBackForwardListItem::itemIsInSameDocument const):
(WebKit::hasSameFrames):
(WebKit::WebBackForwardListItem::itemIsClone):

  • Shared/WebBackForwardListItem.h:
  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::endSwipeGesture):

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::endSwipeGesture):

6:07 PM Changeset in webkit [239719] by ddkilzer@apple.com
  • 5 edits in trunk

Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
<​https://webkit.org/b/193222>
<rdar://problem/46862309>

Reviewed by Joseph Pecoraro.

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageRegisterScrollOperationCompletionCallback): Change
to return true if callback will be called, else false.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

(WKBundlePageRegisterScrollOperationCompletionCallback): Change
to return bool value to denote whether callback will be called
(true) or not called (false).

Tools:

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::executeCallback): Fix camel case of variable name.
(WTR::EventSendingController::callAfterScrollingCompletes): If
WKBundlePageRegisterScrollOperationCompletionCallback() returns
false, make sure to release the ScrollCompletionCallbackData
object. This fixes the leak.

5:37 PM Changeset in webkit [239718] by Fujii Hironori
  • 2 edits in trunk/Tools

[Win] EWS: wincairo-ews cannot apply a patch with *.png
​https://bugs.webkit.org/show_bug.cgi?id=193044

Reviewed by Daniel Bates.

WinCairo EWS bots are using Windows Perl. Binary files should be
opened as binary mode.

  • Scripts/svn-apply:

(handleGitBinaryChange): Use 'binmode' for binary file handles.

5:18 PM Changeset in webkit [239717] by Alan Coon
  • 7 edits in trunk/Source

Versioning.

4:55 PM Changeset in webkit [239716] by don.olmstead@sony.com
  • 4 edits in trunk

[CMake] Add ENABLE_CSS_TYPED_OM option
​https://bugs.webkit.org/show_bug.cgi?id=193216

Reviewed by Michael Catanzaro.

.:

  • Source/cmake/WebKitFeatures.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
4:39 PM Changeset in webkit [239715] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in SWServer::Connection::resolveRegistrationReadyRequests
​https://bugs.webkit.org/show_bug.cgi?id=193217

Reviewed by Chris Dumez.

As can be seen from the traces, SWServer might clear its connections HashMap in its destructor.
This might then trigger calling SWServer::resolveRegistrationReadyRequests.
This method is iterating on the connections HashMap which is being cleared.
To remove this problem, move the HashMap in a temporary variable and clear the temporary variable.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::~SWServer):

4:14 PM Changeset in webkit [239714] by Alan Coon
  • 1 copy in tags/Safari-606.4.5.2.1

Tag Safari-606.4.5.2.1.

4:09 PM Changeset in webkit [239713] by Alan Coon
  • 2 edits in branches/safari-606.4.5.2-branch/Source/WebCore

Apply patch. rdar://problem/46941524

4:05 PM Changeset in webkit [239712] by Alan Coon
  • 7 edits in branches/safari-606.4.5.2-branch/Source

Versioning.

4:04 PM Changeset in webkit [239711] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION (r239519): ASSERTION FAILED: !m_adoptionIsRequired in com.apple.WebCore: void WTF::refIfNotNull<WebCore::CDMSessionMediaSourceAVFObjC> + 53
​https://bugs.webkit.org/show_bug.cgi?id=193211
<rdar://problem/46937412>

Reviewed by Eric Carlson.

Make CDMSessionMediaSourceAVFObjC a CanMakeWeakPtr rather than RefCounted, as CDMSessions are stored in
std::unique_ptrs, and not in Ref or RefPtr.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCDMSession):

4:04 PM Changeset in webkit [239710] by achristensen@apple.com
  • 8 edits in trunk/Source/WebKit

Remove use of NetworkProcess::singleton from CacheStorage::Engine::from
​https://bugs.webkit.org/show_bug.cgi?id=193220

Reviewed by Andy Estes.

This required passing the NetworkProcess& in from all its callers.
While I was at it, I made them use CompletionHandlers where appropriate.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::findCacheEngine):
(WebKit::NetworkProcess::ensureCacheEngine):
(WebKit::NetworkProcess::removeCacheEngine):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::destroyEngine):
(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):
(WebKit::CacheStorage::Engine::representation):
(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):
(WebKit::CacheStorage::globalEngineMap): Deleted.

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):
(WebKit::CacheStorageEngineConnection::clearMemoryRepresentation):
(WebKit::CacheStorageEngineConnection::engineRepresentation):

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::remove):
(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::clear):
(WebKit::NetworkCache::Cache::retrieveData):

  • NetworkProcess/cache/NetworkCache.h:
4:03 PM Changeset in webkit [239709] by ddkilzer@apple.com
  • 42 edits in trunk

Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
<​https://webkit.org/b/193056>

Reviewed by Alex Christensen.

Source/WebCore:

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]):
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]):

  • platform/network/cf/AuthenticationChallenge.h:
  • Remove '*' from RetainPtr<> type.
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::cookiesForURL):

  • Once retainPtr() was changed to return RetainPtr<NSArray> instead of RetainPtr<NSArray *> here, that forced the type of cookiesPtr to change as well since Optional<RetainPtr<NSArray>> is not assignable to Optional<RetainPtr<NSArray *>> without further template specialization, which didn't seem useful since Optional<RetainPtr<>> variable types are rarely used.

Source/WebKit:

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createEmbeddedView):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone const):

  • Remove '*' from RetainPtr<> type.

Source/WebKitLegacy/mac:

  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invoke):

  • WebCoreSupport/WebGeolocationClient.mm:
  • WebView/WebDataSource.mm:

(-[WebDataSource _receivedData:]):

  • WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

  • Remove '*' from RetainPtr<> type.

Source/WTF:

  • wtf/RetainPtr.h:

(WTF::RetainPtr<T>::HelperPtrType):

  • Use C++ template metaprogramming to define a shared return type for adoptNS() and retainPtr() that uses RetainPtr<NSObject> instead of RetainPtr<NSObject *>. The non-Objective-C typedef is used with retainPtr() for CFTypeRef objects.

(WTF::adoptNS):

  • Only make declarations available when compilng with Objective-C. The inline implementation is only available for Objective-C, so this makes the declarations consistent.
  • Change return type to remove '*' from NS types using RetainPtr<T>::HelperPtrType.

(WTF::retainPtr):

  • Change return type to remove '*' from NS types using RetainPtr<T>::HelperPtrType.
  • wtf/SchedulePair.h:
  • Remove '*' from RetainPtr<> type.

Tools:

  • Scripts/webkitpy/style/checker.py:
  • Ignore use of new runtime/retainptr check in Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it contains tests to ensure RetainPtr<NSObject *> is compatible with RetainPtr<NSObject>.
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_language):
(CppChecker):

  • Add checker for use of '*' in RetainPtr<> type. A for loop was used instead of a single regex so that angle brackets could be matched up when checking the type contained within the RetainPtr<> type.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):

  • Add unit test for new runtime/retainptr check.
  • TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
  • TestWebKitAPI/EditingTestHarness.h:
  • Remove '*' from RetainPtr<> type.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • Add cf/RetainPtr.cpp back to TestWTFLibrary target! This regressed in r201938.
  • TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:

(TestWebKitAPI::TEST):

  • Update tests to match RetainPtr.mm tests (except for the *SimilarNSType tests since there is no CF equivalent of RetainPtr<NSString> and RetainPtr<NSString *>).
  • TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:

(TestWebKitAPI::TEST):

  • Update tests to:
    • Not conflict by name with equivalent CF tests in RetainPtr.cpp.
    • Add test cases for RetainPtr<NSObject>, RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
    • Add *SimilarNSType tests for converting between RetainPtr<NSObject> and RetainPtr<NSObject *>.
    • Change 0 to nil as appropriate.
    • Re-alphabetize the tests by name.
    • Add Optional<RetainPtr<>> tests.
    • Add retainPtr() tests.
  • TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:

(-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):

  • TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:

(TEST):

  • Remove '*' from RetainPtr<> type.
  • TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:

(TEST(WebKit, JITEnabled)):

  • Add missing WTFMove(). Apparently a temporary was being created before in the argument list due to mismatched RetainPtr<> types.
  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:

(TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
  • TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
  • WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:

(WTR::resourcesDirectoryURL):

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  • Remove '*' from RetainPtr<> type.
3:49 PM Changeset in webkit [239708] by Alan Coon
  • 7 edits in tags/Safari-607.1.18.3/Source

Versioning.

3:42 PM Changeset in webkit [239707] by youenn@apple.com
  • 3 edits in trunk/LayoutTests

LayoutTests/http/wpt/fetch/csp-reports-bypass-csp-checks.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=193178

Reviewed by Chris Dumez.

Test was flaky as the ping load CSP report request might be sent after the
fetch that grabs the report.
To overcome that issue, fetch the report several times until receiving a report.

  • http/wpt/fetch/csp-reports-bypass-csp-checks.html:
  • http/wpt/fetch/resources/store-csp-report.py:

(main):

3:34 PM Changeset in webkit [239706] by Alan Coon
  • 1 copy in tags/Safari-607.1.18.3

New tag.

3:22 PM Changeset in webkit [239705] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: run arrow shouldn't be visible when running tests
​https://bugs.webkit.org/show_bug.cgi?id=192209
<rdar://problem/46423615>

Reviewed by Brian Burg.

  • UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.ondetach):
(WI.AuditTreeElement.prototype._updateLevel):
(WI.AuditTreeElement.prototype._handleAuditManagerTestScheduled): Added.
(WI.AuditTreeElement.prototype._handleAuditManagerTestCompleted): Added.

  • UserInterface/Views/AuditTreeElement.css: Added.

(.tree-outline .item.audit:matches(.test-case, .test-group):not(.manager-active) > .status:hover > img): Added.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Added.
(.tree-outline .item.audit:matches(.test-case, .test-group) > .status:hover > img): Deleted.
(.tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Deleted.

3:15 PM Changeset in webkit [239704] by dino@apple.com
  • 12 edits in trunk

Turn on Pointer Events by default for iOS
​https://bugs.webkit.org/show_bug.cgi?id=193214
<rdar://problem/46974878>

Reviewed by Wenson Hsieh.

LayoutTests/imported/w3c:

Update expected results.

  • web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
  • web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
  • web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:

Source/WebKit:

Turn on Pointer Events.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.

LayoutTests:

Skip the pointer events tests everywhere but iOS.

  • TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
2:41 PM Changeset in webkit [239703] by Devin Rousso
  • 19 edits
    5 moves
    3 adds
    2 deletes in trunk

Web Inspector: extend XHR breakpoints to work with fetch
​https://bugs.webkit.org/show_bug.cgi?id=185843
<rdar://problem/40431027>

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/DOMDebugger.json:

Rename XHR to URL.

  • inspector/protocol/Debugger.json:

Add Fetch to reason enum for the Debugger.paused event.

Source/WebCore:

Test: inspector/dom-debugger/url-breakpoints.html

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willFetch): Added.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willFetchImpl): Added.

  • inspector/agents/InspectorDOMDebuggerAgent.h:
  • inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::discardBindings):
(WebCore::InspectorDOMDebuggerAgent::setURLBreakpoint): Added.
(WebCore::InspectorDOMDebuggerAgent::removeURLBreakpoint): Added.
(WebCore::InspectorDOMDebuggerAgent::breakOnURLIfNeeded): Added.
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorDOMDebuggerAgent::willFetch): Added.
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint): Deleted.
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint): Deleted.

Source/WebInspectorUI:

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.supportsURLBreakpoints): Added.
(WI.DOMDebuggerManager.prototype.get urlBreakpoints): Added.
(WI.DOMDebuggerManager.prototype.urlBreakpointForURL): Added.
(WI.DOMDebuggerManager.prototype.addURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._speculativelyResolveBreakpoints):
(WI.DOMDebuggerManager.prototype._updateURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._resolveURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._saveURLBreakpoints): Added.
(WI.DOMDebuggerManager.prototype._urlBreakpointDisabledStateDidChange): Added.
(WI.DOMDebuggerManager.prototype.get xhrBreakpoints): Deleted.
(WI.DOMDebuggerManager.prototype.xhrBreakpointForURL): Deleted.
(WI.DOMDebuggerManager.prototype.addXHRBreakpoint): Deleted.
(WI.DOMDebuggerManager.prototype.removeXHRBreakpoint): Deleted.
(WI.DOMDebuggerManager.prototype._updateXHRBreakpoint.breakpointUpdated): Deleted.
(WI.DOMDebuggerManager.prototype._updateXHRBreakpoint): Deleted.
(WI.DOMDebuggerManager.prototype._resolveXHRBreakpoint): Deleted.
(WI.DOMDebuggerManager.prototype._saveXHRBreakpoints): Deleted.
(WI.DOMDebuggerManager.prototype._xhrBreakpointDisabledStateDidChange): Deleted.

  • UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype._pauseReasonFromPayload):

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel):
(WI.DebuggerSidebarPanel.prototype.willDismissPopover):
(WI.DebuggerSidebarPanel.prototype._addBreakpoint):
(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
(WI.DebuggerSidebarPanel.prototype._addTreeElement):
(WI.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointClicked):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):

  • UserInterface/Models/URLBreakpoint.js: Renamed from Source/WebInspectorUI/UserInterface/Models/XHRBreakpoint.js.
  • UserInterface/Views/URLBreakpointPopover.css: Renamed from Source/WebInspectorUI/UserInterface/Views/XHRBreakpointPopover.css.
  • UserInterface/Views/URLBreakpointPopover.js: Renamed from Source/WebInspectorUI/UserInterface/Views/XHRBreakpointPopover.js.
  • UserInterface/Views/URLBreakpointTreeElement.css: Renamed from Source/WebInspectorUI/UserInterface/Views/XHRBreakpointTreeElement.css.
  • UserInterface/Views/URLBreakpointTreeElement.js: Renamed from Source/WebInspectorUI/UserInterface/Views/XHRBreakpointTreeElement.js.
  • UserInterface/Base/Setting.js:

(WI.Setting.migrateValue): Added.

  • UserInterface/Main.html:
  • UserInterface/Test.html:
  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • inspector/dom-debugger/url-breakpoints.html: Copied from LayoutTests/inspector/dom-debugger/xhr-breakpoints.html.
  • inspector/dom-debugger/url-breakpoints-expected.txt: Copied from LayoutTests/inspector/dom-debugger/xhr-breakpoints-expected.txt.
  • inspector/dom-debugger/xhr-breakpoints.html: Deleted.
  • inspector/dom-debugger/xhr-breakpoints-expected.txt: Deleted.
  • inspector/dom-debugger/resources/dataFetch.json: Added.
2:39 PM Changeset in webkit [239702] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup AudioTrackPrivateMediaStreamCocoa
​https://bugs.webkit.org/show_bug.cgi?id=193208
<rdar://problem/42225870>

Reviewed by Youenn Fablet.

  • platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable): Clear input and
output format descriptions after stopping the audio unit.

2:31 PM Changeset in webkit [239701] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Remove use of NetworkProcess::singleton in ServiceWorker code
​https://bugs.webkit.org/show_bug.cgi?id=193209

Reviewed by Megan Gardner.

Use a member Ref<NetworkProcess> instead to avoid global singleton use.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorker):
(WebKit::WebSWServerConnection::scheduleJobInServer):

  • NetworkProcess/ServiceWorker/WebSWServerConnection.h:
2:30 PM Changeset in webkit [239700] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Remove use of NetworkProcess::singleton in NetworkLoad/NetworkDataTask code
​https://bugs.webkit.org/show_bug.cgi?id=193212

Reviewed by Andy Estes.

  • NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::NetworkDataTaskBlob):
(WebKit::NetworkDataTaskBlob::download):
(WebKit::NetworkDataTaskBlob::writeDownload):
(WebKit::NetworkDataTaskBlob::didFailDownload):
(WebKit::NetworkDataTaskBlob::didFinishDownload):

  • NetworkProcess/NetworkDataTaskBlob.h:
  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponse):

  • NetworkProcess/NetworkLoad.h:
2:29 PM Changeset in webkit [239699] by achristensen@apple.com
  • 10 edits in trunk/Source/WebKit

Remove use of NetworkProcess::singleton for downloads
​https://bugs.webkit.org/show_bug.cgi?id=193207

Reviewed by Brady Eidson.

No change in behavior. The DownloadManager is now a member of the NetworkProcess instead of a static singleton.

  • NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::Download):
(WebKit::Download::didReceiveChallenge):

  • NetworkProcess/Downloads/Download.h:
  • NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertNetworkLoadToDownload):

  • NetworkProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::client):

  • NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::PendingDownload):
(WebKit::PendingDownload::messageSenderConnection):

  • NetworkProcess/Downloads/PendingDownload.h:
  • NetworkProcess/NetworkLoadChecker.cpp:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadManager):

  • NetworkProcess/NetworkProcess.h:
2:18 PM Changeset in webkit [239698] by Devin Rousso
  • 20 edits
    2 moves
    2 adds in trunk

Web Inspector: Network: show secure connection details per-request
​https://bugs.webkit.org/show_bug.cgi?id=191539
<rdar://problem/45979891>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/Security.json:

Add Connection type.

  • inspector/protocol/Network.json:

Send Security.Connection information when request metrics become available.

Source/WebCore:

Test: http/tests/inspector/network/resource-security-connection.html

  • platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics:isolatedCopy):
(WebCore::NetworkLoadMetrics:clearNonTimingData):
(WebCore::NetworkLoadMetrics:operator==):
(WebCore::NetworkLoadMetrics:encode):
(WebCore::NetworkLoadMetrics:decode):

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForMetrics):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebInspectorUI:

  • UserInterface/Models/Resource.js:

(WI.Resource):
(WI.Resource.prototype.get security): Added.
(WI.Resource.prototype.updateForResponse):
(WI.Resource.prototype.updateWithMetrics):
(WI.Resource.prototype.get responseSecurity): Deleted.

  • UserInterface/Views/ResourceSecurityContentView.js:

(WI.ResourceSecurityContentView):
(WI.ResourceSecurityContentView.prototype.initialLayout):
(WI.ResourceSecurityContentView.prototype.layout):
(WI.ResourceSecurityContentView.prototype._refreshConnectionSection): Added.
(WI.ResourceSecurityContentView.prototype._refreshCetificateSection):
(WI.ResourceSecurityContentView.prototype._handleResourceMetricsDidChange): Added.

  • UserInterface/Views/ResourceSecurityContentView.css:

(body[dir] .resource-security > section:matches(.connection, .certificate) > .details): Added.
(@media (prefers-dark-interface) body[dir] .resource-security > section:matches(.connection, .certificate) > .details): Added.
(body[dir] .resource-security > section.certificate > .details): Deleted.
(@media (prefers-dark-interface) body[dir] .resource-security > section.certificate > .details): Deleted.

  • Localizations/en.lproj/localizedStrings.js:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(stringForSSLProtocol): Added.
(stringForSSLCipher): Added.
(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

LayoutTests:

  • http/tests/inspector/network/resource-security-connection-expected.txt: Added.
  • http/tests/inspector/network/resource-security-connection.html: Added.
  • http/tests/inspector/network/resource-security-certificate-expected.txt: Added.
  • http/tests/inspector/network/resource-security-certificate.html: Added.
  • http/tests/inspector/network/resource-response-security-expected.txt: Deleted.
  • http/tests/inspector/network/resource-response-security.html: Deleted.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wpe/TestExpectations:
2:13 PM Changeset in webkit [239697] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Web Inspector: Remote inspector can crash if attempting to navigate inspector page
​https://bugs.webkit.org/show_bug.cgi?id=193204
<rdar://problem/45550428>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-07
Reviewed by Devin Rousso.

  • UIProcess/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):

  • UIProcess/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):

2:05 PM Changeset in webkit [239696] by Alan Coon
  • 1 copy in branches/safari-606.4.5.2-branch

New branch.

1:51 PM Changeset in webkit [239695] by Truitt Savell
  • 3 edits in trunk/LayoutTests

Update test expectations for platform/mac/media/audio-session-category-video-paused.html
​https://bugs.webkit.org/show_bug.cgi?id=189680

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
1:47 PM Changeset in webkit [239694] by eric.carlson@apple.com
  • 16 edits
    2 adds in trunk

Deactivate audio session whenever possible
​https://bugs.webkit.org/show_bug.cgi?id=193188
<rdar://problem/42678977>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/deactivate-audio-session.html

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::tryToSetActive):
(WebCore::AudioSession::tryToSetActiveInternal):

  • platform/audio/AudioSession.h:

(WebCore::AudioSession::isActive const):

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::removeSession):
(WebCore::deactivateAudioSession):
(WebCore::PlatformMediaSessionManager::shouldDeactivateAudioSession):
(WebCore::PlatformMediaSessionManager::setShouldDeactivateAudioSession):

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::tryToSetActive): Deleted.

  • platform/audio/mac/AudioSessionMac.cpp:

(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::tryToSetActive): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::audioSessionActive const):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

LayoutTests:

  • TestExpectations: Skip the new test.
  • media/deactivate-audio-session-expected.txt: Added.
  • media/deactivate-audio-session.html: Added.
  • platform/ios/TestExpectations: Run the new test.
  • platform/mac-wk2/TestExpectations: Ditto.
12:31 PM Changeset in webkit [239693] by youenn@apple.com
  • 117 edits
    85 copies
    22 moves
    243 adds
    46 deletes in trunk/LayoutTests

Resync WPT fetch tests to 834eac4
​https://bugs.webkit.org/show_bug.cgi?id=193125

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch: Resynced.
  • web-platform-tests/html/webappapis/atob/base64-expected.txt:

LayoutTests:

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/imported/w3c/web-platform-tests/fetch/content-type/response.window-expected.txt: Added.
  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-init-stream.any-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-reset-attributes.https-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/content-type/script.window-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/304-update-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/heuristic-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/invalidate-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/status-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/sec-metadata/embed.tentative.https.sub-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/sec-metadata/object.tentative.https.sub-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/sec-metadata/serviceworker.tentative.https.sub-expected.txt: Added.
  • platform/mac/TestExpectations:
  • tests-options.json:
12:30 PM Changeset in webkit [239692] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebCore

PlatformECKey should use a std::unique_ptr
<​https://webkit.org/b/193170>

Reviewed by Brent Fulgham.

Broadly:

  • Switch from using raw pointers to using std::unique_ptr<> to hold PlatformECKey.
  • Introduce PlatformECKeyContainer type to handle different std::unique_ptr<> types on each platform.
  • Get rid of custom CryptoKeyEC destructors since the std::unique_ptr<> handles that with a Deleter.
  • Initialize stack variables to nullptr.
  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::CryptoKeyEC::keySizeInBits const):
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):
(WebCore::CryptoKeyEC::~CryptoKeyEC): Deleted.

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::CryptoKeyEC):

  • crypto/keys/CryptoKeyEC.h:

(WebCore::CCECCryptorRefDeleter::operator() const):

  • crypto/mac/CryptoKeyECMac.cpp:

(WebCore::CryptoKeyEC::keySizeInBits const):
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):
(WebCore::CryptoKeyEC::~CryptoKeyEC): Deleted.

12:20 PM Changeset in webkit [239691] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

[Cocoa] Add SPI to check if a WKWebView has an inspector frontend
​https://bugs.webkit.org/show_bug.cgi?id=193162
<rdar://problem/24267143>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-07
Reviewed by Alex Christensen.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _hasInspectorFrontend]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::hasInspectorFrontend const):

12:20 PM Changeset in webkit [239690] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: "white" isn't recognized as a color keyword
​https://bugs.webkit.org/show_bug.cgi?id=193173
<rdar://problem/47068595>

Reviewed by Joseph Pecoraro.

Attempt to parse "atom" token types as colors.

Display color picker only for color-aware properties. For instance,
display it for "color: white" but not for "-apple-pay-button-style: white".

  • UserInterface/Models/CSSKeywordCompletions.js:

(addKeywordsForName):
(WI.CSSKeywordCompletions.forProperty):
(WI.CSSKeywordCompletions.isColorAwareProperty):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._addColorTokens):

12:10 PM Changeset in webkit [239689] by Antti Koivisto
  • 29 edits
    2 copies
    5 adds in trunk/Source

UI process side scrollbars for UI side compositing on Mac
​https://bugs.webkit.org/show_bug.cgi?id=193106

Reviewed by Tim Horton.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::paintScrollCorner):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):

Pass scrollbar host layers and the dark appearance bit to the scrolling tree.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::verticalScrollbarLayerForFrameView):
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForFrameView):

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollableAreaParameters::ScrollableAreaParameters):
(WebCore::ScrollableAreaParameters::operator== const):

  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setScrollbarLayers):

  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::scrollableAreaSize const):
(WebCore::ScrollingTreeScrollingNode::totalContentsSize const):
(WebCore::ScrollingTreeScrollingNode::useDarkAppearanceForScrollbars const):
(WebCore::ScrollingTreeScrollingNode::lastCommittedScrollPosition const):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::useDarkAppearanceForScrollbars const):

Factor into a function as this is used in several places.

  • platform/ScrollableArea.h:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]):

  • platform/mac/ScrollbarThemeMac.h:

Source/WebKit:

This patch implements Mac scrollbars on UI process side using the low level NSScrollerImp/NSScrollerPairImp
SPIs. With this patch scrollbars mostly work for the main frame and also render (but can't be interacted with)
for the subframes.

This is based on the similar code for web process side scrollbars in ScrollAnimatorMac. There is quite a bit of
copy code as there is no way to share nicely. One of these will eventually go away anyway.

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::decode):

  • UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
(WebKit::RemoteScrollingCoordinatorProxy::handleMouseEvent):

  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode):
(WebKit::RemoteScrollingTree::handleMouseEvent):

  • UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
  • UIProcess/RemoteLayerTree/mac: Added.
  • UIProcess/RemoteLayerTree/mac/ScrollerMac.h: Added.

Wraps NSScrollerImp for vertical or horizontal scrollbar.

(WebKit::ScrollerMac::pair):
(WebKit::ScrollerMac::orientation const):
(WebKit::ScrollerMac::hostLayer const):
(WebKit::ScrollerMac::scrollerImp):

  • UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Added.

(-[WKScrollbarPartAnimation initWithScroller:featureToAnimate:animateFrom:animateTo:duration:]):
(-[WKScrollbarPartAnimation startAnimation]):
(-[WKScrollbarPartAnimation setStartValue:]):
(-[WKScrollbarPartAnimation setEndValue:]):
(-[WKScrollbarPartAnimation setCurrentProgress:]):
(-[WKScrollbarPartAnimation invalidate]):
(-[WKScrollerImpDelegate initWithScroller:]):
(-[WKScrollerImpDelegate cancelAnimations]):
(-[WKScrollerImpDelegate scrollerPair]):
(-[WKScrollerImpDelegate convertRectToBacking:]):
(-[WKScrollerImpDelegate convertRectFromBacking:]):
(-[WKScrollerImpDelegate layer]):
(-[WKScrollerImpDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WKScrollerImpDelegate convertRectToLayer:]):
(-[WKScrollerImpDelegate shouldUseLayerPerPartForScrollerImp:]):
(-[WKScrollerImpDelegate effectiveAppearanceForScrollerImp:]):
(-[WKScrollerImpDelegate setUpAlphaAnimation:scrollerPainter:part:animateAlphaTo:duration:]):
(-[WKScrollerImpDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WKScrollerImpDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WKScrollerImpDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WKScrollerImpDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WKScrollerImpDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(-[WKScrollerImpDelegate invalidate]):
(WebKit::ScrollerMac::ScrollerMac):
(WebKit::ScrollerMac::~ScrollerMac):
(WebKit::ScrollerMac::attach):
(WebKit::ScrollerMac::setHostLayer):
(WebKit::ScrollerMac::updatePosition):
(WebKit::ScrollerMac::convertFromContent const):

  • UIProcess/RemoteLayerTree/mac/ScrollerPairMac.h: Added.

(WebKit::ScrollerPairMac::verticalScroller):
(WebKit::ScrollerPairMac::horizontalScroller):
(WebKit::ScrollerPairMac::scrollerImpPair):
(WebKit::ScrollerPairMac::lastKnownMousePosition const):

  • UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm: Added.

Wraps NSScrollerPairImp and owns the vertical and horizontal scrollers.

(-[WKScrollerImpPairDelegate initWithScrollerPair:]):
(-[WKScrollerImpPairDelegate invalidate]):
(-[WKScrollerImpPairDelegate contentAreaRectForScrollerImpPair:]):
(-[WKScrollerImpPairDelegate inLiveResizeForScrollerImpPair:]):
(-[WKScrollerImpPairDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WKScrollerImpPairDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WKScrollerImpPairDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WKScrollerImpPairDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebKit::ScrollerPairMac::ScrollerPairMac):
(WebKit::ScrollerPairMac::~ScrollerPairMac):
(WebKit::ScrollerPairMac::handleWheelEvent):
(WebKit::ScrollerPairMac::handleMouseEvent):
(WebKit::ScrollerPairMac::updatePositions):
(WebKit::ScrollerPairMac::contentsSize const):
(WebKit::ScrollerPairMac::visibleContentsRect const):
(WebKit::ScrollerPairMac::useDarkAppearance const):

  • UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp: Added.

Special node for UI side Mac scrolling. Owns ScrollerPairMac instance.

(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::ScrollingTreeFrameScrollingNodeRemoteMac):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::~ScrollingTreeFrameScrollingNodeRemoteMac):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::create):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::commitStateBeforeChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::setScrollLayerPosition):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::handleWheelEvent):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::handleMouseEvent):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::scrollingTree const):

  • UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleMouseEvent):

  • WebKit.xcodeproj/project.pbxproj:
11:59 AM Changeset in webkit [239688] by eric.carlson@apple.com
  • 4 edits in trunk

A MediaTime timescale must never be zero
​https://bugs.webkit.org/show_bug.cgi?id=193156
<rdar://problem/32504501>

Reviewed by Jer Noble.

Source/WTF:

  • wtf/MediaTime.cpp:

(WTF::greatestCommonDivisor): ASSERT if either parameter or return value is zero.
(WTF::MediaTime::MediaTime): Create +/- infinity if passed zero timescale.
(WTF::MediaTime::createWithFloat): Ditto.
(WTF::MediaTime::createWithDouble): Ditto.
(WTF::MediaTime::setTimeScale): Ditto.

Tools:

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST): Add tests for zero timescale.

11:47 AM Changeset in webkit [239687] by Alan Coon
  • 1 copy in branches/safari-607-branch

New branch.

11:25 AM Changeset in webkit [239686] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Unwanted page navigation after showing & dismissing contextual menu with control-click
​https://bugs.webkit.org/show_bug.cgi?id=192912
<rdar://problem/46318508>

Reviewed by Timothy Hatcher.

After the conversion to use a mouse event queue, this behavior was observed rarely, especially
when CPU is under load and lots of things are going on in the page. In other words, it's racy.

Based on NSEvent logging, it seems that when the system is under load, we simply take too long
to enter the nested runloop that AppKit uses to handle events when the context menu is present.
AppKit doesn't care whether or not the MouseDown triggered a nested runloop; on my machine it delivers
the MouseUp event about 130ms after the MouseDown event. If we haven't show the context menu in
that time, then the MouseUp is enqueued as a normal mouse event. If the Ctrl-click is on a link,
then the MouseUp will be interpreted by EventHandler as a click event, which in the simplest case
will initiate a main frame navigation. When the context menu is dismissed and the nested runloop
is torn down, the navigation IPC message is handled in UIProcess and the page navigates away.

We can't do much to change AppKit's inherently racy behavior, but we can avoid processing
mouse events that are delivered whilst we are processing the context menu-initiating event.
From the WebProcess point of view, there is no race anymore because it does not receive the
MouseUp event.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
If new events come in, drop them on the floor. Based on testing, the nested runloop will discard
the unpaired MouseUp event anyway, so this does not cause a change in behavior.

10:50 AM Changeset in webkit [239685] by Wenson Hsieh
  • 12 edits
    4 adds in trunk

Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net
​https://bugs.webkit.org/show_bug.cgi?id=193180
<rdar://problem/45971041>

Reviewed by Tim Horton.

Source/WebCore:

Adjust a method on RenderObject to additionally detect when the RenderObject is inside of an overflow: hidden
container that is also empty. See WebKit ChangeLog for more details.

Test: editing/selection/ios/hide-selection-in-empty-overflow-hidden-container.html

editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isTransparentOrFullyClippedRespectingParentFrames const):
(WebCore::RenderObject::isTransparentRespectingParentFrames const): Deleted.

  • rendering/RenderObject.h:

Source/WebKit:

JSFiddle uses CodeMirror; CodeMirror's editor works by capturing keystrokes and input in a hidden textarea
element, and then drawing its own selection caret using web content. This textarea is hidden by being placed
underneath an empty div with overflow: hidden;.

When requesting desktop site on iOS, both CodeMirror's caret and the native iOS caret are shown because iOS
selection UI consists of native views overlaid on the page, whereas on macOS, the entire textarea (along with
the caret) are occluded by the hidden overflow container. Additionally, various iOS behaviors related to
selection and editing, such as zooming to reveal the focused element and showing the platform callout bar, are
active when focusing this hidden editable area; these don't work as intended, and just interfere with the page's
custom editing UI.

To fix this, we augment the text interaction suppression mechanism added in r238146 to detect when the focused
element is in an empty overflow: hidden container, and bail out of native text editing behaviors.

  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):

  • Shared/EditorState.h:

Rename elementIsTransparent to elementIsTransparentOrFullyClipped.

  • Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

  • Shared/FocusedElementInformation.h:
  • UIProcess/ios/WKContentViewInteraction.h:

Rename FocusedElementIsTransparent to FocusedElementIsTransparentOrFullyClipped.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _elementDidBlur]):

Make an additional tweak here to only stop suppressing text interaction assistant in -_elementDidBlur if we're
not also in the middle of changing the focused element. Without this, focusing a hidden editable element while
another hidden editable element is currently focused causes us to zoom to reveal the newly focused hidden
editable element, when we should be avoiding this behavior.

(-[WKContentView _updateChangedSelection:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::getFocusedElementInformation):

LayoutTests:

  • editing/selection/ios/hide-selection-in-empty-overflow-hidden-container-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-empty-overflow-hidden-container.html: Added.

Add a layout test to verify that focusing a hidden editable element underneath an empty container with
overflow: hidden doesn't cause platform selection UI to appear.

  • editing/selection/ios/show-selection-in-empty-overflow-hidden-document-expected.txt: Added.
  • editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html: Added.

Add a layout test to verify that native selection UI shows up when the document element is made empty with
overflow: hidden, but the focused elements are still visible.

10:46 AM Changeset in webkit [239684] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Mark compositing/masks/compositing-clip-path-change-no-repaint.html flakey for Mojave WK1
​https://bugs.webkit.org/show_bug.cgi?id=189753

Unreviewed Test Gardening

  • platform/mac-wk1/TestExpectations:
10:36 AM Changeset in webkit [239683] by achristensen@apple.com
  • 9 edits in trunk/Source/WebKit

Move identifierBase from SessionTracker to NetworkProcess/WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=193201

Reviewed by Tim Horton.

No change in behavior. This just reduces process-global state.

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::uiProcessBundleIdentifier const):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • Shared/SessionTracker.cpp:

(WebKit::identifierBase): Deleted.
(WebKit::SessionTracker::getIdentifierBase): Deleted.
(WebKit::SessionTracker::setIdentifierBase): Deleted.

  • Shared/SessionTracker.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::WebFrameNetworkingContext::sourceApplicationIdentifier const):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::uiProcessBundleIdentifier const):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

10:04 AM Changeset in webkit [239682] by Alan Coon
  • 7 edits in tags/Safari-607.1.18.2/Source

Versioning.

10:03 AM Changeset in webkit [239681] by Alan Coon
  • 4 edits
    2 adds in tags/Safari-607.1.18.2

Cherry-pick r239591. rdar://problem/47014944

REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
​https://bugs.webkit.org/show_bug.cgi?id=193095
<rdar://problem/47014944>

Reviewed by Zalan Bujtas.

Source/WebCore:

In r239306 we stopped making CALayers for font-smoothed text when not necessary on macOS Mojave
and later. However, we still turned off smoothing for non-opaque layers (setShouldSmoothFonts(false)),
which continues to affect the appearance of text.

Fix by only calling setShouldSmoothFonts(false) when the OS supports font smoothing.

Test: compositing/contents-format/subpixel-antialiased-text.html

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayer::drawLayerContents):

LayoutTests:

A ref test that compares the rendering of layer and non-layer text with smoothing and antialiasing.

  • compositing/contents-format/subpixel-antialiased-text-expected.html: Added.
  • compositing/contents-format/subpixel-antialiased-text.html: Added.
  • platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:03 AM Changeset in webkit [239680] by achristensen@apple.com
  • 23 edits in trunk/Source/WebKit

Reduce use of NetworkProcess::singleton
​https://bugs.webkit.org/show_bug.cgi?id=193197

Reviewed by Brady Eidson.

Pass it around as a Ref<NetworkProcess> as a step towards reducing global state.
Soup's WebFrameNetworkingContext no longer makes a NetworkSession like all other ports
because networking is no longer done in the WebProcess.

  • NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess):
(WebKit::WebIDBConnectionToClient::deleteDatabase):
(WebKit::WebIDBConnectionToClient::openDatabase):
(WebKit::WebIDBConnectionToClient::abortTransaction):
(WebKit::WebIDBConnectionToClient::commitTransaction):
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::createObjectStore):
(WebKit::WebIDBConnectionToClient::deleteObjectStore):
(WebKit::WebIDBConnectionToClient::renameObjectStore):
(WebKit::WebIDBConnectionToClient::clearObjectStore):
(WebKit::WebIDBConnectionToClient::createIndex):
(WebKit::WebIDBConnectionToClient::deleteIndex):
(WebKit::WebIDBConnectionToClient::renameIndex):
(WebKit::WebIDBConnectionToClient::putOrAdd):
(WebKit::WebIDBConnectionToClient::getRecord):
(WebKit::WebIDBConnectionToClient::getAllRecords):
(WebKit::WebIDBConnectionToClient::getCount):
(WebKit::WebIDBConnectionToClient::deleteRecord):
(WebKit::WebIDBConnectionToClient::openCursor):
(WebKit::WebIDBConnectionToClient::iterateCursor):
(WebKit::WebIDBConnectionToClient::establishTransaction):
(WebKit::WebIDBConnectionToClient::databaseConnectionPendingClose):
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed):
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent):
(WebKit::WebIDBConnectionToClient::openDBRequestCancelled):
(WebKit::WebIDBConnectionToClient::confirmDidCloseFromServer):
(WebKit::WebIDBConnectionToClient::getAllDatabaseNames):

  • NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::create):
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::NetworkConnectionToWebProcess::prefetchDNS):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):
(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):

  • NetworkProcess/NetworkConnectionToWebProcess.h:

(WebKit::NetworkConnectionToWebProcess::networkProcess):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::singleton):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::getNetworkProcessStatistics):
(WebKit::NetworkProcess::idbServer):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::convertToDownload):
(WebKit::NetworkResourceLoader::isAlwaysOnLoggingAllowed const):

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):
(WebKit::NetworkSession::NetworkSession):

  • NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::networkProcess):

  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::isAlwaysOnLoggingAllowed const):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::clearDiskCache):

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

  • NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

  • NetworkProcess/curl/NetworkSessionCurl.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup):

  • NetworkProcess/soup/NetworkSessionSoup.h:
9:59 AM Changeset in webkit [239679] by Alan Coon
  • 1 copy in tags/Safari-607.1.18.2

New tag.

9:57 AM Changeset in webkit [239678] by Alan Coon
  • 4 edits
    2 deletes in tags/Safari-607.1.18.1

Revert r239677. rdar://problem/47014944

9:50 AM Changeset in webkit [239677] by Alan Coon
  • 4 edits
    2 adds in tags/Safari-607.1.18.1

Cherry-pick r239591. rdar://problem/47014944

REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
​https://bugs.webkit.org/show_bug.cgi?id=193095
<rdar://problem/47014944>

Reviewed by Zalan Bujtas.

Source/WebCore:

In r239306 we stopped making CALayers for font-smoothed text when not necessary on macOS Mojave
and later. However, we still turned off smoothing for non-opaque layers (setShouldSmoothFonts(false)),
which continues to affect the appearance of text.

Fix by only calling setShouldSmoothFonts(false) when the OS supports font smoothing.

Test: compositing/contents-format/subpixel-antialiased-text.html

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayer::drawLayerContents):

LayoutTests:

A ref test that compares the rendering of layer and non-layer text with smoothing and antialiasing.

  • compositing/contents-format/subpixel-antialiased-text-expected.html: Added.
  • compositing/contents-format/subpixel-antialiased-text.html: Added.
  • platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:06 AM Changeset in webkit [239676] by youenn@apple.com
  • 3 edits
    1 move in trunk/Tools

API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
​https://bugs.webkit.org/show_bug.cgi?id=193175

Reviewed by Chris Dumez.

Updated API test as we bumped the SW schema to version 4.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
  • TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

8:18 AM Changeset in webkit [239675] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[LFC][BFC] Margin collapsing should not be limited to in-flow non-replaced boxes.
​https://bugs.webkit.org/show_bug.cgi?id=193183

Reviewed by Antti Koivisto.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

  • layout/LayoutUnits.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):

8:16 AM Changeset in webkit [239674] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][BFC] Move MarginCollapse from BlockFormattingContext::Geometry to BlockFormattingContext
​https://bugs.webkit.org/show_bug.cgi?id=193181

Reviewed by Antti Koivisto.

This is in preparation to share margin collapsing across all boxes in block formatting context.

  • layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBeforeFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginAfterFromLastChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSibling):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSibling):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfter):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBeforeFromFirstChild): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginAfterFromLastChild): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBeforeCollapsesWithParentMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfterCollapsesWithParentMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfterCollapsesWithParentMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBeforeCollapsesWithPreviousSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfterCollapsesWithNextSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginsCollapseThrough): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginAfter): Deleted.

8:04 AM Changeset in webkit [239673] by Claudio Saavedra
  • 3 edits in trunk/LayoutTests

[WPE][GTK] Skip css-painting-api tests

Unreviewed gardening. CSS_PAINTING_API is disabled by default.
Also remove a few tests that were individually marked as failing
for css-typedom since we already skipped the whole directory.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
7:39 AM Changeset in webkit [239672] by Claudio Saavedra
  • 3 edits in trunk/LayoutTests

[WPE][GTK] Skip css-typedom tests

Unreviewed gardening. CSS_TYPED_OM is disabled by default.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
5:56 AM Changeset in webkit [239671] by achristensen@apple.com
  • 22 edits in trunk/Source/WebKit

Modernize CacheModel and disk cache fetching and clearing
​https://bugs.webkit.org/show_bug.cgi?id=193164

Reviewed by Joseph Pecoraro.

fetchDiskCacheEntries and clearDiskCacheEntries now use an early-return model.
CacheModel is now an enum class.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::setCacheModel):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord const):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::clearDiskCache):

  • Shared/CacheModel.cpp:

(WebKit::calculateMemoryCacheSizes):
(WebKit::calculateURLCacheSizes):

  • Shared/CacheModel.h:

(): Deleted.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithLegacyOptions):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toCacheModel):
(WebKit::toAPI):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration pageCacheEnabled]):
(-[_WKProcessPoolConfiguration setPageCacheEnabled:]):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setCacheModel):
(WebKit::WebProcess::clearResourceCaches):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
2:42 AM Changeset in webkit [239670] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[WPE] Use Widget bounds for PlatformScreen rectangle information
​https://bugs.webkit.org/show_bug.cgi?id=193190

Reviewed by Philippe Normand.

Provide a better screen area estimate in screenRect() and
screenAvailableRect() return values than the current 1240x640 value by
using the Widget's bounds rectangle.

This approach is only factually correct when the Widget-associated view
is displayed in fullscreen, but it provides a better estimate even when
displayed in any other case as well. WPE doesn't provide specific API
that could enable the embedding environment to provide this information.

  • platform/wpe/PlatformScreenWPE.cpp:

(WebCore::screenRect): Return bounds of the Widget object.
(WebCore::screenAvailableRect): Relay the call to screenRect().

2:41 AM Changeset in webkit [239669] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Make Gradient::gradientSpaceTransform(), Pattern::patternSpaceTransform() methods const
​https://bugs.webkit.org/show_bug.cgi?id=193189

Reviewed by Philippe Normand.

The transform getter methods on the Gradient and Pattern classes both
return const references to the transform objects, and don't modify any
internal state. They should be marked const accordingly, allowing
invocations of these two methods through const references to Gradient
and Pattern objects.

  • platform/graphics/Gradient.h:

(WebCore::Gradient::gradientSpaceTransform): Now const.

  • platform/graphics/Pattern.h:

(WebCore::Pattern::patternSpaceTransform): Now const.

2:40 AM Changeset in webkit [239668] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r239636): ImageDecoder::setEncodedDataStatusChangeCallback() can be called on a null decoder
​https://bugs.webkit.org/show_bug.cgi?id=193187

Reviewed by Philippe Normand.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::ensureDecoderAvailable): Bail before calling the
setEncodedDataStatusChangeCallback() method when the returned
ImageDecoder object is null.

Jan 6, 2019:

10:42 PM Changeset in webkit [239667] by zandobersek@gmail.com
  • 5 edits
    12 adds
    1 delete in trunk/Source/WebCore

[Nicosia] Take over CoordinatedGraphics-named implementation of async scrolling classes
​https://bugs.webkit.org/show_bug.cgi?id=193133

Reviewed by Michael Catanzaro.

Move the CoordinatedGraphics-specific files under
page/scrolling/coordinatedgraphics/ to page/scrolling/nicosia/, along
with renaming the files and classes accordingly. Implementation will
only depend on the Nicosia-specific layer structure and is not specific
to the CoordinatedGraphics system.

  • PlatformPlayStation.cmake:
  • SourcesGTK.txt:
  • SourcesWPE.txt:
  • page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp.
  • page/scrolling/nicosia/ScrollingCoordinatorNicosia.h: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h.
  • page/scrolling/nicosia/ScrollingStateNodeNicosia.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp.
  • page/scrolling/nicosia/ScrollingTreeFixedNode.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeFixedNode.cpp.
  • page/scrolling/nicosia/ScrollingTreeFixedNode.h: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeFixedNode.h.
  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeFrameScrollingNodeCoordinatedGraphics.cpp.
  • page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeFrameScrollingNodeCoordinatedGraphics.h.
  • page/scrolling/nicosia/ScrollingTreeNicosia.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeCoordinatedGraphics.cpp.
  • page/scrolling/nicosia/ScrollingTreeNicosia.h: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeCoordinatedGraphics.h.
  • page/scrolling/nicosia/ScrollingTreeStickyNode.cpp: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeStickyNode.cpp.
  • page/scrolling/nicosia/ScrollingTreeStickyNode.h: Renamed from Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingTreeStickyNode.h.
  • platform/TextureMapper.cmake:
7:27 PM Changeset in webkit [239666] by Fujii Hironori
  • 7 edits in trunk/Tools

[Win][Clang] Fix compilation warnings of MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=193029

Reviewed by Ross Kirsling.

  • MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont

and m_URLBarFont. Reorder member variables to fix -Wreorder
warning.

  • MiniBrowser/win/PageLoadTestClient.cpp:

(PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.

  • MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of

pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
m_currentURLIndex.

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::WebKitBrowserWindow): Initialize
navigationClient with '{ }' to fix the missing field warning.

  • MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(initDocStruct): Changed the argument type docname to const.

6:08 PM Changeset in webkit [239665] by jiewen_tan@apple.com
  • 18 edits
    1 copy
    1 move
    6 adds in trunk

[WebAuthN] Import U2F command/response converters from Chromium
​https://bugs.webkit.org/show_bug.cgi?id=193150
<rdar://problem/47054028>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch imports Chromium's U2F command/response converters:
​https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-client-to-authenticator-protocol-v2.0-id-20180227.html#u2f-interoperability

  1. It directly imports the following files and suit them to WebKit's coding style:

​https://cs.chromium.org/chromium/src/device/fido/u2f_command_constructor.cc?l=1&rcl=db624110317d01efa78cd32e7be1524190e1beb0
​https://cs.chromium.org/chromium/src/device/fido/u2f_command_constructor.h?rcl=db624110317d01efa78cd32e7be1524190e1beb0
​https://cs.chromium.org/chromium/src/device/fido/u2f_command_constructor_unittest.cc?rcl=db624110317d01efa78cd32e7be1524190e1beb0

  1. It gathers the following methods into U2fResponseConverter:

AuthenticatorMakeCredentialResponse::CreateFromU2fRegisterResponse()
AuthenticatorGetAssertionResponse::CreateFromU2fSignResponse()

  1. It also updates FidoConstants.h, FidoTestData.h and CtapResponseTest.cpp accordingly.

Besides importing stuff from Chroimum, it also gathers a bunch of constants and helper functions into WebAuthenticationConstants.h
and WebAuthenticationUtils.h. It also fixes Bug 183534: 2) and 7).

Covered by API tests.

  • Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJsonHash):

  • Modules/webauthn/WebAuthenticationConstants.h: Copied from Source/WebCore/Modules/webauthn/COSEConstants.h.
  • Modules/webauthn/WebAuthenticationUtils.cpp: Added.

(WebCore::convertBytesToVector):
(WebCore::produceRpIdHash):
(WebCore::encodeES256PublicKeyAsCBOR):
(WebCore::buildAttestedCredentialData):
(WebCore::buildAuthData):
(WebCore::buildAttestationObject):

  • Modules/webauthn/WebAuthenticationUtils.h: Renamed from Source/WebCore/Modules/webauthn/COSEConstants.h.
  • Modules/webauthn/fido/DeviceResponseConverter.cpp:

(fido::getCredentialId):
(fido::readCTAPGetInfoResponse):

  • Modules/webauthn/fido/FidoConstants.h:
  • Modules/webauthn/fido/U2fCommandConstructor.cpp: Added.

(fido::WebCore::constructU2fRegisterCommand):
(fido::WebCore::constructU2fSignCommand):
(fido::isConvertibleToU2fRegisterCommand):
(fido::isConvertibleToU2fSignCommand):
(fido::convertToU2fRegisterCommand):
(fido::convertToU2fCheckOnlySignCommand):
(fido::convertToU2fSignCommand):
(fido::constructBogusU2fRegistrationCommand):

  • Modules/webauthn/fido/U2fCommandConstructor.h: Added.
  • Modules/webauthn/fido/U2fResponseConverter.cpp: Added.

(fido::WebCore::extractECPublicKeyFromU2fRegistrationResponse):
(fido::WebCore::extractCredentialIdFromU2fRegistrationResponse):
(fido::WebCore::createAttestedCredentialDataFromU2fRegisterResponse):
(fido::WebCore::parseX509Length):
(fido::WebCore::createFidoAttestationStatementFromU2fRegisterResponse):
(fido::readU2fRegisterResponse):
(fido::readFromU2fSignResponse):

  • Modules/webauthn/fido/U2fResponseConverter.h: Added.
  • Modules/webgpu/WebGPUCommandBuffer.cpp:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Moves helper functions to WebAuthenticationUtils.

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticatorInternal::produceHashSet):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
(): Deleted.
(WebKit::LocalAuthenticatorInternal::buildAuthData): Deleted.

  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:

(WebKit::MockHidConnection::feedReports):

Tools:

Adds API tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:

(TestWebKitAPI::getTestAttestedCredentialDataBytes):
(TestWebKitAPI::getTestAuthenticatorDataBytes):
(TestWebKitAPI::getTestAttestationObjectBytes):
(TestWebKitAPI::getTestSignResponse):
(TestWebKitAPI::getTestU2fRegisterResponse):
(TestWebKitAPI::TEST):
(TestWebKitAPI::convertToVector): Deleted.

  • TestWebKitAPI/Tests/WebCore/FidoTestData.h:
  • TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.

(TestWebKitAPI::constructMakeCredentialRequest):
(TestWebKitAPI::constructGetAssertionRequest):
(TestWebKitAPI::TEST):

LayoutTests:

Fixes Bug 183534:
7) Change little endian bytes (ARM and x86 default) to big endian as requested by the spec.

  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
  • http/wpt/webauthn/resources/util.js:
6:05 PM Changeset in webkit [239664] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Leak of WTF::Function objects in WebCore::CryptoKeyRSA::generatePair() (64-80 bytes each) in com.apple.WebKit.WebContent running WebKit layout tests
<​https://webkit.org/b/193177>
<rdar://problem/47072196>

Reviewed by Saam Barati.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair): Fix the leak by changing
raw pointers to heap-allocated block variables to hold the
WTF::Function objects until they are consumed within the block
passed to dispatch_async(). The block variables act like
captured variables in a C++ lambda and have the same lifetime as
the block that they are captured in. Note that we would have to
convert the source file from C++ to Objective-C++ to use a C++
lambda functor with dispatch_async(), which creates its own
issue because the comipiler requires a copy constructor to
convert the C++ lambda to a block functor, but the copy
constructor for the C++ lambda is implicitly deleted because the
WTF::Function copy constructor is explicitly deleted. Whew!

9:15 AM Changeset in webkit [239663] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying to use Document MediaPlayback functions.
​https://bugs.webkit.org/show_bug.cgi?id=193174

Patch by Pablo Saavedra <Pablo Saavedra> on 2019-01-06
Reviewed by Michael Catanzaro.

  • page/Page.cpp:

(WebCore::Page::stopAllMediaPlayback):
(WebCore::Page::suspendAllMediaPlayback):
(WebCore::Page::resumeAllMediaPlayback):

Note: See TracTimeline for information about the timeline view.