Context Navigation

← Previous Period
Next Period →

Timeline

Jan 9, 2019:

9:23 PM Changeset in webkit [239818] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 73

Added a tag for Safari Technology Preview release 73.

8:15 PM Changeset in webkit [239817] by Brent Fulgham

2 edits in trunk/Source/WebKit

Unreviewed build fix after r239816.

Although EWS had no problem with the patch, I'm seeing build errors on the actual bots.
This patch corrects the problem.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::logFrameNavigation):
(WebKit::NetworkProcess::logUserInteraction):

7:28 PM Changeset in webkit [239816] by Brent Fulgham

19 edits in trunk/Source/WebKit

Create a WebResourceLoadStatisticsStore attached to the NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=193261
<rdar://problem/47158616>

Reviewed by Alex Christensen.

This patch modifies NetworkSession so that it owns a WebResourceLoadStatisticsStore
object. This object is only created if the ResourceLoadStatistics feature is turned on.

The patch also modifies WebResourceLoadStatisticsStore so that it can be constructed
with an owning NetworkSession as an alternative to the current practice of using a
WebsiteDataStore object.

Two initial messages from the WebContent process are added (logFrameNavigation and
logUserNavigation) that notify the network process of these actions. Currently they
are called in addition the calls to the WebsiteDataStore object. These redundant calls
will be removed in a future patch.

This patch forces the ResourceLoadStatistics code in the NetworkSession to be off by
default, so there should be no change in behavior with this patch.

NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccessForFrame):
(WebKit::WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::WebResourceLoadStatisticsStore::updatePrevalentDomainsToBlockCookiesFor):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):
(WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains):
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::logFrameNavigation):
(WebKit::NetworkProcess::logUserInteraction):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::enableResourceLoadStatistics):

NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::resourceLoadStatistics const):

NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

NetworkProcess/NetworkSessionCreationParameters.h:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didLogUserInteraction):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebsiteDataStore::parameters):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::logFrameNavigation):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):

7:08 PM Changeset in webkit [239815] by achristensen@apple.com

37 edits
2 deletes in trunk/Source/WebKit

Replace SessionTracker with HashMap member of NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193266

Reviewed by Joseph Pecoraro.

NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):

NetworkProcess/Downloads/DownloadManager.h:
NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::startPreflight):

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::clearCachedCredentials):
(WebKit::NetworkProcess::networkSession):
(WebKit::NetworkProcess::setSession):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::preconnectTo):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
(WebKit::NetworkResourceLoader::logCookieInformation const):
(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):
(WebKit::NetworkResourceLoader::logCookieInformation):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::loadRequest):

NetworkProcess/PingLoad.h:
NetworkProcess/PreconnectTask.cpp:

(WebKit::PreconnectTask::PreconnectTask):

NetworkProcess/PreconnectTask.h:
NetworkProcess/RemoteNetworkingContext.h:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:
NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

Shared/SessionTracker.cpp: Removed.
Shared/SessionTracker.h: Removed.
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

WebProcess/Network/WebLoaderStrategy.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::destroyLegacyPrivateBrowsingSessionInNetworkProcess):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

6:27 PM Changeset in webkit [239814] by rniwa@webkit.org

6 edits in trunk/Source/WebCore

ThreadTimers should not store a raw pointer in its heap
https://bugs.webkit.org/show_bug.cgi?id=192975
<rdar://problem/46893946>

Reviewed by Geoffrey Garen.

Right now, ThreadTimers's heap data structure stores a raw pointer to TimerBase. In order to harden the timer code,
this patch replaces it with ThreadTimerHeapItem, a newly introduced struct, which effectively acks like
WeakReference<TimerBase*> as the timer heap and TimerBase both store RefPtr to it, and TimerBase's destructor clears
the raw pointer back to TimerBase*.

This approach was taken instead of an out-right adoptation of WeakPtr since the heap data structure requires each node
in the heap to have a fixed "priority" yet WeakPtr with no valid pointer back to TimerBase would effectively lose its
"priority" thereby corrupting the heap data structure. That is, each item in the heap must remember its fire time and
insertion order even when the underlying TimerBase had gone away (this should never happen but the whole point of this
hardening is to make it work even in the precense of such a bug).

This patch also moves the heap index in TimerBase to ThreadTimerHeapItem, and replaces the pointer to the heap vector
in TimerBase by a reference to ThreadTimers in ThreadTimerHeapItem. Note that ThreadTimers is a per-thread singleton.

The correctness of this hardening was tested by commenting out the call to stop() and !isInHeap() assertion in
TimerBase::~TimerBase() as well as the !isInHeap() assertion in ThreadTimerHeapItem::clearTimer() and observing that
layout tests run successfully without hitting any debug assertions.

No new tests since there should be no observable behavior difference.

WebCore.xcodeproj/project.pbxproj: Export ThreadTimers.h as a private header since it's now included in Timer.h
platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer): Delete ThreadTimerHeapItem's with nullptr TimerBase* (TimerBase had
already been deleted). This should only happen when TimerBase's destructor failed to remove itself from the timer heap,
which should never happen.
(WebCore::ThreadTimers::sharedTimerFiredInternal): Ditto. Also removed the redundant code which had removed the timer
from the heap since setNextFireTime does the removal already.

platform/ThreadTimers.h: Outdented the whole file.

(WebCore::ThreadTimers::timerHeap): We use Vector<RefPtr<ThreadTimerHeapItem>> instead of Vector<Ref<~>> since Ref<~>
doesn't have a copy constructor which is used by std::push_heap.
(WebCore::ThreadTimerHeapItem): Added.
(WebCore::ThreadTimerHeapItem::hasTimer const): Added.
(WebCore::ThreadTimerHeapItem::setNotInHeap): Added. ThreadTimerHeapItem uses unsigned -1 as the single value which
signifies the item not being in the heap instead of all negative values as in the old code in TimerBase.
(WebCore::ThreadTimerHeapItem::isInHeap const): Added.
(WebCore::ThreadTimerHeapItem::isFirstInHeap const): Added.
(WebCore::ThreadTimerHeapItem::timer): Added.
(WebCore::ThreadTimerHeapItem::clearTimer): Added.
(WebCore::ThreadTimerHeapItem::heapIndex const): Added.
(WebCore::ThreadTimerHeapItem::setHeapIndex): Added.
(WebCore::ThreadTimerHeapItem::timerHeap const): Added.

platform/Timer.cpp:

(WebCore::threadGlobalTimerHeap): This function is now only used in assertions.
(WebCore::ThreadTimerHeapItem::ThreadTimerHeapItem): Added.
(WebCore::ThreadTimerHeapItem::create): Added.
(WebCore::TimerHeapPointer::TimerHeapPointer):
(WebCore::TimerHeapPointer::operator-> const):
(WebCore::TimerHeapReference::TimerHeapReference): Added a copy constructor.
(WebCore::TimerHeapReference::copyRef const): Added.
(WebCore::TimerHeapReference::operator RefPtr<ThreadTimerHeapItem>& const):
(WebCore::TimerHeapPointer::operator* const):
(WebCore::TimerHeapReference::operator=): Use move assignment operator.
(WebCore::TimerHeapReference::swapWith):
(WebCore::TimerHeapReference::updateHeapIndex): Extracted to share code between two verions of operator=.
(WebCore::swap):
(WebCore::TimerHeapIterator::TimerHeapIterator):
(WebCore::TimerHeapIterator::operator-> const):
(WebCore::TimerHeapLessThanFunction::compare): Added variants which take RefPtr<ThreadTimerHeapItem>.
(WebCore::TimerHeapLessThanFunction::operator() const):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::~TimerBase):Clear the raw pointer in ThreadTimerHeapItem.
(WebCore::TimerBase::stop):
(WebCore::TimerBase::nextFireInterval const):
(WebCore::TimerBase::checkHeapIndex const): Added the consistency check for other items in the heap.
(WebCore::TimerBase::checkConsistency const):
(WebCore::TimerBase::heapDecreaseKey):
(WebCore::TimerBase::heapDelete):
(WebCore::TimerBase::heapDeleteMin):
(WebCore::TimerBase::heapIncreaseKey):
(WebCore::TimerBase::heapInsert):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::heapPopMin):
(WebCore::TimerBase::heapDeleteNullMin): Added. Used to delete ThreadTimerHeapItem which no longer has a valid TimerBase.
(WebCore::parentHeapPropertyHolds):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition const):
(WebCore::TimerBase::updateHeapIfNeeded): Tweaked the heap index assertion as heapIndex() itself would assert when called
on an item with an invalid (-1) heap index.
(WebCore::TimerBase::setNextFireTime): Create ThreadTimerHeapItem. Note m_heapItem is never cleared until this TimerBase
is deleted.
(WebCore::TimerHeapReference::operator TimerBase* const): Deleted.

platform/Timer.h:

(WebCore::TimerBase): Replaced m_nextFireTime, m_heapIndex, m_heapInsertionOrder, and m_cachedThreadGlobalTimerHeap
by m_heapItem, RefPtr to an ThreadTimerHeapItem.
(WebCore::TimerBase::augmentFireInterval):
(WebCore::TimerBase::inHeap const):
(WebCore::TimerBase::nextFireTime const):
(WebCore::TimerBase::isActive const):
(WebCore::TimerBase:: const): Deleted.

6:20 PM Changeset in webkit [239813] by Fujii Hironori

2 edits in trunk/Source/WTF

Use directory local sequential numbers for Unified Sources filenames instead of global sequential numbers for CMake
https://bugs.webkit.org/show_bug.cgi?id=192391

Reviewed by Don Olmstead.

Unified Source Builds are using global sequential numbers for
bundle filenames UnifiedSource{sequential-number}.cpp. As the
result, every new source file added would shift the next ones and
prevent compiler caches from speeding up consecutive builds e.g.
in git-bisect sessions.

Changed it to directory local sequential numbers,
UnifiedSource-{hash-of-dir-name}-{sequential-number-within-the-dir}.cpp.

This is affecting only CMake builds which is where no
'--max-cpp-bundle-count' nor '--max-obj-c-bundle-count' options
are set. Xcode builds still use the old convention.

Scripts/generate-unified-source-bundles.rb: Add new instance

variables @currentDirectory and @extraFiles to BundleManager.
Still use global sequential numbers if --max-cpp-bundle-count or
--max-obj-c-bundle-count is given.

6:04 PM Changeset in webkit [239812] by Fujii Hironori

3 edits in trunk/Tools

[Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
https://bugs.webkit.org/show_bug.cgi?id=193271

Reviewed by Brent Fulgham.

BSTR is a special data structure created by SysAllocString, not a
wchar_t null-terminated string.

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.

MiniBrowser/win/MiniBrowserWebHost.cpp:

(MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
BSTR from wide string literals.

6:03 PM Changeset in webkit [239811] by Alan Coon

7 edits in branches/safari-607-branch/Source

Versioning.

5:38 PM Changeset in webkit [239810] by sbarati@apple.com

1 edit
1 copy in trunk/Websites/browserbench.org

Merge the latest version of JetStream2.0 to browserbench.org.

Rubber-stamped by Ryosuke Niwa.

JetStream2.0: Copied from PerformanceTests/JetStream2.

5:38 PM Changeset in webkit [239809] by Alan Coon

8 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r239777. rdar://problem/47158629

[PSON] Flash of blank content while transitioning from page A to page B.
https://bugs.webkit.org/show_bug.cgi?id=193283

Reviewed by Chris Dumez.

Layer tree is not frozen during WebPage construction. If the flush timer (started for the initial
empty document) manages to run before the actual page load starts, we'll get a flash.

Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
Shared/WebPageCreationParameters.h:

Rename shouldDelayAttachingDrawingArea bit to isSwapFromSuspended and make it available on all platforms.

UIProcess/RemoteLayerTree/mac/ScrollerMac.h: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerPairMac.h: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm: Removed.
UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp: Removed.
UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h: Removed.
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::swapToWebProcess): (WebKit::WebPageProxy::finishAttachingToWebProcess): (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::continueNavigationInNewProcess):
UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::m_shouldAttachDrawingAreaOnPageTransition):

Freeze the layer tree in WebPage constructor if this is a swap from a suspended process.

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::didCompletePageTransition):

Unfreeze on first non-initial empty document page transition.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239808] by Alan Coon

2 edits in branches/safari-607-branch/Source/WebInspectorUI

Cherry-pick r239766. rdar://problem/47158780

Web Inspector: Styles: clicking on property that soon to be discarded shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=193218
<rdar://problem/47098303>

Reviewed by Devin Rousso.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown): A style property may get removed on blur event, so propertyElement may get removed from the DOM right when mousedown event happens.

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._stopSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239807] by Alan Coon

3 edits in branches/safari-607-branch/Source/WebInspectorUI

Cherry-pick r239762. rdar://problem/47158734

Web Inspector: Styles: Undo reverts all changes at once
https://bugs.webkit.org/show_bug.cgi?id=177676
<rdar://problem/34745031>

Reviewed by Devin Rousso.

Command-Z used to revert all changes at once because Web Inspector never
set any history checkpoints in the style editor.

UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
UserInterface/Views/SpreadsheetTextField.js: (WI.SpreadsheetTextField.prototype._handleBlur):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239806] by Alan Coon

7 edits
1 add in branches/safari-607-branch

Cherry-pick r239758. rdar://problem/47158613

Blob references for System Previews don't get a correct file extension
https://bugs.webkit.org/show_bug.cgi?id=193268
<rdar://problem/47133037>

Reviewed by Tim Horton.

Source/WebCore:

Apple platforms don't yet have a mapping from the USD MIME type to
file extensions (and we support some non-standard MIME types), which
means that downloads from Blob references don't get correctly named.

Fix this by adding an explicit mapping between System Preview types
and ".usdz".

WebKit API test: _WKDownload.SystemPreviewUSDZBlobNaming

platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::isSystemPreviewMIMEType): Remove USE(SYSTEM_PREVIEW) since this applies to macOS and iOS now.
platform/MIMETypeRegistry.h:
platform/cocoa/MIMETypeRegistryCocoa.mm: (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): Add a mapping for USDZ.

Tools:

New test that a Blob download of a USDZ file gets named correctly.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/Download.mm: (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]): (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]): (TEST):
TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239805] by Alan Coon

2 edits in branches/safari-607-branch/Source/JavaScriptCore

Cherry-pick r239755. rdar://problem/47158650

Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
<https://webkit.org/b/193264>
<rdar://problem/46651026>

Reviewed by Yusuke Suzuki.

parser/VariableEnvironment.cpp: (JSC::CompactVariableMap::Handle::~Handle): Call delete on m_environment instead of fastFree() to make sure the destructors for the Vector instance variables are run. This fixes the leaks because calling fastFree() would only free the CompactVariableEnvironment object, but not the heap-based buffers allocated for the Vector instance variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239804] by Alan Coon

9 edits in branches/safari-607-branch

Cherry-pick r239746. rdar://problem/47158728

IDB storage of Crypto keys does not work in private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=193219

Reviewed by Brady Eidson.

Source/WebCore:

https://trac.webkit.org/changeset/238677 moved from using a JSGlobalObject to a JSDOMGlobalObject for serialization/deserialization.
This does not work for crypto keys as they require not only a JSDOMGlobalObject but either a window or worker global object.

To fix the issue, revert 238677, and fix it by checking whether the dumping of an ArrayBuffer happens for a JSDOMGlobalObject or a JSGlobalObject.
If it is the latter, use JSC routines instead of toJS() which requires a JSDOMGlobalObject.

Covered by updated test.

Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::databaseThreadVM): (WebCore::IDBServer::UniqueIDBDatabase::databaseThreadExecState):
bindings/js/JSDOMGlobalObject.cpp:
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMObject::JSDOMObject):
bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpArrayBufferView): (WebCore::CloneSerializer::toJSArrayBuffer):

LayoutTests:

Activate private browsing mode for these two tests.

crypto/subtle/rsa-indexeddb-non-exportable-private.html:
crypto/subtle/rsa-indexeddb-private.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239803] by Alan Coon

3 edits
1 add in branches/safari-607-branch

Cherry-pick r239731. rdar://problem/47158715

LLInt put_by_id uses the wrong load instruction for loading flags from the metadata
https://bugs.webkit.org/show_bug.cgi?id=193221

Reviewed by Mark Lam.

JSTests:

stress/put-by-id-flags.js: Added. (f): (g): (numberOfDFGCompiles):

Source/JavaScriptCore:

The flags are only 4 bytes, but were loaded with loadp. It used to work,
since the flags were followed by a 4-byte padding, but it broke after the
struct was compacted in r239626.

llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239802] by Alan Coon

2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r239715. rdar://problem/47158638

Crash in SWServer::Connection::resolveRegistrationReadyRequests
https://bugs.webkit.org/show_bug.cgi?id=193217

Reviewed by Chris Dumez.

As can be seen from the traces, SWServer might clear its connections HashMap in its destructor.
This might then trigger calling SWServer::resolveRegistrationReadyRequests.
This method is iterating on the connections HashMap which is being cleared.
To remove this problem, move the HashMap in a temporary variable and clear the temporary variable.

workers/service/server/SWServer.cpp: (WebCore::SWServer::~SWServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239801] by Alan Coon

4 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r239711. rdar://problem/47158701

REGRESSION (r239519): ASSERTION FAILED: !m_adoptionIsRequired in com.apple.WebCore: void WTF::refIfNotNull<WebCore::CDMSessionMediaSourceAVFObjC> + 53
https://bugs.webkit.org/show_bug.cgi?id=193211
<rdar://problem/46937412>

Reviewed by Eric Carlson.

Make CDMSessionMediaSourceAVFObjC a CanMakeWeakPtr rather than RefCounted, as CDMSessions are stored in
std::unique_ptrs, and not in Ref or RefPtr.

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCDMSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239800] by Alan Coon

2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r239702. rdar://problem/47158664

Cleanup AudioTrackPrivateMediaStreamCocoa
https://bugs.webkit.org/show_bug.cgi?id=193208
<rdar://problem/42225870>

Reviewed by Youenn Fablet.

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp: (WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable): Clear input and output format descriptions after stopping the audio unit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239799] by Alan Coon

16 edits
2 adds in branches/safari-607-branch

Cherry-pick r239694. rdar://problem/47158722

Deactivate audio session whenever possible
https://bugs.webkit.org/show_bug.cgi?id=193188
<rdar://problem/42678977>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/deactivate-audio-session.html

platform/audio/AudioSession.cpp: (WebCore::AudioSession::tryToSetActive): (WebCore::AudioSession::tryToSetActiveInternal):
platform/audio/AudioSession.h: (WebCore::AudioSession::isActive const):

platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::removeSession): (WebCore::deactivateAudioSession): (WebCore::PlatformMediaSessionManager::shouldDeactivateAudioSession): (WebCore::PlatformMediaSessionManager::setShouldDeactivateAudioSession):
platform/audio/PlatformMediaSessionManager.h:

platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSession::tryToSetActiveInternal): (WebCore::AudioSession::tryToSetActive): Deleted.

platform/audio/mac/AudioSessionMac.cpp: (WebCore::AudioSession::tryToSetActiveInternal): (WebCore::AudioSession::tryToSetActive): Deleted.

testing/Internals.cpp: (WebCore::Internals::audioSessionActive const):
testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):

LayoutTests:

TestExpectations: Skip the new test.
media/deactivate-audio-session-expected.txt: Added.
media/deactivate-audio-session.html: Added.
platform/ios/TestExpectations: Run the new test.
platform/mac-wk2/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [239798] by Alan Coon

4 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r239691. rdar://problem/47158674

[Cocoa] Add SPI to check if a WKWebView has an inspector frontend
https://bugs.webkit.org/show_bug.cgi?id=193162
<rdar://problem/24267143>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-07
Reviewed by Alex Christensen.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _hasInspectorFrontend]):
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::hasInspectorFrontend const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:37 PM Changeset in webkit [239797] by Alan Coon

4 edits in branches/safari-607-branch

Cherry-pick r239688. rdar://problem/47158770

A MediaTime timescale must never be zero
https://bugs.webkit.org/show_bug.cgi?id=193156
<rdar://problem/32504501>

Reviewed by Jer Noble.

Source/WTF:

wtf/MediaTime.cpp: (WTF::greatestCommonDivisor): ASSERT if either parameter or return value is zero. (WTF::MediaTime::MediaTime): Create +/- infinity if passed zero timescale. (WTF::MediaTime::createWithFloat): Ditto. (WTF::MediaTime::createWithDouble): Ditto. (WTF::MediaTime::setTimeScale): Ditto.

Tools:

TestWebKitAPI/Tests/WTF/MediaTime.cpp: (TestWebKitAPI::TEST): Add tests for zero timescale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:37 PM Changeset in webkit [239796] by Alan Coon

2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r239686. rdar://problem/47158659

Unwanted page navigation after showing & dismissing contextual menu with control-click
https://bugs.webkit.org/show_bug.cgi?id=192912
<rdar://problem/46318508>

Reviewed by Timothy Hatcher.

After the conversion to use a mouse event queue, this behavior was observed rarely, especially
when CPU is under load and lots of things are going on in the page. In other words, it's racy.

Based on NSEvent logging, it seems that when the system is under load, we simply take too long
to enter the nested runloop that AppKit uses to handle events when the context menu is present.
AppKit doesn't care whether or not the MouseDown triggered a nested runloop; on my machine it delivers
the MouseUp event about 130ms after the MouseDown event. If we haven't show the context menu in
that time, then the MouseUp is enqueued as a normal mouse event. If the Ctrl-click is on a link,
then the MouseUp will be interpreted by EventHandler as a click event, which in the simplest case
will initiate a main frame navigation. When the context menu is dismissed and the nested runloop
is torn down, the navigation IPC message is handled in UIProcess and the page navigates away.

We can't do much to change AppKit's inherently racy behavior, but we can avoid processing
mouse events that are delivered whilst we are processing the context menu-initiating event.
From the WebProcess point of view, there is no race anymore because it does not receive the
MouseUp event.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showContextMenu): If new events come in, drop them on the floor. Based on testing, the nested runloop will discard the unpaired MouseUp event anyway, so this does not cause a change in behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:37 PM Changeset in webkit [239795] by Alan Coon

3 edits
1 move in branches/safari-607-branch/Tools

Cherry-pick r239676. rdar://problem/47158606

API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
https://bugs.webkit.org/show_bug.cgi?id=193175

Reviewed by Chris Dumez.

Updated API test as we bumped the SW schema to version 4.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm: (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:40 PM Changeset in webkit [239794] by Alan Coon

2 edits in branches/safari-607-branch/Source/JavaScriptCore

Apply patch. rdar://problem/47158817

4:34 PM Changeset in webkit [239793] by Alan Coon

3 edits in branches/safari-607-branch/Source/WebInspectorUI

Cherry-pick r239690. rdar://problem/47158814

Web Inspector: "white" isn't recognized as a color keyword
https://bugs.webkit.org/show_bug.cgi?id=193173
<rdar://problem/47068595>

Reviewed by Joseph Pecoraro.

Attempt to parse "atom" token types as colors.

Display color picker only for color-aware properties. For instance,
display it for "color: white" but not for "-apple-pay-button-style: white".

UserInterface/Models/CSSKeywordCompletions.js: (addKeywordsForName): (WI.CSSKeywordCompletions.forProperty): (WI.CSSKeywordCompletions.isColorAwareProperty):
UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype._renderValue): (WI.SpreadsheetStyleProperty.prototype._addColorTokens):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:31 PM Changeset in webkit [239792] by achristensen@apple.com

10 edits
1 copy in trunk/Source

Expand use of sourceApplicationAuditData
https://bugs.webkit.org/show_bug.cgi?id=192995
<rdar://problem/46627875>

Reviewed by Brady Eidson.

Source/WebKit:

sourceApplicationAuditData has been used for a long time on iOS, but it's needed on more platforms.
I also made it return an Optional instead of a bool and returning by reference. Ahhh. So much nicer.
The NetworkProcess needed an additional entitlement on Mac to continue to load anything, which is desirable.

NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::sourceApplicationAuditData const):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::getAuditToken):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::sourceApplicationAuditData const):

Source/WTF:

wtf/Platform.h:

4:19 PM Changeset in webkit [239791] by achristensen@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(239737) iOS quicklook tests should not dereference null
https://bugs.webkit.org/show_bug.cgi?id=193307

Reviewed by Brent Fulgham.

The quicklook tests rely on ResourceHandle on iOS for some reason.
This is a problem we'll fix later, but for now keep them working by not crashing.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
(WebCore::ResourceHandle::receivedCredential):

4:04 PM Changeset in webkit [239790] by Alan Coon

1 copy in tags/Safari-607.1.20

Tag Safari-607.1.20.

3:30 PM Changeset in webkit [239789] by ap@apple.com

3 edits in trunk/Tools

Tweak wording for build/version_check style checker error
https://bugs.webkit.org/show_bug.cgi?id=193256

Reviewed by Tim Horton.

Scripts/webkitpy/style/checkers/cpp.py:

(check_os_version_checks):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_os_version_checks):

3:03 PM Changeset in webkit [239788] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Restore bytecode dumper's ability to dump jump target as offset#(->targetBytecodeIndex#).
https://bugs.webkit.org/show_bug.cgi?id=193300

Reviewed by Saam Barati.

For example, instead of:

[ 95] jtrue loc11, 9

We can now again (as before the bytecode format rewrite) have:

[ 95] jtrue loc11, 9(->104)

bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::printLocationAndOp):

bytecode/BytecodeDumper.h:

(JSC::BytecodeDumper::dumpValue):

2:45 PM Changeset in webkit [239787] by mark.lam@apple.com

9 edits in trunk/Source

Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292
<rdar://problem/46485450>

Reviewed by Yusuke Suzuki.

Source/bmalloc:

Previously, when GIGACAGE_ALLOCATION_CAN_FAIL is true, we allow the Gigacage to
be disabled if we fail to allocate memory for it. However, Gigacage::primitiveGigacageDisabled()
still always assumes that the Gigacage is always enabled after ensureGigacage() is
called.

This patch updates Gigacage::primitiveGigacageDisabled() to allow the Gigacage to
already be disabled if GIGACAGE_ALLOCATION_CAN_FAIL is true and wasEnabled() is
false.

In this patch, we also put the wasEnabled flag in the 0th slot of the
g_gigacageBasePtrs buffer to ensure that it is also protected against writes just
like the Gigacage base pointers.

To achieve this, we do the following:

Added a reservedForFlags field in struct BasePtrs.
Added a ReservedForFlagsAndNotABasePtr Gigacage::Kind.
Added assertions to ensure that the BasePtrs::primitive is at the offset matching the offset computed from Gigacage::Primitive. Ditto for BasePtrs::jsValue and Gigacage::JSValue.
Added assertions to ensure that Gigacage::ReservedForFlagsAndNotABasePtr is not used for fetching a Gigacage base pointer.
Added RELEASE_BASSERT_NOT_REACHED() to implement such assertions in bmalloc.

No test added because this issue requires Gigacage allocation to fail in order to
manifest. I've tested it manually by modifying the code locally to force an
allocation failure.

bmalloc/BAssert.h:
bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::primitiveGigacageDisabled):

bmalloc/Gigacage.h:

(Gigacage::wasEnabled):
(Gigacage::setWasEnabled):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::size):

bmalloc/HeapKind.h:

(bmalloc::heapKind):

Source/JavaScriptCore:

runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

Source/WTF:

Update the USE_SYSTEM_MALLOC version of Gigacage.h to match the bmalloc version.

wtf/Gigacage.h:

2:25 PM Changeset in webkit [239786] by Alan Bujtas

5 edits
2 adds in trunk

[Datalist] Crash when input with datalist is dynamically added.
https://bugs.webkit.org/show_bug.cgi?id=193012
<rdar://problem/45923457>

Reviewed by Brent Fulgham.

Source/WebCore:

In certain cases (cloning, setAttribute), it's too early to check for the list attribute in createShadowSubtree
to see whether the input needs datalist related items. The list attribute is simply not set yet.
This patch only addresses the obvious crash. m_dataListDropdownIndicator clearly lacks proper lifecycle management (see webkit.org/b/193032).

Test: fast/forms/datalist/datalist-crash-when-dynamic.html

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::attributeChanged):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):

html/TextFieldInputType.h:

LayoutTests:

fast/forms/datalist/datalist-crash-when-dynamic-expected.txt: Added.
fast/forms/datalist/datalist-crash-when-dynamic.html: Added.

2:24 PM Changeset in webkit [239785] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] Add link to bug along with bug title
https://bugs.webkit.org/show_bug.cgi?id=193293

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/steps.py:

(ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
(ConfigureBuild.add_bug_id_url): Deleted.
(ConfigureBuild.getBugURL): Deleted.

2:08 PM Changeset in webkit [239784] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] Use https for ews-build server
https://bugs.webkit.org/show_bug.cgi?id=193193

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/steps.py:

1:59 PM Changeset in webkit [239783] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] Parse and display number of style failures
https://bugs.webkit.org/show_bug.cgi?id=193280

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/steps.py:

(CheckStyle): Use TestWithFailureCount as base class.
(CheckStyle.countFailures): Count the number of style failures.

1:56 PM Changeset in webkit [239782] by aakash_jain@apple.com

4 edits in trunk/Tools

[ews-build] use patch_id instead of ewspatchid
https://bugs.webkit.org/show_bug.cgi?id=193235

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
BuildSlaveSupport/ews-build/steps.py: Ditto.
BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.

12:47 PM Changeset in webkit [239781] by Alan Coon

2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r239776. rdar://problem/47147610

WebKit Networking process crashes if the HTTPSUpgradeList is not found in the bundle
https://bugs.webkit.org/show_bug.cgi?id=193285
<rdar://problem/47147610>

Reviewed by Geoffrey Garen.

NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: (WebKit::networkHTTPSUpgradeCheckerDatabasePath): (WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:05 PM Changeset in webkit [239780] by Justin Fan

6 edits in trunk

[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
https://bugs.webkit.org/show_bug.cgi?id=193289

Reviewed by Dean Jackson.

Source/WebCore:

Fix broken test after pipeline layouts were added, and a small refactoring to GPURenderPipeline to avoid
retaining its descriptor after creation.

platform/graphics/gpu/GPURenderPipeline.h:

(WebCore::GPURenderPipeline::primitiveTopology const):

platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::GPURenderPipeline::GPURenderPipeline):

LayoutTests:

Fix broken test after pipeline layouts were added.

webgpu/js/webgpu-functions.js:

(createBasicPipeline): Ensure pipeline layout is actually optional.

webgpu/vertex-buffer-triangle-strip.html:

11:38 AM Changeset in webkit [239779] by Devin Rousso

6 edits in trunk/Source

Web Inspector: Protocol Logging: log messages as objects if inspector^{2 is open

https://bugs.webkit.org/show_bug.cgi?id=193284}

Reviewed by Joseph Pecoraro.

Source/WebCore:

No newe tests, as this is simply exposes a value.

inspector/InspectorFrontendHost.idl:
inspector/InspectorFrontendHost.h:
inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::isBeingInspected): Added.

Source/WebInspectorUI:

If inspector^{2 is closed, stringify all messages.

If inspector}2 is open, log each message JSON object without modifying it.

UserInterface/Protocol/LoggingProtocolTracer.js:

(WI.LoggingProtocolTracer.prototype._processEntry):

11:05 AM Changeset in webkit [239778] by Brent Fulgham

2 edits in trunk/Source/WebKit

[iOS] Update sandbox profile to use iconservices instead of lsdiconservice
https://bugs.webkit.org/show_bug.cgi?id=193115
<rdar://problem/44867379>

Reviewed by Eric Carlson.

Add access to the 'com.apple.iconservices' endpoint. We will remove access to
the older name ('com.apple.lsdiconservices') once existing clients have completed
the switch.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

10:23 AM Changeset in webkit [239777] by Antti Koivisto

8 edits in trunk/Source/WebKit

[PSON] Flash of blank content while transitioning from page A to page B.
https://bugs.webkit.org/show_bug.cgi?id=193283

Reviewed by Chris Dumez.

Layer tree is not frozen during WebPage construction. If the flush timer (started for the initial
empty document) manages to run before the actual page load starts, we'll get a flash.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

Rename shouldDelayAttachingDrawingArea bit to isSwapFromSuspended and make it available on all platforms.

UIProcess/RemoteLayerTree/mac/ScrollerMac.h: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerPairMac.h: Removed.
UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm: Removed.
UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp: Removed.
UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::swapToWebProcess):
(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldAttachDrawingAreaOnPageTransition):

Freeze the layer tree in WebPage constructor if this is a swap from a suspended process.

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::didCompletePageTransition):

Unfreeze on first non-initial empty document page transition.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

10:09 AM Changeset in webkit [239776] by Chris Dumez

2 edits in trunk/Source/WebKit

WebKit Networking process crashes if the HTTPSUpgradeList is not found in the bundle
https://bugs.webkit.org/show_bug.cgi?id=193285
<rdar://problem/47147610>

Reviewed by Geoffrey Garen.

NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:

(WebKit::networkHTTPSUpgradeCheckerDatabasePath):
(WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):

10:03 AM Changeset in webkit [239775] by Alan Coon

7 edits in branches/safari-607-branch/Source

Versioning.

9:40 AM Changeset in webkit [239774] by keith_miller@apple.com

7 edits in trunk/Source/JavaScriptCore

builtins should be able to use async/await
https://bugs.webkit.org/show_bug.cgi?id=193263

Reviewed by Saam Barati.

This patch makes it possible to use async functions when writing builtin JS code.

Scripts/wkbuiltins/builtins_generator.py:

(BuiltinsGenerator.generate_embedded_code_string_section_for_function):

Scripts/wkbuiltins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):
(BuiltinFunction.str):

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

builtins/ModuleLoader.js:

(requestInstantiate):
(async.loadModule):
(async.loadAndEvaluateModule):
(async.requestImportModule):
(loadModule): Deleted.
(): Deleted.
(loadAndEvaluateModule): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

8:08 AM Changeset in webkit [239773] by Alan Bujtas

15 edits in trunk

[LFC][BFC][MarginCollapsing] Add support for peculiar cases.
https://bugs.webkit.org/show_bug.cgi?id=192625

Reviewed by Antti Koivisto.

Source/WebCore:

Implement some of the more peculiar cases like margin collpasing through multiple boxes etc.
Add ~100 new passing cases.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

layout/LayoutState.h:

(WebCore::Layout::LayoutState::hasFormattingState const):

layout/MarginTypes.h:
layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const):
(WebCore::Layout::hasPrecomputedMarginBefore):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::blockFormattingState const):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginAfter): Deleted.

layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginAfter):
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight): Deleted.

layout/blockformatting/BlockFormattingState.h:

(WebCore::Layout::BlockFormattingState::setPositiveAndNegativeVerticalMargin):
(WebCore::Layout::BlockFormattingState::hasPositiveAndNegativeVerticalMargin const):
(WebCore::Layout::BlockFormattingState::positiveAndNegativeVerticalMargin const):
(WebCore::Layout::BlockFormattingState::setHasEstimatedMarginBefore):
(WebCore::Layout::BlockFormattingState::clearHasEstimatedMarginBefore):
(WebCore::Layout::BlockFormattingState::hasEstimatedMarginBefore const):

layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::hasClearance):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSiblingMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
(WebCore::Layout::computedPositiveAndNegativeMargin):
(WebCore::Layout::marginValue):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateCollapsedMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBeforeFromFirstChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginAfterFromLastChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfter): Deleted.

layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):

layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::hasClearance const):
(WebCore::Display::Box::setEstimatedMarginBefore):
(WebCore::Display::Box::estimatedMarginBefore const):
(WebCore::Display::Box::setHasClearance):
(WebCore::Display::Box::invalidateEstimatedMarginBefore):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::rectWithMargin const):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

7:30 AM Changeset in webkit [239772] by Michael Catanzaro

57 edits in trunk/Tools

[WPE][GTK] Purge use of g_assert() under TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=192841

Reviewed by Carlos Garcia Campos.

There are separate g_assert_*() macros for use in tests, which we use inconsistently
currently. Use them always. We'll get nicer error messages now when tests fail, and the
assertions will now run during tests even if G_DISABLE_ASSERT is used when building.

Note that the documentation of g_assert() says that it is not to be used when writing tests.

TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:

(WebKitWebEditorTest::testSelectionChanged):

TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:

(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::testJavaScriptValues):

TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(testWebViewAuthenticationRequest):
(testWebViewAuthenticationLoadCancelled):
(testWebViewAuthenticationFailure):
(testWebViewAuthenticationStorage):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionRequestSession):

TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:

(testBackForwardListNavigation):
(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):

TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:

(ConsoleMessageTest::consoleMessageReceivedCallback):
(testWebKitConsoleMessageConsoleAPI):
(testWebKitConsoleMessageJavaScriptException):
(testWebKitConsoleMessageNetworkError):
(testWebKitConsoleMessageSecurityError):

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerAcceptPolicy):
(testCookieManagerCookiesChanged):
(testCookieManagerPersistentStorage):
(testCookieManagerPersistentStorageDeleteAll):
(testCookieManagerEphemeral):

TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:

(testWebKitDOMElementAutoFill):

TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(downloadLocalFileSuccessfully):
(createFileAtDestination):
(testDownloadOverwriteDestinationDisallowed):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(testDownloadMIMEType):
(contextMenuCallback):
(testContextMenuDownloadActions):
(testBlobDownload):

TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:

(testWebKitWebEditorSelectionChanged):

TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:

(testWebKitFrameMainFrame):
(testWebKitFrameURI):
(testWebKitFrameJavaScriptContext):
(testWebKitFrameJavaScriptValues):

TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(LoadStopTrackingTest::loadFailed):
(testWebViewTitle):
(testURIRequestHTTPHeaders):
(testURIRequestHTTPMethod):
(testURIResponseHTTPHeaders):
(testRedirectToDataURI):

TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:

(testProcessPerWebView):
(testWebProcessLimit):

TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:

(testWebViewResources):
(testWebResourceLoading):
(testWebResourceSuggestedFilename):
(testWebResourceGetData):
(testWebResourceGetDataError):
(testWebViewResourcesHistoryCache):
(testWebResourceSendRequest):

TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:

(testSSL):
(testInsecureContent):
(testTLSErrorsPolicy):
(testTLSErrorsRedirect):
(testTLSErrorsHTTPAuth):
(testLoadFailedWithTLSErrors):
(testSubresourceLoadFailedWithTLSErrors):
(httpsServerCallback):

TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:

(testWebViewCreateNavigationData):
(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
(testWebViewMouseTarget):
(testWebViewFileChooserRequest):
(testWebViewColorChooserRequest):

TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionGetTitle):
(testDocumentLoadedSignal):
(testWebKitWebViewProcessCrashed):
(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):
(permissionRequestCallback):
(didAssociateFormControlsCallback):
(testWebExtensionFormControlsAssociated):
(FormSubmissionTest::FormSubmissionTest):
(FormSubmissionTest::testFormSubmissionResult):
(testWebExtensionFormSubmissionSteps):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:

(testNotInitialized):
(testClearDatabase):
(testPrivateBrowsing):
(testGetFavicon):
(testWebViewFavicon):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:

(testFindControllerTextFound):
(testFindControllerTextNotFound):
(testFindControllerMatchCount):
(testFindControllerMaxMatchCount):
(testFindControllerNext):
(testFindControllerPrevious):
(testFindControllerCountedMatches):
(testFindControllerOptions):
(testFindControllerHide):
(testFindControllerInstance):
(testFindControllerGetters):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:

(testNavigationPolicy):
(testResponsePolicy):
(testNewWindowPolicy):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:

(testSecurityOriginBasicConstructor):
(testSecurityOriginURIConstructor):
(testSecurityOriginDefaultPort):
(testSecurityOriginFileURI):
(testOpaqueSecurityOrigin):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):
(testWebKitSettingsNewWithSettings):
(testWebKitSettingsUserAgent):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:

(testWebViewNewWithUserContentManager):
(isStyleSheetInjectedForURLAtPath):
(isScriptInjectedForURLAtPath):
(testUserContentManagerInjectedStyleSheet):
(testUserContentManagerInjectedScript):
(UserScriptMessageTest::scriptMessageReceived):
(UserScriptMessageTest::waitUntilMessageReceived):
(UserScriptMessageTest::runJavaScriptFinished):
(testUserContentManagerScriptMessageReceived):
(testUserContentManagerScriptMessageInWorldReceived):
(testUserContentManagerScriptMessageFromDOMBindings):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextDefault):
(testWebContextEphemeral):
(testWebContextGetPlugins):
(testWebContextURIScheme):
(testWebContextSpellChecker):
(testWebContextLanguages):
(consoleMessageReceivedCallback):
(testWebContextSecurityFileXHR):
(ProxyTest::ProxyTest):
(testWebContextProxySettings):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewWebContext):
(testWebViewWebBackend):
(testWebViewEphemeral):
(testWebViewCustomCharset):
(testWebViewSettings):
(testWebViewRunJavaScript):
(testWebViewCanShowMIMEType):
(testWebViewSubmitForm):
(testWebViewSave):
(testWebViewPageVisibility):
(testWebViewSnapshot):
(testWebViewNotification):
(testWebViewNotificationInitialPermissionAllowed):
(testWebViewNotificationInitialPermissionDisallowed):
(testWebViewIsPlayingAudio):

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(WebsiteDataTest::WebsiteDataTest):
(WebsiteDataTest::remove):
(WebsiteDataTest::clear):
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(testWebsiteDataCache):
(testWebsiteDataStorage):
(testWebsiteDataDatabases):
(testWebsiteDataAppcache):
(testWebsiteDataCookies):
(testWebsiteDataDeviceIdHashSalt):

TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(emitDocumentLoaded):
(emitURIChanged):
(sendRequestCallback):
(contextMenuCallback):
(consoleMessageSentCallback):
(emitFormControlsAssociated):
(formControlsAssociatedCallback):
(emitFormSubmissionEvent):
(willSubmitFormCallback):
(windowObjectCleared):
(methodCallCallback):
(registerGResource):
(webkit_web_extension_initialize_with_user_data):

TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:

(checkLeaks):
(WebProcessTest::create):
(runTest):

TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:

(AutocleanupsTest::testWebProcessAutocleanups):

TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:

(WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
(WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):

TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:

(WebKitDOMDOMWindowTest::testSignals):
(WebKitDOMDOMWindowTest::testDispatchEvent):
(WebKitDOMDOMWindowTest::testGetComputedStyle):

TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:

(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):

TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(WebKitDOMNodeTest::testDOMCache):

TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:

(WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):

TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:

(testUIProcessAutocleanups):
(testWebProcessAutocleanups):

TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

(testContextMenuPopulateMenu):
(testContextMenuDismissed):

TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:

(testWebKitDOMClientRectDivBoundingClientRectPosition):
(testWebKitDOMClientRectDivClientRectsPositionAndLength):

TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:

(testWebKitDOMDOMWindowSignals):
(testWebKitDOMDOMWindowDispatchEvent):
(testWebKitDOMDOMWindowGetComputedStyle):

TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:

(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(testWebKitDOMObjectCache):

TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:

(testWebKitDOMNodeFilterTreeWalker):
(testWebKitDOMNodeFilterNodeIterator):

TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:

(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):

TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:

(testInspectorDefault):
(testInspectorManualAttachDetach):
(testInspectorCustomContainerDestroyed):

TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:

(startTestServer):
(testInspectorServerPageList):

TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:

(OptionMenuTest::showOptionMenuCallback):
(OptionMenuTest::menuCloseCallback):
(OptionMenuTest::close):
(OptionMenuTest::activateItem):
(OptionMenuTest::selectItem):
(testOptionMenuSimple):
(testOptionMenuGroups):
(testOptionMenuActivate):
(testOptionMenuSelect):

TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:

(testPrintOperationPrintSettings):
(webViewPrintCallback):
(testPrintOperationPrint):
(testPrintCustomWidget):

TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(checkAtspiAccessible):
(testAtspiBasicHierarchy):

TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:

(testWebKitCheckVersion):

TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:

(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(testWebViewEditorSelectAllNonEditable):
(testWebViewEditorSelectAllEditable):
(loadContentsAndTryToCutSelection):
(testWebViewEditorNonEditable):
(testWebViewEditorEditable):
(testWebViewEditorEditorStateTypingAttributes):
(testWebViewEditorInsertImage):
(testWebViewEditorCreateLink):

TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:

(loadChangedCallback):
(loadFailedCallback):
(loadFailedWithTLSErrorsCallback):
(LoadTrackingTest::LoadTrackingTest):

TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:

(registerGResource):
(removeNonEmptyDirectory):

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::adoptView):
(Test::~Test):

TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:

(WebKitTestBus::getOrCreateConnection):
(WebKitTestBus::createProxy):

TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:

(WebKitTestServer::getWebSocketURIForPath const):

TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):
(WebViewTest::loadURI):
(WebViewTest::loadHtml):
(WebViewTest::loadPlainText):
(WebViewTest::loadBytes):
(WebViewTest::loadRequest):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):
(resourceGetDataCallback):
(WebViewTest::mainResourceData):
(WebViewTest::javascriptResultToCString):
(WebViewTest::javascriptResultToNumber):
(WebViewTest::javascriptResultToBoolean):
(WebViewTest::javascriptResultIsNull):
(WebViewTest::javascriptResultIsUndefined):
(onSnapshotReady):
(WebViewTest::runWebProcessTest):

TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::platformInitializeWebView):
(WebViewTest::showInWindow):
(WebViewTest::showInWindowAndWaitUntilMapped):
(WebViewTest::mouseMoveTo):
(WebViewTest::emitPopupMenuSignal):
(WebViewTest::keyStroke):
(WebViewTest::doMouseButtonEvent):

7:24 AM Changeset in webkit [239771] by Wenson Hsieh

2 edits in trunk/LayoutTests

[iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation
https://bugs.webkit.org/show_bug.cgi?id=193238

Reviewed by Megan Gardner.

Fix a flaky layout test that currently attempts to run the main logic of the test twice (once after the child
frame finishes loading, and another time after the main document finishes loading). This leads to a race
condition in the test where the incorrect text field is focused, causing the caret rect to deviate from the
expected value.

editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html:

7:08 AM Changeset in webkit [239770] by Michael Catanzaro

2 edits in trunk/Source/WebKit

[GTK] Add missing autocleanups
https://bugs.webkit.org/show_bug.cgi?id=193068

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/WebKitAutocleanups.h:

4:42 AM Changeset in webkit [239769] by Carlos Garcia Campos

15 edits in trunk/LayoutTests

Unreviewed, rolling out r239565.

Rebaseline was not correct, changes were due to
webkit.org/b/193276

Reverted changeset:

"Unreviewed GTK+ gardening. Rebaseline several tests after
r239156."
https://trac.webkit.org/changeset/239565

4:39 AM Changeset in webkit [239768] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

REGRESSION(r239156): [FreeType] fixed width, and synthetic bold/italic not correctly applied since r239156
https://bugs.webkit.org/show_bug.cgi?id=193276

Reviewed by Žan Doberšek.

FontCache::createFontPlatformData() is calling getFontPropertiesFromPattern() with the configure pattern instead
of the result one after the match.

platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::createFontPlatformData):

2:59 AM Changeset in webkit [239767] by Philippe Normand

3 edits in trunk/Tools

[WPE] API tests can't run in flatpak environment
https://bugs.webkit.org/show_bug.cgi?id=193242

Reviewed by Michael Catanzaro.

Scripts/run-wpe-tests: Add --wpe to arguments passed to

flatpakutils so that it knows which port it's dealing with.

glib/common.py: Remove build_dir globals so that subsequent

calls actually take args into account.
(library_build_path):
(binary_build_path):

12:34 AM Changeset in webkit [239766] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: clicking on property that soon to be discarded shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=193218
<rdar://problem/47098303>

Reviewed by Devin Rousso.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
A style property may get removed on blur event, so propertyElement may get removed from the DOM right when mousedown event happens.

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._stopSelection):

Jan 8, 2019:

10:35 PM Changeset in webkit [239765] by bshafiei@apple.com

1 copy in tags/Safari-606.4.5.2.2

Tag Safari-606.4.5.2.2.

10:31 PM Changeset in webkit [239764] by bshafiei@apple.com

2 edits in branches/safari-606.4.5.2-branch/Source/WebCore

Apply patch. rdar://problem/47109691

10:26 PM Changeset in webkit [239763] by bshafiei@apple.com

7 edits in branches/safari-606.4.5.2-branch/Source

Versioning.

7:29 PM Changeset in webkit [239762] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Undo reverts all changes at once
https://bugs.webkit.org/show_bug.cgi?id=177676
<rdar://problem/34745031>

Reviewed by Devin Rousso.

Command-Z used to revert all changes at once because Web Inspector never
set any history checkpoints in the style editor.

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):

UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._handleBlur):

6:56 PM Changeset in webkit [239761] by yusukesuzuki@slowstart.org

35 edits
2 adds in trunk

Array.prototype.flat/flatMap have a minor bug in ArraySpeciesCreate
https://bugs.webkit.org/show_bug.cgi?id=193127

Reviewed by Saam Barati.

JSTests:

stress/array-species-create-should-handle-masquerader.js: Added.

(shouldThrow):

stress/is-undefined-or-null-builtin.js: Added.

(shouldBe):
(isUndefinedOrNull.vm.createBuiltin):

Source/JavaScriptCore:

== null is frequently used idiom to check null or undefined in JS.
However, it has a problem in terms of the builtin JS implementation: it
returns true if masquerade-as-undefined objects (e.g. document.all) come.

In this patch, we introduce a convenient builtin intrinsic @isUndefinedOrNull,
which is equivalent to C++ JSValue::isUndefinedOrNull. It does not consider
about masquerade-as-undefined objects, so that we can use it instead of
value === null || value === @undefined. We introduce is_undefined_or_null
bytecode, IsUndefinedOrNull DFG node and its DFG and FTL backends. Since
Null and Undefined have some bit patterns, we can implement this query
very efficiently.

builtins/ArrayIteratorPrototype.js:

(next):

builtins/ArrayPrototype.js:

(globalPrivate.arraySpeciesCreate):

builtins/GlobalOperations.js:

(globalPrivate.speciesConstructor):
(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):

builtins/MapIteratorPrototype.js:

(next):

builtins/SetIteratorPrototype.js:

(next):

builtins/StringIteratorPrototype.js:

(next):

builtins/StringPrototype.js:

(match):
(repeat):
(padStart):
(padEnd):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(search):
(split):
(concat):
(globalPrivate.createHTML):

builtins/TypedArrayPrototype.js:

(globalPrivate.typedArraySpeciesConstructor):
(map):
(filter):

bytecode/BytecodeIntrinsicRegistry.h:
bytecode/BytecodeList.rb:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitIsUndefinedOrNull):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_isUndefinedOrNull):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsUndefinedOrNull):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined_or_null):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined_or_null):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

6:03 PM Changeset in webkit [239760] by Nikita Vasilyev

75 edits in trunk/Source/WebInspectorUI

Web Inspector: Use prefers-color-scheme instead of prefers-dark-interface
https://bugs.webkit.org/show_bug.cgi?id=193265

Reviewed by Timothy Hatcher.

UserInterface/Views/AuditTestContentView.css: