Context Navigation

← Previous Period
Next Period →

Timeline

Jan 12, 2019:

9:54 PM Changeset in webkit [239904] by timothy@apple.com

27 edits
7 adds in trunk

Have prefers-color-scheme: light always match on macOS versions before Mojave.
https://bugs.webkit.org/show_bug.cgi?id=191655
rdar://problem/46074680

Reviewed by Megan Gardner.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.

Source/WebCore:

Tests: css-dark-mode/older-systems/prefers-color-scheme.html

css-dark-mode/older-systems/supported-color-schemes-css.html
css-dark-mode/older-systems/supported-color-schemes.html

Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code.
Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems.

Configurations/FeatureDefines.xcconfig:
dom/Document.cpp:

(WebCore::Document::useDarkAppearance const):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::enable):

page/Page.cpp:

(WebCore::Page::setUseDarkAppearance):
(WebCore::Page::useDarkAppearance const):
(WebCore::Page::setUseDarkAppearanceOverride):

platform/mac/LocalDefaultSystemAppearance.h:

(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const):

platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):

platform/mac/ScrollAnimatorMac.mm:
rendering/RenderThemeMac.mm:

(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
(-[WebListButtonCell drawWithFrame:inView:]):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::systemColor const):

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.

Source/WebKit:

Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::effectiveAppearanceIsDark):

UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
WebView/WebView.mm:

(-[WebView _effectiveAppearanceIsDark]):

Source/WTF:

wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14.

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:

LayoutTests:

css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added.
css-dark-mode/older-systems/prefers-color-scheme.html: Added.
css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added.
css-dark-mode/older-systems/supported-color-schemes-css.html: Added.
css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added.
css-dark-mode/older-systems/supported-color-schemes.html: Added.
platform/mac/TestExpectations:

3:52 PM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

1:28 PM Changeset in webkit [239903] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC] Block/InlinFormattingContext should take Block/InlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=193383

Reviewed by Antti Koivisto.

This is just a downcast really.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::formattingState const): Deleted.

layout/FormattingContext.h:
layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::createFormattingContext):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::BlockFormattingContext):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::formattingState const):
(WebCore::Layout::BlockFormattingContext::blockFormattingState const): Deleted.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::createFinalRuns const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::formattingState const):
(WebCore::Layout::InlineFormattingContext::inlineFormattingState const): Deleted.

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

12:56 PM Changeset in webkit [239902] by mmaxfield@apple.com

11 edits
7 copies
7 adds in trunk/Source/WebCore

[WHLSL] Add native function synthesis passes
https://bugs.webkit.org/show_bug.cgi?id=193360

Reviewed by Dean Jackson.

This patch includes all the passes in prepare() that are between the name resolver and the
type checker. It involves a few small pieces:

CheckDuplicateFunctions which makes sure the same function isn't defined twice
Intrinsics, which remembers all of the native types so they can be referred to by the rest of the compiler
RecursiveTypeChecker which makes sure types don't refer to themselves
SynthesizeArrayOperatorLength which creates operator.length() functions for arrays
SynthesizeConstructors which creates copy constructors and default constructors for all types
SynthesizeEnumerationFunctions which provides cast operators between enum types and their base types
SynthesizeStructureAccessors which provides getters, setters, and anders for each member of a struct

No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
of test. When enough of the compiler is present, I'll port the reference implementation's test suite.

Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:

(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):

Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:

(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):

Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp: Added.

(WebCore::WHLSL::checkDuplicateFunctions):

Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp: Added.

(WebCore::WHLSL::Intrinsics::Intrinsics):
(WebCore::WHLSL::Intrinsics::add):
(WebCore::WHLSL::Intrinsics::addPrimitive):
(WebCore::WHLSL::Intrinsics::addVector):
(WebCore::WHLSL::Intrinsics::addMatrix):
(WebCore::WHLSL::Intrinsics::addFullTexture):
(WebCore::WHLSL::Intrinsics::addDepthTexture):
(WebCore::WHLSL::Intrinsics::addTexture):

Modules/webgpu/WHLSL/WHLSLIntrinsics.h: Added.

(WebCore::WHLSL::Intrinsics::voidType const):
(WebCore::WHLSL::Intrinsics::boolType const):
(WebCore::WHLSL::Intrinsics::intType const):
(WebCore::WHLSL::Intrinsics::uintType const):
(WebCore::WHLSL::Intrinsics::samplerType const):
(WebCore::WHLSL::Intrinsics::floatType const):
(WebCore::WHLSL::Intrinsics::float3Type const):
(WebCore::WHLSL::Intrinsics::float4Type const):

Modules/webgpu/WHLSL/WHLSLProgram.h:

(WebCore::WHLSL::Program::append):
(WebCore::WHLSL::Program::intrinsics):

Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp: Added.

(WebCore::WHLSL::checkRecursiveTypes):

Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp: Added.

(WebCore::WHLSL::FindArrayTypes::takeArrayTypes):
(WebCore::WHLSL::synthesizeArrayOperatorLength):

Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp: Added.

(WebCore::WHLSL::FindAllTypes::takeUnnamedTypes):
(WebCore::WHLSL::FindAllTypes::takeNamedTypes):
(WebCore::WHLSL::synthesizeConstructors):

Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp: Added.

(WebCore::WHLSL::synthesizeEnumerationFunctions):

Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp: Added.

(WebCore::WHLSL::synthesizeStructureAccessors):

Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

12:36 PM Changeset in webkit [239901] by mitz@apple.com

39 edits in trunk

[Cocoa] Avoid importing directly from subumbrella frameworks
https://bugs.webkit.org/show_bug.cgi?id=186016
<rdar://problem/40591038>

Reviewed by Sam Weinig.

Source/WebCore:

Configurations/WebCore.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
editing/mac/DictionaryLookupLegacy.mm: Import Quartz.h instead of a PDFKit header.
platform/mac/PlatformEventFactoryMac.mm: Import Carbon.h instead of HIToolbox headers.
platform/text/mac/TextEncodingRegistryMac.mm: Import Carbon.h instead of CarbonCore.h.

Source/WebCore/PAL:

Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.

Source/WebKit:

Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
UIProcess/Automation/mac/WebAutomationSessionMac.mm: Import Carbon.h instead of an HIToolbox header.
UIProcess/Cocoa/WebViewImpl.mm: Ditto.
UIProcess/mac/WKPrintingView.mm: Import Quartz.h instead of a PDFKit header.
UIProcess/mac/WKTextInputWindowController.mm: Import Carbon.h instead of an HIToolbox header.
WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h: Import Quartz.h instead of a PDFKit header.
WebProcess/Plugins/PDF/PDFLayerControllerSPI.h: Ditto.
WebProcess/Plugins/PDF/PDFPlugin.mm: Ditto.
WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: Ditto.
WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: Ditto.
WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Ditto.
WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: Ditto.
WebProcess/WebPage/mac/WebPageMac.mm: Ditto.

Source/WebKitLegacy/mac:

Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
Carbon/CarbonWindowAdapter.mm: Ditto.
Carbon/CarbonWindowFrame.m: Ditto.
Carbon/HIViewAdapter.h: Ditto.
Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS_COCOA_TOUCH_NO.
Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
WebView/WebPDFView.h: Ditto.

Tools:

DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a LaunchServices header.
DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h when using SDKs earlier than 10.13.
TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a LaunchServices header.

8:56 AM Changeset in webkit [239900] by Alan Bujtas

12 edits in trunk/Source/WebCore

[LFC] Move formatting context creation from FormattingState to LayoutState
https://bugs.webkit.org/show_bug.cgi?id=193381

Reviewed by Antti Koivisto.

layoutState().createFormattingStateForFormattingRootIfNeeded(root).createFormattingContext(root) is not only mouthful
but also feels unintuitive. Use layoutState().createFormattingContext(root) instead.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::~FormattingContext):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

layout/FormattingState.h:
layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::createFormattingContext):

layout/LayoutState.h:

(WebCore::Layout::LayoutState::deregisterFormattingContext):
(WebCore::Layout::LayoutState::registerFormattingContext):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::createFormattingContext): Deleted.

layout/blockformatting/BlockFormattingState.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::createFormattingContext): Deleted.

layout/inlineformatting/InlineFormattingState.h:

7:30 AM Changeset in webkit [239899] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC][BFC][MarginCollapsing] Move estimatedMarginBefore flag from state/display box to BlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=193375

Reviewed by Antti Koivisto.

The estimated marginBefore is a pre-computed, temporary value. We need to keep it around until the final vertical margin value is computed.
Neither BlockFormattingState nor Display should hold temporary values.

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const):
(WebCore::Layout::BlockFormattingContext::hasPrecomputedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::setEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::hasEstimatedMarginBefore const):
(WebCore::Layout::hasPrecomputedMarginBefore): Deleted.

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::removeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::estimatedMarginBefore const):

layout/blockformatting/BlockFormattingState.h:

(WebCore::Layout::BlockFormattingState::setHasEstimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingState::clearHasEstimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingState::hasEstimatedMarginBefore const): Deleted.

layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):

layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::setHasEstimatedMarginBefore):
(WebCore::Display::Box::invalidateEstimatedMarginBefore):
(WebCore::Display::Box::top const):
(WebCore::Display::Box::topLeft const):
(WebCore::Display::Box::setEstimatedMarginBefore): Deleted.
(WebCore::Display::Box::estimatedMarginBefore const): Deleted.

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

1:49 AM Changeset in webkit [239898] by yusukesuzuki@slowstart.org

4 edits in trunk/Source/JavaScriptCore

Unreviewed, fix scope check assertions
https://bugs.webkit.org/show_bug.cgi?id=193308

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::notifyLexicalBindingShadowing):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::notifyLexicalBindingShadowing):

runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

Jan 11, 2019:

11:42 PM Changeset in webkit [239897] by rniwa@webkit.org

4 edits in trunk/Source

Enable visual viewport API by default
https://bugs.webkit.org/show_bug.cgi?id=193376

Reviewed by Simon Fraser.

Source/WebKit:

Enable this feature by default since the remaining issue on iOS is mostly about test failures,
not an issue with the core functionality of the API.

Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

10:26 PM Changeset in webkit [239896] by mmaxfield@apple.com

12 edits
5 copies
4 adds in trunk/Source/WebCore

[WHLSL] Implement the NameResolver
https://bugs.webkit.org/show_bug.cgi?id=193007

Reviewed by Dean Jackson.

This is the base implementation for WHLSL's name resolver. The name resolver matches three kinds of things:

It matches VariableRefs to VariableDecls
It matches TypeRefs to NamedTypes
It matches CallExpressions to FunctionDeclarations

Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp: Now that InferTypes.h exists, we can implement these

functions.
(WebCore::WHLSL::AST::FloatLiteralType::canResolve const):
(WebCore::WHLSL::AST::FloatLiteralType::conversionCost const):

Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h: Remove unnecessary function.

(WebCore::WHLSL::AST::FloatLiteralType::value const): Deleted.

Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp: Now that InferTypes.h exists, we can implement these

functions.
(WebCore::WHLSL::AST::IntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::IntegerLiteralType::conversionCost const):

Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h: Remove unnecessary function.

(WebCore::WHLSL::AST::IntegerLiteralType::value const): Deleted.

Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp: Modifying Sources.txt caused the sources

to get shuffled around, so the #includes need to be fixed.

Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp: Now that InferTypes.h exists, we can implement

these functions.
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::conversionCost const):

Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h: Remove unnecessary function.

(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::value const): Deleted.

Modules/webgpu/WHLSL/WHLSLInferTypes.cpp: Added. This is the replacement for UnificationContext in the

reference compiler. It's much simpler (and we should remove UnificationContext in the reference compiler in
favor of this design). It has three sets of functions: Tell if two types are the same, tell if two types are
the same and commit the resolvable type, and run the above functions on type references or function arguments.
(WebCore::WHLSL::matches):
(WebCore::WHLSL::matchAndCommit):
(WebCore::WHLSL::commit):
(WebCore::WHLSL::inferTypesForTypeArguments):
(WebCore::WHLSL::inferTypesForCall):

Modules/webgpu/WHLSL/WHLSLInferTypes.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp.
Modules/webgpu/WHLSL/WHLSLNameContext.cpp: Added. This is the data structure that remembers NamedTypes,

FunctionDeclarations, and VariableDeclarations so NameResolver can work.
(WebCore::WHLSL::NameContext::NameContext):
(WebCore::WHLSL::NameContext::add):
(WebCore::WHLSL::NameContext::getTypes):
(WebCore::WHLSL::NameContext::getFunctions):
(WebCore::WHLSL::NameContext::getVariable):
(WebCore::WHLSL::NameContext::exists):

Modules/webgpu/WHLSL/WHLSLNameContext.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h.
Modules/webgpu/WHLSL/WHLSLNameResolver.cpp: Added. Use the NameContext to match up the three types of names.

(WebCore::WHLSL::NameResolver::NameResolver):
(WebCore::WHLSL::NameResolver::visit):
(WebCore::WHLSL::resolveNamesInTypes):
(WebCore::WHLSL::resolveNamesInFunctions):

Modules/webgpu/WHLSL/WHLSLNameResolver.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h.

(WebCore::WHLSL::NameResolver::setCurrentFunctionDefinition):

Modules/webgpu/WHLSL/WHLSLProgram.h:

(WebCore::WHLSL::Program::append): The parser needs to add all global declarations to the name context so the
name resolver is ready to go as soon as parsing is finished.
(WebCore::WHLSL::Program::nameContext):

Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp: Added. Pick the appropriate FunctionDeclaration or

NamedType for a particular CallExpression or TypeReference.
(WebCore::WHLSL::conversionCost):
(WebCore::WHLSL::resolveFunctionOverloadImpl):
(WebCore::WHLSL::resolveTypeOverloadImpl):

Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp.
Modules/webgpu/WHLSL/WHLSLResolvingType.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp. This describes the two states that a type in the type resolver can be in: either an owned

UnnamedType, or a reference to a ResolvableType. This is because every expression needs to have a type
associated with it, but those types might be the type of a literal (aka a ResolvableType). Multiple
expressions might need to reference the same ResolvableType so when it gets resolved, all the expressions
get the result.
(WebCore::WHLSL::ResolvableTypeReference::ResolvableTypeReference):
(WebCore::WHLSL::ResolvableTypeReference::resolvableType):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

7:40 PM Changeset in webkit [239895] by Brent Fulgham

2 edits in trunk/Source/WebKit

Allow WebContent process access to some drawing-related IOKit properties
https://bugs.webkit.org/show_bug.cgi?id=193086
<rdar://problem/46568088>

Reviewed by Eric Carlson.

Add one missing IOKit property, and revise the regexp used for another.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

7:07 PM Changeset in webkit [239894] by ddkilzer@apple.com

2 edits in trunk/Source/WTF

Follow-up: WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350

wtf/WorkQueue.cpp:

(WTF::WorkQueue::concurrentApply): Fix whitespace.

6:46 PM Changeset in webkit [239893] by mmaxfield@apple.com

3 edits
2 adds in trunk/Source/WebCore

[WHLSL] Add a Visitor class
https://bugs.webkit.org/show_bug.cgi?id=192826

Reviewed by Dean Jackson.

This patch exposes a bunch of the private members of WHLSL's AST nodes so that Visitor can recurse on constituent nodes.
It also writes the recursion in Visitor.h. This is a virtual base class that gets subclassed for compiler passes.

I've split this part into its own patch to aid reviewing of the compiler.

Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
Modules/webgpu/WHLSL/WHLSLVisitor.cpp: Added.

(WebCore::WHLSL::Visitor::visit):
(WebCore::WHLSL::Visitor::checkErrorAndVisit):

Modules/webgpu/WHLSL/WHLSLVisitor.h: Added.

(WebCore::WHLSL::Visitor::setError):
(WebCore::WHLSL::Visitor::error const):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

5:50 PM Changeset in webkit [239892] by Alan Coon

10 edits
1 add in tags/Safari-607.1.20.1/Source

Cherry-pick r239792. rdar://problem/46627875

Expand use of sourceApplicationAuditData
https://bugs.webkit.org/show_bug.cgi?id=192995
<rdar://problem/46627875>

Reviewed by Brady Eidson.

Source/WebKit:

sourceApplicationAuditData has been used for a long time on iOS, but it's needed on more platforms.
I also made it return an Optional instead of a bool and returning by reference. Ahhh. So much nicer.
The NetworkProcess needed an additional entitlement on Mac to continue to load anything, which is desirable.

NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::sourceApplicationAuditData const):
Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm: (IPC::Connection::getAuditToken):
WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::sourceApplicationAuditData const):

Source/WTF:

wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:49 PM Changeset in webkit [239891] by Alan Coon

7 edits in tags/Safari-607.1.20.1/Source

Versioning.

5:25 PM Changeset in webkit [239890] by Alan Coon

1 copy in tags/Safari-607.1.20.1

New tag.

5:22 PM Changeset in webkit [239889] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

REGRESSION(r239419): Crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC()
https://bugs.webkit.org/show_bug.cgi?id=193342
<rdar://problem/47119836>

Reviewed by Eric Carlson.

Make the TapStorage used by AudioSourceProviderAVFObjC thread-safe RefCounted.

platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::initCallback):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):

5:13 PM Changeset in webkit [239888] by wilander@apple.com

19 edits in trunk

Compile out Web API Statistics Collection
https://bugs.webkit.org/show_bug.cgi?id=193370
<rdar://problem/45388584>

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Defined ENABLE_WEB_API_STATISTICS, off by default.

Source/WebCore:

No new tests. This patch disables functionality. The associated tests
are skipped.

These functions are now no-ops unless web API statistics is enabled.

Configurations/FeatureDefines.xcconfig:
loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logFontLoad):
(WebCore::ResourceLoadObserver::logCanvasRead):
(WebCore::ResourceLoadObserver::logCanvasWriteOrMeasure):
(WebCore::ResourceLoadObserver::logNavigatorAPIAccessed):
(WebCore::ResourceLoadObserver::logScreenAPIAccessed):

loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::encode const):
(WebCore::ResourceLoadStatistics::decode):
(WebCore::ResourceLoadStatistics::toString const):
(WebCore::ResourceLoadStatistics::merge):

loader/ResourceLoadStatistics.h:

The associated struct members are skipped unless web API
statistics is enabled.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Defined ENABLE_WEB_API_STATISTICS, off by default.

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Defined ENABLE_WEB_API_STATISTICS, off by default.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceLoadStatistics>::encode):

Skipped encoding of web API statistics.

(IPC::ArgumentCoder<ResourceLoadStatistics>::decode):

Skipped decoding of web API statistics.

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Defined ENABLE_WEB_API_STATISTICS, off by default.

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Defined ENABLE_WEB_API_STATISTICS, off by default.

LayoutTests:

platform/ios-wk2/TestExpectations:

http/tests/webAPIStatistics skipped.

platform/mac-wk2/TestExpectations:

http/tests/webAPIStatistics skipped.

5:11 PM Changeset in webkit [239887] by sihui_liu@apple.com

8 edits in trunk/Source

IndexedDB: leak WebIDBConnectionToClient for retain cycle
https://bugs.webkit.org/show_bug.cgi?id=193097
<rdar://problem/46899601>

Reviewed by Brady Eidson.

Source/WebCore:

Let IDBConnectionToClient hold a WeakPtr of IDBConnectionToClientDelegate.

Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::IDBConnectionToClient):
(WebCore::IDBServer::IDBConnectionToClient::identifier const):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteDatabase):
(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):
(WebCore::IDBServer::IDBConnectionToClient::didAbortTransaction):
(WebCore::IDBServer::IDBConnectionToClient::didCreateObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didRenameObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didClearObjectStore):
(WebCore::IDBServer::IDBConnectionToClient::didCreateIndex):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteIndex):
(WebCore::IDBServer::IDBConnectionToClient::didRenameIndex):
(WebCore::IDBServer::IDBConnectionToClient::didPutOrAdd):
(WebCore::IDBServer::IDBConnectionToClient::didGetRecord):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllRecords):
(WebCore::IDBServer::IDBConnectionToClient::didGetCount):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteRecord):
(WebCore::IDBServer::IDBConnectionToClient::didOpenCursor):
(WebCore::IDBServer::IDBConnectionToClient::didIterateCursor):
(WebCore::IDBServer::IDBConnectionToClient::didCommitTransaction):
(WebCore::IDBServer::IDBConnectionToClient::fireVersionChangeEvent):
(WebCore::IDBServer::IDBConnectionToClient::didStartTransaction):
(WebCore::IDBServer::IDBConnectionToClient::didCloseFromServer):
(WebCore::IDBServer::IDBConnectionToClient::notifyOpenDBRequestBlocked):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNames):

Modules/indexeddb/server/IDBConnectionToClient.h:
Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

Source/WebKit:

Let WebIDBConnectionToClient hold reference to IPC::Connection instead of NetworkConnectionToWebProcess to break
the cycle.

NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::messageSenderConnection):

NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::establishIDBConnectionToServer):

5:02 PM Changeset in webkit [239886] by commit-queue@webkit.org

3 edits in trunk/Tools

[WPE] Add gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=178900

Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2019-01-11
Reviewed by Michael Catanzaro.

Add Tools/gtkdoc to manifest.txt.in files.
This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.

gtk/manifest.txt.in: Add Tools/gtkdoc directory.
wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.

5:00 PM Changeset in webkit [239885] by sihui_liu@apple.com

2 edits in trunk/Source/WebKit

Make "Disable Web SQL" on by default
https://bugs.webkit.org/show_bug.cgi?id=193354
<rdar://problem/46524584>

Reviewed by Geoffrey Garen.

Shared/WebPreferences.yaml:

4:40 PM Changeset in webkit [239884] by Devin Rousso

6 edits in trunk/Source

Fix style CFNetworkSPI style checker warnings from r239698
https://bugs.webkit.org/show_bug.cgi?id=193369

Reviewed by Joseph Pecoraro.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

Source/WTF:

wtf/Platform.h:

4:39 PM Changeset in webkit [239883] by mmaxfield@apple.com

5 edits in trunk/Source/WebCore

Fix the build after r239844
https://bugs.webkit.org/show_bug.cgi?id=192991

Unreviewed.

Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:

4:26 PM Changeset in webkit [239882] by sbarati@apple.com

5 edits
1 add in trunk

DFG combined liveness can be wrong for terminal basic blocks
https://bugs.webkit.org/show_bug.cgi?id=193304
<rdar://problem/45268632>

Reviewed by Yusuke Suzuki.

JSTests:

stress/dfg-combined-liveness-consider-terminal-blocks-bytecode-liveness.js: Added.

Source/JavaScriptCore:

If a block doesn't have any successors, it can't rely on the typical
backwards liveness propagation that CombinedLiveness was doing. The phase
first got what was live in bytecode and IR at the heads of each block. Then
for each block, it made the live at tail the union of the live at head for
each successor. For a terminal block though, this could be wrong. We could
end up saying nothing is live even though many things may be live in bytecode.
We must account for what's bytecode live at the end of the block. Consider a
block that ends with:
`
ForceOSRExit
Unreachable
`

Things may definitely be live in bytecode at the tail. However, we'll
report nothing as being alive. This probably subtly breaks many analyses,
but we have a test case of it breaking the interference analysis that
the ArgumentsEliminationPhase performs.

dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::last const):

dfg/DFGCombinedLiveness.cpp:

(JSC::DFG::addBytecodeLiveness):
(JSC::DFG::liveNodesAtHead):
(JSC::DFG::CombinedLiveness::CombinedLiveness):

dfg/DFGCombinedLiveness.h:

4:21 PM Changeset in webkit [239881] by Wenson Hsieh

11 edits in trunk

[iOS] Precision drop state thrashes when dragging near the top edge of an editable element
https://bugs.webkit.org/show_bug.cgi?id=193364
<rdar://problem/47214117>

Reviewed by Tim Horton.

Source/WebCore:

Add a new helper method on DragCaretController to compute the bounds of the editable element around the drop
caret position. This is either the enclosing form control (in the case of text fields and text areas), or the
highest editable root. See WebKit ChangeLog for more details.

Test: DragAndDropTests.AvoidPreciseDropNearTopOfTextArea

editing/FrameSelection.cpp:

(WebCore::DragCaretController::editableElementRectInRootViewCoordinates const):

editing/FrameSelection.h:

Source/WebKit:

On iOS, marking a UIDropProposal as precise offsets the hit-testing location of the drop by a small distance
either upwards or downwards from the actual location of the user's finger. When dragging over an editable
element, WebKit currently marks the drop proposal as precise; however, when dragging over the top edge of an
editable element, what happens is that the hit-testing location is offset to a location outside of the editable
element, which causes us to turn off precision drop mode; subsequently, turning off precision drop mode removes
the offset, which causes us to hit-test within the editable element once again and re-enable precision mode, and
the cycle continues.

In order to mitigate this, bail out of precision drop mode when dragging near the top or bottom edges of the
highest editable root that contains the current drop caret position (or, if the drop caret is inside of a text
form control, use the form control as the editable element instead).

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformDragControllerAction):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::currentDragCaretEditableElementRect const):

UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView dropInteraction:sessionDidUpdate:]):

Avoid precise mode when we're less than 25pt away from the top and bottom edge of the editable element rect.
Since the drag location offset amount is a fixed offset in window coordinates, we first convert this minimum
distance to the content view's coordinate space by dividing by the content scale factor.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

Tools:

Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
precise, whereas dragging near the middle of the textarea does.

TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::TEST):

3:30 PM Changeset in webkit [239880] by timothy_horton@apple.com

7 edits in trunk/Source

REGRESSION (PSON): Firefox app lacks Open in New Tab in menu
https://bugs.webkit.org/show_bug.cgi?id=193366
<rdar://problem/46097212>

Reviewed by Simon Fraser.

Source/WebCore:

platform/RuntimeApplicationChecks.h:
platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isFirefox):
Add a Firefox Mobile bundle check.

Source/WebKit:

A pair of unrelated changes broke Firefox's use of WKWebView internals
to override the long-press menu. Maintain binary compatibility by
introducing linked-on-or-after checks.

UIProcess/Cocoa/VersionChecks.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):
Disable PSON in Firefox when linked against an SDK where PSON wasn't enabled by default.
Because gestures are very stateful, we always swap them out when swapping
processes (changing that behavior is fairly risky). Also, we don't always
inform the client when we swap processes (only when the process actually crashes),
so they currently don't re-adjust the gesture recognizers when a PSON swap occurs.

UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Synchronously install gesture recognizers under -init when linked against
an SDK before the version that introduces lazy gesture recognizer installation.
r237331 is an optimization that made us lazily install gestures when the
view is parented, but Firefox (and potentially other clients) depend
on them being installed synchronously in order to find and override them.

3:10 PM Changeset in webkit [239879] by yusukesuzuki@slowstart.org

16 edits
15 adds in trunk

[JSC] Global lexical bindings can shadow global variables if it is configurable = true
https://bugs.webkit.org/show_bug.cgi?id=193308
<rdar://problem/45546542>

Reviewed by Saam Barati.

JSTests:

stress/const-lexical-binding-shadow-existing-global-property-ftl.js: Added.

(shouldThrow):
(shouldBe):
(foo):
(get shouldThrow):

stress/const-lexical-binding-shadow-existing-global-property-tdz-ftl.js: Added.

(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):
(get return):

stress/const-lexical-binding-shadow-existing-global-property-tdz.js: Added.

(shouldThrow):
(shouldBe):
(foo):
(get shouldBe):
(get shouldThrow):

stress/const-lexical-binding-shadow-existing-global-property.js: Added.