Context Navigation

← Previous Period
Next Period →

Timeline

Jan 28, 2019:

11:55 PM Changeset in webkit [240647] by commit-queue@webkit.org

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler
https://bugs.webkit.org/show_bug.cgi?id=193921

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-28
Reviewed by Devin Rousso.

UserInterface/Base/Utilities.js:
UserInterface/Debug/UncaughtExceptionReporter.js:
UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._exportHAR):

UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.updateFormattedState):

11:15 PM Changeset in webkit [240646] by rniwa@webkit.org

12 edits in trunk

User agent string override for navigator.userAgent should be site specific quirks
https://bugs.webkit.org/show_bug.cgi?id=193950

Reviewed by Brent Fulgham.

Source/WebCore:

In order to make it possible to toggle the UA string override just for navigator.userAgent via Web Inspector,
we need to put this override behind the site specific quirks. Because WebInspector overrides Page's setting
without updating WKPreferences, there is no way for WKWebView client's to know whether the site specific quirks
had been disabled or not.

loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomJavaScriptUserAgentAsSiteSpecificQuirks):
(WebCore::DocumentLoader::customJavaScriptUserAgentAsSiteSpecificQuirks const):
(WebCore::DocumentLoader::setCustomJavaScriptUserAgent): Deleted.
(WebCore::DocumentLoader::customJavaScriptUserAgent const): Deleted.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::userAgentForJavaScript const):

Source/WebKit:

Renamed the various member variables, functions, properties and selectors.

Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

Shared/WebsitePoliciesData.h:
UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

UIProcess/API/APIWebsitePolicies.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.h:
UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies setCustomJavaScriptUserAgentAsSiteSpecificQuirks:]): Renamed from setCustomJavaScriptUserAgent.
(-[_WKWebsitePolicies customJavaScriptUserAgentAsSiteSpecificQuirks]): Renamed from customJavaScriptUserAgent.

Tools:

Updated per the _WKWebsitePolicies rename.

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):

10:59 PM Changeset in webkit [240645] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit

Unreviewed, rolling out r240630.
https://bugs.webkit.org/show_bug.cgi?id=193958

Broke Apple internal builds (Requested by rniwa on #webkit).

Reverted changeset:

"Add back some includes that got removed at some point."
https://bugs.webkit.org/show_bug.cgi?id=193942
https://trac.webkit.org/changeset/240630

10:20 PM Changeset in webkit [240644] by Devin Rousso

26 edits
4 adds in trunk

Web Inspector: provide a way to edit page WebRTC settings on a remote target
https://bugs.webkit.org/show_bug.cgi?id=193863
<rdar://problem/47572764>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/protocol/Page.json:

Add more values to the Setting enum type:

ICECandidateFilteringEnabled
MediaCaptureRequiresSecureConnection
MockCaptureDevicesEnabled

Source/WebCore:

Test: inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

inspector/page/overrideSetting-MockCaptureDevicesEnabled.html

inspector/agents/InspectorPageAgent.cpp:

page/Settings.yaml:
page/SettingsBase.h:
page/SettingsBase.cpp:

(SettingsBase::iceCandidateFilteringEnabledChanged): Added.
(SettingsBase::mockCaptureDevicesEnabledChanged): Added.

Scripts/GenerateSettings.rb:
Scripts/SettingsTemplates/Settings.cpp.erb:

Add page-level settings for WebRTC preferences.

Modules/mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::canCallGetUserMedia):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaCaptureRequiresSecureConnection):

testing/Internals.h:
testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setMockMediaCaptureDevicesEnabled):
(WebCore::Internals::setMediaCaptureRequiresSecureConnection): Added.

page/DeprecatedGlobalSettings.h:
page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::mockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setMockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::mediaCaptureRequiresSecureConnection): Deleted.
(WebCore::DeprecatedGlobalSettings::setMediaCaptureRequiresSecureConnection): Deleted.

Source/WebInspectorUI:

UserInterface/Base/Main.js:

(WI.loaded):
(WI.initializeTarget):
(WI._handleDeviceSettingsToolbarButtonClicked):
(WI._handleDeviceSettingsToolbarButtonClicked.createCheckbox):
(WI._handleDeviceSettingsToolbarButtonClicked.createColumns): Deleted.

UserInterface/Views/Main.css:

(.device-settings-content .container): Added.

Localizations/en.lproj/localizedStrings.js:

Source/WebKit:

Shared/WebPreferences.yaml:

Add page-level settings for WebRTC preferences.

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add page-level settings for WebRTC preferences.

LayoutTests:

inspector/page/overrideSetting-ICECandidateFilteringEnabled.html: Added.
inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt: Added.
inspector/page/overrideSetting-MockCaptureDevicesEnabled.html: Added.
inspector/page/overrideSetting-MockCaptureDevicesEnabled-expected.txt: Added.
platform/mac/TestExpectations:

10:11 PM Changeset in webkit [240643] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

webkitcurrentplaybacktargetiswirelesschanged and webkitCurrentPlaybackIsWireless are non-deterministic.
https://bugs.webkit.org/show_bug.cgi?id=193923
<rdar://problem/45956595>

Reviewed by Eric Carlson.

The value of webkitCurrentPlaybackTargetIsWireless can change in between when the event is scheduled
and when it's actually dispatched. To make this more deterministic, use a GenericTaskQueue to enqueue
setting m_isPlayingToWirelessTarget and dispatch the changed event in the same run-loop.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):
(WebCore::HTMLMediaElement::dispatchEvent):

html/HTMLMediaElement.h:

10:01 PM Changeset in webkit [240642] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION (r240553): Crash in WebCore::ScrollingTree::updateTreeFromStateNode
https://bugs.webkit.org/show_bug.cgi?id=193955

Unreviewed test gardening.

platform/ios/TestExpectations: Skip crashing test to unblock EWS.

10:00 PM Changeset in webkit [240641] by Ross Kirsling

77 edits in trunk

Remove unnecessary using namespace WTFs (or at least restrict their scope).
https://bugs.webkit.org/show_bug.cgi?id=193941

Reviewed by Alex Christensen.

Source/JavaScriptCore:

API/JSWeakObjectMapRefPrivate.cpp:
bytecompiler/NodesCodegen.cpp:
heap/MachineStackMarker.cpp:
jit/ExecutableAllocator.cpp:
jsc.cpp:
parser/Nodes.cpp:
runtime/DateConstructor.cpp:
runtime/DateConversion.cpp:
runtime/DateInstance.cpp:
runtime/DatePrototype.cpp:
runtime/InitializeThreading.cpp:
runtime/IteratorOperations.cpp:
runtime/JSDateMath.cpp:
runtime/JSGlobalObjectFunctions.cpp:
runtime/StringPrototype.cpp:
runtime/VM.cpp:
testRegExp.cpp:
tools/JSDollarVM.cpp:
yarr/YarrInterpreter.cpp:
yarr/YarrJIT.cpp:
yarr/YarrPattern.cpp:
yarr/YarrUnicodeProperties.cpp:

Source/WebCore:

css/CSSBasicShapes.cpp:
css/CSSPrimitiveValue.cpp:
css/parser/CSSParser.cpp:
css/parser/CSSParserSelector.cpp:
css/parser/CSSPropertyParser.cpp:
dom/Document.cpp:
dom/EventListenerMap.cpp:
dom/EventTarget.cpp:
editing/Editor.cpp:
html/HTMLElement.cpp:
html/HTMLFontElement.cpp:
html/parser/HTMLTokenizer.cpp:
html/track/TrackBase.cpp:
loader/FTPDirectoryParser.cpp:
loader/TextResourceDecoder.cpp:
loader/cache/CachedResource.cpp:
page/ContextMenuController.cpp:
page/Navigator.cpp:
platform/Length.cpp:
platform/cocoa/KeyEventCocoa.mm:
platform/graphics/FontCascade.cpp:
platform/graphics/WidthIterator.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
platform/ios/KeyEventIOS.mm:
platform/mac/KeyEventMac.mm:
platform/network/HTTPParsers.cpp:
platform/text/TextCodecUTF8.cpp:
platform/text/TextEncodingRegistry.cpp:
platform/win/KeyEventWin.cpp:
rendering/BidiRun.cpp:
rendering/FloatingObjects.cpp:
rendering/RenderBlock.cpp:
rendering/RenderListMarker.cpp:
rendering/RenderText.cpp:

Source/WebKit:

Shared/linux/WebMemorySamplerLinux.cpp:

Source/WebKitLegacy/win:

Plugins/PluginMessageThrottlerWin.cpp:
Plugins/PluginView.cpp:
Plugins/PluginViewWin.cpp:

Tools:

TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
TestWebKitAPI/Tests/WTF/Condition.cpp:
TestWebKitAPI/Tests/WTF/Lock.cpp:
TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
TestWebKitAPI/Tests/WTF/Time.cpp:
TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
TestWebKitAPI/Tests/WebCore/Logging.cpp:
WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:

9:58 PM Changeset in webkit [240640] by Fujii Hironori

19 edits
2 moves in trunk/Source

[Win] WebCore/platform/Process.h is conflicting with process.h
https://bugs.webkit.org/show_bug.cgi?id=193944

Reviewed by Ross Kirsling.

Source/WebCore:

Windows has process.h. Rename Process.h to ProcessIdentifier.h.

No new tests because there is no behavior change.

Sources.txt:
UnifiedSources-input.xcfilelist:
WebCore.xcodeproj/project.pbxproj:
dom/MessagePortIdentifier.h:
dom/messageports/MessagePortChannel.h:
dom/messageports/MessagePortChannelProvider.h:
dom/messageports/MessagePortChannelRegistry.h:
history/BackForwardItemIdentifier.h:
page/GlobalWindowIdentifier.h:
platform/ProcessIdentifier.cpp: Renamed from Source/WebCore/platform/Process.cpp.

(WebCore::Process::setIdentifier):
(WebCore::Process::identifier):

platform/ProcessIdentifier.h: Renamed from Source/WebCore/platform/Process.h.

Source/WebKit:

Shared/ChildProcess.h:
Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
Shared/unix/ChildProcessMain.cpp:
UIProcess/API/APINavigation.h:
UIProcess/ChildProcessProxy.h:
UIProcess/Launcher/ProcessLauncher.h:
UIProcess/WebProcessPool.cpp:
UIProcess/WebProcessProxy.h:

9:21 PM Changeset in webkit [240639] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements tab should toggle visibility for all selected nodes
https://bugs.webkit.org/show_bug.cgi?id=193089
<rdar://problem/47009256>

Reviewed by Devin Rousso.

Update "Toggle Visibility" command in DOM tree for multiple selection.
When both visible and hidden elements are selected in the DOM tree,
the toggle command behaves contextually. If one or more elements are
visible, they are hidden, otherwise they are shown. The context menu
shows "Hide Elements" or "Show Elements", respectively.

When only one element is selected, or the context menu target element
is not selected, the command continues to be "Toggle Visibility".

Localizations/en.lproj/localizedStrings.js:

UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.get isNodeHidden): Added.
(WI.DOMTreeElement.prototype.toggleElementVisibility.inspectedPage_node_injectStyleAndToggleClass):
(WI.DOMTreeElement.prototype.toggleElementVisibility):
(WI.DOMTreeElement.prototype._populateTagContextMenu):

UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.toggleSelectedElementsVisibility): Added.
Provide a public method for toggling the visibility of selected DOM nodes.
Used by the "H" keyboard shortcut and DOMTreeElement context menu.

(WI.DOMTreeOutline.prototype._hideElements):
(WI.DOMTreeOutline.prototype._hideElement): Deleted.
Rename for multiple selection.

8:49 PM Changeset in webkit [240638] by ysuzuki@apple.com

2 edits in trunk/Tools

Unreviewed, reorder my emails to fix autocomplete in bugzilla

Scripts/webkitpy/common/config/contributors.json:

8:33 PM Changeset in webkit [240637] by ysuzuki@apple.com

15 edits in trunk/Source/JavaScriptCore

[JSC] Reduce size of memory used for ShadowChicken
https://bugs.webkit.org/show_bug.cgi?id=193546

Reviewed by Mark Lam.

This patch lazily instantiate ShadowChicken. We do not need this until we start logging ShadowChicken packets.
The removal of ShadowChicken saves 55KB memory.

debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::create):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):

heap/Heap.cpp:

(JSC::Heap::stopThePeriphery):
(JSC::Heap::addCoreConstraints):

jit/CCallHelpers.cpp:

(JSC::CCallHelpers::ensureShadowChickenPacket):

jit/JITExceptions.cpp:

(JSC::genericUnwind):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

jit/JITOperations.cpp:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::setDebugger):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::setDebugger): Deleted.

runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::ensureShadowChicken):

runtime/VM.h:

(JSC::VM::shadowChicken):

tools/JSDollarVM.cpp:

(JSC::functionShadowChickenFunctionsOnStack):
(JSC::changeDebuggerModeWhenIdle):

8:00 PM Changeset in webkit [240636] by Ross Kirsling

9 edits
9 moves in trunk/Source/WTF

Move platform-specific files out of WTF root directory.
https://bugs.webkit.org/show_bug.cgi?id=193929

Reviewed by Alex Christensen.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/PlatformGTK.cmake:
wtf/PlatformJSCOnly.cmake:
wtf/PlatformMac.cmake:
wtf/PlatformPlayStation.cmake:
wtf/PlatformWPE.cmake:
wtf/PlatformWin.cmake:
wtf/cf/RunLoopTimerCF.cpp: Renamed from Source/WTF/wtf/RunLoopTimerCF.cpp.
wtf/cf/SchedulePairCF.cpp: Renamed from Source/WTF/wtf/SchedulePairCF.cpp.
wtf/mac/SchedulePairMac.mm: Renamed from Source/WTF/wtf/SchedulePairMac.mm.
wtf/posix/OSAllocatorPOSIX.cpp: Renamed from Source/WTF/wtf/OSAllocatorPosix.cpp.
wtf/posix/ThreadingPOSIX.cpp: Renamed from Source/WTF/wtf/ThreadingPthreads.cpp.
wtf/win/CONTRIBUTORS.pthreads-win32: Renamed from Source/WTF/wtf/CONTRIBUTORS.pthreads-win32.
wtf/win/OSAllocatorWin.cpp: Renamed from Source/WTF/wtf/OSAllocatorWin.cpp.
wtf/win/ThreadSpecificWin.cpp: Renamed from Source/WTF/wtf/ThreadSpecificWin.cpp.
wtf/win/ThreadingWin.cpp: Renamed from Source/WTF/wtf/ThreadingWin.cpp.

7:36 PM Changeset in webkit [240635] by jonlee@apple.com

2 edits in trunk/Source/WebKit

Update Screen Capture preference
https://bugs.webkit.org/show_bug.cgi?id=193947
rdar://problem/47620199

Reviewed by Youenn Fablet.

Shared/WebPreferences.yaml:

7:15 PM Changeset in webkit [240634] by graouts@webkit.org

13 edits
12 adds in trunk

Implement capture for Pointer Events on iOS
https://bugs.webkit.org/show_bug.cgi?id=193917
<rdar://problem/47605689>

Reviewed by Dean Jackson.

Source/WebCore:

We add a new PointerCaptureController object which gets notified upon dispatch of pointer events
to implement implicit pointer capture, dispatch the gotpointercapture and lostpointercaptiure events,
and implement the Element APIs for pointer capture: hasPointerCapture(), setPointerCapture() and
releasePointerCapture().

Tests: pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down.html

pointerevents/ios/pointer-events-implicit-capture-release-exception.html
pointerevents/ios/pointer-events-implicit-capture-release.html
pointerevents/ios/pointer-events-implicit-capture.html
pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Element.cpp:

(WebCore::Element::setPointerCapture):
(WebCore::Element::releasePointerCapture):
(WebCore::Element::hasPointerCapture):

dom/Element.h:
dom/Element.idl:
dom/EventNames.h:
dom/PointerEvent.h:
page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore::Page::pointerCaptureController const):

page/PointerCaptureController.cpp: Added.

(WebCore::PointerCaptureController::PointerCaptureController):
(WebCore::PointerCaptureController::setPointerCapture):
(WebCore::PointerCaptureController::releasePointerCapture):
(WebCore::PointerCaptureController::hasPointerCapture):
(WebCore::PointerCaptureController::pointerLockWasApplied):
(WebCore::PointerCaptureController::touchEndedOrWasCancelledForIdentifier):
(WebCore::PointerCaptureController::pointerEventWillBeDispatched):
(WebCore::PointerCaptureController::pointerEventWasDispatched):
(WebCore::PointerCaptureController::processPendingPointerCapture):

page/PointerCaptureController.h: Added.
page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

page/PointerLockController.h:

LayoutTests:

New tests for implicit pointer capture and the Element APIs related to pointer capture.

pointerevents/ios/pointer-events-implicit-capture-expected.txt: Added.
pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down-expected.txt: Added.
pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down.html: Added.
pointerevents/ios/pointer-events-implicit-capture-release-exception-expected.txt: Added.
pointerevents/ios/pointer-events-implicit-capture-release-exception.html: Added.
pointerevents/ios/pointer-events-implicit-capture-release-expected.txt: Added.
pointerevents/ios/pointer-events-implicit-capture-release.html: Added.
pointerevents/ios/pointer-events-implicit-capture.html: Added.
pointerevents/ios/pointer-events-set-pointer-capture-exceptions-expected.txt: Added.
pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html: Added.

7:06 PM Scrolling edited by Simon Fraser

(diff)

6:59 PM Changeset in webkit [240633] by aestes@apple.com

14 edits in trunk

[watchOS] Enable Parental Controls content filtering
https://bugs.webkit.org/show_bug.cgi?id=193939
<rdar://problem/46641912>

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/Platform.h:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

6:03 PM Changeset in webkit [240632] by dino@apple.com

6 edits
1 copy
1 add in trunk

Produce "pen" Pointer Events if using a stylus (e.g. Apple Pencil)
https://bugs.webkit.org/show_bug.cgi?id=193945
<rdar://problem/47618922>

Reviewed by Antoine Quint.

Source/WebCore:

Calculate the pressure, tiltX and tiltY values for incoming
Pointer Events, which have values when the PlatformTouchEvent
originated from a stylus.

Test: pointerevents/ios/pointer-events-dispatch-on-stylus.html

dom/PointerEvent.h: Default to "mouse".
dom/ios/PointerEventIOS.cpp: Calculate the values.

LayoutTests:

Test for stylus -> "pen" Pointer Events.

pointerevents/ios/pointer-events-dispatch-on-stylus-expected.txt: Added.
pointerevents/ios/pointer-events-dispatch-on-stylus.html: Added.
pointerevents/ios/pointer-events-dispatch-on-touch.html: Test for "touch" type.
pointerevents/utils.js: Add a new helper for stylus event generation.

(prototype.assertMatchesEvents):
(const.ui.new.UIController.prototype.beginStylus):

5:58 PM Changeset in webkit [240631] by ddkilzer@apple.com

7 edits
1 copy in trunk

REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
<https://webkit.org/b/193884>

Reviewed by Jiewen Tan.

Source/WebKit:

SourcesCocoa.txt:
UnifiedSources-input.xcfilelist:
WebKit.xcodeproj/project.pbxproj:
Add LocalAuthenticationSoftLink.mm to the project.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.h:
UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.mm: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.h.
Move soft-linking implementation to LocalAuthenticationSoftLink.mm.

Tools:

Scripts/webkitpy/style/checkers/cpp.py:

(check_language): Add LocalAuthentication to
frameworks_with_soft_links.

5:56 PM Changeset in webkit [240630] by timothy@apple.com

5 edits in trunk/Source/WebKit

Add back some includes that got removed at some point.
https://bugs.webkit.org/show_bug.cgi?id=193942

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKWebView.mm:
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

5:53 PM Changeset in webkit [240629] by ysuzuki@apple.com

2 edits in trunk/JSTests

Unreviewed, fix the test after r240543 not to use @Error / Error in builtins
https://bugs.webkit.org/show_bug.cgi?id=193713

stress/try-get-by-id-should-spill-registers-dfg.js:

(let.f.createBuiltin):

5:51 PM Changeset in webkit [240628] by timothy@apple.com

17 edits in trunk/Source

Make it easier for non-Apple ports to enable dark mode CSS support.
https://bugs.webkit.org/show_bug.cgi?id=193882

Reviewed by Megan Gardner.

Source/WebCore:

page/FrameView.cpp:

(WebCore::FrameView::updateBackgroundRecursively): Limit use of system
background color to the Mac platform.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::purgeCaches): Purge m_darkColorCache.
(WebCore::RenderTheme::platformColorsDidChange): Reset m_darkColorCache.
(WebCore::RenderTheme::colorCache const): Added m_darkColorCache.

rendering/RenderTheme.h:

(WebCore::RenderTheme::colorCache const): Deleted.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::purgeCaches): Removed m_darkColorCache.
(WebCore::RenderThemeMac::platformColorsDidChange): Deleted.
(WebCore::RenderThemeMac::colorCache const): Deleted.

Source/WebKit:

Make modern WebKit code for dark mode usable by other ports, to match
the WebCore parts that have been cross-platform all along.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/PageClient.h:

(WebKit::PageClient::effectiveAppearanceIsDark const):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::effectiveAppearanceDidChange):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
(WebKit::WebPage::setUseDarkAppearance):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
(-[WebView _effectiveAppearanceIsDark]): Ditto.

5:38 PM Changeset in webkit [240627] by Alan Coon

1 copy in tags/Safari-607.1.29

Tag Safari-607.1.29.

5:14 PM Changeset in webkit [240626] by Alan Coon

2 edits in tags/Safari-608.1.3/Source/WebKit

Cherry-pick r240620. rdar://problem/47614992

REGRESSION (r240348): Loading netflix home page panics device
https://bugs.webkit.org/show_bug.cgi?id=193936

Reviewed by Alexey Proskuryakov.

Temporarily enable permissive call filtering.

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:14 PM Changeset in webkit [240625] by Alan Coon

4 edits in tags/Safari-608.1.3

Cherry-pick r240599. rdar://problem/47560907

Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>

Reviewed by Alex Christensen.

Source/WebKit:

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving IPC after this or even worse, commit the provisional page.

(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:12 PM Changeset in webkit [240624] by aestes@apple.com

3 edits in trunk/Source/WebKit

[Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
https://bugs.webkit.org/show_bug.cgi?id=193927

Reviewed by Tim Horton.

This is useful for clients migrating from _WKUserContentExtensionStore to the modern
WKContentRuleList* APIs.

UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(-[_WKUserContentExtensionStore _contentRuleListStore]):

UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:

5:07 PM Changeset in webkit [240623] by Alan Coon

7 edits in tags/Safari-608.1.3/Source

Versioning.

4:59 PM Changeset in webkit [240622] by Fujii Hironori

2 edits in trunk/Tools

[Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
https://bugs.webkit.org/show_bug.cgi?id=193891

Reviewed by Ross Kirsling.

There were three problems in window sizes of WebView and the host window.

The sizes of pixel image output were incorrect.
The host window is going to appear after window.resize was invoked.
window.resize resized only the host window, not WebView.

This change solves them with a following approach.

PlatformWebView::PlatformWebView creates the initial host window as zero size.
Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP as well as DumpRenderTree in order to match the client area and the window area.
PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
PlatformWebView::setWindowFrame changes both window sizes.
PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.

WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): Create the host window
and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
(WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
(WTR::PlatformWebView::setWindowFrame): Change both window sizes.

4:58 PM Changeset in webkit [240621] by ddkilzer@apple.com

3 edits in trunk/Source/WebKit

Move soft-linking of ManagedConfiguration.framework out of ManagedConfigurationSPI.h
<https://webkit.org/b/193868>

Reviewed by Daniel Bates.

Platform/spi/ios/ManagedConfigurationSPI.h:
Remove soft-linking code from header.
Add PLATFORM(IOS_FAMILY) && !PLATFORM(IOSMAC) guard.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):

Add soft-linking code formerly in ManagedConfigurationSPI.h.
Change MCFeatureDefinitionLookupAllowed to use soft-link function getMCFeatureDefinitionLookupAllowed() to remove the #define.

4:55 PM Changeset in webkit [240620] by pvollan@apple.com

2 edits in trunk/Source/WebKit

REGRESSION (r240348): Loading netflix home page panics device
https://bugs.webkit.org/show_bug.cgi?id=193936

Reviewed by Alexey Proskuryakov.

Temporarily enable permissive call filtering.

WebProcess/com.apple.WebProcess.sb.in:

4:54 PM Changeset in webkit [240619] by Alan Coon

1 copy in tags/Safari-608.1.3

Tag Safari-608.1.3.

4:52 PM Changeset in webkit [240618] by Alan Coon

7 edits in trunk/Source

Versioning.

4:46 PM Changeset in webkit [240617] by Alan Coon

1 delete in tags/Safari-608.1.3

Delete tag.

4:41 PM Changeset in webkit [240616] by mark.lam@apple.com

3 edits
3 adds in trunk

ToString node actually does GC.
https://bugs.webkit.org/show_bug.cgi?id=193920
<rdar://problem/46695900>

Reviewed by Yusuke Suzuki.

JSTests:

stress/dfg-to-string-on-int-does-gc.js: Added.
stress/dfg-to-string-on-string-object-does-not-gc.js: Added.
stress/dfg-to-string-on-string-or-string-object-does-not-gc.js: Added.

Source/JavaScriptCore:

Other than for StringObjectUse and StringOrStringObjectUse, ToString and
CallStringConstructor can allocate new JSStrings, and hence, can GC.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

4:37 PM Changeset in webkit [240615] by Alan Coon

7 edits in tags/Safari-608.1.3/Source

Versioning.

4:24 PM Changeset in webkit [240614] by Alan Coon

1 delete in tags/Safari-608.1.3.1

Delete tag.

4:21 PM Changeset in webkit [240613] by Alan Coon

1 copy in tags/Safari-608.1.3.1

New tag.

4:21 PM Changeset in webkit [240612] by Alan Coon

1 copy in tags/Safari-608.1.3

Tag Safari-608.1.3.

4:19 PM Changeset in webkit [240611] by Alan Coon

1 delete in tags/Safari-608.1.3

Delete tag.

4:15 PM Changeset in webkit [240610] by Simon Fraser

3 edits in trunk/Source/WebCore

svg/text/select-text-inside-non-static-position.html crashes under ScrollingStateTree::unparentChildrenAndDestroyNode()
https://bugs.webkit.org/show_bug.cgi?id=193930

Reviewed by Tim Horton.

ScrollingStateTree::unparentChildrenAndDestroyNode() should make a copy of the 'children' vector
before iterating, since iteration mutates the array.

Tested by ASan tests.

page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::takeChildren):

page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):

4:14 PM Changeset in webkit [240609] by Simon Fraser

2 edits in trunk/Source/WebCore

css3/filters/blur-filter-page-scroll-self.html crashes under WebCore::ScrollingStateNode::ScrollingStateNode
https://bugs.webkit.org/show_bug.cgi?id=193925

Reviewed by Tim Horton.

Some css3/filters/ tests disable accelerated compositing (which is crazy). Make these
tests not crash by ensuring that unparentNode() and unparentChildrenAndDestroyNode() clears the root
node if it's the node being unparented or destroyed.

Tested by existing tests.

page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::unparentNode):
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):

4:12 PM Changeset in webkit [240608] by Alan Coon

1 copy in tags/Safari-608.1.3

Tag Safari-608.1.3.

3:21 PM Changeset in webkit [240607] by Alan Coon

7 edits in trunk/Source

Versioning.

3:18 PM Changeset in webkit [240606] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash
https://bugs.webkit.org/show_bug.cgi?id=193456
<rdar://problem/47275642>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-28
Reviewed by Brent Fulgham.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Allow access to iconservices.

3:07 PM Changeset in webkit [240605] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-app] Add method to save Step data to database
https://bugs.webkit.org/show_bug.cgi?id=193890

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/models/step.py:

(Step.save_step): Method to save step data.
(Step.update_step): Method to update step data.
(Step.get_existing_step): Method to fetch existing step from database.
(Step.is_valid_result): Method to validate valid step result.

3:00 PM Changeset in webkit [240604] by dbates@webkit.org

6 edits
4 adds in trunk

[iOS] Make Window virtual key code computation match Mac
https://bugs.webkit.org/show_bug.cgi?id=193452

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use the same approach for computing the Windows virtual key code on iOS as we do on Mac for
web compatibility. On Mac, we prefer to compute the Windows virtual key code from the input
strings of the key event and use the key event's keycode as a last resort.

Test: fast/events/ios/key-events-meta-alt-combinations.html

platform/ios/PlatformEventFactoryIOS.h:
platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::isKeypadEvent): Added.
(WebCore::windowsKeyCodeForKeyEvent): Added.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): Modified to call
WebCore::windowsKeyCodeForKeyEvent() to compute the Windows virtual key code.

Source/WebKit:

Compute the Windows virtual key code from the WebEvent.

Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

LayoutTests:

Add a test that ensures we do not regress DOM key events dispatches for combinations
of Option and Command + Option key commands.

fast/events/ios/key-events-meta-alt-combinations-expected.txt: Added.
fast/events/ios/key-events-meta-alt-combinations.html: Added.
fast/events/ios/resources/key-tester.js: Added.

(computeDifference):
(areArraysEqual):
(areKeyCommandsEqual):
(KeyCommand):
(KeyCommand.prototype.toString):
(keyCommandsHasCommand):
(computeSubsets.compareByModifierOrder):
(handleKeyUp):
(handleKeyPress):
(log):
(logKeyEvent):
(displayNameForTest):
(nextKeyPress):
(runTest):
(setUp):

3:00 PM Changeset in webkit [240603] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-app] Add method to save Build data to database
https://bugs.webkit.org/show_bug.cgi?id=193735

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/models/build.py:

(Build.save_build): Method to save build information to database.
(Build.get_existing_build): Method to fetch existing build from database.
(Build.is_valid_result): Method to validate build result.

BuildSlaveSupport/ews-app/ews/common/util.py:

(is_valid_int_id): Method to validate valid id.

2:34 PM Changeset in webkit [240602] by Brent Fulgham

4 edits in trunk/Source/WebKit

REGRESSION (r240498): Storage Access API prompts result is not remembered
https://bugs.webkit.org/show_bug.cgi?id=193922
<rdar://problem/47608767>

Reviewed by Chris Dumez.

The refactoring in r240498 bypassed bookkeeping in ResourceLoadStatisticsMemoryStore
that kept track of whether a successful user prompt had been encountered. This
patch corrects this codepath so the user is not prompted repeatedly after approving
use of the Storage Access API.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess): Switch from Move operator to
const reference to allow the method to be called by the NetworkProcess.

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::grantStorageAccess): Request access through the WebResourceLoadStatistics
object, rather than jumping directly to the NetworkStorageSession.

2:12 PM Changeset in webkit [240601] by Alan Coon

4 edits in branches/safari-607-branch

Cherry-pick r240599. rdar://problem/47609799

Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>

Reviewed by Alex Christensen.

Source/WebKit:

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving IPC after this or even worse, commit the provisional page.

(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:35 PM Changeset in webkit [240600] by Ross Kirsling

5 edits in trunk/Source/WTF

[JSCOnly][WTF] Expose FileSystem.
https://bugs.webkit.org/show_bug.cgi?id=193789

Reviewed by Don Olmstead.

wtf/FileSystem.h:
wtf/PlatformJSCOnly.cmake:
wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::getVolumeFreeSpace):

wtf/win/FileSystemWin.cpp:

(WTF::FileSystemImpl::fileSystemRepresentation):

1:19 PM Changeset in webkit [240599] by Chris Dumez

4 edits in trunk

Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>

Reviewed by Alex Christensen.

Source/WebKit:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving
IPC after this or even worse, commit the provisional page.

(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

12:21 PM Changeset in webkit [240598] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Unreviewed, rolling out r240351.
https://bugs.webkit.org/show_bug.cgi?id=193918

Causes overlapping Timeline records, as some record types
don't have an endTime (Requested by drousso on #webkit).

Reverted changeset:

"WebInspector: Confusingly nested events in the timeline for
Mutation Observers"
https://bugs.webkit.org/show_bug.cgi?id=192884
https://trac.webkit.org/changeset/240351

12:08 PM Changeset in webkit [240597] by aakash_jain@apple.com

8 edits in trunk/Tools

[ews-app] Rename id variables
https://bugs.webkit.org/show_bug.cgi?id=193883

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/models/build.py:
BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
BuildSlaveSupport/ews-app/ews/models/step.py:
BuildSlaveSupport/ews-app/ews/urls.py:
BuildSlaveSupport/ews-app/ews/views/patch.py:
BuildSlaveSupport/ews-app/ews/views/results.py:
BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

11:58 AM Changeset in webkit [240596] by graouts@webkit.org

2 edits in trunk/Source/WebCore

Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447

Unreviewed build fix.

dom/Element.cpp:

(WebCore::parentCrossingFrameBoundaries):

11:54 AM Changeset in webkit [240595] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-app] Allow certain fields to be empty
https://bugs.webkit.org/show_bug.cgi?id=193892

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/models/build.py:
BuildSlaveSupport/ews-app/ews/models/step.py:

11:53 AM Changeset in webkit [240594] by Matt Baker

3 edits in trunk/Source/WebInspectorUI

REGRESSION(?): Web Inspector: Can have multiple Timelines selected after edit mode
https://bugs.webkit.org/show_bug.cgi?id=193808
<rdar://problem/47537734>

Reviewed by Devin Rousso.

UserInterface/Controllers/SelectionController.js:

(WI.SelectionController.prototype.didRemoveItems):

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype._indexesForSubtree):
Fix a bug where no IndexSet was returned when passed a TreeElement with
no children. This caused the Timelines tree selection to be corrupted when
entering and exiting edit mode, as TreeElements are inserted and removed.

11:52 AM Changeset in webkit [240593] by ysuzuki@apple.com

25 edits
3 adds in trunk/Source/JavaScriptCore

[JSC] RegExpConstructor should not have own IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=193801

Reviewed by Mark Lam.

This patch finally removes RegExpConstructor's cached data to JSGlobalObject and remove IsoSubspace for RegExpConstructor.
sizeof(RegExpConstructor) != sizeof(InternalFunction), so that we have 16KB memory just for RegExpConstructor. But cached
regexp matching data (e.g. RegExp.$1) is per-JSGlobalObject one, and we can move this data to JSGlobalObject and remove
it from RegExpConstructor members.

We introduce RegExpGlobalData, which holds the per-global RegExp matching data. And we perform performMatch etc. with
JSGlobalObject instead of RegExpConstructor. This change requires small changes in DFG / FTL's RecordRegExpCachedResult
node since its 1st argument is changed from RegExpConstructor to JSGlobalObject.

We also move emptyRegExp from RegExpPrototype to VM's RegExpCache because it is more natural place to put it.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
dfg/DFGOperations.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileRecordRegExpCachedResult):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

ftl/FTLAbstractHeapRepository.cpp:
ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileRecordRegExpCachedResult):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpGlobalData):
(JSC::JSGlobalObject::regExpGlobalDataOffset):
(JSC::JSGlobalObject::regExpConstructor const): Deleted.

runtime/RegExpCache.cpp:

(JSC::RegExpCache::initialize):

runtime/RegExpCache.h:

(JSC::RegExpCache::emptyRegExp const):

runtime/RegExpCachedResult.cpp:

(JSC::RegExpCachedResult::visitAggregate):
(JSC::RegExpCachedResult::visitChildren): Deleted.

runtime/RegExpCachedResult.h:

(JSC::RegExpCachedResult::RegExpCachedResult): Deleted.

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::regExpConstructorDollar):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):
(JSC::RegExpConstructor::destroy): Deleted.
(JSC::RegExpConstructor::visitChildren): Deleted.
(JSC::RegExpConstructor::getBackref): Deleted.
(JSC::RegExpConstructor::getLastParen): Deleted.
(JSC::RegExpConstructor::getLeftContext): Deleted.
(JSC::RegExpConstructor::getRightContext): Deleted.

runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::performMatch): Deleted.
(JSC::RegExpConstructor::recordMatch): Deleted.

runtime/RegExpGlobalData.cpp: Added.

(JSC::RegExpGlobalData::visitAggregate):
(JSC::RegExpGlobalData::getBackref):
(JSC::RegExpGlobalData::getLastParen):
(JSC::RegExpGlobalData::getLeftContext):
(JSC::RegExpGlobalData::getRightContext):

runtime/RegExpGlobalData.h: Added.

(JSC::RegExpGlobalData::cachedResult):
(JSC::RegExpGlobalData::setMultiline):
(JSC::RegExpGlobalData::multiline const):
(JSC::RegExpGlobalData::input):
(JSC::RegExpGlobalData::offsetOfCachedResult):

runtime/RegExpGlobalDataInlines.h: Added.

(JSC::RegExpGlobalData::setInput):
(JSC::RegExpGlobalData::performMatch):
(JSC::RegExpGlobalData::recordMatch):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::matchGlobal):

runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::execInline):
(JSC::RegExpObject::matchInline):
(JSC::collectMatches):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):
(JSC::regExpProtoFuncSearchFast):
(JSC::RegExpPrototype::visitChildren): Deleted.

runtime/RegExpPrototype.h:
runtime/StringPrototype.cpp:

(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

11:19 AM Changeset in webkit [240592] by eric.carlson@apple.com

15 edits in trunk/Source

AVStreamSession isn't always available, make a HAVE compile flag for it
https://bugs.webkit.org/show_bug.cgi?id=193889
<rdar://problem/47452863>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, no functional change.

page/Settings.yaml:
page/SettingsBase.cpp:

(WebCore::SettingsBase::platformDefaultMediaSourceEnabled):

page/SettingsBase.h:
page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::platformDefaultMediaSourceEnabled):

platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::createSession):

platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): Fix logging.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

Use a HashMap to associate CMSampleBuffer with SourceBufferPrivateAVFObjC.

(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]): isEqualTo
-> isEqualToString.
(WebCore::sourceBufferMap):
(WebCore::nextMapID):
(WebCore::bufferWasConsumedCallback):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::willProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::bufferWasConsumed):
(-[WebBufferConsumedContext initWithParent:]): Deleted.
(-[WebBufferConsumedContext parent]): Deleted.

Source/WTF:

wtf/FeatureDefines.h:

11:11 AM Changeset in webkit [240591] by commit-queue@webkit.org

6 edits in trunk

Update MIME type parser
https://bugs.webkit.org/show_bug.cgi?id=180526

Patch by Rob Buis <rbuis@igalia.com> on 2019-01-28
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update improved test expectations.

web-platform-tests/xhr/overridemimetype-blob-expected.txt:

Source/WebCore:

I overlooked step 11.9.3 [1], for Mimesniff we should not
bail out on missing subtype, but keep trying. Note
that Rfc2045 does require bailing out, as before.

Test: ParsedContentType unittest

[1] https://mimesniff.spec.whatwg.org/#parse-a-mime-type

platform/network/ParsedContentType.cpp:

(WebCore::parseToken):
(WebCore::parseContentType):

Tools:

TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:

(TestWebKitAPI::TEST):

11:09 AM Changeset in webkit [240590] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Unreviewed follow-up to r240557, restore a call to makeString
https://bugs.webkit.org/show_bug.cgi?id=192742
<rdar://problem/46757369>

It works if we add this #include that was missing. I got confused by the error messages and
missed that there were two similarly-named headers.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

10:35 AM Changeset in webkit [240589] by graouts@webkit.org

2 edits in trunk/Source/WebKit

Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447

Unreviewed build fix.

UIProcess/API/Cocoa/WKWebView.mm:

9:44 AM Changeset in webkit [240588] by commit-queue@webkit.org

4 edits
21 adds in trunk

[css-logical] Reject unitless length quirk in 'inset' shorthand
https://bugs.webkit.org/show_bug.cgi?id=193773

Patch by Oriol Brufau <Oriol Brufau> on 2019-01-28
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import WPT tests that check that the unitless length quirk is not
allowed in the 'inset' shorthand.

resources/import-expectations.json:
web-platform-tests/quirks/support/test-ref-iframe.js: Added.

(setupIframe):

web-platform-tests/quirks/support/w3c-import.log: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-001.html: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-002.html: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-003-expected.txt: Added.
web-platform-tests/quirks/unitless-length/excluded-properties-003.html: Added.
web-platform-tests/quirks/unitless-length/limited-quirks-expected.txt: Added.
web-platform-tests/quirks/unitless-length/limited-quirks.html: Added.
web-platform-tests/quirks/unitless-length/no-quirks-expected.txt: Added.
web-platform-tests/quirks/unitless-length/no-quirks.html: Added.
web-platform-tests/quirks/unitless-length/quirks-expected.txt: Added.
web-platform-tests/quirks/unitless-length/quirks.html: Added.
web-platform-tests/quirks/unitless-length/support/common.js: Added.

(onload):

web-platform-tests/quirks/unitless-length/support/w3c-import.log: Added.
web-platform-tests/quirks/unitless-length/w3c-import.log: Added.

Source/WebCore:

Even though its longhands ('top', 'right', 'bottom', 'left') accept the
unitless length quirk, the 'inset' shorthand is a new CSS property and
should reject it. This was resolved by the CSS WG in
https://github.com/w3c/csswg-drafts/issues/3525#issuecomment-456902648

Tests: imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001.html

imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002.html
imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-003.html
imported/w3c/web-platform-tests/quirks/unitless-length/limited-quirks.html
imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html
imported/w3c/web-platform-tests/quirks/unitless-length/quirks.html

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

9:33 AM Changeset in webkit [240587] by graouts@webkit.org

2 edits in trunk/Source/WebKit

Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447

Unreviewed build fix.

UIProcess/ios/WKContentViewInteraction.mm:

9:29 AM Changeset in webkit [240586] by Brent Fulgham

8 edits in trunk/Source/WebKit

Remove the UIProcess components of the ResourceLoadStatistics code
https://bugs.webkit.org/show_bug.cgi?id=193303
<rdar://problem/47160073>

Reviewed by Chris Dumez.

Now that the ResourceLoadStatistics code is running in the NetworkProcess, we can get rid
of the UIProcess copies of these routines.

Tested by existing ResourceLoadStatistics and StorageAccess tests.

NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler):
(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler):
(WebKit::WebResourceLoadStatisticsStore::logTestingEvent):
(WebKit::WebResourceLoadStatisticsStore::notifyResourceLoadStatisticsProcessed):
(WebKit::WebResourceLoadStatisticsStore::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebResourceLoadStatisticsStore::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const):
(WebKit::WebResourceLoadStatisticsStore::notifyPageStatisticsTelemetryFinished const):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores): Deleted.
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData): Deleted.

UIProcess/WebProcessProxy.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebsiteDataStore::hasStorageAccess):
(WebKit::WebsiteDataStore::requestStorageAccess):
(WebKit::WebsiteDataStore::grantStorageAccess):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::webProcessWillOpenConnection):
(WebKit::WebsiteDataStore::webProcessDidCloseConnection):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::didCreateNetworkProcess):
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData): Deleted.
(WebKit::WebsiteDataStore::removeDataForTopPrivatelyControlledDomains): Deleted.
(WebKit::WebsiteDataStore::setCacheMaxAgeCap): Deleted.
(WebKit::WebsiteDataStore::updatePrevalentDomainsToBlockCookiesFor): Deleted.
(WebKit::WebsiteDataStore::setAgeCapForClientSideCookies): Deleted.
(WebKit::WebsiteDataStore::hasStorageAccessForFrameHandler): Deleted.
(WebKit::WebsiteDataStore::grantStorageAccessHandler): Deleted.
(WebKit::WebsiteDataStore::removeAllStorageAccessHandler): Deleted.
(WebKit::WebsiteDataStore::removePrevalentDomains): Deleted.
(WebKit::WebsiteDataStore::isGrandfathered): Deleted.

UIProcess/WebsiteData/WebsiteDataStore.h:

9:23 AM WebKitGTK/2.22.x edited by Michael Catanzaro

(diff)

9:23 AM Changeset in webkit [240585] by Michael Catanzaro

3 edits in releases/WebKitGTK/webkit-2.22

Merge r238928: REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=191997

Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2018-12-06
Reviewed by Philippe Normand.

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF

Source/cmake/OptionsGTK.cmake: make ENABLE_ASYNC_SCROLLING depend on ENABLE_OPENGL

Source/WebCore:

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.

No new tests required. Only fixing build.

platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)

Source/WebKit:

Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)

9:19 AM Changeset in webkit [240584] by Michael Catanzaro

2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

Merge r239869 - [GTK] Garbled rendering on Youtube while scrolling under X11.
https://bugs.webkit.org/show_bug.cgi?id=192982

Reviewed by Carlos Garcia Campos.

When creating a GLX window context, try to get a GLXFBConfig that has depth and stencil buffers for
the default framebuffer.

platform/graphics/glx/GLContextGLX.cpp:

(WebCore::compatibleVisuals):
(WebCore::GLContextGLX::createWindowContext):

8:20 AM Changeset in webkit [240583] by Alan Bujtas

7 edits in trunk

[LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
https://bugs.webkit.org/show_bug.cgi?id=193896

Reviewed by Antti Koivisto.

Source/WebCore:

This patch implements quirk margin value collapsing. There are a few "quirk" rules when it comes to margin collapsing.

Collapsed quirk margin values are ignored on quirk containers

<body>

<p> p elements have 1em vertical (top/bottom) quirk margin

</body>

In quirk mode, <p> and <body> (quirk container) collapses their vertical margins but <p>'s quirk values(1qem -> 16px) are ignored.
Used vertical margin values on the <body> are top: 8px bottom: 8px.

Quirk margin values are turned into non-quirk values when collapsed with non-zero, non-quirk margins.

<body>

<div style="margin-top: 1px">

<p> p elements have 1em vertical (top/bottom) quirk margin

</div>

</body>

When <p>'s vertical margin collapses with the parent <div>,

the collapsed before value becomes 16px (max(1qem, 1px)) and this collapsed value is now considered as a non-quirk value
the collapsed after value stays 1qem quirk value.

When <div> collapses with <body>

the collapsed before value becomes 16px (max(16px, 8px))
the <div>'s quirk after value gets ignored and the collapsed after value stays 8px. Used vertical margin values on the <body> are top: 16px (1em) bottom: 8px.

layout/MarginTypes.h:

(WebCore::Layout::PositiveAndNegativeVerticalMargin::Values::isNonZero const):

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreCollapsedQuirkMargin):
(WebCore::Layout::hasMarginBeforeQuirkValue): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginAfter): Deleted.

layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):
(WebCore::Layout::computedPositiveAndNegativeMargin):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

7:43 AM Changeset in webkit [240582] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][BFC] Remove redundant vertical positioning in BlockFormattingContext::computeFloatingPosition
https://bugs.webkit.org/show_bug.cgi?id=193872

Reviewed by Antti Koivisto.

This is taken care of by verticalPositionWithMargin() in BlockFormattingContext::computeHeightAndMargin().

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):

7:31 AM Changeset in webkit [240581] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add missing #include in ScrollingTreeFrameScrollingNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=193905

Patch by cathie chen <cathiechen> on 2019-01-28
Reviewed by Frédéric Wang.

page/scrolling/ScrollingTreeFrameScrollingNode.cpp: Add

#include "ScrollingStateFrameScrollingNode.h"

7:29 AM Changeset in webkit [240580] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][BFC][Quirk] Ignore collapsed(through) margin after when stretching body height.
https://bugs.webkit.org/show_bug.cgi?id=193894

Reviewed by Antti Koivisto.

layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

7:08 AM Changeset in webkit [240579] by graouts@webkit.org

26 edits
19 adds in trunk

Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447
<rdar://problem/47283874>

Reviewed by Antti Koivisto and Simon Fraser.

Source/WebCore:

We now compile a list of elements with a non-auto touch-action property that is updated whenever an element has its style changed
or is removed from its document. When the content of that list changes, we inform the scrolling coordinator such that it can compile
a list of TouchActionData structures which hold the touch-action value, the ID of the nearest scroll node and the Region containing
the bounds of each of those elements to send it up to the UI process along with touch regions. Computing the list of allowed touch
actions for a given element accounts for not only the value specified directly on that element's style, but also in its hierarchy,
crossing any frame boundary towards the top-level document's root node.

Tests: pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html

pointerevents/ios/touch-action-none-on-iframe.html
pointerevents/ios/touch-action-none-on-parent.html
pointerevents/ios/touch-action-none.html
pointerevents/ios/touch-action-pan-x-pan-y.html
pointerevents/ios/touch-action-pan-x.html
pointerevents/ios/touch-action-pan-y.html
pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html
pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling.html

WebCore.xcodeproj/project.pbxproj: Update how certain headers are exposed such that they can be used from WebKit.
dom/Document.cpp:

(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::nodeWillBeRemoved): Ensure a node that is being removed from this document is no longer listed in its
list of elements with a non-auto touch-action property.
(WebCore::Document::absoluteEventRegionForNode):
(WebCore::Document::absoluteRegionForEventTargets):
(WebCore::Document::updateTouchActionElements): Create a list of elements with a non-auto touch-action property if one doesn't
exist yet and update it to add the given element if it contains a non-auto touch-action, or remove it if it doesn't. If the contents
of that list changed as a result, the scrolling coordinator is informed.

dom/Document.h:

(WebCore::Document:: const):

dom/Element.cpp:

(WebCore::parentCrossingFrameBoundaries):
(WebCore::Element::computedTouchActions const): Provide the list of allowed touch actions accounting for the "touch-action" property
specified on this element and all of its hierarchy, crossing frame boundary.
(WebCore::Element::nearestScrollingNodeIDUsingTouchOverflowScrolling const): Provide the ScrollingNodeID, if any, for the nearest scrolling node
for that element. This will allow the UI process to identify which scroll view's behavior to customize to reflect the element's allowed
touch actions.

dom/Element.h:
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const): Compute the region for all elements with a non-auto touch-action property
throughout the provided frame and all of its subframes.

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollableAreaParameters::operator== const): Deleted.

page/scrolling/ScrollingCoordinatorTypes.h: Added.

(WebCore::ScrollableAreaParameters::operator== const):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::touchActionDataAtPoint const): Query the list of TouchActionData objects for a match based on the provided point. Right
now the logic is pretty crude, stopping at the first TouchActionData for which the region contains the provided point, but future patches will
account for overlap and nesting.

page/scrolling/ScrollingTree.h:
page/scrolling/ScrollingTreeNode.h:
platform/EventTrackingRegions.cpp:

(WebCore::operator==):

platform/EventTrackingRegions.h:

(WebCore::operator!=):

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement): Update the list of elements with a non-auto touch-action property when an element's style changes.

Source/WebKit:

Handle the "none", "pan-x", "pan-y" and "pinch-zoom" values for the touch-action property by querying the scrolling tree whenever a touch begins
to identify whether its point is contained within the region of an element with a non-auto touch-action property. If it is, we use the list of
permitted touch actions such to then customize the behavior of the nearest scroll view to pan or zoom only as instructed.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TouchActionData>::encode):
(IPC::ArgumentCoder<TouchActionData>::decode):
(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):
(IPC::ArgumentCoder<Region>::decode):

Shared/WebCoreArgumentCoders.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Account for panning constraints set on the content view to prevent deceleration
to pan the view if it ought not.
(-[WKWebView _scrollView:adjustedOffsetForOffset:translation:startPoint:locationInView:horizontalVelocity:verticalVelocity:]): Implement an additional
UIScrollView delegation method to apply the panning constraints set on the content view while panning.

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::touchActionDataAtPoint const):
(WebKit::RemoteScrollingCoordinatorProxy::touchActionDataForScrollNodeID const):
(WebKit::RemoteScrollingCoordinatorProxy::setTouchDataForTouchIdentifier):
(WebKit::RemoteScrollingCoordinatorProxy::clearTouchDataForTouchIdentifier):

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Apply the same logic as in WKWebView.
(-[WKScrollingNodeScrollViewDelegate _scrollView:adjustedOffsetForOffset:translation:startPoint:locationInView:horizontalVelocity:verticalVelocity:]): Apply
the same logic as in WKWebView.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::touchActionData const):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isScrollingOrZooming const):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView preventsPanningInXAxis]):
(-[WKContentView preventsPanningInYAxis]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _handleTouchActionsForTouchEvent:]): As we process touches, check whether there are touch actions set for this touch's points' locations. Based
on those touch actions, either setDefaultPrevented on the _touchEventGestureRecognizer if the touch action is "none" or selectively disable panning and zooming.
(-[WKContentView _resetPanningPreventionFlags]):
(-[WKContentView _didEndScrollingOrZooming]):

LayoutTests:

Add a new series of tests that check that the "none", "pan-x", "pan-y" and "pinch-zoom" values have the expected
impact on page panning on iOS.

pointerevents/ios/touch-action-none-expected.txt: Added.
pointerevents/ios/touch-action-none-in-overflow-scrolling-touch-expected.txt: Added.
pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html: Added.
pointerevents/ios/touch-action-none-on-iframe-expected.txt: Added.
pointerevents/ios/touch-action-none-on-iframe.html: Added.
pointerevents/ios/touch-action-none-on-parent-expected.txt: Added.
pointerevents/ios/touch-action-none-on-parent.html: Added.
pointerevents/ios/touch-action-none.html: Added.
pointerevents/ios/touch-action-pan-x-expected.txt: Added.
pointerevents/ios/touch-action-pan-x-pan-y-expected.txt: Added.
pointerevents/ios/touch-action-pan-x-pan-y.html: Added.
pointerevents/ios/touch-action-pan-x.html: Added.
pointerevents/ios/touch-action-pan-y-expected.txt: Added.
pointerevents/ios/touch-action-pan-y.html: Added.
pointerevents/ios/touch-action-pinch-zoom-allows-zooming-expected.txt: Added.
pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html: Added.
pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling-expected.txt: Added.
pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling.html: Added.

5:15 AM Changeset in webkit [240578] by Antti Koivisto

2 edits in trunk/Source/WebKit

WebUserContentController::removeUserScriptMessageHandlerInternal may deref and delete itself
https://bugs.webkit.org/show_bug.cgi?id=193901
<rdar://problem/47338669>

Reviewed by David Kilzer.

Don't know how to repro.

WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal):

Calling userMessageHandlers.removeFirstMatching() may remove the last ref to this
(because WebUserMessageHandlerDescriptorProxy refs WebUserContentController).
Fix by protecting this over the function.

1:46 AM Changeset in webkit [240577] by bshafiei@apple.com

8 edits in branches/safari-607-branch

Cherry-pick r240516. rdar://problem/47586889

Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193802
<rdar://problem/46010580>

Reviewed by Andy Estes.

Source/WebKit:

UIProcess/API/APIUIClient.h: (API::UIClient::didClickGoBackFromSafeBrowsingWarning):
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::didClickGoBackFromSafeBrowsingWarning):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240576] by bshafiei@apple.com

5 edits in branches/safari-607-branch

Cherry-pick r240533. rdar://problem/47586823

REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
https://bugs.webkit.org/show_bug.cgi?id=193831
<rdar://problem/47399263>

Reviewed by Chris Dumez.

Source/WebKit:

A System Preview (<a rel="ar">) displays in a modal and doesn't trigger
a navigation. If the link was cross origin, it was causing a process swap,
which meant that the response defaulted back to a navigation.

The fix is to not cause a PSON when the navigation is a system preview.

UIProcess/API/APINavigation.h: (API::Navigation::shouldForceDownload const): This is now just tracking the "download" attribute, and not including System Preview. (API::Navigation::isSystemPreview const): New method to check for a navigation triggered as a System Preview.
UIProcess/WebPageProxy.cpp: Move the code from receivedPolicyDecision to receivedNavigationPolicyDecision, so that downloads and System Previews are detected before we decide to change process. (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::receivedPolicyDecision):

Tools:

Two new tests that exercise cross-origin and same-origin System
Previews.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240575] by bshafiei@apple.com

15 edits
1 delete in branches/safari-607-branch/Source/WebKit

Cherry-pick r240484. rdar://problem/47591281

Drop WebKit::WebKitPolicyAction type as it is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=193827

Reviewed by Antti Koivisto.

Drop WebKit::WebKitPolicyAction type as it is no longer needed. It is now identical to
WebCore::PolicyAction.

Shared/WebPolicyAction.h: Removed.
UIProcess/WebFramePolicyListenerProxy.cpp: (WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults): (WebKit::WebFramePolicyListenerProxy::use): (WebKit::WebFramePolicyListenerProxy::download): (WebKit::WebFramePolicyListenerProxy::ignore):
UIProcess/WebFramePolicyListenerProxy.h:
UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::setUpPolicyListenerProxy):
UIProcess/WebFrameProxy.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::receivedPolicyDecision): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponseShared):
UIProcess/WebPageProxy.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::didReceivePolicyDecision): (WebKit::toPolicyAction): Deleted.
WebProcess/WebPage/WebFrame.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceivePolicyDecision):
WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240574] by bshafiei@apple.com

4 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r240542. rdar://problem/47586850

REGRESSION (r238818): Snapshot is removed too late after swiping back on Twitter
https://bugs.webkit.org/show_bug.cgi?id=193860
<rdar://problem/47535022>

Reviewed by Antti Koivisto.

UIProcess/Cocoa/ViewGestureController.cpp: (WebKit::ViewGestureController::didStartProvisionalOrSameDocumentLoadForMainFrame): (WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame): (WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
UIProcess/Cocoa/ViewGestureController.h: Treat provisional load and same document load the same: they already both unpause the snapshot removal tracker, request render tree size notifications, but same-document navigation was missing the call to dispatchAfterEnsuringDrawing and thus would get stuck waiting for RepaintAfterNavigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240573] by bshafiei@apple.com

2 edits in branches/safari-607-branch/LayoutTests

Cherry-pick r240532. rdar://problem/47586874

Remove expectation for inspector/css/createStyleSheet.html as test appears to be passing.
https://bugs.webkit.org/show_bug.cgi?id=148636

Unreviewed test gardening.

platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240572] by bshafiei@apple.com

5 edits
2 adds in branches/safari-607-branch

Cherry-pick r240497. rdar://problem/47586863

iOS: inputmode="none" disables hardware keyboard's globe key
https://bugs.webkit.org/show_bug.cgi?id=193811
<rdar://problem/47406553>

Reviewed by Wenson Hsieh.

Source/WebKit:

Removed the support for inputmode="none" for now since we need a new SPI from UIKit
to properly implement this feature some time in the future.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _zoomToRevealFocusedElement]): (-[WKContentView inputView]): (-[WKContentView requiresAccessoryView]): (-[WKContentView textInputTraits]):

LayoutTests:

Updated and renamed the test expecting the keyboard to update upon inputmode content attribute changed
to use inputmode="decimal" instead of inputmode="none", and updated another test to expect inputmode="none"
has no effect instead of hiding the keyboard.

fast/forms/ios/inputmode-change-update-keyboard-expected.txt: Renamed from inputmode-none-removed-expected.txt.
fast/forms/ios/inputmode-change-update-keyboard.html: Renamed from inputmode-none-removed.html.
fast/forms/ios/inputmode-none-expected.txt:
fast/forms/ios/inputmode-none.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240571] by bshafiei@apple.com

6 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r240493. rdar://problem/47586905

REGRESSION (PSON): After swipe back, first few attempts to swipe forward not recognized as swipe gestures
https://bugs.webkit.org/show_bug.cgi?id=193818
<rdar://problem/47456584>

Reviewed by Tim Horton.

We don't hit the RenderTreeSizeThreshold milestone to remove the snapshot and allow interaction because we request it
from a wrong process (the one we are leaving behind).

UIProcess/Cocoa/ViewGestureController.cpp: (WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):

Request the RenderTreeSizeThreshold notification when the load has started and we know the process to use.

(WebKit::ViewGestureController::SnapshotRemovalTracker::hasOutstandingEvent):

UIProcess/Cocoa/ViewGestureController.h: (WebKit::ViewGestureController::SnapshotRemovalTracker::renderTreeSizeThreshold const): (WebKit::ViewGestureController::SnapshotRemovalTracker::setRenderTreeSizeThreshold):
UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::endSwipeGesture):

Don't request immediately, save the threshold to SnapshotRemovalTracker.

(WebKit::ViewGestureController::requestRenderTreeSizeNotificationIfNeeded):

Do the request to the right process.

WebProcess/WebPage/ViewGestureGeometryCollector.cpp: (WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):

Ensure we send the notification even if we reached the threshold before it was requested.

(WebKit::ViewGestureGeometryCollector::sendDidHitRenderTreeSizeThresholdIfNeeded):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):

WebProcess/WebPage/ViewGestureGeometryCollector.h: (WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240570] by bshafiei@apple.com

8 edits in branches/safari-607-branch

Cherry-pick r240490. rdar://problem/47586864

WKWebView.goBack should reload if there is a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193805
<rdar://problem/46908216>

Reviewed by Geoff Garen.

Source/WebKit:

If a WKWebView is showing a safe browsing warning and the user clicks a back button
in the app which calls WKWebView.goBack, the WKWebView is in a state where it has not navigated yet,
so actually going back will appear to the user to go back twice. We can't just do nothing because the
app is in a state where it is expecting a navigation to happen. Reloading achieves what the user expects
and makes the app work like the app expects.

UIProcess/API/C/WKPage.cpp: (WKPageGoBack):
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView goBack]):
UIProcess/PageClient.h: (WebKit::PageClient::hasSafeBrowsingWarning const):
UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::hasSafeBrowsingWarning const):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (+[Simple3LookupContext sharedLookupContext]): (-[Simple3LookupContext lookUpURL:completionHandler:]): (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]): (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240569] by bshafiei@apple.com

1 edit
3 adds in branches/safari-607-branch/Source/WebInspectorUI

Cherry-pick r240488. rdar://problem/47586897

Web Inspector: Add another Protocol Version (iOS 12.2)
https://bugs.webkit.org/show_bug.cgi?id=193810
<rdar://problem/42981838>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-25
Reviewed by Matt Baker.

UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js: Added.
Versions/Inspector-iOS-12.2.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:41 AM Changeset in webkit [240568] by bshafiei@apple.com

4 edits in branches/safari-607-branch

Cherry-pick r240485. rdar://problem/47586895

Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
https://bugs.webkit.org/show_bug.cgi?id=193788
<rdar://problem/47531231>

Reviewed by Alex Christensen.

Source/WebKit:

When the page starts a new provisional load, make sure we cancel any pending one in the provisional
process, as it would have happened in the first provisional load happened in the same process.
Without this, we could have 2 parallel loads happening, one in the committed process and another
in the provisional one, leading to assertion failures in debug.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240567] by bshafiei@apple.com

5 edits in branches/safari-607-branch

Cherry-pick r240477. rdar://problem/47586845

Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=193779
<rdar://problem/46170903>

Reviewed by Antti Koivisto.

Source/WebKit:

UIProcess/Cocoa/NavigationState.mm: (WebKit::tryAppLink): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): We were crashing when trying to get the URL of the main frame, which was sad because we never ended up using the main frame URL. Therefore, this patch drops the code in question.

UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): Add assertion to make sure that the DecidePolicyForNavigationActionAsync IPC it is getting from the process is related to its main frame.

Tools:

Add API test that quickly navigates forward to a previous process without waiting for it to
suspend. I suspect the crash could have been happening due to receiving leftover IPC from
the process' previous page when reconnecting the it for the forward navigation.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240566] by bshafiei@apple.com

2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r240451. rdar://problem/47586844

Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
https://bugs.webkit.org/show_bug.cgi?id=193778

Reviewed by Jon Lee.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240565] by bshafiei@apple.com

5 edits
1 add in branches/safari-607-branch

Cherry-pick r240450. rdar://problem/47586830

DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
https://bugs.webkit.org/show_bug.cgi?id=193741
<rdar://problem/47135030>

Reviewed by Antti Koivisto and Simon Fraser.

Source/WebCore:

fireLayoutRelatedMilestonesIfNeeded() is part of the post-layout tasks. In certain cases when

the received data is not "contentful" yet
and we are expecting some more (loading is not complete yet)
but no layout is initiated anymore

nothing triggers the milestone firing.

This patch ensures that we fire the DidFirstVisuallyNonEmptyLayout when the frame load is complete unless we already did.

page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::loadProgressingStatusChanged):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240564] by bshafiei@apple.com

8 edits
1 add in branches/safari-607-branch

Cherry-pick r240449. rdar://problem/47586886

stress/const-semantics.js fails a dfg-eager / ftl-eager run with an ASAN release build.
https://bugs.webkit.org/show_bug.cgi?id=190693

Reviewed by Michael Saboff.

JSTests:

stress/regress-190693.js: Added. (truth): (assert): (shouldThrowInvalidConstAssignment): (taz):

Source/JavaScriptCore:

JITStubRoutine's fields are marked only when JITStubRoutine::m_mayBeExecuting is true.
This becomes true when we find the executable address in our conservative roots, which
means that we could be executing it right now. This means that object liveness in
JITStubRoutine depends on the information gathered in ConservativeRoots. However, our
constraints are separated, "Conservative Scan" and "JIT Stub Routines". They can even
be executed concurrently, so that "JIT Stub Routines" may miss to mark the actually
executing JITStubRoutine because "Conservative Scan" finds it later.
When finalizing the GC, we delete the dead JITStubRoutines. At that time, since
"Conservative Scan" already finishes, we do not delete some JITStubRoutines which do not
mark the depending objects. Then, in the next cycle, we find JITStubRoutines still live,
attempt to mark the depending objects, and encounter the dead objects which are collected
in the previous cycles.

This patch removes "JIT Stub Routines" and merge it to "Conservative Scan". Since
"Conservative Scan" and "JIT Stub Routines" need to be executed only when the execution
happens (ensured by GreyedByExecution and CollectionPhase check), this change is OK for
GC stop time.

heap/ConservativeRoots.h: (JSC::ConservativeRoots::roots const): (JSC::ConservativeRoots::roots): Deleted.
heap/Heap.cpp: (JSC::Heap::addCoreConstraints):
heap/SlotVisitor.cpp: (JSC::SlotVisitor::append):
heap/SlotVisitor.h:
jit/GCAwareJITStubRoutine.cpp: (JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
jit/GCAwareJITStubRoutine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240563] by bshafiei@apple.com

3 edits
1 add in branches/safari-607-branch

Cherry-pick r240447. rdar://problem/47586899

Object Allocation Sinking phase can move a node that walks the stack into a place where the InlineCallFrame is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=193751
<rdar://problem/47280215>

Reviewed by Michael Saboff.

JSTests:

stress/object-allocation-sinking-phase-must-only-move-allocations-if-stack-trace-is-still-valid.js: Added. (let.thing): (foo.let.hello): (foo):

Source/JavaScriptCore:

The Object Allocation Sinking phase may move allocations around inside
of the program. However, it was not ensuring that it's still possible
to walk the stack at the point in the program that it moved the allocation to.
Certain InlineCallFrames rely on data in the stack when taking a stack trace.
All allocation sites can do a stack walk (we do a stack walk when we GC).
Conservatively, this patch says we're ok to move this allocation if we are
moving within the same InlineCallFrame. We could be more precise and do an
analysis of stack writes. However, this scenario is so rare that we just
take the conservative-and-straight-forward approach of checking that the place
we're moving to is the same InlineCallFrame as the allocation site.

In general, this issue arises anytime we do any kind of code motion.
Interestingly, LICM gets this right. It gets it right because the only
InlineCallFrames we can't move out of are the InlineCallFrames that
have metadata stored on the stack (callee for closure calls and argument
count for varargs calls). LICM doesn't have this issue because it relies
on Clobberize for doing its effects analysis. In clobberize, we model every
node within an InlineCallFrame that meets the above criteria as reading
from those stack fields. Consequently, LICM won't hoist any node in that
InlineCallFrame past the beginning of the InlineCallFrame since the IR
we generate to set up such an InlineCallFrame contains writes to that
stack location.

dfg/DFGObjectAllocationSinkingPhase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240562] by bshafiei@apple.com

9 edits in branches/safari-607-branch

Cherry-pick r240443. rdar://problem/47586900

[PSON] Flash on back navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=193716
<rdar://problem/47148458>

Reviewed by Chris Dumez.

Source/WebKit:

We close the page immediately if we fail to suspend. Layers disappear and we get a flash.

UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::~SuspendedPageProxy): (WebKit::SuspendedPageProxy::close):

Track closed state so we don't send the message twice, causing unhandled message errors in web process.

(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):

Close the suspended page if the suspension fails.
Skip this if we are using web process side compositing on Mac.

UIProcess/SuspendedPageProxy.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode):

On Mac, close the failed SuspendedPageProxy when entering compositing mode. At this point we don't need it to keep layers alive.

UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::closeFailedSuspendedPagesForPage):
UIProcess/WebProcessPool.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::suspendForProcessSwap):

Don't close the page on suspension failure. This is now managed by the UI process.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Closing of the previous page is delayed so waiting for didFinishNavigation is
not sufficient to guarantee we have received all the messages. Wait for them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240561] by bshafiei@apple.com

4 edits in branches/safari-607-branch

Cherry-pick r240442. rdar://problem/47586826

Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
https://bugs.webkit.org/show_bug.cgi?id=193761
<rdar://problem/47456405>

Reviewed by Alex Christensen.

Source/WebKit:

When doing a history navigation cross-process, the UIProcess would first send the back/forward list items
to the destination WebProcess via WebPage::updateBackForwardListForReattach(), then ask the process to
navigate to the expected back/forward list item.

WebPage::updateBackForwardListForReattach() would call restoreSessionInternal(), which would call
toHistoryItem() on each BackForwardListItem. This may end up creating more than one HistoryItem for each
BackForwardListItem because HistoryItems are part of a tree (each frame has its own list of history items).

Note that BackForwardListItems and HistoryItem share a BackForwardItemIdentifier which is a
(processIdentifier, itemIdentifier) pair. We normally generate the HistoryItem's identifier from inside
its constructor like so:
{ Process::identifier(), generateObjectIdentifier<BackForwardItemIdentifier::ItemIdentifierType>() }

However, when calling updateBackForwardListForReattach() and constructing children HistoryItem,
applyFrameState() would generate the identifier by itself and passing it to the HistoryItem constructor.
Its genegates the ID the exact same way so this would in theory not be a problem. Unfortunately, both
calls to generateObjectIdentifier() get inlined and both call sites end up with their own static counter
to generate ids. As a result, we may end up with conflicts as HistoryItems for child frames (restored
by restoreSessionInternal()) can end up with the same identifier as HistoryItems for top frames.

This confusion would lead to the WebContent process sending the UIProcess bad information and the URL
of subframes could end up as the WebBackForwardListItem's mainframe URL.

WebProcess/WebCoreSupport/SessionStateConversion.cpp: (WebKit::applyFrameState): Stop calling generateObjectIdentifier() explicitly and let the HistoryItem constructor take care of it. Calling generateObjectIdentifier() for the same type from different places is not safe due to inlining.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 AM Changeset in webkit [240560] by bshafiei@apple.com

4 edits
1 add in branches/safari-607-branch

Cherry-pick r240364. rdar://problem/47586820

[DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
https://bugs.webkit.org/show_bug.cgi?id=193711
<rdar://problem/47250262>

Reviewed by Saam Barati.

JSTests:

stress/availability-was-cleared-when-locals-are-not-live.js: Added. (shouldBe): (foo): (bar): (baz):

Source/JavaScriptCore:

When pruning OSR Availability based on bytecode liveness, we accidentally clear the Availability (making it DeadFlush) instead of
making it Availability::unavailable() (Making it ConflictingFlush). In OSRAvailabilityAnalysisPhase, we perform forward analysis.
We first clear all the availability of basic blocks DeadFlush, which is an empty set. And then, we set operands in the root block
ConflictingFlush. In this forward analysis, DeadFlush is BOTTOM, and ConflictingFlush is TOP. Then, we propagate information by
merging availability until we reach to the fixed-point. As an optimization, we perform "pruning" of the availability in the head
of the basic blocks. We remove availabilities of operands which are not live in the bytecode liveness at the head of the basic block.
The problem is, when removing availabilities, we set DeadFlush for them instead of ConflictingFlush. Basically, it means that we set
BOTTOM (an empty set) instead of TOP. Let's consider the following simple example. We have 6 basic blocks, and they are connected
as follows.

BB0 -> BB1 -> BB2 -> BB4

| \ ^{v > BB3 /}

BB5

And consider about loc1 in FTL, which is required to be recovered in BB4's OSR exit.

BB0 does nothing

head: loc1 is dead
tail: loc1 is dead

BB1 has MovHint @1, loc1

head: loc1 is dead
tail: loc1 is live

BB2 does nothing

head: loc1 is live
tail: loc1 is live

BB3 has PutStack @1, loc1

head: loc1 is live
tail: loc1 is live

BB4 has OSR exit using loc1

head: loc1 is live
tail: loc1 is live (in bytecode)

BB5 does nothing

head: loc1 is dead
tail: loc1 is dead

In our OSR Availability analysis, we always prune loc1 result in BB1's head since its head says "loc1 is dead".
But at that time, we clear the availability for loc1, which makes it DeadFlush, instead of making it ConflictingFlush.

So, the flush format of loc1 in each tail of BB is like this.

BB0

ConflictingFlush (because all the local operands are initialized with ConflictingFlush)

BB1

DeadFlush+@1 (pruning clears it)

BB2

DeadFlush+@1 (since it is propagated from BB1)

BB3

FlushedJSValue+@1 with loc1 (since it has PutStack)

BB4

FlushedJSValue+@1 with loc1 (since MERGE(DeadFlush, FlushedJSValue) = FlushedJSValue)

BB5

DeadFlush (pruning clears it)

Then, if we go the path BB0->BB1->BB2->BB4, we read the value from the stack while it is not flushed.
The correct fix is making availability "unavailable" when pruning based on bytecode liveness.

dfg/DFGAvailabilityMap.cpp: (JSC::DFG::AvailabilityMap::pruneByLiveness): When pruning availability, we first set all the operands Availability::unavailable(), and copy the calculated value from the current availability map.
dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::OSRAvailabilityAnalysisPhase::run): Add logging things for debugging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:29 AM Changeset in webkit [240559] by Nikita Vasilyev

16 edits
2 adds in trunk

Web Inspector: Add Changes panel to Elements tab
https://bugs.webkit.org/show_bug.cgi?id=193803

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Introduce the new experimental Changes Panel. It shows a list of CSS changes
made via Web Inspector, so the changes could be copied to the source files.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Setting.js:
UserInterface/Base/Utilities.js:

(Array.diffArrays): Added.

UserInterface/Controllers/CSSManager.js:

(WI.CSSManager):
(WI.CSSManager.prototype.get modifiedCSSRules):
(WI.CSSManager.prototype.addModifiedCSSRule):
(WI.CSSManager.prototype.removeModifiedCSSRule):
(WI.CSSManager.prototype._mainResourceDidChange):

UserInterface/Main.html:
UserInterface/Models/CSSProperty.js:

(WI.CSSProperty):
(WI.CSSProperty.prototype.remove):
(WI.CSSProperty.prototype.replaceWithText):
(WI.CSSProperty.prototype.commentOut):
(WI.CSSProperty.prototype.set text):
(WI.CSSProperty.prototype.get modified):
(WI.CSSProperty.prototype.set name):
(WI.CSSProperty.prototype.set rawValue):
(WI.CSSProperty.prototype.get initialState):
(WI.CSSProperty.prototype._updateOwnerStyleText):
(WI.CSSProperty.prototype._markModified):
Mark CSSProperty modified *before* making any changes to copy its initial state.

UserInterface/Models/CSSRule.js:

(WI.CSSRule):
(WI.CSSRule.prototype.get id):
(WI.CSSRule.prototype.get initialState):
(WI.CSSRule.prototype.get stringId):
(WI.CSSRule.prototype.markModified):

UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration):
(WI.CSSStyleDeclaration.prototype.get initialState):
(WI.CSSStyleDeclaration.prototype.get enabledProperties):
(WI.CSSStyleDeclaration.prototype.get properties):
(WI.CSSStyleDeclaration.prototype.set properties):
(WI.CSSStyleDeclaration.prototype.propertyForName):
(WI.CSSStyleDeclaration.prototype.newBlankProperty):
(WI.CSSStyleDeclaration.prototype.markModified):

UserInterface/Views/ChangesDetailsSidebarPanel.css: Added.

(.sidebar > .panel.changes-panel):
(.sidebar > .panel.changes-panel:not(.empty)):
(.sidebar > .panel.changes-panel.empty):
(.changes-panel ins):
(.changes-panel del):
(.changes-panel del.css-property::before):
(.changes-panel ins.css-property::before):
(@media (prefers-color-scheme: dark)):

UserInterface/Views/ChangesDetailsSidebarPanel.js: Added.

(WI.ChangesDetailsSidebarPanel):
(WI.ChangesDetailsSidebarPanel.prototype.inspect):
(WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
(WI.ChangesDetailsSidebarPanel.prototype.shown):
(WI.ChangesDetailsSidebarPanel.prototype.detached):
(WI.ChangesDetailsSidebarPanel.prototype.layout):
(WI.ChangesDetailsSidebarPanel.prototype._mainResourceDidChange):

UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property):
(.spreadsheet-style-declaration-editor .property.modified):
(.spreadsheet-style-declaration-editor .property.modified:not(.selected)):
(@media (prefers-color-scheme: dark)):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.updateStatus):

LayoutTests:

Test newly added Array.diffArrays.

inspector/unit-tests/array-utilities-expected.txt:
inspector/unit-tests/array-utilities.html:

Use the old InspectorTest.log method since it shows diffs for actual and expected text.

Jan 27, 2019:

7:03 PM Changeset in webkit [240558] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Unreviewed, fix WPE/GTK debug builds after r240557
https://bugs.webkit.org/show_bug.cgi?id=192742
<rdar://problem/46757369>

Also fix an improper format string that was recently added in a different commit.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):

5:56 PM Changeset in webkit [240557] by Darin Adler

115 edits in trunk

Replace many uses of String::format with more type-safe alternatives
https://bugs.webkit.org/show_bug.cgi?id=192742

Reviewed by Mark Lam.

Source/JavaScriptCore:

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeCall): Use makeString.
(Inspector::InjectedScriptBase::makeAsyncCall): Ditto.

inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::getPropertyValue): Ditto.

inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable): Ditto.

jsc.cpp:

(FunctionJSCStackFunctor::operator() const): Ditto.

runtime/CodeCache.cpp:

(JSC::writeCodeBlock): Use makeString's numeric capabilities instead of
using String::number.

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat): Use string concatenation.

runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList): Ditto.

Source/WebCore:

A while back, String::format was more efficient than string concatenation,
but that is no longer true, and we should prefer String::number, makeString,
or concatenation with the "+" operator to String::format for new code.

This is not as good for programmers who are fond of printf formatting
style, and in some cases it's a little harder to read the strings
interspersed with variables rather than a format string, but it's better
in a few ways:

more efficient (I didn't measure the difference, but it's definitely slower to use String::Format which calls vsnprintf twice than to use the WTF code)
works in a type-safe way without a need to use a format specifier such as "%" PRIu64 or "%tu" making it much easier to avoid problems due to subtle differences between platforms
allows us to use StringView in some cases to sidestep the need to allocate temporary WTF::String objects
does not require converting each WTF::String to a C string, allowing us to remove many cases of ".utf8().data()" and similar expressions, eliminating the allocation of temporary WTF::CString objects

This patch covers a batch of easiest-to-convert call sites.
Later patches will allow us to deprecate or remove String::format.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Use makeString.

Modules/indexeddb/shared/IDBCursorInfo.cpp:

(WebCore::IDBCursorInfo::loggingString const): Ditto.

Modules/indexeddb/shared/IDBGetAllRecordsData.cpp:

(WebCore::IDBGetAllRecordsData::loggingString const): Ditto.

Modules/indexeddb/shared/IDBGetRecordData.cpp:

(WebCore::IDBGetRecordData::loggingString const): Ditto.

Modules/indexeddb/shared/IDBIndexInfo.cpp:

(WebCore::IDBIndexInfo::loggingString const): Ditto.
(WebCore::IDBIndexInfo::condensedLoggingString const): Ditto.

Modules/indexeddb/shared/IDBIterateCursorData.cpp:

(WebCore::IDBIterateCursorData::loggingString const): Ditto.

Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:

(WebCore::IDBObjectStoreInfo::condensedLoggingString const): Ditto.

Modules/indexeddb/shared/IDBResourceIdentifier.cpp:

(WebCore::IDBResourceIdentifier::loggingString const): Ditto.

Modules/webdatabase/Database.cpp:

(WebCore::formatErrorMessage): Ditto.

Modules/webdatabase/SQLError.h:

(WebCore::SQLError::create): Ditto.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Use makeString.

bindings/scripts/test/JS/JSInterfaceName.cpp:
bindings/scripts/test/JS/JSMapLike.cpp:
bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
bindings/scripts/test/JS/JSTestCEReactions.cpp:
bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
bindings/scripts/test/JS/JSTestCallTracer.cpp:
bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
bindings/scripts/test/JS/JSTestDOMJIT.cpp:
bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestException.cpp:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
bindings/scripts/test/JS/JSTestIterable.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
bindings/scripts/test/JS/JSTestPluginInterface.cpp:
bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
bindings/scripts/test/JS/JSTestSerialization.cpp:
bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestStringifier.cpp:
bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
bindings/scripts/test/JS/JSTestTypedefs.cpp:

Updated expected results.

Source/WebKit:

Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::writeHeaders): Use makeString.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::makeCredential): Use string concatentation.

UIProcess/WebInspectorUtilities.cpp:

(WebKit::inspectorPageGroupIdentifierForPage): Use makeString.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processDidFinishLaunching): Ditto.
(WebKit::WebProcessPool::startMemorySampler): Ditto.

Source/WebKitLegacy:

Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::writeHeaders): Use makeString.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::makeCredential): Use string concatentation.

UIProcess/WebInspectorUtilities.cpp:

(WebKit::inspectorPageGroupIdentifierForPage): Use makeString.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processDidFinishLaunching): Ditto.
(WebKit::WebProcessPool::startMemorySampler): Ditto.

Source/WTF:

wtf/WorkQueue.cpp:

(WTF::WorkQueue::concurrentApply): Use makeString.

wtf/dtoa.cpp:

(WTF::dtoa): Use sprintf instead of String::format in the comments,
since these functions have nothing to do with WTF::String.

Tools:

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::cacheTestRunnerCallback): Use makeString.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
(WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.

3:51 PM Changeset in webkit [240556] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Remove a couple of PLATFORM defines intended for watchOS
https://bugs.webkit.org/show_bug.cgi?id=193888

Reviewed by Alexey Proskuryakov.

Remove the use of !PLATFORM(WATCH), since this is true on every platform.

editing/cocoa/DictionaryLookup.mm:

12:44 PM Changeset in webkit [240555] by jiewen_tan@apple.com

11 edits
3 copies in trunk

Use a load optimizer for some sites
https://bugs.webkit.org/show_bug.cgi?id=193881
<rdar://problem/46325455>

Reviewed by Brent Fulgham.

Source/WebCore:

Expose FormData::flatten to be used by the load optimizer.

WebCore.xcodeproj/project.pbxproj:
platform/network/FormData.h:

Source/WebKit:

We will try to speed up some sites with a dedicated load optimizer. The load optimizer lives
within the WebsiteDataStore as one client instance should have only one and it should live
as long as the client lives. How does the load optimizer work? It intercepts every load in
the navigation state. If a request meets some requirements, it will then fetch the request
from its own cache. Once the fetch succeeds, the original load will be ignored and the
optimizer will display the cached content.

Covered by API tests.

SourcesCocoa.txt:
UIProcess/Cocoa/LoadOptimizer.h: Added.
UIProcess/Cocoa/LoadOptimizer.mm: Added.
UIProcess/Cocoa/MediaCaptureUtilities.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::tryInterceptNavigation):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::tryAppLink): Deleted.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::loadOptimizer):

WebKit.xcodeproj/project.pbxproj:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.

10:36 AM Changeset in webkit [240554] by BJ Burg

10 edits
2 adds in trunk/Source/WebKit

Web Automation: add support for simulating single touches to Automation.performInteractionSequence
https://bugs.webkit.org/show_bug.cgi?id=193852
<rdar://problem/28360781>

Reviewed by Joseph Pecoraro and Simon Fraser.

This patch makes it possible to simulate touches via the Actions API. The approach is to
use a stripped down version of HIDEventGenerator to send HID events to the UIWindow.
The initial version supports a single touch point; this may be expanded if needed, but
so far it hasn't been an impediment when running desktop-oriented WebDriver test suites.

As part of implementing this support, I went through and added [somewhat obnoxious] ENABLE()
guards so that we don't mistakenly compile mouse support on iOS and touch on Mac,
and vice versa. Each of the interaction methods---touch, mouse, keyboard---can be independently
compiled out. If none is supported (i.e., Windows), then we don't even try to compile
platformSimulate*Interaction methods or SimulatedInputDispatcher. This allows WebAutomationSession
to not include members and code that are never going to be used on a particular platform.

This functionality is covered by existing WebDriver test suites that use Element Click command.
Additional tests that explicitly include 'touch' pointerType will be submitted to WPT later.

UIProcess/Automation/Automation.json: Update comment.

UIProcess/Automation/SimulatedInputDispatcher.h:
UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

Add appropriate guards for code specific to each interaction type.
Handle SimulatedInputSourceType::Touch and call out to dispatch events.

UIProcess/Automation/WebAutomationSession.h:
UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::terminate):
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
(WebKit::WebAutomationSession::mouseEventsFlushedForPage):
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::willClosePage):
Add appropriate guards for code specific to each interaction type.

(WebKit::WebAutomationSession::isSimulatingUserInteraction const):
Add new hook so that we can detect when a touch simulation is in progress.
We don't rely on checking WebKit's event queue, so use a flag.

(WebKit::WebAutomationSession::simulateTouchInteraction):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::cancelInteractionSequence):
(WebKit::WebAutomationSession::performInteractionSequence):

Add appropriate guards for code specific to each interaction type.
Bail out immediately if a requested interaction type is not supported.
Shim Touch input type to Mouse if mouse is not supported but touches are.

Nearly all WebDriver tests in the wild will be requesting a 'mouse' pointerType,
so this is necessary for compatibility. It's easier to shim at this level than try
to implement platformSimulateMouseInteraction for iOS because
platformSimulateMouseinteraction does not use a completion handler but the iOS
implementation would require that.

(WebKit::WebAutomationSession::platformSimulateMouseInteraction): Deleted.
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Deleted.

Remove these stubs. Platform methods of this class are no longer being filled

with stubs on unsupported platforms because we expect the command to fail earlier.

UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateTouchInteraction):

Add appropriate guards for code specific to each interaction type.
Implement new platform method to simulate touches. This uses _WKTouchEventGenerator.

UIProcess/Automation/mac/WebAutomationSessionMac.mm:

Add appropriate guards for code specific to each interaction type.

UIProcess/_WKTouchEventGenerator.h: Added.
UIProcess/_WKTouchEventGenerator.mm: Added.

(simpleCurveInterpolation):
(calculateNextCurveLocation):
(delayBetweenMove):
(+[_WKTouchEventGenerator sharedTouchEventGenerator]):
(+[_WKTouchEventGenerator nextEventCallbackID]):
(-[_WKTouchEventGenerator init]):
(-[_WKTouchEventGenerator dealloc]):
(-[_WKTouchEventGenerator _createIOHIDEventType:]):
(-[_WKTouchEventGenerator _sendHIDEvent:]):
(-[_WKTouchEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[_WKTouchEventGenerator _updateTouchPoints:count:]):
(-[_WKTouchEventGenerator touchDownAtPoints:touchCount:]):
(-[_WKTouchEventGenerator touchDown:touchCount:]):
(-[_WKTouchEventGenerator touchDown:]):
(-[_WKTouchEventGenerator liftUpAtPoints:touchCount:]):
(-[_WKTouchEventGenerator liftUp:touchCount:]):
(-[_WKTouchEventGenerator liftUp:]):
(-[_WKTouchEventGenerator moveToPoints:touchCount:duration:]):
(-[_WKTouchEventGenerator touchDown:completionBlock:]):
(-[_WKTouchEventGenerator liftUp:completionBlock:]):
(-[_WKTouchEventGenerator moveToPoint:duration:completionBlock:]):
(-[_WKTouchEventGenerator receivedHIDEvent:]):
Copied and simplified from HIDEventGenerator in WebKitTestRunner.

WebKit.xcodeproj/project.pbxproj:

Add _WKTouchEventGenerator.{h,mm} and make it a private header. The client needs to
route received HID events to -receivedHIDEvent: in order to detect when the marker
HID event has been processed (and thus the interaction is completed).

config.h: Add ENABLE(WEBDRIVER_*_INTERACTIONS) macros here.

8:58 AM Changeset in webkit [240553] by Simon Fraser

26 edits in trunk

Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node
https://bugs.webkit.org/show_bug.cgi?id=193879

Reviewed by Antti Koivisto.

Source/WebCore:

Currently we parent iframe scrolling tree nodes by finding the closest ancestor layer with a scrolling tree node.
This results in scrolling tree nodes being connected across iframe boundaries in some arbitrary ancestor. This
makes updating scrolling tree geometry very error-prone, since changes in the parent document will need to trigger
updates of the scrolling tree node in an iframe.

To address this, I already added a new "FrameHosting" scrolling node type. This patch actually instantiates these
nodes, which are owned by the RenderIFrame's composited layer. Connecting across frame boundaries is theforefore
simply a case of getting the FrameHosting node from the ownerElement's renderer; this is very similar to how we
connect GraphicsLayers together.

RenderLayerBacking gains another scrolling role for FrameHosting and ScrollingNodeID.

Tested by existing tests.

page/FrameView.h:
rendering/RenderLayer.cpp:

(WebCore::outputPaintOrderTreeRecursive):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):

rendering/RenderLayerCompositor.cpp:

(WebCore::frameContentsRenderView):
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::isLayerForIFrameWithScrollCoordinatedContents const):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::scrollCoordinatedAncestorInParentOfFrame):
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

rendering/RenderLayerCompositor.h:
testing/Internals.cpp:

(WebCore::Internals::scrollingStateTreeAsText const):

Source/WebKit:

Need a specialization of dump() for ScrollingStateFrameHostingNode to avoid infinite recursion.

Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::dump):

LayoutTests:

New test results with FrameHosting nodes.

platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
platform/ios-wk2/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:

12:49 AM Changeset in webkit [240552] by Chris Fleizach

27 edits
6 adds in trunk

Source/JavaScriptCore:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Reviewed by Ryosuke Niwa.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Reviewed by Ryosuke Niwa.

In order to improve performance when requesting the accessibility hierarchy, we introduce the idea of a "static accessibility tree" which
could be accessed on a different thread by assistive technologies.
That is accomplished by storing all the data needed to answer accessibility attribute queries in a static object that mirrors the
"live" AccessibilityObjects (which interact with both DOM and Render trees).
These static objects are generally created after layout is done and final tasks are being performed. They are then stored in the static tree
representation and able to be read from anywhere.
Tactically this is done with AXIsolatedTreeNodes inside of an AXIsolatedTree. The TreeNodes implement an AccessibilityObjectInterface shared
with AccessibilityObject.
This allows the wrappers to access either one depending on conditions and platforms without significant code duplication or re-organization.

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::createIsolatedAccessibilityTree):
(WebCore::AXObjectCache::generateStaticAccessibilityTreeIfNeeded):

accessibility/AXObjectCache.h:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h: Added.
accessibility/isolatedtree: Added.
accessibility/isolatedtree/AXIsolatedTree.cpp: Added.

(WebCore::AXIsolatedTree::treeCache):
(WebCore::AXIsolatedTree::AXIsolatedTree):
(WebCore::AXIsolatedTree::create):
(WebCore::AXIsolatedTree::treeForID):
(WebCore::AXIsolatedTree::treeForPageID):
(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::rootNode):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::appendNodeChanges):
(WebCore::AXIsolatedTree::applyPendingChanges):

accessibility/isolatedtree/AXIsolatedTree.h: Added.

(WebCore::AXIsolatedTree::treeIdentifier const):

accessibility/isolatedtree/AXIsolatedTreeNode.cpp: Added.

To note: we don't mark the attribute map const because even though attributes don't change after initial creation,
we may copy an existing node and replace specific values.

(WebCore::AXIsolatedTreeNode::AXIsolatedTreeNode):
(WebCore::AXIsolatedTreeNode::create):
(WebCore::AXIsolatedTreeNode::initializeAttributeData):
(WebCore::AXIsolatedTreeNode::setProperty):
(WebCore::AXIsolatedTreeNode::doubleAttributeValue const):
(WebCore::AXIsolatedTreeNode::unsignedAttributeValue const):
(WebCore::AXIsolatedTreeNode::boolAttributeValue const):
(WebCore::AXIsolatedTreeNode::stringAttributeValue const):
(WebCore::AXIsolatedTreeNode::intAttributeValue const):

accessibility/isolatedtree/AXIsolatedTreeNode.h: Added.
accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::associateIsolatedTreeNode):

accessibility/mac/WebAccessibilityObjectWrapperBase.h:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapperBase isolatedTreeNode]):
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

dom/Document.cpp:

(WebCore::Document::pageID const):

dom/Document.h:

Source/WebCore/PAL:
AX: Introduce isolated accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Reviewed by Ryosuke Niwa.

Configurations/FeatureDefines.xcconfig:

Source/WebKit:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Reviewed by Ryosuke Niwa.

Configurations/FeatureDefines.xcconfig:
WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):

Source/WebKitLegacy/mac:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Reviewed by Ryosuke Niwa.

Configurations/FeatureDefines.xcconfig:

Tools:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>

Context Navigation

Timeline

Jan 28, 2019:

Jan 27, 2019:

Download in other formats: