⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 10, 2019:

10:36 PM Changeset in webkit [241258] by Carlos Garcia Campos
  • 8 edits in trunk

[GTK][WPE] Add enable-javascript-markup setting
​https://bugs.webkit.org/show_bug.cgi?id=193439

Reviewed by Michael Catanzaro.

Source/WebKit:

Expose JavaScriptMarkupEnabled setting in the GLib API.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_javascript_markup):
(webkit_settings_set_enable_javascript_markup):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/wpe/WebKitSettings.h:
  • UIProcess/API/wpe/docs/wpe-0.1-sections.txt:

Tools:

Add test cases to check the new setting.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):
(testWebKitSettingsJavaScriptMarkup):
(beforeAll):

10:17 PM Changeset in webkit [241257] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC] Fix spelling error.
​https://bugs.webkit.org/show_bug.cgi?id=194489

Reviewed by Simon Fraser.

instrinsic -> intrinsic

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

  • layout/FormattingState.h:

(WebCore::Layout::FormattingState::setIntrinsicWidthConstraints):
(WebCore::Layout::FormattingState::clearIntrinsicWidthConstraints):
(WebCore::Layout::FormattingState::intrinsicWidthConstraints const):
(WebCore::Layout::FormattingState::setInstrinsicWidthConstraints): Deleted.
(WebCore::Layout::FormattingState::clearInstrinsicWidthConstraints): Deleted.
(WebCore::Layout::FormattingState::instrinsicWidthConstraints const): Deleted.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::intrinsicWidthConstraints const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const): Deleted.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraintsNeedChildrenWidth):
(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraintsNeedChildrenWidth): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints): Deleted.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::intrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
10:02 PM Changeset in webkit [241256] by Darin Adler
  • 20 edits in trunk

Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
​https://bugs.webkit.org/show_bug.cgi?id=194485

Reviewed by Daniel Bates.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json): Use appendUnsignedAsHex along with
reinterpret_cast<uintptr_t> to replace uses of String::format with "%p".

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode): Removed some unneeded casts in StringBuilder code,
including one in a call to appendByteAsHex.
(JSC::globalFuncEscape): Ditto.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::encodeProtocolString): Use appendUnsignedAsHexFixedSize instead of String::format.

  • css/parser/CSSParserToken.cpp:

(WebCore::CSSParserToken::serialize const): Fixed style of many return statements
that called a function returning void; doesn't match WebKit's prevailing style.
Also use break instead of return. Used appendLiteral instead of append in many
cases, and append character instead of single-character literal in others.
Use appendUnsignedAsHex instead of String::format.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::generateHashedName): Use appendUnsignedAsHex instad of appendUnsigned64AsHex.
Should come back here and use makeString once we make HexNumber.h work with that.

  • platform/mac/WebCoreNSURLExtras.mm: Removed unnecessary include of HexNumber.h.
  • rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables): Use appendLiteral instead of multiple calls
to character append. Touched because it was next to a call to appendUnsignedAsHex.

Source/WebKit:

  • UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::completeDeviceIdHashSaltForOriginCall): Use
appendUnsignedAsHex instead of appendUnsigned64AsHex.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::loggingString): Use appendUnsignedAsHex and
reinterpret_cast<uintptr_t> instead of String::format and "%p".

Source/WTF:

  • wtf/HexNumber.h: Removed unused functions placeByteAsHexCompressIfPossible and

placeByteAsHex. Can always bring them back if someone needs them. Updated
appendUnsignedAsHex to be a template so we can use it on any integer type,
got rid of unnecessary use of Vector and unnecessary reversing, and got rid of
appendUnsigned64AsHex since callers can now just use appendUnsignedAsHex.
Rewrote appendUnsignedAsHexFixedSize to share mode code rather than replicating.

  • wtf/Logger.h: Use appendUnsignedAsHex instead of appendUnsigned64AsHex.
  • wtf/URL.cpp: Removed unnecessary include of HexNumber.h.
  • wtf/cocoa/NSURLExtras.h: Added missing include of Foundation.h that was

worked around in NSURLExtras.mm.

  • wtf/cocoa/NSURLExtras.mm: Removed unnecessary includes of HexNumber.h

and Foundation.h.

Tools:

  • WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
8:10 PM Changeset in webkit [241255] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r241230.
​https://bugs.webkit.org/show_bug.cgi?id=194488

"It regressed JetStream2 by ~6%" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"We should only make rope strings when concatenating strings
long enough."
​https://bugs.webkit.org/show_bug.cgi?id=194465
​https://trac.webkit.org/changeset/241230

7:25 PM Changeset in webkit [241254] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BBQ-Air: Emit better code for switch
​https://bugs.webkit.org/show_bug.cgi?id=194053

Reviewed by Yusuke Suzuki.

Instead of emitting a linear set of jumps for Switch, this patch
makes the BBQ-Air backend emit a binary switch.

  • wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addSwitch):

4:29 PM Changeset in webkit [241253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

libWPEWebKit-0.1.so: undefined reference to `JSC::JSValue::asCell() const
​https://bugs.webkit.org/show_bug.cgi?id=194484

Patch by Pablo Saavedra <Pablo Saavedra> on 2019-02-10
Reviewed by Darin Adler.

  • bindings/js/JSUndoItemCustom.cpp:
11:44 AM Changeset in webkit [241252] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r241167.
​https://bugs.webkit.org/show_bug.cgi?id=194482

Broke the GTK mediastream tests (Requested by philn on
#webkit).

Reverted changeset:

"Filter out Overconstrainederror.constraint when getUserMedia
is not granted"
​https://bugs.webkit.org/show_bug.cgi?id=194240
​https://trac.webkit.org/changeset/241167

11:34 AM Changeset in webkit [241251] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK Debug build fix after r241148.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
SourceBuffer::logClassName and friends are declared for
!RELEASE_LOG_DISABLED builds so adapt calling sites accordingly.

10:03 AM Changeset in webkit [241250] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Add intrinsic width support for inline-block boxes
​https://bugs.webkit.org/show_bug.cgi?id=194479

Reviewed by Antti Koivisto.

Compute the intrinsic width for the inline-block (formatting context root) and set it as the content box width while
laying out the content for the min/max width.

<div style="position: absolute">before<span id=inline-block style="display: inline-block">inline_block content<span>after</div>

The "inline-block" formatting root returns "inline_block" width for the minimum and "inline_block width" for
the maximum width. These min/max values are used to figure out the intrinsic width for the parent <div>.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):

  • layout/inlineformatting/InlineFormattingContext.h:
  • page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

8:53 AM Changeset in webkit [241249] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Add intrinsic width support for replaced boxes
​https://bugs.webkit.org/show_bug.cgi?id=194478

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):
(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeMarginBorderAndPadding const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
6:38 AM Changeset in webkit [241248] by aboya@igalia.com
  • 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Add missing return type to lambda
​https://bugs.webkit.org/show_bug.cgi?id=194414

Reviewed by Darin Adler.

Since g_signal_connect() is untyped, a compiler error was not
generated when a lambda with a missing GstFlowReturn return type was
provided for a signal that expects it.

This used to work before r240784 because a recent function call had
set GST_FLOW_OK in the return value register and it happened to
survive until the lambda function call ended. Starting on that commit
such return value was removed and it stopped working on debug.

Of course, the actual problem is in the signature of the lambda
function, and this patch fixes that.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):

Feb 9, 2019:

4:41 PM Changeset in webkit [241247] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Add more tests for clampTo<>()
​https://bugs.webkit.org/show_bug.cgi?id=194462

Reviewed by Geoffrey Garen.

Darin suggested to test the very last floating point number
at the boundaries when truncating to integer.
I added test for max/min and max-1/min-1.

  • TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

3:16 PM Changeset in webkit [241246] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, Lexer should use isLatin1 implementation in WTF
​https://bugs.webkit.org/show_bug.cgi?id=194466

Follow-up after r241233 pointed by Darin.

  • parser/Lexer.cpp:

(JSC::isLatin1): Deleted.

1:00 PM Changeset in webkit [241245] by Darin Adler
  • 5 edits in trunk

Fix change log dates; I thought webkit-patch land would do it for me

1:00 PM Changeset in webkit [241244] by Darin Adler
  • 58 edits in trunk

Eliminate unnecessary String temporaries by using StringConcatenateNumbers
​https://bugs.webkit.org/show_bug.cgi?id=194021

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::count): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::objectGroupForBreakpointAction): Ditto.
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl): Ditto.
(Inspector::InspectorDebuggerAgent::setBreakpoint): Ditto.

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty): Ditto.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed): Use String::numberToStringFixedWidth instead
of calling numberToFixedWidthString to do the same thing.
(JSC::numberProtoFuncToPrecision): Use String::number instead of calling
numberToFixedPrecisionString to do the same thing.

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions): Ditto.

Source/WebCore:

For floating point numbers, String::number gives a fixed precision result,
stripping trailing zeroes. When possible, I changed the code to instead use the
equivalent of String::numberToStringECMAScript, which is what makeString does by
default for floating point, gives the same results for many cases, and gives
better results in many others. However, for floats, we do not yet have a good
implementation, so instead I used FormattedNumber::fixedPrecision to match
the old behavior.

  • Modules/indexeddb/shared/IDBTransactionInfo.cpp:

(WebCore::IDBTransactionInfo::loggingString const): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create): Ditto.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect): Ditto. Added a cast to "unsigned" to sidestep the
ambiguity with 16-bit unsigned types that are sometimes used for numbers (uint16_t)
and sometimes used for UTF-16 code units (UChar) and can be the same type.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream): Use ASCIILiteral when intializing
a string instead of just a normal C literal. Switched to makeString so we could
remove String::number and do the conversion without allocating/destroying a String.
(WebCore::WebSocketChannel::didFail): Ditto.
(WebCore::WebSocketChannel::processFrame): Ditto.

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::WebSocketFrame::parseFrame): Ditto.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake): Ditto.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA const): Ditto.

  • bindings/js/JSDOMConvertNumbers.cpp:

(WebCore::rangeErrorString): Ditto.

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCSSText const): Ditto. Used
FormattedNumber::fixedPrecision since these are floats.

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::toString const): Use
StringBuilder::builder.appendECMAScriptNumber instead of
String::numberToStringECMAScript so we can do it without allocating/destroying
a String.

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString const): Ditto.

  • dom/MessagePortIdentifier.h:

(WebCore::MessagePortIdentifier::logString const): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • editing/cocoa/DataDetection.mm:

(WebCore::dataDetectorStringForPath): Remove unnecessary type casts on values
passed to String::number and to StringBuilder::appendNumber. These could do
harm if the values were out of range, and should not be necessary.

  • history/BackForwardItemIdentifier.h:

(WebCore::BackForwardItemIdentifier::logString const): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString): Ditto.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::getUniformLocation): Ditto.
(WebCore::WebGLRenderingContextBase::checkTextureCompleteness): Ditto.

  • inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::didReceiveResponse): Ditto.

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFailLoadingManifest): Ditto.

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame): Ditto.

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Ditto.
(WebCore::PrintContext::pageSizeAndMarginsInPixels): Ditto.

  • page/WheelEventTestTrigger.cpp:

(WebCore::dumpState): Use StringBuilder::appendNumber instead of
String::number so we can do it without allocating/destroying a String.
Also use StringBuilder::appendLiteral on a literal.

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::ResourceUsageOverlay::platformDraw): Pass explicit
KeepTrailingZeros to FormattedNumber::fixedPrecision to preserve behavior,
since default is now to truncate trailing zeros.

  • platform/graphics/Color.cpp:

(WebCore::Color::cssText): Use StringBuilder::appendNumber instead of
calling numberToFixedPrecisionString to do the same thing.

  • platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::cssText): Ditto.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::animationIdentifier): Remove String::number and let makeString
do the conversion without allocating/destroying a String. Had to add
a typecast to convert the enumeration into an integer.

  • platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(WebCore::PlatformCAFilters::setFiltersOnLayer): Ditto.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::description const): Ditto.

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::MockMediaSample): Use AtomicString::number
instead of String::number to avoid unneccessarily allocating an additional
temporary String when an AtomicString already exists.

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::reportErrorToClient): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::setMaximumSize): Ditto.
(WebCore::SQLiteDatabase::setSynchronous): Ditto. Had to add a typecast to
convert the enumeration into an integer.

  • svg/SVGAngleValue.cpp:

(WebCore::SVGAngleValue::valueAsString const): Ditto.

  • svg/SVGLengthValue.cpp:

(WebCore::SVGLengthValue::valueAsString const): Ditto.

  • testing/Internals.cpp:

(WebCore::Internals::configurationForViewport): Ditto. Used
FormattedNumber::fixedPrecision since these are floats.
(WebCore::Internals::getCurrentCursorInfo): Use StringBuilder::appendNumber
instead of calling numberToFixedPrecisionString to do the same thing.
(WebCore::Internals::queueMicroTask): Remove String::number and let makeString
do the conversion without allocating/destroying a String.
(WebCore::appendOffsets): Use StringBuilder::appendNumber instead of
String::number so we can do it without allocating/destroying a String.

  • workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::toString const): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::databaseFilenameFromVersion): Ditto.

Source/WebKit:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::escapeIDForJSON): Use an ASCIILiteral to create a String.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::makeVersionedDirectoryPath): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • NetworkProcess/mac/RemoteNetworkingContext.mm: Removed "using namespace WebCore".

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • NetworkProcess/webrtc/NetworkMDNSRegister.cpp: Removed "using namespace WebCore".

(WebKit::registerMDNSNameCallback): Added explicit WebCore prefix as needed.
(WebKit::NetworkMDNSRegister::registerMDNSName): Ditto. Also remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData): Remove String::number and let makeString do the conversion
without allocating/destroying a String.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createInspectorTargets): Ditto.

  • UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView _URLForLinkAnnotation:]): Ditto.

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::uniqueWorldName): Ditto.

  • WebProcess/WebPage/WebPageInspectorTarget.cpp:

(WebKit::WebPageInspectorTarget::identifier const): Ditto.

Source/WTF:

  • wtf/URL.cpp:

(WTF::URL::setPort): Remove String::number and let makeString do the conversion
without allocating/destroying a String. Added a cast to "unsigned" to sidestep the
ambiguity with 16-bit unsigned types that are sometimes used for numbers (uint16_t)
and sometimes used for UTF-16 code units (UChar) and can be the same type.

  • wtf/text/StringConcatenateNumbers.h:

Changed FormattedNumber::fixedPrecision to more closely match String::number and
StringBuilder::appendNumber by defaulting to truncating trailing zeros and using
a named enumeration for the truncation policy rather than a boolean.

Tools:

  • TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:

(TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
to understand. Updated tests for changes to FormattedNumber::fixedPrecision.

12:37 PM Changeset in webkit [241243] by Alan Bujtas
  • 5 edits in trunk

[LFC][IFC] Add intrinsic width support for basic inline containers
​https://bugs.webkit.org/show_bug.cgi?id=194473

Reviewed by Antti Koivisto.

Source/WebCore:

Preferred width computation logic is very similar to normal layout.
One of the main difference is that the preferred width codepath does not provide valid containing block width.
This patch implement basic inline container support by passing nullopt containing block width in UsedHorizontalValues.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::computeMarginBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):

  • layout/inlineformatting/InlineFormattingContext.h:

Tools:

Expand tests coverage (11 new tests -> 798)

  • LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
11:44 AM Changeset in webkit [241242] by ysuzuki@apple.com
  • 4 edits in trunk/Source

Unreviewed, rolling in r241237 again
​https://bugs.webkit.org/show_bug.cgi?id=194469

Source/JavaScriptCore:

  • runtime/JSString.h:

(JSC::jsSubstring):

Source/WTF:

After the measurement, this patch was unrelated to recent regression.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::isSubString const):
(WTF::StringImpl::createSubstringSharingImpl):

9:52 AM Changeset in webkit [241241] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r241237.
​https://bugs.webkit.org/show_bug.cgi?id=194474

Shows significant memory increase in WSL (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"[WTF] Use BufferInternal StringImpl if substring StringImpl
takes more memory"
​https://bugs.webkit.org/show_bug.cgi?id=194469
​https://trac.webkit.org/changeset/241237

8:04 AM Changeset in webkit [241240] by Michael Catanzaro
  • 3 edits in trunk/Source/WebKit

[GTK] Fix typo in the newly added API
​https://bugs.webkit.org/show_bug.cgi?id=194472

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2019-02-09
Reviewed by Michael Catanzaro.

Fix a typo: enableed -> enabled.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_set_enable_back_forward_navigation_gestures):

  • UIProcess/API/gtk/WebKitSettings.h:
1:39 AM Changeset in webkit [241239] by Nikita Vasilyev
  • 2 edits in trunk/LayoutTests

Web Inspector: fix typos in tests

Unreviewed test gardening.

  • inspector/css/force-page-appearance.html:
12:11 AM Changeset in webkit [241238] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix MiniBrowser's entitlements
​https://bugs.webkit.org/show_bug.cgi?id=192431

Reviewed by Joseph Pecoraro.

MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
files, making it impossible to load any extension.

  • MiniBrowser/MiniBrowser.entitlements:
Note: See TracTimeline for information about the timeline view.