Timeline

Feb 14, 2019:

10:37 PM Changeset in webkit [241578] by bshafiei@apple.com

• 7 edits in branches/safari-608.1.5.1-branch/Source

Versioning.

10:37 PM Changeset in webkit [241577] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

lowerStackArgs should lower Lea32/64 on ARM64 to Add
​https://bugs.webkit.org/show_bug.cgi?id=194656

Reviewed by Yusuke Suzuki.

On arm64, Lea is just implemented as an add. However, Air treats it as an
address with a given width. Because of this width, we were incorrectly
computing whether or not this immediate could fit into the instruction itself
or it needed to be explicitly put into a register. This patch makes
AirLowerStackArgs lower Lea to Add on arm64.

• b3/air/AirLowerStackArgs.cpp:

(JSC::B3::Air::lowerStackArgs):

• b3/air/AirOpcode.opcodes:
• b3/air/testair.cpp:

10:06 PM Changeset in webkit [241576] by bshafiei@apple.com

• 7 edits in tags/Safari-608.1.6.1/Source

Versioning.

10:01 PM Changeset in webkit [241575] by bshafiei@apple.com

• 1 copy in tags/Safari-608.1.6.1

New tag.

5:55 PM Changeset in webkit [241574] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

REGRESSION (r240446): Storage Access API does not handle domains consistently
​https://bugs.webkit.org/show_bug.cgi?id=194664

Reviewed by Alex Christensen.

During my refactoring of the ResourceLoadStatistics code, I introduced two bugs:
(1) I neglected to be consistent in my use of 'primaryDomain', causing some Storage
Access API code paths to store approves under one domain (e.g., 'www.example.com'),
while checking status under the eTLD+1 (e.g., 'example.com'). The exact string matching
requirement caused these to get missed.

(2) I used a move operator before a final set of copies of domain names, leading to
some empty strings being passed to Storage Access API calls.

Both issues are corrected in this patch.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::setPrevalentResourceForDebugMode): Always make the
domain comply with our 'primaryDomain' logic.
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess): Ditto.
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessGranted): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logWebSocketLoading): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logSubresourceLoading): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logSubresourceRedirect): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setLastSeen): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubresourceUnder): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom): Ditto.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::hasStorageAccess): Always make the
domain comply with our 'primaryDomain' logic.
(WebKit::WebsiteDataStore::requestStorageAccess): Ditto. Also make copy of domain
names before moving them to the completion handler.
(WebKit::WebsiteDataStore::grantStorageAccess): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasStorageAccess): Always make the domain comply with our
'primaryDomain' logic.
(WebKit::WebPage::requestStorageAccess): Ditto.

4:51 PM Changeset in webkit [241573] by timothy_horton@apple.com

• 4 edits in trunk/Tools

Fix the build.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::drawSquareInEditableImage):

4:19 PM Changeset in webkit [241572] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r241497.
​https://bugs.webkit.org/show_bug.cgi?id=194676

New test times out (Requested by NVI on #webkit).

Reverted changeset:

"Web Inspector: Styles: valid values in style attributes are
reported as unsupported property values"
​https://bugs.webkit.org/show_bug.cgi?id=194619
​https://trac.webkit.org/changeset/241497

4:06 PM Changeset in webkit [241571] by sbarati@apple.com

• 10 edits
  1 add in trunk

Cache the results of BytecodeGenerator::getVariablesUnderTDZ
​https://bugs.webkit.org/show_bug.cgi?id=194583
<rdar://problem/48028140>

Reviewed by Yusuke Suzuki.

JSTests:

• microbenchmarks/cache-get-variables-under-tdz-in-bytecode-generator.js: Added.

Source/JavaScriptCore:

This patch makes it so that getVariablesUnderTDZ caches a result of
CompactVariableMap::Handle. getVariablesUnderTDZ is costly when
it's called in an environment where there are a lot of variables.
This patch makes it so we cache its results. This is profitable when
getVariablesUnderTDZ is called repeatedly with the same environment
state. This is common since we call this every time we encounter a
function definition/expression node.

• builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

• bytecode/UnlinkedFunctionExecutable.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::liftTDZCheckIfPossible):
(JSC::BytecodeGenerator::pushTDZVariables):
(JSC::BytecodeGenerator::getVariablesUnderTDZ):
(JSC::BytecodeGenerator::restoreTDZStack):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

• parser/VariableEnvironment.cpp:

(JSC::CompactVariableMap::Handle::Handle):
(JSC::CompactVariableMap::Handle::operator=):

• parser/VariableEnvironment.h:

(JSC::CompactVariableMap::Handle::operator bool const):

• runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

4:01 PM Changeset in webkit [241570] by timothy_horton@apple.com

• 5 edits in trunk

Fix the build.

• UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView renderedDrawing]):

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::drawSquareInEditableImage):

3:52 PM Changeset in webkit [241569] by Alan Coon

• 1 copy in tags/Safari-607.1.36

Tag Safari-607.1.36.

3:49 PM Changeset in webkit [241568] by Alan Coon

• 1 copy in tags/Safari-608.1.5.1.2

Tag Safari-608.1.5.1.2.

3:39 PM Changeset in webkit [241567] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Occasional crash under WebCore::CSSStyleSheet::item called from Inspector
​https://bugs.webkit.org/show_bug.cgi?id=194671
<rdar://problem/47628191>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-14
Reviewed by Devin Rousso.

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::item):
A crash may happen if the m_childRuleCSSOMWrappers Vector gets out of
sync with the m_contents list of rules. In particular if the wrappers
vector is shorter than the rule list. We tried exercising code paths
that modify these lists but were not able to reproduce the crash.
To avoid a crash we can make this access safer and avoid the original
overflow. At the same time we will keep and promote the assertion that
would catch the lists getting out of sync in debug builds.

3:06 PM Changeset in webkit [241566] by Ross Kirsling

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for WinCairo Debug after r241559.

• platform/network/curl/CurlContext.cpp:

(WebCore::CurlContext::CurlContext):

2:55 PM Changeset in webkit [241565] by youenn@apple.com

• 3 edits in trunk/Source/WebKit

ASSERTION FAILED: m_caches.isEmpty()

!m_pendingInitializationCallbacks.isEmpty() in WebKit::CacheStorage::Caches::clearMemoryRepresentation()

​https://bugs.webkit.org/show_bug.cgi?id=188393
<rdar://problem/43025665>

Reviewed by Alex Christensen.

In case Caches::dispose is called, clearMemoryRepresentation might be called if there is no active cache.
We also ensure to not clear the memory representation if there is any remaining removed cache.
Update the clearMemoryRepresentation assertion to take that into account.

In case a Caches is cleared twice, the clearMemoryRepresentation assertion will assert while it should not.
In that case m_storage is null the second time. Update the assertion accordingly.

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::hasActiveCache const):
(WebKit::CacheStorage::Caches::dispose):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCaches.h:

2:32 PM Changeset in webkit [241564] by BJ Burg

• 12 edits in trunk

[Mac] WebInspectorUI.framework does not need to be soft-linked anymore
​https://bugs.webkit.org/show_bug.cgi?id=194411
<rdar://problem/47787614>

Reviewed by Joseph Pecoraro.

Source/WebKit:

• Configurations/WebKit.xcconfig:

Conditionalize weak linking to WebInspectorUI.framework for Mac only.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

• WebProcess/WebPage/mac/WebInspectorUIMac.mm:

(WebKit::webInspectorUILocalizedStringsURL):
Rewrite uses of the bundle to exit early if bundle couldn't be loaded.

Source/WebKitLegacy/mac:

• Configurations/WebKitLegacy.xcconfig:

Conditionalize weak linking to WebInspectorUI.framework for Mac only.

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):
(-[WebInspectorWindowController inspectorTestPagePath]):
Rewrite uses of the bundle to exit early if bundle couldn't be loaded.

Source/WTF:

• wtf/cocoa/SoftLinking.h:

Remove macro that now has no uses.

Tools:

Remove unnecessary soft linking macro usage.

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::inspectorTestStubURL):
(SOFT_LINK_STAGED_FRAMEWORK): Deleted.

• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(WTR::TestRunner::inspectorTestStubURL):

2:11 PM Changeset in webkit [241563] by Michael Catanzaro

• 7 edits in trunk/Source/WebKit

[GTK] WebKitGTK+ -> WebKitGTK
​https://bugs.webkit.org/show_bug.cgi?id=194658

Reviewed by Alex Christensen.

This renames WebKitGTK+ to WebKitGTK in a few user-visible places: the API documentation,
the pkg-config, and an error message.

In a couple places where it's exposed in WPE documentation, WPE is now mentioned, or the
reference to "WebKitGTK+" is changed to just "WebKit."

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

• UIProcess/API/glib/WebKitWebView.cpp:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivateGtk.h:
• gtk/webkit2gtk-web-extension.pc.in:
• gtk/webkit2gtk.pc.in:

2:10 PM Changeset in webkit [241562] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] status bubble should fetch builder name info from BuilderMapping table
​https://bugs.webkit.org/show_bug.cgi?id=194599

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):

2:08 PM Changeset in webkit [241561] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Set Foreign Key in Django build model
​https://bugs.webkit.org/show_bug.cgi?id=194667

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/models/build.py:

(Build):

1:35 PM Changeset in webkit [241560] by ysuzuki@apple.com

• 6 edits in trunk/Source/JavaScriptCore

[JSC] Non-JIT entrypoints should share NativeJITCode per entrypoint type
​https://bugs.webkit.org/show_bug.cgi?id=194659

Reviewed by Mark Lam.

Non-JIT entrypoints create NativeJITCode every time it is called. But it is meaningless since these entry point code are identical.
We should create one per entrypoint type (for function, we should have CodeForCall and CodeForConstruct) and continue to use them.
And we use NativeJITCode instead of DirectJITCode if it does not have difference between usual entrypoint and arity check entrypoint.

• dfg/DFGJITCode.h:
• dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):

• jit/JITCode.cpp:

(JSC::DirectJITCode::initializeCodeRefForDFG):
(JSC::DirectJITCode::initializeCodeRef): Deleted.
(JSC::NativeJITCode::initializeCodeRef): Deleted.

• jit/JITCode.h:
• llint/LLIntEntrypoint.cpp:

(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
(JSC::LLInt::setModuleProgramEntrypoint): Retagged is removed since the tag is the same.

12:03 PM Changeset in webkit [241559] by Ross Kirsling

• 83 edits
  3 adds in trunk

[WTF] Add environment variable helpers
​https://bugs.webkit.org/show_bug.cgi?id=192405

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):

• jsc.cpp:

(startTimeoutThreadIfNeeded):

• runtime/Options.cpp:

(JSC::overrideOptionWithHeuristic):
(JSC::Options::overrideAliasedOptionWithHeuristic):
(JSC::Options::initialize):

• runtime/VM.cpp:

(JSC::enableAssembler):
(JSC::VM::VM):

• tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator):
Utilize WTF::Environment where possible.

Source/WebCore:

• platform/NotImplemented.h:
• platform/cocoa/SystemVersion.mm:

(WebCore::createSystemMarketingVersion):

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/nicosia/NicosiaPaintingEngine.cpp:

(Nicosia::PaintingEngine::create):

• platform/graphics/texmap/TextureMapperFPSCounter.cpp:

(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):

• platform/graphics/x11/PlatformDisplayX11.cpp:

(WebCore::PlatformDisplayX11::create):

• platform/gtk/RenderThemeWidget.cpp:

(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):

• platform/network/curl/CurlContext.cpp:

(WebCore::CurlContext::CurlContext):
(WebCore::EnvironmentVariableReader::read): Deleted.
(WebCore::EnvironmentVariableReader::defined): Deleted.
(WebCore::EnvironmentVariableReader::readAs): Deleted.
(WebCore::EnvironmentVariableReader::sscanTemplate): Deleted.
(WebCore::EnvironmentVariableReader::sscanTemplate<signed>): Deleted.
(WebCore::EnvironmentVariableReader::sscanTemplate<unsigned>): Deleted.

• platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::defaultCookieJarPath):

• platform/network/playstation/CurlSSLHandlePlayStation.cpp:

(WebCore::getCACertPathEnv):

• platform/network/win/CurlSSLHandleWin.cpp:

(WebCore::getCACertPathEnv):

• platform/text/hyphen/HyphenationLibHyphen.cpp:

(WebCore::topLevelPath):
(WebCore::webkitBuildDirectory):

• platform/unix/LoggingUnix.cpp:

(WebCore::logLevelString):

• platform/win/LoggingWin.cpp:

(WebCore::logLevelString):
Utilize WTF::Environment where possible.

Source/WebCore/PAL:

• pal/unix/LoggingUnix.cpp:

(PAL::logLevelString):

• pal/win/LoggingWin.cpp:

(PAL::logLevelString):
Utilize WTF::Environment where possible.

Source/WebKit:

• NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

• Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):

• Platform/unix/LoggingUnix.cpp:

(WebKit::logLevelString):

• Platform/win/LoggingWin.cpp:

(WebKit::logLevelString):

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::shouldCallRealDebugger):

• Shared/Plugins/unix/PluginSearchPath.cpp:

(WebKit::pluginsDirectories):

• Shared/glib/ProcessExecutablePathGLib.cpp:

(WebKit::findWebKitProcess):

• UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsConstructed):
(webKitSettingsSetProperty):

• UIProcess/API/glib/WebKitWebContext.cpp:

(injectedBundleDirectory):
(webkitWebContextConstructed):

• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewMaximizeWindow):
(webkitWebViewRestoreWindow):

• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::getLaunchOptions):

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::XDGDBusProxyLauncher::launch):
(WebKit::bindDBusSession):
(WebKit::bindX11):
(WebKit::bindWayland):
(WebKit::bindPulse):
(WebKit::bindPathVar):
(WebKit::bindGStreamerData):
(WebKit::bubblewrapSpawn):

• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::systemDirectoryPath):
(WebKit::ProcessLauncher::launchProcess):

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::memoryPressureMonitorDisabled):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

• WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

• WebProcess/gtk/WebProcessMainGtk.cpp:
• WebProcess/wpe/WebProcessMainWPE.cpp:

Utilize WTF::Environment where possible.

Source/WebKitLegacy/ios:

• Misc/WebUIKitSupport.mm:

(WebKitPlatformSystemRootDirectory):
Utilize WTF::Environment where possible.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _initWithFrame:frameName:groupName:]):
Utilize WTF::Environment where possible.

Source/WTF:

Create a new Environment API as a platform-independent, thread-safe(r)
way to get and set environment variables.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Environment.h: Added.
• wtf/PlatformGTK.cmake:
• wtf/PlatformJSCOnly.cmake:
• wtf/PlatformMac.cmake:
• wtf/PlatformPlayStation.cmake:
• wtf/PlatformWPE.cmake:
• wtf/PlatformWin.cmake:
• wtf/posix/EnvironmentPOSIX.cpp: Added.
• wtf/win/EnvironmentWin.cpp: Added.

Introduce WTF::Environment.

• wtf/Threading.cpp:

(WTF::threadingIsInitialized):
(WTF::initializeThreading):

• wtf/Threading.h:

Introduce WTF::threadingIsInitialized() so that we can ASSERT that it's
false before setting an environment variable through the new API.

• wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):

• wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

• wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::openTemporaryFile):
Utilize WTF::Environment where possible.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(libraryPathForDumpRenderTree):

• DumpRenderTree/win/DumpRenderTree.cpp:

(libraryPathForDumpRenderTree):

• TestRunnerShared/IOSLayoutTestCommunication.cpp:

(setUpIOSLayoutTestCommunication):

• TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:

(TestWebKitAPI::strip):

• TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(beforeAll):

• TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:

(main):

• TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:

(WebKitTestBus::run):

• WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getOutputDir):
(WTR::initializeFontConfigSetting):

• WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WTR::InjectedBundle::platformInitialize):

• WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:

(WTR::topLevelPath):

• WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:

(WTR::topLevelPath):
(WTR::getOutputDir):
(WTR::activateFonts):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::libraryPathForTesting):
(WTR::TestController::generateContextConfiguration const):
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::platformAdjustContext):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize):
(WTR::TestController::platformAdjustContext):

• WebKitTestRunner/gtk/main.cpp:

(main):

• WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::configureContentExtensionForTest):

• WebKitTestRunner/wpe/main.cpp:

(main):
Utilize WTF::Environment where possible.

11:54 AM Changeset in webkit [241558] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebKit

Handle _WKNavigationActionPolicyAllowWithoutTryingAppLink for LoadOptimizer
​https://bugs.webkit.org/show_bug.cgi?id=194640
<rdar://problem/48064140>

Reviewed by Brent Fulgham.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

11:10 AM Changeset in webkit [241557] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Should have default NativeJITCode
​https://bugs.webkit.org/show_bug.cgi?id=194634

Reviewed by Mark Lam.

In JSC_useJIT=false mode, we always create identical NativeJITCode for call and construct when we create NativeExecutable.
This is meaningless since we do not modify NativeJITCode after the creation. This patch adds singleton used as a default one.
Since NativeJITCode (& JITCode) is ThreadSafeRefCounted, we can just share it in a whole process level. This removes 446 NativeJITCode
allocations, which takes 14KB.

• runtime/VM.cpp:

(JSC::jitCodeForCallTrampoline):
(JSC::jitCodeForConstructTrampoline):
(JSC::VM::getHostFunction):

11:06 AM Changeset in webkit [241556] by Chris Dumez

• 29 edits
  2 adds in trunk

[PSON] Introduce a WebContent Process cache
​https://bugs.webkit.org/show_bug.cgi?id=194594
<rdar://problem/46793397>

Reviewed by Geoff Garen.

Source/WebCore:

Update localizable strings.

• en.lproj/Localizable.strings:

Source/WebKit:

Introduce a WebContent Process cache to reduce the number of process launches when
process swap on navigation is enabled, and to reduce the power cost of the feature.

If a WebProcess loaded pages from a single registrable domain then it is eligible
for the cache. When process-swapping on navigation to a new registrable domain, we
now attempt to retrieve a process from the cache for the domain in question instead
of always launching a new one.

The WebProcess cache currently has the following attributes:

• It may contains 4 processes per GB of RAM the machine has, up to 30 processes.
• WebProcesses automatically get evicted from the cache after 30 minutes.
• If the application is no longer the active app, then the cache will get cleared after 5 minutes.
• WebProcesses that are in the cache are reported as "(Cached)" in Activity Monitor.

The WebProcess cache is currently disabled by default and can by enabled by the
client via SPI.

• Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

• Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::lastProcessIdentifier const):
(WebKit::WebBackForwardListItem::setLastProcessIdentifier):
Add new lastProcessIdentifier data member that reflects which process this item
was last loaded in. It is normally identical to the identifier of the process
that created the item but it gets overriden in case of cross-site client-side
redirect, since a new process takes over the item in this case.

• Sources.txt:

Add new source file.

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationUsesWebProcessCache):
(WKContextConfigurationSetUsesWebProcessCache):

• UIProcess/API/C/WKContextConfigurationRef.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setUsesWebProcessCache:]):
(-[_WKProcessPoolConfiguration usesWebProcessCache]):
Add new SPI to enable the WebProcess cache.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _webProcessCountIgnoringPrewarmedAndCached]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Add new SPI for testing which returns the number of WebProcesses ignoring
both prewarmed and cached ones.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
Add application active state observers as the WebProcess cache gets cleared
when the application resigns active state for more than 5 minutes.

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::loadRequest):
When doing a load in a new process with the BackForwardList locked (i.e. client-side
redirect), make sure we update the last process identifier for the BackForwardListItem.
This is important because the logic in WebProcessPool::processForNavigation() relies on
this identifier to select which process to do the history navigation into, and we want
to do the load in the post-redirect process, not the pre-redirect one.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
Tell the WebProcess whenever a main frame provisional load is started, providing the URL.

• UIProcess/WebProcessCache.cpp: Added.

(WebKit::WebProcessCache::WebProcessCache):
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::updateMaximumSize):
(WebKit::WebProcessCache::clear):
(WebKit::WebProcessCache::setApplicationIsActive):
(WebKit::WebProcessCache::evictProcess):
(WebKit::WebProcessCache::CachedProcess::CachedProcess):
(WebKit::WebProcessCache::CachedProcess::~CachedProcess):
(WebKit::WebProcessCache::CachedProcess::takeProcess):
(WebKit::WebProcessCache::CachedProcess::evictionTimerFired):

• UIProcess/WebProcessCache.h: Added.

(WebKit::WebProcessCache::maximumSize):
(WebKit::WebProcessCache::size const):
(WebKit::WebProcessCache::CachedProcess::process):
Add process cache implementation.

• UIProcess/WebProcessPool.cpp:

(WebKit::m_webProcessCache):
WebProcessCache is stored on the WebProcessPool via m_webProcessCache data member.

(WebKit::WebProcessPool::~WebProcessPool):
Clear the WebProcess cache in the destructor.

(WebKit::WebProcessPool::setApplicationIsActive):
Notify the WebProcessCache whenever the application's active state changes.

(WebKit::WebProcessPool::createWebPage):
If the state of PSON changes via the experimental features menu, dynamically
update the WebProcessCache's size. This is needed because the cache is disabled
when PSON is disabled.

(WebKit::WebProcessPool::handleMemoryPressureWarning):
Clear the WebProcess cache on memory pressure.

(WebKit::WebProcessPool::processForNavigationInternal):
Query the WebProcessCache before attempting to create a new WebProcess for a cross-site
navigation.

(WebKit::WebProcessPool::findReusableSuspendedPageProcess):
This logic was split out of processForNavigationInternal() to reduce the size
of the method.

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setIsInProcessCache):
Update the isInProcessCache flag on the WebProcessProxy and send an IPC to the WebContent
process so that it can update its name in Activity Monitor.
We also need to stop holding a strong reference to the WebProcessPool whenever the process
is in the cache, similarly to what we do for pre-warmed processes, given that such processes
should not keep the process pool alive.

(WebKit::WebProcessProxy::addExistingWebPage):
Assert that we never try to add a page to a cached process, it should be taken out of the
cache before use.

(WebKit::WebProcessProxy::hasProvisionalPageWithID const):
(WebKit::WebProcessProxy::isAllowedToUpdateBackForwardItem const):
(WebKit::WebProcessProxy::updateBackForwardItem):
In case of client-side redirects, the previous process would sometimes send an IPC causing
the UIProcess' backforward list item to get updated with the pre-redirect URL after we've
already redirected. This previously would be unlikely to occur because we do not suspend
client-redirect pages and their process would normally exit before getting a chance to send
the IPC. However, with the process cache, the bug became obvious as the process would stay
alive and send up the "bad" IPC. To address the issue, we now only let the IPC update the
item if the item's page is (still) associated with the process. In the future, we may want
to update the IPC so that it gets sent to the WebPageProxy instead of the WebProcessProxy.

(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
If a cached WebProcess crashes, remove it from the cache so that we do not attempt to use
it for a load later.

(WebKit::WebProcessProxy::canBeAddedToWebProcessCache const):
Only cache WebProcesses that have loaded a single registrable domain. Also prevent caching
for service worker and inspector processes.

(WebKit::WebProcessProxy::maybeShutDown):
If the process is cacheable, add it to the cache instead of shutting it down right away.

(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):
Make sure we do not attempt to terminate a processes that is in the cache.

(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
Whenever a main frame provisional load starts, make sure we update the process's associated
registrable domain. nullopt indicates that there is no associated domain yet. Null string
indicates that the process is associated with several registrable domain and is therefore
not eligible for caching.

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::registrableDomain const):
(WebKit::WebProcessProxy::isInProcessCache const):
(WebKit::WebProcessProxy::provisionalPageCount const):
Add convenience getters.

• WebKit.xcodeproj/project.pbxproj:

Add new files to project.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setIsInProcessCache):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateProcessName):
Update the WebProcess' name in Activity Monitor whenever it goes into or out of the WebProcess
cache.

Tools:

Update API tests to turn on the WebContent Process cache.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:00 AM Changeset in webkit [241555] by Alan Coon

• 2 edits in branches/safari-607-branch/Tools

Cherry-pick r241553. rdar://problem/47610130

Unreviewed, build fix after r241480

• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: (-[DragAndDropSimulator initWithWebViewFrame:configuration:]): (-[DragAndDropSimulator initWithWebView:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:55 AM Changeset in webkit [241554] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Open sandbox for certain calls.
​https://bugs.webkit.org/show_bug.cgi?id=194626

Reviewed by Brent Fulgham.

Reporting shows that certain calls needs to be allowed in the sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

10:47 AM Changeset in webkit [241553] by jiewen_tan@apple.com

• 2 edits in trunk/Tools

Unreviewed, build fix after r241480

• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:

(-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
(-[DragAndDropSimulator initWithWebView:]):

10:12 AM Changeset in webkit [241552] by Tadeu Zagallo

• 4 edits in trunk/Source/JavaScriptCore

generateUnlinkedCodeBlockForFunctions shouldn't need to create a FunctionExecutable just to get its source code
​https://bugs.webkit.org/show_bug.cgi?id=194576

Reviewed by Saam Barati.

Extract a new function, linkedSourceCode from UnlinkedFunctionExecutable::link
and use it in generateUnlinkedCodeBlockForFunctions instead.

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::linkedSourceCode const):
(JSC::UnlinkedFunctionExecutable::link):

• bytecode/UnlinkedFunctionExecutable.h:
• runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockForFunctions):

10:12 AM Changeset in webkit [241551] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Italian translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=194652

Patch by Milo Casagrande <​milo@milo.name> on 2019-02-14
Rubber-stamped by Michael Catanzaro.

• it.po:

9:37 AM Changeset in webkit [241550] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

CachedBitVector's size must be converted from bits to bytes
​https://bugs.webkit.org/show_bug.cgi?id=194441

Reviewed by Saam Barati.

CachedBitVector used its size in bits for memcpy. That didn't cause any
issues when encoding, since the size in bits was also used in the allocation,
but would overflow the actual BitVector buffer when decoding.

• runtime/CachedTypes.cpp:

(JSC::CachedBitVector::encode):
(JSC::CachedBitVector::decode const):

9:27 AM Changeset in webkit [241549] by Chris Fleizach

• 4 edits in trunk

AX: ARIA Reflection was disabled in error
​https://bugs.webkit.org/show_bug.cgi?id=194647
<rdar://problem/48068336>

Reviewed by Ryosuke Niwa.

Source/WebKit:

• Shared/WebPreferences.yaml:

Tools:

Remove test override now that this feature should be enabled by default.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

9:10 AM Changeset in webkit [241548] by commit-queue@webkit.org

• 20 edits
  1 delete in trunk

Unreviewed, rolling out r241486.
​https://bugs.webkit.org/show_bug.cgi?id=194655

causing API failures in builds (Requested by ShawnRoberts on
#webkit).

Reverted changeset:

"[Cocoa] Media elements will restart network buffering just
before suspending"
​https://bugs.webkit.org/show_bug.cgi?id=193691
​https://trac.webkit.org/changeset/241486

9:06 AM Changeset in webkit [241547] by BJ Burg

• 5 edits in trunk/Source

Web Inspector: don't include accessibility role in DOM.Node object payloads
​https://bugs.webkit.org/show_bug.cgi?id=194623
<rdar://problem/36384037>

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Remove property of DOM.Node that is no longer being sent.

• inspector/protocol/DOM.json:

Source/WebCore:

Accessibility properties are complicated to fetch at all the points where we want to build and push nodes immediately.
Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the
first place due to a DOM node tree update (i.e., NodeInserted).

It turns out that DOM.getAccessibilityPropertiesForNode is called every time we display
the computed role in the Elements Tab > Nodes Sidebar > Accessibility Section. So it is not
necessary to collect this information in a problematic way when initially pushing the node, as
it will be updated anyway.

No new tests, no change in behavior.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

8:44 AM Changeset in webkit [241546] by Alan Bujtas

• 5 edits
  2 adds in trunk

[LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
​https://bugs.webkit.org/show_bug.cgi?id=194622

Reviewed by Antti Koivisto.

Source/WebCore:

Ensure that block replaced boxes don't collapse through their vertical margins.

Test: fast/block/block-only/block-replaced-with-vertical-margins.html

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):

• page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/block/block-only/block-replaced-with-vertical-margins-expected.html: Added.
• fast/block/block-only/block-replaced-with-vertical-margins.html: Added.

8:32 AM Changeset in webkit [241545] by Alan Bujtas

• 7 edits in trunk

[LFC] Shrink-to-fit-width should be constrained by min/max width
​https://bugs.webkit.org/show_bug.cgi?id=194653

Reviewed by Antti Koivisto.

Source/WebCore:

Use the fixed value of min-width/max-width to constrain the computed preferred width.

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::constrainByMinMaxWidth):

• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

7:51 AM Changeset in webkit [241544] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Do not add a caches to its engine if the salt cannot be initialized
​https://bugs.webkit.org/show_bug.cgi?id=194604

Reviewed by Antti Koivisto.

This is a follow-up to ​https://bugs.webkit.org/show_bug.cgi?id=194588.
We should return early if initialize fails.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk):

4:57 AM Changeset in webkit [241543] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.23.90

WebKitGTK 2.23.90

4:57 AM Changeset in webkit [241542] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.90 release

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers

Source/WebKit:

• gtk/NEWS: Add release notes for 2.23.90.

4:57 AM Changeset in webkit [241541] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Unreviewed. Add missing symbols to webkitglib-symbols.map

Add symbols global in JSC and present in WebKit.

• webkitglib-symbols.map:

3:28 AM Changeset in webkit [241540] by Carlos Garcia Campos

• 15 edits
  4 deletes in releases/WebKitGTK/webkit-2.24

[WPE][GTK][STABLE] Remove sandbox APIs from 2.24 branch
​https://bugs.webkit.org/show_bug.cgi?id=194553

Patch by Michael Catanzaro <Michael Catanzaro> on 2019-02-14
Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

• PlatformGTK.cmake:
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_sandbox_enabled): Deleted.
(webkit_web_context_add_path_to_sandbox): Deleted.
(webkit_web_context_get_sandbox_enabled): Deleted.

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitWebContext.h:
• UIProcess/API/wpe/docs/wpe-0.1-sections.txt:
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Removed.
• UIProcess/Launcher/glib/BubblewrapLauncher.h: Removed.
• UIProcess/Launcher/glib/FlatpakLauncher.cpp: Removed.
• UIProcess/Launcher/glib/FlatpakLauncher.h: Removed.
• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):
(WebKit::isInsideFlatpak): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/glib/WebProcessProxyGLib.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

3:28 AM Changeset in webkit [241539] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241515 - [GTK] Use a scrolled window for script alerts text
​https://bugs.webkit.org/show_bug.cgi?id=184875

Reviewed by Michael Catanzaro.

To ensure long text doesn't make the dialog bigger.

• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed): Use PANGO_ELLIPSIZE_END for the title and add a scrolled window for the body.
(webkitScriptDialogImplSetText): Helper function to set the dialog body, ensuring the scrolled window fills the
dialog available size.
(webkitScriptDialogImplNew): It now receives the maximum size and uses webkitScriptDialogImplSetText().

• UIProcess/API/gtk/WebKitScriptDialogImpl.h:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewScriptDialog): Pass the 80% of the web view size as the maximum size of script dialogs.

3:28 AM Changeset in webkit [241538] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24

Merge r241500 - Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
​https://bugs.webkit.org/show_bug.cgi?id=194641

Reviewed by Geoffrey Garen.

Source/WebKit:

Fixed the bug by adding a null check to WebFrame::parentFrame.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::parentFrame const):

Tools:

Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
so that the test would fail without this fix.

• TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:

(TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

3:28 AM Changeset in webkit [241537] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r241499 - Crash in DOMTimer::fired
​https://bugs.webkit.org/show_bug.cgi?id=194638

Reviewed by Brent Fulgham.

Source/WebCore:

This patch continues the saga of hunting down timer related crashes after r239814, r225985, r227934.

The crash was caused by the bug that we don't remove a DOMTimer from NestedTimersMap if a DOMTimer
is created & installed inside another DOMTimer's callback (via execute call in DOMTimer::fired).

Fixed the crash by using a Ref in NestedTimersMap. This will keep the timer alive until we exit
from DOMTimer::fired. Because DOMTimer::fired always calls stopTracking() which clears the map
we would not leak these DOM timers.

We could, alternatively, use WeakPtr in NestedTimersMap but that would unnecessarily increase the
size of DOMTimer for a very marginal benefit of DOMTimer objcets being deleted slightly earlier.
Deleting itself in DOMTimer's destructor involves more logic & house keeping in the timer code,
and is no longer the preferred approach when dealing with these classes of bugs in WebKit.

Test: fast/dom/timer-destruction-during-firing.html

• page/DOMTimer.cpp:

(WebCore::NestedTimersMap::add):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

LayoutTests:

Added a regression test. It needs debug assertions without the fix.

• fast/dom/timer-destruction-during-firing-expected.txt: Added.
• fast/dom/timer-destruction-during-firing.html: Added.

3:28 AM Changeset in webkit [241536] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r241497 - Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
​https://bugs.webkit.org/show_bug.cgi?id=194619
<rdar://problem/47917373>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Payload of inline styles may contain range that doesn't match
the actual text of the payload - it has an extra empty line at the end.
Mismatching ranges caused data corruption.

• UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):

LayoutTests:

• inspector/css/modify-inline-style-expected.txt: Added.
• inspector/css/modify-inline-style.html: Added.

3:28 AM Changeset in webkit [241535] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241495 - Web Inspector: Crash when inspecting an element that constantly changes visibility
​https://bugs.webkit.org/show_bug.cgi?id=194632
<rdar://problem/48060258>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-13
Reviewed by Matt Baker and Devin Rousso.

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::processAccessibilityChildren):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Don't use rvalue-references as that was taking ownership and deleting
the object we want to keep around. Instead simplify this to just use
references so no ref counting changes happen.

3:28 AM Changeset in webkit [241534] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241494 - AX: Crash in handleMenuOpen
​https://bugs.webkit.org/show_bug.cgi?id=194627

Reviewed by Zalan Bujtas.

Tests run under libGuardMalloc will cause crashes.

This list of objects is a Node list, not an Element list, so we were
not removing some nodes when they were being deallocated.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):

3:28 AM Changeset in webkit [241533] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241493 - We should only make rope strings when concatenating strings long enough.
​https://bugs.webkit.org/show_bug.cgi?id=194465

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch stops us from allocating a rope string if the resulting
rope would be smaller than the size of the JSRopeString object we
would need to allocate.

This patch also adds paths so that we don't unnecessarily allocate
JSString cells for primitives we are going to concatenate with a
string anyway.

The important change from the previous one is that we do not apply
the above rule to JSRopeStrings generated by JSStrings. If we convert
it to JSString, comparison of memory consumption becomes the following,
because JSRopeString does not have StringImpl until it is resolved.

sizeof(JSRopeString) v.s. sizeof(JSString) + sizeof(StringImpl) + content

Since sizeof(JSString) + sizeof(StringImpl) is larger than sizeof(JSRopeString),
resolving eagerly increases memory footprint. The point is that we need to
account newly created JSString and JSRopeString from the operands. This is the
reason why this patch adds different thresholds for each jsString functions.

This patch also avoids concatenation for ropes conservatively. Many ropes are
temporary cells. So we do not resolve eagerly if one of operands is already a
rope.

In CLI execution, this change is performance neutral in JetStream2 (run 6 times, 1 for warming up and average in latter 5.).

Before: 159.3778
After: 160.72340000000003

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSString.h:

(JSC::JSString::isRope const):

• runtime/Operations.cpp:

(JSC::jsAddSlowCase):

• runtime/Operations.h:

(JSC::jsString):
(JSC::jsAddNonNumber):
(JSC::jsAdd):

Source/WTF:

• wtf/text/StringImpl.h:

(WTF::StringImpl::headerSize):

3:28 AM Changeset in webkit [241532] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241491 - Unreviewed GTK test gardening
​https://bugs.webkit.org/show_bug.cgi?id=194631

• platform/gtk/TestExpectations:
• platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
• platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:

3:28 AM Changeset in webkit [241531] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merge r241484 - Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
​https://bugs.webkit.org/show_bug.cgi?id=194516
<rdar://problem/44678353>

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html

When walking up the element ancestor chain, use parentElementInComposedTree() to
walk past the shadow root boundary.

• dom/Element.cpp:

(WebCore::parentCrossingFrameBoundaries):

LayoutTests:

• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor-expected.txt: Added.
• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html: Added.
• platform/ios-wk2/TestExpectations:

3:27 AM Changeset in webkit [241530] by Carlos Garcia Campos

• 30 edits
  4 adds in releases/WebKitGTK/webkit-2.24

Merge r241480 - Further restricting webarchive loads
​https://bugs.webkit.org/show_bug.cgi?id=194567
<rdar://problem/47610130>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch futher restricts main frame webarchive loads to the followings:
1) loaded by clients;
2) loaded by drag;
3) reloaded from any of the previous two.

It moves setAlwaysAllowLocalWebarchive, which is used for testing only, from Document
to FrameLoader such that the option is remembered during redirections.

Covered by API tests.

• dom/Document.h:

(WebCore::Document::setAlwaysAllowLocalWebarchive): Deleted.
(WebCore::Document::alwaysAllowLocalWebarchive const): Deleted.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::disallowWebArchive const):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setAllowsWebArchiveForMainFrame):
(WebCore::DocumentLoader::allowsWebArchiveForMainFrame):

• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setIsRequestFromClientOrUserInput):
(WebCore::FrameLoadRequest::isRequestFromClientOrUserInput):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reload):

• loader/FrameLoader.h:

(WebCore::FrameLoader::setAlwaysAllowLocalWebarchive):
(WebCore::FrameLoader::alwaysAllowLocalWebarchive const):

• page/DragController.cpp:

(WebCore::DragController::performDragOperation):

• testing/Internals.cpp:

(WebCore::Internals::setAlwaysAllowLocalWebarchive const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
Set a flag to indicate a load is started from clients.

Tools:

Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
navigations on drop.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.

(-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
(-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
(-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:

(-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
(-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

• platform/mac/fast/loader/webarchive-encoding-respected.html:
• webarchive/loading/cache-expired-subresource.html:
• webarchive/loading/javascript-url-iframe-crash.html:
• webarchive/loading/mainresource-null-mimetype-crash.html:
• webarchive/loading/missing-data.html:
• webarchive/loading/object.html:
• webarchive/loading/test-loading-archive-subresource-null-mimetype.html:
• webarchive/loading/test-loading-archive-subresource.html:
• webarchive/loading/test-loading-archive.html:
• webarchive/loading/test-loading-top-archive.html:
• webarchive/loading/video-in-webarchive.html:

3:27 AM Changeset in webkit [241529] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241475 - AirIRGenerator::addSwitch switch patchpoint needs to model clobbering the scratch register
​https://bugs.webkit.org/show_bug.cgi?id=194610

Reviewed by Michael Saboff.

BinarySwitch might use the scratch register. We must model the
effects of that properly. This is already caught by our br-table
tests on arm64.

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addSwitch):

3:27 AM Changeset in webkit [241528] by Carlos Garcia Campos

• 3 edits
  1 move
  1 delete in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241474 - [WPE][GTK] Merge WebProcessPoolWPE.cpp and WebProcessPoolGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=194551

Reviewed by Carlos Garcia Campos.

• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/glib/WebProcessPoolGLib.cpp: Renamed from Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp.

(WebKit::initializeRemoteInspectorServer):
(WebKit::memoryPressureMonitorDisabled):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

• UIProcess/wpe/WebProcessPoolWPE.cpp: Removed.

3:27 AM Changeset in webkit [241527] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241472 - Unreviewed, fix unused variable warnings after r241148/r241251
​https://bugs.webkit.org/show_bug.cgi?id=194348
<rdar://problem/47566449>

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
(WebCore::SourceBuffer::evictCodedFrames):
(WebCore::SourceBuffer::provideMediaData):

3:27 AM Changeset in webkit [241526] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241468 - REGRESSION: [ Mac Debug WK2 ] Layout Test storage/indexeddb/key-type-infinity-private.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=194413
<rdar://problem/47897254>

Reviewed by Brady Eidson.

IDB clients expected transaction operations to be executed in order, but in
UniqueIDBDatabase::immediateCloseForUserDelete, callbacks in callback map were errored out randomly.
This patch added a callback queue to UniqueIDBDatabase to make sure callbacks will be called in the same order
as IDB Server receives the request.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetResultCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetAllResultsCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performCountCallback):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

3:27 AM Changeset in webkit [241525] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241453 - Fix -Wformat warning from r241401
​https://bugs.webkit.org/show_bug.cgi?id=194584
<rdar://problem/47761293>

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

3:27 AM Changeset in webkit [241524] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241450 - Revert r240434
​https://bugs.webkit.org/show_bug.cgi?id=194600
<rdar://problem/48044566>

Reviewed by Brent Fulgham.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::updateVolume):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume):

3:27 AM Changeset in webkit [241523] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241449 - Create a randomized free list for new StructureIDs on StructureIDTable resize.
​https://bugs.webkit.org/show_bug.cgi?id=194566
<rdar://problem/47975502>

Reviewed by Michael Saboff.

Also isolate 32-bit implementation of StructureIDTable out more so the 64-bit
implementation is a little easier to read.

This patch appears to be perf neutral on JetStream2 (as run from the command line).

• runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::makeFreeListFromRange):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):
(JSC::StructureIDTable::deallocateID):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::flushOldTables):

3:27 AM Changeset in webkit [241522] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241448 - Crash in WebKit::CacheStorage::Engine::cachesRootPath
​https://bugs.webkit.org/show_bug.cgi?id=194588
<rdar://problem/46363997>

Reviewed by Youenn Fablet.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::cachesRootPath):

Salt may have not been initialized yet when the Engine is destroyed.

3:26 AM Changeset in webkit [241521] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241447 - VariableLengthObject::allocate<T> should initialize objects
​https://bugs.webkit.org/show_bug.cgi?id=194534

Reviewed by Michael Saboff.

buffer() should not be called for empty VariableLengthObjects, but
these cases were not being caught due to the objects not being properly
initialized. Fix it so that allocate calls the constructor and fix the
assertion failues.

• runtime/CachedTypes.cpp:

(JSC::CachedObject::operator new):
(JSC::VariableLengthObject::allocate):
(JSC::CachedVector::encode):
(JSC::CachedVector::decode const):
(JSC::CachedUniquedStringImpl::decode const):
(JSC::CachedBitVector::encode):
(JSC::CachedBitVector::decode const):
(JSC::CachedArray::encode):
(JSC::CachedArray::decode const):
(JSC::CachedImmutableButterfly::CachedImmutableButterfly):
(JSC::CachedBigInt::decode const):

3:26 AM Changeset in webkit [241520] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241442 - CodeBlocks read from disk should not be re-written
​https://bugs.webkit.org/show_bug.cgi?id=194535

Reviewed by Michael Saboff.

Keep track of which CodeBlocks have been read from disk or have already
been serialized in CodeCache.

• runtime/CodeCache.cpp:

(JSC::CodeCache::write):

• runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(JSC::CodeCacheMap::fetchFromDiskImpl):

3:26 AM Changeset in webkit [241519] by Carlos Garcia Campos

• 13 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241441 - Remove legacy sync messaging in some IPC code
​https://bugs.webkit.org/show_bug.cgi?id=194561

Reviewed by Geoffrey Garen.

Changing some LegacySync messages to Delayed messages. We should probably rename Delayed to Sync.
There are too many ways to send messages. Let's work to get rid of the old one.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAllowsAnySSLCertificateForWebSocket):
(WebKit::NetworkProcess::processWillSuspendImminently):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::handleKeyboardEvent):
(WebKit::PluginControllerProxy::handleEditingCommand):
(WebKit::PluginControllerProxy::isEditingCommandEnabled):
(WebKit::PluginControllerProxy::handlesPageScaleFactor):
(WebKit::PluginControllerProxy::requiresUnifiedScaleFactor):
(WebKit::PluginControllerProxy::paintEntirePlugin):
(WebKit::PluginControllerProxy::supportsSnapshotting):
(WebKit::PluginControllerProxy::snapshot):
(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
(WebKit::PluginControllerProxy::getFormValue):

• PluginProcess/PluginControllerProxy.h:
• PluginProcess/PluginControllerProxy.messages.in:
• Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::deallocate):
(WebKit::NPObjectMessageReceiver::hasMethod):
(WebKit::NPObjectMessageReceiver::invoke):
(WebKit::NPObjectMessageReceiver::invokeDefault):
(WebKit::NPObjectMessageReceiver::hasProperty):
(WebKit::NPObjectMessageReceiver::getProperty):
(WebKit::NPObjectMessageReceiver::setProperty):
(WebKit::NPObjectMessageReceiver::removeProperty):
(WebKit::NPObjectMessageReceiver::enumerate):
(WebKit::NPObjectMessageReceiver::construct):

• Shared/Plugins/NPObjectMessageReceiver.h:
• Shared/Plugins/NPObjectMessageReceiver.messages.in:
• UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::secItemRequest):

• UIProcess/mac/SecItemShimProxy.h:
• UIProcess/mac/SecItemShimProxy.messages.in:

3:26 AM Changeset in webkit [241518] by Carlos Garcia Campos

• 3 edits
  6 adds in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241436 - Add two regression tests for reference cycle in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=194527

Reviewed by Geoffrey Garen.

• fast/dom/reference-cycle-leaks.html:
• platform/win/TestExpectations:

The added tests are failing on win bots for unknown reasons, propably related to webkit.org/b/193540. Skip them
on win.

• storage/indexeddb/resources/result-request-cycle.js: Added.

(prepareDatabase):

• storage/indexeddb/resources/value-cursor-cycle.js: Added.

(prepareDatabase):
(onOpen.cursorRequest.onsuccess):

• storage/indexeddb/result-request-cycle-expected.txt: Added.
• storage/indexeddb/result-request-cycle.html: Added.
• storage/indexeddb/value-cursor-cycle-expected.txt: Added.
• storage/indexeddb/value-cursor-cycle.html: Added.

3:26 AM Changeset in webkit [241517] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241431 - SourceCode should be copied when generating bytecode for functions
​https://bugs.webkit.org/show_bug.cgi?id=194536

Reviewed by Saam Barati.

The FunctionExecutable might be collected while generating the bytecode
for nested functions, in which case the SourceCode reference would no
longer be valid.

• runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockForFunctions):

3:26 AM Changeset in webkit [241516] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241430 - [GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=194587

Unreviewed gardening.

• platform/gtk/TestExpectations: Removed DumpJSConsoleLogInStdErr markers which are marked in top TestExpectations.
• platform/wpe/TestExpectations: Ditto.

2:11 AM Changeset in webkit [241515] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit

[GTK] Use a scrolled window for script alerts text
​https://bugs.webkit.org/show_bug.cgi?id=184875

Reviewed by Michael Catanzaro.

To ensure long text doesn't make the dialog bigger.

• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed): Use PANGO_ELLIPSIZE_END for the title and add a scrolled window for the body.
(webkitScriptDialogImplSetText): Helper function to set the dialog body, ensuring the scrolled window fills the
dialog available size.
(webkitScriptDialogImplNew): It now receives the maximum size and uses webkitScriptDialogImplSetText().

• UIProcess/API/gtk/WebKitScriptDialogImpl.h:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewScriptDialog): Pass the 80% of the web view size as the maximum size of script dialogs.

12:35 AM Changeset in webkit [241514] by bshafiei@apple.com

• 3 edits in branches/safari-607-branch/Source/WebKit

Apply patch. rdar://problem/47673836

12:35 AM Changeset in webkit [241513] by bshafiei@apple.com

• 4 edits in branches/safari-607-branch

Cherry-pick r241500. rdar://problem/48065631

Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
​https://bugs.webkit.org/show_bug.cgi?id=194641

Reviewed by Geoffrey Garen.

Source/WebKit:

Fixed the bug by adding a null check to WebFrame::parentFrame.

• WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::parentFrame const):

Tools:

Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
so that the test would fail without this fix.

• TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241512] by bshafiei@apple.com

• 3 edits
  2 adds in branches/safari-607-branch

Cherry-pick r241499. rdar://problem/48065634

Crash in DOMTimer::fired
​https://bugs.webkit.org/show_bug.cgi?id=194638

Reviewed by Brent Fulgham.

Source/WebCore:

This patch continues the saga of hunting down timer related crashes after r239814, r225985, r227934.

The crash was caused by the bug that we don't remove a DOMTimer from NestedTimersMap if a DOMTimer
is created & installed inside another DOMTimer's callback (via execute call in DOMTimer::fired).

Fixed the crash by using a Ref in NestedTimersMap. This will keep the timer alive until we exit
from DOMTimer::fired. Because DOMTimer::fired always calls stopTracking() which clears the map
we would not leak these DOM timers.

We could, alternatively, use WeakPtr in NestedTimersMap but that would unnecessarily increase the
size of DOMTimer for a very marginal benefit of DOMTimer objcets being deleted slightly earlier.
Deleting itself in DOMTimer's destructor involves more logic & house keeping in the timer code,
and is no longer the preferred approach when dealing with these classes of bugs in WebKit.

Test: fast/dom/timer-destruction-during-firing.html

• page/DOMTimer.cpp: (WebCore::NestedTimersMap::add): (WebCore::DOMTimer::install): (WebCore::DOMTimer::fired):

LayoutTests:

Added a regression test. It needs debug assertions without the fix.

• fast/dom/timer-destruction-during-firing-expected.txt: Added.
• fast/dom/timer-destruction-during-firing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241511] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241494. rdar://problem/48065624

AX: Crash in handleMenuOpen
​https://bugs.webkit.org/show_bug.cgi?id=194627

Reviewed by Zalan Bujtas.

Tests run under libGuardMalloc will cause crashes.

This list of objects is a Node list, not an Element list, so we were
not removing some nodes when they were being deallocated.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241510] by bshafiei@apple.com

• 4 edits
  2 adds in branches/safari-607-branch

Cherry-pick r241484. rdar://problem/48065620

Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
​https://bugs.webkit.org/show_bug.cgi?id=194516
<rdar://problem/44678353>

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html

When walking up the element ancestor chain, use parentElementInComposedTree() to
walk past the shadow root boundary.

• dom/Element.cpp: (WebCore::parentCrossingFrameBoundaries):

LayoutTests:

• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor-expected.txt: Added.
• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html: Added.
• platform/ios-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241509] by bshafiei@apple.com

• 3 edits
  4 adds in branches/safari-607-branch

Cherry-pick r241481. rdar://problem/48065616

Encrypted PDFs inside <embed> or <object> crash the Web Content process
​https://bugs.webkit.org/show_bug.cgi?id=194605
<rdar://problem/19894818>

Reviewed by Andy Estes.

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::createPasswordEntryForm): Don't try to create a password form field if we can't make form fields.

This means you will be left with a useless embedded PDF, but at least
the Web Content process won't crash.

We'll need to find an alternative implementation of PDF embedded form
fields that is compatible with <embed> and <object> if we want to support
this. Currently we piggy-back off the fact that we can just insert
<input>s into the PluginDocument's DOM, but we can't do that if there
is no PluginDocument, just a main document, like in the <embed> case.

LayoutTests:

• fast/replaced/encrypted-pdf-as-object-and-embed-expected.txt: Added.
• fast/replaced/encrypted-pdf-as-object-and-embed.html: Added.
• fast/replaced/resources/encrypted-image.pdf: Added. Add a test ensuring that we don't crash with encrypted PDF in <object> or <embed>.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241508] by bshafiei@apple.com

• 30 edits
  4 adds in branches/safari-607-branch

Cherry-pick r241480. rdar://problem/48065618

Further restricting webarchive loads
​https://bugs.webkit.org/show_bug.cgi?id=194567
<rdar://problem/47610130>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch futher restricts main frame webarchive loads to the followings:
1) loaded by clients;
2) loaded by drag;
3) reloaded from any of the previous two.

It moves setAlwaysAllowLocalWebarchive, which is used for testing only, from Document
to FrameLoader such that the option is remembered during redirections.

Covered by API tests.

• dom/Document.h: (WebCore::Document::setAlwaysAllowLocalWebarchive): Deleted. (WebCore::Document::alwaysAllowLocalWebarchive const): Deleted.
• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::disallowWebArchive const):
• loader/DocumentLoader.h: (WebCore::DocumentLoader::setAllowsWebArchiveForMainFrame): (WebCore::DocumentLoader::allowsWebArchiveForMainFrame):
• loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::setIsRequestFromClientOrUserInput): (WebCore::FrameLoadRequest::isRequestFromClientOrUserInput):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::reload):
• loader/FrameLoader.h: (WebCore::FrameLoader::setAlwaysAllowLocalWebarchive): (WebCore::FrameLoader::alwaysAllowLocalWebarchive const):
• page/DragController.cpp: (WebCore::DragController::performDragOperation):
• testing/Internals.cpp: (WebCore::Internals::setAlwaysAllowLocalWebarchive const):
• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadRequest): Set a flag to indicate a load is started from clients.

Tools:

Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
navigations on drop.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added. (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]): (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]): (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): (TestWebKitAPI::TEST):
• TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: (-[DragAndDropSimulator initWithWebViewFrame:configuration:]): (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

• platform/mac/fast/loader/webarchive-encoding-respected.html:
• webarchive/loading/cache-expired-subresource.html:
• webarchive/loading/javascript-url-iframe-crash.html:
• webarchive/loading/mainresource-null-mimetype-crash.html:
• webarchive/loading/missing-data.html:
• webarchive/loading/object.html:
• webarchive/loading/test-loading-archive-subresource-null-mimetype.html:
• webarchive/loading/test-loading-archive-subresource.html:
• webarchive/loading/test-loading-archive.html:
• webarchive/loading/test-loading-top-archive.html:
• webarchive/loading/video-in-webarchive.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241507] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241479. rdar://problem/48065642

Null-deref crash at SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged()
​https://bugs.webkit.org/show_bug.cgi?id=194613
<rdar://problem/48023912>

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241506] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r241453. rdar://problem/48065612

Fix -Wformat warning from r241401
​https://bugs.webkit.org/show_bug.cgi?id=194584
<rdar://problem/47761293>

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setActivityState):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241505] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r241448. rdar://problem/48065637

Crash in WebKit::CacheStorage::Engine::cachesRootPath
​https://bugs.webkit.org/show_bug.cgi?id=194588
<rdar://problem/46363997>

Reviewed by Youenn Fablet.

• NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::cachesRootPath):

Salt may have not been initialized yet when the Engine is destroyed.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241504] by bshafiei@apple.com

• 4 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241437. rdar://problem/48065626

[Cocoa] Switch to CVPixelBufferGetBytesPerRow() for calculating CVPixelBuffer base address size.
​https://bugs.webkit.org/show_bug.cgi?id=194580
<rdar://problem/42727739>

Reviewed by Eric Carlson.

• platform/cocoa/CoreVideoSoftLink.cpp:
• platform/cocoa/CoreVideoSoftLink.h:
• platform/graphics/cv/PixelBufferConformerCV.cpp: (WebCore::CVPixelBufferGetBytePointerCallback): (WebCore::PixelBufferConformerCV::createImageFromPixelBuffer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241503] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r241401. rdar://problem/48065612

Crash in Page::setActivityState because m_page is null
​https://bugs.webkit.org/show_bug.cgi?id=194584

Reviewed by Antti Koivisto.

Add a null check to avoid the crash. Also add a debug assertion to help diagnose this in the future.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setActivityState):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241502] by bshafiei@apple.com

• 2 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r241349. rdar://problem/48065639

Null deref in userInterfaceLayoutDirection under ViewGestureController::handleSwipeGesture
​https://bugs.webkit.org/show_bug.cgi?id=194569
<rdar://problem/46711049>

Reviewed by Wenson Hsieh.

• UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::handleSwipeGesture): It is conceivable that we could get here if the client closes the page e.g. in the callback from willEndSwipeGesture. We already guarded against this ... one line too late! Rearrange the lines so we don't call into WebPageProxy at all if we don't have a drawing area (which is a strict subset of the time that isValid would return true). This is a speculative fix, since I can no longer reproduce the crash on demand.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:34 AM Changeset in webkit [241501] by bshafiei@apple.com

• 6 edits in branches/safari-607-branch

Cherry-pick r241336. rdar://problem/48065621

Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
​https://bugs.webkit.org/show_bug.cgi?id=194568
<rdar://problem/47944490>

Reviewed by Ryosuke Niwa.

Source/WebKit:

When the provisional process crashes, it is unsafe to call ProvisionalPageProxy::cancel() because
the WebProcessProxy clears its frame map as soon as the process crashes. Calling cancel() after
that would call WebPageProxy::didFailProvisionalLoadForFrameShared(), which would try to look up
the frame by ID and MESSAGE_CHECK() that the frame is not null. We would fail this check since
the frame has been removed from the WebProcessProxy at this point.

• UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _provisionalWebProcessIdentifier]):
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::provisionalProcessDidTerminate):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Feb 13, 2019:

10:47 PM Changeset in webkit [241500] by rniwa@webkit.org

• 4 edits in trunk

Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
​https://bugs.webkit.org/show_bug.cgi?id=194641

Reviewed by Geoffrey Garen.

Source/WebKit:

Fixed the bug by adding a null check to WebFrame::parentFrame.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::parentFrame const):

Tools:

Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
so that the test would fail without this fix.

• TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:

(TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

10:43 PM Changeset in webkit [241499] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Crash in DOMTimer::fired
​https://bugs.webkit.org/show_bug.cgi?id=194638

Reviewed by Brent Fulgham.

Source/WebCore:

This patch continues the saga of hunting down timer related crashes after r239814, r225985, r227934.

The crash was caused by the bug that we don't remove a DOMTimer from NestedTimersMap if a DOMTimer
is created & installed inside another DOMTimer's callback (via execute call in DOMTimer::fired).

Fixed the crash by using a Ref in NestedTimersMap. This will keep the timer alive until we exit
from DOMTimer::fired. Because DOMTimer::fired always calls stopTracking() which clears the map
we would not leak these DOM timers.

We could, alternatively, use WeakPtr in NestedTimersMap but that would unnecessarily increase the
size of DOMTimer for a very marginal benefit of DOMTimer objcets being deleted slightly earlier.
Deleting itself in DOMTimer's destructor involves more logic & house keeping in the timer code,
and is no longer the preferred approach when dealing with these classes of bugs in WebKit.

Test: fast/dom/timer-destruction-during-firing.html

• page/DOMTimer.cpp:

(WebCore::NestedTimersMap::add):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

LayoutTests:

Added a regression test. It needs debug assertions without the fix.

• fast/dom/timer-destruction-during-firing-expected.txt: Added.
• fast/dom/timer-destruction-during-firing.html: Added.

9:33 PM Changeset in webkit [241498] by timothy@apple.com

• 2 edits in trunk/Source/WebKit

Allow some deprecations in WKDrawingView.
​https://bugs.webkit.org/show_bug.cgi?id=194636

Reviewed by Wenson Hsieh.

• UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView PNGRepresentation]):
(-[WKDrawingView loadDrawingFromPNGRepresentation:]):
(-[WKDrawingView _canvasViewWillBeginDrawing:]):
(-[WKDrawingView didChangeInk:]):

9:32 PM Changeset in webkit [241497] by Nikita Vasilyev

• 3 edits
  2 adds in trunk

Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
​https://bugs.webkit.org/show_bug.cgi?id=194619
<rdar://problem/47917373>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Payload of inline styles may contain range that doesn't match
the actual text of the payload - it has an extra empty line at the end.
Mismatching ranges caused data corruption.

• UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):

LayoutTests:

• inspector/css/modify-inline-style-expected.txt: Added.
• inspector/css/modify-inline-style.html: Added.

7:47 PM Changeset in webkit [241496] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update combined and minified copyright header for 2018-2019
​https://bugs.webkit.org/show_bug.cgi?id=194635

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-13
Reviewed by Devin Rousso.

• Scripts/copy-user-interface-resources.pl:

7:38 PM Changeset in webkit [241495] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Web Inspector: Crash when inspecting an element that constantly changes visibility
​https://bugs.webkit.org/show_bug.cgi?id=194632
<rdar://problem/48060258>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-13
Reviewed by Matt Baker and Devin Rousso.

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::processAccessibilityChildren):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Don't use rvalue-references as that was taking ownership and deleting
the object we want to keep around. Instead simplify this to just use
references so no ref counting changes happen.

7:27 PM Changeset in webkit [241494] by Chris Fleizach

• 2 edits in trunk/Source/WebCore

AX: Crash in handleMenuOpen
​https://bugs.webkit.org/show_bug.cgi?id=194627

Reviewed by Zalan Bujtas.

Tests run under libGuardMalloc will cause crashes.

This list of objects is a Node list, not an Element list, so we were
not removing some nodes when they were being deallocated.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):

7:01 PM Changeset in webkit [241493] by ysuzuki@apple.com

• 8 edits in trunk/Source

We should only make rope strings when concatenating strings long enough.
​https://bugs.webkit.org/show_bug.cgi?id=194465

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch stops us from allocating a rope string if the resulting
rope would be smaller than the size of the JSRopeString object we
would need to allocate.

This patch also adds paths so that we don't unnecessarily allocate
JSString cells for primitives we are going to concatenate with a
string anyway.

The important change from the previous one is that we do not apply
the above rule to JSRopeStrings generated by JSStrings. If we convert
it to JSString, comparison of memory consumption becomes the following,
because JSRopeString does not have StringImpl until it is resolved.

sizeof(JSRopeString) v.s. sizeof(JSString) + sizeof(StringImpl) + content

Since sizeof(JSString) + sizeof(StringImpl) is larger than sizeof(JSRopeString),
resolving eagerly increases memory footprint. The point is that we need to
account newly created JSString and JSRopeString from the operands. This is the
reason why this patch adds different thresholds for each jsString functions.

This patch also avoids concatenation for ropes conservatively. Many ropes are
temporary cells. So we do not resolve eagerly if one of operands is already a
rope.

In CLI execution, this change is performance neutral in JetStream2 (run 6 times, 1 for warming up and average in latter 5.).

Before: 159.3778
After: 160.72340000000003

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSString.h:

(JSC::JSString::isRope const):

• runtime/Operations.cpp:

(JSC::jsAddSlowCase):

• runtime/Operations.h:

(JSC::jsString):
(JSC::jsAddNonNumber):
(JSC::jsAdd):

Source/WTF:

• wtf/text/StringImpl.h:

(WTF::StringImpl::headerSize):

6:28 PM Changeset in webkit [241492] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
​https://bugs.webkit.org/show_bug.cgi?id=194621
<rdar://problem/48002560>

Reviewed by Eric Carlson.

When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
change events in the media-controller.js on rAF().

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._returnMediaLayerToInlineIfNeeded):

6:28 PM Changeset in webkit [241491] by aboya@igalia.com

• 4 edits in trunk/LayoutTests

Unreviewed GTK test gardening
​https://bugs.webkit.org/show_bug.cgi?id=194631

• platform/gtk/TestExpectations:
• platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
• platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:

5:36 PM Changeset in webkit [241490] by wilander@apple.com

• 6 edits in trunk

Ignore Ad Click Attribution where source and destination are same-site
​https://bugs.webkit.org/show_bug.cgi?id=194620
<rdar://problem/47890018>

Reviewed by Jiewen Tan.

Source/WebCore:

Updated the existing test.

We should not accept Ad Click Attribution requests where the site of the
anchor tag and its addestination attribute are same-site. Such attributions
don’t make sense (the site can track intra-site clicks through better means)
and would just lead to increased memory use where are the pending
attributions are stored.

For ports that don't have access to the Public Suffix List, this patch
only checks that the hosts don't match, i.e. not just eTLD+1.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAdClickAttribution const):

Now returns WTF::nullopt if the current document and the
addestination are same site. Also fixed a console message
typo.

LayoutTests:

Same-site test added and test results updated.

• http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
• http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
• platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:

5:25 PM Changeset in webkit [241489] by youenn@apple.com

• 8 edits
  2 adds in trunk

getUserMedia with an ideal deviceId constraint doesn't always select the correct device
​https://bugs.webkit.org/show_bug.cgi?id=193614

Source/WebCore:

Reviewed by Eric Carlson.

Compute a fitness score based on constraints.
For each constraint, a fitness score is computed from the distance.
The smaller the distance, the higher the score.
Fitness scores are then summed to give a device fitness score.
Matching devices are then sorted according the fitness score.

For important constraints, deviceId and facingMode, add a more important weight.
This ensures that should any of these ideal constraints are set, they will be respected.

Restrict our automatic setting of default constraints to not add a default ideal facingMode in case of existing deviceId constraint.
Do not set a default ideal frameRate if width and height are already set.

Covered by updated test.

• platform/mediastream/MediaConstraints.cpp:

(WebCore::FlattenedConstraint::set):
(WebCore::MediaConstraints::setDefaultVideoConstraints):

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::RealtimeMediaSource::selectSettings):
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):

LayoutTests:

Reviewed by Eric Carlson.

• fast/mediastream/get-user-media-device-id-expected.txt:
• fast/mediastream/get-user-media-device-id.html:

4:31 PM Changeset in webkit [241488] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Change log level for a log statement

Unreviewed minor fix.

• BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch.save_patch):

4:28 PM Changeset in webkit [241487] by eric.carlson@apple.com

• 4 edits
  2 adds in trunk

[iOS] Add a hack to work around buggy video control library
​https://bugs.webkit.org/show_bug.cgi?id=194615
<rdar://problem/46146946>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/ios/video-volume-ios-quirk.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume): Change m_volume for one turn of the runloop.
(WebCore::HTMLMediaElement::cancelPendingTasks): Clear the task queue used to restore m_volume.
(WebCore::HTMLMediaElement::closeTaskQueues): Close it.

• html/HTMLMediaElement.h:

LayoutTests:

• media/ios/video-volume-ios-quirk-expected.txt: Added.
• media/ios/video-volume-ios-quirk.html: Added.

4:21 PM Changeset in webkit [241486] by jer.noble@apple.com

• 20 edits
  1 add in trunk

[Cocoa] Media elements will restart network buffering just before suspending
​https://bugs.webkit.org/show_bug.cgi?id=193691

Reviewed by Eric Carlson.

Source/WebCore:

API Test: WebKit.ProcessSuspendMediaBuffering

Allow the Page to suspend all media buffering in its child Documents.

• dom/Document.cpp:

(WebCore::Document::suspendAllMediaBuffering):
(WebCore::Document::resumeAllMediaBuffering):

• dom/Document.h:
• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::dataBufferingPermitted const):
(WebCore::MediaElementSession::suspendBuffering):
(WebCore::MediaElementSession::resumeBuffering):
(WebCore::MediaElementSession::bufferingSuspended const):

• html/MediaElementSession.h:
• page/Page.cpp:

(WebCore::Page::suspendAllMediaBuffering):
(WebCore::Page::resumeAllMediaBuffering):

• page/Page.h:

(WebCore::Page::mediaPlaybackIsSuspended const):
(WebCore::Page::mediaBufferingIsSuspended const):
(WebCore::Page::mediaPlaybackIsSuspended): Deleted.

• platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::suspendBuffering):
(WebCore::PlatformMediaSession::resumeBuffering):

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):

• platform/audio/PlatformMediaSessionManager.h:

Source/WebKit:

When the WebProcess receives a notification that the process is about to become
suspended, it tells the MemoryPressureHandler to release all critical memory. This
has the side effect of causing AVFoundation-backed media elements to dump their
in-memory caches and start downloading media data again. Instead, media elements
should all stop buffering media data during suspension. Add new testing SPI to
simulate suspension and resume messages.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):
(-[WKWebView _processDidResumeForTesting]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebProcessProxy.h:
• UIProcess/ios/WKInkPickerView.mm:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::suspendAllMediaBuffering):
(WebKit::WebPage::resumeAllMediaBuffering):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::processDidResume):
(WebKit::WebProcess::suspendAllMediaBuffering):
(WebKit::WebProcess::resumeAllMediaBuffering):

• WebProcess/WebProcess.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.

(TEST):

4:16 PM Changeset in webkit [241485] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Fetch builder id to name mapping
​https://bugs.webkit.org/show_bug.cgi?id=194355

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.get_builder_id_to_name_mapping):
(Buildbot._get_display_name_from_builder_name):

4:11 PM Changeset in webkit [241484] by jer.noble@apple.com

• 4 edits
  2 adds in trunk

Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
​https://bugs.webkit.org/show_bug.cgi?id=194516
<rdar://problem/44678353>

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html

When walking up the element ancestor chain, use parentElementInComposedTree() to
walk past the shadow root boundary.

• dom/Element.cpp:

(WebCore::parentCrossingFrameBoundaries):

LayoutTests:

• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor-expected.txt: Added.
• fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html: Added.
• platform/ios-wk2/TestExpectations:

4:03 PM Changeset in webkit [241483] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Fix sandbox violation during media playback
​https://bugs.webkit.org/show_bug.cgi?id=194616
<rdar://problem/48049264>

Reviewed by Brent Fulgham.

Mach lookup to "com.apple.coremedia.figcontentkeysession.xpc" should be allowed.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:14 PM Changeset in webkit [241482] by Chris Dumez

• 4 edits in trunk/Source

Unreviewed, update localizable strings.

Source/WebCore:

• en.lproj/Localizable.strings:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

3:08 PM Changeset in webkit [241481] by timothy_horton@apple.com

• 3 edits
  4 adds in trunk

Encrypted PDFs inside <embed> or <object> crash the Web Content process
​https://bugs.webkit.org/show_bug.cgi?id=194605
<rdar://problem/19894818>

Reviewed by Andy Estes.

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createPasswordEntryForm):
Don't try to create a password form field if we can't make form fields.

This means you will be left with a useless embedded PDF, but at least
the Web Content process won't crash.

We'll need to find an alternative implementation of PDF embedded form
fields that is compatible with <embed> and <object> if we want to support
this. Currently we piggy-back off the fact that we can just insert
<input>s into the PluginDocument's DOM, but we can't do that if there
is no PluginDocument, just a main document, like in the <embed> case.

LayoutTests:

• fast/replaced/encrypted-pdf-as-object-and-embed-expected.txt: Added.
• fast/replaced/encrypted-pdf-as-object-and-embed.html: Added.
• fast/replaced/resources/encrypted-image.pdf: Added.

Add a test ensuring that we don't crash with encrypted PDF in <object> or <embed>.

3:07 PM Changeset in webkit [241480] by jiewen_tan@apple.com

• 30 edits
  4 adds in trunk

Further restricting webarchive loads
​https://bugs.webkit.org/show_bug.cgi?id=194567
<rdar://problem/47610130>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch futher restricts main frame webarchive loads to the followings:
1) loaded by clients;
2) loaded by drag;
3) reloaded from any of the previous two.

It moves setAlwaysAllowLocalWebarchive, which is used for testing only, from Document
to FrameLoader such that the option is remembered during redirections.

Covered by API tests.

• dom/Document.h:

(WebCore::Document::setAlwaysAllowLocalWebarchive): Deleted.
(WebCore::Document::alwaysAllowLocalWebarchive const): Deleted.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::disallowWebArchive const):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setAllowsWebArchiveForMainFrame):
(WebCore::DocumentLoader::allowsWebArchiveForMainFrame):

• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setIsRequestFromClientOrUserInput):
(WebCore::FrameLoadRequest::isRequestFromClientOrUserInput):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reload):

• loader/FrameLoader.h:

(WebCore::FrameLoader::setAlwaysAllowLocalWebarchive):
(WebCore::FrameLoader::alwaysAllowLocalWebarchive const):

• page/DragController.cpp:

(WebCore::DragController::performDragOperation):

• testing/Internals.cpp:

(WebCore::Internals::setAlwaysAllowLocalWebarchive const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
Set a flag to indicate a load is started from clients.

Tools:

Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
navigations on drop.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.

(-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
(-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
(-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
• TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
• TestWebKitAPI/cocoa/DragAndDropSimulator.h:
• TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:

(-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
(-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

• platform/mac/fast/loader/webarchive-encoding-respected.html:
• webarchive/loading/cache-expired-subresource.html:
• webarchive/loading/javascript-url-iframe-crash.html:
• webarchive/loading/mainresource-null-mimetype-crash.html:
• webarchive/loading/missing-data.html:
• webarchive/loading/object.html:
• webarchive/loading/test-loading-archive-subresource-null-mimetype.html:
• webarchive/loading/test-loading-archive-subresource.html:
• webarchive/loading/test-loading-archive.html:
• webarchive/loading/test-loading-top-archive.html:
• webarchive/loading/video-in-webarchive.html:

2:59 PM Changeset in webkit [241479] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Null-deref crash at SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged()
​https://bugs.webkit.org/show_bug.cgi?id=194613
<rdar://problem/48023912>

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

2:49 PM Changeset in webkit [241478] by Alan Coon

• 5 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241297. rdar://problem/47969451

Source/WebCore:
Unreviewed build fix; add a HAVE_CELESTIAL guard around Celestial framework usage.

• platform/audio/ios/MediaSessionManagerIOS.h:
• platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary):

Source/WebCore/PAL:
Unreviewed build fix; add a HAVE_CELESTIAL guard around the CelestialSPI.h contents.

• pal/spi/ios/CelestialSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:49 PM Changeset in webkit [241477] by Alan Coon

• 15 edits
  1 move in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241281. rdar://problem/47969451

[Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
​https://bugs.webkit.org/show_bug.cgi?id=194504

Reviewed by Eric Carlson.

Source/WebCore:

This allows the MediaRemote framework to associate the WebContent process with its host application.

• Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::start):
• platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::prepareToSendUserMediaPermissionRequest):
• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm: (MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest): (MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary): (MediaSessionManagerCocoa::updateNowPlayingInfo):

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebUserMediaClient.cpp: (WebKit::WebUserMediaClient::requestUserMediaAccess):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
• WebProcess/WebPage/WebPage.h: (WebKit::WebPage::userMediaPermissionRequestManager):
• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:42 PM Changeset in webkit [241476] by Alan Coon

• 4 edits in tags/Safari-607.1.34.1/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:36 PM Changeset in webkit [241475] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

AirIRGenerator::addSwitch switch patchpoint needs to model clobbering the scratch register
​https://bugs.webkit.org/show_bug.cgi?id=194610

Reviewed by Michael Saboff.

BinarySwitch might use the scratch register. We must model the
effects of that properly. This is already caught by our br-table
tests on arm64.

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addSwitch):

2:35 PM Changeset in webkit [241474] by Michael Catanzaro

• 3 edits
  1 move
  1 delete in trunk/Source/WebKit

[WPE][GTK] Merge WebProcessPoolWPE.cpp and WebProcessPoolGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=194551

Reviewed by Carlos Garcia Campos.

• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/glib/WebProcessPoolGLib.cpp: Renamed from Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp.

(WebKit::initializeRemoteInspectorServer):
(WebKit::memoryPressureMonitorDisabled):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

• UIProcess/wpe/WebProcessPoolWPE.cpp: Removed.

2:28 PM Changeset in webkit [241473] by Alan Coon

• 4 edits in tags/Safari-607.1.35.1/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:23 PM Changeset in webkit [241472] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

Unreviewed, fix unused variable warnings after r241148/r241251
​https://bugs.webkit.org/show_bug.cgi?id=194348
<rdar://problem/47566449>

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
(WebCore::SourceBuffer::evictCodedFrames):
(WebCore::SourceBuffer::provideMediaData):

2:10 PM Changeset in webkit [241471] by Alan Coon

• 7 edits in tags/Safari-607.1.34.1/Source

Versioning.

1:39 PM Changeset in webkit [241470] by Alan Coon

• 7 edits in tags/Safari-607.1.35.1/Source

Versioning.

1:38 PM Changeset in webkit [241469] by Alan Coon

• 1 copy in tags/Safari-607.1.34.1

New tag.

1:32 PM Changeset in webkit [241468] by sihui_liu@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION: [ Mac Debug WK2 ] Layout Test storage/indexeddb/key-type-infinity-private.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=194413
<rdar://problem/47897254>

Reviewed by Brady Eidson.

IDB clients expected transaction operations to be executed in order, but in
UniqueIDBDatabase::immediateCloseForUserDelete, callbacks in callback map were errored out randomly.
This patch added a callback queue to UniqueIDBDatabase to make sure callbacks will be called in the same order
as IDB Server receives the request.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetResultCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetAllResultsCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performCountCallback):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

1:29 PM Changeset in webkit [241467] by Alan Coon

• 1 copy in tags/Safari-607.1.35.1

New tag.

1:14 PM Changeset in webkit [241466] by Alan Coon

• 7 edits in branches/safari-607-branch/Source/WebKit

Apply patch. rdar://problem/40966400

1:11 PM Changeset in webkit [241465] by Alan Coon

• 3 edits
  2 adds in branches/safari-607-branch

Cherry-pick r241319. rdar://problem/48015672

Source/WebCore:
Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

• inspector/PageScriptDebugServer.cpp: (WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

• fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
• fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241464] by Alan Coon

• 4 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241300. rdar://problem/48016008

Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

1. a Document detaches from its StyleSheetList.
2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

2. Fix CodeGeneratorJS.pm to null check the opaque root before using it.

• bindings/js/JSNodeCustom.h: (WebCore::root):
• bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241463] by Alan Coon

• 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241296. rdar://problem/48015654

Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241462] by Alan Coon

• 11 edits in branches/safari-607-branch

Cherry-pick r241289. rdar://problem/48015662

AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
​https://bugs.webkit.org/show_bug.cgi?id=182280
<rdar://problem/37018386>

Reviewed by Alan Bujtas.

Source/WebCore:

Remove the possibility that changing children calls back into updating layout by
handling children changes in a deferred manner.

This follows the same architecture as many other deferred changes, but also requires us to check deferred changes
in updateBackingStore, because things like aria-hidden changes won't trigger a layout, but will require us to update children.

A few tests had to be modified to no longer change the tree and then check the children immediately.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::prepareForDocumentDestruction): (WebCore::AXObjectCache::performDeferredCacheUpdate):
• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::updateBackingStore):
• accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (convertToNSArray): (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

• accessibility/aria-hidden-update.html:
• accessibility/aria-hidden-updates-alldescendants.html:
• accessibility/image-load-on-delay.html:
• accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
• accessibility/removed-anonymous-block-child-causes-crash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241461] by Alan Coon

• 25 edits
  2 adds
  2 deletes in branches/safari-607-branch

Cherry-pick r241288. rdar://problem/47992210

[Cocoa] Ask platform for generic font family mappings
​https://bugs.webkit.org/show_bug.cgi?id=187723
<rdar://problem/41892438>

Reviewed by Brent Fulgham.

Source/WebCore:

WebKit API allows setting the generic font families for the USCRIPT_COMMON script.
When trying to style a character with a generic font family, we first look to see if
we have a mapping for the particular script the character is rendered with, and if we
don't find a match, we then check USCRIPT_COMMON.

In the Cocoa ports, the only way families get set for non-USCRIPT_COMMON scripts (aka
the only scripts which won't use the API families) is in
SettingsBase::initializeDefaultFontFamilies(). That function only sets the families
for the CJK scripts.

The mappings inside SettingsBase are incorrect and conflict with our policy regarding
user-installed fonts. Instead, we should be consulting with the platform for some of
these mappings, by calling CTFontDescriptorCreateForCSSFamily(). However, the WebKit
API still has to work to set the mappings for untagged content. Therefore, we use the
system mappings for language-tagged content, and the API mappings for non-language-tagged
content. This is a good balance that makes sure we always have a good mapping for every
language, but API clients can still set the mappings, too.

Test: fast/text/ja-sans-serif.html

• css/CSSComputedStyleDeclaration.cpp:
• css/CSSFontSelector.cpp: (WebCore::resolveGenericFamily):
• css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontFamily):
• page/cocoa/SettingsBaseCocoa.mm: (WebCore::SettingsBase::initializeDefaultFontFamilies): (WebCore::osakaMonoIsInstalled): Deleted.
• platform/graphics/FontDescription.cpp: (WebCore::FontDescription::platformResolveGenericFamily):
• platform/graphics/FontDescription.h:
• platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::computeSpecializedChineseLocale): (WebCore::cachedSpecializedChineseLocale): (WebCore::languageChanged): (WebCore::FontDescription::platformResolveGenericFamily):
• platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::clear): (WebCore::genericFamily): (WebCore::SystemFontDatabaseCoreText::serifFamily): (WebCore::SystemFontDatabaseCoreText::sansSerifFamily): (WebCore::SystemFontDatabaseCoreText::cursiveFamily): (WebCore::SystemFontDatabaseCoreText::fantasyFamily): (WebCore::SystemFontDatabaseCoreText::monospaceFamily):
• platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

Source/WebCore/PAL:

• pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

Add an ENABLE in Platform.

• wtf/Platform.h:

Tools:

Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().

• DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet):
• WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet):

LayoutTests:

Update the tests to work with this new model.

• fast/text/international/font-fallback-to-common-script-expected.html: Removed.
• fast/text/international/font-fallback-to-common-script.html: Removed.
• fast/text/international/lang-sensitive-fonts-expected.html:
• fast/text/international/lang-sensitive-fonts-xml-expected.html:
• fast/text/international/lang-sensitive-fonts-xml.xhtml:
• fast/text/international/lang-sensitive-fonts.html:
• fast/text/international/locale-sensitive-fonts-expected.html:
• fast/text/international/locale-sensitive-fonts.html:
• fast/text/ja-sans-serif-expected-mismatch.html: Added.
• fast/text/ja-sans-serif.html: Added.
• platform/ios/fast/block/float/016-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241460] by Alan Coon

• 2 edits in branches/safari-607-branch/Source/JavaScriptCore

Cherry-pick r241267. rdar://problem/47971556

Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor.
​https://bugs.webkit.org/show_bug.cgi?id=194493
<rdar://problem/36380852>

Reviewed by Yusuke Suzuki.

Having duplicate cases in the BinarySwitch is not a correctness issue. It is
however not good for performance and memory usage. As such, a debug ASSERT will
do. We'll also do an audit of the clients of BinarySwitch to see if it's
possible to be instantiated with duplicate cases in
​https://bugs.webkit.org/show_bug.cgi?id=194492 later.

Also added some value dumps to the RELEASE_ASSERT to help debug the issue when we
see duplicate cases.

• jit/BinarySwitch.cpp: (JSC::BinarySwitch::BinarySwitch):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241459] by Alan Coon

• 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241231. rdar://problem/47971603

[Cocoa] CTLineGetGlyphRuns() might return nullptr
​https://bugs.webkit.org/show_bug.cgi?id=194467
<rdar://problem/42423999>

Reviewed by Simon Fraser.

Be somewhat defensive to try to make sure this sort of thing doesn't happen in the future.

Covered by find/text/find-backwards.html

• platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241458] by Alan Coon

• 14 edits
  1 add in branches/safari-607-branch

Cherry-pick r241228. rdar://problem/47971567

Nodes that rely on being dominated by CheckInBounds should have a child edge to it
​https://bugs.webkit.org/show_bug.cgi?id=194334
<rdar://problem/47844327>

Reviewed by Mark Lam.

JSTests:

• stress/check-in-bounds-should-be-a-child-use.js: Added. (func):

Source/JavaScriptCore:

• dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
• dfg/DFGClobberize.h: (JSC::DFG::clobberize):
• dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants):
• dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::convertToHasIndexedProperty):
• dfg/DFGIntegerCheckCombiningPhase.cpp: (JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
• dfg/DFGIntegerRangeOptimizationPhase.cpp:
• dfg/DFGNodeType.h:
• dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCheckInBounds): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241457] by Alan Coon

• 4 edits in branches/safari-607-branch/Source/JavaScriptCore

Cherry-pick r241210. rdar://problem/47971573

Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and StringCharAt nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194446
<rdar://problem/47926792>

Reviewed by Saam Barati.

Fix doesGC() for the following nodes:

CheckTierUpAtReturn:

Calls triggerTierUpNow(), which calls triggerFTLReplacementCompile(),
which calls Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpInLoop:

Calls triggerTierUpNowInLoop(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpAndOSREnter:

Calls triggerOSREntryNow(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

GetByVal:

case Array::String calls operationSingleCharacterString(), which calls
jsSingleCharacterString(), which can allocate a string.

PutByValDirect:
PutByVal:
PutByValAlias:

For the DFG only, the integer TypeArrays calls compilePutByValForIntTypedArray(),
which may call slow paths operationPutByValDirectStrict(), operationPutByValDirectNonStrict(),
operationPutByValStrict(), or operationPutByValNonStrict(). All of these
slow paths call putByValInternal(), which may create exception objects, or
call the generic JSValue::put() which may execute arbitrary code.

StringCharAt:

Can call operationSingleCharacterString(), which calls jsSingleCharacterString(),
which can allocate a string.

Also fix DFG::SpeculativeJIT::compileGetByValOnString() and FTL's compileStringCharAt()
to use the maxSingleCharacterString constant instead of a literal constant.

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString):
• dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241456] by Alan Coon

• 5 edits in branches/safari-607-branch

Cherry-pick r241203. rdar://problem/47971610

[WebVTT] Inline WebVTT styles should start with '::cue'
​https://bugs.webkit.org/show_bug.cgi?id=194227
<rdar://problem/47791087>

Reviewed by Eric Carlson.

Source/WebCore:

Check that the CSS string starts with '::cue' and is successfully parsed before adding it
to the CSS stylesheet list. Also, the caption preferences CSS string should start with
'::cue', since it is added inside the video shadow root element.

Test: media/track/track-cue-css.html

• html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::checkAndStoreStyleSheet):
• page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):

LayoutTests:

• media/track/captions-webvtt/css-styling.vtt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241455] by Alan Coon

• 10 edits in branches/safari-607-branch

Cherry-pick r241200. rdar://problem/47971541

Running RTCRtpSender.getCapabilities("video") before initial offer breaks VP8
​https://bugs.webkit.org/show_bug.cgi?id=194380
<rdar://problem/47916514>

Reviewed by Eric Carlson.

Source/WebCore:

Set whether VP8 is supported at creation of the page.
This ensures that any call creating a peer connection factory will end up supporting the runtime flag configuration.

Add internal API to enable resetting the factory to enable proper testing.

Covered by updated test.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend):
• page/Page.cpp: (WebCore::m_applicationManifest):
• platform/mediastream/libwebrtc/LibWebRTCProvider.h:
• testing/Internals.cpp: (WebCore::Internals::clearPeerConnectionFactory):
• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• webrtc/video-mute-vp8-expected.txt:
• webrtc/video-mute-vp8.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241454] by Alan Coon

• 6 edits in branches/safari-607-branch

Cherry-pick r241198. rdar://problem/47971587

[WebIDL] Support serializing sequences and FrozenArrays of non-interfaces
​https://bugs.webkit.org/show_bug.cgi?id=190997
<rdar://problem/35983035>

Reviewed by Brent Fulgham.

Source/WebCore:

Support serializing sequences and FrozenArrays of types that aren't interfaces. This is
needed to properly serialize PaymentAddress, which has a FrozenArray of DOMStrings.

We should support serializing sequences of interfaces too, but that's slightly more
complicated since it involves iterating the sequence and serializing each of its items. I
left that as a follow-up task, since I don't see any IDLs that currently need this.

We also don't support serializing sequences with the CachedAttribute or CustomGetter
extended attributes, because WebIDL specifies that a new array should be created when
converting an IDL sequence into an ECMAScript value.

Added bindings test cases to TestSerialization.idl and PaymentAddress test cases to
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html.

• bindings/scripts/CodeGenerator.pm: (GetInterfaceForType): Renamed from GetInterfaceForAttribute. (IsSerializableType): Modified to allow sequences and FrozenArrays of non-interface types. (hasCachedAttributeOrCustomGetterExtendedAttribute): Added a helper to determine if an attribute has the CachedAttribute or CustomGetter extended attributes. (IsSerializableAttribute): Checked for sequences with the CachedAttribute or CustomGetter extended attributes before calling IsSerializableType. (GetInterfaceForAttribute): Renamed to GetInterfaceForType.
• bindings/scripts/test/JS/JSTestSerialization.cpp:
• bindings/scripts/test/TestSerialization.idl:

LayoutTests:

• http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:10 PM Changeset in webkit [241453] by Michael Catanzaro

• 2 edits in trunk/Source/WebKit

Fix -Wformat warning from r241401
​https://bugs.webkit.org/show_bug.cgi?id=194584
<rdar://problem/47761293>

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

12:49 PM Changeset in webkit [241452] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Make WebRTCUnifiedPlanEnabled true by default
​https://bugs.webkit.org/show_bug.cgi?id=194595

Reviewed by Eric Carlson.

• Shared/WebPreferences.yaml:

12:47 PM Changeset in webkit [241451] by wilander@apple.com

• 37 edits
  1 copy
  3 adds in trunk

Store Ad Click Attribution requests in the network process
​https://bugs.webkit.org/show_bug.cgi?id=194510
<rdar://problem/47650118>

Reviewed by Alex Christensen and Daniel Bates.

Source/WebCore:

Test: http/tests/adClickAttribution/store-ad-click-attribution.html

This patch adds support functions for validation and storage of
WebCore::AdClickAttribution objects. It also adds WTF::HashTraits so that
WebCore::AdClickAttribution::Source and WebCore::AdClickAttribution::Destination
can be used in a HashMap.

• loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::toString const):

• loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Source::operator== const):
(WebCore::AdClickAttribution::Source::deletedValue):
(WebCore::AdClickAttribution::Source::constructDeletedValue):
(WebCore::AdClickAttribution::Source::deleteValue):
(WebCore::AdClickAttribution::Source::isDeletedValue const):
(WebCore::AdClickAttribution::SourceHash::hash):
(WebCore::AdClickAttribution::SourceHash::equal):
(WebCore::AdClickAttribution::Destination::operator== const):
(WebCore::AdClickAttribution::Destination::matches const):

This convenience function allows matching of a WTF::URL object.

(WebCore::AdClickAttribution::Destination::deletedValue):
(WebCore::AdClickAttribution::Destination::constructDeletedValue):
(WebCore::AdClickAttribution::Destination::deleteValue):
(WebCore::AdClickAttribution::Destination::isDeletedValue const):
(WebCore::AdClickAttribution::DestinationHash::hash):
(WebCore::AdClickAttribution::DestinationHash::equal):
(WebCore::AdClickAttribution::source const):
(WebCore::AdClickAttribution::destination const):

Getters added to support mapped storage based on source and destination.

(WTF::HashTraits<WebCore::AdClickAttribution::Source>::emptyValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Source>::constructDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Source>::isDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::emptyValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::constructDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::isDeletedValue):

• loader/NavigationAction.h:

(WebCore::NavigationAction::adClickAttribution const):
(WebCore::NavigationAction::adClickAttribution): Deleted.

Corrected the constness of this function.

Source/WebKit:

With this patch, WebPageProxy::didCommitLoadForFrame() now looks for
an AdClickAttribution object in its navigation state. If there is an
attribution, it sends it to the network process where the
WebKit::NetworkSession stores it in an object of a new class,
WebKit::NetworkAdClickAttribution.

This patch also covers test infrastructure to support two new
TestRunner functions:

• dumpAdClickAttribution()
• clearAdClickAttribution()

• NetworkProcess/Cookies/WebCookieManager.cpp:

Added missing header include.

• NetworkProcess/Downloads/DownloadManager.cpp:

Added missing header include.

• NetworkProcess/NetworkAdClickAttribution.cpp: Added.

(WebKit::NetworkAdClickAttribution::ensureDestinationMapForSource):
(WebKit::NetworkAdClickAttribution::store):
(WebKit::NetworkAdClickAttribution::clear):
(WebKit::NetworkAdClickAttribution::toString const):

• NetworkProcess/NetworkAdClickAttribution.h: Added.

Stores WebCore::AdClickAttribution objects in a map structure.

• NetworkProcess/NetworkLoad.cpp:

Added missing header includes.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::storeAdClickAttribution):
(WebKit::NetworkProcess::dumpAdClickAttribution):
(WebKit::NetworkProcess::clearAdClickAttribution):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::storeAdClickAttribution):
(WebKit::NetworkSession::dumpAdClickAttribution):
(WebKit::NetworkSession::clearAdClickAttribution):

• NetworkProcess/NetworkSession.h:
• NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

Added missing header include.

• Sources.txt:

Added NetworkProcess/NetworkAdClickAttribution.cpp.

• UIProcess/API/APINavigation.h:

(API::Navigation::adClickAttribution const):

• UIProcess/API/C/WKPage.cpp:

(WKPageDumpAdClickAttribution):
(WKPageClearAdClickAttribution):

Test infrastructure.

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::dumpAdClickAttribution):
(WebKit::NetworkProcessProxy::clearAdClickAttribution):

Test infrastructure.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):

This is where pending Ad Click Attributions are forwarded to the
network process.

(WebKit::WebPageProxy::dumpAdClickAttribution):
(WebKit::WebPageProxy::clearAdClickAttribution):

Test infrastructure.

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::dumpAdClickAttribution):
(WebKit::WebProcessPool::clearAdClickAttribution):

Test infrastructure.

• UIProcess/WebProcessPool.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Added missing data copying from navigationAction to navigationActionData.

Tools:

This patch adds two TestRunner functions:

• dumpAdClickAttribution()
• clearAdClickAttribution()

They call into the network process to dump and clear Ad Click
Attribution state, respectively.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dumpAdClickAttribution):
(WTR::TestRunner::clearAdClickAttribution):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
(WTR::adClickAttributionStringResultCallback):
(WTR::TestController::dumpAdClickAttribution):
(WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
(WTR::adClickAttributionVoidCallback):
(WTR::TestController::clearAdClickAttribution):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::dumpAdClickAttribution):

• WebKitTestRunner/TestInvocation.h:

LayoutTests:

• TestExpectations:

Marked "Skip" because the feature is not applicable to WK1.

• http/tests/adClickAttribution/store-ad-click-attribution-expected.txt: Added.
• http/tests/adClickAttribution/store-ad-click-attribution.html: Added.
• platform/wk2/TestExpectations:

Marked "Pass."

12:34 PM Changeset in webkit [241450] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

Revert r240434
​https://bugs.webkit.org/show_bug.cgi?id=194600
<rdar://problem/48044566>

Reviewed by Brent Fulgham.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::updateVolume):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume):

12:34 PM Changeset in webkit [241449] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Create a randomized free list for new StructureIDs on StructureIDTable resize.
​https://bugs.webkit.org/show_bug.cgi?id=194566
<rdar://problem/47975502>

Reviewed by Michael Saboff.

Also isolate 32-bit implementation of StructureIDTable out more so the 64-bit
implementation is a little easier to read.

This patch appears to be perf neutral on JetStream2 (as run from the command line).

• runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::makeFreeListFromRange):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):
(JSC::StructureIDTable::deallocateID):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::flushOldTables):

11:24 AM Changeset in webkit [241448] by Antti Koivisto

• 2 edits in trunk/Source/WebKit

Crash in WebKit::CacheStorage::Engine::cachesRootPath
​https://bugs.webkit.org/show_bug.cgi?id=194588
<rdar://problem/46363997>

Reviewed by Youenn Fablet.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::cachesRootPath):

Salt may have not been initialized yet when the Engine is destroyed.

11:16 AM Changeset in webkit [241447] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

VariableLengthObject::allocate<T> should initialize objects
​https://bugs.webkit.org/show_bug.cgi?id=194534

Reviewed by Michael Saboff.

buffer() should not be called for empty VariableLengthObjects, but
these cases were not being caught due to the objects not being properly
initialized. Fix it so that allocate calls the constructor and fix the
assertion failues.

• runtime/CachedTypes.cpp:

(JSC::CachedObject::operator new):
(JSC::VariableLengthObject::allocate):
(JSC::CachedVector::encode):
(JSC::CachedVector::decode const):
(JSC::CachedUniquedStringImpl::decode const):
(JSC::CachedBitVector::encode):
(JSC::CachedBitVector::decode const):
(JSC::CachedArray::encode):
(JSC::CachedArray::decode const):
(JSC::CachedImmutableButterfly::CachedImmutableButterfly):
(JSC::CachedBigInt::decode const):

11:11 AM Changeset in webkit [241446] by Alan Coon

• 7 edits in trunk/Source

Versioning.

11:05 AM Changeset in webkit [241445] by Alan Coon

• 1 copy in tags/Safari-608.1.6

Tag Safari-608.1.6.

11:00 AM Changeset in webkit [241444] by achristensen@apple.com

• 6 edits in trunk/Source/WebCore

Stop using setDefersLoading from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=194315

Reviewed by Jer Noble.

That is what CompletionHandlers are for.

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::setDefersLoading): Deleted.

• loader/MediaResourceLoader.h:
• platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::responseReceived):
(WebCore::PlatformMediaResource::stop):
(WebCore::PlatformMediaResource::setDefersLoading): Deleted.

• platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Deleted.

10:54 AM Changeset in webkit [241443] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Generate status-bubble
​https://bugs.webkit.org/show_bug.cgi?id=194572

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._should_show_bubble_for):
(StatusBubble._build_bubbles_for_patch):

10:50 AM Changeset in webkit [241442] by Tadeu Zagallo

• 3 edits in trunk/Source/JavaScriptCore

CodeBlocks read from disk should not be re-written
​https://bugs.webkit.org/show_bug.cgi?id=194535

Reviewed by Michael Saboff.

Keep track of which CodeBlocks have been read from disk or have already
been serialized in CodeCache.

• runtime/CodeCache.cpp:

(JSC::CodeCache::write):

• runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(JSC::CodeCacheMap::fetchFromDiskImpl):

10:35 AM Changeset in webkit [241441] by achristensen@apple.com

• 13 edits in trunk/Source/WebKit

Remove legacy sync messaging in some IPC code
​https://bugs.webkit.org/show_bug.cgi?id=194561

Reviewed by Geoffrey Garen.

Changing some LegacySync messages to Delayed messages. We should probably rename Delayed to Sync.
There are too many ways to send messages. Let's work to get rid of the old one.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAllowsAnySSLCertificateForWebSocket):
(WebKit::NetworkProcess::processWillSuspendImminently):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::handleKeyboardEvent):
(WebKit::PluginControllerProxy::handleEditingCommand):
(WebKit::PluginControllerProxy::isEditingCommandEnabled):
(WebKit::PluginControllerProxy::handlesPageScaleFactor):
(WebKit::PluginControllerProxy::requiresUnifiedScaleFactor):
(WebKit::PluginControllerProxy::paintEntirePlugin):
(WebKit::PluginControllerProxy::supportsSnapshotting):
(WebKit::PluginControllerProxy::snapshot):
(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
(WebKit::PluginControllerProxy::getFormValue):

• PluginProcess/PluginControllerProxy.h:
• PluginProcess/PluginControllerProxy.messages.in:
• Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::deallocate):
(WebKit::NPObjectMessageReceiver::hasMethod):
(WebKit::NPObjectMessageReceiver::invoke):
(WebKit::NPObjectMessageReceiver::invokeDefault):
(WebKit::NPObjectMessageReceiver::hasProperty):
(WebKit::NPObjectMessageReceiver::getProperty):
(WebKit::NPObjectMessageReceiver::setProperty):
(WebKit::NPObjectMessageReceiver::removeProperty):
(WebKit::NPObjectMessageReceiver::enumerate):
(WebKit::NPObjectMessageReceiver::construct):

• Shared/Plugins/NPObjectMessageReceiver.h:
• Shared/Plugins/NPObjectMessageReceiver.messages.in:
• UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::secItemRequest):

• UIProcess/mac/SecItemShimProxy.h:
• UIProcess/mac/SecItemShimProxy.messages.in:

10:30 AM Changeset in webkit [241440] by aakash_jain@apple.com

• 1 edit
  1 copy
  1 add in trunk/Tools

[ews-app] Add status bubble html template
​https://bugs.webkit.org/show_bug.cgi?id=194571

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/templates: Added.
• BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.

10:06 AM Changeset in webkit [241439] by Alan Coon

• 7 edits in branches/safari-607-branch/Source

Versioning.

10:02 AM Changeset in webkit [241438] by Alan Coon

• 4 edits in branches/safari-607-branch/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:45 AM Changeset in webkit [241437] by jer.noble@apple.com

• 4 edits in trunk/Source/WebCore

[Cocoa] Switch to CVPixelBufferGetBytesPerRow() for calculating CVPixelBuffer base address size.
​https://bugs.webkit.org/show_bug.cgi?id=194580
<rdar://problem/42727739>

Reviewed by Eric Carlson.

• platform/cocoa/CoreVideoSoftLink.cpp:
• platform/cocoa/CoreVideoSoftLink.h:
• platform/graphics/cv/PixelBufferConformerCV.cpp:

(WebCore::CVPixelBufferGetBytePointerCallback):
(WebCore::PixelBufferConformerCV::createImageFromPixelBuffer):

9:12 AM Changeset in webkit [241436] by sihui_liu@apple.com

• 3 edits
  6 adds in trunk/LayoutTests

Add two regression tests for reference cycle in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=194527

Reviewed by Geoffrey Garen.

• fast/dom/reference-cycle-leaks.html:
• platform/win/TestExpectations:

The added tests are failing on win bots for unknown reasons, propably related to webkit.org/b/193540. Skip them
on win.

• storage/indexeddb/resources/result-request-cycle.js: Added.

(prepareDatabase):

• storage/indexeddb/resources/value-cursor-cycle.js: Added.

(prepareDatabase):
(onOpen.cursorRequest.onsuccess):

• storage/indexeddb/result-request-cycle-expected.txt: Added.
• storage/indexeddb/result-request-cycle.html: Added.
• storage/indexeddb/value-cursor-cycle-expected.txt: Added.
• storage/indexeddb/value-cursor-cycle.html: Added.

8:55 AM Changeset in webkit [241435] by Truitt Savell

• 3 edits in trunk/Source/WebKit

Unreviewed, rolling out r241433.

Broke internal builds.

Reverted changeset:

"Move
UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to
SPI"
​https://bugs.webkit.org/show_bug.cgi?id=194531
​https://trac.webkit.org/changeset/241433

8:40 AM Changeset in webkit [241434] by bshafiei@apple.com

• 4 edits in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241352. rdar://problem/47941089

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:46 AM Changeset in webkit [241433] by graouts@webkit.org

• 3 edits in trunk/Source/WebKit

Move UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to SPI
​https://bugs.webkit.org/show_bug.cgi?id=194531
<rdar://problem/47714562>

Reviewed by Dean Jackson.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cancelPointersForGestureRecognizer:]): We update the referenced Radar since we need to keep the call
to respondsToSelector until the SPI has shipped for OpenSource builds to work.

5:34 AM Changeset in webkit [241432] by graouts@webkit.org

• 18 edits
  3 adds in trunk

Support simulated mouse events on iOS based on a PlatformTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=194501
<rdar://problem/46910790>

Reviewed by Dean Jackson.

Source/WebCore:

Add support for two new internal runtime flags to control whether simulated mouse events should be dipatched along with touch events and
whether simulated mousemove events dispatched should automatically trigger the behavior preventDefault() would also trigger. To facilitate
that, we allow for a MouseEvent to be created, much like a PointerEvent, based on a PlatformTouchEvent. Then, we set a flag on Event within
EventTarget::innerInvokeEventListeners() to see whether any page code has been evaluated as a result of a mousemove event being dispatched.
Finally, we also track mouse events when invalidating touch regions provided the required internal runtime flag is on.

Test: fast/events/touch/ios/mouse-events-dispatch-with-touch.html

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/Event.cpp:
• dom/Event.h:

(WebCore::Event::hasEncounteredListener const):
(WebCore::Event::setHasEncounteredListener):

• dom/EventNames.h:

(WebCore::EventNames::isTouchRelatedEventType const):
(WebCore::EventNames::touchRelatedEventNames const):
(WebCore::EventNames::extendedTouchRelatedEventNames const):
(WebCore::EventNames::isTouchEventType const): Deleted.
(WebCore::EventNames::touchAndPointerEventNames const): Deleted.

• dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

• dom/MouseEvent.h:
• dom/Node.cpp:

(WebCore::Node::moveNodeToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::defaultEventHandler):

• dom/ios/MouseEventIOS.cpp: Added.

(WebCore::mouseEventType):
(WebCore::MouseEvent::create):

• dom/ios/PointerEventIOS.cpp:

(WebCore::pointerEventType):
(WebCore::PointerEvent::create):
(WebCore::eventType): Deleted.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

• page/EventHandler.h:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::mouseEventsSimulationEnabled const):
(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const):
(WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled):

Source/WebKit:

Add two new internal runtime flags to control whether simulated mouse events should be dipatched along with touch events and whether
simulated mousemove events dispatched should automatically trigger the behavior preventDefault() would also trigger. We also ensure
that we correctly create touch tracking regions for mouse events.

• Shared/WebPreferences.yaml:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateTouchEventTracking):

LayoutTests:

Add a new test to check that we correctly dispatch mouse events as touches occur.

• fast/events/touch/ios/mouse-events-dispatch-with-touch-expected.txt: Added.
• fast/events/touch/ios/mouse-events-dispatch-with-touch.html: Added.
• pointerevents/utils.js:

(prototype.handleEvent):
(prototype._handlePointerEvent):
(prototype._handleMouseEvent):

4:21 AM Changeset in webkit [241431] by Tadeu Zagallo

• 2 edits in trunk/Source/JavaScriptCore

SourceCode should be copied when generating bytecode for functions
​https://bugs.webkit.org/show_bug.cgi?id=194536

Reviewed by Saam Barati.

The FunctionExecutable might be collected while generating the bytecode
for nested functions, in which case the SourceCode reference would no
longer be valid.

• runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockForFunctions):

2:12 AM Changeset in webkit [241430] by Fujii Hironori

• 3 edits in trunk/LayoutTests

[GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=194587

Unreviewed gardening.

• platform/gtk/TestExpectations: Removed DumpJSConsoleLogInStdErr markers which are marked in top TestExpectations.
• platform/wpe/TestExpectations: Ditto.

1:58 AM Changeset in webkit [241429] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241402 - [FreeType] Unable to render some Hebrew characters
​https://bugs.webkit.org/show_bug.cgi?id=194498

Reviewed by Michael Catanzaro.

We are failing to find a font for some of the combining character sequences because normalization is failing due
to overflow error. In case of overflow, normalize returns the required length for the normalized characters, so
we should handle that case to resize the output buffer and try again.

• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence const):

1:58 AM Changeset in webkit [241428] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241401 - Crash in Page::setActivityState because m_page is null
​https://bugs.webkit.org/show_bug.cgi?id=194584

Reviewed by Antti Koivisto.

Add a null check to avoid the crash. Also add a debug assertion to help diagnose this in the future.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

1:57 AM Changeset in webkit [241427] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241352 - Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp:

(WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

1:57 AM Changeset in webkit [241426] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241351 - Responsiveness timers are too expensive for frequent events
​https://bugs.webkit.org/show_bug.cgi?id=194003

Reviewed by Geoffrey Garen.

With each event, we set a responsivness timer to check if the WebProcess
is responsive, and reset the timer when the WebProcess sends an answer.

For frequent events (e.g. wheel events, mouse force events, etc),
we are spamming the kernel with hundreds of timers per second.
That is a bit inefficient.

Another source of inefficiency comes from the timer implementation
itself. Stopping a RunLoop::Timer removes the timer from every mode
and invalidate the timer. It becomes costly since we do it a lot.

With this patch, I tweak ResponsivenessTimer and its use to minimize
how often we schedule system timers.

The first change is to not stop the timer when we get the stop()
calls if we expect more events to come in. Instead, we keep track
if we care about the timeout or not in the attribute "m_waitingForTimer".
When the next event starts, we can reschedule the timer without ever
having told the kernel about the stop.
If there are no next events, the timeout fires but m_waitingForTimer
is false. To avoid idle wake up, the lazy stop is only used when having
following events is common.

The second improvements comes from not even rescheduling the timer
when restarted. Instead of changing the timer, we let the original timer
fire and re-shedule a new one with the missing time.

For more context, also see patches r240759 and r240944.

• UIProcess/ResponsivenessTimer.cpp:

(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::invalidate):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(WebKit::ResponsivenessTimer::startWithLazyStop):
(WebKit::ResponsivenessTimer::stop):
(WebKit::ResponsivenessTimer::processTerminated):
(WebKit::ResponsivenessTimer::~ResponsivenessTimer): Deleted.

• UIProcess/ResponsivenessTimer.h:

(WebKit::ResponsivenessTimer::hasActiveTimer const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::isResponsiveWithLazyStop):

• UIProcess/WebProcessProxy.h:

1:57 AM Changeset in webkit [241425] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241350 - Unreviewed, rolling out r241273.
​https://bugs.webkit.org/show_bug.cgi?id=194579

This change is causing a flaky assertion failure crash in High
Sierra Debug (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Stop using setDefersLoading from WebCore"
​https://bugs.webkit.org/show_bug.cgi?id=194315
​https://trac.webkit.org/changeset/241273

1:57 AM Changeset in webkit [241424] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241338 - WebServiceWorkerProvider::handleFetch no longer needs a CachedResource parameter
​https://bugs.webkit.org/show_bug.cgi?id=194548

Reviewed by Alex Christensen.

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::handleFetch):

• WebProcess/Storage/WebServiceWorkerProvider.h:

1:57 AM Changeset in webkit [241423] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241335 - Make B3Value::returnsBool() more precise
​https://bugs.webkit.org/show_bug.cgi?id=194457

Reviewed by Saam Barati.

It is currently used repeatedly in B3ReduceStrength, as well as once in B3LowerToAir.
It has a needlessly complex rule for BitAnd, and has no rule for other easy cases such as BitOr or Select.
No new tests added as this should be indirectly tested by the already existing tests.

• b3/B3Value.cpp:

(JSC::B3::Value::returnsBool const):

1:57 AM Changeset in webkit [241422] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24

Merge r241333 - Align with Fetch on data: URLs
​https://bugs.webkit.org/show_bug.cgi?id=182325

Patch by Rob Buis <​rbuis@igalia.com> on 2019-02-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectations.

• web-platform-tests/fetch/data-urls/processing.any-expected.txt:
• web-platform-tests/fetch/data-urls/processing.any.worker-expected.txt:

Source/WebCore:

The MIME type part of the data url should be serialized as
specified in step 3 under "data" [1].

Test: web-platform-tests/fetch/data-urls/processing.any.js

[1] ​https://fetch.spec.whatwg.org/#concept-scheme-fetch

• platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::parseMediaType):

1:57 AM Changeset in webkit [241421] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merege r241330 - Remove firing assertion after r241317
​https://bugs.webkit.org/show_bug.cgi?id=194506

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::setDefersLoading):
The creation of a PageGroupLoadDeferrer in Chrome.cpp tries to defer loading.
See comments in Chrome::runJavaScriptAlert et al.
This was necessary with WebKitLegacy, so keep it, but it doesn't need to do anything in modern WebKit.

1:57 AM Changeset in webkit [241420] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.24

Merger r241319 - Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

• fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
• fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.

1:57 AM Changeset in webkit [241419] by Carlos Garcia Campos

• 28 edits in releases/WebKitGTK/webkit-2.24

Merge r241317 - Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Reviewed by Brady Eidson.

Source/WebCore:

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::setDefersLoading): Deleted.

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkDataTask.h:
• NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::suspend): Deleted.

• NetworkProcess/NetworkDataTaskBlob.h:
• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::initialize):
(WebKit::NetworkLoad::setDefersLoading): Deleted.

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/NetworkLoadParameters.h:
• NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::setDefersLoading): Deleted.

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::suspend): Deleted.

• NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::suspend): Deleted.

• NetworkProcess/curl/NetworkDataTaskCurl.h:
• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::suspend): Deleted.

• NetworkProcess/soup/NetworkDataTaskSoup.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::setDefersLoading):

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDefersLoading): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

• platform/wk2/TestExpectations:

1:57 AM Changeset in webkit [241418] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241316 - Unreviewed, fix build warnings after content extensions enablement
​https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

Source/WebCore:

• contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

• contentextensions/DFABytecodeCompiler.h:
• contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::statusString):

Source/WebKit:

• UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(toResult):

1:57 AM Changeset in webkit [241417] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241315 - Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
​https://bugs.webkit.org/show_bug.cgi?id=194549

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

• UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsInTimeRange):

1:56 AM Changeset in webkit [241416] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

MNerge r241314 - Unreviewed, fix -Wimplicit-fallthrough warning after r241140
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

1:56 AM Changeset in webkit [241415] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241308 - Make use of is<SubresourceLoader>
​https://bugs.webkit.org/show_bug.cgi?id=194541

Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveResponse):

• loader/SubresourceLoader.h:

(isType):

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

1:56 AM Changeset in webkit [241414] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241307 - AX: Fix flaky accessibility/loading-iframe-sends-notification.html
​https://bugs.webkit.org/show_bug.cgi?id=194546

Reviewed by Zalan Bujtas.

This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.

• accessibility/loading-iframe-sends-notification-expected.txt:
• accessibility/loading-iframe-sends-notification.html:

1:56 AM Changeset in webkit [241413] by Carlos Garcia Campos

• 7 edits
  1 add in releases/WebKitGTK/webkit-2.24

Merge r241306 - WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
​https://bugs.webkit.org/show_bug.cgi?id=194522
<rdar://problem/47789393>

Reviewed by Chris Dumez.

Source/WebKit:

The InjectedBundle SPI can retain the WebPage or wrapping objects (WKWebProcessPlugInBrowserContextController/WKBundlePageRef).
This can make it so WebPage::close is called before WebPage::~WebPage, and if the SuspendedPageProxy is reused for a subsequent
navigation to the same domain, the WebProcess is reused with a different WebPage instance with the same PageID, which causes problems
when another WebPage registers message handlers and then the previous WebPage is destroyed, which removes both message handlers.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::mainFrameDidLayout):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebProcess.h:

(WebKit::WebProcess::eventDispatcher):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.

(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

1:56 AM Changeset in webkit [241412] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24/Source/bmalloc

Merge r241305 - Unreviewed, rolling out r241182.
​https://bugs.webkit.org/show_bug.cgi?id=194547

causes a 2-3% Speedometer2 regression. (Requested by
keith_miller on #webkit).

Reverted changeset:

"bmalloc uses more memory on iOS compared to macOS due to
physical page size differences"
​https://bugs.webkit.org/show_bug.cgi?id=192389
​https://trac.webkit.org/changeset/241182

1:56 AM Changeset in webkit [241411] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241304 - [WPE][GTK] Unsafe g_unsetenv() use in WebProcessPool::platformInitialize
​https://bugs.webkit.org/show_bug.cgi?id=194370

Reviewed by Darin Adler.

Source/JavaScriptCore:

Change a couple WTFLogAlways to use g_warning, for good measure. Of course this isn't
necessary, but it will make errors more visible.

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::start):
(Inspector::dbusConnectionCallAsyncReadyCallback):

• inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::start):

Source/WebKit:

It is incorrect to use g_unsetenv() here because it is MT-Unsafe. We know that it is
impossible and unreasonable to expect the application has not started other threads at this
point, and threads will be calling getenv(). WebKit itself has probably already started
threads of its own.

Fortunately, the remote inspector in the web process is already prepared to deal with
failure to connect to the inspector server, so we don't need to do anything except stop
messing with the environment.

Note these files are copies of each other. I'll merge them together in a follow-up patch.

• UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

• UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

1:56 AM Changeset in webkit [241410] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241302 - Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar
​https://bugs.webkit.org/show_bug.cgi?id=194365
<rdar://problem/47868426>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineRecordBar.js:

(WI.TimelineRecordBar.prototype._handleClick):
Mark the "click" event so that later listeners know it was handled by WI.TimelineRecordBar.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype._instrumentAdded):
(WI.TimelineOverview.prototype._instrumentRemoved):
(WI.TimelineOverview.prototype._handleGraphsContainerClick): Added.
(WI.TimelineOverview.prototype._handleOverviewGraphRecordSelected): Added.
(WI.TimelineOverview.prototype._recordSelected):
Listen for "click" on the graph container and deselect all records when fired, unless the
click was marked by a WI.TimelineRecordBar.

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._recordSelected):
Ensure that all WI.TimelineView update their selected record whenever it changes for any
other WI.TimelineView (or if there is no selected record).

• UserInterface/Views/TimelineOverviewGraph.js:

(WI.TimelineOverviewGraph.prototype.didLayoutSubtree): Added.
Drive-by: since WI.TimelineRecordBar are reused when combining, we need to re-determine
which one holds the currently selected record.

1:56 AM Changeset in webkit [241409] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241301 - Web Inspector: Remove unused maxUsage in CPUTimelineView
​https://bugs.webkit.org/show_bug.cgi?id=194526

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView):
(WI.CPUTimelineView.prototype.shown):

1:56 AM Changeset in webkit [241408] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241300 - Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

1. a Document detaches from its StyleSheetList.
2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

2. Fix CodeGeneratorJS.pm to null check the opaque root before using it.

• bindings/js/JSNodeCustom.h:

(WebCore::root):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

1:56 AM Changeset in webkit [241407] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241298 - Unreviewed WPE gardening. Unskip content extensions tests after r241283

• platform/wpe/TestExpectations: Unskip content extensions tests, and list

as failing those known to not pass due to missing expectaions or timeouts.

1:56 AM Changeset in webkit [241406] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241296 - Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

1:56 AM Changeset in webkit [241405] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241295 - [LFC] Remove redundant InlineFormattingContext::computeBorderAndPadding
​https://bugs.webkit.org/show_bug.cgi?id=194540

Reviewed by Antti Koivisto.

Use FormattingContext::computeBorderAndPadding instead.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeBorderAndPadding const):

• layout/FormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:

1:56 AM Changeset in webkit [241404] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.24

Merge r241294 - [LFC][IFC] Add intrinsic width support for float boxes.
​https://bugs.webkit.org/show_bug.cgi?id=194528

Reviewed by Antti Koivisto.

Source/WebCore:

This patch implements a very simple float box support for intrinsic width.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFloatBox const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForInlineBlock const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:

Tools:

Expand tests coverage (2 new tests -> 800).
(This is the correct test ordering --runs-singly --child-processes=1)

• LayoutReloaded/misc/LFC-passing-tests.txt:

1:12 AM Changeset in webkit [241403] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241131. rdar://problem/47627599

Print backgrounds preference should be honored instead of WKWebViewConfiguration value
​https://bugs.webkit.org/show_bug.cgi?id=194364
<rdar://problem/47627599>

Reviewed by Tim Horton.

Without this patch, changing the preference for printing the background has no effect.
This patch fixes that, and I verified it manually by checking "Print backgrounds" in Safari's print menu.
Unfortunately, the only way to test this is actually printing because only values from WebPageProxy::preferences
or WebPageProxy::configuration's preferences are exposed to the API, but values from WebPageProxy::preferencesStore
are used when printing. Actually printing verifies this change fixes the bug.

• UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:10 AM Changeset in webkit [241402] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[FreeType] Unable to render some Hebrew characters
​https://bugs.webkit.org/show_bug.cgi?id=194498

Reviewed by Michael Catanzaro.

We are failing to find a font for some of the combining character sequences because normalization is failing due
to overflow error. In case of overflow, normalize returns the required length for the normalized characters, so
we should handle that case to resize the output buffer and try again.

• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence const):

1:07 AM Changeset in webkit [241401] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit

Crash in Page::setActivityState because m_page is null
​https://bugs.webkit.org/show_bug.cgi?id=194584

Reviewed by Antti Koivisto.

Add a null check to avoid the crash. Also add a debug assertion to help diagnose this in the future.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

1:05 AM Changeset in webkit [241400] by bshafiei@apple.com

• 32 edits
  7 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241282. rdar://problem/45929460

[iOS] Mouse/Touch/Pointer events are missing modifier keys
​https://bugs.webkit.org/show_bug.cgi?id=191446
<rdar://problem/45929460>

Reviewed by Tim Horton.

Source/WebCore:

Extract the modifier flags from the WebEvent. This code is only used by Legacy WebKit
on iOS and we will need to fix <rdar://problem/47929759> in order for modifier flags
to be passed to WebKit.

Tests: fast/events/touch/ios/mouse-events-with-modifiers.html

fast/events/touch/ios/pointer-events-with-modifiers.html
fast/events/touch/ios/touch-events-with-modifiers.html

• platform/ios/PlatformEventFactoryIOS.mm: (WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
• platform/ios/WebEvent.h:
• platform/ios/WebEvent.mm: (-[WebEvent initWithMouseEventType:timeStamp:location:]): (-[WebEvent initWithMouseEventType:timeStamp:location:modifiers:]):

Source/WebKit:

Make use of UIKit SPI to retreive the modifier flags when dispatching mouse and touch events.
Add new WebKit SPI for iOS, -[WKNavigationAction modifierFlags], to retrieve the the modifier
flags held when a navigation action was initiated.

• Platform/spi/ios/UIKitSPI.h: Expose SPI.
• Shared/NativeWebTouchEvent.h: Re-arrange macro guards so that we can expose the helper function WebKit::webEventModifierFlags(). This is a bit more involved that usual since this header is included from both C++ and Objective-C source files. It only makes sense to expose this function when compiling as part of an Objective-C source file.
• Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Modified to take the modifier flags held down when the platform touch event was received and pass them through to the base constructor. (WebKit::webEventModifierFlags): Added. Converts from the platform-speciifc UIKeyModifierFlags to OptionSet<WebKit::WebEvent::Modifier>.
• Shared/ios/WebIOSEventFactory.h:
• Shared/ios/WebIOSEventFactory.mm: (WebIOSEventFactory::toUIKeyModifierFlags): Added. Converts from OptionSet<WebKit::WebEvent::Modifier> to the platform-specific UIKeyModifierFlags.
• UIProcess/API/Cocoa/WKNavigationAction.mm: (-[WKNavigationAction modifierFlags]): Added.
• UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm: (gestureRecognizerModifierFlags): Added.

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapCommited:]):
Pass modifier flags through.

(-[WKContentView _attemptClickAtLocation:modifierFlags:]): Added.
(-[WKContentView actionSheetAssistant:openElementAtLocation:]): This is invoked when a person opens a link
via the action sheet. We don't have access to the modifier flags to pass. It also seems like an implementation
detail that this action is implemented via mouse click and we should re-evaluate this decision in light of
the fact tht the action sheet is browser UI and we tend to be very reserved on what UI actions are visible
to the page. On Mac, opening a link via the context menu is not visible to the page, at least from a mouse
event perspective.
(webEventFlagsForUIKeyModifierFlags): Added.
(-[WKContentView _hoverGestureRecognizerChanged:]): Pass modifier flags through.
(-[WKContentView _attemptClickAtLocation:]): Deleted.

• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::handleTwoFingerTapAtPoint): (WebKit::WebPageProxy::commitPotentialTap): (WebKit::WebPageProxy::handleTap):
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::handleSyntheticClick): (WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver): (WebKit::WebPage::completeSyntheticClick): (WebKit::WebPage::handleTap): (WebKit::WebPage::handleTwoFingerTapAtPoint): (WebKit::WebPage::commitPotentialTap): Pass modifier flags through.

Tools:

Add support infrastructure for testing touch and stylus taps when holding modifier keys.

• DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
• TestRunnerShared/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::arrayLength): (WTR::parseModifierArray): (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers(). (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers(). (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

LayoutTests:

Refactor existing iOS key events tests to share code. Add new tests to ensure touch and mouse events
have accurate modifier key details.

• fast/events/ios/key-events-meta-alt-combinations.html:
• fast/events/ios/resources/key-tester.js: (computeSubsets.compareByModifierOrder): Deleted.
• fast/events/resources/compute-subsets.js: Added. (computeSubsets.compareByOriginalArrayOrder): (computeSubsets):
• fast/events/touch/ios/mouse-events-with-modifiers-expected.txt: Added.
• fast/events/touch/ios/mouse-events-with-modifiers.html: Added.
• fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Added.
• fast/events/touch/ios/pointer-events-with-modifiers.html: Added.
• fast/events/touch/ios/touch-events-with-modifiers-expected.txt: Added.
• fast/events/touch/ios/touch-events-with-modifiers.html: Added.
• http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Update expected result due to changes to ui-helper.js.
• http/tests/security/anchor-download-block-crossorigin-expected.txt: Ditto.
• platform/ios/TestExpectations:
• resources/ui-helper.js: (window.UIHelper.tapAt.return.new.Promise): (window.UIHelper.tapAt): (window.UIHelper.stylusTapAt.return.new.Promise): (window.UIHelper.stylusTapAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:05 AM Changeset in webkit [241399] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241007. rdar://problem/47836218

Fix a typo in r241006. Substitute Modifier for Modifiers.

• Shared/mac/NativeWebGestureEventMac.mm: (WebKit::NativeWebGestureEvent::NativeWebGestureEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:05 AM Changeset in webkit [241398] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241006. rdar://problem/47836218

Attempt to fix the build following r241000
(​https://bugs.webkit.org/show_bug.cgi?id=194241)

Substitute OptionSet<WebEvent::Modifier> for Modifiers.

• Shared/mac/NativeWebGestureEventMac.mm: (WebKit::NativeWebGestureEvent::NativeWebGestureEvent):
• Shared/mac/WebGestureEvent.h: (WebKit::WebGestureEvent::WebGestureEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241397] by bshafiei@apple.com

• 8 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241001. rdar://problem/47836218

Attempt to fix the build following r241000
(​https://bugs.webkit.org/show_bug.cgi?id=194241)

Substitute WebEvent::Modifier::CapsLockKey for WebEvent::CapsLockKey.

• Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent):
• Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent):
• UIProcess/API/Cocoa/WKNavigationAction.mm: (toNSEventModifierFlags):
• UIProcess/Automation/WebAutomationSession.cpp: (WebKit::protocolModifierToWebEventModifier):
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::modifiersToEventState):
• UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
• UIProcess/Cocoa/UIDelegate.mm: (WebKit::toNSEventModifierFlags):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241396] by bshafiei@apple.com

• 43 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241000. rdar://problem/47836218

Make WebEvent::Modifiers an OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=194241

Reviewed by Simon Fraser.

Use an OptionSet to represent the bitmask of keyboard modifier flags. This improves type safety
and makes debugging more enjoyable because our LLDB pretty-printers have built-in support for
OptionSet.

While I am at it, make WebEvent::Modifier an enum class. It is currently an enum. This makes
this enum more closely match WebCore::PlatformEvent::Modifier.

• Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI):
• Shared/NavigationActionData.cpp: (WebKit::NavigationActionData::encode const): (WebKit::NavigationActionData::decode):
• Shared/NavigationActionData.h:
• Shared/WebEvent.cpp: (WebKit::WebEvent::WebEvent):
• Shared/WebEvent.h: (WebKit::WebEvent::shiftKey const): (WebKit::WebEvent::controlKey const): (WebKit::WebEvent::altKey const): (WebKit::WebEvent::metaKey const): (WebKit::WebEvent::capsLockKey const): (WebKit::WebEvent::modifiers const): (WebKit::WebTouchEvent::WebTouchEvent):
• Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
• Shared/WebKeyboardEvent.cpp: (WebKit::WebKeyboardEvent::WebKeyboardEvent):
• Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent):
• Shared/WebTouchEvent.cpp: (WebKit::WebTouchEvent::WebTouchEvent):
• Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent):
• Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent):
• Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
• Shared/ios/WebIOSEventFactory.mm: (modifiersForEvent): (WebIOSEventFactory::createWebKeyboardEvent): (WebIOSEventFactory::createWebMouseEvent):
• Shared/libwpe/WebEventFactory.cpp: (WebKit::modifiersForEventModifiers): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebTouchEvent):
• Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
• Shared/win/WebEventFactory.cpp: (WebKit::modifiersForEvent): (WebKit::modifiersForCurrentKeyState): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
• UIProcess/API/APINavigationAction.h:
• UIProcess/API/APIUIClient.h: (API::UIClient::mouseDidMoveOverElement):
• UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient):
• UIProcess/API/Cocoa/WKNavigationAction.mm: (toNSEventModifierFlags):
• UIProcess/API/glib/WebKitPrivate.cpp: (toPlatformModifiers):
• UIProcess/API/glib/WebKitPrivate.h:
• UIProcess/API/glib/WebKitUIClient.cpp:
• UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewMouseTargetChanged):
• UIProcess/API/glib/WebKitWebViewPrivate.h:
• UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::simulateMouseInteraction): (WebKit::protocolModifierToWebEventModifier): (WebKit::WebAutomationSession::performMouseInteraction):
• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::modifiersToEventState): (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
• UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
• UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: (WebKit::modifiersToEventState): (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm: (WebKit::toNSEventModifierFlags): (WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
• WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h: (API::InjectedBundle::PageUIClient::mouseDidMoveOverElement):
• WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: (WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
• WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: (WebKit::InjectedBundleNavigationAction::modifiers const):
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::showContextMenuAtPoint):
• WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::createWebEvent const):
• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::simulateMouseDown): (WebKit::WebPage::simulateMouseUp): (WebKit::WebPage::simulateMouseMotion):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241395] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241332. rdar://problem/47974770

[iOS] Youtube fails to play.
​https://bugs.webkit.org/show_bug.cgi?id=194565
<rdar://problem/47974770>

Reviewed by Geoffrey Garen.

This is caused by sandbox violations and was introduced in r240500.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241394] by bshafiei@apple.com

• 5 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241323. rdar://problem/42087017

Find on Page shouldn't zoom in on matches
​https://bugs.webkit.org/show_bug.cgi?id=194557
<rdar://problem/42087017>

Reviewed by Wenson Hsieh.

• UIProcess/ios/SmartMagnificationController.h:
• UIProcess/ios/SmartMagnificationController.messages.in:
• UIProcess/ios/SmartMagnificationController.mm: (WebKit::SmartMagnificationController::scrollToRect):
• WebProcess/WebPage/ios/FindControllerIOS.mm: (WebKit::FindController::updateFindIndicator): Only scroll to reveal the find result, do not zoom in.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241393] by bshafiei@apple.com

• 3 edits
  2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241319. rdar://problem/47857150

Source/WebCore:
Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

• inspector/PageScriptDebugServer.cpp: (WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

• fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
• fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241392] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241314. rdar://problem/47889777

Unreviewed, fix -Wimplicit-fallthrough warning after r241140
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241391] by bshafiei@apple.com

• 7 edits in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241309. rdar://problem/47924449

REGRESSION (r238955, r240494): Soft-linking optional Lookup.framework triggers release assertion when missing
<​https://webkit.org/b/194529>
<rdar://problem/47924449>

Reviewed by Eric Carlson.

Source/WebCore:

• SourcesCocoa.txt:
• Do not include DataDetectorsCoreSoftLink.mm in unified sources.
• WebCore.xcodeproj/project.pbxproj:
• Add DataDetectorsCoreSoftLink.mm to the WebCore target now that it isn't part of the unifed sources.
• platform/cocoa/DataDetectorsCoreSoftLink.mm:
• Switch from using SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL() to SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE() when linking DataDetectorsCore.framework. None of the other macros assume this framework is optional, and it was likely made optional originally because the framework was new to iOS and thus didn't exist on older versions.
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• Change use of SOFT_LINK_CLASS_FOR_SOURCE() macros to SOFT_LINK_CLASS() since the latter can only be used with SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation). This broke after the fix for <wtf/SoftLinking.h> was applied.

Source/WTF:

• wtf/cocoa/SoftLinking.h: (SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL): Rename SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION() to this and change assertion argument to isOptional. Pass isOptional to framework##Library() method to control assertion behavior. Only check RELEASE_ASSERT() if !isOptional, else that code should be optimized out by the compiler. This fixes the crash. (NO_ASSERT): Remove macro since it's no longer used. (SOFT_LINK_IS_OPTIONAL): Add macro to use for soft-linking optional classes. (SOFT_LINK_IS_NOT_OPTIONAL): Add macro to use for soft-linking non-optional classes. (SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT): Update to use new SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL() macro. (SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT): Ditto. (SOFT_LINK_CLASS_FOR_SOURCE): Ditto. (SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241390] by bshafiei@apple.com

• 4 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241300. rdar://problem/47973274

Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

1. a Document detaches from its StyleSheetList.
2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

2. Fix CodeGeneratorJS.pm to null check the opaque root before using it.

• bindings/js/JSNodeCustom.h: (WebCore::root):
• bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241389] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241296. rdar://problem/47841926

Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241388] by bshafiei@apple.com

• 11 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241289. rdar://problem/37018386

AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
​https://bugs.webkit.org/show_bug.cgi?id=182280
<rdar://problem/37018386>

Reviewed by Alan Bujtas.

Source/WebCore:

Remove the possibility that changing children calls back into updating layout by
handling children changes in a deferred manner.

This follows the same architecture as many other deferred changes, but also requires us to check deferred changes
in updateBackingStore, because things like aria-hidden changes won't trigger a layout, but will require us to update children.

A few tests had to be modified to no longer change the tree and then check the children immediately.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::prepareForDocumentDestruction): (WebCore::AXObjectCache::performDeferredCacheUpdate):
• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::updateBackingStore):
• accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (convertToNSArray): (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

• accessibility/aria-hidden-update.html:
• accessibility/aria-hidden-updates-alldescendants.html:
• accessibility/image-load-on-delay.html:
• accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
• accessibility/removed-anonymous-block-child-causes-crash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241387] by bshafiei@apple.com

• 25 edits
  2 adds
  2 deletes in branches/safari-608.1.5.1-branch

Cherry-pick r241288. rdar://problem/41892438

[Cocoa] Ask platform for generic font family mappings
​https://bugs.webkit.org/show_bug.cgi?id=187723
<rdar://problem/41892438>

Reviewed by Brent Fulgham.

Source/WebCore:

WebKit API allows setting the generic font families for the USCRIPT_COMMON script.
When trying to style a character with a generic font family, we first look to see if
we have a mapping for the particular script the character is rendered with, and if we
don't find a match, we then check USCRIPT_COMMON.

In the Cocoa ports, the only way families get set for non-USCRIPT_COMMON scripts (aka
the only scripts which won't use the API families) is in
SettingsBase::initializeDefaultFontFamilies(). That function only sets the families
for the CJK scripts.

The mappings inside SettingsBase are incorrect and conflict with our policy regarding
user-installed fonts. Instead, we should be consulting with the platform for some of
these mappings, by calling CTFontDescriptorCreateForCSSFamily(). However, the WebKit
API still has to work to set the mappings for untagged content. Therefore, we use the
system mappings for language-tagged content, and the API mappings for non-language-tagged
content. This is a good balance that makes sure we always have a good mapping for every
language, but API clients can still set the mappings, too.

Test: fast/text/ja-sans-serif.html

• css/CSSComputedStyleDeclaration.cpp:
• css/CSSFontSelector.cpp: (WebCore::resolveGenericFamily):
• css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontFamily):
• page/cocoa/SettingsBaseCocoa.mm: (WebCore::SettingsBase::initializeDefaultFontFamilies): (WebCore::osakaMonoIsInstalled): Deleted.
• platform/graphics/FontDescription.cpp: (WebCore::FontDescription::platformResolveGenericFamily):
• platform/graphics/FontDescription.h:
• platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::computeSpecializedChineseLocale): (WebCore::cachedSpecializedChineseLocale): (WebCore::languageChanged): (WebCore::FontDescription::platformResolveGenericFamily):
• platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::clear): (WebCore::genericFamily): (WebCore::SystemFontDatabaseCoreText::serifFamily): (WebCore::SystemFontDatabaseCoreText::sansSerifFamily): (WebCore::SystemFontDatabaseCoreText::cursiveFamily): (WebCore::SystemFontDatabaseCoreText::fantasyFamily): (WebCore::SystemFontDatabaseCoreText::monospaceFamily):
• platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

Source/WebCore/PAL:

• pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

Add an ENABLE in Platform.

• wtf/Platform.h:

Tools:

Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().

• DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet):
• WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet):

LayoutTests:

Update the tests to work with this new model.

• fast/text/international/font-fallback-to-common-script-expected.html: Removed.
• fast/text/international/font-fallback-to-common-script.html: Removed.
• fast/text/international/lang-sensitive-fonts-expected.html:
• fast/text/international/lang-sensitive-fonts-xml-expected.html:
• fast/text/international/lang-sensitive-fonts-xml.xhtml:
• fast/text/international/lang-sensitive-fonts.html:
• fast/text/international/locale-sensitive-fonts-expected.html:
• fast/text/international/locale-sensitive-fonts.html:
• fast/text/ja-sans-serif-expected-mismatch.html: Added.
• fast/text/ja-sans-serif.html: Added.
• platform/ios/fast/block/float/016-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241386] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241267. rdar://problem/36380852

Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor.
​https://bugs.webkit.org/show_bug.cgi?id=194493
<rdar://problem/36380852>

Reviewed by Yusuke Suzuki.

Having duplicate cases in the BinarySwitch is not a correctness issue. It is
however not good for performance and memory usage. As such, a debug ASSERT will
do. We'll also do an audit of the clients of BinarySwitch to see if it's
possible to be instantiated with duplicate cases in
​https://bugs.webkit.org/show_bug.cgi?id=194492 later.

Also added some value dumps to the RELEASE_ASSERT to help debug the issue when we
see duplicate cases.

• jit/BinarySwitch.cpp: (JSC::BinarySwitch::BinarySwitch):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241385] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241231. rdar://problem/42423999

[Cocoa] CTLineGetGlyphRuns() might return nullptr
​https://bugs.webkit.org/show_bug.cgi?id=194467
<rdar://problem/42423999>

Reviewed by Simon Fraser.

Be somewhat defensive to try to make sure this sort of thing doesn't happen in the future.

Covered by find/text/find-backwards.html

• platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241384] by bshafiei@apple.com

• 14 edits
  1 add in branches/safari-608.1.5.1-branch

Cherry-pick r241228. rdar://problem/47844327

Nodes that rely on being dominated by CheckInBounds should have a child edge to it
​https://bugs.webkit.org/show_bug.cgi?id=194334
<rdar://problem/47844327>

Reviewed by Mark Lam.

JSTests:

• stress/check-in-bounds-should-be-a-child-use.js: Added. (func):

Source/JavaScriptCore:

• dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
• dfg/DFGClobberize.h: (JSC::DFG::clobberize):
• dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants):
• dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::convertToHasIndexedProperty):
• dfg/DFGIntegerCheckCombiningPhase.cpp: (JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
• dfg/DFGIntegerRangeOptimizationPhase.cpp:
• dfg/DFGNodeType.h:
• dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCheckInBounds): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241383] by bshafiei@apple.com

• 4 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241210. rdar://problem/47926792

Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and StringCharAt nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194446
<rdar://problem/47926792>

Reviewed by Saam Barati.

Fix doesGC() for the following nodes:

CheckTierUpAtReturn:

Calls triggerTierUpNow(), which calls triggerFTLReplacementCompile(),
which calls Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpInLoop:

Calls triggerTierUpNowInLoop(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpAndOSREnter:

Calls triggerOSREntryNow(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

GetByVal:

case Array::String calls operationSingleCharacterString(), which calls
jsSingleCharacterString(), which can allocate a string.

PutByValDirect:
PutByVal:
PutByValAlias:

For the DFG only, the integer TypeArrays calls compilePutByValForIntTypedArray(),
which may call slow paths operationPutByValDirectStrict(), operationPutByValDirectNonStrict(),
operationPutByValStrict(), or operationPutByValNonStrict(). All of these
slow paths call putByValInternal(), which may create exception objects, or
call the generic JSValue::put() which may execute arbitrary code.

StringCharAt:

Can call operationSingleCharacterString(), which calls jsSingleCharacterString(),
which can allocate a string.

Also fix DFG::SpeculativeJIT::compileGetByValOnString() and FTL's compileStringCharAt()
to use the maxSingleCharacterString constant instead of a literal constant.

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString):
• dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241382] by bshafiei@apple.com

• 5 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241203. rdar://problem/47791087

[WebVTT] Inline WebVTT styles should start with '::cue'
​https://bugs.webkit.org/show_bug.cgi?id=194227
<rdar://problem/47791087>

Reviewed by Eric Carlson.

Source/WebCore:

Check that the CSS string starts with '::cue' and is successfully parsed before adding it
to the CSS stylesheet list. Also, the caption preferences CSS string should start with
'::cue', since it is added inside the video shadow root element.

Test: media/track/track-cue-css.html

• html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::checkAndStoreStyleSheet):
• page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):

LayoutTests:

• media/track/captions-webvtt/css-styling.vtt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241381] by bshafiei@apple.com

• 10 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241200. rdar://problem/47916514

Running RTCRtpSender.getCapabilities("video") before initial offer breaks VP8
​https://bugs.webkit.org/show_bug.cgi?id=194380
<rdar://problem/47916514>

Reviewed by Eric Carlson.

Source/WebCore:

Set whether VP8 is supported at creation of the page.
This ensures that any call creating a peer connection factory will end up supporting the runtime flag configuration.

Add internal API to enable resetting the factory to enable proper testing.

Covered by updated test.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend):
• page/Page.cpp: (WebCore::m_applicationManifest):
• platform/mediastream/libwebrtc/LibWebRTCProvider.h:
• testing/Internals.cpp: (WebCore::Internals::clearPeerConnectionFactory):
• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• webrtc/video-mute-vp8-expected.txt:
• webrtc/video-mute-vp8.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241380] by bshafiei@apple.com

• 6 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241198. rdar://problem/35983035

[WebIDL] Support serializing sequences and FrozenArrays of non-interfaces
​https://bugs.webkit.org/show_bug.cgi?id=190997
<rdar://problem/35983035>

Reviewed by Brent Fulgham.

Source/WebCore:

Support serializing sequences and FrozenArrays of types that aren't interfaces. This is
needed to properly serialize PaymentAddress, which has a FrozenArray of DOMStrings.

We should support serializing sequences of interfaces too, but that's slightly more
complicated since it involves iterating the sequence and serializing each of its items. I
left that as a follow-up task, since I don't see any IDLs that currently need this.

We also don't support serializing sequences with the CachedAttribute or CustomGetter
extended attributes, because WebIDL specifies that a new array should be created when
converting an IDL sequence into an ECMAScript value.

Added bindings test cases to TestSerialization.idl and PaymentAddress test cases to
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html.

• bindings/scripts/CodeGenerator.pm: (GetInterfaceForType): Renamed from GetInterfaceForAttribute. (IsSerializableType): Modified to allow sequences and FrozenArrays of non-interface types. (hasCachedAttributeOrCustomGetterExtendedAttribute): Added a helper to determine if an attribute has the CachedAttribute or CustomGetter extended attributes. (IsSerializableAttribute): Checked for sequences with the CachedAttribute or CustomGetter extended attributes before calling IsSerializableType. (GetInterfaceForAttribute): Renamed to GetInterfaceForType.
• bindings/scripts/test/JS/JSTestSerialization.cpp:
• bindings/scripts/test/TestSerialization.idl:

LayoutTests:

• http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241379] by bshafiei@apple.com

• 3 edits
  2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241171. rdar://problem/47550281

[iOS] Clicking links in Safari using Apple Pencil is much more difficult after r238475
​https://bugs.webkit.org/show_bug.cgi?id=194415
<rdar://problem/47550281>

Reviewed by Tim Horton.

Source/WebKit:

Fix the bug by not firing the Apple-pencil-exclusive tap gesture recognizer in the case where editable images
are disabled. This gesture recognizer is only used for inserting editable images, and currently conflicts with
the synthetic click gesture recognizer used to recognize clicks from generic digitizer inputs.

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView gestureRecognizerShouldBegin:]): (-[WKContentView _stylusSingleTapRecognized:]):

LayoutTests:

Add a layout test to verify that a stylus tap dispatches clicks.

• fast/events/touch/ios/pencil-tap-dispatches-click-expected.txt: Added.
• fast/events/touch/ios/pencil-tap-dispatches-click.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241378] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241170. rdar://problem/47858241

REGRESSION(r239887): Crash under IDBConnectionToClient::didDeleteDatabase(WebCore::IDBResultData const&)
​https://bugs.webkit.org/show_bug.cgi?id=194402
<rdar://problem/47858241>

Reviewed by Geoffrey Garen.

r239887 removed a reference cycle of IDBConnectionToClient so that IDBConnectionToClient would no longer be
around forever. Therefore, ServerOpenRequest should keep a reference to IDBConnectionToClient to make sure it
is valid during access.

• Modules/indexeddb/server/ServerOpenDBRequest.cpp: (WebCore::IDBServer::ServerOpenDBRequest::maybeNotifyRequestBlocked): (WebCore::IDBServer::ServerOpenDBRequest::notifyDidDeleteDatabase):
• Modules/indexeddb/server/ServerOpenDBRequest.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241377] by bshafiei@apple.com

• 11 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241150. rdar://problem/45991585

Overflow element scrollbar is light for dark mode content.
​https://bugs.webkit.org/show_bug.cgi?id=194407
rdar://problem/45991585

Reviewed by Beth Dakin.

Source/WebCore:

Tested by css-dark-mode/supported-color-schemes-scrollbar.html.

• page/ChromeClient.h: (WebCore::FrameView::preferredScrollbarOverlayStyle): Return WTF::nullopt by default to avoid short-circuiting auto detection in recalculateScrollbarOverlayStyle() for clients, like WK1, that do not implement preferredScrollbarOverlayStyle().
• page/FrameView.cpp: (WebCore::FrameView::recalculateScrollbarOverlayStyle): Use WTF::nullopt in the false case to auto detect overlay style when page() is null.
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::useDarkAppearance const): Added.
• rendering/RenderLayer.h:
• testing/Internals.cpp: (WebCore::Internals::scrollbarOverlayStyle const): Added Node argument. (WebCore::Internals::scrollbarUsingDarkAppearance const): Added.
• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Updated tests to look at overflow elements and if dark apearance
is used by the scrollbar directly.

• css-dark-mode/supported-color-schemes-scrollbar-expected.txt:
• css-dark-mode/supported-color-schemes-scrollbar.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241376] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241143. rdar://problem/47820615

Permit additional IOKit Properties needed by Media PlugIns on older Mac Hardware
​https://bugs.webkit.org/show_bug.cgi?id=194412
<rdar://problem/47820615>

Reviewed by Per Arne Vollan.

• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241375] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241142. rdar://problem/47820620

Permit additional IOKit Properties needed by older Mac Hardware
​https://bugs.webkit.org/show_bug.cgi?id=194410
<rdar://problem/47820620>

Reviewed by Per Arne Vollan.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241374] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241140. rdar://problem/47889777

Fix more doesGC() for CheckTraps, GetMapBucket, and Switch nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

CheckTraps:

We normally will not emit this node because Options::usePollingTraps() is
false by default. However, as it is implemented now, CheckTraps can GC
because it can allocate a TerminatedExecutionException. If we make the
TerminatedExecutionException a singleton allocated at initialization time,
doesGC() can return false for CheckTraps.
​https://bugs.webkit.org/show_bug.cgi?id=194323

GetMapBucket:

Can call operationJSMapFindBucket() or operationJSSetFindBucket(),
which calls HashMapImpl::findBucket(), which calls jsMapHash(), which
can resolve a rope.

Switch:

If switchData kind is SwitchChar, can call operationResolveRope() .
If switchData kind is SwitchString and the child use kind is not StringIdentUse,

can call operationSwitchString() which resolves ropes.

DirectTailCall:
ForceOSRExit:
Return:
TailCallForwardVarargs:
TailCallVarargs:
Throw:

These are terminal nodes. It shouldn't really matter what doesGC() returns
for them, but following our conservative practice, unless we have a good
reason for doesGC() to return false, we should just return true.

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241373] by bshafiei@apple.com

• 5 edits
  2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241137. rdar://problem/47259025

Unable to sign in leetcode.
​https://bugs.webkit.org/show_bug.cgi?id=194366
rdar://problem/47259025.

Reviewed by Chris Dumez.

Source/WebCore:

In case a signal is passed as part of a FetchRequestInit,
the IDL binding code is throwing an exception in case signal is not an AbortSignal object.
This breaks an AbortSignal shim used in some web sites.
Relaxed the IDL binding rule by marking signal as any and doing the conversion in FetchRequest.

Test: http/wpt/fetch/request-abort.html
Also covered by manually signing in to leetcode.

• Modules/fetch/FetchRequest.cpp: (WebCore::FetchRequest::initializeWith):
• Modules/fetch/FetchRequestInit.h: (WebCore::FetchRequestInit::hasMembers const):
• Modules/fetch/FetchRequestInit.idl:

LayoutTests:

• http/wpt/fetch/request-abort-expected.txt: Added.
• http/wpt/fetch/request-abort.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241372] by bshafiei@apple.com

• 17 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241130. rdar://problem/47801392

HTMLMediaElement registers wrong ScriptExecutionContext with its ActiveDOMObject parent class
​https://bugs.webkit.org/show_bug.cgi?id=194360

HTMLMediaElement registers the Document used to create it with ActiveDOMObject, when it should
really use that Document's contextDocument(). Rather than just fix this in HTMLMediaElement,
make sure that the correct document is used everywhere by adding a new ActiveDOMObject constructor
taking a Document&, and making an explicitly deleted Document* constructor to catch any new cases.

Reviewed by Geoffrey Garen.

• Modules/applepay/ApplePaySession.cpp: (WebCore::ApplePaySession::ApplePaySession):
• Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::MediaRecorder):
• Modules/mediastream/MediaDevices.cpp: (WebCore::MediaDevices::MediaDevices):
• Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::UserMediaRequest):
• Modules/notifications/Notification.cpp: (WebCore::Notification::Notification):
• Modules/paymentrequest/PaymentRequest.cpp: (WebCore::PaymentRequest::PaymentRequest):
• Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
• animation/WebAnimation.cpp: (WebCore::WebAnimation::WebAnimation):
• css/FontFaceSet.cpp: (WebCore::FontFaceSet::FontFaceSet):
• dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject):
• dom/ActiveDOMObject.h:
• dom/Document.h: (WebCore::ActiveDOMObject::ActiveDOMObject):
• html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
• html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement):
• page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::IntersectionObserver):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241371] by bshafiei@apple.com

• 5 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241128. rdar://problem/46664625

[macOS] API test times out after r241026
​https://bugs.webkit.org/show_bug.cgi?id=194372

Reviewed by Alex Christensen.

The API test TestWebKitAPI.RenderingProgress.FirstMeaningfulPaint times out after r241026.
A new function pointer, layoutMilestones, is added to WKBundlePageLoaderClient, in order
for clients to decide which milestones they would like to listen for.

• WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: (layoutMilestones): (setUpPageLoaderClient):
• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::layoutMilestones const):
• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241370] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241124. rdar://problem/47466549

Shrink and hyphenate safe browsing warning text on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=194361
<rdar://problem/47466549>

Reviewed by Geoffrey Garen.

Some internationalizations use long words that didn't fit on small watches.

• UIProcess/Cocoa/WKSafeBrowsingWarning.mm: (fontOfSize): (-[WKSafeBrowsingWarning addContent]): (-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241369] by bshafiei@apple.com

• 6 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241121. rdar://problem/42023295

Infinite recursion via CachedResource::~CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=194378
<rdar://problem/42023295>

Reviewed by Daniel Bates.

I don't know the exact steps to trigger this but the mechanism seems clear.

1) An existing resource is removed from or replaced in CachedResourceLoader::m_documentResources map.
2) This decrements the handle count of resource and causes it be deleted.
3) CachedResource::~CachedResource calls m_owningCachedResourceLoader->removeCachedResource(*this). This only happens with

resources that are "owned" by CachedResourceLoader which is a rare special case (used by image document and if memory cache is disabled).

4) CachedResourceLoader::removeCachedResource looks up the resource from the map which causes a temporary CachedResourceHandle to be created.

This increments the handle count of the resource from 0 back to 1.

5) When the temporary dies, CachedResource::~CachedResource is called again and we cycle back to 3).

The fix here is simply to remove CachedResourceLoader::removeCachedResource call from ~CachedResource.
It is a leftover from when the map contained raw pointers instead of owning CachedResourceHandles.

Since m_documentResources map has a handle to the resource, the only way we are in the destructor is that the resource
has been removed from the map already (or is in process of being removed like in this crash). Any call that does anything
other than bail out is going to crash.

CachedResource::n_owningCachedResourceLoader member and CachedResourceLoader::removeCachedResource function only exist to
support this erranous call so they are removed as well.

• loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
• loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):

This is the substantive change. The rest just removes now-dead code.

• loader/cache/CachedResource.h: (WebCore::CachedResource::setOwningCachedResourceLoader): Deleted.
• loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::loadResource): (WebCore::CachedResourceLoader::garbageCollectDocumentResources): (WebCore::CachedResourceLoader::removeCachedResource): Deleted.
• loader/cache/CachedResourceLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241368] by bshafiei@apple.com

• 29 edits
  3 copies in branches/safari-608.1.5.1-branch

Cherry-pick r241105. rdar://problem/46733045

[Payment Request] It should be possible to require a phonetic name for shipping contacts
​https://bugs.webkit.org/show_bug.cgi?id=194311
<rdar://46733045>

Reviewed by Alex Christensen.

Source/WebCore:

It should be possible to require that a shipping contact has a phonetic name in Payment Request.
To accomplish this, move requiredShippingContactFields from ApplePayPaymentRequest to
ApplePayRequestBase so that it can be used as part of an Apple Pay payment method data.

Since required shipping contact fields can now be specified both in
requiredShippingContactFields and PaymentOptions, we merge the required fields from these
two sources such that, e.g., email is required if it is specified in either place.

So that clients can detect this new feature, the API version number is bumped from 5 to 6.

Added test cases to ApplePayRequestShippingContact.https.html and ApplePayRequestShippingContactV3.https.html.

• DerivedSources.make:
• Modules/applepay/ApplePayPaymentRequest.h:
• Modules/applepay/ApplePayPaymentRequest.idl:
• Modules/applepay/ApplePayRequestBase.cpp: (WebCore::convertAndValidate):
• Modules/applepay/ApplePayRequestBase.h:
• Modules/applepay/ApplePayRequestBase.idl:
• Modules/applepay/ApplePaySession.cpp: (WebCore::convertAndValidate):
• Modules/applepay/PaymentCoordinatorClient.cpp: Added. (WebCore::PaymentCoordinatorClient::supportsVersion):
• Modules/applepay/PaymentCoordinatorClient.h:
• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: (WebCore::mergePaymentOptions): (WebCore::ApplePayPaymentHandler::show):
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:
• testing/MockPaymentContactFields.h: Added. (WebCore::MockPaymentContactFields::MockPaymentContactFields):
• testing/MockPaymentContactFields.idl: Added.
• testing/MockPaymentCoordinator.cpp: (WebCore::MockPaymentCoordinator::showPaymentUI): (WebCore::MockPaymentCoordinator::supportsVersion): Deleted.
• testing/MockPaymentCoordinator.h:
• testing/MockPaymentCoordinator.idl:

Source/WebKit:

• WebProcess/ApplePay/WebPaymentCoordinator.cpp: (WebKit::WebPaymentCoordinator::supportsVersion): Deleted.
• WebProcess/ApplePay/WebPaymentCoordinator.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebPaymentCoordinatorClient.h:
• WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::supportsVersion): Deleted.

LayoutTests:

• http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt:
• http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:
• http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https-expected.txt:
• http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html:
• http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
• http/tests/ssl/applepay/PaymentRequest.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241367] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241026. rdar://problem/46664625

Roll out parts of r238819 since it is a PLT performance regression.
​https://bugs.webkit.org/show_bug.cgi?id=194346

Unreviewed performance fix.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: (didStartProvisionalLoadForFrame): (didReceiveServerRedirectForProvisionalLoadForFrame): (didFinishLoadForFrame): (globalObjectIsAvailableForFrame): (didRemoveFrameFromHierarchy): (didCommitLoadForFrame): (didFinishDocumentLoadForFrame): (didFailProvisionalLoadWithErrorForFrame): (didFailLoadWithErrorForFrame): (didSameDocumentNavigationForFrame): (didLayoutForFrame): (didReachLayoutMilestone): (didFirstVisuallyNonEmptyLayoutForFrame): (didHandleOnloadEventsForFrame): (userAgentForURL): (setUpPageLoaderClient): (willSendRequestForFrame): (didInitiateLoadForResource): (didFinishLoadForResource): (didFailLoadForResource): (setUpResourceLoadClient): (-[WKWebProcessPlugInBrowserContextController setLoadDelegate:]): (ResourceLoadClient::ResourceLoadClient): Deleted. (ResourceLoadClient::loadDelegate const): Deleted. (ResourceLoadClient::pluginContextController const): Deleted. (PageLoaderClient::PageLoaderClient): Deleted. (PageLoaderClient::loadDelegate const): Deleted. (PageLoaderClient::pluginContextController const): Deleted. (PageLoaderClient::didStartProvisionalLoadForFrame): Deleted. (PageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted. (PageLoaderClient::didFinishLoadForFrame): Deleted. (PageLoaderClient::globalObjectIsAvailableForFrame): Deleted. (PageLoaderClient::didRemoveFrameFromHierarchy): Deleted. (PageLoaderClient::didCommitLoadForFrame): Deleted. (PageLoaderClient::didFinishDocumentLoadForFrame): Deleted. (PageLoaderClient::didFailProvisionalLoadWithErrorForFrame): Deleted. (PageLoaderClient::didFailLoadWithErrorForFrame): Deleted. (PageLoaderClient::didSameDocumentNavigationForFrame): Deleted. (PageLoaderClient::didLayoutForFrame): Deleted. (PageLoaderClient::didReachLayoutMilestone): Deleted. (PageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame): Deleted. (PageLoaderClient::layoutMilestones const): Deleted. (PageLoaderClient::didHandleOnloadEventsForFrame): Deleted. (PageLoaderClient::userAgentForURL const): Deleted. (ResourceLoadClient::willSendRequestForFrame): Deleted. (ResourceLoadClient::didInitiateLoadForResource): Deleted. (ResourceLoadClient::didFinishLoadForResource): Deleted. (ResourceLoadClient::didFailLoadForResource): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241366] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241022. rdar://problem/47833940

CoreAudioCaptureSource should not configure its audio unit until it starts producing data
​https://bugs.webkit.org/show_bug.cgi?id=194310

Reviewed by Eric Carlson.

Delay the configuration of the audio unit until the source is instructed to start producing data.
This allows the UIProcess to not start changing the audio unit when
checking for constraints during getUserMedia call before the prompt.
Covered by manual testing.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::initializeToStartProducingData): (WebCore::CoreAudioCaptureSource::startProducingData):
• platform/mediastream/mac/CoreAudioCaptureSource.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241365] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241021. rdar://problem/45354090

Disable audio ducking at Audio Unit setup time
​https://bugs.webkit.org/show_bug.cgi?id=194303

Reviewed by Eric Carlson.

When creating a CoreAudioCaptureSource, the audio unit might be
reconfigured if a past audio capture was done.
This might trigger audio ducking which is undone in startInternal.
In some cases, startInternal will never call start.
In that case, the audio unit will continue ducking the other processing.
To ensure ducking is disabled, unduck in setupAudioUnit as well as startInternal.

In addition to that, once a shared unit is created, it stays alive until the UIProcess exits.
This might affect all applications.
Instead, whenever the shared unit is stopped, clean it so as to restore the state as if no capture ever happened.
This has noticeable effects in the quality of audio being played on bluetooth devices.

Covered by manual tests.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioSharedUnit::setupAudioUnit): (WebCore::CoreAudioSharedUnit::unduck): (WebCore::CoreAudioSharedUnit::startInternal): (WebCore::CoreAudioSharedUnit::captureFailed): (WebCore::CoreAudioSharedUnit::stopProducingData):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241364] by bshafiei@apple.com

• 3 edits
  3 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241018. rdar://problem/47822929

RELEASE_ASSERT(!m_document.isResolvingTreeStyle()) in com.apple.WebKit.WebContent at WebCore: WebCore::StyleResolver::~StyleResolver
​https://bugs.webkit.org/show_bug.cgi?id=194333
<rdar://problem/47822929>

Reviewed by Zalan Bujtas.

Source/WebCore:

Content extensions may mutate the extension stylesheet in the middle of a style resolution as a result of
the legacy animation code triggering a resource load.

Test: http/tests/contentextensions/css-display-none-keyframe.html

• style/StyleScope.cpp: (WebCore::Style::Scope::scheduleUpdate):

Avoid clearing the style resolver if we are in the middle of a style resolution.
A better fix that avoid doing this in the first place is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=194335.

LayoutTests:

• http/tests/contentextensions/css-display-none-keyframe-expected.txt: Added.
• http/tests/contentextensions/css-display-none-keyframe.html: Added.
• http/tests/contentextensions/css-display-none-keyframe.html.json: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241363] by bshafiei@apple.com

• 6 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241011. rdar://problem/47827420

Web Inspector: Styles: PropertiesChanged shouldn't fire when old and new text are both empty
​https://bugs.webkit.org/show_bug.cgi?id=194318

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Previously, WI.CSSStyleDeclaration.Event.PropertiesChanged fired when
old text and new text were empty strings.

• UserInterface/Models/CSSStyleDeclaration.js:

LayoutTests:

Fix the flaky test on Debug.

• inspector/css/modify-css-property-race-expected.txt:
• inspector/css/modify-css-property-race.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241362] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r241003. rdar://problem/47829275

Web Inspector: Elements tab: selection is broken after deleting the selected node
​https://bugs.webkit.org/show_bug.cgi?id=194300
<rdar://problem/47829275>

Reviewed by Devin Rousso.

Deleting a TreeElement can cause an IndexSet including indexes
outside the deleted range to be passed to SelectionController,
corrupting the internal selection state.

• UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype._indexesForSubtree.numberOfElementsInSubtree): Added. (WI.TreeOutline.prototype._indexesForSubtree): Finding the last (rightmost leaf) TreeElement in the subtree used TreeElement.prototype.traverseNextElement to do a depth first traversal. This method did not stay within the subtree rooted at treeElement.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241361] by bshafiei@apple.com

• 4 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r240998. rdar://problem/47832956

Fix DFG's doesGC() for a few more nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194307
<rdar://problem/47832956>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

NumberToStringWithValidRadixConstant:

Calls operationInt32ToStringWithValidRadix(), which calls int32ToString(),
which can allocate a string.
Calls operationInt52ToStringWithValidRadix(), which calls int52ToString(),
which can allocate a string.
Calls operationDoubleToStringWithValidRadix(), which calls numberToString(),
which can allocate a string.

RegExpExecNonGlobalOrSticky: calls createRegExpMatchesArray() which allocates

memory for all kinds of objects.

RegExpMatchFast: calls operationRegExpMatchFastString(), which calls

RegExpObject::execInline() and RegExpObject::matchGlobal(). Both of
these allocates memory for the match result.

RegExpMatchFastGlobal: calls operationRegExpMatchFastGlobalString(), which

calls RegExpObject's collectMatches(), which allocates an array amongst
other objects.

StringFromCharCode:

If the uint32 code to convert is greater than maxSingleCharacterString,
we'll call operationStringFromCharCode(), which calls jsSingleCharacterString(),
which allocates a new string if the code is greater than maxSingleCharacterString.

Also fix SpeculativeJIT::compileFromCharCode() and FTL's compileStringFromCharCode()
to use maxSingleCharacterString instead of a literal constant.

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
• dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileFromCharCode):
• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241360] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240997. rdar://problem/47805023

Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
​https://bugs.webkit.org/show_bug.cgi?id=194254
<rdar://problem/47805023>

Reviewed by Devin Rousso.

• UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype.selectionControllerSelectionDidChange): TreeOutline should always call the TreeElement select and deselect methods while processing selection changes. Having notifications suppressed by this._suppressNextSelectionDidChangeEvent should only affect the dispatching of TreeOutline events.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241359] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r240995. rdar://problem/47719379

Reproducible crash under WKShareSheet presentWithParameters when cancelling a share
​https://bugs.webkit.org/show_bug.cgi?id=194301
<rdar://problem/47719379>

Reviewed by Beth Dakin.

• UIProcess/Cocoa/WKShareSheet.mm: (-[WKShareSheet presentWithParameters:completionHandler:]): NSSharingServicePicker's delegate callbacks can be called synchronously. We release the WKShareSheet (which holds our reference to the NSSharingServicePicker) under sharingServicePicker:didChooseSharingService:. On older versions of macOS, there was nothing keeping the NSSharingServicePicker alive inside showRelativeToRect:ofView:preferredEdge:, thus the whole chain of references would fall and result in sending a message to a released NSSharingServicePicker. To resolve this, keep an extra reference to the WKShareSheet until presentation is complete.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241358] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r240991. rdar://problem/47827589

Move DFG nodes that clobberize() says will write(Heap) to the doesGC() list that returns true.
​https://bugs.webkit.org/show_bug.cgi?id=194298
<rdar://problem/47827555>

Reviewed by Saam Barati.

We do this for 3 reasons:

1. It's clearer when reading doesGC()'s code that these nodes will return true.
2. If things change in the future where clobberize() no longer reports these nodes as write(Heap), each node should be vetted first to make sure that it can never GC before being moved back to the doesGC() list that returns false.
3. This reduces the list of nodes that we need to audit to make sure doesGC() is correct in its claims about the nodes' GCing possibility.

The list of nodes moved are:

ArrayPush
ArrayPop
Call
CallEval
CallForwardVarargs
CallVarargs
Construct
ConstructForwardVarargs
ConstructVarargs
DefineDataProperty
DefineAccessorProperty
DeleteById
DeleteByVal
DirectCall
DirectConstruct
DirectTailCallInlinedCaller
GetById
GetByIdDirect
GetByIdDirectFlush
GetByIdFlush
GetByIdWithThis
GetByValWithThis
GetDirectPname
GetDynamicVar
HasGenericProperty
HasOwnProperty
HasStructureProperty
InById
InByVal
InstanceOf
InstanceOfCustom
LoadVarargs
NumberToStringWithRadix
PutById
PutByIdDirect
PutByIdFlush
PutByIdWithThis
PutByOffset
PutByValWithThis
PutDynamicVar
PutGetterById
PutGetterByVal
PutGetterSetterById
PutSetterById
PutSetterByVal
PutStack
PutToArguments
RegExpExec
RegExpTest
ResolveScope
ResolveScopeForHoistingFuncDeclInEval
TailCall
TailCallForwardVarargsInlinedCaller
TailCallInlinedCaller
TailCallVarargsInlinedCaller
ToNumber
ToPrimitive
ValueNegate

• dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241357] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.5.1-branch/LayoutTests

Cherry-pick r240989. rdar://problem/47827420

Web Inspector: Fix modify-css-property-race.html test failures
​https://bugs.webkit.org/show_bug.cgi?id=194282

Reviewed by Matt Baker.

Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
so it doesn't log the actual values.

• inspector/css/modify-css-property-race-expected.txt:
• inspector/css/modify-css-property-race.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241356] by bshafiei@apple.com

• 16 edits in branches/safari-608.1.5.1-branch

Cherry-pick r240983. rdar://problem/47756320

Unreviewed, rolling out r240742.

Causes crashes on iOS simulator.

Reverted changeset:

"[iOS] Keyups for non-modifier keys identified as "Dead" when
not focused in a content-editable element"
​https://bugs.webkit.org/show_bug.cgi?id=192824
​https://trac.webkit.org/changeset/240742

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241355] by bshafiei@apple.com

• 3 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240952. rdar://problem/47559021

Web Inspector: Resources: missing resource data for document on reload
​https://bugs.webkit.org/show_bug.cgi?id=194243
<rdar://problem/47559021>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ResourceDetailsSidebarPanel.js: (WI.ResourceDetailsSidebarPanel.prototype.set resource): (WI.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):

• UserInterface/Base/Object.js: (WI.Object.removeEventListener): Drive-by: there's no need to iterate over the entire table to check if thisObject exists, as that is handled for us by ListMultimap, which we later call anyways.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241354] by bshafiei@apple.com

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240947. rdar://problem/47743864

Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
​https://bugs.webkit.org/show_bug.cgi?id=194169
<rdar://problem/47743864>

Reviewed by Devin Rousso.

• UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype._handleMouseDown): Add a special case for a single-selection TreeOutline with allowsRepeatSelection enabled. Since the element is already selected, bypass the SelectionCongroller and dispatch an event with event.data.selectedByUser set to true.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241353] by bshafiei@apple.com

• 8 edits
  2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r240946. rdar://problem/47827420

Web Inspector: Styles: fix race conditions when editing
​https://bugs.webkit.org/show_bug.cgi?id=192739
<rdar://problem/46752925>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Editing CSS property in the style editor syncronously updates CSSStyleDeclaration on the front-end
and asyncronously updates the backend by calling CSSAgent.setStyleText. After the new style text is applied
on the backend, CSSStyleDeclaration (on the front-end) gets updated.

Unsure there's no race conditions by introducing _updatesInProgressCount:

• Increment it before calling CSSAgent.setStyleText.
• Decrement it after CSSAgent.setStyleText is finished.

Prevent updates of CSSStyleDeclaration when _updatesInProgressCount isn't 0.

• UserInterface/Models/CSSProperty.js: (WI.CSSProperty.prototype._updateOwnerStyleText):
• UserInterface/Models/CSSStyleDeclaration.js: (WI.CSSStyleDeclaration): (WI.CSSStyleDeclaration.prototype.set text): Removed. (WI.CSSStyleDeclaration.prototype.setText): Added. Change the setter to a method since it has side effects including an asynchronous backend call.

• UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.prototype.changeStyleText):

• UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.get nameTextField): Removed. (WI.SpreadsheetStyleProperty.prototype.get valueTextField): Removed. Drive-by: remove unused code.

LayoutTests:

• inspector/css/modify-css-property-expected.txt:
• inspector/css/modify-css-property-race-expected.txt: Added.
• inspector/css/modify-css-property-race.html: Added.
• inspector/css/modify-css-property.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 AM Changeset in webkit [241352] by rniwa@webkit.org

• 4 edits in trunk/Source

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

• loader/PolicyChecker.cpp:

(WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

12:41 AM Changeset in webkit [241351] by benjamin@webkit.org

• 6 edits in trunk/Source/WebKit

Responsiveness timers are too expensive for frequent events
​https://bugs.webkit.org/show_bug.cgi?id=194003

Reviewed by Geoffrey Garen.

With each event, we set a responsivness timer to check if the WebProcess
is responsive, and reset the timer when the WebProcess sends an answer.

For frequent events (e.g. wheel events, mouse force events, etc),
we are spamming the kernel with hundreds of timers per second.
That is a bit inefficient.

Another source of inefficiency comes from the timer implementation
itself. Stopping a RunLoop::Timer removes the timer from every mode
and invalidate the timer. It becomes costly since we do it a lot.

With this patch, I tweak ResponsivenessTimer and its use to minimize
how often we schedule system timers.

The first change is to not stop the timer when we get the stop()
calls if we expect more events to come in. Instead, we keep track
if we care about the timeout or not in the attribute "m_waitingForTimer".
When the next event starts, we can reschedule the timer without ever
having told the kernel about the stop.
If there are no next events, the timeout fires but m_waitingForTimer
is false. To avoid idle wake up, the lazy stop is only used when having
following events is common.

The second improvements comes from not even rescheduling the timer
when restarted. Instead of changing the timer, we let the original timer
fire and re-shedule a new one with the missing time.

For more context, also see patches r240759 and r240944.

• UIProcess/ResponsivenessTimer.cpp:

(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::invalidate):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(WebKit::ResponsivenessTimer::startWithLazyStop):
(WebKit::ResponsivenessTimer::stop):
(WebKit::ResponsivenessTimer::processTerminated):
(WebKit::ResponsivenessTimer::~ResponsivenessTimer): Deleted.

• UIProcess/ResponsivenessTimer.h:

(WebKit::ResponsivenessTimer::hasActiveTimer const):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::isResponsiveWithLazyStop):

• UIProcess/WebProcessProxy.h:

12:26 AM Changeset in webkit [241350] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r241273.
​https://bugs.webkit.org/show_bug.cgi?id=194579

This change is causing a flaky assertion failure crash in High
Sierra Debug (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Stop using setDefersLoading from WebCore"
​https://bugs.webkit.org/show_bug.cgi?id=194315
​https://trac.webkit.org/changeset/241273