Timeline

Feb 27, 2019:

11:28 PM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

10:54 PM Changeset in webkit [242194] by Joseph Pecoraro

• 11 edits in trunk/Source/WebInspectorUI

Web Inspector: Add a new Scanner TimelineMarker to show up when mousing over TimelineView graphs
​https://bugs.webkit.org/show_bug.cgi?id=195079

Reviewed by Devin Rousso.

• UserInterface/Base/Utilities.js:

(Note.prototype.enclosingNodeOrSelfWithClassInArray):
Helper for a set of classes.

• UserInterface/Models/TimelineMarker.js:

Add a new marker type, "Scanner".

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.initialLayout):
(WI.CPUTimelineView.prototype._graphPositionForMouseEvent):
(WI.CPUTimelineView.prototype._handleGraphMouseMove):

• UserInterface/Views/MemoryTimelineView.js:

(WI.MemoryTimelineView):
(WI.MemoryTimelineView.prototype._graphPositionForMouseEvent):
(WI.MemoryTimelineView.prototype._handleGraphMouseMove):
Update a scanner time when mousing over various graphs that span the entire time range.
These use the containing graph element because there was a single pixel between
adjacent graphs which would cause the scanner to flicker because the mouse event target
was not an svg element.

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype.hidden):
(WI.TimelineOverview.prototype.updateScannerTime):
(WI.TimelineOverview.prototype.clearScanner):

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._handleTimelineViewScannerTimeDidChange):
(WI.TimelineRecordingContentView.prototype._handleTimelineViewScannerDidClear):
Update the overview's ruler with scanner changes.

• UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .markers > .marker.scanner):

• UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler):
(WI.TimelineRuler.prototype.clearMarkers):
(WI.TimelineRuler.prototype.updateScannerTime):
(WI.TimelineRuler.prototype.clearScanner):
(WI.TimelineRuler.prototype._updateMarkers):
Have a special scanner marker that updates.

• UserInterface/Views/TimelineView.js:

New events that a TimelineView can dispatch to update the overview.

• UserInterface/Views/Variables.css:

(:root):
(@media (prefers-color-scheme: dark)):
Scanner marker colors.

10:44 PM Changeset in webkit [242193] by mark.lam@apple.com

• 3 edits
  1 add in trunk

The parser is failing to record the token location of new in new.target.
​https://bugs.webkit.org/show_bug.cgi?id=195127
<rdar://problem/39645578>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/parser-should-record-token-location-of-new-dot-target.js: Added.

Source/JavaScriptCore:

Also adjust the token location for the following to be as shown:

new.target

^super

import.meta

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

10:25 PM Changeset in webkit [242192] by ysuzuki@apple.com

• 15 edits
  2 adds in trunk

[JSC] mustHandleValues for dead bytecode locals should be ignored in DFG phases
​https://bugs.webkit.org/show_bug.cgi?id=195144
<rdar://problem/47595961>

Reviewed by Mark Lam.

JSTests:

• stress/read-dead-bytecode-locals-in-must-handle-values1.js: Added.

(bar):
(foo):

• stress/read-dead-bytecode-locals-in-must-handle-values2.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

DFGMaximalFlushInsertionPhase inserts Flush for all the locals at the end of basic blocks. This enlarges the live ranges of
locals in DFG, and it sometimes makes DFG value live while it is dead in bytecode. The issue happens when we use mustHandleValues
to widen AbstractValue in CFAPhase. At that time, DFG tells "this value is live in DFG", but it may be dead in the bytecode level.
At that time, we attempt to merge AbstractValue with dead mustHandleValue, which is cleared as jsUndefined() in
DFG::Plan::cleanMustHandleValuesIfNecessary before start compilation, and crash because jsUndefined() may be irrelevant to the FlushFormat
in VariableAccessData.

This patch makes the type of mustHandleValues Operands<Optional<JSValue>>. We clear dead JSValues in DFG::Plan::cleanMustHandleValuesIfNecessary.
And we skip handling dead mustHandleValue in DFG phases.

• bytecode/Operands.h:

(JSC::Operands::isLocal const):
(JSC::Operands::isVariable const): Deleted.

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::injectOSR):

• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):
(JSC::DFG::compile):

• dfg/DFGDriver.h:
• dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

• dfg/DFGJITCode.h:
• dfg/DFGOperations.cpp:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::cleanMustHandleValuesIfNecessary):

• dfg/DFGPlan.h:

(JSC::DFG::Plan::mustHandleValues const):

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):

• ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

• jit/JITOperations.cpp:

9:27 PM Changeset in webkit [242191] by Simon Fraser

• 3 edits in trunk/LayoutTests

fast/scrolling/ios/hit-testing-iframe-002.html always fails
​https://bugs.webkit.org/show_bug.cgi?id=195108

Reviewed by Frédéric Wang.

Errant ; in this.style.background='green;'

• fast/scrolling/ios/hit-testing-iframe-002.html:
• platform/ios-wk2/TestExpectations:

8:39 PM Changeset in webkit [242190] by Alan Bujtas

• 5 edits
  1 move
  1 delete in trunk/Source/WebCore

[ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChangeObserver class.
​https://bugs.webkit.org/show_bug.cgi?id=195128
<rdar://problem/48456752>

Reviewed by Simon Fraser.

Move the final bits over to ContentChangeObserver and delete WKContentObservationInternal.h.

• WebCore.xcodeproj/project.pbxproj:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::setObservedContentChange):

• platform/ios/wak/WKContentObservation.cpp:

(WKSetObservedContentChange):

• platform/ios/wak/WKContentObservation.h:
• platform/ios/wak/WKContentObservationInternal.h: Removed.

8:35 PM Changeset in webkit [242189] by Simon Fraser

• 27 edits in trunk/Source

Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::lastModified const):

• html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

• mathml/MathMLElement.cpp:

(WebCore::convertToPercentageIfNeeded):
(WebCore::MathMLElement::collectStyleForPresentationAttribute):

• page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::ResourceUsageOverlay::platformDraw):

• page/linux/ResourceUsageOverlayLinux.cpp:

(WebCore::cpuUsageString):
(WebCore::gcTimerString):

• platform/DateComponents.cpp:

(WebCore::DateComponents::toStringForTime const):
(WebCore::DateComponents::toString const):

• platform/LocalizedStrings.cpp:

(WebCore::localizedString):

• platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::drawText):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::formatMediaControlsTime const):

Source/WebKit:

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticator::getAssertion):

Source/WebKitLegacy/win:

• FullscreenVideoController.cpp:

(timeToString):

Source/WTF:

• wtf/Assertions.cpp:

(WTF::createWithFormatAndArguments): Deleted.

• wtf/HexNumber.h:

(WTF::StringTypeAdapter<HexNumberBuffer>::toString const):

• wtf/text/StringConcatenate.h:

(WTF::makeString):
(WTF::pad): Deleted.
(WTF::StringTypeAdapter<PaddingSpecification<UnderlyingAdapterType>>::StringTypeAdapter): Deleted.
(WTF::StringTypeAdapter<PaddingSpecification<UnderlyingAdapterType>>::length const): Deleted.
(WTF::StringTypeAdapter<PaddingSpecification<UnderlyingAdapterType>>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<PaddingSpecification<UnderlyingAdapterType>>::writeTo const): Deleted.

• wtf/text/StringConcatenateNumbers.h:

(WTF::FormattedNumber::fixedPrecision):
(WTF::FormattedNumber::fixedWidth):
(WTF::StringTypeAdapter<FormattedNumber>::toString const):

• wtf/text/StringOperators.h:

(WTF::StringAppend::StringAppend):

• wtf/text/StringView.h:

(WTF::StringView::invalidate):

• wtf/text/WTFString.cpp:

(WTF::createWithFormatAndArguments):
(WTF::String::format):

• wtf/text/WTFString.h:

7:42 PM Changeset in webkit [242188] by youenn@apple.com

• 2 edits in trunk/Tools

Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
​https://bugs.webkit.org/show_bug.cgi?id=194959

Reviewed by Chris Dumez.

Spin loop until getting the condition to remove flakiness.

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

6:37 PM Changeset in webkit [242187] by Michael Catanzaro

• 2 edits in trunk/Source/WebKit

Unreviewed, fix -Wformat warning

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):

6:22 PM Changeset in webkit [242186] by aboya@igalia.com

• 2 edits
  4 adds
  4 deletes in trunk/LayoutTests

Unreviewed GTK test gardening
​https://bugs.webkit.org/show_bug.cgi?id=195138

• platform/gtk/TestExpectations:
• platform/gtk/compositing/visibility/root-visibility-toggle-expected.txt: Added.
• platform/gtk/editing/deleting/smart-delete-001-expected.txt: Removed.
• platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
• platform/gtk/editing/deleting/smart-delete-003-expected.txt: Removed.
• platform/gtk/editing/deleting/smart-delete-004-expected.txt: Removed.
• platform/gtk/fast/css/apple-system-colors-expected.txt: Added.
• platform/gtk/fast/text/ja-sans-serif-expected.png: Added.
• platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: Added.

5:47 PM Changeset in webkit [242185] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-build] Buildbot should include builder_display_name in the build events
​https://bugs.webkit.org/show_bug.cgi?id=195045

Reviewed by Dewei Zhu.

• BuildSlaveSupport/ews-build/events.py:

(Events.buildStarted): Included builder_display_name in event data. Also renamed
buildername to builder_name to be consistent in naming style.
(Events.buildFinished): Ditto.

4:58 PM Changeset in webkit [242184] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[ContentChangeObserver] Move _WKObservingContentChanges from global to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195091
<rdar://problem/48427271>

Reviewed by Tim Horton.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingContentChanges):
(WebCore::ContentChangeObserver::stopObservingContentChanges):
(WebCore::ContentChangeObserver::isObservingContentChanges):

• platform/ios/wak/WKContentObservation.cpp:

(WKObservingContentChanges): Deleted.
(WKStartObservingContentChanges): Deleted.
(WKStopObservingContentChanges): Deleted.

• platform/ios/wak/WKContentObservation.h:
• platform/ios/wak/WKContentObservationInternal.h:

4:57 PM Changeset in webkit [242183] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

REGRESSION: Crash beneath ResourceLoadObserver::logSubresourceLoading
​https://bugs.webkit.org/show_bug.cgi?id=195072

Reviewed by Ryosuke Niwa.

ResourceLoadObserver and WebProcess should exist as long as the web page (process) is running. However,
the NetworkProcess connection can close for a variety of reasons. If the ResourceLoadObserver observes
a load or user gesture in the WebProcess, we should attempt to reconnect to the NetworkProcess (if it
was disconnected), just like we do for other message send cases.

This patch switches from using the m_networkProcessConnection member (which might be null) to use the
'ensureNetworkProcessConnection' accessor which ensures we have a valid connection for message sends.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

4:54 PM Changeset in webkit [242182] by Chris Dumez

• 15 edits in trunk

Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
​https://bugs.webkit.org/show_bug.cgi?id=194480

Reviewed by Brady Eidson.

Source/WebKit:

The StorageManager would only start listening for IPC on a given connection when
StorageManager::processWillOpenConnection() is called. This gets called from
WebsiteDataStore::webProcessWillOpenConnection() which gets called from
WebProcessLifetimeTracker::webPageEnteringWebProcess().

webPageEnteringWebProcess() was called in WebPageProxy::finishAttachingToWebProcess()
after process-swapping. This means that IPC comming from the *provisional* process
would not get processed and we would only start processing IPC on the provisional
process's connection when it would get committed.

To address the issue, this patch teaches WebProcessLifetimeTracker that a page can
now have several processes. We also make sure that webPageEnteringWebProcess() gets
called for the provisional process as soon as we create the provisional page, instead
of waiting for it to get committed.

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::~ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::connectionWillOpen):

• UIProcess/ProvisionalPageProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::webProcessWillShutDown):
(WebKit::WebPageProxy::processDidTerminate):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::webProcessLifetimeTracker):

• UIProcess/WebProcessLifetimeObserver.cpp:

(WebKit::WebProcessLifetimeObserver::addWebPage):
(WebKit::WebProcessLifetimeObserver::removeWebPage):

• UIProcess/WebProcessLifetimeObserver.h:
• UIProcess/WebProcessLifetimeTracker.cpp:

(WebKit::WebProcessLifetimeTracker::addObserver):
(WebKit::WebProcessLifetimeTracker::webPageEnteringWebProcess):
(WebKit::WebProcessLifetimeTracker::webPageLeavingWebProcess):
(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
(WebKit::WebProcessLifetimeTracker::processIsRunning):

• UIProcess/WebProcessLifetimeTracker.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):

• UIProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):
(WebKit::StorageManager::SessionStorageNamespace::addAllowedConnection):
(WebKit::StorageManager::SessionStorageNamespace::removeAllowedConnection):
(WebKit::StorageManager::addAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::removeAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::SessionStorageNamespace::allowedConnection const): Deleted.
(WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection): Deleted.
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection): Deleted.

• UIProcess/WebStorage/StorageManager.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::webPageWillOpenConnection):
(WebKit::WebsiteDataStore::webPageDidCloseConnection):

Tools:

Update existing API test to make it more likely to reproduce the issue.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

4:50 PM Changeset in webkit [242181] by beidson@apple.com

• 6 edits in trunk

Universal links from Google search results pages don't open the app.
<rdar://problem/46887179> and ​https://bugs.webkit.org/show_bug.cgi?id=195126

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by new API tests.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::shouldOpenExternalURLsPolicyToPropagate const): Propagate the external URL policy from

an iframe if it is from the same security origin as the main frame.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
• TestWebKitAPI/cocoa/TestNavigationDelegate.h:
• TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

4:47 PM Changeset in webkit [242180] by Chris Dumez

• 2 edits in trunk/Tools

Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
​https://bugs.webkit.org/show_bug.cgi?id=195102

Reviewed by Geoffrey Garen.

If the number of processes is not yet what we expect, wait a bit and check again to give
processes some time to exit.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

4:43 PM Changeset in webkit [242179] by Chris Dumez

• 2 edits in trunk/Tools

Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
​https://bugs.webkit.org/show_bug.cgi?id=194545

Reviewed by Brady Eidson.

Make sure the test navigates forward and then back only once. Previously, navigating
back would trigger a navigation again in a timer.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

4:19 PM Changeset in webkit [242178] by Kocsen Chung

• 1 copy in tags/Safari-607.1.40.1.1

Tag Safari-607.1.40.1.1.

4:13 PM Changeset in webkit [242177] by Kocsen Chung

• 1 copy in tags/Safari-607.1.40.0.1

Tag Safari-607.1.40.0.1.

4:08 PM Changeset in webkit [242176] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[ContentChangeObserver] Move DOMTimer schedule handling from global to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195090
<rdar://problem/48426771>

Reviewed by Tim Horton.

Also remove some unused functions from WKContentObservationInternal.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingDOMTimerScheduling):
(WebCore::ContentChangeObserver::stopObservingDOMTimerScheduling):
(WebCore::ContentChangeObserver::isObservingDOMTimerScheduling):

• platform/ios/wak/WKContentObservation.cpp:

(WKStartObservingDOMTimerScheduling): Deleted.
(WKStopObservingDOMTimerScheduling): Deleted.
(WKIsObservingDOMTimerScheduling): Deleted.

• platform/ios/wak/WKContentObservation.h:
• platform/ios/wak/WKContentObservationInternal.h:

4:02 PM Changeset in webkit [242175] by Alan Coon

• 12 edits in branches/safari-607.1.40.1-branch

Apply patch. rdar://problem/48429602

3:54 PM Changeset in webkit [242174] by Devin Rousso

• 18 edits in trunk/Source/WebInspectorUI

Web Inspector: Use Element.closest for internal code
​https://bugs.webkit.org/show_bug.cgi?id=173747

Reviewed by Joseph Pecoraro.

Replace usage of added utility functions on the Node prototype with the built-in
Element.prototype.closest as it's more flexible and is capable of doing the same thing.

• UserInterface/Base/Utilities.js:

(Node.prototype.enclosingNodeOrSelfWithClass): Deleted.
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): Deleted.
(Node.prototype.enclosingNodeOrSelfWithNodeName): Deleted.

• UserInterface/Base/Main.js:

(WI.handlePossibleLinkClick):
(WI._focusedContentBrowser):

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype._graphPositionForMouseEvent):

• UserInterface/Views/CompletionSuggestionsView.js:

(WI.CompletionSuggestionsView.prototype.set selectedIndex):
(WI.CompletionSuggestionsView.prototype.update):
(WI.CompletionSuggestionsView.prototype._itemClicked):

• UserInterface/Views/ConsoleGroup.js:

(WI.ConsoleGroup.prototype._titleClicked):

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype._mouseWasClicked):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._startEditingTarget):
(WI.DOMTreeElement.prototype._populateTagContextMenu):

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.populateContextMenu):

• UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype._startEditing):
(WI.DataGrid.prototype._editingCancelled):
(WI.DataGrid.prototype.dataGridNodeFromNode):
(WI.DataGrid.prototype.dataGridNodeFromPoint):
(WI.DataGrid.prototype._headerCellClicked):
(WI.DataGrid.prototype._mouseoverColumnCollapser):
(WI.DataGrid.prototype._mouseoutColumnCollapser):
(WI.DataGrid.prototype._clickInColumnCollapser):
(WI.DataGrid.prototype._contextMenuInHeader):
(WI.DataGrid.prototype._contextMenuInDataTable):

• UserInterface/Views/DataGridNode.js:

(WI.DataGridNode.prototype.isEventWithinDisclosureTriangle):

• UserInterface/Views/LegacyTabBar.js:

(WI.LegacyTabBar.prototype._handleMouseDown):
(WI.LegacyTabBar.prototype._handleClick):

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._handleContextMenuEvent):
(WI.LogContentView.prototype._mousedown):
(WI.LogContentView.prototype._targetInMessageCanBeSelected):
(WI.LogContentView.prototype._mousemove):
(WI.LogContentView.prototype._mouseup):
(WI.LogContentView.prototype._ondragstart):

• UserInterface/Views/NavigationBar.js:

(WI.NavigationBar.prototype._mouseDown):
(WI.NavigationBar.prototype._mouseMoved):

• UserInterface/Views/Popover.js:

(WI.Popover.prototype.handleEvent):

• UserInterface/Views/TabBar.js:

(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleClick):

• UserInterface/Views/Table.js:

(WI.Table.prototype._handleMouseDown):
(WI.Table.prototype._handleContextMenu):

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.treeElementFromNode):

3:54 PM Changeset in webkit [242173] by Wenson Hsieh

• 4 edits
  2 adds in trunk

[iOS] Web pages shouldn't be able to present a keyboard after the web view resigns first responder
​https://bugs.webkit.org/show_bug.cgi?id=195118
<rdar://problem/43411940>

Reviewed by Tim Horton.

Source/WebKit:

It's currently possible for websites to redirect focus into an editable element on the page by programmatically
requesting focus within the "blur" event handler. This is because our current heuristics:

(1) Allow programmatic focus to show the keyboard when an element is already focused; this is meant to handle

the case where the page moves focus between different elements on the page.

(2) And also allow programmatic focus to show the keyboard when changing activity state; this is meant to handle

the case where a focused element should show the keyboard when first responder is restored on a web view
(e.g. in the case where a modal view controller is dismissed, and the web view regains first responder once
again).

In both of these scenarios, we actually only want the keyboard to appear if the web view itself is either
becoming the first responder, or is already the first responder. Importantly, when blurring the focused element
by calling -[WKWebViewe resignFirstResponder] (as is the case when dismissing the keyboard by tapping 'Done' or
focusing other platform UI), we don't want to allow the page to show the keyboard due to element focus.

To fix this issue, we enforce that we're either becoming the first responder or already are the first responder
before showing the keyboard due to activity state change or focused element change.

Test: fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView textInputTraits]):

Quick drive-by tweak: rename _isBlurringFocusedNode to _isBlurringFocusedElement, to match the rest of the
terminology used in WebKit.

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

Make our heuristics for determining whether to show the keyboard a tiny bit easier to follow, by moving the
logic into a lambda function and using early returns. See above for more details.

(-[WKContentView _elementDidBlur]):
(-[WKContentView focusedFormControllerDidUpdateSuggestions:]):

LayoutTests:

Add a test to verify that after resigning first responder (e.g. tapping 'Done' on the keyboard, or focusing a
native input field elsewhere in the app), the page cannot force the keyboard to appear by focusing an input
field.

• fast/events/ios/do-not-show-keyboard-when-focusing-after-blur-expected.txt: Added.
• fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html: Added.

3:52 PM Changeset in webkit [242172] by Alan Coon

• 4 edits in branches/safari-607.1.40.1-branch

Cherry-pick r242089. rdar://problem/48445620

WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
​https://bugs.webkit.org/show_bug.cgi?id=195028
<rdar://problem/48243733>

Reviewed by Eric Carlson.

Source/WebKit:

Covered by API test.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resetState):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:45 PM Changeset in webkit [242171] by Kocsen Chung

• 3 edits in tags/Safari-607.1.39.0.1/Source/WebKit

Cherry-pick r242098. rdar://problem/48400927

[iOS] REGRESSION(r238490?): Safari sometimes shows blank page until a cross site navigation or re-opening the tab
​https://bugs.webkit.org/show_bug.cgi?id=195037
<rdar://problem/48154508>

Reviewed by Antti Koivisto.

Restore the pre-r238490 behavior of WebPage::didCompletePageTransition clearing LayerTreeFreezeReason::ProcessSuspended
as this has been an issue when I was able to reproduce the issue locally.

Also added release logging to help diagnose the issue in the future.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::freezeLayerTree): (WebKit::WebPage::unfreezeLayerTree): (WebKit::WebPage::didCompletePageTransition):
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::freezeAllLayerTrees): (WebKit::WebProcess::unfreezeAllLayerTrees):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:43 PM Changeset in webkit [242170] by Kocsen Chung

• 7 edits in tags/Safari-607.1.39.0.1/Source

Versioning.

3:31 PM Changeset in webkit [242169] by Alan Coon

• 1 copy in tags/Safari-607.1.39.0.1

New tag.

3:30 PM Changeset in webkit [242168] by Alan Coon

• 1 delete in tags/Safari-607.1.39.0

Delete tag.

3:29 PM Changeset in webkit [242167] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[ContentChangeObserver] Move style recalc handling from global to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195087

Reviewed by Simon Fraser.

Add m_observingNextStyleRecalc/m_observingStyleRecalcScheduling to ContentChangeObserver and move the related code over from WK functions.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingStyleRecalcScheduling):
(WebCore::ContentChangeObserver::stopObservingStyleRecalcScheduling):
(WebCore::ContentChangeObserver::isObservingStyleRecalcScheduling):
(WebCore::ContentChangeObserver::setShouldObserveNextStyleRecalc):
(WebCore::ContentChangeObserver::shouldObserveNextStyleRecalc):
(WebCore::ContentChangeObserver::setObservedContentChange):

• platform/ios/wak/WKContentObservation.cpp:

(WKSetObservedContentChange):
(WKStartObservingStyleRecalcScheduling): Deleted.
(WKStopObservingStyleRecalcScheduling): Deleted.
(WKIsObservingStyleRecalcScheduling): Deleted.
(WKSetShouldObserveNextStyleRecalc): Deleted.
(WKShouldObserveNextStyleRecalc): Deleted.

• platform/ios/wak/WKContentObservation.h:

3:20 PM Changeset in webkit [242166] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[ContentChangeObserver] Move DOM timer handling from global to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195070
<rdar://problem/48417650>

Reviewed by Tim Horton.

Add DOM timer list to ContentChangeObserver and move the related code over from WK functions.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingDOMTimerScheduling):
(WebCore::ContentChangeObserver::countOfObservedDOMTimers):
(WebCore::ContentChangeObserver::clearObservedDOMTimers):
(WebCore::ContentChangeObserver::setObservedContentChange):
(WebCore::ContentChangeObserver::containsObservedDOMTimer):
(WebCore::ContentChangeObserver::addObservedDOMTimer):
(WebCore::ContentChangeObserver::removeObservedDOMTimer):

• platform/ios/wak/WKContentObservation.cpp:

(WKStartObservingDOMTimerScheduling):
(WKSetObservedContentChange):
(WebThreadGetObservedDOMTimers): Deleted.
(WebThreadCountOfObservedDOMTimers): Deleted.
(WebThreadClearObservedDOMTimers): Deleted.
(WebThreadContainsObservedDOMTimer): Deleted.
(WebThreadAddObservedDOMTimer): Deleted.
(WebThreadRemoveObservedDOMTimer): Deleted.

• platform/ios/wak/WKContentObservation.h:

3:11 PM Changeset in webkit [242165] by Alan Coon

• 7 edits in tags/Safari-607.1.39.0/Source

Versioning.

3:09 PM Changeset in webkit [242164] by Justin Fan

• 8 edits in trunk/Source/WebCore

Fix build errors after Web GPU buffer updates changed some IDL fields from unsigned long to unsigned long long.

Unreviewed build fix.

• Modules/webgpu/WebGPUBuffer.cpp:

(WebCore::WebGPUBuffer::setSubData):

• Modules/webgpu/WebGPUBuffer.h:
• Modules/webgpu/WebGPUBufferBinding.h:
• Modules/webgpu/WebGPURenderPassEncoder.idl:
• platform/graphics/gpu/GPUBufferBinding.h:
• platform/graphics/gpu/GPUVertexAttributeDescriptor.h:
• platform/graphics/gpu/GPUVertexInputDescriptor.h:

2:59 PM Changeset in webkit [242163] by Adrian Perez de Castro

• 14 edits in releases/WebKitGTK/webkit-2.24

Merged r242055 - [WPE] Bump WPEBackend-fdo requirement to API version 1.0
​https://bugs.webkit.org/show_bug.cgi?id=195001

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/FindWPEBackend-fdo.cmake: Use WPEBackend-fdo-1.0.
• Source/cmake/OptionsWPE.cmake: Ditto.

Source/WebKit:

API version 1.0 always includes the functionality previously guarded with
WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
unconditionally.

• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::View): Remove usage of WPE_BACKEND_CHECK_VERSION().
(WKWPE::m_backend): Ditto.

• UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:

(WPEQtViewBackend::WPEQtViewBackend): Use libWPEBackend-fdo-1.0 as
library name, remove call to wpe_fdo_initialize_for_egl_display().
(WPEQtViewBackend::create): Call wpe_fdo_initialize_for_egl_display()
here, to bail out early in case initialization fails.

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess): Remove usage of
WPE_BACKEND_CHECK_VERSION().

Tools:

API version 1.0 always includes the functionality previously guarded with
WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
unconditionally.

• TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().

• TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:

(WebViewTest::showInWindow): Ditto.
(WebViewTest::hideView): Ditto.

• wpe/backends/HeadlessViewBackend.cpp:

(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.

• wpe/backends/ViewBackend.cpp:

(WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.

• wpe/backends/WindowViewBackend.cpp:

(WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
WPE_BACKEND_CHECK_VERSION().

• wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.

2:57 PM Changeset in webkit [242162] by Alan Coon

• 1 copy in tags/Safari-607.1.39.0

New tag.

2:24 PM Changeset in webkit [242161] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r242118): Debugger: event breakpoints have no icon
​https://bugs.webkit.org/show_bug.cgi?id=195119

Reviewed by Matt Baker.

• UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):

1:51 PM Changeset in webkit [242160] by Alan Coon

• 7 edits in branches/safari-607.1.40.2-branch/Source

Versioning.

1:49 PM Changeset in webkit [242159] by Alan Coon

• 7 edits in branches/safari-607.1.40.1-branch/Source

Versioning.

1:46 PM Changeset in webkit [242158] by Alan Coon

• 7 edits in branches/safari-607.1.40.0-branch/Source

Versioning.

1:42 PM Changeset in webkit [242157] by Alan Coon

• 7 edits in branches/safari-607-branch/Source

Versioning.

1:37 PM Changeset in webkit [242156] by Ryan Haddad

• 8 edits in trunk/Tools

High Sierra Debug JSC test queue should use faster hardware
​https://bugs.webkit.org/show_bug.cgi?id=194603

Rubber-stamped by Alexey Proskuryakov.

Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
• QueueStatusServer/config/queues.py:
• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(test_ews_name):

1:34 PM Changeset in webkit [242155] by wilander@apple.com

• 41 edits in trunk

Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
​https://bugs.webkit.org/show_bug.cgi?id=195071
<rdar://problem/48417690>

Reviewed by Alex Christensen and Brent Fulgham.

Source/WebCore:

No new tests. This patch maintains functionality covered by plenty of layout
tests under http/tests/resourceLoadStatistics/ and http/tests/storageAccess.

This patch adopts WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics
and makes the necessary infrastructure changes to support that.

The previous HashCountedSets in WebCore::ResourceLoadStatistics are now just
HashSets since we never used the counts for anything. This change simplified
encoding and decoding for IPC and will eventually simplify encoding and
decoding in loader/ResourceLoadStatistics.cpp when we obsolete statistics
model version 14 and below.

The patch also makes WebCore::RegistrableDomain's String constructor private.
A new create function WebCore::RegistrableDomain::uncheckedCreateFromString()
is introduced to better signal to users that creating a registrable domain
object with a string may create an object that doesn't match a registrable
domain in a valid HTTP-family URL. This change (private String constructor)
motivated a change in WebCore::AdClickAttribution where the Source and
Destination structs now take a URL as parameter instead of a String.

Finally, this patch harmonizes parameter and variable naming, going from
"origin" to "domain" and "mainFrame" to "topFrame."

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAdClickAttribution const):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaSessionTitle const):

• loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Source::Source):
(WebCore::AdClickAttribution::Source::deletedValue):
(WebCore::AdClickAttribution::Destination::Destination):
(WebCore::AdClickAttribution::Destination::deletedValue):
(WebCore::AdClickAttribution::decode):

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::statisticsForURL):
(WebCore::ResourceLoadObserver::statisticsForOrigin): Deleted.

• loader/ResourceLoadObserver.h:
• loader/ResourceLoadStatistics.cpp:

(WebCore::encodeHashSet):
(WebCore::ResourceLoadStatistics::encode const):
(WebCore::decodeHashCountedSet):
(WebCore::decodeHashSet):
(WebCore::ResourceLoadStatistics::decode):
(WebCore::appendHashSet):
(WebCore::ResourceLoadStatistics::toString const):
(WebCore::ResourceLoadStatistics::merge):
(WebCore::encodeHashCountedSet): Deleted.
(WebCore::encodeOriginHashSet): Deleted.
(WebCore::decodeOriginHashSet): Deleted.
(WebCore::appendHashCountedSet): Deleted.

• loader/ResourceLoadStatistics.h:
• platform/RegistrableDomain.h:

(WebCore::RegistrableDomain::uncheckedCreateFromString):
(WebCore::RegistrableDomain::RegistrableDomain):

• testing/Internals.cpp:

(WebCore::Internals::resourceLoadStatisticsForURL):
(WebCore::Internals::resourceLoadStatisticsForOrigin): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

This patch adopts WebCore::RegistrableDomain in WebKit::NetworkProcessProxy
and makes the necessary infrastructure changes to support that.

The previous HashCountedSets in WebCore::ResourceLoadStatistics are now just
HashSets since we never used the counts for anything. This change simplified
the IPC::ArgumentCoder<ResourceLoadStatistics> encode and decode functions.

The patch also makes WebCore::RegistrableDomain's String constructor private.
A new create function WebCore::RegistrableDomain::uncheckedCreateFromString()
is introduced to better signal to users that creating a registrable domain
object with a string may create an object that doesn't match a registrable
domain in a valid HTTP-family URL.

Finally, this patch harmonizes parameter and variable naming, going from
"origin" to "domain" and "mainFrame" to "topFrame."

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::removeDataRecords):
(WebKit::ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain const):
(WebKit::ResourceLoadStatisticsMemoryStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsMemoryStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsMemoryStore::logSubresourceLoading):
(WebKit::ResourceLoadStatisticsMemoryStore::logSubresourceRedirect):
(WebKit::ResourceLoadStatisticsMemoryStore::isRegisteredAsSubresourceUnder const):
(WebKit::ResourceLoadStatisticsMemoryStore::isRegisteredAsSubFrameUnder const):
(WebKit::ResourceLoadStatisticsMemoryStore::isRegisteredAsRedirectingTo const):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubframeUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUnderTopFrameDomain):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsMemoryStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsMemoryStore::setTopFrameUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsMemoryStore::createEncoderFromData const):
(WebKit::ResourceLoadStatisticsMemoryStore::hasUserGrantedStorageAccessThroughPrompt):
(WebKit::ResourceLoadStatisticsMemoryStore::hasHadUnexpiredRecentUserInteraction const):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubframeUnderTopFrameOrigin): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUnderTopFrameOrigin): Deleted.

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessGranted):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameDomain):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebResourceLoadStatisticsStore::deleteWebsiteDataForRegistrableDomainsInAllPersistentDataStores):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin): Deleted.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin): Deleted.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::sortedPrevalentResourceTelemetry):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setSubframeUnderTopFrameDomain):
(WebKit::NetworkProcess::setSubresourceUnderTopFrameDomain):
(WebKit::filterForRegistrableDomains):
(WebKit::NetworkProcess::deleteWebsiteDataForRegistrableDomainsInAllPersistentDataStores):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::setSubframeUnderTopFrameOrigin): Deleted.
(WebKit::NetworkProcess::setSubresourceUnderTopFrameOrigin): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::deleteWebsiteDataForRegistrableDomainsInAllPersistentDataStores):

• NetworkProcess/NetworkSession.h:
• Platform/classifier/ResourceLoadStatisticsClassifier.cpp:

(WebKit::ResourceLoadStatisticsClassifier::calculateResourcePrevalence):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ResourceLoadStatistics>::encode):
(IPC::ArgumentCoder<ResourceLoadStatistics>::decode):

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):

• UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm:

(WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updatePrevalentDomainsToBlockCookiesFor):
(WebKit::NetworkProcessProxy::isPrevalentResource):
(WebKit::NetworkProcessProxy::isVeryPrevalentResource):
(WebKit::NetworkProcessProxy::setPrevalentResource):
(WebKit::NetworkProcessProxy::setPrevalentResourceForDebugMode):
(WebKit::NetworkProcessProxy::setVeryPrevalentResource):
(WebKit::NetworkProcessProxy::setLastSeen):
(WebKit::NetworkProcessProxy::clearPrevalentResource):
(WebKit::NetworkProcessProxy::logUserInteraction):
(WebKit::NetworkProcessProxy::hasHadUserInteraction):
(WebKit::NetworkProcessProxy::clearUserInteraction):
(WebKit::NetworkProcessProxy::setSubframeUnderTopFrameDomain):
(WebKit::NetworkProcessProxy::isRegisteredAsRedirectingTo):
(WebKit::NetworkProcessProxy::isRegisteredAsSubFrameUnder):
(WebKit::NetworkProcessProxy::setSubresourceUnderTopFrameDomain):
(WebKit::NetworkProcessProxy::isRegisteredAsSubresourceUnder):
(WebKit::NetworkProcessProxy::setSubresourceUniqueRedirectTo):
(WebKit::NetworkProcessProxy::setSubresourceUniqueRedirectFrom):
(WebKit::NetworkProcessProxy::setTopFrameUniqueRedirectTo):
(WebKit::NetworkProcessProxy::setTopFrameUniqueRedirectFrom):
(WebKit::NetworkProcessProxy::isGrandfathered):
(WebKit::NetworkProcessProxy::setGrandfathered):
(WebKit::NetworkProcessProxy::hasStorageAccessForFrame):
(WebKit::NetworkProcessProxy::hasStorageAccess):
(WebKit::NetworkProcessProxy::requestStorageAccess):
(WebKit::NetworkProcessProxy::requestStorageAccessConfirm):
(WebKit::NetworkProcessProxy::grantStorageAccess):
(WebKit::NetworkProcessProxy::setSubframeUnderTopFrameOrigin): Deleted.
(WebKit::NetworkProcessProxy::setSubresourceUnderTopFrameOrigin): Deleted.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestStorageAccessConfirm):

• UIProcess/WebPageProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::hasStorageAccess):
(WebKit::WebsiteDataStore::requestStorageAccess):
(WebKit::WebsiteDataStore::grantStorageAccess):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameOrigin): Deleted.
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameOrigin): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasStorageAccess):
(WebKit::WebPage::requestStorageAccess):

Tools:

• TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:

(TestWebKitAPI::createURL):

Convenience function.

(TestWebKitAPI::TEST):

WebCore::AdClickAttribution now takes a URL when creating Source and
Destination.

• TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:

(TestWebKitAPI::TEST):

WebCore::AdClickAttribution now takes a URL when creating Source and
Destination.

LayoutTests:

• http/tests/navigation/resources/redirect-updates-history-item-done-statistics.html:

Changed from window.internals.resourceLoadStatisticsForOrigin() to
window.internals.resourceLoadStatisticsForURL() and now submit a URL.

1:29 PM Changeset in webkit [242154] by Alan Coon

• 7 edits in branches/safari-607-branch/Source

Versioning.

1:28 PM Changeset in webkit [242153] by Keith Rollin

• 2 edits in trunk/Source/WebKit

Fix Xcode project UUIDs for TextCheckerCompletion.cpp and TextCheckerCompletion.h
​https://bugs.webkit.org/show_bug.cgi?id=195109
<rdar://problem/48442272>

Reviewed by Alexey Proskuryakov.

In r144436, TextCheckerCompletion.cpp and TextCheckerCompletion.h were
added to WebKit2.xcodeproj with invalid UUIDs (they included Q's and
Z's in hexadecimal strings). While these UUIDs haven't caused any
problems in practice over the last six years, they are indeed invalid,
and were discovered via an Xcode-project processing tool that did not
anticipate their format. Fix this by removing the files from the
project and re-adding them.

• WebKit.xcodeproj/project.pbxproj:

1:26 PM Changeset in webkit [242152] by Alan Coon

• 1 copy in branches/safari-607.1.40.2-branch

New branch.

1:24 PM Changeset in webkit [242151] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: unreadable text in bezier curve editor numeric input fields
​https://bugs.webkit.org/show_bug.cgi?id=195018
<rdar://problem/48378541>

Reviewed by Matt Baker.

Simplify some styles using -webkit-* properties instead of [dir=ltr]/[dir=rtl] selectors.

• UserInterface/Views/BezierEditor.css:

(.bezier-editor):
(.bezier-editor > .bezier-preview):
(.bezier-editor > .bezier-preview-timing):
(.bezier-editor > .bezier-container .linear-curve):
(.bezier-editor > .bezier-container .bezier-curve):
(.bezier-editor > .bezier-container .control-line):
(.bezier-editor > .bezier-container .control-handle):
(.bezier-editor > .number-input-container):
(.bezier-editor > .number-input-container > input):
(body[dir=ltr] .bezier-editor > .bezier-preview-timing): Deleted.
(body[dir=rtl] .bezier-editor > .bezier-preview-timing): Deleted.
(body[dir=ltr] .bezier-editor > .number-input-container > input): Deleted.
(body[dir=rtl] .bezier-editor > .number-input-container > input): Deleted.
(@media (prefers-color-scheme: dark)): Deleted.
Remove all custom styling on any <input>s, as they look fine with their default styling.

• UserInterface/Views/SpringEditor.css:

(.spring-editor > .spring-preview):
(.spring-editor > .spring-preview > div):
(.spring-editor > .spring-timing > div):

1:23 PM Changeset in webkit [242150] by Alan Coon

• 7 edits in branches/safari-607-branch/Source

Versioning.

1:14 PM Changeset in webkit [242149] by Alan Coon

• 1 copy in branches/safari-607.1.40.1-branch

New branch.

1:10 PM Changeset in webkit [242148] by Justin Fan

• 33 edits
  1 copy
  4 adds in trunk

[Web GPU] Buffer updates part 2: setSubData, GPU/CPU synchronization
​https://bugs.webkit.org/show_bug.cgi?id=195077
<rdar://problem/47805229>

Reviewed by Dean Jackson.

Source/WebCore:

Implement GPUBuffer.setSubData and prevent the resolving of mapping promises if the buffer is scheduled to be
used on the GPU, and add handlers to resolve such promises after command buffer execution completes. In addition,
update buffer sizes to u64 (unsigned long in C++) as per the updated Web GPU API.

Tests: webgpu/buffer-command-buffer-races.html

webgpu/map-read-buffers.html

• Modules/webgpu/WebGPUBindGroup.h:

(WebCore::WebGPUBindGroup::bindGroup const):

• Modules/webgpu/WebGPUBindGroupDescriptor.cpp:

(WebCore::WebGPUBindGroupDescriptor::asGPUBindGroupDescriptor const): Rename binding -> bufferBinding to reduce confusion.

• Modules/webgpu/WebGPUBuffer.cpp: Small tweaks.

(WebCore::WebGPUBuffer::setSubData):
(WebCore::WebGPUBuffer::unmap): Correctly fail if buffer is destroyed.
(WebCore::WebGPUBuffer::destroy):
(WebCore::WebGPUBuffer::rejectOrRegisterPromiseCallback):

• Modules/webgpu/WebGPUBuffer.h:

(WebCore::WebGPUBuffer::buffer const): Returned buffer is no longer const so that it can be used in completed handler callbacks.

• Modules/webgpu/WebGPUBuffer.idl: Enable setSubData.
• Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::beginRenderPass):

• Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:

(WebCore::WebGPUProgrammablePassEncoder::setBindGroup const):

• Modules/webgpu/WebGPUProgrammablePassEncoder.h:
• Modules/webgpu/WebGPURenderPassEncoder.cpp:

(WebCore::WebGPURenderPassEncoder::setVertexBuffers):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/gpu/GPUBuffer.h:

(WebCore::GPUBuffer::isTransferDst const): Added various state and flag getters.
(WebCore::GPUBuffer::isVertex const):
(WebCore::GPUBuffer::isUniform const):
(WebCore::GPUBuffer::isStorage const):
(WebCore::GPUBuffer::isReadOnly const):
(WebCore::GPUBuffer::isMappable const):
(WebCore::GPUBuffer::isMapWrite const):
(WebCore::GPUBuffer::isMapRead const):
(WebCore::GPUBuffer::isMapWriteable const):
(WebCore::GPUBuffer::isMapReadable const):

• platform/graphics/gpu/GPUBufferBinding.h:
• platform/graphics/gpu/GPUCommandBuffer.h:

(WebCore::GPUCommandBuffer::usedBuffers const):
(WebCore::GPUCommandBuffer::useBuffer):

• platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::tryCreateBuffer): Pass Ref of itself for Buffer to request the Queue later, if needed.
(WebCore::GPUDevice::tryCreateBuffer const): Deleted.

• platform/graphics/gpu/GPUDevice.h:
• platform/graphics/gpu/GPUProgrammablePassEncoder.cpp: Retain the encoder's commandBuffer to reference its used resource buffers.

(WebCore::GPUProgrammablePassEncoder::GPUProgrammablePassEncoder):

• platform/graphics/gpu/GPUProgrammablePassEncoder.h:

(WebCore::GPUProgrammablePassEncoder::commandBuffer const):

• platform/graphics/gpu/GPURenderPassEncoder.h:
• platform/graphics/gpu/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::validateBufferCreate): Move validation out of tryCreate.
(WebCore::GPUBuffer::tryCreate): Create both shared and private buffers, depending on usage.
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::~GPUBuffer): Call destroy instead of just unmap.
(WebCore::GPUBuffer::state const):
(WebCore::GPUBuffer::setSubData): Uses a cached collection of staging MTLBuffers to encode data copies to the implementation MTLBuffer.
(WebCore::GPUBuffer::commandBufferCommitted): Register on the GPUBuffer that the provided MTLCommandBuffer uses it, and is about to be committed.
(WebCore::GPUBuffer::commandBufferCompleted): MTLCommandBuffer's onCompletedHandler calls this.
(WebCore::GPUBuffer::reuseSubDataBuffer): SetSubData's blit command buffers call this to return a staging buffer to the pool.
(WebCore::GPUBuffer::registerMappingCallback):
(WebCore::GPUBuffer::runMappingCallback):
(WebCore::GPUBuffer::unmap):
(WebCore::GPUBuffer::destroy):
(WebCore::GPUBuffer::tryCreateSharedBuffer): Deleted.

• platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm:

(WebCore::GPUProgrammablePassEncoder::setResourceAsBufferOnEncoder):
(WebCore::GPUProgrammablePassEncoder::setBindGroup):

• platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::submit): Ensure submitted buffers are in the correct state, and add completed handlers for synchronization.

• platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:

(WebCore::GPURenderPassEncoder::tryCreate):
(WebCore::GPURenderPassEncoder::GPURenderPassEncoder): Retain the commandBuffer for later reference.
(WebCore::GPURenderPassEncoder::setVertexBuffers): Mark vertex buffers as used before submission.
(WebCore::GPURenderPassEncoder::create): Deleted.

Buffer size updates in the IDL:

• Modules/webgpu/GPUBufferDescriptor.idl:
• Modules/webgpu/WebGPUBuffer.idl:
• Modules/webgpu/WebGPUBufferBinding.idl:
• Modules/webgpu/WebGPUCommandBuffer.idl:
• Modules/webgpu/WebGPURenderPassEncoder.idl:
• Modules/webgpu/WebGPUVertexAttributeDescriptor.idl:
• Modules/webgpu/WebGPUVertexInputDescriptor.idl:

LayoutTests:

Add tests for mapReadAysnc and setSubData calls. Nofity testRunner when done on some drawing tests
that may take more time.

• webgpu/buffer-command-buffer-races-expected.html: Added.
• webgpu/buffer-command-buffer-races.html: Added.
• webgpu/buffer-resource-triangles.html: Use setSubData.
• webgpu/depth-enabled-triangle-strip.html: Ditto.
• webgpu/map-read-buffers-expected.txt: Added.
• webgpu/map-read-buffers.html: Added.
• webgpu/vertex-buffer-triangle-strip.html: Use setSubData.

1:05 PM Changeset in webkit [242147] by Alan Coon

• 7 edits in branches/safari-607-branch/Source

Versioning.

12:59 PM Changeset in webkit [242146] by Alan Coon

• 1 copy in branches/safari-607.1.40.0-branch

New branch.

12:14 PM Changeset in webkit [242145] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Remove LeetCode FetchRequest quirk
​https://bugs.webkit.org/show_bug.cgi?id=195100

Reviewed by Alex Christensen.

Covered by manual testing.

• Modules/fetch/FetchRequest.cpp:

(WebCore::needsSignalQuirk):

12:13 PM Changeset in webkit [242144] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: popover colors don't change when transitioning to/from dark mode
​https://bugs.webkit.org/show_bug.cgi?id=195113
<rdar://problem/48444188>

Reviewed by Timothy Hatcher.

• UserInterface/Views/Popover.js:

(WI.Popover.prototype.dismiss):
(WI.Popover.prototype._addListenersIfNeeded):

12:11 PM Changeset in webkit [242143] by bshafiei@apple.com

• 12 edits in branches/safari-607-branch

Apply patch. rdar://problem/48429676

11:53 AM Changeset in webkit [242142] by youenn@apple.com

• 14 edits in trunk/Source/WebKit

Remove UserMediaProcessManager processState map
​https://bugs.webkit.org/show_bug.cgi?id=195056

Reviewed by Eric Carlson.

Before the patch, the WebProcessProxy->ProcessState map was storing the list of manager proxies and process state.
To improve on this model, this patch does the following:

• Move the process state to WebProcessProxy.
• Remove the map and replace it by a set of all manager proxies.

This simplifies the handling.
On WebProcess side, instead of storing the sandbox extensions in each WebPage, we handle them in WebProcess directly.
This mirrors what is being done in UIProcess and reduces the risk of inconsistencies between the two, the risk being that capture would fail.

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::forEach):
(WebKit::UserMediaPermissionRequestManagerProxy::UserMediaPermissionRequestManagerProxy):
(WebKit::UserMediaPermissionRequestManagerProxy::~UserMediaPermissionRequestManagerProxy):
(WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::muteCaptureMediaStreamsExceptIn):
(WebKit::UserMediaProcessManager::willCreateMediaStream):
(WebKit::UserMediaProcessManager::endedCaptureSession):
(WebKit::UserMediaProcessManager::setCaptureEnabled):
(WebKit::UserMediaProcessManager::captureDevicesChanged):
(WebKit::ProcessState::ProcessState): Deleted.
(WebKit::ProcessState::hasVideoExtension const): Deleted.
(WebKit::ProcessState::grantVideoExtension): Deleted.
(WebKit::ProcessState::revokeVideoExtension): Deleted.
(WebKit::ProcessState::hasAudioExtension const): Deleted.
(WebKit::ProcessState::grantAudioExtension): Deleted.
(WebKit::ProcessState::revokeAudioExtension): Deleted.
(WebKit::stateMap): Deleted.
(WebKit::processState): Deleted.
(WebKit::ProcessState::addRequestManager): Deleted.
(WebKit::ProcessState::removeRequestManager): Deleted.
(WebKit::UserMediaProcessManager::addUserMediaPermissionRequestManagerProxy): Deleted.
(WebKit::UserMediaProcessManager::removeUserMediaPermissionRequestManagerProxy): Deleted.
(WebKit::UserMediaProcessManager::startedCaptureSession): Deleted.

• UIProcess/UserMediaProcessManager.h:
• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::mediaCaptureSandboxExtensions const):
(WebKit::WebProcessProxy::hasVideoCaptureExtension const):
(WebKit::WebProcessProxy::grantVideoCaptureExtension):
(WebKit::WebProcessProxy::revokeVideoCaptureExtension):
(WebKit::WebProcessProxy::hasAudioCaptureExtension const):
(WebKit::WebProcessProxy::grantAudioCaptureExtension):
(WebKit::WebProcessProxy::revokeAudioCaptureExtension):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::~UserMediaPermissionRequestManager): Deleted.
(WebKit::UserMediaPermissionRequestManager::clear): Deleted.
(WebKit::UserMediaPermissionRequestManager::grantUserMediaDeviceSandboxExtensions): Deleted.
(WebKit::UserMediaPermissionRequestManager::revokeUserMediaDeviceSandboxExtensions): Deleted.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::grantUserMediaDeviceSandboxExtensions): Deleted.
(WebKit::WebPage::revokeUserMediaDeviceSandboxExtensions): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::grantUserMediaDeviceSandboxExtensions):
(WebKit::WebProcess::revokeUserMediaDeviceSandboxExtensions):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

11:47 AM Changeset in webkit [242141] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Disable permissive call logging in sandbox
​https://bugs.webkit.org/show_bug.cgi?id=194061
<rdar://problem/47686253>

Reviewed by Brent Fulgham.

Strict call filtering should be reenabled.

• WebProcess/com.apple.WebProcess.sb.in:

11:44 AM Changeset in webkit [242140] by Alan Coon

• 3 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r242138. rdar://problem/48444136

Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled
​https://bugs.webkit.org/show_bug.cgi?id=195101
<rdar://problem/48423023>

Reviewed by Geoffrey Garen.

Add site-specific quirk for chase.com on iOS where we fire a dummy DeviceMotionEvent if the page
tries to register a "devicemotion" event listener and fails because the API is disabled. This is
needed to unblock the site and proceed with the login flow.

Unfortunately, document()->settings().needsSiteSpecificQuirks() is false on iOS so I could not
guard the quirk behind this flag.

• page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::failedToRegisterDeviceMotionEventListener):
• page/DOMWindow.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [242139] by Chris Dumez

• 3 edits in trunk/Source/WebKit

[HTTPSUpgrade] Use open source database until the feature is ready
​https://bugs.webkit.org/show_bug.cgi?id=195069
<rdar://problem/47838224>

Reviewed by Geoffrey Garen.

• DerivedSources-input.xcfilelist:
• DerivedSources.make:

11:03 AM Changeset in webkit [242138] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled
​https://bugs.webkit.org/show_bug.cgi?id=195101
<rdar://problem/48423023>

Reviewed by Geoffrey Garen.

Add site-specific quirk for chase.com on iOS where we fire a dummy DeviceMotionEvent if the page
tries to register a "devicemotion" event listener and fails because the API is disabled. This is
needed to unblock the site and proceed with the login flow.

Unfortunately, document()->settings().needsSiteSpecificQuirks() is false on iOS so I could not
guard the quirk behind this flag.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::failedToRegisterDeviceMotionEventListener):

• page/DOMWindow.h:

11:02 AM Changeset in webkit [242137] by commit-queue@webkit.org

• 30 edits
  11 adds in trunk

Support Pointer Events on macOS
​https://bugs.webkit.org/show_bug.cgi?id=195008
<rdar://problem/47454419>

Patch by Antoine Quint <Antoine Quint> on 2019-02-27
Reviewed by Dean Jackson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

We now dispatch relevant pointer events as we prepare to dispatch mouse events. In most cases, this means we dispatch
a pointer event of the same type, with "mouse" being substituted by "pointer", and with the same properties with the
exception that if preventDefault() is called for a "pointerdown" event, the matching "mousedown" will not be dispatched,
and the same behavior also extends to "pointerup".

Tests: pointerevents/mouse/over-enter-out-leave.html

pointerevents/mouse/pointer-capture.html
pointerevents/mouse/pointer-event-basic-properties.html
pointerevents/mouse/pointer-events-before-mouse-events.html
pointerevents/mouse/pointerdown-prevent-default.html

• Configurations/FeatureDefines.xcconfig:
• dom/Document.cpp: All of the touch-action related members and functions should be iOS-specific since the touch-action

property does not have any effect on macOS.
(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::updateTouchActionElements):

• dom/Document.h:
• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent): Dispatch a pointer event matching the mouse event that is about to be dispatched.
If preventDefault() is called in the event handler for either "pointerdown" or "pointerup", do not proceed with dispatching
the mouse event.

• dom/PointerEvent.cpp:

(WebCore::pointerEventType):
(WebCore::PointerEvent::create):

• dom/PointerEvent.h:
• page/EventHandler.cpp: Check both the pointer and mouse events to see if we need to dispatch "enter" and "leave" events.

(WebCore::hierarchyHasCapturingEventListeners):
(WebCore::EventHandler::updateMouseEventTargetNode):

• page/PointerCaptureController.cpp: Fix a build error which only happened on macOS.

(WebCore::PointerCaptureController::PointerCaptureController): Create the CapturingData for the unique mouse pointer.
(WebCore::PointerCaptureController::hasPointerCapture): The code did not match the spec cited in the comment, only the
pending target override needs to be considered to determine whether a given element has pointer capture enabled.
(WebCore::PointerCaptureController::dispatchEvent): Dispatch the provided pointer event, accounting for pointer capture if
it is set.

• page/PointerLockController.cpp: Fix a build error which only happened on macOS.
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement): Code related to touch-action is only relevant to iOS.

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.

• Configurations/FeatureDefines.xcconfig:
• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences pointerEventsEnabled]):
(-[WebPreferences setPointerEventsEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• platform/mac-wk1/TestExpectations: Mark select tests as failures due to webkit.org/b/195008.
• platform/mac/TestExpectations: Enable the new mouse-based tests.
• pointerevents/mouse/over-enter-out-leave-expected.txt: Added.
• pointerevents/mouse/over-enter-out-leave.html: Added.
• pointerevents/mouse/pointer-capture-expected.txt: Added.
• pointerevents/mouse/pointer-capture.html: Added.
• pointerevents/mouse/pointer-event-basic-properties-expected.txt: Added.
• pointerevents/mouse/pointer-event-basic-properties.html: Added.
• pointerevents/mouse/pointer-events-before-mouse-events-expected.txt: Added.
• pointerevents/mouse/pointer-events-before-mouse-events.html: Added.
• pointerevents/mouse/pointerdown-prevent-default-expected.txt: Added.
• pointerevents/mouse/pointerdown-prevent-default.html: Added.
• pointerevents/utils.js:

(prototype.clear):

10:55 AM Changeset in webkit [242136] by sihui_liu@apple.com

• 11 edits in trunk/Source

Network Process is put to suspended when holding locked IndexedDB files
​https://bugs.webkit.org/show_bug.cgi?id=195024
<rdar://problem/45194169>

Reviewed by Geoffrey Garen.

Source/WebCore:

We found network process was suspended when IDBDatabase was being closed in the background database thread,
holding locks to its database file. To avoid starvation or deadlock, we need to keep network process alive by
taking background assertion in UI process until the closes are done and locks are released.

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::create):
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::closeDatabase):
(WebCore::IDBServer::IDBServer::didCloseDatabase):

• Modules/indexeddb/server/IDBServer.h:

(WebCore::IDBServer::IDBServer::create):

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didShutdownForClose):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::notifyServerAboutClose):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::notifyHoldingLockedFiles):

• NetworkProcess/NetworkProcess.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::setIsIDBDatabaseHoldingLockedFiles):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:

10:49 AM Changeset in webkit [242135] by bshafiei@apple.com

• 10 edits in branches/safari-607-branch/Source

Cherry-pick r242099. rdar://problem/48429675

[iOS] Regression(PSON) Scroll position is no longer restored when navigating back to reddit.com
​https://bugs.webkit.org/show_bug.cgi?id=195054
<rdar://problem/48330549>

Reviewed by Geoff Garen.

Source/WebCore:

Add MaintainMemoryCache flag to indicate that the memory cache should not get purged.

• page/MemoryRelease.cpp: (WebCore::releaseNoncriticalMemory): (WebCore::releaseCriticalMemory): (WebCore::releaseMemory):
• page/MemoryRelease.h:

Source/WebKit:

We attempt to restore the scroll position twice, on first layout and then on load completion.
Before PSON, the scroll position would fail to get restored on first layout but would succeed
on load completion because the view is tall enough by then. With PSON however, we would
fail to restore the scroll position on load completion because the view would not be tall
enough yet by this point. The reason is that the dynamic resources would not be in the memory cache
and would then get reloaded abd finish loading *after* the load event.

To address the issue, we now make sure to not purge the memory cache on process suspension on
iOS if there is currently a SuspendedPageProxy in the UIProcess for this process.

• UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::SuspendedPageProxy): (WebKit::SuspendedPageProxy::~SuspendedPageProxy):
• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::incrementSuspendedPageCount): (WebKit::WebProcessProxy::decrementSuspendedPageCount):
• UIProcess/WebProcessProxy.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setHasSuspendedPageProxy):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:49 AM Changeset in webkit [242134] by bshafiei@apple.com

• 4 edits in branches/safari-607-branch

Cherry-pick r242089. rdar://problem/48429668

WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
​https://bugs.webkit.org/show_bug.cgi?id=195028
<rdar://problem/48243733>

Reviewed by Eric Carlson.

Source/WebKit:

Covered by API test.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resetState):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:49 AM Changeset in webkit [242133] by bshafiei@apple.com

• 3 edits in branches/safari-607-branch/Source/WebKit

Cherry-pick r242098. rdar://problem/48429674

[iOS] REGRESSION(r238490?): Safari sometimes shows blank page until a cross site navigation or re-opening the tab
​https://bugs.webkit.org/show_bug.cgi?id=195037
<rdar://problem/48154508>

Reviewed by Antti Koivisto.

Restore the pre-r238490 behavior of WebPage::didCompletePageTransition clearing LayerTreeFreezeReason::ProcessSuspended
as this has been an issue when I was able to reproduce the issue locally.

Also added release logging to help diagnose the issue in the future.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::freezeLayerTree): (WebKit::WebPage::unfreezeLayerTree): (WebKit::WebPage::didCompletePageTransition):
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::freezeAllLayerTrees): (WebKit::WebProcess::unfreezeAllLayerTrees):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:47 AM Changeset in webkit [242132] by Simon Fraser

• 53 edits in trunk

Have a single notion of scroll position in the scrolling tree and derive layoutViewport from it
​https://bugs.webkit.org/show_bug.cgi?id=194973

Reviewed by Antti Koivisto.

This patch cleans up how the scrolling tree responds to scrolls.

First, ScrollingTreeScrollingNode::m_currentScrollPosition is "truth" for scrolling thread/
UI process scroll position.

On macOS where handleWheelEvent on the scrolling thread changes scroll position, the
bottleneck is ScrollingTreeScrollingNode::scrollTo() which sets the new scroll position,
update the visual viewport (for frame scrolls) updates the scrolledContentsLayer position,
updates related layers on this node (counter-scrolling layers etc), and then tells the
scrolling tree, which recurses through descendant nodes so they can adjust their layer
positions.

On iOS, the bottleneck is ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling(),
which does the above other than setting scrolledContentsLayer (since we're reacting to
layer state changes, not producing them).

updateLayersAfterAncestorChange() is renamed to relatedNodeScrollPositionDidChange(), and
ScrollingTree does the tree walk so classes don't have to implement
updateLayersAfterAncestorChange() just to talk children. The ScrollingTree tree walk knows
how to get the correct layoutViewport and to stop at frame boundaries (layer updates never
need to cross frame boundaries).

We preserve 'cumulativeDelta'; it's necessary for things like fixed inside overflow:scroll,
since the fixed state was computed with the "layout" scroll position, so we have to account
for the scroll delta since the last committed position. It's possible we could improve this
in future.

Source/WebCore:

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::mainFrameViewportChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::notifyRelatedNodesAfterScrollPositionChange):
(WebCore::ScrollingTree::notifyRelatedNodesRecursive):
(WebCore::ScrollingTree::mainFrameLayoutViewport):
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling): Deleted.

• page/scrolling/ScrollingTree.h:
• page/scrolling/ScrollingTreeFrameHostingNode.cpp:

(WebCore::ScrollingTreeFrameHostingNode::updateLayersAfterAncestorChange): Deleted.

• page/scrolling/ScrollingTreeFrameHostingNode.h:
• page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::updateViewportForCurrentScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNode::localToContentsPoint const):

• page/scrolling/ScrollingTreeFrameScrollingNode.h:
• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::relatedNodeScrollPositionDidChange):
(WebCore::ScrollingTreeNode::enclosingScrollingNodeIncludingSelf):

• page/scrolling/ScrollingTreeNode.h:
• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::minimumScrollPosition const):
(WebCore::ScrollingTreeScrollingNode::scrollLimitReached const):
(WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const):
(WebCore::ScrollingTreeScrollingNode::scrollBy):
(WebCore::ScrollingTreeScrollingNode::scrollTo):
(WebCore::ScrollingTreeScrollingNode::currentScrollPositionChanged):
(WebCore::ScrollingTreeScrollingNode::wasScrolledByDelegatedScrolling):
(WebCore::ScrollingTreeScrollingNode::localToContentsPoint const):
(WebCore::ScrollingTreeScrollingNode::updateLayersAfterAncestorChange): Deleted.
(WebCore::ScrollingTreeScrollingNode::setScrollPosition): Deleted.

• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/ScrollingTreeScrollingNodeDelegate.h:

(WebCore::ScrollingTreeScrollingNodeDelegate::currentScrollPosition const):
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollPosition const): Deleted.

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/cocoa/ScrollingTreeFixedNode.h:
• page/scrolling/cocoa/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::relatedNodeScrollPositionDidChange):
(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange): Deleted.

• page/scrolling/cocoa/ScrollingTreeStickyNode.h:
• page/scrolling/cocoa/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::relatedNodeScrollPositionDidChange):
(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange): Deleted.

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const):
(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateMainFramePinState):
(WebCore::ScrollingTreeFrameScrollingNodeMac::exposedUnfilledArea const):
(WebCore::ScrollingTreeFrameScrollingNodeMac::scrollPosition const): Deleted.
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition): Deleted.
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): Deleted.
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateLayersAfterViewportChange): Deleted.

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:

(): Deleted.

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::repositionScrollingLayers):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::~ScrollingTreeOverflowScrollingNodeMac): Deleted.
(WebCore::ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterAncestorChange): Deleted.
(WebCore::ScrollingTreeOverflowScrollingNodeMac::scrollPosition const): Deleted.
(WebCore::ScrollingTreeOverflowScrollingNodeMac::setScrollPosition): Deleted.
(WebCore::ScrollingTreeOverflowScrollingNodeMac::setScrollLayerPosition): Deleted.
(WebCore::ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterDelegatedScroll): Deleted.

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::isAlreadyPinnedInDirectionOfGesture):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stretchAmount):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::pinnedInDirection):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::adjustScrollPositionToBoundsIfNecessary):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::scrollOffset const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollOnAxis):

Source/WebKit:

• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::viewportChangedViaDelegatedScrolling):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):

• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
• UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll):

• UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
• UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::currentLayoutViewport const):

• UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm:

(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::commitStateAfterChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::repositionScrollingLayers):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::repositionRelatedLayers):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::scrollPosition const): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::setScrollPosition): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::setScrollLayerPosition): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateChildNodesAfterScroll): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateLayersAfterDelegatedScroll): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateLayersAfterViewportChange): Deleted.
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::updateLayersAfterAncestorChange): Deleted.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::repositionScrollingLayers):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange): Deleted.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollPosition const): Deleted.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Deleted.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterDelegatedScroll): Deleted.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::repositionScrollingLayers):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateLayersAfterAncestorChange): Deleted.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollPosition const): Deleted.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::setScrollLayerPosition): Deleted.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Deleted.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll const): Deleted.

• UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm:

(WebKit::ScrollerPairMac::updateValues):
(WebKit::ScrollerPairMac::valuesForOrientation):

• UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp:

(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::repositionRelatedLayers):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::setScrollLayerPosition): Deleted.

• UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):

10:05 AM Changeset in webkit [242131] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Silence log after r242122
​https://bugs.webkit.org/show_bug.cgi?id=195074

• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databasePath const):
m_localStorageDirectory can now be null for ephemeral sessions.
This is not a failure to create a directory and needs no log.
This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.

9:33 AM Changeset in webkit [242130] by Simon Fraser

• 9 edits in trunk/LayoutTests

scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
​https://bugs.webkit.org/show_bug.cgi?id=195099

Reviewed by Frederic Wang.

These tests were failing because the ref test captured the tap highlight, so hide
it with -webkit-tap-highlight-color: transparent;

• fast/scrolling/ios/hit-testing-iframe-001.html:
• fast/scrolling/ios/hit-testing-iframe-002.html:
• fast/scrolling/ios/hit-testing-iframe-003.html:
• fast/scrolling/ios/hit-testing-iframe-004.html:
• fast/scrolling/ios/hit-testing-iframe-005.html:
• fast/scrolling/ios/hit-testing-iframe-006.html:
• fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
• platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.

9:31 AM Changeset in webkit [242129] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[MSE] SourceBuffer sample time increment vs. last frame duration check is broken
​https://bugs.webkit.org/show_bug.cgi?id=194747
<rdar://problem/48148469>

Patch by Ulrich Pflueger <​up@nanocosmos.de> on 2019-02-27
Reviewed by Jer Noble.

Source/WebCore:

Prevent unintended frame drops by including last frame duration in discontinuity check.

Test: media/media-source/media-source-append-variable-frame-lengths-with-matching-durations.html

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

• media/media-source/media-source-append-variable-frame-lengths-with-matching-durations-expected.txt: Added.
• media/media-source/media-source-append-variable-frame-lengths-with-matching-durations.html: Added.

8:59 AM Changeset in webkit [242128] by timothy@apple.com

• 4 edits in trunk/Source

REGRESSION: WebKit content crash in Base System (because NSAppearance is NULL).
​https://bugs.webkit.org/show_bug.cgi?id=195086
rdar://problem/48419124

Reviewed by Tim Horton.

Source/WebCore:

• platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]): Always return a valid NSAppearance.

Source/WebKit:

• UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:

(-[WKScrollerImpDelegate effectiveAppearanceForScrollerImp:]): Always return a valid NSAppearance.

Feb 26, 2019:

11:50 PM Changeset in webkit [242127] by mark.lam@apple.com

• 12 edits
  9 deletes in trunk

Remove remaining poisoning code.
​https://bugs.webkit.org/show_bug.cgi?id=194138

Reviewed by Saam Barati.

Source/WTF:

This patch removes the instantiation of Poisoned variants of the various containers
but retains the ability of those containers to work with pointer traits. This
allows us to use them with smart pointers in the future (just like we used to with
Poisoned values). At minimum, this ability will be useful when we want to insert
an observer into the container storage type for debugging purposes, or to collect
statistics for profiling.

• WTF.xcodeproj/project.pbxproj:
• wtf/Bag.h:
• wtf/CMakeLists.txt:
• wtf/Platform.h:
• wtf/Poisoned.cpp: Removed.
• wtf/Poisoned.h: Removed.
• wtf/PoisonedUniquePtr.h: Removed.
• wtf/Ref.h:
• wtf/RefCountedArray.h:
• wtf/RefPtr.h:
• wtf/WTFAssertions.cpp:

Tools:

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
• TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
• TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
• TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
• TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
• TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.

11:33 PM Changeset in webkit [242126] by Dewei Zhu

• 2 edits in trunk/Websites/perf.webkit.org

The table head of test freshness page should not scroll with the page.
​https://bugs.webkit.org/show_bug.cgi?id=195092

Reviewed by Ryosuke Niwa.

Fix the location of the freshness table head to make it easier to corelate cell with test.

• public/v3/pages/test-freshness-page.js: Changed some style rules to make the table head fixed.

(TestFreshnessPage.prototype._renderTable):
(TestFreshnessPage.cssTemplate):

11:21 PM Changeset in webkit [242125] by bshafiei@apple.com

• 7 edits in branches/safari-607-branch/Source

Versioning.

9:46 PM Changeset in webkit [242124] by Chris Dumez

• 9 edits in trunk/Source/WebKit

[PSON] Add mechanism to clear suspended pages while bypassing the WebProcess cache
​https://bugs.webkit.org/show_bug.cgi?id=195089

Reviewed by Geoffrey Garen.

Add a convenient mechanism to clear suspended pages while bypassing the WebProcess
cache since we need to do this on memory pressure and when clearing website data.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

• UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::addProcessIfPossible):
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::CachedProcess::~CachedProcess):

• UIProcess/WebProcessCache.h:

(WebKit::WebProcessCache::setIsDisabled): Deleted.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::handleMemoryPressureWarning):
(WebKit::WebProcessPool::hasSuspendedPageFor const):
(WebKit::WebProcessPool::clearSuspendedPages):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::maybeShutDown):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::suspendedPageCount const):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):

9:43 PM Changeset in webkit [242123] by mark.lam@apple.com

• 55 edits
  2 deletes in trunk/Source/JavaScriptCore

Remove poisons in JSCPoison and uses of them.
​https://bugs.webkit.org/show_bug.cgi?id=195082

Reviewed by Yusuke Suzuki.

Also removed unused poisoning code in WriteBarrier, AssemblyHelpers,
DFG::SpeculativeJIT, FTLLowerDFGToB3, and FTL::Output.

• API/JSAPIWrapperObject.h:

(JSC::JSAPIWrapperObject::wrappedObject):

• API/JSCallbackFunction.h:
• API/JSCallbackObject.h:
• API/glib/JSAPIWrapperGlobalObject.h:
• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileNewFunctionCommon):
(JSC::DFG::SpeculativeJIT::compileGetExecutable):
(JSC::DFG::SpeculativeJIT::compileCreateThis):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::TrustedImmPtr::weakPoisonedPointer): Deleted.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetExecutable):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArrayLength):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::weakPointer):
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoison): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoisonOnLoadedType): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoisonOnType): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::weakPoisonedPointer): Deleted.

• ftl/FTLOutput.h:

(JSC::FTL::Output::weakPoisonedPointer): Deleted.

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitDynamicPoison): Deleted.
(JSC::AssemblyHelpers::emitDynamicPoisonOnLoadedType): Deleted.
(JSC::AssemblyHelpers::emitDynamicPoisonOnType): Deleted.

• jit/AssemblyHelpers.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_create_this):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

• jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

• jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):

• parser/UnlinkedSourceCode.h:
• runtime/ArrayPrototype.h:
• runtime/CustomGetterSetter.h:

(JSC::CustomGetterSetter::getter const):
(JSC::CustomGetterSetter::setter const):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::getCallData):
(JSC::InternalFunction::getConstructData):

• runtime/InternalFunction.h:

(JSC::InternalFunction::nativeFunctionFor):

• runtime/JSArrayBuffer.h:
• runtime/JSBoundFunction.h:
• runtime/JSCPoison.cpp: Removed.
• runtime/JSCPoison.h: Removed.
• runtime/JSFunction.h:
• runtime/JSGlobalObject.h:
• runtime/JSScriptFetchParameters.h:
• runtime/JSScriptFetcher.h:
• runtime/JSString.h:
• runtime/NativeExecutable.cpp:

(JSC::NativeExecutable::hashFor const):

• runtime/NativeExecutable.h:
• runtime/Options.h:
• runtime/ScopedArguments.h:
• runtime/Structure.cpp:

(JSC::StructureTransitionTable::setSingleTransition):

• runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::map const):
(JSC::StructureTransitionTable::weakImpl const):
(JSC::StructureTransitionTable::setMap):

• runtime/WriteBarrier.h:
• wasm/WasmB3IRGenerator.cpp:
• wasm/WasmInstance.h:
• wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

• wasm/js/JSWebAssemblyCodeBlock.h:
• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::JSWebAssemblyInstance):
(JSC::JSWebAssemblyInstance::visitChildren):

• wasm/js/JSWebAssemblyInstance.h:
• wasm/js/JSWebAssemblyMemory.h:
• wasm/js/JSWebAssemblyModule.h:
• wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::JSWebAssemblyTable):
(JSC::JSWebAssemblyTable::grow):
(JSC::JSWebAssemblyTable::clearFunction):

• wasm/js/JSWebAssemblyTable.h:
• wasm/js/WasmToJS.cpp:

(JSC::Wasm::materializeImportJSCell):
(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):

• wasm/js/WebAssemblyFunctionBase.h:
• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

• wasm/js/WebAssemblyModuleRecord.h:
• wasm/js/WebAssemblyToJSCallee.h:
• wasm/js/WebAssemblyWrapperFunction.h:

8:40 PM Changeset in webkit [242122] by achristensen@apple.com

• 11 edits in trunk

Move ephemeral local storage from WebProcess to UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=195074
<rdar://problem/47937975>

Reviewed by Geoff Garen.

Source/WebKit:

Before PSON, a page could navigate to another domain that navigates back and still have its local storage.
Since PSON makes it unreliable to retain the state in the WebProcess, move it to the process with the rest of the local storage.
If it's ephemeral, we obviously can't use the SQLite on-disk storage implementation, so use the same WebCore::StorageMap we used to in the WebProcess.

• UIProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::LocalStorageNamespace::LocalStorageNamespace):
(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createTransientLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):

• UIProcess/WebStorage/StorageManager.h:
• UIProcess/WebStorage/StorageManager.messages.in:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):

• WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::loadValuesIfNeeded):

• WebProcess/WebStorage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::createEphemeralLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::storageArea):
(WebKit::StorageNamespaceImpl::copy):
(): Deleted.
(WebKit::StorageNamespaceImpl::ephemeralLocalStorageArea): Deleted.

• WebProcess/WebStorage/StorageNamespaceImpl.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

8:19 PM Changeset in webkit [242121] by commit-queue@webkit.org

• 2 edits in trunk

Incorrect formatting around command in Readme.md
​https://bugs.webkit.org/show_bug.cgi?id=195061

Patch by Gabe Giosia <​giosia@google.com> on 2019-02-26
Reviewed by Fujii Hironori.

• ReadMe.md: removed stray period

7:48 PM Changeset in webkit [242120] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

REGRESSION: stress/regress-178386.js is timing out on JSC debug bot
​https://bugs.webkit.org/show_bug.cgi?id=194677
<rdar://problem/48112492>

Reviewed by Mark Lam.

Before r241233, String.fromCharCode (except for an empty string) always returns 16bit string.
This makes the rope generated by padEnd 16bit. When we resolve the rope inside JSON.stringify,
it immediately fails due the large size.

After r241233, String.fromCharCode starts returning 8bit string if possible. So the rope becomes
8bit, and we successfully resolve the rope in this case. Resolving such a large rope takes long
time and that is why stress/regress-178386.js starts timing out. Note that, the test fails with
OOM error anyway because JSON.stringify's builder overflows with such a large string input.

This patch changes the test to produce 16bit string from String.fromCharCode.

• stress/regress-178386.js:

5:33 PM Changeset in webkit [242119] by Alan Coon

• 1 copy in tags/Safari-607.1.39

Tag Safari-607.1.39.

5:28 PM Changeset in webkit [242118] by Matt Baker

• 25 edits
  1 add
  4 deletes in trunk/Source/WebInspectorUI

Web Inspector: Use system accent color throughout UI
​https://bugs.webkit.org/show_bug.cgi?id=193507
<rdar://problem/47327971>

Reviewed by Timothy Hatcher.

• UserInterface/Images/Breakpoint.png: Removed.
• UserInterface/Images/Breakpoint.svg: Added.
• UserInterface/Images/Breakpoint@2x.png: Removed.
• UserInterface/Images/BreakpointInactive.png: Removed.
• UserInterface/Images/BreakpointInactive@2x.png: Removed.

Replace breakpoint pixel art with an SVG image that can be styled in CSS.

• UserInterface/Images/CSSVariable.svg:
• UserInterface/Images/CubicBezier.svg:
• UserInterface/Images/UserInputPrompt.svg:

Remove fill color since it is now styled in CSS.

• UserInterface/Views/BezierEditor.css:

(.bezier-editor > .bezier-preview > div):
(@media (prefers-color-scheme: dark)):
(.bezier-editor > .bezier-container .control-handle):
(.bezier-editor > .bezier-container .control-line):
Use system accent color for control handles.

• UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image):
(.item.breakpoint .status > .status-image.resolved):
Use system accent color for breakpoint fill, with a dark outline
to match Xcode and make the button stand out against the selection.

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype._updateStatus):

• UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button > .glyph):

• UserInterface/Views/ConsolePrompt.js:

(WI.ConsolePrompt):

• UserInterface/Views/DOMBreakpointTreeElement.js:
• UserInterface/Views/DOMTreeContentView.css:

(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint):
(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint.disabled,):
(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint.subtree):
(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint.disabled): Deleted.
(.content-view.dom-tree .tree-outline.dom.breakpoints-disabled li .status-image.breakpoint): Deleted.
(.content-view.dom-tree .tree-outline.dom.breakpoints-disabled li .status-image.breakpoint.disabled): Deleted.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li.selected .selection-area):
(.tree-outline.dom li.elements-drag-over .selection-area):
(.tree-outline.dom:focus li:matches(.selected, .hovered) .selection-area):
(.tree-outline.dom li.hovered:not(.selected) .selection-area):
(.tree-outline.dom li.pseudo-class-enabled > .selection-area::before):
Use the system accent color for the "pseudo-class enabled" marker.
(@media (prefers-color-scheme: dark)):
(.tree-outline.dom:focus li.selected .selection-area): Deleted.
Use --selected-background-color for selection and hover styles, which is
set to the system highlight color if available.

• UserInterface/Views/InlineSwatch.css:

(.inline-swatch:matches(.bezier, .spring, .variable)):
(.inline-swatch:matches(.bezier, .spring)): Deleted.
(.inline-swatch.variable): Deleted.

• UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch):

• UserInterface/Views/NetworkDetailView.css:

(.network .network-detail .navigation-bar .item.radio.button.text-only:before):
(.network .network-detail .navigation-bar .item.radio.button.text-only.selected):
(@media (prefers-color-scheme: dark)):
(.network-detail .item.close > .glyph):

• UserInterface/Views/QuickConsole.css:

(.quick-console > .console-prompt > .glyph):
(.quick-console > .console-prompt::before): Deleted.

• UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only):
(.navigation-bar .item.radio.button.text-only::before):
(.navigation-bar .item.radio.button.text-only:matches(.selected, :hover)):
(.navigation-bar .item.radio.button.text-only:matches(.selected, :hover)::before):
(.navigation-bar .item.radio.button.text-only:not(.selected):hover::before):
(.navigation-bar .item.radio.button.text-only.selected:active::before):
(.navigation-bar .item.radio.button.text-only:hover): Deleted.
(.navigation-bar .item.radio.button.text-only.selected): Deleted.
(.navigation-bar .item.radio.button.text-only:active): Deleted.
(.navigation-bar .item.radio.button.text-only.selected:active): Deleted.
Use system accent color for selection and hover styles. Since it isn't
yet possible to derive new colors from the accent color in CSS, fake it
with a ::before pseudo-element that can have have filter or opacity
effects applied to it without altering the button text color.

• UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:

(.timeline-overview-graph.rendering-frame > .frame-marker):
Use system accent color for selected frame marker.

• UserInterface/Views/ScopeBar.css:

(.scope-bar > li):
(.scope-bar > li::before):
(.scope-bar.default-item-selected > li.multiple.selected::before):
(.scope-bar > li:matches(.selected, :hover)):
(.scope-bar > li:matches(.selected, :hover)::before):
(.scope-bar > li:not(.selected):hover::before):
(.scope-bar > li.selected:active::before):
(.scope-bar > li:hover): Deleted.
(.scope-bar > li.selected): Deleted.
(.scope-bar > li:active): Deleted.
(.scope-bar > li.selected:active): Deleted.

• UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar .item.radio.button.text-only:before):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):
(@media (prefers-color-scheme: dark)):

• UserInterface/Views/TextEditor.css:

(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before):
(.text-editor > .CodeMirror .breakpoint-resolved .CodeMirror-linenumber::before):
(.text-editor > .CodeMirror .has-breakpoint.multiple-breakpoints .CodeMirror-linenumber::before):
(@keyframes text-editor-highlight-fadeout):
(@keyframes text-editor-hovered-expression-highlight-fadeout):
Replace breakpoint pixel art with a solid color (the system accent
color) clipped to the shape of a breakpoint.

• UserInterface/Views/TimelineRecordFrame.css:

(.timeline-record-frame.selected):

• UserInterface/Views/URLBreakpointTreeElement.js:

• UserInterface/Views/Variables.css:

(:root):
(body.window-inactive):
(@media (prefers-color-scheme: dark)):
(body.mac-platform:not(.sierra, .high-sierra)):
Add custom property overrides for system colors where supported.

5:13 PM Changeset in webkit [242117] by Wenson Hsieh

• 4 edits
  2 adds in trunk

Remove conditional compile guard for InsertIntoTextNodeCommand::doReapply
​https://bugs.webkit.org/show_bug.cgi?id=195067
<rdar://problem/44812080>

Reviewed by Tim Horton.

Source/WebCore:

This iOS-specific override was introduced to fix <rdar://problem/7114425>, in which the last typed character
would be revealed when redoing text input on iOS inside a password field. The associated change fixed this bug
by overriding doReapply on iOS to only insert text (instead of additionally handling password echo); however, it
really makes sense to skip password echo when redoing on all platforms, so we can just remove the platform-
specific guards around this logic.

Doing this allows us to add the hasEditableStyle() check on iOS when redoing text insertion, which results in
a very subtle behavior change covered by the new layout test below.

Test: editing/undo/redo-text-insertion-in-non-editable-node.html

• editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doReapply):

• editing/InsertIntoTextNodeCommand.h:

LayoutTests:

Add a new layout test to verify that redoing text insertion in a non-editable element (which was previously
editable) does not mutate the text nodes affected by editing. This test case currently fails on iOS, since we
take a separate codepath when redoing that does not contain this additional check.

• editing/undo/redo-text-insertion-in-non-editable-node-expected.txt: Added.
• editing/undo/redo-text-insertion-in-non-editable-node.html: Added.

4:59 PM Changeset in webkit [242116] by keith_miller@apple.com

• 4 edits in trunk/Source

Code quality cleanup in NeverDestroyed
​https://bugs.webkit.org/show_bug.cgi?id=194824

Source/WebCore:

Reviewed by Mark Lam.

name_names.pl should not just assume the layout of LazyNeverDestroyed.

• dom/make_names.pl:

(printNamesCppFile):

Source/WTF:

Reviewed by Yusuke Suzuki.

First, move data members to the end of the class per WebKit
style. Also, add forbid heap allocation since we expect the
NeverDestroyed classes to be static.

• wtf/NeverDestroyed.h:

4:36 PM Changeset in webkit [242115] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Do not try to observe the timer when Page is nullptr
​https://bugs.webkit.org/show_bug.cgi?id=195076

Reviewed by Tim Horton.

Covered by fast/dom/Window/timer-null-script-execution-context.html.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):

4:25 PM Changeset in webkit [242114] by mark.lam@apple.com

• 5 edits
  1 add in trunk

wasmToJS() should purify incoming NaNs.
​https://bugs.webkit.org/show_bug.cgi?id=194807
<rdar://problem/48189132>

Reviewed by Saam Barati.

JSTests:

• wasm/regress/wasmToJS-should-purify-NaNs.js: Added.

Source/JavaScriptCore:

• runtime/JSCJSValue.h:

(JSC::jsNumber):

• runtime/TypedArrayAdaptors.h:

(JSC::IntegralTypedArrayAdaptor::toJSValue):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

4:04 PM Changeset in webkit [242113] by jer.noble@apple.com

• 20 edits
  1 add in trunk

[Cocoa] Media elements will restart network buffering just before suspending
​https://bugs.webkit.org/show_bug.cgi?id=193691

Reviewed by Eric Carlson.

Source/WebCore:

API Test: WebKit.ProcessSuspendMediaBuffering

Allow the Page to suspend all media buffering in its child Documents.

• dom/Document.cpp:

(WebCore::Document::suspendAllMediaBuffering):
(WebCore::Document::resumeAllMediaBuffering):

• dom/Document.h:
• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::dataBufferingPermitted const):
(WebCore::MediaElementSession::suspendBuffering):
(WebCore::MediaElementSession::resumeBuffering):
(WebCore::MediaElementSession::bufferingSuspended const):

• html/MediaElementSession.h:
• page/Page.cpp:

(WebCore::Page::suspendAllMediaBuffering):
(WebCore::Page::resumeAllMediaBuffering):

• page/Page.h:

(WebCore::Page::mediaPlaybackIsSuspended const):
(WebCore::Page::mediaBufferingIsSuspended const):
(WebCore::Page::mediaPlaybackIsSuspended): Deleted.

• platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::suspendBuffering):
(WebCore::PlatformMediaSession::resumeBuffering):

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):

• platform/audio/PlatformMediaSessionManager.h:

Source/WebKit:

When the WebProcess receives a notification that the process is about to become
suspended, it tells the MemoryPressureHandler to release all critical memory. This
has the side effect of causing AVFoundation-backed media elements to dump their
in-memory caches and start downloading media data again. Instead, media elements
should all stop buffering media data during suspension. Add new testing SPI to
simulate suspension and resume messages.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):
(-[WKWebView _processDidResumeForTesting]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebProcessProxy.h:
• UIProcess/ios/WKInkPickerView.mm:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::suspendAllMediaBuffering):
(WebKit::WebPage::resumeAllMediaBuffering):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::processDidResume):
(WebKit::WebProcess::suspendAllMediaBuffering):
(WebKit::WebProcess::resumeAllMediaBuffering):

• WebProcess/WebProcess.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.

(TEST):

3:53 PM Changeset in webkit [242112] by youenn@apple.com

• 10 edits in trunk

Move service worker response validation from the service worker client to the service worker itself
​https://bugs.webkit.org/show_bug.cgi?id=194716

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebased tests as we now report to the console log any service worker response validation erorr.

• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-image.https-expected.txt:

Source/WebCore:

Added response validation at service worker side.

No change of behavior except for now logging validation error messages in the console.
Covered by rebased tests.

• workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::validateResponse):
(WebCore::ServiceWorkerFetch::processResponse):
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

Source/WebKit:

Removed response validation as it is now done in service worker side.

• WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::didReceiveRedirectResponse):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

LayoutTests:

Rebased tests as we now report to the console log any service worker response validation erorr.

• http/tests/inspector/network/resource-response-service-worker-expected.txt:
• http/tests/workers/service/basic-fetch.https-expected.txt:
• http/tests/workers/service/service-worker-crossorigin-fetch-expected.txt:

3:45 PM Changeset in webkit [242111] by Kocsen Chung

• 1 copy in tags/Safari-608.1.7

Tag Safari-608.1.7.

3:38 PM Changeset in webkit [242110] by sihui_liu@apple.com

• 6 edits in trunk/Source/WebCore

[Mac WK2] storage/indexeddb/IDBObject-leak.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=195036

Reviewed by Geoffrey Garen.

When connection to IDBServer is lost, IDBDatabase in web process should not only stop active transactions, but
also transactions in committing process.

Also, TransactionOpration should clear its perform function when the operation is being completed, otherwise
there is a reference cycle of TransactionOpration.

Covered by existing tests storage/indexeddb/IDBObject-leak.html.

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::connectionToServerLost): notify committing transasctions that connection is lost.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::connectionClosedFromServer): notify IDBConnectionProxy that transaction ends.

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::forgetTransaction): clear finished transactions.

• Modules/indexeddb/client/IDBConnectionProxy.h:
• Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::TransactionOperation::doComplete): clear perform function unconditionally when the
operation is in completion process.

2:40 PM Changeset in webkit [242109] by dinfuehr@igalia.com

• 9 edits in trunk

Fix warnings on ARM and MIPS
​https://bugs.webkit.org/show_bug.cgi?id=195049

Reviewed by Mark Lam.

.:

Disable warnings for changes to the ABI with GCC 7.1.

• Source/cmake/WebKitCompilerFlags.cmake:

Source/JavaScriptCore:

Fix all warnings on ARM and MIPS.

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printMemory):

• assembler/testmasm.cpp:

(JSC::testProbeModifiesStackValues):

• bytecode/InByIdStatus.cpp:

(JSC::InByIdStatus::computeFor):

• runtime/CachedTypes.cpp:

(JSC::VariableLengthObject::buffer const):

• runtime/JSBigInt.h:
• tools/JSDollarVM.cpp:

(JSC::codeBlockFromArg):

2:31 PM Changeset in webkit [242108] by Alan Bujtas

• 13 edits in trunk/Source

[ContentChangeObserver] clearContentChangeObservers should be internal to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195066
<rdar://problem/48411682>

Reviewed by Tim Horton.

Source/WebCore:

Now all the empty clearContentChangeObservers() implementations can be removed.

• dom/Document.cpp:

(WebCore::Document::platformSuspendOrStopActiveDOMObjects):

• loader/EmptyClients.h:
• page/ChromeClient.h:
• page/Frame.cpp:

(WebCore::Frame::willDetachPage):

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::clearTimersAndReportContentChange):
(WebCore::ContentChangeObserver::didSuspendActiveDOMObjects): Might need to merge them.
(WebCore::ContentChangeObserver::willDetachPage):

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::clearContentChangeObservers): Deleted.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebChromeClientIOS.h:
• WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::clearContentChangeObservers): Deleted.

2:14 PM Changeset in webkit [242107] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[iOS] Sandbox should allow mach lookups related to media capturing
​https://bugs.webkit.org/show_bug.cgi?id=194951

Reviewed by Eric Carlson.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:08 PM Changeset in webkit [242106] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Update NetworkSession to use Session Cleanup when available
​https://bugs.webkit.org/show_bug.cgi?id=195019
<rdar://problem/45149868>

Reviewed by Alex Christensen.

If the build environment supports Session Cleanup, initialize it.

No test changes since this doesn't do anything on the test systems at present.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

1:50 PM Changeset in webkit [242105] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Search: no results when opening to Search tab
​https://bugs.webkit.org/show_bug.cgi?id=195058
<rdar://problem/48407699>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch):
If targets aren't available, wait until they are and then perform the search.

• UserInterface/Base/Main.js:

(WI.targetsAvailable): Added.
Expose getter for indicating whether targets are available.

1:40 PM Changeset in webkit [242104] by Joseph Pecoraro

• 8 edits
  3 adds in trunk/Source/WebInspectorUI

Web Inspector: CPU Usage Timeline - Main Thread Indicator
​https://bugs.webkit.org/show_bug.cgi?id=194972

Reviewed by Devin Rousso.

• UserInterface/Main.html:
• UserInterface/Base/Utilities.js:

(value):
The existing enclosingNode doesn't work for SVG because its names
are lowercase. Add a simplified version for the svg case.

• UserInterface/Views/RangeChart.js: Added.

(WI.RangeChart):
(WI.RangeChart.prototype.get size):
(WI.RangeChart.prototype.set size):
(WI.RangeChart.prototype.addRange):
(WI.RangeChart.prototype.clear):
(WI.RangeChart.prototype.layout):
A new chart that draws rects for given ranges.

• UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsOverlappingTimeRange):
Helper to specifically get records touching a range. Useful
for when we have a single pixel spanning (startTime -> endTime)
and we want to find records in that pixel.

• UserInterface/Views/CPUTimelineView.css:

(.timeline-view.cpu .cpu-usage-indicator-view > .graph > .range-chart rect):
(.timeline-view.cpu .cpu-usage-indicator-view > .graph > .range-chart .sample-type-script):
(.timeline-view.cpu .cpu-usage-indicator-view > .graph > .range-chart .sample-type-style):
(.timeline-view.cpu .cpu-usage-indicator-view > .graph > .range-chart .sample-type-layout):
(.timeline-view.cpu .cpu-usage-indicator-view > .graph > .range-chart .sample-type-paint):

• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.get indicatorViewHeight):
(WI.CPUTimelineView.prototype.clear):
(WI.CPUTimelineView.prototype.get scrollableElements):
(WI.CPUTimelineView.prototype.initialLayout):
(WI.CPUTimelineView.prototype.layout):
(WI.CPUTimelineView.prototype._graphPositionForMouseEvent):
(WI.CPUTimelineView.prototype._handleIndicatorClick):
(WI.CPUTimelineView.prototype._attemptSelectIndicatatorTimelineRecord):
(WI.CPUTimelineView.prototype._selectTimelineRecord):
Place the Main Thread Indicator view beneath the big graph.
Clicking inside it selects records in the Timeline Overview.

• UserInterface/Views/CPUUsageIndicatorView.css: Added.

(.cpu-usage-indicator-view):
(.cpu-usage-indicator-view > .details):
(body[dir=ltr] .cpu-usage-indicator-view > .details):
(body[dir=rtl] .cpu-usage-indicator-view > .details):
(body[dir=rtl] .cpu-usage-indicator-view > .graph):
(.cpu-usage-indicator-view > .graph):
(.cpu-usage-indicator-view > .graph,):

• UserInterface/Views/CPUUsageIndicatorView.js: Added.

(WI.CPUUsageIndicatorView):
(WI.CPUUsageIndicatorView.prototype.get chart):
(WI.CPUUsageIndicatorView.prototype.clear):
(WI.CPUUsageIndicatorView.prototype.updateChart):
Converts the CPU samples data into a RangeChart. It works to coalesce
many samples of the same type into a single range to reduce total ranges.

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._recordSelected):
(WI.TimelineRecordingContentView.prototype._recordWasSelected):
(WI.TimelineRecordingContentView.prototype._selectRecordInTimelineOverview):
(WI.TimelineRecordingContentView.prototype._selectRecordInTimelineView):

• UserInterface/Views/TimelineView.js:

Add a path for a TimelineView to dispatch a record selected event and cause
have the TimelineRecordingContentView react to it by updating the timeline
overview and relevent timeline view.

1:40 PM Changeset in webkit [242103] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Misc cleanup in StructureIDTable after r242096.
​https://bugs.webkit.org/show_bug.cgi?id=195063

Reviewed by Saam Barati.

• runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::allocateID):

• RELEASE_ASSERT that the StructureID allocation will succeed.

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::decode):
(JSC::StructureIDTable::encode):

• Add back a comment that Yusuke requested but was lost when the patch was rolled out and relanded.
• Applied bitwise_casts that Saam requested.

1:01 PM Changeset in webkit [242102] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[ContentChangeObserver] Move style recalc schedule observation logic to ContentChangeObserver
​https://bugs.webkit.org/show_bug.cgi?id=195062
<rdar://problem/48409258>

Reviewed by Tim Horton.

Also rename registerDOMTimerForContentObservationIfNeeded to be consistent with the did* naming style.

• dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::didInstallDOMTimer):
(WebCore::ContentChangeObserver::didScheduleStyleRecalc):
(WebCore::ContentChangeObserver::registerDOMTimerForContentObservationIfNeeded): Deleted.

12:54 PM Changeset in webkit [242101] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: 32-bit build fix after r242096.
​https://bugs.webkit.org/show_bug.cgi?id=194989

Not reviewed.

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitLoadStructure):

12:49 PM Changeset in webkit [242100] by mark.lam@apple.com

• 19 edits in trunk/Source/JavaScriptCore

Unpoison MacroAssemblerCodePtr, ClassInfo pointers, and a few other things.
​https://bugs.webkit.org/show_bug.cgi?id=195039

Reviewed by Saam Barati.

1. Unpoison MacroAssemblerCodePtrs, ReturnAddressPtr.
2. Replace PoisonedClassInfoPtr with ClassInfo*.
3. Replace PoisonedMasmPtr with const void*.
4. Remove all references to CodeBlockPoison, JITCodePoison, and GlobalDataPoison.

• API/JSCallbackObject.h:
• API/JSObjectRef.cpp:

(classInfoPrivate):

• assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):
(JSC::FunctionPtr::executableAddress const):
(JSC::FunctionPtr::retaggedExecutableAddress const):
(JSC::ReturnAddressPtr::ReturnAddressPtr):
(JSC::ReturnAddressPtr::value const):
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::operator! const):
(JSC::MacroAssemblerCodePtr::operator== const):
(JSC::MacroAssemblerCodePtr::hash const):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::FunctionPtr<tag>::FunctionPtr):
(JSC::MacroAssemblerCodePtr::poisonedPtr const): Deleted.

• b3/B3LowerMacros.cpp:
• b3/testb3.cpp:

(JSC::B3::testInterpreter):

• dfg/DFGOSRExitCompilerCommon.h:

(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):

• dfg/DFGSpeculativeJIT.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateDestructibleObject):

• jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):
(JSC::boundThisNoArgsFunctionCallGenerator):

• runtime/JSCPoison.h:
• runtime/JSDestructibleObject.h:

(JSC::JSDestructibleObject::classInfo const):

• runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::classInfo const):

• runtime/Structure.h:
• runtime/VM.h:
• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):

• wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

12:34 PM Changeset in webkit [242099] by Chris Dumez

• 10 edits in trunk/Source

[iOS] Regression(PSON) Scroll position is no longer restored when navigating back to reddit.com
​https://bugs.webkit.org/show_bug.cgi?id=195054
<rdar://problem/48330549>

Reviewed by Geoff Garen.

Source/WebCore:

Add MaintainMemoryCache flag to indicate that the memory cache should not get purged.

• page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):
(WebCore::releaseCriticalMemory):
(WebCore::releaseMemory):

• page/MemoryRelease.h:

Source/WebKit:

We attempt to restore the scroll position twice, on first layout and then on load completion.
Before PSON, the scroll position would fail to get restored on first layout but would succeed
on load completion because the view is tall enough by then. With PSON however, we would
fail to restore the scroll position on load completion because the view would not be tall
enough yet by this point. The reason is that the dynamic resources would not be in the memory cache
and would then get reloaded abd finish loading *after* the load event.

To address the issue, we now make sure to not purge the memory cache on process suspension on
iOS if there is currently a SuspendedPageProxy in the UIProcess for this process.

• UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):
(WebKit::SuspendedPageProxy::~SuspendedPageProxy):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::incrementSuspendedPageCount):
(WebKit::WebProcessProxy::decrementSuspendedPageCount):

• UIProcess/WebProcessProxy.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setHasSuspendedPageProxy):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

12:24 PM Changeset in webkit [242098] by rniwa@webkit.org

• 3 edits in trunk/Source/WebKit

[iOS] REGRESSION(r238490?): Safari sometimes shows blank page until a cross site navigation or re-opening the tab
​https://bugs.webkit.org/show_bug.cgi?id=195037
<rdar://problem/48154508>

Reviewed by Antti Koivisto.

Restore the pre-r238490 behavior of WebPage::didCompletePageTransition clearing LayerTreeFreezeReason::ProcessSuspended
as this has been an issue when I was able to reproduce the issue locally.

Also added release logging to help diagnose the issue in the future.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::didCompletePageTransition):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::freezeAllLayerTrees):
(WebKit::WebProcess::unfreezeAllLayerTrees):

11:47 AM Changeset in webkit [242097] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Create WebPageProxy::m_userMediaPermissionRequestManager only when needed
​https://bugs.webkit.org/show_bug.cgi?id=195051

Reviewed by Eric Carlson.

Before the patch, WebPageProxy::m_userMediaPermissionRequestManager was created
in some methods to reset its state when main document is changing, view is becoming visible...
This code is unnecessary if the page did not create it already using JS APIs such as getUserMedia/enumerateDevices/ondevicechange.
This patch skips processing in the other cases if WebPageProxy::m_userMediaPermissionRequestManager is null.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): No need to nullify it since it will be done in resetState shortly after.
(WebKit::WebPageProxy::didChangeMainDocument):
(WebKit::WebPageProxy::viewIsBecomingVisible):
(WebKit::WebPageProxy::clearUserMediaState):
(WebKit::WebPageProxy::updatePlayingMediaDidChange): m_userMediaPermissionRequestManager should not be null here
since there is or was some capturing done for the page.

11:41 AM Changeset in webkit [242096] by mark.lam@apple.com

• 10 edits in trunk/Source/JavaScriptCore

[Re-landing] Add some randomness into the StructureID.
​https://bugs.webkit.org/show_bug.cgi?id=194989
<rdar://problem/47975563>

Reviewed by Yusuke Suzuki.

1. On 64-bit, the StructureID will now be encoded as:

----------------------------------------------------------------
| 1 Nuke Bit | 24 StructureIDTable index bits | 7 entropy bits |
----------------------------------------------------------------

The entropy bits are chosen at random and assigned when a StructureID is
allocated.

2. Instead of Structure pointers, the StructureIDTable will now contain encodedStructureBits, which is encoded as such:

----------------------------------------------------------------
| 7 entropy bits | 57 structure pointer bits |
----------------------------------------------------------------

The entropy bits here are the same 7 bits used in the encoding of the
StructureID for this structure entry in the StructureIDTable.

3. Retrieval of the structure pointer given a StructureID is now computed as follows:

index = structureID >> 7; with arithmetic shift.
encodedStructureBits = structureIDTable[index];
structure = encodedStructureBits ^{(structureID << 57);}

We use an arithmetic shift for the right shift because that will preserve
the nuke bit in the high bit of the index if the StructureID was not
decontaminated before use as expected.

4. Remove unused function loadArgumentWithSpecificClass() in SpecializedThunkJIT.

5. Define StructureIDTable::m_size to be the number of allocated StructureIDs instead of always being the same as m_capacity.

6. Change StructureIDTable::s_unusedID's value to 0.

Its previous value of unusedPointer i.e. 0xd1e7beef, does not make sense for
StructureID on 64-bit. Also, there was never any code that initializes unused
IDs to the s_unusedID. The only meaningful value for s_unusedID is 0, which
is the ID we'll get when the freelist is empty, prompting a resize of the
structureIDTable.

This patch appears to be perf neutral on JetStream 2 run via the cli on a
11" MacBook Air, 13" MacBook Pro, iPhone 6S, and iPhone XR.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::loadStructure):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitLoadStructure):

• jit/AssemblyHelpers.h:
• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass): Deleted.

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::makeFreeListFromRange):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

• runtime/StructureIDTable.h:

(JSC::StructureIDTable::decode):
(JSC::StructureIDTable::encode):
(JSC::StructureIDTable::get):
(JSC::StructureIDTable::isValid):

11:23 AM Changeset in webkit [242095] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r241970.
​https://bugs.webkit.org/show_bug.cgi?id=195057

made the QuickLook.LegacyQuickLookContent API test flakey
(Requested by estes on #webkit).

Reverted changeset:

"[iOS] Break a reference cycle between PreviewLoader and
ResourceLoader"
​https://bugs.webkit.org/show_bug.cgi?id=194964
​https://trac.webkit.org/changeset/241970

10:37 AM Changeset in webkit [242094] by Alan Bujtas

• 6 edits in trunk/Source

[ContentChangeObserver] Simplify content observation API by removing explicit DOMTimer observation.
​https://bugs.webkit.org/show_bug.cgi?id=195023
<rdar://problem/48381885>

Reviewed by Tim Horton.

Source/WebCore:

In the future we might decide that certain activities don't require DOMTimer observation, but that should
be internal to ContentChangeObserver.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingContentChanges):
(WebCore::ContentChangeObserver::stopObservingContentChanges):

• page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::mouseMoved):

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

10:28 AM Changeset in webkit [242093] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[ContentChangeObserver] Move observing logic from Document::updateStyleIfNeeded to ContentChangeObserver
​https://bugs.webkit.org/show_bug.cgi?id=195032
<rdar://problem/48388063>

Reviewed by Tim Horton.

This might eventually turn into a regular start/stop content observing call.

• dom/Document.cpp:

(WebCore::Document::updateStyleIfNeeded):

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::ContentChangeObserver::startObservingStyleResolve):
(WebCore::ContentChangeObserver::stopObservingStyleResolve):

10:24 AM Changeset in webkit [242092] by commit-queue@webkit.org

• 7 edits
  8 adds in trunk

[Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
​https://bugs.webkit.org/show_bug.cgi?id=191652

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2019-02-26
Reviewed by Alex Christensen.

Source/WebKit:

Test: http/tests/security/401-logout/401-logout.php

• NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::tryHttpAuthentication):
(WebKit::NetworkDataTaskCurl::tryProxyAuthentication):

• NetworkProcess/curl/NetworkDataTaskCurl.h:

Tools:

Fix WinCairo MiniBrowser behavior of authentication dialog.

• MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::didReceiveAuthenticationChallenge):

LayoutTests:

Added appropriate expected results for WebKit/WebKitLegacy of WinCairo port.

• platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt: Added.
• platform/wincairo/TestExpectations:
• platform/wincairo/http/tests/security/401-logout/401-logout-expected.txt: Added.

10:20 AM Changeset in webkit [242091] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[ContentChangeObserver] Move CheckForVisibilityChange to ContentChangeObserver class
​https://bugs.webkit.org/show_bug.cgi?id=195035
<rdar://problem/48389123>

Reviewed by Tim Horton.

Visibility checking logic belongs to ContentChangeObserver.

• page/ios/ContentChangeObserver.h:
• page/ios/ContentChangeObserver.mm:

(WebCore::elementImplicitVisibility):
(WebCore::ContentChangeObserver::StyleChange::StyleChange):
(WebCore::ContentChangeObserver::StyleChange::~StyleChange):

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):
(WebCore::elementImplicitVisibility): Deleted.
(WebCore::CheckForVisibilityChange::CheckForVisibilityChange): Deleted.
(WebCore::CheckForVisibilityChange::~CheckForVisibilityChange): Deleted.

10:14 AM Changeset in webkit [242090] by commit-queue@webkit.org

• 1 edit
  8 copies
  1 move
  17 adds
  3 deletes in trunk/LayoutTests

Split tests programmatic-scroll-iframe and scroll-iframe
​https://bugs.webkit.org/show_bug.cgi?id=195050

This patch splits some iOS frame scrolling tests into separate tests in order to make debugging
and test expectations easier to manage.

Patch by Frederic Wang <​fwang@igalia.com> on 2019-02-26
Reviewed by Antti Koivisto.

• fast/scrolling/ios/programmatic-scroll-iframe-001-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-001.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-002-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-002.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-003-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-003.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-004-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-004.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-005-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-005.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-006-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-006.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-007-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-007.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-008-expected.html: Copied from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-008.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe-009-expected.html: Renamed from LayoutTests/fast/scrolling/ios/programmatic-scroll-iframe-expected.html.
• fast/scrolling/ios/programmatic-scroll-iframe-009.html: Added.
• fast/scrolling/ios/programmatic-scroll-iframe.html: Removed.
• fast/scrolling/ios/scroll-iframe-001-expected.html: Added.
• fast/scrolling/ios/scroll-iframe-001.html: Added.
• fast/scrolling/ios/scroll-iframe-002-expected.html: Added.
• fast/scrolling/ios/scroll-iframe-002.html: Added.
• fast/scrolling/ios/scroll-iframe-003-expected.html: Added.
• fast/scrolling/ios/scroll-iframe-003.html: Added.
• fast/scrolling/ios/scroll-iframe-004-expected.html: Added.
• fast/scrolling/ios/scroll-iframe-004.html: Added.
• fast/scrolling/ios/scroll-iframe-expected.html: Removed.
• fast/scrolling/ios/scroll-iframe.html: Removed.

10:09 AM Changeset in webkit [242089] by youenn@apple.com

• 4 edits in trunk

WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
​https://bugs.webkit.org/show_bug.cgi?id=195028
<rdar://problem/48243733>

Reviewed by Eric Carlson.

Source/WebKit:

Covered by API test.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

10:01 AM Changeset in webkit [242088] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

9:13 AM Changeset in webkit [242087] by Ryan Haddad

• 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r242071.

Breaks internal builds.

Reverted changeset:

"Add some randomness into the StructureID."
​https://bugs.webkit.org/show_bug.cgi?id=194989
​https://trac.webkit.org/changeset/242071

8:28 AM Changeset in webkit [242086] by commit-queue@webkit.org

• 76 edits
  1 add in trunk/LayoutTests

Synchronize MathML WPT tests
​https://bugs.webkit.org/show_bug.cgi?id=195048

This imports changes to the documentation and spec references for MathML.
It also imports a new test for href currently disabled due to bug 187039.

Patch by Frederic Wang <​fwang@igalia.com> on 2019-02-26
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

• web-platform-tests/mathml/README.md:
• web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html:
• web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html:
• web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-2.html:
• web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html:
• web-platform-tests/mathml/relations/css-styling/color-1.html:
• web-platform-tests/mathml/relations/css-styling/display-1.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-1.html:
• web-platform-tests/mathml/relations/css-styling/lengths-1.html:
• web-platform-tests/mathml/relations/css-styling/lengths-2.html:
• web-platform-tests/mathml/relations/css-styling/lengths-3.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-script.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html:
• web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html:
• web-platform-tests/mathml/relations/css-styling/visibility-1.html:
• web-platform-tests/mathml/relations/html5-tree/class-1.html:
• web-platform-tests/mathml/relations/html5-tree/class-2.html:
• web-platform-tests/mathml/relations/html5-tree/color-attributes-1.html:
• web-platform-tests/mathml/relations/html5-tree/display-1.html:
• web-platform-tests/mathml/relations/html5-tree/dynamic-1.html:
• web-platform-tests/mathml/relations/html5-tree/href-click-1.html:
• web-platform-tests/mathml/relations/html5-tree/href-click-2.html:
• web-platform-tests/mathml/relations/html5-tree/href-click-3.html: Added.
• web-platform-tests/mathml/relations/html5-tree/integration-point-1.html:
• web-platform-tests/mathml/relations/html5-tree/integration-point-2.html:
• web-platform-tests/mathml/relations/html5-tree/integration-point-3.html:
• web-platform-tests/mathml/relations/html5-tree/required-extensions-1.html:
• web-platform-tests/mathml/relations/html5-tree/required-extensions-2.html:
• web-platform-tests/mathml/relations/html5-tree/unique-identifier-1.html:
• web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html:
• web-platform-tests/mathml/relations/html5-tree/unique-identifier-3.html:
• web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
• web-platform-tests/mathml/relations/text-and-math/use-typo-metrics-1.html:
• web-platform-tests/mathml/tools/mathvariant-transforms.py:
• web-platform-tests/mathml/tools/utils/w3c-import.log:

LayoutTests:

• TestExpectations: Disable the new href test since testdriver.js is not supported.

7:29 AM Changeset in webkit [242085] by fred.wang@free.fr

• 60 edits
  4 moves
  21 adds
  19 deletes in trunk/LayoutTests

Export MathML fraction tests to WPT
​https://bugs.webkit.org/show_bug.cgi?id=194436

LayoutTests/imported/w3c:

This is just an import of the current MathML WPT tests. It includes fraction tests from
WebKit that were exported in [1]. Some test results have whitespace change, due to [2].

[1] ​https://github.com/web-platform-tests/wpt/pull/15301
[2] ​https://github.com/web-platform-tests/wpt/commit/e2dd57c3f273468b3c6a087978c531dcd00933de

Patch by Frederic Wang <​fwang@igalia.com> on 2019-02-26
Reviewed by Manuel Rego Casasnovas.

• resources/resource-files.json:
• web-platform-tests/mathml/META.yml: Added.
• web-platform-tests/mathml/OWNERS: Removed.
• web-platform-tests/mathml/README.md:
• web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-notref.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-notref.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt:
• web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001-expected.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html: Added.
• web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html:
• web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt:
• web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html:
• web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt:
• web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
• web-platform-tests/mathml/presentation-markup/spaces/space-2.html:
• web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log:
• web-platform-tests/mathml/presentation-markup/tables/table-axis-height-expected.txt:
• web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html:
• web-platform-tests/mathml/presentation-markup/tables/w3c-import.log:
• web-platform-tests/mathml/relations/css-styling/display-1.html:
• web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt:
• web-platform-tests/mathml/relations/css-styling/displaystyle-1.html:
• web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt:
• web-platform-tests/mathml/relations/css-styling/lengths-3.html:
• web-platform-tests/mathml/relations/css-styling/w3c-import.log:
• web-platform-tests/mathml/relations/html5-tree/class-2.html:
• web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
• web-platform-tests/mathml/relations/html5-tree/display-1.html:
• web-platform-tests/mathml/relations/html5-tree/href-click-1.html:
• web-platform-tests/mathml/relations/html5-tree/href-click-2.html:
• web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html:
• web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
• web-platform-tests/mathml/relations/text-and-math/w3c-import.log:
• web-platform-tests/mathml/tools/utils/w3c-import.log:
• web-platform-tests/mathml/tools/w3c-import.log:
• web-platform-tests/mathml/w3c-import.log:

LayoutTests:

We removed some fraction tests that have equivalent WPT tests.
Some of them were actually exported from WebKit to WPT in [1]
We also move tests for crashes/asserts/hangs to the top mathml/ directory.

[1] ​https://github.com/web-platform-tests/wpt/pull/15301

Patch by Frederic Wang <​fwang@igalia.com> on 2019-02-26
Reviewed by Manuel Rego Casasnovas.

• mathml/fractions-invalid-expected.html: Moved to parent directory.
• mathml/fractions-invalid.html: Ditto.
• mathml/mfrac-nested-expected.txt: Ditto.
• mathml/mfrac-nested.html: Ditto.
• mathml/presentation/fractions-box-expected.html: Removed. This is better tested by WPT

tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html.

• mathml/presentation/fractions-box.html: Removed. Ditto.
• mathml/presentation/fractions-color-expected-mismatch.html: Removed. This is exported as

frac-color-001.html.

• mathml/presentation/fractions-color.html: Removed. Ditto.
• mathml/presentation/fractions-linethickness-expected.html: Removed. Covered by WPT tests

frac-linethickness-*.html.

• mathml/presentation/fractions-linethickness.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness1.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness2-expected.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness2.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Removed. Ditto.
• mathml/presentation/mfrac-linethickness3.html: Removed. Ditto.
• mathml/presentation/fractions-mrow-expected.html: Removed. Exported as frac-mrow-001.html.
• mathml/presentation/fractions-mrow.html: Removed. Ditto.
• mathml/presentation/fractions-numalign-denomalign-expected.html: Removed. Exported as

frac-numalign-denomalign-001.html.

• mathml/presentation/fractions-numalign-denomalign.html: Removed. Ditto.
• mathml/presentation/fractions-vertical-alignment-expected.html: Removed. This is better

tests by WPT tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html.

• mathml/presentation/fractions-vertical-alignment.html: Removed. Ditto.

7:13 AM WebKitGTK/2.24.x edited by Philippe Normand

(diff)

7:11 AM Changeset in webkit [242084] by Philippe Normand

• 2 edits in trunk/Source/WebCore

[EGL] Runtime support for RGB565 pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=194817

Reviewed by Carlos Garcia Campos.

Currently our graphics pipeline always relies on a ARGB8888 (32
bpp) pixel configuration. On some low-end (old) embedded platforms
the graphics driver is sometimes optimized for 16 bpp
configurations, such as RGB565. On those platforms the application
can now set the WEBKIT_EGL_PIXEL_LAYOUT environment variable to
"RGB565" to adjust to the best pixel configuration supported by
the screen and graphics driver.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::getEGLConfig):

2:52 AM WebKitGTK/2.24.x edited by Philippe Normand

(diff)

2:28 AM Changeset in webkit [242083] by guijemont@igalia.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix compilation on 32-bit platforms after r242071
​https://bugs.webkit.org/show_bug.cgi?id=195042

Reviewed by Carlos Garcia Campos.

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitLoadStructure):

1:55 AM Changeset in webkit [242082] by Carlos Garcia Campos

• 50 edits
  3 adds in trunk

[WPE] Add API for webview background color configuration
​https://bugs.webkit.org/show_bug.cgi?id=192305

Source/WebCore:

Reviewed by Michael Catanzaro.

Adapt the FrameView API to allow a default non-white background color.

• page/Frame.cpp:

(WebCore::Frame::createView): Replace isTransparent argument with a background color one.

• page/Frame.h:
• page/FrameView.cpp:

(WebCore::FrameView::recalculateBaseBackgroundColor): Use Color::transparent if m_isTransparent is true.
(WebCore::FrameView::updateBackgroundRecursively): Allow the fallback background color to be non-white, this is
used only in non-dark-mode-css build configurations.

• page/FrameView.h:
• testing/Internals.cpp:

(WebCore::Internals::setViewIsTransparent): Use Color::transparent if transparent is true.

Source/WebKit:

Reviewed by Michael Catanzaro.

In the case of WPE we need to send the background color to the web process to be used as the background color of
the page. This patch adapts the GTK+ implementation to do the same, since it's a lot simpler. The patch also
removes the SetDrawsBackground message in favor of the new SetBackgroundColor message that receives an optional
color.

• PlatformWPE.cmake: Add new WPE API for WebKitColor boxed type.
• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext): Remove background rendering and opacity handling.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree): Remove drawsBakground and always clear the context with
transparent color.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const): Replace drawsBackground with backgroundColor.
(WebKit::WebPageCreationParameters::decode): Ditto.

• Shared/WebPageCreationParameters.h:
• SourcesWPE.txt:
• UIProcess/API/glib/WebKitWebView.cpp:
• UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkit_web_view_set_background_color):
(webkit_web_view_get_background_color):

• UIProcess/API/wpe/WebKitColor.cpp: Added.

(webkit_color_copy):
(webkit_color_free):
(webkitColorToWebCoreColor):
(webkitColorFillFromWebCoreColor):
(webkit_color_parse):

• UIProcess/API/wpe/WebKitColor.h: Added.
• UIProcess/API/wpe/WebKitColorPrivate.h: Added.
• UIProcess/API/wpe/WebKitWebView.h: Implement webkit_web_view_set_background_color API.
• UIProcess/API/wpe/WebKitWebViewWPE.cpp: Ditto.

(webkit_web_view_set_background_color):
(webkit_web_view_get_background_color):

• UIProcess/API/wpe/docs/wpe-0.1-sections.txt: Add new symbols.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDrawsBackground): Set a transparent background color when false is passed.
(WebKit::WebPageProxy::setBackgroundColor): Send background color to the WebProcess.
(WebKit::WebPageProxy::creationParameters): Replace drawsBackground with backgroundColor.

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::drawsBackground const):
(WebKit::WebPageProxy::backgroundColor const):

• UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate): Remove GTK+ code to handle background color.

• UIProcess/gtk/AcceleratedBackingStore.cpp:
• UIProcess/gtk/AcceleratedBackingStore.h: Make paint() pure virtual and remove the implementation.
• UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::AcceleratedBackingStoreWayland::paint): Dot not call AcceleratedBackingStore::paint() now that is pure virtual.

• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::paint): Ditto.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Use background color as provided by the
UIProcess when creating the FrameView.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:
• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::setIsDiscardable):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
• WebProcess/WebPage/DrawingArea.h:
• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display): Remove special case for transparent background.

• WebProcess/WebPage/LayerTreeHost.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setBackgroundColor): New API for background color configuration. Proxies to FrameView and DrawingArea.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::backgroundColor const): Read-only access to the current background color.

• WebProcess/WebPage/WebPage.messages.in: Replace SetDrawsBackground message with SetBackgroundColor.

Source/WebKitLegacy/win:

Patch by Philippe Normand <​pnormand@igalia.com> on 2019-02-26
Reviewed by Michael Catanzaro.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transitionToCommittedForNewPage): Create
FrameView with background color.

Tools:

Patch by Philippe Normand <​pnormand@igalia.com> on 2019-02-26
Reviewed by Michael Catanzaro.

• MiniBrowser/wpe/main.cpp:

(main): Add a new option to configure the webview background
color. Example: --bg-color=transparent.

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewBackgroundColor): Enable background color API tests for WPE.
(beforeAll): Ditto.

12:50 AM Changeset in webkit [242081] by guijemont@igalia.com

• 5 edits
  2 adds in trunk

[JSC] Repeat string created from Array.prototype.join() take too much memory
​https://bugs.webkit.org/show_bug.cgi?id=193912

Reviewed by Saam Barati.

JSTests:

Added a test and a microbenchmark for corner cases of
Array.prototype.join() with an uninitialized array.

• microbenchmarks/array-prototype-join-uninitialized.js: Added.
• stress/array-prototype-join-uninitialized.js: Added.

(testArray):
(testABC):
(B):
(C):

Source/JavaScriptCore:

Added a fast case in Array.prototype.join when the array is
uninitialized.

• runtime/ArrayPrototype.cpp:

(JSC::canUseFastJoin):
(JSC::fastJoin):

• runtime/JSStringInlines.h:

(JSC::repeatCharacter): moved from StringPrototype.cpp

• runtime/StringPrototype.cpp:

12:14 AM Changeset in webkit [242080] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: navigation sidebar says "No Search Results" when a slow search is in progress
​https://bugs.webkit.org/show_bug.cgi?id=170631
<rdar://problem/29473874>

Reviewed by Joseph Pecoraro.

Keep a count of all the backend commands (increment when firing, decrement when a result is
sent back to the frontend). Once the count comes back to 0, attempt to show the "No Results"
placeholder, since we will have finished searching at that point. Since commands can be called
as a result of other commands, using Promise.all isn't possible.

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch):
(WI.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon): Deleted.
(WI.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder): Deleted.
Drive-by: replace bind calls with arrow functions, and use for-of loops.

• Localizations/en.lproj/localizedStrings.js:

12:11 AM Changeset in webkit [242079] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: if no auto-capture value is specified, don't force the input to have "0" as the value
​https://bugs.webkit.org/show_bug.cgi?id=194950
<rdar://problem/48276798>

Reviewed by Joseph Pecoraro.

Create a getter/setter for the value of the auto-capture frame count <input> so that all
code follows the same path.

If the <input> currently has no content and the frame count is 0, only set the placeholder.

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
(WI.CanvasOverviewContentView.prototype.get _recordingAutoCaptureFrameCountInputElementValue): Added.
(WI.CanvasOverviewContentView.prototype.set _recordingAutoCaptureFrameCountInputElementValue): Added.
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):

12:00 AM Changeset in webkit [242078] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Console: dragging a selection outside the selected element clears the selection
​https://bugs.webkit.org/show_bug.cgi?id=194660
<rdar://problem/46719239>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._mousemove):
Don't clear the selection if the target of the "mousemove" is outside of the view.

(WI.LogContentView.prototype._updateMessagesSelection):
Drive-by: clear the saved selected messages when we're just selecting a single message.