Context Navigation

← Previous Period
Next Period →

Timeline

Mar 12, 2019:

9:24 PM Changeset in webkit [242842] by Ross Kirsling

31 edits in trunk

[Win] Fix a slew of simple clang-cl warnings.
https://bugs.webkit.org/show_bug.cgi?id=195652

Reviewed by Don Olmstead.

Source/WebCore:

page/AutoscrollController.cpp:

(WebCore::AutoscrollController::handleMouseReleaseEvent): -Wswitch

platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::willSetupSslCtx):
(WebCore::CurlHandle::appendRequestHeaders): -Wunused-variable

platform/network/curl/CurlFormDataStream.cpp:

(WebCore::CurlFormDataStream::computeContentLength): -Wunused-variable

platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::CurlRequest): -Wreorder
(WebCore::CurlRequest::setupTransfer): -Wunused-variable

platform/network/curl/CurlSSLVerifier.cpp:

(WebCore::CurlSSLVerifier::CurlSSLVerifier):

platform/network/curl/CurlSSLVerifier.h: -Wunused-private-field
platform/win/LoggingWin.cpp:

(WebCore::logLevelString): -Wwritable-strings

rendering/RenderThemeWin.cpp: -Wunused-const-variable (x2)

(WebCore::RenderThemeWin::getThemeData): -Wswitch

Source/WebCore/PAL:

pal/win/LoggingWin.cpp:

(PAL::logLevelString): -Wwritable-strings

Source/WebKit:

NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): -Wswitch

Platform/IPC/win/ConnectionWin.cpp:

(IPC::Connection::readEventHandler): -Wunused-variable

Platform/win/LoggingWin.cpp:

(WebKit::logLevelString): -Wwritable-strings

UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess): -Wunused-variable

Source/WebKitLegacy/win:

Interfaces/AccessibleComparable.idl: -Wmissing-braces
Plugins/PluginDatabaseWin.cpp: -Wunused-function

(WebCore::addJavaPluginDirectory): Deleted.

WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder

WebCoreSupport/WebEditorClient.cpp:

(WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
(undoNameForEditAction): -Wswitch

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable

WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder

WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
WebError.cpp:

(WebError::WebError): -Wreorder

WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses

WebHistory.cpp: -Wunused-function (x5)

(areEqualOrClose): Deleted.
(addDayToSystemTime): Deleted.
(getDayBoundaries): Deleted.
(beginningOfDay): Deleted.
(dateKey): Deleted.

WebNotificationCenter.cpp:

(WebNotificationCenter::removeObserver): -Wunused-variable

WebView.cpp: -Wunused-function, -Wreorder

(WebView::addVisitedLinks): -Wunused-variable

Tools:

WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable

7:34 PM Changeset in webkit [242841] by ysuzuki@apple.com

3 edits
1 add in trunk

[JSC] OSR entry should respect abstract values in addition to flush formats
https://bugs.webkit.org/show_bug.cgi?id=195653

Reviewed by Mark Lam.

JSTests:

stress/osr-entry-locals-none.js: Added.

Source/JavaScriptCore:

Let's consider the following graph.

Block #0

...
27:< 2:loc13> JSConstant(JS|UseAsOther, StringIdent, Strong:String (atomic) (identifier): , StructureID: 42679, bc#10, ExitValid)
...
28:< 2:loc13> ArithPow(DoubleRep:@437<Double>, Int32:@27, Double|UseAsOther, BytecodeDouble, Exits, bc#10, ExitValid)
29:<!0:-> MovHint(DoubleRep:@28<Double>, MustGen, loc7, W:SideState, ClobbersExit, bc#10, ExitValid)
30:< 1:-> SetLocal(DoubleRep:@28<Double>, loc7(M<Double>/FlushedDouble), machine:loc6, W:Stack(-8), bc#10, exit: bc#14, ExitValid) predicting BytecodeDouble
...
73:<!0:-> Jump(MustGen, T:#1, W:SideState, bc#71, ExitValid)

Block #1 (bc#71): (OSR target) pred, #0

...

102:<!2:loc15> GetLocal(Check:Untyped:@400, Double|MustGen|PureInt, BytecodeDouble, loc7(M<Double>/FlushedDouble), machine:loc6, R:Stack(-8), bc#120, ExitValid) predicting BytecodeDouble

...

CFA at @28 says it is invalid since there are type contradiction (Int32:@27 v.s. StringIdent). So, of course, we do not propagate #0's type information to #1 since we become invalid state.
However, #1 is still reachable since it is an OSR target. Since #0 was only the predecessor of #1, loc7's type information becomes None at the head of #1.
Since loc7's AbstractValue is None, @102 GetLocal emits breakpoint. It is OK as long as OSR entry fails because AbstractValue validation requires the given value is None type.

The issue here is that we skipped AbstractValue validation when we have FlushFormat information. Since loc7 has FlushedDouble format, DFG OSR entry code does not validate it against AbstractValue,
which is None. Then, we hit the breakpoint emitted by @102.

This patch performs AbstractValue validation against values even if we have FlushFormat. We should correctly configure AbstractValue for OSR entry's locals too to avoid unnecessary OSR entry
failures in the future but anyway validating locals with AbstractValue is correct behavior here since DFGSpeculativeJIT relies on that.

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

7:31 PM Changeset in webkit [242840] by rniwa@webkit.org

12 edits in trunk/Source

Move the code for determining the need for touch bar quirks to Quirks class
https://bugs.webkit.org/show_bug.cgi?id=195654

Reviewed by Brent Fulgham.

Source/WebCore:

Moved the code to determine whether the touch bar quirks are needed or not from WebKit2.

WebCore.xcodeproj/project.pbxproj:
page/Quirks.cpp:

(WebCore::Quirks::isTouchBarUpdateSupressedForHiddenContentEditable const):
(WebCore::Quirks::isNeverRichlyEditableForTouchBar const):

page/Quirks.h:

Source/WebKit:

Moved the code to determine whether touch bar quirks are needed or not to WebCore.

Also renamed HiddenContentEditableQuirk to IsTouchBarUpdateSupressedForHiddenContentEditable
and PlainTextQuirk to NeverRichlyEditableForTouchBar.

UIProcess/Cocoa/WebViewImpl.h:

(WebKit::WebViewImpl::isRichlyEditableForTouchBar): Renamed.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateTouchBar):
(WebKit::WebViewImpl::candidateListTouchBarItem const):
(WebKit::WebViewImpl::isRichlyEditableForTouchBar const): Renamed from isRichlyEditable.
(WebKit::WebViewImpl::textTouchBar const):
(WebKit::WebViewImpl::updateTextTouchBar):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIsTouchBarUpdateSupressedForHiddenContentEditable): Renamed from
setNeedsHiddenContentEditableQuirk.
(WebKit::WebPageProxy::setIsNeverRichlyEditableForTouchBar): Renamed from setNeedsPlainTextQuirk.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isTouchBarUpdateSupressedForHiddenContentEditable const): Renamed from
needsHiddenContentEditableQuirk.
(WebKit::WebPageProxy::isNeverRichlyEditableForTouchBar const): Renamed from needsPlainTextQuirk.

UIProcess/WebPageProxy.messages.in: Renamed the IPC messages.
WebProcess/WebPage/WebPage.cpp:

(WebKit::needsHiddenContentEditableQuirk): Deleted. Moved to WebCore.
(WebKit::needsPlainTextQuirk): Deleted. Moved to WebCore.
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::didChangeSelection):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage):

6:33 PM Changeset in webkit [242839] by Justin Fan

53 edits
1 copy
5 moves
6 deletes in trunk

[Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
https://bugs.webkit.org/show_bug.cgi?id=195518
<rdar://problem/46322356>

Reviewed by Myles C. Maxfield.

Source/WebCore:

Upgrade the implementation of GPURenderPipelineDescriptor and GPURenderPipeline and match the updated Web GPU API.
Add stubs for GPUColorStateDescriptor so attachment format can be provided by GPURenderPipelineDescriptor.

All affected Web GPU tests updated to cover existing behavior.

Update file names and symbols:

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:

Updates to GPURenderPipeline, GPURenderPipelineDescriptor, and its components:

Modules/webgpu/GPUColorStateDescriptor.idl: Added. Provide the expected texture format of the render pipeline's color attachments.
Modules/webgpu/GPUInputStateDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUInputStateDescriptor.idl.
Modules/webgpu/GPUTextureFormat.idl: Update the existing values to match the new style.
Modules/webgpu/GPUVertexAttributeDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUVertexAttributeDescriptor.idl.
Modules/webgpu/GPUVertexInputDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUVertexInputDescriptor.idl.
Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createPipelineLayout const): Remove unnecessary comment.
(WebCore::WebGPUDevice::createRenderPipeline const): Descriptor validation and conversion moved into WebGPURenderPipelineDescriptor.
(WebCore::validateAndConvertPipelineStage): Deleted.

Modules/webgpu/WebGPUDevice.h: create* functions should not return nullable.
Modules/webgpu/WebGPUIndexFormat.h: Removed. Moved into GPUInputStateDescriptor.idl.
Modules/webgpu/WebGPUInputStateDescriptor.h: Removed.
Modules/webgpu/WebGPUInputStepMode.idl: Removed. Moved into GPUVertexInputDescriptor.idl.
Modules/webgpu/WebGPUPipelineLayout.h:

(WebCore::WebGPUPipelineLayout::pipelineLayout): Getters should return raw references.

Modules/webgpu/WebGPUPipelineStageDescriptor.h: Now shares a common base with GPUPipelineStageDescriptor.
Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::create):
(WebCore::WebGPURenderPipeline::WebGPURenderPipeline):

Modules/webgpu/WebGPURenderPipeline.h: Now internally nullable.

(WebCore::WebGPURenderPipeline::renderPipeline const):
(WebCore::WebGPURenderPipeline::renderPipeline): Deleted.

Modules/webgpu/WebGPURenderPipelineDescriptor.cpp:

(WebCore::WebGPUPipelineStageDescriptor::asGPUPipelineStageDescriptor const): Validate and convert a WebGPUPipelineStageDescriptor to GPU version.
(WebCore::WebGPURenderPipelineDescriptor::asGPURenderPipelineDescriptor const): Ditto for WebGPURenderPipelineDescriptor.

Modules/webgpu/WebGPURenderPipelineDescriptor.h: Now shares a base class and some instance variables with GPURenderPipelineDescriptor.
Modules/webgpu/WebGPURenderPipelineDescriptor.idl: Update GPUPrimitiveTopology for new style and add colorStates.
Modules/webgpu/WebGPUShaderModule.idl: Small pilot to test using InterfaceName to easily rename DOM-facing interfaces.
Modules/webgpu/WebGPUVertexAttributeDescriptor.h: Removed.
Modules/webgpu/WebGPUVertexFormat.idl: Removed. Moved and updated in GPUVertexAttributeDescriptor.idl.
Modules/webgpu/WebGPUVertexInputDescriptor.h: Removed.
platform/graphics/gpu/GPUInputStateDescriptor.h:
platform/graphics/gpu/GPUPipelineStageDescriptor.h:

(WebCore::GPUPipelineStageDescriptor::GPUPipelineStageDescriptor):

platform/graphics/gpu/GPURenderPipelineDescriptor.h: Add shared base class for Web/GPURenderPipelineDescriptor.

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):

platform/graphics/gpu/GPUTextureFormat.h:
platform/graphics/gpu/GPUVertexAttributeDescriptor.h:
platform/graphics/gpu/GPUVertexInputDescriptor.h:
platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::setFunctionsForPipelineDescriptor): Make fragment required since descriptor validation fails if fragment function is not found right now.
(WebCore::mtlVertexFormatForGPUVertexFormat): Renamed from validateAndConvertVertexFormatToMTLVertexFormat.
(WebCore::mtlStepFunctionForGPUInputStepMode): Renamed from validateAndConvertStepModeToMTLStepFunction
(WebCore::trySetInputStateForPipelineDescriptor):
(WebCore::trySetColorStatesForColorAttachmentArray):
(WebCore::tryCreateMtlRenderPipelineState):
(WebCore::GPURenderPipeline::create):
(WebCore::validateAndConvertVertexFormatToMTLVertexFormat): Deleted.
(WebCore::validateAndConvertStepModeToMTLStepFunction): Deleted.

platform/graphics/gpu/cocoa/GPUUtilsMetal.mm:

(WebCore::platformTextureFormatForGPUTextureFormat):

platform/graphics/gpu/GPUColorStateDescriptor.h: Added.

Misc:

Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:

(WebCore::WebGPUProgrammablePassEncoder::setPipeline):

Modules/webgpu/WebGPUProgrammablePassEncoder.h:
platform/graphics/gpu/GPUProgrammablePassEncoder.h:
platform/graphics/gpu/GPURenderPassEncoder.h:
platform/graphics/gpu/GPURenderPipeline.h:

(WebCore::GPURenderPipeline::primitiveTopology const):

platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:

(WebCore::GPURenderPassEncoder::setPipeline):
(WebCore::primitiveTypeForGPUPrimitiveTopology):

Tools:

DumpRenderTree/DerivedSources-input.xcfilelist:
DumpRenderTree/DerivedSources-output.xcfilelist:

LayoutTests:

Update all tests with new enum styles and re-namings, and specify the format of the color attachment.

webgpu/blit-commands.html:
webgpu/buffer-command-buffer-races.html:
webgpu/buffer-resource-triangles.html:
webgpu/depth-enabled-triangle-strip.html:
webgpu/js/webgpu-functions.js:

(createBasicSwapChain):
(createBasicDepthTexture):

webgpu/render-pipelines-expected.txt:
webgpu/render-pipelines.html: Remove error cases, as createRenderPipeline no longer returns a null value on failure.
webgpu/shader-modules.html:
webgpu/texture-triangle-strip.html:
webgpu/textures-textureviews.html:
webgpu/vertex-buffer-triangle-strip.html:

6:26 PM Changeset in webkit [242838] by msaboff@apple.com

3 edits
1 add in trunk

REGRESSION (iOS 12.2): Webpage using CoffeeScript crashes
https://bugs.webkit.org/show_bug.cgi?id=195613

Reviewed by Mark Lam.

JSTests:

New regression test.

stress/regexp-backref-inbounds.js: Added.

(testRegExp):

Source/JavaScriptCore:

The bug here is in Yarr JIT backreference matching code. We are incorrectly
using a checkedOffset / inputPosition correction when checking for the available
length left in a string. It is improper to do these corrections as a backreference's
match length is based on what was matched in the referenced capture group and not
part of the checkedOffset and inputPosition computed when we compiled the RegExp.
In some cases, the resulting incorrect calculation would allow us to go past
the subject string's length. Removed these adjustments.

After writing tests for the first bug, found another bug where the non-greedy
backreference backtracking code didn't do an "are we at the end of the input?" check.
This caused an infinite loop as we'd jump from the backtracking code back to
try matching one more backreference, fail and then backtrack.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateBackReference):
(JSC::Yarr::YarrGenerator::backtrackBackReference):

6:19 PM Changeset in webkit [242837] by bshafiei@apple.com

1 copy in tags/Safari-607.1.40.1.4

Tag Safari-607.1.40.1.4.

5:36 PM Changeset in webkit [242836] by jiewen_tan@apple.com

6 edits in trunk/Source/WebKit

Add WebFrameProxy::loadData
https://bugs.webkit.org/show_bug.cgi?id=195647
<rdar://problem/48826856>

Reviewed by Youenn Fablet.

This patch adds WebFrameProxy::loadData which is a simplified version of WebPageProxy::loadData that
loads substitute data to an iframe. This is needed by the Load Optimizer.

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::loadData):

UIProcess/WebFrameProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataInFrame):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:15 PM Changeset in webkit [242835] by rniwa@webkit.org

2 edits in trunk/Source/WebKitLegacy/mac

Remove a site specific hack for AppleConnect plugin
https://bugs.webkit.org/show_bug.cgi?id=195643

Reviewed by Simon Fraser.

r66437 added a workaround for AppleConnect plugin.

Remove this code since Safari doesn't even use WebKitLegacy anymore,
and other WebKit clients support AppleConnect plugins.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):

5:12 PM Changeset in webkit [242834] by Alan Bujtas

3 edits in trunk/Source/WebCore

[ContentChangeObserver] Reset state when touchStart does not turn into click.
https://bugs.webkit.org/show_bug.cgi?id=195603
<rdar://problem/48796582>

Reviewed by Simon Fraser.

Add reset() function to assert and reset the current state.

page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::willNotProceedWithClick):
(WebCore::ContentChangeObserver::adjustObservedState):

page/ios/ContentChangeObserver.h:

4:51 PM Changeset in webkit [242833] by Wenson Hsieh

9 edits
2 adds in trunk

[iOS] Input view sometimes flickers when blurring and refocusing an element
https://bugs.webkit.org/show_bug.cgi?id=195639
<rdar://problem/48735337>

Reviewed by Tim Horton.

Source/WebKit:

On iOS, if a focused element is blurred and immediately refocused in the scope of user interaction, we will end
up reloading interaction state (input views, autocorrection contexts, etc.) in the UI process. On certain well-
trafficked websites, this results in the input view and input accessory view flickering (or more egregiously,
scrolling to re-reveal the focused element) when changing selection.

To fix the issue, this patch refactors some focus management logic to suppress sending focused element updates
to the UI process in the case where the same element is being blurred and immediately refocused. To do this, we
track the most recently blurred element and bail when the recently blurred element is identical to the newly
focused element. See below for more detail.

Test: fast/forms/ios/keyboard-stability-when-refocusing-element.html

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _elementDidBlur]):

Update the web process' notion of whether an input view is showing. Importantly, this accounts for decisions
made by _WKUIDelegate. See below for more details.

(isAssistableInputType): Deleted.

Removed this helper function; this was only used in one place as a sanity check that the focused element's type
is not none, right before attempting to show an input view. Instead, we can just check the focused element's
type directly against InputType::None in the if statement of the early return.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setIsShowingInputViewForFocusedElement):

Add a hook to notify the web process when an input view is showing or not (see below for more detail).

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::shouldDispatchUpdateAfterFocusingElement const):

Add a helper to determine whether we notify the UI process about a newly focused element. On macOS, this is true
only when the new focused element is neither the currently focused element, nor the focused element that was
just blurred. On iOS, we have an additional constraint that when the input view is not showing, we still need to
notify the UI process, since the UI process might want to begin showing the keyboard for an element that has
only been programmatically focused, for which we aren't currently showing the input view.

(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):

Replace a couple of existing member variables in WebPage used for focus management:

Replace m_hasPendingBlurNotification with m_recentlyBlurredElement, a RefPtr to the Element that is being

blurred. Behavior here is the same as before (i.e. having a pending blur notification is equivalent to
having recently blurred a focused element). However, this allows us to check newly focused elements against
the recently blurred element in WebPage::elementDidFocus().

Replace m_isFocusingElementDueToUserInteraction with m_isShowingInputViewForFocusedElement. The flag

m_isFocusingElementDueToUserInteraction was originally added to fix <webkit.org/b/146735>, by ensuring that
we don't send redundant ElementDidFocus (formerly, StartAssistingNode) messages to the UI process even when
the keyboard is already up. In these simpler times, user interaction when focusing an element was equivalent
to showing an input view for the focused element. However, in today's world, there are a variety of reasons
why we might or might not show an input view for a given element (including, but not limited to activity
state changes and decisions made by _WKInputDelegate). As such, it doesn't make sense to continue relying on
m_isFocusingElementDueToUserInteraction in this early return. Instead, have the UI process propagate a
message back to the web process, to let it know whether there is a keyboard showing, and use this flag
instead.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setIsShowingInputViewForFocusedElement):

LayoutTests:

Add a test to ensure that the form control interaction doesn't stop and start again when blurring and focusing
an editable element.

fast/forms/ios/keyboard-stability-when-refocusing-element-expected.txt: Added.
fast/forms/ios/keyboard-stability-when-refocusing-element.html: Added.

3:49 PM Changeset in webkit [242832] by commit-queue@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r242825.
https://bugs.webkit.org/show_bug.cgi?id=195648

"Broke webkitpy tests with my change to
lldb_dump_class_layout.py" (Requested by rmorisset on
#webkit).

Reverted changeset:

"Alter Tools/Scripts/dump-class-layout to be able to dump all
classes with suspicious padding"
https://bugs.webkit.org/show_bug.cgi?id=195573
https://trac.webkit.org/changeset/242825

3:42 PM Changeset in webkit [242831] by timothy@apple.com

5 edits in trunk/Source/WebCore

Expose document attributes and body background color through HTMLConverter.
https://bugs.webkit.org/show_bug.cgi?id=195636
rdar://problem/45055697

Reviewed by Tim Horton.

Source/WebCore:

editing/cocoa/HTMLConverter.h:
editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert):
(WebCore::attributedStringFromRange):
(WebCore::attributedStringFromSelection):
(WebCore::attributedStringBetweenStartAndEnd):

Source/WebCore/PAL:

pal/spi/cocoa/NSAttributedStringSPI.h:

(NSBackgroundColorDocumentAttribute): Added.

3:35 PM Changeset in webkit [242830] by Antti Koivisto

3 edits in trunk/Source/WebCore

Compositing layer that renders two positioned elements should not hit test
https://bugs.webkit.org/show_bug.cgi?id=195371
<rdar://problem/48649586>

Reviewed by Simon Fraser.

Followup to fix the test case (fast/scrolling/ios/overflow-scroll-overlap-2.html)

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setEventRegion):

Revert a last minute change (that was done to fix a Mac displaylist test).

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Compute the region on iOS only for now (it is not used on other platforms).

2:47 PM Changeset in webkit [242829] by Devin Rousso

7 edits
1 copy in trunk/Source/WebInspectorUI

Web Inspector: Sources: allow image collections to be filtered by type
https://bugs.webkit.org/show_bug.cgi?id=195630

Reviewed by Matt Baker.

UserInterface/Views/ResourceCollectionContentView.js:

(WI.ResourceCollectionContentView):
(WI.ResourceCollectionContentView.prototype.get navigationItems): Added.
(WI.ResourceCollectionContentView.prototype.contentViewAdded):
(WI.ResourceCollectionContentView.prototype.contentViewRemoved): Added.
(WI.ResourceCollectionContentView.prototype._updateImageTypeScopeBar): Added.
(WI.ResourceCollectionContentView.prototype._handleImageTypeSelectionChanged): Added.

UserInterface/Views/ResourceCollectionContentView.css: Asdded.

(.resource-collection-image-type-scope-bar.default-item-selected):

UserInterface/Views/CollectionContentView.css:

(.content-view.collection > .content-view[hidden]): Added.

UserInterface/Views/ScopeBarItem.js:

(WI.ScopeBarItem.prototype.set hidden):

UserInterface/Views/MultipleScopeBarItem.js:

(WI.MultipleScopeBarItem.prototype.set scopeBarItems):
(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
(WI.MultipleScopeBarItem.prototype.get _visibleScopeBarItems): Added.
(WI.MultipleScopeBarItem.prototype._selectElementSelectionChanged):
(WI.MultipleScopeBarItem.prototype._handleItemHiddenChanged): Added.
Dispatch an event when an item is hidden so that any owner WI.MultipleScopeBarItem can
rerender it's <select> without that item.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:

2:03 PM Changeset in webkit [242828] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Unreviewed, rolling out r242747.
https://bugs.webkit.org/show_bug.cgi?id=195641

Performance measurement is difficult in this period, rolling
out it and rolling in later to isolate it from the other
sensitive patches (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] Make StaticStringImpl & StaticSymbolImpl actually
static"
https://bugs.webkit.org/show_bug.cgi?id=194212
https://trac.webkit.org/changeset/242747

1:58 PM Changeset in webkit [242827] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] Show status bubbles while the patch is waiting in queue
https://bugs.webkit.org/show_bug.cgi?id=195618

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are
enabled in initial deployment.
(StatusBubble._build_bubble): Display bubble even when build hasn't started.
(StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
(StatusBubble.get_builds_for_queue): Get all builds for a given queue.
(StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
(StatusBubble._build_bubbles_for_patch):

1:57 PM Changeset in webkit [242826] by dino@apple.com

3 edits
2 adds in trunk

[WebGL] WebGLBuffer can be too large
https://bugs.webkit.org/show_bug.cgi?id=195068
<rdar://problem/48414289>

Reviewed by Antoine Quint.

Source/WebCore:

When creating an element array buffer, make sure to
test against the maximum size of an ArrayBuffer, rather
than just assume it can be created.

Test: fast/canvas/webgl/largeBuffer.html

html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::associateBufferDataImpl):

LayoutTests:

fast/canvas/webgl/largeBuffer-expected.txt: Added.
fast/canvas/webgl/largeBuffer.html: Added.

1:55 PM Changeset in webkit [242825] by rmorisset@apple.com

3 edits in trunk/Tools

Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
https://bugs.webkit.org/show_bug.cgi?id=195573

Reviewed by Simon Fraser.

Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.

Scripts/dump-class-layout:

(main):

lldb/lldb_dump_class_layout.py:

(ClassLayout.init):
(ClassLayout._compute_padding_recursive):
(LLDBDebuggerInstance.dump_layout_for_classname):
(LLDBDebuggerInstance):
(LLDBDebuggerInstance.dump_all_wasteful_layouts):
(LLDBDebuggerInstance.layout_for_classname): Deleted.

1:40 PM Changeset in webkit [242824] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

More attempts at build fixing.

UIProcess/ios/WKActionSheetAssistant.mm:

Yet more.

1:32 PM Changeset in webkit [242823] by Chris Dumez

7 edits
1 add in trunk

Device Orientation access permission should be denied unless explicitly granted by the client
https://bugs.webkit.org/show_bug.cgi?id=195625

Reviewed by Youenn Fablet.

Source/WebKit:

Device Orientation access permission should be denied unless explicitly granted by the client.
Previously, it was granted by default.

UIProcess/API/APIUIClient.h:

(API::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

Tools:

add API test coverage.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.

(-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
(-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
(-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
(runDeviceOrientationTest):
(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):

1:17 PM Changeset in webkit [242822] by Kocsen Chung

2 edits in branches/safari-607.1.40.0-branch/Source/WebCore

Apply patch. rdar://problem/48795264

1:10 PM Changeset in webkit [242821] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
https://bugs.webkit.org/show_bug.cgi?id=192947
<rdar://problem/46886779>

Reviewed by Devin Rousso.

UserInterface/Base/Main.js:

(WI._showSettingsTab):

1:05 PM Changeset in webkit [242820] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: provide node context menu items for event listeners sorted by node
https://bugs.webkit.org/show_bug.cgi?id=195633

Reviewed by Matt Baker.

UserInterface/Base/DOMUtilities.js:

(WI.linkifyNodeReferenceElement):
(WI.bindInteractionsForNodeToElement): Added.
Split logic for adding event listeners into a separate function so it can be used on
existing DOM without modifying it.

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):

12:37 PM Changeset in webkit [242819] by jer.noble@apple.com

2 edits in trunk/Tools

Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
https://bugs.webkit.org/show_bug.cgi?id=195137
<rdar://problem/48810307>

Reviewed by Eric Carlson.

TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:

(TestWebKitAPI::TEST):

12:36 PM Changeset in webkit [242818] by sihui_liu@apple.com

7 edits in trunk

Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-*-event-exception.html are failing
https://bugs.webkit.org/show_bug.cgi?id=195581

LayoutTests/imported/w3c:

Updated test expectations to PASS.

Reviewed by Brady Eidson.

web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt:
web-platform-tests/IndexedDB/fire-success-event-exception-expected.txt:
web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception-expected.txt:

Source/WebCore:

Reviewed by Brady Eidson.

Uncaught exceptions should be handled after IDBRequest dispatches events so that IDBTransaction would stay
active during event dispatch.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

Modules/indexeddb/IDBRequest.h:

12:34 PM Changeset in webkit [242817] by aakash_jain@apple.com

4 edits in trunk/Tools

[ews-build] Change urls from uat to production
https://bugs.webkit.org/show_bug.cgi?id=195566

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-app/ews/config.py:
BuildSlaveSupport/ews-build/events.py:
BuildSlaveSupport/ews-build/steps.py:

12:32 PM Changeset in webkit [242816] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-build] change max_builds for local-worker to 1
https://bugs.webkit.org/show_bug.cgi?id=195568

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/loadConfig.py:

12:28 PM Changeset in webkit [242815] by sihui_liu@apple.com

4 edits in trunk

Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=195570

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Updated test expectation to PASS.

web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt:

Source/WebCore:

IDBRequest result should be undefined if it is never set.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):

12:18 PM Changeset in webkit [242814] by Antti Koivisto

3 edits in trunk/Source/WebKit

[iOS] Enable asynchronous frame scrolling by default
https://bugs.webkit.org/show_bug.cgi?id=195622
<rdar://problem/48658028>

Reviewed by Simon Fraser

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.h:

12:16 PM Changeset in webkit [242813] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed, fix a typo in TestExpecations.

platform/mac/TestExpectations:

12:07 PM Changeset in webkit [242812] by rmorisset@apple.com

35 edits in trunk/Source

A lot more classes have padding that can be reduced by reordering their fields
https://bugs.webkit.org/show_bug.cgi?id=195579

Reviewed by Mark Lam.

Source/bmalloc:

bmalloc/Heap.h:
bmalloc/Scavenger.h:

Source/JavaScriptCore:

assembler/LinkBuffer.h:
dfg/DFGArrayifySlowPathGenerator.h:

(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):

dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

dfg/DFGGraph.h:
dfg/DFGNode.h:

(JSC::DFG::SwitchData::SwitchData):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

dfg/DFGPlan.h:
dfg/DFGSlowPathGenerator.h:

(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

dfg/DFGSpeculativeJIT.h:
domjit/DOMJITSignature.h:

(JSC::DOMJIT::Signature::Signature):
(JSC::DOMJIT::Signature::effect):
(JSC::DOMJIT::Signature::argumentCount): Deleted.

heap/MarkingConstraintSolver.h:
heap/SlotVisitor.h:
jit/CallFrameShuffleData.h:
jit/JITDivGenerator.h:
jit/SpillRegistersMode.h:
parser/Nodes.h:
profiler/ProfilerOSRExit.cpp:

(JSC::Profiler::OSRExit::OSRExit):

profiler/ProfilerOSRExit.h:
runtime/ArrayBufferView.h:
runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::SamplingProfiler):

runtime/SamplingProfiler.h:
runtime/TypeSet.cpp:

(JSC::StructureShape::StructureShape):

runtime/TypeSet.h:
runtime/Watchdog.h:

Source/WTF:

wtf/CrossThreadQueue.h:
wtf/Logger.h:
wtf/MemoryPressureHandler.h:
wtf/MetaAllocator.h:
wtf/Threading.cpp:

12:03 PM Changeset in webkit [242811] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed
https://bugs.webkit.org/show_bug.cgi?id=195522

Reviewed by Matt Baker.

UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype._updateBreakpointStatus):

UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype.get hasBreakpoint): Added.

12:02 PM Changeset in webkit [242810] by mark.lam@apple.com

3 edits
1 add in trunk

The HasIndexedProperty node does GC.
https://bugs.webkit.org/show_bug.cgi?id=195559
<rdar://problem/48767923>

Reviewed by Yusuke Suzuki.

JSTests:

stress/HasIndexedProperty-does-gc.js: Added.

Source/JavaScriptCore:

HasIndexedProperty can call the slow path operationHasIndexedPropertyByInt(),
which can eventually call JSString::getIndex(), which can resolve a rope.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

11:59 AM Changeset in webkit [242809] by Devin Rousso

12 edits
2 adds in trunk

Web Inspector: Canvas: export recording as HTML
https://bugs.webkit.org/show_bug.cgi?id=195311
<rdar://problem/48588673>

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

UserInterface/Models/Recording.js:

(WI.Recording.prototype.async swizzle):
(WI.Recording.prototype.toHTML): Added.
(WI.Recording.prototype.toHTML.escapeHTML): Added.
(WI.Recording.prototype.toHTML.processObject): Added.
(WI.Recording.prototype.toHTML.processValue): Added.

UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype._exportRecording):
(WI.RecordingContentView.prototype._exportReduction): Added.
(WI.RecordingContentView.prototype._updateExportButton): Added.
(WI.RecordingContentView.prototype._handleExportNavigationItemClicked): Added.
(WI.RecordingContentView.prototype._handleRecordingProcessedAction):

UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):

UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView):

UserInterface/Views/HeapSnapshotContentView.js:

(WI.HeapSnapshotContentView):
Drive-by: s/toolTip/tooltip.

Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/canvas/recording-html-2d.html: Added.
inspector/canvas/recording-html-2d-expected.txt: Added.
inspector/canvas/recording-2d-expected.txt: Added.
inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.log):
(TestPage.registerInitializer.window.startRecording):

platform/ios-wk1/TestExpectations:
platform/mac-wk1/TestExpectations:

11:56 AM Changeset in webkit [242808] by Devin Rousso

12 edits
2 adds in trunk

Web Inspector: Audit: there should be a centralized place for reusable code
https://bugs.webkit.org/show_bug.cgi?id=195265
<rdar://problem/47040673>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/protocol/Audit.json:

Increment version.

Source/WebInspectorUI:

UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.async start):
(WI.AuditManager.prototype._topLevelTestForTest): Added.
(WI.AuditManager.prototype._topLevelTestForTest.walk): Added.

UserInterface/Models/AuditTestBase.js:

(WI.AuditTestBase):
(WI.AuditTestBase.prototype.async setup): Added.
(WI.AuditTestBase.toJSON):

UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.async.fromPayload):
(WI.AuditTestCase.prototype.async run.async parseResponse):
Allow additional data to be passed back to the result's data for testing.

UserInterface/Models/AuditTestGroup.js:

(WI.AuditTestGroup.async.fromPayload):

LayoutTests:

inspector/audit/manager-start-setup.html: Added.
inspector/audit/manager-start-setup-expected.txt: Added.
inspector/model/auditTestCase.html:
inspector/model/auditTestCase-expected.txt:
inspector/model/auditTestGroup.html:
inspector/model/auditTestGroup-expected.txt:

11:51 AM Changeset in webkit [242807] by pvollan@apple.com

9 edits in trunk/Source/WebKit

[iOS] Block access to backboardd service
https://bugs.webkit.org/show_bug.cgi?id=195484

Reviewed by Brent Fulgham.

This patch is addressing blocking the backboardd service "com.apple.backboard.hid.services". Getting the
backlight level in the WebContent process will initiate a connection with this service. To be able to
block the service, the backlight level is queried in the UI process and sent to the WebContent process
when the WebContent process is started, and when the backlight level is changed. On the WebContent side,
the method getting the backlight level is swizzled to return the value sent from the UI process.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::displayBrightness):
(WebKit::WebProcessPool::backlightLevelDidChangeCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

UIProcess/WebProcessPool.h:
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::currentBacklightLevel):
(WebKit::WebProcess::backlightLevelDidChange):

11:25 AM Changeset in webkit [242806] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the build after 242801

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant _elementActionForDDAction:]):
More.

11:23 AM Changeset in webkit [242805] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the build after 242801

UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant _elementActionForDDAction:]):

11:08 AM Changeset in webkit [242804] by youenn@apple.com

8 edits in trunk/Source/WebCore

Rename originsMatch in originSerializationsMatch
https://bugs.webkit.org/show_bug.cgi?id=195572

Reviewed by Jiewen Tan.

In addition to renaming, make use of SecurityOrigin::isSameOriginAs
where it makes more sense than to compare origin serialization.
The main difference is that isSameOriginAs will return false for two different unique origins
while originsSerializationsMatch will not.

Modules/credentialmanagement/CredentialsContainer.cpp:

(WebCore::CredentialsContainer::doesHaveSameOriginAsItsAncestors):

Modules/mediastream/RTCController.cpp:

(WebCore::matchDocumentOrigin):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::certificatesFromConfiguration):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::shouldOpenExternalURLsPolicyToPropagate const):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest):

page/SecurityOrigin.cpp:

(WebCore::serializedOriginsMatch):
(WebCore::originsMatch): Deleted.

page/SecurityOrigin.h:

10:47 AM Changeset in webkit [242803] by eric.carlson@apple.com

2 edits in trunk/Source/WebKit

[iOS] Sandbox must allow mach lookup required to compress video
https://bugs.webkit.org/show_bug.cgi?id=195627
<rdar://problem/48811072>

Reviewed by Youenn Fablet.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

10:42 AM Changeset in webkit [242802] by rmorisset@apple.com

3 edits in trunk/Source/JavaScriptCore

blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector
https://bugs.webkit.org/show_bug.cgi?id=195595

Reviewed by Saam Barati.

Also change BlockList from being Vector<BasicBlock*, 5> to Vector<BasicBlock*>

dfg/DFGBasicBlock.h:
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):

10:41 AM Changeset in webkit [242801] by commit-queue@webkit.org

6 edits in trunk/Source

Check whether to launch a default action instead of action sheet
https://bugs.webkit.org/show_bug.cgi?id=195225
<rdar://problem/47715544>

Patch by Jennifer Moore <jennifer.moore@apple.com> on 2019-03-12
Source/WebCore/PAL:

Reviewed by Daniel Bates.

Add new SPI declarations.

pal/spi/ios/DataDetectorsUISPI.h:

Source/WebKit:

Reviewed by Daniel Bates and Tim Horton.

Notify DataDetectors at the start of a touch on a link, and check whether to immediately
launch the default action instead of an action sheet.

UIProcess/ios/WKActionSheetAssistant.h:
UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant interactionDidStart]):
(-[WKActionSheetAssistant _createSheetWithElementActions:defaultTitle:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]): Deleted.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _webTouchEventsRecognized:]):

10:23 AM Changeset in webkit [242800] by dbates@webkit.org

2 edits
1 add in trunk/LayoutTests

[iOS] Add test to ensure that a web page can prevent the default for Command + A
https://bugs.webkit.org/show_bug.cgi?id=192425

Reviewed by Wenson Hsieh.

Skip the test until we have the UIKit fix for <rdar://problem/46430796>.

fast/events/ios/key-command-select-all-prevent-default.html: Added.
platform/ios/TestExpectations:

10:22 AM Changeset in webkit [242799] by timothy_horton@apple.com

3 edits in trunk/Tools

Fix the build

TestRunnerShared/spi/PencilKitTestSPI.h:
TestWebKitAPI/ios/PencilKitTestSPI.h:

10:15 AM Changeset in webkit [242798] by Alan Bujtas

8 edits
1 copy
1 add in trunk

[Synthetic Click] Dispatch mouseout soon after mouseup
https://bugs.webkit.org/show_bug.cgi?id=195575
<rdar://problem/47093049>

Reviewed by Simon Fraser.

Source/WebCore:

Let's fire a mouseout event when a click is submitted as the result of a tap. It helps to dismiss content which would otherwise require you to move the mouse (cases like control bar on youtube.com).

Test: fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html

page/EventHandler.h:
page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::dispatchFakeMouseOut):

Source/WebKit:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click-expected.txt: Added.
fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html: Added.

9:50 AM Changeset in webkit [242797] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

In CachedFrame's constructor, release-assert that DOMWindow still has a frame after page-caching subframes
https://bugs.webkit.org/show_bug.cgi?id=195609

Reviewed by Chris Dumez.

r242677 added release assertions to DOMWindow::suspendForPageCache. But when the first release assert in
that function is hit, we still can't tell whether active DOM objects are detaching frames, or if creating
CachedFrame's on one of subframes is causing the frame to go way.

Add a release assertion immediately after creating CachedFrame on subframes to detect this case.

history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

9:40 AM Changeset in webkit [242796] by Alan Bujtas

10 edits in trunk/Source

[ContentChangeObserver] Stop content change observation when the touch event turns into long press
https://bugs.webkit.org/show_bug.cgi?id=195601
<rdar://problem/48796324>

Reviewed by Wenson Hsieh.

Source/WebCore:

Cancel the ongoing content observation (started at touchStart) when the touch event does not turn into a tap gesture.

Not testable because any subsequent tap would reset the state anyway (though it might be measurable through some code triggering heavy content change).

page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::didRecognizeLongPress):
(WebCore::ContentChangeObserver::willNotProceedWithClick):

page/ios/ContentChangeObserver.h:

Source/WebKit:

Add didRecognizeLongPress() message to be able to cancel content observation (started at touchStart).

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _longPressRecognized:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didRecognizeLongPress):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didRecognizeLongPress):

8:07 AM Changeset in webkit [242795] by aestes@apple.com

3 edits in trunk/Source/WebKit

[Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
https://bugs.webkit.org/show_bug.cgi?id=195583
<rdar://problem/48420224>

Reviewed by Daniel Bates.

PassKit.framework is optionally soft-linked on Mac because it is missing from the Recovery
Partition. We need to check if the framework is available before calling into it.

Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments):
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):
(WebKit::WebPaymentCoordinatorProxy::platformAvailablePaymentNetworks):

Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

7:45 AM Changeset in webkit [242794] by Antti Koivisto

25 edits
2 adds in trunk

Compositing layer that renders two positioned elements should not hit test
https://bugs.webkit.org/show_bug.cgi?id=195371
<rdar://problem/48649586>

Reviewed by Simon Fraser.

Source/WebCore:

Compute and pass an event region for layers if it differs from layer bounds.

This patch fixes various block overflow and layer expansion cases. It does not handle
overflowing line boxes yet (it adds tests for those too).

Test: fast/scrolling/ios/overflow-scroll-overlap-2.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setEventRegion):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::eventRegion):

platform/graphics/Region.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setEventRegion):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateEventRegion):

Pass the region via the main platform layer of the graphics layer.

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
rendering/PaintInfo.h:
rendering/PaintPhase.h:

Add EventRegion paint phase that computes the region instead of painting anything.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):

Invoke EventRegion paint phase.

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

Request event region when pointing a layer.

Source/WebKit:

Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):

Pass event region to UI process.

UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:

(WebKit::RemoteLayerTreeNode::layerID const):
(WebKit::RemoteLayerTreeNode::eventRegion const):

UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:

(WebKit::RemoteLayerTreeNode::RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::~RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::setEventRegion):

Maintain event region in RemoteLayerTreeNodes.

(WebKit::RemoteLayerTreeNode::initializeLayer):
(WebKit::RemoteLayerTreeNode::layerID):
(WebKit::RemoteLayerTreeNode::forCALayer):

Move layerID to RemoteLayerTreeNode and store RemoteLayerTreeNode pointer to CALayers instead.
This makes it easy to find the matching RemoteLayerTreeNode from a layer, globally.

(WebKit::RemoteLayerTreeNode::setLayerID): Deleted.

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(WebKit::collectDescendantViewsAtPoint):

If we have event region, use it for hit testing.

(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(collectDescendantViewsAtPoint): Deleted.

WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::eventRegion const):
(WebKit::PlatformCALayerRemote::setEventRegion):

WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

LayoutTests:

fast/scrolling/ios/overflow-scroll-overlap-2-expected.txt: Added.
fast/scrolling/ios/overflow-scroll-overlap-2.html: Added.

7:18 AM WebKitGTK/2.24.x edited by Philippe Normand

(diff)

7:17 AM Changeset in webkit [242793] by Philippe Normand

6 edits in trunk/Source/WebCore

[GStreamer][v4l2] Synchronous video texture flushing support
https://bugs.webkit.org/show_bug.cgi?id=195453

Reviewed by Xabier Rodriguez-Calvar.

The v4l2 video decoder currently requires that downstream users of
the graphics resources complete any pending draw call and release
resources before returning from the DRAIN query.

To accomplish this the player monitors the pipeline and whenever a
v4l2 decoder is added, synchronous video texture flushing support
is enabled. Additionally and for all decoder configurations, a
flush is performed before disposing of the player.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::playbinDeepElementAddedCallback):
Monitor elements added to the decodebin bin.
(WebCore::MediaPlayerPrivateGStreamer::decodebinElementAdded): Set
a flag if a v4l2 decoder was added in decodebin.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Connect
to the deep-element-added signal so as to monitor pipeline
topology updates.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Flush video texture before disposing of the player.
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
Synchronously flush if the pipeline contains a v4l2 decoder.
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Monitor push events only.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::pushNextBuffer): New
boolean flag used mostly to trigger synchronous flush conditions.
(WebCore::TextureMapperPlatformLayerProxy::dropCurrentBufferWhilePreservingTexture):
Optionally drop the current buffer in a synchronous manner. By
default the method keeps operating asynchronously.

platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:

4:38 AM Changeset in webkit [242792] by rniwa@webkit.org

7 edits in trunk/Source/WebCore

Move the remaining code to decide whether site specific quirks are needed to Quirks class
https://bugs.webkit.org/show_bug.cgi?id=195610

Reviewed by Antti Koivisto.

Moved the remaining code scattered across WebCore to decide whether a site specific quirk
is needed or not to Quirks class introduced in r236818.

Modules/fetch/FetchRequest.cpp:

(WebCore::needsSignalQuirk): Deleted.
(WebCore::processInvalidSignal):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::needsMouseFocusableQuirk const):

html/HTMLMediaElement.cpp:

(WebCore::needsAutoplayPlayPauseEventsQuirk): Deleted.
(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):
(WebCore::needsSeekingSupportQuirk): Deleted.
(WebCore::HTMLMediaElement::supportsSeeking const):

html/MediaElementSession.cpp:

(WebCore::needsArbitraryUserGestureAutoplayQuirk): Deleted.
(WebCore::needsPerDocumentAutoplayBehaviorQuirk): Deleted.
(WebCore::MediaElementSession::playbackPermitted const):

page/Quirks.cpp:

(WebCore::allowedAutoplayQuirks): Added.
(WebCore::Quirks::needsQuirks const): Added.
(WebCore::Quirks::shouldIgnoreInvalidSignal const): Added.
(WebCore::Quirks::needsFormControlToBeMouseFocusable const): Added.
(WebCore::Quirks::needsAutoplayPlayPauseEvents const): Added.
(WebCore::Quirks::needsSeekingSupportDisabled const): Addd.
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const): Added.
(WebCore::Quirks::shouldAutoplayForArbitraryUserGesture const): Added.
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const): Added.
(WebCore::Quirks::hasWebSQLSupportQuirk const): Fixed the coding style.

page/Quirks.h:

4:09 AM Changeset in webkit [242791] by eocanha@igalia.com

7 edits in trunk

[Media][MSE] Don't emit timeUpdate after play() if currentTime hasn't changed
https://bugs.webkit.org/show_bug.cgi?id=195454

Reviewed by Jer Noble.

Source/WebCore:

This change fixes YouTube 2019 MSE Conformance Tests "26. SFRPausedAccuracy"
and "27. HFRPausedAccuracy".

The first timeUpdate event after play() is omitted, because currentTime
doesn't actually change in that scenario.

Tests 26 and 27 measure the time drift (real time vs. media time) on playback
and start counting since the first timeUpdate event. In WebKit, that event
happens at play(), before the pipeline has completed the transition to playing.
Therefore, the real time inherits this startup delay and the test thinks that
the player has drifted.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal): Don't emit a timeUpdated event unless currentTime has changed.

LayoutTests:

This patch removes expectations for the first timeUpdate event after
play(), because currentTime doesn't actually change in that scenario
and the spec[1] states that a timeupdate event is fired if "The current
playback position changed as part of normal playback or in an
especially interesting way, for example discontinuously."

[1] https://www.w3.org/TR/html52/semantics-embedded-content.html#eventdef-media-timeupdate

media/video-paused-0-rate.html: Don't require the timeUpdate event when currentTime=0 to pass the test.
media/video-play-pause-events-expected.txt: Ditto, and changed test description.
media/video-play-pause-events.html: Changed test description to reflect the new behaviour.
media/video-play-pause-exception-expected.txt: Don't require the timeUpdate event.

3:59 AM Changeset in webkit [242790] by eocanha@igalia.com

2 edits in trunk/Source/WebCore

[EME][GStreamer] Speculative build fix
https://bugs.webkit.org/show_bug.cgi?id=195614

Unreviewed speculative WPE build fix after r242776.

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h: Added missing include.

3:25 AM Changeset in webkit [242789] by Philippe Normand

4 edits in trunk/Source/WebCore

[GStreamer] remove legacy GStreamer version checks
https://bugs.webkit.org/show_bug.cgi?id=195552

Reviewed by Xabier Rodriguez-Calvar.

We require GStreamer 1.8.x so version checks below that make
little sense. Also checks for odd minor version numbers make sense
only for the latest GStreamer git development version.

platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamerAndRegisterWebKitElements):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext):

2:08 AM WebKitGTK/2.24.x edited by Philippe Normand

(diff)

1:30 AM Changeset in webkit [242788] by Carlos Garcia Campos

12 edits in trunk

[WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
https://bugs.webkit.org/show_bug.cgi?id=194131

Source/WebKit:

Reviewed by Michael Catanzaro.

Ensure we emit the load-failed and load-changed with finished event when there's still an ongoing load when a
new provisional load strarts. Previous load fails with cancelled error.

UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewWillStartLoad): Call webkitWebViewLoadFailed() if current page load state is not finished.

UIProcess/API/glib/WebKitWebViewPrivate.h:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame): Call webkitWebViewWillStartLoad().

UIProcess/API/wpe/APIViewClient.h:

(API::ViewClient::willStartLoad): Add willStartLoad() to API::ViewClient

UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame): Call WPEView::willStartLoad().

UIProcess/API/wpe/PageClientImpl.h:
UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::willStartLoad): Call API::ViewClient::willStartLoad().

UIProcess/API/wpe/WPEView.h:
UIProcess/PageLoadState.h:

(WebKit::PageLoadState::isProvisional const):
(WebKit::PageLoadState::isCommitted const):
(WebKit::PageLoadState::isFinished const):

Tools:

Patch by Michael Catanzaro <Michael Catanzaro> on 2019-03-12
Reviewed by Michael Catanzaro.

TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(uriChanged):
(testUnfinishedSubresourceLoad):
(serverCallback):
(beforeAll):

1:29 AM Changeset in webkit [242787] by calvaris@igalia.com

2 edits in trunk/Source/WebCore

[EME] generateRequest was not using the sanitized init data
https://bugs.webkit.org/show_bug.cgi?id=195555

Reviewed by Jer Noble.

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::generateRequest): Use sanitized init
data instead of the original one.

1:13 AM Changeset in webkit [242786] by commit-queue@webkit.org

7 edits in trunk

Implement further CORS restrictions
https://bugs.webkit.org/show_bug.cgi?id=188644

Patch by Rob Buis <rbuis@igalia.com> on 2019-03-12
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test results.

web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any-expected.txt:
web-platform-tests/fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker-expected.txt:
web-platform-tests/fetch/api/headers/headers-no-cors.window-expected.txt:

Source/WebCore:

Verify that header value length is not greater than 128 [1]. Also implement
Step 5 of [2] to append values to existing header value when calling
Headers.append.

Tests: fetch/api/cors/cors-preflight-not-cors-safelisted.any.html

fetch/api/cors/cors-preflight-not-cors-safelisted.any.worker.html
fetch/api/headers/headers-no-cors.window.html

[1] https://fetch.spec.whatwg.org/#cors-safelisted-request-header
[2] https://fetch.spec.whatwg.org/#concept-headers-append

Modules/fetch/FetchHeaders.cpp:

(WebCore::canWriteHeader):
(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::filterAndFill):

platform/network/HTTPParsers.cpp:

(WebCore::isCrossOriginSafeRequestHeader): verify that header length is not greater than 128

12:10 AM Changeset in webkit [242785] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines - Improve handling of past recordings (readonly)
https://bugs.webkit.org/show_bug.cgi?id=195594

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-12
Reviewed by Devin Rousso.

UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._clearTimeline):
Don't allow clearing of a readonly recording.

UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
Don't do anything when viewing a readonly recording.

(WI.TimelineTabContentView.prototype._recordButtonClicked):
Start a new recording if viewing a readonly recording.

Mar 11, 2019:

11:58 PM Changeset in webkit [242784] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Remove OS X Server QuickTime plugin quirks
https://bugs.webkit.org/show_bug.cgi?id=195607

Reviewed by Brent Fulgham.

r87244 added a site specific quirk for Mac OS X Sever wiki pages.
However, the issue has since been resolved as of OS X Mountain Lion,
of which Apple has ended the support in September 2015.

Because the latest versions of Safari no longer supports non-Flash plugins,
the only scenario in which this quirk comes into play is when a third party app
which embeds WKWebView or WebKitLegacy loaded web pages on a OS X Server
running OS X Mountain Lion or earlier.

Given these observations, it's probably safe to remove this quirk from WebKit.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent const):
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Deleted.

html/HTMLObjectElement.h:

11:44 PM Changeset in webkit [242783] by Ross Kirsling

2 edits in trunk/Source/WebCore

Unreviewed speculative WPE build fix after r195586.

platform/encryptedmedia/CDMInstance.h:

11:15 PM Changeset in webkit [242782] by Kocsen Chung

2 edits in branches/safari-607.1.40.1-branch/Source/WebCore

Cherry-pick r242770. rdar://problem/48795263

REGRESSION(r236281): YouTube Movies fail with "video format" error
https://bugs.webkit.org/show_bug.cgi?id=195598
<rdar://problem/48782842>

Reviewed by Jon Lee.

Partially revert r236281 for YouTube.com.

page/Quirks.cpp: (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:10 PM Changeset in webkit [242781] by Kocsen Chung

2 edits in branches/safari-607.1.40.0-branch/Source/WebCore

Cherry-pick r242770. rdar://problem/48795264

REGRESSION(r236281): YouTube Movies fail with "video format" error
https://bugs.webkit.org/show_bug.cgi?id=195598
<rdar://problem/48782842>

Reviewed by Jon Lee.

Partially revert r236281 for YouTube.com.

page/Quirks.cpp: (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:09 PM Changeset in webkit [242780] by rniwa@webkit.org

4 edits in trunk/Source/WebCore

Remove MediaWiki site specific quirks
https://bugs.webkit.org/show_bug.cgi?id=195597

Reviewed by Simon Fraser.

r47383 added a site specific quirk for the KHTML workaround in MediaWiki.

Blink since removed this workaround:
https://github.com/chromium/chromium/commit/ecf84fc9c1a51c8ede7adfd0b0cba446d9a8caa0

Given Chrome has been shipping without this quirk for six years, it's safe to assume
this site specific quirk is no longer neeed for Web compatibility.

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):

css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

css/parser/CSSParserContext.h:

(WebCore::CSSParserContextHash::hash):

11:07 PM Changeset in webkit [242779] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove OpenCube QuickMenu quirks from navigator.appVersion
https://bugs.webkit.org/show_bug.cgi?id=195600

Reviewed by Simon Fraser.

Remove the site specific quirk added in r35050 for OpenCube QuickMenu library for nwa.com

Blink removed this code back in 2013. The fact Chrome has been shipping successfully without
this quirk for six years is a good evidence that it's no longer needed for the Web compatibility.

page/Navigator.cpp:

(WebCore::Navigator::appVersion const):
(WebCore::shouldHideFourDot): Deleted.

11:04 PM Changeset in webkit [242778] by commit-queue@webkit.org

4 edits in trunk

WTF::Expected should use std::addressof instead of operator&
https://bugs.webkit.org/show_bug.cgi?id=195604

Patch by Alex Christensen <achristensen@webkit.org> on 2019-03-11
Reviewed by Myles Maxfield.

Source/WTF:

The latter was causing problems with types that do tricky things with constructors and operator&,
specifically UniqueRef but I made a reduced test case. When it used operator&, it would get the contained
type and call the constructor that takes a contained type instead of the move constructor.

wtf/Expected.h:

(std::experimental::fundamentals_v3::expected_detail::base::base):
(std::experimental::fundamentals_v3::expected::swap):

Tools:

TestWebKitAPI/Tests/WTF/Expected.cpp:

(TestWebKitAPI::Unique::Unique):
(TestWebKitAPI::Unique::operator&):
(TestWebKitAPI::TEST):

10:50 PM Changeset in webkit [242777] by Ryan Haddad

8 edits in trunk

Unreviewed, rolling out r242763.

Causes layout test crashes on iOS simulator

Reverted changeset:

"[Synthetic Click] Dispatch mouseout soon after mouseup"
https://bugs.webkit.org/show_bug.cgi?id=195575
https://trac.webkit.org/changeset/242763

10:27 PM Changeset in webkit [242776] by Ross Kirsling

132 edits in trunk

Add Optional to Forward.h.
https://bugs.webkit.org/show_bug.cgi?id=195586

Reviewed by Darin Adler.

Source/JavaScriptCore:

b3/B3Common.cpp:
b3/B3Common.h:
debugger/DebuggerParseData.cpp:
debugger/DebuggerParseData.h:
heap/HeapSnapshot.cpp:
heap/HeapSnapshot.h:
jit/PCToCodeOriginMap.cpp:
jit/PCToCodeOriginMap.h:
runtime/AbstractModuleRecord.cpp:
runtime/AbstractModuleRecord.h:
wasm/WasmInstance.h:
wasm/WasmModuleParser.h:
wasm/WasmSectionParser.cpp:
wasm/WasmSectionParser.h:
wasm/WasmStreamingParser.cpp:
wasm/WasmStreamingParser.h:
yarr/YarrFlags.cpp:
yarr/YarrFlags.h:
yarr/YarrUnicodeProperties.cpp:
yarr/YarrUnicodeProperties.h: