Timeline
Apr 3, 2019:
- 10:53 PM Changeset in webkit [243864] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper()
https://bugs.webkit.org/show_bug.cgi?id=196538
Reviewed by Michael Catanzaro.
In most of the cases the parent is not found, probably because the child is not a direct descendant of the
parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Use -1 as the index when find() returns notFound.
- 10:52 PM Changeset in webkit [243863] by
-
- 6 edits1 move1 add1 delete in trunk
[ATK] Cleanup WebPageAccessibilityObjectAtk
https://bugs.webkit.org/show_bug.cgi?id=196537
Reviewed by Michael Catanzaro.
Source/WebKit:
Several changes and cleanups:
- Add WebKit prefix so that style checker doesn't complain about GObject conventions.
- Rename the header to remove the Atk prefix to match the cpp file and class name.
- Use pragma once.
- Use nullptr instead of 0.
- Use WEBKIT_DEFINE_TYPE instead of G_DEFINE_TYPE.
- Return generic AtkObject* from constructor.
- SourcesGTK.txt:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp: Renamed from Source/WebKit/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp.
(accessibilityRootObjectWrapper):
(webkitWebPageAccessibilityObjectInitialize):
(webkitWebPageAccessibilityObjectGetIndexInParent):
(webkitWebPageAccessibilityObjectGetNChildren):
(webkitWebPageAccessibilityObjectRefChild):
(webkit_web_page_accessibility_object_class_init):
(webkitWebPageAccessibilityObjectNew):
(webkitWebPageAccessibilityObjectRefresh):
- WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.h: Added.
- WebProcess/WebPage/atk/WebPageAccessibilityObject.h: Removed.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::updateAccessibilityTree):
Tools:
Also consider files under atk directories as exceptions for GObject conventions.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- 10:51 PM Changeset in webkit [243862] by
-
- 3 edits in trunk/Source/WebKit
[ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded
https://bugs.webkit.org/show_bug.cgi?id=196535
Reviewed by Michael Catanzaro.
This way the properties are not cached. Right now, if number of children is queried before the socket is
embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded.
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:
(webkitWebViewBaseAccessibleRefStateSet): Set ATK_STATE_TRANSIENT is the socket is not occupied.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree): Unset ATK_STATE_TRANSIENT.
- 10:50 PM Changeset in webkit [243861] by
-
- 4 edits in trunk/Source/WebKit
[ATK] Embed the AtkSocket as soon as we receive the plug ID
https://bugs.webkit.org/show_bug.cgi?id=196534
Reviewed by Michael Catanzaro.
We are currently storing the ID and waiting for the next time get_accessible is called to embed the socket. We
can simply embed the socket when the plug ID is received.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseGetAccessible):
- UIProcess/WebPageProxy.h:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
- 10:48 PM Changeset in webkit [243860] by
-
- 2 edits in trunk/Source/WebKit
[ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=193914
Reviewed by Michael Catanzaro.
Move it to dispatchDidFinishDocumentLoad, since we know we have the document at that point and we can create the
root accessibility object wrapper.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- 10:47 PM Changeset in webkit [243859] by
-
- 6 edits in trunk
Update AutoFill field icons to be SVG instead of PNG images.
https://bugs.webkit.org/show_bug.cgi?id=196557
rdar://problem/48292514
Reviewed by Tim Horton.
Source/WebCore:
- css/html.css:
(input::-webkit-credentials-auto-fill-button):
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-credit-card-auto-fill-button):
LayoutTests:
- platform/ios/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
- platform/mac/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
- platform/win/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
- 10:44 PM Changeset in webkit [243858] by
-
- 2 edits in trunk/Tools
The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
https://bugs.webkit.org/show_bug.cgi?id=196588
<rdar://problem/49365787>
Unreviewed build fix for Windows port.
error C3861: 'kill': identifier not found
- TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
- 10:27 PM Changeset in webkit [243857] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling in r243843 with the build fix
https://bugs.webkit.org/show_bug.cgi?id=196586
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- runtime/RandomizingFuzzerAgent.cpp:
(JSC::RandomizingFuzzerAgent::getPrediction):
- 9:32 PM Changeset in webkit [243856] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 79
Added a tag for Safari Technology Preview release 79.
- 8:57 PM Changeset in webkit [243855] by
-
- 9 edits in trunk/Source
Simplify some "programmaticScroll" code paths
https://bugs.webkit.org/show_bug.cgi?id=196589
Reviewed by Zalan Bujtas.
Source/WebCore:
AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll() just returned early if programmaticScroll
was true, so instead, just never call it. This means we can remove the "programmaticScroll" argument from
scheduleUpdateScrollPositionAfterAsyncScroll(). Also change some callers to use the ScrollType enum
instead of a bool.
Now, ThreadedScrollingTree::scrollingTreeNodeDidScroll() just returns early. Programmatic scrolls
update state on the main thread before updating the scrolling tree, so this makes sense.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
- page/scrolling/AsyncScrollingCoordinator.h:
(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::ScheduledScrollUpdate):
(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::matchesUpdateType const):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::operator<<):
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::reconcileScrollingState):
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
Source/WebKit:
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: Remove the parameter.
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode): Use the enum type.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- 8:57 PM Changeset in webkit [243854] by
-
- 2 edits in trunk/Tools
[ews-build] Cancel build and similar operations should have authentication
https://bugs.webkit.org/show_bug.cgi?id=196520
Reviewed by Dewei Zhu.
- BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
environment variables.
- 8:44 PM Changeset in webkit [243853] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r243843.
Broke CLoop and Windows builds.
Reverted changeset:
"[JSC] Add dump feature for RandomizingFuzzerAgent"
https://bugs.webkit.org/show_bug.cgi?id=196586
https://trac.webkit.org/changeset/243843
- 8:38 PM Changeset in webkit [243852] by
-
- 2 edits in trunk/Tools
[ews-build] Do not trigger queues which are not in production yet
https://bugs.webkit.org/show_bug.cgi?id=196581
Reviewed by Dewei Zhu.
- BuildSlaveSupport/ews-build/config.json:
- 8:37 PM Changeset in webkit [243851] by
-
- 10 edits2 copies5 adds in trunk
B3 should use associativity to optimize expression trees
https://bugs.webkit.org/show_bug.cgi?id=194081
Reviewed by Filip Pizlo.
JSTests:
Added three microbenchmarks:
- add-tree should be the ideal case, but there is no speedup because we are currently unable to prove that the CheckAdd won't overflow
- bit-xor-tree most closely matches the situation where the optimization triggers on the JetStream2 subtests where it triggers: an unbalanced expression tree of size 8 that can be balanced, with no other optimizations being unlocked. 16% speedup
- bit-or-tree is an ideal case, where the reassociation also enables a ton of further simplifications. 42% speedup
- microbenchmarks/add-tree.js: Added.
- microbenchmarks/bit-or-tree.js: Added.
- microbenchmarks/bit-xor-tree.js: Added.
Source/JavaScriptCore:
This patch adds a new B3 pass, that tries to find and optimize expression trees made purely of any one associative and commutative operator (Add/Mul/BitOr/BitAnd/BitXor).
The pass only runs in O2, and runs once, after lowerMacros and just before a run of B3ReduceStrength (which helps clean up the dead code it tends to leave behind).
I had to separate killDeadCode out of B3ReduceStrength (as a new B3EliminateDeadCode pass) to run it before B3OptimizeAssociativeExpressionTrees, as otherwise it is stopped by high use counts
inherited from CSE.
This extra run of DCE is by itself a win, most notably on microbenchmarks/instanceof-always-hit-two (1.5x faster), and on microbenchmarks/licm-dragons(-out-of-bounds) (both get 1.16x speedup).
I suspect it is because it runs between CSE and tail-dedup, and as a result allows a lot more tail-dedup to occur.
The pass is currently extremely conservative, not trying anything if it would cause _any_ code duplication.
For this purpose, it starts by computing use counts for the potentially interesting nodes (those with the right opcodes), and segregate them into expression trees.
The root of an expression tree is a node that is either used in multiple places, or is used by a value with a different opcode.
The leaves of an expression tree are nodes that are either used in multiple places, or have a different opcode.
All constant leaves of a tree are combined, as well as all leaves that are identical. What remains is then laid out into a balanced binary tree, hopefully maximizing ILP.
This optimization was implemented as a stand-alone pass and not as part of B3ReduceStrength mostly because it needs use counts to avoid code duplication.
It also benefits from finding all tree roots first, and not trying to repeatedly optimize subtrees.
I added several tests to testB3 with varying patterns of trees. It is also tested in a less focused way by lots of older tests.
In the future this pass could be expanded to allow some bounded amount of code duplication, and merging more leaves (e.g. Mul(a, 3) and a in an Add tree, into Mul(a, 4))
The latter will need exposing the peephole optimizations out of B3ReduceStrength to avoid duplicating code.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- b3/B3Common.cpp:
(JSC::B3::shouldDumpIR):
(JSC::B3::shouldDumpIRAtEachPhase):
- b3/B3Common.h:
- b3/B3EliminateDeadCode.cpp: Added.
(JSC::B3::EliminateDeadCode::run):
(JSC::B3::eliminateDeadCode):
- b3/B3EliminateDeadCode.h: Added.
(JSC::B3::EliminateDeadCode::EliminateDeadCode):
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3OptimizeAssociativeExpressionTrees.cpp: Added.
(JSC::B3::OptimizeAssociativeExpressionTrees::OptimizeAssociativeExpressionTrees):
(JSC::B3::OptimizeAssociativeExpressionTrees::neutralElement):
(JSC::B3::OptimizeAssociativeExpressionTrees::isAbsorbingElement):
(JSC::B3::OptimizeAssociativeExpressionTrees::combineConstants):
(JSC::B3::OptimizeAssociativeExpressionTrees::emitValue):
(JSC::B3::OptimizeAssociativeExpressionTrees::optimizeRootedTree):
(JSC::B3::OptimizeAssociativeExpressionTrees::run):
(JSC::B3::optimizeAssociativeExpressionTrees):
- b3/B3OptimizeAssociativeExpressionTrees.h: Added.
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithIdentity):
- b3/testb3.cpp:
(JSC::B3::testBitXorTreeArgs):
(JSC::B3::testBitXorTreeArgsEven):
(JSC::B3::testBitXorTreeArgImm):
(JSC::B3::testAddTreeArg32):
(JSC::B3::testMulTreeArg32):
(JSC::B3::testBitAndTreeArg32):
(JSC::B3::testBitOrTreeArg32):
(JSC::B3::run):
- 8:34 PM Changeset in webkit [243850] by
-
- 4 edits in trunk/Source
Add logging and ASSERTs to investigate issue with VPModuleInitialize
https://bugs.webkit.org/show_bug.cgi?id=196573
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Expand macros directly to add some logging.
Removed the dispatch_once since VPModuleInitialize is already called in one.
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:
(webrtc::initVideoProcessingVPModuleInitialize):
Source/WebCore:
Add some ASSERTs.
No change of behavior.
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProviderCocoa::createDecoderFactory):
(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):
- 8:23 PM Changeset in webkit [243849] by
-
- 2 edits in trunk/Tools
Unreviewed, fix typo in the name of API test added in r243848.
- TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::TEST):
- 8:09 PM Changeset in webkit [243848] by
-
- 4 edits in trunk
The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
https://bugs.webkit.org/show_bug.cgi?id=196588
<rdar://problem/49365787>
Reviewed by Ryosuke Niwa.
Source/WebKit:
The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash.
This can lead to returning stale frames to the client if it asks for those.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::nullJavaScriptCallback):
(TestWebKitAPI::didCrashCheckFrames):
(TestWebKitAPI::TEST):
- 7:53 PM Changeset in webkit [243847] by
-
- 15 edits in trunk/Source/WebKit
Remove the isProgrammaticScroll argument to requestScroll() because no-one uses it
https://bugs.webkit.org/show_bug.cgi?id=196587
Reviewed by Zalan Bujtas.
This argument was unused.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::requestScroll):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::requestScroll):
- UIProcess/API/wpe/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestScroll):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::requestScroll):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::requestScroll):
- UIProcess/win/PageClientImpl.cpp:
(WebKit::PageClientImpl::requestScroll):
- UIProcess/win/PageClientImpl.h:
- 7:52 PM Changeset in webkit [243846] by
-
- 3 edits in trunk/Source/WebCore
Remove some redundant memebers from ScrollingStateFrameScrollingNode
https://bugs.webkit.org/show_bug.cgi?id=196571
Reviewed by Zalan Bujtas.
m_requestedScrollPosition and m_requestedScrollPositionRepresentsProgrammaticScroll were
duplicated on ScrollingStateFrameScrollingNode and ScrollingStateScrollingNode, so
remove them from the derived class.
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- 7:09 PM Changeset in webkit [243845] by
-
- 3 edits2 adds in trunk
REGRESSION (r220717): Assertion fires when animating an SVG rounded corner rect till it collapses
https://bugs.webkit.org/show_bug.cgi?id=196518
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-03
Reviewed by Simon Fraser.
Source/WebCore:
r220717 made RenderSVGRect clear its m_path in updateShapeFromElement().
RenderSVGRect tries to optimize its layout and drawing if the rectangle
is not rounded. So it uses the flag m_usePathFallback to know whether to
use m_path or m_innerStrokeRect and m_outerStrokeRect. If the rectangle
is rounded but its boundingSize is empty, m_path will be cleared,
m_innerStrokeRect and m_outerStrokeRect will be recalculated but
m_usePathFallback will not be reset to false. Therefore when calling
RenderSVGRect::isEmpty(), it will call RenderSVGShape::isEmpty() which
will assert since m_path is null.
Test: svg/animations/animate-rounded-corner-rect-zero-height.svg
- rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::updateShapeFromElement):
Reset m_usePathFallback to false once clearPath() is called.
LayoutTests:
- svg/animations/animate-rounded-corner-rect-zero-height-expected.txt: Added.
- svg/animations/animate-rounded-corner-rect-zero-height.svg: Added.
- 7:01 PM Changeset in webkit [243844] by
-
- 2 edits in trunk/Source/WebCore
Nullptr crash in InlineTextBox::selectionState via TextIndicator::createWithRange
https://bugs.webkit.org/show_bug.cgi?id=196579
Reviewed by Simon Fraser.
Avoid crashing accessing the unengated optional's value in relese builds for now.
Unfortunately, fixing the underlying cause of the selection states of RenderView & RenderObject
getting out out of sync would require a significant re-architecturing of the whole selection
repainting / state managing mechanism.
- rendering/SelectionRangeData.h:
(WebCore::SelectionRangeData::startPosition const):
(WebCore::SelectionRangeData::endPosition const):
- 6:28 PM Changeset in webkit [243843] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Add dump feature for RandomizingFuzzerAgent
https://bugs.webkit.org/show_bug.cgi?id=196586
Reviewed by Saam Barati.
Towards deterministic tests for the results from randomizing fuzzer agent, this patch adds Options::dumpRandomizingFuzzerAgentPredictions, which dumps the generated types.
The results is like this.
getPrediction name:(#C2q9xD),bytecodeIndex:(22),original:(Array),generated:(OtherObj|Array|Float64Array|BigInt|NonIntAsDouble)
getPrediction name:(makeUnwriteableUnconfigurableObject#AiEJv1),bytecodeIndex:(14),original:(OtherObj),generated:(Final|Uint8Array|Float64Array|SetObject|WeakSetObject|BigInt|NonIntAsDouble)
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- runtime/RandomizingFuzzerAgent.cpp:
(JSC::RandomizingFuzzerAgent::getPrediction):
- 5:43 PM Changeset in webkit [243842] by
-
- 3 edits in trunk/Tools
run-webkit-tests: Upload test results (new results database)
https://bugs.webkit.org/show_bug.cgi?id=196577
<rdar://problem/34841155>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Upload results after each device shard, since the configuration will be
different for each device.
(Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
uploaded to a results database.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
- 5:16 PM Changeset in webkit [243841] by
-
- 24 edits2 adds in trunk
-apple-trailing-word is needed for browser detection
https://bugs.webkit.org/show_bug.cgi?id=196575
Unreviewed.
PerformanceTests:
- MotionMark/resources/debug-runner/motionmark.css:
(#intro .start-benchmark p):
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This is an unreviewed partial revert of r243819. Turns out there are some websites
which use this property to do browser detection. So, we need to continue to parse
the property, but we don't need the property to do anything.
Test: fast/text/trailing-word-detection.html
- Configurations/FeatureDefines.xcconfig:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TrailingWord const):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::trailingWord const):
(WebCore::RenderStyle::setTrailingWord):
(WebCore::RenderStyle::initialTrailingWord):
- rendering/style/RenderStyleConstants.h:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
- fast/text/trailing-word-detection-expected.txt: Added.
- fast/text/trailing-word-detection.html: Added.
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 4:57 PM Changeset in webkit [243840] by
-
- 2 edits in trunk/LayoutTests
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html is a flaky failure and timeout
https://bugs.webkit.org/show_bug.cgi?id=196115
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky test
- 4:51 PM Changeset in webkit [243839] by
-
- 5 edits in trunk
REGRESSION (r243642): com.apple.JavaScriptCore crash in JSC::RegExpObject::execInline
https://bugs.webkit.org/show_bug.cgi?id=196477
Reviewed by Keith Miller.
Source/JavaScriptCore:
The problem here is that when we advance the index by 2 for a character class that only
has non-BMP characters, we might go past the end of the string. This can happen for
greedy counted character classes that are part of a alternative where there is one
character to match after the greedy non-BMP character class.
The "do we have string left to match" check at the top of the JIT loop for the counted
character class checks to see if index is not equal to the string length. For non-BMP
character classes, we need to check to see if there are at least 2 characters left.
Therefore we now temporarily add 1 to the current index before comparing. This checks
to see if there are iat least 2 characters left to match, instead of 1.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
LayoutTests:
Updated the test with a couple more test cases to test a few variants of this bug.
Also added a couple of non-greedy counted non-BMP character class tests that don't have
the bug just to be sure.
- js/regexp-unicode-expected.txt:
- js/script-tests/regexp-unicode.js:
- 4:39 PM Changeset in webkit [243838] by
-
- 2 deletes in trunk/Source/ThirdParty/libwebrtc/Source/third_party
Remove unneeded libwebrtc files, this time all the files
https://bugs.webkit.org/show_bug.cgi?id=196553
Reviewed by Eric Carlson.
- Source/third_party/boringssl/src/fuzz: Removed.
- Source/third_party/protobuf/csharp/keys: Removed.
- 4:35 PM Changeset in webkit [243837] by
-
- 1 edit in trunk/Source/ThirdParty/libwebrtc/ChangeLog
Remove unneeded libwebrtc files
https://bugs.webkit.org/show_bug.cgi?id=196553
Reviewed by Eric Carlson.
- Source/third_party/boringssl/src/fuzz: Removed.
- Source/third_party/protobuf/csharp/keys: Removed.
- 4:30 PM Changeset in webkit [243836] by
-
- 2 edits in trunk/Source/WebKit
Add a WebKit internal feature flag to always enable modern compatibility mode by default
https://bugs.webkit.org/show_bug.cgi?id=196526
<rdar://problem/49532923>
Reviewed by Tim Horton.
Change UseModernCompatibilityModeByDefault from an internal preference to a debug preference, so that it may be
enabled for all apps on the system.
- Shared/WebPreferences.yaml:
- 4:29 PM Changeset in webkit [243835] by
-
- 3 edits1 add in trunk
[JSC] Exception verification crash on operationArrayIndexOfValueInt32OrContiguous
https://bugs.webkit.org/show_bug.cgi?id=196574
Reviewed by Saam Barati.
JSTests:
- stress/string-index-of-exception-check.js: Added.
(blurType):
(1.forEach):
Source/JavaScriptCore:
This patch adds missing exception check in operationArrayIndexOfValueInt32OrContiguous.
- dfg/DFGOperations.cpp:
- 4:21 PM Changeset in webkit [243834] by
-
- 2 edits in trunk/Source/WebKit
Fix internal build after r243829
https://bugs.webkit.org/show_bug.cgi?id=196549
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Some SDK's don't include this selector in the header.
Use NSSelectorFromString.
- 4:08 PM Changeset in webkit [243833] by
-
- 28 edits2 adds in trunk
[CMake][WTF] Mirror XCode header directories
https://bugs.webkit.org/show_bug.cgi?id=191662
Reviewed by Konstantin Tokarev.
.:
Add WTF_FRAMEWORK_HEADERS_DIR to place WTF headers into. Add frameworks/WTF.cmake
which creates an interface target which will populate dependencies for consumers.
This file is added here to support AppleWin internal builds which invoke CMake on
each directory.
- Source/cmake/WebKitFS.cmake:
- Source/cmake/frameworks/WTF.cmake: Added.
Source/JavaScriptCore:
Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
builds.
- CMakeLists.txt:
- shell/CMakeLists.txt:
Source/WebCore:
Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
builds.
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebDriver:
Use WTFFramework as a dependency.
- CMakeLists.txt:
Source/WebKit:
Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
builds.
- CMakeLists.txt:
Source/WebKitLegacy:
Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
builds.
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebKitLegacy/win:
- WebKitQuartzCoreAdditions/CMakeLists.txt:
Source/WTF:
Rename WTF forwarding header target to WTFFramework and update the install location
to WTF_FRAMEWORK_HEADERS_DIR.
- wtf/CMakeLists.txt:
Tools:
Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
builds.
- CMakeLists.txt:
- DumpRenderTree/CMakeLists.txt:
- DumpRenderTree/PlatformWin.cmake:
- MiniBrowser/win/CMakeLists.txt:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformWin.cmake:
- WebKitTestRunner/PlatformGTK.cmake:
- WebKitTestRunner/PlatformWin.cmake:
- 3:24 PM Changeset in webkit [243832] by
-
- 11 edits4 adds in trunk/Source/JavaScriptCore
[JSC] Add FuzzerAgent, which has a hooks to get feedback & inject fuzz data into JSC
https://bugs.webkit.org/show_bug.cgi?id=196530
Reviewed by Saam Barati.
This patch adds FuzzerAgent interface and simple RandomizingFuzzerAgent to JSC.
This RandomizingFuzzerAgent returns random SpeculatedType for value profiling to find
the issues in JSC. The seed for randomization can be specified by seedOfRandomizingFuzzerAgent.
I ran this with seedOfRandomizingFuzzerAgent=1 last night and it finds 3 failures in the current JSC tests,
they should be fixed in subsequent patches.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
- runtime/FuzzerAgent.cpp: Added.
(JSC::FuzzerAgent::~FuzzerAgent):
(JSC::FuzzerAgent::getPrediction):
- runtime/FuzzerAgent.h: Added.
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/Options.h:
- runtime/RandomizingFuzzerAgent.cpp: Added.
(JSC::RandomizingFuzzerAgent::RandomizingFuzzerAgent):
(JSC::RandomizingFuzzerAgent::getPrediction):
- runtime/RandomizingFuzzerAgent.h: Added.
- runtime/RegExpCachedResult.h:
- runtime/RegExpGlobalData.cpp:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::fuzzerAgent const):
(JSC::VM::setFuzzerAgent):
- 3:16 PM Changeset in webkit [243831] by
-
- 2 edits in trunk/Source/WebCore/PAL
Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h
https://bugs.webkit.org/show_bug.cgi?id=196566
Reviewed by Timothy Hatcher.
- pal/spi/mac/NSMenuSPI.h:
- 3:07 PM Changeset in webkit [243830] by
-
- 97 edits19 deletes in trunk/Source/WebCore
Remove SVG properties tear-off objects
https://bugs.webkit.org/show_bug.cgi?id=191237
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-03
Reviewed by Simon Fraser.
This patch cleans the code from unused SVG sources and get rid off the
remaining SVG properties tear-off objects. Here are more details:
-- Remove the SVGAttributeAnimationController and move its code to the
SVGAnimateElementBase. SVGAttributeAnimationController was introduced
to allow animating the SVG properties whether they are backed by tear
off objects or not. Since there will be no tear off objects anymore,
one animation controller will be needed. But in this case, it will be
better if we make SVGAnimateElementBase is the animation controller
and make it manage the animator directly.
-- Remove SVGAttributeRegistry, SVGAttributeOwnerProxy and the virtual
function SVGElement::attributeOwnerProxy(). Remove also all the
overriding functions attributeOwnerProxy() from all the SVGElements.
-- Remove isKnownAttribute() from all the SVG header files except from
four classes: SVGURIReference, SVGFitToViewBox, SVGLangSpace
and SVGExternalResourcesRequired.
-- Remove all the SVG animated properties classifying functions from
SVGElement. This is now handled by SVGPropertyRegistry.
-- There is no need for the enum AnimatedPropertyType anymore. The SVG
property accessor knows its type, knows how to access it and know what
animator it should be created for it.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes const):
(WebCore::Element::synchronizeAttribute const):
(WebCore::Element::fastAttributeLookupAllowed const):
These functions are surprisingly marked 'const'. They were calling 'const'
functions in SVGElement and SVGElement was casting 'this' as non 'const'
before calling the non 'const' functions through the non 'const' 'this'
pointer. Change this by moving the casting to the Element functions.
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
- svg/SVGAElement.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::animator const):
(WebCore::SVGAnimateElementBase::hasInvalidCSSAttributeType const):
(WebCore::SVGAnimateElementBase::isDiscreteAnimator const):
(WebCore::SVGAnimateElementBase::setTargetElement):
(WebCore::SVGAnimateElementBase::setAttributeName):
(WebCore::SVGAnimateElementBase::resetAnimation):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::resetAnimatedType):
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
(WebCore::SVGAnimateElementBase::applyResultsToTarget):
(WebCore::SVGAnimateElementBase::clearAnimatedType):
(WebCore::SVGAnimateElementBase::calculateDistance):
(WebCore::SVGAnimateElementBase::attributeAnimationController): Deleted.
(WebCore::SVGAnimateElementBase::determineAnimatedPropertyType const): Deleted.
(WebCore::SVGAnimateElementBase::isAdditive const): Deleted.
- svg/SVGAnimateElementBase.h:
(WebCore::SVGAnimateElementBase::animatorIfExists const):
(WebCore::SVGAnimateElementBase::attributeAnimationControllerIfExists const): Deleted.
The order of the functions was changed to resemble the order of running
the animation:
-- Setting the animation range
-- Starting the animation
-- Progressing the animation
-- Applying the the progressed animaVal() to the target element
-- Stopping the animation
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::calculateDistance):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
(WebCore::SVGAnimationElement::shouldApplyAnimation): Deleted.
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::attributeRegistry): Deleted.
(WebCore::SVGAnimationElement::calculateDistance): Deleted.
- svg/SVGAttributeAnimationController.cpp: Removed.
- svg/SVGAttributeAnimationController.h: Removed.
- svg/SVGAttributeAnimationControllerBase.cpp: Removed.
- svg/SVGAttributeAnimationControllerBase.h: Removed.
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAttribute):
(WebCore::SVGElement::synchronizeAllAttributes):
(WebCore::SVGElement::synchronizeAllAnimatedSVGAttribute):
(WebCore::createAttributeNameToAnimatedPropertyTypeMap): Deleted.
(WebCore::attributeNameToAnimatedPropertyTypeMap): Deleted.
(WebCore::createCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): Deleted.
(WebCore::cssPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): Deleted.
(WebCore::SVGElement::animatedPropertyTypesForAttribute): Deleted.
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute const): Deleted.
(WebCore::SVGElement::isAnimatableCSSProperty): Deleted.
(WebCore::SVGElement::isPresentationAttributeWithSVGDOM): Deleted.
- svg/SVGElement.h:
(WebCore::SVGElement::attributeOwnerProxy const): Deleted.
(WebCore::SVGElement::attributeRegistry): Deleted.
(WebCore::SVGElement::synchronizeAttribute): Deleted.
(WebCore::SVGElement::synchronizeAttributes): Deleted.
(WebCore::SVGElement::animatedTypes const): Deleted.
(WebCore::SVGElement::lookupAnimatedProperty const): Deleted.
(WebCore::SVGElement::lookupOrCreateAnimatedProperty): Deleted.
(WebCore::SVGElement::lookupOrCreateAnimatedProperties): Deleted.
(WebCore::SVGElement::isKnownAttribute): Deleted.
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.h:
(WebCore::SVGExternalResourcesRequired::attributeRegistry): Deleted.
(WebCore::SVGExternalResourcesRequired::attributeOwnerProxy): Deleted.
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::attributeRegistry): Deleted.
- svg/SVGFitToViewBox.h:
(WebCore::SVGFitToViewBox::attributeRegistry): Deleted.
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGeometryElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
- svg/SVGGradientElement.h:
(WebCore::SVGGradientElement::attributeRegistry): Deleted.
(WebCore::SVGGradientElement::isKnownAttribute): Deleted.
- svg/SVGGraphicsElement.h:
(WebCore::SVGGraphicsElement::attributeRegistry): Deleted.
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPathElement.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGStopElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.h:
- svg/SVGTests.cpp:
(WebCore::SVGTests::svgAttributeChanged):
(WebCore::SVGTests::attributeRegistry): Deleted.
(WebCore::SVGTests::isKnownAttribute): Deleted.
- svg/SVGTests.h:
- svg/SVGTextContentElement.cpp:
- svg/SVGTextContentElement.h:
(WebCore::SVGTextContentElement::attributeRegistry): Deleted.
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.h:
(WebCore::SVGTextPositioningElement::attributeRegistry): Deleted.
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::SVGURIReference):
(WebCore::SVGURIReference::attributeRegistry): Deleted.
- svg/SVGURIReference.h:
- svg/SVGUseElement.h:
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h:
- svg/SVGZoomAndPanType.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h: Removed.
- svg/properties/SVGAnimatedPropertyAnimator.h:
- svg/properties/SVGAnimatedPropertyAnimatorImpl.h:
- svg/properties/SVGAnimatedPropertyPairAnimator.h:
- svg/properties/SVGAnimatedPropertyPairAnimatorImpl.h:
- svg/properties/SVGAnimatedPropertyTearOff.h: Removed.
- svg/properties/SVGAnimatedPropertyType.h: Removed.
- svg/properties/SVGAnimationAdditiveFunction.h:
(WebCore::SVGAnimationAdditiveFunction::animate):
(WebCore::SVGAnimationAdditiveFunction::progress): Deleted.
- svg/properties/SVGAnimationAdditiveListFunctionImpl.h:
(WebCore::SVGAnimationLengthListFunction::animate):
(WebCore::SVGAnimationNumberListFunction::animate):
(WebCore::SVGAnimationPointListFunction::animate):
(WebCore::SVGAnimationTransformListFunction::animate):
(WebCore::SVGAnimationLengthListFunction::progress): Deleted.
(WebCore::SVGAnimationNumberListFunction::progress): Deleted.
(WebCore::SVGAnimationPointListFunction::progress): Deleted.
(WebCore::SVGAnimationTransformListFunction::progress): Deleted.
- svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
(WebCore::SVGAnimationAngleFunction::animate):
(WebCore::SVGAnimationColorFunction::animate):
(WebCore::SVGAnimationIntegerFunction::animate):
(WebCore::SVGAnimationLengthFunction::animate):
(WebCore::SVGAnimationNumberFunction::animate):
(WebCore::SVGAnimationPathSegListFunction::animate):
(WebCore::SVGAnimationRectFunction::animate):
(WebCore::SVGAnimationAngleFunction::progress): Deleted.
(WebCore::SVGAnimationColorFunction::progress): Deleted.
(WebCore::SVGAnimationIntegerFunction::progress): Deleted.
(WebCore::SVGAnimationLengthFunction::progress): Deleted.
(WebCore::SVGAnimationNumberFunction::progress): Deleted.
(WebCore::SVGAnimationPathSegListFunction::progress): Deleted.
(WebCore::SVGAnimationRectFunction::progress): Deleted.
- svg/properties/SVGAnimationDiscreteFunction.h:
(WebCore::SVGAnimationDiscreteFunction::animate):
(WebCore::SVGAnimationDiscreteFunction::progress): Deleted.
- svg/properties/SVGAnimationFunction.h:
(WebCore::SVGAnimationFunction::calculateDistance const):
-- Rename the 'progress()' functions of SVGAttributeAnimator and SVGAnimationFunction
to 'animate()'.
-- Rename the argument 'percentage' of these function to 'progress'
-- Make calculateDistance return Optional<float> so it does not have to
return -1 in case of error.
- svg/properties/SVGAttribute.h: Removed.
- svg/properties/SVGAttributeAccessor.h: Removed.
- svg/properties/SVGAttributeAnimator.h:
(WebCore::SVGAttributeAnimator::calculateDistance const):
- svg/properties/SVGAttributeOwnerProxy.cpp: Removed.
- svg/properties/SVGAttributeOwnerProxy.h: Removed.
- svg/properties/SVGAttributeOwnerProxyImpl.h: Removed.
- svg/properties/SVGAttributeRegistry.h: Removed.
- svg/properties/SVGLegacyAnimatedProperty.cpp: Removed.
- svg/properties/SVGLegacyAnimatedProperty.h: Removed.
- svg/properties/SVGLegacyProperty.h: Removed.
- svg/properties/SVGListProperty.h: Removed.
- svg/properties/SVGListPropertyTearOff.h: Removed.
- svg/properties/SVGPrimitivePropertyAnimator.h:
- svg/properties/SVGProperty.h:
- svg/properties/SVGPropertyAnimator.h:
- svg/properties/SVGPropertyTearOff.h: Removed.
- svg/properties/SVGValuePropertyAnimator.h:
- svg/properties/SVGValuePropertyListAnimator.h:
- 3:04 PM Changeset in webkit [243829] by
-
- 12 edits in trunk/Source
Add SPI to disable legacy TLS fallback
https://bugs.webkit.org/show_bug.cgi?id=196549
<rdar://44979744>
Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-03
Reviewed by Geoffrey Garen.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _setAllowsTLSFallback:]):
(-[WKWebsiteDataStore _allowsTLSFallback]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier):
(WebKit::WebsiteDataStore::setAllowsTLSFallback):
(WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::allowsTLSFallback const):
(WebKit::WebsiteDataStore::networkingHasBegun):
(WebKit::WebsiteDataStore::finalizeApplicationIdentifiers): Deleted.
- 2:46 PM Changeset in webkit [243828] by
-
- 6 edits2 adds in trunk
Documents can be destroyed before their CSSFontFaceSet is destroyed
https://bugs.webkit.org/show_bug.cgi?id=195830
Reviewed by Darin Adler.
Source/WebCore:
CSSFontFaceSet has a raw pointer to its owning document. JS can keep the CSSFontFaceSet alive (by using FontFaceSet)
and can destroy the document at any time. When the document is destroyed, the link between the two objects needs to
be severed.
Test: fast/text/font-face-set-destroy-document.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
- css/CSSFontFace.h:
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::CSSFontFaceSet):
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
- css/CSSFontFaceSet.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSFontSelector.h:
- css/FontFace.cpp:
(WebCore::FontFace::FontFace):
LayoutTests:
- fast/text/font-face-set-destroy-document-expected.html: Added.
- fast/text/font-face-set-destroy-document.html: Added.
- 2:29 PM Changeset in webkit [243827] by
-
- 2 edits in trunk/LayoutTests
http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-but-access-from-wrong-frame.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=194164
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky timeout
- 2:03 PM Changeset in webkit [243826] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Single click on links in non-read-only TextEditors should not follow links
https://bugs.webkit.org/show_bug.cgi?id=123364
<rdar://problem/15323913>
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js:
(WI._updateModifierKeys):
Add classes to the body whenever alt, shift, or ctrl are pressed.
- UserInterface/Views/CodeMirrorEditor.js:
(WI.CodeMirrorEditor.create):
Add aread-onlyclass if theCodeMirroris readonly.
- UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.cm-s-default .cm-link,):
(.read-only.cm-s-default .cm-link:hover,):
(.cm-s-default .cm-link:hover,): Deleted.
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.set readOnly):
(WI.TextEditor.prototype._openClickedLinks):
- 1:49 PM Changeset in webkit [243825] by
-
- 2 edits in trunk/LayoutTests
Rebaseline scrollingcoordinator/scrolling-tree/fixed-inside-frame.html
https://bugs.webkit.org/show_bug.cgi?id=195254
Unreviewed test gardening.
- scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: Rebaselined test
- 1:37 PM Changeset in webkit [243824] by
-
- 2 edits in trunk/Source/WebCore
Follow up fix for r243807: Use MarkedArgumentBuffer instead of Vector for JSValue
https://bugs.webkit.org/show_bug.cgi?id=196547
Reviewed by Geoffrey Garen.
JSValue in Vector could be garbage collected because GC doesn't know Vector memory on C++ heap.
- bindings/js/JSIDBRequestCustom.cpp:
(WebCore::JSIDBRequest::result const):
- 1:27 PM Changeset in webkit [243823] by
-
- 2 edits in trunk/Tools
[ews-app] Status bubble should not display certain infrastructure status messages
https://bugs.webkit.org/show_bug.cgi?id=196550
Reviewed by Lucas Forschler.
Do not display the steps which are un-needed for end-user. This information is still avaiable
if the user click on the bubble and look at the Buildbot build.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._steps_messages):
(StatusBubble._should_display_step): Method to decide whether to display the step or not.
- 1:13 PM Changeset in webkit [243822] by
-
- 2 edits in trunk/Tools
[ews-build] Use https for sending data to ews-app
https://bugs.webkit.org/show_bug.cgi?id=196492
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/events.py:
- 1:08 PM Changeset in webkit [243821] by
-
- 4 edits in trunk
HTML fragment serialization should not strip whitespace from URL attribute values
https://bugs.webkit.org/show_bug.cgi?id=196551
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing. This test was already passing
in Gecko and Blink.
- web-platform-tests/domparsing/innerhtml-mxss.sub-expected.txt:
Source/WebCore:
HTML fragment serialization should not strip whitespace from URL attribute values as per:
WebKit was stripping such whitespace, Gecko and Blink are not. Align WebKit with other
browser engines and the specification.
No new tests, rebaselined existing test.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
- 1:04 PM Changeset in webkit [243820] by
-
- 9 edits in trunk/Source/WebCore
Crash in HTMLCanvasElement::createContext2d after the element got adopted to a new document
https://bugs.webkit.org/show_bug.cgi?id=196527
Reviewed by Antti Koivisto.
We need to update CanvasBase::m_scriptExecutionContext when HTMLCanvasElement moves from
one document to another. Fixed the bug by making CanvasBase::scriptExecutionContext make
a virtual function call instead of directly storing a raw pointer. In HTMLCanvasElement,
we use Node::scriptExecutionContext(). Use ContextDestructionObserver in CustomPaintCanvas
and OffscreenCanvas instead of a raw pointer.
Unfortunately, no new tests since there is no reproducible test case.
- html/CanvasBase.cpp:
(WebCore::CanvasBase::CanvasBase):
- html/CanvasBase.h:
(WebCore::CanvasBase::scriptExecutionContext const):
- html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::CustomPaintCanvas):
- html/CustomPaintCanvas.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
- html/HTMLCanvasElement.h:
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::OffscreenCanvas):
- html/OffscreenCanvas.h:
- 12:47 PM Changeset in webkit [243819] by
-
- 33 edits4 deletes in trunk
Remove support for -apple-trailing-word
https://bugs.webkit.org/show_bug.cgi?id=196525
Reviewed by Zalan Bujtas.
This CSS property is nonstandard and not used.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TrailingWord const): Deleted.
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForStyle):
- rendering/SimpleLineLayoutCoverage.cpp:
(WebCore::SimpleLineLayout::printReason):
- rendering/SimpleLineLayoutCoverage.h:
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakClear):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::BreakingContext::InlineIteratorHistory::InlineIteratorHistory): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::push): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::update): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::renderer const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::offset const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::atTextParagraphSeparator const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::previousInSameNode const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::get const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::current const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::historyLength const): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::moveTo): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::increment): Deleted.
(WebCore::BreakingContext::InlineIteratorHistory::clear): Deleted.
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord): Deleted.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::trailingWord const): Deleted.
(WebCore::RenderStyle::setTrailingWord): Deleted.
(WebCore::RenderStyle::initialTrailingWord): Deleted.
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
- rendering/style/StyleRareInheritedData.h:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebInspectorUI:
- UserInterface/Models/CSSKeywordCompletions.js:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
- fast/text/trailing-word-expected.html: Removed.
- fast/text/trailing-word.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/fast/text/trailing-word-parse-expected.txt: Removed.
- platform/mac/fast/text/trailing-word-parse.html: Removed.
- platform/win/TestExpectations:
- 12:38 PM Changeset in webkit [243818] by
-
- 4 edits in trunk/Source/WebCore
Use makePendingActivity in DOMCache
https://bugs.webkit.org/show_bug.cgi?id=196515
Reviewed by Geoffrey Garen.
No change of behavior, just modernizing the code.
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
- Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::match):
- 12:13 PM Changeset in webkit [243817] by
-
- 5 edits in trunk
[XML Parser] Insert the error message block when stopping parsing and an error occurred
https://bugs.webkit.org/show_bug.cgi?id=196546
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing. Both Gecko and Blink already passed
these checks.
- web-platform-tests/domparsing/DOMParser-parseFromString-xml-parsererror-expected.txt:
Source/WebCore:
Insert the error message block when stopping parsing and an error occurred. This is based
on the following Blink commit:
No new tests, rebaselined existing test.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end):
Avoid showing the error message block twice in some cases. No need to ever call
insertErrorMessageBlock() if we're already stopped since stopParsing() already
takes care of doing this.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::stopParsing):
When XMLDocumentParser::stopParsing() is called to stop parsing, call
insertErrorMessageBlock() to insert the <parsererror> element if an error
occurred.
- 11:05 AM Changeset in webkit [243816] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=192108
<rdar://problem/46685392>
Reviewed by Devin Rousso.
This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
working the same way as before the patch.
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.
- 11:03 AM Changeset in webkit [243815] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Adding myself to contributors.json.
Unreviewed contributors.json update.
- 10:54 AM Changeset in webkit [243814] by
-
- 2 edits in trunk/Tools
Add a test for DOMCache on multiple browsing in case of private browsing
https://bugs.webkit.org/show_bug.cgi?id=196524
Reviewed by Alex Christensen.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
- 10:48 AM Changeset in webkit [243813] by
-
- 8 edits11 adds1 delete in trunk/LayoutTests/imported/w3c
Re-sync web-platform-tests/domparsing from upstream
https://bugs.webkit.org/show_bug.cgi?id=196544
Reviewed by Alex Christensen.
Re-sync web-platform-tests/domparsing from upstream 3bfdeb8976fc5.
- web-platform-tests/domparsing/*: Updated
- web-platform-tests/interfaces/DOM-Parsing.idl: Added.
- 10:45 AM Changeset in webkit [243812] by
-
- 6 edits in trunk/Source/WebCore
Clear WorkerCacheStorageConnection callbacks on WorkerGlobalScope termination
https://bugs.webkit.org/show_bug.cgi?id=196521
Reviewed by Alex Christensen.
When the worker global scope is preparing for termination,
all ActiveDOMObjects are stopped.
At that time, the completion handlers related to
WorkerCacheStorageConnection should be cleared to be able to free
memory, and as they are now no-op anyway.
We clear the completion handlers once the active DOM objects are stopped
to limit the processing triggered by clearing them.
Introducing a new Stopped error code to handle this case.
Add an assertion so that this error does not surface to JS.
Covered by existing tests.
- Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::clearPendingRequests):
- Modules/cache/CacheStorageConnection.h:
- Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::errorToException):
- Modules/cache/DOMCacheEngine.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::prepareForTermination):
(WebCore::WorkerGlobalScope::stopIndexedDatabase):
- 10:37 AM Changeset in webkit [243811] by
-
- 7 edits in trunk/Source
Adopt new VCP SPI
https://bugs.webkit.org/show_bug.cgi?id=193357
<rdar://problem/43656651>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Enable VCP through VTB API with specific encoder id.
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::setApplicationStatus):
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
Source/WebCore:
Covered by existing tests.
- testing/Internals.cpp:
(WebCore::Internals::supportsVCPEncoder):
- 10:27 AM Changeset in webkit [243810] by
-
- 6 edits in trunk
Remove legacy webkitRequestAnimationFrame time quirk
https://bugs.webkit.org/show_bug.cgi?id=196458
<rdar://problem/49490207>
Reviewed by Simon Fraser.
Source/WebCore:
Remove legacy webkitRequestAnimationFrame time quirk and log a deprecation
warning whenever webkitRequestAnimationFrame is called.
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::requestAnimationFrame):
(WebCore::DOMWindow::webkitRequestAnimationFrame):
LayoutTests:
Rebaseline webkitRequestAnimationFrame layout test now that we log a deprecation
warning.
- fast/animation/request-animation-frame-prefix-expected.txt:
- 10:23 AM Changeset in webkit [243809] by
-
- 4 edits in trunk
Resurrect and fix layout test http/tests/adClickAttribution/store-ad-click-attribution.html
https://bugs.webkit.org/show_bug.cgi?id=196476
Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-03
Reviewed by Chris Dumez.
Source/WebKit:
Re-apply a change I reverted in r241754 now that it's safe to do so.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
LayoutTests:
- http/tests/adClickAttribution/store-ad-click-attribution-expected.txt:
- 10:06 AM Changeset in webkit [243808] by
-
- 14 edits1 copy3 adds in trunk
[iOS] Should be able to dismiss picker or popover using the keyboard
https://bugs.webkit.org/show_bug.cgi?id=196272
<rdar://problem/48943170>
Patch by Daniel Bates <dabates@apple.com> on 2019-04-03
Reviewed by Wenson Hsieh.
Source/WebKit:
Intercept key events and route them to the current input peripheral (if we have one). Add a base key event handler
for all form peripherals that dismisses the accessory when either the Escape key is pressed or Command + . is pressed.
I will fix this issue for the file upload picker/popover in <https://bugs.webkit.org/show_bug.cgi?id=196287>.
- SourcesCocoa.txt: Add file WKFormPeripheralBase.mm.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason]): Added.
(-[WKContentView resignFirstResponderForWebView]): Write in terms of -endEditingAndUpdateFocusAppearance.
(-[WKContentView inputView]): Code style nit while I am here; add an empty line to demarcate the "crazy"
code that the FIXME is referring to and should ideally be removed from the code that is sane to always do.
(-[WKContentView accessoryDone]): When the accessory is dismissed via the Done button (iPhone) or by pressing
Escape or Command + . using a hardware keyboard (iPhone or iPad) then end the current editing session, but
do not resign first responder status as the page activation state should not be changed.
(-[WKContentView _handleKeyUIEvent:]): Bring back this code when building with USE(UIKIT_KEYBOARD_ADDITIONS)
as we need to route key events to the input peripheral (if we have one). If the input peripheral handles it
then we're done: no need to let UIKit or WebKit handle it when building with USE(UIKIT_KEYBOARD_ADDITIONS),
respectively. If the input peripheral does not handle it then do what we do now.
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
If the element is re-focused and we have an input peripheral then we want to ensure we are first responder,
reveal the focused element, update the accessory and tell the peripheral that editing has begun (again).
For all other element re-focusing where we don't have a peripheral do what we do now. Also, update _isEditable
to reflect whether the focused element contains selectable text. This is what UIKit wants to know when it queries
-isEditable. Now that we no longer blur the focused element on iPad when the popover is dismissed and keep the
peripheral until there is a focus change we need to ensure that we give the correct answer to UIKit on view
editability. Otherwise, UIKit thinks it needs to update the text selection state when a popup button is tapped
again (as part of its gesture recognizer logic) and this causes an assertion failure in UIKit after it calls back
into us to ask for selection details, which we correctly respond with the equivalent of "we have none" and is
not the answer UIKit expects since we told it we are editable. (Currently we manage to get away with telling UIKit
we are always editable because it is not possible to perform a selection operation when we have a popover open.
Closing the popover blurs the element, setting -isEditable to NO and deallocates the peripheral avoiding this issue).
- UIProcess/ios/forms/WKFormColorControl.h:
- UIProcess/ios/forms/WKFormColorControl.mm:
(-[WKColorPopover controlEndEditing]): Dismiss the popover.
(-[WKFormColorControl initWithView:]): Modified to call base class initializer.
(-[WKFormColorControl assistantView]): Deleted.
(-[WKFormColorControl beginEditing]): Deleted.
(-[WKFormColorControl endEditing]): Deleted.
- UIProcess/ios/forms/WKFormInputControl.h:
- UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKFormInputControl initWithView:]): Modified to call base class initializer.
(-[WKFormInputControl dateTimePickerCalendarType]): Write in terms of self.control.
(-[WKDateTimePopover controlEndEditing]): Dismiss the popover and tell the controller that editing ended.
(-[WKFormInputControl beginEditing]): Deleted.
(-[WKFormInputControl endEditing]): Deleted.
(-[WKFormInputControl assistantView]): Deleted.
- UIProcess/ios/forms/WKFormPeripheral.h:
- UIProcess/ios/forms/WKFormPeripheralBase.h: Added.
- UIProcess/ios/forms/WKFormPeripheralBase.mm: Added.
(-[WKFormPeripheralBase initWithView:control:]): Take ownership of the passed WKFormControl.
(-[WKFormPeripheralBase beginEditing]): Turn around and tell the control.
(-[WKFormPeripheralBase endEditing]): Ditto.
(-[WKFormPeripheralBase assistantView]): Ditto.
(-[WKFormPeripheralBase control]): Return the control.
(-[WKFormPeripheralBase handleKeyEvent:]): Dismiss the accessory (in the same way we dismiss when the Done
button is pressed on iPhone) on keydown of the Escape key or when we receive a UIKeyInputEscape event (for
Command + .).
- UIProcess/ios/forms/WKFormSelectControl.h:
- UIProcess/ios/forms/WKFormSelectControl.mm:
(-[WKFormSelectControl initWithView:]): Modified to call base class initializer.
(-[WKFormSelectControl selectRow:inComponent:extendingSelection:]): Write in terms of self.control.
(-[WKFormSelectControl selectFormPopoverTitle]): Ditto.
(-[WKFormSelectControl assistantView]): Deleted.
(-[WKFormSelectControl beginEditing]): Deleted.
(-[WKFormSelectControl endEditing]): Deleted.
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover controlEndEditing]): Dismiss the popover.
- WebKit.xcodeproj/project.pbxproj: Add files WKFormPeripheralBase.{h, mm}.
LayoutTests:
Add test to ensure that pressing Escape or Command + . dismisses a picker.
- fast/forms/ios/dismiss-picker-using-keyboard-expected.txt: Added.
- fast/forms/ios/dismiss-picker-using-keyboard.html: Added.
- 10:03 AM Changeset in webkit [243807] by
-
- 31 edits3 adds in trunk
Blob type cannot be stored correctly in IDB when IDBObjectStore has autoIncrement and keyPath options
https://bugs.webkit.org/show_bug.cgi?id=196128
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Updated test expectations to PASS.
- web-platform-tests/IndexedDB/nested-cloning-large-expected.txt:
- web-platform-tests/IndexedDB/nested-cloning-large-multiple-expected.txt:
- web-platform-tests/IndexedDB/nested-cloning-small-expected.txt:
Source/WebCore:
If a key is auto-generated, it should become a property of the value object. Network process would perform the
key injection by deserializing IDBValue into script value, setting the property, serializing the result and
storing it in a database record. But network process does not have a JSDOMGlobalObject, so it would fail to
deserialize types including Blob and File.
To solve this issue, we move the key injection to web process and let network process store the original value
it gets. In this case, when web process asks for some value, network process should return key, value and key
path so that web process can decide whether it should perform a key injection before returning the result. Note
that the auto-generated key would always be stored as the key in a ObjectStore record.
Test: storage/indexeddb/modern/objectstore-autoincrement-types.html
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setGetResult):
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::primaryKeyPath):
- Modules/indexeddb/IDBGetAllResult.cpp:
(WebCore::IDBGetAllResult::isolatedCopy):
(WebCore::IDBGetAllResult::addKey):
(WebCore::IDBGetAllResult::addValue):
(WebCore::IDBGetAllResult::keys const):
(WebCore::IDBGetAllResult::values const):
(WebCore::IDBGetAllResult::allBlobFilePaths const):
(WebCore::isolatedCopyOfVariant): Deleted.
- Modules/indexeddb/IDBGetAllResult.h: Introduce an IDBKeyPath parameter. Also replace Variant with two Vectors,
because we only needed to store either key or value before, and now the stored value could be incomplete.
(WebCore::IDBGetAllResult::IDBGetAllResult):
(WebCore::IDBGetAllResult::keyPath const):
(WebCore::IDBGetAllResult::encode const):
(WebCore::IDBGetAllResult::decode):
- Modules/indexeddb/IDBGetResult.cpp:
(WebCore::IDBGetResult::setValue):
- Modules/indexeddb/IDBGetResult.h:
(WebCore::IDBGetResult::IDBGetResult):
(WebCore::IDBGetResult::keyPath const):
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::didGetAllRecordsOnServer):
(WebCore::IDBTransaction::didGetRecordOnServer):
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
- Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::getResultForKeyRange const):
(WebCore::IDBServer::MemoryIndex::getAllRecords const):
- Modules/indexeddb/server/MemoryIndexCursor.cpp:
(WebCore::IDBServer::MemoryIndexCursor::currentData):
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords):
(WebCore::IDBServer::MemoryObjectStore::getAllRecords const):
- Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:
(WebCore::IDBServer::MemoryObjectStoreCursor::currentData):
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::cachedStatementForGetAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::currentData):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): Remove the key injection from network process.
UniqueIDBDatabase stores any value it gets from IDBClient.
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::getResultRef):
- Modules/indexeddb/shared/IDBResultData.h:
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue): If property is read-only, set would fail and injectKeyIntoResult would
return null, but we expect it to return result as long as the property value is the same as target. Therefore,
we can add an early return here.
(WebCore::createKeyPathArray):
(WebCore::generateIndexKeyForValue): We used to generate IndexKey from value stored in database but now the
value gets stored does not include auto-generated key, as we remove the key injection from network process. In
this case if the IDBIndex has the same key path as the auto-generated key, IndexKey would be failed to create
for it cannot extract auto-generated key from value. Since the auto-generated key would always be the key in
database record, we could use value of that key when we find a match in key path.
(WebCore::deserializeIDBValueWithKeyInjection): If the key path in the result is single entry, the key is
probably auto-generated, so we could inject the result key into the result value unconditionally.
- bindings/js/IDBBindingUtilities.h:
- bindings/js/JSIDBCursorWithValueCustom.cpp:
(WebCore::JSIDBCursorWithValue::value const):
- bindings/js/JSIDBRequestCustom.cpp:
(WebCore::JSIDBRequest::result const):
LayoutTests:
- TestExpectations:
- storage/indexeddb/modern/objectstore-autoincrement-types-expected.txt: Added.
- storage/indexeddb/modern/objectstore-autoincrement-types.html: Added.
- storage/indexeddb/modern/resources/objectstore-autoincrement-types.js: Added.
(next):
(prepareDatabase.event.target.onsuccess):
(prepareDatabase):
(testSteps):
- 10:00 AM Changeset in webkit [243806] by
-
- 7 edits in trunk
Resetting quota should take into account third party origins
https://bugs.webkit.org/show_bug.cgi?id=196462
Reviewed by Geoffrey Garen.
Source/WebKit:
When clearing the storage quota, we were resetting it to the default value
without taking care of whether third party or not.
Updated the code to ensure that the default quota is computed based on the origin.
Updated existing test to cover this case.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearStorageQuota):
(WebKit::NetworkProcess::setCacheStorageParameters):
(WebKit::NetworkProcess::updateQuotaBasedOnSpaceUsageForTesting):
(WebKit::NetworkProcess::storageQuotaManager):
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::StorageQuotaManagers::defaultQuota const):
(WebKit::NetworkProcess::StorageQuotaManagers::setDefaultQuotas):
(WebKit::NetworkProcess::StorageQuotaManagers::managersPerOrigin):
LayoutTests:
- http/wpt/cache-storage/quota-third-party.https-expected.txt:
- http/wpt/cache-storage/quota-third-party.https.html:
- platform/mac-wk2/TestExpectations:
- 9:53 AM Changeset in webkit [243805] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening, update test expectations
- platform/gtk/TestExpectations:
- 9:41 AM WebKitGTK/2.24.x edited by
- (diff)
- 9:40 AM Changeset in webkit [243804] by
-
- 10 edits4 deletes in trunk
Get rid of HTMLInputElement::setEditingValue
https://bugs.webkit.org/show_bug.cgi?id=196402
Reviewed by Darin Adler.
Source/WebCore:
HTMLInputElement::setEditingValue is only used for Epiphany password autofill. We did it
this way because that's what Chrome uses for autofill, but Apple uses
HTMLInputElement::setValueForUser. Let's switch to that instead, then we can get rid of
setEditingValue.
This fixes logging into ting.com after username and password are autofilled by Epiphany.
Before this change, the login would fail unless you first manually edit either the username
or the password field.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setEditingValue): Deleted.
- html/HTMLInputElement.h:
- testing/Internals.cpp:
(WebCore::Internals::setEditingValue): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMElement.cpp:
(webkit_dom_element_html_input_element_set_editing_value):
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:
(webkit_dom_html_input_element_set_editing_value):
LayoutTests:
- fast/forms/editing-value-expected.txt: Removed.
- fast/forms/editing-value-null-renderer-expected.txt: Removed.
- fast/forms/editing-value-null-renderer.html: Removed.
- fast/forms/editing-value.html: Removed.
- 9:39 AM Changeset in webkit [243803] by
-
- 2 edits in trunk/Tools
[ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
https://bugs.webkit.org/show_bug.cgi?id=196540
Reviewed by Aakash Jain.
- EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
- 9:30 AM Changeset in webkit [243802] by
-
- 2 edits in trunk/LayoutTests
The following layout tests are flaky failures
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html
https://bugs.webkit.org/show_bug.cgi?id=195466
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations: Updating test expectations for flaky failures
- 9:14 AM Changeset in webkit [243801] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/wpt/resource-timing/rt-resources-per-worker.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=180260
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:02 AM Changeset in webkit [243800] by
-
- 2 edits in trunk/Source/WebKit
Add a WebKit internal feature flag to always enable modern compatibility mode by default
https://bugs.webkit.org/show_bug.cgi?id=196526
<rdar://problem/49532923>
Reviewed by Antoine Quint.
- Shared/WebPreferences.yaml:
- 8:58 AM Changeset in webkit [243799] by
-
- 2 edits in trunk/Source/WebCore
Missing includes that were previously provided via UnifiedSources
https://bugs.webkit.org/show_bug.cgi?id=196434
Unreviewed build fix.
Patch by Pablo Saavedra <Pablo Saavedra> on 2019-04-03
- html/InputType.h:
- 8:22 AM Changeset in webkit [243798] by
-
- 9 edits1 copy in trunk/Source
Introduce and add plumbing for a website policy for meta viewport tag handling
https://bugs.webkit.org/show_bug.cgi?id=196285
Reviewed by Tim Horton.
Source/WebCore:
Add MetaViewportPolicy to DocumentLoader. See WebKit ChangeLog for more detail.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::metaViewportPolicy const):
(WebCore::DocumentLoader::setMetaViewportPolicy):
Source/WebKit:
Add WebsiteMetaViewportPolicy, a bit that can be used to determine whether to respect or ignore the meta
viewport tag and use native web page parameters instead of the default parameters.
- Shared/WebsiteMetaViewportPolicy.h: Copied from Source/WebKit/Shared/WebsitePoliciesData.h.
- Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
Convert WebKit::WebsiteMetaViewportPolicy into WebCore::MetaViewportPolicy.
- Shared/WebsitePoliciesData.h:
- UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::data):
- UIProcess/API/APIWebsitePolicies.h:
Add additional plumbing for the policy flag.
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetViewportDefaultConfiguration):
Use native web page parameters if either "shouldIgnoreMetaViewport" is enabled, or the new policy is set.
Eventually, the policy should completely replace the former preference once no internal clients depend on it.
- 8:02 AM Changeset in webkit [243797] by
-
- 10 edits2 adds in trunk
Add plumbing for a compatibility mode preference in WebKit
https://bugs.webkit.org/show_bug.cgi?id=196005
Reviewed by Tim Horton.
Source/WebKit:
Add plumbing between the Cocoa API object (WKWebpagePreferences) and the inner C++ API object
(API::WebsitePolicies) for compatibility mode.
- Shared/WebCompatibilityMode.h: Added.
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/Cocoa/WKWebpagePreferences.mm:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::adjustPoliciesForCompatibilityMode):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
- WebKit.xcodeproj/project.pbxproj:
Tools:
Add new API tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
- 6:00 AM Changeset in webkit [243796] by
-
- 2 edits in trunk/Source/WebKit
[CoordinatedGraphics] Hidden pages are not suspended after a web view resize
https://bugs.webkit.org/show_bug.cgi?id=196487
Reviewed by Žan Doberšek.
When resizing the window, the hidden tabs are updated too, to avoid flickering or getting the old size when
switching tabs. For that we need to resume painting but we are not suspending it again after the update.
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState): Suspend the painting again after a
synchronous update if needed.
- 5:42 AM Changeset in webkit [243795] by
-
- 9 edits in trunk/Source
Web Inspector: Remote Inspector indicate callback should always happen on the main thread
https://bugs.webkit.org/show_bug.cgi?id=196513
<rdar://problem/49498284>
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::receivedIndicateMessage):
When we have a WebThread, don't just run on the WebThread,
run on the MainThread with the WebThreadLock.
Source/WebCore:
- platform/ios/wak/WebCoreThreadSystemInterface.cpp:
(InitWebCoreThreadSystemInterface):
Source/WTF:
- wtf/MainThread.h:
- wtf/cocoa/MainThreadCocoa.mm:
(WTF::dispatchAsyncOnMainThreadWithWebThreadLockIfNeeded):
- wtf/ios/WebCoreThread.cpp:
- wtf/ios/WebCoreThread.h:
- 1:33 AM Changeset in webkit [243794] by
-
- 3 edits in trunk/Tools
[WPE][GTK] Update libsrtp dependency package for Debian
https://bugs.webkit.org/show_bug.cgi?id=196528
Reviewed by Frédéric Wang.
- gtk/install-dependencies:
- wpe/install-dependencies:
- 1:25 AM Changeset in webkit [243793] by
-
- 3 edits in trunk/Source/WebKit
Web Inspector: [GTK] Copy copies to nowhere
https://bugs.webkit.org/show_bug.cgi?id=181228
Reviewed by Michael Catanzaro.
The thing is that those items are actually submenu items, with options, for example in the case of Copy to copy
HTML, Text, XPath, etc. We are not correctly handling submenus when populating the context menu received from
the web process.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::populateSubMenu): Helper to populate submenu items recursively.
(WebKit::WebContextMenuProxyGtk::populate): Handle submenu items.
- UIProcess/gtk/WebContextMenuProxyGtk.h:
Apr 2, 2019:
- 11:23 PM Changeset in webkit [243792] by
-
- 9 edits in tags/Safari-608.1.13.5
Cherry-pick r243711. rdar://problem/49245471
UIProcess crash when a prewarmed process is terminated
https://bugs.webkit.org/show_bug.cgi?id=196451
<rdar://problem/49245471>
Reviewed by Geoffrey Garen.
Source/WebKit:
Stop assuming that WebProcessProxy::m_websiteDataStore is non-null as this is no longer
true after r243384. For example, prewarmed WebContent processe do not get a data store
until they actually get used.
- UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _prewarmedProcessIdentifier]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::networkProcessIdentifier): (WebKit::WebProcessPool::prewarmedProcessIdentifier):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didClose): (WebKit::WebProcessProxy::didFinishLaunching): (WebKit::WebProcessProxy::requestTermination): (WebKit::WebProcessProxy::isReleaseLoggingAllowed const):
- UIProcess/WebProcessProxy.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:23 PM Changeset in webkit [243791] by
-
- 2 edits in tags/Safari-608.1.13.5/Source/WebKit
Cherry-pick r243606. rdar://problem/49229632
[iPad] Tapping on a popup form control may not show a popover
https://bugs.webkit.org/show_bug.cgi?id=196322
<rdar://problem/49229632>
Reviewed by Wenson Hsieh.
Stop taking advantage of -[WKContentView inputView] being called when we invoke -reloadInputViews
to "lazily" allocate the input peripheral for the currently focused element. In theory, UIKit only
needs to call -inputView when it actually needs to display the input view (the keyboard). For
popup menu buttons, like <select>, no keyboard is needed. Instead we should create the peripheral
as part of the logic in the UI process to focus a new element before we call -reloadInputViews.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView inputView]): Extract logic to allocate the peripheral from here and moved it to createInputPeripheralWithView(). (-[WKContentView accessoryTab:]): While I am here, add a FIXME comment to explain why we need to end the input sessions and nullify the input peripheral before we tell the web process to switch focus as opposed to letting this happen after the web process tells us it focused a new element. (createInputPeripheralWithView): Added. (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]): Write in terms of createInputPeripheralWithView(). Create the input peripheral after becoming first responder because creating the peripheral has known side-effects: for popup buttons it tells the popup controller to present the popover. For key input to popovers to work from the get-go, the content view must be the first responder. See <https://bugs.webkit.org/show_bug.cgi?id=196272> for more details.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:23 PM Changeset in webkit [243790] by
-
- 2 edits in tags/Safari-608.1.13.5/Source/WebKit
Cherry-pick r243485. rdar://problem/49083324
Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker
https://bugs.webkit.org/show_bug.cgi?id=196205
<rdar://problem/49083324>
Reviewed by Geoffrey Garen.
Update our FileUploadPanel code on iOS to properly deal with the MIME types containing
wild cards (e.g. "image/*") that are defined in the HTML specification:
Previously, we would fail to convert those to UTIs.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:19 PM Changeset in webkit [243789] by
-
- 7 edits in tags/Safari-608.1.13.5/Source
Versioning.
- 11:16 PM Changeset in webkit [243788] by
-
- 1 copy in tags/Safari-608.1.13.5
New tag.
- 9:58 PM Changeset in webkit [243787] by
-
- 13 edits in trunk/Source/WebKit
[Cocoa] Add new API around WKWebpagePreferences in WKNavigationDelegate and WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=196284
<rdar://problem/47228232>
Reviewed by Tim Horton.
Tests for both of these APIs will be added in a subsequent patch.
- Shared/API/Cocoa/WebKit.h:
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::defaultWebsitePolicies const):
(API::PageConfiguration::setDefaultWebsitePolicies):
- UIProcess/API/APIPageConfiguration.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
Add a new navigation delegate hook to allow clients to return a WKWebpagePreference targeting the given
navigation action.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
Add new API on WKWebViewConfiguration to specify a default WKWebpagePreference to use when navigating.
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration defaultWebpagePreferences]):
(-[WKWebViewConfiguration setDefaultWebpagePreferences:]):
- UIProcess/API/Cocoa/WKWebpagePreferences.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
Invoke the new WKWebpagePreferences-based navigation delegate method.
- WebKit.xcodeproj/project.pbxproj:
- mac/postprocess-framework-headers.sh:
- mac/replace-webkit-additions-in-framework-headers.sh: Added.
Move logic in the "Postprocess Framework Headers" step responsible for stripping away included files from
WebKitAdditions out into a separate build phase, called "Replace WebKitAdditions in Framework Headers". This
ensures headers attempting to include from WebKitAdditions have these additional statements removed.
- 9:20 PM Changeset in webkit [243786] by
-
- 3 edits2 adds in trunk
REGRESSION (r238266): Exchange 2013 Outlook Web Access displays partially blank page when creating new e-mail
https://bugs.webkit.org/show_bug.cgi?id=196522
Source/WebCore:
rdar://problem/49472941
Reviewed by Zalan Bujtas.
In this content a layer is composited to clip descendants, and has negative z-order children,
so we compute that it "paints into ancestor", and has a foreground layer. This combination doesn't
make sense, and when the layer becomes scrollable, we end up with bad paint phases on layers, and
fail to paint the contents.
Fix by ensuring that a layer has its own backing store if it requires a foreground layer
by virtue of having negative z-order children.
Test: compositing/backing/foreground-layer-no-paints-into-ancestor.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
LayoutTests:
Reviewed by Zalan Bujtas.
- compositing/backing/foreground-layer-no-paints-into-ancestor-expected.html: Added.
- compositing/backing/foreground-layer-no-paints-into-ancestor.html: Added.
- 8:46 PM Changeset in webkit [243785] by
-
- 2 edits in trunk/Source/WebCore
Cursor count badge reverts to Zero during Drag & Drop of multiple items.
https://bugs.webkit.org/show_bug.cgi?id=196511
Reviewed by Daniel Bates.
- page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag): Don't set m_numberOfItemsToBeAccepted to
zero when dragging to a non-file input element.
- 8:24 PM Changeset in webkit [243784] by
-
- 5 edits in trunk/Source/WebKit
Eliminate plugin sandbox exceptions
https://bugs.webkit.org/show_bug.cgi?id=196510
Reviewed by Chris Dumez.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldAllowPluginToRunUnsandboxed): Deleted.
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::shouldAllowPluginToRunUnsandboxed): Deleted.
- 6:56 PM Changeset in webkit [243783] by
-
- 2 edits in trunk/Tools
[WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478
<rdar://problem/49535124>
Unreviewed build fix for MSVC.
WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
- WebKitTestRunner/TestController.cpp:
(WTR::printFrame): Use int and float literals.
- 6:55 PM Changeset in webkit [243782] by
-
- 8 edits in trunk
HTML Parser: Remove conditional parsing of <noembed> content
https://bugs.webkit.org/show_bug.cgi?id=196514
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Resync WPT after https://github.com/web-platform-tests/wpt/pull/15471 to gain
test coverage. Both Gecko and Blink are passing the new check, only WebKit was
failing.
- web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
- web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
Source/WebCore:
Our HTML Parser has raw text handling for <noembed> content only if plugins are runnable.
However, the HTML specification doesn't ask such behavior [1], and it doesn't match to
our HTML serializer. We should always handle it as raw text.
Blink already made this change in https://chromium-review.googlesource.com/c/1477556.
[1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed
No new tests, updated existing test.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 5:44 PM Changeset in webkit [243781] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements: DOM breakpoint icon should stroke when hovering selection area
https://bugs.webkit.org/show_bug.cgi?id=196516
<rdar://problem/49540494>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeContentView.css:
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, .hovered) .status-image.breakpoint,): Added.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, .hovered) .status-image.breakpoint.subtree): Added.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, :hover) .status-image.breakpoint): Deleted.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, :hover) .status-image.breakpoint.subtree): Deleted.
- 5:26 PM Changeset in webkit [243780] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG Animation (SMIL) on <text> or <tspan> doesn't work on second run
https://bugs.webkit.org/show_bug.cgi?id=150388
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-02
Reviewed by Simon Fraser.
The bug is fixed by removing the SVG tear off objects. See
https://bugs.webkit.org/show_bug.cgi?id=191237.
We need to add a layout test to ensure that no code change will break
this scenario in the future.
- svg/animations/smil-multiple-animate-list-expected.svg: Added.
- svg/animations/smil-multiple-animate-list.svg: Added.
- 5:04 PM Changeset in webkit [243779] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=196517
Unreviewed test gardening.
- platform/mac/TestExpectations: Skipping test for flaky crashing
- 5:04 PM Changeset in webkit [243778] by
-
- 3 edits in branches/safari-607-branch/LayoutTests
Cherry-pick r240492. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Gardening)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed test gardening.
- platform/ios/TestExpectations: Remove non-existant directories.
- platform/mac/TestExpectations: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243777] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240339. rdar://problem/49539128
webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
https://bugs.webkit.org/show_bug.cgi?id=193722
<rdar://problem/47481475>
Reviewed by Lucas Forschler.
iPhone and iPad ports should both use the iOS config.
- Scripts/webkitpy/port/ios_simulator.py: (IPhoneSimulatorPort.init): (IPadSimulatorPort.init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243776] by
-
- 4 edits in branches/safari-607-branch/Tools
Cherry-pick r240163. rdar://problem/49539128
webkitpy: Add iPhone and iPad ports
https://bugs.webkit.org/show_bug.cgi?id=193537
<rdar://problem/47353390>
Reviewed by Lucas Forschler.
Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
ports. Note that this separation is optional, the --ios-simulator command remains.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_device_type_test_division): Drive-by fix. (RunTest.test_device_type_specific_listing): Ditto. (RunTest.test_ipad_test_division): (RunTest): (RunTest.test_ipad_listing):
- Scripts/webkitpy/port/factory.py: (platform_options): Add --iphone-simulator and --ipad-simulator flags. (PortFactory):
- Scripts/webkitpy/port/ios_simulator.py: (IPhoneSimulatorPort): (IPadSimulatorPort):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243775] by
-
- 1 edit2 deletes in branches/safari-607-branch/LayoutTests
Cherry-pick r240157. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed test gardening.
- tiled-drawing/ios/iphone7: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243774] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240153. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed infrastructure fix.
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): Don't boot a device if no tests are available to run on it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243773] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240151. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed infrastructure fix.
- Scripts/webkitpy/api_tests/manager.py: (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243772] by
-
- 24 edits43 moves19 adds in branches/safari-607-branch
Cherry-pick r240150. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Rubber-stamped by Aakash Jain.
Tools:
This change uses device_type to select a different set of TestExpectation files based on the type of device running
tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: (LayoutTestFinder.find_tests): Pass device_type through.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.init): Make _expectations an OrderedDict indexed by device_type, add current_device_type. (Manager._collect_tests): Pass device type to test finder. (Manager._needs_web_platform_test): (Manager._prepare_lists): Index _expectations by device type. (Manager._test_input_for_file): (Manager._test_is_slow): Ditto. (Manager._test_should_dump_jsconsolelog_in_stderr): (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto. (Manager._get_test_inputs): (Manager._update_worker_count): (Manager._set_up_run): Use current_device_type instead of passing device_type in. (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event that a test can be run on multiple device types, the first device in the device type list which is eligible will be the one which runs the test. (Manager._run_test_subset): (Manager._run_tests): Index _expectations by current_device_type. (Manager._print_expectation_line_for_test): Ditto. (Manager._print_expectations_for_subset): Ditto. (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths. Unlike run, this function will behave the same regardless of what devices are available. (Manager._custom_device_for_test): Deleted.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_uses_custom_device): Deleted. (ManagerTest.test_uses_custom_device.get_manager): Deleted.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: (JSONLayoutResultsGenerator.init): Pass expectations as a dictionary indexed by device type. (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration all of the expectations.
- Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: (FakePort.skipped_layout_tests): Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.init): Allow device_type to be passed through. (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results):
- Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation a test ran with, one must check all expectations to find the first non-skip expectation.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_device_type_test_division): (RunTest): (RunTest.test_device_type_specific_listing):
- Scripts/webkitpy/port/base.py: (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES. (Port.supported_device_types): The result of this function will change based on what devices are available.
- Scripts/webkitpy/port/device_port.py: (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE. (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object can be used. (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are any, or the DEFAULT_DEVICE_TYPES of the port.
- Scripts/webkitpy/port/ios.py: (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
- Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
- Scripts/webkitpy/port/watch.py: (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
- Scripts/webkitpy/port/watch_simulator.py: (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
- Scripts/webkitpy/xcode/device_type.py: (DeviceType): (DeviceType.hash): Allow DeviceType to be used as a dictionary index.
LayoutTests:
Move iPad and iPhone 7 tests to their respective platform specific directories.
- TestExpectations:
- fast/events/touch/ios/iphone7: Removed.
- fast/forms/ios/ipad: Removed.
- fast/text-autosizing/ios/ipad: Removed.
- fast/viewport/ios/ipad: Removed.
- media/controls/ipad: Removed.
- media/modern-media-controls/media-documents/ipad: Removed.
- media/modern-media-controls/pip-support/ipad: Removed.
- platform/ios-wk1/TestExpectations:
- platform/ios/TestExpectations:
- platform/ipad: Added.
- platform/ipad/fast: Added.
- platform/ipad/fast/forms: Added.
- platform/ipad/fast/forms/choose-select-option-expected.txt: Added.
- platform/ipad/fast/forms/choose-select-option.html: Added.
- platform/ipad/fast/forms/focus-input-via-button-expected.txt: Added.
- platform/ipad/fast/forms/focus-input-via-button.html: Added.
- platform/ipad/fast/forms/multiple-select-updates-renderer-expected.txt: Added.
- platform/ipad/fast/forms/multiple-select-updates-renderer.html: Added.
- platform/ipad/fast/forms/select-form-run-twice-expected.txt: Added.
- platform/ipad/fast/forms/select-form-run-twice.html: Added.
- platform/ipad/fast/forms/select-with-title-expected.txt: Added.
- platform/ipad/fast/forms/select-with-title.html: Added.
- platform/ipad/fast/forms/unfocus-inside-fixed-hittest-expected.txt: Added.
- platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html: Added.
- platform/ipad/fast/text-autosizing: Added.
- platform/ipad/fast/text-autosizing/programmatic-text-size-adjust-expected.txt: Added.
- platform/ipad/fast/text-autosizing/programmatic-text-size-adjust.html: Added.
- platform/ipad/fast/text-autosizing/text-size-adjust-inline-style-expected.html: Added.
- platform/ipad/fast/text-autosizing/text-size-adjust-inline-style.html: Added.
- platform/ipad/fast/viewport: Added.
- platform/ipad/fast/viewport/empty-meta-expected.txt: Added.
- platform/ipad/fast/viewport/empty-meta.html: Added.
- platform/ipad/fast/viewport/meta-viewport-ignored-expected.txt: Added.
- platform/ipad/fast/viewport/meta-viewport-ignored.html: Added.
- platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport-expected.txt: Added.
- platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html: Added.
- platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-expected.txt: Added.
- platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html: Added.
- platform/ipad/fast/viewport/width-is-device-width-expected.txt: Added.
- platform/ipad/fast/viewport/width-is-device-width.html: Added.
- platform/ipad/media: Added.
- platform/ipad/media/controls: Added.
- platform/ipad/media/controls/close-page-with-picture-in-picture-video-assertion-failure-expected.txt: Added.
- platform/ipad/media/controls/close-page-with-picture-in-picture-video-assertion-failure.html: Added.
- platform/ipad/media/controls/resources: Added.
- platform/ipad/media/controls/resources/picture-in-picture.html: Added.
- platform/ipad/media/modern-media-controls: Added.
- platform/ipad/media/modern-media-controls/media-documents: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
- platform/ipad/media/modern-media-controls/pip-support: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled-expected.txt: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-tap-expected.txt: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-tap.html: Added.
- platform/iphone-7: Added.
- platform/iphone-7/fast: Added.
- platform/iphone-7/fast/events: Added.
- platform/iphone-7/fast/events/touch: Added.
- platform/iphone-7/fast/events/touch/force-press-event-expected.txt: Added.
- platform/iphone-7/fast/events/touch/force-press-event.html: Added.
- platform/iphone-7/fast/events/touch/force-press-on-link-expected.txt: Added.
- platform/iphone-7/fast/events/touch/force-press-on-link.html: Added.
- platform/iphone-7/fast/events/touch/prevent-default-touchmove-prevents-scrolling-expected.txt: Added.
- platform/iphone-7/fast/events/touch/prevent-default-touchmove-prevents-scrolling.html: Added.
- platform/iphone-7/tiled-drawing: Added.
- platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt: Added.
- platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- tiled-drawing/ios: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243771] by
-
- 19 edits in branches/safari-607-branch/Tools
Cherry-pick r239989. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=192162
Reviewed by Lucas Forschler.
Device type specific expected results covers two related ideas. The first (covered by this change)
is where to search for -expected.* files. The second is which tests to run based on the
TestExpectations.txt file.
After this change, the baseline search path will be determined by the type of device running a
test. Device type will be passed into any function which picks a file based on the baseline search
path.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): Print baseline search path for each round of devices.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.init): Pass device_type into expected_*(...). (SingleTestRunner._expected_driver_output): Ditto. (SingleTestRunner._driver_input): Ditto.
- Scripts/webkitpy/layout_tests/views/printing.py: (Printer.print_config): Move printing of baseline search path to a separate function. (Printer.print_baseline_search_path): Moved from Printer.print_config.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py: (Testprinter.test_print_config): (Testprinter.test_print_baseline_search_path):
- Scripts/webkitpy/port/base.py: (Port.baseline_search_path): Pass device_type through. (Port._expected_baselines_for_suffixes): Ditto. (Port.expected_baselines): Ditto. (Port.expected_filename): Ditto. (Port.expected_checksum): Ditto. (Port.expected_image): Ditto. (Port.expected_audio): Ditto. (Port.expected_text): Ditto. (Port.reference_files): Ditto. (Port.tests): Ditto. (Port._expanded_paths): Ditto. (Port.skipped_layout_tests): Ditto. (Port.expectations_dict): Ditto. (Port._port_specific_expectations_files): Ditto. (Port.expectations_files): Ditto. (Port.test_search_path): Ditto. (Port._tests_for_other_platforms): Ditto.
- Scripts/webkitpy/port/base_unittest.py: (PortTest.test_additional_platform_directory): Accept, but do not use, device_type. (PortTest.test_nonexistant_expectations): Ditto. (test_ref_tests_platform_directory): Ditto.
- Scripts/webkitpy/port/darwin.py: (DarwinPort._port_specific_expectations_files): Accept device_type.
- Scripts/webkitpy/port/driver.py: (DriverProxy): (DriverProxy.host): Expose _target_host for device_type information.
- Scripts/webkitpy/port/gtk.py: (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
- Scripts/webkitpy/port/ios.py: (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/mac.py: (MacPort. default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/port_testcase.py: (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/port/watch.py: (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/win.py: (WinPort.test_search_path): Accept, but do not use, device_type.
- Scripts/webkitpy/port/wpe.py: (WPEPort._port_specific_expectations_files): Ditto.
- Scripts/webkitpy/tool/servers/rebaselineserver.py: (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243770] by
-
- 6 edits in branches/safari-607-branch/Tools
Cherry-pick r239945. rdar://problem/49539128
webkitpy: Expose device_type from host-like objects
https://bugs.webkit.org/show_bug.cgi?id=193406
<rdar://problem/47262305>
Reviewed by Lucas Forschler.
Devices should expose device_type. As a result, all host objects should
provide a device_type property, even if they do not yet define a device_type.
- Scripts/webkitpy/common/system/systemhost.py: (SystemHost): (SystemHost.device_type):
- Scripts/webkitpy/common/system/systemhost_mock.py: (MockSystemHost): (MockSystemHost.device_type):
- Scripts/webkitpy/port/device.py: (Device): (Device.device_type):
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._find_exisiting_device_for_request): (SimulatedDeviceManager._disambiguate_device_type): (SimulatedDeviceManager._does_fulfill_request): (SimulatedDeviceManager.device_count_for_type): (SimulatedDeviceManager.initialize_devices):
- Scripts/webkitpy/xcode/simulated_device_unittest.py: (test_available_devices): (test_swapping_devices):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:03 PM Changeset in webkit [243769] by
-
- 10 edits in branches/safari-607-branch/Tools
Cherry-pick r239875. rdar://problem/49539128
webkitpy: Incorporate device type into baseline search path
https://bugs.webkit.org/show_bug.cgi?id=193356
<rdar://problem/47215515>
Reviewed by Lucas Forschler.
We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
- Scripts/webkitpy/port/base.py: (Port.default_baseline_search_path): Allow device type to be passed in.
- Scripts/webkitpy/port/gtk.py: (GtkPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/ios.py: (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path. (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
- Scripts/webkitpy/port/ios_device_unittest.py: (IOSDeviceTest):
- Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest):
- Scripts/webkitpy/port/mac.py: (MacPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/watch.py: (WatchPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/win.py: (WinPort.default_baseline_search_path): Ditto. (WinCairoPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/wpe.py: (WPEPort.default_baseline_search_path): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:33 PM Changeset in webkit [243768] by
-
- 2 edits in trunk/LayoutTests
[Mojave] Layout test fast/text/complex-initial-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=196512
Unreviewed test gardening.
- platform/mac/TestExpectations: Mark test as failing.
- 4:11 PM Changeset in webkit [243767] by
-
- 8 edits in trunk
Fix assertion in http/tests/adClickAttribution/store-ad-click-attribution.html
https://bugs.webkit.org/show_bug.cgi?id=196503
Reviewed by Chris Dumez.
Source/WebKit:
In WebPageProxy::didDestroyNavigation we try to ignore a request to destroy a navigation from a page being navigated from
during a cross-site navigation, but if the old web process sends the message after WebPageProxy::commitProvisionalPage
has been called, we can still destroy a navigation when we are continuing a navigation in another process. To prevent this,
have the process not send the message when it knows the navigation is continuing in another process.
Also make the use of unchecked navigation pointers more robust by checking it for nullity.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
(WebKit::WebFrame::documentLoaderDetached):
- WebProcess/WebPage/WebFrame.h:
LayoutTests:
- http/tests/adClickAttribution/store-ad-click-attribution-expected.txt:
- http/tests/adClickAttribution/store-ad-click-attribution.html:
- platform/wk2/TestExpectations:
- 4:07 PM Changeset in webkit [243766] by
-
- 2 edits in trunk/Tools
[ews-build] Reassign bots to queues
- BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
- 4:00 PM Changeset in webkit [243765] by
-
- 14 edits in trunk
XMLHttpRequestUpload's loadstart event not correct initialized
https://bugs.webkit.org/show_bug.cgi?id=196174
<rdar://problem/49191412>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/xhr/event-error-order.sub.html:
Update test after https://github.com/web-platform-tests/wpt/pull/13365
- web-platform-tests/xhr/abort-during-upload-expected.txt:
- web-platform-tests/xhr/event-error-order.sub-expected.txt:
- web-platform-tests/xhr/event-loadstart-upload-expected.txt:
- web-platform-tests/xhr/event-timeout-order-expected.txt:
- web-platform-tests/xhr/send-response-event-order-expected.txt:
Rebaseline several WPT tests that are now passing.
Source/WebCore:
Align progress event firing with the XHR specification.
No new tests, rebaselined existing tests.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
As per [1], the loadstart event fired on the XMLHttpRequestUpload object should use
loaded=0 and total=req’s body’s total bytes.
[1] https://xhr.spec.whatwg.org/#the-send()-method (step 11.2.)
(WebCore::XMLHttpRequest::didSendData):
As per [2], the progress / load / loadend should use loaded=transmitted and total=length.
[2] https://xhr.spec.whatwg.org/#ref-for-process-request-end-of-body (steps 5, 6 and 7)
(WebCore::XMLHttpRequest::didReceiveData):
As per [3], we should fire the readystatechange event *before* the progress event.
This is covered by web-platform-tests/xhr/send-response-event-order.htm which was failing
differently after the other changes in this patch.
[3] https://xhr.spec.whatwg.org/#ref-for-process-response (steps 9.4 and 9.5)
(WebCore::XMLHttpRequest::dispatchErrorEvents):
As per [4], in case of an error, we should fire the provided 'event' and 'loadend' with
loaded=0 and total=0.
[4] https://xhr.spec.whatwg.org/#request-error-steps (steps 7 and 8)
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h:
Simplify XMLHttpRequestUpload. It no longer needs to store loaded / total as data
members now that they are always passed by the call site. lengthComputable is set
to !!total as [5] says to set it to true if length/total is not 0.
[5] https://xhr.spec.whatwg.org/#concept-event-fire-progress
- 3:39 PM Changeset in webkit [243764] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Fix iokit-get-properties sandbox violation in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=196500
<rdar://problem/49497788>
Reviewed by Brent Fulgham.
Attempting to get the iokit properties 'product-description', 'artwork-display-gamut' and
'artwork-scale-factor' is causing sandbox violations.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:19 PM Changeset in webkit [243763] by
-
- 24 edits1 copy3 adds in trunk
Web Inspector: Canvas: add support for showing WebGPU contexts
https://bugs.webkit.org/show_bug.cgi?id=196413
<rdar://problem/49438898>
Reviewed by Timothy Hatcher.
Source/WebCore:
Tests: inspector/canvas/create-context-webgpu.html
inspector/canvas/resolveCanvasContext-webgpu.html
- Modules/webgpu/GPUCanvasContext.idl:
- Modules/webgpu/GPUCanvasContext.h:
(WebCore::GPUCanvasContext::canvas const): Added.
- Modules/webgpu/GPUCanvasContext.cpp:
(WebCore::GPUCanvasContext::create):
- testing/InternalSettings.idl:
- testing/InternalSettings.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setWebGPUEnabled): Added.
LayoutTests:
- inspector/canvas/create-context-webgpu.html: Added.
- inspector/canvas/create-context-webgpu-expected.txt: Added.
- inspector/canvas/resolveCanvasContext-webgpu.html: Added.
- inspector/canvas/resolveCanvasContext-webgpu-expected.txt: Added.
- inspector/canvas/resources/create-context-utilities.js:
(createDetachedCanvas):
(createCSSCanvas):
(destroyCanvases):
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.initializeTestSuite): Added.
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.addSimpleTestCase): Added.
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.addCSSCanvasTestCase): Added.
(TestPage.registerInitializer.window.initializeTestSuite): Deleted.
(TestPage.registerInitializer.window.addSimpleTestCase): Deleted.
(TestPage.registerInitializer.window.addCSSCanvasTestCase): Deleted.
- inspector/canvas/create-context-2d.html:
- inspector/canvas/create-context-2d-expected.txt:
- inspector/canvas/create-context-bitmaprenderer.html:
- inspector/canvas/create-context-bitmaprenderer-expected.txt:
- inspector/canvas/create-context-webgl.html:
- inspector/canvas/create-context-webgl-expected.txt:
- inspector/canvas/create-context-webgl2.html:
- inspector/canvas/create-context-webgl2-expected.txt:
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wpe/TestExpectations:
- 2:43 PM Changeset in webkit [243762] by
-
- 22 edits2 adds in trunk
[WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.https-expected.txt:
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub-expected.txt:
- web-platform-tests/html/browsers/the-window-object/window-properties.https-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt:
Source/WebCore:
Add support for Window's beforeprint / afterprint events as per:
Blink and Gecko already support this.
Test: printing/printing-events.html
- dom/EventNames.h:
- html/HTMLAttributeNames.in:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::createWindowEventHandlerNameMap):
- page/Page.cpp:
(WebCore::dispatchPrintEvent):
(WebCore::Page::dispatchBeforePrintEvent):
(WebCore::Page::dispatchAfterPrintEvent):
- page/Page.h:
- page/WindowEventHandlers.idl:
Source/WebKit:
Add support for Window's beforeprint / afterprint events as per:
Blink and Gecko already support this.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::endPrinting):
Tools:
Add minimal implementation for printFrame in WebKitTestRunner.
- WebKitTestRunner/TestController.cpp:
(WTR::printFrame):
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
LayoutTests:
Add layout test coverage.
- TestExpectations:
- platform/wk2/TestExpectations:
- printing/printing-events-expected.txt: Added.
- printing/printing-events.html: Added.
- 2:15 PM Changeset in webkit [243761] by
-
- 2 edits in trunk/Tools
[ews-app] Status bubble hover over message should clearly indicate that build is in-progress
https://bugs.webkit.org/show_bug.cgi?id=196491
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
- 2:11 PM Changeset in webkit [243760] by
-
- 3 edits2 adds in trunk
[ContentChangeObserver] Hover menus do not function on fidelity.com
https://bugs.webkit.org/show_bug.cgi?id=196507
<rdar://problem/49496520>
Reviewed by Simon Fraser.
Source/WebCore:
fidelity.com has 400ms hover intent timer to bring up the main menus.
Test: fast/events/touch/ios/content-observation/400ms-hover-intent.html
- page/ios/ContentChangeObserver.cpp:
LayoutTests:
- fast/events/touch/ios/content-observation/400ms-hover-intent-expected.txt: Added.
- fast/events/touch/ios/content-observation/400ms-hover-intent.html: Added.
- 2:09 PM Changeset in webkit [243759] by
-
- 4 edits in trunk/Tools
[ews-build] Configure buildbot try credentials in environment variables
https://bugs.webkit.org/show_bug.cgi?id=196501
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
- BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
- BuildSlaveSupport/ews-app/ews/config.py: Ditto.
- 2:06 PM Changeset in webkit [243758] by
-
- 2 edits in trunk/Source/WebCore
NSAttributedString crashes when encoding text attachment cell for missing image.
https://bugs.webkit.org/show_bug.cgi?id=196504
rdar://problem/49161281
Reviewed by Tim Horton.
Clean up and fix a couple of errors and crashes in the missing image path of our
attributed string converter.
Fixes include:
- Removed manual call to release on a RetainPtr, leading to autorelease pool crash.
- No longer try to load an image that is missing on disk and has long been renamed.
- No longer use a NSTextAttachmentCell in the Mac code path which can't be encoded for sending to the UIProcess, so it was pretty useless in the web content process.
- Stopped using NSFileWrapper for the missing image so the attachment can contain the retina versions of the missing image.
- Simplified bundle finding code, since WebCore is assumed to be loaded.
- Fix leak of attachment by adding missing adoptNS().
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addAttachmentForElement): Unify and simplify missing image path.
(_NSFirstPathForDirectoriesInDomains): Deleted.
(_NSSystemLibraryPath): Deleted.
(_webKitBundle): Deleted.
- 1:48 PM Changeset in webkit [243757] by
-
- 4 edits in trunk
[Fetch API] Allow used body replacement in Request constructor
https://bugs.webkit.org/show_bug.cgi?id=183703
<rdar://problem/49425609>
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline WPT test now that one more check is passing.
- web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
Source/WebCore:
Allow used body replacement in Request constructor as per:
No new tests, rebaseline existing test.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::initializeWith):
- 1:30 PM Changeset in webkit [243756] by
-
- 15 edits in trunk
Unreviewed, rolling out r243551.
Seems to have broken file uploads to SoundCloud
Reverted changeset:
"XMLHttpRequestUpload's loadstart event not correct
initialized"
https://bugs.webkit.org/show_bug.cgi?id=196174
https://trac.webkit.org/changeset/243551
- 12:59 PM Changeset in webkit [243755] by
-
- 20 edits4 copies4 adds in trunk
Source/WebCore:
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=196474
Reviewed by Myles C. Maxfield.
Blend states and color write masks must now be specified on GPUColorStateDescriptor instead of
relying on underlying MTLRenderPipelineColorAttachmentDescriptor defaults.
Test: webgpu/blend-triangle-strip.html, webgpu/color-write-mask-triangle-strip.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webgpu/GPUBlendDescriptor.idl:
- Modules/webgpu/GPUColorStateDescriptor.idl:
- Modules/webgpu/GPUColorWriteBits.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- platform/graphics/gpu/GPUBlendDescriptor.h:
- platform/graphics/gpu/GPUColorStateDescriptor.h:
- platform/graphics/gpu/GPUColorWriteBits.h:
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::mtlColorWriteMaskForGPUColorWriteFlags):
(WebCore::mtlBlendOperationForGPUBlendOperation):
(WebCore::mtlBlendFactorForGPUBlendFactor):
(WebCore::setColorStatesForColorAttachmentArray):
(WebCore::tryCreateMtlRenderPipelineState):
(WebCore::trySetColorStatesForColorAttachmentArray): Deleted.
LayoutTests:
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=196474
Reviewed by Myles C. Maxfield.
Add blend-triangle-strip to test color blending and color-write-mask-triangle-strip.html to test color write mask.
Update other tests to specify blend states when creating a GPURenderPipeline.
- webgpu/blend-triangle-strip-expected.html: Added.
- webgpu/blend-triangle-strip.html: Added.
- webgpu/buffer-command-buffer-races.html:
- webgpu/buffer-resource-triangles.html:
- webgpu/color-write-mask-triangle-strip-expected.html: Added.
- webgpu/color-write-mask-triangle-strip.html: Added.
- webgpu/depth-enabled-triangle-strip.html:
- webgpu/js/webgpu-functions.js:
- webgpu/render-pipelines.html:
- webgpu/texture-triangle-strip.html:
- webgpu/vertex-buffer-triangle-strip.html:
- webgpu/whlsl.html:
- 12:56 PM Changeset in webkit [243754] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in Options::setOptions() using --configFile option and libgmalloc
https://bugs.webkit.org/show_bug.cgi?id=196506
Reviewed by Keith Miller.
Changed to call CString::data() while making the call to Options::setOptions(). This keeps
the implicit CString temporary alive until after setOptions() returns.
- runtime/ConfigFile.cpp:
(JSC::ConfigFile::parse):
- 12:46 PM Changeset in webkit [243753] by
-
- 4 edits in trunk
REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
https://bugs.webkit.org/show_bug.cgi?id=196496
<rdar://problem/49521634>
Reviewed by Chris Dumez.
Source/WebKit:
r243726 made an incorrect assumption that all callers of -decidePolicyForNavigationAction:decisionHandler: and
-decidePolicyForNavigationAction:userInfo:decisionHandler: must be instances of _WKWebsitePolicies, as opposed
to the new WKWebpagePreferences. However, it's possible for clients (in this case, Safari) to already generate
and pass in an instance of WKWebpagePreferences by bridging the C API opaque ref (WKWebsitePoliciesRef) into the
Objective-C object (which is now WKWebpagePreferences, after my change).
To maintain binary compatibility of trunk WebKit against prior versions of Safari, we need to handle both
WKWebpagePreferences and the soon-to-be-deprecated _WKWebsitePolicies in the navigation action policy decision
handler.
Tests: WebKit.WebsitePoliciesWithBridgingCast
WebKit.WebsitePoliciesWithUnexpectedType
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
Tools:
Add new API tests (see WebKit ChangeLog for more detail).
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(TEST):
- 12:43 PM Changeset in webkit [243752] by
-
- 5 edits6 adds in trunk
[ContentChangeObserver] Ignore reconstructed renderers when checking for visibility change
https://bugs.webkit.org/show_bug.cgi?id=196483
<rdar://problem/49288174>
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes the cases when the content gets reconstructed in a way that existing and visible elements gain
new renderers within one style recalc. We failed to recognize such cases and ended up detecting the newly constructed renderers
as "visible change" thereby triggering hover.
Test: fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html
- page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::renderTreeUpdateDidStart):
(WebCore::ContentChangeObserver::renderTreeUpdateDidFinish):
(WebCore::ContentChangeObserver::reset):
(WebCore::ContentChangeObserver::willDestroyRenderer):
(WebCore::ContentChangeObserver::StyleChangeScope::StyleChangeScope):
(WebCore::ContentChangeObserver::RenderTreeUpdateScope::RenderTreeUpdateScope):
(WebCore::ContentChangeObserver::RenderTreeUpdateScope::~RenderTreeUpdateScope):
- page/ios/ContentChangeObserver.h:
(WebCore::ContentChangeObserver::visibleRendererWasDestroyed const):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::tearDownRenderers):
LayoutTests:
- fast/events/touch/ios/content-observation/visible-content-gains-new-renderer-expected.txt: Added.
- fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html: Added.
- 12:41 PM Changeset in webkit [243751] by
-
- 2 edits in trunk/Tools
Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
<https://webkit.org/b/196499>
Reviewed by Alexey Proskuryakov.
- asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
ENABLE_ADDRESS_SANITIZER.
- 12:08 PM Changeset in webkit [243750] by
-
- 2 edits in trunk/LayoutTests
accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196505
Unreviewed test gardening.
- platform/mac/TestExpectations: Updating test expectations for flaky failure
- 11:36 AM Changeset in webkit [243749] by
-
- 2 edits in trunk/LayoutTests
media/video-background-tab-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196502
Unreviewed test gardening
- platform/mac-wk1/TestExpectations: Updating test expectations for flaky failure
- 10:51 AM Changeset in webkit [243748] by
-
- 11 edits in branches/safari-607-branch/Tools
Cherry-pick r243732. rdar://problem/49356714
run-api-tests: Upload test results
https://bugs.webkit.org/show_bug.cgi?id=196323
<rdar://problem/49356714>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/api_tests/manager.py: (Manager): (Manager.run): Upload results to a results database.
- Scripts/webkitpy/api_tests/run_api_tests.py: (parse_args): Add upload arguments.
- Scripts/webkitpy/port/base.py: (Port): (Port.configuration_for_upload): Creates a configuration dictionary for uploading results. (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along with commits from any other associated repositories.
- Scripts/webkitpy/port/device.py: (Device): (Device.build_version): Access build_versoin of underlying platform device.
- Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest): (IOSSimulatorTest.test_configuration_for_upload):
- Scripts/webkitpy/port/device_port.py: (DevicePort): (DevicePort.configuration_for_upload): Devices are unique because their configuration is not the same as the machine uploading results.
- Scripts/webkitpy/port/mac.py: (MacPort): (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
- Scripts/webkitpy/port/mac_unittest.py: (MacTest): (MacTest.test_configuration_for_upload):
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._create_device_with_runtime): (SimulatedDevice.init): Create simulated device with a build_version.
- Scripts/webkitpy/xcode/simulated_device_unittest.py: (test_existing_simulator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:46 AM Changeset in webkit [243747] by
-
- 2 edits in trunk/Source/WTF
Inhibit CFNetwork logging in private sessions
https://bugs.webkit.org/show_bug.cgi?id=196268
<rdar://problem/48210793>
Fix a conditional in Platform.h where IOS should have been used
instead of IOS_FAMILY. The latter happened to work, but we really want
to be using the proper symbol here.
Reviewed by Alexey Proskuryakov.
- wtf/Platform.h:
- 9:33 AM Changeset in webkit [243746] by
-
- 12 edits in trunk
[CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
https://bugs.webkit.org/show_bug.cgi?id=182757
Reviewed by Don Olmstead.
.:
Some generated headers need to be exported to its client modules.
Before this change, WEBKIT_MAKE_FORWARDING_HEADERS copies all *.h
files in the directory specified by DERIVED_SOURCE_DIRECTORIES
parameter. The copy operation was triggered by POST_BUILD event.
This caused build dependency issues for Ninja builds. This change
remove the DERIVED_SOURCE_DIRECTORIES parameter. And list all
generated headers explicitly which need to be copied.
- Source/cmake/WebKitMacros.cmake: Removed
DERIVED_SOURCE_DIRECTORIES parameter of
WEBKIT_MAKE_FORWARDING_HEADERS. Accept absolute paths for FILES
parameter.
Source/JavaScriptCore:
- CMakeLists.txt: Do not use DERIVED_SOURCE_DIRECTORIES parameter
of WEBKIT_MAKE_FORWARDING_HEADERS. Added generated headers to
JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS.
Source/WebCore:
No new tests because no behavior changes.
- PlatformWin.cmake: Do not use DERIVED_SOURCE_DIRECTORIES of
WEBKIT_MAKE_FORWARDING_HEADERS. Added
WebCore_PRIVATE_FRAMEWORK_HEADERS.
- WebCoreMacros.cmake (GENERATE_DOM_NAMES): Added
${_namespace}ElementTypeHelpers.h to _outputfiles.
Source/WebKitLegacy:
- PlatformWin.cmake: Do not use DERIVED_SOURCE_DIRECTORIES
parameter of WEBKIT_MAKE_FORWARDING_HEADERS. Added
WebKitLegacyGUID_PRIVATE_FRAMEWORK_HEADERS.
Tools:
- TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
- TestWebKitAPI/PlatformWPE.cmake: Ditto.
- 9:23 AM Changeset in webkit [243745] by
-
- 3 edits in trunk/LayoutTests
inspector/audit/basic.html is a flaky timeout on bots
https://bugs.webkit.org/show_bug.cgi?id=196448
Unreviewed test gardening
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations: Updating test expectaions for flaky timeout
- 8:58 AM Changeset in webkit [243744] by
-
- 5 edits2 adds in trunk/Source/JavaScriptCore
Add a ValueRepReduction phase
https://bugs.webkit.org/show_bug.cgi?id=196234
Reviewed by Filip Pizlo.
This patch adds a ValueRepReduction phase. The main idea here is
to try to reduce DoubleRep(RealNumberUse:ValueRep(DoubleRepUse:@x))
to just be @x. This patch handles such above strengh reduction rules
as long as we prove that all users of the ValueRep can be converted
to using the incoming double value. That way we prevent introducing
a parallel live range for the double value.
This patch tracks the uses of the ValueRep through Phi variables,
so we can convert entire Phi variables to being Double instead
of JSValue if the Phi also has only double uses.
This is implemented through a simple escape analysis. DoubleRep(RealNumberUse:)
and OSR exit hints are not counted as escapes. All other uses are counted
as escapes. Connected Phi graphs are converted to being Double only if the
entire graph is ok with the result being Double.
Some ways we could extend this phase in the future:
- There are a lot of DoubleRep(NumberUse:@ValueRep(@x)) uses. This ensures that the result of the DoubleRep of @x is not impure NaN. We could handle this case if we introduced a PurifyNaN node and replace the DoubleRep with PurifyNaN(@x). Alternatively, we could see if certain users of this DoubleRep are okay with impure NaN flowing into them and we'd need to ensure their output type is always treated as if the input is impure NaN.
- We could do sinking of ValueRep where we think it's profitable. So instead of an escape making it so we never represent the variable as a Double, we could make the escape reconstruct the JSValueRep where profitable.
- We can extend this phase to handle Int52Rep if it's profitable.
- We can opt other nodes into accepting incoming Doubles so we no longer treat them as escapes.
This patch is somewhere between neutral and a 1% progression on JetStream 2.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGValueRepReductionPhase.cpp: Added.
(JSC::DFG::ValueRepReductionPhase::ValueRepReductionPhase):
(JSC::DFG::ValueRepReductionPhase::run):
(JSC::DFG::ValueRepReductionPhase::convertValueRepsToDouble):
(JSC::DFG::performValueRepReduction):
- dfg/DFGValueRepReductionPhase.h: Added.
- runtime/Options.h:
- 8:57 AM Changeset in webkit [243743] by
-
- 2 edits in trunk/LayoutTests
fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=195341
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations: Updating test expecations for flaky failure
- 8:50 AM Changeset in webkit [243742] by
-
- 2 edits in trunk/LayoutTests
fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196495
Unreviewed test gardening
- platform/ios-simulator-wk2/TestExpectations: Updating test expectations for flaky failure
- 7:47 AM Changeset in webkit [243741] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
[GSteamer][WebRTC] Fix building libwebrtc on ARM
https://bugs.webkit.org/show_bug.cgi?id=196157
Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-04-02
Reviewed by Philippe Normand.
Making sure neon files are built as required
- CMakeLists.txt:
- 7:31 AM Changeset in webkit [243740] by
-
- 4 edits in trunk/LayoutTests
REGRESSION(r243512): Change locale of test in intl-datetimeformat.js
https://bugs.webkit.org/show_bug.cgi?id=196395
r243512 modifes Intl.DateTimeFormat to obey 2-digit hour. A test was
added to test 2-digit hour in Russian using 12-hour setting as true and
false. In the former case, the expected string appends the string 'AM'
in Russian. This localised string made GTK-based ports fail since
according to Glib the 'am_pm' values in Russian are not localised.
This patch keeps the same test but changes locale to 'en' to prevent
the test from failing.
Reviewed by Michael Catanzaro.
- js/intl-datetimeformat-expected.txt:
- js/script-tests/intl-datetimeformat.js:
- platform/gtk/js/intl-datetimeformat-expected.txt:
- 3:59 AM Changeset in webkit [243739] by
-
- 2 edits in trunk/Source/WebCore
Update the status of ResizeObserver in features.json.
https://bugs.webkit.org/show_bug.cgi?id=196443
Patch by Cathie Chen <cathiechen> on 2019-04-02
Reviewed by Rob Buis.
- features.json:
