Timeline
Apr 26, 2019:
- 11:50 PM Changeset in webkit [244717] by
-
- 3 edits in trunk/Source/WebKit
Rename m_LayerTreeFreezeReasons to m_layerTreeFreezeReasons
https://bugs.webkit.org/show_bug.cgi?id=197343
Reviewed by Antti Koivisto.
No change in behavior.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState):
- WebProcess/WebPage/WebPage.h:
- 10:38 PM Changeset in webkit [244716] by
-
- 2 edits in trunk/Source/WebCore
Reduce the number of copies made during SourceBufferPrivateAVFObjC::append() using SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=197335
<rdar://problem/49175604>
Rubber-stamped by Alex Christensen.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::append):
- 9:28 PM Changeset in webkit [244715] by
-
- 6 edits in trunk/Source
Enable new build rule for post-processing headers when using XCBuild
https://bugs.webkit.org/show_bug.cgi?id=197340
<rdar://problem/50226685>
Reviewed by Brent Fulgham.
In Bug 197116, we conditionally disabled the old method for
post-processing header files when we are using the new XCBuild build
system. This check-in conditionally enables the new post-processing
facility. Note that the old system is disabled and the new system
enabled only when the USE_NEW_BUILD_SYSTEM environment variable is set
to YES.
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
Source/WebKit:
- Configurations/WebKit.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/WebKitLegacy.xcconfig:
- 7:20 PM Changeset in webkit [244714] by
-
- 20 edits in trunk/Source
Add new mac target numbers
https://bugs.webkit.org/show_bug.cgi?id=197313
Reviewed by Alex Christensen.
- Configurations/Version.xcconfig:
Source/JavaScriptCore:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebCore:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebCore/PAL:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebKit:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/WebKitTargetConditionals.xcconfig:
- 5:37 PM Changeset in webkit [244713] by
-
- 99 edits1 delete in trunk
Unreviewed, rolling out r244708.
https://bugs.webkit.org/show_bug.cgi?id=197334
"Broke the debug build" (Requested by rmorisset on #webkit).
Reverted changeset:
"All prototypes should call didBecomePrototype()"
https://bugs.webkit.org/show_bug.cgi?id=196315
https://trac.webkit.org/changeset/244708
- 5:06 PM Changeset in webkit [244712] by
-
- 12 edits1 delete in trunk
[CMake] Add WEBKIT_EXECUTABLE macro
https://bugs.webkit.org/show_bug.cgi?id=197206
Reviewed by Konstantin Tokarev.
.:
Add WEBKIT_EXECUTABLE macro for creating executable targets. This wraps the creation of
executable targets using the same conventions of WEBKIT_FRAMEWORK.
Common code from the two macros were moved to WEBKIT_TARGET which is meant as an internal
macro.
Add WEBKIT_WRAP_EXECUTABLE macro to support Windows targets which use a DLLLauncherMain to
launch the executable.
- Source/cmake/WebKitMacros.cmake:
Source/JavaScriptCore:
Migrate to WEBKIT_EXECUTABLE for the jsc and test targets.
- b3/air/testair.cpp:
- b3/testb3.cpp:
- dfg/testdfg.cpp:
- shell/CMakeLists.txt:
- shell/PlatformGTK.cmake:
- shell/PlatformJSCOnly.cmake: Removed.
- shell/PlatformMac.cmake:
- shell/PlatformPlayStation.cmake:
- shell/PlatformWPE.cmake:
- shell/PlatformWin.cmake:
- 4:32 PM Changeset in webkit [244711] by
-
- 5 edits1 add in trunk
[JSC] linkPolymorphicCall now does GC
https://bugs.webkit.org/show_bug.cgi?id=197306
Reviewed by Saam Barati.
JSTests:
- stress/link-polymorphic-call-can-gc.js: Added.
(module):
(instance):
Source/JavaScriptCore:
Previously, we assumed that linkPolymorphicCall does not perform allocations. So we put CallVariant into a Vector<>.
But now, WebAssemblyFunction's entrypoint generation can allocate JSToWasmICCallee and cause GC. Since CallLinkInfo
does not hold these cells, they can be collected, and we will see dead cells in the middle of linkPolymorphicCall.
We should defer GC for a while in linkPolymorphicCall. We use DeferGCForAWhile instead of DeferGC because the
caller "operationLinkPolymorphicCall" assumes that this function does not cause GC.
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
Tools:
The test is sensitive to allocations and even adding $vm makes it non-reproducible.
To add this test, we addrunWithoutBaseOption.
- Scripts/run-jsc-stress-tests:
- 4:22 PM Changeset in webkit [244710] by
-
- 1 copy in tags/Safari-607.2.6.0.1
Tag Safari-607.2.6.0.1.
- 4:01 PM Changeset in webkit [244709] by
-
- 2 edits in trunk/Source/WebKit
Use kDNSServiceFlagsKnownUnique to speed up mdns name registration for ICE candidates
https://bugs.webkit.org/show_bug.cgi?id=197328
Reviewed by Eric Carlson.
This allows skipping the probing step of MDNS name registration.
We can do that as registered names are random UUIDs.
- NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):
- 3:21 PM Changeset in webkit [244708] by
-
- 99 edits1 add in trunk
All prototypes should call didBecomePrototype()
https://bugs.webkit.org/show_bug.cgi?id=196315
Reviewed by Saam Barati.
JSTests:
- stress/function-prototype-indexed-accessor.js: Added.
Source/JavaScriptCore:
Otherwise we won't remember to run haveABadTime() when someone adds to them an indexed accessor.
I added a check used in both Structure::finishCreation() and Structure::changePrototypeTransition to make sure we don't
create structures with invalid prototypes.
It found a lot of objects that are used as prototypes in JSGlobalObject and yet were missing didBecomePrototype() in their finishCreation().
Somewhat surprisingly, some of them have names like FunctionConstructor and not only FooPrototype.
- runtime/BigIntPrototype.cpp:
(JSC::BigIntPrototype::finishCreation):
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::finishCreation):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
- runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorPrototype::finishCreation):
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::finishCreation):
- runtime/IntlPluralRulesPrototype.cpp:
(JSC::IntlPluralRulesPrototype::finishCreation):
- runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
- runtime/JSDataViewPrototype.cpp:
(JSC::JSDataViewPrototype::finishCreation):
- runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::createConsoleProperty):
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::finishCreation):
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::finishCreation):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/Structure.cpp:
(JSC::Structure::isValidPrototype):
(JSC::Structure::changePrototypeTransition):
- runtime/Structure.h:
- runtime/SymbolPrototype.cpp:
(JSC::SymbolPrototype::finishCreation):
- wasm/js/WebAssemblyCompileErrorPrototype.cpp:
(JSC::WebAssemblyCompileErrorPrototype::finishCreation):
- wasm/js/WebAssemblyInstancePrototype.cpp:
(JSC::WebAssemblyInstancePrototype::finishCreation):
- wasm/js/WebAssemblyLinkErrorPrototype.cpp:
(JSC::WebAssemblyLinkErrorPrototype::finishCreation):
- wasm/js/WebAssemblyMemoryPrototype.cpp:
(JSC::WebAssemblyMemoryPrototype::finishCreation):
- wasm/js/WebAssemblyModulePrototype.cpp:
(JSC::WebAssemblyModulePrototype::finishCreation):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::WebAssemblyPrototype::finishCreation):
- wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
(JSC::WebAssemblyRuntimeErrorPrototype::finishCreation):
- wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::WebAssemblyTablePrototype::finishCreation):
Source/WebCore:
It was found by existing tests, with the new assert in JSC::Structure
- bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::setWindow):
- bindings/scripts/CodeGeneratorJS.pm:
(GeneratePrototypeDeclaration):
(GenerateConstructorHelperMethods):
- 3:05 PM Changeset in webkit [244707] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Our process assertion should not allow idle sleep
https://bugs.webkit.org/show_bug.cgi?id=197317
<rdar://problem/50137740>
Reviewed by Geoffrey Garen.
Our process assertion should not allow idle sleep. This is bad for power because the device
may switch between sleep and awake state frequently, as it get woken up by network packages.
- UIProcess/ios/ProcessAssertionIOS.mm:
- 2:14 PM Changeset in webkit [244706] by
-
- 2 edits in trunk/Tools
Update inactive reviewers' status to 'contributor'.
Accidentally skipped one at first.
- Scripts/webkitpy/common/config/contributors.json:
- 1:47 PM Changeset in webkit [244705] by
-
- 10 edits in trunk/Tools
Update inactive reviewers' status to 'contributor'.
- Scripts/webkitpy/common/config/contributors.json: The change.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/checkout/checkout_mock.py:
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
Sadly, regression tests operate on a crazy mix of mock and live data for
contributors.json. It would be a substantial project to mock all code paths,
so changing the tests instead.
- 12:58 PM Changeset in webkit [244704] by
-
- 47 edits3 adds in trunk
Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>
Reviewed by Youenn Fablet.
Source/WebCore:
Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):
- platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
- platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
- platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:
(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::label const):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):
- platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::validateHEVCParameters):
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
- platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):
- platform/mediastream/RealtimeVideoSource.h:
- platform/mediastream/VideoPreset.h:
- platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/cocoa/AVFoundationSoftLink.h: Added.
- pal/cocoa/AVFoundationSoftLink.mm: Added.
Source/WebKit:
- Shared/ios/WebIconUtilities.mm:
(WebKit::iconForVideoFile):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone const):
Source/WebKitLegacy/mac:
- WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
(TestWebKitAPI::TEST):
- 11:32 AM Changeset in webkit [244703] by
-
- 4 edits in trunk/Tools
WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
<https://webkit.org/b/197314>
<rdar://problem/50245252>
Reviewed by Simon Fraser.
- WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
- Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator sendEventStream:completionBlock:]):
- Call -autorelease to fix leak of NSDictionary.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::accessibilitySpeakSelectionContent const):
(WTR::UIScriptController::selectFormPopoverTitle const):
(WTR::UIScriptController::textContentType const):
(WTR::UIScriptController::formInputLabel const):
(WTR::UIScriptController::scrollingTreeAsText const):
- Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
- 11:32 AM Changeset in webkit [244702] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r244683.
https://bugs.webkit.org/show_bug.cgi?id=197320
Causing crash on iOS Simulator and EWS failures (Requested by
sroberts on #webkit).
Reverted changeset:
"[iOS] Add internal setting to force -webkit-text-size-adjust
to "auto""
https://bugs.webkit.org/show_bug.cgi?id=197275
https://trac.webkit.org/changeset/244683
- 11:25 AM Changeset in webkit [244701] by
-
- 4 edits in trunk/Tools
webkitpy: Running a single test will always use the default device
https://bugs.webkit.org/show_bug.cgi?id=195472
<rdar://problem/48724825>
Reviewed by Lucas Forschler.
It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
requested will be run regardless of what shard they are in.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
on the default device type.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
(RunTest.test_run_part): Ditto.
- 11:10 AM Changeset in webkit [244700] by
-
- 38 edits2 copies in trunk
Use normal loading path for ping loads
https://bugs.webkit.org/show_bug.cgi?id=196807
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/beacon/headers/header-content-type-expected.txt:
Source/WebCore:
Make use of regular code path for ping loads and beacon.
This is done conditionally on KeepAlive flag.
The benefits are a single loading code path and service worker interception.
For that purpose, introduce a LoaderStrategy switch based on KeepAlive runtime flag.
This switch is used to use ping loads when keepAlive is set or regular loads.
In case of regular loads, the keepAlive flag should be used to extend the lifetime of the load.
Migrate ping loads to use CachedResourceLoader instead of PingLoad.
For that purpose, introduce a new Ping CachedResource type.
Covered by existing tests.
- Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::inspectorResourceType):
- loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient):
- loader/LoaderStrategy.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
- loader/PingLoader.h:
- loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType):
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType):
(WebCore::CachedResource::load):
(WebCore::CachedResource::cancelLoad):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestPingResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::isResourceSuitableForDirectReuse):
(WebCore::destinationForType):
- loader/cache/CachedResourceLoader.h:
Source/WebKit:
In case a NetworkResourceLoader has the keepAlive option we do the following:
- Always use NetworkLoadChecker as we might need it to do checks after the Web context is gone.
- In case of aborting a KeepAlive loader, remove it from NetworkConnectionToWebProcess map
and add it to a kept-alive NetworkSession load set. The loader is only kept alive if it
has not yet received a response. Mark the loader as kept-alive.
- In case loader is kept-alive, cancel the load as soon as a response is gathered.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::transferKeptAliveLoad):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::addKeptAliveLoad):
(WebKit::NetworkProcess::removeKeptAliveLoad):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkResourceLoadMap.cpp:
(WebKit::NetworkResourceLoadMap::remove):
(WebKit::NetworkResourceLoadMap::take):
- NetworkProcess/NetworkResourceLoadMap.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
- NetworkProcess/NetworkResourceLoader.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
(WebKit::WebLoaderStrategy::usePingLoad const):
- WebProcess/Network/WebLoaderStrategy.h:
LayoutTests:
- TestExpectations:
- http/tests/blink/sendbeacon/beacon-cross-origin.https-expected.txt:
- http/tests/blink/sendbeacon/connect-src-beacon-allowed.html:
- http/tests/security/contentSecurityPolicy/connect-src-beacon-allowed.html:
- http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked.php:
- http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt:
- http/wpt/beacon/beacon-async-error-logging-expected.txt:
- http/wpt/beacon/beacon-async-error-logging.html:
- http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt:
- http/wpt/beacon/contentextensions/beacon-redirect-blocked-expected.txt:
- http/wpt/beacon/resources/beacon-preflight.py:
(respondToCORSPreflight):
(main):
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only-expected.txt:
- 10:47 AM Changeset in webkit [244699] by
-
- 2 edits in trunk/LayoutTests
Mark some cache-storage as slow on iOS-simulator
https://bugs.webkit.org/show_bug.cgi?id=197316
Unreviewed.
- platform/ios-simulator-wk2/TestExpectations:
- 10:38 AM Changeset in webkit [244698] by
-
- 2 edits in trunk/LayoutTests
Removing test expectation changes for tests no longer timing out
https://bugs.webkit.org/show_bug.cgi?id=195719
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:33 AM Changeset in webkit [244697] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build after r244695
- loader/PingLoader.cpp:
- 10:21 AM Changeset in webkit [244696] by
-
- 4 edits in trunk/Source
Fix internal High Sierra build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- DerivedSources.make:
-std=gnu++17 didn't exist yet. -std=gnu++1z did.
- 10:03 AM Changeset in webkit [244695] by
-
- 21 edits in trunk
Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
https://bugs.webkit.org/show_bug.cgi?id=197165
Reviewed by Youenn Fablet.
Source/WebCore:
No change in behavior. This will just make it harder for people working on the loader to mistake
these ContentExtension specific structures for other structures general to loading.
One such mistake was made in r244248.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
- contentextensions/ContentExtensionsBackend.h:
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::subresourcesAllowReuse const):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
- loader/PingLoader.cpp:
(WebCore::processContentRuleListsForLoad):
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
- loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType): Deleted.
(WebCore::readResourceType): Deleted.
(WebCore::readLoadType): Deleted.
(WebCore::ResourceLoadInfo::isThirdParty const): Deleted.
(WebCore::ResourceLoadInfo::getResourceFlags const): Deleted.
- loader/ResourceLoadInfo.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
- page/UserContentProvider.cpp:
(WebCore::UserContentProvider::processContentRuleListsForLoad):
(WebCore::UserContentProvider::actionsForResourceLoad):
- page/UserContentProvider.h:
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
- 9:51 AM Changeset in webkit [244694] by
-
- 9 edits in trunk/Source
Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
https://bugs.webkit.org/show_bug.cgi?id=197291
Reviewed by Konstantin Tokarev.
Source/JavaScriptCore:
Replace uses of strcasestr with WTF::findIgnoringASCIICaseWithoutLength.
- API/tests/testapi.cpp:
- assembler/testmasm.cpp:
- b3/air/testair.cpp:
- b3/testb3.cpp:
- dfg/testdfg.cpp:
- dynbench.cpp:
Source/WTF:
Adds an implementation of strcasestr within WTF.
- wtf/text/StringCommon.h:
(WTF::findIgnoringASCIICaseWithoutLength):
- 9:48 AM Changeset in webkit [244693] by
-
- 2 edits in trunk/Tools
Replace iOS build queue hardware
https://bugs.webkit.org/show_bug.cgi?id=197312
Reviewed by Aakash Jain.
- BuildSlaveSupport/build.webkit.org-config/config.json:
Use newer hardware that supports macOS Mojave.
- 9:47 AM Changeset in webkit [244692] by
-
- 4 edits in trunk/Source
Fix an internal High Sierra build after r244653
- DerivedSources.make:
Apparently we can't use gnu++17 when preprocessing Platform.h in the makefile.
- 9:36 AM Changeset in webkit [244691] by
-
- 5 edits in trunk/Source/WebCore
AX: Provide iOS method for setting focus
https://bugs.webkit.org/show_bug.cgi?id=197200
<rdar://problem/50131679>
Reviewed by Alex Christensen.
Put the focus setting code in a place that iOS and macOS can access.
Override a platform level method for setting focus on iOS.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetFocus:]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilitySetFocus:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
- 9:32 AM Changeset in webkit [244690] by
-
- 5 edits2 adds in trunk
propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
https://bugs.webkit.org/show_bug.cgi?id=197303
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-26
Reviewed by Alex Christensen.
Source/WebCore:
Therefore SVGElement::propertyRegistry() was called instead. This means
these two elements will not have access to the properties of the base
class SVGFilterPrimitiveStandardAttributes.
Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg
- svg/SVGElement.cpp:
(WebCore::SVGElement::commitPropertyChange):
- svg/SVGFEFloodElement.h:
- svg/SVGFEMergeElement.h:
LayoutTests:
- svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
- svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.
- 9:29 AM Changeset in webkit [244689] by
-
- 6 edits in trunk
[Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196633
<rdar://problem/49627667>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:
Source/WebCore:
Use formula defined in https://w3c.github.io/webrtc-stats/#dom-rtcrtpcontributingsourcestats-audiolevel
to compute the audio level from the RTP header information.
Covered by rebased test.
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
(WebCore::fillRTCRtpContributingSource):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 9:25 AM Changeset in webkit [244688] by
-
- 3 edits in trunk/Tools
check-webkit-style complains the first block in while loop.
https://bugs.webkit.org/show_bug.cgi?id=197307
The style checker shouldn't complain about an open brace on
its own line if the last non-whitespace character on the previous
non-blank line is another open brace, because it's likely to
indicate the begining of a nested code block.
Reviewed by Alex Christensen.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_braces):
- 9:08 AM Changeset in webkit [244687] by
-
- 19 edits2 adds in trunk
Stop IDB transactions to release locked database files when network process is ready to suspend
https://bugs.webkit.org/show_bug.cgi?id=196372
<rdar://problem/48930116>
Reviewed by Brady Eidson.
Source/WebCore:
Suspend IDB database thread and finish ongoing IDB transactions on the main thread before suspending network
process.
API test: IndexedDB.IndexedDBSuspendImminently
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::tryStop):
(WebCore::IDBServer::IDBServer::resume):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Remove some error log messages, because now we may try
performing database operations without an active transaction if the transaction is finished on the main thread.
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::hasTransaction const):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::prepareToFinishTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransactionAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransactionOnMainThread):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransactionOnMainThread):
(WebCore::IDBServer::UniqueIDBDatabase::finishActiveTransactions):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setState):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::state const):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setResult):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::result const):
- platform/sql/SQLiteDatabaseTracker.cpp:
(WebCore::SQLiteDatabaseTracker::hasTransactionInProgress):
- platform/sql/SQLiteDatabaseTracker.h:
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processWillSuspendImminently):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
Source/WTF:
Provide a method to suspend the thread and block main thread until the thread is suspended.
- wtf/CrossThreadTaskHandler.cpp:
(WTF::CrossThreadTaskHandler::taskRunLoop):
(WTF::CrossThreadTaskHandler::suspendAndWait):
(WTF::CrossThreadTaskHandler::resume):
- wtf/CrossThreadTaskHandler.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
(-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
(runTestAndCheckResult):
(keepNetworkProcessActive):
(TEST):
- 9:00 AM Changeset in webkit [244686] by
-
- 1 copy in tags/Safari-608.1.19
Tag Safari-608.1.19.
- 7:31 AM Changeset in webkit [244685] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/harness/render-tree-as-text-options.html is failing
https://bugs.webkit.org/show_bug.cgi?id=197310
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:52 AM Changeset in webkit [244684] by
-
- 6 edits2 adds in trunk
[Curl] Fix Curl Request Scheduler not to release wrong Curl handle when request is cancelled.
https://bugs.webkit.org/show_bug.cgi?id=191650
Patch by Takashi Komori <Takashi.Komori@sony.com> on 2019-04-26
Reviewed by Fujii Hironori.
Source/WebCore:
Test: http/tests/misc/repeat-open-cancel.html
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::isCancelled):
(WebCore::CurlRequest::isCompletedOrCancelled):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::pausedStatusChanged):
- platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::isCompleted const): Deleted.
(WebCore::CurlRequest::isCancelled const): Deleted.
(WebCore::CurlRequest::isCompletedOrCancelled const): Deleted.
- platform/network/curl/CurlRequestScheduler.cpp:
(WebCore::CurlRequestScheduler::cancel):
(WebCore::CurlRequestScheduler::callOnWorkerThread):
(WebCore::CurlRequestScheduler::startThreadIfNeeded):
(WebCore::CurlRequestScheduler::stopThreadIfNoMoreJobRunning):
(WebCore::CurlRequestScheduler::stopThread):
(WebCore::CurlRequestScheduler::executeTasks):
(WebCore::CurlRequestScheduler::workerThread):
(WebCore::CurlRequestScheduler::startTransfer):
(WebCore::CurlRequestScheduler::completeTransfer):
(WebCore::CurlRequestScheduler::cancelTransfer):
(WebCore::CurlRequestScheduler::finalizeTransfer):
- platform/network/curl/CurlRequestScheduler.h:
LayoutTests:
- http/tests/misc/repeat-open-cancel-expected.txt: Added.
- http/tests/misc/repeat-open-cancel.html: Added.
Apr 25, 2019:
- 11:39 PM Changeset in webkit [244683] by
-
- 7 edits in trunk/Source
[iOS] Add internal setting to force -webkit-text-size-adjust to "auto"
https://bugs.webkit.org/show_bug.cgi?id=197275
<rdar://problem/50211019>
Reviewed by Simon Fraser.
Source/WebCore:
This setting makes it easier to investigate the autosizing work we've been doing
in https://bugs.webkit.org/show_bug.cgi?id=197250.
- page/Settings.yaml:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/WebPreferences.h:
- 11:33 PM Changeset in webkit [244682] by
-
- 19 edits5 adds in trunk
[iOS] Implement idempotent mode for text autosizing
https://bugs.webkit.org/show_bug.cgi?id=197250
<rdar://problem/50211034>
Reviewed by Jon Lee.
Source/WebCore:
Our text autosizing code has this interesting behavior where it is sensitive to the width of the text's container
and the number of lines of text inside the element. Not only is it sensitive to those things, but as those things
change, their values are stored inside the RenderObject itself and then never recomputed. This means that the text
autosizing parameters are sensitive to the entire history of an element. So, a newly created element with the same
style as an existing element can have dramatically different results.
This patch adds a new mode for text autosizing, which isn't sensitive to either of those things, and therefore
maintains the invariant that a newly created element will behave the same as an existing element with the same style.
Instead of using container size, it instead uses the viewport's initial scale. As the viewport's initial scale
changes, new layouts will be triggered, which will cause the autosizing code to use the new value.
Tests: fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html
fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::applyTextSizingIfNeeded):
- page/Page.cpp:
(WebCore::Page::setInitialScale): WebKit will push the initial scale down into the page.
- page/Page.h:
(WebCore::Page::initialScale const):
- page/SettingsBase.h:
- page/cocoa/SettingsBaseCocoa.mm:
(WebCore::SettingsBase::textAutosizingUsesIdempotentMode):
(WebCore::SettingsBase::defaultTextAutosizingEnabled):
- rendering/RenderBlockFlow.cpp:
(WebCore::idempotentTextSize): Describe a piecewise-linear curve for the text size to follow. The curve scales
depending on the viewport's initial scale.
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
- rendering/RenderBlockFlow.h:
- rendering/RenderElement.cpp:
(WebCore::includeNonFixedHeight): This new mode should consider max-height as well as height when determining if
content overflows.
(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):
- rendering/RenderElement.h:
- rendering/RenderObject.h:
Source/WebKit:
Push the initial scale down into the page.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):
LayoutTests:
Add two simple tests that make sure that fonts get autosized > 1x when the layout viewport is wide,
and that fonts don't get autosized when the layout viewport isn't wide.
We don't want to add tons of tests to test exact values because the curve will likely be tweaked
in the future.
- fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-expected.txt: Added.
- fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity-expected.txt: Added.
- fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html: Added.
- fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html: Added.
- 11:33 PM Changeset in webkit [244681] by
-
- 1 copy in tags/Safari-607.2.6.2.1
Tag Safari-607.2.6.2.1.
- 11:32 PM Changeset in webkit [244680] by
-
- 2 edits in branches/safari-607.2.6.2-branch/Source/WTF
Cherry-pick r243641. rdar://problem/50232874
Unreviewed build fix.
- wtf/CMakeLists.txt: Added SpanningTree.h to WTF_PUBLIC_HEADERS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:26 PM Changeset in webkit [244679] by
-
- 7 edits in branches/safari-607.2.6.2-branch/Source
Versioning.
- 11:06 PM Changeset in webkit [244678] by
-
- 7 edits in trunk/Source/WebKit
Make NetworkCache blobs safe for mmap instead of not using blobs
https://bugs.webkit.org/show_bug.cgi?id=197264
<rdar://problem/49564348>
Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-25
Reviewed by Antti Koivisto.
This does what r244597 did for WKContentRuleLists but for the NetworkCache's blobs.
Those are the two cases where we were calling mmap and seeing crashes in apps with
default file protection of NSFileProtectionComplete.
- NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::add):
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath): Deleted.
- NetworkProcess/cache/NetworkCacheFileSystem.h:
- NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::mayContainBlob const):
(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):
(WebKit::NetworkCache::estimateRecordsSize): Deleted.
- NetworkProcess/cache/NetworkCacheStorage.h:
- 10:51 PM Changeset in webkit [244677] by
-
- 1 copy in branches/safari-607.2.6.2-branch
New branch.
- 8:46 PM Changeset in webkit [244676] by
-
- 8 edits in trunk
Unreviewed, rolling out r244669.
Windows ports can't clean build.
Reverted changeset:
"[Win] Add flag to enable version information stamping and
disable by default."
https://bugs.webkit.org/show_bug.cgi?id=197249
https://trac.webkit.org/changeset/244669
- 7:55 PM Changeset in webkit [244675] by
-
- 7 edits in trunk
REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=188357
<rdar://problem/42986633>
Reviewed by Dean Jackson.
Source/WebCore:
DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.
Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.
We no longer need the WK2 C SPI glue.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Source/WebKit:
DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.
Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.
We no longer need the WK2 C SPI glue.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetEventThrottlingBehaviorOverride):
(WKBundlePageSetCompositingPolicyOverride): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Tools:
DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.
Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.
We no longer need the WK2 C SPI glue.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::prepare):
- 6:58 PM Changeset in webkit [244674] by
-
- 8 edits in trunk
[ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196357
<rdar://problem/49386836>
Reviewed by Geoffrey Garen.
Source/WebCore:
Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.
Covered by existing tests.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):
- Modules/indexeddb/IDBTransaction.h:
LayoutTests:
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 6:28 PM Changeset in webkit [244673] by
-
- 3 edits in trunk/Source/WebCore
ASSERT(scriptExecutionContext()) in Performance::resourceTimingBufferFullTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=197300
<rdar://problem/49965990>
Reviewed by Youenn Fablet.
We crash because the scriptExecutionContext has been destroyed by the time the m_resourceTimingBufferFullTimer
timer fires. However, r241598 already makes sure that we stop the timer when the script execution context
is destroyed. This makes me think that somebody restarts the timer *after* the script execution context has
been destroyed. The thing is that we only start the timer in Performance::addResourceTiming() and there are
only 2 call sites for this method. Both call sites get the Performance object from the Window object, which
they get from the Document object. As a result, I would believe that the Window's document is alive, even
though the Performance object's scriptExecutionContext is not. This could indicate that the Performance
object's scriptExecutionContext gets out of sync with its Window's document. I have found one place where
it could happen in theory (DOMWindow::didSecureTransitionTo()). I have not been able to write a test
confirming my theory though so this is a speculative fix. I have also added a few assertions to help us
track down the issue if my speculative fix turns out to be ineffective.
No new tests, we do not know how to reproduce.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::didSecureTransitionTo):
This is a speculative fix for the crash. When a DOMWindow transitions from one document to
another, reset its data members which store the DOMWindow's document to make sure that they
do not get out of sync.
(WebCore::DOMWindow::crypto const):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance const):
Add assertions to make sure that the member's scriptExecutionContext is in sync with
the window's.
- page/Performance.cpp:
(WebCore::Performance::addResourceTiming):
Add assertion to make sure that the scriptExecutionContext() is non-null when calling this
as this may start the m_resourceTimingBufferFullTimer timer. If my speculative fix above
does not work, we should hit this and this should tell us which call site is causing this.
- 5:23 PM Changeset in webkit [244672] by
-
- 2 edits1 add in trunk/Source/ThirdParty/libwebrtc
Make sure sockets file descriptors are in the correct range
https://bugs.webkit.org/show_bug.cgi?id=197301
<rdar://problem/48389381>
Reviewed by Chris Dumez.
- Source/webrtc/rtc_base/physicalsocketserver.cc:
- WebKit/0001-fix-197301.patch: Added.
- 5:17 PM Changeset in webkit [244671] by
-
- 2 edits in trunk/Tools
webkitpy: Including skipped tests in the final count
https://bugs.webkit.org/show_bug.cgi?id=197298
<rdar://problem/49705424>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
- 5:17 PM Changeset in webkit [244670] by
-
- 2 edits in trunk/Source/WebKit
Trying to load a main resource outside the sandbox should not crash the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=197299
<rdar://problem/49808042>
Reviewed by Geoffrey Garen.
Trying to load a main resource outside the sandbox should not crash the WebContent process. We should
simply ignore the load and log an error message.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- 4:08 PM Changeset in webkit [244669] by
-
- 8 edits in trunk
[Win] Add flag to enable version information stamping and disable by default.
https://bugs.webkit.org/show_bug.cgi?id=197249
Reviewed by Ross Kirsling.
This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.
.:
- Source/cmake/OptionsWin.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
Source/WebKitLegacy:
- PlatformWin.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- 3:41 PM Changeset in webkit [244668] by
-
- 2 edits in trunk/Tools
DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
https://bugs.webkit.org/show_bug.cgi?id=197273
Reviewed by Dean Jackson.
Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
so that WebCoreTestSupport::resetInternalsObject() is always run.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
(runTest):
- 3:09 PM Changeset in webkit [244667] by
-
- 2 edits in trunk/Source/WebKit
Only send a synthetic mouse out event if synthetic mouse move events were sent.
https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233
Reviewed by Zalan Bujtas.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):
- 2:52 PM Changeset in webkit [244666] by
-
- 9 edits in trunk/Source/bmalloc
[bmalloc] Follow-up and fixing bug after r244481
https://bugs.webkit.org/show_bug.cgi?id=197294
Reviewed by Saam Barati.
This patch includes follow-up after r244481 and bug fixes which is introduced in the refactoring.
- bmalloc/IsoAllocator.h: Remove unused function.
- bmalloc/IsoAllocatorInlines.h:
(bmalloc::IsoAllocator<Config>::allocateSlow):
- bmalloc/IsoDeallocatorInlines.h:
(bmalloc::IsoDeallocator<Config>::deallocate):
- bmalloc/IsoHeapImpl.h: Rename m_usableBits to m_availableShared and add static_assert.
- bmalloc/IsoHeapImplInlines.h: Do not clear m_numberOfAllocationsFromSharedInOneCycle etc. in scavenge since IsoHeapImpl::scavenge
is not related to thread-local IsoAllocator's status.
(bmalloc::IsoHeapImpl<Config>::scavenge):
(bmalloc::IsoHeapImpl<Config>::forEachLiveObject):
(bmalloc::IsoHeapImpl<Config>::updateAllocationMode): Update m_allocationMode correctly.
(bmalloc::IsoHeapImpl<Config>::allocateFromShared):
- bmalloc/IsoSharedHeapInlines.h:
(bmalloc::computeObjectSizeForSharedCell):
(bmalloc::IsoSharedHeap::allocateNew):
(bmalloc::IsoSharedHeap::allocateSlow): Add computeObjectSizeForSharedCell.
- bmalloc/IsoSharedPage.h:
- bmalloc/IsoSharedPageInlines.h:
(bmalloc::IsoSharedPage::free): Pass
const std::lock_guard<Mutex>&in its parameter.
- 2:42 PM Changeset in webkit [244665] by
-
- 2 edits in trunk/Source/WebCore
Disable ContentChangeObserver on iOSMac.
https://bugs.webkit.org/show_bug.cgi?id=197292
rdar://problem/49039957
Reviewed by Zalan Bujtas.
We don’t need to run any of ContentChangeObserver, because we have hover events on iOSMac.
Disabling it skips the synthetic mouse move events and speeds up clicks.
- page/SettingsBase.cpp:
(WebCore::SettingsBase::defaultContentChangeObserverEnabled): Return false for PLATFORM(IOSMAC).
- 2:38 PM Changeset in webkit [244664] by
-
- 15 edits in trunk
Disable date and time inputs on iOSMac.
https://bugs.webkit.org/show_bug.cgi?id=197287
rdar://problem/46794376
Reviewed by Wenson Hsieh.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- platform/text/mac/LocaleMac.h:
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::formatDateTime):
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 2:27 PM Changeset in webkit [244663] by
-
- 4 edits in trunk/Source/WebCore
Fix more Windows builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- svg/properties/SVGAnimatedPropertyList.h:
- svg/properties/SVGProperty.h:
- svg/properties/SVGPropertyList.h:
- 1:08 PM Changeset in webkit [244662] by
-
- 2 edits in trunk/Tools
Fix test-webkitpy after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- lldb/lldbWebKitTester/Configurations/Base.xcconfig:
Also use C++17.
- 12:43 PM Changeset in webkit [244661] by
-
- 1 edit1 add in trunk/LayoutTests
fast/harness/render-tree-as-text-options.html Rebaselined test for windows
https://bugs.webkit.org/show_bug.cgi?id=197290
Unreviewed test gardening.
- platform/win/fast/render-tree-as-text-options-expected.txt: Added.
- 12:11 PM Changeset in webkit [244660] by
-
- 4 edits in trunk/Source
Fix more builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
Source/JavaScriptCore:
- b3/B3Value.h:
There is an older system with libc++ headers that don't have std::conjunction. Just use constexpr and && instead for the one use of it in WebKit.
Source/WebCore:
- svg/properties/SVGValuePropertyList.h:
Something is preventing MSVC from seeing protected constructors from subclasses.
- 12:04 PM Changeset in webkit [244659] by
-
- 10 edits in trunk
-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>
Reviewed by Alex Christensen.
Source/WebCore:
Add method to get all origins with persistent credentials from credential storage.
API tests: WKWebsiteDataStore.FetchNonPersistentCredentials
WKWebsiteDataStore.FetchPersistentCredentials
- platform/network/CredentialStorage.h:
- platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::originsWithPersistentCredentials):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(-[NavigationTestDelegate init]):
(-[NavigationTestDelegate waitForDidFinishNavigation]):
(-[NavigationTestDelegate webView:didFinishNavigation:]):
(-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TestWebKitAPI::TEST):
(TEST): Deleted.
- 11:59 AM Changeset in webkit [244658] by
-
- 1 edit6 adds in trunk/LayoutTests
Add more tests for ios programmatic iframe scrolling with fixed/sticky layers
https://bugs.webkit.org/show_bug.cgi?id=197280
This commit adds iOS tests for scrolling iframes containing fixed/sticky layers. They are
extracted from earlier experimental patches for iOS frame scrolling but failed with the
alternative patches initially landed in bug 193539 and follow-up bugs. They now pass again
on trunk, so we can finally import them.
Patch by Frederic Wang <fwang@igalia.com> on 2019-04-25
Reviewed by Darin Adler.
- fast/scrolling/ios/programmatic-scroll-iframe-010-expected.html: Added.
- fast/scrolling/ios/programmatic-scroll-iframe-010.html: Added.
- fast/scrolling/ios/programmatic-scroll-iframe-011-expected.html: Added.
- fast/scrolling/ios/programmatic-scroll-iframe-011.html: Added.
- fast/scrolling/ios/programmatic-scroll-iframe-012-expected.html: Added.
- fast/scrolling/ios/programmatic-scroll-iframe-012.html: Added.
- 11:54 AM Changeset in webkit [244657] by
-
- 19 edits in trunk/Source/JavaScriptCore
[RemoteInspector] Fix connection and target identifier types.
https://bugs.webkit.org/show_bug.cgi?id=197243
Reviewed by Ross Kirsling.
Give dedicated type for RemoteControllableTarget's identifier as Inspector::TargetID.
Also rename ClientID type used in Socket backend to ConnectionID because this is the identifier
socket endpoint assign to the newly created connection. The size was changed to uint32_t.
Enough size for managing connections.
- inspector/remote/RemoteConnectionToTarget.cpp:
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
(Inspector::RemoteConnectionToTarget::targetIdentifier const):
- inspector/remote/RemoteConnectionToTarget.h:
- inspector/remote/RemoteControllableTarget.h:
- inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::nextAvailableTargetIdentifier):
(Inspector::RemoteInspector::registerTarget):
(Inspector::RemoteInspector::unregisterTarget):
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupCompleted):
(Inspector::RemoteInspector::waitingForAutomaticInspection):
(Inspector::RemoteInspector::updateTargetListing):
- inspector/remote/RemoteInspector.h:
- inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:
(Inspector::RemoteConnectionToTarget::targetIdentifier const):
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
- inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedCloseMessage):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):
- inspector/remote/socket/RemoteInspectorConnectionClient.cpp:
(Inspector::RemoteInspectorConnectionClient::didReceiveWebInspectorEvent):
- inspector/remote/socket/RemoteInspectorConnectionClient.h:
(Inspector::RemoteInspectorConnectionClient::didAccept):
- inspector/remote/socket/RemoteInspectorMessageParser.cpp:
(Inspector::MessageParser::MessageParser):
(Inspector::MessageParser::parse):
- inspector/remote/socket/RemoteInspectorMessageParser.h:
(Inspector::MessageParser::setDidParseMessageListener):
- inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::didAccept):
(Inspector::RemoteInspectorServer::didClose):
(Inspector::RemoteInspectorServer::dispatchMap):
(Inspector::RemoteInspectorServer::sendWebInspectorEvent):
(Inspector::RemoteInspectorServer::sendCloseEvent):
(Inspector::RemoteInspectorServer::connectionClosed):
- inspector/remote/socket/RemoteInspectorServer.h:
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::didClose):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):
- inspector/remote/socket/RemoteInspectorSocket.h:
- inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::connectInet):
(Inspector::RemoteInspectorSocketEndpoint::isListening):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::send):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
- inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
- 11:49 AM Changeset in webkit [244656] by
-
- 4 edits in trunk/Source
Source/WebCore:
Fix MSVC build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- svg/properties/SVGValueProperty.h:
MSVC doesn't think it can access these protected constructors from subclasses.
Make the build work and investigate this later.
Source/WTF:
Fix High Sierra build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- wtf/StdLibExtras.h:
High Sierra thinks cplusplus is 201406 even when using C++17.
Removing the cplusplus check resolves the build failure on High Sierra.
We can clean up StdLibExtras more later.
- 11:49 AM Changeset in webkit [244655] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
<rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284
Reviewed by Chris Dumez.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
be eligible. Only if all pages are suspended should it be jetsam-able.
- 11:15 AM Changeset in webkit [244654] by
-
- 2 edits in trunk/Tools
Revert some code accidentally committed with r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
- TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):
- 10:41 AM Changeset in webkit [244653] by
-
- 36 edits in trunk
Start using C++17
https://bugs.webkit.org/show_bug.cgi?id=197131
.:
Reviewed by Darin Adler.
- Source/cmake/OptionsMSVC.cmake:
- Source/cmake/WebKitCompilerFlags.cmake:
Source/bmalloc:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/JavaScriptCore:
Reviewed by Darin Alder.
- Configurations/Base.xcconfig:
Source/ThirdParty:
Reviewed by Darin Adler.
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/ThirdParty/libwebrtc:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/WebCore:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- DerivedSources.make:
Source/WebCore/PAL:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/WebKit:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- DerivedSources.make:
Source/WebKitLegacy/mac:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
Source/WTF:
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- wtf/CMakeLists.txt:
- wtf/Variant.h:
(WTF::switchOn):
Tools:
Reviewed by Darin Adler.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MobileMiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 10:36 AM Changeset in webkit [244652] by
-
- 7 edits1 add1 delete in trunk/Source
Remove DeprecatedOptional
https://bugs.webkit.org/show_bug.cgi?id=197161
Reviewed by Darin Adler.
Source/JavaScriptCore:
We need to keep a symbol exported from JavaScriptCore for binary compatibility with iOS12.
We need this symbol to be in a file that doesn't include anything because libcxx's implementation of
std::optional is actually std::1::optional, which has a different mangled name. This change will
prevent protocol errors from being reported if you are running the iOS12 simulator with a custom build of WebKit
and using the web inspector with it, but it's necessary to allow us to start using C++17 in WebKit.
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/InspectorBackendDispatcher.cpp:
- inspector/InspectorBackendDispatcher.h:
- inspector/InspectorBackendDispatcherCompatibility.cpp: Added.
(Inspector::BackendDispatcher::reportProtocolError):
- inspector/InspectorBackendDispatcherCompatibility.h: Added.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/DeprecatedOptional.h: Removed.
- 10:24 AM Changeset in webkit [244651] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197286
Unreviewed test gardening
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure
- 10:22 AM WebKitGTK/2.24.x edited by
- (diff)
- 10:21 AM WebKitGTK/2.24.x edited by
- (diff)
- 10:06 AM Changeset in webkit [244650] by
-
- 3 edits in trunk/LayoutTests
http/wpt/resource-timing/rt-resources-per-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197207
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure
- 9:59 AM Changeset in webkit [244649] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Back/Forward gesture interferes with scrolling
https://bugs.webkit.org/show_bug.cgi?id=197168
Patch by Alexander Mikhaylenko <exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.
When the gesture is released with 0 velocity close to an edge of the webview,
the finishing animation is way too long, and in some cases it can look like the
gesture is already over, when it's still animating. By scrolling vertically while
that happens, it's possible to reset animation over and over again.
To reduce the duration in this case, instead of using maximum possible duration
(400ms), introduce a base velocity and use it for calculating the duration if
the actual velocity, relative to the end point, is equal to or less than 0.
- UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::ViewGestureController::SwipeProgressTracker::startAnimation):
- 9:58 AM Changeset in webkit [244648] by
-
- 4 edits in trunk/Source/WebKit
[GTK] Back/forward gesture snapshot always times out
https://bugs.webkit.org/show_bug.cgi?id=197233
Patch by Alexander Mikhaylenko <exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.
Delaying web process launch caused a regression where we create ViewGestureController when the
web process doesn't yet exist. The controller immediately tries to connect to it and fails,
and because of that never receives DidHitRenderTreeSizeThreshold() message, so navigation
snapshot always stays until timeout after performing the gesture.
To prevent this, create the controller in webkitWebViewBaseDidRelaunchWebProcess() instead of
webkitWebViewBaseCreateWebPage(). Additionally, since settings are now created earlier than
ViewGestureController, store the value of whether swipe gesture is enabled in WebKitWebViewBase
and immediately apply it when creating the controller.
- UIProcess/API/glib/WebKitWebView.cpp:
(enableBackForwardNavigationGesturesChanged):
Move the logic into webkitWebViewBaseSetEnableBackForwardNavigationGesture().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetEnableBackForwardNavigationGesture): Added. In addition to what was in
WebKitWebViewBase::enableBackForwardNavigationGesturesChanged(), store the value in a field
for the case ViewGestureController doesn't exist yet.
(webkitWebViewBaseCreateWebPage): Stop creating ViewGestureController.
(webkitWebViewBaseDidRelaunchWebProcess): Move creating ViewGestureController here. Also
immediately call setSwipeGestureEnabled() with the stored value.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- 9:48 AM Changeset in webkit [244647] by
-
- 2 edits in trunk/LayoutTests
http/tests/resourceLoadStatistics/prune-statistics.html is a flaky failure on Debug testers
https://bugs.webkit.org/show_bug.cgi?id=197285#add_comment
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating expectations for flaky failure
- 9:29 AM Changeset in webkit [244646] by
-
- 2 edits in trunk/LayoutTests
fast/css-custom-paint/animate-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197283
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating expectations for flaky failure
- 8:50 AM Changeset in webkit [244645] by
-
- 2 edits in trunk/Source/WebKit
[Mac iOS WK2] Layout Test http/wpt/cache-storage/cache-quota-after-restart.any.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197040
<rdar://problem/49997641>
Reviewed by Antti Koivisto.
Delay write operations in case synchronize is ongoing.
This is restricted to AvoidRandomness mode which is always used by CacheAPI
and is also used by network cache for layout tests.
Tested by cache-quota-after-restart.any.html no longer exhibiting write disk errors.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::store):
- 8:43 AM Changeset in webkit [244644] by
-
- 47 edits3 deletes in trunk
Unreviewed, rolling out r244627.
https://bugs.webkit.org/show_bug.cgi?id=197282
Causing internal build failures (Requested by ShawnRoberts on
#webkit).
Reverted changeset:
"Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
https://bugs.webkit.org/show_bug.cgi?id=197171
https://trac.webkit.org/changeset/244627
- 4:29 AM Changeset in webkit [244643] by
-
- 2 edits in trunk/Source/WebCore
redefinition of enumerator 'NSAttachmentCharacter' with Apple internal build
https://bugs.webkit.org/show_bug.cgi?id=197279
Reviewed by Antoine Quint.
Try to fix the build.
- platform/mac/WebNSAttributedStringExtras.mm:
- 2:55 AM Changeset in webkit [244642] by
-
- 8 edits2 adds in trunk
Visited link hash should be computed only once
https://bugs.webkit.org/show_bug.cgi?id=197229
<rdar://problem/48438924>
Reviewed by Alex Christensen.
Source/WebCore:
Test: fast/history/visited-href-mutation.html
Visited link style is now based on the first target URL of the link element. Further href mutations don't affect styling.
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
- dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
(WebCore::linkHashForElement):
Visited link support is now limited to HTML and SVG <a> elements.
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::visitedLinkHash const):
(WebCore::HTMLAnchorElement::invalidateCachedVisitedLinkHash): Deleted.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::visitedLinkHash const):
- svg/SVGAElement.h:
LayoutTests:
- fast/history/visited-href-mutation-expected.html: Added.
- fast/history/visited-href-mutation.html: Added.
- 12:53 AM WebKitGTK/2.24.x edited by
- (diff)
- 12:52 AM Changeset in webkit [244641] by
-
- 6 edits in trunk
[GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused
https://bugs.webkit.org/show_bug.cgi?id=196691
Reviewed by Eric Carlson.
Source/WebCore:
For gif assets, fail media loading early and notify the
MediaPlayer by setting both network and ready states, so that the
MediaPlayer will try with with the next media engine or pass the
error to HTMLMediaElement if there are none.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
LayoutTests:
Unflag test no longer crashing.
- platform/gtk/TestExpectations:
- platform/gtk/fast/replaced/border-radius-clip-expected.txt:
- 12:48 AM WebKitGTK/2.24.x edited by
- (diff)
- 12:47 AM Changeset in webkit [244640] by
-
- 3 edits in trunk/Source/WebCore
[REGRESSION(r243197)][GStreamer] http/tests/media/clearkey/collect-webkit-media-session.html hits an ASSERT
https://bugs.webkit.org/show_bug.cgi?id=197230
Reviewed by Xabier Rodriguez-Calvar.
Perform the resource loader disposal and destruction from the main
thread. Also ensure there's no circular reference between the
CachedResourceStreamingClient and WebKitWebSrc when disposing of
the private WebKitWebSrc storage.
- platform/graphics/gstreamer/MainThreadNotifier.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(_WebKitWebSrcPrivate::~_WebKitWebSrcPrivate):
(webkit_web_src_class_init):
(webKitWebSrcDispose):
(webKitWebSrcCloseSession):
(webKitWebSrcFinalize): Deleted.
