⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 27, 2019:

3:45 PM Changeset in webkit [244723] by Chris Dumez
  • 11 edits in trunk/Tools

[WKTR] Move test timeout handling to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=197333

Reviewed by Darin Adler.

Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
every WebContent process in the case of swapping.

Also, because of process caching, the timeout timer would sometime fire in a cached process and it
would lead to crashes when firing the timer.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::shouldDumpPixels const):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):
(WTR::TestRunner::waitUntilDone):
(WTR::TestRunner::setWaitUntilDone):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
  • WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
  • WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
  • WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::createTestSettingsDictionary):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
(WTR::TestInvocation::waitToDumpWatchdogTimerFired):
(WTR::TestInvocation::setWaitUntilDone):
(WTR::TestInvocation::done):

  • WebKitTestRunner/TestInvocation.h:
12:31 PM Changeset in webkit [244722] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Move some Compositing logging to the Layers log channel
​https://bugs.webkit.org/show_bug.cgi?id=197345

Reviewed by Sam Weinig.

Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
accurate visible rects.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateCoverage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::layersLogEnabled):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

10:09 AM Changeset in webkit [244721] by Chris Dumez
  • 4 edits in trunk/Source/WebKit

Improve safety of MachMessage class
​https://bugs.webkit.org/show_bug.cgi?id=197323
<rdar://problem/44291920>

Reviewed by Darin Adler.

Improve safety of MachMessage class and clean things up a bit.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendOutgoingMessage):

  • Pass MessageReceiverName / MessageName when constructing the MachMessage rather than setting them afterwards since they never change for a given MachMessage.
  • Set header->msgh_id to the right value right away instead of setting it first to inlineBodyMessageID and then later fixing it to be outOfLineBodyMessageID when the body is out of line.
  • When messageBodyIsOOL was true, we would call getDescriptorAndSkip() which would advance the pointer by sizeof(mach_msg_port_descriptor_t), even though the descriptor type is mach_msg_ool_descriptor_t. This would not matter in the end because we would not use the messageData pointer after this but still.
  • Platform/IPC/mac/MachMessage.cpp:

(IPC::MachMessage::create):
Use fastZeroedMalloc() instead of fastMalloc() for safety, given that this class
has a mach_msg_header_t flexible array member. This is what is recommended by the
mach documentation. It is much safer because it otherwize relies on the user
(Connection::sendOutgoingMessage()) to initialize ALL the message members
correctly. I suspect this was the cause of <rdar://problem/44291920> because
Connection::sendOutgoingMessage() would fail to initialize header->msgh_voucher_port
and the MachMessage destructor would then call mach_msg_destroy(header()), which
would mach_msg_destroy_port(header->msgh_voucher_port).

(IPC::MachMessage::MachMessage):
Pass MessageReceiverName / MessageName when constructing the MachMessage rather
than setting them afterwards since they never change for a given MachMessage.

(IPC::MachMessage::messageSize):
Drop if checks for portDescriptorCount and memoryDescriptorCount since the logic
will do the right thing even if they are 0.

  • Platform/IPC/mac/MachMessage.h:

(IPC::MachMessage::header):
(IPC::MachMessage::messageReceiverName const):
(IPC::MachMessage::messageName const):

9:17 AM Changeset in webkit [244720] by bshafiei@apple.com
  • 7 edits in tags/Safari-608.1.19.1/Source

Versioning.

9:14 AM Changeset in webkit [244719] by bshafiei@apple.com
  • 1 copy in tags/Safari-608.1.19.1

New tag.

7:41 AM Changeset in webkit [244718] by Megan Gardner
  • 2 edits in trunk/Source/WebCore

Lookup only looking up the first word in selection
​https://bugs.webkit.org/show_bug.cgi?id=197341
<rdar://problem/48221414>

Reviewed by Wenson Hsieh.

Lookup is not testable.

Reveal needs the full range in order to correctly create the item for the popover.

  • editing/cocoa/DictionaryLookup.mm:

(WebCore::showPopupOrCreateAnimationController):

Apr 26, 2019:

11:50 PM Changeset in webkit [244717] by Wenson Hsieh
  • 3 edits in trunk/Source/WebKit

Rename m_LayerTreeFreezeReasons to m_layerTreeFreezeReasons
​https://bugs.webkit.org/show_bug.cgi?id=197343

Reviewed by Antti Koivisto.

No change in behavior.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState):

  • WebProcess/WebPage/WebPage.h:
10:38 PM Changeset in webkit [244716] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce the number of copies made during SourceBufferPrivateAVFObjC::append() using SharedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=197335
<rdar://problem/49175604>

Rubber-stamped by Alex Christensen.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::append):

9:28 PM Changeset in webkit [244715] by Keith Rollin
  • 6 edits in trunk/Source

Enable new build rule for post-processing headers when using XCBuild
​https://bugs.webkit.org/show_bug.cgi?id=197340
<rdar://problem/50226685>

Reviewed by Brent Fulgham.

In Bug 197116, we conditionally disabled the old method for
post-processing header files when we are using the new XCBuild build
system. This check-in conditionally enables the new post-processing
facility. Note that the old system is disabled and the new system
enabled only when the USE_NEW_BUILD_SYSTEM environment variable is set
to YES.

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:

Source/WebKit:

  • Configurations/WebKit.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/WebKitLegacy.xcconfig:
7:20 PM Changeset in webkit [244714] by jberlin@webkit.org
  • 20 edits in trunk/Source

Add new mac target numbers
​https://bugs.webkit.org/show_bug.cgi?id=197313

Reviewed by Alex Christensen.

  • Configurations/Version.xcconfig:

Source/JavaScriptCore:

  • Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/libwebrtc:

  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore:

  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore/PAL:

  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKit:

  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/WebKitTargetConditionals.xcconfig:
5:37 PM Changeset in webkit [244713] by commit-queue@webkit.org
  • 99 edits
    1 delete in trunk

Unreviewed, rolling out r244708.
​https://bugs.webkit.org/show_bug.cgi?id=197334

"Broke the debug build" (Requested by rmorisset on #webkit).

Reverted changeset:

"All prototypes should call didBecomePrototype()"
​https://bugs.webkit.org/show_bug.cgi?id=196315
​https://trac.webkit.org/changeset/244708

5:06 PM Changeset in webkit [244712] by don.olmstead@sony.com
  • 12 edits
    1 delete in trunk

[CMake] Add WEBKIT_EXECUTABLE macro
​https://bugs.webkit.org/show_bug.cgi?id=197206

Reviewed by Konstantin Tokarev.

.:

Add WEBKIT_EXECUTABLE macro for creating executable targets. This wraps the creation of
executable targets using the same conventions of WEBKIT_FRAMEWORK.

Common code from the two macros were moved to WEBKIT_TARGET which is meant as an internal
macro.

Add WEBKIT_WRAP_EXECUTABLE macro to support Windows targets which use a DLLLauncherMain to
launch the executable.

  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

Migrate to WEBKIT_EXECUTABLE for the jsc and test targets.

  • b3/air/testair.cpp:
  • b3/testb3.cpp:
  • dfg/testdfg.cpp:
  • shell/CMakeLists.txt:
  • shell/PlatformGTK.cmake:
  • shell/PlatformJSCOnly.cmake: Removed.
  • shell/PlatformMac.cmake:
  • shell/PlatformPlayStation.cmake:
  • shell/PlatformWPE.cmake:
  • shell/PlatformWin.cmake:
4:32 PM Changeset in webkit [244711] by ysuzuki@apple.com
  • 5 edits
    1 add in trunk

[JSC] linkPolymorphicCall now does GC
​https://bugs.webkit.org/show_bug.cgi?id=197306

Reviewed by Saam Barati.

JSTests:

  • stress/link-polymorphic-call-can-gc.js: Added.

(module):
(instance):

Source/JavaScriptCore:

Previously, we assumed that linkPolymorphicCall does not perform allocations. So we put CallVariant into a Vector<>.
But now, WebAssemblyFunction's entrypoint generation can allocate JSToWasmICCallee and cause GC. Since CallLinkInfo
does not hold these cells, they can be collected, and we will see dead cells in the middle of linkPolymorphicCall.
We should defer GC for a while in linkPolymorphicCall. We use DeferGCForAWhile instead of DeferGC because the
caller "operationLinkPolymorphicCall" assumes that this function does not cause GC.

  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

Tools:

The test is sensitive to allocations and even adding $vm makes it non-reproducible.
To add this test, we add runWithoutBaseOption.

  • Scripts/run-jsc-stress-tests:
4:22 PM Changeset in webkit [244710] by Alan Coon
  • 1 copy in tags/Safari-607.2.6.0.1

Tag Safari-607.2.6.0.1.

4:01 PM Changeset in webkit [244709] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Use kDNSServiceFlagsKnownUnique to speed up mdns name registration for ICE candidates
​https://bugs.webkit.org/show_bug.cgi?id=197328

Reviewed by Eric Carlson.

This allows skipping the probing step of MDNS name registration.
We can do that as registered names are random UUIDs.

  • NetworkProcess/webrtc/NetworkMDNSRegister.cpp:

(WebKit::NetworkMDNSRegister::registerMDNSName):

3:21 PM Changeset in webkit [244708] by rmorisset@apple.com
  • 99 edits
    1 add in trunk

All prototypes should call didBecomePrototype()
​https://bugs.webkit.org/show_bug.cgi?id=196315

Reviewed by Saam Barati.

JSTests:

  • stress/function-prototype-indexed-accessor.js: Added.

Source/JavaScriptCore:

Otherwise we won't remember to run haveABadTime() when someone adds to them an indexed accessor.

I added a check used in both Structure::finishCreation() and Structure::changePrototypeTransition to make sure we don't
create structures with invalid prototypes.
It found a lot of objects that are used as prototypes in JSGlobalObject and yet were missing didBecomePrototype() in their finishCreation().
Somewhat surprisingly, some of them have names like FunctionConstructor and not only FooPrototype.

  • runtime/BigIntPrototype.cpp:

(JSC::BigIntPrototype::finishCreation):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::finishCreation):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::finishCreation):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):

  • runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::finishCreation):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::finishCreation):

  • runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototype::finishCreation):

  • runtime/JSArrayBufferPrototype.cpp:

(JSC::JSArrayBufferPrototype::finishCreation):

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::finishCreation):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):

  • runtime/JSGlobalObject.cpp:

(JSC::createConsoleProperty):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::finishCreation):

  • runtime/JSTypedArrayViewConstructor.cpp:

(JSC::JSTypedArrayViewConstructor::finishCreation):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::finishCreation):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • runtime/Structure.cpp:

(JSC::Structure::isValidPrototype):
(JSC::Structure::changePrototypeTransition):

  • runtime/Structure.h:
  • runtime/SymbolPrototype.cpp:

(JSC::SymbolPrototype::finishCreation):

  • wasm/js/WebAssemblyCompileErrorPrototype.cpp:

(JSC::WebAssemblyCompileErrorPrototype::finishCreation):

  • wasm/js/WebAssemblyInstancePrototype.cpp:

(JSC::WebAssemblyInstancePrototype::finishCreation):

  • wasm/js/WebAssemblyLinkErrorPrototype.cpp:

(JSC::WebAssemblyLinkErrorPrototype::finishCreation):

  • wasm/js/WebAssemblyMemoryPrototype.cpp:

(JSC::WebAssemblyMemoryPrototype::finishCreation):

  • wasm/js/WebAssemblyModulePrototype.cpp:

(JSC::WebAssemblyModulePrototype::finishCreation):

  • wasm/js/WebAssemblyPrototype.cpp:

(JSC::WebAssemblyPrototype::finishCreation):

  • wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:

(JSC::WebAssemblyRuntimeErrorPrototype::finishCreation):

  • wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::WebAssemblyTablePrototype::finishCreation):

Source/WebCore:

It was found by existing tests, with the new assert in JSC::Structure

  • bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::setWindow):

  • bindings/scripts/CodeGeneratorJS.pm:

(GeneratePrototypeDeclaration):
(GenerateConstructorHelperMethods):

3:05 PM Changeset in webkit [244707] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[iOS] Our process assertion should not allow idle sleep
​https://bugs.webkit.org/show_bug.cgi?id=197317
<rdar://problem/50137740>

Reviewed by Geoffrey Garen.

Our process assertion should not allow idle sleep. This is bad for power because the device
may switch between sleep and awake state frequently, as it get woken up by network packages.

  • UIProcess/ios/ProcessAssertionIOS.mm:
2:14 PM Changeset in webkit [244706] by ap@apple.com
  • 2 edits in trunk/Tools

Update inactive reviewers' status to 'contributor'.

Accidentally skipped one at first.

  • Scripts/webkitpy/common/config/contributors.json:
1:47 PM Changeset in webkit [244705] by ap@apple.com
  • 10 edits in trunk/Tools

Update inactive reviewers' status to 'contributor'.

  • Scripts/webkitpy/common/config/contributors.json: The change.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout_mock.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:

Sadly, regression tests operate on a crazy mix of mock and live data for
contributors.json. It would be a substantial project to mock all code paths,
so changing the tests instead.

12:58 PM Changeset in webkit [244704] by eric.carlson@apple.com
  • 47 edits
    3 adds in trunk

Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::updateOptions):

  • platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:

(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):

  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::label const):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::devicePicker):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):

  • platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:

(WebCore::validateHEVCParameters):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):

  • platform/mac/SerializedPlatformRepresentationMac.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):

  • platform/mediastream/RealtimeVideoSource.h:
  • platform/mediastream/VideoPreset.h:
  • platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):

  • platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:

(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/cocoa/AVFoundationSoftLink.h: Added.
  • pal/cocoa/AVFoundationSoftLink.mm: Added.

Source/WebKit:

  • Shared/ios/WebIconUtilities.mm:

(WebKit::iconForVideoFile):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone const):

Source/WebKitLegacy/mac:

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.

(TestWebKitAPI::TEST):

11:32 AM Changeset in webkit [244703] by ddkilzer@apple.com
  • 4 edits in trunk/Tools

WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
<​https://webkit.org/b/197314>
<rdar://problem/50245252>

Reviewed by Simon Fraser.

  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):

  • Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator sendEventStream:completionBlock:]):

  • Call -autorelease to fix leak of NSDictionary.
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::accessibilitySpeakSelectionContent const):
(WTR::UIScriptController::selectFormPopoverTitle const):
(WTR::UIScriptController::textContentType const):
(WTR::UIScriptController::formInputLabel const):
(WTR::UIScriptController::scrollingTreeAsText const):

  • Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
11:32 AM Changeset in webkit [244702] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Unreviewed, rolling out r244683.
​https://bugs.webkit.org/show_bug.cgi?id=197320

Causing crash on iOS Simulator and EWS failures (Requested by
sroberts on #webkit).

Reverted changeset:

"[iOS] Add internal setting to force -webkit-text-size-adjust
to "auto""
​https://bugs.webkit.org/show_bug.cgi?id=197275
​https://trac.webkit.org/changeset/244683

11:25 AM Changeset in webkit [244701] by Jonathan Bedard
  • 4 edits in trunk/Tools

webkitpy: Running a single test will always use the default device
​https://bugs.webkit.org/show_bug.cgi?id=195472
<rdar://problem/48724825>

Reviewed by Lucas Forschler.

It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
requested will be run regardless of what shard they are in.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
on the default device type.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
(RunTest.test_run_part): Ditto.

11:10 AM Changeset in webkit [244700] by youenn@apple.com
  • 38 edits
    2 copies in trunk

Use normal loading path for ping loads
​https://bugs.webkit.org/show_bug.cgi?id=196807

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/beacon/headers/header-content-type-expected.txt:

Source/WebCore:

Make use of regular code path for ping loads and beacon.
This is done conditionally on KeepAlive flag.
The benefits are a single loading code path and service worker interception.

For that purpose, introduce a LoaderStrategy switch based on KeepAlive runtime flag.
This switch is used to use ping loads when keepAlive is set or regular loads.
In case of regular loads, the keepAlive flag should be used to extend the lifetime of the load.

Migrate ping loads to use CachedResourceLoader instead of PingLoad.
For that purpose, introduce a new Ping CachedResource type.

Covered by existing tests.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::inspectorResourceType):

  • loader/LinkLoader.cpp:

(WebCore::createLinkPreloadResourceClient):

  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

  • loader/SubresourceLoader.cpp:

(WebCore::logResourceLoaded):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):
(WebCore::CachedResource::load):
(WebCore::CachedResource::cancelLoad):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestPingResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::isResourceSuitableForDirectReuse):
(WebCore::destinationForType):

  • loader/cache/CachedResourceLoader.h:

Source/WebKit:

In case a NetworkResourceLoader has the keepAlive option we do the following:

  • Always use NetworkLoadChecker as we might need it to do checks after the Web context is gone.
  • In case of aborting a KeepAlive loader, remove it from NetworkConnectionToWebProcess map

and add it to a kept-alive NetworkSession load set. The loader is only kept alive if it
has not yet received a response. Mark the loader as kept-alive.

  • In case loader is kept-alive, cancel the load as soon as a response is gathered.
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::transferKeptAliveLoad):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::addKeptAliveLoad):
(WebKit::NetworkProcess::removeKeptAliveLoad):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoadMap.cpp:

(WebKit::NetworkResourceLoadMap::remove):
(WebKit::NetworkResourceLoadMap::take):

  • NetworkProcess/NetworkResourceLoadMap.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):

  • NetworkProcess/NetworkResourceLoader.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):
(WebKit::WebLoaderStrategy::usePingLoad const):

  • WebProcess/Network/WebLoaderStrategy.h:

LayoutTests:

  • TestExpectations:
  • http/tests/blink/sendbeacon/beacon-cross-origin.https-expected.txt:
  • http/tests/blink/sendbeacon/connect-src-beacon-allowed.html:
  • http/tests/security/contentSecurityPolicy/connect-src-beacon-allowed.html:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked.php:
  • http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt:
  • http/wpt/beacon/beacon-async-error-logging-expected.txt:
  • http/wpt/beacon/beacon-async-error-logging.html:
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt:
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked-expected.txt:
  • http/wpt/beacon/resources/beacon-preflight.py:

(respondToCORSPreflight):
(main):

  • platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only-expected.txt:
10:47 AM Changeset in webkit [244699] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Mark some cache-storage as slow on iOS-simulator
​https://bugs.webkit.org/show_bug.cgi?id=197316

Unreviewed.

  • platform/ios-simulator-wk2/TestExpectations:
10:38 AM Changeset in webkit [244698] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

Removing test expectation changes for tests no longer timing out
​https://bugs.webkit.org/show_bug.cgi?id=195719

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:33 AM Changeset in webkit [244697] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build after r244695

​​https://bugs.webkit.org/show_bug.cgi?id=197165

  • loader/PingLoader.cpp:
10:21 AM Changeset in webkit [244696] by achristensen@apple.com
  • 4 edits in trunk/Source

Fix internal High Sierra build after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • DerivedSources.make:

-std=gnu++17 didn't exist yet. -std=gnu++1z did.

10:03 AM Changeset in webkit [244695] by achristensen@apple.com
  • 21 edits in trunk

Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
​https://bugs.webkit.org/show_bug.cgi?id=197165

Reviewed by Youenn Fablet.

Source/WebCore:

No change in behavior. This will just make it harder for people working on the loader to mistake
these ContentExtension specific structures for other structures general to loading.
One such mistake was made in r244248.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

  • contentextensions/ContentExtensionsBackend.h:
  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::subresourcesAllowReuse const):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):

  • loader/PingLoader.cpp:

(WebCore::processContentRuleListsForLoad):
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):

  • loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType): Deleted.
(WebCore::readResourceType): Deleted.
(WebCore::readLoadType): Deleted.
(WebCore::ResourceLoadInfo::isThirdParty const): Deleted.
(WebCore::ResourceLoadInfo::getResourceFlags const): Deleted.

  • loader/ResourceLoadInfo.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

  • page/UserContentProvider.cpp:

(WebCore::UserContentProvider::processContentRuleListsForLoad):
(WebCore::UserContentProvider::actionsForResourceLoad):

  • page/UserContentProvider.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9:51 AM Changeset in webkit [244694] by don.olmstead@sony.com
  • 9 edits in trunk/Source

Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
​https://bugs.webkit.org/show_bug.cgi?id=197291

Reviewed by Konstantin Tokarev.

Source/JavaScriptCore:

Replace uses of strcasestr with WTF::findIgnoringASCIICaseWithoutLength.

  • API/tests/testapi.cpp:
  • assembler/testmasm.cpp:
  • b3/air/testair.cpp:
  • b3/testb3.cpp:
  • dfg/testdfg.cpp:
  • dynbench.cpp:

Source/WTF:

Adds an implementation of strcasestr within WTF.

  • wtf/text/StringCommon.h:

(WTF::findIgnoringASCIICaseWithoutLength):

9:48 AM Changeset in webkit [244693] by Ryan Haddad
  • 2 edits in trunk/Tools

Replace iOS build queue hardware
​https://bugs.webkit.org/show_bug.cgi?id=197312

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

Use newer hardware that supports macOS Mojave.

9:47 AM Changeset in webkit [244692] by achristensen@apple.com
  • 4 edits in trunk/Source

Fix an internal High Sierra build after r244653

​​https://bugs.webkit.org/show_bug.cgi?id=197131

  • DerivedSources.make:

Apparently we can't use gnu++17 when preprocessing Platform.h in the makefile.

9:36 AM Changeset in webkit [244691] by Chris Fleizach
  • 5 edits in trunk/Source/WebCore

AX: Provide iOS method for setting focus
​https://bugs.webkit.org/show_bug.cgi?id=197200
<rdar://problem/50131679>

Reviewed by Alex Christensen.

Put the focus setting code in a place that iOS and macOS can access.
Override a platform level method for setting focus on iOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilitySetFocus:]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase baseAccessibilitySetFocus:]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

9:32 AM Changeset in webkit [244690] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
​https://bugs.webkit.org/show_bug.cgi?id=197303

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-04-26
Reviewed by Alex Christensen.

Source/WebCore:

Therefore SVGElement::propertyRegistry() was called instead. This means
these two elements will not have access to the properties of the base
class SVGFilterPrimitiveStandardAttributes.

Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg

  • svg/SVGElement.cpp:

(WebCore::SVGElement::commitPropertyChange):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFEMergeElement.h:

LayoutTests:

  • svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
  • svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.
9:29 AM Changeset in webkit [244689] by youenn@apple.com
  • 6 edits in trunk

[Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196633
<rdar://problem/49627667>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Use formula defined in ​https://w3c.github.io/webrtc-stats/#dom-rtcrtpcontributingsourcestats-audiolevel
to compute the audio level from the RTP header information.
Covered by rebased test.

  • Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::fillRTCRtpContributingSource):

LayoutTests:

  • platform/mac-wk2/TestExpectations:
9:25 AM Changeset in webkit [244688] by yoshiaki.jitsukawa@sony.com
  • 3 edits in trunk/Tools

check-webkit-style complains the first block in while loop.
​https://bugs.webkit.org/show_bug.cgi?id=197307

The style checker shouldn't complain about an open brace on
its own line if the last non-whitespace character on the previous
non-blank line is another open brace, because it's likely to
indicate the begining of a nested code block.

Reviewed by Alex Christensen.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_braces):

9:08 AM Changeset in webkit [244687] by sihui_liu@apple.com
  • 19 edits
    2 adds in trunk

Stop IDB transactions to release locked database files when network process is ready to suspend
​https://bugs.webkit.org/show_bug.cgi?id=196372
<rdar://problem/48930116>

Reviewed by Brady Eidson.

Source/WebCore:

Suspend IDB database thread and finish ongoing IDB transactions on the main thread before suspending network
process.

API test: IndexedDB.IndexedDBSuspendImminently

  • Modules/indexeddb/server/IDBBackingStore.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::tryStop):
(WebCore::IDBServer::IDBServer::resume):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Remove some error log messages, because now we may try

performing database operations without an active transaction if the transaction is finished on the main thread.
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::hasTransaction const):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::prepareToFinishTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransactionAfterQuotaCheck):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransactionOnMainThread):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransactionOnMainThread):
(WebCore::IDBServer::UniqueIDBDatabase::finishActiveTransactions):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setState):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::state const):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setResult):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::result const):

  • platform/sql/SQLiteDatabaseTracker.cpp:

(WebCore::SQLiteDatabaseTracker::hasTransactionInProgress):

  • platform/sql/SQLiteDatabaseTracker.h:

Source/WebKit:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspendImminently):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):

Source/WTF:

Provide a method to suspend the thread and block main thread until the thread is suspended.

  • wtf/CrossThreadTaskHandler.cpp:

(WTF::CrossThreadTaskHandler::taskRunLoop):
(WTF::CrossThreadTaskHandler::suspendAndWait):
(WTF::CrossThreadTaskHandler::resume):

  • wtf/CrossThreadTaskHandler.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.

(-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
(runTestAndCheckResult):
(keepNetworkProcessActive):
(TEST):

9:00 AM Changeset in webkit [244686] by Kocsen Chung
  • 1 copy in tags/Safari-608.1.19

Tag Safari-608.1.19.

7:31 AM Changeset in webkit [244685] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/harness/render-tree-as-text-options.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=197310

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:52 AM Changeset in webkit [244684] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[Curl] Fix Curl Request Scheduler not to release wrong Curl handle when request is cancelled.
​https://bugs.webkit.org/show_bug.cgi?id=191650

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2019-04-26
Reviewed by Fujii Hironori.

Source/WebCore:

Test: http/tests/misc/repeat-open-cancel.html

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::isCancelled):
(WebCore::CurlRequest::isCompletedOrCancelled):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::pausedStatusChanged):

  • platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::isCompleted const): Deleted.
(WebCore::CurlRequest::isCancelled const): Deleted.
(WebCore::CurlRequest::isCompletedOrCancelled const): Deleted.

  • platform/network/curl/CurlRequestScheduler.cpp:

(WebCore::CurlRequestScheduler::cancel):
(WebCore::CurlRequestScheduler::callOnWorkerThread):
(WebCore::CurlRequestScheduler::startThreadIfNeeded):
(WebCore::CurlRequestScheduler::stopThreadIfNoMoreJobRunning):
(WebCore::CurlRequestScheduler::stopThread):
(WebCore::CurlRequestScheduler::executeTasks):
(WebCore::CurlRequestScheduler::workerThread):
(WebCore::CurlRequestScheduler::startTransfer):
(WebCore::CurlRequestScheduler::completeTransfer):
(WebCore::CurlRequestScheduler::cancelTransfer):
(WebCore::CurlRequestScheduler::finalizeTransfer):

  • platform/network/curl/CurlRequestScheduler.h:

LayoutTests:

  • http/tests/misc/repeat-open-cancel-expected.txt: Added.
  • http/tests/misc/repeat-open-cancel.html: Added.
Note: See TracTimeline for information about the timeline view.